]>
Commit | Line | Data |
---|---|---|
3e67e5c9 | 1 | #!/usr/bin/env python3 |
35df7443 ZJS |
2 | # SPDX-License-Identifier: LGPL-2.1+ |
3 | # | |
b2ad12eb MP |
4 | # Simple udev rules syntax checker |
5 | # | |
810adae9 | 6 | # © 2010 Canonical Ltd. |
b2ad12eb | 7 | # Author: Martin Pitt <martin.pitt@ubuntu.com> |
b2ad12eb MP |
8 | |
9 | import re | |
10 | import sys | |
e8015e6e MP |
11 | import os |
12 | from glob import glob | |
b2ad12eb | 13 | |
6b97bf22 ZJS |
14 | rules_files = sys.argv[1:] |
15 | if not rules_files: | |
16 | sys.exit('Specify files to test as arguments') | |
b2ad12eb | 17 | |
d498347a FB |
18 | quoted_string_re = r'"(?:[^\\"]|\\.)*"' |
19 | no_args_tests = re.compile(r'(ACTION|DEVPATH|KERNELS?|NAME|SYMLINK|SUBSYSTEMS?|DRIVERS?|TAG|PROGRAM|RESULT|TEST)\s*(?:=|!)=\s*' + quoted_string_re + '$') | |
ed2dc503 JS |
20 | # PROGRAM can also be specified as an assignment. |
21 | program_assign = re.compile(r'PROGRAM\s*=\s*' + quoted_string_re + '$') | |
d498347a FB |
22 | args_tests = re.compile(r'(ATTRS?|ENV|TEST){([a-zA-Z0-9/_.*%-]+)}\s*(?:=|!)=\s*' + quoted_string_re + '$') |
23 | no_args_assign = re.compile(r'(NAME|SYMLINK|OWNER|GROUP|MODE|TAG|RUN|LABEL|GOTO|OPTIONS|IMPORT)\s*(?:\+=|:=|=)\s*' + quoted_string_re + '$') | |
24 | args_assign = re.compile(r'(ATTR|ENV|IMPORT|RUN){([a-zA-Z0-9/_.*%-]+)}\s*(=|\+=)\s*' + quoted_string_re + '$') | |
c9715ffc | 25 | # Find comma-separated groups, but allow commas that are inside quoted strings. |
27e2779b FB |
26 | # Using quoted_string_re + '?' so that strings missing the last double quote |
27 | # will still match for this part that splits on commas. | |
28 | comma_separated_group_re = re.compile(r'(?:[^,"]|' + quoted_string_re + '?)+') | |
b2ad12eb MP |
29 | |
30 | result = 0 | |
31 | buffer = '' | |
e8015e6e | 32 | for path in rules_files: |
2956395c | 33 | print('# looking at {}'.format(path)) |
b2ad12eb MP |
34 | lineno = 0 |
35 | for line in open(path): | |
36 | lineno += 1 | |
37 | ||
38 | # handle line continuation | |
39 | if line.endswith('\\\n'): | |
40 | buffer += line[:-2] | |
41 | continue | |
42 | else: | |
43 | line = buffer + line | |
44 | buffer = '' | |
45 | ||
46 | # filter out comments and empty lines | |
47 | line = line.strip() | |
48 | if not line or line.startswith('#'): | |
49 | continue | |
50 | ||
75a56cb6 FB |
51 | # Separator ',' is normally optional but we make it mandatory here as |
52 | # it generally improves the readability of the rules. | |
c9715ffc FB |
53 | for clause_match in comma_separated_group_re.finditer(line): |
54 | clause = clause_match.group().strip() | |
b2ad12eb | 55 | if not (no_args_tests.match(clause) or args_tests.match(clause) or |
ed2dc503 JS |
56 | no_args_assign.match(clause) or args_assign.match(clause) or |
57 | program_assign.match(clause)): | |
b2ad12eb | 58 | |
2956395c ZJS |
59 | print('Invalid line {}:{}: {}'.format(path, lineno, line)) |
60 | print(' clause:', clause) | |
61 | print() | |
b2ad12eb MP |
62 | result = 1 |
63 | break | |
64 | ||
65 | sys.exit(result) |