]> git.ipfire.org Git - thirdparty/git.git/blob - fsck.c
fsck: detect gitmodules URLs with embedded newlines
[thirdparty/git.git] / fsck.c
1 #include "cache.h"
2 #include "object.h"
3 #include "blob.h"
4 #include "tree.h"
5 #include "tree-walk.h"
6 #include "commit.h"
7 #include "tag.h"
8 #include "fsck.h"
9 #include "refs.h"
10 #include "utf8.h"
11 #include "sha1-array.h"
12 #include "decorate.h"
13 #include "oidset.h"
14 #include "packfile.h"
15 #include "submodule-config.h"
16 #include "config.h"
17 #include "credential.h"
18
19 static struct oidset gitmodules_found = OIDSET_INIT;
20 static struct oidset gitmodules_done = OIDSET_INIT;
21
22 #define FSCK_FATAL -1
23 #define FSCK_INFO -2
24
25 #define FOREACH_MSG_ID(FUNC) \
26 /* fatal errors */ \
27 FUNC(NUL_IN_HEADER, FATAL) \
28 FUNC(UNTERMINATED_HEADER, FATAL) \
29 /* errors */ \
30 FUNC(BAD_DATE, ERROR) \
31 FUNC(BAD_DATE_OVERFLOW, ERROR) \
32 FUNC(BAD_EMAIL, ERROR) \
33 FUNC(BAD_NAME, ERROR) \
34 FUNC(BAD_OBJECT_SHA1, ERROR) \
35 FUNC(BAD_PARENT_SHA1, ERROR) \
36 FUNC(BAD_TAG_OBJECT, ERROR) \
37 FUNC(BAD_TIMEZONE, ERROR) \
38 FUNC(BAD_TREE, ERROR) \
39 FUNC(BAD_TREE_SHA1, ERROR) \
40 FUNC(BAD_TYPE, ERROR) \
41 FUNC(DUPLICATE_ENTRIES, ERROR) \
42 FUNC(MISSING_AUTHOR, ERROR) \
43 FUNC(MISSING_COMMITTER, ERROR) \
44 FUNC(MISSING_EMAIL, ERROR) \
45 FUNC(MISSING_GRAFT, ERROR) \
46 FUNC(MISSING_NAME_BEFORE_EMAIL, ERROR) \
47 FUNC(MISSING_OBJECT, ERROR) \
48 FUNC(MISSING_PARENT, ERROR) \
49 FUNC(MISSING_SPACE_BEFORE_DATE, ERROR) \
50 FUNC(MISSING_SPACE_BEFORE_EMAIL, ERROR) \
51 FUNC(MISSING_TAG, ERROR) \
52 FUNC(MISSING_TAG_ENTRY, ERROR) \
53 FUNC(MISSING_TAG_OBJECT, ERROR) \
54 FUNC(MISSING_TREE, ERROR) \
55 FUNC(MISSING_TREE_OBJECT, ERROR) \
56 FUNC(MISSING_TYPE, ERROR) \
57 FUNC(MISSING_TYPE_ENTRY, ERROR) \
58 FUNC(MULTIPLE_AUTHORS, ERROR) \
59 FUNC(TAG_OBJECT_NOT_TAG, ERROR) \
60 FUNC(TREE_NOT_SORTED, ERROR) \
61 FUNC(UNKNOWN_TYPE, ERROR) \
62 FUNC(ZERO_PADDED_DATE, ERROR) \
63 FUNC(GITMODULES_MISSING, ERROR) \
64 FUNC(GITMODULES_BLOB, ERROR) \
65 FUNC(GITMODULES_PARSE, ERROR) \
66 FUNC(GITMODULES_NAME, ERROR) \
67 FUNC(GITMODULES_SYMLINK, ERROR) \
68 FUNC(GITMODULES_URL, ERROR) \
69 FUNC(GITMODULES_PATH, ERROR) \
70 FUNC(GITMODULES_UPDATE, ERROR) \
71 /* warnings */ \
72 FUNC(BAD_FILEMODE, WARN) \
73 FUNC(EMPTY_NAME, WARN) \
74 FUNC(FULL_PATHNAME, WARN) \
75 FUNC(HAS_DOT, WARN) \
76 FUNC(HAS_DOTDOT, WARN) \
77 FUNC(HAS_DOTGIT, WARN) \
78 FUNC(NULL_SHA1, WARN) \
79 FUNC(ZERO_PADDED_FILEMODE, WARN) \
80 FUNC(NUL_IN_COMMIT, WARN) \
81 /* infos (reported as warnings, but ignored by default) */ \
82 FUNC(BAD_TAG_NAME, INFO) \
83 FUNC(MISSING_TAGGER_ENTRY, INFO)
84
85 #define MSG_ID(id, msg_type) FSCK_MSG_##id,
86 enum fsck_msg_id {
87 FOREACH_MSG_ID(MSG_ID)
88 FSCK_MSG_MAX
89 };
90 #undef MSG_ID
91
92 #define STR(x) #x
93 #define MSG_ID(id, msg_type) { STR(id), NULL, FSCK_##msg_type },
94 static struct {
95 const char *id_string;
96 const char *downcased;
97 int msg_type;
98 } msg_id_info[FSCK_MSG_MAX + 1] = {
99 FOREACH_MSG_ID(MSG_ID)
100 { NULL, NULL, -1 }
101 };
102 #undef MSG_ID
103
104 static int parse_msg_id(const char *text)
105 {
106 int i;
107
108 if (!msg_id_info[0].downcased) {
109 /* convert id_string to lower case, without underscores. */
110 for (i = 0; i < FSCK_MSG_MAX; i++) {
111 const char *p = msg_id_info[i].id_string;
112 int len = strlen(p);
113 char *q = xmalloc(len);
114
115 msg_id_info[i].downcased = q;
116 while (*p)
117 if (*p == '_')
118 p++;
119 else
120 *(q)++ = tolower(*(p)++);
121 *q = '\0';
122 }
123 }
124
125 for (i = 0; i < FSCK_MSG_MAX; i++)
126 if (!strcmp(text, msg_id_info[i].downcased))
127 return i;
128
129 return -1;
130 }
131
132 static int fsck_msg_type(enum fsck_msg_id msg_id,
133 struct fsck_options *options)
134 {
135 int msg_type;
136
137 assert(msg_id >= 0 && msg_id < FSCK_MSG_MAX);
138
139 if (options->msg_type)
140 msg_type = options->msg_type[msg_id];
141 else {
142 msg_type = msg_id_info[msg_id].msg_type;
143 if (options->strict && msg_type == FSCK_WARN)
144 msg_type = FSCK_ERROR;
145 }
146
147 return msg_type;
148 }
149
150 static void init_skiplist(struct fsck_options *options, const char *path)
151 {
152 static struct oid_array skiplist = OID_ARRAY_INIT;
153 int sorted, fd;
154 char buffer[GIT_MAX_HEXSZ + 1];
155 struct object_id oid;
156
157 if (options->skiplist)
158 sorted = options->skiplist->sorted;
159 else {
160 sorted = 1;
161 options->skiplist = &skiplist;
162 }
163
164 fd = open(path, O_RDONLY);
165 if (fd < 0)
166 die("Could not open skip list: %s", path);
167 for (;;) {
168 const char *p;
169 int result = read_in_full(fd, buffer, sizeof(buffer));
170 if (result < 0)
171 die_errno("Could not read '%s'", path);
172 if (!result)
173 break;
174 if (parse_oid_hex(buffer, &oid, &p) || *p != '\n')
175 die("Invalid SHA-1: %s", buffer);
176 oid_array_append(&skiplist, &oid);
177 if (sorted && skiplist.nr > 1 &&
178 oidcmp(&skiplist.oid[skiplist.nr - 2],
179 &oid) > 0)
180 sorted = 0;
181 }
182 close(fd);
183
184 if (sorted)
185 skiplist.sorted = 1;
186 }
187
188 static int parse_msg_type(const char *str)
189 {
190 if (!strcmp(str, "error"))
191 return FSCK_ERROR;
192 else if (!strcmp(str, "warn"))
193 return FSCK_WARN;
194 else if (!strcmp(str, "ignore"))
195 return FSCK_IGNORE;
196 else
197 die("Unknown fsck message type: '%s'", str);
198 }
199
200 int is_valid_msg_type(const char *msg_id, const char *msg_type)
201 {
202 if (parse_msg_id(msg_id) < 0)
203 return 0;
204 parse_msg_type(msg_type);
205 return 1;
206 }
207
208 void fsck_set_msg_type(struct fsck_options *options,
209 const char *msg_id, const char *msg_type)
210 {
211 int id = parse_msg_id(msg_id), type;
212
213 if (id < 0)
214 die("Unhandled message id: %s", msg_id);
215 type = parse_msg_type(msg_type);
216
217 if (type != FSCK_ERROR && msg_id_info[id].msg_type == FSCK_FATAL)
218 die("Cannot demote %s to %s", msg_id, msg_type);
219
220 if (!options->msg_type) {
221 int i;
222 int *msg_type;
223 ALLOC_ARRAY(msg_type, FSCK_MSG_MAX);
224 for (i = 0; i < FSCK_MSG_MAX; i++)
225 msg_type[i] = fsck_msg_type(i, options);
226 options->msg_type = msg_type;
227 }
228
229 options->msg_type[id] = type;
230 }
231
232 void fsck_set_msg_types(struct fsck_options *options, const char *values)
233 {
234 char *buf = xstrdup(values), *to_free = buf;
235 int done = 0;
236
237 while (!done) {
238 int len = strcspn(buf, " ,|"), equal;
239
240 done = !buf[len];
241 if (!len) {
242 buf++;
243 continue;
244 }
245 buf[len] = '\0';
246
247 for (equal = 0;
248 equal < len && buf[equal] != '=' && buf[equal] != ':';
249 equal++)
250 buf[equal] = tolower(buf[equal]);
251 buf[equal] = '\0';
252
253 if (!strcmp(buf, "skiplist")) {
254 if (equal == len)
255 die("skiplist requires a path");
256 init_skiplist(options, buf + equal + 1);
257 buf += len + 1;
258 continue;
259 }
260
261 if (equal == len)
262 die("Missing '=': '%s'", buf);
263
264 fsck_set_msg_type(options, buf, buf + equal + 1);
265 buf += len + 1;
266 }
267 free(to_free);
268 }
269
270 static void append_msg_id(struct strbuf *sb, const char *msg_id)
271 {
272 for (;;) {
273 char c = *(msg_id)++;
274
275 if (!c)
276 break;
277 if (c != '_')
278 strbuf_addch(sb, tolower(c));
279 else {
280 assert(*msg_id);
281 strbuf_addch(sb, *(msg_id)++);
282 }
283 }
284
285 strbuf_addstr(sb, ": ");
286 }
287
288 __attribute__((format (printf, 4, 5)))
289 static int report(struct fsck_options *options, struct object *object,
290 enum fsck_msg_id id, const char *fmt, ...)
291 {
292 va_list ap;
293 struct strbuf sb = STRBUF_INIT;
294 int msg_type = fsck_msg_type(id, options), result;
295
296 if (msg_type == FSCK_IGNORE)
297 return 0;
298
299 if (options->skiplist && object &&
300 oid_array_lookup(options->skiplist, &object->oid) >= 0)
301 return 0;
302
303 if (msg_type == FSCK_FATAL)
304 msg_type = FSCK_ERROR;
305 else if (msg_type == FSCK_INFO)
306 msg_type = FSCK_WARN;
307
308 append_msg_id(&sb, msg_id_info[id].id_string);
309
310 va_start(ap, fmt);
311 strbuf_vaddf(&sb, fmt, ap);
312 result = options->error_func(options, object, msg_type, sb.buf);
313 strbuf_release(&sb);
314 va_end(ap);
315
316 return result;
317 }
318
319 static char *get_object_name(struct fsck_options *options, struct object *obj)
320 {
321 if (!options->object_names)
322 return NULL;
323 return lookup_decoration(options->object_names, obj);
324 }
325
326 static void put_object_name(struct fsck_options *options, struct object *obj,
327 const char *fmt, ...)
328 {
329 va_list ap;
330 struct strbuf buf = STRBUF_INIT;
331 char *existing;
332
333 if (!options->object_names)
334 return;
335 existing = lookup_decoration(options->object_names, obj);
336 if (existing)
337 return;
338 va_start(ap, fmt);
339 strbuf_vaddf(&buf, fmt, ap);
340 add_decoration(options->object_names, obj, strbuf_detach(&buf, NULL));
341 va_end(ap);
342 }
343
344 static const char *describe_object(struct fsck_options *o, struct object *obj)
345 {
346 static struct strbuf buf = STRBUF_INIT;
347 char *name;
348
349 strbuf_reset(&buf);
350 strbuf_addstr(&buf, oid_to_hex(&obj->oid));
351 if (o->object_names && (name = lookup_decoration(o->object_names, obj)))
352 strbuf_addf(&buf, " (%s)", name);
353
354 return buf.buf;
355 }
356
357 static int fsck_walk_tree(struct tree *tree, void *data, struct fsck_options *options)
358 {
359 struct tree_desc desc;
360 struct name_entry entry;
361 int res = 0;
362 const char *name;
363
364 if (parse_tree(tree))
365 return -1;
366
367 name = get_object_name(options, &tree->object);
368 if (init_tree_desc_gently(&desc, tree->buffer, tree->size))
369 return -1;
370 while (tree_entry_gently(&desc, &entry)) {
371 struct object *obj;
372 int result;
373
374 if (S_ISGITLINK(entry.mode))
375 continue;
376
377 if (S_ISDIR(entry.mode)) {
378 obj = (struct object *)lookup_tree(entry.oid);
379 if (name && obj)
380 put_object_name(options, obj, "%s%s/", name,
381 entry.path);
382 result = options->walk(obj, OBJ_TREE, data, options);
383 }
384 else if (S_ISREG(entry.mode) || S_ISLNK(entry.mode)) {
385 obj = (struct object *)lookup_blob(entry.oid);
386 if (name && obj)
387 put_object_name(options, obj, "%s%s", name,
388 entry.path);
389 result = options->walk(obj, OBJ_BLOB, data, options);
390 }
391 else {
392 result = error("in tree %s: entry %s has bad mode %.6o",
393 describe_object(options, &tree->object), entry.path, entry.mode);
394 }
395 if (result < 0)
396 return result;
397 if (!res)
398 res = result;
399 }
400 return res;
401 }
402
403 static int fsck_walk_commit(struct commit *commit, void *data, struct fsck_options *options)
404 {
405 int counter = 0, generation = 0, name_prefix_len = 0;
406 struct commit_list *parents;
407 int res;
408 int result;
409 const char *name;
410
411 if (parse_commit(commit))
412 return -1;
413
414 name = get_object_name(options, &commit->object);
415 if (name)
416 put_object_name(options, &commit->tree->object, "%s:", name);
417
418 result = options->walk((struct object *)commit->tree, OBJ_TREE, data, options);
419 if (result < 0)
420 return result;
421 res = result;
422
423 parents = commit->parents;
424 if (name && parents) {
425 int len = strlen(name), power;
426
427 if (len && name[len - 1] == '^') {
428 generation = 1;
429 name_prefix_len = len - 1;
430 }
431 else { /* parse ~<generation> suffix */
432 for (generation = 0, power = 1;
433 len && isdigit(name[len - 1]);
434 power *= 10)
435 generation += power * (name[--len] - '0');
436 if (power > 1 && len && name[len - 1] == '~')
437 name_prefix_len = len - 1;
438 }
439 }
440
441 while (parents) {
442 if (name) {
443 struct object *obj = &parents->item->object;
444
445 if (++counter > 1)
446 put_object_name(options, obj, "%s^%d",
447 name, counter);
448 else if (generation > 0)
449 put_object_name(options, obj, "%.*s~%d",
450 name_prefix_len, name, generation + 1);
451 else
452 put_object_name(options, obj, "%s^", name);
453 }
454 result = options->walk((struct object *)parents->item, OBJ_COMMIT, data, options);
455 if (result < 0)
456 return result;
457 if (!res)
458 res = result;
459 parents = parents->next;
460 }
461 return res;
462 }
463
464 static int fsck_walk_tag(struct tag *tag, void *data, struct fsck_options *options)
465 {
466 char *name = get_object_name(options, &tag->object);
467
468 if (parse_tag(tag))
469 return -1;
470 if (name)
471 put_object_name(options, tag->tagged, "%s", name);
472 return options->walk(tag->tagged, OBJ_ANY, data, options);
473 }
474
475 int fsck_walk(struct object *obj, void *data, struct fsck_options *options)
476 {
477 if (!obj)
478 return -1;
479
480 if (obj->type == OBJ_NONE)
481 parse_object(&obj->oid);
482
483 switch (obj->type) {
484 case OBJ_BLOB:
485 return 0;
486 case OBJ_TREE:
487 return fsck_walk_tree((struct tree *)obj, data, options);
488 case OBJ_COMMIT:
489 return fsck_walk_commit((struct commit *)obj, data, options);
490 case OBJ_TAG:
491 return fsck_walk_tag((struct tag *)obj, data, options);
492 default:
493 error("Unknown object type for %s", describe_object(options, obj));
494 return -1;
495 }
496 }
497
498 /*
499 * The entries in a tree are ordered in the _path_ order,
500 * which means that a directory entry is ordered by adding
501 * a slash to the end of it.
502 *
503 * So a directory called "a" is ordered _after_ a file
504 * called "a.c", because "a/" sorts after "a.c".
505 */
506 #define TREE_UNORDERED (-1)
507 #define TREE_HAS_DUPS (-2)
508
509 static int verify_ordered(unsigned mode1, const char *name1, unsigned mode2, const char *name2)
510 {
511 int len1 = strlen(name1);
512 int len2 = strlen(name2);
513 int len = len1 < len2 ? len1 : len2;
514 unsigned char c1, c2;
515 int cmp;
516
517 cmp = memcmp(name1, name2, len);
518 if (cmp < 0)
519 return 0;
520 if (cmp > 0)
521 return TREE_UNORDERED;
522
523 /*
524 * Ok, the first <len> characters are the same.
525 * Now we need to order the next one, but turn
526 * a '\0' into a '/' for a directory entry.
527 */
528 c1 = name1[len];
529 c2 = name2[len];
530 if (!c1 && !c2)
531 /*
532 * git-write-tree used to write out a nonsense tree that has
533 * entries with the same name, one blob and one tree. Make
534 * sure we do not have duplicate entries.
535 */
536 return TREE_HAS_DUPS;
537 if (!c1 && S_ISDIR(mode1))
538 c1 = '/';
539 if (!c2 && S_ISDIR(mode2))
540 c2 = '/';
541 return c1 < c2 ? 0 : TREE_UNORDERED;
542 }
543
544 static int fsck_tree(struct tree *item, struct fsck_options *options)
545 {
546 int retval = 0;
547 int has_null_sha1 = 0;
548 int has_full_path = 0;
549 int has_empty_name = 0;
550 int has_dot = 0;
551 int has_dotdot = 0;
552 int has_dotgit = 0;
553 int has_zero_pad = 0;
554 int has_bad_modes = 0;
555 int has_dup_entries = 0;
556 int not_properly_sorted = 0;
557 struct tree_desc desc;
558 unsigned o_mode;
559 const char *o_name;
560
561 if (init_tree_desc_gently(&desc, item->buffer, item->size)) {
562 retval += report(options, &item->object, FSCK_MSG_BAD_TREE, "cannot be parsed as a tree");
563 return retval;
564 }
565
566 o_mode = 0;
567 o_name = NULL;
568
569 while (desc.size) {
570 unsigned mode;
571 const char *name, *backslash;
572 const struct object_id *oid;
573
574 oid = tree_entry_extract(&desc, &name, &mode);
575
576 has_null_sha1 |= is_null_oid(oid);
577 has_full_path |= !!strchr(name, '/');
578 has_empty_name |= !*name;
579 has_dot |= !strcmp(name, ".");
580 has_dotdot |= !strcmp(name, "..");
581 has_dotgit |= is_hfs_dotgit(name) || is_ntfs_dotgit(name);
582 has_zero_pad |= *(char *)desc.buffer == '0';
583
584 if (is_hfs_dotgitmodules(name) || is_ntfs_dotgitmodules(name)) {
585 if (!S_ISLNK(mode))
586 oidset_insert(&gitmodules_found, oid);
587 else
588 retval += report(options, &item->object,
589 FSCK_MSG_GITMODULES_SYMLINK,
590 ".gitmodules is a symbolic link");
591 }
592
593 if ((backslash = strchr(name, '\\'))) {
594 while (backslash) {
595 backslash++;
596 has_dotgit |= is_ntfs_dotgit(backslash);
597 if (is_ntfs_dotgitmodules(backslash)) {
598 if (!S_ISLNK(mode))
599 oidset_insert(&gitmodules_found, oid);
600 else
601 retval += report(options, &item->object,
602 FSCK_MSG_GITMODULES_SYMLINK,
603 ".gitmodules is a symbolic link");
604 }
605 backslash = strchr(backslash, '\\');
606 }
607 }
608
609 if (update_tree_entry_gently(&desc)) {
610 retval += report(options, &item->object, FSCK_MSG_BAD_TREE, "cannot be parsed as a tree");
611 break;
612 }
613
614 switch (mode) {
615 /*
616 * Standard modes..
617 */
618 case S_IFREG | 0755:
619 case S_IFREG | 0644:
620 case S_IFLNK:
621 case S_IFDIR:
622 case S_IFGITLINK:
623 break;
624 /*
625 * This is nonstandard, but we had a few of these
626 * early on when we honored the full set of mode
627 * bits..
628 */
629 case S_IFREG | 0664:
630 if (!options->strict)
631 break;
632 /* fallthrough */
633 default:
634 has_bad_modes = 1;
635 }
636
637 if (o_name) {
638 switch (verify_ordered(o_mode, o_name, mode, name)) {
639 case TREE_UNORDERED:
640 not_properly_sorted = 1;
641 break;
642 case TREE_HAS_DUPS:
643 has_dup_entries = 1;
644 break;
645 default:
646 break;
647 }
648 }
649
650 o_mode = mode;
651 o_name = name;
652 }
653
654 if (has_null_sha1)
655 retval += report(options, &item->object, FSCK_MSG_NULL_SHA1, "contains entries pointing to null sha1");
656 if (has_full_path)
657 retval += report(options, &item->object, FSCK_MSG_FULL_PATHNAME, "contains full pathnames");
658 if (has_empty_name)
659 retval += report(options, &item->object, FSCK_MSG_EMPTY_NAME, "contains empty pathname");
660 if (has_dot)
661 retval += report(options, &item->object, FSCK_MSG_HAS_DOT, "contains '.'");
662 if (has_dotdot)
663 retval += report(options, &item->object, FSCK_MSG_HAS_DOTDOT, "contains '..'");
664 if (has_dotgit)
665 retval += report(options, &item->object, FSCK_MSG_HAS_DOTGIT, "contains '.git'");
666 if (has_zero_pad)
667 retval += report(options, &item->object, FSCK_MSG_ZERO_PADDED_FILEMODE, "contains zero-padded file modes");
668 if (has_bad_modes)
669 retval += report(options, &item->object, FSCK_MSG_BAD_FILEMODE, "contains bad file modes");
670 if (has_dup_entries)
671 retval += report(options, &item->object, FSCK_MSG_DUPLICATE_ENTRIES, "contains duplicate file entries");
672 if (not_properly_sorted)
673 retval += report(options, &item->object, FSCK_MSG_TREE_NOT_SORTED, "not properly sorted");
674 return retval;
675 }
676
677 static int verify_headers(const void *data, unsigned long size,
678 struct object *obj, struct fsck_options *options)
679 {
680 const char *buffer = (const char *)data;
681 unsigned long i;
682
683 for (i = 0; i < size; i++) {
684 switch (buffer[i]) {
685 case '\0':
686 return report(options, obj,
687 FSCK_MSG_NUL_IN_HEADER,
688 "unterminated header: NUL at offset %ld", i);
689 case '\n':
690 if (i + 1 < size && buffer[i + 1] == '\n')
691 return 0;
692 }
693 }
694
695 /*
696 * We did not find double-LF that separates the header
697 * and the body. Not having a body is not a crime but
698 * we do want to see the terminating LF for the last header
699 * line.
700 */
701 if (size && buffer[size - 1] == '\n')
702 return 0;
703
704 return report(options, obj,
705 FSCK_MSG_UNTERMINATED_HEADER, "unterminated header");
706 }
707
708 static int fsck_ident(const char **ident, struct object *obj, struct fsck_options *options)
709 {
710 const char *p = *ident;
711 char *end;
712
713 *ident = strchrnul(*ident, '\n');
714 if (**ident == '\n')
715 (*ident)++;
716
717 if (*p == '<')
718 return report(options, obj, FSCK_MSG_MISSING_NAME_BEFORE_EMAIL, "invalid author/committer line - missing space before email");
719 p += strcspn(p, "<>\n");
720 if (*p == '>')
721 return report(options, obj, FSCK_MSG_BAD_NAME, "invalid author/committer line - bad name");
722 if (*p != '<')
723 return report(options, obj, FSCK_MSG_MISSING_EMAIL, "invalid author/committer line - missing email");
724 if (p[-1] != ' ')
725 return report(options, obj, FSCK_MSG_MISSING_SPACE_BEFORE_EMAIL, "invalid author/committer line - missing space before email");
726 p++;
727 p += strcspn(p, "<>\n");
728 if (*p != '>')
729 return report(options, obj, FSCK_MSG_BAD_EMAIL, "invalid author/committer line - bad email");
730 p++;
731 if (*p != ' ')
732 return report(options, obj, FSCK_MSG_MISSING_SPACE_BEFORE_DATE, "invalid author/committer line - missing space before date");
733 p++;
734 if (*p == '0' && p[1] != ' ')
735 return report(options, obj, FSCK_MSG_ZERO_PADDED_DATE, "invalid author/committer line - zero-padded date");
736 if (date_overflows(parse_timestamp(p, &end, 10)))
737 return report(options, obj, FSCK_MSG_BAD_DATE_OVERFLOW, "invalid author/committer line - date causes integer overflow");
738 if ((end == p || *end != ' '))
739 return report(options, obj, FSCK_MSG_BAD_DATE, "invalid author/committer line - bad date");
740 p = end + 1;
741 if ((*p != '+' && *p != '-') ||
742 !isdigit(p[1]) ||
743 !isdigit(p[2]) ||
744 !isdigit(p[3]) ||
745 !isdigit(p[4]) ||
746 (p[5] != '\n'))
747 return report(options, obj, FSCK_MSG_BAD_TIMEZONE, "invalid author/committer line - bad time zone");
748 p += 6;
749 return 0;
750 }
751
752 static int fsck_commit_buffer(struct commit *commit, const char *buffer,
753 unsigned long size, struct fsck_options *options)
754 {
755 unsigned char tree_sha1[20], sha1[20];
756 struct commit_graft *graft;
757 unsigned parent_count, parent_line_count = 0, author_count;
758 int err;
759 const char *buffer_begin = buffer;
760
761 if (verify_headers(buffer, size, &commit->object, options))
762 return -1;
763
764 if (!skip_prefix(buffer, "tree ", &buffer))
765 return report(options, &commit->object, FSCK_MSG_MISSING_TREE, "invalid format - expected 'tree' line");
766 if (get_sha1_hex(buffer, tree_sha1) || buffer[40] != '\n') {
767 err = report(options, &commit->object, FSCK_MSG_BAD_TREE_SHA1, "invalid 'tree' line format - bad sha1");
768 if (err)
769 return err;
770 }
771 buffer += 41;
772 while (skip_prefix(buffer, "parent ", &buffer)) {
773 if (get_sha1_hex(buffer, sha1) || buffer[40] != '\n') {
774 err = report(options, &commit->object, FSCK_MSG_BAD_PARENT_SHA1, "invalid 'parent' line format - bad sha1");
775 if (err)
776 return err;
777 }
778 buffer += 41;
779 parent_line_count++;
780 }
781 graft = lookup_commit_graft(&commit->object.oid);
782 parent_count = commit_list_count(commit->parents);
783 if (graft) {
784 if (graft->nr_parent == -1 && !parent_count)
785 ; /* shallow commit */
786 else if (graft->nr_parent != parent_count) {
787 err = report(options, &commit->object, FSCK_MSG_MISSING_GRAFT, "graft objects missing");
788 if (err)
789 return err;
790 }
791 } else {
792 if (parent_count != parent_line_count) {
793 err = report(options, &commit->object, FSCK_MSG_MISSING_PARENT, "parent objects missing");
794 if (err)
795 return err;
796 }
797 }
798 author_count = 0;
799 while (skip_prefix(buffer, "author ", &buffer)) {
800 author_count++;
801 err = fsck_ident(&buffer, &commit->object, options);
802 if (err)
803 return err;
804 }
805 if (author_count < 1)
806 err = report(options, &commit->object, FSCK_MSG_MISSING_AUTHOR, "invalid format - expected 'author' line");
807 else if (author_count > 1)
808 err = report(options, &commit->object, FSCK_MSG_MULTIPLE_AUTHORS, "invalid format - multiple 'author' lines");
809 if (err)
810 return err;
811 if (!skip_prefix(buffer, "committer ", &buffer))
812 return report(options, &commit->object, FSCK_MSG_MISSING_COMMITTER, "invalid format - expected 'committer' line");
813 err = fsck_ident(&buffer, &commit->object, options);
814 if (err)
815 return err;
816 if (!commit->tree) {
817 err = report(options, &commit->object, FSCK_MSG_BAD_TREE, "could not load commit's tree %s", sha1_to_hex(tree_sha1));
818 if (err)
819 return err;
820 }
821 if (memchr(buffer_begin, '\0', size)) {
822 err = report(options, &commit->object, FSCK_MSG_NUL_IN_COMMIT,
823 "NUL byte in the commit object body");
824 if (err)
825 return err;
826 }
827 return 0;
828 }
829
830 static int fsck_commit(struct commit *commit, const char *data,
831 unsigned long size, struct fsck_options *options)
832 {
833 const char *buffer = data ? data : get_commit_buffer(commit, &size);
834 int ret = fsck_commit_buffer(commit, buffer, size, options);
835 if (!data)
836 unuse_commit_buffer(commit, buffer);
837 return ret;
838 }
839
840 static int fsck_tag_buffer(struct tag *tag, const char *data,
841 unsigned long size, struct fsck_options *options)
842 {
843 unsigned char sha1[20];
844 int ret = 0;
845 const char *buffer;
846 char *to_free = NULL, *eol;
847 struct strbuf sb = STRBUF_INIT;
848
849 if (data)
850 buffer = data;
851 else {
852 enum object_type type;
853
854 buffer = to_free =
855 read_sha1_file(tag->object.oid.hash, &type, &size);
856 if (!buffer)
857 return report(options, &tag->object,
858 FSCK_MSG_MISSING_TAG_OBJECT,
859 "cannot read tag object");
860
861 if (type != OBJ_TAG) {
862 ret = report(options, &tag->object,
863 FSCK_MSG_TAG_OBJECT_NOT_TAG,
864 "expected tag got %s",
865 type_name(type));
866 goto done;
867 }
868 }
869
870 ret = verify_headers(buffer, size, &tag->object, options);
871 if (ret)
872 goto done;
873
874 if (!skip_prefix(buffer, "object ", &buffer)) {
875 ret = report(options, &tag->object, FSCK_MSG_MISSING_OBJECT, "invalid format - expected 'object' line");
876 goto done;
877 }
878 if (get_sha1_hex(buffer, sha1) || buffer[40] != '\n') {
879 ret = report(options, &tag->object, FSCK_MSG_BAD_OBJECT_SHA1, "invalid 'object' line format - bad sha1");
880 if (ret)
881 goto done;
882 }
883 buffer += 41;
884
885 if (!skip_prefix(buffer, "type ", &buffer)) {
886 ret = report(options, &tag->object, FSCK_MSG_MISSING_TYPE_ENTRY, "invalid format - expected 'type' line");
887 goto done;
888 }
889 eol = strchr(buffer, '\n');
890 if (!eol) {
891 ret = report(options, &tag->object, FSCK_MSG_MISSING_TYPE, "invalid format - unexpected end after 'type' line");
892 goto done;
893 }
894 if (type_from_string_gently(buffer, eol - buffer, 1) < 0)
895 ret = report(options, &tag->object, FSCK_MSG_BAD_TYPE, "invalid 'type' value");
896 if (ret)
897 goto done;
898 buffer = eol + 1;
899
900 if (!skip_prefix(buffer, "tag ", &buffer)) {
901 ret = report(options, &tag->object, FSCK_MSG_MISSING_TAG_ENTRY, "invalid format - expected 'tag' line");
902 goto done;
903 }
904 eol = strchr(buffer, '\n');
905 if (!eol) {
906 ret = report(options, &tag->object, FSCK_MSG_MISSING_TAG, "invalid format - unexpected end after 'type' line");
907 goto done;
908 }
909 strbuf_addf(&sb, "refs/tags/%.*s", (int)(eol - buffer), buffer);
910 if (check_refname_format(sb.buf, 0)) {
911 ret = report(options, &tag->object, FSCK_MSG_BAD_TAG_NAME,
912 "invalid 'tag' name: %.*s",
913 (int)(eol - buffer), buffer);
914 if (ret)
915 goto done;
916 }
917 buffer = eol + 1;
918
919 if (!skip_prefix(buffer, "tagger ", &buffer)) {
920 /* early tags do not contain 'tagger' lines; warn only */
921 ret = report(options, &tag->object, FSCK_MSG_MISSING_TAGGER_ENTRY, "invalid format - expected 'tagger' line");
922 if (ret)
923 goto done;
924 }
925 else
926 ret = fsck_ident(&buffer, &tag->object, options);
927
928 done:
929 strbuf_release(&sb);
930 free(to_free);
931 return ret;
932 }
933
934 static int fsck_tag(struct tag *tag, const char *data,
935 unsigned long size, struct fsck_options *options)
936 {
937 struct object *tagged = tag->tagged;
938
939 if (!tagged)
940 return report(options, &tag->object, FSCK_MSG_BAD_TAG_OBJECT, "could not load tagged object");
941
942 return fsck_tag_buffer(tag, data, size, options);
943 }
944
945 static int check_submodule_url(const char *url)
946 {
947 struct credential c = CREDENTIAL_INIT;
948 int ret;
949
950 if (looks_like_command_line_option(url))
951 return -1;
952
953 ret = credential_from_url_gently(&c, url, 1);
954 credential_clear(&c);
955 return ret;
956 }
957
958 struct fsck_gitmodules_data {
959 struct object *obj;
960 struct fsck_options *options;
961 int ret;
962 };
963
964 static int fsck_gitmodules_fn(const char *var, const char *value, void *vdata)
965 {
966 struct fsck_gitmodules_data *data = vdata;
967 const char *subsection, *key;
968 int subsection_len;
969 char *name;
970
971 if (parse_config_key(var, "submodule", &subsection, &subsection_len, &key) < 0 ||
972 !subsection)
973 return 0;
974
975 name = xmemdupz(subsection, subsection_len);
976 if (check_submodule_name(name) < 0)
977 data->ret |= report(data->options, data->obj,
978 FSCK_MSG_GITMODULES_NAME,
979 "disallowed submodule name: %s",
980 name);
981 if (!strcmp(key, "url") && value &&
982 check_submodule_url(value) < 0)
983 data->ret |= report(data->options, data->obj,
984 FSCK_MSG_GITMODULES_URL,
985 "disallowed submodule url: %s",
986 value);
987 if (!strcmp(key, "path") && value &&
988 looks_like_command_line_option(value))
989 data->ret |= report(data->options, data->obj,
990 FSCK_MSG_GITMODULES_PATH,
991 "disallowed submodule path: %s",
992 value);
993 if (!strcmp(key, "update") && value &&
994 parse_submodule_update_type(value) == SM_UPDATE_COMMAND)
995 data->ret |= report(data->options, data->obj,
996 FSCK_MSG_GITMODULES_UPDATE,
997 "disallowed submodule update setting: %s",
998 value);
999 free(name);
1000
1001 return 0;
1002 }
1003
1004 static int fsck_blob(struct blob *blob, const char *buf,
1005 unsigned long size, struct fsck_options *options)
1006 {
1007 struct fsck_gitmodules_data data;
1008
1009 if (!oidset_contains(&gitmodules_found, &blob->object.oid))
1010 return 0;
1011 oidset_insert(&gitmodules_done, &blob->object.oid);
1012
1013 if (!buf) {
1014 /*
1015 * A missing buffer here is a sign that the caller found the
1016 * blob too gigantic to load into memory. Let's just consider
1017 * that an error.
1018 */
1019 return report(options, &blob->object,
1020 FSCK_MSG_GITMODULES_PARSE,
1021 ".gitmodules too large to parse");
1022 }
1023
1024 data.obj = &blob->object;
1025 data.options = options;
1026 data.ret = 0;
1027 if (git_config_from_mem(fsck_gitmodules_fn, CONFIG_ORIGIN_BLOB,
1028 ".gitmodules", buf, size, &data))
1029 data.ret |= report(options, &blob->object,
1030 FSCK_MSG_GITMODULES_PARSE,
1031 "could not parse gitmodules blob");
1032
1033 return data.ret;
1034 }
1035
1036 int fsck_object(struct object *obj, void *data, unsigned long size,
1037 struct fsck_options *options)
1038 {
1039 if (!obj)
1040 return report(options, obj, FSCK_MSG_BAD_OBJECT_SHA1, "no valid object to fsck");
1041
1042 if (obj->type == OBJ_BLOB)
1043 return fsck_blob((struct blob *)obj, data, size, options);
1044 if (obj->type == OBJ_TREE)
1045 return fsck_tree((struct tree *) obj, options);
1046 if (obj->type == OBJ_COMMIT)
1047 return fsck_commit((struct commit *) obj, (const char *) data,
1048 size, options);
1049 if (obj->type == OBJ_TAG)
1050 return fsck_tag((struct tag *) obj, (const char *) data,
1051 size, options);
1052
1053 return report(options, obj, FSCK_MSG_UNKNOWN_TYPE, "unknown type '%d' (internal fsck error)",
1054 obj->type);
1055 }
1056
1057 int fsck_error_function(struct fsck_options *o,
1058 struct object *obj, int msg_type, const char *message)
1059 {
1060 if (msg_type == FSCK_WARN) {
1061 warning("object %s: %s", describe_object(o, obj), message);
1062 return 0;
1063 }
1064 error("object %s: %s", describe_object(o, obj), message);
1065 return 1;
1066 }
1067
1068 int fsck_finish(struct fsck_options *options)
1069 {
1070 int ret = 0;
1071 struct oidset_iter iter;
1072 const struct object_id *oid;
1073
1074 oidset_iter_init(&gitmodules_found, &iter);
1075 while ((oid = oidset_iter_next(&iter))) {
1076 struct blob *blob;
1077 enum object_type type;
1078 unsigned long size;
1079 char *buf;
1080
1081 if (oidset_contains(&gitmodules_done, oid))
1082 continue;
1083
1084 blob = lookup_blob(oid);
1085 if (!blob) {
1086 ret |= report(options, &blob->object,
1087 FSCK_MSG_GITMODULES_BLOB,
1088 "non-blob found at .gitmodules");
1089 continue;
1090 }
1091
1092 buf = read_sha1_file(oid->hash, &type, &size);
1093 if (!buf) {
1094 if (is_promisor_object(&blob->object.oid))
1095 continue;
1096 ret |= report(options, &blob->object,
1097 FSCK_MSG_GITMODULES_MISSING,
1098 "unable to read .gitmodules blob");
1099 continue;
1100 }
1101
1102 if (type == OBJ_BLOB)
1103 ret |= fsck_blob(blob, buf, size, options);
1104 else
1105 ret |= report(options, &blob->object,
1106 FSCK_MSG_GITMODULES_BLOB,
1107 "non-blob found at .gitmodules");
1108 free(buf);
1109 }
1110
1111
1112 oidset_clear(&gitmodules_found);
1113 oidset_clear(&gitmodules_done);
1114 return ret;
1115 }