gdb/ChangeLog

   1 2020-07-28  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * python/py-frame.c: Remove 'user-regs.h' include.
   4         (frapy_read_register): Rewrite to make use of
   5         gdbpy_parse_register_id.
   6         * python/py-registers.c (gdbpy_parse_register_id): New function,
   7         moved here from python/py-unwind.c.  Updated the return type, and
   8         also accepts register descriptor objects.
   9         * python/py-unwind.c: Remove 'user-regs.h' include.
  10         (pyuw_parse_register_id): Moved to python/py-registers.c.
  11         (unwind_infopy_add_saved_register): Update to use
  12         gdbpy_parse_register_id.
  13         (pending_framepy_read_register): Likewise.
  14         * python/python-internal.h (gdbpy_parse_register_id): Declare.
  15
  16 2020-07-28  Andrew Burgess  <andrew.burgess@embecosm.com>
  17
  18         * python/py-registers.c: Add 'user-regs.h' include.
  19         (register_descriptor_iter_find): New function.
  20         (register_descriptor_iterator_object_methods): New static global
  21         methods array.
  22         (register_descriptor_iterator_object_type): Add pointer to methods
  23         array.
  24
  25 2020-07-27  John Baldwin  <jhb@FreeBSD.org>
  26
  27         * fbsd-nat.h: Include <osreldate.h>.  Define USE_SIGTRAP_SIGINFO
  28         for all architectures on FreeBSD 11.3 and later.
  29
  30 2020-07-27  Tom Tromey  <tromey@adacore.com>
  31
  32         * gcore.h (load_corefile): Don't declare.
  33
  34 2020-07-27  Tom de Vries  <tdevries@suse.de>
  35
  36         * configure.ac: Fix sys/sockets.h -> sys/socket.h typo.
  37         * config.in: Regenerate.
  38         * configure: Regenerate.
  39
  40 2020-07-26  Eli Zaretskii  <eliz@gnu.org>
  41
  42         * configure.ac (AC_CHECK_HEADERS): Check for sys/socket.h and
  43         ws2tcpip.h.  When checking whether socklen_t type is defined, use
  44         ws2tcpip.h if it is available and sys/socket.h isn't.
  45         * configure: Regenerate.
  46         * config.in: Regenerate.
  47
  48 2020-07-25  Andrew Burgess  <andrew.burgess@embecosm.com>
  49
  50         PR fortran/23051
  51         PR fortran/26139
  52         * valops.c (value_ind): Pass address to
  53         readjust_indirect_value_type.
  54         * value.c (readjust_indirect_value_type): Make parameter
  55         non-const, and add extra address parameter.  Resolve original type
  56         before using it.
  57         * value.h (readjust_indirect_value_type): Update function
  58         signature and comment.
  59
  60 2020-07-25  Tom de Vries  <tdevries@suse.de>
  61
  62         PR symtab/26243
  63         * dwarf2/read.c (lnp_state_machine::record_line): Ignore zero line
  64         entries.
  65
  66 2020-07-24  Aaron Merey  <amerey@redhat.com>
  67
  68         * Makefile.in: Replace LIBDEBUGINFOD with DEBUGINFOD_LIBS.
  69         * configure: Rebuild.
  70
  71 2020-07-23  Kevin Buettner  <kevinb@redhat.com>
  72
  73         PR corefiles/26294
  74         * corelow.c (_initialize_corelow): Add period to help text
  75         for "maintenance print core-file-backed-mappings".
  76
  77 2020-07-23  Pedro Alves  <pedro@palves.net>
  78
  79         * frame-unwind.c (frame_unwind_try_unwinder): On exception, don't
  80         touch THIS_CACHE/THIS_FRAME if the frame cache was cleared
  81         meanwhile.
  82         * frame.c (frame_cache_generation, get_frame_cache_generation):
  83         New.
  84         (reinit_frame_cache): Increment FRAME_CACHE_GENERATION.
  85         (get_prev_frame_if_no_cycle): On exception, don't touch
  86         PREV_FRAME/THIS_FRAME if the frame cache was cleared meanwhile.
  87         * frame.h (get_frame_cache_generation): Declare.
  88
  89 2020-07-23  Tom de Vries  <tdevries@suse.de>
  90
  91         PR tui/26282
  92         * tui/tui-winsource.h (struct tui_source_windows::tui_source_windows):
  93         New default constructor.
  94
  95 2020-07-23  Andrew Burgess  <andrew.burgess@embecosm.com>
  96
  97         * disasm.c (do_mixed_source_and_assembly_deprecated): Don't
  98         exclude non-statement entries.
  99
 100 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
 101
 102         * NEWS (New commands): Mention new command
 103         "maintenance print core-file-backed-mappings".
 104
 105 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
 106
 107         * corelow.c (gdbcmd.h): Include.
 108         (core_target::info_proc_mappings): New method.
 109         (get_current_core_target): New function.
 110         (maintenance_print_core_file_backed_mappings): New function.
 111         (_initialize_corelow): Add core-file-backed-mappings to
 112         "maint print" commands.
 113
 114 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
 115
 116         * linux-tdep.c (dump_note_entry_p): New function.
 117         (linux_dump_mapping_p_ftype): New typedef.
 118         (linux_find_memory_regions_full): Add new parameter,
 119         should_dump_mapping_p.
 120         (linux_find_memory_regions): Adjust call to
 121         linux_find_memory_regions_full.
 122         (linux_make_mappings_core_file_notes): Use dump_note_entry_p in
 123         call to linux_find_memory_regions_full.
 124
 125 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
 126
 127         * corelow.c (solist.h, unordered_map): Include.
 128         (class core_target): Add field m_core_file_mappings and
 129         method build_file_mappings.
 130         (core_target::core_target): Call build_file_mappings.
 131         (core_target::~core_target): Free memory associated with
 132         m_core_file_mappings.
 133         (core_target::build_file_mappings): New method.
 134         (core_target::xfer_partial): Use m_core_file_mappings
 135         for memory transfers.
 136         * linux-tdep.c (linux_read_core_file_mappings): New
 137         function.
 138         (linux_core_info_proc_mappings): Rewrite to use
 139         linux_read_core_file_mappings.
 140         (linux_init_abi): Register linux_read_core_file_mappings.
 141
 142 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
 143
 144         * arch-utils.c (default_read_core_file_mappings): New function.
 145         * arch-utils.c (default_read_core_file_mappings): Declare.
 146         * gdbarch.sh (read_core_file_mappings): New gdbarch method.
 147         * gdbarch.h, gdbarch.c: Regenerate.
 148
 149 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
 150
 151         PR corefiles/25631
 152         * corelow.c (core_target:xfer_partial):  Revise
 153         TARGET_OBJECT_MEMORY case to consider non-SEC_HAS_CONTENTS
 154         case after first checking the stratum beneath the core
 155         target.
 156         (has_all_memory): Return true.
 157         * target.c (raw_memory_xfer_partial): Revise comment
 158         regarding use of has_all_memory.
 159
 160 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
 161
 162         * exec.h (section_table_xfer_memory): Revise declaration,
 163         replacing section name parameter with an optional callback
 164         predicate.
 165         * exec.c (section_table_xfer_memory): Likewise.
 166         * bfd-target.c, exec.c, target.c, corelow.c: Adjust all callers
 167         of section_table_xfer_memory.
 168
 169 2020-07-22  Tom Tromey  <tromey@adacore.com>
 170
 171         * mi/mi-cmd-stack.c (list_args_or_locals): Use
 172         lookup_symbol_search_name.
 173
 174 2020-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 175
 176         * python/py-registers.c (gdbpy_register_object_data_init): Remove
 177         redundant local variable.
 178         (gdbpy_get_register_descriptor): Extract descriptor vector as a
 179         reference, not pointer, update code accordingly.
 180
 181 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
 182             Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 183
 184         * objfiles.h (struct objfile) <skip_jit_symbol_lookup>: New field.
 185         * jit.c (jit_breakpoint_re_set_internal): Use the
 186         `skip_jit_symbol_lookup` field.
 187
 188 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
 189             Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 190
 191         * jit.c (jit_read_descriptor): Define the descriptor address once,
 192         use twice.
 193         (jit_breakpoint_deleted): Move the declaration of the loop variable
 194         `iter` into the loop header.
 195         (jit_breakpoint_re_set_internal): Move the declaration of the local
 196         variable `objf_data` to the first point of definition.
 197         (jit_event_handler): Move the declaration of local variables
 198         `code_entry`, `entry_addr`, and `objf` to their first point of use.
 199         Rename `objf` to `jited`.
 200
 201 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
 202
 203         * jit.h (struct jiter_objfile_data) <jiter_objfile_data, objfile>:
 204         Remove.
 205         * jit.c (get_jiter_objfile_data): Update.
 206
 207 2020-07-22  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 208             Simon Marchi  <simon.marchi@polymtl.ca>
 209
 210         * jit.c (struct jit_program_space_data): Remove.
 211         (jit_program_space_key): Remove.
 212         (jiter_objfile_data::~jiter_objfile_data): Remove program space
 213         stuff.
 214         (get_jit_program_space_data): Remove.
 215         (jit_breakpoint_deleted): Iterate on all of the program space's
 216         objfiles.
 217         (jit_inferior_init): Likewise.
 218         (jit_breakpoint_re_set_internal): Likewise.  Also change return
 219         type to void.
 220         (jit_breakpoint_re_set): Pass current_program_space to
 221         jit_breakpoint_re_set_internal.
 222
 223 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
 224
 225         * jit.h (struct jiter_objfile_data) <cached_code_address,
 226         jit_breakpoint>: Move to here from ...
 227         * jit.c (jit_program_space_data): ... here.
 228         (jiter_objfile_data::~jiter_objfile_data): Update.
 229         (jit_breakpoint_deleted): Update.
 230         (jit_breakpoint_re_set_internal): Update.
 231
 232 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
 233
 234         * jit.c (jiter_objfile_data::~jiter_objfile_data): Remove some
 235         checks.
 236         (jit_read_descriptor): Remove NULL check.
 237         (jit_event_handler): Add an assertion.
 238
 239 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
 240
 241         * jit.h (struct jit_objfile_data):  Split into...
 242         (struct jiter_objfile_data): ... this ...
 243         (struct jited_objfile_data): ... and this.
 244         * objfiles.h (struct objfile) <jit_data>: Remove.
 245         <jiter_data, jited_data>: New fields.
 246         * jit.c (jit_objfile_data::~jit_objfile_data): Rename to ...
 247         (jiter_objfile_data::~jiter_objfile_data): ... this.
 248         (get_jit_objfile_data): Rename to ...
 249         (get_jiter_objfile_data): ... this.
 250         (add_objfile_entry): Update.
 251         (jit_read_descriptor): Use get_jiter_objfile_data.
 252         (jit_find_objf_with_entry_addr): Use objfile's jited_data field.
 253         (jit_breakpoint_re_set_internal): Use get_jiter_objfile_data.
 254         (jit_inferior_exit_hook): Use objfile's jited_data field.
 255
 256 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
 257
 258         * jit.h: Forward-declare `struct minimal_symbol`.
 259         (struct jit_objfile_data): Migrate to here from jit.c; also add a
 260         constructor, destructor, and an objfile* field.
 261         * jit.c (jit_objfile_data): Remove.
 262         (struct jit_objfile_data): Migrate from here to jit.h.
 263         (jit_objfile_data::~jit_objfile_data): New destructor
 264         implementation with code moved from free_objfile_data.
 265         (free_objfile_data): Delete.
 266         (get_jit_objfile_data): Update to use the jit_data field of objfile.
 267         (jit_find_objf_with_entry_addr): Ditto.
 268         (jit_inferior_exit_hook): Ditto.
 269         (_initialize_jit): Remove the call to
 270         register_objfile_data_with_cleanup.
 271         * objfiles.h (struct objfile) <jit_data>: New field.
 272
 273 2020-07-22  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 274
 275         * jit.h: Forward-declare `struct objfile`.
 276         (jit_event_handler): Add a second parameter, the JITer objfile.
 277         * jit.c (jit_read_descriptor): Change the signature to take the
 278         JITer objfile as an argument instead of the jit_program_space_data.
 279         (jit_inferior_init): Update the call to jit_read_descriptor.
 280         (jit_event_handler): Use the new JITer objfile argument when calling
 281         jit_read_descriptor.
 282         * breakpoint.c (handle_jit_event): Update the call to
 283         jit_event_handler to pass the JITer objfile.
 284
 285 2020-07-21  John Baldwin  <jhb@FreeBSD.org>
 286
 287         * gdbarch.c: Regenerate.
 288         * gdbarch.h: Regenerate.
 289         * gdbarch.sh (handle_segmentation_fault): Remove method.
 290         * infrun.c (handle_segmentation_fault): Remove.
 291         (print_signal_received_reason): Remove call to
 292         handle_segmentation_fault.
 293
 294 2020-07-21  John Baldwin  <jhb@FreeBSD.org>
 295
 296         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 297         Rename to sparc64_linux_report_signal_info and add siggnal
 298         argument.
 299         (sparc64_linux_init_abi): Use sparc64_linux_report_signal_info
 300         instead of sparc64_linux_handle_segmentation_fault.
 301
 302 2020-07-21  John Baldwin  <jhb@FreeBSD.org>
 303
 304         * amd64-linux-tdep.c (amd64_linux_init_abi_common): Use
 305         i386_linux_report_signal_info instead of
 306         i386_linux_handle_segmentation_fault.
 307         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Rename
 308         to i386_linux_report_signal_info and add siggnal argument.
 309         (i386_linux_init_abi): Use i386_linux_report_signal_info instead
 310         of i386_linux_handle_segmentation_fault.
 311         * i386-linux-tdep.h (i386_linux_handle_segmentation_fault): Rename
 312         to i386_linux_report_signal_info and add siggnal argument.
 313
 314 2020-07-21  John Baldwin  <jhb@FreeBSD.org>
 315
 316         * corelow.c (core_target_open): Invoke gdbarch report_signal_info
 317         hook if present.
 318
 319 2020-07-21  John Baldwin  <jhb@FreeBSD.org>
 320
 321         * gdbarch.c: Regenerate.
 322         * gdbarch.h: Regenerate.
 323         * gdbarch.sh (report_signal_info): New method.
 324         * infrun.c (print_signal_received_reason): Invoke gdbarch
 325         report_signal_info hook if present.
 326
 327 2020-07-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 328
 329         * python/py-registers.c : Add 'unordered_map' include.
 330         (gdbpy_new_reggroup): Renamed to...
 331         (gdbpy_get_reggroup): ...this.  Update to only create register
 332         group descriptors when needed.
 333         (gdbpy_reggroup_iter_next): Update.
 334
 335 2020-07-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 336
 337         * python/py-registers.c (gdbpy_register_object_data): New static
 338         global.
 339         (gdbpy_register_object_data_init): New function.
 340         (gdbpy_new_register_descriptor): Renamed to...
 341         (gdbpy_get_register_descriptor): ...this, and update to reuse
 342         existing register descriptors where possible.
 343         (gdbpy_register_descriptor_iter_next): Update.
 344         (gdbpy_initialize_registers): Register new gdbarch data.
 345
 346 2020-07-21  Simon Marchi  <simon.marchi@efficios.com>
 347
 348         * linux-nat.c (stopped_pids): Make static.
 349
 350 2020-07-21  Simon Marchi  <simon.marchi@polymtl.ca>
 351
 352         PR ada/26235
 353         * gdbtypes.c (ada_discrete_type_low_bound,
 354         ada_discrete_type_high_bound): Handle undefined bounds.
 355
 356 2020-07-21  Kamil Rytarowski  <n54@gmx.com>
 357
 358         * nbsd-nat.h (nbsd_nat_target::supports_multi_process): New
 359         declaration.
 360         * nbsd-nat.c (nbsd_nat_target::supports_multi_process): New
 361         function.
 362
 363 2020-07-20  John Baldwin  <jhb@FreeBSD.org>
 364
 365         * fbsd-tdep.c (fbsd_skip_solib_resolver): New function.
 366         (fbsd_init_abi): Install gdbarch "skip_solib_resolver" method.
 367         * fbsd-tdep.h (fbsd_skip_solib_resolver): New prototype.
 368         * mips-fbsd-tdep.c (mips_fbsd_skip_solib_resolver): New function.
 369         (mips_fbsd_init_abi): Install gdbarch "skip_solib_resolver"
 370         method.
 371
 372 2020-07-20 Ludovic Courtès  <ludo@gnu.org>
 373
 374         * guile/scm-math.c (vlscm_integer_fits_p): Use 'uintmax_t'
 375         and 'intmax_t' instead of 'scm_t_uintmax' and 'scm_t_intmax',
 376         which are deprecated in Guile 3.0.
 377         * configure.ac (try_guile_versions): Add "guile-3.0".
 378         * configure (try_guile_versions): Regenerate.
 379         * NEWS: Update entry.
 380
 381 2020-07-20  Ludovic Courtès  <ludo@gnu.org>
 382             Doug Evans  <dje@google.com>
 383
 384         PR gdb/21104
 385         * guile/scm-ports.c (USING_GUILE_BEFORE_2_2): New macro.
 386         (ioscm_memory_port)[read_buf_size, write_buf_size]: Wrap in #if
 387         USING_GUILE_BEFORE_2_2.
 388         (stdio_port_desc, memory_port_desc) [!USING_GUILE_BEFORE_2_2]:
 389         Change type to 'scm_t_port_type *'.
 390         (natural_buffer_size) [!USING_GUILE_BEFORE_2_2]: New variable.
 391         (ioscm_open_port) [USING_GUILE_BEFORE_2_2]: Add 'stream'
 392         parameter and honor it.  Update callers.
 393         (ioscm_open_port) [!USING_GUILE_BEFORE_2_2]: New function.
 394         (ioscm_read_from_port, ioscm_write) [!USING_GUILE_BEFORE_2_2]: New
 395         functions.
 396         (ioscm_fill_input, ioscm_input_waiting, ioscm_flush): Wrap in #if
 397         USING_GUILE_BEFORE_2_2.
 398         (ioscm_init_gdb_stdio_port) [!USING_GUILE_BEFORE_2_2]: Use
 399         'ioscm_read_from_port'.  Call 'scm_set_port_read_wait_fd'.
 400         (ioscm_init_stdio_buffers) [!USING_GUILE_BEFORE_2_2]: New function.
 401         (gdbscm_stdio_port_p) [!USING_GUILE_BEFORE_2_2]: Use 'SCM_PORTP'
 402         and 'SCM_PORT_TYPE'.
 403         (gdbscm_memory_port_end_input, gdbscm_memory_port_seek)
 404         (ioscm_reinit_memory_port): Wrap in #if USING_GUILE_BEFORE_2_2.
 405         (gdbscm_memory_port_read, gdbscm_memory_port_write)
 406         (gdbscm_memory_port_seek, gdbscm_memory_port_close)
 407         [!USING_GUILE_BEFORE_2_2]: New functions.
 408         (gdbscm_memory_port_print): Remove use of 'SCM_PTOB_NAME'.
 409         (ioscm_init_memory_port_type) [!USING_GUILE_BEFORE_2_2]: Use
 410         'gdbscm_memory_port_read'.
 411         Wrap 'scm_set_port_end_input', 'scm_set_port_flush', and
 412         'scm_set_port_free' calls in #if USING_GUILE_BEFORE_2_2.
 413         (gdbscm_get_natural_buffer_sizes) [!USING_GUILE_BEFORE_2_2]: New
 414         function.
 415         (ioscm_init_memory_port): Remove.
 416         (ioscm_init_memory_port_stream): New function
 417         (ioscm_init_memory_port_buffers) [USING_GUILE_BEFORE_2_2]: New
 418         function.
 419         (gdbscm_memory_port_read_buffer_size) [!USING_GUILE_BEFORE_2_2]:
 420         Return scm_from_uint (0).
 421         (gdbscm_set_memory_port_read_buffer_size_x)
 422         [!USING_GUILE_BEFORE_2_2]: Call 'scm_setvbuf'.
 423         (gdbscm_memory_port_write_buffer_size) [!USING_GUILE_BEFORE_2_2]:
 424         Return scm_from_uint (0).
 425         (gdbscm_set_memory_port_write_buffer_size_x)
 426         [!USING_GUILE_BEFORE_2_2]: Call 'scm_setvbuf'.
 427         * configure.ac (try_guile_versions): Add "guile-2.2".
 428         * configure: Regenerate.
 429         * NEWS: Add entry.
 430
 431 2020-07-18  Tom Tromey  <tom@tromey.com>
 432
 433         * linux-nat.c (linux_multi_process): Remove.
 434         (linux_nat_target::supports_multi_process): Return true.
 435
 436 2020-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 437
 438         * arch/riscv.c (riscv_tdesc_cache): Change map type.
 439         (riscv_lookup_target_description): Return pointer out of
 440         unique_ptr.
 441         * target-descriptions.c (allocate_target_description): Add
 442         comment.
 443         (target_desc_deleter::operator()): Likewise.
 444         * target-descriptions.h (struct target_desc_deleter): Moved to
 445         gdbsupport/tdesc.h.
 446         (target_desc_up): Likewise.
 447
 448 2020-07-17  Tom Tromey  <tromey@adacore.com>
 449
 450         * linux-nat.c (linux_nat_target::supports_non_stop)
 451         (linux_nat_target::always_non_stop_p): Use "true".
 452         (linux_nat_target::supports_disable_randomization): Use "true" and
 453         "false".
 454
 455 2020-07-16  Caroline Tice  <cmtice@google.com>
 456
 457         * dwarf2/read.c (RNGLIST_HEADER_SIZE32) New constant definition.
 458         (RNGLIST_HEADER_SIZE64): New constant definition.
 459         (struct dwop_section_names): Add rnglists_dwo.
 460         (dwop_section_names): Add .debug_rnglists.dwo, .zdebug_rnglists.dwo.
 461         (struct loclist_header): Rename to 'loclists_rnglists_header'.
 462         (struct dwo_sections): Add rnglists field.
 463         (read_attribut_reprocess): Add tag parameter.
 464         (dwarf2_ranges_read): Add tag parameter & remove forward function decl.
 465         (cu_debug_rnglists_section): New function (decl & definition).
 466         (dwarf2_locate_dwo_sections): Add code to read rnglists_dwo section.
 467         (dwarf2_rnglists_process): Add a dwarf_tag parameter, for the kind of
 468         die whose range is being checked; get rnglist section from
 469         cu_debug_rnglists_section, to get from either objfile or dwo file as
 470         appropriate.  Add cases for DW_RLE_base_addressx,
 471         DW_RLE_startx_length, DW_RLE_startx_endx.  Also, update to only add
 472         the base address to DW_RLE_offset_pairs (not to all ranges), moving
 473         test inside if-condition and updating complaint message.
 474         (dwarf2_ranges_process): Add dwarf tag parameter and pass it to
 475         dwarf2_rnglists_process.
 476         (dwarf2_ranges_read): Add dwarf tag parameter and pass it to
 477         dwarf2_ranges_process.
 478         (dwarf2_get_pc_bounds): Check for DW_FORM_rnglistx when setting
 479         need_ranges_base and update comment appropriately.  Also pass die tag
 480         to dwarf2_ranges_read.
 481         (dwarf2_record_block_ranges): Check for DW_FORM_rnglistx when setting
 482         need_ranges_base and update comment appropriately.  Also pass die tag
 483         to dwarf2_ranges_process.
 484         (read_full_die_1): Add code to read DW_AT_rnglists_base and assign to
 485         cu->ranges_base.  Also pass die tag to read_attribute_reprocess.
 486         (partial_die_info::read): Check for DW_FORM_rnglistx when setting
 487         need_ranges_base and update comment appropriately.  Also pass die tag
 488         to read_attribute_reprocess and dwarf2_ranges_read.
 489         (read_loclist_header): Rename function to read_loclists_rnglists_header,
 490         and update function comment appropriately.
 491         (read_loclist_index): Call read_loclists_rnglists_header instead of
 492         read_loclist_header.
 493         (read_rnglist_index): New function.
 494         (read_attribute_reprocess):  Add tag parameter. Add code for
 495         DW_FORM_rnglistx, passing tag to read_rnglist_index.
 496         (read_attribute_value): Mark DW_FORM_rnglistx with need_reprocess.
 497
 498 2020-07-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 499
 500         * f-typeprint.c (f_type_print_base): Allow for dynamic types not
 501         being resolved.
 502
 503 2020-07-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 504
 505         * arch-utils.c (show_architecture): Update formatting of messages.
 506
 507 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
 508
 509         * gdbtypes.h (struct type) <bounds>: Handle array and string
 510         types.
 511         * ada-lang.c (assign_aggregate): Use type::bounds on
 512         array/string type.
 513         * c-typeprint.c (c_type_print_varspec_suffix): Likewise.
 514         * c-varobj.c (c_number_of_children): Likewise.
 515         (c_describe_child): Likewise.
 516         * eval.c (evaluate_subexp_for_sizeof): Likewise.
 517         * f-typeprint.c (f_type_print_varspec_suffix): Likewise.
 518         (f_type_print_base): Likewise.
 519         * f-valprint.c (f77_array_offset_tbl): Likewise.
 520         (f77_get_upperbound): Likewise.
 521         (f77_print_array_1): Likewise.
 522         * guile/scm-type.c (gdbscm_type_range): Likewise.
 523         * m2-typeprint.c (m2_array): Likewise.
 524         (m2_is_long_set_of_type): Likewise.
 525         * m2-valprint.c (get_long_set_bounds): Likewise.
 526         * p-typeprint.c (pascal_type_print_varspec_prefix): Likewise.
 527         * python/py-type.c (typy_range): Likewise.
 528         * rust-lang.c (rust_internal_print_type): Likewise.
 529         * type-stack.c (type_stack::follow_types): Likewise.
 530         * valarith.c (value_subscripted_rvalue): Likewise.
 531         * valops.c (value_cast): Likewise.
 532
 533 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
 534
 535         * gdbtypes.c (TYPE_ARRAY_BIT_STRIDE): Remove.  Update all
 536         callers to use the equivalent accessor methods.
 537
 538 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
 539
 540         * gdbtypes.h (struct range_bounds) <bit_stride>: New method.
 541         (struct type) <bit_stride>: New method.
 542         (TYPE_BIT_STRIDE): Remove.
 543         * gdbtypes.c (update_static_array_size): Use type::bit_stride.
 544
 545 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
 546
 547         * gdbtypes.h (TYPE_ARRAY_LOWER_BOUND_VALUE,
 548         TYPE_ARRAY_UPPER_BOUND_VALUE): Remove.  Update all
 549         callers to use the equivalent accessor methods instead.
 550
 551 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
 552
 553         * gdbtypes.h (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED,
 554         TYPE_ARRAY_LOWER_BOUND_IS_UNDEFINED): Remove.  Update all
 555         callers to use the equivalent accessor methods instead.
 556
 557 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
 558
 559         * gdbtypes.h (TYPE_LOW_BOUND_KIND,
 560         TYPE_HIGH_BOUND_KIND): Remove.  Update all callers
 561         to use dynamic_prop::kind.
 562
 563 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
 564
 565         * gdbtypes.h (TYPE_LOW_BOUND_UNDEFINED,
 566         TYPE_HIGH_BOUND_UNDEFINED): Remove.  Update all callers
 567         to get the bound property's kind and check against
 568         PROP_UNDEFINED.
 569
 570 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
 571
 572         * gdbtypes.h (TYPE_LOW_BOUND, TYPE_HIGH_BOUND): Remove.  Update
 573         all callers to use type::range_bounds followed by
 574         dynamic_prop::{low,high}.
 575
 576 2020-07-12  Simon Marchi  <simon.marchi@polymtl.ca>
 577
 578         * gdbtypes.h (struct dynamic_prop) <kind, set_undefined,
 579         const_val, set_const_val, baton, set_locexpr, set_loclist,
 580         set_addr_offset, variant_parts, set_variant_parts,
 581         original_type, set_original_type>: New methods.
 582         <kind>: Rename to...
 583         <m_kind>: ... this.  Update all users to use the new methods
 584         instead.
 585         <data>: Rename to...
 586         <m_data>: ... this.  Update all users to use the new methods
 587         instead.
 588
 589 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
 590
 591         * gdbtypes.c (get_discrete_bounds): Return failure if
 592         the range type's bounds are not both defined and constant
 593         values.
 594         (get_array_bounds): Update comment.  Remove undefined bound check.
 595
 596 2020-07-12  Simon Marchi  <simon.marchi@polymtl.ca>
 597
 598         * gdbtypes.h (TYPE_RANGE_DATA): Remove.  Update callers to use
 599         the type::bounds method directly.
 600
 601 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
 602
 603         * gdbtypes.h (struct type) <bounds, set_bounds>: New methods.
 604         (TYPE_RANGE_DATA): Use type::bounds.  Change all uses that
 605         are used to set the range type's bounds to use set_bounds.
 606
 607 2020-07-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 608
 609         * exec.c (_initialize_exec): Update exec-file-mismatch help.
 610
 611 2020-07-10  Pedro Alves  <pedro@palves.net>
 612
 613         * gdbthread.h (inferior_ref): Define.
 614         (scoped_restore_current_thread) <m_thread>: Now a thread_info_ref.
 615         (scoped_restore_current_thread) <m_inf>: Now an inferior_ref.
 616         * thread.c
 617         (scoped_restore_current_thread::restore):
 618         Adjust to gdb::ref_ptr.
 619         (scoped_restore_current_thread::~scoped_restore_current_thread):
 620         Remove manual decref handling.
 621         (scoped_restore_current_thread::scoped_restore_current_thread):
 622         Adjust to use
 623         inferior_ref::new_reference/thread_info_ref::new_reference.
 624         Incref the thread before calling get_frame_id instead of after.
 625         Let TARGET_CLOSE_ERROR propagate.
 626
 627 2020-07-10  Pedro Alves  <pedro@palves.net>
 628
 629         * frame-tailcall.c (dwarf2_tailcall_sniffer_first): Only swallow
 630         NO_ENTRY_VALUE_ERROR / MEMORY_ERROR / OPTIMIZED_OUT_ERROR /
 631         NOT_AVAILABLE_ERROR.
 632         * value.c (value_optimized_out): Only swallow MEMORY_ERROR /
 633         OPTIMIZED_OUT_ERROR / NOT_AVAILABLE_ERROR.
 634
 635 2020-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 636             Pedro Alves  <pedro@palves.net>
 637
 638         PR gdb/26199
 639         * infrun.c (threads_are_resumed_pending_p): Delete.
 640         (do_target_wait): Remove threads_are_executing and
 641         threads_are_resumed_pending_p checks from the inferior_matches
 642         lambda.  Update comments.
 643
 644 2020-07-10  Pedro Alves  <pedro@palves.net>
 645
 646         PR gdb/26199
 647         * infrun.c (handle_no_resumed): Transfer terminal to inferior with
 648         executing threads.
 649
 650 2020-07-10  Pedro Alves  <pedro@palves.net>
 651
 652         PR gdb/26199
 653         * infrun.c (handle_no_resumed): Handle multiple targets.
 654
 655 2020-07-10  Pedro Alves  <pedro@palves.net>
 656
 657         PR gdb/26199
 658         * infrun.c (prepare_to_wait): Check target_can_async_p instead of
 659         target_is_async_p.
 660
 661 2020-07-10  Pedro Alves  <pedro@palves.net>
 662
 663         PR gdb/26199
 664         * target.c (target_pass_ctrlc): Look at the inferior's non-exited
 665         threads, not all threads.
 666
 667 2020-07-10  Pedro Alves  <pedro@palves.net>
 668
 669         PR gdb/26199
 670         * remote.c (remote_target::open_1): Pass remote target pointer as
 671         data to create_async_event_handler.
 672         (remote_async_inferior_event_handler): Mark async event handler
 673         before returning if the remote target still has either pending
 674         events or unacknowledged notifications.
 675
 676 2020-07-10  John Baldwin  <jhb@FreeBSD.org>
 677
 678         * fbsd-nat.h (fbsd_nat_target::supports_multi_process): New
 679         declaration.
 680         * fbsd-nat.c (fbsd_nat_target::supports_multi_process): New
 681         function.
 682
 683 2020-07-09  John Baldwin  <jhb@FreeBSD.org>
 684
 685         * inf-ptrace.c (inf_ptrace_target::wait): Don't compare against
 686         inferior_ptid.
 687
 688 2020-07-09  John Baldwin  <jhb@FreeBSD.org>
 689
 690         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_ARGC,
 691         AT_FREEBSD_ARGV, AT_FREEBSD_ENVC, AT_FREEBSD_ENVV,
 692         AT_FREEBSD_PS_STRINGS.
 693
 694 2020-07-08  Hannes Domani  <ssbssa@yahoo.de>
 695
 696         * auto-load.c (auto_load_objfile_script_1): Convert drive part
 697         of debugfile path on Windows.
 698
 699 2020-07-08  John Baldwin  <jhb@FreeBSD.org>
 700
 701         * fbsd-nat.c (fbsd_nat_target::find_memory_regions): Rename 'obfd'
 702         argument to 'data'.
 703
 704 2020-07-08  Tom Tromey  <tromey@adacore.com>
 705
 706         * ada-lang.c (ada_exception_message_1): Use read_memory.
 707
 708 2020-07-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 709
 710         PR python/22748
 711         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Remove
 712         special handling for inline frames.
 713         * findvar.c (value_of_register_lazy): Skip inline frames when
 714         creating lazy register values.
 715         * frame.c (frame_id_computed_p): Delete definition.
 716         * frame.h (frame_id_computed_p): Delete declaration.
 717
 718 2020-07-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 719
 720         * NEWS: Mention additions to Python API.
 721         * python/py-arch.c (archpy_register_groups): New function.
 722         (arch_object_methods): Add 'register_groups' method.
 723         * python/py-registers.c (reggroup_iterator_object): New struct.
 724         (reggroup_object): New struct.
 725         (gdbpy_new_reggroup): New function.
 726         (gdbpy_reggroup_to_string): New function.
 727         (gdbpy_reggroup_name): New function.
 728         (gdbpy_reggroup_iter): New function.
 729         (gdbpy_reggroup_iter_next): New function.
 730         (gdbpy_new_reggroup_iterator): New function
 731         (gdbpy_initialize_registers): Register new types.
 732         (reggroup_iterator_object_type): Define new Python type.
 733         (gdbpy_reggroup_getset): New static global.
 734         (reggroup_object_type): Define new Python type.
 735         * python/python-internal.h
 736
 737 2020-07-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 738
 739         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-registers.c
 740         * python/py-arch.c (archpy_registers): New function.
 741         (arch_object_methods): Add 'registers' method.
 742         * python/py-registers.c: New file.
 743         * python/python-internal.h
 744         (gdbpy_new_register_descriptor_iterator): Declare.
 745         (gdbpy_initialize_registers): Declare.
 746         * python/python.c (do_start_initialization): Call
 747         gdbpy_initialize_registers.
 748         * NEWS: Mention additions to the Python API.
 749
 750 2020-07-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 751
 752         * NEWS: Mention new Python API method.
 753         * python/py-unwind.c (pending_framepy_architecture): New function.
 754         (pending_frame_object_methods): Add architecture method.
 755
 756 2020-07-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 757
 758         * gdbarch.c: Regenerate.
 759         * gdbarch.h: Regenerate.
 760         * gdbarch.sh (deprecated_set_gdbarch_data): Delete.
 761         (gdbarch_data): Use internal_error for the case where
 762         deprecated_set_gdbarch_data was originally needed.
 763         * ia64-libunwind-tdep.c (libunwind_descr_init): Update parameters,
 764         and use passed in obstack.
 765         (libunwind_frame_set_descr): Should no longer get back NULL from
 766         gdbarch_data.
 767         (_initialize_libunwind_frame): Register as a pre-init gdbarch data
 768         type.
 769         * user-regs.c (user_regs_init): Update parameters, and use passed
 770         in obstack.
 771         (user_reg_add): Should no longer get back NULL from gdbarch_data.
 772         (_initialize_user_regs): Register as a pre-init gdbarch data type.
 773
 774 2020-07-06  Tom de Vries  <tdevries@suse.de>
 775
 776         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Handle
 777         End-Of-Sequence in lte_is_less_than.
 778         * symtab.c (find_pc_sect_line): Revert change from commit 3d92a3e313
 779         "gdb: Don't reorder line table entries too much when sorting".
 780
 781 2020-07-06  Tom de Vries  <tdevries@suse.de>
 782
 783         PR tui/26205
 784         * tui/tui-win.c (tui_partial_win_by_name): Don't test for NULL name.
 785
 786 2020-07-05  Tom de Vries  <tdevries@suse.de>
 787
 788         PR build/26187
 789         * inferior.h (struct infcall_suspend_state_deleter): If available, use
 790         std::uncaught_exceptions instead of deprecated
 791         std::uncaught_exception.
 792
 793 2020-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 794
 795         * macroexp.h (macro_stringify): Return
 796         gdb::unique_xmalloc_ptr<char>.
 797         * macroexp.c (macro_stringify): Likewise.
 798         * macrotab.c (fixup_definition): Update.
 799
 800 2020-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 801
 802         * c-exp.y (scan_macro_expansion): Don't free `expansion`.
 803         (lex_one_token): Update.
 804         * macroexp.c (struct macro_buffer) <release>: Return
 805         gdb::unique_xmalloc_ptr<char>.
 806         (macro_stringify): Update.
 807         (macro_expand): Update.
 808         (macro_expand_next): Return gdb::unique_xmalloc_ptr<char>.
 809         * macroexp.h (macro_expand_next): Likewise.
 810
 811 2020-07-02  Simon Marchi  <simon.marchi@efficios.com>
 812
 813         * macroexp.h (macro_lookup_ftype): Remove.
 814         (macro_expand, macro_expand_once, macro_expand_next): Remove
 815         lookup function parameters, add scope parameter.
 816         * macroexp.c (scan, substitute_args, expand, maybe_expand,
 817         macro_expand, macro_expand_once, macro_expand_next): Likewise.
 818         * macroscope.h (standard_macro_lookup): Change parameter type
 819         to macro_scope.
 820         * macroscope.c (standard_macro_lookup): Likewise.
 821         * c-exp.y (lex_one_token): Update.
 822         * macrocmd.c (macro_expand_command): Likewise.
 823         (macro_expand_once_command): Likewise.
 824
 825 2020-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 826
 827         * inf-loop.c (inferior_event_handler): Remove client_data param.
 828         * inf-loop.h (inferior_event_handler): Likewise.
 829         * infcmd.c (step_1): Adjust.
 830         * infrun.c (proceed): Adjust.
 831         (fetch_inferior_event): Remove client_data param.
 832         (infrun_async_inferior_event_handler): Adjust.
 833         * infrun.h (fetch_inferior_event): Remove `void *` param.
 834         * linux-nat.c (handle_target_event): Adjust.
 835         * record-btrace.c (record_btrace_handle_async_inferior_event):
 836         Adjust.
 837         * record-full.c (record_full_async_inferior_event_handler):
 838         Adjust.
 839         * remote.c (remote_async_inferior_event_handler): Adjust.
 840
 841 2020-07-01  Tom Tromey  <tom@tromey.com>
 842
 843         * tui/tui-data.h (struct tui_win_info) <name>: Now pure virtual.
 844         * tui/tui-stack.h (struct tui_locator_window) <name>: New method.
 845
 846 2020-07-01  Tom Tromey  <tom@tromey.com>
 847
 848         * tui/tui-wingeneral.c (tui_win_info::refresh_window): Move from
 849         tui_gen_win_info.
 850         (tui_win_info::make_window): Merge with
 851         tui_gen_win_info::make_window.
 852         (tui_win_info::make_visible): Move from tui_gen_win_info.
 853         * tui/tui-win.c (tui_win_info::max_width): Move from
 854         tui_gen_win_info.
 855         * tui/tui-layout.h (class tui_layout_window) <m_window>: Change
 856         type.
 857         <window_factory>: Likewise.
 858         * tui/tui-layout.c (tui_win_info::resize): Move from
 859         tui_gen_win_info.
 860         (make_standard_window): Change return type.
 861         (get_locator_window, tui_get_window_by_name): Likewise.
 862         (tui_layout_window::apply): Remove a cast.
 863         * tui/tui-data.h (MIN_WIN_HEIGHT): Move earlier.
 864         (struct tui_win_info): Merge with tui_gen_win_info.
 865         (struct tui_gen_win_info): Remove.
 866
 867 2020-07-01  Tom Tromey  <tom@tromey.com>
 868
 869         * tui/tui-stack.h (struct tui_locator_window): Derive from
 870         tui_win_info.
 871         <do_scroll_horizontal, do_scroll_vertical>: New methods.
 872         <can_box>: New method.
 873
 874 2020-07-01  Tom Tromey  <tom@tromey.com>
 875
 876         * tui/tui-stack.h (struct tui_locator_window): Remove body.
 877
 878 2020-07-01  Tom Tromey  <tom@tromey.com>
 879
 880         * tui/tui-regs.c (tui_data_window::display_registers_from)
 881         (tui_data_window::display_registers_from)
 882         (tui_data_window::first_data_item_displayed)
 883         (tui_data_window::delete_data_content_windows): Update.
 884         (tui_data_window::refresh_window, tui_data_window::no_refresh):
 885         Remove.
 886         (tui_data_window::check_register_values): Update.
 887         (tui_data_item_window::rerender): Add parameters.  Update.
 888         (tui_data_item_window::refresh_window): Remove.
 889         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: No longer
 890         virtual.
 891         * tui/tui-regs.h (struct tui_data_item_window): Don't derive from
 892         tui_gen_win_info.
 893         <refresh_window, max_height, min_height>: Remove.
 894         <rerender>: Add parameters.
 895         <x, y, visible>: New members.
 896         (struct tui_data_window) <refresh_window, no_refresh>: Remove.
 897         <m_item_width>: New member.
 898
 899 2020-07-01  Tom Tromey  <tom@tromey.com>
 900
 901         * tui/tui-regs.c (tui_data_window::show_register_group)
 902         (tui_data_window::check_register_values): Update.
 903         * tui/tui-regs.h (struct tui_data_item_window) <regno>: Rename
 904         from item_no.
 905
 906 2020-07-01  Tom Tromey  <tom@tromey.com>
 907
 908         * tui/tui-regs.c (tui_data_window::show_register_group): Remove
 909         useless "if".
 910
 911 2020-07-01  Tom Tromey  <tom@tromey.com>
 912
 913         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 914         * tui/tui-regs.h (struct tui_data_item_window) <name>: Remove.
 915
 916 2020-07-01  Tom Tromey  <tom@tromey.com>
 917
 918         * tui/tui-stack.c (SINGLE_KEY): Move from tui-data.h
 919         * tui/tui-winsource.h (enum tui_line_or_address_kind)
 920         (struct tui_line_or_address): Move from tui-data.h.
 921         * tui/tui-win.c (DEFAULT_TAB_LEN): Move from tui-data.h.
 922         * tui/tui-data.h (DEFAULT_TAB_LEN): Move to tui-win.c.
 923         (tui_cmd_window, tui_source_window_base, tui_source_window)
 924         (tui_disasm_window): Don't declare.
 925         (enum tui_line_or_address_kind, struct tui_line_or_address): Move
 926         to tui-winsource.h.
 927         (SINGLE_KEY): Move to tui-stack.c.
 928
 929 2020-07-01  Tom Tromey  <tom@tromey.com>
 930
 931         * tui/tui-regs.h (struct tui_data_item_window) <content>: Now a
 932         std::string.
 933         * tui/tui-regs.c (class tab_expansion_file): New.
 934         (tab_expansion_file::write): New method.
 935         (tui_register_format): Change return type.  Use
 936         tab_expansion_file.
 937         (tui_get_register, tui_data_window::display_registers_from)
 938         (tui_data_item_window::rerender): Update.
 939         * tui/tui-io.h (tui_expand_tabs): Don't declare.
 940         * tui/tui-io.c (tui_expand_tabs): Remove.
 941
 942 2020-07-01  Tom Tromey  <tom@tromey.com>
 943
 944         * tui/tui-regs.c (tui_reggroup_completer): Use complete_on_enum.
 945
 946 2020-07-01  Fangrui Song  <maskray@google.com>
 947
 948         * dwarf2/read.c (lnp_state_machine::check_line_address): Test -1.
 949
 950 2020-07-01  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
 951
 952         * dwarf2/read.c (set_die_type): Removed conditions to restrict
 953         forms for DW_AT_associated and DW_AT_allocated attributes,
 954         which is already checked in function attr_to_dynamic_prop.
 955
 956 2020-06-30  Tom Tromey  <tromey@adacore.com>
 957
 958         * dwarf2/read.c (quirk_rust_enum): Correctly call
 959         alloc_rust_variant for default-less enum.
 960
 961 2020-06-30  Tom Tromey  <tromey@adacore.com>
 962
 963         PR build/26183:
 964         * ada-lang.c (ada_lookup_name_info::ada_lookup_name_info): Use
 965         gdb::to_string.
 966
 967 2020-06-29  Simon Marchi  <simon.marchi@efficios.com>
 968
 969         * gdbarch.sh (displaced_step_copy_insn): Update doc.
 970         * gdbarch.h: Re-generate.
 971
 972 2020-06-28  Tom Tromey  <tom@tromey.com>
 973
 974         * command.h (cmd_types): Remove.
 975         (cmd_type): Don't declare.
 976         * cli/cli-decode.h (enum cmd_types): Uncomment.  No longer a
 977         typedef.
 978         * cli/cli-cmds.c (setting_cmd): Use cmd->type directly.
 979         * cli/cli-decode.c (cmd_type): Remove.
 980
 981 2020-06-27  Pedro Alves  <palves@redhat.com>
 982
 983         * fork-child.c (prefork_hook): Adjust.
 984         * infcmd.c (set_inferior_io_terminal, get_inferior_io_terminal):
 985         Delete.
 986         (set_inferior_tty_command, show_inferior_tty_command): Adjust.
 987         * inferior.c (inferior::set_tty, inferior::tty): New methods.
 988         * inferior.h (set_inferior_io_terminal, get_inferior_io_terminal):
 989         Remove declarations.
 990         (struct inferior) <set_tty, tty>: New methods.
 991         (struct inferior) <terminal>: Rename to ...
 992         (struct inferior) <m_terminal>: ... this and make private.
 993         * main.c (captured_main_1): Adjust.
 994         * mi/mi-cmd-env.c (mi_cmd_inferior_tty_set): Adjust.
 995         (mi_cmd_inferior_tty_show): Adjust.
 996         * nto-procfs.c (nto_procfs_target::create_inferior): Adjust.
 997         * windows-nat.c (windows_nat_target::create_inferior): Adjust.
 998
 999 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
1000
1001         * configure.ac: Add --enable-libctf: handle --disable-static
1002         properly.
1003         * acinclude.m4: sinclude ../config/enable.m4.
1004         * Makefile.in (aclocal_m4_deps): Adjust accordingly.
1005         (LIBCTF): Substitute in.
1006         (CTF_DEPS): New, likewise.
1007         (CLIBS): libctf needs symbols from libbfd: move earlier.
1008         (CDEPS): Use CTF_DEPS, not LIBCTF, now LIBCTF can include rpath
1009         flags.
1010         * ctfread.c: Surround in ENABLE_LIBCTF.
1011         (elfctf_build_psymtabs) [!ENABLE_LIBCTF]: New stub.
1012         * configure: Regenerate.
1013         * config.in: Likewise.
1014
1015 2020-06-25  Simon Marchi  <simon.marchi@efficios.com>
1016
1017         * infcmd.c (set_inferior_io_terminal): Use make_unique_xstrdup.
1018
1019 2020-06-25  Simon Marchi  <simon.marchi@efficios.com>
1020
1021         * inferior.h (struct inferior) <terminal>: Change type to
1022         gdb::unique_xmalloc_ptr<char>.
1023         * inferior.c (inferior::~inferior): Don't free inf->terminal.
1024         * infcmd.c (set_inferior_io_terminal): Don't free terminal
1025         field, adjust to unique pointer.
1026         (get_inferior_io_terminal): Adjust to unique pointer.
1027
1028 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1029
1030         * riscv-tdep.c (riscv_print_registers_info): Loop over all
1031         registers, not just the known core set of registers.
1032
1033 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1034
1035         * riscv-tdep.c (riscv_register_name): Return NULL for duplicate
1036         fflags, frm, and fcsr registers.
1037         (riscv_register_reggroup_p): Remove unknown CSRs from save and
1038         restore groups.
1039         (riscv_tdesc_unknown_reg): New function.
1040         (riscv_gdbarch_init): Pass riscv_tdesc_unknown_reg to
1041         tdesc_use_registers.
1042         * riscv-tdep.h (struct gdbarch_tdep): Add
1043         unknown_csrs_first_regnum, unknown_csrs_count,
1044         duplicate_fflags_regnum, duplicate_frm_regnum, and
1045         duplicate_fcsr_regnum fields.
1046
1047 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1048
1049         * target-descriptions.c (tdesc_use_registers): Add new parameter a
1050         callback, use the callback (when not null) to help number unknown
1051         registers.
1052         * target-descriptions.h (tdesc_unknown_register_ftype): New typedef.
1053         (tdesc_use_registers): Add extra parameter to declaration.
1054
1055 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1056
1057         * riscv-tdep.c (value_of_riscv_user_reg): Moved to here from later
1058         in the file.
1059         (class riscv_pending_register_alias): Likewise.
1060         (riscv_register_feature::register_info): Change 'required_p' field
1061         to 'required', and change its type.  Add 'check' member function.
1062         (riscv_register_feature::register_info::check): Define new member
1063         function.
1064         (riscv_xreg_feature): Change initialisation of 'required' field.
1065         (riscv_freg_feature): Likewise.
1066         (riscv_virtual_feature): Likewise.
1067         (riscv_csr_feature): Likewise.
1068         (riscv_check_tdesc_feature): Take extra parameter, the csr
1069         tdesc_feature, rewrite the function to use the new
1070         riscv_register_feature::register_info::check function.
1071         (riscv_gdbarch_init): Pass the csr tdesc_feature where needed.
1072
1073 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1074
1075         * features/Makefile: Remove all references to the deleted files
1076         below.
1077         * features/riscv/32bit-csr.c: Deleted.
1078         * features/riscv/32bit-csr.xml: Deleted.
1079         * features/riscv/64bit-csr.c: Deleted.
1080         * features/riscv/64bit-csr.xml: Deleted.
1081         * features/riscv/rebuild-csr-xml.sh: Deleted.
1082
1083 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1084
1085         * riscv-tdep.c (struct riscv_register_feature::register_info): Fix
1086         whitespace error for declaration of names member variable.
1087         (struct riscv_register_feature): Add new prefer_first_name member
1088         variable, and fix whitespace error in declaration of registers.
1089         (riscv_xreg_feature): Initialize prefer_first_name field.
1090         (riscv_freg_feature): Likewise.
1091         (riscv_virtual_feature): Likewise.
1092         (riscv_csr_feature): Likewise.
1093         (riscv_register_name): Expand on comments.  Remove register name
1094         modifications for CSR and virtual registers.
1095
1096 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1097
1098         * riscv-tdep.c (struct riscv_register_feature): Fix whitespace
1099         errors.
1100
1101 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1102
1103         * riscv-tdep.c (riscv_create_csr_aliases): Handle csr aliases from
1104         riscv-opc.h.
1105         (class riscv_pending_register_alias): New class.
1106         (riscv_check_tdesc_feature): Take vector of pending aliases and
1107         populate it as appropriate.
1108         (riscv_setup_register_aliases): Delete.
1109         (riscv_gdbarch_init): Create vector of pending aliases and pass it
1110         to riscv_check_tdesc_feature in all cases.  Use the vector to
1111         create the register aliases.
1112
1113 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1114
1115         * sol2-tdep.c (sol2_static_transform_name): Remove.
1116         (sol2_init_abi): Don't register it.
1117         * gdbarch.sh (static_transform_name): Remove.
1118         * gdbarch.c, gdbarch.h: Regenerate.
1119
1120         * dbxread.c (read_dbx_symtab) <'S'>: Remove call to
1121         gdbarch_static_transform_name.
1122         * mdebugread.c (parse_partial_symbols) <'S'>: Likewise.
1123         * stabsread.c (define_symbol) <'X'>: Remove.
1124         (define_symbol) <'S'>: Remove gdbarch_static_transform_name
1125         handling.
1126         <'V'>: Likewise.
1127         * xcoffread.c (scan_xcoff_symtab): Remove gdbarch.
1128         <'S'>: Remove call to gdbarch_static_transform_name.
1129
1130 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1131
1132         * procfs.c (procfs_pre_trace): New function.
1133         (procfs_target::create_inferior): Pass it to fork_inferior.
1134
1135 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1136
1137         * configure.tgt <sparc-*-linux*> (gdb_target_obs): Remove
1138         sparc-sol2-tdep.o, sol2-tdep.o, sparc64-sol2-tdep.o.
1139         <sparc64-*-linux*> (gdb_target_obs): Remove sparc64-sol2-tdep.o,
1140         sol2-tdep.o, sparc-sol2-tdep.o.
1141         * sparc-sol2-tdep.c (sparc32_sol2_init_abi): Make static.
1142         * sparc-tdep.h (sparc32_sol2_init_abi): Remove.
1143         * sparc64-sol2-tdep.c (sparc64_sol2_init_abi): Make static.
1144         * sparc64-tdep.h (sparc64_sol2_init_abi): Remove.
1145
1146 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1147
1148         * amd64-sol2-tdep.c (amd64_sol2_sigtramp_p): Remove.
1149         (amd64_sol2_init_abi): Use sol2_sigtramp_p.
1150         Call sol2_init_abi.
1151         Remove calls to set_gdbarch_skip_solib_resolver,
1152         set_gdbarch_core_pid_to_str.
1153         * i386-sol2-tdep.c (i386_sol2_sigtramp_p): Remove.
1154         (i386_sol2_static_transform_name): Remove.
1155         (i386_sol2_init_abi): Call sol2_init_abi.
1156         Remove calls to set_gdbarch_sofun_address_maybe_missing,
1157         set_gdbarch_static_transform_name,
1158         set_gdbarch_skip_solib_resolver, set_gdbarch_core_pid_to_str.
1159         Use sol2_sigtramp_p.
1160         * sol2-tdep.c (sol2_pc_in_sigtramp): New function.
1161         (sol2_sigtramp_p): New function.
1162         (sol2_static_transform_name): New function.
1163         (sol2_skip_solib_resolver, sol2_core_pid_to_str): Make static.
1164         (sol2_init_abi): New function.
1165         * sol2-tdep.h (sol2_sigtramp_p, sol2_init_abi): Declare.
1166         (sol2_skip_solib_resolver, sol2_core_pid_to_str): Remove.
1167         * sparc-sol2-tdep.c (sparc_sol2_pc_in_sigtramp): Remove.
1168         (sparc32_sol2_sigtramp_frame_sniffer): Just call sol2_sigtramp_p.
1169         (sparc_sol2_static_transform_name): Remove.
1170         (sparc32_sol2_init_abi): Call sol2_init_abi.
1171         Remove calls to set_gdbarch_sofun_address_maybe_missing,
1172         set_gdbarch_static_transform_name,
1173         set_gdbarch_skip_solib_resolver,
1174         set_gdbarch_core_pid_to_str.
1175         * sparc-tdep.h (sparc_sol2_pc_in_sigtramp)
1176         (sparc_sol2_static_transform_name): Remove
1177         * sparc64-sol2-tdep.c (sparc64_sol2_sigtramp_frame_sniffer): Just
1178         call sol2_sigtramp_p.
1179         (sparc64_sol2_init_abi): Call sol2_init_abi.
1180         Remove calls to set_gdbarch_sofun_address_maybe_missing,
1181         set_gdbarch_static_transform_name,
1182         set_gdbarch_skip_solib_resolver, set_gdbarch_core_pid_to_str.
1183
1184 2020-06-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1185
1186         * symfile-add-flags.h: New flag SYMFILE_ALWAYS_CONFIRM.
1187         * exec.c (validate_exec_file): If from_tty, set both
1188         SYMFILE_VERBOSE (== from_tty) and SYMFILE_ALWAYS_CONFIRM.
1189         * symfile.c (symbol_file_add_with_addrs): if always_confirm
1190         and from_tty, unconditionally ask a confirmation.
1191
1192 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1193
1194         * target-descriptions.c (tdesc_architecture_name): Protect against
1195         NULL pointer dereference.
1196         (maint_print_xml_tdesc_cmd): New function.
1197         (_initialize_target_descriptions): Register new 'maint print
1198         xml-tdesc' command and give it the filename completer.
1199         * NEWS: Mention new 'maint print xml-tdesc' command.
1200
1201 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1202
1203         * target-descriptions.c (class tdesc_compatible_info): New class.
1204         (struct target_desc): Change type of compatible vector.
1205         (tdesc_compatible_p): Update for change in type of
1206         target_desc::compatible.
1207         (tdesc_compatible_info_list): New function.
1208         (tdesc_compatible_info_arch_name): New function.
1209         (tdesc_add_compatible): Update for change in type of
1210         target_desc::compatible.
1211         (print_c_tdesc::visit_pre): Likewise.
1212
1213 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1214
1215         * target-descriptions.c (print_c_tdesc::print_c_tdesc): Change
1216         whitespace to underscore.
1217         (maint_print_c_tdesc_cmd): Use fake filename for target
1218         descriptions that came from the target.
1219         (_initialize_target_descriptions): Add filename command completion
1220         for 'maint print c-tdesc'.
1221
1222 2020-06-23  Simon Marchi  <simon.marchi@efficios.com>
1223
1224         * dwarf2/loc.c (decode_debug_loclists_addresses): Add empty
1225         lines.
1226
1227 2020-06-23  Simon Marchi  <simon.marchi@efficios.com>
1228
1229         * dwarf2/loc.c (decode_debug_loc_dwo_addresses): Add empty
1230         lines.
1231         (dwarf2_find_location_expression): Likewise.
1232         (call_site_parameter_matches): Likewise.
1233         (dwarf2_compile_expr_to_ax): Likewise.
1234         (disassemble_dwarf_expression): Likewise.
1235         (loclist_describe_location): Likewise.
1236
1237 2020-06-23  Pedro Alves  <palves@redhat.com>
1238
1239         * gdbarch-selftests.c: Don't include inferior.h, gdbthread.h or
1240         progspace-and-thread.h.  Include scoped-mock-context.h instead.
1241         (register_to_value_test): Use scoped_mock_context.
1242         * regcache.c: Include "scoped-mock-context.h".
1243         (cooked_read_test): Don't error out if a target is already pushed.
1244         Use scoped_mock_context.  Adjust.
1245         * scoped-mock-context.h: New file.
1246
1247 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1248
1249         * ada-lang.c (ada_language_data): Delete la_is_string_type_p
1250         initializer.
1251         (ada_language::is_string_type_p): New member function.
1252         * c-lang.c (c_language_data): Delete la_is_string_type_p
1253         initializer.
1254         (cplus_language_data): Likewise.
1255         (asm_language_data): Likewise.
1256         (minimal_language_data): Likewise.
1257         * d-lang.c (d_language_data): Likewise.
1258         * f-lang.c (f_is_string_type_p): Delete function, implementation
1259         moved to f_language::is_string_type_p.
1260         (f_language_data): Delete la_is_string_type_p initializer.
1261         (f_language::is_string_type_p): New member function,
1262         implementation from f_is_string_type_p.
1263         * go-lang.c (go_is_string_type_p): Delete function, implementation
1264         moved to go_language::is_string_type_p.
1265         (go_language_data): Delete la_is_string_type_p initializer.
1266         (go_language::is_string_type_p): New member function,
1267         implementation from go_is_string_type_p.
1268         * language.c (language_defn::is_string_type_p): Define new member
1269         function.
1270         (default_is_string_type_p): Make static, add comment copied from
1271         header file.
1272         (unknown_language_data): Delete la_is_string_type_p initializer.
1273         (unknown_language::is_string_type_p): New member function.
1274         (auto_language_data): Delete la_is_string_type_p initializer.
1275         (auto_language::is_string_type_p): New member function.
1276         * language.h (language_data): Delete la_is_string_type_p field.
1277         (language_defn::is_string_type_p): Declare new function.
1278         (default_is_string_type_p): Delete desclaration, move comment to
1279         definition.
1280         * m2-lang.c (m2_is_string_type_p): Delete function, implementation
1281         moved to m2_language::is_string_type_p.
1282         (m2_language_data): Delete la_is_string_type_p initializer.
1283         (m2_language::is_string_type_p): New member function,
1284         implementation from m2_is_string_type_p.
1285         * objc-lang.c (objc_language_data): Delete la_is_string_type_p
1286         initializer.
1287         * opencl-lang.c (opencl_language_data): Likewise.
1288         * p-lang.c (pascal_is_string_type_p): Delete function,
1289         implementation moved to pascal_language::is_string_type_p.
1290         (pascal_language_data): Delete la_is_string_type_p initializer.
1291         (pascal_language::is_string_type_p): New member function,
1292         implementation from pascal_is_string_type_p.
1293         * rust-lang.c (rust_is_string_type_p): Delete function,
1294         implementation moved to rust_language::is_string_type_p.
1295         (rust_language_data): Delete la_is_string_type_p initializer.
1296         (rust_language::is_string_type_p): New member function,
1297         implementation from rust_is_string_type_p.
1298         * valprint.c (val_print_scalar_or_string_type_p): Update call to
1299         is_string_type_p.
1300
1301 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1302
1303         * ada-lang.c (ada_language_data): Delete la_print_typedef
1304         initializer.
1305         (ada_language::print_typedef): New member function.
1306         * c-lang.c (c_language_data): Delete la_print_typedef initializer.
1307         (cplus_language_data): Likewise.
1308         (asm_language_data): Likewise.
1309         (minimal_language_data): Likewise.
1310         * d-lang.c (d_language_data): Likewise.
1311         * f-lang.c (f_language_data): Likewise.
1312         (f_language::print_typedef): New member function.
1313         * go-lang.c (go_language_data): Delete la_print_typedef
1314         initializer.
1315         * language.c (language_defn::print_typedef): Define member
1316         function.
1317         (unknown_language_data): Delete la_print_typedef initializer.
1318         (unknown_language::print_typedef): New member function.
1319         (auto_language_data): Delete la_print_typedef initializer.
1320         (auto_language::print_typedef): New member function.
1321         * language.h (language_data): Delete la_print_typedef field.
1322         (language_defn::print_typedef): Declare new member function.
1323         (LA_PRINT_TYPEDEF): Update call to print_typedef.
1324         (default_print_typedef): Delete declaration.
1325         * m2-lang.c (m2_language_data): Delete la_print_typedef
1326         initializer.
1327         (m2_language::print_typedef): New member function.
1328         * objc-lang.c (objc_language_data): Delete la_print_typedef
1329         initializer.
1330         * opencl-lang.c (opencl_language_data): Likewise.
1331         * p-lang.c (pascal_language_data): Likewise.
1332         (pascal_language::print_typedef): New member function.
1333         * rust-lang.c (rust_print_typedef): Delete function,
1334         implementation moved to rust_language::print_typedef.
1335         (rust_language): Delete la_print_typedef initializer.
1336         (rust_language::print_typedef): New member function,
1337         implementation from rust_print_typedef.
1338         * typeprint.c (default_print_typedef): Delete.
1339
1340 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1341
1342         * ada-lang.c (ada_language_data): Delete la_printstr initializer.
1343         (ada_language::printstr): New member function.
1344         * c-lang.c (c_language_data): Delete la_printstr initializer.
1345         (cplus_language_data): Likewise.
1346         (asm_language_data): Likewise.
1347         (minimal_language_data): Likewise.
1348         * d-lang.c (d_language_data): Likewise.
1349         * f-lang.c (f_printstr): Rename to f_language::printstr.
1350         (f_language_data): Delete la_printstr initializer.
1351         (f_language::printstr): New member function, implementation from
1352         f_printstr.
1353         * go-lang.c (go_language_data): Delete la_printstr initializer.
1354         * language.c (language_defn::printstr): Define new member
1355         function.
1356         (unk_lang_printstr): Delete.
1357         (unknown_language_data): Delete la_printstr initializer.
1358         (unknown_language::printstr): New member function.
1359         (auto_language_data): Delete la_printstr initializer.
1360         (auto_language::printstr): New member function.
1361         * language.h (language_data): Delete la_printstr field.
1362         (language_defn::printstr): Declare new member function.
1363         (LA_PRINT_STRING): Update call to printstr.
1364         * m2-lang.c (m2_printstr): Rename to m2_language::printstr.
1365         (m2_language_data): Delete la_printstr initializer.
1366         (m2_language::printstr): New member function, implementation from
1367         m2_printstr.
1368         * objc-lang.c (objc_language_data): Delete la_printstr
1369         initializer.
1370         * opencl-lang.c (opencl_language_data): Likewise.
1371         * p-lang.c (pascal_printstr): Rename to pascal_language::printstr.
1372         (pascal_language_data): Delete la_printstr initializer.
1373         (pascal_language::printstr): New member function, implementation
1374         from pascal_printstr.
1375         * p-lang.h (pascal_printstr): Delete declaration.
1376         * rust-lang.c (rust_printstr): Update header comment.
1377         (rust_language_data): Delete la_printstr initializer.
1378         (rust_language::printstr): New member function.
1379
1380 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1381
1382         * ada-lang.c (ada_language_data): Delete la_printchar initializer.
1383         (ada_language::printchar): New member function.
1384         * c-lang.c (c_language_data): Delete la_printchar initializer.
1385         (cplus_language_data): Likewise.
1386         (asm_language_data): Likewise.
1387         (minimal_language_data): Likewise.
1388         * d-lang.c (d_language_data): Likewise.
1389         * f-lang.c (f_printchar): Rename to f_language::printchar.
1390         (f_language_data): Delete la_printchar initializer.
1391         (f_language::printchar): New member function, implementation from
1392         f_printchar.
1393         * go-lang.c (go_language_data): Delete la_printchar initializer.
1394         * language.c (unk_lang_printchar): Delete.
1395         (language_defn::printchar): Define new member function.
1396         (unknown_language_data): Delete la_printchar initializer.
1397         (unknown_language::printchar): New member function.
1398         (auto_language_data): Delete la_printchar initializer.
1399         (auto_language::printchar): New member function.
1400         * language.h (language_data): Delete la_printchar field.
1401         (language_defn::printchar): Declare new member function.
1402         (LA_PRINT_CHAR): Update call to printchar.
1403         * m2-lang.c (m2_language_data): Delete la_printchar initializer.
1404         (m2_language::printchar): New member function.
1405         * objc-lang.c (objc_language_data): Delete la_printchar
1406         initializer.
1407         * opencl-lang.c (opencl_language_data): Likewise.
1408         * p-lang.c (pascal_language_data): Delete la_printchar
1409         initializer.
1410         (pascal_language::printchar): New member function.
1411         * rust-lang.c (rust_printchar): Rename to
1412         rust_language::printchar.
1413         (rust_language_data): Delete la_printchar initializer.
1414         (rust_language::printchar): New member function, implementation
1415         from rust_printchar.
1416
1417 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1418
1419         * ada-lang.c (emit_char): Renamed to ada_language::emitchar.
1420         (ada_language_data): Delete la_emitchar initializer.
1421         (ada_language::emitchar): New member function, implementation from
1422         emit_char.
1423         * c-lang.c (c_language_data): Delete la_emitchar initializer.
1424         (cplus_language_data): Likewise.
1425         (asm_language_data): Likewise.
1426         (minimal_language_data): Likewise.
1427         * d-lang.c (d_language_data): Likewise.
1428         * f-lang.c (f_emit_char): Rename to f_language::emitchar.
1429         (f_language_data): Delete la_emitchar initializer.
1430         (f_language::emitchar): New member function, implementation from
1431         f_emit_char.
1432         * go-lang.c (go_language_data): Delete la_emitchar initializer.
1433         * language.c (unk_lang_emit_char): Delete.
1434         (language_defn::emitchar): New member function definition.
1435         (unknown_language_data): Delete la_emitchar initializer.
1436         (unknown_language::emitchar): New member function.
1437         (auto_language_data): Delete la_emitchar initializer.
1438         (auto_language::emitchar): New member function.
1439         * language.h (language_data): Delete la_emitchar field.
1440         (language_defn::emitchar): New member field declaration.
1441         (LA_EMIT_CHAR): Update call to emitchar.
1442         * m2-lang.c (m2_emit_char): Rename to m2_language::emitchar.
1443         (m2_language_data): Delete la_emitchar initializer.
1444         (m2_language::emitchar): New member function, implementation from
1445         m2_emit_char.
1446         * objc-lang.c (objc_language_data): Delete la_emitchar
1447         initializer.
1448         * opencl-lang.c (opencl_language_data): Likewise.
1449         * p-lang.c (pascal_emit_char): Rename to pascal_language::emitchar.
1450         (pascal_language_data): Delete la_emitchar initializer.
1451         (pascal_language::emitchar): New member function, implementation
1452         from pascal_emit_char.
1453         * rust-lang.c (rust_emitchar): Rename to rust_language::emitchar.
1454         (rust_language_data): Delete la_emitchar initializer.
1455         (rust_language::emitchar): New member function, implementation
1456         from rust_emitchar.
1457
1458 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1459
1460         * ada-lang.c (resolve): Rename to ada_language::post_parser.
1461         (ada_language_data): Delete la_post_parser initializer.
1462         (ada_language::post_parser): New member function.
1463         * c-lang.c (c_language_data): Delete la_post_parser initializer.
1464         (cplus_language_data): Likewise.
1465         (asm_language_data): Likewise.
1466         (minimal_language_data): Likewise.
1467         * d-lang.c (d_language_data): Likewise.
1468         * f-lang.c (f_language_data): Likewise.
1469         * go-lang.c (go_language_data): Likewise.
1470         * language.c (unknown_language_data): Likewise.
1471         (auto_language_data): Likewise.
1472         * language.h (language_data): Delete la_post_parser field.
1473         (language_defn::post_parser): New member function.
1474         * m2-lang.c (m2_language_data): Delete la_post_parser initializer.
1475         * objc-lang.c (objc_language_data): Likewise.
1476         * opencl-lang.c (opencl_language_data): Likewise.
1477         * p-lang.c (pascal_language_data): Likewise.
1478         * parse.c (parse_exp_in_context): Update call to post_parser.
1479         (null_post_parser): Delete definition.
1480         * parser-defs.h (null_post_parser): Delete declaration.
1481         * rust-lang.c (rust_language_data): Delete la_post_parser
1482         initializer.
1483
1484 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1485
1486         * ada-lang.c (parse): Rename to ada_language::parser.
1487         (ada_language_data): Delete la_parser initializer.
1488         (ada_language::parser): New member function, implementation from
1489         parse.
1490         * c-lang.c (c_language_data): Delete la_parser initializer.
1491         (cplus_language_data): Likewise.
1492         (asm_language_data): Likewise.
1493         (minimal_language_data): Likewise.
1494         * d-lang.c (d_language_data): Likewise.
1495         (d_language::parser): New member function.
1496         * f-lang.c (f_language_data): Delete la_parser initializer.
1497         (f_language::parser): New member function.
1498         * go-lang.c (go_language_data): Delete la_parser initializer.
1499         (go_language::parser): New member function.
1500         * language.c (unk_lang_parser): Delete.
1501         (language_defn::parser): Define new member function.
1502         (unknown_language_data): Delete la_parser initializer.
1503         (unknown_language::parser): New member function.
1504         (auto_language_data): Delete la_parser initializer.
1505         (auto_language::parser): New member function.
1506         * language.h (language_data): Delete la_parser field.
1507         (language_defn::parser): Declare new member function.
1508         * m2-lang.c (m2_language_data): Delete la_parser initializer.
1509         (m2_language::parser): New member function.
1510         * objc-lang.c (objc_language_data): Delete la_parser initializer.
1511         * opencl-lang.c (opencl_language_data): Likewise.
1512         * p-lang.c (pascal_language_data): Likewise.
1513         (pascal_language::parser): New member function.
1514         * parse.c (parse_exp_in_context): Update call to parser.
1515         * rust-lang.c (rust_language_data): Delete la_parser initializer.
1516         (rust_language::parser): New member function.
1517
1518 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1519
1520         * top.c (print_gdb_configuration): Print --with-python-libdir
1521         configuration value.
1522
1523 2020-06-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1524
1525         * NEWS: Mention change to the alias command.
1526
1527 2020-06-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1528
1529         * cli/cli-cmds.c (lookup_cmd_for_default_args)
1530         (alias_command_completer)
1531         (make_alias_options_def_group): New functions.
1532         (alias_opts, alias_option_defs): New struct and array.
1533         (alias_usage_error): Update usage.
1534         (alias_command): Handles optional DEFAULT-ARGS... arguments.
1535         Use option framework.
1536         (_initialize_cli_cmds): Update alias command help.
1537         Update aliases command help.
1538         (show_user):
1539         Add NULL for new default_args lookup_cmd argument.
1540         (valid_command_p): Rename to validate_aliased_command.
1541         Add NULL for new default_args lookup_cmd argument.  Verify that the
1542         aliased_command has no default args.
1543         * cli/cli-decode.c (help_cmd): Show aliases definitions.
1544         (lookup_cmd_1, lookup_cmd): New argument default_args.
1545         (add_alias_cmd):
1546         Add NULL for new default_args lookup_cmd argument.
1547         (print_help_for_command): Show default args under the layout
1548          alias some_alias = some_aliased_cmd some_alias_default_arg.
1549         * cli/cli-decode.h (struct cmd_list_element): New member default_args.
1550         xfree default_args in destructor.
1551         * cli/cli-script.c (process_next_line, do_define_command):
1552         Add NULL for new default_args lookup_cmd argument.
1553         * command.h: Declare new default_args argument in lookup_cmd
1554         and lookup_cmd_1.
1555         * completer.c (complete_line_internal_1):
1556         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
1557         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1558         * guile/scm-param.c (add_setshow_generic, pascm_parameter_defined_p):
1559         Likewise.
1560         * infcmd.c (_initialize_infcmd): Likewise.
1561         * python/py-auto-load.c (gdbpy_initialize_auto_load): Likewise.
1562         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1563         * python/py-param.c (add_setshow_generic): Likewise.
1564         * remote.c (_initialize_remote): Likewise.
1565         * top.c (execute_command): Prepend default_args if command has some.
1566         (set_verbose):
1567         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
1568         * tracepoint.c (validate_actionline, encode_actions_1):
1569         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
1570
1571 2020-06-22  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1572
1573         * jit.c (jit_read_descriptor): Use bool as the return type.
1574         (jit_breakpoint_re_set_internal): Use bool as the return type.
1575         Invert the return value logic; return true if the jit breakpoint
1576         has been successfully initialized.
1577         (jit_inferior_init): Update the call to
1578         jit_breakpoint_re_set_internal.
1579
1580 2020-06-22  Pedro Alves  <palves@redhat.com>
1581
1582         PR gdb/25939
1583         * procfs.c (procfs_target::wait): Don't reference inferior_ptid.
1584         Use the current inferior instead.  Don't return
1585         TARGET_WAITKIND_SPURIOUS/inferior_ptid -- instead continue and
1586         wait again.
1587         * sol-thread.c (sol_thread_target::wait): Don't reference
1588         inferior_ptid.
1589         (ps_lgetregs, ps_lsetregs, ps_lgetfpregs, ps_lsetfpregs)
1590         (sol_update_thread_list_callback): Use the current inferior's pid
1591         instead of inferior_ptid.
1592
1593 2020-06-21  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1594
1595         * procfs.c: Cleanup many comments.
1596
1597         (READ_WATCHFLAG, WRITE_WATCHFLAG, EXEC_WATCHFLAG)
1598         (AFTER_WATCHFLAG): Replace by value.
1599
1600         (MAIN_PROC_NAME_FORMAT): Inline ...
1601         (create_procinfo): ... here.
1602
1603         (procfs_debug_inferior): Remove SYS_exec handling.
1604         (syscall_is_exec): Likewise.
1605         (procfs_set_exec_trap): Likewise.
1606
1607         (syscall_is_lwp_exit): Inline in callers.
1608         (syscall_is_exit): Likewise.
1609         (syscall_is_exec): Likewise.
1610         (syscall_is_lwp_create): Likewise.
1611
1612         (invalidate_cache): Remove #if 0 code.
1613
1614         (make_signal_thread_runnable):  Remove.
1615         (procfs_target::resume): Remove #if 0 code.
1616
1617 2020-06-21  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1618
1619         PR gdb/25939
1620         * procfs.c (procfs_target::procfs_init_inferior): Move push_target
1621         call ...
1622         (procfs_target::create_inferior): ... here.
1623
1624 2020-06-21  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1625
1626         * exec.c (validate_exec_file): Ensure the build-id is up to
1627         date by calling reopen_exec_file (that checks file timestamp
1628         to decide to re-read the file).
1629
1630 2020-06-18  Pedro Alves  <palves@redhat.com>
1631
1632         PR gdb/25412
1633         * gdbthread.h (delete_thread, delete_thread_silent)
1634         (find_thread_ptid): Update comments.
1635         * thread.c (current_thread_): New global.
1636         (is_current_thread): Move higher, and reimplement.
1637         (inferior_thread): Reimplement.
1638         (set_thread_exited): Use bool.  Add assertions.
1639         (add_thread_silent): Simplify thread-reuse handling by always
1640         calling delete_thread.
1641         (delete_thread): Remove intro comment.
1642         (find_thread_ptid): Skip exited threads.
1643         (switch_to_thread_no_regs): Write to current_thread_.
1644         (switch_to_no_thread): Check CURRENT_THREAD_ instead of
1645         INFERIOR_PTID.  Clear current_thread_.
1646
1647 2020-06-18  Pedro Alves  <palves@redhat.com>
1648
1649         * aix-thread.c (pd_update): Use switch_to_thread.
1650
1651 2020-06-18  Pedro Alves  <palves@redhat.com>
1652
1653         * ravenscar-thread.c (ravenscar_thread_target): Update.
1654         (ravenscar_thread_target::update_inferior_ptid): Rename to ...
1655         (ravenscar_thread_target::add_active_thread): ... this.  Don't
1656         set m_base_ptid here.  Update to avoid referencing inferior_ptid.
1657         (ravenscar_thread_target::wait): Don't write to inferior_ptid.
1658
1659 2020-06-18  Pedro Alves  <palves@redhat.com>
1660
1661         * nat/windows-nat.c (current_windows_thread): Remove.
1662         * nat/windows-nat.h (current_windows_thread): Remove.
1663         * windows-nat.c (windows_nat_target::stopped_by_sw_breakpoint):
1664         Adjust.
1665         (display_selectors): Adjust to fetch the current
1666         windows_thread_info based on inferior_ptid.
1667         (fake_create_process): No longer write to current_windows_thread.
1668         (windows_nat_target::get_windows_debug_event):
1669         Don't set inferior_ptid or current_windows_thread.
1670         (windows_nat_target::wait): Adjust to not rely on
1671         current_windows_thread.
1672         (do_initial_windows_stuff): Now a method of windows_nat_target.
1673         Switch to the last_ptid thread.
1674         (windows_nat_target::attach): Adjust.
1675         (windows_nat_target::detach): Use switch_to_no_thread instead of
1676         writing to inferior_ptid directly.
1677         (windows_nat_target::create_inferior): Adjust.
1678
1679 2020-06-18  Pedro Alves  <palves@redhat.com>
1680
1681         * windows-nat.c (do_initial_windows_stuff): No longer set inferior_ptid.
1682
1683 2020-06-18  Pedro Alves  <palves@redhat.com>
1684
1685         * go32-nat.c (go32_nat_target::create_inferior): Switch to thread
1686         after creating it, instead of writing to inferior_ptid.  Don't
1687         write to inferior_ptid.
1688
1689 2020-06-18  Pedro Alves  <palves@redhat.com>
1690
1691         * fork-child.c (postfork_hook): Don't write to inferior_ptid.
1692
1693 2020-06-18  Pedro Alves  <palves@redhat.com>
1694
1695         * bsd-kvm.c (bsd_kvm_target_open): Switch to thread after adding
1696         it, instead of writing to inferior_ptid.
1697
1698 2020-06-18  Pedro Alves  <palves@redhat.com>
1699
1700         * btrace.c (btrace_fetch): Use switch_to_thread instead of writing
1701         to inferior_ptid.
1702
1703 2020-06-18  Pedro Alves  <palves@redhat.com>
1704
1705         * bsd-kvm.c (bsd_kvm_target::close): Use switch_to_no_thread
1706         instead of writing to inferior_ptid directly.
1707
1708 2020-06-18  Pedro Alves  <palves@redhat.com>
1709
1710         * corelow.c (core_target::close): Use switch_to_no_thread instead
1711         of writing to inferior_ptid directly.
1712         (add_to_thread_list, core_target_open): Use switch_to_thread
1713         instead of writing to inferior_ptid directly.
1714
1715 2020-06-18  Pedro Alves  <palves@redhat.com>
1716
1717         * darwin-nat.c (darwin_nat_target::decode_message): Don't write to
1718         inferior_ptid.
1719         (darwin_nat_target::stop_inferior, darwin_nat_target::kill): Avoid
1720         inferior_ptid.
1721         (darwin_attach_pid): Use switch_to_no_thread instead of writing to
1722         inferior_ptid directly.
1723         (darwin_nat_target::init_thread_list): Switch to thread, instead
1724         of writing to inferior_ptid.
1725         (darwin_nat_target::attach): Don't write to inferior_ptid.
1726         (darwin_nat_target::get_ada_task_ptid): Avoid inferior_ptid.
1727
1728 2020-06-18  Pedro Alves  <palves@redhat.com>
1729
1730         * gnu-nat.c (gnu_nat_target::create_inferior): Switch to the added
1731         thread.
1732         (gnu_nat_target::attach): Don't write to inferior_ptid directly.
1733         Instead use switch_to_thread.
1734         (gnu_nat_target::detach): Use switch_to_no_thread
1735         instead of writing to inferior_ptid directly.  Used passed-in
1736         inferior instead of looking up the inferior by pid.
1737
1738 2020-06-18  Pedro Alves  <palves@redhat.com>
1739
1740         * go32-nat.c (go32_nat_target::create_inferior): Don't write to
1741         inferior_ptid.
1742
1743 2020-06-18  Pedro Alves  <palves@redhat.com>
1744
1745         * nto-procfs.c (nto_procfs_target::update_thread_list): Avoid
1746         inferior_ptid.
1747         (nto_procfs_target::attach): Avoid inferior_ptid.  Switch to
1748         thread.
1749         (nto_procfs_target::detach): Avoid referencing
1750         inferior_ptid.  Use switch_to_no_thread instead of writing to
1751         inferior_ptid directly.
1752         (nto_procfs_target::mourn_inferior): Use switch_to_no_thread
1753         instead of writing to inferior_ptid directly.
1754         (nto_procfs_target::create_inferior): Avoid inferior_ptid.  Switch
1755         to thread.
1756
1757 2020-06-18  Pedro Alves  <palves@redhat.com>
1758
1759         * remote-sim.c (gdbsim_target::create_inferior): Switch to thread
1760         after creating it, instead of writing to inferior_ptid.
1761         (gdbsim_target_open): Use switch_to_no_thread instead of writing
1762         to inferior_ptid directly.
1763         (gdbsim_target::wait): Don't write to inferior_ptid.
1764
1765 2020-06-18  Pedro Alves  <palves@redhat.com>
1766
1767         * remote.c (remote_target::remote_notice_new_inferior): Use
1768         switch_to_thread instead of writing to inferior_ptid directly.
1769         (remote_target::add_current_inferior_and_thread): Use
1770         switch_to_no_thread instead of writing to inferior_ptid directly.
1771         (extended_remote_target::attach): Use switch_to_inferior_no_thread
1772         and switch_to_thread instead of using set_current_inferior or
1773         writing to inferior_ptid directly.
1774
1775 2020-06-18  Pedro Alves  <palves@redhat.com>
1776
1777         * tracectf.c (ctf_target_open): Switch to added thread instead of
1778         writing to inferior_ptid directly.
1779         (ctf_target::close): Use switch_to_no_thread instead of writing to
1780         inferior_ptid directly.
1781
1782 2020-06-18  Pedro Alves  <palves@redhat.com>
1783
1784         * tracefile-tfile.c (tfile_target_open): Don't write to
1785         inferior_ptid directly, instead switch to added thread.
1786         (tfile_target::close): Use switch_to_no_thread instead of writing
1787         to inferior_ptid directly.
1788
1789 2020-06-18  Pedro Alves  <palves@redhat.com>
1790
1791         * procfs.c (procfs_target::attach): Don't write to inferior_ptid.
1792         (procfs_target::detach): Use switch_to_no_thread
1793         instead of writing to inferior_ptid directly.
1794         (do_attach): Change return type to void.  Switch to the added
1795         thread.
1796         (procfs_target::create_inferior): Switch to the added thread.
1797         (procfs_do_thread_registers): Don't write to inferior_ptid.
1798
1799 2020-06-18  Pedro Alves  <palves@redhat.com>
1800
1801         * infrun.c (generic_mourn_inferior): Use switch_to_thread instead
1802         of writing to inferior_ptid.
1803         (scoped_restore_exited_inferior): Delete.
1804         (handle_vfork_child_exec_or_exit): Simplify using
1805         scoped_restore_current_pspace_and_thread.  Use switch_to_thread
1806         instead of writing to inferior_ptid.
1807         (THREAD_STOPPED_BY): Delete.
1808         (thread_stopped_by_watchpoint, thread_stopped_by_sw_breakpoint)
1809         (thread_stopped_by_hw_breakpoint): Delete.
1810         (save_waitstatus): Use
1811         scoped_restore_current_thread+switch_to_thread, and call
1812         target_stopped_by_watchpoint instead of
1813         thread_stopped_by_watchpoint, target_stopped_by_sw_breakpoint
1814         instead of thread_stopped_by_sw_breakpoint, and
1815         target_stopped_by_hw_breakpoint instead of
1816         thread_stopped_by_hw_breakpoint.
1817         (handle_inferior_event)
1818         <TARGET_WAITKIND_EXITED/TARGET_WAITKIND_SIGNALLED>: Don't write to
1819         inferior_ptid directly, nor
1820         set_current_inferior/set_current_program_space.  Use
1821         switch_to_thread / switch_to_inferior_no_thread instead.
1822
1823 2020-06-18  Pedro Alves  <palves@redhat.com>
1824
1825         * target.c (generic_mourn_inferior): Use switch_to_no_thread
1826         instead of writing to inferior_ptid.
1827
1828 2020-06-18  Pedro Alves  <palves@redhat.com>
1829
1830         * inf-ptrace.c (inf_ptrace_target::create_inferior): Switch to the
1831         added thread.
1832         (inf_ptrace_target::attach): Don't write to inferior_ptid.  Switch
1833         to the added thread.
1834         (inf_ptrace_target::detach_success): Use switch_to_no_thread
1835         instead of writing to inferior_ptid.
1836
1837 2020-06-18  Pedro Alves  <palves@redhat.com>
1838
1839         * gdbarch-selftests.c: Include "progspace-and-thread.h".
1840         (register_to_value_test): Mock a program_space too.  Heap-allocate
1841         the address space.  Don't write to inferior_ptid.  Use
1842         switch_to_thread instead.
1843
1844 2020-06-18  Pedro Alves  <palves@redhat.com>
1845
1846         * linux-tdep.c (find_signalled_thread(thread_info *,void *)):
1847         Delete.
1848         (find_signalled_thread()): New, factored out from
1849         linux_make_corefile_notes and adjusted to handle exited threads.
1850         (linux_make_corefile_notes): Adjust to use the new
1851         find_signalled_thread.
1852
1853 2020-06-18  Pedro Alves  <palves@redhat.com>
1854
1855         * linux-tdep.c (btrace_fetch): Save/restore current thread instead
1856         of saving/restoring inferior_ptid.
1857
1858 2020-06-17  Tom Tromey  <tom@tromey.com>
1859
1860         * tui/tui-win.h (tui_scroll_forward, tui_scroll_backward)
1861         (tui_scroll_left, tui_scroll_right, struct tui_win_info): Don't
1862         declare.
1863         * tui/tui-data.h (MIN_CMD_WIN_HEIGHT): Remove.
1864
1865 2020-06-15  Simon Marchi  <simon.marchi@efficios.com>
1866
1867         * dwarf2/read.c (dwarf2_initialize_objfile): Check for presence
1868         of partial symtabs.
1869
1870 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
1871
1872         * regformats/reg-arm.dat: Remove.
1873         * regformats/reg-bfin.dat: Remove.
1874         * regformats/reg-cris.dat: Remove.
1875         * regformats/reg-crisv32.dat: Remove.
1876         * regformats/reg-m32r.dat: Remove.
1877         * regformats/reg-tilegx.dat: Remove.
1878         * regformats/reg-tilegx32.dat: Remove.
1879
1880 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
1881
1882         * features/Makefile (WHICH): Remove arm files.
1883         * regformats/arm/arm-with-iwmmxt.dat: Remove.
1884         * regformats/arm/arm-with-neon.dat: Remove.
1885         * regformats/arm/arm-with-vfpv2.dat: Remove.
1886         * regformats/arm/arm-with-vfpv3.dat: Remove.
1887
1888 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
1889
1890         * features/Makefile (XMLTOC): Remove rx.xml.
1891
1892 2020-06-17  Pedro Alves  <palves@redhat.com>
1893
1894         * gdbthread.h (thread_control_state) <trap_expected> Update
1895         comments.
1896
1897 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1898
1899         * ada-lang.c (ada_lookup_symbol_nonlocal): Rename to
1900         ada_language::lookup_symbol_nonlocal.
1901         (ada_language_data): Delete la_lookup_symbol_nonlocal initializer.
1902         (ada_language::lookup_symbol_nonlocal): New member function,
1903         implementation from ada_lookup_symbol_nonlocal.
1904         * c-lang.c (c_language_data): Delete la_lookup_symbol_nonlocal
1905         initializer.
1906         (cplus_language_data): Delete la_lookup_symbol_nonlocal
1907         initializer.
1908         (cplus_language::lookup_symbol_nonlocal): New member function.
1909         (asm_language_data): Delete la_lookup_symbol_nonlocal initializer.
1910         (minimal_language_data) Likewise.
1911         * cp-namespace.c (cp_lookup_nested_symbol): Update comment.
1912         * d-lang.c (d_language_data): Delete la_lookup_symbol_nonlocal
1913         initializer.
1914         (d_language::lookup_symbol_nonlocal): New member function.
1915         * f-lang.c (f_language_data): Delete la_lookup_symbol_nonlocal
1916         initializer.
1917         (f_language::lookup_symbol_nonlocal): New member function.
1918         * go-lang.c (go_language_data): Delete la_lookup_symbol_nonlocal
1919         initializer.
1920         * language.c (unknown_language_data): Likewise.
1921         (auto_language_data): Likewise.
1922         * language.h (language_data): Delete la_lookup_symbol_nonlocal
1923         field.
1924         (language_defn::lookup_symbol_nonlocal): New member function.
1925         * m2-lang.c (m2_language_data): Delete la_lookup_symbol_nonlocal
1926         initializer.
1927         * objc-lang.c (objc_language_data): Likewise.
1928         * opencl-lang.c (opencl_language_data): Likewise.
1929         * p-lang.c (pascal_language_data): Likewise.
1930         * rust-lang.c (rust_lookup_symbol_nonlocal): Rename to
1931         rust_language::lookup_symbol_nonlocal.
1932         (rust_language_data): Delete la_lookup_symbol_nonlocal
1933         initializer.
1934         (rust_language::lookup_symbol_nonlocal): New member function,
1935         implementation from rust_lookup_symbol_nonlocal.
1936         * symtab.c (lookup_symbol_aux): Update call to
1937         lookup_symbol_nonlocal.
1938         (basic_lookup_symbol_nonlocal): Rename to...
1939         (language_defn::lookup_symbol_nonlocal): ...this, and update
1940         header comment.  Remove language_defn parameter, and replace with
1941         uses of `this'.
1942         * symtab.h (basic_lookup_symbol_nonlocal): Delete declaration.
1943
1944 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1945
1946         * ada-lang.c (ada_language_data): Delete la_value_print_inner
1947         initializer.
1948         (ada_language::value_print_inner): New member function.
1949         * c-lang.c (c_language_data): Delete la_value_print_inner
1950         initializer.
1951         (cplus_language_data): Likewise.
1952         (asm_language_data): Likewise.
1953         (minimal_language_data): Likewise.
1954         * d-lang.c (d_language_data): Likewise.
1955         (d_language::value_print_inner): New member function.
1956         * f-lang.c (f_language_data): Delete la_value_print_inner
1957         initializer.
1958         (f_language::value_print_inner): New member function.
1959         * f-lang.h (f_value_print_innner): Rename to...
1960         (f_value_print_inner): ...this (note spelling of 'inner').
1961         * f-valprint.c (f_value_print_innner): Rename to...
1962         (f_value_print_inner): ...this (note spelling of 'inner').
1963         * go-lang.c (go_language_data): Delete la_value_print_inner
1964         initializer.
1965         (go_language::value_print_inner): New member function.
1966         * language.c (language_defn::value_print_inner): Define new member
1967         function.
1968         (unk_lang_value_print_inner): Delete.
1969         (unknown_language_data): Delete la_value_print_inner initializer.
1970         (unknown_language::value_print_inner): New member function.
1971         (auto_language_data): Delete la_value_print_inner initializer.
1972         (auto_language::value_print_inner): New member function.
1973         * language.h (language_data): Delete la_value_print_inner field.
1974         (language_defn::value_print_inner): Delcare new member function.
1975         * m2-lang.c (m2_language_data): Delete la_value_print_inner
1976         initializer.
1977         (m2_language::value_print_inner): New member function.
1978         * objc-lang.c (objc_language_data): Delete la_value_print_inner
1979         initializer.
1980         * opencl-lang.c (opencl_language_data): Likewise.
1981         * p-lang.c (pascal_language_data): Likewise.
1982         (pascal_language::value_print_inner): New member function.
1983         * rust-lang.c (rust_language_data): Delete la_value_print_inner
1984         initializer.
1985         (rust_language::value_print_inner): New member function.
1986         * valprint.c (do_val_print): Update call to value_print_inner.
1987
1988 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1989
1990         * ada-lang.c (ada_language_data): Delete la_value_print
1991         initializer.
1992         (ada_language::value_print): New member function.
1993         * c-lang.c (c_language_data): Delete la_value_print initializer.
1994         (cplus_language_data): Likewise.
1995         (asm_language_data): Likewise.
1996         (minimal_language_data): Likewise.
1997         * d-lang.c (d_language_data): Likewise.
1998         * f-lang.c (f_language_data): Likewise.
1999         * go-lang.c (go_language_data): Likewise.
2000         * language.c (unk_lang_value_print): Delete.
2001         (language_defn::value_print): Define new member function.
2002         (unknown_language_data): Delete la_value_print initializer.
2003         (unknown_language::value_print): New member function.
2004         (auto_language_data): Delete la_value_print initializer.
2005         (auto_language::value_print): New member function.
2006         * language.h (language_data): Delete la_value_print field.
2007         (language_defn::value_print): Declare new member function.
2008         (LA_VALUE_PRINT): Update call to value_print.
2009         * m2-lang.c (m2_language_data): Delete la_value_print initializer.
2010         * objc-lang.c (objc_language_data): Likewise.
2011         * opencl-lang.c (opencl_language_data): Likewise.
2012         * p-lang.c (pascal_language_data): Likewise.
2013         (pascal_language::value_print): New member function.
2014         * rust-lang.c (rust_language_data): Delete la_value_print
2015         initializer.
2016
2017 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2018
2019         * ada-lang.c (ada_watch_location_expression): Rename to
2020         ada_language::watch_location_expression.
2021         (ada_language_data): Delete la_watch_location_expression
2022         initializer.
2023         (ada_language::watch_location_expression): New member function,
2024         implementation from ada_watch_location_expression.
2025         * breakpoint.c (watch_command_1): Update call to
2026         watch_location_expression.
2027         * c-lang.c (c_watch_location_expression): Rename to
2028         language_defn::watch_location_expression.
2029         (c_language_data): Delete la_watch_location_expression
2030         initializer.
2031         (cplus_language_data): Likewise.
2032         (asm_language_data): Likewise.
2033         (minimal_language_data): Likewise.
2034         * c-lang.h (c_watch_location_expression): Delete declaration.
2035         * d-lang.c (d_language_data): Delete la_watch_location_expression
2036         initializer.
2037         * f-lang.c (f_language_data): Likewise.
2038         * go-lang.c (go_language_data): Likewise.
2039         * language.c (language_defn::watch_location_expression): Member
2040         function implementation from c_watch_location_expression.
2041         (unknown_language_data): Delete la_watch_location_expression
2042         initializer.
2043         (auto_language_data): Likewise.
2044         * language.h (language_data): Delete la_watch_location_expression
2045         field.
2046         (language_defn::watch_location_expression): Declare new member
2047         function.
2048         * m2-lang.c (m2_language_data): Delete
2049         la_watch_location_expression initializer.
2050         * objc-lang.c (objc_language_data): Likewise.
2051         * opencl-lang.c (opencl_language_data): Likewise.
2052         * p-lang.c (pascal_language_data): Likewise.
2053         * rust-lang.c (rust_watch_location_expression): Rename to
2054         rust_language::watch_location_expression.
2055         (rust_language_data): Delete la_watch_location_expression
2056         initializer.
2057         (rust_language::watch_location_expression): New member function,
2058         implementation from rust_watch_location_expression.
2059
2060 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2061
2062         * ada-lang.c (ada_collect_symbol_completion_matches): Rename to
2063         ada_language::collect_symbol_completion_matches.
2064         (ada_language_data): Delete la_collect_symbol_completion_matches
2065         initializer.
2066         (ada_language::collect_symbol_completion_matches): New member
2067         function, implementation from
2068         ada_collect_symbol_completion_matches.
2069         * c-lang.c (c_language_data): Delete
2070         la_collect_symbol_completion_matches initializer.
2071         (cplus_language_data): Likewise.
2072         (asm_language_data): Likewise.
2073         (minimal_language_data): Likewise.
2074         * d-lang.c (d_language_data): Likewise.
2075         * f-lang.c (f_collect_symbol_completion_matches): Rename to
2076         f_language::collect_symbol_completion_matches.
2077         (f_language_data): Delete la_collect_symbol_completion_matches
2078         initializer.
2079         (f_language::collect_symbol_completion_matches) New member
2080         function, implementation from f_collect_symbol_completion_matches.
2081         * go-lang.c (go_language_data): Delete
2082         la_collect_symbol_completion_matches initializer.
2083         * language.c (unknown_language_data): Likewise.
2084         (auto_language_data): Likewise.
2085         * language.h (language_data): Delete
2086         la_collect_symbol_completion_matches field.
2087         (language_defn::collect_symbol_completion_matches): New member
2088         function.
2089         * m2-lang.c (m2_language_data): Delete
2090         la_collect_symbol_completion_matches initializer.
2091         * objc-lang.c (objc_language_data): Likewise.
2092         * opencl-lang.c (opencl_language_data): Likewise.
2093         * p-lang.c (pascal_language_data): Likewise.
2094         * rust-lang.c (rust_language_data): Likewise.
2095         * symtab.c (default_collect_symbol_completion_matches): Delete.
2096         (collect_symbol_completion_matches): Update call to
2097         collect_symbol_completion_matches.
2098         (collect_symbol_completion_matches_type): Likewise.
2099         * symtab.h (default_collect_symbol_completion_matches): Delete
2100         declaration.
2101
2102 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2103
2104         * ada-lang.c (ada_get_gdb_completer_word_break_characters): Delete.
2105         (ada_language_data): Delete la_word_break_characters initializer.
2106         (ada_language::word_break_characters): New member function.
2107         * c-lang.c (c_language_data): Delete la_word_break_characters
2108         initializer.
2109         (cplus_language_data): Likewise.
2110         (asm_language_data): Likewise.
2111         (minimal_language_data): Likewise.
2112         * completer.c: Update global comment.
2113         (advance_to_expression_complete_word_point): Update call to
2114         word_break_characters.
2115         (complete_files_symbols): Likewise.
2116         (complete_line_internal_1): Likewise.
2117         (default_completer_handle_brkchars): Likewise.
2118         (skip_quoted_chars): Likewise.
2119         * d-lang.c (d_language_data): Delete la_word_break_characters
2120         initializer.
2121         * f-lang.c (f_word_break_characters): Delete.
2122         (f_language_data): Delete la_word_break_characters initializer.
2123         (f_language::word_break_characters): New member function.
2124         * go-lang.c (go_language_data): Delete la_word_break_characters
2125         initializer.
2126         * language.c (unknown_language_data): Likewise.
2127         (auto_language_data): Likewise.
2128         * language.h (default_word_break_characters): Move declaration to
2129         earlier in the file.
2130         (language_data): Delete la_word_break_characters field.
2131         (language_defn::word_break_characters): New member function.
2132         * m2-lang.c (m2_language_data): Delete la_word_break_characters
2133         initializer.
2134         * objc-lang.c (objc_language_data): Likewise.
2135         * opencl-lang.c (opencl_language_data): Likewise.
2136         * p-lang.c (pascal_language_data): Likewise.
2137         * rust-lang.c (rust_language_data): Likewise.
2138
2139 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2140
2141         * ada-lang.c (ada_get_symbol_name_matcher): Update header comment.
2142         (ada_language_data): Delete la_get_symbol_name_matcher
2143         initializer.
2144         (language_defn::get_symbol_name_matcher_inner): New member
2145         function.
2146         * c-lang.c (c_language_data): Delete la_get_symbol_name_matcher
2147         initializer.
2148         (cplus_language_data): Likewise.
2149         (cplus_language::get_symbol_name_matcher_inner): New member
2150         function.
2151         (asm_language_data): Delete la_get_symbol_name_matcher initializer.
2152         (minimal_language_data): Likewise.
2153         * cp-support.h (cp_get_symbol_name_matcher): Update header comment.
2154         * d-lang.c (d_language_data): Delete la_get_symbol_name_matcher
2155         initializer.
2156         * dictionary.c (iter_match_first_hashed): Update call to
2157         get_symbol_name_matcher.
2158         (iter_match_next_hashed): Likewise.
2159         (iter_match_next_linear): Likewise.
2160         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Likewise.
2161         * f-lang.c (f_language_data): Delete la_get_symbol_name_matcher
2162         initializer.
2163         (f_language::get_symbol_name_matcher_inner): New member function.
2164         * go-lang.c (go_language_data): Delete la_get_symbol_name_matcher
2165         initializer.
2166         * language.c (default_symbol_name_matcher): Update header comment,
2167         make static.
2168         (language_defn::get_symbol_name_matcher): New definition.
2169         (language_defn::get_symbol_name_matcher_inner): Likewise.
2170         (get_symbol_name_matcher): Delete.
2171         (unknown_language_data): Delete la_get_symbol_name_matcher
2172         initializer.
2173         (auto_language_data): Likewise.
2174         * language.h (language_data): Delete la_get_symbol_name_matcher
2175         field.
2176         (language_defn::get_symbol_name_matcher): New member function.
2177         (language_defn::get_symbol_name_matcher_inner): Likewise.
2178         (default_symbol_name_matcher): Delete declaration.
2179         * linespec.c (find_methods): Update call to
2180         get_symbol_name_matcher.
2181         * m2-lang.c (m2_language_data): Delete la_get_symbol_name_matcher
2182         initializer.
2183         * minsyms.c (lookup_minimal_symbol): Update call to
2184         get_symbol_name_matcher.
2185         (iterate_over_minimal_symbols): Likewise.
2186         * objc-lang.c (objc_language_data): Delete
2187         la_get_symbol_name_matcher initializer.
2188         * opencl-lang.c (opencl_language_data): Likewise.
2189         * p-lang.c (pascal_language_data): Likewise.
2190         * psymtab.c (psymbol_name_matches): Update call to
2191         get_symbol_name_matcher.
2192         * rust-lang.c (rust_language_data): Delete
2193         la_get_symbol_name_matcher initializer.
2194         * symtab.c (symbol_matches_search_name): Update call to
2195         get_symbol_name_matcher.
2196         (compare_symbol_name): Likewise.
2197
2198 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2199
2200         * ada-lang.c (ada_language_data): Delete la_compute_program
2201         initializer.
2202         * c-lang.c (c_language_data): Likewise.
2203         (c_language::compute_program): New member function.
2204         (cplus_language_data): Delete la_compute_program initializer.
2205         (cplus_language::compute_program): New member function.
2206         (asm_language_data): Delete la_compute_program initializer.
2207         (minimal_language_data): Likewise.
2208         * c-lang.h (c_compute_program): Update comment.
2209         (cplus_compute_program): Likewise.
2210         * compile/compile-c-support.c (c_compute_program): Likewise.
2211         (cplus_compute_program): Likewise.
2212         * compile/compile.c (compile_to_object): Update call to
2213         la_compute_program.
2214         * d-lang.c (d_language_data): Delete la_compute_program
2215         initializer.
2216         * f-lang.c (f_language_data): Likewise.
2217         * go-lang.c (go_language_data): Likewise.
2218         * language.c (unknown_language_data): Likewise.
2219         (auto_language_data): Likewise.
2220         * language.h (language_data): Delete la_compute_program field.
2221         (language_defn::compute_program): New member function.
2222         * m2-lang.c (m2_language_data): Delete la_compute_program
2223         initializer.
2224         * objc-lang.c (objc_language_data): Likewise.
2225         * opencl-lang.c (opencl_language_data): Likewise.
2226         * p-lang.c (pascal_language_data): Likewise.
2227         * rust-lang.c (rust_language_data): Likewise.
2228
2229 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2230
2231         * ada-lang.c (ada_language_data) Delete
2232         la_class_name_from_physname initializer.
2233         * c-lang.c (c_language_data): Likewise.
2234         (cplus_language_data): Likewise.
2235         (cplus_language::class_name_from_physname): New member function.
2236         (asm_language_data): Delete la_class_name_from_physname
2237         initializer.
2238         (minimal_language_data): Likewise.
2239         * d-lang.c (d_language_data): Likewise.
2240         * dwarf2/read.c (guess_partial_die_structure_name): Update to call
2241         method on language_defn class.
2242         (guess_full_die_structure_name): Likewise.
2243         * f-lang.c (f_language_data): Delete la_class_name_from_physname
2244         initializer.
2245         * go-lang.c (go_language_data): Likewise.
2246         * language.c (language_class_name_from_physname): Delete.
2247         (unk_lang_class_name): Delete.
2248         (unknown_language_data): Delete la_class_name_from_physname
2249         initializer.
2250         (auto_language_data): Likewise.
2251         * language.h (language_data): Delete la_class_name_from_physname
2252         field.
2253         (language_defn::class_name_from_physname): New function.
2254         (language_class_name_from_physname): Delete declaration.
2255         * m2-lang.c (m2_language_data): Delete la_class_name_from_physname
2256         initializer.
2257         * objc-lang.c (objc_language_data): Likewise.
2258         * opencl-lang.c (opencl_language_data): Likewise.
2259         * p-lang.c (pascal_language_data): Likewise.
2260         * rust-lang.c (rust_language_data): Likewise.
2261
2262 2020-06-16  Tom Tromey  <tom@tromey.com>
2263
2264         * tui/tui-data.h (STATUS_NAME): New macro.
2265         * tui/tui-layout.c (tui_remove_some_windows)
2266         (initialize_known_windows, tui_register_window)
2267         (tui_layout_split::remove_windows, initialize_layouts)
2268         (tui_new_layout_command): Don't use hard-coded window names.
2269
2270 2020-06-16  Tom Tromey  <tom@tromey.com>
2271
2272         PR tui/25348:
2273         * tui/tui.c (tui_ensure_readline_initialized): Rename from
2274         tui_initialize_readline.  Only run once.  Call rl_initialize.
2275         * tui/tui.h (tui_ensure_readline_initialized): Rename from
2276         tui_initialize_readline.
2277         * tui/tui-io.c (tui_setup_io): Call
2278         tui_ensure_readline_initialized.
2279         * tui/tui-interp.c (tui_interp::init): Update.
2280
2281 2020-06-16  Tom Tromey  <tom@tromey.com>
2282
2283         * tui/tui-layout.c (tui_layout_split::remove_windows): Fix logic.
2284         Also preserve the status window.
2285
2286 2020-06-16  Tom Tromey  <tom@tromey.com>
2287
2288         * python/py-tui.c (tui_py_window::~tui_py_window): Handle case
2289         where m_window==nullptr.
2290
2291 2020-06-15  Tom Tromey  <tromey@adacore.com>
2292
2293         * windows-nat.c (windows_nat::handle_output_debug_string):
2294         Update.
2295         (windows_nat::handle_ms_vc_exception): Update.
2296         * target.h (target_read_string): Change API.
2297         * target.c (target_read_string): Change API.
2298         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
2299         Update.
2300         * solib-frv.c (frv_current_sos): Update.
2301         * solib-dsbt.c (dsbt_current_sos): Update.
2302         * solib-darwin.c (darwin_current_sos): Update.
2303         * linux-thread-db.c (inferior_has_bug): Update.
2304         * expprint.c (print_subexp_standard): Update.
2305         * ada-lang.c (ada_main_name, ada_tag_name_from_tsd)
2306         (ada_exception_message_1): Update.
2307
2308 2020-06-15  Tom Tromey  <tromey@adacore.com>
2309
2310         * linux-tdep.c (dump_mapping_p): Use target_read_memory.
2311
2312 2020-06-15  Tom Tromey  <tromey@adacore.com>
2313
2314         * valprint.c (read_string): Update comment.
2315         * target.c (MIN): Remove.
2316         (target_read_string): Rewrite.
2317
2318 2020-06-15  Tom Tromey  <tromey@adacore.com>
2319
2320         * corefile.c (read_memory_string): Remove.
2321         * ada-valprint.c (ada_value_print_ptr): Update.
2322         * ada-lang.h (ada_tag_name): Change return type.
2323         * ada-lang.c (type_from_tag): Update.
2324         (ada_tag_name_from_tsd): Change return type.  Use
2325         target_read_string.
2326         (ada_tag_name): Likewise.
2327         * gdbcore.h (read_memory_string): Don't declare.
2328
2329 2020-06-14  Hannes Domani  <ssbssa@yahoo.de>
2330
2331         * symtab.c (rbreak_command): Ignore Windows drive colon.
2332
2333 2020-06-12  Simon Marchi  <simon.marchi@efficios.com>
2334
2335         * NEWS: Mention removed GDBserver host support.
2336
2337 2020-06-12  Nelson Chu  <nelson.chu@sifive.com>
2338
2339         * features/riscv/rebuild-csr-xml.sh: Updated.
2340
2341 2020-06-11  Tom Tromey  <tom@tromey.com>
2342
2343         PR gdb/18318:
2344         * c-exp.y (lex_one_token): Handle 'p' like 'e'.
2345
2346 2020-06-09  Jonny Grant  <jg@jguk.org>
2347 2020-06-09  Simon Marchi  <simon.marchi@polymtl.ca>
2348
2349         * main.c (captured_main_1): Don't print new line after help.
2350         (print_gdb_help): add mailing list and IRC channel information
2351         to --help.  Add new lines between items in the footer.  Remove
2352         quotes around bug url.
2353
2354 2020-06-11  Keith Seitz  <keiths@redhat.com>
2355
2356         PR gdb/21356
2357         * gdbtypes.c (resolve_dynamic_union, resolve_dynamic_struct):
2358         Resolve typedefs for type length calculations.
2359
2360 2020-06-10  Tom de Vries  <tdevries@suse.de>
2361
2362         PR ada/24713
2363         * dwarf2/index-write.c (struct mapped_symtab): Add m_string_obstack.
2364         (write_psymbols): Enable .gdb_index for ada.
2365         * dwarf2/read.c: Remove comment stating .gdb_index is unsupported for
2366         ada.
2367
2368 2020-06-10  Tom de Vries  <tdevries@suse.de>
2369
2370         * dwarf2/read.c (dw2_symtab_iter_init_common): Factor out of ...
2371         (dw2_symtab_iter_init): ... here.  Add variant with "offset_type
2372         namei" instead of "const char *name" argument.
2373         (dw2_map_matching_symbols): Use "offset_type namei" variant of
2374         dw2_symtab_iter_init.
2375
2376 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
2377
2378         * gdbtypes.h (TYPE_FIELD_TYPE): Remove.  Change all call sites
2379         to use type::field and field::type instead.
2380
2381 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
2382
2383         * gdbtypes.h (FIELD_TYPE): Remove.  Change all call sites
2384         to use field::type instead.
2385
2386 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
2387
2388         * gdbtypes.h (struct field) <type, set_type>: New methods.
2389         Rename `type` field to...
2390         <m_type>: ... this.  Change references throughout to use type or
2391         set_type methods.
2392         (FIELD_TYPE): Use field::type.  Change call sites that modify
2393         the field's type to use field::set_type instead.
2394
2395 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
2396
2397         * gdbtypes.h (TYPE_INDEX_TYPE): Remove.  Change all call sites
2398         to use type::index_type instead.
2399
2400 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
2401
2402         * gdbtypes.h (struct type) <index_type, set_index_type>: New
2403         methods.
2404         (TYPE_INDEX_TYPE): Use type::index_type.
2405         * gdbtypes.c (create_array_type_with_stride): Likewise.
2406
2407 2020-06-07  Tom Tromey  <tom@tromey.com>
2408
2409         * valprint.c (generic_val_print_float): Remove "embedded_offset"
2410         parameter.
2411         (generic_value_print): Update.
2412
2413 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2414
2415         Revert commit 982a38f60b0.
2416         * python/py-tui.c (gdbpy_tui_set_title): Restore use of get.
2417
2418 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2419
2420         * python/py-tui.c (gdbpy_tui_set_title): Use release, not get, to
2421         avoid use after free.
2422
2423 2020-06-05  Tom de Vries  <tdevries@suse.de>
2424
2425         * NEWS: Fix typos.
2426
2427 2020-06-04  Simon Marchi  <simon.marchi@efficios.com>
2428
2429         * dwarf2/read.c (dwarf2_read_gdb_index): Save partial_symtabs in
2430         the per_bfd object.
2431         (dwarf2_read_debug_names): Likewise.
2432         (dwarf2_initialize_objfile): Use partial_symtabs from per_bfd
2433         object when re-using a per_bfd object with an index.
2434
2435 2020-06-03  Tom de Vries  <tdevries@suse.de>
2436
2437         PR symtab/26046
2438         * dwarf2/read.c (scan_partial_symbols): Recurse into DW_TAG_subprogram
2439         children for C++.
2440         (load_partial_dies): Don't skip DW_TAG_inlined_subroutine child of
2441         DW_TAG_subprogram.
2442
2443 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2444
2445         * ada-lang.c (ada_language_data): Delete skip_trampoline
2446         initializer.
2447         * c-lang.c (c_language_data): Likewise.
2448         (cplus_language_data): Likewise.
2449         (cplus_language::skip_trampoline): New member function.
2450         (asm_language_data): Delete skip_trampoline initializer.
2451         (minimal_language_data): Likewise.
2452         * d-lang.c (d_language_data): Likewise.
2453         * f-lang.c (f_language_data): Likewise.
2454         * go-lang.c (go_language_data): Likewise.
2455         * language.c (unk_lang_trampoline): Delete function.
2456         (skip_language_trampoline): Update.
2457         (unknown_language_data): Delete skip_trampoline initializer.
2458         (auto_language_data): Likewise.
2459         * language.h (language_data): Delete skip_trampoline field.
2460         (language_defn::skip_trampoline): New function.
2461         * m2-lang.c (m2_language_data): Delete skip_trampoline
2462         initializer.
2463         * objc-lang.c (objc_skip_trampoline): Delete function, move
2464         implementation to objc_language::skip_trampoline.
2465         (objc_language_data): Delete skip_trampoline initializer.
2466         (objc_language::skip_trampoline): New member function with
2467         implementation from objc_skip_trampoline.
2468         * opencl-lang.c (opencl_language_data): Delete skip_trampoline
2469         initializer.
2470         * p-lang.c (pascal_language_data): Likewise.
2471         * rust-lang.c (rust_language_data): Likewise.
2472
2473 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2474
2475         * ada-lang.c (ada_language_data): Delete la_demangle initializer.
2476         (ada_language::demangle): New member function.
2477         * c-lang.c (c_language_data): Delete la_demangle initializer.
2478         (cplus_language_data): Delete la_demangle initializer.
2479         (cplus_language::demangle): New member function.
2480         (asm_language_data): Delete la_demangle initializer.
2481         (minimal_language_data): Delete la_demangle initializer.
2482         * d-lang.c (d_language_data): Delete la_demangle initializer.
2483         (d_language::demangle): New member function.
2484         * f-lang.c (f_language_data): Delete la_demangle initializer.
2485         (f_language::demangle): New member function.
2486         * go-lang.c (go_language_data): Delete la_demangle initializer.
2487         (go_language::demangle): New member function.
2488         * language.c (language_demangle): Update.
2489         (unk_lang_demangle): Delete.
2490         (unknown_language_data): Delete la_demangle initializer.
2491         (unknown_language::demangle): New member function.
2492         (auto_language_data): Delete la_demangle initializer.
2493         (auto_language::demangle): New member function.
2494         * language.h (language_data): Delete la_demangle field.
2495         (language_defn::demangle): New function.
2496         * m2-lang.c (m2_language_data): Delete la_demangle initializer.
2497         * objc-lang.c (objc_language_data): Delete la_demangle
2498         initializer.
2499         (objc_language::demangle): New member function.
2500         * opencl-lang.c (opencl_language_data): Delete la_demangle
2501         initializer.
2502         * p-lang.c (pascal_language_data): Likewise.
2503         * rust-lang.c (rust_language_data): Likewise.
2504         (rust_language::demangle): New member function.
2505
2506 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2507
2508         * ada-lang.c (ada_language_data): Delete la_print_type
2509         initializer.
2510         (ada_language::print_type): New member function.
2511         * c-lang.c (c_language_data): Delete la_print_type initializer.
2512         (c_language::print_type): New member function.
2513         (cplus_language_data): Delete la_print_type initializer.
2514         (cplus_language::print_type): New member function.
2515         (asm_language_data): Delete la_print_type initializer.
2516         (asm_language::print_type): New member function.
2517         (minimal_language_data): Delete la_print_type initializer.
2518         (minimal_language::print_type): New member function.
2519         * d-lang.c (d_language_data): Delete la_print_type initializer.
2520         (d_language::print_type): New member function.
2521         * f-lang.c (f_language_data): Delete la_print_type initializer.
2522         (f_language::print_type): New member function.
2523         * go-lang.c (go_language_data): Delete la_print_type initializer.
2524         (go_language::print_type): New member function.
2525         * language.c (unk_lang_print_type): Delete.
2526         (unknown_language_data): Delete la_print_type initializer.
2527         (unknown_language::print_type): New member function.
2528         (auto_language_data): Delete la_print_type initializer.
2529         (auto_language::print_type): New member function.
2530         * language.h (language_data): Delete la_print_type field.
2531         (language_defn::print_type): New function.
2532         (LA_PRINT_TYPE): Update.
2533         * m2-lang.c (m2_language_data): Delete la_print_type initializer.
2534         (m2_language::print_type): New member function.
2535         * objc-lang.c (objc_language_data): Delete la_print_type
2536         initializer.
2537         (objc_language::print_type): New member function.
2538         * opencl-lang.c (opencl_print_type): Delete, implementation moved
2539         to opencl_language::print_type.
2540         (opencl_language_data): Delete la_print_type initializer.
2541         (opencl_language::print_type): New member function, implementation
2542         from opencl_print_type.
2543         * p-lang.c (pascal_language_data): Delete la_print_type
2544         initializer.
2545         (pascal_language::print_type): New member function.
2546         * rust-lang.c (rust_print_type): Delete, implementation moved to
2547         rust_language::print_type.
2548         (rust_language_data): Delete la_print_type initializer.
2549         (rust_language::print_type): New member function, implementation
2550         from rust_print_type.
2551
2552 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2553
2554         * ada-lang.c (ada_sniff_from_mangled_name): Delete function,
2555         implementation moves to...
2556         (ada_language::sniff_from_mangled_name): ...here.  Update return
2557         type.
2558         (ada_language_data): Delete la_sniff_from_mangled_name
2559         initializer.
2560         * c-lang.c (c_language_data): Likewise.
2561         (cplus_language_data): Likewise.
2562         (cplus_language::sniff_from_mangled_name): New member function,
2563         implementation taken from gdb_sniff_from_mangled_name.
2564         (asm_language_data): Delete la_sniff_from_mangled_name
2565         initializer.
2566         (minimal_language_data): Likewise.
2567         * cp-support.c (gdb_sniff_from_mangled_name): Delete,
2568         implementation moves to cplus_language::sniff_from_mangled_name.
2569         * cp-support.h (gdb_sniff_from_mangled_name): Delete declaration.
2570         * d-lang.c (d_sniff_from_mangled_name): Delete, implementation
2571         moves to...
2572         (d_language::sniff_from_mangled_name): ...here.
2573         (d_language_data): Delete la_sniff_from_mangled_name initializer.
2574         * f-lang.c (f_language_data): Likewise.
2575         * go-lang.c (go_sniff_from_mangled_name): Delete, implementation
2576         moves to...
2577         (go_language::sniff_from_mangled_name): ...here.
2578         (go_language_data): Delete la_sniff_from_mangled_name initializer.
2579         * language.c (language_sniff_from_mangled_name): Delete.
2580         (unknown_language_data): Delete la_sniff_from_mangled_name
2581         initializer.
2582         (auto_language_data): Likewise.
2583         * language.h (language_data): Delete la_sniff_from_mangled_name
2584         field.
2585         (language_defn::sniff_from_mangled_name): New function.
2586         (language_sniff_from_mangled_name): Delete declaration.
2587         * m2-lang.c (m2_language_data): Delete la_sniff_from_mangled_name
2588         field.
2589         * objc-lang.c (objc_sniff_from_mangled_name): Delete,
2590         implementation moves to...
2591         (objc_language::sniff_from_mangled_name): ...here.
2592         (objc_language_data): Delete la_sniff_from_mangled_name initializer.
2593         * opencl-lang.c (opencl_language_data): Likewise.
2594         * p-lang.c (pascal_language_data): Likewise.
2595         * rust-lang.c (rust_sniff_from_mangled_name): Delete,
2596         implementation moves to...
2597         (rust_language::sniff_from_mangled_name): ...here.
2598         (rust_language_data): Delete la_sniff_from_mangled_name
2599         initializer.
2600         * symtab.c (symbol_find_demangled_name): Call
2601         sniff_from_mangled_name member function.
2602
2603 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2604
2605         * ada-lang.c (ada_language_data): Delete la_search_name_hash
2606         initializer.
2607         * c-lang.c (c_language_data): Likewise.
2608         (cplus_language_data): Likewise.
2609         (cplus_language::search_name_hash): New member function.
2610         (asm_language_data): Delete la_search_name_hash initializer.
2611         (minimal_language_data): Likewise.
2612         * d-lang.c (d_language_data): Likewise.
2613         * dictionary.c (default_search_name_hash): Rename to...
2614         (language_defn::search_name_hash): ...this.
2615         * f-lang.c (f_language_data): Likewise.
2616         (f_language::search_name_hash): New member function.
2617         * go-lang.c (go_language_data): Delete la_search_name_hash
2618         initializer.
2619         * language.c (unknown_language_data): Likewise.
2620         (auto_language_data): Likewise.
2621         * language.h (struct language_data): Delete la_search_name_hash
2622         field.
2623         (language_defn::search_name_hash): Declare new member function.
2624         (default_search_name_hash): Delete declaration.
2625         * m2-lang.c (m2_language_data): Delete la_search_name_hash
2626         initializer.
2627         * objc-lang.c (objc_language_data): Likewise.
2628         * opencl-lang.c (opencl_language_data): Likewise.
2629         * p-lang.c (pascal_language_data): Likewise.
2630         * rust-lang.c (rust_language_data): Likewise.
2631         * symtab.c (search_name_hash): Update call.
2632
2633 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2634
2635         * ada-lang.c (ada_language_data): Delete la_get_compile_instance
2636         initializer.
2637         * c-lang.c (class compile_instance): Declare.
2638         (c_language_data): Delete la_get_compile_instance initializer.
2639         (c_language::get_compile_instance): New member function.
2640         (cplus_language_data): Delete la_get_compile_instance initializer.
2641         (cplus_language::get_compile_instance): New member function.
2642         (asm_language_data): Delete la_get_compile_instance initializer.
2643         (minimal_language_data): Likewise.
2644         * c-lang.h (c_get_compile_context): Update comment.
2645         (cplus_get_compile_context): Update comment.
2646         * compile/compile.c (compile_to_object): Update calls, don't rely
2647         on function pointer being NULL.
2648         * d-lang.c (d_language_data): Delete la_get_compile_instance
2649         initializer.
2650         * f-lang.c (f_language_data): Likewise.
2651         * go-lang.c (go_language_data): Likewise.
2652         * language.c (unknown_language_data): Likewise.
2653         (auto_language_data): Likewise.
2654         * language.h (language_data): Delete la_get_compile_instance field.
2655         (language_defn::get_compile_instance): New member function.
2656         * m2-lang.c (m2_language_data): Delete la_get_compile_instance
2657         initializer.
2658         * objc-lang.c (objc_language_data): Likewise.
2659         * opencl-lang.c (opencl_language_data): Likewise.
2660         * p-lang.c (pascal_language_data): Likewise.
2661         * rust-lang.c (rust_language_data): Likewise.
2662
2663 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2664
2665         * ada-lang.c (ada_add_all_symbols): Update comment.
2666         (ada_iterate_over_symbols): Delete, move implementation to...
2667         (ada_language::iterate_over_symbols): ...here, a new member
2668         function, rewrite to use range based for loop.
2669         (ada_language_data): Delete la_iterate_over_symbols initializer.
2670         * c-lang.c (c_language_data): Likewise.
2671         (cplus_language_data): Likewise.
2672         (asm_language_data): Likewise.
2673         (minimal_language_data): Likewise.
2674         * d-lang.c (d_language_data): Likewise.
2675         * f-lang.c (f_language_data): Likewise.
2676         * go-lang.c (go_language_data): Likewise.
2677         * language.c (unknown_language_data): Likewise.
2678         (auto_language_data): Likewise.
2679         * language.h (language_data): Delete la_iterate_over_symbols field.
2680         (language_defn::iterate_over_symbols): New member function.
2681         (LA_ITERATE_OVER_SYMBOLS): Update.
2682         * linespec.c (iterate_over_all_matching_symtabs): Update.
2683         * m2-lang.c (m2_language_data): Delete la_iterate_over_symbols
2684         initializer.
2685         * objc-lang.c (objc_language_data): Likewise.
2686         * opencl-lang.c (opencl_language_data): Likewise.
2687         * p-lang.c (pascal_language_data): Likewise.
2688         * rust-lang.c (rust_language_data): Likewise.
2689
2690 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2691
2692         * ada-lang.c (ada_language_data): Delete
2693         la_lookup_transparent_type initializer.
2694         * c-lang.c (c_language_data): Likewise.
2695         (cplus_language_data): Likewise.
2696         (cplus_language::lookup_transparent_type): New member function.
2697         (asm_language_data): Delete la_lookup_transparent_type
2698         initializer.
2699         (minimal_language_data): Likewise.
2700         * d-lang.c (d_language_data): Likewise.
2701         * f-lang.c (f_language_data): Likewise.
2702         * go-lang.c (go_language_data): Likewise.
2703         * language.c (unknown_language_data): Likewise.
2704         (auto_language_data): Likewise.
2705         * language.h (struct language_data): Delete
2706         la_lookup_transparent_type field.
2707         (language_defn::lookup_transparent_type): New member function.
2708         * m2-lang.c (m2_language_data): Delete la_lookup_transparent_type
2709         initializer.
2710         * objc-lang.c (objc_language_data): Likewise.
2711         * opencl-lang.c (opencl_language_data): Likewise.
2712         * p-lang.c (pascal_language_data): Likewise.
2713         * rust-lang.c (rust_language_data): Likewise.
2714         * symtab.c (symbol_matches_domain): Update call.
2715
2716 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2717
2718         * ada-lang.c (ada_language_arch_info): Delete function, move
2719         implementation to...
2720         (ada_language::language_arch_info): ...here, a new member
2721         function.
2722         (ada_language_data): Delete la_language_arch_info.
2723         * c-lang.c (c_language_data): Likewise.
2724         (c_language::language_arch_info): New member function.
2725         (cplus_language_arch_info): Delete function, move
2726         implementation to...
2727         (cplus_language::language_arch_info): ...here, a new member
2728         function.
2729         (cplus_language_data): Delete la_language_arch_info.
2730         (asm_language_data): Likewise.
2731         (asm_language::language_arch_info): New member function.
2732         (minimal_language_data): Delete la_language_arch_info.
2733         (minimal_language::language_arch_info): New member function.
2734         * d-lang.c (d_language_arch_info): Delete function, move
2735         implementation to...
2736         (d_language::language_arch_info): ...here, a new member
2737         function.
2738         (d_language_data): Delete la_language_arch_info.
2739         * f-lang.c (f_language_arch_info): Delete function, move
2740         implementation to...
2741         (f_language::language_arch_info): ...here, a new member
2742         function.
2743         (f_language_data): Delete la_language_arch_info.
2744         * go-lang.c (go_language_arch_info): Delete function, move
2745         implementation to...
2746         (go_language::language_arch_info): ...here, a new member
2747         function.
2748         (go_language_data): Delete la_language_arch_info.
2749         * language.c (unknown_language_data): Likewise.
2750         (unknown_language::language_arch_info): New member function.
2751         (auto_language_data): Delete la_language_arch_info.
2752         (auto_language::language_arch_info): New member function.
2753         (language_gdbarch_post_init): Update call to
2754         la_language_arch_info.
2755         * language.h (language_data): Delete la_language_arch_info
2756         function pointer.
2757         (language_defn::language_arch_info): New function.
2758         * m2-lang.c (m2_language_arch_info): Delete function, move
2759         implementation to...
2760         (m2_language::language_arch_info): ...here, a new member
2761         function.
2762         (m2_language_data): Delete la_language_arch_info.
2763         * objc-lang.c (objc_language_arch_info): Delete function, move
2764         implementation to...
2765         (objc_language::language_arch_info): ...here, a new member
2766         function.
2767         (objc_language_data): Delete la_language_arch_info.
2768         * opencl-lang.c (opencl_language_arch_info): Delete function, move
2769         implementation to...
2770         (opencl_language::language_arch_info): ...here, a new member
2771         function.
2772         (opencl_language_data): Delete la_language_arch_info.
2773         * p-lang.c (pascal_language_arch_info): Delete function, move
2774         implementation to...
2775         (pascal_language::language_arch_info): ...here, a new member
2776         function.
2777         (pascal_language_data): Delete la_language_arch_info.
2778         * rust-lang.c (rust_language_arch_info): Delete function, move
2779         implementation to...
2780         (rust_language::language_arch_info): ...here, a new member
2781         function.
2782         (rust_language_data): Delete la_language_arch_info.
2783
2784 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2785
2786         * ada-lang.c (ada_language_data): Delete la_pass_by_reference
2787         initializer.
2788         * c-lang.c (c_language_data): Likewise.
2789         (cplus_language_data): Likewise.
2790         (cplus_language::pass_by_reference_info): New method.
2791         (asm_language_data): Delete la_pass_by_reference initializer.
2792         (minimal_language_data): Likewise.
2793         * cp-abi.c (cp_pass_by_reference): Remove use of
2794         default_pass_by_reference.
2795         * d-lang.c (d_language_data): Likewise.
2796         * f-lang.c (f_language_data): Likewise.
2797         * gnu-v3-abi.c (gnuv3_pass_by_reference): Remove use of
2798         default_pass_by_reference.
2799         * go-lang.c (go_language_data): Likewise.
2800         * language.c (language_pass_by_reference): Update.
2801         (default_pass_by_reference): Delete.
2802         (unknown_language_data): Delete la_pass_by_reference
2803         initializer.
2804         (auto_language_data): Likewise.
2805         * language.h (struct language_data): Delete la_pass_by_reference
2806         field.
2807         (language_defn::pass_by_reference_info): New member function.
2808         (default_pass_by_reference): Delete declaration.
2809         * m2-lang.c (m2_language_data): Delete la_pass_by_reference
2810         initializer.
2811         * objc-lang.c (objc_language_data): Likewise.
2812         * opencl-lang.c (opencl_language_data): Likewise.
2813         * p-lang.c (pascal_language_data): Likewise.
2814         * rust-lang.c (rust_language_data): Likewise.
2815
2816 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2817
2818         * ada-lang.c (ada_read_var_value): Delete function, move
2819         implementation to...
2820         (ada_language::read_var_value): ...here.
2821         (ada_language_data): Delete la_read_var_value initializer.
2822         * c-lang.c (c_language_data): Likewise.
2823         (cplus_language_data): Likewise.
2824         (minimal_language_data): Likewise.
2825         * d-lang.c (d_language_data): Likewise.
2826         * f-lang.c (f_language_data): Likewise.
2827         * findvar.c (default_read_var_value): Rename to...
2828         (language_defn::read_var_value): ...this.
2829         * findvar.c (read_var_value): Update header comment, and change to
2830         call member function instead of function pointer.
2831         * go-lang.c (go_language_data): Likewise.
2832         * language.c (unknown_language_data): Delete la_read_var_value
2833         initializer.
2834         (auto_language_data): Likewise.
2835         * language.h (struct language_data): Delete la_read_var_value
2836         field.
2837         (language_defn::read_var_value): New member function.
2838         (default_read_var_value): Delete declaration.
2839         * m2-lang.c (m2_language_data): Delete la_read_var_value
2840         initializer.
2841         * objc-lang.c (objc_language_data): Likewise.
2842         * opencl-lang.c (opencl_language_data): Likewise.
2843         * p-lang.c (pascal_language_data): Likewise.
2844         * rust-lang.c (rust_language_data): Likewise.
2845         * value.h (default_read_var_value): Delete declaration.
2846
2847 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2848
2849         * ada-lang.c (ada_print_array_index): Delete function, move
2850         implementation to...
2851         (ada_language::print_array_index): ...here.
2852         (ada_language_data): Delete la_print_array_index initializer.
2853         * c-lang.c (c_language_data): Likewise.
2854         (cplus_language_data): Likewise.
2855         (minimal_language_data): Likewise.
2856         * d-lang.c (d_language_data): Likewise.
2857         * f-lang.c (f_language_data): Likewise.
2858         * go-lang.c (go_language_data): Likewise.
2859         * language.c (default_print_array_index): Delete function, move
2860         implementation to...
2861         (language_defn::print_array_index): ...here.
2862         (unknown_language_data): Delete la_print_array_index initializer.
2863         (auto_language_data): Likewise.
2864         * language.h (struct language_data): Delete la_print_array_index
2865         field.
2866         (language_defn::print_array_index): New member function.
2867         (LA_PRINT_ARRAY_INDEX): Update.
2868         (default_print_array_index): Delete declaration.
2869         * m2-lang.c (m2_language_data): Delete la_print_array_index
2870         initializer.
2871         * objc-lang.c (objc_language_data): Likewise.
2872         * opencl-lang.c (opencl_language_data): Likewise.
2873         * p-lang.c (pascal_language_data): Likewise.
2874         * rust-lang.c (rust_language_data): Likewise.
2875
2876 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2877
2878         * gdb/ada-lang.c (ada_language_defn): Convert to...
2879         (ada_language_data): ...this.
2880         (class ada_language): New class.
2881         (ada_language_defn): New static global.
2882         * gdb/c-lang.c (c_language_defn): Convert to...
2883         (c_language_data): ...this.
2884         (class c_language): New class.
2885         (c_language_defn): New static global.
2886         (cplus_language_defn): Convert to...
2887         (cplus_language_data): ...this.
2888         (class cplus_language): New class.
2889         (cplus_language_defn): New static global.
2890         (asm_language_defn): Convert to...
2891         (asm_language_data): ...this.
2892         (class asm_language): New class.
2893         (asm_language_defn): New static global.
2894         (minimal_language_defn): Convert to...
2895         (minimal_language_data): ...this.
2896         (class minimal_language): New class.
2897         (minimal_language_defn): New static global.
2898         * gdb/d-lang.c (d_language_defn): Convert to...
2899         (d_language_data): ...this.
2900         (class d_language): New class.
2901         (d_language_defn): New static global.
2902         * gdb/f-lang.c (f_language_defn): Convert to...
2903         (f_language_data): ...this.
2904         (class f_language): New class.
2905         (f_language_defn): New static global.
2906         * gdb/go-lang.c (go_language_defn): Convert to...
2907         (go_language_data): ...this.
2908         (class go_language): New class.
2909         (go_language_defn): New static global.
2910         * gdb/language.c (unknown_language_defn): Remove declaration.
2911         (current_language): Initialize to nullptr, real initialization is
2912         moved to _initialize_language.
2913         (languages): Delete global.
2914         (language_defn::languages): Define.
2915         (set_language_command): Use language_defn::languages.
2916         (set_language): Likewise.
2917         (range_error): Likewise.
2918         (language_enum): Likewise.
2919         (language_def): Likewise.
2920         (add_set_language_command): Use language_def::languages for the
2921         language list, and language_def to lookup language pointers.
2922         (skip_language_trampoline): Use language_defn::languages.
2923         (unknown_language_defn): Convert to...
2924         (unknown_language_data): ...this.
2925         (class unknown_language): New class.
2926         (unknown_language_defn): New static global.
2927         (auto_language_defn): Convert to...
2928         (auto_language_data): ...this.
2929         (class auto_language): New class.
2930         (auto_language_defn): New static global.
2931         (language_gdbarch_post_init): Use language_defn::languages.
2932         (_initialize_language): Initialize current_language.
2933         * gdb/language.h (struct language_defn): Rename to...
2934         (struct language_data): ...this.
2935         (struct language_defn): New.
2936         (auto_language_defn): Delete.
2937         (unknown_language_defn): Delete.
2938         (minimal_language_defn): Delete.
2939         (ada_language_defn): Delete.
2940         (asm_language_defn): Delete.
2941         (c_language_defn): Delete.
2942         (cplus_language_defn): Delete.
2943         (d_language_defn): Delete.
2944         (f_language_defn): Delete.
2945         (go_language_defn): Delete.
2946         (m2_language_defn): Delete.
2947         (objc_language_defn): Delete.
2948         (opencl_language_defn): Delete.
2949         (pascal_language_defn): Delete.
2950         (rust_language_defn): Delete.
2951         * gdb/m2-lang.c (m2_language_defn): Convert to...
2952         (m2_language_data): ...this.
2953         (class m2_language): New class.
2954         (m2_language_defn): New static global.
2955         * gdb/objc-lang.c (objc_language_defn): Convert to...
2956         (objc_language_data): ...this.
2957         (class objc_language): New class.
2958         (objc_language_defn): New static global.
2959         * gdb/opencl-lang.c (opencl_language_defn): Convert to...
2960         (opencl_language_data): ...this.
2961         (class opencl_language): New class.
2962         (opencl_language_defn): New static global.
2963         * gdb/p-lang.c (pascal_language_defn): Convert to...
2964         (pascal_language_data): ...this.
2965         (class pascal_language): New class.
2966         (pascal_language_defn): New static global.
2967         * gdb/rust-exp.y (rust_lex_tests): Use language_def to find
2968         language pointer, update comment format.
2969         * gdb/rust-lang.c (rust_language_defn): Convert to...
2970         (rust_language_data): ...this.
2971         (class rust_language): New class.
2972         (rust_language_defn): New static global.
2973
2974 2020-06-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2975
2976         * dwarf2/read.c (class lnp_state_machine) <m_last_address>: New
2977         member variable.
2978         <m_stmt_at_address>: New member variable.
2979         (lnp_state_machine::record_line): Don't record some lines, update
2980         tracking of is_stmt at the same address.
2981         (lnp_state_machine::lnp_state_machine): Initialise new member
2982         variables.
2983
2984 2020-06-01  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2985
2986         * config/i386/i386gnu.mn [%_S.o %_U.o] (COMPILE.post): Add
2987         "-include gnu-nat-mig.h".
2988         * gnu-nat-mig.h: New file.
2989         * gnu-nat.c: Include "gnu-nat-mig.h".
2990         (exc_server, msg_reply_server, notify_server,
2991         process_reply_server): Remove declarations.
2992
2993 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2994
2995         * gnu-nat.h (inf_validate_procs, inf_suspend, inf_set_traced,
2996         steal_exc_port, proc_get_state, inf_clear_wait, inf_cleanup,
2997         inf_startup, inf_update_suspends, inf_set_pid, inf_steal_exc_ports,
2998         inf_validate_procinfo, inf_validate_task_sc, inf_restore_exc_ports,
2999         inf_set_threads_resume_sc, inf_set_threads_resume_sc_for_signal_thread,
3000         inf_resume, inf_set_step_thread, inf_detach, inf_attach, inf_signal,
3001         inf_continue, make_proc, proc_abort, _proc_free, proc_update_sc,
3002         proc_get_exception_port, proc_set_exception_port, _proc_get_exc_port,
3003         proc_steal_exc_port, proc_restore_exc_port, proc_trace): Move functions
3004         to gnu_nat_target class.
3005         * gnu-nat.c: Likewise.
3006         (inf_update_procs, S_proc_wait_reply, set_task_pause_cmd,
3007         set_task_exc_port_cmd, set_signals_cmd, set_thread_pause_cmd,
3008         set_thread_exc_port_cmd): Call inf_validate_procs through gnu_target
3009         object.
3010         (gnu_nat_target::create_inferior, gnu_nat_target::detach): Pass `this'
3011         instead of `gnu_target'.
3012
3013 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3014
3015         * i386-gnu-tdep.c: Include "gdbcore.h"
3016         (gnu_sigtramp_code, i386_gnu_sc_reg_offset): New arrays.
3017         (GNU_SIGTRAMP_LEN, GNU_SIGTRAMP_TAIL,
3018         I386_GNU_SIGCONTEXT_THREAD_STATE_OFFSET): New macros
3019         (i386_gnu_sigtramp_start, i386_gnu_sigtramp_p,
3020         i386_gnu_sigcontext_addr): New functions
3021         (i386gnu_init_abi): Register i386_gnu_sigtramp_p,
3022         i386_gnu_sigcontext_addr, and i386_gnu_sc_reg_offset in the gdbarch
3023         tdep.
3024
3025 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3026
3027         * gnu-nat.c (gnu_nat_target::create_inferior): Move push_target call
3028         before fork_inferior call. Avoid calling it if target_is_pushed returns
3029         true.
3030
3031 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3032
3033         * gnu-nat.h (gnu_target): New variable declaration.
3034         * i386-gnu-nat.c (_initialize_i386gnu_nat): Initialize
3035         gnu_target.
3036         * gnu-nat.c (gnu_target): New variable.
3037         (inf_validate_procs): Pass gnu_target to thread_change_ptid,
3038         add_thread_silent, and add_thread calls.
3039         (gnu_nat_target::create_inferior): Pass gnu_target to
3040         add_thread_silent, thread_change_ptid call.
3041         (gnu_nat_target::detach): Pass gnu_target to detach_inferior
3042         call.
3043
3044 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3045
3046         * gnu-nat.c (gnu_xfer_auxv): Remove unused `res' variable.
3047         (gnu_nat_target::find_memory_regions): Remove unused
3048         `old_address' variable.
3049
3050 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3051
3052         * gnu-nat.c: Include "gdbarch.h".
3053
3054 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3055
3056         * reply_mig_hack.awk (Error return): Cast function through
3057         void *, to bypass compiler function call check.
3058
3059 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3060
3061         * config/i386/i386gnu.mn (%_reply_S.c): Add dependency on
3062         $(srcdir)/reply_mig_hack.awk.
3063
3064 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3065
3066         * gnu-nat.h (gnu_debug_flag): Set type to bool.
3067
3068 2020-05-30  Jonny Grant  <jg@jguk.org>
3069
3070         * configure.ac (ACX_BUGURL): change bug URL to https.
3071
3072 2020-05-30  Pedro Alves  <palves@redhat.com>
3073
3074         * cp-support.c (replace_typedefs_template): New.
3075         (replace_typedefs_qualified_name): Handle
3076         DEMANGLE_COMPONENT_TEMPLATE.
3077
3078 2020-05-29  Simon Marchi  <simon.marchi@efficios.com>
3079
3080         * dwarf2/comp-unit.c, dwarf2/comp-unit.h, dwarf2/index-cache.c,
3081         dwarf2/index-cache.h, dwarf2/index-write.c,
3082         dwarf2/index-write.h, dwarf2/line-header.c,
3083         dwarf2/line-header.h, dwarf2/macro.c, dwarf2/macro.h,
3084         dwarf2/read.c, dwarf2/read.h: Rename struct dwarf2_per_objfile
3085         variables and fields from `dwarf2_per_objfile` to just
3086         `per_objfile` throughout.
3087
3088 2020-05-28  Simon Marchi  <simon.marchi@polymtl.ca>
3089
3090         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
3091         <push_dwarf_reg_entry_value>: Add comment.
3092
3093 2020-05-28  Kevin Buettner  <kevinb@redhat.com>
3094             Keith Seitz  <keiths@redhat.com>
3095
3096         * python/python.c (do_start_initialization): Call PyEval_SaveThread
3097         instead of PyEval_ReleaseLock.
3098         (class gdbpy_gil): Move to earlier in file.
3099         (finalize_python): Set gdb_python_initialized.
3100         (gdbpy_check_quit_flag): Acquire GIL via gdbpy_gil.  Return early
3101         when not initialized.
3102
3103 2020-05-28  Simon Marchi  <simon.marchi@efficios.com>
3104
3105         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
3106         <push_dwarf_reg_entry_value>: Remove assert.  Override
3107         per_objfile with caller_per_objfile.
3108
3109 2020-05-28  Tom de Vries  <tdevries@suse.de>
3110
3111         * dwarf2/read.c (dw2_symtab_iter_next, dw2_expand_marked_cus): Limit
3112         PR gold/15646 workaround to symbol kind "type".
3113
3114 2020-05-27  Tom Tromey  <tromey@adacore.com>
3115
3116         * dwarf2/read.c (load_partial_dies): Use add_partial_symbol.
3117
3118 2020-05-27  Tom Tromey  <tromey@adacore.com>
3119
3120         * dwarf2/abbrev.h (struct abbrev_table) <lookup_abbrev>: Inline.
3121         Use htab_find_with_hash.
3122         <add_abbrev>: Remove "abbrev_number" parameter.
3123         * dwarf2/abbrev.c (abbrev_table::add_abbrev): Remove
3124         "abbrev_number" parameter.  Use htab_find_slot_with_hash.
3125         (hash_abbrev): Add comment.
3126         (abbrev_table::lookup_abbrev): Move to header file.
3127         (abbrev_table::read): Update.
3128
3129 2020-05-27  Tom Tromey  <tromey@adacore.com>
3130
3131         * dwarf2/read.c (struct partial_die_info) <name>: Declare new
3132         method.
3133         <canonical_name>: New member.
3134         <raw_name>: Rename from "name".
3135         (partial_die_info): Initialize canonical_name.
3136         (scan_partial_symbols): Check raw_name.
3137         (partial_die_parent_scope, partial_die_full_name)
3138         (add_partial_symbol, add_partial_subprogram)
3139         (add_partial_enumeration, load_partial_dies): Use "name" method.
3140         (partial_die_info::name): New method.
3141         (partial_die_info::read, guess_partial_die_structure_name)
3142         (partial_die_info::fixup): Update.
3143
3144 2020-05-27  Tom Tromey  <tromey@adacore.com>
3145
3146         * dwarf2/attribute.h (struct attribute) <form_is_ref>: Inline.
3147         <get_ref_die_offset>: Inline.
3148         <get_ref_die_offset_complaint>: New method.
3149         * dwarf2/attribute.c (attribute::form_is_ref): Move to header.
3150         (attribute::get_ref_die_offset_complaint): Rename from
3151         get_ref_die_offset.  Just issue complaint.
3152
3153 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
3154
3155         * cli/cli-cmds.c (shell_escape): Move exit_status_set_internal_vars.
3156
3157 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
3158
3159         * exec.c (exec_file_attach): Use errno value of first openp failure.
3160
3161 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
3162
3163         * nat/windows-nat.c (windows_thread_info::~windows_thread_info):
3164         Don't close thread handle.
3165
3166 2020-05-27  Tom Tromey  <tom@tromey.com>
3167             Simon Marchi  <simon.marchi@efficios.com>
3168
3169         * objfiles.h (struct objfile) <partial_symtabs>: Now a
3170         shared_ptr.
3171         * dwarf2/read.h (struct dwarf2_per_objfile) <partial_symtabs>: New
3172         member.
3173         * dwarf2/read.c (dwarf2_per_bfd_bfd_data_key,
3174         dwarf2_per_bfd_objfile_data_key>: New globals.
3175         (dwarf2_has_info): Use shared dwarf2_per_bfd if possible.
3176         (dwarf2_get_section_info): Use get_dwarf2_per_objfile.
3177         (dwarf2_initialize_objfile): Consider cases where per_bfd can be
3178         shared.
3179         (dwarf2_build_psymtabs): Set objfile::partial_symtabs and
3180         short-circuit when sharing.
3181         (dwarf2_build_psymtabs): Set dwarf2_per_objfile::partial_symtabs.
3182         (dwarf2_psymtab::expand_psymtab): Use free_cached_comp_units.
3183
3184 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3185
3186         * dwarf2/read.h (struct dwarf2_per_bfd) <line_header_hash>: Move
3187         to...
3188         (struct dwarf2_per_objfile) <line_header_hash>: ... here.
3189         * dwarf2/read.c (handle_DW_AT_stmt_list): Update.
3190
3191 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3192
3193         * dwarf2/read.c (struct mapped_index_base) <symbol_name_at,
3194         build_name_components, find_name_components_bounds>:
3195         Add per_objfile parameter.
3196         (struct mapped_index) <symbol_name_at>: Likewise.
3197         (struct mapped_debug_names): Remove constructor.
3198         <dwarf2_per_objfile>: Remove field.
3199         <namei_to_name, symbol_name_at>: Add per_objfile parameter.
3200         (mapped_index_base::find_name_components_bounds,
3201         mapped_index_base::build_name_components,
3202         dw2_expand_symtabs_matching_symbol): Likewise.
3203         (class mock_mapped_index) <symbol_name_at>: Likewise.
3204         (check_match): Likewise.
3205         (check_find_bounds_finds): Likewise.
3206         (test_mapped_index_find_name_component_bounds): Update.
3207         (CHECK_MATCH): Update.
3208         (dw2_expand_symtabs_matching): Update.
3209         (class dw2_debug_names_iterator) <dw2_debug_names_iterator>: Add
3210         per_objfile parameter.
3211         <find_vec_in_debug_names>: Likewise.
3212         <m_per_objfile>: New field.
3213         (mapped_debug_names::namei_to_name): Add dwarf2_per_objfile
3214         parameter.
3215         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
3216         (dw2_debug_names_iterator::next): Update.
3217         (dw2_debug_names_lookup_symbol): Update.
3218         (dw2_debug_names_expand_symtabs_for_function): Update.
3219         (dw2_debug_names_map_matching_symbols): Update.
3220         (dw2_debug_names_expand_symtabs_matching): Update.
3221         (dwarf2_read_debug_names): Update.
3222
3223 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3224
3225         * dwarf2/read.h (struct dwarf2_cu): Forward-declare.
3226         (struct dwarf2_per_bfd) <free_cached_comp_units>: Remove,
3227         move to dwarf2_per_objfile.
3228         <read_in_chain>: Remove.
3229         (struct dwarf2_per_objfile) <get_cu, set_cu, remove_cu,
3230         remove_all_cus, age_comp_units>: New methods.
3231         <m_dwarf2_cus>: New member.
3232         (struct dwarf2_per_cu_data) <cu>: Remove.
3233         * dwarf2/read.c (struct dwarf2_cu) <read_in_chain>: Remove.
3234         (age_cached_comp_units, free_one_cached_comp_unit): Remove,
3235         moved to methods of dwarf2_per_objfile.
3236         (dwarf2_clear_marks): Remove.
3237         (dwarf2_queue_item::~dwarf2_queue_item): Update.
3238         (dwarf2_per_bfd::~dwarf2_per_bfd): Don't free dwarf2_cus.
3239         (dwarf2_per_bfd::free_cached_comp_units): Remove.
3240         (dwarf2_per_objfile::remove_all_cus): New.
3241         (class free_cached_comp_units) <~free_cached_comp_units>:
3242         Update.
3243         (load_cu): Update.
3244         (dw2_do_instantiate_symtab): Adjust.
3245         (fill_in_sig_entry_from_dwo_entry): Adjust.
3246         (cutu_reader::init_tu_and_read_dwo_dies): Update.
3247         (cutu_reader::cutu_reader): Likewise.
3248         (cutu_reader::keep): Use dwarf2_per_objfile::set_cu.
3249         (cutu_reader::cutu_reader): Use dwarf2_per_objfile::get_cu.
3250         (process_psymtab_comp_unit): Use dwarf2_per_objfile::remove_cu
3251         and dwarf2_per_objfile::age_comp_units.
3252         (load_partial_comp_unit): Update.
3253         (maybe_queue_comp_unit): Use dwarf2_per_objfile::get_cu.
3254         (process_queue): Likewise.
3255         (find_partial_die): Use dwarf2_per_objfile::get_cu instead of cu
3256         backlink.
3257         (dwarf2_read_addr_index): Likewise.
3258         (follow_die_offset): Likewise.
3259         (dwarf2_fetch_die_loc_sect_off): Likewise.
3260         (dwarf2_fetch_constant_bytes): Likewise.
3261         (dwarf2_fetch_die_type_sect_off): Likewise.
3262         (follow_die_sig_1): Likewise.
3263         (load_full_type_unit): Likewise.
3264         (read_signatured_type): Likewise.
3265         (dwarf2_cu::dwarf2_cu): Don't set cu field.
3266         (dwarf2_cu::~dwarf2_cu): Remove.
3267         (dwarf2_per_objfile::get_cu): New.
3268         (dwarf2_per_objfile::set_cu): New.
3269         (age_cached_comp_units): Rename to...
3270         (dwarf2_per_objfile::age_comp_units): ... this.  Adjust
3271         to std::unordered_map.
3272         (free_one_cached_comp_unit): Rename to...
3273         (dwarf2_per_objfile::remove_cu): ... this.  Adjust
3274         to std::unordered_map.
3275         (dwarf2_per_objfile::~dwarf2_per_objfile): New.
3276         (dwarf2_mark_helper): Use dwarf2_per_objfile::get_cu, expect
3277         a dwarf2_per_objfile in data.
3278         (dwarf2_mark): Pass dwarf2_per_objfile in data to htab_traverse.
3279         (dwarf2_clear_marks): Remove.
3280
3281 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3282
3283         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Replace
3284         `int use_existing_cu` parameter with `dwarf2_cu *existing_cu`.
3285         (init_tu_and_read_dwo_dies): Likewise.
3286         (cutu_reader::init_tu_and_read_dwo_dies): Likewise.
3287         (cutu_reader::cutu_reader): Likewise.
3288         (load_partial_comp_unit): Likewise.
3289         (process_psymtab_comp_unit): Update.
3290         (build_type_psymtabs_1): Update.
3291         (process_skeletonless_type_unit): Update.
3292         (load_full_comp_unit): Update.
3293         (find_partial_die): Update.
3294         (dwarf2_read_addr_index): Update.
3295         (read_signatured_type): Update.
3296
3297 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
3298
3299         * dwarf2/read.h (struct dwarf2_per_cu_data) <m_header,
3300         m_header_read_in>: New fields.
3301         <get_header>: New method.
3302         * dwarf2/read.c (per_cu_header_read_in): Remove.
3303         (dwarf2_per_cu_data::get_header): New.
3304         (dwarf2_per_cu_data::addr_size): Update.
3305         (dwarf2_per_cu_data::offset_size): Update.
3306         (dwarf2_per_cu_data::ref_addr_size): Update.
3307
3308 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
3309
3310         * dwarf2/read.c (load_cu): Return dwarf2_cu.
3311         (dw2_do_instantiate_symtab): Update.
3312         (queue_and_load_all_dwo_tus): Change parameter from
3313         dwarf2_per_cu_data to dwarf2_cu.
3314         (dwarf2_fetch_die_loc_sect_off): Update.
3315         (dwarf2_fetch_constant_bytes): Update.
3316         (dwarf2_fetch_die_type_sect_off): Update.
3317
3318 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
3319
3320         * dwarf2/read.c (process_full_comp_unit,
3321         process_full_type_unit): Remove per_cu, per_objfile paramters.
3322         Add dwarf2_cu parameter.
3323         (process_queue): Update.
3324
3325 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
3326
3327         * dwarf2/read.c (create_cu_from_index_list): Replace
3328         dwarf2_per_objfile parameter with dwarf2_per_bfd.
3329         (create_cus_from_index_list): Likewise.
3330         (create_cus_from_index): Likewise.
3331         (create_signatured_type_table_from_index): Likewise.
3332         (create_cus_from_debug_names_list): Likewise.
3333         (create_cus_from_debug_names): Likewise.
3334         (dwarf2_read_gdb_index): Update.
3335         (dwarf2_read_debug_names): Update.
3336
3337 2020-05-27  Tom Tromey  <tom@tromey.com>
3338             Simon Marchi  <simon.marchi@efficios.com>
3339
3340         * dwarf2/read.h (struct dwarf2_per_objfile)
3341         <get_type_for_signatured_type, set_type_for_signatured_type>:
3342         New methods.
3343         <m_type_map>: New member.
3344         (struct signatured_type) <type>: Remove.
3345         * dwarf2/read.c
3346         (dwarf2_per_objfile::get_type_for_signatured_type,
3347         dwarf2_per_objfile::set_type_for_signatured_type): New.
3348         (get_signatured_type): Use new methods.
3349
3350 2020-05-27  Tom Tromey  <tom@tromey.com>
3351             Simon Marchi  <simon.marchi@efficios.com>
3352
3353         * dwarf2/read.h (struct type_unit_group_unshareable): New.
3354         (struct dwarf2_per_objfile) <type_units>: New member.
3355         <get_type_unit_group_unshareable>: New method.
3356         * dwarf2/read.c (struct type_unit_group) <compunit_symtab,
3357         num_symtabs, symtabs>: Remove; move to
3358         type_unit_group_unshareable.
3359         (dwarf2_per_objfile::get_type_unit_group_unshareable): New.
3360         (process_full_type_unit, dwarf2_cu::setup_type_unit_groups)
3361         (dwarf2_cu::setup_type_unit_groups): Use type_unit_group_unshareable.
3362
3363 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3364
3365         * dwarf2/read.h (struct dwarf2_per_cu_data):
3366         <dwarf2_per_objfile>: Remove.
3367         * dwarf2/read.c (create_cu_from_index_list): Don't assign
3368         dwarf2_per_objfile.
3369         (create_signatured_type_table_from_index): Likewise.
3370         (create_signatured_type_table_from_debug_names): Likewise.
3371         (create_debug_type_hash_table): Likewise.
3372         (fill_in_sig_entry_from_dwo_entry): Likewise.
3373         (create_type_unit_group): Likewise.
3374         (read_comp_units_from_section): Likewise.
3375         (create_cus_hash_table): Likewise.
3376
3377 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3378
3379         * dwarf2/read.c (process_psymtab_comp_unit): Remove reference to
3380         dwarf2_per_cu_data::dwarf2_per_objfile.
3381         (compute_compunit_symtab_includes): Likewise.
3382         (dwarf2_cu::start_symtab): Likewise.
3383
3384 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
3385
3386         * dwarf2/read.h (dwarf2_get_die_type): Add dwarf2_per_objfile
3387         parameter.
3388         * dwarf2/read.c (get_die_type_at_offset): Likewise.
3389         (read_namespace_alias): Update.
3390         (lookup_die_type): Update.
3391         (dwarf2_get_die_type): Add dwarf2_per_objfile parameter.
3392         * dwarf2/loc.c (class dwarf_evaluate_loc_desc) <get_base_type>:
3393         Update.
3394         (disassemble_dwarf_expression): Update.
3395
3396 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3397
3398         * dwarf2/read.h (struct dwarf2_queue_item): Add
3399         dwarf2_per_objfile parameter, assign new parameter.
3400         <per_objfile>: New field.
3401         * dwarf2/read.c (free_one_cached_comp_unit): Add
3402         dwarf2_per_objfile parameter.
3403         (queue_comp_unit): Likewise.
3404         (dw2_do_instantiate_symtab): Update.
3405         (process_psymtab_comp_unit): Update.
3406         (maybe_queue_comp_unit): Add dwarf2_per_objfile parameter.
3407         (process_imported_unit_die): Update.
3408         (queue_and_load_dwo_tu): Update.
3409         (follow_die_offset): Update.
3410         (follow_die_sig_1): Update.
3411
3412 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3413
3414         * dwarf2/read.h (struct dwarf2_per_cu_data) <objfile>: Remove.
3415         * dwarf2/read.c (dwarf2_compute_name): Pass per_objfile down.
3416         (read_call_site_scope): Assign per_objfile.
3417         (dwarf2_per_cu_data::objfile): Remove.
3418         * gdbtypes.h (struct call_site) <per_objfile>: New member.
3419         * dwarf2/loc.h (dwarf2_evaluate_loc_desc): Add
3420         dwarf2_per_objfile parameter.
3421         * dwarf2/loc.c (dwarf2_evaluate_loc_desc_full): Add
3422         dwarf2_per_objfile parameter.
3423         (dwarf_expr_reg_to_entry_parameter): Add output
3424         dwarf2_per_objfile parameter.
3425         (locexpr_get_frame_base): Update.
3426         (class dwarf_evaluate_loc_desc) <get_tls_address>: Update.
3427         <push_dwarf_reg_entry_value>: Update.
3428         <call_site_to_target_addr>: Update.
3429         (dwarf_entry_parameter_to_value): Add dwarf2_per_objfile
3430         parameter.
3431         (value_of_dwarf_reg_entry): Update.
3432         (rw_pieced_value): Update.
3433         (indirect_synthetic_pointer): Update.
3434         (dwarf2_evaluate_property): Update.
3435         (dwarf2_loc_desc_get_symbol_read_needs): Add dwarf2_per_objfile
3436         parameter.
3437         (locexpr_read_variable): Update.
3438         (locexpr_get_symbol_read_needs): Update.
3439         (loclist_read_variable): Update.
3440
3441 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3442
3443         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
3444         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3445         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
3446         parameter.
3447         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
3448         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3449         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
3450         parameter.
3451         * dwarf2/loc.c (indirect_synthetic_pointer, per_cu_dwarf_call,
3452         sect_variable_value): Add dwarf2_per_objfile parameter.
3453         (class dwarf_evaluate_loc_desc) <dwarf_call,
3454         dwarf_variable_value>: Update.
3455         (fetch_const_value_from_synthetic_pointer): Add
3456         dwarf2_per_objfile parameter.
3457         (fetch_const_value_from_synthetic_pointer): Update.
3458         (coerced_pieced_ref): Update.
3459         (class symbol_needs_eval_context) <dwarf_call,
3460         dwarf_variable_value>: Update.
3461         (dwarf2_compile_expr_to_ax): Update.
3462
3463 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3464
3465         * dwarf2/loc.c (allocate_piece_closure): Add dwarf2_per_objfile
3466         parameter.
3467         (dwarf2_evaluate_loc_desc_full): Update.
3468
3469 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3470
3471         * dwarf2/read.h (dwarf2_read_addr_index): Add dwarf2_per_objfile
3472         parameter.
3473         * dwarf2/read.c (dwarf2_read_addr_index): Likewise.
3474         * dwarf2/loc.c (decode_debug_loclists_addresses): Add
3475         dwarf2_per_objfile parameter.
3476         (decode_debug_loc_dwo_addresses): Likewise.
3477         (dwarf2_find_location_expression): Update.
3478         (class dwarf_evaluate_loc_desc) <get_addr_index>: Update.
3479         (locexpr_describe_location_piece): Add dwarf2_per_objfile
3480         parameter.
3481         (disassemble_dwarf_expression): Add dwarf2_per_objfile
3482         parameter.
3483         (locexpr_describe_location_1): Likewise.
3484         (locexpr_describe_location): Update.
3485
3486 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3487
3488         * dwarf2/read.h (struct dwarf2_per_cu_data) <text_offset>:
3489         Remove.
3490         * dwarf2/read.c (dwarf2_per_cu_data::text_offset): Remove.
3491         * dwarf2/loc.c (dwarf2_find_location_expression): Update.
3492         (dwarf2_compile_property_to_c): Update.
3493         (dwarf2_compile_expr_to_ax): Add dwarf2_per_objfile parameter,
3494         use text offset from objfile.
3495         (locexpr_tracepoint_var_ref): Update.
3496         (locexpr_generate_c_location): Update.
3497         (loclist_describe_location): Update.
3498         (loclist_tracepoint_var_ref): Update.
3499         * dwarf2/compile.h (compile_dwarf_bounds_to_c): Add
3500         dwarf2_per_objfile parameter.
3501         * dwarf2/loc2c.c (do_compile_dwarf_expr_to_c): Likewise,
3502         use text offset from objfile.
3503         (compile_dwarf_expr_to_c): Add dwarf2_per_objfile parameter.
3504
3505 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3506
3507         * dwarf2/expr.h (struct dwarf_expr_context)
3508         <dwarf_expr_context>: Add dwarf2_per_objfile parameter.
3509         <offset>: Remove.
3510         <per_objfile>: New member.
3511         * dwarf2/expr.c (dwarf_expr_context::dwarf_expr_context): Add
3512         dwarf2_per_objfile parameter.  Don't set offset, set
3513         per_objfile.
3514         (dwarf_expr_context::execute_stack_op): Use offset from objfile.
3515         * dwarf2/frame.c (dwarf2_frame_find_fde): Return (by parameter)
3516         a dwarf2_per_objfile object instead of an offset.
3517         (class dwarf_expr_executor) <dwarf_expr_executor>: Add
3518         constructor.
3519         (execute_stack_op): Add dwarf2_per_objfile parameter, pass it
3520         to dwarf2_expr_executor constructor.  Don't set offset.
3521         (dwarf2_fetch_cfa_info): Update.
3522         (struct dwarf2_frame_cache) <text_offset>: Remove.
3523         <per_objfile>: New field.
3524         (dwarf2_frame_cache): Update.
3525         (dwarf2_frame_prev_register): Update.
3526         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
3527         <dwarf_evaluate_loc_desc>: Add constructor.
3528         (dwarf2_evaluate_loc_desc_full): Update.
3529         (dwarf2_locexpr_baton_eval): Update.
3530         (class symbol_needs_eval_context) <symbol_needs_eval_context>:
3531         Add constructor.
3532         (dwarf2_loc_desc_get_symbol_read_needs): Update.
3533
3534 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3535
3536         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_type,
3537         addr_sized_int_type>: Move to dwarf2_cu.
3538         <int_type>: Move to dwarf2_per_objfile.
3539         (struct dwarf2_per_objfile) <int_type>: Move here.
3540         * dwarf2/read.c (struct dwarf2_cu) <addr_type,
3541         addr_sized_int_type>: Move here.
3542         (read_func_scope): Update.
3543         (read_array_type): Update.
3544         (read_tag_string_type): Update.
3545         (attr_to_dynamic_prop): Update.
3546         (dwarf2_per_cu_data::int_type): Rename to...
3547         (dwarf2_per_objfile::int_type): ... this.
3548         (dwarf2_per_cu_data::addr_sized_int_type): Rename to...
3549         (dwarf2_cu::addr_sized_int_type): ... this.
3550         (read_subrange_type): Update.
3551         (dwarf2_per_cu_data::addr_type): Rename to...
3552         (dwarf2_cu::addr_type): ... this.
3553         (set_die_type): Update.
3554
3555 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3556
3557         * dwarf2/read.c (queue_and_load_all_dwo_tus): Access per_objfile
3558         data through per_cu->cu.
3559
3560 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3561
3562         * dwarf2/read.c (lookup_dwo_comp_unit): Change
3563         dwarf2_per_cu_data parameter fo dwarf2_cu.
3564         (lookup_dwo_type_unit): Likewise.
3565         (read_cutu_die_from_dwo): Likewise.
3566         (lookup_dwo_unit): Likewise.
3567         (open_and_init_dwo_file): Likewise.
3568         (lookup_dwo_cutu): Likewise.
3569         (lookup_dwo_comp_unit): Likewise.
3570         (lookup_dwo_type_unit): Likewise.
3571         (cutu_reader::init_tu_and_read_dwo_dies): Update.
3572         (cutu_reader::cutu_reader): Update.
3573
3574 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3575
3576         * dwarf2/read.c (process_full_comp_unit): Add dwarf2_per_objfile
3577         parameter.
3578         (process_full_type_unit): Likewise.
3579         (process_queue): Update.
3580
3581 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3582
3583         * dwarf2/read.c (recursively_compute_inclusions): Add
3584         dwarf2_per_objfile parameter.
3585         (compute_compunit_symtab_includes): Likewise.
3586         (process_cu_includes): Update.
3587
3588 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3589
3590         * dwarf2/read.c (create_partial_symtab): Add dwarf2_per_objfile
3591         parameter.
3592         (create_type_unit_group): Update.
3593         (process_psymtab_comp_unit_reader): Update.
3594         (build_type_psymtabs_reader): Update.
3595
3596 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3597
3598         * dwarf2/read.c (cutu_reader::keep): Access dwarf2_per_objfile
3599         object through m_this_cu->cu.
3600
3601 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
3602
3603         * dwarf2/read.c (queue_and_load_dwo_tu): Expect a dwarf2_cu as
3604         the info parameter.
3605         (queue_and_load_all_dwo_tus): Pass per_cu->cu.
3606
3607 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
3608
3609         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Add
3610         per_objfile parameter.
3611         (load_full_type_unit): Add per_objfile parameter.
3612         (read_signatured_type): Likewise.
3613         (load_full_comp_unit): Likewise.
3614         (load_cu): Likewise.
3615         (dw2_do_instantiate_symtab): Likewise.
3616         (dw2_get_file_names): Likewise.
3617         (dw2_map_symtabs_matching_filename): Update.
3618         (dw_expand_symtabs_matching_file_matcher): Update.
3619         (dw2_map_symbol_filenames): Update.
3620         (process_psymtab_comp_unit): Add per_objfile parameter.
3621         (build_type_psymtabs_1): Update.
3622         (process_skeletonless_type_unit): Update.
3623         (dwarf2_build_psymtabs_hard): Update.
3624         (load_partial_comp_unit): Add per_objfile parameter.
3625         (scan_partial_symbols): Update.
3626         (load_full_comp_unit): Add per_objfile parameter.
3627         (process_imported_unit_die): Update.
3628         (create_cus_hash_table): Update.
3629         (find_partial_die): Update.
3630         (dwarf2_read_addr_index): Update.
3631         (follow_die_offset): Update.
3632         (dwarf2_fetch_die_loc_sect_off): Update.
3633         (dwarf2_fetch_constant_bytes): Update.
3634         (dwarf2_fetch_die_type_sect_off): Update.
3635         (follow_die_sig_1): Update.
3636         (load_full_type_unit): Add per_objfile parameter.
3637         (read_signatured_type): Likewise.
3638
3639 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3640
3641         * dwarf2/read.c (lookup_dwo_unit): Use bfd_get_filename instead
3642         of objfile_name.
3643
3644 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
3645
3646         * dwarf2/read.h (struct dwarf2_per_bfd) <obfd>: New member.
3647         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
3648         * dwarf2/read.c (dwarf2_per_bfd::dwarf2_per_bfd): Assign obfd
3649         field.
3650         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
3651         (create_cus_from_index): Update.
3652         (dwarf2_read_gdb_index): Update.
3653         (create_cus_from_debug_names): Update.
3654         (dwarf2_read_debug_names): Update.
3655         (get_abbrev_section_for_cu): Update.
3656         (create_all_comp_units): Update.
3657         (read_attribute_value): Update.
3658         (get_debug_line_section): Update.
3659         * dwarf2/index-cache.c (index_cache::store): Update.
3660         * dwarf2/index-write.c (save_gdb_index_command): Update.
3661         * dwarf2/macro.c (dwarf_decode_macro_bytes): Update.
3662
3663 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
3664
3665         * dwarf2/read.h (struct dwarf2_per_cu_data) <per_bfd>: New
3666         member.
3667         * dwarf2/read.c (dwarf2_per_bfd::allocate_per_cu): Initialize
3668         dwarf2_per_cu_data::per_bfd.
3669         (dwarf2_per_bfd::allocate_signatured_type): Likewise.
3670         (create_type_unit_group): Likewise.
3671         (queue_comp_unit): Remove reference to
3672         per_cu->dwarf2_per_objfile.
3673         (maybe_queue_comp_unit): Likewise.
3674         (fill_in_sig_entry_from_dwo_entry): Assign new field.
3675         (create_cus_hash_table): Assign new field.
3676
3677 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3678
3679         * dwarf2/read.c: Replace
3680         dwarf2_cu->per_cu->dwarf2_per_objfile references with
3681         dwarf2_cu->per_objfile throughout.
3682
3683 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3684
3685         * dwarf2/read.c (dw2_do_instantiate_symtab): Add per_objfile
3686         parameter, don't use per_cu->dwarf2_per_objfile.
3687         (dw2_instantiate_symtab): Likewise.
3688         (dw2_find_last_source_symtab): Update.
3689         (dw2_map_expand_apply): Update.
3690         (dw2_lookup_symbol): Update.
3691         (dw2_expand_symtabs_for_function): Update.
3692         (dw2_expand_all_symtabs): Update.
3693         (dw2_expand_symtabs_with_fullname): Update.
3694         (dw2_expand_symtabs_matching_one): Add per_objfile parameter,
3695         don't use per_cu->dwarf2_per_objfile.
3696         (dw2_expand_marked_cus): Update.
3697         (dw2_find_pc_sect_compunit_symtab): Update.
3698         (dw2_debug_names_lookup_symbol): Update.
3699         (dw2_debug_names_expand_symtabs_for_function): Update.
3700         (dw2_debug_names_map_matching_symbols): Update.
3701         (dwarf2_psymtab::expand_psymtab): Update.
3702
3703 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3704
3705         * dwarf2/read.c (struct dwarf2_cu) <dwarf2_cu>: Add parameter.
3706         <per_objfile>: New member.
3707         (class cutu_reader) <init_tu_and_read_dwo_dies>: Add parameter.
3708         (cutu_reader::init_tu_and_read_dwo_dies): Add parameter, update
3709         call to dwarf2_cu.
3710         (cutu_reader::cutu_reader): Update.
3711         (dwarf2_cu::dwarf2_cu): Add parameter, initialize per_objfile.
3712
3713 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3714
3715         * dwarf2/read.h (struct dwarf2_per_bfd) <die_type_hash>: Move to
3716         struct dwarf2_per_objfile.
3717         (struct dwarf2_per_objfile) <die_type_hash>: Move from struct
3718         dwarf2_per_bfd.
3719         * dwarf2/read.c (set_die_type): Update.
3720         (get_die_type_at_offset): Update.
3721
3722 2020-05-27  Tom Tromey  <tom@tromey.com>
3723             Simon Marchi  <simon.marchi@efficios.com>
3724
3725         * dwarf2/read.h (struct dwarf2_per_bfd) <num_psymtabs>: New
3726         method.
3727         (struct dwarf2_per_objfile) <resize_symtabs, symtab_set_p,
3728         get_symtab, set_symtab>: New methods.
3729         <m_symtabs>: New field.
3730         (struct dwarf2_psymtab): Derive from partial_symtab.
3731         <readin_p, get_compunit_symtab>: Declare methods.
3732         * dwarf2/read.c (dwarf2_per_objfile::symtab_set_p,
3733         dwarf2_per_objfile::get_symtab, dwarf2_per_objfile::set_symtab):
3734         New methods.
3735         (struct dwarf2_per_cu_quick_data) <compunit_symtab>: Remove.
3736         (dw2_do_instantiate_symtab, dw2_instantiate_symtab)
3737         (dw2_map_expand_apply, dw2_map_symtabs_matching_filename)
3738         (dw2_symtab_iter_next, dw2_print_stats)
3739         (dw2_expand_symtabs_with_fullname)
3740         (dw2_expand_symtabs_matching_one)
3741         (dw_expand_symtabs_matching_file_matcher)
3742         (dw2_find_pc_sect_compunit_symtab, dw2_map_symbol_filenames)
3743         (dw2_debug_names_iterator::next)
3744         (dw2_debug_names_map_matching_symbols)
3745         (fill_in_sig_entry_from_dwo_entry, dwarf2_psymtab::read_symtab)
3746         (process_queue, dwarf2_psymtab::expand_psymtab): Update.
3747         (dwarf2_psymtab::readin_p, dwarf2_psymtab::get_compunit_symtab):
3748         New methods.
3749         (get_compunit_symtab, process_full_comp_unit)
3750         (process_full_type_unit): Update.
3751         (dwarf2_build_psymtabs, dwarf2_initialize_objfile, add_type_unit): Call
3752
3753 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
3754
3755         * dwarf2/read.h (dwarf2_per_objfile): Rename to dwarf2_per_bfd,
3756         then introduce a new dwarf2_per_objfile type.
3757         <read_line_string>: Move to the new dwarf2_per_objfile type.
3758         <objfile>: Likewise.
3759         (dwarf2_per_bfd): Rename dwarf2_per_objfile to this.
3760         * dwarf2/read.c: Replace references to dwarf2_per_objfile with
3761         dwarf2_per_objfile->per_bfd.
3762         (dwarf2_per_objfile::dwarf2_per_objfile): Rename to...
3763         (dwarf2_per_bfd::dwarf2_per_bfd): ... this.
3764         (dwarf2_per_objfile::free_cached_comp_units): Rename to...
3765         (dwarf2_per_bfd::free_cached_comp_units): ... this.
3766         (dwarf2_has_info): Allocate dwarf2_per_bfd.
3767         (dwarf2_per_objfile::locate_sections): Rename to...
3768         (dwarf2_per_bfd::locate_sections): ... this.
3769         (dwarf2_per_objfile::get_cutu): Rename to...
3770         (dwarf2_per_bfd::get_cutu): ... this.
3771         (dwarf2_per_objfile::get_cu): Rename to...
3772         (dwarf2_per_bfd::get_cu): ... this.
3773         (dwarf2_per_objfile::get_tu): Rename to...
3774         (dwarf2_per_bfd::get_tu): ... this.
3775         (dwarf2_per_objfile::allocate_per_cu): Rename to...
3776         (dwarf2_per_bfd::allocate_per_cu): ... this.
3777         (dwarf2_per_objfile::allocate_signatured_type): Rename to...
3778         (dwarf2_per_bfd::allocate_signatured_type): ... this.
3779         (get_gdb_index_contents_ftype): Change parameter from
3780         dwarf2_per_objfile to dwarf2_per_bfd.
3781         * dwarf2/macro.c, dwarf2/index-write.c: Replace references to
3782         dwarf2_per_objfile with dwarf2_per_objfile->per_bfd.
3783
3784 2020-05-27  Tom Tromey  <tom@tromey.com>
3785             Simon Marchi  <simon.marchi@efficios.com>
3786
3787         * dwarf2/loc.c (struct piece_closure) <per_objfile>: New member.
3788         (allocate_piece_closure): Set "per_objfile" member.
3789         (dwarf2_find_location_expression, dwarf2_locexpr_baton_eval)
3790         (locexpr_describe_location, loclist_describe_location): Use new
3791         member.
3792         * dwarf2/read.c (read_call_site_scope)
3793         (mark_common_block_symbol_computed, attr_to_dynamic_prop)
3794         (dwarf2_const_value_attr, dwarf2_fetch_die_loc_sect_off)
3795         (fill_in_loclist_baton, dwarf2_symbol_mark_computed,
3796         handle_data_member_location): Set per_objfile member.
3797         * dwarf2/loc.h (struct dwarf2_locexpr_baton) <per_objfile>: New
3798         member.
3799         (struct dwarf2_loclist_baton) <per_objfile>: New member.
3800
3801 2020-05-27  Tom Tromey  <tom@tromey.com>
3802
3803         * dwarf2/read.h (struct dwarf2_per_objfile) <allocate_per_cu,
3804         allocate_signatured_type>: Declare new methods.
3805         <m_num_psymtabs>: New member.
3806         (struct dwarf2_per_cu_data) <index>: New member.
3807         * dwarf2/read.c (dwarf2_per_objfile::allocate_per_cu)
3808         (dwarf2_per_objfile::allocate_signatured_type): New methods.
3809         (create_cu_from_index_list): Use allocate_per_cu.
3810         (create_signatured_type_table_from_index)
3811         (create_signatured_type_table_from_debug_names)
3812         (create_debug_type_hash_table, add_type_unit)
3813         (read_comp_units_from_section): Use allocate_signatured_type.
3814
3815 2020-05-27  Tom Tromey  <tom@tromey.com>
3816
3817         * psymtab.c (partial_map_expand_apply)
3818         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
3819         (psym_lookup_global_symbol_language)
3820         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
3821         (psym_print_stats, psym_expand_symtabs_for_function)
3822         (psym_map_symbol_filenames, psym_map_matching_symbols)
3823         (psym_expand_symtabs_matching)
3824         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
3825         (maintenance_check_psymtabs): Update.
3826         * psympriv.h (struct partial_symtab) <readin_p,
3827         get_compunit_symtab>: Add objfile parameter.
3828         (struct standard_psymtab) <readin_p, get_compunit_symtab>:
3829         Likewise.
3830         * dwarf2/read.c (struct dwarf2_include_psymtab) <readin_p,
3831         get_compunit_symtab>: Likewise.
3832         (dwarf2_psymtab::expand_psymtab): Pass objfile argument.
3833
3834 2020-05-27  Tom Tromey  <tom@tromey.com>
3835
3836         * dwarf2/read.h (struct dwarf2_per_objfile) <obstack>: New
3837         member.
3838         * dwarf2/read.c (delete_file_name_entry): Fix comment.
3839         (create_cu_from_index_list)
3840         (create_signatured_type_table_from_index)
3841         (create_signatured_type_table_from_debug_names)
3842         (dw2_get_file_names_reader, dwarf2_initialize_objfile)
3843         (dwarf2_create_include_psymtab)
3844         (create_debug_type_hash_table, add_type_unit)
3845         (create_type_unit_group, read_comp_units_from_section)
3846         (dwarf2_compute_name, create_cus_hash_table)
3847         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
3848         (create_dwo_unit_in_dwp_v2, open_and_init_dwp_file): Use new
3849         obstack.
3850         (dw2_get_real_path): Likewise.  Change argument to
3851         dwarf2_per_objfile.
3852
3853 2020-05-27  Luis Machado  <luis.machado@linaro.org>
3854
3855         PR tdep/26000
3856         * arm-tdep.c (thumb_analyze_prologue): Fix instruction matching
3857         for ldrd (immediate).
3858
3859 2020-05-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3860
3861         * command.h: Add comment giving the name of class_tui.
3862         * cli/cli-cmds.c (_initialize_cli_cmds): If TUI defined,
3863         create the fake command for the help for class_tui.
3864
3865 2020-05-26  Tom Tromey  <tromey@adacore.com>
3866
3867         * ada-lang.c (ada_print_array_index): Change type.  Call val_atr.
3868         (ada_value_ptr_subscript): Don't call pos_atr on the lower bound.
3869         (val_atr): New function.
3870         (value_val_atr): Use it.
3871         * ada-valprint.c (print_optional_low_bound): Change low bound
3872         handling for enums.
3873         (val_print_packed_array_elements): Don't call discrete_position.
3874         * gdbtypes.c (get_discrete_bounds) <TYPE_CODE_RANGE>: Call
3875         discrete_position for enum types.
3876         * language.c (default_print_array_index): Change type.
3877         * language.h (struct language_defn) <la_print_array_index>: Add
3878         index_type parameter, change type of index_value.
3879         (LA_PRINT_ARRAY_INDEX): Add index_type parameter.
3880         (default_print_array_index): Update.
3881         * valprint.c (maybe_print_array_index): Don't call
3882         value_from_longest.  Update.
3883         (value_print_array_elements): Don't call discrete_position.
3884
3885 2020-05-26  Tom Tromey  <tromey@adacore.com>
3886
3887         * ada-lang.c (value_val_atr): Handle TYPE_CODE_RANGE.
3888         * gdbtypes.c (discrete_position): Handle TYPE_CODE_RANGE.
3889
3890 2020-05-25  Cristiano De Alti  <cristiano_dealti@hotmail.com>
3891
3892         PR gdb/13519
3893         * avr-tdep.c (avr_integer_to_address): Return data or code
3894         address accordingly to the second 'type' argument of the
3895         function.
3896
3897 2020-05-25  Michael Weghorn  <m.weghorn@posteo.de>
3898
3899         * infcmd.c, inferior.h: (construct_inferior_arguments):
3900         Moved function from here to gdbsupport/common-inferior.{h,cc}
3901
3902 2020-05-23  Tom Tromey  <tom@tromey.com>
3903
3904         Revert commit eca1f90c:
3905         * NEWS: Remove entry for completion styling.
3906         * completer.c (_rl_completion_prefix_display_length): Move
3907         declaration later.
3908         (gdb_fnprint): Revert.
3909         (gdb_display_match_list_1): Likewise.
3910         * cli/cli-style.c (completion_prefix_style)
3911         (completion_difference_style, completion_suffix_style): Remove.
3912         (_initialize_cli_style): Revert.
3913         * cli/cli-style.h (completion_prefix_style)
3914         (completion_difference_style, completion_suffix_style): Don't
3915         declare.
3916
3917 2020-05-24  Pedro Alves  <palves@redhat.com>
3918
3919         * symtab.c (completion_list_add_name): Return boolean indication
3920         of whether the symbol matched.
3921         (completion_list_add_symbol): Don't try to remove C++ aliases if
3922         the symbol didn't match in the first place.
3923         * symtab.h (completion_list_add_name): Return bool.
3924
3925 2020-05-23  Simon Marchi  <simon.marchi@polymtl.ca>
3926
3927         * gdbtypes.h (TYPE_FIELD): Remove.  Replace all uses with
3928         type::field.
3929
3930 2020-05-23  Joel Brobecker  <brobecker@adacore.com>
3931
3932         GDB 9.2 released.
3933
3934 2020-05-23  Tom Tromey  <tom@tromey.com>
3935
3936         * NEWS: Add entry for completion styling.
3937         * completer.c (_rl_completion_prefix_display_length): Move
3938         declaration earlier.
3939         (gdb_fnprint): Use completion_style.
3940         (gdb_display_match_list_1): Likewise.
3941         * cli/cli-style.c (completion_prefix_style)
3942         (completion_difference_style, completion_suffix_style): New
3943         globals.
3944         (_initialize_cli_style): Register new globals.
3945         * cli/cli-style.h (completion_prefix_style)
3946         (completion_difference_style, completion_suffix_style): Declare.
3947
3948 2020-05-23  Pedro Alves  <palves@redhat.com>
3949
3950         * utils.c: Include "gdbsupport/gdb-safe-ctype.h".
3951         (parse_escape): Use ISDIGIT instead of isdigit.
3952         (puts_debug): Use gdb_isprint instead of isprint.
3953         (fprintf_symbol_filtered): Use ISALNUM instead of isalnum.
3954         (cp_skip_operator_token, skip_ws, strncmp_iw_with_mode): Use
3955         ISSPACE instead of isspace.
3956         (strncmp_iw_with_mode): Use TOLOWER instead of tolower and ISSPACE
3957         instead of isspace.
3958         (strcmp_iw_ordered): Use ISSPACE instead of isspace.
3959         (string_to_core_addr): Use TOLOWER instead of tolower, ISXDIGIT
3960         instead of isxdigit and ISDIGIT instead of isdigit.
3961
3962 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
3963
3964         * gdbtypes.h (struct type) <field>: New method.
3965         (TYPE_FIELDS): Remove, replace all uses with either type::fields
3966         or type::field.
3967
3968 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
3969
3970         * gdbtypes.h (struct type) <fields, set_fields>: New methods.
3971         (TYPE_FIELDS): Use type::fields.  Change all call sites that
3972         modify the propery to use type::set_fields instead.
3973
3974 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
3975
3976         * gdbtypes.h (TYPE_NFIELDS): Remove.  Change all cal sites to use
3977         type::num_fields instead.
3978
3979 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
3980
3981         * gdbtypes.h (struct type) <num_fields, set_num_fields>: New
3982         methods.
3983         (TYPE_NFIELDS): Use type::num_fields.  Change all call sites
3984         that modify the number of fields to use type::set_num_fields
3985         instead.
3986
3987 2020-05-22  Tom Tromey  <tromey@adacore.com>
3988
3989         * compile/compile-object-load.h (munmap_list_free): Don't
3990         declare.
3991
3992 2020-05-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3993
3994         * annotate.c (annotate_source_line): Update return type, add call
3995         to update current symtab and line.
3996         * annotate.h (annotate_source_line): Update return type, and
3997         extend header comment.
3998         * source.c (info_line_command): Check annotation_level before
3999         calling annotate_source_line.
4000         * stack.c (print_frame_info): If calling annotate_source_line
4001         returns true, then don't print any other source line information.
4002
4003 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
4004
4005         * lm32-tdep.c (lm32_register_reggroup_p): Fix condition.
4006
4007 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
4008
4009         * coffread.c (patch_type): Remove NULL check before xfree.
4010         * corefile.c (set_gnutarget): Likewise.
4011         * cp-abi.c (set_cp_abi_as_auto_default): Likewise.
4012         * exec.c (build_section_table): Likewise.
4013         * remote.c (remote_target::pass_signals): Likewise.
4014         * utils.c (n_spaces): Likewise.
4015         * cli/cli-script.c (document_command): Likewise.
4016         * i386-windows-tdep.c (core_process_module_section): Likewise.
4017         * linux-fork.c (struct fork_info) <~fork_info>: Likewise.
4018
4019 2020-05-20  Simon Marchi  <simon.marchi@efficios.com>
4020
4021         * symfile.c (reread_symbols): Clear objfile's section_offsets
4022         vector and section indices, re-compute them by calling
4023         sym_offsets.
4024
4025 2020-05-20  Tom Tromey  <tromey@adacore.com>
4026
4027         * ada-lang.c (bound_name, MAX_ADA_DIMENS): Remove.
4028         (desc_one_bound, desc_index_type): Compute field name.
4029
4030 2020-05-20  Tom de Vries  <tdevries@suse.de>
4031
4032         PR symtab/25833
4033         * dwarf2/read.c (dw2_map_matching_symbols): Handle .gdb_index.
4034
4035 2020-05-20  Alan Modra  <amodra@gmail.com>
4036
4037         PR 25993
4038         * solib-darwin.c (darwin_bfd_open): Don't strdup pathname for
4039         bfd_set_filename.
4040         * solib-aix.c (solib_aix_bfd_open): Use std::string for name
4041         passed to bfd_set_filename.
4042         * symfile-mem.c (add_vsyscall_page): Likewise for string
4043         passed to symbol_file_add_from_memory.
4044         (symbol_file_add_from_memory): Make name param a const char* and
4045         don't strdup.
4046
4047 2020-05-20  Alan Modra  <amodra@gmail.com>
4048
4049         * coff-pe-read.c (read_pe_exported_syms): Use bfd_get_filename
4050         rather than accessing bfd->filename directly.
4051         * dtrace-probe.c (dtrace_static_probe_ops::get_probes): Likewise,
4052         and use bfd_section_name.
4053         * dwarf2/frame.c (decode_frame_entry): Likewise.
4054         * exec.c (exec_set_section_address): Likewise.
4055         * solib-aix.c (solib_aix_bfd_open): Likewise.
4056         * stap-probe.c (get_stap_base_address): Likewise.
4057         * symfile.c (reread_symbols): Likewise.
4058
4059 2020-05-19  Tom Tromey  <tromey@adacore.com>
4060
4061         * sparc64-tdep.c (adi_tag_fd): Update call to target_fileio_open.
4062
4063 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
4064
4065         * dwarf2/read.c (quirk_rust_enum): Allocate enough fields.
4066
4067 2020-05-19  Pedro Alves  <palves@redhat.com>
4068
4069         * NEWS (set exec-file-mismatch): Adjust entry.
4070         * exec.c: Include "build-id.h".
4071         (validate_exec_file): Try to match build IDs instead of filenames.
4072         * gdb_bfd.c (struct gdb_bfd_open_closure): New.
4073         (gdb_bfd_iovec_fileio_open): Adjust to use gdb_bfd_open_closure
4074         and pass down 'warn_if_slow'.
4075         (gdb_bfd_open): Add 'warn_if_slow' parameter.  Use
4076         gdb_bfd_open_closure to pass it down.
4077         * gdb_bfd.h (gdb_bfd_open): Add 'warn_if_slow' parameter.
4078
4079 2020-05-19  Pedro Alves  <palves@redhat.com>
4080
4081         * gdb_bfd.c (gdb_bfd_iovec_fileio_open): Adjust.
4082         * target.c (target_fileio_open_1): Rename to target_fileio_open
4083         and make extern.  Use bool.
4084         (target_fileio_open, target_fileio_open_warn_if_slow): Delete.
4085         (target_fileio_read_alloc_1): Adjust.
4086         * target.h (target_fileio_open): Add 'warn_if_slow' parameter.
4087         (target_fileio_open_warn_if_slow): Delete declaration.
4088
4089 2020-05-19  Pedro Alves  <palves@redhat.com>
4090
4091         * gdb_bfd.h: (gdb_bfd_open): Default to 'fd' parameter to -1.
4092         Adjust all callers.
4093
4094 2020-05-19  Yoshinori Sato  <ysato@users.sourceforge.jp>
4095
4096         * h8300-tdep.c (h8300_is_argument_spill): Change how we check
4097         whether disp is negative.
4098
4099 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
4100
4101         * symfile.h (struct symfile_segment_data)
4102         <~symfile_segment_data>: Remove.
4103         <segment_info>: Change to std::vector.
4104         * symfile.c (default_symfile_segments): Update.
4105         * elfread.c (elf_symfile_segments): Update.
4106
4107 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
4108
4109         * symfile.h (struct symfile_segment_data) <struct segment>: New.
4110         <segments>: New.
4111         <segment_bases, segment_sizes>: Remove.
4112         * symfile.c (default_symfile_segments): Update.
4113         * elfread.c (elf_symfile_segments): Update.
4114         * remote.c (remote_target::get_offsets): Update.
4115         * solib-target.c (solib_target_relocate_section_addresses):
4116         Update.
4117
4118 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
4119
4120         * symfile.h (struct symfile_segment_data): Initialize fields.
4121         <~symfile_segment_data>: Add.
4122         (symfile_segment_data_up): New.
4123         (struct sym_fns) <sym_segments>: Return a
4124         symfile_segment_data_up.
4125         (default_symfile_segments): Return a symfile_segment_data_up.
4126         (free_symfile_segment_data): Remove.
4127         (get_symfile_segment_data): Return a symfile_segment_data_up.
4128         * symfile.c (default_symfile_segments): Likewise.
4129         (get_symfile_segment_data): Likewise.
4130         (free_symfile_segment_data): Remove.
4131         (symfile_find_segment_sections): Update.
4132         * elfread.c (elf_symfile_segments): Return a
4133         symfile_segment_data_up.
4134         * remote.c (remote_target::get_offsets): Update.
4135         * solib-target.c (solib_target_relocate_section_addresses):
4136         Update.
4137         * symfile-debug.c (debug_sym_segments): Return a
4138         symfile_segment_data_up.
4139
4140 2020-05-18  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4141
4142         PR build/25981
4143         * i386-sol2-nat.c [PR_MODEL_NATIVE != PR_MODEL_LP64] (regmap):
4144         Hardcode register numbers.
4145
4146         PR build/25981
4147         * procfs.c [(__i386__ || __x86_64__) && sun] (proc_get_LDT_entry,
4148         procfs_find_LDT_entry): Remove.
4149         * procfs.h [(__i386__ || __x86_64__) && sun] (struct ssd,
4150         procfs_find_LDT_entry): Remove.
4151         * sol-thread.c [(__i386__ || __x86_64__) && sun] (ps_lgetLDT):
4152         Remove.
4153
4154 2020-05-17  Pedro Alves  <palves@redhat.com>
4155             Andrew Burgess  <andrew.burgess@embecosm.com>
4156             Keno Fischer  <keno@juliacomputing.com>
4157
4158         PR gdb/25741
4159         * breakpoint.c (build_target_condition_list): Update comments.
4160         (build_target_command_list): Update comments and skip matching
4161         locations.
4162         (insert_bp_location): Move "set breakpoint auto-hw on" handling to
4163         a separate function.  Simplify "set breakpoint auto-hw off"
4164         handling.
4165         (insert_breakpoints): Update comment.
4166         (tracepoint_locations_match): New parameter.  For breakpoints,
4167         compare location types too, if the caller wants to.
4168         (handle_automatic_hardware_breakpoints): New functions.
4169         (bp_location_is_less_than): Also sort by location type and
4170         hardware breakpoint length.
4171         (update_global_location_list): Handle "set breakpoint auto-hw on"
4172         here.
4173         (update_breakpoint_locations): Ask breakpoint_locations_match to
4174         ignore location types.
4175
4176 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
4177
4178         * gdbtypes.h (TYPE_NAME): Remove.  Change all cal sites to use
4179         type::name instead.
4180
4181 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
4182
4183         * gdbtypes.h (struct type) <name, set_name>: New methods.
4184         (TYPE_CODE): Use type::name.  Change all call sites used to set
4185         the name to use type::set_name instead.
4186
4187 2020-05-16  Tom Tromey  <tom@tromey.com>
4188
4189         * top.c (quit_force): Update.
4190         * infrun.c (handle_no_resumed): Update.
4191         * top.h (all_uis): New function.
4192         (ALL_UIS): Remove.
4193
4194 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
4195
4196         * mips-linux-tdep.c (mips_linux_in_dynsym_stub): Fix condition.
4197
4198 2020-05-16  Pedro Alves  <palves@redhat.com>
4199
4200         * ia64-linux-nat.c
4201         (ia64_linux_nat_target) <enable_watchpoints_in_psr(ptid_t)>:
4202         Declare method.
4203         (enable_watchpoints_in_psr): Now a method of ia64_linux_nat_target.
4204
4205 2020-05-15  Simon Marchi  <simon.marchi@efficios.com>
4206
4207         * sparc64-tdep.c (adi_stat_t): Remove typedef (leaving struct).
4208         (sparc64_adi_info): Likewise.
4209
4210 2020-05-15  Tom Tromey  <tom@tromey.com>
4211
4212         * symtab.c (lookup_language_this, lookup_symbol_aux): Use
4213         block_objfile.
4214         (lookup_objfile_from_block): Remove.
4215         (lookup_symbol_in_block, lookup_symbol_in_static_block)
4216         (lookup_global_symbol): Use block_objfile.
4217         * symtab.h (lookup_objfile_from_block): Don't declare.
4218         * printcmd.c (clear_dangling_display_expressions): Use
4219         block_objfile.
4220         * parse.c (operator_check_standard): Use block_objfile.
4221
4222 2020-05-15  Tom Tromey  <tom@tromey.com>
4223
4224         * language.c (language_alloc_type_symbol): Set
4225         SYMBOL_SECTION.
4226         * symtab.c (initialize_objfile_symbol): Remove.
4227         (allocate_symbol): Remove.
4228         (allocate_template_symbol): Remove.
4229         * dwarf2/read.c (fixup_go_packaging): Use "new".
4230         (new_symbol): Use "new".
4231         (read_variable): Don't call initialize_objfile_symbol.  Use
4232         "new".
4233         (read_func_scope): Use "new".
4234         * xcoffread.c (process_xcoff_symbol): Don't call
4235         initialize_objfile_symbol.
4236         (SYMBOL_DUP): Remove.
4237         * coffread.c (process_coff_symbol, coff_read_enum_type): Use
4238         "new".
4239         * symtab.h (allocate_symbol, initialize_objfile_symbol)
4240         (allocate_template_symbol): Don't declare.
4241         (struct symbol): Add copy constructor.  Change defaults.
4242         * jit.c (finalize_symtab): Use "new".
4243         * ctfread.c (ctf_add_enum_member_cb, new_symbol, ctf_add_var_cb):
4244         Use "new".
4245         * stabsread.c (patch_block_stabs, define_symbol, read_enum_type)
4246         (common_block_end): Use "new".
4247         * mdebugread.c (parse_symbol): Use "new".
4248         (new_symbol): Likewise.
4249
4250 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4251
4252         * NEWS: Mention changes to help and apropos.
4253
4254 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4255
4256         * command.h (enum command_class): Improve comments, document
4257         that class_alias is for user-defined aliases, give the class
4258         name for each class, remove unused class_xdb.
4259         * cli/cli-decode.c (add_com_alias): Document THECLASS intended usage.
4260         * breakpoint.c (_initialize_breakpoint): Replace class_alias
4261         by a precise class.
4262         * infcmd.c (_initialize_infcmd): Likewise.
4263         * reverse.c (_initialize_reverse): Likewise.
4264         * stack.c (_initialize_stack): Likewise.
4265         * symfile.c (_initialize_symfile): Likewise.
4266         * tracepoint.c (_initialize_tracepoint): Likewise.
4267
4268 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4269
4270         * cli/cli-decode.c (apropos_cmd): Produce output for aliases
4271         when their aliased command is traversed.
4272         (help_cmd): Add fput_command_names_styled call to
4273         output command name and aliases when command has an alias.
4274
4275 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4276
4277         * cli/cli-decode.h (help_cmd_list): Remove declaration.
4278         * cli/cli-decode.c (help_cmd_list): Declare as static,
4279         remove prefix argument, use bool for recurse arg, rework to show the aliases of
4280         a command together with the command.
4281         (fput_command_name_styled, fput_command_names_styled): New functions.
4282         (print_help_for_command): Remove prefix arg, use bool for recurse arg, use
4283         fput_command_name_styled.
4284         (help_list, help_all): Update callers to remove prefix arg and use bool recurse.
4285         * cli/cli-cmds.c (_initialize_cli_cmds): Update alias_command doc.
4286
4287 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4288
4289         * cli/cli-setshow.h (cmd_show_list): Remove prefix argument.
4290         * cli/cli-decode.c (do_show_prefix_cmd): Likewise.
4291         * command.h (cmd_show_list): Likewise.
4292         * dwarf2/index-cache.c (show_index_cache_command): Likewise.
4293         * cli/cli-setshow.c (cmd_show_list): Use the prefix to produce the output.  Skip aliases.
4294
4295 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4296
4297         * unittests/command-def-selftests.c (traverse_command_structure):
4298         Verify all commands of a list have the same prefix command and
4299         that only the top cmdlist commands have a null prefix.
4300
4301 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4302
4303         * cli/cli-decode.c (lookup_cmd_for_prefix): Return the aliased command
4304         as prefix, not one of its aliases.
4305         (set_cmd_prefix): Remove.
4306         (do_add_cmd): Centralize the setting of the prefix of a command, when
4307         command is defined after its full chain of prefix commands.
4308         (add_alias_cmd): Remove call to set_cmd_prefix, as do_add_cmd does it.
4309         (add_setshow_cmd_full): Likewise.
4310         (update_prefix_field_of_prefixed_commands): New function.
4311         (add_prefix_cmd): Replace non working call to set_cmd_prefix by
4312         update_prefix_field_of_prefixed_commands.
4313         * gdb/remote-fileio.c (initialize_remote_fileio): Use the real
4314         addresses of remote_set_cmdlist and remote_show_cmdlist given
4315         as argument, not the address of an argument.
4316         * gdb/remote-fileio.h (initialize_remote_fileio): Likewise.
4317         * gdb/remote.c (_initialize_remote): Likewise.
4318
4319 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4320
4321         * cli/cli-cmds.c (alias_command): Check for an existing alias
4322         using lookup_cmd_composition, as valid_command_p is too strict
4323         and forbids aliases that are the prefix of an existing alias
4324         or command.
4325         * cli/cli-decode.c (lookup_cmd_composition): Ensure a prefix
4326         command is properly recognised as a valid command.
4327
4328 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4329
4330         * unittests/help-doc-selftests.c: Rename to
4331         unittests/command-def-selftests.c
4332         * unittests/command-def-selftests.c (help_doc_tests): Update some
4333         comments.
4334         (command_structure_tests, traverse_command_structure): New namespace
4335         and function.
4336         (command_structure_invariants_tests): New function.
4337         (_initialize_command_def_selftests) Renamed from
4338         _initialize_help_doc_selftests, register command_structure_invariants
4339         selftest.
4340
4341 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4342
4343         * cli/cli-cmds.c (_initialize_cli_cmds): Define 'info set' as
4344         an alias of 'show'.
4345
4346 2020-05-15  Joel Brobecker  <brobecker@adacore.com>
4347
4348         * ada-lang.h: (ada_is_gnat_encoded_fixed_point_type): Renames
4349         ada_is_fixed_point_type.  Update all callers.
4350         (gnat_encoded_fixed_point_delta): Renames ada_delta.  Update
4351         all callers.
4352         * ada-lang.c (gnat_encoded_fixed_type_info): Renames fixed_type_info.
4353         Update all callers.
4354         * ada-typeprint.c (print_gnat_encoded_fixed_point_type): Renames
4355         print_fixed_point_type.  Update all callers.
4356         * ada-valprint.c (ada_value_print_num): Replace call to
4357         ada_is_fixed_point_type by ada_is_gnat_encoded_fixed_point_type.
4358
4359 2020-05-14  Kevin Buettner  <kevinb@redhat.com>
4360
4361         * nat/linux-btrace.c (btrace_this_cpu): Add check for AMD
4362         processors.
4363         (cpu_supports_bts): Add CV_AMD case.
4364
4365 2020-05-14  Laurent Morichetti  <Laurent.Morichetti@amd.com>
4366             Simon Marchi  <simon.marchi@efficios.com>
4367
4368         * infrun.c (stop_all_threads): Collect multiple wait events at
4369         each pass.
4370
4371 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
4372
4373         * gdbtypes.h (TYPE_CODE): Remove.  Change all call sites to use
4374         type::code instead.
4375
4376 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
4377
4378         * gdbtypes.h (struct type) <code, set_code>: New methods.
4379         (TYPE_CODE): Use type::code.  Change all call sites used to set
4380         the code to use type::set_code instead.
4381
4382 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4383             Tom de Vries  <tdevries@suse.de>
4384             Pedro Alves  <palves@redhat.com>
4385
4386         PR threads/25478
4387         * infrun.c (stop_all_threads): Do NOT ignore
4388         TARGET_WAITKIND_NO_RESUMED, TARGET_WAITKIND_THREAD_EXITED,
4389         TARGET_WAITKIND_EXITED, TARGET_WAITKIND_SIGNALLED wait statuses
4390         received.
4391         (handle_no_resumed): Remove code handling a live inferior with no
4392         threads.
4393         * remote.c (has_single_non_exited_thread): New.
4394         (remote_target::update_thread_list): Do not delete a thread if is
4395         the last thread of the process.
4396         * thread.c (thread_select): Call delete_exited_threads instead of
4397         prune_threads.
4398
4399 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4400
4401         * infrun.c (stop_all_threads): Enable/disable thread events of all
4402         targets.  Move a debug message denoting the end of the function
4403         into the SCOPED_EXIT block.
4404
4405 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4406
4407         * process-stratum-target.h: Include <set>.
4408         (all_non_exited_process_targets, switch_to_target_no_thread): New
4409         function declarations.
4410         * process-stratum-target.c (all_non_exited_process_targets)
4411         (switch_to_target_no_thread): New function implementations.
4412
4413 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4414
4415         * infrun.c (handle_inferior_event): Extract out a piece of code
4416         into...
4417         (mark_non_executing_threads): ...this new function.
4418
4419 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4420
4421         * infrun.c (resume_1): Move a 'regcache_read_pc' call down to first
4422         use.
4423
4424 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4425
4426         * regcache.c (regcache_read_pc_protected): New function
4427         implementation that returns 0 if the PC cannot read via
4428         'regcache_read_pc'.
4429         * infrun.c (proceed): Call 'regcache_read_pc_protected'
4430         instead of 'regcache_read_pc'.
4431         (keep_going_pass_signal): Ditto.
4432
4433 2020-05-13  Tom Tromey  <tromey@adacore.com>
4434
4435         * ada-lang.c (align_value): Remove.
4436         (ada_template_to_fixed_record_type_1): Use align_up.
4437
4438 2020-05-13  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4439
4440         * async-event.c: Update the copyright year.
4441         * async-event.h: Update the copyright year.
4442
4443 2020-05-12  Simon Marchi  <simon.marchi@efficios.com>
4444
4445         * objfiles.h (is_addr_in_objfile,
4446         shared_objfile_contains_address_p): Return bool.
4447         * objfile.c (is_addr_in_objfile,
4448         shared_objfile_contains_address_p): Return bool.
4449
4450 2020-05-11  Tom Tromey  <tromey@adacore.com>
4451
4452         * cli/cli-cmds.c (info_command): Restore.
4453         (_initialize_cli_cmds): Use add_prefix_command for "info".
4454         * gdb-gdb.gdb.in: Restore breakpoint on info_command.
4455
4456 2020-05-11  Tom Tromey  <tromey@adacore.com>
4457
4458         * ada-lang.c (ada_value_primitive_field): Now public.
4459         * ada-lang.h (ada_value_primitive_field): Declare.
4460         * ada-valprint.c (print_field_values): Use
4461         ada_value_primitive_field for wrapper fields.
4462
4463 2020-05-11  Tom de Vries  <tdevries@suse.de>
4464
4465         * dwarf2/index-write.c (debug_names::psymbol_tag): Handle
4466         MODULE_DOMAIN.
4467
4468 2020-05-11  Tom de Vries  <tdevries@suse.de>
4469
4470         PR symtab/25941
4471         * dwarf2/read.c (create_cus_from_debug_names_list): Initialize CUs
4472         with length 0, if not gdb-produced.
4473         (cutu_reader::cutu_reader): Set CU length to actual length if 0.
4474
4475 2020-05-09  Tom de Vries  <tdevries@suse.de>
4476
4477         PR gdb/25955
4478         * break-catch-throw.c (check_status_exception_catchpoint): Fix name
4479         calculation.
4480
4481 2020-05-09  Tom Tromey  <tom@tromey.com>
4482
4483         * top.c (server_command): Now bool.
4484         * top.h (server_command): Now bool.
4485
4486 2020-05-08  Tom Tromey  <tromey@adacore.com>
4487
4488         * dwarf2/read.c (read_lexical_block_scope): Don't process a DIE
4489         already being processed.
4490
4491 2020-05-08  Tom Tromey  <tom@tromey.com>
4492
4493         * printcmd.c (struct display) <next>: Remove.
4494         <display>: New constructor.
4495         <exp_string>: Now a std::string.
4496         <enabled_p>: Now a bool.
4497         (display_number): Move definition earlier.
4498         (displays): Rename from display_chain.  Now a std::vector.
4499         (ALL_DISPLAYS, ALL_DISPLAYS_SAFE): Remove.
4500         (display_command): Update.
4501         (do_one_display, disable_display)
4502         (enable_disable_display_command, do_enable_disable_display):
4503         Update.
4504         (free_display): Remove.
4505         (clear_displays): Rewrite.
4506         (delete_display): Update.
4507         (map_display_numbers): Use function_view.  Remove "data"
4508         parameter.  Update.
4509         (do_delete_display): Remove.
4510         (undisplay_command): Update.
4511         (do_one_display, do_displays, disable_display)
4512         (info_display_command): Update.
4513         (do_enable_disable_display): Remove.
4514         (enable_disable_display_command)
4515         (clear_dangling_display_expressions): Update.
4516
4517 2020-05-08  Tom Tromey  <tom@tromey.com>
4518
4519         * symtab.c (set_symbol_cache_size)
4520         (maintenance_print_symbol_cache, maintenance_flush_symbol_cache)
4521         (maintenance_print_symbol_cache_statistics): Update.
4522         * symmisc.c (print_symbol_bcache_statistics)
4523         (print_objfile_statistics, maintenance_print_objfiles)
4524         (maintenance_info_symtabs, maintenance_check_symtabs)
4525         (maintenance_expand_symtabs, maintenance_info_line_tables):
4526         Update.
4527         * symfile-debug.c (set_debug_symfile): Update.
4528         * source.c (forget_cached_source_info): Update.
4529         * python/python.c (gdbpy_progspaces): Update.
4530         * psymtab.c (maintenance_info_psymtabs): Update.
4531         * probe.c (parse_probes): Update.
4532         * linespec.c (iterate_over_all_matching_symtabs)
4533         (collect_symtabs_from_filename, search_minsyms_for_name): Update.
4534         * guile/scm-progspace.c (gdbscm_progspaces): Update.
4535         * exec.c (exec_target::close): Update.
4536         * ada-tasks.c (ada_tasks_new_objfile_observer): Update.
4537         * breakpoint.c (print_one_breakpoint_location)
4538         (create_longjmp_master_breakpoint)
4539         (create_std_terminate_master_breakpoint): Update.
4540         * progspace.c (program_spaces): Now a std::vector.
4541         (maybe_new_address_space): Update.
4542         (add_program_space): Remove.
4543         (program_space::program_space): Update.
4544         (remove_program_space): Update.
4545         (number_of_program_spaces): Remove.
4546         (print_program_space, update_address_spaces): Update.
4547         * progspace.h (program_spaces): Change type.
4548         (ALL_PSPACES): Remove.
4549         (number_of_program_spaces): Don't declare.
4550         (struct program_space) <next>: Remove.
4551
4552 2020-05-08  Tom Tromey  <tom@tromey.com>
4553
4554         * mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries): Update.
4555         * solib-svr4.c (svr4_fetch_objfile_link_map): Update.
4556         (enable_break): Update.
4557         * solib-frv.c (frv_fdpic_find_global_pointer): Update.
4558         (frv_fdpic_find_canonical_descriptor): Update.
4559         (frv_fetch_objfile_link_map): Update.
4560         * progspace.c (program_space::free_all_objfiles): Update.
4561         (program_space::solibs): New method.
4562         * progspace.h (struct program_space) <solibs>: New method.
4563         * solist.h (master_so_list): Don't declare.
4564         (ALL_SO_LIBS): Remove.
4565         * solib.h (so_list_head): Remove.
4566         (update_solib_list): Update comment.
4567         * solib.c (master_so_list): Remove.
4568         (solib_used, update_solib_list, solib_add)
4569         (info_sharedlibrary_command, clear_solib)
4570         (reload_shared_libraries_1, remove_user_added_objfile): Update.
4571
4572 2020-05-08  Tom Tromey  <tom@tromey.com>
4573
4574         * extension.c (extension_languages): Now a std::array.
4575         (ALL_EXTENSION_LANGUAGES): Remove.
4576         (get_ext_lang_defn, get_ext_lang_of_file)
4577         (eval_ext_lang_from_control_command): Update.
4578         (finish_ext_lang_initialization)
4579         (auto_load_ext_lang_scripts_for_objfile)
4580         (ext_lang_type_printers::ext_lang_type_printers)
4581         (apply_ext_lang_type_printers)
4582         (ext_lang_type_printers::~ext_lang_type_printers)
4583         (apply_ext_lang_val_pretty_printer, apply_ext_lang_frame_filter)
4584         (preserve_ext_lang_values, get_breakpoint_cond_ext_lang)
4585         (breakpoint_ext_lang_cond_says_stop, check_quit_flag)
4586         (get_matching_xmethod_workers, ext_lang_colorize)
4587         (ext_lang_before_prompt): Update.
4588         (ALL_ENABLED_EXTENSION_LANGUAGES): Remove.
4589
4590 2020-05-08  Tom Tromey  <tom@tromey.com>
4591
4592         * symtab.h (class demangle_result_storage) <set_malloc_ptr>: New
4593         overload.
4594         <swap_string, m_string>: Remove.
4595         * symtab.c (demangle_for_lookup, completion_list_add_symbol):
4596         Update.
4597         * stabsread.c (define_symbol, read_type): Update.
4598         * linespec.c (find_linespec_symbols): Update.
4599         * gnu-v3-abi.c (gnuv3_get_typeid): Update.
4600         * dwarf2/read.c (dwarf2_canonicalize_name): Update.
4601         * dbxread.c (read_dbx_symtab): Update.
4602         * cp-support.h (cp_canonicalize_string_full)
4603         (cp_canonicalize_string, cp_canonicalize_string_no_typedefs):
4604         Return unique_xmalloc_ptr.
4605         * cp-support.c (inspect_type): Update.
4606         (cp_canonicalize_string_full): Return unique_xmalloc_ptr.
4607         (cp_canonicalize_string_no_typedefs, cp_canonicalize_string):
4608         Likewise.
4609         * c-typeprint.c (print_name_maybe_canonical): Update.
4610         * break-catch-throw.c (check_status_exception_catchpoint):
4611         Update.
4612
4613 2020-05-08  Tom de Vries  <tdevries@suse.de>
4614
4615         * infrun.c (follow_fork): Copy current_line and current_symtab to
4616         child thread.
4617
4618 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
4619
4620         * async-event.c (struct async_signal_handler, struct
4621         async_event_handler): Reformat, remove typedef.
4622
4623 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
4624
4625         * gdbtypes.h (TYPE_DYN_PROP_LIST): Remove.  Update all users
4626         access thistype->main_type->dyn_prop_list directly.
4627
4628 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
4629
4630         * gdbtypes.h (struct type) <remove_dyn_prop>: New method.
4631         (remove_dyn_prop): Remove.  Update all users to use
4632         type::remove_dyn_prop.
4633         * gdbtypes.c (remove_dyn_prop): Rename to...
4634         (type::remove_dyn_prop): ... this.
4635
4636 2020-05-07  Simon Marchi via Gdb-patches  <gdb-patches@sourceware.org>
4637
4638         * gdbtypes.h (struct type) <add_dyn_prop>: New method.
4639         (add_dyn_prop): Remove.  Update all users to use
4640         type::add_dyn_prop.
4641         * gdbtypes.c (add_dyn_prop): Rename to...
4642         (type::add_dyn_prop): ... this.
4643
4644 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
4645
4646         * gdbtypes.h (struct type) <get_dyn_prop>: New method.
4647         (get_dyn_prop): Remove.  Update all users to use
4648         type::dyn_prop.
4649         * gdbtypes.c (get_dyn_prop): Rename to...
4650         (type::dyn_prop): ... this.
4651
4652 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
4653
4654         * gdbtypes.h (struct main_type) <flag_static>: Remove.
4655
4656 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
4657
4658         * amd64-tdep.c (amd64_analyze_prologue): Check for `endbr64`
4659         instruction, skip it if it's there.
4660
4661 2020-05-05  Simon Marchi  <simon.marchi@efficios.com>
4662
4663         * gdbtypes.h (struct main_type) <flag_incomplete>: Remove.
4664
4665 2020-05-04  Simon Marchi  <simon.marchi@efficios.com>
4666
4667         * gdbtypes.h (TYPE_INCOMPLETE): Remove.
4668         * gdbtypes.c (recursive_dump_type): Remove use of
4669         TYPE_INCOMPLETE.
4670
4671 2020-05-03  Tom Tromey  <tom@tromey.com>
4672
4673         * breakpoint.c (catch_command, tcatch_command): Remove.
4674         (_initialize_breakpoint): Use add_basic_prefix_cmd,
4675         add_show_prefix_cmd.
4676         (set_breakpoint_cmd, show_breakpoint_cmd): Remove
4677         * utils.c (set_internal_problem_cmd, show_internal_problem_cmd):
4678         Remove.
4679         (add_internal_problem_command): Use add_basic_prefix_cmd,
4680         add_show_prefix_cmd.
4681         * mips-tdep.c (set_mipsfpu_command): Remove.
4682         (_initialize_mips_tdep): Use add_basic_prefix_cmd.
4683         * dwarf2/index-cache.c (set_index_cache_command): Remove.
4684         (_initialize_index_cache): Use add_basic_prefix_cmd.
4685         * memattr.c (dummy_cmd): Remove.
4686         (_initialize_mem): Use add_basic_prefix_cmd, add_show_prefix_cmd.
4687         * tui/tui-win.c (set_tui_cmd, show_tui_cmd): Remove.
4688         (_initialize_tui_win): Use add_basic_prefix_cmd,
4689         add_show_prefix_cmd.
4690         * cli/cli-logging.c (set_logging_command): Remove.
4691         (_initialize_cli_logging): Use add_basic_prefix_cmd,
4692         add_show_prefix_cmd.
4693         (show_logging_command): Remove.
4694         * target.c (target_command): Remove.
4695         (add_target): Use add_basic_prefix_cmd.
4696
4697 2020-05-02  Hannes Domani  <ssbssa@yahoo.de>
4698
4699         * gdbtypes.h (enum dynamic_prop_node_kind): Fix typo.
4700
4701 2020-05-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4702
4703         * gdb-gdb.gdb-in: Remove breakpoint on disappeared function
4704         info_command.
4705
4706 2020-04-30  Kamil Rytarowski  <n54@gmx.com>
4707
4708         * nbsd-nat.c (nbsd_enable_proc_events)
4709         (nbsd_nat_target::post_startup_inferior): Add.
4710         (nbsd_nat_target::post_attach): Call `nbsd_enable_proc_events'.
4711         (nbsd_nat_target::update_thread_list): Rewrite.
4712         (nbsd_nat_target::wait): Handle "PTRACE_LWP_EXIT" and
4713         "PTRACE_LWP_CREATE".
4714         * nbsd-nat.h (nbsd_nat_target::post_startup_inferior): Add.
4715
4716 2020-04-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4717
4718         * stack.c (_initialize_stack): Remove duplicated creation
4719         of "frame" command and "f" alias.
4720
4721 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
4722
4723         PR gdb/18706
4724         * gdbtypes.c (check_typedef): Calculate size of array of
4725         stubbed type.
4726
4727 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
4728
4729         PR gdb/15559
4730         * i386-tdep.c (i386_push_dummy_call): Call
4731         i386_thiscall_push_dummy_call.
4732         (i386_thiscall_push_dummy_call): New function.
4733         * i386-tdep.h (i386_thiscall_push_dummy_call): Declare.
4734         * i386-windows-tdep.c (i386_windows_push_dummy_call): New function.
4735         (i386_windows_init_abi): Call set_gdbarch_push_dummy_call.
4736
4737 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
4738
4739         * gdbarch.sh (do_read): Add shellcheck disable directive for
4740         warning SC2162.
4741
4742 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
4743
4744         * gdbarch.sh: Use ${foo:-} where shellcheck would report a
4745         "referenced but not assigned" warning.
4746
4747 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
4748
4749         * gdbarch.sh: Remove code that sets fallbackdefault.
4750
4751 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
4752
4753         * gdbarch.sh: Use shell operators && and || instead of
4754         -a and -o.
4755
4756 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
4757
4758         * gdbarch.sh: Use $(...) instead of `...`.
4759
4760 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
4761
4762         * gdbarch.sh: Use double quotes around variables.
4763
4764 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
4765
4766         * gdbarch.sh: Use %s with printf, instead of variables in the
4767         format string.
4768
4769 2020-04-29  Tom Tromey  <tromey@adacore.com>
4770
4771         PR ada/25875:
4772         * dwarf2/read.c (update_enumeration_type_from_children): Compute
4773         type fields here.
4774         (read_enumeration_type): Call
4775         update_enumeration_type_from_children later.  Update comments.
4776         (process_enumeration_scope): Don't create type fields.
4777
4778 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
4779
4780         * nbsd-tdep.c: Include "xml-syscall.h".
4781         (nbsd_init_abi): Call `set_xml_syscall_file_name'.
4782
4783 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
4784
4785         * nbsd-nat.c: Include "sys/wait.h".
4786         (nbsd_resume, nbsd_nat_target::resume, nbsd_wait)
4787         (nbsd_nat_target::wait, nbsd_nat_target::insert_exec_catchpoint)
4788         (nbsd_nat_target::remove_exec_catchpoint)
4789         (nbsd_nat_target::set_syscall_catchpoint): Add.
4790         * nbsd-nat.h (nbsd_nat_target::resume, nbsd_nat_target::wait)
4791         (nbsd_nat_target::insert_exec_catchpoint)
4792         (nbsd_nat_target::remove_exec_catchpoint)
4793         (nbsd_nat_target::set_syscall_catchpoint): Add.
4794         * nbsd-tdep.c (nbsd_get_syscall_number): Add.
4795         (nbsd_init_abi): Call `set_gdbarch_get_syscall_number' and pass
4796         `nbsd_get_syscall_number'.
4797
4798 2020-04-29  Tom Tromey  <tom@tromey.com>
4799
4800         * stack.c (print_block_frame_labels): Remove.
4801
4802 2020-04-29  Hannes Domani  <ssbssa@yahoo.de>
4803
4804         PR gdb/17320
4805         * ada-valprint.c (val_print_packed_array_elements): Move array
4806         end bracket to new line.
4807         (ada_val_print_string): Remove extra spaces before first array
4808         element.
4809         * c-valprint.c (c_value_print_array): Likewise.
4810         * m2-valprint.c (m2_print_array_contents): Likewise.
4811         (m2_value_print_inner): Likewise.
4812         * p-valprint.c (pascal_value_print_inner): Likewise.
4813         * valprint.c (generic_val_print_array): Likewise.
4814         (value_print_array_elements): Move first array element and array
4815         end bracket to new line.
4816
4817 2020-04-29  Tom de Vries  <tdevries@suse.de>
4818
4819         PR symtab/25889
4820         * linespec.c (find_method): Fix ix calculation.
4821
4822 2020-04-28  Kamil Rytarowski  <n54@gmx.com>
4823
4824         * syscalls/update-netbsd.sh: New file.
4825         * syscalls/netbsd.xml: Regenerate.
4826         * data-directory/Makefile.in: Register `netbsd.xml' in
4827         `SYSCALLS_FILES'.
4828
4829 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
4830
4831         * syscalls/update-freebsd.sh: Add double quotes.
4832
4833 2020-04-28  Tom Tromey  <tom@tromey.com>
4834
4835         * NEWS: Update.
4836         * python/py-cmd.c (gdbpy_initialize_commands): Add COMMAND_TUI.
4837         (cmdpy_init): Allow class_tui.
4838
4839 2020-04-28 Mark Williams <mark@myosotissp.com>
4840
4841         PR gdb/24480
4842         * dwarf2read.c: Add missing assingments to list_in_scope when
4843         start_symtab was already called.
4844
4845 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
4846
4847         PR gdb/25881
4848         * dwarf2/read.c (offset_map_type): Use
4849         gdb:hash_enum<sect_offset> as hash function.
4850
4851 2020-04-28  Tom de Vries  <tdevries@suse.de>
4852
4853         * dwarf2/read.c (process_structure_scope): Add symbol for struct decl
4854         with DW_AT_signature.
4855
4856 2020-04-27  Simon Marchi  <simon.marchi@efficios.com>
4857
4858         * configure.ac: Remove check for fs_base/gs_base in
4859         user_regs_struct.
4860         * configure: Re-generate.
4861         * config.in: Re-generate.
4862         * amd64-nat.c (amd64_native_gregset_reg_offset): Adjust.
4863         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers,
4864         amd64_linux_nat_target::store_registers, ps_get_thread_area, ): Adjust.
4865
4866 2020-04-27  Luis Machado  <luis.machado@linaro.org>
4867
4868         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Handle
4869         problematic inline frame unwinding situation.
4870         * frame.c (frame_id_computed_p): New function.
4871         * frame.h (frame_id_computed_p): New prototype.
4872
4873 2020-04-26  Tom Tromey  <tom@tromey.com>
4874
4875         * command.h (enum command_class) <class_pseudo>: Remove.
4876
4877 2020-04-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4878
4879         * cli/cli-decode.c (lookup_cmd_composition): Fix comments
4880         and whitespace.
4881
4882 2020-04-25  Kamil Rytarowski  <n54@gmx.com>
4883
4884         * inf-ptrace.c (inf_ptrace_target::wait): Remove
4885         `PT_GET_PROCESS_STATE' block.
4886
4887 2020-04-24  Tom Tromey  <tom@tromey.com>
4888
4889         * symtab.h (symbol_get_demangled_name): Don't declare.
4890         * symtab.c (symbol_get_demangled_name): Remove.
4891         (general_symbol_info::natural_name)
4892         (general_symbol_info::demangled_name): Update.
4893
4894 2020-04-24  Tom Tromey  <tom@tromey.com>
4895
4896         PR rust/25025:
4897         * dwarf2/read.c (dwarf2_physname): Do not demangle for Rust.
4898
4899 2020-04-24  Tom Tromey  <tom@tromey.com>
4900
4901         PR symtab/12707:
4902         * dwarf2/read.c (add_partial_symbol): Use the linkage name if it
4903         exists.
4904         (new_symbol): Likewise.
4905         * compile/compile-object-load.c (get_out_value_type): Use
4906         symbol_matches_search_name.
4907
4908 2020-04-24  Tom Tromey  <tom@tromey.com>
4909
4910         * dwarf2/read.c (add_partial_symbol): Do not call
4911         compute_and_set_names.
4912
4913 2020-04-24  Tom Tromey  <tom@tromey.com>
4914
4915         * dwarf2/read.c (add_partial_symbol): Use new add_psymbol_to_list
4916         overload.
4917
4918 2020-04-24  Tom Tromey  <tom@tromey.com>
4919
4920         * psymtab.c (add_psymbol_to_bcache): Simplify calling convention.
4921         (add_psymbol_to_list): New overload.  Make old overload call new
4922         one.
4923         * psympriv.h (add_psymbol_to_list): New overload.
4924
4925 2020-04-24  Tom Tromey  <tom@tromey.com>
4926
4927         * dwarf2/read.c (partial_die_info::read) <case
4928         DW_AT_linkage_name>: Use value_as_string.
4929         (dwarf2_string_attr): Use value_as_string.
4930         * dwarf2/attribute.h (struct attribute) <value_as_string>: Declare
4931         method.
4932         * dwarf2/attribute.c (attribute::value_as_string): New method.
4933
4934 2020-04-24  Tom Tromey  <tom@tromey.com>
4935
4936         * symtab.c (general_symbol_info::natural_name)
4937         (general_symbol_info::demangled_name): Check for language_rust.
4938
4939 2020-04-24  Tom Tromey  <tom@tromey.com>
4940
4941         * dwarf2/read.c (dw2_linkage_name): Move Rust "{" hack here...
4942         (dwarf2_physname): ... from here.
4943         (partial_die_info::read): Add Rust "{" hack.
4944
4945 2020-04-24  Tom Tromey  <tom@tromey.com>
4946
4947         * symtab.h (struct general_symbol_info) <set_demangled_name>: New
4948         method.
4949         (symbol_set_demangled_name): Don't declare.
4950         * symtab.c (general_symbol_info::set_demangled_name): Rename from
4951         symbol_set_demangled_name.
4952         (general_symbol_info::set_language)
4953         (general_symbol_info::compute_and_set_names): Update.
4954         * minsyms.c (minimal_symbol_reader::install): Update.
4955         * dwarf2/read.c (new_symbol): Update.
4956
4957 2020-04-24  Tom Tromey  <tromey@adacore.com>
4958
4959         PR python/23662:
4960         * python/py-type.c (convert_field): Handle
4961         FIELD_LOC_KIND_DWARF_BLOCK.
4962         (typy_get_sizeof): Handle TYPE_HAS_DYNAMIC_LENGTH.
4963         (typy_get_dynamic): Nw function.
4964         (type_object_getset): Add "dynamic".
4965         * NEWS: Add entry.
4966
4967 2020-04-24  Tom Tromey  <tromey@adacore.com>
4968
4969         * ada-typeprint.c (print_choices, print_variant_part)
4970         (print_record_field_types_dynamic): New functions.
4971         (print_record_field_types): Use print_record_field_types_dynamic.
4972
4973 2020-04-24  Tom Tromey  <tromey@adacore.com>
4974
4975         * dwarf2/read.c (handle_data_member_location): New overload.
4976         (dwarf2_add_field): Use it.
4977         (decode_locdesc): Add "computed" parameter.  Update comment.
4978         * gdbtypes.c (is_dynamic_type_internal): Also look for
4979         FIELD_LOC_KIND_DWARF_BLOCK.
4980         (resolve_dynamic_struct): Handle FIELD_LOC_KIND_DWARF_BLOCK.
4981         * gdbtypes.c (is_dynamic_type_internal): Add special case for C++
4982         virtual base classes.
4983         * gnu-v3-abi.c (gnuv3_baseclass_offset): Handle
4984         FIELD_LOC_KIND_DWARF_BLOCK.
4985
4986 2020-04-24  Tom Tromey  <tromey@adacore.com>
4987
4988         * dwarf2/read.c (read_structure_type): Handle dynamic length.
4989         * gdbtypes.c (is_dynamic_type_internal): Check
4990         TYPE_HAS_DYNAMIC_LENGTH.
4991         (resolve_dynamic_type_internal): Use TYPE_DYNAMIC_LENGTH.
4992         * gdbtypes.h (TYPE_HAS_DYNAMIC_LENGTH, TYPE_DYNAMIC_LENGTH):
4993         New macros.
4994         (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_SIZE>: New
4995         constant.
4996
4997 2020-04-24  Tom Tromey  <tromey@adacore.com>
4998
4999         * dwarf2/read.c (struct variant_field): Rewrite.
5000         (struct variant_part_builder): New.
5001         (struct nextfield): Remove "variant" field.  Add "offset".
5002         (struct field_info): Add "current_variant_part" and
5003         "variant_parts".
5004         (alloc_discriminant_info): Remove.
5005         (alloc_rust_variant): New function.
5006         (quirk_rust_enum): Update.
5007         (dwarf2_add_field): Set "offset" member.  Don't handle
5008         DW_TAG_variant_part.
5009         (offset_map_type): New typedef.
5010         (convert_variant_range, create_one_variant)
5011         (create_one_variant_part, create_variant_parts)
5012         (add_variant_property): New functions.
5013         (dwarf2_attach_fields_to_type): Call add_variant_property.
5014         (read_structure_type): Don't handle DW_TAG_variant_part.
5015         (handle_variant_part, handle_variant): New functions.
5016         (handle_struct_member_die): Use them.
5017         (process_structure_scope): Don't handle variant parts.
5018         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): Remove.
5019         (struct discriminant_info): Remove.
5020         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: Remove.
5021         (struct main_type) <flag_discriminated_union>: Remove.
5022         * rust-lang.c (rust_enum_p, rust_empty_enum_p): Rewrite.
5023         (rust_enum_variant): Return int.  Remove "contents".  Rewrite.
5024         (rust_print_enum, rust_print_struct_def, rust_evaluate_subexp):
5025         Update.
5026         * valops.c (value_union_variant): Remove.
5027         * value.h (value_union_variant): Don't declare.
5028
5029 2020-04-24  Tom Tromey  <tromey@adacore.com>
5030
5031         * ada-lang.c (ada_discrete_type_high_bound, ada_discrete_type_low)
5032         (ada_value_primitive_packed_val): Update.
5033         * ada-valprint.c (ada_value_print_1): Update.
5034         * dwarf2/loc.c (evaluate_for_locexpr_baton): New struct.
5035         (dwarf2_locexpr_baton_eval): Take a property_addr_info rather than
5036         just an address.  Use evaluate_for_locexpr_baton.
5037         (dwarf2_evaluate_property): Update.
5038         * dwarf2/loc.h (struct property_addr_info) <valaddr>: Now an
5039         array_view.
5040         * findvar.c (default_read_var_value): Update.
5041         * gdbtypes.c (compute_variant_fields_inner)
5042         (resolve_dynamic_type_internal): Update.
5043         (resolve_dynamic_type): Change type of valaddr parameter.
5044         * gdbtypes.h (resolve_dynamic_type): Update.
5045         * valarith.c (value_subscripted_rvalue): Update.
5046         * value.c (value_from_contents_and_address): Update.
5047
5048 2020-04-24  Tom Tromey  <tromey@adacore.com>
5049
5050         * dwarf2/loc.c (dwarf2_locexpr_baton_eval): Add
5051         "push_initial_value" parameter.
5052         (dwarf2_evaluate_property): Likewise.
5053         * dwarf2/loc.h (dwarf2_evaluate_property): Update.
5054
5055 2020-04-24  Tom Tromey  <tromey@adacore.com>
5056
5057         * gdbtypes.c (is_dynamic_type_internal): Check for variant parts.
5058         (variant::matches, compute_variant_fields_recurse)
5059         (compute_variant_fields_inner, compute_variant_fields): New
5060         functions.
5061         (resolve_dynamic_struct): Check for DYN_PROP_VARIANT_PARTS.
5062         Use resolved_type after type is made.
5063         (operator==): Add new cases.
5064         * gdbtypes.h (TYPE_HAS_VARIANT_PARTS): New macro.
5065         (struct discriminant_range, struct variant, struct variant_part):
5066         New.
5067         (union dynamic_prop_data) <variant_parts, original_type>: New
5068         members.
5069         (enum dynamic_prop_node_kind) <DYN_PROP_VARIANT_PARTS>: New constant.
5070         (enum dynamic_prop_kind) <PROP_TYPE, PROP_VARIANT_PARTS>: New
5071         constants.
5072         * value.c (unpack_bits_as_long): Now public.
5073         * value.h (unpack_bits_as_long): Declare.
5074
5075 2020-04-24  Tom Tromey  <tromey@adacore.com>
5076
5077         * rs6000-tdep.c (struct ppc_variant): Rename from "variant".
5078         (variants, find_variant_by_arch, rs6000_gdbarch_init): Update.
5079
5080 2020-04-24  Hannes Domani  <ssbssa@yahoo.de>
5081
5082         * windows-tdep.c (exception_values): Add WOW64 exception numbers.
5083
5084 2020-04-24  Kamil Rytarowski  <n54@gmx.com>
5085
5086         * inf-ptrace.h (follow_fork, insert_fork_catchpoint)
5087         (remove_fork_catchpoint, post_startup_inferior)
5088         (post_attach): Move...
5089         * obsd-nat.h (follow_fork, insert_fork_catchpoint)
5090         (remove_fork_catchpoint, post_startup_inferior)
5091         (post_attach): ...here.
5092         * inf-ptrace.c (follow_fork, insert_fork_catchpoint)
5093         (remove_fork_catchpoint, post_startup_inferior)
5094         (post_attach): Move...
5095         * obsd-nat.c (follow_fork, insert_fork_catchpoint)
5096         (remove_fork_catchpoint, post_startup_inferior)
5097         (post_attach): ...here.
5098
5099 2020-04-24  Tom Tromey  <tromey@adacore.com>
5100
5101         * nat/windows-nat.h (struct windows_thread_info)
5102         <pc_adjusted>: New member.
5103         * windows-nat.c (windows_fetch_one_register): Check
5104         pc_adjusted.
5105         (windows_nat_target::get_windows_debug_event)
5106         (windows_nat_target::wait): Set pc_adjusted.
5107
5108 2020-04-24  Tom de Vries  <tdevries@suse.de>
5109
5110         * contrib/cc-with-tweaks.sh: Remove <exec>.gdb-index file handling.
5111         Run gdb-add-index inside temp dir.
5112
5113 2020-04-23  Tom Tromey  <tromey@adacore.com>
5114
5115         * windows-tdep.c (is_linked_with_cygwin_dll): Always update "iter"
5116         in loop.
5117
5118 2020-04-23  Luis Machado  <luis.machado@linaro.org>
5119
5120         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Use
5121         get_frame_register instead of gdbarch_unwind_pc.
5122
5123 2020-04-23  Tom de Vries  <tdevries@suse.de>
5124
5125         * symtab.c (lookup_global_symbol): Prefer def over decl.
5126
5127 2020-04-23  Tom de Vries  <tdevries@suse.de>
5128
5129         PR symtab/25807
5130         * block.c (best_symbol, better_symbol): Promote to external.
5131         * block.h (best_symbol, better_symbol): Declare.
5132         * symtab.c (lookup_symbol_in_objfile_symtabs): Prefer def over
5133         decl.
5134
5135 2020-04-23  Tom Tromey  <tromey@adacore.com>
5136
5137         PR ada/25837:
5138         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Store a
5139         "const char *", not a "const std::string &".
5140         <name_and_matcher::operator==>: Update.
5141         * unittests/lookup_name_info-selftests.c: Change type of
5142         "result".
5143
5144 2020-04-23  Tom Tromey  <tom@tromey.com>
5145
5146         * inferior.h (iterate_over_inferiors): Don't declare.
5147         * inferior.c (iterate_over_inferiors): Remove.
5148         * darwin-nat.c (find_inferior_task_it, find_inferior_pid_it):
5149         Remove.
5150         (darwin_find_inferior_by_task, darwin_find_inferior_by_pid): Don't
5151         use iterate_over_inferiors.
5152         (darwin_resume_inferior_it)
5153         (struct resume_inferior_threads_param)
5154         (darwin_resume_inferior_threads_it): Remove.
5155         (darwin_nat_target::resume): Don't use iterate_over_inferiors.
5156
5157 2020-04-23  Tom de Vries  <tdevries@suse.de>
5158
5159         * blockframe.c (find_pc_partial_function): Use
5160         find_pc_sect_compunit_symtab rather than
5161         objfile->sf->qf->find_pc_sect_compunit_symtab.
5162
5163 2020-04-22  Tom de Vries  <tdevries@suse.de>
5164
5165         PR symtab/25764
5166         * dwarf2/read.c (scan_partial_symbols): Allow external variable decls
5167         in psymtabs.
5168
5169 2020-04-22  Tom de Vries  <tdevries@suse.de>
5170
5171         PR symtab/25801
5172         * psymtab.c (psym_map_symtabs_matching_filename): Don't skip shared
5173         symtabs.
5174
5175 2020-04-22  Tom de Vries  <tdevries@suse.de>
5176
5177         PR symtab/25700
5178         * dwarf2/read.c (dwarf2_build_psymtabs_hard): Don't create psymtab for
5179         CU if already created.
5180
5181 2020-04-21  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5182
5183         * infrun.c (displaced_step_fixup): Switch to the event_thread
5184         before calling displaced_step_restore, not after.
5185
5186 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
5187
5188         * record-btrace.c (record_btrace_enable_warn): Ignore thread if
5189         its inferior is not recorded by us.
5190         (record_btrace_target_open): Replace call to
5191         all_non_exited_threads () with call to current_inferior
5192         ()->non_exited_threads ().
5193         (record_btrace_target::stop_recording): Likewise.
5194         (record_btrace_target::close): Likewise.
5195         (record_btrace_target::wait): Likewise.
5196         (record_btrace_target::record_stop_replaying): Likewise.
5197
5198 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
5199
5200         * btrace.c (btrace_enable): Throw an error on double enables and
5201         when enabling recording fails.
5202         (btrace_disable): Throw an error if the thread is not recorded.
5203
5204 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
5205
5206         * record-btrace.c (record_btrace_target::fetch_registers): Forward
5207         request if we do not have a thread_info.
5208
5209 2020-04-21  Tom de Vries  <tdevries@suse.de>
5210
5211         PR gdb/25471
5212         * thread.c
5213         (scoped_restore_current_thread::scoped_restore_current_thread): Catch
5214         exception in get_frame_id.
5215
5216 2020-04-20  Tom Tromey  <tromey@adacore.com>
5217
5218         * python/python.c (struct gdbpy_event): Mark move constructor as
5219         noexcept.
5220         * python/py-tui.c (class gdbpy_tui_window_maker): Mark move
5221         constructor as noexcept.
5222         * completer.h (struct completion_result): Mark move constructor as
5223         noexcept.
5224         * completer.c (completion_result::completion_result): Use
5225         initialization style.  Don't call reset_match_list.
5226
5227 2020-04-20  Mihails Strasuns  <mihails.strasuns@intel.com>
5228
5229         * MAINTAINERS (Write After Approval): Add myself.
5230
5231 2020-04-18  Tom Tromey  <tom@tromey.com>
5232
5233         * windows-tdep.c (init_w32_command_list)
5234         (w32_prefix_command_valid): Restore.
5235         (_initialize_windows_tdep): Call init_w32_command_list.
5236
5237 2020-04-18  Tom Tromey  <tom@tromey.com>
5238
5239         * xcoffread.c (enter_line_range, scan_xcoff_symtab): Update.
5240         * value.c (value_fn_field): Update.
5241         * valops.c (find_function_in_inferior)
5242         (value_allocate_space_in_inferior): Update.
5243         * tui/tui-winsource.c (tui_update_source_windows_with_line):
5244         Update.
5245         * tui/tui-source.c (tui_source_window::set_contents): Update.
5246         * symtab.c (lookup_global_or_static_symbol)
5247         (find_function_start_sal_1, skip_prologue_sal)
5248         (print_msymbol_info, find_gnu_ifunc, symbol_arch): Update.
5249         * symmisc.c (dump_msymbols, dump_symtab_1)
5250         (maintenance_print_one_line_table): Update.
5251         * symfile.c (init_entry_point_info, section_is_mapped)
5252         (list_overlays_command, simple_read_overlay_table)
5253         (simple_overlay_update_1): Update.
5254         * stap-probe.c (handle_stap_probe): Update.
5255         * stabsread.c (dbx_init_float_type, define_symbol)
5256         (read_one_struct_field, read_enum_type, read_range_type): Update.
5257         * source.c (info_line_command): Update.
5258         * python/python.c (gdbpy_source_objfile_script)
5259         (gdbpy_execute_objfile_script): Update.
5260         * python/py-type.c (save_objfile_types): Update.
5261         * python/py-objfile.c (py_free_objfile): Update.
5262         * python/py-inferior.c (python_new_objfile): Update.
5263         * psymtab.c (psym_find_pc_sect_compunit_symtab, dump_psymtab)
5264         (dump_psymtab_addrmap_1, maintenance_info_psymtabs)
5265         (maintenance_check_psymtabs): Update.
5266         * printcmd.c (info_address_command): Update.
5267         * objfiles.h (struct objfile) <arch>: New method, from
5268         get_objfile_arch.
5269         (get_objfile_arch): Don't declare.
5270         * objfiles.c (get_objfile_arch): Remove.
5271         (filter_overlapping_sections): Update.
5272         * minsyms.c (msymbol_is_function): Update.
5273         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines)
5274         (output_nondebug_symbol): Update.
5275         * mdebugread.c (parse_symbol, basic_type, parse_partial_symbols)
5276         (mdebug_expand_psymtab): Update.
5277         * machoread.c (macho_add_oso_symfile): Update.
5278         * linux-tdep.c (linux_infcall_mmap, linux_infcall_munmap):
5279         Update.
5280         * linux-fork.c (checkpoint_command): Update.
5281         * linespec.c (convert_linespec_to_sals): Update.
5282         * jit.c (finalize_symtab): Update.
5283         * infrun.c (insert_exception_resume_from_probe): Update.
5284         * ia64-tdep.c (ia64_find_unwind_table): Update.
5285         * hppa-tdep.c (internalize_unwinds): Update.
5286         * gdbtypes.c (get_type_arch, init_float_type, objfile_type):
5287         Update.
5288         * gcore.c (call_target_sbrk): Update.
5289         * elfread.c (record_minimal_symbol, elf_symtab_read)
5290         (elf_rel_plt_read, elf_gnu_ifunc_record_cache)
5291         (elf_gnu_ifunc_resolve_by_got): Update.
5292         * dwarf2/read.c (create_addrmap_from_index)
5293         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5294         (read_debug_names_from_section)
5295         (process_psymtab_comp_unit_reader, add_partial_symbol)
5296         (add_partial_subprogram, process_full_comp_unit)
5297         (read_file_scope, read_func_scope, read_lexical_block_scope)
5298         (read_call_site_scope, dwarf2_ranges_read)
5299         (dwarf2_record_block_ranges, dwarf2_add_field)
5300         (mark_common_block_symbol_computed, read_tag_pointer_type)
5301         (read_tag_string_type, dwarf2_init_float_type)
5302         (dwarf2_init_complex_target_type, read_base_type)
5303         (partial_die_info::read, partial_die_info::read)
5304         (read_attribute_value, dwarf_decode_lines_1, new_symbol)
5305         (dwarf2_fetch_die_loc_sect_off): Update.
5306         * dwarf2/loc.c (dwarf2_find_location_expression)
5307         (class dwarf_evaluate_loc_desc, rw_pieced_value)
5308         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval)
5309         (dwarf2_loc_desc_get_symbol_read_needs)
5310         (locexpr_describe_location_piece, locexpr_describe_location_1)
5311         (loclist_describe_location): Update.
5312         * dwarf2/index-write.c (write_debug_names): Update.
5313         * dwarf2/frame.c (dwarf2_build_frame_info): Update.
5314         * dtrace-probe.c (dtrace_process_dof): Update.
5315         * dbxread.c (read_dbx_symtab, dbx_end_psymtab)
5316         (process_one_symbol): Update.
5317         * ctfread.c (ctf_init_float_type, read_base_type): Update.
5318         * coffread.c (coff_symtab_read, enter_linenos, decode_base_type)
5319         (coff_read_enum_type): Update.
5320         * cli/cli-cmds.c (edit_command, list_command): Update.
5321         * buildsym.c (buildsym_compunit::finish_block_internal): Update.
5322         * breakpoint.c (create_overlay_event_breakpoint)
5323         (create_longjmp_master_breakpoint)
5324         (create_std_terminate_master_breakpoint)
5325         (create_exception_master_breakpoint, get_sal_arch): Update.
5326         * block.c (block_gdbarch): Update.
5327         * annotate.c (annotate_source_line): Update.
5328
5329 2020-04-17  Tom Tromey  <tromey@adacore.com>
5330
5331         * auto-load.c (show_auto_load_cmd): Remove.
5332         (auto_load_show_cmdlist_get): Use add_show_prefix_cmd.
5333         * arc-tdep.c (_initialize_arc_tdep): Use add_show_prefix_cmd.
5334         (maintenance_print_arc_command): Remove.
5335         * tui/tui-win.c (tui_command): Remove.
5336         (tui_get_cmd_list): Use add_basic_prefix_cmd.
5337         * tui/tui-layout.c (tui_layout_command): Remove.
5338         (_initialize_tui_layout): Use add_basic_prefix_cmd.
5339         * python/python.c (user_set_python, user_show_python): Remove.
5340         (_initialize_python): Use add_basic_prefix_cmd,
5341         add_show_prefix_cmd.
5342         * guile/guile.c (set_guile_command, show_guile_command): Remove.
5343         (install_gdb_commands): Use add_basic_prefix_cmd,
5344         add_show_prefix_cmd.
5345         (info_guile_command): Remove.
5346         * dwarf2/read.c (set_dwarf_cmd, show_dwarf_cmd): Remove.
5347         (_initialize_dwarf2_read): Use add_basic_prefix_cmd,
5348         add_show_prefix_cmd.
5349         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
5350         Remove do_set and do_show parameters.
5351         * cli/cli-style.c (set_style, show_style): Remove.
5352         (_initialize_cli_style): Use add_basic_prefix_cmd,
5353         add_show_prefix_cmd.
5354         (cli_style_option::add_setshow_commands): Remove do_set and
5355         do_show parameters.
5356         (cli_style_option::add_setshow_commands): Use
5357         add_basic_prefix_cmd, add_show_prefix_cmd.
5358         (STYLE_ADD_SETSHOW_COMMANDS): Remove macro.
5359         (set_style_name): Remove.
5360         * cli/cli-dump.c (dump_command, append_command): Remove.
5361         (srec_dump_command, ihex_dump_command, verilog_dump_command)
5362         (tekhex_dump_command, binary_dump_command)
5363         (binary_append_command): Remove.
5364         (_initialize_cli_dump): Use add_basic_prefix_cmd.
5365         * windows-tdep.c (w32_prefix_command_valid): Remove global.
5366         (init_w32_command_list): Remove; move into ...
5367         (_initialize_windows_tdep): ... here.  Use add_basic_prefix_cmd.
5368         * valprint.c (set_print, show_print, set_print_raw)
5369         (show_print_raw): Remove.
5370         (_initialize_valprint): Use add_basic_prefix_cmd,
5371         add_show_prefix_cmd.
5372         * typeprint.c (set_print_type, show_print_type): Remove.
5373         (_initialize_typeprint): Use add_basic_prefix_cmd,
5374         add_show_prefix_cmd.
5375         * record.c (set_record_command, show_record_command): Remove.
5376         (_initialize_record): Use add_basic_prefix_cmd,
5377         add_show_prefix_cmd.
5378         * cli/cli-cmds.c (_initialize_cli_cmds): Use add_basic_prefix_cmd,
5379         add_show_prefix_cmd.
5380         (info_command, show_command, set_debug, show_debug): Remove.
5381         * top.h (set_history, show_history): Don't declare.
5382         * top.c (set_history, show_history): Remove.
5383         * target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
5384         (unset_tdesc_cmd): Remove.
5385         (_initialize_target_descriptions): Use add_basic_prefix_cmd,
5386         add_show_prefix_cmd.
5387         * symtab.c (info_module_command): Remove.
5388         (_initialize_symtab): Use add_basic_prefix_cmd.
5389         * symfile.c (overlay_command): Remove.
5390         (_initialize_symfile): Use add_basic_prefix_cmd.
5391         * sparc64-tdep.c (info_adi_command): Remove.
5392         (_initialize_sparc64_adi_tdep): Use add_basic_prefix_cmd.
5393         * sh-tdep.c (show_sh_command, set_sh_command): Remove.
5394         (_initialize_sh_tdep): Use add_basic_prefix_cmd,
5395         add_show_prefix_cmd.
5396         * serial.c (serial_set_cmd, serial_show_cmd): Remove.
5397         (_initialize_serial): Use add_basic_prefix_cmd,
5398         add_show_prefix_cmd.
5399         * ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Remove.
5400         (_initialize_ser_tcp): Use add_basic_prefix_cmd,
5401         add_show_prefix_cmd.
5402         * rs6000-tdep.c (set_powerpc_command, show_powerpc_command)
5403         (_initialize_rs6000_tdep): Use add_basic_prefix_cmd,
5404         add_show_prefix_cmd.
5405         * riscv-tdep.c (show_riscv_command, set_riscv_command)
5406         (show_debug_riscv_command, set_debug_riscv_command): Remove.
5407         (_initialize_riscv_tdep): Use add_basic_prefix_cmd,
5408         add_show_prefix_cmd.
5409         * remote.c (remote_command, set_remote_cmd): Remove.
5410         (_initialize_remote): Use add_basic_prefix_cmd.
5411         * record-full.c (set_record_full_command)
5412         (show_record_full_command): Remove.
5413         (_initialize_record_full): Use add_basic_prefix_cmd,
5414         add_show_prefix_cmd.
5415         * record-btrace.c (cmd_set_record_btrace)
5416         (cmd_show_record_btrace, cmd_set_record_btrace_bts)
5417         (cmd_show_record_btrace_bts, cmd_set_record_btrace_pt)
5418         (cmd_show_record_btrace_pt): Remove.
5419         (_initialize_record_btrace): Use add_basic_prefix_cmd,
5420         add_show_prefix_cmd.
5421         * ravenscar-thread.c (set_ravenscar_command)
5422         (show_ravenscar_command): Remove.
5423         (_initialize_ravenscar): Use add_basic_prefix_cmd,
5424         add_show_prefix_cmd.
5425         * mips-tdep.c (show_mips_command, set_mips_command)
5426         (_initialize_mips_tdep): Use add_basic_prefix_cmd,
5427         add_show_prefix_cmd.
5428         * maint.c (maintenance_command, maintenance_info_command)
5429         (maintenance_check_command, maintenance_print_command)
5430         (maintenance_set_cmd, maintenance_show_cmd): Remove.
5431         (_initialize_maint_cmds): Use add_basic_prefix_cmd,
5432         add_show_prefix_cmd.
5433         (show_per_command_cmd): Remove.
5434         * maint-test-settings.c (maintenance_set_test_settings_cmd):
5435         Remove.
5436         (maintenance_show_test_settings_cmd): Remove.
5437         (_initialize_maint_test_settings): Use add_basic_prefix_cmd,
5438         add_show_prefix_cmd.
5439         * maint-test-options.c (maintenance_test_options_command):
5440         Remove.
5441         (_initialize_maint_test_options): Use add_basic_prefix_cmd.
5442         * macrocmd.c (macro_command): Remove
5443         (_initialize_macrocmd): Use add_basic_prefix_cmd.
5444         * language.c (set_check, show_check): Remove.
5445         (_initialize_language): Use add_basic_prefix_cmd,
5446         add_show_prefix_cmd.
5447         * infcmd.c (unset_command): Remove.
5448         (_initialize_infcmd): Use add_basic_prefix_cmd.
5449         * i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Remove.
5450         (_initialize_i386_tdep): Use add_basic_prefix_cmd,
5451         add_show_prefix_cmd.
5452         * go32-nat.c (go32_info_dos_command): Remove.
5453         (_initialize_go32_nat): Use add_basic_prefix_cmd.
5454         * cli/cli-decode.c (do_prefix_cmd, add_basic_prefix_cmd)
5455         (do_show_prefix_cmd, add_show_prefix_cmd): New functions.
5456         * frame.c (set_backtrace_cmd, show_backtrace_cmd): Remove.
5457         (_initialize_frame): Use add_basic_prefix_cmd,
5458         add_show_prefix_cmd.
5459         * dcache.c (set_dcache_command, show_dcache_command): Remove.
5460         (_initialize_dcache): Use add_basic_prefix_cmd,
5461         add_show_prefix_cmd.
5462         * cp-support.c (maint_cplus_command): Remove.
5463         (_initialize_cp_support): Use add_basic_prefix_cmd.
5464         * btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
5465         (maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
5466         (maint_btrace_pt_show_cmd, _initialize_btrace): Use
5467         add_basic_prefix_cmd, add_show_prefix_cmd.
5468         * breakpoint.c (save_command): Remove.
5469         (_initialize_breakpoint): Use add_basic_prefix_cmd.
5470         * arm-tdep.c (set_arm_command, show_arm_command): Remove.
5471         (_initialize_arm_tdep): Use add_basic_prefix_cmd,
5472         add_show_prefix_cmd.
5473         * ada-lang.c (maint_set_ada_cmd, maint_show_ada_cmd)
5474         (set_ada_command, show_ada_command): Remove.
5475         (_initialize_ada_language): Use add_basic_prefix_cmd,
5476         add_show_prefix_cmd.
5477         * command.h (add_basic_prefix_cmd, add_show_prefix_cmd): Declare.
5478
5479 2020-04-16  Kamil Rytarowski  <n54@gmx.com>
5480
5481         * nbsd-nat.c (inf_ptrace_target::auxv_parse): Remove.
5482         * nbsd-nat.h (inf_ptrace_target::auxv_parse): Likewise.
5483
5484 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
5485
5486         * windows-tdep.c (is_linked_with_cygwin_dll): Add filename to
5487         warning messages.
5488
5489 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
5490
5491         * windows-tdep.c (is_linked_with_cygwin_dll): Consider case where
5492         import table is not at beginning of .idata section.
5493
5494 2020-04-16  Pedro Alves  <palves@redhat.com>
5495
5496         * inferior.c (delete_inferior): Use delete operator directly
5497         instead of delete_program_space.
5498         * progspace.c (add_program_space): New, factored out from
5499         program_space::program_space.
5500         (remove_program_space): New, factored out from
5501         delete_program_space.
5502         (program_space::program_space): Remove intro comment.  Rewrite.
5503         (program_space::~program_space): Remove intro comment.  Call
5504         remove_program_space.
5505         (delete_program_space): Delete.
5506         * progspace.h (program_space::program_space): Make explicit.  Move
5507         intro comment here, adjusted.
5508         (program_space::~program_space): Move intro comment here,
5509         adjusted.
5510         (delete_program_space): Remove.
5511
5512 2020-04-16  Tom Tromey  <tromey@adacore.com>
5513
5514         * windows-nat.c (windows_nat::handle_access_violation): New
5515         function.
5516         * nat/windows-nat.h (handle_access_violation): Declare.
5517         * nat/windows-nat.c (handle_exception): Move Cygwin code to
5518         windows-nat.c.  Call handle_access_violation.
5519
5520 2020-04-16  Tom de Vries  <tdevries@suse.de>
5521
5522         PR symtab/25791
5523         * dwarf2/index-write.c (write_gdbindex): Generate CU table entries for
5524         CUs without psymtab.
5525
5526 2020-04-16  Kevin Buettner  <kevinb@redhat.com>
5527
5528         * python/python.c (do_start_initialization): Don't call
5529         PyEval_InitThreads for Python 3.9 and beyond.
5530
5531 2020-04-15  Kamil Rytarowski  <n54@gmx.com>
5532
5533         * obsd-nat.c (obsd_nat_target::update_thread_list): Pass "this" to
5534         thread functions.
5535         (obsd_nat_target::wait): Likewise.
5536
5537 2020-04-15  Tom Tromey  <tromey@adacore.com>
5538
5539         * windows-nat.c (DEBUG_EXEC, DEBUG_EVENTS, DEBUG_MEM)
5540         (DEBUG_EXCEPT): Use debug_printf.
5541
5542 2020-04-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5543
5544         * completer.c (class completion_tracker::completion_hash_entry)
5545         <hash_name>: New member function.
5546         (completion_tracker::discard_completions): New callback to hash a
5547         completion_hash_entry, pass this to htab_create_alloc.
5548
5549 2016-01-20  Jon Turney  <jon.turney@dronecode.org.uk>
5550
5551         * windows-nat.c (windows_make_so): Warn rather than stopping with
5552         an error if realpath() fails.
5553
5554 2020-04-14  Kamil Rytarowski  <n54@gmx.com>
5555
5556         * nbsd-nat.c (nbsd_pid_to_kinfo_proc2): New.
5557         (nbsd_nat_target::info_proc): Add do_status.
5558
5559 2020-04-14  Simon Marchi  <simon.marchi@polymtl.ca>
5560             Tom de Vries  <tdevries@suse.de>
5561
5562         PR symtab/25718
5563         * psympriv.h (struct partial_symtab::read_symtab)
5564         (struct partial_symtab::expand_psymtab)
5565         (struct partial_symtab::read_dependencies): Update comments.
5566         * dwarf2/read.c (struct dwarf2_include_psymtab::read_symtab): Call
5567         read_symtab for includer.
5568         (struct dwarf2_include_psymtab::expand_psymtab): Assert false.
5569         (struct dwarf2_include_psymtab::readin_p): Call readin_p () for includer.
5570         (struct dwarf2_include_psymtab::m_readin): Remove.
5571         (struct dwarf2_include_psymtab::includer): New member function.
5572         (dwarf2_psymtab::expand_psymtab): Assert !readin.
5573
5574 2020-04-14  Tom de Vries  <tdevries@suse.de>
5575
5576         PR symtab/25720
5577         * symmisc.c (maintenance_expand_symtabs): Call expand_symtabs_matching
5578         with NULL symbol_matcher and lookup_name.
5579         * psymtab.c (psym_expand_symtabs_matching): Handle NULL symbol_matcher
5580         and lookup_name.
5581         * dwarf2/read.c (dw2_expand_symtabs_matching)
5582         (dw2_debug_names_expand_symtabs_matching): Same.
5583         * symfile.h (struct quick_symbol_functions::expand_symtabs_matching):
5584         Make lookup_name a pointer.  Update comment.
5585         * symtab.c (global_symbol_searcher::expand_symtabs): Handle
5586         lookup_name being a pointer.
5587         * symfile.c (expand_symtabs_matching): Same.
5588         * symfile-debug.c (debug_qf_expand_symtabs_matching): Same.
5589         * linespec.c (iterate_over_all_matching_symtabs): Same.
5590
5591 2020-04-13  Tom Tromey  <tom@tromey.com>
5592
5593         * run-on-main-thread.c: Update include.
5594         * unittests/main-thread-selftests.c: Update include.
5595         * tui/tui-win.c: Update include.
5596         * tui/tui-io.c: Update include.
5597         * tui/tui-interp.c: Update include.
5598         * tui/tui-hooks.c: Update include.
5599         * top.h: Update include.
5600         * top.c: Update include.
5601         * ser-base.c: Update include.
5602         * remote.c: Update include.
5603         * remote-notif.c: Update include.
5604         * remote-fileio.c: Update include.
5605         * record-full.c: Update include.
5606         * record-btrace.c: Update include.
5607         * python/python.c: Update include.
5608         * posix-hdep.c: Update include.
5609         * mingw-hdep.c: Update include.
5610         * mi/mi-main.c: Update include.
5611         * mi/mi-interp.c: Update include.
5612         * main.c: Update include.
5613         * linux-nat.c: Update include.
5614         * interps.c: Update include.
5615         * infrun.c: Update include.
5616         * inf-loop.c: Update include.
5617         * event-top.c: Update include.
5618         * event-loop.c: Move to ../gdbsupport/.
5619         * event-loop.h: Move to ../gdbsupport/.
5620         * async-event.h: Update include.
5621         * Makefile.in (COMMON_SFILES, HFILES_NO_SRCDIR): Update.
5622
5623 2020-04-13  Tom Tromey  <tom@tromey.com>
5624
5625         * tui/tui-win.c: Include async-event.h.
5626         * remote.c: Include async-event.h.
5627         * remote-notif.c: Include async-event.h.
5628         * record-full.c: Include async-event.h.
5629         * record-btrace.c: Include async-event.h.
5630         * infrun.c: Include async-event.h.
5631         * event-top.c: Include async-event.h.
5632         * event-loop.h: Move some declarations to async-event.h.
5633         * event-loop.c: Don't include ser-event.h or top.h.  Move some
5634         code to async-event.c.
5635         * async-event.h: New file.
5636         * async-event.c: New file.
5637         * Makefile.in (COMMON_SFILES): Add async-event.c.
5638         (HFILES_NO_SRCDIR): Add async-event.h.
5639
5640 2020-04-13  Tom Tromey  <tom@tromey.com>
5641
5642         * utils.c (flush_streams): New function.
5643         * event-loop.c (gdb_wait_for_event): Call flush_streams.
5644
5645 2020-04-13  Tom Tromey  <tom@tromey.com>
5646
5647         * event-loop.c (handle_file_event): Use warning, not
5648         printf_unfiltered.
5649
5650 2020-04-13  Tom Tromey  <tom@tromey.com>
5651
5652         * event-loop.c: Include <chrono>.
5653
5654 2020-04-13  Tom Tromey  <tom@tromey.com>
5655
5656         * gdb_select.h: Move to ../gdbsupport/.
5657         * event-loop.c: Update include path.
5658         * top.c: Update include path.
5659         * ser-base.c: Update include path.
5660         * ui-file.c: Update include path.
5661         * ser-tcp.c: Update include path.
5662         * guile/scm-ports.c: Update include path.
5663         * posix-hdep.c: Update include path.
5664         * ser-unix.c: Update include path.
5665         * gdb_usleep.c: Update include path.
5666         * mingw-hdep.c: Update include path.
5667         * inflow.c: Update include path.
5668         * infrun.c: Update include path.
5669         * event-top.c: Update include path.
5670
5671 2020-04-13  Tom Tromey  <tom@tromey.com>
5672
5673         * configure: Rebuild.
5674         * configure.ac: Remove checks that are now in GDB_AC_COMMON.
5675
5676 2020-04-13  Tom Tromey  <tom@tromey.com>
5677
5678         * event-loop.h (start_event_loop): Don't declare.
5679         * event-loop.c (start_event_loop): Move...
5680         * main.c (start_event_loop): ...here.  Now static.
5681
5682 2020-04-13  Sergio Durigan Junior  <sergiodj@sergiodj.net>
5683
5684         * MAINTAINERS: Update my email address.
5685
5686 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
5687
5688         * nbsd-nat.c (nbsd_nat_target::info_proc): Add IP_MINIMAL and
5689         IP_ALL.
5690
5691 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
5692
5693         * nbsd-nat.c (nbsd_pid_to_cmdline): Add.
5694         (nbsd_nat_target::info_proc): Add do_cmdline.
5695
5696 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
5697
5698         * nbsd-nat.c (nbsd_pid_to_cwd): Add.
5699         (nbsd_nat_target::info_proc): Add do_cwd.
5700
5701 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
5702
5703         * nbsd-nat.c (nbsd_nat_target::info_proc): Add do_exe.
5704
5705 2020-04-11  Kamil Rytarowski  <n54@gmx.com>
5706
5707         * nbsd-nat.c; Include "nbsd-tdep.h" and "gdbarch.h".
5708         * nbsd-nat.c (nbsd_nat_target::find_memory_regions)
5709         (nbsd_nat_target::info_proc): New functions.
5710         * nbsd-nat.c (kinfo_get_vmmap): New function.
5711         * nbsd-nat.c (nbsd_nat_target::info_proc) Use
5712         nbsd_info_proc_mappings_header and nbsd_info_proc_mappings_entry.
5713         * nbsd-tdep.c (nbsd_info_proc_mappings_header)
5714         (nbsd_info_proc_mappings_entry, nbsd_vm_map_entry_flags): New
5715         functions.
5716         * nbsd-tdep.c (KINFO_VME_PROT_READ, KINFO_VME_PROT_WRITE)
5717         (KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
5718         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
5719         (KINFO_VME_FLAG_PAGEABLE, KINFO_VME_FLAG_GROWS_UP)
5720         (KINFO_VME_FLAG_GROWS_DOWN): New.
5721
5722 2020-04-10  Artur Shepilko  <nomadbyte@gmail.com>
5723
5724         * utils.c (copy_bitwise): Use unsigned 0 constant as operand of
5725         bit shift.
5726
5727 2020-04-10  Tom Tromey  <tromey@adacore.com>
5728
5729         * symfile.c (symbol_file_add_separate): Preserve OBJF_MAINLINE.
5730
5731 2020-04-10  Tom Tromey  <tromey@adacore.com>
5732
5733         * symtab.c (get_symbol_address, get_msymbol_address): Skip
5734         separate debug files.
5735
5736 2020-04-10  Hannes Domani  <ssbssa@yahoo.de>
5737
5738         * nat/windows-nat.c (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
5739         Move to...
5740         * nat/windows-nat.h (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
5741         ... here.
5742         * windows-nat.c (windows_nat_target::get_windows_debug_event):
5743         Check for STATUS_WX86_BREAKPOINT.
5744         (windows_nat_target::wait): Same.
5745
5746 2020-04-10  Tom de Vries  <tdevries@suse.de>
5747
5748         PR cli/25808
5749         * python/lib/gdb/__init__.py: Initialize lexer with stripnl=False.
5750
5751 2020-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
5752
5753         * MAINTAINERS (Global Maintainers): Add Tom de Vries.
5754         (Write After Approval): Remove Tom de Vries.
5755
5756 2020-04-09  Bernd Edlinger  <bernd.edlinger@hotmail.de>
5757
5758         revert partially:
5759         2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
5760
5761         * buildsym.c (record_line): Fix undefined behavior and preserve
5762         lines at eof.
5763
5764 2020-04-09  Kamil Rytarowski  <n54@gmx.com>
5765
5766         * auxv.h (svr4_auxv_parse): New.
5767         * auxv.c (default_auxv_parse): Split into default_auxv_parse
5768         and generic_auxv_parse.
5769         (svr4_auxv_parse): Add.
5770         * obsd-tdep.c: Include "auxv.h".
5771         (obsd_auxv_parse): Remove.
5772         (obsd_init_abi): Remove comment.
5773         (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument
5774         from `obsd_auxv_parse' to `svr4_auxv_parse'.
5775         * nbsd-tdep.c: Include "auxv.h".
5776         (nbsd_init_abi): Call set_gdbarch_auxv_parse.
5777
5778 2020-04-08  Tom Tromey  <tromey@adacore.com>
5779
5780         * nat/windows-nat.h (last_wait_event): Don't declare.
5781         (wait_for_debug_event): Update comment.
5782         * nat/windows-nat.c (last_wait_event): Now static.
5783
5784 2020-04-08  Tom Tromey  <tromey@adacore.com>
5785
5786         * windows-nat.c (wait_for_debug_event): Move to
5787         nat/windows-nat.c.
5788         * nat/windows-nat.h (wait_for_debug_event): Declare.
5789         * nat/windows-nat.c (wait_for_debug_event): Move from
5790         windows-nat.c.  No longer static.
5791
5792 2020-04-08  Tom Tromey  <tromey@adacore.com>
5793
5794         * windows-nat.c (get_windows_debug_event): Use
5795         fetch_pending_stop.
5796         * nat/windows-nat.h (fetch_pending_stop): Declare.
5797         * nat/windows-nat.c (fetch_pending_stop): New function.
5798
5799 2020-04-08  Tom Tromey  <tromey@adacore.com>
5800
5801         * windows-nat.c (windows_continue): Use matching_pending_stop and
5802         continue_last_debug_event.
5803         * nat/windows-nat.h (matching_pending_stop)
5804         (continue_last_debug_event): Declare.
5805         * nat/windows-nat.c (DEBUG_EVENTS): New define.
5806         (matching_pending_stop, continue_last_debug_event): New
5807         functions.
5808
5809 2020-04-08  Tom Tromey  <tromey@adacore.com>
5810
5811         * windows-nat.c (MS_VC_EXCEPTION): Move to nat/windows-nat.c.
5812         (handle_exception_result): Move to nat/windows-nat.h.
5813         (DEBUG_EXCEPTION_SIMPLE): Remove.
5814         (windows_nat::handle_ms_vc_exception): New function.
5815         (handle_exception): Move to nat/windows-nat.c.
5816         (get_windows_debug_event): Update.
5817         (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP): Move to
5818         nat/windows-nat.c.
5819         * nat/windows-nat.h (handle_ms_vc_exception): Declare.
5820         (handle_exception_result): Move from windows-nat.c.
5821         (handle_exception): Declare.
5822         * nat/windows-nat.c (MS_VC_EXCEPTION, handle_exception)
5823         (STATUS_WX86_SINGLE_STEP, STATUS_WX86_BREAKPOINT): Move from
5824         windows-nat.c.
5825
5826 2020-04-08  Tom Tromey  <tromey@adacore.com>
5827
5828         * windows-nat.c (exception_count, event_count): Remove.
5829         (handle_exception, get_windows_debug_event)
5830         (do_initial_windows_stuff): Update.
5831
5832 2020-04-08  Tom Tromey  <tromey@adacore.com>
5833
5834         * windows-nat.c (windows_nat::handle_load_dll)
5835         (windows_nat::handle_unload_dll): Rename.  No longer static.
5836         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
5837         Declare.
5838
5839 2020-04-08  Tom Tromey  <tromey@adacore.com>
5840
5841         * complaints.h (stop_whining): Declare at top-level.
5842         (complaint): Don't declare stop_whining.
5843
5844 2020-04-08  Tom Tromey  <tromey@adacore.com>
5845
5846         * windows-nat.c (windows_nat::handle_output_debug_string):
5847         Rename.  No longer static.
5848         * nat/windows-nat.h (handle_output_debug_string): Declare.
5849
5850 2020-04-08  Tom Tromey  <tromey@adacore.com>
5851
5852         * windows-nat.c (current_process_handle, current_process_id)
5853         (main_thread_id, last_sig, current_event, last_wait_event)
5854         (current_windows_thread, desired_stop_thread_id, pending_stops)
5855         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
5856         (display_selectors, fake_create_process)
5857         (get_windows_debug_event): Update.
5858         * nat/windows-nat.h (current_process_handle, current_process_id)
5859         (main_thread_id, last_sig, current_event, last_wait_event)
5860         (current_windows_thread, desired_stop_thread_id, pending_stops)
5861         (struct pending_stop, siginfo_er): Move from windows-nat.c.
5862         * nat/windows-nat.c (current_process_handle, current_process_id)
5863         (main_thread_id, last_sig, current_event, last_wait_event)
5864         (current_windows_thread, desired_stop_thread_id, pending_stops)
5865         (siginfo_er): New globals.  Move from windows-nat.c.
5866
5867 2020-04-08  Tom Tromey  <tromey@adacore.com>
5868
5869         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
5870         (handle_load_dll): Update.
5871         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
5872
5873 2020-04-08  Tom Tromey  <tromey@adacore.com>
5874
5875         * windows-nat.c (enum thread_disposition_type): Move to
5876         nat/windows-nat.h.
5877         (windows_nat::thread_rec): Rename from thread_rec.  No longer
5878         static.
5879         (windows_add_thread, windows_nat_target::fetch_registers)
5880         (windows_nat_target::store_registers, handle_exception)
5881         (windows_nat_target::resume, get_windows_debug_event)
5882         (windows_nat_target::get_tib_address)
5883         (windows_nat_target::thread_name)
5884         (windows_nat_target::thread_alive): Update.
5885         * nat/windows-nat.h (enum thread_disposition_type): Move from
5886         windows-nat.c.
5887         (thread_rec): Declare.
5888
5889 2020-04-08  Tom Tromey  <tromey@adacore.com>
5890
5891         * windows-nat.c: Add "using namespace".
5892         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
5893         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
5894
5895 2020-04-08  Tom Tromey  <tromey@adacore.com>
5896
5897         * nat/windows-nat.h (struct windows_thread_info): Declare
5898         destructor.
5899         * nat/windows-nat.c (~windows_thread_info): New.
5900
5901 2020-04-08  Tom Tromey  <tromey@adacore.com>
5902
5903         PR gdb/22992
5904         * windows-nat.c (current_event): Update comment.
5905         (last_wait_event, desired_stop_thread_id): New globals.
5906         (struct pending_stop): New.
5907         (pending_stops): New global.
5908         (windows_nat_target) <stopped_by_sw_breakpoint>
5909         <supports_stopped_by_sw_breakpoint>: New methods.
5910         (windows_fetch_one_register): Add assertions.  Adjust PC.
5911         (windows_continue): Handle pending stops.  Suspend other threads
5912         when stepping.  Use last_wait_event
5913         (wait_for_debug_event): New function.
5914         (get_windows_debug_event): Use wait_for_debug_event.  Handle
5915         pending stops.  Queue spurious stops.
5916         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
5917         (windows_nat_target::kill): Use wait_for_debug_event.
5918         * nat/windows-nat.h (struct windows_thread_info)
5919         <stopped_at_software_breakpoint>: New field.
5920         * nat/windows-nat.c (windows_thread_info::resume): Clear
5921         stopped_at_software_breakpoint.
5922
5923 2020-04-08  Tom Tromey  <tromey@adacore.com>
5924
5925         * windows-nat.c (enum thread_disposition_type): New.
5926         (thread_rec): Replace "get_context" parameter with "disposition";
5927         change type.
5928         (windows_add_thread, windows_nat_target::fetch_registers)
5929         (windows_nat_target::store_registers, handle_exception)
5930         (windows_nat_target::resume, get_windows_debug_event)
5931         (windows_nat_target::get_tib_address)
5932         (windows_nat_target::thread_name)
5933         (windows_nat_target::thread_alive): Update.
5934
5935 2020-04-08  Tom Tromey  <tromey@adacore.com>
5936
5937         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
5938         (windows_continue): Use windows_continue::resume.
5939         * nat/windows-nat.h (struct windows_thread_info) <suspend,
5940         resume>: Declare new methods.
5941         * nat/windows-nat.c: New file.
5942         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
5943
5944 2020-04-08  Tom Tromey  <tromey@adacore.com>
5945
5946         * windows-nat.c (windows_add_thread, windows_delete_thread)
5947         (windows_nat_target::fetch_registers)
5948         (windows_nat_target::store_registers, fake_create_process)
5949         (windows_nat_target::resume, windows_nat_target::resume)
5950         (get_windows_debug_event, windows_nat_target::wait)
5951         (windows_nat_target::pid_to_str)
5952         (windows_nat_target::get_tib_address)
5953         (windows_nat_target::get_ada_task_ptid)
5954         (windows_nat_target::thread_name)
5955         (windows_nat_target::thread_alive): Use lwp, not tid.
5956
5957 2020-04-08  Tom Tromey  <tromey@adacore.com>
5958
5959         * windows-nat.c (handle_exception)
5960         (windows_nat_target::thread_name): Update.
5961         * nat/windows-nat.h (windows_thread_info): Remove destructor.
5962         <name>: Now unique_xmalloc_ptr.
5963
5964 2020-04-08  Tom Tromey  <tromey@adacore.com>
5965
5966         * windows-nat.c (thread_rec)
5967         (windows_nat_target::fetch_registers): Update.
5968         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
5969         Update comment.
5970         <debug_registers_changed, reload_context>: Now bool.
5971
5972 2020-04-08  Tom Tromey  <tromey@adacore.com>
5973
5974         * windows-nat.c (windows_add_thread): Use new.
5975         (windows_init_thread_list, windows_delete_thread): Use delete.
5976         (get_windows_debug_event): Update.
5977         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
5978         destructor, and initializers.
5979
5980 2020-04-08  Tom Tromey  <tromey@adacore.com>
5981
5982         * windows-nat.c (struct windows_thread_info): Remove.
5983         * nat/windows-nat.h: New file.
5984
5985 2020-04-08  Tom Tromey  <tromey@adacore.com>
5986
5987         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
5988         (thread_rec, windows_add_thread, windows_delete_thread)
5989         (windows_continue): Update.
5990
5991 2020-04-08  Tom Tromey  <tromey@adacore.com>
5992
5993         * windows-nat.c (struct windows_thread_info): Remove typedef.
5994         (thread_head): Remove.
5995         (thread_list): New global.
5996         (thread_rec, windows_add_thread, windows_init_thread_list)
5997         (windows_delete_thread, windows_continue): Update.
5998
5999 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
6000
6001         * windows-tdep.h (windows_init_abi): Add comment.
6002         (cygwin_init_abi): New declaration.
6003         * windows-tdep.c: Split signal enumeration in two, one for
6004         Windows and one for Cygwin.
6005         (windows_gdb_signal_to_target): Only deal with signal of the
6006         Windows OS ABI.
6007         (cygwin_gdb_signal_to_target): New function.
6008         (windows_init_abi): Rename to windows_init_abi_common, don't set
6009         gdb_signal_to_target gdbarch method.  Add new new function with
6010         this name.
6011         (cygwin_init_abi): New function.
6012         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
6013         comment.  Don't call windows_init_abi.
6014         (amd64_windows_init_abi): Add comment, call windows_init_abi.
6015         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
6016         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
6017         i386_windows_init_abi_common, don't call windows_init_abi.  Add
6018         a new function of this name.
6019         (i386_cygwin_init_abi): New function.
6020         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
6021         OS ABI Cygwin.
6022
6023 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
6024
6025         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
6026         parameter.c.
6027         (dwarf2_read_gdb_index): Update.
6028
6029 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
6030
6031         * nbsd-tdep.c: Include "objfiles.h".
6032         (nbsd_skip_solib_resolver): New.
6033         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
6034
6035 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
6036
6037         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
6038         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
6039         with DW_LLE_base_addressx are being emitted in DWARFv5.
6040         Add the newly added kind DW_LOC_OFFSET_PAIR also.
6041         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
6042         unsigned integer.
6043
6044 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
6045
6046         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
6047         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
6048         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
6049         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
6050         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
6051         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
6052         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
6053
6054
6055 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
6056
6057         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
6058         (read_loclist_index): New function definition.
6059         (lookup_loclist_base): New function definition.
6060         (read_loclist_header): New function definition.
6061         (dwarf2_cu): Add loclist_base and loclist_header field.
6062         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
6063         (read_full_die_1): Read the value of DW_AT_loclists_base.
6064         (read_attribute_reprocess): Handle DW_FORM_loclistx.
6065         (read_attribute_value): Handle DW_FORM_loclistx.
6066         (skip_one_die): Handle DW_FORM_loclistx.
6067         (loclist_header): New structure declaration.
6068         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
6069
6070 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
6071
6072         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
6073         constructor.  Remove `addr` parameter from other constructor and
6074         add `per_cu` parameter.
6075         * dwarf2/read.c (create_partial_symtab): Update.
6076
6077 2020-04-07  Tom de Vries  <tdevries@suse.de>
6078
6079         PR symtab/25796
6080         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
6081         (partial_die_info::fixup): Inherit has_const_value.
6082
6083 2020-04-07  Tom de Vries  <tdevries@suse.de>
6084
6085         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
6086         symbols without address.
6087
6088 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
6089
6090         * nbsd-nat.h (struct thread_info): Add forward declaration.
6091         (nbsd_nat_target::thread_alive): Add.
6092         (nbsd_nat_target::thread_name): Likewise.
6093         (nbsd_nat_target::update_thread_list): Likewise.
6094         (update_thread_list::post_attach): Likewise.
6095         (post_attach::pid_to_str): Likewise.
6096         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
6097         (nbsd_thread_lister): Add.
6098         (nbsd_nat_target::thread_alive): Likewise.
6099         (nbsd_nat_target::thread_name): Likewise.
6100         (nbsd_add_threads): Likewise.
6101         (update_thread_list::post_attach): Likewise.
6102         (nbsd_nat_target::update_thread_list): Likewise.
6103         (post_attach::pid_to_str): Likewise.
6104
6105 2020-04-06  Tom Tromey  <tromey@adacore.com>
6106
6107         * ada-valprint.c (print_variant_part): Extract the variant field.
6108         (print_field_values): Use the field as the outer value when
6109         recursing.
6110
6111 2020-04-06  Tom Tromey  <tromey@adacore.com>
6112
6113         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
6114         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
6115         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
6116         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
6117         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
6118
6119 2020-04-06  Tom Tromey  <tromey@adacore.com>
6120
6121         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
6122         TYPE_CODE_ERROR.
6123
6124 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
6125
6126         * nbsd-tdep.c: Include "gdbarch.h".
6127         Define enum with NetBSD signal numbers.
6128         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
6129         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
6130         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
6131         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
6132         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
6133         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
6134         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
6135         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
6136         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
6137         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
6138         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
6139         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
6140
6141 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
6142
6143         PR gdb/25325
6144         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
6145
6146 2020-04-03  Tom Tromey  <tromey@adacore.com>
6147
6148         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
6149         Read constant block.
6150
6151 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
6152
6153         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
6154         (gdb_bfd_get_full_section_contents): New declaration.
6155         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
6156         * windows-tdep.c (is_linked_with_cygwin_dll): Use
6157         gdb_bfd_get_full_section_contents.
6158
6159 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
6160
6161         * exec.c (build_section_table): Replace internal_error with
6162         gdb_assert.
6163         (section_table_xfer_memory_partial): Likewise.
6164         * mdebugread.c (parse_partial_symbols): Likewise.
6165         * psymtab.c (lookup_partial_symbol): Likewise.
6166         * utils.c (wrap_here): Likewise.
6167
6168 2020-04-02  Tom Tromey  <tromey@adacore.com>
6169
6170         * f-lang.c (build_fortran_types): Use arch_type to initialize
6171         builtin_complex_s32 in the TYPE_CODE_ERROR case.
6172
6173 2020-04-02  Tom Tromey  <tromey@adacore.com>
6174
6175         * dwarf2/read.c (partial_die_info::read): Do not create a vector
6176         of attributes.
6177
6178 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6179             Bernd Edlinger <bernd.edlinger@hotmail.de>
6180             Tom Tromey  <tromey@adacore.com>
6181
6182         * buildsym.c (buildsym_compunit::record_line): Remove
6183         deduplication code.
6184
6185 2020-04-02  Tom de Vries  <tdevries@suse.de>
6186
6187         PR ada/24671
6188         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
6189
6190 2020-04-02  Tom de Vries  <tdevries@suse.de>
6191
6192         * dwarf2/read.c (dwarf2_gdb_index_functions,
6193         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
6194         NULL.
6195         * psymtab.c (psym_lookup_global_symbol_language): New function.
6196         (psym_functions): Init psym_lookup_global_symbol_language with
6197         psym_lookup_global_symbol_language.
6198         * symfile-debug.c (debug_sym_quick_functions): Init
6199         lookup_global_symbol_language with NULL.
6200         * symfile.c (set_initial_language): Remove fixme comment.
6201         * symfile.h (struct quick_symbol_functions): Add
6202         lookup_global_symbol_language.
6203         * symtab.c (find_quick_global_symbol_language): New function.
6204         (find_main_name): Use find_quick_global_symbol_language.
6205
6206 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
6207
6208         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
6209
6210 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
6211
6212         * buildsym.c (record_line): Fix undefined behavior and preserve
6213         lines at eof.
6214
6215 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
6216
6217         * buildsym.c (record_line): Fix the resizing condition.
6218
6219 2020-04-01  Tom Tromey  <tom@tromey.com>
6220
6221         * value.h (value_literal_complex): Add comment.
6222         * valops.c (value_literal_complex): Refer to value.h.
6223
6224 2020-04-01  Tom Tromey  <tom@tromey.com>
6225
6226         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
6227         (scalar_type): New rule, from typebase.
6228         (typebase): Use scalar_type.  Recognize complex types.
6229         (field_name): Handle FLOAT_KEYWORD.
6230         (ident_tokens): Add _Complex and __complex__.
6231
6232 2020-04-01  Tom Tromey  <tom@tromey.com>
6233
6234         PR exp/25299:
6235         * valarith.c (promotion_type, complex_binop): New functions.
6236         (scalar_binop): Handle complex numbers.  Use promotion_type.
6237         (value_pos, value_neg, value_complement): Handle complex numbers.
6238
6239 2020-04-01  Tom Tromey  <tom@tromey.com>
6240
6241         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
6242         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
6243         (parse_number): Handle complex numbers.
6244
6245 2020-04-01  Tom Tromey  <tom@tromey.com>
6246
6247         * c-valprint.c (c_decorations): Change complex suffix to "i".
6248
6249 2020-04-01  Tom Tromey  <tom@tromey.com>
6250
6251         * valprint.c (generic_value_print_complex): Use accessors.
6252         * value.h (value_real_part, value_imaginary_part): Declare.
6253         * valops.c (value_real_part, value_imaginary_part): New
6254         functions.
6255         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
6256
6257 2020-04-01  Tom Tromey  <tom@tromey.com>
6258
6259         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
6260         (read_range_type): Update.
6261         * mdebugread.c (basic_type): Update.
6262         * go-lang.c (build_go_types): Use init_complex_type.
6263         * gdbtypes.h (struct main_type) <complex_type>: New member.
6264         (init_complex_type): Update.
6265         (arch_complex_type): Don't declare.
6266         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
6267         Make name if none given.  Use alloc_type_copy.  Look for cached
6268         complex type.
6269         (arch_complex_type): Remove.
6270         (gdbtypes_post_init): Use init_complex_type.
6271         * f-lang.c (build_fortran_types): Use init_complex_type.
6272         * dwarf2/read.c (read_base_type): Update.
6273         * d-lang.c (build_d_types): Use init_complex_type.
6274         * ctfread.c (read_base_type): Update.
6275
6276 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6277
6278         * infrun.c (stop_all_threads): Update assertion, plus when
6279         stopping threads, take into account that we might be trying
6280         to stop an all-stop target.
6281         (stop_waiting): Call 'stop_all_threads' if there exists a
6282         non-stop target.
6283
6284 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6285
6286         * target.h (exists_non_stop_target): New function declaration.
6287         * target.c (exists_non_stop_target): New function.
6288
6289 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
6290
6291         PR gdb/24789
6292         * eval.c (is_integral_or_integral_reference): New function.
6293         (evaluate_subexp_standard): Allow integer references in
6294         pointer arithmetic.
6295
6296 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6297
6298         * remote.c (remote_target::remote_parse_stop_reply): Remove the
6299         check for no ptid in the stop reply when the target is non-stop.
6300
6301 2020-04-01  Tom Tromey  <tromey@adacore.com>
6302
6303         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
6304         "name" parameter to rvalue reference.  Initialize m_name_holder.
6305         <lookup_name_info>: New overloads.
6306         <name>: Return gdb::string_view.
6307         <c_str>: New method.
6308         <make_ignore_params>: Update.
6309         <search_name_hash>: Update.
6310         <language_lookup_name>: Return const char *.
6311         <m_name>: Change type.
6312         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
6313         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
6314         (lookup_name_info::match_any): Update.
6315         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
6316         Update.
6317         * minsyms.c (linkage_name_str): Update.
6318         * language.c (default_symbol_name_matcher): Update.
6319         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
6320         Update.
6321         * ada-lang.c (ada_fold_name): Change parameter to string_view.
6322         (ada_lookup_name_info::ada_lookup_name_info): Update.
6323         (literal_symbol_name_matcher): Update.
6324
6325 2020-04-01  Tom Tromey  <tromey@adacore.com>
6326
6327         * psymtab.c (psymtab_search_name): Remove function.
6328         (psym_lookup_symbol): Create search name and lookup name here.
6329         (lookup_partial_symbol): Remove "name" parameter; add
6330         lookup_name.
6331         (psym_expand_symtabs_for_function): Update.
6332
6333 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
6334
6335         PR tui/25597:
6336         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
6337
6338 2020-03-31  Tom Tromey  <tromey@adacore.com>
6339
6340         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
6341         memcpy.
6342
6343 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
6344
6345         * features/riscv/32bit-csr.xml: Regenerated.
6346         * features/riscv/64bit-csr.xml: Regenerated.
6347
6348 2020-03-30  Tom Tromey  <tromey@adacore.com>
6349
6350         * ada-valprint.c (print_variant_part): Update.
6351         * ada-lang.h (ada_which_variant_applies): Update.
6352         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
6353         outer_valaddr parameters; replace with "outer" value parameter.
6354         (to_fixed_variant_branch_type): Update.
6355
6356 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6357
6358         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
6359         <list>.  Remove inclusion of observable.h.
6360         (PPC_DEBUG_CURRENT_VERSION): Move up define.
6361         (struct arch_lwp_info): New struct.
6362         (class ppc_linux_dreg_interface): New class.
6363         (struct ppc_linux_process_info): New struct.
6364         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
6365         <low_new_clone, low_forget_process, low_prepare_to_resume>
6366         <copy_thread_dreg_state, mark_thread_stale>
6367         <mark_debug_registers_changed, register_hw_breakpoint>
6368         <clear_hw_breakpoint, register_wp, clear_wp>
6369         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
6370         <num_memory_accesses, get_trigger_type>
6371         <create_watchpoint_request, hwdebug_point_cmp>
6372         <init_arch_lwp_info, get_arch_lwp_info>
6373         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
6374         methods.
6375         <struct ptid_hash>: New inner struct.
6376         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
6377         members.
6378         (saved_dabr_value, hwdebug_info, max_slots_number)
6379         (struct hw_break_tuple, struct thread_points, ppc_threads)
6380         (have_ptrace_hwdebug_interface)
6381         (hwdebug_find_thread_points_by_tid)
6382         (hwdebug_insert_point, hwdebug_remove_point): Remove.
6383         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
6384         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
6385         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
6386         use m_dreg_interface.
6387         (hwdebug_point_cmp): Change to...
6388         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
6389         reference arguments instead of pointers.
6390         (ppc_linux_nat_target::ranged_break_num_registers): Use
6391         m_dreg_interface.
6392         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
6393         m_dreg_interface.  Call register_hw_breakpoint.
6394         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
6395         m_dreg_interface.  Call clear_hw_breakpoint.
6396         (get_trigger_type): Change to...
6397         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
6398         comment.
6399         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
6400         use m_dreg_interface.  Call register_hw_breakpoint.
6401         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
6402         use m_dreg_interface.  Call clear_hw_breakpoint.
6403         (can_use_watchpoint_cond_accel): Change to...
6404         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
6405         method.  Update comment, use m_dreg_interface and
6406         m_process_info.
6407         (calculate_dvc): Change to...
6408         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
6409         m_dreg_interface.
6410         (num_memory_accesses): Change to...
6411         (ppc_linux_nat_target::num_memory_accesses): ...this method.
6412         (check_condition): Change to...
6413         (ppc_linux_nat_target::check_condition): ...this method.
6414         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
6415         comment, use m_dreg_interface.
6416         (create_watchpoint_request): Change to...
6417         (ppc_linux_nat_target::create_watchpoint_request): ...this
6418         method.  Use m_dreg_interface.
6419         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
6420         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
6421         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
6422         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
6423         (ppc_linux_nat_target::low_forget_process)
6424         (ppc_linux_nat_target::low_new_fork)
6425         (ppc_linux_nat_target::low_new_clone)
6426         (ppc_linux_nat_target::low_delete_thread)
6427         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
6428         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
6429         only call mark_thread_stale.
6430         (ppc_linux_thread_exit): Remove.
6431         (ppc_linux_nat_target::stopped_data_address): Change to...
6432         (ppc_linux_nat_target::low_stopped_data_address): This. Add
6433         comment, use m_dreg_interface and m_thread_hw_breakpoints.
6434         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
6435         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
6436         comment.  Call low_stopped_data_address.
6437         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
6438         m_dreg_interface.
6439         (ppc_linux_nat_target::masked_watch_num_registers): Use
6440         m_dreg_interface.
6441         (ppc_linux_nat_target::copy_thread_dreg_state)
6442         (ppc_linux_nat_target::mark_thread_stale)
6443         (ppc_linux_nat_target::mark_debug_registers_changed)
6444         (ppc_linux_nat_target::register_hw_breakpoint)
6445         (ppc_linux_nat_target::clear_hw_breakpoint)
6446         (ppc_linux_nat_target::register_wp)
6447         (ppc_linux_nat_target::clear_wp)
6448         (ppc_linux_nat_target::init_arch_lwp_info)
6449         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
6450         (_initialize_ppc_linux_nat): Remove observer callback.
6451
6452 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6453
6454         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
6455         (ppc_linux_nat_target::auxv_parse)
6456         (ppc_linux_nat_target::read_description)
6457         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
6458         Move up.
6459
6460 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6461
6462         * linux-nat.h (low_new_clone): New method.
6463         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
6464
6465 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
6466
6467         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
6468         (dbx_expand_psymtab): ... this.
6469         (start_psymtab): Update.
6470         * mdebugread.c (psymtab_to_symtab_1): Rename to...
6471         (mdebug_expand_psymtab): ... this.
6472         (parse_partial_symbols): Update.
6473         (new_psymtab): Update.
6474         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
6475         (xcoff_expand_psymtab): ... this.
6476         (xcoff_start_psymtab): Update.
6477
6478 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
6479
6480         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
6481         <expand_dependencies>: ... this.
6482         * psymtab.c (partial_symtab::read_dependencies): Rename to...
6483         (partial_symtab::expand_dependencies): ... this.
6484         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
6485         Update.
6486         (dwarf2_psymtab::expand_psymtab): Update.
6487         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
6488         * mdebugread.c (psymtab_to_symtab_1): Update.
6489         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
6490
6491 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
6492
6493         * psympriv.h (discard_psymtab): Remove.
6494         * dbxread.c (dbx_end_psymtab): Update.
6495         * xcoffread.c (xcoff_end_psymtab): Update.
6496
6497 2020-03-28  Tom Tromey  <tom@tromey.com>
6498
6499         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
6500         comment.
6501
6502 2020-03-28  Tom Tromey  <tom@tromey.com>
6503
6504         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
6505
6506 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
6507
6508         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
6509
6510 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
6511
6512         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
6513
6514 2020-03-26  Tom Tromey  <tom@tromey.com>
6515
6516         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
6517         (mark_common_block_symbol_computed, read_tag_string_type)
6518         (attr_to_dynamic_prop, read_subrange_type): Update.
6519         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
6520         to be methods on struct attribute.
6521         (skip_one_die, process_imported_unit_die, read_namespace_alias)
6522         (read_call_site_scope, partial_die_info::read)
6523         (partial_die_info::read, lookup_die_type, follow_die_ref):
6524         Update.
6525         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
6526         from dwarf2_get_ref_die_offset.
6527         (attribute::constant_value): New method, from
6528         dwarf2_get_attr_constant_value.
6529         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
6530         Declare method.
6531         <constant_value>: New method.
6532
6533 2020-03-26  Tom Tromey  <tom@tromey.com>
6534
6535         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
6536         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
6537         (dwarf_type_encoding_name): Move to stringify.c.
6538         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
6539         * dwarf2/stringify.c: New file.
6540         * dwarf2/stringify.h: New file.
6541
6542 2020-03-26  Tom Tromey  <tom@tromey.com>
6543
6544         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
6545         Rewrite.
6546
6547 2020-03-26  Tom Tromey  <tom@tromey.com>
6548
6549         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
6550         methods.
6551         * dwarf2/read.c (lookup_addr_base): Move to die.h.
6552         (lookup_ranges_base): Likewise.
6553         (read_cutu_die_from_dwo, read_full_die_1): Update.
6554
6555 2020-03-26  Tom Tromey  <tom@tromey.com>
6556
6557         * dwarf2/read.c (read_import_statement, read_file_scope)
6558         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
6559         (read_lexical_block_scope, read_call_site_scope)
6560         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
6561         (handle_struct_member_die, process_structure_scope)
6562         (update_enumeration_type_from_children)
6563         (process_enumeration_scope, read_array_type, read_common_block)
6564         (read_namespace, read_module, read_subroutine_type): Update.
6565         (sibling_die): Remove.
6566
6567 2020-03-26  Tom Tromey  <tom@tromey.com>
6568
6569         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
6570         (build_type_psymtabs_reader, read_structure_type)
6571         (read_enumeration_type, read_full_die_1): Update.
6572         (dwarf2_attr_no_follow): Move to die.h.
6573         * dwarf2/die.h (struct die_info) <attr>: New method.
6574
6575 2020-03-26  Tom Tromey  <tom@tromey.com>
6576
6577         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
6578         <base_address>: Now an optional.
6579         (dwarf2_find_base_address, dwarf2_rnglists_process)
6580         (dwarf2_ranges_process, fill_in_loclist_baton)
6581         (dwarf2_symbol_mark_computed): Update.
6582
6583 2020-03-26  Tom Tromey  <tom@tromey.com>
6584
6585         * dwarf2/read.c (struct die_info): Move to die.h.
6586         * dwarf2/die.h: New file.
6587
6588 2020-03-26  Tom Tromey  <tom@tromey.com>
6589
6590         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
6591         * dwarf2/read.c
6592         (dwarf2_statement_list_fits_in_line_number_section_complaint):
6593         Move to line-header.c.
6594         (read_checked_initial_length_and_offset, read_formatted_entries):
6595         Likewise.
6596         (dwarf_decode_line_header): Split into two.
6597         * dwarf2/line-header.c
6598         (dwarf2_statement_list_fits_in_line_number_section_complaint):
6599         Move from read.c.
6600         (read_checked_initial_length_and_offset, read_formatted_entries):
6601         Likewise.
6602         (dwarf_decode_line_header): New function, split from read.c.
6603
6604 2020-03-26  Tom Tromey  <tom@tromey.com>
6605
6606         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
6607         Declare method.
6608         * dwarf2/read.c (read_attribute_value): Update.
6609         (dwarf2_per_objfile::read_line_string): Rename from
6610         read_indirect_line_string.
6611         (read_formatted_entries): Update.
6612
6613 2020-03-26  Tom Tromey  <tom@tromey.com>
6614
6615         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
6616         variable.
6617
6618 2020-03-26  Tom Tromey  <tom@tromey.com>
6619
6620         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
6621         const.
6622         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
6623         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
6624         parameter const.
6625
6626 2020-03-26  Tom Tromey  <tom@tromey.com>
6627
6628         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
6629         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
6630         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
6631         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
6632
6633 2020-03-26  Tom Tromey  <tom@tromey.com>
6634
6635         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
6636         file_names_size, file_full_name, file_file_name>: Use const.
6637         <file_name_at, file_names>: Add const overload.
6638         * dwarf2/line-header.c (line_header::file_file_name)
6639         (line_header::file_full_name): Update.
6640
6641 2020-03-26  Tom Tromey  <tom@tromey.com>
6642
6643         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
6644         (macro_start_file, consume_improper_spaces)
6645         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
6646         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
6647         (dwarf_decode_macros): Move to macro.c.
6648         * dwarf2/macro.c: New file.
6649         * dwarf2/macro.h: New file.
6650         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
6651
6652 2020-03-26  Tom Tromey  <tom@tromey.com>
6653
6654         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
6655         method.
6656         * dwarf2/section.c: New method.  From
6657         read_indirect_string_at_offset_from.
6658         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
6659         (read_indirect_string_at_offset_from): Move to section.c.
6660         (read_indirect_string_at_offset): Rewrite.
6661         (read_indirect_line_string_at_offset): Remove.
6662         (read_indirect_string, read_indirect_line_string)
6663         (dwarf_decode_macro_bytes): Update.
6664
6665 2020-03-26  Tom Tromey  <tom@tromey.com>
6666
6667         * dwarf2/section.h (struct dwarf2_section_info)
6668         <overload_complaint>: Declare.
6669         (dwarf2_section_buffer_overflow_complaint): Don't declare.
6670         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
6671         Rename from dwarf2_section_buffer_overflow_complaint.
6672         * dwarf2/read.c (skip_one_die, partial_die_info::read)
6673         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
6674
6675 2020-03-26  Tom Tromey  <tom@tromey.com>
6676
6677         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
6678         Declare.
6679         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
6680         Move from read.c.
6681         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
6682         to section.c.
6683
6684 2020-03-26  Tom Tromey  <tom@tromey.com>
6685
6686         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
6687
6688 2020-03-26  Tom Tromey  <tom@tromey.com>
6689
6690         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
6691         "builder".
6692         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
6693         parameter.
6694         (dwarf_decode_macros): Update.
6695
6696 2020-03-26  Tom Tromey  <tom@tromey.com>
6697
6698         * dwarf2/read.c (read_attribute_value): Update.
6699         (read_indirect_string_from_dwz): Move to dwz.c; change into
6700         method.
6701         (dwarf_decode_macro_bytes): Update.
6702         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
6703         * dwarf2/dwz.c: New file.
6704         * Makefile.in (COMMON_SFILES): Add dwz.c.
6705
6706 2020-03-26  Tom Tromey  <tom@tromey.com>
6707
6708         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
6709         * dwarf2/read.c: Add include.
6710         * dwarf2/index-write.c: Add include.
6711         * dwarf2/index-cache.c: Add include.
6712         * dwarf2/dwz.h: New file.
6713
6714 2020-03-25  Tom Tromey  <tom@tromey.com>
6715
6716         * compile/compile-object-load.c (get_out_value_type): Mention
6717         correct symbol name in error message.
6718
6719 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
6720
6721         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
6722
6723 2020-03-25  Tom de Vries  <tdevries@suse.de>
6724
6725         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
6726         * symmisc.c (dump_symtab_1): Print user and includes fields.
6727         (maintenance_info_symtabs): Same.
6728
6729 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
6730
6731         PR gdb/25534
6732         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
6733         (riscv_regcache_cooked_write): New function.
6734         (riscv_push_dummy_call): Use new function.
6735         (riscv_return_value): Likewise.
6736
6737 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
6738
6739         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
6740         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
6741         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
6742         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
6743         * infrun.c (follow_fork): Likewise.
6744         (follow_fork_inferior): Likewise.
6745         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
6746         * linux-nat.h (class linux_nat_target): Likewise.
6747         * remote.c (class remote_target) <follow_fork>: Likewise.
6748         (remote_target::follow_fork): Likewise.
6749         * target-delegates.c: Re-generate.
6750         * target.c (default_follow_fork): Likewise.
6751         (target_follow_fork): Likewise.
6752         * target.h (struct target_ops) <follow_fork>: Likewise.
6753         (target_follow_fork): Likewise.
6754
6755 2020-03-24  Tom de Vries  <tdevries@suse.de>
6756
6757         * psymtab.c (maintenance_info_psymtabs): Print user field.
6758
6759 2020-03-20  Tom Tromey  <tromey@adacore.com>
6760
6761         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
6762         const.
6763         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
6764         const.
6765
6766 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
6767
6768         * ptrace.m4: Don't check for ptrace declaration.
6769         * config.in: Re-generate.
6770         * configure: Re-generate.
6771         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
6772         not defined.
6773
6774 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
6775
6776         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
6777         `PTRACE_TYPE_RET'.
6778         * i386-bsd-nat.c (gdb_ptrace): Likewise.
6779         * sparc-nat.c (gdb_ptrace): Likewise.
6780         * x86-bsd-nat.c (gdb_ptrace): Likewise.
6781
6782 2020-03-20  Tom Tromey  <tromey@adacore.com>
6783
6784         * c-exp.y (lex_one_token): Fix assert.
6785
6786 2020-03-20  Tom Tromey  <tromey@adacore.com>
6787
6788         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
6789         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
6790         strncpy call.
6791
6792 2020-03-20  Tom Tromey  <tromey@adacore.com>
6793
6794         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
6795
6796 2020-03-20  Tom Tromey  <tromey@adacore.com>
6797
6798         * ada-valprint.c (print_variant_part): Remove parameters; switch
6799         to value-based API.
6800         (print_field_values): Likewise.
6801         (ada_val_print_struct_union): Likewise.
6802         (ada_value_print_1): Update.
6803
6804 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
6805
6806         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
6807         nbsd_nat_target instead of inf_ptrace_target.
6808         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
6809         nbsd_nat_target.
6810
6811 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
6812
6813         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
6814         it to the ptrace call.
6815         * (store_registers): Likewise.
6816
6817 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
6818
6819         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
6820         it to the ptrace call.
6821         * (store_registers): Likewise.
6822
6823 2020-03-19  Luis Machado  <luis.machado@linaro.org>
6824
6825         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
6826         valid, fetch vg value from ptrace.
6827
6828 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
6829         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
6830         * inf-ptrace.c: Likewise.
6831         * (gdb_ptrace): Add.
6832         * (inf_ptrace_target::resume): Update.
6833         * (inf_ptrace_target::xfer_partial): Likewise.
6834         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
6835         * (inf_ptrace_peek_poke): Update.
6836
6837 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
6838
6839         * x86-bsd-nat.c (gdb_ptrace): New.
6840         * (x86bsd_dr_set): Add new argument `ptid'.
6841         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
6842         x86bsd_dr_set_addr): Update.
6843
6844 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6845
6846         * remote.c (remote_target::process_stop_reply): Handle events for
6847         all threads differently.
6848
6849 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6850
6851         * completer.c (completion_tracker::remove_completion): Define new
6852         function.
6853         * completer.h (completion_tracker::remove_completion): Declare new
6854         function.
6855         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
6856         when adding a C++ function symbol.
6857
6858 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6859
6860         * completer.c (completion_tracker::completion_hash_entry): Define
6861         new class.
6862         (advance_to_filename_complete_word_point): Call
6863         recompute_lowest_common_denominator.
6864         (completion_tracker::completion_tracker): Call discard_completions
6865         to setup the hash table.
6866         (completion_tracker::discard_completions): Allow for being called
6867         from the constructor, pass new equal function, and element deleter
6868         when constructing the hash table.  Initialise new class member
6869         variables.
6870         (completion_tracker::maybe_add_completion): Remove use of
6871         m_entries_vec, and store more information into m_entries_hash.
6872         (completion_tracker::recompute_lcd_visitor): New function, most
6873         content taken from...
6874         (completion_tracker::recompute_lowest_common_denominator):
6875         ...here, this now just visits each item in the hash calling the
6876         above visitor.
6877         (completion_tracker::build_completion_result): Remove use of
6878         m_entries_vec, call recompute_lowest_common_denominator.
6879         * completer.h (completion_tracker::have_completions): Remove use
6880         of m_entries_vec.
6881         (completion_tracker::completion_hash_entry): Declare new class.
6882         (completion_tracker::recompute_lowest_common_denominator): Change
6883         function signature.
6884         (completion_tracker::recompute_lcd_visitor): Declare new function.
6885         (completion_tracker::m_entries_vec): Delete.
6886         (completion_tracker::m_entries_hash): Initialize to NULL.
6887         (completion_tracker::m_lowest_common_denominator_valid): New
6888         member variable.
6889         (completion_tracker::m_lowest_common_denominator_max_length): New
6890         member variable.
6891
6892 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6893
6894         * regformats/regdef.h: Put reg in gdb namespace.
6895
6896 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6897
6898         * i386-bsd-nat.c (gdb_ptrace): New.
6899         * (i386bsd_fetch_inferior_registers,
6900         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
6901         * (i386bsd_fetch_inferior_registers,
6902         i386bsd_store_inferior_registers) Use gdb_ptrace.
6903
6904 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6905
6906         * amd64-bsd-nat.c (gdb_ptrace): New.
6907         * (amd64bsd_fetch_inferior_registers,
6908         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
6909         * (amd64bsd_fetch_inferior_registers,
6910         amd64bsd_store_inferior_registers) Use gdb_ptrace.
6911
6912 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6913
6914         * user-regs.c (user_reg::read): Rename to...
6915         (user_reg::xread): ...this.
6916         * (append_user_reg): Rename argument `read' to `xread'.
6917         * (user_reg_add_builtin): Likewise.
6918         * (user_reg_add): Likewise.
6919         * (value_of_user_reg): Likewise.
6920
6921 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6922
6923         * sparc-nat.c (gdb_ptrace): New.
6924         * sparc-nat.c (sparc_fetch_inferior_registers)
6925         (sparc_store_inferior_registers) Remove obsolete comment.
6926         * sparc-nat.c (sparc_fetch_inferior_registers)
6927         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
6928         * sparc-nat.c (sparc_fetch_inferior_registers)
6929         (sparc_store_inferior_registers) Use gdb_ptrace.
6930
6931 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6932
6933         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
6934         it to the ptrace call.
6935         * sh-nbsd-nat.c (store_registers): Likewise.
6936
6937 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6938
6939         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
6940         nbsd_nat_target instead of inf_ptrace_target.
6941         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
6942         nbsd_nat_target.
6943
6944 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6945
6946         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
6947
6948 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6949
6950         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
6951         <sys/sysctl.h>.
6952         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
6953
6954 2020-03-17  Tom de Vries  <tdevries@suse.de>
6955
6956         PR gdb/23710
6957         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
6958         fields.
6959         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
6960         fields.
6961         (process_imported_unit_die): Skip import of c++ CUs.
6962
6963 2020-03-16  Tom Tromey  <tom@tromey.com>
6964
6965         * p-valprint.c (pascal_object_print_value): Initialize
6966         base_value.
6967
6968 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
6969             Shahab Vahedi  <shahab@synopsys.com>
6970
6971         * Makefile.in: Add arch/arc.o
6972         * configure.tgt: Likewise.
6973         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
6974         (_initialize_arc_tdep): Don't initialize old target descriptions.
6975         (arc_read_description): New function to cache target descriptions.
6976         * arc-tdep.h (arc_read_description): Add proto type.
6977         * arch/arc.c: New file.
6978         * arch/arc.h: Likewise.
6979         * features/Makefile: Replace old target descriptions with new.
6980         * features/arc-arcompact.c: Remove.
6981         * features/arc-arcompact.xml: Likewise.
6982         * features/arc-v2.c: Likewise
6983         * features/arc-v2.xml: Likewise
6984         * features/arc/aux-arcompact.xml: New file.
6985         * features/arc/aux-v2.xml: Likewise.
6986         * features/arc/core-arcompact.xml: Likewise.
6987         * features/arc/core-v2.xml: Likewise.
6988         * features/arc/aux-arcompact.c: Generate.
6989         * features/arc/aux-v2.c: Likewise.
6990         * features/arc/core-arcompact.c: Likewise.
6991         * features/arc/core-v2.c: Likewise.
6992         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
6993
6994 2020-03-16  Tom Tromey  <tromey@adacore.com>
6995
6996         PR gdb/25663:
6997         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
6998         putting value into bcache.
6999
7000 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
7001
7002         PR gdb/21500
7003         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
7004         to...
7005         (amd64_windows_init_abi_common): ... this.  Don't set size of
7006         long type.
7007         (amd64_windows_init_abi): New function.
7008         (amd64_cygwin_init_abi): New function.
7009         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
7010         the Cygwin OS ABI.
7011         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
7012         comment.
7013
7014 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
7015
7016         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
7017         * windows-tdep.c (CYGWIN_DLL_NAME): New.
7018         (pe_import_directory_entry): New struct type.
7019         (is_linked_with_cygwin_dll): New function.
7020         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
7021         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
7022         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
7023
7024 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
7025
7026         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
7027         i386_cygwin_core_osabi_sniffer.
7028
7029 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
7030
7031         * i386-cygwin-tdep.c: Rename to...
7032         * i386-windows-tdep.c: ... this.
7033         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
7034         i386-windows-tdep.c.
7035         * configure.tgt: Likewise.
7036
7037 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
7038
7039         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
7040         * osabi.c (gdb_osabi_names): Add "Windows".
7041         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
7042         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
7043         (i386_cygwin_core_osabi_sniffer): New function, extracted from
7044         i386_cygwin_osabi_sniffer.
7045         (_initialize_i386_cygwin_tdep): Register OS ABI
7046         GDB_OSABI_WINDOWS for i386.
7047         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
7048         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
7049         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
7050         for x86-64.
7051         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
7052         when the target matches '*-*-mingw*'.
7053
7054 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
7055
7056         * defs.h (enum gdb_osabi): Move to...
7057         * osabi.h (enum gdb_osabi): ... here.
7058         * gdbarch.sh: Include osabi.h in gdbarch.h.
7059         * gdbarch.h: Re-generate.
7060
7061 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
7062
7063         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
7064         function.
7065         (_initialize_amd64_windows_tdep): Register osabi sniffer.
7066
7067 2020-03-14  Tom Tromey  <tom@tromey.com>
7068
7069         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
7070         for C++.
7071         (c_type_print_modifier): Likewise.  Add "language" parameter.
7072         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
7073         (c_type_print_base_1): Update.
7074         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
7075         constants.
7076         * type-stack.c (type_stack::insert): Handle tp_atomic and
7077         tp_restrict.
7078         (type_stack::follow_type_instance_flags): Likewise.
7079         (type_stack::follow_types): Likewise.  Merge type-following code.
7080         * c-exp.y (RESTRICT, ATOMIC): New tokens.
7081         (space_identifier, cv_with_space_id)
7082         (const_or_volatile_or_space_identifier_noopt)
7083         (const_or_volatile_or_space_identifier): Remove.
7084         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
7085         rules.
7086         (ptr_operator, typebase): Update.
7087         (enum token_flag) <FLAG_C>: New constant.
7088         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
7089         "_Atomic".
7090         (lex_one_token): Handle FLAG_C.
7091
7092 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7093
7094         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
7095         it to the ptrace call.
7096         * m68k-bsd-nat.c (store_registers): Likewise.
7097
7098 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7099
7100         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
7101         gdb_byte *.
7102         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
7103         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
7104         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
7105
7106 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7107
7108         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
7109         nbsd_nat_target instead of inf_ptrace_target.
7110         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
7111         nbsd_nat_target.
7112
7113 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7114
7115         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
7116         register_t.
7117
7118 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7119
7120         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
7121         it to the ptrace call.
7122         * alpha-bsd-nat.c (store_registers): Likewise.
7123
7124 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7125
7126         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
7127         includes.
7128         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
7129         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
7130         fill_fpregset): Likewise.
7131
7132 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7133
7134         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
7135         nbsd_nat_target instead of inf_ptrace_target.
7136         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
7137         nbsd_nat_target.
7138
7139 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7140
7141         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
7142         register_t.
7143
7144 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7145
7146         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
7147         it to the ptrace call.
7148         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
7149         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
7150         * arm-nbsd-nat.c (store_register): Likewise.
7151         * arm-nbsd-nat.c (store_regs): Likewise.
7152         * arm-nbsd-nat.c (store_fp_register): Likewise.
7153         * arm-nbsd-nat.c (store_fp_regs): Likewise.
7154
7155 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7156
7157         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
7158         nbsd_nat_target instead of inf_ptrace_target.
7159         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
7160         nbsd_nat_target.
7161
7162 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7163
7164         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
7165         it to the ptrace call.
7166         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
7167
7168 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7169
7170         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
7171         it to the ptrace call.
7172         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
7173
7174 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7175
7176         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
7177         gdb_byte *.
7178         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
7179
7180 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7181
7182         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
7183         instead of inf_ptrace_target.
7184         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
7185         nbsd_nat_target.
7186
7187 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7188
7189         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
7190         register_t.
7191
7192 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7193
7194         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
7195         register_t.
7196
7197 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7198
7199         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
7200         register_t.
7201
7202 2020-03-13  Tom Tromey  <tom@tromey.com>
7203
7204         * value.h (val_print): Don't declare.
7205         * valprint.h (val_print_array_elements)
7206         (val_print_scalar_formatted, generic_val_print): Don't declare.
7207         * valprint.c (generic_val_print_array): Take a struct value.
7208         (generic_val_print_ptr, generic_val_print_memberptr)
7209         (generic_val_print_bool, generic_val_print_int)
7210         (generic_val_print_char, generic_val_print_complex)
7211         (generic_val_print): Remove.
7212         (generic_value_print): Update.
7213         (do_val_print): Remove unused parameters.  Don't call
7214         la_val_print.
7215         (val_print): Remove.
7216         (common_val_print): Update.  Don't call value_check_printable.
7217         (val_print_scalar_formatted, val_print_array_elements): Remove.
7218         * rust-lang.c (rust_val_print): Remove.
7219         (rust_language_defn): Update.
7220         * p-valprint.c (pascal_val_print): Remove.
7221         (pascal_value_print_inner): Update.
7222         (pascal_object_print_val_fields, pascal_object_print_val):
7223         Remove.
7224         (pascal_object_print_static_field): Update.
7225         * p-lang.h (pascal_val_print): Don't declare.
7226         * p-lang.c (pascal_language_defn): Update.
7227         * opencl-lang.c (opencl_language_defn): Update.
7228         * objc-lang.c (objc_language_defn): Update.
7229         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
7230         * m2-lang.h (m2_val_print): Don't declare.
7231         * m2-lang.c (m2_language_defn): Update.
7232         * language.h (struct language_defn) <la_val_print>: Remove.
7233         * language.c (unk_lang_value_print_inner): Rename.  Change
7234         argument types.
7235         (unknown_language_defn, auto_language_defn): Update.
7236         * go-valprint.c (go_val_print): Remove.
7237         * go-lang.h (go_val_print): Don't declare.
7238         * go-lang.c (go_language_defn): Update.
7239         * f-valprint.c (f_val_print): Remove.
7240         * f-lang.h (f_value_print): Don't declare.
7241         * f-lang.c (f_language_defn): Update.
7242         * d-valprint.c (d_val_print): Remove.
7243         * d-lang.h (d_value_print): Don't declare.
7244         * d-lang.c (d_language_defn): Update.
7245         * cp-valprint.c (cp_print_value_fields)
7246         (cp_print_value_fields_rtti, cp_print_value): Remove.
7247         (cp_print_static_field): Update.
7248         * c-valprint.c (c_val_print_array, c_val_print_ptr)
7249         (c_val_print_struct, c_val_print_union, c_val_print_int)
7250         (c_val_print_memberptr, c_val_print): Remove.
7251         * c-lang.h (c_val_print_array, cp_print_value_fields)
7252         (cp_print_value_fields_rtti): Don't declare.
7253         * c-lang.c (c_language_defn, cplus_language_defn)
7254         (asm_language_defn, minimal_language_defn): Update.
7255         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
7256         (ada_val_print_enum): Take a struct value.
7257         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
7258         (ada_val_print): Remove.
7259         (ada_value_print_1): Update.
7260         (printable_val_type): Remove.
7261         * ada-lang.h (ada_val_print): Don't declare.
7262         * ada-lang.c (ada_language_defn): Update.
7263
7264 2020-03-13  Tom Tromey  <tom@tromey.com>
7265
7266         * valprint.c (do_val_print): Update.
7267         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
7268         a struct value.
7269         (value_to_value_object_no_release): Declare.
7270         * python/py-value.c (value_to_value_object_no_release): New
7271         function.
7272         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
7273         struct value.
7274         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
7275         function.
7276         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
7277         a struct value.
7278         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
7279         Declare.
7280         (gdbscm_apply_val_pretty_printer): Take a struct value.
7281         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
7282         value.
7283         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
7284         value.
7285         * extension-priv.h (struct extension_language_ops)
7286         <apply_val_pretty_printer>: Take a struct value.
7287         * cp-valprint.c (cp_print_value): Create a struct value.
7288         (cp_print_value): Update.
7289
7290 2020-03-13  Tom Tromey  <tom@tromey.com>
7291
7292         * ada-valprint.c (print_field_values): Call common_val_print.
7293
7294 2020-03-13  Tom Tromey  <tom@tromey.com>
7295
7296         * ada-valprint.c (val_print_packed_array_elements): Remove
7297         bitoffset and val parameters.  Call common_val_print.
7298         (ada_val_print_string): Remove offset, address, and original_value
7299         parameters.
7300         (ada_val_print_array): Update.
7301         (ada_value_print_array): New function.
7302         (ada_value_print_1): Call it.
7303
7304 2020-03-13  Tom Tromey  <tom@tromey.com>
7305
7306         * ada-valprint.c (ada_value_print): Use common_val_print.
7307
7308 2020-03-13  Tom Tromey  <tom@tromey.com>
7309
7310         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
7311
7312 2020-03-13  Tom Tromey  <tom@tromey.com>
7313
7314         * ada-valprint.c (ada_value_print_num): New function.
7315         (ada_value_print_1): Use it.
7316
7317 2020-03-13  Tom Tromey  <tom@tromey.com>
7318
7319         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
7320
7321 2020-03-13  Tom Tromey  <tom@tromey.com>
7322
7323         * ada-valprint.c (ada_value_print_ptr): New function.
7324         (ada_value_print_1): Use it.
7325
7326 2020-03-13  Tom Tromey  <tom@tromey.com>
7327
7328         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
7329         call common_val_print.
7330         (ada_val_print_1): Update.
7331         (ada_value_print_1): New function.
7332         (ada_value_print_inner): Rewrite.
7333
7334 2020-03-13  Tom Tromey  <tom@tromey.com>
7335
7336         * cp-valprint.c (cp_print_value_fields): Update.
7337         (cp_print_value): New function.
7338
7339 2020-03-13  Tom Tromey  <tom@tromey.com>
7340
7341         * m2-valprint.c (m2_value_print_inner): Use
7342         cp_print_value_fields.
7343         * cp-valprint.c (cp_print_value_fields): New function.
7344         * c-valprint.c (c_value_print_struct): New function.
7345         (c_value_print_inner): Use c_value_print_struct.
7346         * c-lang.h (cp_print_value_fields): Declare.
7347
7348 2020-03-13  Tom Tromey  <tom@tromey.com>
7349
7350         * c-valprint.c (c_value_print_array): New function.
7351         (c_value_print_inner): Use it.
7352
7353 2020-03-13  Tom Tromey  <tom@tromey.com>
7354
7355         * c-valprint.c (c_value_print_memberptr): New function.
7356         (c_value_print_inner): Use it.
7357
7358 2020-03-13  Tom Tromey  <tom@tromey.com>
7359
7360         * c-valprint.c (c_value_print_int): New function.
7361         (c_value_print_inner): Use it.
7362
7363 2020-03-13  Tom Tromey  <tom@tromey.com>
7364
7365         * c-valprint.c (c_value_print_ptr): New function.
7366         (c_value_print_inner): Use it.
7367
7368 2020-03-13  Tom Tromey  <tom@tromey.com>
7369
7370         * c-valprint.c (c_value_print_inner): Rewrite.
7371
7372 2020-03-13  Tom Tromey  <tom@tromey.com>
7373
7374         * valprint.c (generic_value_print_complex): New function.
7375         (generic_value_print): Use it.
7376
7377 2020-03-13  Tom Tromey  <tom@tromey.com>
7378
7379         * valprint.c (generic_val_print_float): Don't call
7380         val_print_scalar_formatted.
7381         (generic_val_print, generic_value_print): Update.
7382
7383 2020-03-13  Tom Tromey  <tom@tromey.com>
7384
7385         * valprint.c (generic_value_print_char): New function
7386         (generic_value_print): Use it.
7387
7388 2020-03-13  Tom Tromey  <tom@tromey.com>
7389
7390         * valprint.c (generic_value_print_int): New function.
7391         (generic_value_print): Use it.
7392
7393 2020-03-13  Tom Tromey  <tom@tromey.com>
7394
7395         * valprint.c (generic_value_print_bool): New function.
7396         (generic_value_print): Use it.
7397
7398 2020-03-13  Tom Tromey  <tom@tromey.com>
7399
7400         * valprint.c (generic_val_print_func): Simplify.
7401         (generic_val_print, generic_value_print): Update.
7402
7403 2020-03-13  Tom Tromey  <tom@tromey.com>
7404
7405         * valprint.c (generic_val_print_flags): Remove.
7406         (generic_val_print, generic_value_print): Update.
7407         (val_print_type_code_flags): Add original_value parameter.
7408
7409 2020-03-13  Tom Tromey  <tom@tromey.com>
7410
7411         * valprint.c (generic_val_print): Update.
7412         (generic_value_print): Update.
7413         * valprint.c (generic_val_print_enum): Don't call
7414         val_print_scalar_formatted.
7415
7416 2020-03-13  Tom Tromey  <tom@tromey.com>
7417
7418         * valprint.c (generic_value_print): Call generic_value_print_ptr.
7419         * valprint.c (generic_value_print_ptr): New function.
7420
7421 2020-03-13  Tom Tromey  <tom@tromey.com>
7422
7423         * valprint.c (generic_value_print): Rewrite.
7424
7425 2020-03-13  Tom Tromey  <tom@tromey.com>
7426
7427         * p-valprint.c (pascal_object_print_value_fields)
7428         (pascal_object_print_value): New functions.
7429
7430 2020-03-13  Tom Tromey  <tom@tromey.com>
7431
7432         * p-valprint.c (pascal_value_print_inner): Rewrite.
7433
7434 2020-03-13  Tom Tromey  <tom@tromey.com>
7435
7436         * f-valprint.c (f_value_print_innner): Rewrite.
7437
7438 2020-03-13  Tom Tromey  <tom@tromey.com>
7439
7440         * m2-valprint.c (m2_print_unbounded_array): New overload.
7441         (m2_print_unbounded_array): Update.
7442         (m2_print_array_contents): Take a struct value.
7443         (m2_value_print_inner): Rewrite.
7444
7445 2020-03-13  Tom Tromey  <tom@tromey.com>
7446
7447         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
7448         (d_value_print_inner): New function.
7449         * d-lang.h (d_value_print_inner): Declare.
7450         * d-lang.c (d_language_defn): Use d_value_print_inner.
7451
7452 2020-03-13  Tom Tromey  <tom@tromey.com>
7453
7454         * go-valprint.c (go_value_print_inner): New function.
7455         * go-lang.h (go_value_print_inner): Declare.
7456         * go-lang.c (go_language_defn): Use go_value_print_inner.
7457
7458 2020-03-13  Tom Tromey  <tom@tromey.com>
7459
7460         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
7461         API.
7462         (rust_val_print): Rewrite.
7463         (rust_value_print_inner): New function, from rust_val_print.
7464         (rust_language_defn): Use rust_value_print_inner.
7465
7466 2020-03-13  Tom Tromey  <tom@tromey.com>
7467
7468         * ada-valprint.c (ada_value_print_inner): New function.
7469         * ada-lang.h (ada_value_print_inner): Declare.
7470         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
7471
7472 2020-03-13  Tom Tromey  <tom@tromey.com>
7473
7474         * f-valprint.c (f_value_print_innner): New function.
7475         * f-lang.h (f_value_print_innner): Declare.
7476         * f-lang.c (f_language_defn): Use f_value_print_innner.
7477
7478 2020-03-13  Tom Tromey  <tom@tromey.com>
7479
7480         * p-valprint.c (pascal_value_print_inner): New function.
7481         * p-lang.h (pascal_value_print_inner): Declare.
7482         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
7483
7484 2020-03-13  Tom Tromey  <tom@tromey.com>
7485
7486         * m2-valprint.c (m2_value_print_inner): New function.
7487         * m2-lang.h (m2_value_print_inner): Declare.
7488         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
7489
7490 2020-03-13  Tom Tromey  <tom@tromey.com>
7491
7492         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
7493         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
7494         * c-valprint.c (c_value_print_inner): New function.
7495         * c-lang.h (c_value_print_inner): Declare.
7496         * c-lang.c (c_language_defn, cplus_language_defn)
7497         (asm_language_defn, minimal_language_defn): Use
7498         c_value_print_inner.
7499
7500 2020-03-13  Tom Tromey  <tom@tromey.com>
7501
7502         * p-valprint.c (pascal_object_print_value_fields): Now static.
7503         * p-lang.h (pascal_object_print_value_fields): Don't declare.
7504
7505 2020-03-13  Tom Tromey  <tom@tromey.com>
7506
7507         * c-valprint.c (c_val_print_array): Simplify.
7508
7509 2020-03-13  Tom Tromey  <tom@tromey.com>
7510
7511         * valprint.c (value_print_array_elements): New function.
7512         * valprint.h (value_print_array_elements): Declare.
7513
7514 2020-03-13  Tom Tromey  <tom@tromey.com>
7515
7516         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
7517         * mips-tdep.c (mips_print_register): Use
7518         value_print_scalar_formatted.
7519
7520 2020-03-13  Tom Tromey  <tom@tromey.com>
7521
7522         * valprint.h (value_print_scalar_formatted): Declare.
7523         * valprint.c (value_print_scalar_formatted): New function.
7524
7525 2020-03-13  Tom Tromey  <tom@tromey.com>
7526
7527         * valprint.h (generic_value_print): Declare.
7528         * valprint.c (generic_value_print): New function.
7529
7530 2020-03-13  Tom Tromey  <tom@tromey.com>
7531
7532         * valprint.c (do_val_print): Call la_value_print_inner, if
7533         available.
7534         * rust-lang.c (rust_language_defn): Update.
7535         * p-lang.c (pascal_language_defn): Update.
7536         * opencl-lang.c (opencl_language_defn): Update.
7537         * objc-lang.c (objc_language_defn): Update.
7538         * m2-lang.c (m2_language_defn): Update.
7539         * language.h (struct language_defn) <la_value_print_inner>: New
7540         member.
7541         * language.c (unknown_language_defn, auto_language_defn): Update.
7542         * go-lang.c (go_language_defn): Update.
7543         * f-lang.c (f_language_defn): Update.
7544         * d-lang.c (d_language_defn): Update.
7545         * c-lang.c (c_language_defn, cplus_language_defn)
7546         (asm_language_defn, minimal_language_defn): Update.
7547         * ada-lang.c (ada_language_defn): Update.
7548
7549 2020-03-13  Tom Tromey  <tom@tromey.com>
7550
7551         * c-valprint.c (c_value_print): Use common_val_print.
7552
7553 2020-03-13  Tom Tromey  <tom@tromey.com>
7554
7555         * cp-valprint.c (cp_print_static_field): Use common_val_print.
7556
7557 2020-03-13  Tom Tromey  <tom@tromey.com>
7558
7559         * f-valprint.c (f77_print_array_1, f_val_print): Use
7560         common_val_print.
7561
7562 2020-03-13  Tom Tromey  <tom@tromey.com>
7563
7564         * riscv-tdep.c (riscv_print_one_register_info): Use
7565         common_val_print.
7566
7567 2020-03-13  Tom Tromey  <tom@tromey.com>
7568
7569         * mi/mi-main.c (output_register): Use common_val_print.
7570
7571 2020-03-13  Tom Tromey  <tom@tromey.com>
7572
7573         * infcmd.c (default_print_one_register_info): Use
7574         common_val_print.
7575
7576 2020-03-13  Tom Tromey  <tom@tromey.com>
7577
7578         * valprint.h (common_val_print_checked): Declare.
7579         * valprint.c (common_val_print_checked): New function.
7580         * stack.c (print_frame_arg): Use common_val_print_checked.
7581
7582 2020-03-13  Tom Tromey  <tom@tromey.com>
7583
7584         * valprint.c (do_val_print): New function, from val_print.
7585         (val_print): Use do_val_print.
7586         (common_val_print): Use do_val_print.
7587
7588 2020-03-13  Tom Tromey  <tom@tromey.com>
7589
7590         * valprint.c (value_print): Use scoped_value_mark.
7591
7592 2020-03-13  Tom de Vries  <tdevries@suse.de>
7593
7594         PR symtab/25646
7595         * psymtab.c (partial_symtab::partial_symtab): Don't set
7596         globals_offset and statics_offset.  Push element onto
7597         current_global_psymbols and current_static_psymbols stacks.
7598         (concat): New function.
7599         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
7600         element from current_global_psymbols and current_static_psymbols
7601         stacks.  Concat popped elements to global_psymbols and
7602         static_symbols.
7603         (add_psymbol_to_list): Use current_global_psymbols and
7604         current_static_psymbols stacks.
7605         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
7606         current_static_psymbols fields.
7607
7608 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
7609
7610         * corelow.c (sniff_core_bfd): Remove.
7611         (class core_target) <m_core_vec>: Remove.
7612         (core_target::core_target): Update.
7613         (core_file_fns): Remove.
7614         (deprecated_add_core_fns): Remove.
7615         (default_core_sniffer): Remove.
7616         (sniff_core_bfd): Remove.
7617         (default_check_format): Remove.
7618         (gdb_check_format): Remove.
7619         (core_target_open): Update.
7620         (core_target::get_core_register_section): Update.
7621         (get_core_registers_cb): Update.
7622         (core_target::fetch_registers): Update.
7623         * gdbcore.h (struct core_fns): Remove.
7624         (deprecated_add_core_fns): Remove.
7625         (default_core_sniffer): Remove.
7626         (default_check_format): Remove.
7627
7628 2020-03-12  Tom Tromey  <tom@tromey.com>
7629
7630         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
7631         CORE_ADDR.
7632         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
7633
7634 2020-03-12  Tom Tromey  <tom@tromey.com>
7635
7636         * remote.c (remote_target::download_tracepoint)
7637         (remote_target::enable_tracepoint)
7638         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
7639         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
7640         sprintf_vma.
7641
7642 2020-03-12  Tom Tromey  <tom@tromey.com>
7643
7644         * symfile-mem.c: Update CORE_ADDR size assert.
7645
7646 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
7647
7648         * selftest.m4: Move to gdbsupport/.
7649         * acinclude.m4: Update path to selftest.m4.
7650
7651 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
7652
7653         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
7654         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
7655         gdbarch-selfselftests.c and selftest-arch.c.
7656         (SUBDIR_UNITTESTS_OBS): Rename to...
7657         (SELFTESTS_OBS): ... this.
7658         (COMMON_SFILES): Remove disasm-selftests.c and
7659         gdbarch-selftests.c.
7660         * configure.ac: Don't add selftest-arch.{c,o} to
7661         CONFIG_{SRCS,OBS}.
7662         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
7663         preprocessor conditions.
7664
7665 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
7666
7667         * configure.ac: Don't source bfd/development.sh.
7668         * selftest.m4: Modify comment.
7669         * configure: Re-generate.
7670
7671 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
7672
7673         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
7674         not "true" or "false".
7675         * configure: Re-generate.
7676
7677 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
7678
7679         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
7680         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
7681         renamed to arm_nbsd_supply_gregset.
7682         (fetch_register): Update to call arm_nbsd_supply_gregset.
7683         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
7684         (arm_netbsd_nat_target::fetch_registers): Update.
7685         (fetch_elfcore_registers): Removed.
7686         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
7687         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
7688         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
7689         not require NetBSD system headers.
7690         (arm_nbsd_regset): New struct.
7691         (arm_nbsd_iterate_over_regset_sections): New function.
7692         (arm_netbsd_init_abi_common): Updated to call
7693         set_gdbarch_iterate_over_regset_sections.
7694         * arm-nbsd-tdep.h: New file.
7695
7696 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
7697
7698         * symtab.c (find_pc_sect_line): Add check which prevents infinite
7699         recursion.
7700
7701 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
7702
7703         * configure: Re-generate.
7704
7705 2020-03-11  Tom Tromey  <tromey@adacore.com>
7706
7707         * ada-typeprint.c (print_choices): Fix comment.
7708
7709 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7710
7711         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
7712         previous item in the list, when the list has no items.
7713
7714 2020-03-11  Tom de Vries  <tdevries@suse.de>
7715
7716         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
7717         PROP_LOCLIST handling code.
7718
7719 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7720
7721         * buildsym-legacy.c (record_line): Pass extra parameter to
7722         record_line.
7723         * buildsym.c (buildsym_compunit::record_line): Take an extra
7724         parameter, reduce duplication in the line table, and record the
7725         is_stmt flag in the line table.
7726         * buildsym.h (buildsym_compunit::record_line): Add extra
7727         parameter.
7728         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
7729         non-statement lines.
7730         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
7731         this to the symtab builder.
7732         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
7733         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
7734         through to dwarf_record_line_1.
7735         * infrun.c (process_event_stop_test): When stepping, don't stop at
7736         a non-statement instruction, and only refresh the step info when
7737         we land in the middle of a line's range.  Also add an extra
7738         comment.
7739         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
7740         field.
7741         * record-btrace.c (btrace_find_line_range): Only record lines
7742         marked as is-statement.
7743         * stack.c (frame_show_address): Show the frame address if we are
7744         in a non-statement sal.
7745         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
7746         (maintenance_print_one_line_table): Print a header for the is_stmt
7747         column, and include is_stmt information in the output.
7748         * symtab.c (find_pc_sect_line): Find lines marked as statements in
7749         preference to non-statements.
7750         (find_pcs_for_symtab_line): Prefer is-statement entries.
7751         (find_line_common): Likewise.
7752         * symtab.h (struct linetable_entry): Add is_stmt field.
7753         (struct symtab_and_line): Likewise.
7754         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
7755         arranging the line table.
7756
7757 2020-03-07  Tom de Vries  <tdevries@suse.de>
7758
7759         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
7760         DIE.
7761
7762 2020-03-07  Tom Tromey  <tom@tromey.com>
7763
7764         * valops.c (value_literal_complex): Remove obsolete comment.
7765         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
7766         comment.
7767
7768 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
7769
7770         * infrun.h: Forward-declare thread_info.
7771         (set_step_info): Add thread_info parameter, add doc.
7772         * infrun.c (set_step_info): Add thread_info parameter, move doc
7773         to header.
7774         * infrun.c (process_event_stop_test): Pass thread to
7775         set_step_info call.
7776         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
7777         set_step_info.
7778         (prepare_one_step): Add thread_info parameter, pass it to
7779         set_step_frame and prepare_one_step (recursive) call.
7780         (step_1): Pass thread to prepare_one_step call.
7781         (step_command_fsm::should_stop): Pass thread to
7782         prepare_one_step.
7783         (until_next_fsm): Pass thread to set_step_frame call.
7784         (finish_command): Pass thread to set_step_info call.
7785
7786 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
7787
7788         * windows-tdep.c (windows_solib_create_inferior_hook):
7789         Check if inferior is running.
7790
7791 2020-03-06  Tom de Vries  <tdevries@suse.de>
7792
7793         * NEWS: Fix "the the".
7794         * ctfread.c: Same.
7795
7796 2020-03-06  Tom de Vries  <tdevries@suse.de>
7797
7798         * psymtab.c (psymtab_to_symtab): Don't print "done.".
7799
7800 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7801
7802         * .dir-locals.el: Add a comment referencing the other copies of
7803         this file.
7804
7805 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
7806
7807         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
7808         psargs.
7809
7810 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
7811
7812         * .gitattributes: New file.
7813
7814 2020-03-04  Tom Tromey  <tom@tromey.com>
7815
7816         * symmisc.c (print_symbol_bcache_statistics)
7817         (print_objfile_statistics): Update.
7818         * symfile.c (allocate_symtab): Use intern.
7819         * psymtab.c (partial_symtab::partial_symtab): Use intern.
7820         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7821         macro_cache>: Remove.
7822         <string_cache>: New member.
7823         (struct objfile) <intern>: New methods.
7824         * elfread.c (elf_symtab_read): Use intern.
7825         * dwarf2/read.c (fixup_go_packaging): Intern package name.
7826         (dwarf2_compute_name, dwarf2_physname)
7827         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
7828         names.
7829         (guess_partial_die_structure_name): Update.
7830         (partial_die_info::fixup): Intern name.
7831         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
7832         name.
7833         (dwarf2_name): Intern name.  Update.
7834         * buildsym.c (buildsym_compunit::get_macro_table): Use
7835         string_cache.
7836
7837 2020-03-04  Tom Tromey  <tom@tromey.com>
7838
7839         * jit.c (bfd_open_from_target_memory): Make "target" const.
7840         * corefile.c (gnutarget): Now const.
7841         * gdbcore.h (gnutarget): Now const.
7842
7843 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
7844
7845         * NEWS: Mention support for WOW64 processes.
7846         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
7847         (amd64_windows_segment_register_p): Remove static.
7848         (_initialize_amd64_windows_nat): Update.
7849         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
7850         * i386-windows-nat.c (context_offset): Update.
7851         (i386_mappings): Rename and remove static.
7852         (i386_windows_segment_register_p): Remove static.
7853         (_initialize_i386_windows_nat): Update.
7854         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
7855         (STATUS_WX86_SINGLE_STEP): New macro.
7856         (EnumProcessModulesEx): New macro.
7857         (Wow64SuspendThread): New macro.
7858         (Wow64GetThreadContext): New macro.
7859         (Wow64SetThreadContext): New macro.
7860         (Wow64GetThreadSelectorEntry): New macro.
7861         (windows_set_context_register_offsets): Add static.
7862         (windows_set_segment_register_p): Likewise.
7863         (windows_add_thread): Adapt for WOW64 processes.
7864         (windows_fetch_one_register): Likewise.
7865         (windows_nat_target::fetch_registers): Likewise.
7866         (windows_store_one_register): Likewise.
7867         (display_selector): Likewise.
7868         (display_selectors): Likewise.
7869         (handle_exception): Likewise.
7870         (windows_continue): Likewise.
7871         (windows_nat_target::resume): Likewise.
7872         (windows_add_all_dlls): Likewise.
7873         (do_initial_windows_stuff): Likewise.
7874         (windows_nat_target::attach): Likewise.
7875         (windows_get_exec_module_filename): Likewise.
7876         (windows_nat_target::create_inferior): Likewise.
7877         (windows_xfer_siginfo): Likewise.
7878         (_initialize_loadable): Initialize Wow64SuspendThread,
7879         Wow64GetThreadContext, Wow64SetThreadContext,
7880         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
7881         * windows-nat.h (windows_set_context_register_offsets):
7882         Remove declaration.
7883         (windows_set_segment_register_p): Likewise.
7884         (i386_windows_segment_register_p): Add declaration.
7885         (amd64_windows_segment_register_p): Likewise.
7886
7887 2020-03-04  Luis Machado  <luis.machado@linaro.org>
7888
7889         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
7890         in "info registers" for AArch64/ARM.
7891
7892         The change caused "info registers" to not print GPR's.
7893
7894         gdb/ChangeLog:
7895
7896         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
7897
7898         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
7899         when reg->group is empty and reggroup is not.
7900
7901 2020-03-03  Tom Tromey  <tromey@adacore.com>
7902
7903         * dwarf2/frame.c (struct dwarf2_frame_cache)
7904         <checked_tailcall_bottom, entry_cfa_sp_offset,
7905         entry_cfa_sp_offset_p>: Remove members.
7906         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
7907         (dwarf2_frame_prev_register): Don't call
7908         dwarf2_tailcall_sniffer_first.
7909         (dwarf2_append_unwinders): Don't append tailcall unwinder.
7910         * frame-unwind.c (add_unwinder): New fuction.
7911         (frame_unwind_init): Use it.  Add tailcall unwinder.
7912
7913 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7914             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
7915
7916         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
7917         value should be printed as true.
7918
7919 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
7920
7921         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
7922         (windows_init_abi): Set and use windows_so_ops.
7923
7924 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
7925
7926         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
7927         when verifying if dealing with a convenience variable.
7928
7929 2020-03-03  Luis Machado  <luis.machado@linaro.org>
7930
7931         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
7932
7933 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
7934
7935         * infrun.c (gdbarch_supports_displaced_stepping): New.
7936         (use_displaced_stepping): Break up conditions in smaller pieces.
7937         Use gdbarch_supports_displaced_stepping.
7938         (displaced_step_prepare_throw): Use
7939         gdbarch_supports_displaced_stepping.
7940
7941 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7942
7943         * NEWS: Mention new behaviour of the history filename.
7944         * top.c (write_history_p): Add comment.
7945         (show_write_history_p): Add header comment, give a different
7946         message when history writing is on, but the history filename is
7947         empty.
7948         (history_filename): Add comment.
7949         (history_filename_empty): New function.
7950         (show_history_filename): Add header comment, give a different
7951         message when the filename is empty.
7952         (init_history): Compare history_filename against nullptr, and only
7953         read history if the filename is not empty.
7954         (set_history_filename): Add header comment, and only make
7955         non-empty filenames absolute.
7956         (init_main): Make the filename argument to 'set history filename'
7957         optional.
7958
7959 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
7960
7961         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
7962         (arm_supply_vfpregset): ...this, and update to use VFP registers.
7963         (fetch_fp_register): Update.
7964         (fetch_fp_regs): Update.
7965         (store_fp_register): Update.
7966         (store_fp_regs): Update.
7967         (arm_netbsd_nat_target::read_description): New function.
7968         (fetch_elfcore_registers): Update.
7969
7970 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7971
7972         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
7973         general_thread if the stop reply is missing a thread-id.
7974         (remote_target::process_stop_reply): Use the first non-exited
7975         thread if the target didn't pass a thread-id.
7976         * infrun.c (do_target_wait): Move call to
7977         switch_to_inferior_no_thread to ....
7978         (do_target_wait_1): ... here.
7979
7980 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
7981
7982         * debuginfod-support.c: Include defs.h first.
7983
7984 2020-02-28  Tom de Vries  <tdevries@suse.de>
7985
7986         * symfile.c (set_initial_language): Use default language for lookup.
7987
7988 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
7989
7990         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
7991         reader variable, pass `this` to read_cutu_die_from_dwo.
7992
7993 2020-02-27  Aaron Merey  <amerey@redhat.com>
7994
7995         * source.c (open_source_file): Check for nullptr when computing
7996         srcpath.
7997
7998 2020-02-27  Tom Tromey  <tromey@adacore.com>
7999
8000         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
8001         member.
8002         (dwarf2_add_field): Don't update nfields.
8003         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
8004
8005 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8006
8007         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
8008         abs.
8009
8010 2020-02-26  Tom Tromey  <tom@tromey.com>
8011
8012         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
8013         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
8014         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
8015         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
8016         per_cu_data.
8017
8018 2020-02-26  Tom Tromey  <tom@tromey.com>
8019
8020         * dwarf2/index-write.c (psym_index_map): Change type.
8021         (add_address_entry_worker, write_one_signatured_type)
8022         (recursively_count_psymbols, recursively_write_psymbols)
8023         (class debug_names, psyms_seen_size, write_gdbindex)
8024         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
8025
8026 2020-02-26  Aaron Merey  <amerey@redhat.com>
8027
8028         * Makefile.in: Handle optional debuginfod support.
8029         * NEWS: Update.
8030         * README: Add --with-debuginfod summary.
8031         * config.in: Regenerate.
8032         * configure: Regenerate.
8033         * configure.ac: Handle optional debuginfod support.
8034         * debuginfod-support.c: debuginfod helper functions.
8035         * debuginfod-support.h: Ditto.
8036         * doc/gdb.texinfo: Add --with-debuginfod to configure options
8037         summary.
8038         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
8039         when a dwz file cannot be found.
8040         * elfread.c (elf_symfile_read): Query debuginfod servers when a
8041         debuginfo file cannot be found.
8042         * source.c (open_source_file): Query debuginfod servers when a
8043         source file cannot be found.
8044         * top.c (print_gdb_configuration): Include
8045         --{with,without}-debuginfod in the output.
8046
8047 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
8048
8049         * thread.c (thr_try_catch_cmd): Print thread name.
8050
8051 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
8052
8053         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
8054         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
8055         dwarf2_fetch_die_type_sect_off): Move to...
8056         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
8057         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
8058         dwarf2_fetch_die_type_sect_off): ... here.
8059         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
8060         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
8061         dwarf2_fetch_die_type_sect_off): Move doc to header file.
8062
8063 2020-02-26  Tom de Vries  <tdevries@suse.de>
8064
8065         PR gdb/25603
8066         * symfile.c (set_initial_language): Exit-early if
8067         language_mode == language_mode_manual.
8068
8069 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
8070
8071         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
8072         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
8073         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
8074
8075 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
8076
8077         * gdbtypes.c (create_array_type_with_stride): Handle negative
8078         array strides.
8079         * valarith.c (value_subscripted_rvalue): Likewise.
8080
8081 2020-02-25  Luis Machado  <luis.machado@linaro.org>
8082
8083         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
8084
8085 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
8086
8087         * loc.h (dwarf2_get_die_type): Move to...
8088         * read.h (dwarf2_get_die_type): ... here.
8089         * read.c (dwarf2_get_die_type): Move doc to header.
8090
8091 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
8092
8093         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
8094         'gnulib/Makefile.in' to the list.
8095
8096 2020-02-24  Tom Tromey  <tom@tromey.com>
8097
8098         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
8099         Remove.
8100         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
8101         XOBNEWVEC.
8102
8103 2020-02-24  Tom Tromey  <tom@tromey.com>
8104
8105         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
8106         New method.
8107         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
8108         (dw2_do_instantiate_symtab, dw2_get_file_names)
8109         (build_type_psymtab_dependencies, load_full_type_unit): Update.
8110
8111 2020-02-24  Tom Tromey  <tom@tromey.com>
8112
8113         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
8114         make_scoped_restore.
8115         (dwarf2_psymtab::read_symtab): Don't clear
8116         reading_partial_symbols.
8117
8118 2020-02-24  Tom de Vries  <tdevries@suse.de>
8119
8120         PR gdb/25592
8121         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
8122
8123 2020-02-24  Tom de Vries  <tdevries@suse.de>
8124
8125         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
8126         commands layout next/prev/regs.
8127
8128 2020-02-22  Tom Tromey  <tom@tromey.com>
8129
8130         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
8131         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
8132
8133 2020-02-22  Tom Tromey  <tom@tromey.com>
8134
8135         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
8136
8137 2020-02-22  Tom Tromey  <tom@tromey.com>
8138
8139         * tui/tui-win.c (_initialize_tui_win): Add usage text.
8140         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
8141         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
8142         * tui/tui.c (_initialize_tui): Add usage text.
8143
8144 2020-02-22  Tom Tromey  <tom@tromey.com>
8145
8146         * tui/tui-win.c (tui_set_focus_command)
8147         (tui_set_win_height_command): Use error_no_arg.
8148         (_initialize_tui_win): Update help text.
8149         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
8150
8151 2020-02-22  Tom Tromey  <tom@tromey.com>
8152
8153         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
8154         * tui/tui-disasm.h (struct tui_disasm_window)
8155         <display_start_addr>: Declare.
8156         * tui/tui-source.h (struct tui_source_window)
8157         <display_start_addr>: Declare.
8158         * tui/tui-winsource.h (struct tui_source_window_base)
8159         <show_source_line, display_start_addr>: New methods.
8160         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
8161         Rename and move to protected section.
8162         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
8163         (tui_source_window_base::do_erase_source_content): Update.
8164         (tui_source_window_base::show_source_line): Now a method.
8165         (tui_source_window_base::show_source_content)
8166         (tui_source_window_base::tui_source_window_base)
8167         (tui_source_window_base::rerender)
8168         (tui_source_window_base::refill)
8169         (tui_source_window_base::do_scroll_horizontal)
8170         (tui_source_window_base::set_is_exec_point_at)
8171         (tui_source_window_base::update_breakpoint_info)
8172         (tui_source_window_base::update_exec_info): Update.
8173         * tui/tui-source.c (tui_source_window::set_contents)
8174         (tui_source_window::showing_source_p)
8175         (tui_source_window::do_scroll_vertical)
8176         (tui_source_window::location_matches_p)
8177         (tui_source_window::line_is_displayed): Update.
8178         (tui_source_window::display_start_addr): New method.
8179         * tui/tui-disasm.c (tui_disasm_window::set_contents)
8180         (tui_disasm_window::do_scroll_vertical)
8181         (tui_disasm_window::location_matches_p): Update.
8182         (tui_disasm_window::display_start_addr): New method.
8183
8184 2020-02-22  Tom Tromey  <tom@tromey.com>
8185
8186         * NEWS: Add entry for gdb.register_window_type.
8187         * tui/tui-layout.h (window_factory): New typedef.
8188         (tui_register_window): Declare.
8189         * tui/tui-layout.c (saved_tui_windows): New global.
8190         (tui_apply_current_layout): Use it.
8191         (tui_register_window): New function.
8192         * python/python.c (do_start_initialization): Call
8193         gdbpy_initialize_tui.
8194         (python_GdbMethods): Add "register_window_type" function.
8195         * python/python-internal.h (gdbpy_register_tui_window)
8196         (gdbpy_initialize_tui): Declare.
8197         * python/py-tui.c: New file.
8198         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
8199
8200 2020-02-22  Tom Tromey  <tom@tromey.com>
8201
8202         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
8203
8204 2020-02-22  Tom Tromey  <tom@tromey.com>
8205
8206         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
8207         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
8208         * tui/tui-data.c (tui_set_win_with_focus): Remove.
8209         (tui_set_win_focus_to): Move from tui-win.c.
8210
8211 2020-02-22  Tom Tromey  <tom@tromey.com>
8212
8213         * tui/tui-layout.c (make_standard_window, get_locator_window): New
8214         functions.
8215         (known_window_types): New global.
8216         (tui_get_window_by_name): Reimplement.
8217         (initialize_known_windows): New function.
8218         (validate_window_name): Rewrite.
8219         (_initialize_tui_layout): Call initialize_known_windows.
8220
8221 2020-02-22  Tom Tromey  <tom@tromey.com>
8222
8223         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
8224         Remove constants.
8225         * tui/tui-winsource.h (struct tui_source_window_base)
8226         <tui_source_window_base>: Remove parameter.
8227         * tui/tui-winsource.c
8228         (tui_source_window_base::tui_source_window_base): Remove
8229         parameter.
8230         (tui_source_window_base::refill): Update.
8231         * tui/tui-stack.h (struct tui_locator_window)
8232         <tui_locator_window>: Update.
8233         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
8234         Default the constructor.
8235         * tui/tui-regs.h (struct tui_data_item_window)
8236         <tui_data_item_window>: Default the constructor.
8237         (struct tui_data_window) <tui_data_window>: Likewise.
8238         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
8239         Default the constructor.
8240         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
8241         Default the constructor.
8242         <type>: Remove.
8243         (struct tui_win_info) <tui_win_info>: Default the constructor.
8244         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
8245         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
8246         Default the constructor.
8247
8248 2020-02-22  Tom Tromey  <tom@tromey.com>
8249
8250         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
8251         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
8252         * tui/tui-win.c (tui_resize_all): Don't call
8253         tui_delete_invisible_windows.
8254         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
8255         done.
8256         (tui_set_layout): Update.
8257         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
8258         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
8259         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
8260
8261 2020-02-22  Tom Tromey  <tom@tromey.com>
8262
8263         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
8264         correctly.
8265
8266 2020-02-22  Tom Tromey  <tom@tromey.com>
8267
8268         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
8269
8270 2020-02-22  Tom Tromey  <tom@tromey.com>
8271
8272         * tui/tui-winsource.h (struct tui_source_window_iterator)
8273         <inner_iterator>: New etytypedef.
8274         <tui_source_window_iterator>: Take "end" parameter.
8275         <tui_source_window_iterator>: Take iterator.
8276         <operator*, advance>: Update.
8277         <m_iter>: Change type.
8278         <m_end>: New field.
8279         (struct tui_source_windows) <begin, end>: Update.
8280         * tui/tui-layout.c (tui_windows): New global.
8281         (tui_apply_current_layout): Clear tui_windows.
8282         (tui_layout_window::apply): Update tui_windows.
8283         * tui/tui-data.h (tui_windows): Declare.
8284         (all_tui_windows): Now inline function.
8285         (class tui_window_iterator, struct all_tui_windows): Remove.
8286
8287 2020-02-22  Tom Tromey  <tom@tromey.com>
8288
8289         PR tui/17850:
8290         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
8291         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
8292         "height" argument.
8293         (class tui_layout_window) <get_sizes>: Likewise.
8294         (class tui_layout_split) <tui_layout_split>: Add "vertical"
8295         argument.
8296         <get_sizes>: Add "height" argument.
8297         <m_vertical>: New field.
8298         * tui/tui-layout.c (tui_layout_split::clone): Update.
8299         (tui_layout_split::get_sizes): Add "height" argument.
8300         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
8301         (tui_new_layout_command): Parse "-horizontal".
8302         (_initialize_tui_layout): Update help string.
8303         (tui_layout_split::specification): Add "-horizontal" when needed.
8304         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
8305         argument.
8306         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
8307         New methods.
8308
8309 2020-02-22  Tom Tromey  <tom@tromey.com>
8310
8311         * tui/tui-layout.h (enum tui_adjust_result): New.
8312         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
8313         (class tui_layout_window) <adjust_size>: Return
8314         tui_adjust_result.  Rewrite.
8315         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
8316         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
8317
8318 2020-02-22  Tom Tromey  <tom@tromey.com>
8319
8320         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
8321         parameter and return types.
8322         (class tui_layout_base) <specification>: Add "depth".
8323         (class tui_layout_window) <specification>: Add "depth".
8324         (class tui_layout_split) <specification>: Add "depth".
8325         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
8326         and return types.
8327         (tui_new_layout_command): Parse sub-layouts.
8328         (_initialize_tui_layout): Update help string.
8329         (tui_layout_window::specification): Add "depth".
8330         (add_layout_command): Update.
8331
8332 2020-02-22  Tom Tromey  <tom@tromey.com>
8333
8334         * NEWS: Add "tui new-layout" item.
8335         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
8336         Add new-layout command to help text.
8337         (validate_window_name): New function.
8338         (tui_new_layout_command): New function.
8339         (_initialize_tui_layout): Register "new-layout".
8340         (tui_layout_window::specification): New method.
8341         (tui_layout_window::specification): New method.
8342         * tui/tui-layout.h (class tui_layout_base) <specification>: New
8343         method.
8344         (class tui_layout_window) <specification>: New method.
8345         (class tui_layout_split) <specification>: New method.
8346
8347 2020-02-22  Tom Tromey  <tom@tromey.com>
8348
8349         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
8350         * tui/tui-win.c (window_name_completer): Update comment.
8351         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
8352         Declare method.
8353         (class tui_layout_window) <replace_window>: Likewise.
8354         (class tui_layout_split) <replace_window>: Likewise.
8355         (tui_set_layout): Don't declare.
8356         (tui_set_initial_layout): Declare function.
8357         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
8358         (asm_regs_layout): New globals.
8359         (tui_current_layout, show_layout): Remove.
8360         (tui_set_layout, tui_add_win_to_layout): Rewrite.
8361         (find_layout, tui_apply_layout): New function.
8362         (layout_completer): Remove.
8363         (tui_next_layout): Reimplement.
8364         (tui_next_layout_command): New function.
8365         (tui_set_initial_layout, tui_prev_layout_command): New functions.
8366         (tui_regs_layout): Reimplement.
8367         (tui_regs_layout_command): New function.
8368         (extract_display_start_addr): Rewrite.
8369         (next_layout, prev_layout): Remove.
8370         (tui_layout_window::replace_window): New method.
8371         (tui_layout_split::replace_window): New method.
8372         (destroy_layout): New function.
8373         (layout_list): New global.
8374         (add_layout_command): New function.
8375         (initialize_layouts): Update.
8376         (tui_layout_command): New function.
8377         (_initialize_tui_layout): Install "layout" commands.
8378         * tui/tui-data.h (enum tui_layout_type): Remove.
8379         (tui_current_layout): Don't declare.
8380
8381 2020-02-22  Tom Tromey  <tom@tromey.com>
8382
8383         * tui/tui-regs.c (tui_reg_layout): Remove.
8384         (tui_reg_command): Use tui_regs_layout.
8385         * tui/tui-layout.h (tui_reg_command): Declare.
8386         * tui/tui-layout.c (tui_reg_command): New function.
8387
8388 2020-02-22  Tom Tromey  <tom@tromey.com>
8389
8390         * tui/tui.c (tui_rl_delete_other_windows): Call
8391         tui_remove_some_windows.
8392         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
8393         Declare method.
8394         (class tui_layout_window) <remove_windows>: New method.
8395         (class tui_layout_split) <remove_windows>: Declare.
8396         (tui_remove_some_windows): Declare.
8397         * tui/tui-layout.c (tui_remove_some_windows): New function.
8398         (tui_layout_split::remove_windows): New method.
8399
8400 2020-02-22  Tom Tromey  <tom@tromey.com>
8401
8402         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
8403         * tui/tui-layout.h (tui_next_layout): Declare.
8404         * tui/tui-layout.c (tui_next_layout): New function.
8405
8406 2020-02-22  Tom Tromey  <tom@tromey.com>
8407
8408         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
8409         correct coordinates.
8410
8411 2020-02-22  Tom Tromey  <tom@tromey.com>
8412
8413         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
8414         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
8415         DATA_WIN case.
8416
8417 2020-02-22  Tom Tromey  <tom@tromey.com>
8418
8419         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
8420         TUI_DISASM_WIN, not tui_win_list.
8421
8422 2020-02-22  Tom Tromey  <tom@tromey.com>
8423
8424         * valprint.c (generic_val_print_enum_1)
8425         (val_print_type_code_flags): Style member names.
8426         * rust-lang.c (val_print_struct, rust_print_enum)
8427         (rust_print_struct_def, rust_internal_print_type): Style member
8428         names.
8429         * p-valprint.c (pascal_object_print_value_fields): Style member
8430         names.  Only call fprintf_symbol_filtered for static members.
8431         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
8432         * f-valprint.c (f_val_print): Style member names.
8433         * f-typeprint.c (f_type_print_base): Style member names.
8434         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
8435         call fprintf_symbol_filtered for static members.
8436         (cp_print_class_member): Style member names.
8437         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
8438         member names.
8439         * ada-valprint.c (ada_print_scalar): Style enum names.
8440         (ada_val_print_enum): Likewise.
8441         * ada-typeprint.c (print_enum_type): Style enum names.
8442
8443 2020-02-21  Tom Tromey  <tom@tromey.com>
8444
8445         * psympriv.h (struct partial_symtab): Update comment.
8446
8447 2020-02-21  Tom Tromey  <tromey@adacore.com>
8448
8449         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
8450         type is CORE_ADDR.
8451
8452 2020-02-21  Tom de Vries  <tdevries@suse.de>
8453
8454         PR gdb/25534
8455         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
8456         if dependencies[i]->user != NULL.
8457
8458 2020-02-21  Ali Tamur  <tamur@google.com>
8459
8460         * dwarf2/read.c (dwarf2_name): Add null check.
8461
8462 2020-02-20  Tom Tromey  <tom@tromey.com>
8463
8464         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
8465         ">=", in binary search.
8466         (dwarf2_find_containing_comp_unit): New overload.
8467         (run_test): New self-test.
8468         (_initialize_dwarf2_read): Register new test.
8469
8470 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
8471
8472         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
8473         * riscv-tdep.h: Likewise.
8474         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
8475         rv32-only CSR.
8476         * features/riscv/64bit-csr.xml: Regenerated.
8477
8478 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
8479             Tom Tromey  <tom@tromey.com>
8480
8481         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
8482         of 'fputc_unfiltered'.
8483         (putchar_unfiltered): Call 'fputc_unfiltered'.
8484         (fputc_unfiltered): Call 'fputs_unfiltered'.
8485
8486 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
8487
8488         * config.in: Regenerate.
8489         * configure: Regenerate.
8490         * configure.ac: Add --with-python-libdir option.
8491         * main.c: Use WITH_PYTHON_LIBDIR.
8492
8493 2020-02-19  Tom Tromey  <tom@tromey.com>
8494
8495         * symtab.c (general_symbol_info::compute_and_set_names): Use
8496         obstack_strndup.  Simplify call to symbol_set_demangled_name.
8497
8498 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
8499
8500         * dwarf2/read.c (allocate_signatured_type_table,
8501         allocate_dwo_unit_table, allocate_type_unit_groups_table,
8502         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
8503         Remove objfile parameter, update all callers.
8504
8505 2020-02-19  Doug Evans  <dje@google.com>
8506
8507         PR rust/25535
8508         * rust-lang.c (rust_print_enum): Apply embedded_offset to
8509         rust_enum_variant calculation.
8510
8511 2020-02-19  Tom Tromey  <tromey@adacore.com>
8512
8513         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
8514
8515 2020-02-19  Tom Tromey  <tromey@adacore.com>
8516
8517         * ada-lang.c (cache_symbol): Use obstack_strdup.
8518
8519 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
8520
8521         * configure: Regenerate.
8522
8523 2020-02-19  Tom Tromey  <tromey@adacore.com>
8524
8525         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
8526         NULL check.
8527
8528 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
8529
8530         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
8531
8532 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
8533
8534         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
8535         if GDBSERVER is not defined.
8536         (riscv_tdesc_cache): Likewise, also store const target_desc.
8537         (STATIC_IN_GDB): Define.
8538         (riscv_create_target_description): Update declaration with
8539         STATIC_IN_GDB.
8540         (riscv_lookup_target_description): New function, only define if
8541         GDBSERVER is not defined.
8542         * arch/riscv.h (riscv_create_target_description): Declare only
8543         when GDBSERVER is defined.
8544         (riscv_lookup_target_description): New declaration when GDBSERVER
8545         is not defined.
8546         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
8547         (riscv_linux_read_features): ...this, and return
8548         riscv_gdbarch_features instead of target_desc.
8549         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
8550         (riscv_linux_read_description): Rename to...
8551         (riscv_linux_read_features): ...this.
8552         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
8553         Update to use riscv_gdbarch_features and
8554         riscv_lookup_target_description.
8555         * riscv-tdep.c (riscv_find_default_target_description): Use
8556         riscv_lookup_target_description instead of
8557         riscv_create_target_description.
8558
8559 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
8560
8561         * valprint.c (generic_val_print_enum_1): When printing a flag
8562         enum with value 0 and there is no enumerator with value 0, print
8563         just "0" instead of "(unknown: 0x0)".
8564
8565 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
8566
8567         * valprint.c (generic_val_print_enum_1): Print unknown part of
8568         flag enum in hex.
8569
8570 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
8571
8572         * dwarf2/read.c (update_enumeration_type_from_children): Allow
8573         flag enums to contain duplicate enumerators.
8574         * valprint.c (generic_val_print_enum_1): Update comment.
8575
8576 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
8577
8578         * dwarf2/read.c: Include "count-one-bits.h".
8579         (update_enumeration_type_from_children): If an enumerator has
8580         multiple bits set, don't treat the enumeration as a "flag enum".
8581         * valprint.c (generic_val_print_enum_1): Assert that enumerators
8582         of flag enums have 0 or 1 bit set.
8583
8584 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
8585
8586         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
8587         conversion.
8588         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
8589         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
8590         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
8591         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
8592         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
8593
8594 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
8595
8596         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
8597
8598 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
8599
8600         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
8601         displaced_step_closure_up.
8602         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
8603         (struct displaced_step_closure_up):
8604         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
8605         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
8606         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
8607         Likewise.
8608         * gdbarch.sh (displaced_step_copy_insn): Likewise.
8609         * gdbarch.c, gdbarch.h: Re-generate.
8610         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
8611         displaced_step_closure_up.
8612         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
8613         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
8614         * infrun.h (displaced_step_closure_up): New type alias.
8615         (struct displaced_step_inferior_state) <step_closure>: Change
8616         type to displaced_step_closure_up.
8617         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
8618         displaced_step_closure_up.
8619         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
8620
8621 2020-02-14  Tom Tromey  <tom@tromey.com>
8622
8623         * minidebug.c (gnu_debug_key): New global.
8624         (find_separate_debug_file_in_section): Use it.
8625
8626 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
8627
8628         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
8629         std::unique_ptr.
8630         * gdbarch.c: Re-generate.
8631         * gdbarch.h: Re-generate.
8632         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
8633         change.
8634         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
8635         type to std::unique_ptr.
8636         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
8637         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
8638         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
8639         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
8640         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
8641         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
8642         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
8643         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
8644         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
8645
8646 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
8647
8648         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
8649         std::unique_ptr.
8650         (displaced_step_clear): Rename to...
8651         (displaced_step_reset): ... this.  Just call displaced->reset ().
8652         (displaced_step_clear_cleanup): Rename to...
8653         (displaced_step_reset_cleanup): ... this.
8654         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
8655         (displaced_step_fixup): Likewise.
8656         (resume_1): Likewise.
8657         (handle_inferior_event): Restore child's memory before calling
8658         displaced_step_fixup on the parent.
8659         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
8660         to std::unique_ptr.
8661         <step_closure>: Change type to std::unique_ptr.
8662
8663 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
8664
8665         * arm-tdep.c: Include count-one-bits.h.
8666         (cleanup_block_store_pc): Use count_one_bits.
8667         (cleanup_block_load_pc): Use count_one_bits.
8668         (arm_copy_block_xfer): Use count_one_bits.
8669         (thumb2_copy_block_xfer): Use count_one_bits.
8670         (thumb_copy_pop_pc_16bit): Use count_one_bits.
8671         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
8672         (thumb_get_next_pcs_raw): Use count_one_bits.
8673         (arm_get_next_pcs_raw): Use count_one_bits_l.
8674         * arch/arm.c (bitcount): Remove.
8675         * arch/arm.h (bitcount): Remove.
8676
8677 2020-02-14  Tom Tromey  <tromey@adacore.com>
8678
8679         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
8680         Update.
8681         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
8682         * dwarf2/loc.c (call_site_find_chain_1): Return
8683         unique_xmalloc_ptr.
8684         (call_site_find_chain): Likewise.
8685
8686 2020-02-14  Richard Biener  <rguenther@suse.de>
8687
8688         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
8689         on expression with division operators.
8690
8691 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
8692
8693         * MAINTAINERS (Write After Approval): Adding myself.
8694
8695 2020-02-12  Tom Tromey  <tom@tromey.com>
8696
8697         * event-loop.c (event_data, gdb_event, event_handler_func):
8698         Remove.
8699
8700 2020-02-12  Tom Tromey  <tom@tromey.com>
8701
8702         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
8703         (dwarf2_frame_objfile_data): Add comment.
8704         (find_comp_unit, set_comp_unit): New functions.
8705         (dwarf2_frame_find_fde): Use find_comp_unit.
8706         (dwarf2_build_frame_info): Use set_comp_unit.
8707
8708 2020-02-12  Tom Tromey  <tom@tromey.com>
8709
8710         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
8711         (comp_unit): Don't initialize objfile.
8712         (execute_cfa_program): Add text_offset parameter.
8713         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
8714         (dwarf2_frame_cache): Update.
8715         (dwarf2_build_frame_info): Don't set "objfile" member.
8716
8717 2020-02-12  Tom Tromey  <tom@tromey.com>
8718
8719         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
8720         (decode_frame_entry): Likewise.
8721         (dwarf2_build_frame_info): Update.
8722
8723 2020-02-12  Tom Tromey  <tom@tromey.com>
8724
8725         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
8726         (decode_frame_entry_1): Use the comp_unit obstack.
8727
8728 2020-02-12  Tom Tromey  <tom@tromey.com>
8729
8730         * dwarf2/frame.c (struct comp_unit): Add initializers and
8731         constructor.
8732         (dwarf2_frame_objfile_data): Store a comp_unit.
8733         (dwarf2_frame_find_fde): Update.
8734         (dwarf2_build_frame_info): Use "new".
8735
8736 2020-02-12  Tom Tromey  <tom@tromey.com>
8737
8738         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
8739         (dwarf2_fde_table): Typedef for std::vector.
8740         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
8741         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
8742         (decode_frame_entry): Update.
8743         (dwarf2_build_frame_info): Use "new".
8744
8745 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
8746
8747         * arm-tdep.c (arm_gdbarch_init): Update.
8748         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
8749         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
8750         have_neon, is_m>: Change to bool.
8751
8752 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
8753
8754         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
8755
8756 2020-02-12  Tom Tromey  <tom@tromey.com>
8757
8758         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
8759
8760 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
8761
8762         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
8763         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
8764
8765 2020-02-11  Tom Tromey  <tom@tromey.com>
8766
8767         * psymtab.h: Update comment.
8768
8769 2020-02-11  Tom Tromey  <tom@tromey.com>
8770
8771         * gdb_obstack.h (struct auto_obstack): Use
8772         DISABLE_COPY_AND_ASSIGN.
8773
8774 2020-02-11  Tom Tromey  <tom@tromey.com>
8775
8776         * dwarf2/frame.h (struct objfile): Don't forward declare.
8777
8778 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
8779
8780         * cris-tdep.c (cris_supply_gregset): Change signature to match
8781         what struct regset expects.
8782         (cris_regset): New struct.
8783         (fetch_core_registers): Remove.
8784         (cris_iterate_over_regset_sections): New function.
8785         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
8786         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
8787
8788 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
8789
8790         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
8791         registers.
8792
8793 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
8794
8795         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
8796
8797 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
8798
8799         * configure: Re-generate.
8800
8801 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
8802
8803         * configure: Re-generate.
8804
8805 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
8806
8807         * acinclude: Update warning.m4 path.
8808         * warning.m4: Move to gdbsupport.
8809
8810 2020-02-11  Tom Tromey  <tromey@adacore.com>
8811
8812         * remote.c (remote_console_output): Update.
8813         * printcmd.c (printf_command): Update.
8814         * event-loop.c (gdb_wait_for_event): Update.
8815         * linux-nat.c (sigchld_handler): Update.
8816         * remote-sim.c (gdb_os_write_stdout): Update.
8817         (gdb_os_flush_stdout): Update.
8818         (gdb_os_flush_stderr): Update.
8819         (gdb_os_write_stderr): Update.
8820         * exceptions.c (print_exception): Update.
8821         * remote-fileio.c (remote_fileio_func_read): Update.
8822         (remote_fileio_func_write): Update.
8823         * tui/tui.c (tui_enable): Update.
8824         * tui/tui-interp.c (tui_interp::init): Update.
8825         * utils.c (init_page_info): Update.
8826         (putchar_unfiltered, fputc_unfiltered): Update.
8827         (gdb_flush): Update.
8828         (emit_style_escape): Update.
8829         (flush_wrap_buffer, fputs_maybe_filtered): Update.
8830         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
8831         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
8832         (stderr_file::write): Update.
8833         (stderr_file::puts): Update.
8834         * ui-file.h (ui_file_isatty, ui_file_write)
8835         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
8836         (ui_file_puts): Don't declare.
8837
8838 2020-02-10  Tom de Vries  <tdevries@suse.de>
8839
8840         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
8841         sentinel to char *.
8842
8843 2020-02-09  Tom de Vries  <tdevries@suse.de>
8844
8845         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
8846         filename if it matches "<artificial>".
8847
8848 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
8849
8850         * windows-tdep.c (struct enum_value_name): New struct.
8851         (create_enum): New function.
8852         (windows_get_siginfo_type): Create and use enum types.
8853
8854 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
8855
8856         * NEWS: Mention $_siginfo support for Windows.
8857         * windows-nat.c (handle_exception): Set siginfo_er.
8858         (windows_nat_target::mourn_inferior): Reset siginfo_er.
8859         (windows_xfer_siginfo): New function.
8860         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
8861         * windows-tdep.c (struct windows_gdbarch_data): New struct.
8862         (init_windows_gdbarch_data): New function.
8863         (get_windows_gdbarch_data): New function.
8864         (windows_get_siginfo_type): New function.
8865         (windows_init_abi): Register windows_get_siginfo_type.
8866         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
8867
8868 2020-02-08  Tom Tromey  <tom@tromey.com>
8869
8870         * dwarf2/read.c (class cutu_reader) <cutu_reader,
8871         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
8872         <keep>: Declare method.
8873         <m_keep>: Remove member.
8874         <~cutu_reader>: Remove.
8875         (cutu_reader::init_tu_and_read_dwo_dies): Update.
8876         (cutu_reader::cutu_reader): Update.
8877         (cutu_reader::keep): Rename from ~cutu_reader.
8878         (process_psymtab_comp_unit, build_type_psymtabs_1)
8879         (process_skeletonless_type_unit, load_partial_comp_unit)
8880         (load_full_comp_unit, dwarf2_read_addr_index)
8881         (read_signatured_type): Update.
8882
8883 2020-02-08  Tom Tromey  <tom@tromey.com>
8884
8885         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
8886         "want_partial_unit" parameter.
8887         (process_psymtab_comp_unit): Change want_partial_unit to bool.
8888         Inline check for DW_TAG_partial_unit.
8889         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
8890
8891 2020-02-08  Tom Tromey  <tom@tromey.com>
8892
8893         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
8894         read.c.
8895         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
8896         read.c.
8897
8898 2020-02-08  Tom Tromey  <tom@tromey.com>
8899
8900         * dwarf2/read.c (read_address): Move to comp-unit.c.
8901         (dwarf2_rnglists_process, dwarf2_ranges_process)
8902         (read_attribute_value, dwarf_decode_lines_1)
8903         (var_decode_location, decode_locdesc): Update.
8904         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
8905         read.c.  Remove "cu" parameter.
8906         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
8907         method.
8908
8909 2020-02-08  Tom Tromey  <tom@tromey.com>
8910
8911         * dwarf2/read.c (read_attribute_value, read_indirect_string)
8912         (read_indirect_line_string): Update.
8913         * dwarf2/comp-unit.c (read_offset): Remove.
8914         (read_comp_unit_head): Update.
8915         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
8916         method.
8917         (read_offset): Don't declare.
8918
8919 2020-02-08  Tom Tromey  <tom@tromey.com>
8920
8921         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
8922         * dwarf2/read.c (struct comp_unit_head): Move to
8923         dwarf2/comp-unit.h.
8924         (enum class rcuh_kind): Move to comp-unit.h.
8925         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
8926         (read_comp_unit_head, error_check_comp_unit_head)
8927         (read_and_check_comp_unit_head): Move to comp-unit.c.
8928         (read_offset, dwarf_unit_type_name): Likewise.
8929         (create_debug_type_hash_table, read_cutu_die_from_dwo)
8930         (cutu_reader::cutu_reader, read_call_site_scope)
8931         (find_partial_die, follow_die_offset): Update.
8932         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
8933
8934 2020-02-08  Tom Tromey  <tom@tromey.com>
8935
8936         * dwarf2/read.c (read_offset_1): Move to leb.c.
8937         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
8938         (dwarf_decode_macro_bytes): Update.
8939         * dwarf2/leb.c (read_offset): Rename; move from read.c.
8940         * dwarf2/leb.h (read_offset): Declare.
8941
8942 2020-02-08  Tom Tromey  <tom@tromey.com>
8943
8944         * dwarf2/read.c (dwarf2_section_size): Remove.
8945         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
8946         Update.
8947         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
8948
8949 2020-02-08  Tom Tromey  <tom@tromey.com>
8950
8951         * dwarf2/read.c (read_initial_length): Move to leb.c.
8952         * dwarf2/leb.h (read_initial_length): Declare.
8953         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
8954         handle_nonstd parameter.
8955         * dwarf2/frame.c (read_initial_length): Remove.
8956         (decode_frame_entry_1): Update.
8957
8958 2020-02-08  Tom Tromey  <tom@tromey.com>
8959
8960         * dwarf2/loc.c (dwarf2_find_location_expression)
8961         (dwarf_evaluate_loc_desc::get_tls_address)
8962         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
8963         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
8964         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
8965         (dwarf2_compile_property_to_c)
8966         (dwarf2_loc_desc_get_symbol_read_needs)
8967         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
8968         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
8969         (loclist_describe_location, loclist_tracepoint_var_ref)
8970         (loclist_generate_c_location): Update.
8971         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
8972         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
8973         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
8974         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
8975         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
8976         (dwarf2_per_cu_data::addr_size)
8977         (dwarf2_per_cu_data::ref_addr_size)
8978         (dwarf2_per_cu_data::text_offset)
8979         (dwarf2_per_cu_data::addr_type): Now methods.
8980         (per_cu_header_read_in): Make per_cu "const".
8981         (dwarf2_version): Remove.
8982         (dwarf2_per_cu_data::int_type): Now a method.
8983         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
8984         (set_die_type, read_array_type, read_subrange_index_type)
8985         (read_tag_string_type, read_subrange_type): Update.
8986         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
8987         offset_size, ref_addr_size, text_offset, addr_type, version,
8988         objfile, int_type, addr_sized_int_type>: Declare methods.
8989
8990 2020-02-08  Tom Tromey  <tom@tromey.com>
8991
8992         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
8993         Move earlier.
8994
8995 2020-02-08  Tom Tromey  <tom@tromey.com>
8996
8997         * dwarf2/read.h (dwarf_line_debug): Declare.
8998         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
8999         * dwarf2/read.c: Move line_header code to new files.
9000         (dwarf_line_debug): No longer static.
9001         * dwarf2/line-header.c: New file.
9002         * dwarf2/line-header.h: New file.
9003
9004 2020-02-08  Tom Tromey  <tom@tromey.com>
9005
9006         * dwarf2/read.c (struct line_header) <file_full_name,
9007         file_file_name>: Return unique_xmalloc_ptr.
9008         (line_header::file_file_name): Update.
9009         (line_header::file_full_name): Update.
9010         (dw2_get_file_names_reader): Update.
9011         (macro_start_file): Update.
9012
9013 2020-02-08  Tom Tromey  <tom@tromey.com>
9014
9015         * dwarf2/read.c (struct line_header) <file_full_name,
9016         file_file_name>: Declare methods.
9017         (dw2_get_file_names_reader): Update.
9018         (file_file_name): Now a method.
9019         (file_full_name): Likewise.
9020         (macro_start_file): Update.
9021
9022 2020-02-08  Tom Tromey  <tom@tromey.com>
9023
9024         * dwarf2/read.c (dwarf_always_disassemble)
9025         (show_dwarf_always_disassemble): Move to loc.c.
9026         (_initialize_dwarf2_read): Move "always-disassemble" registration
9027         to loc.c.
9028         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
9029         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
9030         static.
9031         (show_dwarf_always_disassemble): Move from read.c.
9032         (_initialize_dwarf2loc): Move always-disassemble from read.c.
9033
9034 2020-02-08  Tom Tromey  <tom@tromey.com>
9035
9036         * dwarf2/read.c (~dwarf2_per_objfile): Update.
9037         (create_quick_file_names_table): Return htab_up.
9038         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
9039         Update.
9040         * dwarf2/read.h (struct dwarf2_per_objfile)
9041         <quick_file_names_table>: Now htab_up.
9042
9043 2020-02-08  Tom Tromey  <tom@tromey.com>
9044
9045         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
9046
9047 2020-02-08  Tom Tromey  <tom@tromey.com>
9048
9049         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
9050         Rewrite.
9051         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
9052         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
9053         (abbrev_table::abbrev_table): No longer inline.
9054         (ABBREV_HASH_SIZE): Remove.
9055         (abbrev_table::m_abbrevs): Now an htab_up.
9056
9057 2020-02-08  Tom Tromey  <tom@tromey.com>
9058
9059         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
9060         (cutu_reader): Update.
9061         (build_type_psymtabs_1): Update.
9062         * dwarf2/abbrev.c (abbrev_table::read): Rename.
9063         (abbrev_table::alloc_abbrev): Update.
9064         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
9065         (abbrev_table::read): New static method, renamed from
9066         abbrev_table_read_table.
9067         (abbrev_table::alloc_abbrev)
9068         (abbrev_table::add_abbrev): Now private.
9069         (abbrev_table::abbrev_table): Now private.
9070         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
9071
9072 2020-02-08  Tom Tromey  <tom@tromey.com>
9073
9074         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
9075         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
9076         htab_up.
9077
9078 2020-02-08  Tom Tromey  <tom@tromey.com>
9079
9080         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
9081         htab_up.
9082         (lookup_dwo_unit_in_dwp): Update.
9083         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
9084         on obstack.
9085
9086 2020-02-08  Tom Tromey  <tom@tromey.com>
9087
9088         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
9089         obstack.
9090
9091 2020-02-08  Tom Tromey  <tom@tromey.com>
9092
9093         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
9094         line_header_hash.
9095         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
9096         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
9097         Change type to htab_up.
9098
9099 2020-02-08  Tom Tromey  <tom@tromey.com>
9100
9101         * dwarf2/read.c (allocate_type_unit_groups_table): Return
9102         htab_up.  Don't allocate on obstack.
9103         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
9104         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
9105         Change type to htab_up.
9106
9107 2020-02-08  Tom Tromey  <tom@tromey.com>
9108
9109         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
9110         Change type to htab_up.
9111         * dwarf2/read.c (create_signatured_type_table_from_index)
9112         (create_signatured_type_table_from_debug_names)
9113         (create_all_type_units, add_type_unit)
9114         (lookup_dwo_signatured_type, lookup_signatured_type)
9115         (process_skeletonless_type_unit): Update.
9116         (create_debug_type_hash_table, create_debug_types_hash_table):
9117         Change type of types_htab.
9118         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
9119         htab_up.  Don't allocate on obstack.
9120         (create_cus_hash_table): Change type of cus_htab parameter.
9121         (struct dwo_file) <cus, tus>: Now htab_up.
9122         (lookup_dwo_signatured_type, lookup_dwo_cutu)
9123         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
9124         (queue_and_load_all_dwo_tus): Update.
9125         * dwarf2/index-write.c (write_gdbindex): Update.
9126         (write_debug_names): Update.
9127
9128 2020-02-08  Tom Tromey  <tom@tromey.com>
9129
9130         * dwarf2/read.h (struct dwarf2_queue_item): Move from
9131         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
9132         destructor.
9133         (struct dwarf2_per_objfile) <queue>: New member.
9134         * dwarf2/read.c (struct dwarf2_queue_item): Move to
9135         dwarf2/read.h.
9136         (dwarf2_queue, dwarf2_queue_tail): Remove.
9137         (class dwarf2_queue_guard): Add parameter to constructor.  Use
9138         DISABLE_COPY_AND_ASSIGN.
9139         <m_per_objfile>: New member.
9140         <~dwarf2_queue_guard>: Rewrite.
9141         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
9142         Update.
9143         (~dwarf2_queue_item): New.
9144
9145 2020-02-08  Tom Tromey  <tom@tromey.com>
9146
9147         * dwarf2/read.c (struct die_info) <has_children>: New member.
9148         (dw2_get_file_names_reader): Remove has_children.
9149         (dw2_get_file_names): Update.
9150         (read_cutu_die_from_dwo): Remove has_children.
9151         (cutu_reader::init_tu_and_read_dwo_dies)
9152         (cutu_reader::cutu_reader): Update.
9153         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
9154         Remove has_children.
9155         (build_type_psymtabs_1, process_skeletonless_type_unit)
9156         (load_partial_comp_unit, load_full_comp_unit): Update.
9157         (create_dwo_cu_reader): Remove has_children.
9158         (create_cus_hash_table, read_die_and_children): Update.
9159         (read_full_die_1,read_full_die): Remove has_children.
9160         (read_signatured_type): Update.
9161         (class cutu_reader) <has_children>: Remove.
9162
9163 2020-02-08  Tom Tromey  <tom@tromey.com>
9164
9165         * dwarf2/expr.c: Rename from dwarf2expr.c.
9166         * dwarf2/expr.h: Rename from dwarf2expr.h.
9167         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
9168         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
9169         * dwarf2/frame.c: Rename from dwarf2-frame.c.
9170         * dwarf2/frame.h: Rename from dwarf2-frame.h.
9171         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
9172         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
9173         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
9174         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
9175         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
9176         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
9177         * dwarf2/loc.c: Rename from dwarf2loc.c.
9178         * dwarf2/loc.h: Rename from dwarf2loc.h.
9179         * dwarf2/read.c: Rename from dwarf2read.c.
9180         * dwarf2/read.h: Rename from dwarf2read.h.
9181         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
9182         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
9183         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
9184         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
9185         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
9186         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
9187         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
9188         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
9189         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
9190         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
9191         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
9192         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
9193         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
9194         Update.
9195         * Makefile.in (COMMON_SFILES): Update.
9196         (HFILES_NO_SRCDIR): Update.
9197
9198 2020-02-08  Tom Tromey  <tom@tromey.com>
9199
9200         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
9201         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
9202
9203 2020-02-08  Tom Tromey  <tom@tromey.com>
9204
9205         * dwarf2read.h (struct die_info): Don't declare.
9206
9207 2020-02-08  Tom Tromey  <tom@tromey.com>
9208
9209         * dwarf2read.h (die_info_ptr): Remove typedef.
9210
9211 2020-02-08  Tom Tromey  <tom@tromey.com>
9212
9213         * dwarf2read.c (read_call_site_scope)
9214         (handle_data_member_location, dwarf2_add_member_fn)
9215         (mark_common_block_symbol_computed, read_common_block)
9216         (attr_to_dynamic_prop, partial_die_info::read)
9217         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
9218         (dwarf2_symbol_mark_computed, set_die_type): Update.
9219         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
9220         method.
9221         (attr_form_is_block): Don't declare.
9222         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
9223
9224 2020-02-08  Tom Tromey  <tom@tromey.com>
9225
9226         * dwarf2read.c (dwarf2_find_base_address, )
9227         (read_call_site_scope, rust_containing_type)
9228         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
9229         (handle_data_member_location, dwarf2_add_member_fn)
9230         (get_alignment, read_structure_type, process_structure_scope)
9231         (mark_common_block_symbol_computed, read_common_block)
9232         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
9233         (partial_die_info::read, read_attribute_value, new_symbol)
9234         (lookup_die_type, dwarf2_get_ref_die_offset)
9235         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
9236         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
9237         (dwarf2_symbol_mark_computed): Update.
9238         * dwarf2/attribute.h (struct attribute) <value_as_address,
9239         form_is_section_offset, form_is_constant, form_is_ref>: Declare
9240         methods.
9241         (value_as_address, attr_form_is_section_offset)
9242         (attr_form_is_constant, attr_form_is_ref): Don't declare.
9243         * dwarf2/attribute.c (attribute::value_as_address)
9244         (attribute::form_is_section_offset, attribute::form_is_constant)
9245         (attribute::form_is_ref): Now methods.
9246
9247 2020-02-08  Tom Tromey  <tom@tromey.com>
9248
9249         * dwarf2read.c (struct attribute, DW_STRING)
9250         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
9251         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
9252         (attr_form_is_block, attr_form_is_section_offset)
9253         (attr_form_is_constant, attr_form_is_ref): Move.
9254         * dwarf2/attribute.h: New file.
9255         * dwarf2/attribute.c: New file, from dwarf2read.c.
9256         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
9257
9258 2020-02-08  Tom Tromey  <tom@tromey.com>
9259
9260         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
9261         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
9262         Move.
9263         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
9264         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
9265         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
9266         abbrev.c.
9267         * dwarf2/abbrev.h: New file.
9268         * dwarf2/abbrev.c: New file, from dwarf2read.c.
9269         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
9270
9271 2020-02-08  Tom Tromey  <tom@tromey.com>
9272
9273         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
9274         (dwarf2_section_size, dwarf2_get_section_info)
9275         (create_signatured_type_table_from_debug_names)
9276         (create_addrmap_from_aranges, read_debug_names_from_section)
9277         (get_gdb_index_contents_from_section, read_comp_unit_head)
9278         (error_check_comp_unit_head, read_abbrev_offset)
9279         (create_debug_type_hash_table, init_cu_die_reader)
9280         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
9281         (read_comp_units_from_section, create_cus_hash_table)
9282         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
9283         (create_dwp_v2_section, dwarf2_rnglists_process)
9284         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
9285         (abbrev_table_read_table, read_indirect_string_at_offset_from)
9286         (read_indirect_string_from_dwz, read_addr_index_1)
9287         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
9288         (dwarf_decode_macro_bytes, dwarf_decode_macros)
9289         (fill_in_loclist_baton): Update.
9290         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
9291         get_containing_section, get_bfd_owner, get_bfd_section,
9292         get_file_name, get_id, get_flags, empty, read>: Declare methods.
9293         (dwarf2_read_section, get_section_name, get_section_file_name)
9294         (get_containing_section, get_section_bfd_owner)
9295         (get_section_bfd_section, get_section_name, get_section_file_name)
9296         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
9297         declare.
9298         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
9299         (dwarf2_section_info::get_bfd_owner)
9300         (dwarf2_section_info::get_bfd_section)
9301         (dwarf2_section_info::get_name)
9302         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
9303         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
9304         (dwarf2_section_info::read): Now methods.
9305         * dwarf-index-write.c (class debug_names): Update.
9306
9307 2020-02-08  Tom Tromey  <tom@tromey.com>
9308
9309         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
9310         Move to dwarf2/section.h.
9311         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
9312         (get_section_bfd_section, get_section_name)
9313         (get_section_file_name, get_section_id, get_section_flags)
9314         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
9315         dwarf2/section.c.
9316         * dwarf2/section.h: New file.
9317         * dwarf2/section.c: New file, from dwarf2read.c.
9318         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
9319
9320 2020-02-08  Tom Tromey  <tom@tromey.com>
9321
9322         * dwarf2read.h (read_unsigned_leb128): Don't declare.
9323         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
9324         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
9325         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
9326         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
9327         * dwarf2/leb.h: New file, from dwarf2read.c.
9328         * dwarf2/leb.c: New file, from dwarf2read.c.
9329         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
9330         Remove.
9331         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
9332         (COMMON_SFILES): Add dwarf2/leb.c.
9333
9334 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
9335
9336         GDB 9.1 released.
9337
9338 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
9339
9340         PR gdb/25190:
9341         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
9342         * gdb/remote.c (remote_console_output): Update.
9343         * gdb/ui-file.c (fputs_unfiltered): Rename to...
9344         (ui_file_puts): ...this.
9345         * gdb/ui-file.h (ui_file_puts): Add declaration.
9346         * gdb/utils.c (emit_style_escape): Update.
9347         (flush_wrap_buffer): Update.
9348         (fputs_maybe_filtered): Update.
9349         (fputs_unfiltered): Add function.
9350
9351 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
9352
9353         * gdb/event-loop.c (gdb_wait_for_event): Update.
9354         * gdb/printcmd.c (printf_command): Update.
9355         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
9356         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
9357         (gdb_os_flush_stderr): Update.
9358         * gdb/remote.c (remote_console_output): Update.
9359         * gdb/ui-file.c (gdb_flush): Rename to...
9360         (ui_file_flush): ...this.
9361         (stderr_file::write): Update.
9362         (stderr_file::puts): Update.
9363         * gdb/ui-file.h (gdb_flush): Rename to...
9364         (ui_file_flush): ...this.
9365         * gdb/utils.c (gdb_flush): Add function.
9366         * gdb/utils.h (gdb_flush): Add declaration.
9367
9368 2020-02-07  Tom Tromey  <tromey@adacore.com>
9369
9370         PR breakpoints/24915:
9371         * source.c (find_and_open_source): Do not check basenames_may_differ.
9372
9373 2020-02-07  Tom Tromey  <tom@tromey.com>
9374
9375         * README: Update gdbserver documentation.
9376         * gdbserver: Move to top level.
9377         * configure.tgt (build_gdbserver): Remove.
9378         * configure.ac: Remove --enable-gdbserver.
9379         * configure: Rebuild.
9380         * Makefile.in (distclean): Don't mention gdbserver.
9381
9382 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
9383
9384         * source-cache.c (source_cache::ensure): Surround
9385         get_plain_source_lines with a try/catch.
9386         (source_cache::get_line_charpos): Get rid of try/catch
9387         and only check for the return value of "ensure".
9388         * tui/tui-source.c (tui_source_window::set_contents):
9389         Simplify "nlines" calculation.
9390
9391 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
9392
9393         * MAINTAINERS (Write After Approval): Add myself.
9394
9395 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
9396
9397         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
9398         function call.
9399
9400 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
9401
9402         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
9403
9404 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
9405
9406         * nat/riscv-linux-tdesc.h: New file.
9407         * nat/riscv-linux-tdesc.c: New file, taking code from...
9408         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
9409         ... here.
9410         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
9411         NATDEPFILES.
9412
9413 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
9414
9415         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
9416         we don't set the fake simulator ptid to the null_ptid.
9417
9418 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
9419
9420         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
9421         * gdbthread.h (class thread_info) <resumed>: Likewise.
9422         * infrun.c (resume_1): Likewise.
9423         (proceed): Likewise.
9424         (infrun_thread_stop_requested): Likewise.
9425         (stop_all_threads): Likewise.
9426         (handle_inferior_event): Likewise.
9427         (restart_threads): Likewise.
9428         (finish_step_over): Likewise.
9429         (keep_going_stepped_thread): Likewise.
9430         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
9431         (linux_handle_extended_wait): Likewise.
9432         * record-btrace.c (get_thread_current_frame_id): Likewise.
9433         * record-full.c (record_full_wait_1): Likewise.
9434         * remote.c (remote_target::process_initial_stop_replies): Likewise.
9435         * target.c (target_resume): Likewise.
9436         * thread.c (set_running_thread): Likewise.
9437
9438 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
9439
9440         * f-valprint.c (f77_print_array_1): Changed datatype of index
9441         variable to LONGEST from int to enable it to contain bound
9442         values correctly.
9443
9444 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
9445
9446         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
9447         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
9448         offsets according to FLEN determined.
9449         (riscv_linux_nat_target::read_description): Determine FLEN
9450         dynamically.
9451         (riscv_linux_nat_target::fetch_registers): Size regset buffer
9452         according to FLEN determined.
9453         (riscv_linux_nat_target::store_registers): Likewise.
9454
9455 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
9456
9457         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
9458         when reg->group is empty and reggroup is not.
9459
9460 2020-01-31  Tom Tromey  <tromey@adacore.com>
9461
9462         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
9463         Call beneath target's mourn_inferior after unpushing.
9464
9465 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
9466
9467         PR tui/9765
9468         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
9469         have enough lines to fill the screen, still return the lowest
9470         address we found.
9471
9472 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
9473
9474         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
9475         '-', '<', and '>' commands.
9476
9477 2020-01-29  Pedro Alves  <palves@redhat.com>
9478             Sergio Durigan Junior  <sergiodj@redhat.com>
9479
9480         * infcmd.c (construct_inferior_arguments): Assert that
9481         'argc' is greater than 0.
9482
9483 2020-01-29  Luis Machado  <luis.machado@linaro.org>
9484
9485         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
9486         (BRK_INSN_MASK): Define to 0xd4200000.
9487         (aarch64_program_breakpoint_here_p): New function.
9488         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
9489         * arch-utils.c (default_program_breakpoint_here_p): Moved from
9490         breakpoint.c.
9491         * arch-utils.h (default_program_breakpoint_here_p): Moved from
9492         breakpoint.h
9493         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
9494         call gdbarch_program_breakpoint_here_p.
9495         (program_breakpoint_here): Moved to arch-utils.c, renamed to
9496         default_program_breakpoint_here_p, changed return type to bool and
9497         simplified.
9498         * breakpoint.h (program_breakpoint_here): Moved prototype to
9499         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
9500         return type to bool.
9501         * gdbarch.c: Regenerate.
9502         * gdbarch.h: Regenerate.
9503         * gdbarch.sh (program_breakpoint_here_p): New method.
9504         * infrun.c (handle_signal_stop): Call
9505         gdbarch_program_breakpoint_here_p.
9506
9507 2020-01-26  Tom Tromey  <tom@tromey.com>
9508
9509         * ctfread.c (struct ctf_fp_info): Reindent.
9510         (_initialize_ctfread): Remove.
9511
9512 2020-01-26  Tom Tromey  <tom@tromey.com>
9513
9514         * psymtab.c (partial_map_expand_apply)
9515         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
9516         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
9517         (psym_print_stats, psym_expand_symtabs_for_function)
9518         (psym_map_symbol_filenames, psym_map_matching_symbols)
9519         (psym_expand_symtabs_matching)
9520         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
9521         (maintenance_check_psymtabs): Use new methods.
9522         * psympriv.h (struct partial_symtab) <readin_p,
9523         get_compunit_symtab>: New methods.
9524         <readin, compunit_symtab>: Remove members.
9525         (struct standard_psymtab): New.
9526         (struct legacy_psymtab): Derive from standard_psymtab.
9527         * dwarf2read.h (struct dwarf2_psymtab): Derive from
9528         standard_psymtab.
9529         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
9530
9531 2020-01-26  Tom Tromey  <tom@tromey.com>
9532
9533         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
9534         read_dependencies.  Add assert.
9535         * psymtab.c (partial_symtab::read_dependencies): New method.
9536         * psympriv.h (struct partial_symtab) <read_dependencies>: New
9537         method.
9538         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
9539         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
9540         read_dependencies.
9541         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
9542         Add assert.
9543
9544 2020-01-26  Tom Tromey  <tom@tromey.com>
9545
9546         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
9547         Call expand_psymtab.
9548         (xcoff_read_symtab): Call expand_psymtab.
9549         (xcoff_start_psymtab, xcoff_end_psymtab): Set
9550         legacy_expand_psymtab.
9551         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
9552         method.
9553         (struct legacy_psymtab) <expand_psymtab>: Implement.
9554         <legacy_expand_psymtab>: New member.
9555         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
9556         (parse_partial_symbols): Set legacy_expand_psymtab.
9557         (psymtab_to_symtab_1): Change argument order.  Call
9558         expand_psymtab.
9559         (new_psymtab): Set legacy_expand_psymtab.
9560         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
9561         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
9562         expand_psymtab.
9563         (dwarf2_psymtab::expand_psymtab): Rename from
9564         psymtab_to_symtab_1.  Call expand_psymtab.
9565         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
9566         (dbx_end_psymtab): Likewise.
9567         (dbx_psymtab_to_symtab_1): Change argument order. Call
9568         expand_psymtab.
9569         (dbx_read_symtab): Call expand_psymtab.
9570         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
9571         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
9572         (ctf_psymtab::read_symtab): Call expand_psymtab.
9573
9574 2020-01-26  Tom Tromey  <tom@tromey.com>
9575
9576         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
9577         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
9578         messages.
9579         * mdebugread.c (mdebug_read_symtab): Remove prints.
9580         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
9581         assert.
9582         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
9583
9584 2020-01-26  Tom Tromey  <tom@tromey.com>
9585
9586         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
9587         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
9588         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
9589         legacy_symtab.
9590         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
9591         * psymtab.c (psymtab_to_symtab): Call method.
9592         (dump_psymtab): Update.
9593         * psympriv.h (struct partial_symtab): Add virtual destructor.
9594         <read_symtab>: New method.
9595         (struct legacy_symtab): New.
9596         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
9597         (struct pst_map) <pst>: Now a legacy_psymtab.
9598         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
9599         (new_psymtab): Use legacy_psymtab.
9600         * dwarf2read.h (struct dwarf2_psymtab): New.
9601         (struct dwarf2_per_cu_data) <psymtab>: Use it.
9602         * dwarf2read.c (dwarf2_create_include_psymtab)
9603         (dwarf2_build_include_psymtabs, create_type_unit_group)
9604         (create_partial_symtab, process_psymtab_comp_unit_reader)
9605         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
9606         (set_partial_user): Use dwarf2_psymtab.
9607         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
9608         (psymtab_to_symtab_1, process_full_comp_unit)
9609         (process_full_type_unit, dwarf2_ranges_read)
9610         (dwarf2_get_pc_bounds, psymtab_include_file_name)
9611         (dwarf_decode_lines): Use dwarf2_psymtab.
9612         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
9613         (add_address_entry_worker, write_one_signatured_type)
9614         (recursively_count_psymbols, recursively_write_psymbols)
9615         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
9616         (write_debug_names): Likewise.
9617         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
9618         <pst>: Now a legacy_psymtab.
9619         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
9620         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
9621         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
9622         * ctfread.c (struct ctf_psymtab): New.
9623         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
9624         ctf_psymtab.
9625         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
9626         (create_partial_symtab): Return a ctf_psymtab.
9627         (scan_partial_symbols): Update.
9628
9629 2020-01-26  Tom Tromey  <tom@tromey.com>
9630
9631         * xcoffread.c (xcoff_start_psymtab): Use new.
9632         * psymtab.c (partial_symtab::partial_symtab): New constructor,
9633         renamed from start_psymtab_common.
9634         * psympriv.h (struct partial_symtab): Add new constructor.
9635         (start_psymtab_common): Don't declare.
9636         * mdebugread.c (parse_partial_symbols): Use new.
9637         * dwarf2read.c (create_partial_symtab): Use new.
9638         * dbxread.c (start_psymtab): Use new.
9639         * ctfread.c (create_partial_symtab): Use new.
9640
9641 2020-01-26  Tom Tromey  <tom@tromey.com>
9642
9643         * xcoffread.c (xcoff_end_psymtab): Use new.
9644         * psymtab.c (start_psymtab_common): Use new.
9645         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
9646         Update.
9647         * psympriv.h (struct partial_symtab): Add parameters to
9648         constructor.  Don't inline.
9649         (allocate_psymtab): Don't declare.
9650         * mdebugread.c (new_psymtab): Use new.
9651         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
9652         * dbxread.c (dbx_end_psymtab): Use new.
9653
9654 2020-01-26  Tom Tromey  <tom@tromey.com>
9655
9656         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
9657         allocate_psymtab.  Update documentation.
9658         * psymtab.c (psymtab_storage::install_psymtab): Rename from
9659         allocate_psymtab.  Do not use new.
9660         (allocate_psymtab): Use new.  Update.
9661
9662 2020-01-26  Tom Tromey  <tom@tromey.com>
9663
9664         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
9665         * psymtab.c (psym_print_stats): Update.
9666         * psympriv.h (struct partial_symtab) <readin,
9667         psymtabs_addrmap_supported, anonymous>: Now bool.
9668         * mdebugread.c (psymtab_to_symtab_1): Update.
9669         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
9670         (build_type_psymtabs_reader, psymtab_to_symtab_1)
9671         (process_full_comp_unit, process_full_type_unit): Update.
9672         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
9673         * ctfread.c (psymtab_to_symtab): Update.
9674
9675 2020-01-26  Tom Tromey  <tom@tromey.com>
9676
9677         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
9678         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
9679         * psymtab.c (psymtab_storage): Delete psymtabs.
9680         (psymtab_storage::allocate_psymtab): Use new.
9681         (psymtab_storage::discard_psymtab): Use delete.
9682         * psympriv.h (struct partial_symtab): Add constructor and
9683         initializers.
9684
9685 2020-01-26  Tom Tromey  <tom@tromey.com>
9686
9687         * machoread.c: Do not include psympriv.h.
9688
9689 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9690
9691         * NEWS: Mention the new option and the set/show commands.
9692
9693 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9694
9695         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
9696         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
9697         (validate_exec_file): New variables, enums, functions.
9698         (exec_file_locate_attach, print_section_info): Style the filenames.
9699         (_initialize_exec): Install show_exec_file_mismatch_command and
9700          set_exec_file_mismatch_command.
9701         * gdbcore.h (validate_exec_file): Declare.
9702         * infcmd.c (attach_command): Call validate_exec_file.
9703         * remote.c ( remote_target::remote_add_inferior): Likewise.
9704
9705 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
9706
9707         * frame.c (find_frame_sal): Move call to get_next_frame into more
9708         inner scope.
9709         * inline-frame.c (inilne_state) <inline_state>: Update argument
9710         types.
9711         (inilne_state) <skipped_symbol>: Rename to...
9712         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
9713         (skip_inline_frames): Build vector of skipped symbols and use this
9714         to reate the inline_state.
9715         (inline_skipped_symbol): Add a comment and some assertions, fetch
9716         skipped symbol from the list.
9717
9718 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
9719
9720         * buildsym.c (lte_is_less_than): Delete.
9721         (buildsym_compunit::end_symtab_with_blockvector): Create local
9722         lambda function to sort line table entries, and use
9723         std::stable_sort instead of std::sort.
9724         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
9725         markers when looking for a previous line.
9726
9727 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
9728
9729         * dwarf2read.c (lnp_state_machine::record_line): Include
9730         end_sequence parameter in debug print out.  Record the line if we
9731         are at an end_sequence marker even if it's not the start of a
9732         statement.
9733         * symmisc.c (maintenance_print_one_line_table): Print end of
9734         sequence markers with 'END' not '0'.
9735
9736 2020-01-24  Pedro Alves  <palves@redhat.com>
9737
9738         PR gdb/25410
9739         * thread.c (scoped_restore_current_thread::restore): Use
9740         switch_to_inferior_no_thread.
9741         * exec.c: Include "progspace-and-thread.h".
9742         (add_target_sections, remove_target_sections):
9743         scoped_restore_current_pspace_and_thread instead of
9744         scoped_restore_current_thread.
9745         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
9746         and aspace to the inferior before calling clone_program_space.
9747         Remove stale comment.
9748
9749 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
9750
9751         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
9752         (arm_netbsd_nat_target::fetch_registers): ...this.
9753         (arm_nbsd_nat_target::store_registers): Rename to...
9754         (arm_netbsd_nat_target::store_registers): ...this.
9755
9756 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
9757
9758         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
9759         register_t.
9760
9761 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
9762
9763         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
9764         Update comment.
9765         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
9766         Likewise.
9767         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
9768         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
9769         the correct replacement (iterate_over_regset_sections).
9770         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
9771         Update comment.
9772
9773 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
9774
9775         PR gdb/23718
9776         * gdb/python/python.c (execute_gdb_command): Call
9777         async_enable_stdin in catch block.
9778
9779 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
9780
9781         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
9782         SWITCH_THRU_ALL_UIS.
9783
9784 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
9785
9786         PR tui/9765
9787         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
9788         comment, add extra parameter, and update to store previous symbol
9789         when appropriate.
9790         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
9791         add extra parameter.
9792         * tui/tui-disasm.c (tui_disassemble): Update header comment,
9793         remove unneeded parameter, add try/catch around gdb_print_insn,
9794         rewrite to add items to asm_lines vector.
9795         (tui_find_backward_disassembly_start_address): New function.
9796         (tui_find_disassembly_address): Updated throughout.
9797         (tui_disasm_window::set_contents): Update for changes to
9798         tui_disassemble.
9799         (tui_disasm_window::do_scroll_vertical): No need to adjust the
9800         number of lines to scroll.
9801
9802 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
9803
9804         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
9805         (SECT_OFF_DATA): Likewise.
9806         (SECT_OFF_RODATA): Likewise.
9807         (SECT_OFF_TEXT): Likewise.
9808         (SECT_OFF_BSS): Likewise.
9809         (struct objfile) <text_section_offset, data_section_offset>: New
9810         methods.
9811         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
9812         objfile::text_section_offset.
9813         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
9814         * coffread.c (coff_symtab_read): Likewise.
9815         (enter_linenos): Likewise.
9816         (process_coff_symbol): Likewise.
9817         * ctfread.c (get_objfile_text_range): Likewise.
9818         * dtrace-probe.c (dtrace_probe::get_relocated_address):
9819         Use objfile::data_section_offset.
9820         * dwarf2-frame.c (execute_cfa_program): Use
9821         objfile::text_section_offset.
9822         (dwarf2_frame_find_fde): Likewise.
9823         * dwarf2read.c (create_addrmap_from_index): Likewise.
9824         (create_addrmap_from_aranges): Likewise.
9825         (dw2_find_pc_sect_compunit_symtab): Likewise.
9826         (process_psymtab_comp_unit_reader): Likewise.
9827         (add_partial_symbol): Likewise.
9828         (add_partial_subprogram): Likewise.
9829         (process_full_comp_unit): Likewise.
9830         (read_file_scope): Likewise.
9831         (read_func_scope): Likewise.
9832         (read_lexical_block_scope): Likewise.
9833         (read_call_site_scope): Likewise.
9834         (dwarf2_rnglists_process): Likewise.
9835         (dwarf2_ranges_process): Likewise.
9836         (dwarf2_ranges_read): Likewise.
9837         (dwarf_decode_lines_1): Likewise.
9838         (new_symbol): Likewise.
9839         (dwarf2_fetch_die_loc_sect_off): Likewise.
9840         (dwarf2_per_cu_text_offset): Likewise.
9841         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
9842         * hppa-tdep.c (read_unwind_info): Likewise.
9843         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
9844         * psympriv.h (struct partial_symtab): Likewise.
9845         * psymtab.c (find_pc_sect_psymtab): Likewise.
9846         * solib-svr4.c (enable_break): Likewise.
9847         * stap-probe.c (relocate_address): Use
9848         objfile::data_section_offset.
9849         * xcoffread.c (enter_line_range): Use
9850         objfile::text_section_offset.
9851         (read_xcoff_symtab): Likewise.
9852
9853 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
9854
9855         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
9856         declaration to narrower scopes.
9857
9858 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
9859
9860         * darwin-nat.h (struct darwin_exception_msg, enum
9861         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
9862         Move up.
9863         (class darwin_nat_target) <wait_1, check_new_threads,
9864         decode_exception_message, decode_message, stop_inferior,
9865         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
9866         * darwin-nat.c (darwin_check_new_threads): Rename to...
9867         (darwin_nat_target::check_new_threads): ... this.
9868         (darwin_suspend_inferior_it): Remove.
9869         (darwin_decode_exception_message): Rename to...
9870         (darwin_nat_target::decode_exception_message): ... this.
9871         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
9872         (darwin_decode_message): Rename to...
9873         (darwin_nat_target::decode_message): ... this.
9874         (cancel_breakpoint): Rename to...
9875         (darwin_nat_target::cancel_breakpoint): ... this.
9876         (darwin_wait): Rename to...
9877         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
9878         instead of iterate_over_inferiors.
9879         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
9880         (darwin_stop_inferior): Rename to...
9881         (darwin_nat_target::stop_inferior): ... this.
9882         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
9883         (darwin_init_thread_list): Rename to...
9884         (darwin_nat_target::init_thread_list): ... this.
9885         (darwin_ptrace_him): Rename to...
9886         (darwin_nat_target::ptrace_him): ... this.
9887         (darwin_nat_target::create_inferior): Pass lambda function to
9888         fork_inferior.
9889         (darwin_nat_target::detach): Call stop_inferior instead of
9890         darwin_stop_inferior.
9891         * fork-inferior.h (fork_inferior): Change init_trace_fun
9892         parameter to gdb::function_view.
9893         * fork-inferior.c (fork_inferior): Likewise.
9894
9895 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
9896
9897         * i386-cygwin-tdep.c (core_process_module_section): Update.
9898         * windows-nat.c (struct lm_info_windows): Add text_offset.
9899         (windows_xfer_shared_libraries): Update.
9900         * windows-tdep.c (windows_xfer_shared_library):
9901         Add text_offset_cached argument.
9902         * windows-tdep.h (windows_xfer_shared_library): Update.
9903
9904 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
9905
9906         * gdbarch.sh: Add declaration for _initialize_gdbarch.
9907
9908 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
9909
9910         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
9911         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
9912         replace with range-based for.
9913         (gdbsim_interrupt_inferior): Remove.
9914         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
9915         with a range-based for.  Inline code from
9916         gdbsim_interrupt_inferior.
9917
9918 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
9919
9920         * infrun.c (proceed): Fix indentation.
9921
9922 2020-01-21  Tom Tromey  <tromey@adacore.com>
9923
9924         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
9925         * python/python.c (python_extension_ops): Update.
9926         (gdbpy_colorize): New function.
9927         * python/lib/gdb/__init__.py (colorize): New function.
9928         * extension.h (ext_lang_colorize): Declare.
9929         * extension.c (ext_lang_colorize): New function.
9930         * extension-priv.h (struct extension_language_ops) <colorize>: New
9931         member.
9932         * cli/cli-style.c (_initialize_cli_style): Update help text.
9933
9934 2020-01-21  Luis Machado  <luis.machado@linaro.org>
9935
9936         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
9937         <cond>: Change type to bool.
9938         (aarch64_displaced_step_b_cond): Update cond to use bool type.
9939         (aarch64_displaced_step_cb): Likewise.
9940         (aarch64_displaced_step_tb): Likewise.
9941
9942 2020-01-21  Luis Machado  <luis.machado@linaro.org>
9943
9944         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
9945         output.
9946
9947 2020-01-21  Luis Machado  <luis.machado@linaro.org>
9948
9949         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
9950         <pc_adjust>: Adjust the documentation.
9951         (aarch64_displaced_step_fixup): Check if PC really moved before
9952         adjusting it.
9953
9954 2020-01-19  Tom Tromey  <tom@tromey.com>
9955
9956         * disasm.c (~gdb_disassembler): New destructor.
9957         (gdb_buffered_insn_length): Call disassemble_free_target.
9958         * disasm.h (class gdb_disassembler): Declare destructor.  Use
9959         DISABLE_COPY_AND_ASSIGN.
9960
9961 2020-01-19  Tom Tromey  <tom@tromey.com>
9962
9963         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
9964         (die_reader_func_ftype): Remove.
9965         (cutu_reader): New class.
9966         (dw2_get_file_names_reader): Remove "data" parameter.
9967         (dw2_get_file_names): Use cutu_reader.
9968         (create_debug_type_hash_table): Update.
9969         (read_cutu_die_from_dwo): Update comment.
9970         (lookup_dwo_unit): Add dwo_name parameter.
9971         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
9972         die_reader_func_ftype and data parameters.
9973         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
9974         Remove die_reader_func_ftype and data parameters.
9975         (~cutu_reader): New; from init_cutu_and_read_dies.
9976         (cutu_reader::cutu_reader): Rename from
9977         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
9978         and data parameters.
9979         (init_cutu_and_read_dies_simple): Remove.
9980         (struct process_psymtab_comp_unit_data): Remove.
9981         (process_psymtab_comp_unit_reader): Remove data parameter; add
9982         want_partial_unit and pretend_language parameters.
9983         (process_psymtab_comp_unit): Use cutu_reader.
9984         (build_type_psymtabs_reader): Remove data parameter.
9985         (build_type_psymtabs_1): Use cutu_reader.
9986         (process_skeletonless_type_unit): Likewise.
9987         (load_partial_comp_unit_reader): Remove.
9988         (load_partial_comp_unit): Use cutu_reader.
9989         (load_full_comp_unit_reader): Remove.
9990         (load_full_comp_unit): Use cutu_reader.
9991         (struct create_dwo_cu_data): Remove.
9992         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
9993         dwo_unit parameters.
9994         (create_cus_hash_table): Use cutu_reader.
9995         (struct dwarf2_read_addr_index_data): Remove.
9996         (dwarf2_read_addr_index_reader): Remove.
9997         (dwarf2_read_addr_index): Use cutu_reader.
9998         (read_signatured_type_reader): Remove.
9999         (read_signatured_type): Use cutu_reader.
10000
10001 2020-01-19  Tom Tromey  <tom@tromey.com>
10002
10003         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
10004         * tui/tui-wingeneral.h (class tui_suppress_output): New.
10005         (tui_wrefresh): Declare.
10006         * tui/tui-wingeneral.c (suppress_output): New global.
10007         (tui_suppress_output, ~tui_suppress_output): New constructor and
10008         destructor.
10009         (tui_wrefresh): New function.
10010         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
10011         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
10012         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
10013         method.
10014         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
10015         tui_wrefresh.
10016         (tui_data_window::no_refresh): New method.
10017         (tui_data_item_window::refresh_window): Call tui_wrefresh.
10018         (tui_reg_command): Use tui_suppress_output
10019         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
10020         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
10021         method.
10022         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
10023
10024 2020-01-19  Tom Tromey  <tom@tromey.com>
10025
10026         * tui/tui-winsource.c (tui_update_source_windows_with_line):
10027         Handle case where symtab is null.
10028
10029 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
10030
10031         * linux-fork.c (one_fork_p): Simplify.
10032
10033 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
10034
10035         * top.c (struct qt_args): Remove.
10036         (kill_or_detach): Change return type to void, replace `void *`
10037         parameter with a proper one.
10038         (print_inferior_quit_action):  Likewise.
10039         (quit_confirm): Use range-based for loop to iterate over inferiors.
10040         (quit_force): Likewise.
10041
10042 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
10043
10044         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
10045         `void *` parameter with proper parameters.
10046         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
10047         (print_one_inferior): Change return type to void, replace `void *`
10048         parameter with proper parameters.
10049         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
10050         inferiors.
10051         (get_other_inferior): Remove.
10052         (mi_cmd_remove_inferior): Use range-based loop to iterate over
10053         inferiors.
10054
10055 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
10056
10057         * mi/mi-interp.c (report_initial_inferior): Remove.
10058         (mi_interp::init): Use range-based for to iterate over inferiors.
10059
10060 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
10061
10062         * python/py-inferior.c (build_inferior_list): Remove.
10063         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
10064
10065 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
10066
10067         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
10068         (btrace_stitch_trace): Likewise.
10069         * charset.c (intermediate_encoding): Likewise (vaild).
10070         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
10071         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
10072         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
10073
10074 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
10075
10076         * windows-tdep.c (windows_get_tlb_type):
10077         Add rtl_user_process_parameters type.
10078
10079 2020-01-16  Pedro Alves  <palves@redhat.com>
10080             Norbert Lange  <nolange79@gmail.com>
10081
10082         PR build/24805
10083         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
10084         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
10085         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
10086         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
10087         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
10088         (ps_plog): Redeclare exported functions with default visibility.
10089
10090 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
10091
10092         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
10093         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
10094
10095 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
10096
10097         * infcmd.c (post_create_inferior): Use get_thread_regcache
10098         instead of get_current_regcache.
10099
10100 2020-01-14  Tom Tromey  <tom@tromey.com>
10101
10102         PR symtab/12535:
10103         * python/python.c (gdbpy_decode_line): Treat empty string the same
10104         as no argument.
10105
10106 2020-01-14  Tom Tromey  <tom@tromey.com>
10107
10108         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
10109
10110 2020-01-14  Tom Tromey  <tom@tromey.com>
10111
10112         * nat/linux-btrace.c: Don't include <config.h>.
10113         * nat/linux-ptrace.c: Don't include <config.h>.
10114         * nat/x86-linux-dregs.c: Don't include <config.h>.
10115
10116 2020-01-14  Tom Tromey  <tom@tromey.com>
10117
10118         * configure: Rebuild.
10119         * configure.ac: Move many checks to ../gdbsupport/common.m4.
10120
10121 2020-01-14  Tom Tromey  <tom@tromey.com>
10122
10123         * nat/x86-linux-dregs.c: Include configh.h.
10124         * nat/linux-ptrace.c: Include configh.h.
10125         * nat/linux-btrace.c: Include configh.h.
10126         * defs.h: Include config.h, bfd.h.
10127         * configure.ac: Don't source common.host.
10128         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
10129         * configure: Rebuild.
10130         * acinclude.m4: Update path.
10131         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
10132         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
10133         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
10134         (CLIBS): Add LIBSUPPORT.
10135         (CDEPS): Likewise.
10136         (COMMON_SFILES): Remove gdbsupport files.
10137         (HFILES_NO_SRCDIR): Likewise.
10138         (stamp-version): Update path to create-version.sh.
10139         (ALLDEPFILES): Remove gdbsupport files.
10140
10141 2020-01-14  Tom Tromey  <tom@tromey.com>
10142
10143         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
10144         USE_WIN32API when needed.
10145         * configure.ac (USE_WIN32API): Don't define.
10146         (WIN32LIBS): Use WIN32APILIBS.
10147         * configure: Rebuild.
10148
10149 2020-01-14  Tom Tromey  <tom@tromey.com>
10150
10151         * configure: Rebuild.
10152         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
10153
10154 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
10155
10156         * skip.c (skip_function_command): Make skip w/o arguments use the
10157         name of the inlined function if pc is inside any inlined function.
10158
10159 2020-01-14  Luis Machado  <luis.machado@linaro.org>
10160
10161         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
10162         * infrun.c (resume_1): Likewise.
10163         (handle_inferior_event): Remove stale comment.
10164         * linux-nat.c (linux_nat_target::resume): Update comments.
10165         (save_stop_reason): Likewise.
10166         (linux_nat_filter_event): Likewise.
10167         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
10168
10169 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
10170
10171         * elfread.c (record_minimal_symbol): Set section index to 0 for
10172         non-allocatable sections.
10173
10174
10175 2020-01-13  Ali Tamur <tamur@google.com>
10176
10177         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
10178         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
10179         to gdb::optional.  Update comments.
10180         (dwo_file): Update comments.
10181         (read_attribute): Update API to take an additional out parameter,
10182         need_reprocess.  This is used to mark attributes that need other
10183         attributes (e.g. str_offsets_base) for correct computation which may not
10184         have been read yet.
10185         (read_attribute_reprocess): New function declaration.
10186         (read_addr_index): Likewise.
10187         (read_dwo_str_index): Likewise.
10188         (read_stub_str_index): Likewise.
10189         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
10190         (lookup_addr_base): New function definition.
10191         (lookup_ranges_base): Likewise.
10192         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
10193         lookup_ranges_base.
10194         (init_cutu_and_read_dies): Update comments.
10195         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
10196         unit.  This is used to inherit parent's str_offsets_base and addr_base.
10197         Update comments.
10198         (init_cutu_and_read_dies_simple): Reflect API changes.
10199         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
10200         (create_cus_hash_table): Change API to take parent compile unit.
10201         Reflect API changes.
10202         (open_and_init_dwo_file): Reflect API changes.
10203         (dwarf2_get_pc_bounds): Update comments.
10204         (dwarf2_record_block_ranges): Likewise.
10205         (read_full_die_1): Change implementation to reprocess attributes that
10206         need str_offsets_base and addr_base.
10207         (partial_die_info::read): Likewise.
10208         (read_attribute_reprocess): New function definition.
10209         (read_attribute_value): Change API to take an additional out parameter,
10210         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
10211         when a non-dwo compile unit has index based attributes.
10212         (read_attribute): Reflect API changes.
10213         (read_addr_index_1): Reflect API changes.  Update comments.
10214         (dwarf2_read_addr_index_data): Reflect API changes.
10215         (dwarf2_read_addr_index): Likewise.
10216         (read_str_index): Change API and implementation.  This becomes a helper
10217         to be used by the new string index related methods.  Update error
10218         message and comments.
10219         (read_dwo_str_index): New function definition.
10220         (read_stub_str_index): Likewise.
10221         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
10222         * symfile.h (dwarf2_debug_sections): Likewise.
10223         * xcoffread.c (dwarf2_debug_sections): Likewise.
10224
10225 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
10226
10227         * gdbcore.h (struct core_fns) <core_read_registers>: Change
10228         core_reg_sect type to gdb_byte *.
10229         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
10230         * cris-tdep.c (fetch_core_registers): Likewise.
10231         * corelow.c (core_target::get_core_register_section): Change
10232         type of `contents` to gdb::byte_vector.
10233
10234 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
10235
10236         * tui/tui-wingeneral.c (box_win): Position the title in the center
10237         of the border.
10238
10239 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
10240
10241         * corelow.c (core_target::get_core_register_section): Use
10242           std::vector instead of alloca.
10243
10244 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
10245
10246         * warning.m4: Add -Wmissing-declarations to build_warnings.
10247         * configure: Re-generate.
10248
10249 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
10250
10251         * python/python.c (init__gdb_module): Add declaration.
10252
10253 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
10254
10255         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
10256         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
10257         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
10258         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
10259         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
10260         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
10261         * ada-exp.y (_initialize_ada_exp): Add declaration.
10262         * ada-lang.c (_initialize_ada_language): Add declaration.
10263         * ada-tasks.c (_initialize_tasks): Add declaration.
10264         * agent.c (_initialize_agent): Add declaration.
10265         * aix-thread.c (_initialize_aix_thread): Add declaration.
10266         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
10267         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
10268         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
10269         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
10270         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
10271         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
10272         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
10273         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
10274         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
10275         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
10276         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
10277         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
10278         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
10279         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
10280         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
10281         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
10282         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
10283         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
10284         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
10285         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
10286         * annotate.c (_initialize_annotate): Add declaration.
10287         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
10288         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
10289         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
10290         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
10291         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
10292         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
10293         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
10294         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
10295         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
10296         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
10297         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
10298         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
10299         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
10300         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
10301         * auto-load.c (_initialize_auto_load): Add declaration.
10302         * auxv.c (_initialize_auxv): Add declaration.
10303         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
10304         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
10305         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
10306         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
10307         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
10308         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
10309         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
10310         * breakpoint.c (_initialize_breakpoint): Add declaration.
10311         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
10312         * btrace.c (_initialize_btrace): Add declaration.
10313         * charset.c (_initialize_charset): Add declaration.
10314         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
10315         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
10316         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
10317         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
10318         * cli/cli-script.c (_initialize_cli_script): Add declaration.
10319         * cli/cli-style.c (_initialize_cli_style): Add declaration.
10320         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
10321         * coffread.c (_initialize_coffread): Add declaration.
10322         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
10323         * compile/compile.c (_initialize_compile): Add declaration.
10324         * complaints.c (_initialize_complaints): Add declaration.
10325         * completer.c (_initialize_completer): Add declaration.
10326         * copying.c (_initialize_copying): Add declaration.
10327         * corefile.c (_initialize_core): Add declaration.
10328         * corelow.c (_initialize_corelow): Add declaration.
10329         * cp-abi.c (_initialize_cp_abi): Add declaration.
10330         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
10331         * cp-support.c (_initialize_cp_support): Add declaration.
10332         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
10333         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
10334         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
10335         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
10336         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
10337         * ctfread.c (_initialize_ctfread): Add declaration.
10338         * d-lang.c (_initialize_d_language): Add declaration.
10339         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
10340         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
10341         * dbxread.c (_initialize_dbxread): Add declaration.
10342         * dcache.c (_initialize_dcache): Add declaration.
10343         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
10344         * disasm.c (_initialize_disasm): Add declaration.
10345         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
10346         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
10347         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
10348         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
10349         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
10350         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
10351         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
10352         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
10353         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
10354         * elfread.c (_initialize_elfread): Add declaration.
10355         * exec.c (_initialize_exec): Add declaration.
10356         * extension.c (_initialize_extension): Add declaration.
10357         * f-lang.c (_initialize_f_language): Add declaration.
10358         * f-valprint.c (_initialize_f_valprint): Add declaration.
10359         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
10360         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
10361         * filesystem.c (_initialize_filesystem): Add declaration.
10362         * findcmd.c (_initialize_mem_search): Add declaration.
10363         * findvar.c (_initialize_findvar): Add declaration.
10364         * fork-child.c (_initialize_fork_child): Add declaration.
10365         * frame-base.c (_initialize_frame_base): Add declaration.
10366         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
10367         * frame.c (_initialize_frame): Add declaration.
10368         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
10369         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
10370         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
10371         * gcore.c (_initialize_gcore): Add declaration.
10372         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
10373         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
10374         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
10375         * gdbarch.c (_initialize_gdbarch): Add declaration.
10376         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
10377         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
10378         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
10379         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
10380         * go-lang.c (_initialize_go_language): Add declaration.
10381         * go32-nat.c (_initialize_go32_nat): Add declaration.
10382         * guile/guile.c (_initialize_guile): Add declaration.
10383         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
10384         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
10385         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
10386         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
10387         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
10388         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
10389         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
10390         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
10391         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
10392         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
10393         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
10394         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
10395         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
10396         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
10397         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
10398         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
10399         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
10400         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
10401         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
10402         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
10403         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
10404         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
10405         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
10406         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
10407         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
10408         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
10409         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
10410         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
10411         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
10412         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
10413         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
10414         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
10415         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
10416         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
10417         * infcall.c (_initialize_infcall): Add declaration.
10418         * infcmd.c (_initialize_infcmd): Add declaration.
10419         * inflow.c (_initialize_inflow): Add declaration.
10420         * infrun.c (_initialize_infrun): Add declaration.
10421         * interps.c (_initialize_interpreter): Add declaration.
10422         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
10423         * jit.c (_initialize_jit): Add declaration.
10424         * language.c (_initialize_language): Add declaration.
10425         * linux-fork.c (_initialize_linux_fork): Add declaration.
10426         * linux-nat.c (_initialize_linux_nat): Add declaration.
10427         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
10428         * linux-thread-db.c (_initialize_thread_db): Add declaration.
10429         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
10430         * m2-lang.c (_initialize_m2_language): Add declaration.
10431         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
10432         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
10433         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
10434         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
10435         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
10436         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
10437         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
10438         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
10439         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
10440         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
10441         * machoread.c (_initialize_machoread): Add declaration.
10442         * macrocmd.c (_initialize_macrocmd): Add declaration.
10443         * macroscope.c (_initialize_macroscope): Add declaration.
10444         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
10445         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
10446         * maint.c (_initialize_maint_cmds): Add declaration.
10447         * mdebugread.c (_initialize_mdebugread): Add declaration.
10448         * memattr.c (_initialize_mem): Add declaration.
10449         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
10450         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
10451         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
10452         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
10453         * mi/mi-main.c (_initialize_mi_main): Add declaration.
10454         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
10455         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
10456         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
10457         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
10458         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
10459         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
10460         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
10461         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
10462         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
10463         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
10464         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
10465         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
10466         * mipsread.c (_initialize_mipsread): Add declaration.
10467         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
10468         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
10469         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
10470         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
10471         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
10472         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
10473         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
10474         * nto-procfs.c (_initialize_procfs): Add declaration.
10475         * objc-lang.c (_initialize_objc_language): Add declaration.
10476         * observable.c (_initialize_observer): Add declaration.
10477         * opencl-lang.c (_initialize_opencl_language): Add declaration.
10478         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
10479         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
10480         * osabi.c (_initialize_gdb_osabi): Add declaration.
10481         * osdata.c (_initialize_osdata): Add declaration.
10482         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
10483         * parse.c (_initialize_parse): Add declaration.
10484         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
10485         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
10486         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
10487         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
10488         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
10489         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
10490         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
10491         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
10492         * printcmd.c (_initialize_printcmd): Add declaration.
10493         * probe.c (_initialize_probe): Add declaration.
10494         * proc-api.c (_initialize_proc_api): Add declaration.
10495         * proc-events.c (_initialize_proc_events): Add declaration.
10496         * proc-service.c (_initialize_proc_service): Add declaration.
10497         * procfs.c (_initialize_procfs): Add declaration.
10498         * producer.c (_initialize_producer): Add declaration.
10499         * psymtab.c (_initialize_psymtab): Add declaration.
10500         * python/python.c (_initialize_python): Add declaration.
10501         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
10502         * record-btrace.c (_initialize_record_btrace): Add declaration.
10503         * record-full.c (_initialize_record_full): Add declaration.
10504         * record.c (_initialize_record): Add declaration.
10505         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
10506         * regcache.c (_initialize_regcache): Add declaration.
10507         * reggroups.c (_initialize_reggroup): Add declaration.
10508         * remote-notif.c (_initialize_notif): Add declaration.
10509         * remote-sim.c (_initialize_remote_sim): Add declaration.
10510         * remote.c (_initialize_remote): Add declaration.
10511         * reverse.c (_initialize_reverse): Add declaration.
10512         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
10513         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
10514         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
10515         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
10516         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
10517         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
10518         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
10519         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
10520         Add declaration.
10521         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
10522         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
10523         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
10524         * rust-exp.y (_initialize_rust_exp): Add declaration.
10525         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
10526         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
10527         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
10528         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
10529         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
10530         * score-tdep.c (_initialize_score_tdep): Add declaration.
10531         * ser-go32.c (_initialize_ser_dos): Add declaration.
10532         * ser-mingw.c (_initialize_ser_windows): Add declaration.
10533         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
10534         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
10535         * ser-uds.c (_initialize_ser_socket): Add declaration.
10536         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
10537         * serial.c (_initialize_serial): Add declaration.
10538         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
10539         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
10540         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
10541         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
10542         * skip.c (_initialize_step_skip): Add declaration.
10543         * sol-thread.c (_initialize_sol_thread): Add declaration.
10544         * solib-aix.c (_initialize_solib_aix): Add declaration.
10545         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
10546         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
10547         * solib-frv.c (_initialize_frv_solib): Add declaration.
10548         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
10549         * solib-target.c (_initialize_solib_target): Add declaration.
10550         * solib.c (_initialize_solib): Add declaration.
10551         * source-cache.c (_initialize_source_cache): Add declaration.
10552         * source.c (_initialize_source): Add declaration.
10553         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
10554         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
10555         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
10556         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
10557         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
10558         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
10559         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
10560         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
10561         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
10562         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
10563         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
10564         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
10565         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
10566         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
10567         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
10568         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
10569         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
10570         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
10571         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
10572         * stabsread.c (_initialize_stabsread): Add declaration.
10573         * stack.c (_initialize_stack): Add declaration.
10574         * stap-probe.c (_initialize_stap_probe): Add declaration.
10575         * std-regs.c (_initialize_frame_reg): Add declaration.
10576         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
10577         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
10578         * symfile.c (_initialize_symfile): Add declaration.
10579         * symmisc.c (_initialize_symmisc): Add declaration.
10580         * symtab.c (_initialize_symtab): Add declaration.
10581         * target.c (_initialize_target): Add declaration.
10582         * target-connection.c (_initialize_target_connection): Add
10583         declaration.
10584         * target-dcache.c (_initialize_target_dcache): Add declaration.
10585         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
10586         * thread.c (_initialize_thread): Add declaration.
10587         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
10588         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
10589         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
10590         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
10591         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
10592         * tracectf.c (_initialize_ctf): Add declaration.
10593         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
10594         * tracefile.c (_initialize_tracefile): Add declaration.
10595         * tracepoint.c (_initialize_tracepoint): Add declaration.
10596         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
10597         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
10598         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
10599         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
10600         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
10601         * tui/tui-win.c (_initialize_tui_win): Add declaration.
10602         * tui/tui.c (_initialize_tui): Add declaration.
10603         * typeprint.c (_initialize_typeprint): Add declaration.
10604         * ui-style.c (_initialize_ui_style): Add declaration.
10605         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
10606         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
10607         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
10608         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
10609         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
10610         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
10611         * unittests/filtered_iterator-selftests.c
10612         (_initialize_filtered_iterator_selftests): Add declaration.
10613         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
10614         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
10615         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
10616         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
10617         * unittests/main-thread-selftests.c
10618         (_initialize_main_thread_selftests): Add declaration.
10619         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
10620         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
10621         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
10622         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
10623         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
10624         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
10625         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
10626         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
10627         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
10628         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
10629         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
10630         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
10631         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
10632         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
10633         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
10634         declaration.
10635         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
10636         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
10637         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
10638         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
10639         * user-regs.c (_initialize_user_regs): Add declaration.
10640         * utils.c (_initialize_utils): Add declaration.
10641         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
10642         * valops.c (_initialize_valops): Add declaration.
10643         * valprint.c (_initialize_valprint): Add declaration.
10644         * value.c (_initialize_values): Add declaration.
10645         * varobj.c (_initialize_varobj): Add declaration.
10646         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
10647         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
10648         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
10649         * windows-nat.c (_initialize_windows_nat): Add declaration.
10650         (_initialize_check_for_gdb_ini): Add declaration.
10651         (_initialize_loadable): Add declaration.
10652         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
10653         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
10654         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
10655         * xcoffread.c (_initialize_xcoffread): Add declaration.
10656         * xml-support.c (_initialize_xml_support): Add declaration.
10657         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
10658         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
10659         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
10660         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
10661
10662 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
10663
10664         * regformats/regdat.sh: Generate declaration for init function.
10665
10666 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
10667
10668         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
10669         up.
10670         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
10671         close_one_inferior>: New methods.
10672         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
10673         pass down target to find_inferior_pid.
10674         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
10675         Pass down target to find_inferior_ptid.
10676         (gdbsim_target::create_inferior): Pass down target to
10677         add_thread_silent.
10678         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
10679         target down to find_inferior_ptid and switch_to_thread.
10680         (gdbsim_target::close): Update to call close_one_inferior.
10681         (struct resume_data): Remove.
10682         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
10683         directly, rather than through a void pointer.
10684         (gdbsim_target::resume): Update to call resume_one_inferior.
10685
10686 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
10687
10688         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
10689
10690 2020-01-12  Pedro Alves  <palves@redhat.com>
10691
10692         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
10693         directly for the current inferior instead of
10694         discard_all_inferiors.
10695         (discard_all_inferiors): Delete.
10696
10697 2020-01-11  Tom Tromey  <tom@tromey.com>
10698
10699         * tui/tui-wingeneral.c (box_win): Check cli_styling.
10700         * tui/tui-winsource.c (tui_source_window_base::refill): Use
10701         deprecated_safe_get_selected_frame.
10702
10703 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
10704
10705         * inferior.c (print_inferior): Switch inferior before printing it.
10706
10707 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
10708             Pedro Alves  <palves@redhat.com>
10709
10710         * progspace-and-thread.c (switch_to_program_space_and_thread):
10711         Assert there's an inferior for PSPACE.  Use
10712         switch_to_inferior_no_thread to switch the inferior too.
10713         * progspace.c (program_space::~program_space): Call
10714         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
10715         (program_space::free_all_objfiles): Don't call clear_symtab_users
10716         here.
10717         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
10718
10719 2020-01-10  Pedro Alves  <palves@redhat.com>
10720
10721         * NEWS: Mention multi-target debugging, "info connections", and
10722         "add-inferior -no-connection".
10723
10724 2020-01-10  Pedro Alves  <palves@redhat.com>
10725
10726         * infrun.c: Include "target-connection.h".
10727         (check_multi_target_resumption): New.
10728         (proceed): Call it.
10729         * target-connection.c (make_target_connection_string): Make
10730         extern.
10731         * target-connection.h (make_target_connection_string): Declare.
10732
10733 2020-01-10  Pedro Alves  <palves@redhat.com>
10734
10735         * Makefile.in (COMMON_SFILES): Add target-connection.c.
10736         * inferior.c (uiout_field_connection): New function.
10737         (print_inferior): Add new "connection-id" column.
10738         (add_inferior_command): Show connection number/string of added
10739         inferior.
10740         * process-stratum-target.h
10741         (process_stratum_target::connection_string): New virtual method.
10742         (process_stratum_target::connection_number): New field.
10743         * remote.c (remote_target::connection_string): New override.
10744         * target-connection.c: New file.
10745         * target-connection.h: New file.
10746         * target.c (decref_target): Remove process_stratum targets from
10747         the connection list.
10748         (target_stack::push): Add process_stratum targets to the
10749         connection list.
10750
10751 2020-01-10  Pedro Alves  <palves@redhat.com>
10752
10753         Revert:
10754         2016-04-12  Pedro Alves  <palves@redhat.com>
10755         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
10756         Remove references to name.
10757         * serial.h (struct serial) <name>: Delete.
10758
10759 2020-01-10  Pedro Alves  <palves@redhat.com>
10760
10761         * gdbarch-selftests.c (register_to_value_test): Remove "target
10762         already pushed" check.
10763
10764 2020-01-10  Pedro Alves  <palves@redhat.com>
10765             John Baldwin  <jhb@FreeBSD.org>
10766
10767         * aarch64-linux-nat.c
10768         (aarch64_linux_nat_target::thread_architecture): Adjust.
10769         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
10770         (task_command_1): Likewise.
10771         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
10772         (aix_thread_target::wait, aix_thread_target::fetch_registers)
10773         (aix_thread_target::store_registers)
10774         (aix_thread_target::thread_alive): Adjust.
10775         * amd64-fbsd-tdep.c: Include "inferior.h".
10776         (amd64fbsd_get_thread_local_address): Pass down target.
10777         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
10778         thread's gdbarch instead of target_gdbarch.
10779         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
10780         get_last_target_status.
10781         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
10782         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
10783         inferiors.
10784         (update_inserted_breakpoint_locations): Skip if inferiors with no
10785         execution.
10786         (update_global_location_list): When handling moribund locations,
10787         find representative inferior for location's pspace, and use thread
10788         count of its process_stratum target.
10789         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
10790         * bsd-uthread.c (bsd_uthread_target::wait): Use
10791         as_process_stratum_target and adjust thread_change_ptid and
10792         add_thread calls.
10793         (bsd_uthread_target::update_thread_list): Use
10794         as_process_stratum_target and adjust find_thread_ptid,
10795         thread_change_ptid and add_thread calls.
10796         * btrace.c (maint_btrace_packet_history_cmd): Adjust
10797         find_thread_ptid call.
10798         * corelow.c (add_to_thread_list): Adjust add_thread call.
10799         (core_target_open): Adjust add_thread_silent and thread_count
10800         calls.
10801         (core_target::pid_to_str): Adjust find_inferior_ptid call.
10802         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
10803         * event-top.c (async_disconnect): Pop targets from all inferiors.
10804         * exec.c (add_target_sections): Push exec target on all inferiors
10805         sharing the program space.
10806         (remove_target_sections): Remove the exec target from all
10807         inferiors sharing the program space.
10808         (exec_on_vfork): New.
10809         * exec.h (exec_on_vfork): Declare.
10810         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
10811         Pass it down.
10812         (fbsd_nat_target::update_thread_list): Adjust.
10813         (fbsd_nat_target::resume): Adjust.
10814         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
10815         down.
10816         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
10817         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
10818         get_thread_arch_regcache call.
10819         * fork-child.c (gdb_startup_inferior): Pass target down to
10820         startup_inferior and set_executing.
10821         * gdbthread.h (struct process_stratum_target): Forward declare.
10822         (add_thread, add_thread_silent, add_thread_with_info)
10823         (in_thread_list): Add process_stratum_target parameter.
10824         (find_thread_ptid(inferior*, ptid_t)): New overload.
10825         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
10826         parameter.
10827         (all_threads()): Delete overload.
10828         (all_threads, all_non_exited_threads): Add process_stratum_target
10829         parameter.
10830         (all_threads_safe): Use brace initialization.
10831         (thread_count): Add process_stratum_target parameter.
10832         (set_resumed, set_running, set_stop_requested, set_executing)
10833         (threads_are_executing, finish_thread_state): Add
10834         process_stratum_target parameter.
10835         (switch_to_thread): Use is_current_thread.
10836         * i386-fbsd-tdep.c: Include "inferior.h".
10837         (i386fbsd_get_thread_local_address): Pass down target.
10838         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
10839         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
10840         have_inferiors check.
10841         * inf-ptrace.c (inf_ptrace_target::create_inferior)
10842         (inf_ptrace_target::attach): Adjust.
10843         * infcall.c (run_inferior_call): Adjust.
10844         * infcmd.c (run_command_1): Pass target to
10845         scoped_finish_thread_state.
10846         (proceed_thread_callback): Skip inferiors with no execution.
10847         (continue_command): Rename 'all_threads' local to avoid hiding
10848         'all_threads' function.  Adjust get_last_target_status call.
10849         (prepare_one_step): Adjust set_running call.
10850         (signal_command): Use user_visible_resume_target.  Compare thread
10851         pointers instead of inferior_ptid.
10852         (info_program_command): Adjust to pass down target.
10853         (attach_command): Mark target's 'thread_executing' flag.
10854         (stop_current_target_threads_ns): New, factored out from ...
10855         (interrupt_target_1): ... this.  Switch inferior before making
10856         target calls.
10857         * inferior-iter.h
10858         (struct all_inferiors_iterator, struct all_inferiors_range)
10859         (struct all_inferiors_safe_range)
10860         (struct all_non_exited_inferiors_range): Filter on
10861         process_stratum_target too.  Remove explicit.
10862         * inferior.c (inferior::inferior): Push dummy target on target
10863         stack.
10864         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
10865         Add process_stratum_target parameter, and pass it down.
10866         (have_live_inferiors): Adjust.
10867         (switch_to_inferior_and_push_target): New.
10868         (add_inferior_command, clone_inferior_command): Handle
10869         "-no-connection" parameter.  Use
10870         switch_to_inferior_and_push_target.
10871         (_initialize_inferior): Mention "-no-connection" option in
10872         the help of "add-inferior" and "clone-inferior" commands.
10873         * inferior.h: Include "process-stratum-target.h".
10874         (interrupt_target_1): Use bool.
10875         (struct inferior) <push_target, unpush_target, target_is_pushed,
10876         find_target_beneath, top_target, process_target, target_at,
10877         m_stack>: New.
10878         (discard_all_inferiors): Delete.
10879         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
10880         (all_inferiors, all_non_exited_inferiors): Add
10881         process_stratum_target parameter.
10882         * infrun.c: Include "gdb_select.h" and <unordered_map>.
10883         (target_last_proc_target): New global.
10884         (follow_fork_inferior): Push target on new inferior.  Pass target
10885         to add_thread_silent.  Call exec_on_vfork.  Handle target's
10886         reference count.
10887         (follow_fork): Adjust get_last_target_status call.  Also consider
10888         target.
10889         (follow_exec): Push target on new inferior.
10890         (struct execution_control_state) <target>: New field.
10891         (user_visible_resume_target): New.
10892         (do_target_resume): Call target_async.
10893         (resume_1): Set target's threads_executing flag.  Consider resume
10894         target.
10895         (commit_resume_all_targets): New.
10896         (proceed): Also consider resume target.  Skip threads of inferiors
10897         with no execution.  Commit resumtion in all targets.
10898         (start_remote): Pass current inferior to wait_for_inferior.
10899         (infrun_thread_stop_requested): Consider target as well.  Pass
10900         thread_info pointer to clear_inline_frame_state instead of ptid.
10901         (infrun_thread_thread_exit): Consider target as well.
10902         (random_pending_event_thread): New inferior parameter.  Use it.
10903         (do_target_wait): Rename to ...
10904         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
10905         down.
10906         (threads_are_resumed_pending_p, do_target_wait): New.
10907         (prepare_for_detach): Adjust calls.
10908         (wait_for_inferior): New inferior parameter.  Handle it.  Use
10909         do_target_wait_1 instead of do_target_wait.
10910         (fetch_inferior_event): Adjust.  Switch to representative
10911         inferior.  Pass target down.
10912         (set_last_target_status): Add process_stratum_target parameter.
10913         Save target in global.
10914         (get_last_target_status): Add process_stratum_target parameter and
10915         handle it.
10916         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
10917         (context_switch): Check inferior_ptid == null_ptid before calling
10918         inferior_thread().
10919         (get_inferior_stop_soon): Pass down target.
10920         (wait_one): Rename to ...
10921         (poll_one_curr_target): ... this.
10922         (struct wait_one_event): New.
10923         (wait_one): New.
10924         (stop_all_threads): Adjust.
10925         (handle_no_resumed, handle_inferior_event): Adjust to consider the
10926         event's target.
10927         (switch_back_to_stepped_thread): Also consider target.
10928         (print_stop_event): Update.
10929         (normal_stop): Update.  Also consider the resume target.
10930         * infrun.h (wait_for_inferior): Remove declaration.
10931         (user_visible_resume_target): New declaration.
10932         (get_last_target_status, set_last_target_status): New
10933         process_stratum_target parameter.
10934         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
10935         process_stratum_target parameter, and use it.
10936         (clear_inline_frame_state (thread_info*)): New.
10937         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
10938         process_stratum_target parameter.
10939         (clear_inline_frame_state (thread_info*)): Declare.
10940         * linux-fork.c (delete_checkpoint_command): Pass target down to
10941         find_thread_ptid.
10942         (checkpoint_command): Adjust.
10943         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
10944         instead of just tweaking inferior_ptid.
10945         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
10946         (exit_lwp): Pass target down to find_thread_ptid.
10947         (attach_proc_task_lwp_callback): Pass target down to
10948         add_thread/set_running/set_executing.
10949         (linux_nat_target::attach): Pass target down to
10950         thread_change_ptid.
10951         (get_detach_signal): Pass target down to find_thread_ptid.
10952         Consider last target status's target.
10953         (linux_resume_one_lwp_throw, resume_lwp)
10954         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
10955         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
10956         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
10957         (linux_nat_target::async_wait_fd): New.
10958         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
10959         target down.
10960         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
10961         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
10962         * linux-thread-db.c (struct thread_db_info::process_target): New
10963         field.
10964         (add_thread_db_info): Save target.
10965         (get_thread_db_info): New process_stratum_target parameter.  Also
10966         match target.
10967         (delete_thread_db_info): New process_stratum_target parameter.
10968         Also match target.
10969         (thread_from_lwp): Adjust to pass down target.
10970         (thread_db_notice_clone): Pass down target.
10971         (check_thread_db_callback): Pass down target.
10972         (try_thread_db_load_1): Always push the thread_db target.
10973         (try_thread_db_load, record_thread): Pass target down.
10974         (thread_db_target::detach): Pass target down.  Always unpush the
10975         thread_db target.
10976         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
10977         target down.  Always unpush the thread_db target.
10978         (find_new_threads_callback, thread_db_find_new_threads_2)
10979         (thread_db_target::update_thread_list): Pass target down.
10980         (thread_db_target::pid_to_str): Pass current inferior down.
10981         (thread_db_target::get_thread_local_address): Pass target down.
10982         (thread_db_target::resume, maintenance_check_libthread_db): Pass
10983         target down.
10984         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
10985         * procfs.c (procfs_target::procfs_init_inferior): Declare.
10986         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
10987         (procfs_init_inferior): Rename to ...
10988         (procfs_target::procfs_init_inferior): ... this and adjust.
10989         (procfs_target::create_inferior, procfs_notice_thread)
10990         (procfs_do_thread_registers): Adjust.
10991         * ppc-fbsd-tdep.c: Include "inferior.h".
10992         (ppcfbsd_get_thread_local_address): Pass down target.
10993         * proc-service.c (ps_xfer_memory): Switch current inferior and
10994         program space as well.
10995         (get_ps_regcache): Pass target down.
10996         * process-stratum-target.c
10997         (process_stratum_target::thread_address_space)
10998         (process_stratum_target::thread_architecture): Pass target down.
10999         * process-stratum-target.h
11000         (process_stratum_target::threads_executing): New field.
11001         (as_process_stratum_target): New.
11002         * ravenscar-thread.c
11003         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
11004         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
11005         down.
11006         * record-btrace.c (record_btrace_target::info_record): Adjust.
11007         (record_btrace_target::record_method)
11008         (record_btrace_target::record_is_replaying)
11009         (record_btrace_target::fetch_registers)
11010         (get_thread_current_frame_id, record_btrace_target::resume)
11011         (record_btrace_target::wait, record_btrace_target::stop): Pass
11012         target down.
11013         * record-full.c (record_full_wait_1): Switch to event thread.
11014         Pass target down.
11015         * regcache.c (regcache::regcache)
11016         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
11017         process_stratum_target parameter and handle it.
11018         (current_thread_target): New global.
11019         (get_thread_regcache): Add process_stratum_target parameter and
11020         handle it.  Switch inferior before calling target method.
11021         (get_thread_regcache): Pass target down.
11022         (get_thread_regcache_for_ptid): Pass target down.
11023         (registers_changed_ptid): Add process_stratum_target parameter and
11024         handle it.
11025         (registers_changed_thread, registers_changed): Pass target down.
11026         (test_get_thread_arch_aspace_regcache): New.
11027         (current_regcache_test): Define a couple local test_target_ops
11028         instances and use them for testing.
11029         (readwrite_regcache): Pass process_stratum_target parameter.
11030         (cooked_read_test, cooked_write_test): Pass mock_target down.
11031         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
11032         (get_thread_arch_aspace_regcache): Add process_stratum_target
11033         parameter.
11034         (regcache::target): New method.
11035         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
11036         (regcache::registers_changed_ptid): Add process_stratum_target
11037         parameter.
11038         (regcache::m_target): New field.
11039         (registers_changed_ptid): Add process_stratum_target parameter.
11040         * remote.c (remote_state::supports_vCont_probed): New field.
11041         (remote_target::async_wait_fd): New method.
11042         (remote_unpush_and_throw): Add remote_target parameter.
11043         (get_current_remote_target): Adjust.
11044         (remote_target::remote_add_inferior): Push target.
11045         (remote_target::remote_add_thread)
11046         (remote_target::remote_notice_new_inferior)
11047         (get_remote_thread_info): Pass target down.
11048         (remote_target::update_thread_list): Skip threads of inferiors
11049         bound to other targets.  (remote_target::close): Don't discard
11050         inferiors.  (remote_target::add_current_inferior_and_thread)
11051         (remote_target::process_initial_stop_replies)
11052         (remote_target::start_remote)
11053         (remote_target::remote_serial_quit_handler): Pass down target.
11054         (remote_target::remote_unpush_target): New remote_target
11055         parameter.  Unpush the target from all inferiors.
11056         (remote_target::remote_unpush_and_throw): New remote_target
11057         parameter.  Pass it down.
11058         (remote_target::open_1): Check whether the current inferior has
11059         execution instead of checking whether any inferior is live.  Pass
11060         target down.
11061         (remote_target::remote_detach_1): Pass down target.  Use
11062         remote_unpush_target.
11063         (extended_remote_target::attach): Pass down target.
11064         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
11065         (remote_target::append_resumption): Pass down target.
11066         (remote_target::append_pending_thread_resumptions)
11067         (remote_target::remote_resume_with_hc, remote_target::resume)
11068         (remote_target::commit_resume): Pass down target.
11069         (remote_target::remote_stop_ns): Check supports_vCont_probed.
11070         (remote_target::interrupt_query)
11071         (remote_target::remove_new_fork_children)
11072         (remote_target::check_pending_events_prevent_wildcard_vcont)
11073         (remote_target::remote_parse_stop_reply)
11074         (remote_target::process_stop_reply): Pass down target.
11075         (first_remote_resumed_thread): New remote_target parameter.  Pass
11076         it down.
11077         (remote_target::wait_as): Pass down target.
11078         (unpush_and_perror): New remote_target parameter.  Pass it down.
11079         (remote_target::readchar, remote_target::remote_serial_write)
11080         (remote_target::getpkt_or_notif_sane_1)
11081         (remote_target::kill_new_fork_children, remote_target::kill): Pass
11082         down target.
11083         (remote_target::mourn_inferior): Pass down target.  Use
11084         remote_unpush_target.
11085         (remote_target::core_of_thread)
11086         (remote_target::remote_btrace_maybe_reopen): Pass down target.
11087         (remote_target::pid_to_exec_file)
11088         (remote_target::thread_handle_to_thread_info): Pass down target.
11089         (remote_target::async_wait_fd): New.
11090         * riscv-fbsd-tdep.c: Include "inferior.h".
11091         (riscv_fbsd_get_thread_local_address): Pass down target.
11092         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
11093         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
11094         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
11095         Adjust.
11096         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
11097         * solib-svr4.c (enable_break): Pass down target.
11098         * spu-multiarch.c (parse_spufs_run): Pass down target.
11099         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
11100         * target-delegates.c: Regenerate.
11101         * target.c (g_target_stack): Delete.
11102         (current_top_target): Return the current inferior's top target.
11103         (target_has_execution_1): Refer to the passed-in inferior's top
11104         target.
11105         (target_supports_terminal_ours): Check whether the initial
11106         inferior was already created.
11107         (decref_target): New.
11108         (target_stack::push): Incref/decref the target.
11109         (push_target, push_target, unpush_target): Adjust.
11110         (target_stack::unpush): Defref target.
11111         (target_is_pushed): Return bool.  Adjust to refer to the current
11112         inferior's target stack.
11113         (dispose_inferior): Delete, and inline parts ...
11114         (target_preopen): ... here.  Only dispose of the current inferior.
11115         (target_detach): Hold strong target reference while detaching.
11116         Pass target down.
11117         (target_thread_name): Add assertion.
11118         (target_resume): Pass down target.
11119         (target_ops::beneath, find_target_at): Adjust to refer to the
11120         current inferior's target stack.
11121         (get_dummy_target): New.
11122         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
11123         has a thread running.
11124         (initialize_targets): Rename to ...
11125         (_initialize_target): ... this.
11126         * target.h: Include "gdbsupport/refcounted-object.h".
11127         (struct target_ops): Inherit refcounted_object.
11128         (target_ops::shortname, target_ops::longname): Make const.
11129         (target_ops::async_wait_fd): New method.
11130         (decref_target): Declare.
11131         (struct target_ops_ref_policy): New.
11132         (target_ops_ref): New typedef.
11133         (get_dummy_target): Declare function.
11134         (target_is_pushed): Return bool.
11135         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
11136         (all_matching_threads_iterator::all_matching_threads_iterator):
11137         Handle filter target.
11138         * thread-iter.h (struct all_matching_threads_iterator, struct
11139         all_matching_threads_range, class all_non_exited_threads_range):
11140         Filter by target too.  Remove explicit.
11141         * thread.c (threads_executing): Delete.
11142         (inferior_thread): Pass down current inferior.
11143         (clear_thread_inferior_resources): Pass down thread pointer
11144         instead of ptid_t.
11145         (add_thread_silent, add_thread_with_info, add_thread): Add
11146         process_stratum_target parameter.  Use it for thread and inferior
11147         searches.
11148         (is_current_thread): New.
11149         (thread_info::deletable): Use it.
11150         (find_thread_ptid, thread_count, in_thread_list)
11151         (thread_change_ptid, set_resumed, set_running): New
11152         process_stratum_target parameter.  Pass it down.
11153         (set_executing): New process_stratum_target parameter.  Pass it
11154         down.  Adjust reference to 'threads_executing'.
11155         (threads_are_executing): New process_stratum_target parameter.
11156         Adjust reference to 'threads_executing'.
11157         (set_stop_requested, finish_thread_state): New
11158         process_stratum_target parameter.  Pass it down.
11159         (switch_to_thread): Also match inferior.
11160         (switch_to_thread): New process_stratum_target parameter.  Pass it
11161         down.
11162         (update_threads_executing): Reimplement.
11163         * top.c (quit_force): Pop targets from all inferior.
11164         (gdb_init): Don't call initialize_targets.
11165         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
11166         Declare.
11167         (windows_add_thread, windows_delete_thread): Adjust.
11168         (get_windows_debug_event): Rename to ...
11169         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
11170         * tracefile-tfile.c (tfile_target_open): Pass down target.
11171         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
11172         Forward declare.
11173         (switch_to_thread): Add process_stratum_target parameter.
11174         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
11175         parameter.  Use it.
11176         (mi_on_resume): Pass target down.
11177         * nat/fork-inferior.c (startup_inferior): Add
11178         process_stratum_target parameter.  Pass it down.
11179         * nat/fork-inferior.h (startup_inferior): Add
11180         process_stratum_target parameter.
11181         * python/py-threadevent.c (py_get_event_thread): Pass target down.
11182
11183 2020-01-10  Pedro Alves  <palves@redhat.com>
11184
11185         * remote.c (remote_target::start_remote): Don't set inferior_ptid
11186         directly.  Instead find the first thread in the thread list and
11187         use switch_to_thread.
11188
11189 2020-01-10  Pedro Alves  <palves@redhat.com>
11190
11191         * remote.c (remote_target::remote_add_inferior): Don't bind a
11192         process to the current inferior if the current inferior is already
11193         bound to a process.
11194
11195 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
11196             Pedro Alves  <palves@redhat.com>
11197
11198         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
11199         If no process is specified, return null_ptid instead of
11200         inferior_ptid.
11201         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
11202         TARGET_WAITKIND_SIGNALLED with no pid.
11203
11204 2020-01-10  Pedro Alves  <palves@redhat.com>
11205
11206         * remote.c (first_remote_resumed_thread): New.
11207         (remote_target::wait_as): Use it as default event_ptid instead of
11208         inferior_ptid.
11209
11210 2020-01-10  Pedro Alves  <palves@redhat.com>
11211
11212         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
11213
11214 2020-01-10  Pedro Alves  <palves@redhat.com>
11215
11216         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
11217         not -1.
11218
11219 2020-01-10  Pedro Alves  <palves@redhat.com>
11220
11221         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
11222         ptid to get_last_target_status.
11223         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
11224         ptid to get_last_target_status.
11225         * infcmd.c (continue_command): Don't pass a target_waitstatus to
11226         get_last_target_status.
11227         (info_program_command): Don't pass a target_waitstatus to
11228         get_last_target_status.
11229         * infrun.c (init_wait_for_inferior): Use
11230         nullify_last_target_wait_ptid.
11231         (get_last_target_status): Handle nullptr arguments.
11232         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
11233         (print_stop_event): Don't pass a ptid to get_last_target_status.
11234         (normal_stop): Don't pass a ptid to get_last_target_status.
11235         * infrun.h (get_last_target_status, set_last_target_status): Move
11236         comments here and update.
11237         (nullify_last_target_wait_ptid): Declare.
11238         * linux-fork.c (fork_load_infrun_state): Remove local extern
11239         declaration of nullify_last_target_wait_ptid.
11240         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
11241         to get_last_target_status.
11242
11243 2020-01-10  Pedro Alves  <palves@redhat.com>
11244
11245         * gdbthread.h (scoped_restore_current_thread)
11246         <dont_restore, restore, m_dont_restore>: Declare.
11247         * thread.c (thread_alive): Add assertion.  Return bool.
11248         (switch_to_thread_if_alive): New.
11249         (prune_threads): Switch inferior/thread.
11250         (print_thread_info_1): Switch thread before calling target methods.
11251         (scoped_restore_current_thread::restore): New, factored out from
11252         ...
11253         (scoped_restore_current_thread::~scoped_restore_current_thread):
11254         ... this.
11255         (scoped_restore_current_thread::scoped_restore_current_thread):
11256         Add assertion.
11257         (thread_apply_all_command, thread_select): Use
11258         switch_to_thread_if_alive.
11259         * infrun.c (proceed, restart_threads, handle_signal_stop)
11260         (switch_back_to_stepped_thread): Switch current thread before
11261         calling target methods.
11262
11263 2020-01-10  Pedro Alves <palves@redhat.com>
11264
11265         * inferior.c (switch_to_inferior_no_thread): New function,
11266         factored out from ...
11267         (inferior_command): ... here.
11268         * inferior.h (switch_to_inferior_no_thread): Declare.
11269         * mi/mi-main.c (run_one_inferior): Use
11270         switch_to_inferior_no_thread.
11271
11272 2020-01-10  Pedro Alves  <palves@redhat.com>
11273
11274         * infcmd.c (kill_command): Remove dead code.
11275
11276 2020-01-10  Pedro Alves  <palves@redhat.com>
11277
11278         * remote.c (remote_target::mourn_inferior): No longer check
11279         whether the target is running.
11280
11281 2020-01-10  Pedro Alves  <palves@redhat.com>
11282
11283         * corelow.c (core_target::has_execution): Change parameter type to
11284         inferior pointer.
11285         * inferior.c (number_of_live_inferiors): Use
11286         inferior::has_execution instead of target_has_execution_1.
11287         * inferior.h (inferior::has_execution): New.
11288         * linux-thread-db.c (thread_db_target::update_thread_list): Use
11289         inferior::has_execution instead of target_has_execution_1.
11290         * process-stratum-target.c
11291         (process_stratum_target::has_execution): Change parameter type to
11292         inferior pointer.  Check the inferior's PID instead of
11293         inferior_ptid.
11294         * process-stratum-target.h
11295         (process_stratum_target::has_execution): Change parameter type to
11296         inferior pointer.
11297         * record-full.c (record_full_core_target::has_execution): Change
11298         parameter type to inferior pointer.
11299         * target.c (target_has_execution_1): Change parameter type to
11300         inferior pointer.
11301         (target_has_execution_current): Adjust.
11302         * target.h (target_ops::has_execution): Change parameter type to
11303         inferior pointer.
11304         (target_has_execution_1): Change parameter type to inferior
11305         pointer.  Change return type to bool.
11306         * tracefile.h (tracefile_target::has_execution): Change parameter
11307         type to inferior pointer.
11308
11309 2020-01-10  Pedro Alves  <palves@redhat.com>
11310
11311         * exceptions.c (print_flush): Remove current_top_target() check.
11312
11313 2020-01-10  Pedro Alves  <palves@redhat.com>
11314
11315         * remote.c (show_remote_exec_file): Show the current inferior's
11316         exec-file instead of the command variable's value.
11317
11318 2020-01-10  Pedro Alves  <palves@redhat.com>
11319
11320         * record-full.c (record_full_resume_ptid): New global.
11321         (record_full_target::resume): Set it.
11322         (record_full_wait_1): Use record_full_resume_ptid instead of
11323         inferior_ptid.
11324
11325 2020-01-10  Pedro Alves  <palves@redhat.com>
11326
11327         * gdbthread.h (scoped_restore_current_thread)
11328         <dont_restore, restore, m_dont_restore>: Declare.
11329         * thread.c (thread_alive): Add assertion.  Return bool.
11330         (switch_to_thread_if_alive): New.
11331         (prune_threads): Switch inferior/thread.
11332         (print_thread_info_1): Switch thread before calling target methods.
11333         (scoped_restore_current_thread::restore): New, factored out from
11334         ...
11335         (scoped_restore_current_thread::~scoped_restore_current_thread):
11336         ... this.
11337         (scoped_restore_current_thread::scoped_restore_current_thread):
11338         Add assertion.
11339         (thread_apply_all_command, thread_select): Use
11340         switch_to_thread_if_alive.
11341
11342 2020-01-10  George Barrett  <bob@bob131.so>
11343
11344         * stap-probe.c (stap_modify_semaphore): Don't check for null
11345         semaphores.
11346         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
11347         for null semaphores.
11348
11349 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11350
11351         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
11352         all source windows, and maintain horizontal scroll status while
11353         doing so.
11354
11355 2020-01-09  Tom Tromey  <tom@tromey.com>
11356
11357         PR tui/18932:
11358         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
11359         update_source_window, not print_source_lines.
11360
11361 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11362
11363         * tui/tui.c (tui_enable): Register tui hooks after calling
11364         tui_display_main.
11365
11366 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
11367
11368         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
11369
11370 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
11371
11372         * thread.c (print_thread_info_1): Fix indentation.
11373
11374 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
11375
11376         * symtab.c (general_symbol_info::compute_and_set_names): Move the
11377         unique_xmalloc_ptr outside the if to always free the demangled name.
11378
11379 2020-01-08  Tom Tromey  <tromey@adacore.com>
11380
11381         * xcoffread.c (enter_line_range, read_xcoff_symtab)
11382         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
11383         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
11384         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
11385         Remove.
11386         (section_offsets): New typedef.
11387         * symtab.c (fixup_section, get_msymbol_address): Update.
11388         * symmisc.c (dump_msymbols): Update.
11389         * symfile.h (relative_addr_info_to_section_offsets)
11390         (symfile_map_offsets_to_segments): Update.
11391         * symfile.c (build_section_addr_info_from_objfile)
11392         (init_objfile_sect_indices): Update.
11393         (struct place_section_arg): Change type of "offsets".
11394         (place_section): Update.
11395         (relative_addr_info_to_section_offsets): Change type of
11396         "section_offsets".  Remove "num_sections" parameter.
11397         (default_symfile_offsets, syms_from_objfile_1)
11398         (set_objfile_default_section_offset): Update.
11399         (reread_symbols): No need to preserve section offsets by hand.
11400         (symfile_map_offsets_to_segments): Change type of "offsets".
11401         * stap-probe.c (relocate_address): Update.
11402         * stabsread.h (process_one_symbol): Update.
11403         * solib-target.c (struct lm_info_target) <offsets>: Change type.
11404         (solib_target_relocate_section_addresses): Update.
11405         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
11406         Update.
11407         * solib-frv.c (frv_relocate_main_executable): Update.
11408         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
11409         * solib-aix.c (solib_aix_get_section_offsets): Change return
11410         type.
11411         (solib_aix_solib_create_inferior_hook): Update.
11412         * remote.c (remote_target::get_offsets): Update.
11413         * psymtab.c (find_pc_sect_psymtab): Update.
11414         * psympriv.h (struct partial_symbol) <address, text_low,
11415         text_high>: Update.
11416         * objfiles.h (obj_section_offset): Update.
11417         (struct objfile) <section_offsets>: Change type.
11418         <num_sections>: Remove.
11419         (objfile_relocate): Update.
11420         * objfiles.c (entry_point_address_query): Update
11421         (relocate_one_symbol): Change type of "section_offsets".
11422         (objfile_relocate1, objfile_relocate1): Change type of
11423         "new_offsets".
11424         (objfile_rebase1): Update.
11425         * mipsread.c (mipscoff_symfile_read): Update.
11426         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
11427         parameter.
11428         * mdebugread.c (parse_symbol): Change type of "section_offsets".
11429         (parse_external, psymtab_to_symtab_1): Update.
11430         * machoread.c (macho_symfile_offsets): Update.
11431         * ia64-tdep.c (ia64_find_unwind_table): Update.
11432         * hppa-tdep.c (read_unwind_info): Update.
11433         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
11434         * dwarf2read.c (create_addrmap_from_index)
11435         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11436         (process_psymtab_comp_unit_reader, add_partial_symbol)
11437         (add_partial_subprogram, process_full_comp_unit)
11438         (read_file_scope, read_func_scope, read_lexical_block_scope)
11439         (read_call_site_scope, dwarf2_rnglists_process)
11440         (dwarf2_ranges_process, dwarf2_ranges_read)
11441         (dwarf_decode_lines_1, var_decode_location, new_symbol)
11442         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
11443         Update.
11444         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
11445         Update.
11446         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
11447         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
11448         (process_one_symbol): Change type of "section_offsets".
11449         * ctfread.c (get_objfile_text_range): Update.
11450         * coffread.c (coff_symtab_read, enter_linenos)
11451         (process_coff_symbol): Update.
11452         * coff-pe-read.c (add_pe_forwarded_sym): Update.
11453         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
11454
11455 2020-01-08  Tom Tromey  <tromey@adacore.com>
11456
11457         * dwarf2read.c (parse_macro_definition): Use std::string.
11458         (parse_macro_definition): Likewise.
11459
11460 2020-01-08  Tom Tromey  <tromey@adacore.com>
11461
11462         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
11463         (ATTR_ALLOC_CHUNK): Remove.
11464
11465 2020-01-08  Tom Tromey  <tromey@adacore.com>
11466
11467         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
11468
11469 2020-01-08  Tom Tromey  <tromey@adacore.com>
11470
11471         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
11472         (dwarf2_compute_name, open_dwo_file): Likewise.
11473         (process_enumeration_scope): Use std::vector.
11474         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
11475         (partial_die_info::fixup, dwarf2_start_subfile)
11476         (guess_full_die_structure_name, dwarf2_name): Likewise.
11477         (determine_prefix): Update.
11478         (guess_full_die_structure_name): Make return type const.
11479         (partial_die_full_name): Return unique_xmalloc_ptr.
11480         (DW_FIELD_ALLOC_CHUNK): Remove.
11481
11482 2020-01-07  Tom Tromey  <tromey@adacore.com>
11483
11484         PR build/24937:
11485         * stap-probe.c (class stap_static_probe_ops): Add constructor.
11486
11487 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
11488
11489         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
11490
11491 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11492
11493         * stack.c (print_frame_info): Move disassemble_next_line code
11494         inside source_print block.
11495
11496 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
11497
11498         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
11499         gdb/signals.h, as we are now using native signal symbols.
11500
11501 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
11502
11503         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
11504         overflow by an early check of content vs threshold.
11505         * tui/tui-source.c (tui_source_window::line_is_displayed):
11506         Likewise.
11507
11508 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
11509
11510         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
11511
11512 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
11513
11514         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
11515         export table if no section contains it's RVA.
11516
11517 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
11518
11519         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
11520
11521 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
11522
11523         * source.c (print_source_lines_base): Set last_line_listed.
11524
11525 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
11526
11527         * tui/tui-disasm.c: Remove trailing spaces.
11528
11529 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
11530             Pedro Alves  <palves@redhat.com>
11531
11532         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
11533         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
11534         (windows_gdb_signal_to_target): New function, uses the above
11535         enumeration to convert GDB internal signal codes to equivalent
11536         Windows codes.
11537         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
11538         * windows-nat.c: Include "gdb_wait.h".
11539         (get_windows_debug_event): Extract the fatal exception from the
11540         exit status and convert to the equivalent Posix signal number.
11541         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
11542         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
11543         * gdbsupport/gdb_wait.c: New file, implements
11544         windows_status_to_termsig.
11545         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
11546         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
11547
11548 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
11549
11550         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
11551         show_layout.
11552
11553 2020-01-05  Luis Machado  <luis.machado@linaro.org>
11554
11555         * aarch64-linux-nat.c
11556         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
11557         and bfd_mach_aarch64.
11558
11559 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11560
11561         * ui-file.c (stdio_file::can_emit_style_escape)
11562         (tee_file::can_emit_style_escape): Ensure style is used also on
11563         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
11564         to gdb_stdout.
11565         * main.c (set_gdb_data_directory): Use file style to output the
11566         warning that the given pathname is not a directory.
11567         * top.c (show_history_filename, gdb_safe_append_history)
11568         (show_gdb_datadir): Use file style.
11569
11570 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
11571
11572         * solib-target.c (struct lm_info_target):
11573         Change offsets to be a unique_xmalloc_ptr.
11574         (solib_target_relocate_section_addresses): Update.
11575
11576 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
11577
11578         * windows-nat.c (windows_clear_solib): Free so_list linked list.
11579
11580 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
11581
11582         * MAINTAINERS (Write After Approval): Add myself.
11583
11584 2020-01-02  Luis Machado  <luis.machado@linaro.org>
11585
11586         * proc-service.c (get_ps_regcache): Remove reference to obsolete
11587         Cell BE architecture.
11588         * target.h (struct target_ops) <thread_architecture>: Likewise.
11589
11590 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
11591
11592         * Makefile.in: Use INSTALL_PROGRAM_ENV.
11593
11594 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
11595
11596         * MAINTAINERS (Write After Approval): Add myself.
11597
11598 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
11599
11600         * gdbarch.sh: Update copyright year range of generated files.
11601
11602 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
11603
11604         Update copyright year range in all GDB files.
11605
11606 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
11607
11608         * copyright.py: Convert to Python 3.
11609
11610 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
11611
11612         * copyright.py: Adapt after move of gnulib directory from gdb
11613         directory to toplevel directory.
11614
11615 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
11616
11617         * copyright.py (main): Exit if run from the wrong directory.
11618
11619 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
11620
11621         * top.c (print_gdb_version): Change copyright year to 2020.
11622
11623 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
11624
11625         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
11626
11627 For older changes see ChangeLog-2019.
11628 \f
11629 Local Variables:
11630 mode: change-log
11631 left-margin: 8
11632 fill-column: 74
11633 version-control: never
11634 coding: utf-8
11635 End: