]> git.ipfire.org Git - thirdparty/binutils-gdb.git/blob - gdb/ChangeLog
6174da4e8da73cf0a0ce49b43195343add3a5624
[thirdparty/binutils-gdb.git] / gdb / ChangeLog
1 2019-12-18 Tom Tromey <tromey@adacore.com>
2
3 PR build/25250:
4 * ui-out.c (ui_out::vmessage): Update.
5 * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
6 Rename.
7 (string_field): Update.
8 (signed_field): Update.
9
10 2019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
11
12 * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
13
14 2019-12-11 Joel Brobecker <brobecker@adacore.com>
15
16 * version.in: Set GDB version number to 9.0.90.DATE-git.
17
18 2019-12-11 Joel Brobecker <brobecker@adacore.com>
19
20 GDB 9.0.90 released.
21
22 2019-12-11 Joel Brobecker <brobecker@adacore.com>
23
24 * version.in: Set GDB version number to 9.0.90.
25
26 2019-12-11 Joel Brobecker <brobecker@adacore.com>
27
28 * NEWS: Change "Changes since GDB 8.3" into "Changes in GDB 9".
29
30 2019-12-11 Joel Brobecker <brobecker@adacore.com>
31
32 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
33 * version.in: Bump version to 9.0.90.DATE-git.
34
35 2019-12-11 Tom Tromey <tromey@adacore.com>
36
37 PR build/25268:
38 * gdbsupport/thread-pool.c (set_thread_name): New function.
39 (thread_pool::set_thread_count): Don't call pthread_setname_np.
40 (thread_pool::thread_function): Call set_thread_name.
41
42 2019-12-11 Tom Tromey <tromey@adacore.com>
43
44 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
45 bfd_get_signed_8.
46
47 2019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
48
49 * NEWS: Document -raw-values option and the related setting commands.
50 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
51 only set it on when /r is given.
52 * valprint.c (value_print_option_defs): New element raw-values.
53 * Makefile.in: Add the new file.
54
55 2019-12-10 Christian Biesinger <cbiesinger@google.com>
56
57 * gdbsupport/safe-strerror.c: Supress the unused function warning
58 for select_strerror_r.
59
60 2019-12-10 Christian Biesinger <cbiesinger@google.com>
61
62 * config.in: Regenerate.
63 * configure: Regenerate.
64 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
65 safe_strerror instead of strerror.
66 * gdbsupport/common.m4: Don't check for strerror.
67 * gdbsupport/safe-strerror.c: Support both the glibc version
68 of strerror_r and the XSI version.
69
70 2019-12-10 Tom Tromey <tromey@adacore.com>
71
72 * ada-typeprint.c (print_choices): Use a single "?".
73 (print_variant_part): Print "?" if the discriminant name
74 is not known.
75
76 2019-12-10 George Barrett <bob@bob131.so>
77
78 Fix scripted probe breakpoints.
79 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
80 declaration forward.
81 (breakpoint_ops_for_event_location_type)
82 (breakpoint_ops_for_event_location): Add function definitions.
83 (break_command_1, trace_command): Use
84 breakpoint_ops_for_event_location.
85 * breakpoint.h (breakpoint_ops_for_event_location): Add function
86 declarations.
87 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
88 breakpoint_ops_for_event_location.
89 * python/py-breakpoint.c (bppy_init): Use
90 breakpoint_ops_for_event_location.
91
92 2019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
93
94 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
95 when ranking an lvalue argument for an rvalue parameter.
96
97 2019-12-08 Wataru Ashihara <wataash@wataash.com>
98
99 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
100 template argument for scoped_restore_tmpl from bool to int.
101
102 2019-12-07 Keith Seitz <keiths@redhat.com>
103
104 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
105 (build_id_to_debug_bfd): Make static, rewriting to use
106 build_id_to_bfd_suffix.
107 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
108 adding `suffix' parameter. Append SUFFIX to file names
109 when searching for matching files.
110 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
111 (build_id_to_exec_bfd): Likewise.
112 * build-id.h (build_id_to_debug_bfd): Clarify that function
113 searches for BFD of debug info file.
114 (build_id_to_exec_bfd): Declare.
115 * corelow.c: Include build-id.h.
116 (locate_exec_from_corefile_build_id): New function.
117 (core_target_open): If no executable BFD is found,
118 search for a core file BFD using build-id.
119
120 2019-12-06 Christian Biesinger <cbiesinger@google.com>
121
122 * bcache.c: Put in namespace gdb.
123 * bcache.h: Likewise.
124 * gdbtypes.c (check_types_worklist): Update.
125 (types_deeply_equal): Update.
126 * macrotab.c (struct macro_table) <bcache>: Update.
127 (new_macro_table): Update.
128 * macrotab.h (struct bcache): Put this forward declaration
129 inside namespace gdb.
130 (new_macro_table): Update.
131 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
132 Update.
133 <macro_cache>: Update.
134 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
135
136 2019-12-06 Tom de Vries <tdevries@suse.de>
137
138 PR symtab/24971
139 * block.c (best_symbol, better_symbol): New function.
140 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
141 decl.
142
143 2019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
144
145 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
146 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
147 for ranking see-through reference cases.
148
149 2019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
150 * stack.c (faas_command): Check a command is provided.
151 * thread.c (taas_command, tfaas_command): Likewise.
152
153 2019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
154 * inferior.c (prune_inferiors): Only call delete_inferior,
155 Do not modify the inferior list.
156
157 2019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
158
159 * c-exp.y: Update calls to lookup_typename,
160 lookup_signed_typename and lookup_unsigned_typename.
161 * c-lang.c (evaluate_subexp_c): Likewise.
162 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
163 Likewise.
164 * eval.c (binop_promote): Likewise.
165 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
166 (lookup_unsigned_typename): Likewise.
167 (lookup_signed_typename): Likewise.
168 * gdbtypes.h (lookup_unsigned_typename): Likewise.
169 (lookup_signed_typename): Likewise.
170 (lookup_typename): Likewise.
171 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
172 lookup_typename, lookup_signed_typename,
173 lookup_unsigned_typename.
174 * m2-exp.y: Likewise.
175 * printcmd.c (printf_wide_c_string): Likewise.
176 (ui_printf): Likewise.
177 * python/py-type.c (typy_lookup_typename): Likewise.
178 * python/py-xmethods.c (python_xmethod_worker::invoke):
179 Likewise.
180 * rust-exp.y: Likewise.
181
182 2019-12-04 Christian Biesinger <cbiesinger@google.com>
183
184 * configure.nat (obsd64): Add missing files x86-nat.o and
185 nat/x86-dregs.o.
186
187 2019-12-04 Tom Tromey <tom@tromey.com>
188
189 * valprint.c (val_print_string): Use metadata_style.
190 * go-valprint.c (print_go_string): Use metadata style.
191 * p-valprint.c (pascal_object_print_static_field): Use metadata
192 style.
193 * cp-valprint.c (cp_print_static_field): Use metadata style.
194
195 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
196 Chris January <chris.january@arm.com>
197
198 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
199 tokens.
200 (typebase): New patterns for complex, single/double precision, and
201 single/double complex.
202 (f77_keywords): Change token for complex keyword, and add single,
203 double, and precision keywords.
204
205 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
206
207 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
208 "info io_registers".
209
210 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
211
212 * regcache.c (cooked_read_test): Initialize thread list of
213 mock_inferior.
214
215 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
216
217 * aarch64-linux-tdep.c: Remove includes.
218
219 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
220
221 * aarch64-tdep.c: Remove includes.
222
223 2019-12-04 Simon Marchi <simon.marchi@efficios.com>
224
225 * filtered-iterator.h (filtered_iterator) <operator==,
226 operator!=>: Compare wrapped iterators, not wrapped pointers.
227 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
228 unittests/filtered_iterator-selftests.c.
229 * unittests/filtered_iterator-selftests.c: New file.
230
231 2019-12-04 Tom Tromey <tromey@adacore.com>
232
233 * gdbtypes.c (create_range_type): Inherit endianity
234 from base type.
235
236 2019-12-04 Tom Tromey <tromey@adacore.com>
237
238 * ada-lang.c (decode_constrained_packed_array)
239 (ada_value_assign, value_assign_to_component): Update.
240 * dwarf2loc.c (rw_pieced_value, access_memory)
241 (dwarf2_compile_expr_to_ax): Update.
242 * dwarf2read.c (dwarf2_add_field): Update.
243 * eval.c (evaluate_subexp_standard): Update.
244 * gdbarch.c, gdbarch.h: Rebuild.
245 * gdbarch.sh (bits_big_endian): Remove.
246 * gdbtypes.h (union field_location): Update comment.
247 * target-descriptions.c (make_gdb_type): Update.
248 * valarith.c (value_bit_index): Update.
249 * value.c (struct value) <bitpos>: Update comment.
250 (unpack_bits_as_long, modify_field): Update.
251 * value.h (value_bitpos): Update comment.
252
253 2019-12-04 Tom Tromey <tromey@adacore.com>
254
255 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
256 endian-ness.
257
258 2019-12-04 Tom Tromey <tromey@adacore.com>
259
260 * dwarf2read.c (dwarf2_init_float_type)
261 (dwarf2_init_complex_target_type): Add byte_order parameter.
262 (read_base_type): Compute byte order earlier.
263 * gdbtypes.c (init_float_type): Add byte_order parameter.
264 * gdbtypes.h (init_float_type): Add byte_order parameter.
265
266 2019-12-04 Tom Tromey <tromey@adacore.com>
267
268 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
269
270 2019-12-04 Tom Tromey <tromey@adacore.com>
271
272 * dwarf2read.c (process_structure_scope): Initialize
273 "discr_offset".
274
275 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
276
277 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
278 add it into the search spec.
279 (parse_max_results_option): New function.
280 (mi_info_functions_or_variables): Parse -max-results flag and pass
281 it to mi_symbol_info.
282 (mi_cmd_symbol_info_modules): Likewise.
283 (mi_cmd_symbol_info_types): Likewise.
284 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
285 return type to bool, change result container into a set, and don't
286 add new results if we have enough already.
287 (global_symbol_searcher::add_matching_msymbols): Change return
288 type to bool, and don't add new results if we have enough already.
289 (sort_search_symbols_remove_dups): Delete.
290 (global_symbol_searcher::search): Early exit from search loop when
291 we have enough results. Use a std::set to collect the results
292 from calling add_matching_symbols.
293 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
294 member function.
295 (global_symbol_searcher) <m_max_search_results>: New member
296 variable.
297 (global_symbol_searcher) <add_matching_symbols>: Update header
298 comment and change return type to bool.
299 (global_symbol_searcher) <add_matching_msymbols>: Update header
300 comment and change return type to bool.
301
302 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
303
304 * symtab.c (symbol_search::compare_search_syms): Update header
305 comment.
306 (global_symbol_searcher::is_suitable_msymbol): New function.
307 (global_symbol_searcher::expand_symtabs): New function.
308 (global_symbol_searcher::add_matching_symbols): New function.
309 (global_symbol_searcher::add_matching_msymbols): New function.
310 (global_symbol_searcher::search): Move most of the content
311 into the new functions above, and call them as needed.
312 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
313 function.
314 (global_symbol_searcher) <add_matching_symbols>: New member
315 function.
316 (global_symbol_searcher) <add_matching_msymbols>: New member
317 function.
318 (global_symbol_searcher) <is_suitable_msymbol>: New member
319 function.
320
321 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
322
323 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
324 -symbol-info-module-variables entries.
325 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
326 (mi_cmd_symbol_info_module_variables): Declare.
327 * mi/mi-symbol-cmds.c
328 (module_symbol_search_iterator): New typedef.
329 (output_module_symbols_in_single_module_and_file): New function.
330 (output_module_symbols_in_single_module): New function.
331 (mi_info_module_functions_or_variables): New function.
332 (mi_cmd_symbol_info_module_functions): New function.
333 (mi_cmd_symbol_info_module_variables): New function.
334 * NEWS: Mention new MI command.
335
336 2019-12-03 Christian Biesinger <cbiesinger@google.com>
337
338 * bcache.c (hash): Remove.
339 (hash_continue): Remove.
340 * bcache.h (hash): Remove.
341 (hash_continue): Remove.
342 (struct bcache) <ctor>: Update.
343 * psymtab.c (psymbol_hash): Update.
344 * stabsread.c (hashname): Update.
345 * utils.h (fast_hash): Add an argument for a start value,
346 defaulting to zero.
347
348 2019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
349 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
350 (destroy_block_symbol_cache): New function.
351 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
352 (resize_symbol_cache): Likewise.
353
354 2019-12-02 Tom Tromey <tom@tromey.com>
355
356 * unittests/tui-selftests.c (run_tests): Make conditional.
357 (_initialize_tui_selftest): Make conditional.
358
359 2019-12-02 Christian Biesinger <cbiesinger@google.com>
360
361 * aix-thread.c (debug_aix_thread): Change type to bool.
362
363 2019-12-02 Luis Machado <luis.machado@linaro.org>
364
365 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
366
367 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
368
369 * dwarf2read.c (read_tag_string_type): Read the fields required to
370 make a dynamic string, and possibly create a dynamic range for the
371 string.
372 (attr_to_dynamic_prop): Setup is_reference based on the type of
373 attribute being processed.
374 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
375 (resolve_dynamic_array): Rename to...
376 (resolve_dynamic_array_or_string): ...this, update header comment,
377 and accept TYPE_CODE_STRING.
378 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
379
380 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
381
382 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
383 of its implementation from...
384 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
385 the new function.
386
387 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
388
389 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
390 create a range with stride where appropriate.
391 * f-valprint.c: Include 'gdbarch.h'.
392 (f77_print_array_1): Take the stride into account when walking the
393 array. Also convert the stride into addressable units.
394 * gdbtypes.c (create_range_type): Initialise the stride to
395 constant zero.
396 (create_range_type_with_stride): New function, initialise the
397 range as normal, and then setup the stride.
398 (has_static_range): Include the stride here. Also change the
399 return type to bool.
400 (create_array_type_with_stride): Consider the range stride if the
401 array isn't given its own stride.
402 (resolve_dynamic_range): Resolve the stride if needed.
403 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
404 (struct range_bounds) <flag_is_byte_stride>: New member variable.
405 (TYPE_BIT_STRIDE): Define.
406 (TYPE_ARRAY_BIT_STRIDE): Define.
407 (create_range_type_with_stride): Declare.
408 * valarith.c (value_subscripted_rvalue): Take range stride into
409 account when walking the array.
410
411 2019-12-01 Tom Tromey <tom@tromey.com>
412
413 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
414 specially.
415
416 2019-12-01 Tom Tromey <tom@tromey.com>
417
418 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
419 \0.
420 * unittests/tui-selftests.c: New file.
421 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
422
423 2019-12-01 Tom Tromey <tom@tromey.com>
424
425 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
426
427 2019-12-01 Tom Tromey <tom@tromey.com>
428
429 * NEWS: Document new settings.
430 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
431 * tui/tui-win.c (_initialize_tui_win): Add border style
432 observers.
433 * tui/tui-io.h (tui_apply_style): Declare.
434 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
435 longer static.
436 (apply_ansi_escape, tui_set_reverse_mode): Update.
437 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
438 Add "skip_intensity" parameter.
439 <changed>: New member.
440 <do_set_value>: Declare.
441 (tui_border_style, tui_active_border_style): Declare.
442 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
443 globals.
444 (cli_style_option): Initialize "changed".
445 (cli_style_option::do_set_value): New function.
446 (cli_style_option::add_setshow_commands): Add "skip_intensity"
447 parameter. Update.
448 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
449 (_initialize_cli_style): Update. Create TUI border style
450 commands.
451
452 2019-12-01 Tom Tromey <tom@tromey.com>
453
454 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
455 parameter.
456 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
457 parameter.
458 * tui/tui-win.h (compact_source): Declare.
459 * tui/tui-win.c (compact_source): New global.
460 (tui_set_compact_source, tui_show_compact_source): New functions.
461 (_initialize_tui_win): Add "compact-source" setting.
462 * tui/tui-source.c (tui_source_window::set_contents): Handle
463 compact_source setting.
464 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
465 * NEWS: Document new setting.
466
467 2019-11-30 Tom Tromey <tom@tromey.com>
468
469 * dwarf2read.c (dwarf2_add_field): Include field offset when
470 computing variant part length.
471
472 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
473 * NEWS: Mention define-prefix. Tell that command names can now
474 contain a . character.
475
476 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
477
478 * command.h (valid_cmd_char_p): Declare.
479 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
480 the check of valid command char.
481 (find_command_name_length, valid_user_defined_cmd_name_p): Use
482 valid_cmd_char_p.
483 * cli/cli-script.c (validate_comname): Likewise.
484 * completer.c (gdb_completer_command_word_break_characters):
485 Do not remove . from the word break char, update comments.
486 (complete_line_internal_1): Use valid_cmd_char_p.
487 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
488 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
489
490 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
491
492 * cli/cli-script.c (do_define_command): Ensure a redefined
493 prefix command is kept as a prefix command.
494 (define_prefix_command): New function.
495 (show_user_1): Report user defined prefixes.
496 (_initialize_cli_script): Create the new 'define-prefix' command.
497 Add completers for 'define' and 'document'.
498 * top.c (execute_command): If command is a user-defined prefix only
499 command, report the list of commands for this prefix command.
500
501 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
502
503 * valops.c (find_oload_champ): Improve debug output.
504
505 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
506
507 * valops.c (find_oload_champ): Print part of debug messages
508 before the badness vector is std::move'd.
509
510 2019-11-28 Tom Tromey <tom@tromey.com>
511
512 * value.c (creal_internal_fn): Fix comment.
513
514 2019-11-28 Tom Tromey <tom@tromey.com>
515
516 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
517 flag_bound_evaluated>: Now unsigned.
518
519 2019-11-28 Tom Tromey <tom@tromey.com>
520
521 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
522 declare.
523
524 2019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
525
526 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
527 debug output.
528 * jit.c (jit_unregister_code): Add debug print to match
529 `jit_register_code`.
530
531 2019-11-27 Christian Biesinger <cbiesinger@google.com>
532
533 * NEWS: Mention the new multithreaded symbol loading.
534
535 2019-11-27 Christian Biesinger <cbiesinger@google.com>
536
537 * maint.c (n_worker_threads): Default to 0.
538 (worker_threads_disabled): New function.
539 * maint.h (worker_threads_disabled): New function.
540 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
541 here if worker_threads_disabled () is true.
542 (minimal_symbol_reader::install): Skip all threading if
543 worker_threads_disabled () is true.
544
545 2019-11-27 Christian Biesinger <cbiesinger@google.com>
546
547 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
548 hash code if possible.
549 (add_minsym_to_demangled_hash_table): Likewise.
550 (minimal_symbol_reader::install): Compute the hash codes for msymbol
551 on the background thread.
552 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
553 Add these fields.
554
555 2019-11-27 Christian Biesinger <cbiesinger@google.com>
556
557 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
558 of the mangled name on the background thread.
559 * symtab.c (symbol_set_names): Allow passing in the hash of the
560 linkage_name.
561 * symtab.h (symbol_set_names): Likewise.
562
563 2019-11-27 Kevin Buettner <kevinb@redhat.com>
564
565 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
566 physnames are computed for inherited DIEs.
567
568 2019-11-27 Tom Tromey <tromey@adacore.com>
569
570 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
571 backslashes.
572 * cp-support.c: Remove unnecessary backslashes.
573
574 2019-11-27 Christian Biesinger <cbiesinger@google.com>
575
576 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
577 with sym->set_linkage_name.
578 * coffread.c (coff_read_enum_type): Likewise.
579 * mdebugread.c (parse_symbol): Likewise.
580 * stabsread.c (patch_block_stabs): Likewise.
581 (define_symbol): Likewise.
582 (read_enum_type): Likewise.
583 (common_block_end): Likewise.
584 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
585 function.
586 (SYMBOL_SET_LINKAGE_NAME): Remove.
587 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
588 with sym->set_linkage_name.
589
590 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
591
592 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
593 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
594 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
595 * NEWS: Mention new MI command.
596
597 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
598
599 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
600 '-symbol-info-types', and '-symbol-info-variables'.
601 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
602 (mi_cmd_symbol_info_types): Declare.
603 (mi_cmd_symbol_info_variables): Declare.
604 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
605 (output_debug_symbol): New function.
606 (output_nondebug_symbol): New function.
607 (mi_symbol_info): New function.
608 (mi_info_functions_or_variables): New function.
609 (mi_cmd_symbol_info_functions): New function.
610 (mi_cmd_symbol_info_types): New function.
611 (mi_cmd_symbol_info_variables): New function.
612 * NEWS: Mention new commands.
613
614 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
615
616 * symtab.c (symbol_to_info_string): New function, most content
617 moved from print_symbol_info, but updated to return a std::string.
618 (print_symbol_info): Update to use symbol_to_info_string and print
619 returned string.
620 * symtab.h (symbol_to_info_string): Declare new function.
621
622 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
623
624 * python/python.c (gdbpy_rbreak): Convert to using
625 global_symbol_searcher.
626 * symtab.c (file_matches): Convert return type to bool, change
627 file list to std::vector, update header comment.
628 (search_symbols): Rename to...
629 (global_symbol_searcher::search): ...this and update now its
630 a member function of global_symbol_searcher. Take account of the
631 changes to file_matches.
632 (symtab_symbol_info): Convert to using global_symbol_searcher.
633 (rbreak_command): Likewise.
634 (search_module_symbols): Likewise.
635 * symtab.h (enum symbol_search): Update comment.
636 (search_symbols): Remove declaration.
637 (class global_symbol_searcher): New class.
638
639 2019-11-26 Tom Tromey <tromey@adacore.com>
640
641 * cp-support.c (_initialize_cp_support): Conditionally initialize
642 gdb_demangle_attempt_core_dump.
643
644 2019-11-26 Tom Tromey <tom@tromey.com>
645
646 * python/py-function.c (fnpy_init): Update.
647 * value.h (add_internal_function): Adjust declaration.
648 * value.c (function_destroyer): Remove.
649 (do_add_internal_function): Don't set destroyer or copy name.
650 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
651 Set name_allocated.
652 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
653 (cmdpy_init): Set name_allocated.
654 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
655 member.
656 (~cmd_list_element): Free "name" if needed.
657
658 2019-11-26 Tom Tromey <tom@tromey.com>
659
660 * value.h (add_internal_function): Add new overload. Move
661 documentation from value.h.
662 * value.c (do_add_internal_function): New function.
663 (add_internal_function): Use it. Add new overload.
664 (function_destroyer): Don't free doc.
665 * python/py-function.c (fnpy_init): Update.
666
667 2019-11-26 Tom Tromey <tom@tromey.com>
668
669 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
670 (cmdpy_init): Set "doc_allocated".
671
672 2019-11-26 Tom Tromey <tom@tromey.com>
673
674 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
675 name of worker thread.
676 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
677 pthread_setname_np.
678 * configure, config.in: Rebuild.
679
680 2019-11-26 Tom Tromey <tom@tromey.com>
681
682 * python/python.c (class gdbpy_gil): New.
683 (struct gdbpy_event): Add constructor, destructor, operator().
684 (gdbpy_post_event): Use run_on_main_thread.
685 (gdbpy_initialize_events): Remove.
686 (do_start_initialization): Update.
687
688 2019-11-26 Tom Tromey <tom@tromey.com>
689
690 * NEWS: Add entry.
691 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
692 commands. Call update_thread_pool_size.
693 (update_thread_pool_size, maintenance_set_worker_threads): New
694 functions.
695 (n_worker_threads): New global.
696
697 2019-11-26 Christian Biesinger <cbiesinger@google.com>
698 Tom Tromey <tom@tromey.com>
699
700 * minsyms.c (minimal_symbol_reader::install): Use
701 parallel_for_each.
702 * gdbsupport/parallel-for.h: New file.
703 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
704
705 2019-11-26 Christian Biesinger <cbiesinger@google.com>
706 Tom Tromey <tom@tromey.com>
707
708 * gdbsupport/thread-pool.h: New file.
709 * gdbsupport/thread-pool.c: New file.
710 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
711 (HFILES_NO_SRCDIR): Add thread-pool.h.
712
713 2019-11-26 Tom Tromey <tom@tromey.com>
714
715 * event-top.h (thread_local_segv_handler): Declare.
716 * event-top.c (thread_local_segv_handler): New global.
717 (install_handle_sigsegv, handle_sigsegv): New functions.
718 (async_init_signals): Install SIGSEGV handler.
719 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
720 thread-local.
721 (report_failed_demangle): New function.
722 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
723 handler-setting code, instead use segv_handler. Run warning code
724 on main thread.
725
726 2019-11-26 Tom Tromey <tom@tromey.com>
727
728 * run-on-main-thread.c: New file.
729 * run-on-main-thread.h: New file.
730 * unittests/main-thread-selftests.c: New file.
731 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
732 main-thread-selftests.c.
733 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
734 (COMMON_SFILES): Add run-on-main-thread.c.
735
736 2019-11-26 Tom Tromey <tom@tromey.com>
737
738 * main.c (setup_alternate_signal_stack): Remove.
739 (captured_main_1): Use gdb::alternate_signal_stack.
740 * gdbsupport/alt-stack.h: New file.
741
742 2019-11-26 Tom Tromey <tom@tromey.com>
743
744 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
745 Remove comment.
746 (save_original_signals_state, restore_original_signals_state): Use
747 gdb_sigmask.
748 * linux-nat.c (block_child_signals, restore_child_signals_mask)
749 (_initialize_linux_nat): Use gdb_sigmask.
750 * guile/guile.c (_initialize_guile): Use block_signals.
751 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
752 * gdbsupport/gdb-sigmask.h: New file.
753 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
754 * cp-support.c (gdb_demangle): Use gdb_sigmask.
755 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
756 pthread_sigmask.
757 * configure, config.in: Rebuild.
758 * gdbsupport/block-signals.h: New file.
759
760 2019-11-26 Tom Tromey <tom@tromey.com>
761
762 * acinclude.m4: Include ax_pthread.m4.
763 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
764 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
765 (CLIBS): Use PTHREAD_LIBS.
766 (aclocal_m4_deps): Add ax_pthread.m4.
767 * config.in, configure: Rebuild.
768 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
769
770 2019-11-26 Tom Tromey <tom@tromey.com>
771
772 * symtab.h (struct minimal_symbol) <name_set>: New member.
773 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
774 Don't call symbol_set_names.
775 (minimal_symbol_reader::install): Call symbol_set_names.
776
777 2019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
778
779 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
780 restore_active_ext_lang, as GIL is needed for (indirectly)
781 called PyOS_InterruptOccurred.
782
783 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
784
785 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
786 definition.
787
788 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
789
790 * remote-sim.c (simulator_command): Make static, remove
791 declaration.
792
793 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
794
795 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
796 static.
797 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
798 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
799 (main): Likewise.
800 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
801 (main): Likewise.
802 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
803 (main): Likewise.
804 * unittests/basic_string_view/element_access/char/1.cc (test01):
805 Likewise.
806 (main): Likewise.
807 * unittests/basic_string_view/element_access/char/empty.cc (main):
808 Likewise.
809 * unittests/basic_string_view/element_access/char/front_back.cc
810 (test01): Likewise.
811 (main): Likewise.
812 * unittests/basic_string_view/inserters/char/2.cc (test05):
813 Likewise.
814 (main): Likewise.
815 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
816 (test01): Likewise.
817 (main): Likewise.
818 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
819 (test01): Likewise.
820 (main): Likewise.
821 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
822 Likewise.
823 * unittests/basic_string_view/operations/compare/char/1.cc
824 (test01): Likewise.
825 (main): Likewise.
826 * unittests/basic_string_view/operations/compare/char/13650.cc
827 (test01): Likewise.
828 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
829 Likewise.
830 (main): Likewise.
831 * unittests/basic_string_view/operations/data/char/1.cc (test01):
832 Likewise.
833 (main): Likewise.
834 * unittests/basic_string_view/operations/find/char/1.cc (test01):
835 Likewise.
836 (main): Likewise.
837 * unittests/basic_string_view/operations/find/char/2.cc (test02):
838 Likewise.
839 (main): Likewise.
840 * unittests/basic_string_view/operations/find/char/3.cc (test03):
841 Likewise.
842 (main): Likewise.
843 * unittests/basic_string_view/operations/find/char/4.cc (main):
844 Likewise.
845 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
846 Likewise.
847 (main): Likewise.
848 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
849 Likewise.
850 (main): Likewise.
851 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
852 Likewise.
853 (main): Likewise.
854 * unittests/basic_string_view/operations/substr/char/1.cc
855 (test01): Likewise.
856 (main): Likewise.
857 * unittests/basic_string_view/operators/char/2.cc (main):
858 Likewise.
859 * unittests/optional/assignment/1.cc (test): Likewise.
860 * unittests/optional/assignment/2.cc (test): Likewise.
861 * unittests/optional/assignment/3.cc (test): Likewise.
862 * unittests/optional/assignment/4.cc (test): Likewise.
863 * unittests/optional/assignment/5.cc (test): Likewise.
864 * unittests/optional/assignment/6.cc (test): Likewise.
865 * unittests/optional/assignment/7.cc (test): Likewise.
866 * unittests/optional/cons/copy.cc (test): Likewise.
867 * unittests/optional/cons/default.cc (test): Likewise.
868 * unittests/optional/cons/move.cc (test): Likewise.
869 * unittests/optional/cons/value.cc (test): Likewise.
870 * unittests/optional/in_place.cc (test): Likewise.
871 * unittests/optional/observers/1.cc (test): Likewise.
872 * unittests/optional/observers/2.cc (test): Likewise.
873
874 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
875
876 * tui-win.h (tui_set_var_cmd): Remove.
877 * tui-win.c (tui_set_var_cmd): Make static.
878
879 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
880
881 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
882 rbreak_command_wrapper): Remove.
883 * symtab.c (rbreak_command_wrapper): Remove.
884
885 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
886
887 * inferior.h (info_terminal_command): Remove declaration.
888 * inflow.c (info_terminal_command): Make static.
889
890 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
891
892 * inferior.c (exit_inferior_silent): Remove.
893
894 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
895
896 * dictionary.c (dict_empty, mdict_empty): Remove.
897 * dictionary.c (mdict_empty): Remove.
898
899 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
900
901 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
902 (arc_insn_get_memory_offset): Likewise.
903 (arc_insn_dump): Likewise.
904 * cp-support.c (test_cp_symbol_name_matches): Likewise.
905 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
906 * dictionary.c (dict_iterator_next): Likewise.
907 (dict_iter_match_first): Likewise.
908 (dict_iter_match_next): Likewise.
909 * f-lang.c (evaluate_subexp_f): Likewise.
910 * hppa-tdep.c (hppa_read_pc): Likewise.
911 * i386-tdep.c (i386_floatformat_for_type): Likewise.
912 * parse.c (write_exp_elt_msym): Likewise.
913 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
914 * remote.c (remote_packet_size): Likewise.
915 (remote_notif_stop_parse): Likewise.
916 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
917 * s12z-tdep.c (s12z_disassemble_info): Likewise.
918 * source.c (prepare_path_for_appending): Likewise.
919 * sparc64-linux-tdep.c
920 (sparc64_linux_handle_segmentation_fault); Likewise.
921 * stack.c (frame_selection_by_function_completer): Likewise.
922
923 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
924
925 * completer.c (set_gdb_completion_word_break_characters):
926 Remove.
927
928 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
929
930 * dwarf-index-write.c: Include dwarf-index-write.h.
931 * mi/mi-interp.c: Include mi/mi-interp.h.
932
933 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
934
935 * aarch32-tdep.c: Include aarch32-tdep.h.
936 * aarch32-tdep.h: Forward-declare struct target_desc.
937
938 2019-11-26 Christian Biesinger <cbiesinger@google.com>
939
940 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
941 strerror.
942 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
943 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
944
945 2019-11-25 Tom de Vries <tdevries@suse.de>
946
947 * contrib/words.sh: Add -c option.
948
949 2019-11-25 Christian Biesinger <cbiesinger@google.com>
950
951 * solib.c (solib_find_1): Change int to bool.
952 (exec_file_find): Change int to bool.
953 (solib_find): Change int to bool.
954 (solib_read_symbols): Change int to bool.
955 (solib_used): Change int to bool.
956 (solib_add): Change int to bool.
957 (info_sharedlibrary_command): Change int to bool.
958 (solib_contains_address_p): Change int to bool.
959 (solib_keep_data_in_core): Change int to bool.
960 (in_solib_dynsym_resolve_code): Change int to bool.
961 (reload_shared_libraries_1): Change int to bool.
962 (gdb_sysroot_changed): Change int to bool.
963 * solib.h (solib_read_symbols): Change int to bool.
964 (solib_contains_address_p): Change int to bool.
965 (solib_keep_data_in_core): Change int to bool.
966 (in_solib_dynsym_resolve_code): Change int to bool.
967 (libpthread_name_p): Change int to bool.
968
969 2019-11-25 Luis Machado <luis.machado@linaro.org>
970
971 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
972 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
973 (remote_packet_max_chars): New static global.
974 (show_remote_packet_max_chars): New function.
975 (remote_target::putpkt_binary): Adjust to use new
976 remote_packet_max_chars option.
977 (remote_target::getpkt_or_notif_sane_1): Likewise.
978 (_initialize_remote): Register new remote-packet-max-chars option.
979
980 2019-11-24 Simon Marchi <simon.marchi@efficios.com>
981
982 * m68k-linux-nat.c: Include gdbarch.h.
983
984 2019-11-24 Tom Tromey <tom@tromey.com>
985
986 * symfile.c (read_symbols): Update.
987 * psymtab.c (require_partial_symbols): Change type of "verbose" to
988 bool.
989 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
990 (psym_lookup_symbol, psym_find_last_source_symtab)
991 (psym_forget_cached_source_info, psym_print_stats)
992 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
993 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
994 (psym_map_matching_symbols, psym_expand_symtabs_matching)
995 (psym_find_compunit_symtab_by_address)
996 (maintenance_print_psymbols, maintenance_info_psymtabs)
997 (maintenance_check_psymtabs): Update.
998 * psymtab.h (require_partial_symbols): Change type of "verbose" to
999 bool.
1000
1001 2019-11-22 Tom Tromey <tom@tromey.com>
1002
1003 * observable.h: Update comments.
1004
1005 2019-11-22 Tom Tromey <tromey@adacore.com>
1006
1007 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1008 (print_ada_task_info): Don't try to fetch thread id if task is not
1009 alive.
1010
1011 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1012
1013 * ada-exp.y: Update.
1014 * ada-lang.c (sort_choices): Update.
1015 (ada_print_symbol_signature): Update.
1016 (resolve_subexp): Update.
1017 (ada_parse_renaming): Update.
1018 (ada_read_renaming_var_value): Update.
1019 (lesseq_defined_than): Update.
1020 (remove_extra_symbols): Update.
1021 (remove_irrelevant_renamings): Update.
1022 (ada_add_block_symbols): Update.
1023 (ada_collect_symbol_completion_matches): Update.
1024 (ada_is_renaming_symbol): Update.
1025 (aggregate_assign_from_choices): Update.
1026 (ada_evaluate_subexp): Update.
1027 (ada_has_this_exception_support): Update.
1028 (ada_is_non_standard_exception_sym): Update.
1029 (ada_add_exceptions_from_frame): Update.
1030 (ada_add_global_exceptions): Update.
1031 (ada_print_subexp): Update.
1032 * ax-gdb.c (gen_var_ref): Update.
1033 (gen_maybe_namespace_elt): Update.
1034 (gen_expr_for_cast): Update.
1035 (gen_expr): Update.
1036 * block.h: Update.
1037 * blockframe.c (find_pc_partial_function): Update.
1038 * breakpoint.c (print_breakpoint_location): Update.
1039 (update_static_tracepoint): Update.
1040 * btrace.c (ftrace_print_function_name): Update.
1041 (ftrace_function_switched): Update.
1042 * buildsym.c (find_symbol_in_list): Update.
1043 * c-exp.y: Update.
1044 * c-typeprint.c (c_print_typedef): Update.
1045 (c_type_print_template_args): Update.
1046 * cli/cli-cmds.c (edit_command): Update.
1047 (list_command): Update.
1048 (print_sal_location): Update.
1049 * coffread.c (patch_opaque_types): Update.
1050 (process_coff_symbol): Update.
1051 (coff_read_enum_type): Update.
1052 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1053 (convert_one_symbol): Update.
1054 (hash_symname): Update.
1055 (eq_symname): Update.
1056 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1057 * compile/compile-cplus-types.c (debug_print_scope): Update.
1058 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1059 * compile/compile-object-load.c (get_out_value_type): Update.
1060 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1061 (search_symbol_list): Update.
1062 (cp_lookup_symbol_imports_or_template): Update.
1063 * cp-support.c (overload_list_add_symbol): Update.
1064 * ctfread.c (psymtab_to_symtab): Update.
1065 * dbxread.c (cp_set_block_scope): Update.
1066 * dictionary.c (iter_match_first_hashed): Update.
1067 (iter_match_next_hashed): Update.
1068 (insert_symbol_hashed): Update.
1069 (iter_match_next_linear): Update.
1070 * dictionary.h: Update.
1071 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1072 (locexpr_describe_location_piece): Update.
1073 (locexpr_describe_location_1): Update.
1074 (locexpr_generate_c_location): Update.
1075 (loclist_describe_location): Update.
1076 (loclist_generate_c_location): Update.
1077 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1078 (read_func_scope): Update.
1079 (process_enumeration_scope): Update.
1080 (new_symbol): Update.
1081 (dwarf2_const_value): Update.
1082 (dwarf2_symbol_mark_computed): Update.
1083 * eval.c (evaluate_funcall): Update.
1084 (evaluate_subexp_standard): Update.
1085 * expprint.c (print_subexp_standard): Update.
1086 (dump_subexp_body_standard): Update.
1087 * f-valprint.c (info_common_command_for_block): Update.
1088 * findvar.c (get_hosting_frame): Update.
1089 (default_read_var_value): Update.
1090 * go-lang.c (go_symbol_package_name): Update.
1091 * guile/scm-block.c (bkscm_print_block_smob): Update.
1092 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1093 (gdbscm_symbol_name): Update.
1094 (gdbscm_symbol_linkage_name): Update.
1095 (gdbscm_symbol_print_name): Update.
1096 * infcall.c (get_function_name): Update.
1097 * infcmd.c (jump_command): Update.
1098 (finish_command): Update.
1099 * infrun.c (insert_exception_resume_breakpoint): Update.
1100 * linespec.c (canonicalize_linespec): Update.
1101 (create_sals_line_offset): Update.
1102 (convert_linespec_to_sals): Update.
1103 (complete_label): Update.
1104 (find_label_symbols_in_block): Update.
1105 * m2-typeprint.c (m2_print_typedef): Update.
1106 * mdebugread.c (mdebug_reg_to_regnum): Update.
1107 (parse_symbol): Update.
1108 (mylookup_symbol): Update.
1109 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1110 (list_args_or_locals): Update.
1111 * objc-lang.c (compare_selectors): Update.
1112 (info_selectors_command): Update.
1113 (compare_classes): Update.
1114 (info_classes_command): Update.
1115 (find_imps): Update.
1116 * p-typeprint.c (pascal_print_typedef): Update.
1117 * printcmd.c (build_address_symbolic): Update.
1118 (info_address_command): Update.
1119 (print_variable_and_value): Update.
1120 * python/py-framefilter.c (extract_sym): Update.
1121 (py_print_single_arg): Update.
1122 * python/py-symbol.c (sympy_str): Update.
1123 (sympy_get_name): Update.
1124 (sympy_get_linkage_name): Update.
1125 * python/python.c (gdbpy_rbreak): Update.
1126 * record-btrace.c (btrace_get_bfun_name): Update.
1127 (btrace_call_history): Update.
1128 * rust-lang.c (rust_print_typedef): Update.
1129 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1130 * stabsread.c (stab_reg_to_regnum): Update.
1131 (define_symbol): Update.
1132 (read_enum_type): Update.
1133 (common_block_end): Update.
1134 (cleanup_undefined_types_1): Update.
1135 (scan_file_globals): Update.
1136 * stack.c (print_frame_arg): Update.
1137 (print_frame_args): Update.
1138 (find_frame_funname): Update.
1139 (info_frame_command_core): Update.
1140 (iterate_over_block_locals): Update.
1141 (print_block_frame_labels): Update.
1142 (do_print_variable_and_value): Update.
1143 (iterate_over_block_arg_vars): Update.
1144 (return_command): Update.
1145 * symmisc.c (dump_symtab_1): Update.
1146 (print_symbol): Update.
1147 * symtab.c (eq_symbol_entry): Update.
1148 (symbol_cache_dump): Update.
1149 (lookup_language_this): Update.
1150 (find_pc_sect_line): Update.
1151 (skip_prologue_sal): Update.
1152 (symbol_search::compare_search_syms): Update.
1153 (treg_matches_sym_type_name): Update.
1154 (search_symbols): Update.
1155 (print_symbol_info): Update.
1156 (rbreak_command): Update.
1157 (completion_list_add_symbol): Update.
1158 (find_gnu_ifunc): Update.
1159 (get_symbol_address): Update.
1160 (search_module_symbols): Update.
1161 (info_module_subcommand): Update.
1162 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1163 (SYMBOL_LINKAGE_NAME): Remove.
1164 (SYMBOL_DEMANGLED_NAME): Remove.
1165 (SYMBOL_PRINT_NAME): Remove.
1166 (SYMBOL_SEARCH_NAME): Remove.
1167 * tracepoint.c (set_traceframe_context): Update.
1168 (validate_actionline): Update.
1169 (collection_list::collect_symbol): Update.
1170 (encode_actions_1): Update.
1171 (info_scope_command): Update.
1172 (print_one_static_tracepoint_marker): Update.
1173 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1174 * valops.c (address_of_variable): Update.
1175 (find_overload_match): Update.
1176 (find_oload_champ): Update.
1177
1178 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1179
1180 * ada-lang.c (ada_lookup_simple_minsym): Update.
1181 (ada_collect_symbol_completion_matches): Update.
1182 * ada-tasks.c (read_atcb): Update.
1183 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1184 (amd64_windows_skip_trampoline_code): Update.
1185 * arm-tdep.c (skip_prologue_function): Update.
1186 (arm_skip_stack_protector): Update.
1187 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1188 (arm_wince_skip_main_prologue): Update.
1189 * ax-gdb.c (gen_expr): Update.
1190 * block.c (call_site_for_pc): Update.
1191 * blockframe.c (find_pc_partial_function): Update.
1192 * breakpoint.c (set_breakpoint_location_function): Update.
1193 * btrace.c (ftrace_print_function_name): Update.
1194 (ftrace_function_switched): Update.
1195 * c-valprint.c (print_unpacked_pointer): Update.
1196 * coffread.c (coff_symfile_read): Update.
1197 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1198 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1199 * dwarf-index-write.c (write_psymbols): Update.
1200 * dwarf2loc.c (call_site_to_target_addr): Update.
1201 (func_verify_no_selftailcall): Update.
1202 (tailcall_dump): Update.
1203 (call_site_find_chain_1): Update.
1204 (dwarf_expr_reg_to_entry_parameter): Update.
1205 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1206 * eval.c (evaluate_funcall): Update.
1207 (evaluate_subexp_standard): Update.
1208 (evaluate_subexp_for_sizeof): Update.
1209 * expprint.c (print_subexp_standard): Update.
1210 (dump_subexp_body_standard): Update.
1211 * frame.c (get_prev_frame_always_1): Update.
1212 * frv-tdep.c (frv_skip_main_prologue): Update.
1213 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1214 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1215 (gnuv3_get_typename_from_type_info): Update.
1216 (gnuv3_skip_trampoline): Update.
1217 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1218 * i386-tdep.c (i386_skip_main_prologue): Update.
1219 (i386_pe_skip_trampoline_code): Update.
1220 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1221 * infcall.c (get_function_name): Update.
1222 * linespec.c (minsym_found): Update.
1223 * linux-fork.c (info_checkpoints_command): Update.
1224 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1225 (m32c_m16c_pointer_to_address): Update.
1226 * maint.c (maintenance_translate_address): Update.
1227 * minsyms.c (add_minsym_to_hash_table): Update.
1228 (add_minsym_to_demangled_hash_table): Update.
1229 (lookup_minimal_symbol_mangled): Update.
1230 (lookup_minimal_symbol_demangled): Update.
1231 (lookup_minimal_symbol_linkage): Update.
1232 (lookup_minimal_symbol_text): Update.
1233 (lookup_minimal_symbol_by_pc_name): Update.
1234 (minimal_symbol_is_less_than): Update.
1235 (compact_minimal_symbols): Update.
1236 (build_minimal_symbol_hash_tables): Update.
1237 (find_solib_trampoline_target): Update.
1238 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1239 (mips_skip_pic_trampoline_code): Update.
1240 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1241 * objc-lang.c (info_selectors_command): Update.
1242 (info_classes_command): Update.
1243 (find_methods): Update.
1244 (find_imps): Update.
1245 * p-valprint.c (pascal_val_print): Update.
1246 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1247 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1248 * printcmd.c (build_address_symbolic): Update.
1249 (info_symbol_command): Update.
1250 * psymtab.c (psymbol_name_matches): Update.
1251 (match_partial_symbol): Update.
1252 (lookup_partial_symbol): Update.
1253 (print_partial_symbols): Update.
1254 (sort_pst_symbols): Update.
1255 (maintenance_check_psymtabs): Update.
1256 * python/py-framefilter.c (py_print_frame): Update.
1257 * python/python.c (gdbpy_rbreak): Update.
1258 * record-btrace.c (btrace_get_bfun_name): Update.
1259 (btrace_call_history): Update.
1260 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1261 (rs6000_skip_trampoline_code): Update.
1262 * sol-thread.c (info_cb): Update.
1263 * stabsread.c (scan_file_globals): Update.
1264 * stack.c (find_frame_funname): Update.
1265 (info_frame_command_core): Update.
1266 * symmisc.c (dump_msymbols): Update.
1267 * symtab.c (symbol_natural_name): Rename to..,
1268 (general_symbol_info::natural_name): ...this.
1269 (symbol_demangled_name): Rename to...
1270 (general_symbol_info::demangled_name): ...this.
1271 (symbol_search_name): Rename to...
1272 (general_symbol_info::search_name): ...this.
1273 (symbol_matches_search_name): Update.
1274 (find_pc_sect_line): Update.
1275 (skip_prologue_sal): Update.
1276 (search_symbols): Update.
1277 (print_msymbol_info): Update.
1278 (rbreak_command): Update.
1279 (completion_list_add_msymbol): Update.
1280 (completion_list_objc_symbol): Update.
1281 (get_msymbol_address): Update.
1282 * symtab.h (struct general_symbol_info): Add member functions
1283 natural_name (), linkage_name (), print_name (), demangled_name (),
1284 and search_name ().
1285 (SYMBOL_NATURAL_NAME): Update.
1286 (symbol_natural_name): Move to a member function on general_symbol_info.
1287 (SYMBOL_DEMANGLED_NAME): Update.
1288 (symbol_demangled_name): Move to a member function on
1289 general_symbol_info.
1290 (SYMBOL_SEARCH_NAME): Update.
1291 (symbol_search_name): Move to a member function on general_symbol_info.
1292 (MSYMBOL_NATURAL_NAME): Remove.
1293 (MSYMBOL_LINKAGE_NAME): Remove.
1294 (MSYMBOL_PRINT_NAME): Remove.
1295 (MSYMBOL_DEMANGLED_NAME): Remove.
1296 (MSYMBOL_SEARCH_NAME): Remove.
1297 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1298
1299 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1300
1301 * symtab.c (create_demangled_names_hash): Use per_bfd->
1302 minimal_symbol_count for computing the initial size, if greater
1303 than our default size.
1304
1305 2019-11-22 Tom de Vries <tdevries@suse.de>
1306
1307 * contrib/words.sh: Improve words extraction.
1308
1309 2019-11-22 Tom de Vries <tdevries@suse.de>
1310
1311 * contrib/words.sh: Combine sed invocations.
1312
1313 2019-11-21 Christian Biesinger <cbiesinger@google.com>
1314
1315 * Makefile.in: Update.
1316 * demangle.c: Rename to...
1317 * gdb-demangle.c: ..this.
1318 (is_cplus_marker): Change return type to bool.
1319 (_initialize_demangler): Rename to...
1320 (_initialize_gdb_demangle): ...this.
1321 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1322 * symtab.h (demangle): Remove declaration; instead include
1323 gdb-demangle.h.
1324
1325 2019-11-21 Tom Tromey <tromey@adacore.com>
1326
1327 * gdbsupport/format.c (format_pieces): Parse %I64d.
1328 * unittests/format_pieces-selftests.c (test_windows_formats): New
1329 function.
1330 (run_tests): Call it.
1331
1332 2019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1333
1334 Byte reverse display of variables with DW_END_big, DW_END_little
1335 (DW_AT_endianity) dwarf attributes if different than the native
1336 byte order.
1337 * ada-lang.c (ada_value_binop):
1338 Use type_byte_order instead of gdbarch_byte_order.
1339 * ada-valprint.c (printstr):
1340 (ada_val_print_string):
1341 * ada-lang.c (value_pointer):
1342 (ada_value_binop):
1343 Use type_byte_order instead of gdbarch_byte_order.
1344 * c-lang.c (c_get_string):
1345 Use type_byte_order instead of gdbarch_byte_order.
1346 * c-valprint.c (c_val_print_array):
1347 Use type_byte_order instead of gdbarch_byte_order.
1348 * cp-valprint.c (cp_print_class_member):
1349 Use type_byte_order instead of gdbarch_byte_order.
1350 * dwarf2loc.c (rw_pieced_value):
1351 Use type_byte_order instead of gdbarch_byte_order.
1352 * dwarf2read.c (read_base_type): Handle DW_END_big,
1353 DW_END_little
1354 * f-lang.c (f_get_encoding):
1355 Use type_byte_order instead of gdbarch_byte_order.
1356 * findvar.c (default_read_var_value):
1357 Use type_byte_order instead of gdbarch_byte_order.
1358 * gdbtypes.c (check_types_equal):
1359 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1360 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1361 and TYPE_ENDIANITY_LITTLE if set.
1362 (type_byte_order): new function.
1363 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1364 (struct main_type) <flag_endianity_not_default>:
1365 New field.
1366 (type_byte_order): New function.
1367 * infcmd.c (default_print_one_register_info):
1368 Use type_byte_order instead of gdbarch_byte_order.
1369 * p-lang.c (pascal_printstr):
1370 Use type_byte_order instead of gdbarch_byte_order.
1371 * p-valprint.c (pascal_val_print):
1372 Use type_byte_order instead of gdbarch_byte_order.
1373 * printcmd.c (print_scalar_formatted):
1374 Use type_byte_order instead of gdbarch_byte_order.
1375 * solib-darwin.c (darwin_current_sos):
1376 Use type_byte_order instead of gdbarch_byte_order.
1377 * solib-svr4.c (solib_svr4_r_ldsomap):
1378 Use type_byte_order instead of gdbarch_byte_order.
1379 * stap-probe.c (stap_modify_semaphore):
1380 Use type_byte_order instead of gdbarch_byte_order.
1381 * target-float.c (target_float_same_format_p):
1382 Use type_byte_order instead of gdbarch_byte_order.
1383 * valarith.c (scalar_binop):
1384 (value_bit_index):
1385 Use type_byte_order instead of gdbarch_byte_order.
1386 * valops.c (value_cast):
1387 Use type_byte_order instead of gdbarch_byte_order.
1388 * valprint.c (generic_emit_char):
1389 (generic_printstr):
1390 (val_print_string):
1391 Use type_byte_order instead of gdbarch_byte_order.
1392 * value.c (unpack_long):
1393 (unpack_bits_as_long):
1394 (unpack_value_bitfield):
1395 (modify_field):
1396 (pack_long):
1397 (pack_unsigned_long):
1398 Use type_byte_order instead of gdbarch_byte_order.
1399 * findvar.c (unsigned_pointer_to_address):
1400 (signed_pointer_to_address):
1401 (unsigned_address_to_pointer):
1402 (address_to_signed_pointer):
1403 (default_read_var_value):
1404 (default_value_from_register):
1405 Use type_byte_order instead of gdbarch_byte_order.
1406 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1407 Use type_byte_order instead of gdbarch_byte_order.
1408 * riscv-tdep.c (riscv_print_one_register_info):
1409 Use type_byte_order instead of gdbarch_byte_order.
1410
1411 2019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1412
1413 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1414 (current_ui_gdb_stdin_ptr): Likewise.
1415 (current_ui_gdb_stderr_ptr): Likewise.
1416 (current_ui_gdb_stdlog_ptr): Likewise.
1417 (current_ui_current_uiout_ptr): Likewise.
1418 (gen_ret_current_ui_field_ptr): Remove.
1419
1420 2019-11-21 Tom de Vries <tdevries@suse.de>
1421
1422 PR gdb/24956
1423 * cli/cli-script.c (execute_control_command): Only switch to
1424 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1425
1426 2019-11-19 Tom Tromey <tom@tromey.com>
1427
1428 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1429 Now static. Change type of "name".
1430 (tui_set_win_height_command): Don't copy "arg".
1431 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1432 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1433
1434 2019-11-19 Ali Tamur <tamur@google.com>
1435
1436 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1437 "if (attr != nullptr)".
1438 (dwarf2_find_base_address): Likewise.
1439 (dwarf2_build_include_psymtabs): Likewise.
1440 (read_cutu_die_from_dwo): Likewise.
1441 (read_func_scope): Likewise.
1442 (read_call_site_scope): Likewise.
1443 (dwarf2_get_pc_bounds): Likewise.
1444 (dwarf2_record_block_ranges): Likewise.
1445 (dwarf2_add_field): Likewise.
1446 (dwarf2_add_member_fn): Likewise.
1447 (read_structure_type): Likewise.
1448 (read_enumeration_type): Likewise.
1449 (read_array_type): Likewise.
1450 (read_array_order): Likewise.
1451 (read_set_type): Likewise.
1452 (read_common_block): Likewise.
1453 (read_tag_reference_type): Likewise.
1454 (read_tag_string_type): Likewise.
1455 (read_subroutine_type): Likewise.
1456 (read_base_type): Likewise.
1457 (read_subrange_type): Likewise.
1458 (new_symbol): Likewise.
1459 (prepare_one_comp_unit): Likewise.
1460
1461 2019-11-19 Tom Tromey <tromey@adacore.com>
1462
1463 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1464 result in error when DebugActiveProcess fails.
1465
1466 2019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1467 Pedro Alves <palves@redhat.com>
1468
1469 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1470 * target.c (target_stack::push): Call 'unpush' if there's a
1471 target on top of the stack.
1472
1473 2019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1474
1475 * python/py-block.c (blpy_dealloc): Call tp_free.
1476 (blpy_block_syms_dealloc): Likewise.
1477 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1478 * python/py-inferior.c (infpy_dealloc): Likewise.
1479 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1480 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1481 * python/py-symbol.c (sympy_dealloc): Likewise.
1482 * python/py-symtab.c (stpy_dealloc): Likewise.
1483 * python/py-type.c (typy_iterator_dealloc): Likewise.
1484
1485 2019-11-18 Christian Biesinger <cbiesinger@google.com>
1486
1487 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1488 constructor instead of using a class initializer.
1489
1490 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1491
1492 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1493 * configure: Regenerate.
1494 * configure.ac: Don't source common.host.
1495 * gdbsupport/common.host: Remove.
1496 * gdbsupport/mingw-strerror.c: Remove.
1497 * gdbsupport/posix-strerror.c: Rename to...
1498 * gdbsupport/safe-strerror.c: ...this.
1499
1500 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1501
1502 * maint.c (scoped_command_stats::print_time): Use localtime_r
1503 instead of localtime (provided through gnulib if necessary).
1504 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1505 of ctime.
1506
1507 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1508
1509 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1510 avoid compile errors.
1511
1512 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1513
1514 * config.in: Regenerate.
1515 * configure: Regenerate.
1516 * gdbsupport/common.m4: No longer check for strerror_r.
1517 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1518 POSIX version of strerror_r, now that gnulib provides it if
1519 necessary.
1520
1521 2019-11-14 Christian Biesinger <cbiesinger@google.com>
1522
1523 * README (`configure' options): Update.
1524
1525 2019-11-14 Tom Tromey <tromey@adacore.com>
1526
1527 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1528 expected type for the RHS if the LHS is a convenience variable.
1529
1530 2019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1531
1532 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1533 Provide explicit default and copy constructor.
1534
1535 2019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1536
1537 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1538 only call Py_INCREF (newbp) in the bppy_pending_object case.
1539
1540 2019-11-13 Tom Tromey <tromey@adacore.com>
1541
1542 PR build/25182:
1543 * psympriv.h (partial_symbol): Remove static assert.
1544 * symtab.h (general_symbol_info, symbol): Remove static assert.
1545
1546 2019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1547
1548 * gdbsupport/format.c (format_pieces::format_pieces): Support
1549 printf 'z' size modifier.
1550 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1551 * printcmd.c (ui_printf): Handle size_t_arg.
1552 * ui-out.c (ui_out::vmessage): Likewise.
1553 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1554 function.
1555 (run_tests): Call test_format_int_sizes.
1556
1557 2019-11-12 Christian Biesinger <cbiesinger@google.com>
1558
1559 * ada-exp.y (write_ambiguous_var): Update.
1560 * buildsym.c (add_symbol_to_list): Update.
1561 * dwarf2read.c (read_variable): Update.
1562 (new_symbol): Update.
1563 * jit.c (finalize_symtab): Update.
1564 * language.c (language_alloc_type_symbol): Update.
1565 * symtab.c (fixup_symbol_section): Update.
1566 (initialize_objfile_symbol_1): Move code to...
1567 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1568 (allocate_symbol): Update.
1569 (allocate_template_symbol): Update.
1570 (get_symbol_address): Update.
1571 * symtab.h (struct symbol): Inherit from general_symbol_info instead
1572 of having as a field, and add a constructor.
1573 (SYMBOL_VALUE): Update.
1574 (SYMBOL_VALUE_ADDRESS): Update.
1575 (SET_SYMBOL_VALUE_ADDRESS): Update.
1576 (SYMBOL_VALUE_BYTES): Update.
1577 (SYMBOL_VALUE_COMMON_BLOCK): Update.
1578 (SYMBOL_BLOCK_VALUE): Update.
1579 (SYMBOL_VALUE_CHAIN): Update.
1580 (SYMBOL_LANGUAGE): Update.
1581 (SYMBOL_SECTION): Update.
1582 (SYMBOL_OBJ_SECTION): Update.
1583 (SYMBOL_SET_LANGUAGE): Update.
1584 (SYMBOL_SET_LINKAGE_NAME): Update.
1585 (SYMBOL_SET_NAMES): Update.
1586 (SYMBOL_NATURAL_NAME): Update.
1587 (SYMBOL_LINKAGE_NAME): Update.
1588 (SYMBOL_DEMANGLED_NAME): Update.
1589 (SYMBOL_SEARCH_NAME): Update.
1590 (SYMBOL_MATCHES_SEARCH_NAME): Update.
1591 (struct symbol): Update.
1592 (struct template_symbol): Update.
1593 (struct rust_vtable_symbol): Update.
1594 * xcoffread.c (SYMBOL_DUP): Update.
1595
1596 2019-11-12 Tom Tromey <tom@tromey.com>
1597
1598 * tui/tui-layout.c (show_layout): Set current_layout.
1599 (show_source_disasm_command, show_data)
1600 (show_source_or_disasm_and_command): Don't set current_layout.
1601
1602 2019-11-12 Tom Tromey <tom@tromey.com>
1603
1604 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1605
1606 2019-11-12 Tom Tromey <tom@tromey.com>
1607
1608 * tui/tui-win.c (resize_message): New global.
1609 (show_tui_resize_message): New function.
1610 (tui_async_resize_screen): Print message if requested.
1611 (_initialize_tui_win): Add tui-resize-message setting.
1612 * NEWS: Add entry for new commands.
1613
1614 2019-11-11 Tom Tromey <tom@tromey.com>
1615
1616 * tui/tui.c (tui_initialize_readline): Add new bindable readline
1617 functions.
1618
1619 2019-11-11 Christian Biesinger <cbiesinger@google.com>
1620
1621 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1622
1623 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1624
1625 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1626 function.
1627 * python/python-internal.h (gdbpy_lookup_static_symbols):
1628 Declare new function.
1629 * python/python.c (python_GdbMethods): Add
1630 gdb.lookup_static_symbols method.
1631 * NEWS: Mention gdb.lookup_static_symbols.
1632
1633 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1634
1635 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1636 static block of current object file first. Also fix typo in
1637 header comment.
1638
1639 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1640
1641 * stack.c (set_last_displayed_sal): Delete.
1642 (last_displayed_sal_valid): Delete.
1643 (last_displayed_pspace): Delete.
1644 (last_displayed_addr): Delete.
1645 (last_displayed_symtab): Delete.
1646 (last_displayed_line): Delete.
1647 (class last_displayed_symtab_info_type): New.
1648 (last_displayed_symtab_info): New static global variable.
1649 (print_frame_info): Call methods on last_displayed_symtab_info.
1650 (clear_last_displayed_sal): Update header comment, and make use of
1651 last_displayed_symtab_info.
1652 (last_displayed_sal_is_valid): Likewise.
1653 (get_last_displayed_pspace): Likewise.
1654 (get_last_displayed_addr): Likewise.
1655 (get_last_displayed_symtab): Likewise.
1656 (get_last_displayed_line): Likewise.
1657 (get_last_displayed_sal): Likewise.
1658 * stack.h (clear_last_displayed_sal): Update header comment.
1659 (last_displayed_sal_is_valid): Likewise.
1660 (get_last_displayed_pspace): Likewise.
1661 (get_last_displayed_addr): Likewise.
1662 (get_last_displayed_symtab): Likewise.
1663 (get_last_displayed_line): Likewise.
1664 (get_last_displayed_sal): Likewise.
1665
1666 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1667
1668 * stack.c (frame_show_address): Convert return type to bool.
1669 * stack.h (frame_show_address): Likewise, and update header
1670 comment.
1671
1672 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1673
1674 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1675 * unittests/vec-utils-selftests.c: New file.
1676 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1677
1678 2019-11-10 Tom Tromey <tom@tromey.com>
1679
1680 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1681 (tui_highlight_win): Likewise.
1682 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1683 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1684 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1685 Don't set can_highlight.
1686
1687 2019-11-10 Tom Tromey <tom@tromey.com>
1688
1689 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1690 Remove unused declaration.
1691
1692 2019-11-08 Tom Tromey <tromey@adacore.com>
1693
1694 * top.c (read_command_file): Update.
1695 (command_line_input): Make return type const.
1696 * python/py-gdb-readline.c: Update.
1697 * linespec.c (decode_line_2): Update.
1698 * defs.h (command_line_input): Make return type const.
1699 * cli/cli-script.c (read_next_line): Make return type const.
1700 * ada-lang.c (get_selections): Update.
1701
1702 2019-11-06 Christian Biesinger <cbiesinger@google.com>
1703
1704 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1705 * mi/mi-main.c (output_cores): Likewise.
1706 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1707 (linux_xfer_osdata_modules): Likewise.
1708 * remote.c (register_remote_support_xml): Likewise.
1709 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1710 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1711
1712 2019-11-06 Tom Tromey <tom@tromey.com>
1713
1714 * tui/tui-interp.c: Don't include readline.h.
1715 * tui/tui-hooks.c: Don't include readline.h.
1716 * symmisc.c: Include tilde.h, not readline.h.
1717 * symfile.c: Include tilde.h, not readline.h.
1718 * source.c: Include tilde.h, not readline.h.
1719 * solib.c: Include tilde.h, not readline.h.
1720 * psymtab.c: Include tilde.h, not readline.h.
1721 * exec.c: Include tilde.h, not readline.h.
1722 * corelow.c: Include tilde.h, not readline.h.
1723 * cli/cli-dump.c: Include tilde.h, not readline.h.
1724 * cli/cli-cmds.c: Don't include readline.h.
1725
1726 2019-11-05 Tom Tromey <tom@tromey.com>
1727
1728 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1729 (tui_disassemble): Set addr_size.
1730 (tui_disasm_window::set_contents): Use addr_size.
1731
1732 2019-11-05 Tom Tromey <tom@tromey.com>
1733
1734 * rust-lang.c (rust_language_defn): Update.
1735 * python/py-value.c (valpy_string): Call c_get_string.
1736 * p-lang.c (pascal_language_defn): Update.
1737 * opencl-lang.c (opencl_language_defn): Update.
1738 * objc-lang.c (objc_language_defn): Update.
1739 * m2-lang.c (m2_language_defn): Update.
1740 * language.c (unknown_language_defn, auto_language_defn): Update.
1741 (default_get_string): Remove.
1742 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1743 * go-lang.c (go_language_defn): Update.
1744 * f-lang.c (f_language_defn): Update.
1745 * d-lang.c (d_language_defn): Update.
1746 * c-lang.c (c_language_defn, cplus_language_defn)
1747 (asm_language_defn, minimal_language_defn): Update.
1748 * ada-lang.c (ada_language_defn): Update.
1749 * language.h (struct language_defn) <la_get_string>: Remove.
1750 (LA_GET_STRING): Remove.
1751 (default_get_string): Don't declare.
1752
1753 2019-11-05 Tom Tromey <tom@tromey.com>
1754
1755 * tui/tui-source.h (struct tui_source_window): Inline
1756 constructor. Remove destructor.
1757 <style_changed, m_observable>: Move to superclass.
1758 * tui/tui-winsource.h (tui_copy_source_line): Declare.
1759 (struct tui_source_window_base): Move private members to end.
1760 <style_changed, m_observable>: Move from tui_source_window.
1761 * tui/tui-winsource.c (tui_copy_source_line): Move from
1762 tui-source.c. Rename from copy_source_line. Add special handling
1763 for negative line number.
1764 (tui_source_window_base::style_changed): Move from
1765 tui_source_window.
1766 (tui_source_window_base): Register observer.
1767 (~tui_source_window_base): New.
1768 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1769 rename.
1770 (tui_source_window::set_contents): Use tui_copy_source_line.
1771 (tui_source_window::tui_source_window): Move to tui-source.h.
1772 (tui_source_window::~tui_source_window): Remove.
1773 (tui_source_window::style_changed): Move to superclass.
1774 * tui/tui-disasm.c (tui_disassemble): Create string file with
1775 styling, when possible. Add "addr_size" parameter.
1776 (tui_disasm_window::set_contents): Use tui_copy_source_line.
1777 Don't compute maximum size.
1778 (len_without_escapes): New function
1779
1780 2019-11-05 Tom Tromey <tom@tromey.com>
1781
1782 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1783 std::string.
1784 * tui/tui-winsource.c (tui_show_source_line): Update.
1785 * tui/tui-source.c (tui_source_window::set_contents): Update.
1786 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1787
1788 2019-11-05 Christian Biesinger <cbiesinger@google.com>
1789
1790 * symtab.h (gdb_static_assert): Put && operator at the beginning
1791 of the line instead of the end.
1792
1793 2019-11-04 Christian Biesinger <cbiesinger@google.com>
1794
1795 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1796 and sizeof (symbol).
1797 * symtab.h: Add a static_assert for sizeof (partial_symbol).
1798
1799 2019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
1800
1801 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1802 * configure.host: Mark *-*-solaris2.10* obsolete.
1803 * configure.tgt: Mark Solaris < 11 obsolete.
1804 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1805 Update target triplet.
1806
1807 2019-11-01 Tom Tromey <tromey@adacore.com>
1808
1809 * utils.c (print_sys_errmsg): Simplify.
1810
1811 2019-11-01 Tom Tromey <tromey@adacore.com>
1812
1813 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1814
1815 2019-11-01 Christian Biesinger <cbiesinger@google.com>
1816
1817 * configure: Regenerate.
1818 * configure.ac: Remove check for strerror_r.
1819 * gdbsupport/common.m4: Check for strerror_r.
1820
1821 2019-11-01 Luis Machado <luis.machado@linaro.org>
1822
1823 PR gdb/25124
1824
1825 * arm-tdep.c (arm_per_objfile): Rename to ...
1826 (arm_per_bfd): ... this.
1827 (arm_objfile_data_key): Rename to ...
1828 (arm_bfd_data_key): ... this.
1829 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1830 data.
1831 (arm_record_special_symbol): Likewise.
1832
1833 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1834
1835 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1836 end.
1837 * c-typeprint.c (c_print_typedef): Likewise.
1838 * f-typeprint.c (f_print_typedef): Likewise.
1839 * m2-typeprint.c (m2_print_typedef): Likewise.
1840 * p-typeprint.c (pascal_print_typedef): Likewise.
1841 * rust-lang.c (rust_print_typedef): Likewise.
1842 * symtab.c (print_symbol_info): Print a newline after calling
1843 typedef_print.
1844
1845 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1846
1847 * symtab.c (info_module_cmdlist): New variable.
1848 (info_module_command): New function.
1849 (search_module_symbols): New function.
1850 (info_module_subcommand): New function.
1851 (struct info_modules_var_func_options): New struct.
1852 (info_modules_var_func_options_defs): New variable.
1853 (make_info_modules_var_func_options_def_group): New function.
1854 (info_module_functions_command): New function.
1855 (info_module_variables_command): New function.
1856 (info_module_var_func_command_completer): New function.
1857 (_initialize_symtab): Register new 'info module functions' and
1858 'info module variables' commands.
1859 * symtab.h (typedef symbol_search_in_module): New typedef.
1860 (search_module_symbols): Declare new function.
1861 * NEWS: Mention new commands.
1862
1863 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1864
1865 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1866 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1867 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1868 MODULES_DOMAIN.
1869 (scan_partial_symbols): Only create partial module symbols for non
1870 declarations.
1871 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1872 and MODULES_DOMAIN.
1873 * symtab.c (search_domain_name): Likewise.
1874 (search_symbols): Likewise.
1875 (print_symbol_info): Likewise.
1876 (symtab_symbol_info): Likewise.
1877 (info_modules_command): New function.
1878 (_initialize_symtab): Register 'info modules' command.
1879 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1880 * NEWS: Mention new 'info modules' command.
1881
1882 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1883
1884 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1885 and $_gdb_maint_setting_str.
1886
1887 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1888
1889 * cli/cli-cmds.c (setting_cmd, value_from_setting)
1890 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1891 (str_value_from_setting, gdb_setting_str_internal_fn)
1892 (gdb_maint_setting_str_internal_fn): New functions.
1893 (_initialize_cli_cmds): Define the new convenience functions.
1894 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1895 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1896
1897 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1898
1899 * agent.c (set_can_use_agent): When the setting is turned on,
1900 look up agent symbols if we don't have them yet.
1901 (agent_new_objfile): Don't look up agent symbols when the agent
1902 setting is off.
1903
1904 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1905
1906 * config.in: Regenerate.
1907
1908 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1909
1910 * configure: Regenerate.
1911 * configure.ac: Check for strerror_r.
1912 * gdbsupport/common-utils.h (safe_strerror): Change return value
1913 to const char * and document that this function is now threadsafe.
1914 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
1915 thread_local and call strerror_r, if available.
1916 * utils.c (perror_string): Update.
1917 (print_sys_errmsg): Update.
1918
1919 2019-10-31 Luis Machado <luis.machado@linaro.org>
1920
1921 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
1922 objfile_key.
1923 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
1924 objfile to fetch per-bfd data.
1925 (arm_find_exidx_entry): Likewise.
1926
1927 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1928
1929 * gdbsupport/agent.c (debug_agent): Change type to bool.
1930 (use_agent): Likewise.
1931 (all_agent_symbols_look_up): Likewise.
1932 (agent_loaded_p): Change return value to bool.
1933 (agent_look_up_symbols): Update.
1934 (agent_capability_check): Change return value to bool.
1935 * gdbsupport/agent.h (agent_loaded_p): Likewise.
1936 (debug_agent): Change type to bool.
1937 (use_agent): Likewise.
1938 (agent_capability_check): Change return value to bool.
1939
1940 2019-10-30 Christian Biesinger <cbiesinger@google.com>
1941
1942 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
1943 (build_minimal_symbol_hash_tables): Code to clear the table moved
1944 to clear_minimal_symbol_hash_tables.
1945 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
1946 when needed.
1947
1948 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
1949
1950 * infcmd.c: Remove includes.
1951 * infrun.c: Remove includes.
1952
1953 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
1954
1955 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
1956 (grow_vect): Remove declaration.
1957 (ada_type_of_array): Remove declaration.
1958 (ada_update_initial_language): Remove declaration.
1959 (ada_fold_name): Remove declaration.
1960 (ada_fill_in_ada_prototype): Remove declaration.
1961 (user_select_syms): Remove declaration.
1962 (get_selections): Remove declaration.
1963 (ada_tag_type): Remove declaration.
1964 (ada_value_tag): Remove declaration.
1965 (ada_is_others_clause): Remove declaration.
1966 (ada_in_variant): Remove declaration.
1967 (ada_value_struct_elt): Remove declaration.
1968 (ada_attribute_name): Remove declaration.
1969 (ada_system_address_type): Remove declaration.
1970 * ada-lang.c (ada_watch_location_expression): Make static.
1971 (GROW_VECT): Move here from ada-lang.h.
1972 (grow_vect): Make static.
1973 (ada_update_initial_language): Make static.
1974 (ada_fold_name): Make static.
1975 (ada_type_of_array): Make static.
1976 (encoded_ordered_before): Move up.
1977 (sort_choices): Move up.
1978 (print_signatures): Move up.
1979 (ada_print_symbol_signature): Move up.
1980 (get_selections): Move up and make static.
1981 (user_select_syms): Move up and make static.
1982 (ada_value_struct_elt): Move up and make static.
1983 (ada_tag_type): Make static.
1984 (ada_value_tag): Make static.
1985 (ada_is_others_clause): Make static.
1986 (ada_in_variant): Make static.
1987 (ada_attribute_name): Make static.
1988
1989 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
1990
1991 * ada-lang.c: Remove includes.
1992 * ada-typeprint.c: Remove includes.
1993 * ada-valprint.c: Remove includes.
1994
1995 2019-10-29 Simon Marchi <simon.marchi@efficios.com>
1996
1997 * addrmap.c: Add static assertions of type size, moved from
1998 _initialize_addrmap.
1999 (_initialize_addrmap): Remove.
2000
2001 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2002
2003 * coffread.c (record_minimal_symbol): Update.
2004 (process_coff_symbol): Update.
2005 * dbxread.c (read_dbx_symtab): Update.
2006 * dwarf2read.c (add_partial_symbol): Update.
2007 (fixup_go_packaging): Update.
2008 (load_partial_dies): Update.
2009 (new_symbol): Update.
2010 * elfread.c (record_minimal_symbol): Change signature to use
2011 gdb::string_view instead of name+len.
2012 (elf_symtab_read): Update.
2013 (elf_rel_plt_read): Update.
2014 * mdebugread.c (parse_partial_symbols): Update.
2015 (handle_psymbol_enumerators): Update.
2016 (new_symbol): Update.
2017 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2018 to use gdb::string_view instead of name+len.
2019 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2020 * psympriv.h (add_psymbol_to_list): Likewise.
2021 * psymtab.c (add_psymbol_to_bcache): Likewise.
2022 (add_psymbol_to_list): Likewise.
2023 * stabsread.c (define_symbol): Update.
2024 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2025 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2026 (symbol_set_names): Likewise.
2027 * xcoffread.c (scan_xcoff_symtab): Update.
2028
2029 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2030
2031 * symtab.h (symbol_set_names): Document that copy_name must be
2032 set to true for non-nullterminated strings.
2033 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2034 linkage_name if the entry was not found and we need to demangle.
2035
2036 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2037
2038 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2039 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2040 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2041 * gdbsupport/gdb_binary_search.h: New file.
2042
2043 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2044
2045 * NEWS: Mention new --with-system-gdbinit-dir option.
2046 * config.in: Regenerate.
2047 * configure: Regenerate.
2048 * configure.ac: Add new option --with-system-gdbinit-dir.
2049 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2050 for a ".gdb" suffix.
2051 * main.c (get_init_files): Change system_gdbinit argument to
2052 a vector and return the files in SYSTEM_GDBINIT_DIR in
2053 addition to SYSTEM_GDBINIT.
2054 (captured_main_1): Update.
2055 (print_gdb_help): Update.
2056 * top.c (print_gdb_configuration): Also print the value of
2057 SYSTEM_GDBINIT_DIR.
2058
2059 2019-10-28 Christian Biesinger <cbiesinger@google.com>
2060
2061 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2062 that takes gdb::string_view arguments.
2063
2064 2019-10-26 Tom de Vries <tdevries@suse.de>
2065
2066 * aarch64-linux-tdep.c: Fix typos in comments.
2067 * aarch64-tdep.c: Same.
2068 * ada-lang.c: Same.
2069 * amd64-nat.c: Same.
2070 * arc-tdep.c: Same.
2071 * arch/aarch64-insn.c: Same.
2072 * block.c: Same.
2073 * breakpoint.h: Same.
2074 * btrace.h: Same.
2075 * c-varobj.c: Same.
2076 * cli/cli-decode.c: Same.
2077 * cli/cli-script.c: Same.
2078 * cli/cli-utils.h: Same.
2079 * coff-pe-read.c: Same.
2080 * coffread.c: Same.
2081 * compile/compile-cplus-symbols.c: Same.
2082 * compile/compile-object-run.c: Same.
2083 * completer.c: Same.
2084 * corelow.c: Same.
2085 * cp-support.c: Same.
2086 * demangle.c: Same.
2087 * dwarf-index-write.c: Same.
2088 * dwarf2-frame.c: Same.
2089 * dwarf2-frame.h: Same.
2090 * eval.c: Same.
2091 * frame-base.h: Same.
2092 * frame.h: Same.
2093 * gdbcmd.h: Same.
2094 * gdbtypes.h: Same.
2095 * gnu-nat.c: Same.
2096 * guile/scm-objfile.c: Same.
2097 * i386-tdep.c: Same.
2098 * i386-tdep.h: Same.
2099 * infcall.c: Same.
2100 * infcall.h: Same.
2101 * linux-nat.c: Same.
2102 * m68k-tdep.c: Same.
2103 * macroexp.c: Same.
2104 * memattr.c: Same.
2105 * mi/mi-cmd-disas.c: Same.
2106 * mi/mi-getopt.h: Same.
2107 * mi/mi-main.c: Same.
2108 * minsyms.c: Same.
2109 * nat/aarch64-sve-linux-sigcontext.h: Same.
2110 * objfiles.h: Same.
2111 * ppc-linux-nat.c: Same.
2112 * ppc-linux-tdep.c: Same.
2113 * ppc-tdep.h: Same.
2114 * progspace.h: Same.
2115 * prologue-value.h: Same.
2116 * python/py-evtregistry.c: Same.
2117 * python/py-instruction.h: Same.
2118 * record-btrace.c: Same.
2119 * record-full.c: Same.
2120 * remote.c: Same.
2121 * rs6000-tdep.c: Same.
2122 * ser-tcp.c: Same.
2123 * sol-thread.c: Same.
2124 * sparc-sol2-tdep.c: Same.
2125 * sparc64-tdep.c: Same.
2126 * stabsread.c: Same.
2127 * symfile.c: Same.
2128 * symtab.h: Same.
2129 * target.c: Same.
2130 * tracepoint.c: Same.
2131 * tui/tui-data.h: Same.
2132 * tui/tui-io.c: Same.
2133 * tui/tui-win.c: Same.
2134 * tui/tui.c: Same.
2135 * unittests/rsp-low-selftests.c: Same.
2136 * user-regs.h: Same.
2137 * utils.c: Same.
2138 * utils.h: Same.
2139 * valarith.c: Same.
2140 * valops.c: Same.
2141 * valprint.c: Same.
2142 * valprint.h: Same.
2143 * value.c: Same.
2144 * value.h: Same.
2145 * varobj.c: Same.
2146 * x86-nat.h: Same.
2147 * xtensa-tdep.c: Same.
2148
2149 2019-10-25 Ali Tamur <tamur@google.com>
2150
2151 * charset.c (find_charset_names): Reflect API change.
2152
2153 2019-10-25 Christian Biesinger <cbiesinger@google.com>
2154
2155 * symtab.c (struct demangled_name_entry): Change demangled name
2156 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2157 part of the struct anymore.
2158 (symbol_set_names): No longer obstack allocate + copy the demangled
2159 name, just store the allocated name from bfd.
2160
2161 2019-10-25 Tom Tromey <tromey@adacore.com>
2162
2163 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2164 (bsearch_cie_cmp, add_cie): Remove.
2165 (find_cie): Reimplement.
2166 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2167 (dwarf2_build_frame_info): Update.
2168
2169 2019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2170
2171 PR gdb/25126
2172 * symfile.c (reread_symbols): Call forget_cached_source_info to
2173 clear the stale source cache.
2174
2175 2019-10-24 Christian Biesinger <cbiesinger@google.com>
2176
2177 * configure: Regenerate.
2178 * configure.ac: Remove code that sets python_has_threads.
2179
2180 2019-10-24 Christian Biesinger <cbiesinger@google.com>
2181
2182 * config.in: Regenerate.
2183 * configure: Regenerate.
2184 * configure.ac: Remove the code that uses sed to get the python
2185 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2186
2187 2019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2188
2189 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2190 error paths.
2191
2192 2019-10-23 Tom Tromey <tom@tromey.com>
2193
2194 * arc-tdep.c: Remove ".." from include.
2195 * frv-tdep.c: Remove ".." from include.
2196 * lm32-tdep.c: Remove ".." from include.
2197 * microblaze-tdep.c: Remove ".." from include.
2198 * or1k-tdep.h: Remove ".." from include.
2199 * s12z-tdep.c: Remove ".." from include.
2200 * Makefile.in (OPCODES_CFLAGS): Add comment.
2201 (TOP_CFLAGS): New variable.
2202 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2203
2204 2019-10-23 Tom Tromey <tom@tromey.com>
2205
2206 * Makefile.in (READLINE_DIR): Update.
2207
2208 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2209
2210 * infcall.c (call_function_by_hand_dummy): Fix the function
2211 comment. And extract out a code section into...
2212 (reserve_stack_space): ...this new function.
2213
2214 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2215
2216 * infcall.c (value_arg_coerce): Remove an unused parameter.
2217 (call_function_by_hand_dummy): Update the call to
2218 'value_arg_coerce'.
2219
2220 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2221
2222 * infcall.c (call_function_by_hand_dummy): Refactor.
2223
2224 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2225
2226 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2227
2228 2019-10-23 Tom Tromey <tom@tromey.com>
2229
2230 * configure: Rebuild.
2231 * configure.ac: Don't check for sigprocmask.
2232 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2233
2234 2019-10-23 Tom Tromey <tom@tromey.com>
2235
2236 * configure: Rebuild.
2237 * acinclude.m4: Use m4_include, not sinclude.
2238
2239 2019-10-23 Tom de Vries <tdevries@suse.de>
2240
2241 PR breakpoints/24687
2242 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2243
2244 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2245
2246 * symtab.c (struct demangled_name_entry) <language>: Change from
2247 bitfield to regular variable.
2248
2249 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2250
2251 * symtab.c (struct demangled_name_entry): Add a constructor.
2252 (free_demangled_name_entry): New function to call the destructor
2253 for demangled_name_entry.
2254 (create_demangled_names_hash): Pass free_demangled_name_entry to
2255 htab_create_alloc.
2256 (symbol_set_names): Call placement new for demangled_name_entry.
2257 * utils.c: No longer include xxhash.h here, now that fast_hash
2258 is inlined in the header.
2259 * utils.h: Instead, include it here.
2260
2261 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2262
2263 * Makefile.in: Link with libxxhash.
2264 * config.in: Regenerate.
2265 * configure: Regenerate.
2266 * configure.ac: Search for libxxhash.
2267 * utils.c (fast_hash): Use xxhash if present.
2268
2269 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2270
2271 * utils.h (fast_hash): New function.
2272 * symtab.c (hash_demangled_name_entry): Call new function
2273 fast_hash.
2274
2275 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2276
2277 * symtab.c (struct demangled_name_entry): Change type of mangled
2278 to gdb::string_view. Also adds a constructor that takes the
2279 mangled name.
2280 (hash_demangled_name_entry): Update.
2281 (eq_demangled_name_entry): Update.
2282 (free_demangled_name_entry): New function to call the destructor
2283 now that this is not a POD anymore.
2284 (create_demangled_names_hash): Pass free_demangled_name_entry to
2285 htab_create_alloc.
2286 (symbol_set_names): Update.
2287
2288 2019-10-21 Ali Tamur <tamu@google.com>
2289
2290 * dwarf2read.c (dir_index): Change type.
2291 (file_name_index): Likewise.
2292 (line_header::include_dir_at): Change comment and implementation on
2293 whether it is DWARF 5.
2294 (line_header::is_valid_file_index): New function.
2295 (line_header::file_name_at): Change comment and implementation on
2296 whether it is DWARF 5.
2297 (line_header::file_names): Change to private field renamed as
2298 m_file_names and introduce a new accessor method.
2299 (line_header::file_names_size): New method.
2300 (line_header::include_dirs): Change to private field and rename as
2301 m_include_dirs.
2302 (dw2_get_file_names_reader): Define local var at a smaller scope and
2303 reflect API change.
2304 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2305 (process_structure_scope): Likewise.
2306 (line_header::add_include_dir): Change message and reflect renaming.
2307 (line_header::add_file_name): Likewise.
2308 (read_formatted_entries): Handle DW_FORM_data16.
2309 (dwarf_decode_line_header): Fix line header length calculation.
2310 (psymtab_include_file_name): Change comment and API.
2311 (lnp_state_machine::m_file): Update comment and reflect type change.
2312 (lnp_state_machine::record_line): Reflect type change.
2313 (dwarf_decode_lines): Reflect API change.
2314 (file_file_name): Likewise.
2315 (file_full_name): Likewise.
2316
2317 2019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2318
2319 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2320
2321 2019-10-21 Tom Tromey <tom@tromey.com>
2322
2323 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2324
2325 2019-10-21 Tom Tromey <tom@tromey.com>
2326
2327 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2328 NM_H. Use AC_CONFIG_LINKS.
2329 * configure: Rebuild.
2330 * Makefile.in (NM_H): New variable.
2331 (generated_files): Add NM_H. Remove gcore.
2332 (nm.h, stamp-nmh): New targets.
2333
2334 2019-10-20 Tom Tromey <tom@tromey.com>
2335
2336 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2337 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2338 obsolete comment.
2339 (put_objfile_before): Now static.
2340
2341 2019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2342
2343 * gdbsupport/common-utils.h (startswith): Change return type to
2344 bool.
2345
2346 2019-10-19 Christian Biesinger <cbiesinger@google.com>
2347
2348 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2349 * breakpoint.c (bp_locations_compare): Rename to...
2350 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2351 (update_global_location_list): Use std::sort instead of qsort.
2352 * buildsym.c (compare_line_numbers): Rename to...
2353 (lte_is_less_than): ...this, and change to std::sort semantics.
2354 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2355 instead of qsort.
2356 * disasm.c (compare_lines): Rename to...
2357 (line_is_less_than): ...this, and change to std::sort semantics.
2358 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2359 of qsort.
2360 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2361 (fde_is_less_than): ...this, and change to std::sort semantics.
2362 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2363 * mdebugread.c (compare_blocks):
2364 (block_is_less_than): ...this, and change to std::sort semantics.
2365 (sort_blocks): Call std::sort instead of qsort.
2366 * objfiles.c (qsort_cmp): Rename to...
2367 (sort_cmp): ...this, and change to std::sort semantics.
2368 (update_section_map): Call std::sort instead of qsort.
2369 * remote.c (compare_pnums): Remove.
2370 (map_regcache_remote_table): Call std::sort instead of qsort.
2371 * utils.c (compare_positive_ints): Remove.
2372 * utils.h (compare_positive_ints): Remove.
2373 * xcoffread.c (compare_lte): Remove.
2374 (arrange_linetable): Call std::sort instead of qsort.
2375
2376 2019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2377
2378 * symfile.c (init_entry_point_info): Fix typo.
2379 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2380
2381 2019-10-18 Tom de Vries <tdevries@suse.de>
2382
2383 * aarch64-tdep.c: Fix typos in comments.
2384 * ada-lang.c: Same.
2385 * ada-tasks.c: Same.
2386 * alpha-tdep.c: Same.
2387 * alpha-tdep.h: Same.
2388 * amd64-nat.c: Same.
2389 * amd64-windows-tdep.c: Same.
2390 * arc-tdep.c: Same.
2391 * arc-tdep.h: Same.
2392 * arch-utils.c: Same.
2393 * arm-nbsd-tdep.c: Same.
2394 * arm-tdep.c: Same.
2395 * ax-gdb.c: Same.
2396 * blockframe.c: Same.
2397 * btrace.c: Same.
2398 * c-varobj.c: Same.
2399 * coff-pe-read.c: Same.
2400 * coffread.c: Same.
2401 * cris-tdep.c: Same.
2402 * darwin-nat.c: Same.
2403 * dbxread.c: Same.
2404 * dcache.c: Same.
2405 * disasm.c: Same.
2406 * dtrace-probe.c: Same.
2407 * dwarf-index-write.c: Same.
2408 * dwarf2-frame-tailcall.c: Same.
2409 * dwarf2-frame.c: Same.
2410 * dwarf2read.c: Same.
2411 * eval.c: Same.
2412 * exceptions.c: Same.
2413 * fbsd-tdep.c: Same.
2414 * findvar.c: Same.
2415 * frame.c: Same.
2416 * frv-tdep.c: Same.
2417 * gnu-v3-abi.c: Same.
2418 * go32-nat.c: Same.
2419 * h8300-tdep.c: Same.
2420 * hppa-tdep.c: Same.
2421 * i386-linux-tdep.c: Same.
2422 * i386-tdep.c: Same.
2423 * ia64-libunwind-tdep.c: Same.
2424 * ia64-tdep.c: Same.
2425 * infcmd.c: Same.
2426 * infrun.c: Same.
2427 * linespec.c: Same.
2428 * linux-nat.c: Same.
2429 * linux-thread-db.c: Same.
2430 * machoread.c: Same.
2431 * mdebugread.c: Same.
2432 * mep-tdep.c: Same.
2433 * mn10300-tdep.c: Same.
2434 * namespace.c: Same.
2435 * objfiles.c: Same.
2436 * opencl-lang.c: Same.
2437 * or1k-tdep.c: Same.
2438 * osabi.c: Same.
2439 * ppc-linux-nat.c: Same.
2440 * ppc-linux-tdep.c: Same.
2441 * ppc-sysv-tdep.c: Same.
2442 * printcmd.c: Same.
2443 * procfs.c: Same.
2444 * record-btrace.c: Same.
2445 * record-full.c: Same.
2446 * remote-fileio.c: Same.
2447 * remote.c: Same.
2448 * rs6000-tdep.c: Same.
2449 * s12z-tdep.c: Same.
2450 * score-tdep.c: Same.
2451 * ser-base.c: Same.
2452 * ser-go32.c: Same.
2453 * skip.c: Same.
2454 * sol-thread.c: Same.
2455 * solib-svr4.c: Same.
2456 * solib.c: Same.
2457 * source.c: Same.
2458 * sparc-nat.c: Same.
2459 * sparc-sol2-tdep.c: Same.
2460 * sparc-tdep.c: Same.
2461 * sparc64-tdep.c: Same.
2462 * stabsread.c: Same.
2463 * stack.c: Same.
2464 * symfile.c: Same.
2465 * symtab.c: Same.
2466 * target-descriptions.c: Same.
2467 * target-float.c: Same.
2468 * thread.c: Same.
2469 * utils.c: Same.
2470 * valops.c: Same.
2471 * valprint.c: Same.
2472 * value.c: Same.
2473 * varobj.c: Same.
2474 * windows-nat.c: Same.
2475 * xcoffread.c: Same.
2476 * xstormy16-tdep.c: Same.
2477 * xtensa-tdep.c: Same.
2478
2479 2019-10-17 Tom Tromey <tromey@adacore.com>
2480
2481 * configure: Rebuild.
2482 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2483 in AC_CONFIG_FILES invocation.
2484 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2485 new-style config.status invocation.
2486
2487 2019-10-17 Tom de Vries <tdevries@suse.de>
2488
2489 * arm-nbsd-nat.c: Fix typos in comments.
2490 * arm-tdep.c: Same.
2491 * darwin-nat-info.c: Same.
2492 * dwarf2read.c: Same.
2493 * elfread.c: Same.
2494 * event-top.c: Same.
2495 * findvar.c: Same.
2496 * gdbtypes.c: Same.
2497 * hppa-tdep.c: Same.
2498 * i386-tdep.c: Same.
2499 * jit.c: Same.
2500 * main.c: Same.
2501 * mdebugread.c: Same.
2502 * moxie-tdep.c: Same.
2503 * nto-procfs.c: Same.
2504 * osabi.c: Same.
2505 * ppc-linux-tdep.c: Same.
2506 * remote.c: Same.
2507 * riscv-tdep.c: Same.
2508 * s390-tdep.c: Same.
2509 * sh-tdep.c: Same.
2510 * sparc-linux-tdep.c: Same.
2511 * sparc-nat.c: Same.
2512 * stack.c: Same.
2513 * target-descriptions.c: Same.
2514 * top.c: Same.
2515 * varobj.c: Same.
2516
2517 2019-10-16 Tom Tromey <tom@tromey.com>
2518
2519 * objfiles.h (struct objfile) <original_name>: Now const.
2520
2521 2019-10-16 Christian Biesinger <cbiesinger@google.com>
2522
2523 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2524 pass on to sigsetjmp's second argument.
2525 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2526
2527 2019-10-16 Keith Seitz <keiths@redhat.com>
2528
2529 PR gdb/23567
2530 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2531 sections whose size is greater than the file size.
2532
2533 2019-10-16 Jim Wilson <jimw@sifive.com>
2534
2535 * riscv-tdep.c (riscv_gcc_target_options): New.
2536 (riscv_gnu_triplet_regexp): New.
2537 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2538 set_gdbarch_gnu_triplet_regexp.
2539
2540 2019-10-16 Christian Biesinger <cbiesinger@google.com>
2541
2542 * Makefile.in: Add xml-builtin.h.
2543 * features/feature_to_c.sh: Add an include for xml-builtin.h
2544 to ensure that the compiler checks that the types match.
2545 * xml-builtin.h: New file.
2546 * xml-support.c (fetch_xml_builtin): Add missing const.
2547 * xml-support.h: Remove declaration of xml_builtins.
2548
2549 2019-10-16 Tom de Vries <tdevries@suse.de>
2550
2551 PR tdep/25096
2552 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2553 (amd64_classify_aggregate): ... here.
2554 (amd64_classify_aggregate_field): Handled fiels of nested structs
2555 recursively.
2556
2557 2019-10-16 Tom de Vries <tdevries@suse.de>
2558
2559 PR tdep/24104
2560 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2561 that handles 'theclass'.
2562
2563 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2564
2565 * linespec.c (decode_digits_ordinary): Update comment.
2566 * make-target-delegates: No longer need to handle VEC case.
2567 * memrange.c (normalize_mem_ranges): Update comment.
2568 * namespace.c (add_using_directive): Update comment.
2569 * objc-lang.c (uniquify_strings): Update comment.
2570 * ppc-linux-nat.c (struct thread_points): Update comment.
2571 * probe.h (find_probes_in_objfile): Update comment.
2572 * target.h (enum flash_preserve_mode): Update comment.
2573 * varobj.c (varobj_restrict_range): Update comment.
2574 * varobj.h (varobj_list_children): Update comment.
2575
2576 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2577
2578 * Makefile.in: Remove references to vec.h and vec.c.
2579 * aarch64-tdep.c: No longer include vec.h.
2580 * ada-lang.c: Likewise.
2581 * ada-lang.h: Likewise.
2582 * arm-tdep.c: Likewise.
2583 * ax.h: Likewise.
2584 * breakpoint.h: Likewise.
2585 * charset.c: Likewise.
2586 * cp-support.h: Likewise.
2587 * dtrace-probe.c: Likewise.
2588 * dwarf2read.c: Likewise.
2589 * extension.h: Likewise.
2590 * gdb_bfd.c: Likewise.
2591 * gdbsupport/gdb_vecs.h: Likewise.
2592 * gdbsupport/vec.c: Remove.
2593 * gdbsupport/vec.h: Remove.
2594 * gdbthread.h: Likewise.
2595 * guile/scm-type.c: Likewise.
2596 * inline-frame.c: Likewise.
2597 * machoread.c: Likewise.
2598 * memattr.c: Likewise.
2599 * memrange.h: Likewise.
2600 * namespace.h: Likewise.
2601 * nat/linux-btrace.h: Likewise.
2602 * osdata.c: Likewise.
2603 * parser-defs.h: Likewise.
2604 * progspace.h: Likewise.
2605 * python/py-type.c: Likewise.
2606 * record-btrace.c: Likewise.
2607 * rust-exp.y: Likewise.
2608 * solib-target.c: Likewise.
2609 * stap-probe.c: Likewise.
2610 * target-descriptions.c: Likewise.
2611 * target-memory.c: Likewise.
2612 * target.h: Likewise.
2613 * varobj.c: Likewise.
2614 * varobj.h: Likewise.
2615 * xml-support.h: Likewise.
2616
2617 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2618
2619 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2620 Update for new std::vector based implementation.
2621 (process_psymtab_comp_unit_reader): Likewise.
2622 (scan_partial_symbols): Likewise.
2623 (recursively_compute_inclusions): Likewise.
2624 (compute_compunit_symtab_includes): Likewise.
2625 (process_imported_unit_die): Likewise.
2626 (queue_and_load_dwo_tu): Likewise.
2627 (follow_die_sig_1): Likewise.
2628 * gdb/dwarf2read.h: Remove DEF_VEC_P.
2629 (typedef dwarf2_per_cu_ptr): Remove.
2630 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2631 function.
2632 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2633 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2634 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2635 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2636 std::vector.
2637
2638 2019-10-15 Tom Tromey <tromey@adacore.com>
2639
2640 * windows-nat.c (windows_nat_target::resume): Use %x when logging
2641 TID.
2642
2643 2019-10-15 Tom Tromey <tromey@adacore.com>
2644
2645 * windows-nat.c (windows_nat_target::fetch_registers)
2646 (windows_nat_target::store_registers): Rename "pid" to "tid".
2647
2648 2019-10-15 Tom Tromey <tromey@adacore.com>
2649
2650 * gdbarch.h, gdbarch.c: Rebuild.
2651 * gdbarch.sh (gcc_target_options): Change return type to
2652 std::string.
2653 * compile/compile.c (get_args): Update.
2654 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2655 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2656 std::string.
2657 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2658 std::string.
2659 * arch-utils.c (default_gcc_target_options): Return std::string.
2660 * arch-utils.h (default_gcc_target_options): Return std::string.
2661 * s390-tdep.c (s390_gcc_target_options): Return std::string.
2662
2663 2019-10-15 Christian Biesinger <cbiesinger@google.com>
2664
2665 * breakpoint.c (breakpoint_chain): Make static.
2666 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2667 of accessing breakpoint_chain.
2668
2669 2019-10-15 Christian Biesinger <cbiesinger@google.com>
2670
2671 * breakpoint.c (iterate_over_breakpoints): Change function pointer
2672 to a gdb::function_view and return value to bool.
2673 * breakpoint.h (iterate_over_breakpoints): Likewise.
2674 * dummy-frame.c (pop_dummy_frame_bpt): Update.
2675 (pop_dummy_frame): Update.
2676 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2677 (gdbscm_breakpoints): Update.
2678 * python/py-breakpoint.c (build_bp_list): Update.
2679 (gdbpy_breakpoints): Update.
2680 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2681 Update.
2682 (bpfinishpy_handle_stop): Update.
2683 (bpfinishpy_handle_exit): Update.
2684 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2685 (svr4_update_solib_event_breakpoints): Update.
2686
2687 2019-10-15 Andreas Arnez <arnez@linux.ibm.com>
2688
2689 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2690 when unwrapping single-field structs.
2691
2692 2019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2693
2694 * dwarf2read.c: Remove includes.
2695
2696 2019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2697
2698 * ui-out.c (ui_out::call_do_message): Silence
2699 -Wformat-nonliteral warning.
2700
2701 2019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
2702
2703 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2704 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2705 include: readline/tilde.h.
2706
2707 2019-10-12 Christian Biesinger <cbiesinger@google.com>
2708
2709 * remote.c (remote_target::get_trace_status): Remove declaration of
2710 trace_regblock_size.
2711
2712 2019-10-12 Christian Biesinger <cbiesinger@google.com>
2713
2714 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2715 (show_user): Remove declaration of cmdlist.
2716 * cli/cli-cmds.h (max_user_call_depth): Declare.
2717 * cli/cli-script.c (execute_user_command): Remove declaration
2718 of max_user_call_depth.
2719
2720 2019-10-11 Jim Wilson <jimw@sifive.com>
2721
2722 * gdbsupport/print-utils.h (pulongest): Fix comment.
2723 (plongest): Likewise.
2724 (phex): Add missing comment, mention leading zeros.
2725 (phex_nz): Add mention of no leading zeros to comment.
2726
2727 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2728 plongest instead of unsigned long long cast.
2729
2730 2019-10-10 Christian Biesinger <cbiesinger@google.com>
2731
2732 * main.c (captured_main_1): Include gdbtk.h and remove declarations
2733 for external_editor_command and gdbtk_test.
2734
2735 2019-10-10 Christian Biesinger <cbiesinger@google.com>
2736
2737 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2738 * varobj.c (varobjdebug): Move comment to...
2739 * varobj.h (varobjdebug): ...here, and declare.
2740
2741 2019-10-09 Tom Tromey <tom@tromey.com>
2742
2743 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2744 erase_data_content.
2745
2746 2019-10-09 Tom Tromey <tom@tromey.com>
2747
2748 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2749 * tui/tui-stack.c (tui_locator_window::rerender): Update.
2750 * tui/tui-command.c (tui_cmd_window::resize)
2751 (tui_refresh_cmd_win): Update.
2752 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2753 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2754 * tui/tui-data.c (~tui_gen_win_info): Remove.
2755 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2756 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2757 (tui_redisplay_readline, tui_mld_flush)
2758 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2759 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2760 (tui_data_window::erase_data_content)
2761 (tui_data_item_window::rerender)
2762 (tui_data_item_window::refresh_window): Update.
2763 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2764 (box_win, tui_gen_win_info::make_window)
2765 (tui_gen_win_info::make_visible): Update.
2766 (tui_delete_win): Remove.
2767 * tui/tui-winsource.c
2768 (tui_source_window_base::do_erase_source_content): Update.
2769 (tui_show_source_line, tui_source_window_base::update_tab_width)
2770 (tui_source_window_base::update_exec_info): Update.
2771 * tui/tui-data.h (struct curses_deleter): New.
2772 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2773 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2774
2775 2019-10-09 Tom Tromey <tom@tromey.com>
2776
2777 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2778
2779 2019-10-09 Tom Tromey <tom@tromey.com>
2780
2781 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2782 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2783
2784 2019-10-09 Tom Tromey <tom@tromey.com>
2785
2786 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2787 window height directly.
2788 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2789 declare.
2790 * tui/tui-layout.c (tui_default_win_height): Remove.
2791 (tui_default_win_viewport_height): Remove.
2792
2793 2019-10-09 Tom Tromey <tom@tromey.com>
2794
2795 * tui/tui.h: Remove comments.
2796
2797 2019-10-09 Tom de Vries <tdevries@suse.de>
2798
2799 * python/lib/gdb/printer/bound_registers.py: Use
2800 '^builtin_type_bound128' as regexp argument for
2801 add_builtin_pretty_printer.
2802
2803 2019-10-09 Christian Biesinger <cbiesinger@google.com>
2804
2805 * guile/guile.c (guile_extension_script_ops): Remove forward
2806 declaration and mark as static.
2807 (guile_script_ops): Likewise.
2808 (extension_language_guile): Move further down in the file so
2809 it can reference the definitions for guile_{extension_,}script_ops.
2810
2811 2019-10-09 Andreas Arnez <arnez@linux.ibm.com>
2812
2813 * s390-tdep.c (390_process_record): Handle new arch13 instructions
2814 except SORTL, DFLTCC, and KDSA.
2815
2816 2019-10-08 Tom Tromey <tromey@adacore.com>
2817
2818 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2819 (struct safe_symbol_file_add_args): Remove.
2820
2821 2019-10-08 Tom Tromey <tromey@adacore.com>
2822
2823 * windows-nat.c: Don't include buildsym-legacy.h.
2824
2825 2019-10-08 Tom Tromey <tromey@adacore.com>
2826
2827 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2828
2829 2019-10-08 Christian Biesinger <cbiesinger@google.com>
2830
2831 * gdbtypes.c (overload_debug): Move comment to header.
2832 * gdbtypes.h (overload_debug): Declare.
2833 * valops.c: Remove declaration of overload_debug, instead
2834 include gdbtypes.h.
2835
2836 2019-10-08 Christian Biesinger <cbiesinger@google.com>
2837
2838 * language.c (show_language_command): Pass lang_frame_mismatch_warn
2839 through _().
2840 (lang_frame_mismatch_warn): Make const, mark with N_(), and
2841 move comment...
2842 * language.h (lang_frame_mismatch_warn): ... here. Also add
2843 declaration.
2844 * top.c (lang_frame_mismatch_warn): Remove declaration.
2845 (check_frame_language_change): Pass lang_frame_mismatch_warn
2846 through _().
2847
2848 2019-10-07 Christian Biesinger <cbiesinger@google.com>
2849
2850 * c-lang.h (vtbl_ptr_name): Declare.
2851 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2852 it from the header.
2853 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2854
2855 2019-10-07 Christian Biesinger <cbiesinger@google.com>
2856
2857 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2858 gdb_static_assert.
2859
2860 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
2861
2862 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2863 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
2864 * ctfread.c: New file.
2865 * ctfread.h: New file.
2866 * elfread.c: Include ctfread.h.
2867 (struct elfinfo text_p): New member ctfsect.
2868 (elf_locate_sections): Mark CTF section.
2869 (elf_symfile_read): Call elfctf_build_psymtabs.
2870 * Makefile.in (LIBCTF): Add.
2871 (CLIBS): Use it.
2872 (CDEPS): Likewise.
2873 (DIST): Add ctfread.c.
2874
2875 2019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
2876
2877 * ctfread.c (struct nextfield): Renamed to ...
2878 (struct ctf_nextfield): ... this.
2879 (struct field_info): Renamed to ...
2880 (strut ctf_field_info): ... this.
2881 (attach_fields_to_type): Update for renamed structures.
2882 (ctf_add_member_cb): Likewise.
2883 (ctf_add_enum_member_cb): Likewise.
2884 (process_struct_members): Likewise.
2885 (process_enum_type): Likewise.
2886
2887 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
2888
2889 * tracectf.h: Rename, was ctf.h.
2890 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2891 * tracefile.c: Likewise.
2892 * tracepoint.c: Remove unused include ctf.h.
2893 * mi/mi-main.c: Likewise.
2894 * Makefile.in Replace ctf.c with tracectf.c.
2895
2896 2019-10-06 Joel Brobecker <brobecker@adacore.com>
2897
2898 * version.in: Change version number to "9.0.50.DATE-git".
2899
2900 2019-10-03 Tom Tromey <tom@tromey.com>
2901
2902 PR rust/24976:
2903 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2904
2905 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2906
2907 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2908 cp_search_name_hash.
2909 * NEWS: Add entry about nested function support.
2910
2911 2019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
2912 Andrew Burgess <andrew.burgess@embecosm.com>
2913
2914 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
2915 for nested static variables when searchin VAR_DOMAIN.
2916 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
2917 global scope, update comment.
2918 (add_partial_subprogram): Call add_partial_subprogram recursively
2919 for nested subroutines when processinng Fortran.
2920 (load_partial_dies): Process the child entities of a subprogram
2921 when processing Fortran.
2922 (partial_die_parent_scope): Handle building scope
2923 for Fortran nested functions.
2924 (process_die): Record that nested functions have a scope.
2925 (new_symbol): Always record Fortran subprograms on the global
2926 symbol list.
2927 (determine_prefix): How to build the prefix for Fortran
2928 subprograms.
2929
2930 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2931
2932 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
2933 have just sent the thread a SIGSTOP and are waiting for it to
2934 arrive.
2935
2936 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2937
2938 * btrace.c (btrace_add_pc): Remove whitespace before the template
2939 parameter in 'std::vector <...>'.
2940 (parse_xml_btrace_block): Likewise.
2941 (btrace_maint_decode_pt): Likewise.
2942 (btrace_maint_update_packets): Likewise.
2943 (btrace_maint_print_packets): Likewise.
2944 * btrace.h (struct btrace_maint_info): Likewise.
2945 * dwarf2read.c (struct type_unit_group): Likewise.
2946 (build_type_psymtabs_reader): Likewise.
2947 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
2948 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
2949 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
2950
2951 2019-10-03 Tom de Vries <tdevries@suse.de>
2952
2953 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
2954 the first line of the help text for set/show style metadata.
2955
2956 2019-10-02 Tom Tromey <tromey@adacore.com>
2957
2958 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
2959 * gdbsupport/common-inferior.c: New file.
2960 * infcmd.c (startup_with_shell): Don't define.
2961 * nat/fork-inferior.h (startup_with_shell): Don't declare.
2962 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
2963 * inferior.h (startup_with_shell): Don't declare.
2964
2965 2019-10-02 Christian Biesinger <cbiesinger@google.com>
2966
2967 * gdbsupport/gdb_assert.h: Include errors.h.
2968 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
2969
2970 2019-10-02 Tom Tromey <tromey@adacore.com>
2971
2972 * NEWS: Add $_ada_exception entry.
2973 * ada-lang.c (struct ada_catchpoint): Add constructor.
2974 <m_kind>: New member.
2975 (allocate_location_exception, re_set_exception): Remove
2976 "ex" parameter.
2977 (should_stop_exception): Compute $_ada_exception.
2978 (check_status_exception, print_it_exception)
2979 (print_one_exception, print_mention_exception): Remove
2980 "ex" parameter.
2981 (allocate_location_catch_exception, re_set_catch_exception)
2982 (check_status_exception, print_it_catch_exception)
2983 (print_one_catch_exception, print_mention_catch_exception)
2984 (print_recreate_catch_exception)
2985 (allocate_location_catch_exception_unhandled)
2986 (re_set_catch_exception_unhandled)
2987 (check_status_exception, print_it_catch_exception_unhandled)
2988 (print_one_catch_exception_unhandled)
2989 (print_mention_catch_exception_unhandled)
2990 (print_recreate_catch_exception_unhandled)
2991 (allocate_location_catch_assert, re_set_catch_assert)
2992 (check_status_assert, print_it_catch_assert)
2993 (print_one_catch_assert, print_mention_catch_assert)
2994 (print_recreate_catch_assert)
2995 (allocate_location_catch_handlers, re_set_catch_handlers)
2996 (check_status_handlers, print_it_catch_handlers)
2997 (print_one_catch_handlers, print_mention_catch_handlers)
2998 (print_recreate_catch_handlers): Remove.
2999 (create_ada_exception_catchpoint): Update.
3000 (initialize_ada_catchpoint_ops): Update.
3001
3002 2019-10-02 Tom Tromey <tromey@adacore.com>
3003
3004 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3005 (create_excep_cond_exprs): Simplify exception string computation.
3006 (ada_exception_catchpoint_cond_string): Likewise.
3007
3008 2019-10-02 Tom Tromey <tromey@adacore.com>
3009
3010 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3011 * ada-lang.c (lesseq_defined_than): Handle
3012 LOC_STATIC.
3013 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3014 parameter.
3015 (dwarf2_has_info): Likewise.
3016 (new_symbol): Set maybe_copied on symbol when
3017 appropriate.
3018 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3019 parameter.
3020 <can_copy>: New member.
3021 * elfread.c (record_minimal_symbol): Set maybe_copied
3022 on symbol when appropriate.
3023 (elf_symfile_read): Update call to dwarf2_has_info.
3024 * minsyms.c (lookup_minimal_symbol_linkage): New
3025 function.
3026 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3027 * symtab.c (get_symbol_address, get_msymbol_address):
3028 New functions.
3029 * symtab.h (get_symbol_address, get_msymbol_address):
3030 Declare.
3031 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3032 maybe_copied.
3033 (struct symbol, struct minimal_symbol) <maybe_copied>:
3034 New member.
3035
3036 2019-10-02 Tom Tromey <tromey@adacore.com>
3037
3038 * source.c (struct current_source_location): New.
3039 (current_source_key): New global.
3040 (current_source_symtab, current_source_line)
3041 (current_source_pspace): Remove.
3042 (get_source_location): New function.
3043 (get_current_source_symtab_and_line)
3044 (set_default_source_symtab_and_line)
3045 (set_current_source_symtab_and_line)
3046 (clear_current_source_symtab_and_line, select_source_symtab)
3047 (info_source_command, print_source_lines_base)
3048 (info_line_command, search_command_helper, _initialize_source):
3049 Update.
3050
3051 2019-10-02 Tom Tromey <tromey@adacore.com>
3052
3053 * source.c (select_source_symtab): Don't call
3054 decode_line_with_current_source.
3055
3056 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3057
3058 * symtab.c (lookup_global_symbol): Search global block.
3059
3060 2019-10-02 Tom Tromey <tromey@adacore.com>
3061
3062 * coffread.c (process_coff_symbol): Update.
3063 * dwarf2read.c (var_decode_location, new_symbol): Update.
3064 * mdebugread.c (parse_symbol): Update.
3065 * objfiles.c (relocate_one_symbol): Update.
3066 * stabsread.c (define_symbol, fix_common_block)
3067 (scan_file_globals): Update.
3068 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3069 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3070 * xcoffread.c (process_xcoff_symbol): Update.
3071
3072 2019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3073
3074 * MAINTAINERS: Update my email address.
3075
3076 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3077
3078 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3079 std::vector.
3080 (build_type_psymtabs_reader): Update for std::vector.
3081 (build_type_psymtab_dependencies): Likewise.
3082 * dwarf2read.h: Remove use of DEF_VEC_P.
3083 (typedef sig_type_ptr): Delete.
3084
3085 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3086
3087 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3088 to std::vector.
3089 (btrace_maint_decode_pt): Likewise, and move allocation of the
3090 vector outside of the loop.
3091 (btrace_maint_update_packets): Update to handle change from VEC to
3092 std::vector.
3093 (btrace_maint_print_packets): Likewise.
3094 (maint_info_btrace_cmd): Likewise.
3095 * btrace.h: Remove use of DEF_VEC_O.
3096 (typedef btrace_pt_packet_s): Delete.
3097 (struct btrace_maint_info) <packets>: Change fromm VEC to
3098 std::vector.
3099 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3100
3101 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3102
3103 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3104 make accesses into the vector constant references.
3105 (btrace_add_pc): Update for std::vector.
3106 (btrace_stitch_bts): Likewise.
3107 (parse_xml_btrace_block): Likewise.
3108 (btrace_maint_update_packets): Likewise.
3109 (btrace_maint_print_packets): Likewise.
3110 (maint_info_btrace_cmd): Likewise.
3111 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3112 std::vector.
3113 (btrace_data::empty): Likewise.
3114 (btrace_data_append): Likewise.
3115 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3116 (typedef btrace_block_s): Delete.
3117 (struct btrace_block): Add constructor.
3118 (struct btrace_data_bts) <blocks>: Change to std::vector.
3119 * nat/linux-btrace.c (perf_event_read_bts): Update for
3120 std::vector.
3121 (linux_read_bts): Likewise.
3122
3123 2019-10-01 Tom Tromey <tom@tromey.com>
3124
3125 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3126
3127 2019-10-01 Tom Tromey <tom@tromey.com>
3128
3129 * stack.c (print_frame, info_frame_command_core): Use
3130 styled_string.
3131 * linux-thread-db.c (try_thread_db_load_1)
3132 (try_thread_db_load_from_pdir_1): Use styled_string.
3133 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3134 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3135 (maybe_print_unsupported_script_warning)
3136 (maybe_print_script_not_found_warning): Use styled_string.
3137 * ada-lang.c (user_select_syms): Use styled_string.
3138
3139 2019-10-01 Tom Tromey <tom@tromey.com>
3140
3141 * p-lang.c (pascal_printstr): Use metadata style.
3142 * value.c (show_convenience): Use metadata style.
3143 * valprint.c (valprint_check_validity, val_print_optimized_out)
3144 (val_print_not_saved, val_print_unavailable)
3145 (val_print_invalid_address, generic_val_print, val_print)
3146 (value_check_printable, val_print_array_elements): Use metadata
3147 style.
3148 * ui-out.h (class ui_out) <field_fmt>: New overload.
3149 <do_field_fmt>: Add style parameter.
3150 * ui-out.c (ui_out::field_fmt): New overload.
3151 * typeprint.c (type_print_unknown_return_type)
3152 (val_print_not_allocated, val_print_not_associated): Use metadata
3153 style.
3154 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3155 parameter.
3156 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3157 * tracepoint.c (tvariables_info_1): Use metadata style.
3158 * stack.c (print_frame_arg, print_frame_info, print_frame)
3159 (info_frame_command_core): Use metadata style.
3160 * skip.c (info_skip_command): Use metadata style.
3161 * rust-lang.c (rust_print_enum): Use metadata style.
3162 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3163 metadata style.
3164 * python/py-framefilter.c (py_print_single_arg): Use metadata
3165 style.
3166 * printcmd.c (do_one_display, print_variable_and_value): Use
3167 metadata style.
3168 * p-valprint.c (pascal_val_print)
3169 (pascal_object_print_value_fields): Use metadata style.
3170 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3171 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3172 parameter.
3173 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3174 * m2-valprint.c (m2_print_long_set): Use metadata style.
3175 * m2-typeprint.c (m2_print_type): Use metadata style.
3176 * infcmd.c (print_return_value_1): Use metadata style.
3177 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3178 * f-valprint.c (info_common_command_for_block): Use metadata
3179 style.
3180 * f-typeprint.c (f_type_print_base): Use metadata style.
3181 * expprint.c (print_subexp_standard): Use metadata style.
3182 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3183 * cli/cli-style.h (class cli_style_option): Add constructor.
3184 (metadata_style): Declare.
3185 * cli/cli-style.c (metadata_style): New global.
3186 (_initialize_cli_style): Register metadata style.
3187 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3188 parameter.
3189 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3190 * c-typeprint.c (c_type_print_base_struct_union)
3191 (c_type_print_base_1): Use metadata style.
3192 * breakpoint.c (watchpoint_value_print)
3193 (print_one_breakpoint_location): Use metadata style.
3194 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3195 style.
3196 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3197 style.
3198 * ada-valprint.c (val_print_packed_array_elements, printstr)
3199 (print_field_values, ada_val_print_ref, ada_val_print): Use
3200 metadata style.
3201 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3202 style.
3203 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3204 style.
3205 * ada-lang.c (user_select_syms): Use metadata style.
3206
3207 2019-10-01 Tom Tromey <tom@tromey.com>
3208
3209 * cli/cli-cmds.c (pwd_command): Style output.
3210
3211 2019-10-01 Pedro Alves <palves@redhat.com>
3212 Tom Tromey <tom@tromey.com>
3213
3214 * symtab.c (print_symbol_info): Use %ps.
3215 (print_msymbol_info): Use %ps.
3216 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3217 * printcmd.c (print_variable_and_value): Use %ps.
3218 * macrocmd.c (show_pp_source_pos): Use %ps.
3219 * infrun.c (print_exited_reason): Use ui_out::message.
3220 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3221 (describe_other_breakpoints): Use ui_out::message and new
3222 formats.
3223 (say_where): Use new formats.
3224 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3225 and new formats.
3226
3227 2019-10-01 Pedro Alves <palves@redhat.com>
3228 Tom Tromey <tom@tromey.com>
3229
3230 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3231 (test_gdb_formats): New function.
3232 (run_tests): Call it.
3233 (test_format_specifier): Update.
3234 * utils.h (fputs_filtered): Update comment.
3235 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3236 (fputs_styled_unfiltered): Declare.
3237 * utils.c (fputs_styled_unfiltered): New function.
3238 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3239 (vfprintf_filtered): Update.
3240 (vfprintf_unfiltered, vprintf_filtered): Update.
3241 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3242 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3243 disallow_ui_out_field>: New constants.
3244 (enum class field_kind): New.
3245 (struct base_field_s, struct signed_field_s): New.
3246 (signed_field): New function.
3247 (struct string_field_s): New.
3248 (string_field): New function.
3249 (struct styled_string_s): New.
3250 (styled_string): New function.
3251 (class ui_out) <message>: Add comment.
3252 <vmessage, call_do_message>: New methods.
3253 <do_message>: Add style parameter.
3254 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3255 methods.
3256 (ui_out::message): Rewrite.
3257 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3258 parameter.
3259 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3260 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3261 gdb_extensions parameter.
3262 (class format_piece): Add parameter to constructor.
3263 (n_int_args): New field.
3264 * gdbsupport/format.c (format_pieces::format_pieces): Add
3265 gdb_extensions parameter. Handle '*'.
3266 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3267 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3268 vfprintf_styled_no_gdbfmt.
3269 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3270 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3271 unfiltered output.
3272 * ui-style.h (struct ui_file_style) <ptr>: New method.
3273
3274 2019-10-01 Tom Tromey <tom@tromey.com>
3275
3276 * unittests/format_pieces-selftests.c: Update. Add final format.
3277 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3278 empty literal pieces.
3279
3280 2019-10-01 Tom Tromey <tom@tromey.com>
3281
3282 * ui-out.h (enum class ui_out_style_kind): Remove.
3283 (class ui_out) <field_string, field_stsream, do_field_string>:
3284 Change type of "style".
3285 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3286 (ui_out::field_string): Update.
3287 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3288 of "style".
3289 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3290 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3291 * stack.c (print_frame_arg, print_frame_info, print_frame):
3292 Update.
3293 * source.c (print_source_lines_base): Update.
3294 * solib.c (info_sharedlibrary_command): Update.
3295 * skip.c (info_skip_command): Update.
3296 * record-btrace.c (btrace_call_history_src_line)
3297 (btrace_call_history): Update.
3298 * python/py-framefilter.c (py_print_frame): Update.
3299 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3300 "style".
3301 * mi/mi-out.c (mi_ui_out::do_table_header)
3302 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3303 (mi_ui_out::do_field_string): Update.
3304 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3305 Update.
3306 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3307 "style".
3308 * cli-out.c (cli_ui_out::do_table_header)
3309 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3310 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3311 (cli_ui_out::do_field_fmt): Update.
3312 * breakpoint.c (print_breakpoint_location): Update.
3313 (update_static_tracepoint): Update.
3314
3315 2019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3316
3317 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3318 conversion of gdb_datadir.
3319 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3320 remove not needed c_str ().
3321
3322 2019-09-30 Ali Tamur <tamur@google.com>
3323
3324 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3325 (dwarf2_string_attr): Likewise.
3326
3327 2019-09-30 Ali Tamur <tamur@google.com>
3328
3329 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3330 (process_full_type_unit): Likewise.
3331 (dump_die_shallow): Likewise.
3332 (cu_debug_loc_section): Likewise.
3333
3334 2019-09-28 Christian Biesinger <cbiesinger@google.com>
3335
3336 * minsyms.c (compare_minimal_symbols): Rename to...
3337 (minimal_symbol_is_less_than): ...this, and adjust to STL
3338 conventions (return bool, take arguments as references)
3339 (minimal_symbol_reader::install): Call std::sort instead
3340 of qsort.
3341
3342 2019-09-29 Christian Biesinger <cbiesinger@google.com>
3343
3344 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3345 hash and why.
3346 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3347 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3348
3349 2019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3350
3351 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3352 * psympriv.h (add_psymbol_to_list): Move comment here and update
3353 it.
3354
3355 2019-09-29 Tom de Vries <tdevries@suse.de>
3356
3357 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3358 Use $tmpdir/$(basename "$output_file").dwz instead of
3359 "${output_file}.dwz".
3360
3361 2019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3362
3363 PR gdb/25045
3364 * hppa-linux-nat.c: Include gdbarch.h.
3365
3366 2019-09-26 Christian Biesinger <cbiesinger@google.com>
3367
3368 * blockframe.c (find_pc_partial_function): Change return type to bool.
3369 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3370 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3371 (stub_gnu_ifunc_resolve_name): Likewise.
3372 * symtab.c (compare_filenames_for_search): Likewise.
3373 (compare_glob_filenames_for_search): Likewise.
3374 (matching_obj_sections): Likewise.
3375 (symbol_matches_domain): Likewise.
3376 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3377 (find_line_pc): Change return type to bool.
3378 (find_line_pc_range): Likewise.
3379 (producer_is_realview): Likewise.
3380 * symtab.h (symbol_matches_domain): Likewise.
3381 (find_pc_partial_function): Likewise.
3382 (find_pc_line_pc_range): Likewise.
3383 (in_gnu_ifunc_stub): Likewise.
3384 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3385 (find_line_pc): Likewise.
3386 (find_line_pc_range): Likewise.
3387 (matching_obj_sections): Likewise.
3388 (find_line_symtab): Change out parameter to bool.
3389 (producer_is_realview): Change return type to bool.
3390 (compare_filenames_for_search): Likewise.
3391 (compare_glob_filenames_for_search): Likewise.
3392
3393 2019-09-26 Tom Tromey <tom@tromey.com>
3394
3395 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3396 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3397 * gdb_usleep.h: Remove.
3398 * gdb_usleep.c: Remove.
3399 * utils.c: Don't include gdb_usleep.h.
3400
3401 2019-09-26 Tom Tromey <tromey@adacore.com>
3402
3403 * python/py-type.c (type_to_type_object): Call check_typedef
3404 for stub types.
3405
3406 2019-09-26 Tom Tromey <tom@tromey.com>
3407
3408 * utils.h (initialize_utils): Don't declare.
3409 * top.c (gdb_init): Don't call initialize_utils.
3410 * utils.c (initialize_utils): Remove. Move contents...
3411 (_initialize_utils): ... here.
3412
3413 2019-09-25 Tom Tromey <tom@tromey.com>
3414
3415 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3416 * utils.h (make_hex_string): Don't declare.
3417 * utils.c (make_hex_string): Remove.
3418
3419 2019-09-24 Tom de Vries <tdevries@suse.de>
3420
3421 PR gdb/23815
3422 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3423 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3424
3425 2019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3426
3427 * NEWS: Mention new simulator port for PRU.
3428
3429 2019-09-23 Christian Biesinger <cbiesinger@google.com>
3430
3431 * ada-exp.y (write_object_remaining): Update.
3432 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3433 and eliminate the static buffer.
3434 (ada_decode_symbol): Update.
3435 (ada_la_decode): Update.
3436 (ada_sniff_from_mangled_name): Update.
3437 (is_valid_name_for_wild_match): Update.
3438 (ada_lookup_name_info::matches): Update and simplify.
3439 (name_matches_regex): Update.
3440 (ada_add_global_exceptions): Update.
3441 * ada-lang.h (ada_decode): Update signature.
3442 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3443 * dwarf-index-write.c (debug_names::insert): Update.
3444
3445 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3446
3447 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3448 formatting.
3449
3450 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3451
3452 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3453 Change "nonzero" to "true" in documentation.
3454
3455 2019-09-20 Christian Biesinger <cbiesinger@google.com>
3456
3457 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3458 (_initialize_darwin_solib): Don't set
3459 darwin_so_ops.lookup_lib_global_symbol.
3460 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3461 set_gdbarch_iterate_over_objfiles_in_search_order.
3462 (elf_lookup_lib_symbol): Rename to...
3463 (svr4_iterate_over_objfiles_in_search_order): this, and update
3464 to iterate semantics.
3465 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3466 * solib.c (solib_global_lookup): Remove.
3467 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3468 (solib_global_lookup): Remove.
3469 * symtab.c (lookup_global_or_static_symbol): Remove call to
3470 solib_global_lookup.
3471
3472 2019-09-20 Joel Brobecker <brobecker@adacore.com>
3473
3474 * NEWS: Move entries about default MI version now being
3475 version 3, and about the GDB/MI fix for multi-location
3476 breakpoints to the "since GDB 8.3" section.
3477
3478 2019-09-20 Joel Brobecker <brobecker@adacore.com>
3479
3480 GDB 8.3.1 released.
3481
3482 2019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3483
3484 * NEWS: Mention that Cell/B.E. debugging support was removed.
3485 * MAINTAINERS: Remove spu target.
3486
3487 * config/djgpp/fnchange.lst: Remove entries for removed files.
3488
3489 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3490 spu-multiarch.o, and spu-tdep.o.
3491 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3492 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3493 spu-multiarch.c, and spu-tdep.c.
3494 * spu-linux-nat.c: Remove file.
3495 * spu-multiarch.c: Remove file.
3496 * spu-tdep.c: Remove file.
3497 * spu-tdep.h: Remove file.
3498 * solib-spu.c: Remove file.
3499 * solib-spu.h: Remove file.
3500
3501 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3502 * configure.nat (spu-linux): Remove.
3503 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3504 solib-multiarch.o from gdb_target_obs.
3505 (spu*-*-*): Remove.
3506
3507 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3508 feature flag.
3509 (ppc_linux_no_features): Update.
3510 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3511 Cell/B.E. support.
3512 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3513 (tdesc_powerpc_cell64l): Likewise.
3514 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3515 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3516 Cell/B.E. support.
3517 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3518 Do not include "features/rs6000/powerpc-cell32l.c" or
3519 "features/rs6000/powerpc-cell64l.c".
3520 (ppc_linux_spu_section): Remove.
3521 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3522 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3523 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3524 (ppc_linux_spe_context_lookup): Remove.
3525 (ppc_linux_spe_context_inferior_created): Remove.
3526 (ppc_linux_spe_context_solib_loaded): Remove.
3527 (ppc_linux_spe_context_solib_unloaded): Remove.
3528 (ppc_linux_spe_context): Remove.
3529 (struct ppu2spu_cache): Remove.
3530 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3531 (struct ppu2spu_data): Remove.
3532 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3533 ppu2spu_unwind): Remove.
3534 (ppc_linux_init_abi): Remove Cell/B.E. support.
3535 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3536
3537 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3538 (rs6000/powerpc-cell64l-expedite): Likewise
3539 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3540 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3541 rs6000/powerpc-cell64l.xml.
3542 * features/rs6000/powerpc-cell32l.xml: Remove.
3543 * features/rs6000/powerpc-cell64l.xml: Likewise.
3544 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3545 * features/rs6000/powerpc-cell64l.c: Likewise.
3546 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3547 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3548 * regformats/reg-spu.dat: Remove.
3549
3550 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3551 * corelow.c (struct spuid_list): Remove.
3552 (add_to_spuid_list): Remove.
3553 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3554 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3555 (remote_protocol_features): Remove associated entries.
3556 (_initialize_remote): No longer initialize them.
3557 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3558 * linux-nat.c (SPUFS_MAGIC): Remove.
3559 (linux_proc_xfer_spu): Remove.
3560 (spu_enumerate_spu_ids): Remove.
3561 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3562 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3563 (linux_make_corefile_notes): No longer call it.
3564
3565 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3566 (cooked_write_test): Likewise.
3567
3568 2019-09-20 Tom Tromey <tom@tromey.com>
3569
3570 * NEWS: Mention case-sensitivity of TUI commands.
3571 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3572 (tui_set_win_height_command, parse_scrolling_args): Likewise.
3573 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3574
3575 2019-09-20 Tom Tromey <tom@tromey.com>
3576
3577 * tui/tui-source.c (tui_source_window::set_contents): Use
3578 make_unique_xstrdup.
3579 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3580 make_unique_xstrdup.
3581
3582 2019-09-20 Tom Tromey <tom@tromey.com>
3583
3584 * tui/tui-data.c: Remove separator comments.
3585 * tui/tui-layout.c: Remove separator comments.
3586 * tui/tui-win.c: Remove separator comments.
3587 * tui/tui-wingeneral.c: Remove separator comments.
3588
3589 2019-09-20 Tom Tromey <tom@tromey.com>
3590
3591 * tui/tui.h (strcat_to_buf): Don't declare.
3592 * tui/tui.c (strcat_to_buf): Remove.
3593
3594 2019-09-20 Tom Tromey <tom@tromey.com>
3595
3596 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3597 from "fullname".
3598 * tui/tui-source.c (tui_source_window::set_contents)
3599 (tui_source_window::location_matches_p)
3600 (tui_source_window::maybe_update): Update.
3601
3602 2019-09-20 Tom Tromey <tom@tromey.com>
3603
3604 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3605 Update.
3606 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3607 prefix.
3608 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3609 (tui_data_window::line_from_reg_element_no)
3610 (tui_data_window::first_reg_element_no_inline)
3611 (tui_data_window::show_registers)
3612 (tui_data_window::show_register_group)
3613 (tui_data_window::display_registers_from)
3614 (tui_data_window::display_registers_from_line)
3615 (tui_data_window::first_data_item_displayed)
3616 (tui_data_window::delete_data_content_windows)
3617 (tui_data_window::erase_data_content)
3618 (tui_data_window::do_scroll_vertical)
3619 (tui_data_window::refresh_window)
3620 (tui_data_window::check_register_values): Update.
3621
3622 2019-09-20 Tom Tromey <tom@tromey.com>
3623
3624 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3625 (struct tui_locator_window) <full_name, proc_name>: Now
3626 std::string.
3627 * tui/tui-stack.c (tui_locator_window::make_status_line)
3628 (tui_locator_window::set_locator_fullname)
3629 (tui_locator_window::set_locator_info): Update.
3630 * tui/tui-source.c (tui_source_window::set_contents)
3631 (tui_source_window::showing_source_p): Update.
3632
3633 2019-09-20 Tom Tromey <tom@tromey.com>
3634
3635 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3636 Don't call tui_locator_win_info_ptr.
3637
3638 2019-09-20 Tom Tromey <tom@tromey.com>
3639
3640 * tui/tui-win.c (tui_resize_all): Don't call refresh.
3641
3642 2019-09-20 Tom Tromey <tom@tromey.com>
3643
3644 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3645 height for locator.
3646 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3647 * tui/tui-layout.c (show_source_disasm_command, show_data)
3648 (show_source_or_disasm_and_command): Use 1 as height for locator.
3649
3650 2019-09-20 Tom Tromey <tom@tromey.com>
3651
3652 * tui/tui.c (tui_enable): Update.
3653 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3654 Update.
3655 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3656 Update.
3657 * tui/tui-data.c (win_resized): Now bool.
3658 (tui_win_resized): Return bool.
3659 (tui_set_win_resized_to): Accept a bool.
3660
3661 2019-09-20 Tom Tromey <tom@tromey.com>
3662
3663 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3664 Change type of "refresh_values_only".
3665 * tui/tui-regs.c (tui_data_window::show_register_group): Change
3666 type of "refresh_values_only".
3667
3668 2019-09-20 Tom Tromey <tom@tromey.com>
3669
3670 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3671 std::string.
3672 (tui_disassemble): Add "pos" parameter.
3673 (tui_disasm_window::set_contents): Simplify.
3674
3675 2019-09-20 Tom Tromey <tom@tromey.com>
3676
3677 * tui/tui-winsource.h (struct tui_source_window_base)
3678 <show_source_content>: Now private.
3679 * tui/tui-winsource.c
3680 (tui_source_window_base::show_source_content): Don't handle empty
3681 content case.
3682
3683 2019-09-20 Tom Tromey <tom@tromey.com>
3684
3685 * tui/tui-layout.c (show_source_disasm_command)
3686 (show_source_or_disasm_and_command): Don't call
3687 show_source_content.
3688
3689 2019-09-20 Tom Tromey <tom@tromey.com>
3690
3691 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3692 Declare.
3693 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3694 from tui_make_status_line.
3695 (tui_locator_window::rerender): Update.
3696
3697 2019-09-20 Tom Tromey <tom@tromey.com>
3698
3699 * tui/tui-stack.c (tui_make_status_line): Return std::string.
3700 (tui_locator_window::rerender): Update.
3701
3702 2019-09-20 Tom Tromey <tom@tromey.com>
3703
3704 * tui/tui-winsource.h (struct tui_source_window_base)
3705 <~tui_source_window_base>: Don't declare.
3706 <fullname>: Remove.
3707 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3708 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3709 member.
3710 * tui/tui-source.c (tui_source_window::set_contents): Update.
3711 (tui_source_window::location_matches_p)
3712 (tui_source_window::maybe_update): Update.
3713
3714 2019-09-20 Tom Tromey <tom@tromey.com>
3715
3716 * tui/tui-winsource.h (~tui_source_element): Remove.
3717 (tui_source_element): Update.
3718 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3719 * tui/tui-winsource.c (tui_show_source_line): Update.
3720 * tui/tui-source.c (tui_source_window::set_contents): Update.
3721 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3722
3723 2019-09-20 Tom Tromey <tom@tromey.com>
3724
3725 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3726 declare.
3727 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3728 tui_clear_source_windows_detail.
3729 * tui/tui-winsource.h (struct tui_source_window_base)
3730 <clear_detail>: Don't declare.
3731 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3732 Remove.
3733 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3734
3735 2019-09-20 Tom Tromey <tromey@adacore.com>
3736
3737 PR ada/24919:
3738 * block.c (contained_in): Fix final return value.
3739
3740 2019-09-20 Alan Modra <amodra@gmail.com>
3741
3742 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3743 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3744 (read_indirect_string_from_dwz): Use bfd accessor.
3745 * dwarf2read.h (struct dwz_file <filename>): Likewise.
3746 * machoread.c (macho_symfile_read_all_oso): Likewise.
3747 * solib.c (solib_bfd_open): Likewise.
3748
3749 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3750
3751 * eval.c: Move declaration of overload_resolution to...
3752 * value.h: ...here.
3753
3754 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3755
3756 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3757 * arm-linux-tdep.c: Likewise.
3758 * arm-nbsd-nat.c: Likewise.
3759 * arm-tdep.h: Declare arm_apcs_32.
3760 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3761
3762 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3763
3764 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3765 * dwarf2read.h: Declare dwarf_always_disassemble.
3766
3767 2019-09-19 Tom de Vries <tdevries@suse.de>
3768
3769 PR gdb/25009
3770 * source-cache.c (source_cache::ensure): Catch exception thrown during
3771 construction of the highlighter.
3772
3773 2019-09-18 Alan Modra <amodra@gmail.com>
3774
3775 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3776 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3777 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3778 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3779 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3780 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3781 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3782 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3783 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3784 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3785 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3786 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3787 * solib-spu.c, * solib-svr4.c, * solib-target.c,
3788 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3789 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3790 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3791 * mi/mi-interp.c: Update throughout for bfd section macro and
3792 function changes.
3793 * gcore (gcore_create_callback): Use bfd_set_section_lma.
3794 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3795
3796 2019-09-18 Tom Tromey <tom@tromey.com>
3797
3798 * NEWS: Add entry.
3799 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
3800 call rl_initialize.
3801 (tui_enable): Do not call rl_initialize.
3802
3803 2019-09-18 Christian Groessler <chris@groessler.org>
3804
3805 * alpha-linux-nat.c: Include gdbarch.h.
3806
3807 2019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
3808
3809 * ui-file.c: Include cli/cli-style.h.
3810 (term_cli_styling): Remove cli_styling declaration.
3811
3812 2019-09-18 Alan Modra <amodra@gmail.com>
3813
3814 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3815 to bfd_asymbol_section.
3816
3817 2019-09-18 Alan Modra <amodra@gmail.com>
3818
3819 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3820 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3821 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3822
3823 2019-09-18 Alan Modra <amodra@gmail.com>
3824
3825 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3826 * spu-linux-nat.c (spu_bfd_open): Likewise.
3827
3828 2019-09-18 Christian Biesinger <cbiesinger@google.com>
3829
3830 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3831 to bool to match definition in dwarf2read.c.
3832
3833 2019-09-17 Christian Biesinger <cbiesinger@google.com>
3834
3835 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3836 (print_signatures): Likewise.
3837 (trust_pad_over_xvs): Likewise.
3838 * arch/aarch64-insn.c (aarch64_debug): Likewise.
3839 * arch/aarch64-insn.h (aarch64_debug): Likewise.
3840 * arm-linux-nat.c (arm_apcs_32): Likewise.
3841 * arm-linux-tdep.c (arm_apcs_32): Likewise.
3842 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3843 * arm-tdep.c (arm_debug): Likewise.
3844 (arm_apcs_32): Likewise.
3845 * auto-load.c (debug_auto_load): Likewise.
3846 (auto_load_gdb_scripts): Likewise.
3847 (global_auto_load): Likewise.
3848 (auto_load_local_gdbinit): Likewise.
3849 (auto_load_local_gdbinit_loaded): Likewise.
3850 * auto-load.h (global_auto_load): Likewise.
3851 (auto_load_local_gdbinit): Likewise.
3852 (auto_load_local_gdbinit_loaded): Likewise.
3853 * breakpoint.c (disconnected_dprintf): Likewise.
3854 (breakpoint_proceeded): Likewise.
3855 (automatic_hardware_breakpoints): Likewise.
3856 (always_inserted_mode): Likewise.
3857 (target_exact_watchpoints): Likewise.
3858 (_initialize_breakpoint): Update.
3859 * breakpoint.h (target_exact_watchpoints): Change to bool.
3860 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3861 * cli/cli-cmds.c (trace_commands): Likewise.
3862 * cli/cli-cmds.h (trace_commands): Likewise.
3863 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3864 to bool*.
3865 * cli/cli-logging.c (logging_overwrite): Change to bool.
3866 (logging_redirect): Likewise.
3867 (debug_redirect): Likewise.
3868 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3869 (struct boolean_option_def) <get_var_address_cb_>: Change return type
3870 to bool.
3871 <boolean_option_def>: Update.
3872 (struct flag_option_def): Change default type of Context to bool
3873 from int.
3874 <flag_option_def>: Change return type of var_address_cb_ to bool*.
3875 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3876 (get_setshow_command_value_string): Likewise.
3877 * cli/cli-style.c (cli_styling): Change to bool.
3878 (source_styling): Likewise.
3879 * cli/cli-style.h (source_styling): Likewise.
3880 (cli_styling): Likewise.
3881 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3882 to bool.
3883 * command.h (var_types): Update comment.
3884 (add_setshow_boolean_cmd): Change int* var argument to bool*.
3885 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3886 bool.
3887 (debug_compile_cplus_scopes): Likewise.
3888 * compile/compile-internal.h (compile_debug): Likewise.
3889 * compile/compile.c (compile_debug): Likewise.
3890 (struct compile_options) <raw>: Likewise.
3891 * cp-support.c (catch_demangler_crashes): Likewise.
3892 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3893 (usr_cmd_cris_dwarf2_cfi): Likewise.
3894 * csky-tdep.c (csky_debug): Likewise.
3895 * darwin-nat.c (enable_mach_exceptions): Likewise.
3896 * dcache.c (dcache_enabled_p): Likewise.
3897 * defs.h (info_verbose): Likewise.
3898 * demangle.c (demangle): Likewise.
3899 (asm_demangle): Likewise.
3900 * dwarf-index-cache.c (debug_index_cache): Likewise.
3901 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3902 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3903 * dwarf2read.c (check_physname): Likewise.
3904 (use_deprecated_index_sections): Likewise.
3905 (dwarf_always_disassemble): Likewise.
3906 * eval.c (overload_resolution): Likewise.
3907 * event-top.c (set_editing_cmd_var): Likewise.
3908 (exec_done_display_p): Likewise.
3909 * event-top.h (set_editing_cmd_var): Likewise.
3910 (exec_done_display_p): Likewise.
3911 * exec.c (write_files): Likewise.
3912 * fbsd-nat.c (debug_fbsd_lwp): Likewise
3913 (debug_fbsd_nat): Likewise.
3914 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
3915 Likewise.
3916 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
3917 <backtrace_past_entry> Likewise.
3918 * gdb-demangle.h (demangle): Likewise.
3919 (asm_demangle): Likewise.
3920 * gdb_bfd.c (bfd_sharing): Likewise.
3921 * gdbcore.h (write_files): Likewise.
3922 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
3923 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
3924 * gdbthread.h (print_thread_events): Likewise.
3925 * gdbtypes.c (opaque_type_resolution): Likewise.
3926 (strict_type_checking): Likewise.
3927 * gnu-nat.c (gnu_debug_flag): Likewise.
3928 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
3929 * guile/scm-param.c (pascm_variable): Add boolval.
3930 (add_setshow_generic): Update.
3931 (pascm_param_value): Update.
3932 (pascm_set_param_value_x): Update.
3933 * hppa-tdep.c (hppa_debug): Change to bool..
3934 * infcall.c (may_call_functions_p): Likewise.
3935 (coerce_float_to_double_p): Likewise.
3936 (unwind_on_signal_p): Likewise.
3937 (unwind_on_terminating_exception_p): Likewise.
3938 * infcmd.c (startup_with_shell): Likewise.
3939 * inferior.c (print_inferior_events): Likewise.
3940 * inferior.h (startup_with_shell): Likewise.
3941 (print_inferior_events): Likewise.
3942 * infrun.c (step_stop_if_no_debug): Likewise.
3943 (detach_fork): Likewise.
3944 (debug_displaced): Likewise.
3945 (disable_randomization): Likewise.
3946 (non_stop): Likewise.
3947 (non_stop_1): Likewise.
3948 (observer_mode): Likewise.
3949 (observer_mode_1): Likewise.
3950 (set_observer_mode): Update.
3951 (sched_multi): Change to bool.
3952 * infrun.h (debug_displaced): Likewise.
3953 (sched_multi): Likewise.
3954 (step_stop_if_no_debug): Likewise.
3955 (non_stop): Likewise.
3956 (disable_randomization): Likewise.
3957 * linux-tdep.c (use_coredump_filter): Likewise.
3958 (dump_excluded_mappings): Likewise.
3959 * linux-thread-db.c (auto_load_thread_db): Likewise.
3960 (check_thread_db_on_load): Likewise.
3961 * main.c (captured_main_1): Update.
3962 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
3963 xx2_opt, boolean_opt>: Change to bool.
3964 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
3965 * maint.c (maintenance_profile_p): Likewise.
3966 (per_command_time): Likewise.
3967 (per_command_space): Likewise.
3968 (per_command_symtab): Likewise.
3969 * memattr.c (inaccessible_by_default): Likewise.
3970 * mi/mi-main.c (mi_async): Likewise.
3971 (mi_async_1): Likewise.
3972 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
3973 * nat/fork-inferior.h (startup_with_shell): Likewise.
3974 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
3975 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
3976 * nios2-tdep.c (nios2_debug): Likewise.
3977 * or1k-tdep.c (or1k_debug): Likewise.
3978 * parse.c (parser_debug): Likewise.
3979 * parser-defs.h (parser_debug): Likewise.
3980 * printcmd.c (print_symbol_filename): Likewise.
3981 * proc-api.c (procfs_trace): Likewise.
3982 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
3983 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
3984 (set_parameter_value): Update.
3985 (add_setshow_generic): Update.
3986 * python/py-value.c (copy_py_bool_obj): Change argument from int*
3987 to bool*.
3988 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
3989 int*.
3990 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
3991 * record-btrace.c (record_btrace_target::store_registers): Update.
3992 * record-full.c (record_full_memory_query): Change to bool.
3993 (record_full_stop_at_limit): Likewise.
3994 * record-full.h (record_full_memory_query): Likewise.
3995 * remote-notif.c (notif_debug): Likewise.
3996 * remote-notif.h (notif_debug): Likewise.
3997 * remote.c (use_range_stepping): Likewise.
3998 (interrupt_on_connect): Likewise.
3999 (remote_break): Likewise.
4000 * ser-tcp.c (tcp_auto_retry): Likewise.
4001 * ser-unix.c (serial_hwflow): Likewise.
4002 * skip.c (debug_skip): Likewise.
4003 * solib-aix.c (solib_aix_debug): Likewise.
4004 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4005 (spu_auto_flush_cache_p): Likewise.
4006 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4007 Likewise.
4008 (struct info_print_options) <quiet>: Likewise.
4009 * symfile-debug.c (debug_symfile): Likewise.
4010 * symfile.c (auto_solib_add): Likewise.
4011 (separate_debug_file_debug): Likewise.
4012 * symfile.h (auto_solib_add): Likewise.
4013 (separate_debug_file_debug): Likewise.
4014 * symtab.c (basenames_may_differ): Likewise.
4015 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4016 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4017 (struct info_types_options) <quiet>: Likewise.
4018 * symtab.h (demangle): Likewise.
4019 (basenames_may_differ): Likewise.
4020 * target-dcache.c (stack_cache_enabled_1): Likewise.
4021 (code_cache_enabled_1): Likewise.
4022 * target.c (trust_readonly): Likewise.
4023 (may_write_registers): Likewise.
4024 (may_write_memory): Likewise.
4025 (may_insert_breakpoints): Likewise.
4026 (may_insert_tracepoints): Likewise.
4027 (may_insert_fast_tracepoints): Likewise.
4028 (may_stop): Likewise.
4029 (auto_connect_native_target): Likewise.
4030 (target_stop_and_wait): Update.
4031 (target_async_permitted): Change to bool.
4032 (target_async_permitted_1): Likewise.
4033 (may_write_registers_1): Likewise.
4034 (may_write_memory_1): Likewise.
4035 (may_insert_breakpoints_1): Likewise.
4036 (may_insert_tracepoints_1): Likewise.
4037 (may_insert_fast_tracepoints_1): Likewise.
4038 (may_stop_1): Likewise.
4039 * target.h (target_async_permitted): Likewise.
4040 (may_write_registers): Likewise.
4041 (may_write_memory): Likewise.
4042 (may_insert_breakpoints): Likewise.
4043 (may_insert_tracepoints): Likewise.
4044 (may_insert_fast_tracepoints): Likewise.
4045 (may_stop): Likewise.
4046 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4047 (make_thread_apply_all_options_def_group): Change argument from int*
4048 to bool*.
4049 (thread_apply_all_command): Update.
4050 (print_thread_events): Change to bool.
4051 * top.c (confirm): Likewise.
4052 (command_editing_p): Likewise.
4053 (history_expansion_p): Likewise.
4054 (write_history_p): Likewise.
4055 (info_verbose): Likewise.
4056 * top.h (confirm): Likewise.
4057 (history_expansion_p): Likewise.
4058 * tracepoint.c (disconnected_tracing): Likewise.
4059 (circular_trace_buffer): Likewise.
4060 * typeprint.c (print_methods): Likewise.
4061 (print_typedefs): Likewise.
4062 * utils.c (debug_timestamp): Likewise.
4063 (sevenbit_strings): Likewise.
4064 (pagination_enabled): Likewise.
4065 * utils.h (sevenbit_strings): Likewise.
4066 (pagination_enabled): Likewise.
4067 * valops.c (overload_resolution): Likewise.
4068 * valprint.h (struct value_print_options) <prettyformat_arrays,
4069 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4070 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4071 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4072 Likewise.
4073 * windows-nat.c (new_console): Likewise.
4074 (cygwin_exceptions): Likewise.
4075 (new_group): Likewise.
4076 (debug_exec): Likewise.
4077 (debug_events): Likewise.
4078 (debug_memory): Likewise.
4079 (debug_exceptions): Likewise.
4080 (useshell): Likewise.
4081 * windows-tdep.c (maint_display_all_tib): Likewise.
4082 * xml-support.c (debug_xml): Likewise.
4083
4084 2019-09-17 Mike Gulick <mgulick@mathworks.com>
4085
4086 * source.c (prepare_path_for_appending): New function.
4087 (openp): Make use of new function.
4088 (find_and_open_source): Search for the compilation directory and
4089 source file as a relative path beneath the directory search path.
4090
4091 2019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4092
4093 * source-cache.c (source_cache::get_line_charpos): Catch
4094 exceptions and return false, this matches the behaviour documented
4095 in the header file.
4096
4097 2019-09-17 Joel Brobecker <brobecker@adacore.com>
4098
4099 * ada-tasks.c (info_task): Remove quoting of the task's name.
4100
4101 2019-09-16 Christian Biesinger <cbiesinger@google.com>
4102
4103 * symfile.c (auto_solib_add): Replace comment with a reference
4104 to the header file.
4105
4106 2019-09-14 Christian Biesinger <cbiesinger@google.com>
4107
4108 * NEWS: Mention that gdb can now be compiled with Python 3
4109 on Windows.
4110
4111 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4112
4113 * maint.c (maint_print_section_data::maint_print_section_data):
4114 Force use of 'float log10 (float)' by casting the argument to
4115 float.
4116
4117 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4118
4119 * maint.c: Add 'cmath' include.
4120 (struct maint_print_section_data): New structure.
4121 (print_section_index): New function.
4122 (print_bfd_section_info): Add header comment, small whitespace
4123 cleanup, and update to call new print_section_index function.
4124 (print_objfile_section_info): Likewise.
4125 (maint_obj_section_from_bfd_section): New function.
4126 (print_bfd_section_info_maybe_relocated): New function.
4127 (maintenance_info_sections): Add header comment, always use
4128 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4129
4130 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4131
4132 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4133 inner scope, add check that the objfile has psymtabs before
4134 checking psymtabs_addrmap.
4135 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4136
4137 2019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4138
4139 * NEWS: Announce that Ada task names are now shown at more places,
4140 and between quotes (except in info task output).
4141 * gdb/ada-tasks.c (task_to_str): New function.
4142 (display_current_task_id): Call task_to_str.
4143 (task_command_1): Likewise.
4144 (print_ada_task_info): In non-mi mode, Properly align headers and data
4145 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4146
4147 2019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4148
4149 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4150 prstatus.pr_lwp.pr_info instead of making it up.
4151
4152 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4153
4154 * auto-load.c (auto_load_expand_dir_vars): Update.
4155 * defs.h (gdb_datadir): Change to std::string.
4156 (python_libdir): Likewise.
4157 (relocate_gdb_directory): Change return type to std::string.
4158 * guile/guile.c (gdbscm_data_directory): Update.
4159 (initialize_scheme_side): Update.
4160 * jit.c (jit_reader_dir): Change to std::string.
4161 (jit_reader_load_command): Update.
4162 * main.c (gdb_datadir): Change to std::string.
4163 (python_libdir): Likewise.
4164 (set_gdb_data_directory): Update.
4165 (relocate_path): Change to return std::string.
4166 (relocate_gdb_directory): Change to return std::string.
4167 (relocate_gdbinit_path_maybe_in_datadir): Update.
4168 (captured_main_1): Update.
4169 * python/python.c (do_start_initialization): Update.
4170 * top.c (show_gdb_datadir): Update.
4171 * xml-syscall.c (xml_init_syscalls_info): Update.
4172 (init_syscalls_info): Update.
4173
4174 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4175
4176 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4177 out of get_init_files.
4178 (get_init_files): Update.
4179
4180 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4181
4182 * main.c (get_init_files): Change to use std::string.
4183 (captured_main_1): Update.
4184 (print_gdb_help): Update.
4185
4186 2019-09-11 Ali Tamur <tamur@google.com>
4187
4188 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4189 implementation.
4190
4191 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4192
4193 * dbxread.c (read_dbx_symtab): Update.
4194 * dwarf2read.c (load_partial_dies): Update.
4195 * mdebugread.c (parse_partial_symbols): Update.
4196 (handle_psymbol_enumerators): Update.
4197 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4198 * psymtab.c (add_psymbol_to_bcache): Likewise.
4199 (add_psymbol_to_list): Likewise.
4200 * symtab.c (symbol_set_names): Likewise.
4201 * symtab.h (symbol_set_names): Likewise.
4202 * xcoffread.c (scan_xcoff_symtab): Update.
4203
4204 2019-09-11 Tom Tromey <tom@tromey.com>
4205
4206 * symfile-mem.c (symbol_file_add_from_memory): Use
4207 bfd_set_filename.
4208 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4209 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4210
4211 2019-09-10 Tom Tromey <tromey@adacore.com>
4212
4213 * dwarf-index-write.c (write_psymbols): Extend error message.
4214 (debug_names::insert): Add Ada code.
4215 (debug_names::write_psymbols): Remove Ada check.
4216 (debug_names) <m_string_obstack>: New member.
4217 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4218 (gdb_index_symbol_name_matcher::matches): Remove.
4219 (mapped_index_base::find_name_components_bounds): Add "lang"
4220 parameter.
4221 (mapped_index_base::build_name_components): Also split names
4222 according to Ada syntax.
4223 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4224 type of "match_callback".
4225 (check_match, check_find_bounds_finds)
4226 (dw2_expand_symtabs_matching): Update.
4227 (dw2_debug_names_iterator): Add new constructor.
4228 (dw2_debug_names_map_matching_symbols): New function.
4229 (dw2_debug_names_expand_symtabs_matching): Update.
4230 (dwarf2_debug_names_functions): Use
4231 dw2_debug_names_map_matching_symbols.
4232
4233 2019-09-10 Tom Tromey <tromey@adacore.com>
4234
4235 * dwarf2read.c (dw2_get_file_names_reader): Add the
4236 CU's file name to the results.
4237
4238 2019-09-10 Tom Tromey <tromey@adacore.com>
4239
4240 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4241 map_matching_symbols. Update.
4242 * dwarf2read.c (dw2_map_matching_symbols): Update.
4243 * psymtab.c (match_partial_symbol): Change type; update.
4244 (psym_map_matching_symbols): Likewise.
4245 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4246 type; update.
4247 * symfile.h (struct quick_symbol_functions)
4248 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4249 Remove "match".
4250
4251 2019-09-10 Tom Tromey <tromey@adacore.com>
4252
4253 * psymtab.c (map_block): Remove.
4254 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4255 * symtab.c (iterate_over_symbols_terminated): New function.
4256 * symtab.c (iterate_over_symbols_terminated): Declare.
4257
4258 2019-09-10 Tom Tromey <tromey@adacore.com>
4259
4260 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4261 * language.h (struct language_defn) <la_iterate_over_symbols>:
4262 Return bool.
4263 * symtab.c (iterate_over_symbols): Return bool.
4264 * symtab.h (iterate_over_symbols): Return bool.
4265
4266 2019-09-10 Tom Tromey <tromey@adacore.com>
4267
4268 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4269 (add_nonlocal_symbols): Update.
4270 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4271 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4272 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4273 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4274 Change type of "callback". Remove "data".
4275
4276
4277 2019-09-09 Ali Tamur <tamur@google.com>
4278
4279 * dwarf2read.c (comp_unit_head): Update comment.
4280 (dwarf2_dwo_name): New function declaration.
4281 (dwarf_unit_type_name): New function declaration.
4282 (read_comp_unit_head): Add support for new compilation units,
4283 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4284 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4285 (currently named as "signature") in their header. Also clarify error
4286 messages.
4287 (lookup_dwo_id): New function. Returns the dwo id of the given
4288 compile unit.
4289 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4290 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4291 functions.
4292 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4293 (dwarf2_dwo_name): Get the dwo name if present.
4294 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4295 purposes.
4296
4297 2019-09-09 Tom Tromey <tom@tromey.com>
4298
4299 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4300
4301 2019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4302
4303 * python/python.c (do_start_initialization): Make progname_copy static,
4304 to avoid a leak report.
4305
4306 2019-09-08 Tom Tromey <tom@tromey.com>
4307
4308 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4309
4310 2019-09-07 Simon Marchi <simon.marchi@efficios.com>
4311
4312 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4313 Change type to gdb::optional<block_enum>.
4314 (dw2_symtab_iter_init): Change block_index parameter type
4315 to gdb::optional<block_enum>.
4316 (dw2_lookup_symbol): Change block_index parameter
4317 type to block_enum.c
4318 (dw2_debug_names_lookup_symbol): Likewise.
4319 * psymtab.c (psym_lookup_symbol): Likewise.
4320 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4321 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4322 Likewise.
4323
4324 2019-09-06 Christian Biesinger <cbiesinger@google.com>
4325
4326 * defs.h (relocate_gdb_directory): Change int to bool in
4327 signature and rename flag to relocatable.
4328 * main.c (relocate_path): Likewise.
4329 (relocate_gdb_directory): Likewise.
4330
4331 2019-09-06 Alan Modra <amodra@gmail.com>
4332
4333 * coffread.c (coff_symfile_read): Constify filename variable.
4334 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4335 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4336 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4337 * solib.c (reload_shared_libraries_1): Likewise.
4338 * symfile.c (reread_symbols): Likewise.
4339 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4340 * solib-darwin.c (darwin_bfd_open): Likewise.
4341 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4342
4343 2019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4344
4345 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4346 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4347
4348 2019-09-03 Tom Tromey <tromey@adacore.com>
4349
4350 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4351 types.
4352 (has_negatives): Unbias a range type bound.
4353 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4354 * gdbtypes.c (operator==): Handle new field.
4355 (create_range_type): Add "bias" parameter.
4356 (create_static_range_type, resolve_dynamic_range): Update.
4357 * gdbtypes.h (struct range_bounds) <bias>: New member.
4358 (create_range_type): Add bias parameter.
4359 * printcmd.c (print_scalar_formatted): Unbias range types.
4360 * value.c (unpack_long): Unbias range types.
4361 (pack_long): Bias range types.
4362
4363 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4364
4365 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4366 probe arguments.
4367
4368 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4369
4370 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4371 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4372 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4373 (compile_probe_arg): Likewise.
4374 * probe.h (get_argument_count): Likewise.
4375 * solib-svr4.c (solib_event_probe_action): Likewise.
4376 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4377
4378 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4379
4380 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4381 code to here...
4382 (svr4_create_solib_event_breakpoints): ...from here.
4383
4384 2019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4385
4386 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4387 suffix from warning message.
4388
4389 2019-08-30 Tom Tromey <tom@tromey.com>
4390
4391 * tui/tui-winsource.h (struct tui_source_window_base)
4392 <refresh_all>: Don't declare.
4393 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4394 Remove.
4395 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4396 tui_show_locator_content.
4397 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4398 declare.
4399 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4400 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4401 declare.
4402
4403 2019-08-30 Tom Tromey <tom@tromey.com>
4404
4405 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4406
4407 2019-08-30 Tom Tromey <tom@tromey.com>
4408
4409 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4410 Remove unnecessary forward declarations.
4411
4412 2019-08-30 Tom Tromey <tom@tromey.com>
4413
4414 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4415 rerender.
4416 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4417 tui_show_locator_content.
4418
4419 2019-08-30 Tom Tromey <tom@tromey.com>
4420
4421 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4422 (tui_locator_window::rerender): Rewrite using body of previous
4423 tui_show_locator_content.
4424
4425 2019-08-30 Tom Tromey <tom@tromey.com>
4426
4427 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4428 set_locator_fullname>: New methods.
4429 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4430 Rename from tui_set_locator_fullname.
4431 (tui_locator_window::set_locator_info): Rename from
4432 tui_set_locator_info. Return bool.
4433 (tui_update_locator_fullname, tui_show_frame_info): Update.
4434
4435 2019-08-30 Tom Tromey <tom@tromey.com>
4436
4437 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4438
4439 2019-08-30 Tom Tromey <tom@tromey.com>
4440
4441 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4442 call touchwin.
4443
4444 2019-08-30 Tom Tromey <tom@tromey.com>
4445
4446 * tui/tui-wingeneral.c (box_win): Assume win_info and
4447 win_info->handle cannot be NULL.
4448
4449 2019-08-30 Tom Tromey <tom@tromey.com>
4450
4451 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4452 refresh_window>: Declare.
4453 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4454 resize.
4455 (tui_data_item_window::rerender): Rename from
4456 tui_display_register.
4457 (tui_data_item_window::refresh_window): New method.
4458 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4459 no-op.
4460
4461 2019-08-30 Tom Tromey <tom@tromey.com>
4462
4463 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4464 regs_column_count, current_group>: Move later. Now private.
4465 <get_current_group>: New method.
4466 * tui/tui-regs.c (tui_reg_command): Update.
4467 * tui/tui-layout.c (tui_set_layout): Update.
4468
4469 2019-08-30 Tom Tromey <tom@tromey.com>
4470
4471 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4472 (tui_data_window::rerender): Don't call
4473 check_and_display_highlight_if_needed.
4474 (tui_data_window::refresh_all): Remove call to
4475 erase_data_content.
4476
4477 2019-08-30 Tom Tromey <tom@tromey.com>
4478
4479 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4480 (tui_data_window::display_registers_from)
4481 (tui_data_window::display_reg_element_at_line)
4482 (tui_data_window::display_registers_from_line): Remove checks of
4483 "empty".
4484
4485 2019-08-30 Tom Tromey <tom@tromey.com>
4486
4487 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4488 Don't declare.
4489 * tui/tui-regs.c (tui_data_window::show_registers): Call
4490 rerender.
4491 (tui_data_window::rerender): Rename from display_all_data.
4492 (tui_data_window::rerender): Remove old implementation.
4493
4494 2019-08-30 Tom Tromey <tom@tromey.com>
4495
4496 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4497 text.
4498 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4499
4500 2019-08-29 Bernhard Wodok <barto@gmx.net>
4501 Sergio Durigan Junior <sergiodj@redhat.com>
4502
4503 PR win32/24284
4504 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4505
4506 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4507
4508 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4509 when searching for types.
4510
4511 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4512
4513 * f-lang.c (f_language_defn): Use f_print_typedef.
4514 * f-lang.h (f_print_typedef): Declare.
4515 * f-typeprint.c (f_print_typedef): Define.
4516
4517 2019-08-27 Christian Biesinger <cbiesinger@google.com>
4518
4519 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4520
4521 2019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4522
4523 * cli/cli-utils.c (info_print_options_defs): Delete.
4524 (make_info_print_options_def_group): Delete.
4525 (extract_info_print_options): Delete.
4526 (info_print_command_completer): Delete.
4527 (info_print_args_help): Add extra parameter, and optionally
4528 include text about -n flag.
4529 * cli/cli-utils.h (struct info_print_options): Delete.
4530 (extract_info_print_options): Delete declaration.
4531 (info_print_command_completer): Delete declaration.
4532 (info_print_args_help): Add extra parameter, extend header
4533 comment.
4534 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4535 search_symbols.
4536 * stack.c (struct info_print_options): New type.
4537 (info_print_options_defs): New file scoped variable.
4538 (make_info_print_options_def_group): New static function.
4539 (info_print_command_completer): New static function.
4540 (info_locals_command): Update to use new local functions.
4541 (info_args_command): Likewise.
4542 (_initialize_stack): Add extra parameter to calls to
4543 info_print_args_help.
4544 * symtab.c (search_symbols): Add extra parameter, use this to
4545 possibly excluse non-debug symbols.
4546 (symtab_symbol_info): Add extra parameter, which is passed on to
4547 search_symbols.
4548 (struct info_print_options): New type.
4549 (info_print_options_defs): New file scoped variable.
4550 (make_info_print_options_def_group): New static function.
4551 (info_print_command_completer): New static function.
4552 (info_variables_command): Update to use local functions, and pass
4553 extra parameter through to symtab_symbol_info.
4554 (info_functions_command): Likewise.
4555 (info_types_command): Pass additional argument through to
4556 symtab_symbol_info.
4557 (rbreak_command): Pass extra argument to search_symbols.
4558 (_initialize_symtab): Add extra arguments for calls to
4559 info_print_args_help, and update help text for 'info variables',
4560 'whereis', and 'info functions' commands.
4561 * symtab.h (search_symbols): Add extra argument to declaration.
4562 * NEWS: Mention new flags.
4563
4564 2019-08-26 Christian Biesinger <cbiesinger@google.com>
4565
4566 * symtab.c (lookup_static_symbol): Call the new function (and move
4567 it down to be next to lookup_global_symbol).
4568 (struct global_sym_lookup_data): Add block_enum member and rename to...
4569 (struct global_or_static_sym_lookup_data): ...this.
4570 (lookup_symbol_global_iterator_cb): Pass block_index instead of
4571 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4572 (lookup_symbol_global_or_static_iterator_cb): ...this.
4573 (lookup_global_or_static_symbol): New function.
4574 (lookup_global_symbol): Call new function.
4575
4576 2019-08-26 Tom de Vries <tdevries@suse.de>
4577
4578 PR c++/24852
4579 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4580 when pc_probe.prob == NULL.
4581
4582 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
4583
4584 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4585 variable symbol_linkage to symbol_linkage_.
4586
4587 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
4588
4589 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4590 represent whether the symbol is static, dynamic, or we don't
4591 know.
4592
4593 2019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
4594
4595 * gdb/rx-tdep.c (rx_register_names): New.
4596 (rx_register_name): Delete.
4597 (rx_psw_type): Delete.
4598 (rx_fpsw_type): Delete.
4599 (rx_register_type): Delete.
4600 (rx_gdbarch_init): Convert target-descriptions.
4601 (_initialize_rx_tdep): Add initialize_tdesc_rx.
4602 * gdb/features/Makefile: Add rx.xml.
4603 * gdb/features/rx.xml: New.
4604 * gdb/features/rx.c: Generated.
4605 * gdb/NEWS: Mention target description support.
4606
4607 2019-08-22 Christian Biesinger <cbiesinger@google.com>
4608
4609 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4610 *slot_ptr.
4611
4612 2019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
4613
4614 * configure.ac: Don't check for 'dlfcn.h' (moved to
4615 gdbsupport/common.m4).
4616 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4617 'gdbsupport/'.
4618 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4619 * compile/compile-c-support.c: Include
4620 'gdbsupport/gdb-dlfcn.h'.
4621 * gdbsupport/common.m4: Check for 'dlfcn.h'.
4622 * gdb-dlfcn.c: Move to...
4623 * gdbsupport/gdb-dlfcn.c: ... here.
4624 * gdb-dlfcn.h: Move to...
4625 * gdbsupport/gdb-dlfcn.h: ... here.
4626
4627 2019-08-23 Sandra Loosemore <sandra@codesourcery.com>
4628
4629 * nios2-tdep.c (struct reg_value): Improve comments. Make
4630 the offset field signed.
4631
4632 2019-08-22 Christian Biesinger <cbiesinger@google.com>
4633
4634 * python/lib/gdb/__init__.py (_execute_file): New function.
4635 * python/python.c (python_run_simple_file): Call gdb._execute_file
4636 on Windows.
4637
4638 2019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
4639
4640 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4641 all uses as this was never set to anything but a zero value.
4642
4643 2019-08-21 Bogdan Harjoc <harjoc@gmail.com>
4644
4645 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4646
4647 2019-08-21 Christian Biesinger <cbiesinger@google.com>
4648
4649 * tui/tui-data.h (tui_gen_win_info): Add an =default
4650 move constructor, required by some GCC versions.
4651
4652 2019-08-21 Jinke Fan <fanjinke51@yeah.net>
4653
4654 * go32-nat.c (go32_sysinfo): Add hygon_p.
4655
4656 2019-08-20 Tom Tromey <tom@tromey.com>
4657
4658 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4659 line_from_reg_element_no, first_reg_element_no_inline,
4660 display_all_data, delete_data_content_windows,
4661 erase_data_content>: Now private.
4662
4663 2019-08-20 Tom Tromey <tom@tromey.com>
4664
4665 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4666 (tui_unhighlight_win, tui_highlight_win)
4667 (tui_win_info::make_window): Update.
4668 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4669
4670 2019-08-20 Tom Tromey <tom@tromey.com>
4671
4672 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4673 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4674 (MAX_PID_WIDTH): Move to tui-stack.c.
4675 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4676 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4677 (MAX_PID_WIDTH): Move from tui-data.h.
4678
4679 2019-08-20 Tom Tromey <tom@tromey.com>
4680
4681 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4682 * tui/tui-wingeneral.c (box_win): Change type of win_info.
4683 (box_win): Update.
4684 (tui_gen_win_info::make_window): Rename from tui_make_window.
4685 (tui_win_info::make_window): New method.
4686 (tui_gen_win_info::make_visible): Update.
4687 * tui/tui-source.c (tui_source_window::set_contents): Update.
4688 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4689 (tui_data_window::display_registers_from): Update.
4690 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4691 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4692 Declare.
4693 <can_box>: Remove.
4694 <title>: Remove.
4695 (struct tui_win_info) <make_window>: Declare.
4696 <can_box>: Now virtual.
4697 <title>: New member.
4698 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4699 * tui/tui-command.c (tui_cmd_window::resize): Update.
4700
4701 2019-08-20 Tom Tromey <tom@tromey.com>
4702
4703 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4704 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4705 (tui_data_window::check_register_values): Update.
4706
4707 2019-08-20 Tom Tromey <tom@tromey.com>
4708
4709 * tui/tui-regs.h (struct tui_data_window): Use
4710 DISABLE_COPY_AND_ASSIGN.
4711 <regs_content>: Change type, removing unique_ptr.
4712 <tui_data_window>: Add move constructor.
4713 * tui/tui-regs.c (tui_data_window::show_registers)
4714 (tui_data_window::show_register_group)
4715 (tui_data_window::display_registers_from)
4716 (tui_data_window::display_registers_from)
4717 (tui_data_window::first_data_item_displayed)
4718 (tui_data_window::delete_data_content_windows)
4719 (tui_data_window::rerender, tui_data_window::refresh_window)
4720 (tui_data_window::check_register_values): Update.
4721
4722 2019-08-20 Tom Tromey <tom@tromey.com>
4723
4724 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4725 show_register_group>: Declare.
4726 (tui_show_register_group): Don't declare.
4727 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4728 tui_show_registers.
4729 (tui_data_window::show_register_group): Rename from
4730 tui_show_register_group.
4731 (tui_data_window::check_register_values, tui_reg_command):
4732 Update.
4733 * tui/tui-layout.c (tui_set_layout): Update.
4734
4735 2019-08-20 Tom Tromey <tom@tromey.com>
4736
4737 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4738 Declare.
4739 (tui_check_register_values): Don't declare.
4740 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4741 from tui_check_register_values.
4742 * tui/tui-hooks.c (tui_register_changed): Update.
4743
4744 2019-08-20 Tom Tromey <tom@tromey.com>
4745
4746 * tui/tui-regs.c (tui_reg_layout): Move later.
4747 (tui_show_registers): Don't enable TUI mode or change layout.
4748
4749 2019-08-20 Tom Tromey <tom@tromey.com>
4750
4751 * tui/tui-regs.h (struct tui_data_item_window)
4752 <~tui_data_item_window>: Remove.
4753 <content>: Now a unique_xmalloc_ptr.
4754 * tui/tui-regs.c (tui_register_format): Return a
4755 unique_xmalloc_ptr.
4756 (tui_get_register): Update.
4757 (~tui_data_item_window): Remove.
4758 (tui_data_window::display_registers_from, tui_display_register):
4759 Update.
4760 * tui/tui-io.h (tui_expand_tabs): Update.
4761 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4762 Remove "col" parameter.
4763
4764 2019-08-20 Tom Tromey <tom@tromey.com>
4765
4766 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4767 field.
4768 * tui/tui-regs.c (~tui_data_item_window): Update.
4769
4770 2019-08-20 Tom Tromey <tom@tromey.com>
4771
4772 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4773 earlier.
4774
4775 2019-08-20 Tom Tromey <tom@tromey.com>
4776
4777 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4778
4779 2019-08-20 Tom Tromey <tom@tromey.com>
4780
4781 * tui/tui-source.h (struct tui_source_window): Update.
4782 * tui/tui-regs.c (tui_show_registers): Update.
4783 * tui/tui-disasm.h (struct tui_disasm_window): Update.
4784 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4785 (NO_REGS_STRING): Remove defines.
4786
4787 2019-08-20 Conrad Meyer <cem@FreeBSD.org>
4788
4789 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4790 unnecessary thread walk if remote doesn't support the packet.
4791
4792 2019-08-19 Tom Tromey <tromey@adacore.com>
4793
4794 * python/py-value.c (value_has_field): Fix indentation.
4795
4796 2019-08-19 Tom Tromey <tromey@adacore.com>
4797
4798 * printcmd.c (do_one_display, info_display_command): Update.
4799 * block.h (contained_in): Return bool. Add allow_nested
4800 parameter.
4801 * block.c (contained_in): Return bool. Add allow_nested
4802 parameter.
4803
4804 2019-08-19 Tom Tromey <tom@tromey.com>
4805
4806 * configure: Rebuild.
4807 * configure.ac: Disallow the combination of -static-libstdc++ and
4808 source highlight.
4809 * source-cache.c (get_language_name): Handle rust.
4810 (source_cache::get_source_lines): Ignore highlighting exceptions.
4811
4812 2019-08-16 Tom Tromey <tom@tromey.com>
4813
4814 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4815 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4816 (struct tui_source_window_base) <make_visible, refresh_window,
4817 resize>: Remove methods.
4818 <execution_info>: Remove field.
4819 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4820 (tui_show_source_line, tui_source_window_base)
4821 (~tui_source_window_base): Update.
4822 (tui_source_window_base::resize)
4823 (tui_source_window_base::make_visible)
4824 (tui_source_window_base::refresh_window): Remove.
4825 (tui_source_window_base::update_exec_info): Update.
4826 * tui/tui-source.c (tui_source_window::set_contents): Update.
4827 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4828
4829 2019-08-16 Tom Tromey <tom@tromey.com>
4830
4831 * tui/tui-hooks.c (tui_remove_hooks): Don't set
4832 deprecated_query_hook.
4833
4834 2019-08-16 Tom Tromey <tom@tromey.com>
4835
4836 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4837 (tui_update_source_windows_with_line): Update.
4838 * tui/tui-source.h (struct tui_source_window)
4839 <show_symtab_source>: Declare.
4840 (tui_show_symtab_source): Don't declare.
4841 * tui/tui-source.c (tui_show_symtab_source): Rename from
4842 tui_show_symtab_source.
4843
4844 2019-08-16 Tom Tromey <tom@tromey.com>
4845
4846 * tui/tui-winsource.h (struct tui_source_window_base)
4847 <set_contents>: Declare.
4848 * tui/tui-winsource.c
4849 (tui_source_window_base::update_source_window_as_is): Update.
4850 * tui/tui-source.h (struct tui_source_window) <set_contents>:
4851 Declare.
4852 (tui_set_source_content): Don't declare.
4853 * tui/tui-source.c (tui_source_window::set_contents): Rename from
4854 tui_set_source_content.
4855 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4856 Declare.
4857 (tui_set_disassem_content): Don't declare.
4858 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4859 tui_set_disassem_content.
4860
4861 2019-08-16 Tom Tromey <tom@tromey.com>
4862
4863 * tui/tui-winsource.h (struct tui_source_window_base)
4864 <update_breakpoint_info>: Declare.
4865 (tui_update_breakpoint_info): Don't declare.
4866 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4867 (tui_update_all_breakpoint_info): Update.
4868 (tui_source_window_base::update_breakpoint_info): Rename from
4869 tui_update_breakpoint_info.
4870 (tui_source_window_base::update_exec_info): Update.
4871
4872 2019-08-16 Tom Tromey <tom@tromey.com>
4873
4874 * tui/tui-winsource.h (struct tui_source_window_base)
4875 <update_source_window>: Declare.
4876 (tui_update_source_window): Don't declare.
4877 * tui/tui-winsource.c
4878 (tui_source_window_base::update_source_window): Rename from
4879 tui_update_source_window.
4880 (tui_source_window_base::rerender): Update.
4881 * tui/tui-source.c (tui_source_window::maybe_update): Update.
4882 * tui/tui-disasm.c (tui_show_disassem)
4883 (tui_show_disassem_and_update_source)
4884 (tui_disasm_window::maybe_update): Update.
4885
4886 2019-08-16 Tom Tromey <tom@tromey.com>
4887
4888 * tui/tui-winsource.h (struct tui_source_window_base)
4889 <update_source_window_as_is>: Declare.
4890 (tui_update_source_window_as_is): Don't declare.
4891 * tui/tui-winsource.c (tui_update_source_window): Update
4892 (tui_source_window_base::update_source_window_as_is): Rename from
4893 tui_update_source_window_as_is.
4894 (tui_source_window_base::refill): Update.
4895 * tui/tui-source.c (tui_show_symtab_source): Update.
4896 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4897 Update.
4898
4899 2019-08-16 Tom Tromey <tom@tromey.com>
4900
4901 * tui/tui-winsource.h (tui_update_source_window)
4902 (tui_update_source_window_as_is): Remove "noerror" parameter.
4903 * tui/tui-winsource.c (tui_update_source_window)
4904 (tui_update_source_window_as_is): Remove "noerror" parameter.
4905 (tui_update_source_windows_with_addr)
4906 (tui_update_source_windows_with_line)
4907 (tui_source_window_base::rerender)
4908 (tui_source_window_base::refill): Update.
4909 * tui/tui-source.h (tui_set_source_content)
4910 (tui_show_symtab_source): Remove "noerror" parameter.
4911 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
4912 parameter.
4913 (tui_show_symtab_source): Likewise.
4914 (tui_source_window::maybe_update): Update.
4915 * tui/tui-disasm.c (tui_show_disassem)
4916 (tui_show_disassem_and_update_source)
4917 (tui_disasm_window::do_scroll_vertical)
4918 (tui_disasm_window::maybe_update): Update.
4919
4920 2019-08-16 Tom Tromey <tom@tromey.com>
4921
4922 * tui/tui.c (tui_is_window_visible): Update.
4923 * tui/tui-wingeneral.c (tui_make_window)
4924 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
4925 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
4926 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
4927 (tui_set_win_height_command, parse_scrolling_args): Update.
4928 * tui/tui-source.c (tui_source_window::style_changed): Update.
4929 * tui/tui-regs.c (tui_show_registers)
4930 (tui_data_window::first_data_item_displayed)
4931 (tui_data_window::delete_data_content_windows)
4932 (tui_check_register_values, tui_reg_command): Update.
4933 * tui/tui-disasm.c (tui_show_disassem): Update.
4934 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
4935 method.
4936 <is_visible>: Remove field.
4937 * tui/tui-data.c (tui_next_win, tui_prev_win)
4938 (tui_delete_invisible_windows): Update.
4939
4940 2019-08-16 Tom Tromey <tom@tromey.com>
4941
4942 * tui/tui-winsource.h (struct tui_source_window_base)
4943 <m_has_locator>: Remove.
4944 * tui/tui-layout.c (show_source_disasm_command, show_data)
4945 (show_source_or_disasm_and_command): Update.
4946
4947 2019-08-16 Alan Hayward <alan.hayward@arm.com>
4948
4949 * NEWS (Other MI changes): New subsection.
4950 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
4951 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
4952 * arch-utils.c (default_get_pc_address_flags): New function.
4953 * arch-utils.h (default_get_pc_address_flags): New declaration.
4954 * gdbarch.sh: Add get_pc_address_flags.
4955 * gdbarch.c: Regenerate.
4956 * gdbarch.h: Likewise.
4957 * stack.c (print_pc): New function.
4958 (print_frame_info) (print_frame): Call print_pc.
4959
4960 2019-08-16 Tom de Vries <tdevries@suse.de>
4961
4962 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
4963 print_objfile_section_info.
4964
4965 2019-08-15 Tom Tromey <tom@tromey.com>
4966
4967 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
4968 calling update_cmdwin_start_line.
4969 * tui/tui-winsource.h (struct tui_source_window_base)
4970 <do_make_visible_with_new_height, set_new_height>: Don't declare.
4971 <rerender>: Declare.
4972 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
4973 Call rerender.
4974 (tui_source_window_base::set_new_height): Remove.
4975 (tui_source_window_base::rerender): Rename from
4976 do_make_visible_with_new_height.
4977 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
4978 resize method.
4979 (tui_win_info::make_invisible_and_set_new_height)
4980 (tui_win_info::make_visible_with_new_height): Remove.
4981 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
4982 Declare.
4983 * tui/tui-stack.c (tui_locator_window::rerender): New method.
4984 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
4985 do_make_visible_with_new_height>: Don't declare.
4986 <rerender>: Declare.
4987 * tui/tui-regs.c (tui_data_window::rerender): Rename from
4988 set_new_height.
4989 (tui_data_window::do_make_visible_with_new_height): Remove.
4990 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
4991 call tui_show_locator_content.
4992 (tui_gen_win_info::resize): Call rerender.
4993 (show_source_or_disasm_and_command): Don't call
4994 tui_show_locator_content.
4995 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
4996 method.
4997 (struct tui_win_info) <rerender>: Declare.
4998 <set_new_height, make_invisible_and_set_new_height,
4999 make_visible_with_new_height>: Don't declare.
5000 * tui/tui-data.c (tui_win_list::rerender): New method.
5001 * tui/tui-command.h (struct tui_cmd_window)
5002 <do_make_visible_with_new_height>: Don't declare.
5003 * tui/tui-command.c
5004 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5005
5006 2019-08-15 Tom Tromey <tromey@adacore.com>
5007
5008 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5009 * ada-lang.c (ada_enum_name): Likewise.
5010
5011 2019-08-15 Christian Biesinger <cbiesinger@google.com>
5012
5013 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5014 leading underscore.
5015 (GdbOutputErrorFile): Likewise.
5016 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5017 accordingly.
5018 (execute_unwinders): Rename to have a leading underscore.
5019 (auto_load_packages): Likewise.
5020 (global scope): Adjust call to auto_load_packages accordingly.
5021 (GdbSetPythonDirectory): Likewise.
5022 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5023 instead of execute_unwinders.
5024
5025 2019-08-15 Tom Tromey <tom@tromey.com>
5026
5027 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5028 (show_data): Don't change window visibility.
5029 (tui_gen_win_info::resize): Remove special case for command
5030 window. Use wresize, when available.
5031 (show_source_or_disasm_and_command): Don't change window
5032 visibility.
5033 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5034 <make_visible>: New method.
5035 * tui/tui-command.c (tui_cmd_window::resize): New method.
5036
5037 2019-08-15 Tom Tromey <tom@tromey.com>
5038
5039 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5040 (struct tui_source_windows): New.
5041 * tui/tui-winsource.c (tui_display_main): Update.
5042 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5043 (new_height_ok, parse_scrolling_args): Update.
5044 * tui/tui-layout.c (show_layout, show_data): Update.
5045 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5046 (tui_add_to_source_windows): Don't declare.
5047 * tui/tui-data.c (source_windows, tui_source_windows)
5048 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5049
5050 2019-08-15 Tom Tromey <tom@tromey.com>
5051
5052 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5053 Rename from reset.
5054 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5055 * tui/tui-layout.c (show_source_disasm_command, show_data):
5056 Update.
5057 (tui_gen_win_info::resize): Rename.
5058 (show_source_or_disasm_and_command): Update.
5059 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5060 reset.
5061
5062 2019-08-15 Tom Tromey <tom@tromey.com>
5063
5064 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5065 * tui/tui-interp.c (tui_interp::init): Don't call
5066 tui_initialize_static_data.
5067 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5068
5069 2019-08-15 Tom Tromey <tom@tromey.com>
5070
5071 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5072 examine tui_win_list.
5073
5074 2019-08-15 Tom Tromey <tom@tromey.com>
5075
5076 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5077 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5078 tui_clear_source_content.
5079 (tui_clear_source_content): Remove.
5080 (tui_source_window_base::do_erase_source_content): Hoist call to
5081 content.clear().
5082 * tui/tui-stack.c (tui_show_frame_info): Don't call
5083 tui_clear_source_content.
5084
5085 2019-08-15 Tom Tromey <tom@tromey.com>
5086
5087 * tui/tui-winsource.h (struct tui_source_window_base)
5088 <do_erase_source_content>: New method.
5089 <erase_source_content>: New method.
5090 (tui_erase_source_content): Don't declare.
5091 * tui/tui-winsource.c (tui_clear_source_content): Update.
5092 (tui_source_window_base::do_erase_source_content): Rename from
5093 tui_erase_source_content.
5094 (tui_source_window_base::show_source_content): Update.
5095 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5096 * tui/tui-source.h (struct tui_source_window)
5097 <erase_source_content>: New method.
5098 * tui/tui-disasm.h (struct tui_disasm_window)
5099 <erase_source_content>: New method.
5100
5101 2019-08-15 Tom Tromey <tom@tromey.com>
5102
5103 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5104 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5105 constructor.
5106 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5107 * tui/tui-source.c (tui_set_source_content): Update.
5108 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5109
5110 2019-08-15 Tom Tromey <tom@tromey.com>
5111
5112 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5113 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5114 tui-source.c.
5115 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5116 Declare.
5117 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5118 method.
5119 (tui_source_window::maybe_update): Update.
5120
5121 2019-08-15 Tom Tromey <tom@tromey.com>
5122
5123 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5124 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5125 tui-disasm.c.
5126 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5127 Declare.
5128 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5129 method.
5130 (tui_disasm_window::maybe_update): Update.
5131
5132 2019-08-15 Tom Tromey <tom@tromey.com>
5133
5134 * tui/tui-winsource.h (struct tui_source_window_base)
5135 <maybe_update>: Declare.
5136 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5137 method.
5138 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5139 Declare.
5140 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5141 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5142 Declare.
5143 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5144
5145 2019-08-15 Tom Tromey <tom@tromey.com>
5146
5147 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5148
5149 2019-08-15 Tom Tromey <tom@tromey.com>
5150
5151 * tui/tui-wingeneral.c: Include tui-stack.h.
5152 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5153 (struct tui_locator_window): Move from tui-data.h.
5154 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5155 (tui_initialize_static_data): Move from tui-data.c.
5156 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5157 (struct tui_locator_window): Move to tui-stack.c.
5158 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5159 (tui_initialize_static_data): Move to tui-stack.c.
5160
5161 2019-08-15 Tom Tromey <tom@tromey.com>
5162
5163 * tui/tui-layout.c (show_source_disasm_command)
5164 (show_source_or_disasm_and_command): Use make_visible method, not
5165 tui_make_window.
5166 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5167 Remove.
5168
5169 2019-08-15 Tom Tromey <tom@tromey.com>
5170
5171 * tui/tui-wingeneral.h (tui_make_window): Update.
5172 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5173 parameter.
5174 (tui_gen_win_info::make_visible): Update.
5175 * tui/tui-regs.c (tui_data_window::display_registers_from):
5176 Update.
5177 * tui/tui-layout.c (show_source_disasm_command)
5178 (show_source_or_disasm_and_command): Update.
5179 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5180 (enum tui_box): Remove.
5181 (struct tui_win_info) <can_box>: New method.
5182 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5183 method.
5184
5185 2019-08-15 Tom de Vries <tdevries@suse.de>
5186
5187 * linux-nat-trad.c: Include gdbarch.h.
5188
5189 2019-08-14 Alan Hayward <alan.hayward@arm.com>
5190
5191 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5192 register sizes.
5193
5194 2019-08-14 Tom Tromey <tromey@adacore.com>
5195
5196 * darwin-nat.c: Include gdbarch.h.
5197 * darwin-nat-info.c: Include gdbarch.h.
5198
5199 2019-08-13 Tom Tromey <tom@tromey.com>
5200
5201 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5202 Remove.
5203 * tui/tui-data.c (tui_initialize_static_data): Update.
5204
5205 2019-08-13 Tom Tromey <tom@tromey.com>
5206
5207 * tui/tui-winsource.h (struct tui_exec_info_window)
5208 <~tui_exec_info_window, maybe_allocate_content, get_content,
5209 m_content>: Remove.
5210 (struct tui_source_window_base) <set_exec_info_content,
5211 show_exec_info_content>: Don't declare.
5212 * tui/tui-winsource.c
5213 (tui_exec_info_window::maybe_allocate_content): Remove.
5214 (tui_source_window_base::update_exec_info): Rename from
5215 set_exec_info_content.
5216 (tui_source_window_base::show_exec_info_content)
5217 (tui_source_window_base::update_exec_info): Remove.
5218
5219 2019-08-13 Tom Tromey <tom@tromey.com>
5220
5221 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5222 declare.
5223 * tui/tui-winsource.c (tui_update_source_window_as_is)
5224 (tui_update_source_windows_with_addr, tui_erase_source_content):
5225 Update.
5226 (tui_clear_exec_info_content): Remove.
5227
5228 2019-08-13 Tom Tromey <tom@tromey.com>
5229
5230 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5231 declare.
5232 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5233 call tui_erase_exec_info_content.
5234 (tui_clear_exec_info_content): Rename from
5235 tui_erase_exec_info_content.
5236 (tui_clear_exec_info_content): Delete.
5237
5238 2019-08-13 Tom Tromey <tom@tromey.com>
5239
5240 * tui/tui-winsource.h (struct tui_source_window_base)
5241 <show_exec_info_content>: Declare.
5242 (tui_show_exec_info_content): Don't declare.
5243 * tui/tui-winsource.c
5244 (tui_source_window_base::show_exec_info_content): Rename from
5245 tui_show_exec_info_content.
5246 (tui_source_window_base::update_exec_info): Update.
5247
5248 2019-08-13 Tom Tromey <tom@tromey.com>
5249
5250 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5251 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5252 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5253 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5254 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5255 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5256 ... here.
5257
5258 2019-08-13 Tom Tromey <tom@tromey.com>
5259
5260 * tui/tui-winsource.h (struct tui_source_window_base)
5261 <update_exec_info>: Declare.
5262 (tui_update_exec_info): Don't declare.
5263 * tui/tui-winsource.c (tui_update_source_window_as_is)
5264 (tui_source_window_base::refresh_all)
5265 (tui_update_all_breakpoint_info): Update.
5266 (tui_source_window_base::update_exec_info): Rename from
5267 tui_update_exec_info.
5268 * tui/tui-stack.c (tui_show_frame_info): Update.
5269
5270 2019-08-13 Tom Tromey <tom@tromey.com>
5271
5272 * tui/tui-winsource.h (struct tui_source_window_base)
5273 <set_exec_info_content>: Declare.
5274 (tui_set_exec_info_content): Don't declare.
5275 * tui/tui-winsource.c
5276 (tui_source_window_base::set_exec_info_content): Rename from
5277 tui_set_exec_info_content.
5278 (tui_update_exec_info): Update.
5279
5280 2019-08-13 Tom Tromey <tom@tromey.com>
5281
5282 * tui/tui-winsource.h (struct tui_source_window_base)
5283 <show_source_content>: Declare.
5284 (tui_show_source_content): Don't declare.
5285 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5286 (tui_source_window_base::show_source_content): Rename from
5287 tui_show_source_content.
5288 (tui_source_window_base::refresh_all): Update.
5289 * tui/tui-layout.c (show_source_disasm_command)
5290 (show_source_or_disasm_and_command): Update.
5291
5292 2019-08-13 Tom Tromey <tom@tromey.com>
5293
5294 * tui/tui-winsource.c (tui_erase_source_content)
5295 (tui_show_source_content, tui_source_window_base::refresh_all):
5296 Update.
5297 * tui/tui-wingeneral.h
5298 (tui_check_and_display_highlight_if_needed): Don't declare.
5299 * tui/tui-wingeneral.c
5300 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5301 check_and_display_highlight_if_needed.
5302 * tui/tui-win.c (tui_rehighlight_all)
5303 (tui_win_info::make_visible_with_new_height): Update.
5304 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5305 (tui_data_window::erase_data_content)
5306 (tui_data_window::display_all_data): Update.
5307 * tui/tui-data.h (struct tui_win_info)
5308 <check_and_display_highlight_if_needed>: Declare.
5309
5310 2019-08-13 Tom Tromey <tom@tromey.com>
5311
5312 * tui/tui-win.c (tui_resize_all): Call
5313 tui_delete_invisible_windows.
5314 * tui/tui-layout.c (show_layout): Call
5315 tui_delete_invisible_windows.
5316 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5317 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5318
5319 2019-08-13 Tom Tromey <tom@tromey.com>
5320
5321 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5322 tui_add_win_to_layout.
5323
5324 2019-08-13 Tom Tromey <tom@tromey.com>
5325
5326 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5327 * tui/tui-layout.c (tui_default_win_height): Now static.
5328
5329 2019-08-13 Tom Tromey <tom@tromey.com>
5330
5331 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5332 single switch.
5333 (show_source_disasm_command, show_source_or_disasm_and_command):
5334 Don't check current layout.
5335
5336 2019-08-13 Tom Tromey <tom@tromey.com>
5337
5338 * tui/tui-wingeneral.c (make_all_visible): Remove.
5339 (tui_make_all_invisible): Simplify.
5340 * tui/tui-layout.c (tui_make_all_invisible): Move from
5341 tui-wingeneral.c; simplify.
5342 (show_layout): Hoist call to tui_make_all_invisible.
5343 (show_data): Don't call tui_make_all_invisible.
5344
5345 2019-08-13 Tom Tromey <tom@tromey.com>
5346
5347 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5348 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5349
5350 2019-08-13 Tom Tromey <tom@tromey.com>
5351
5352 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5353 tui-data.c.
5354 (show_source_disasm_command, show_data)
5355 (show_source_or_disasm_and_command): Don't use
5356 tui_set_current_layout_to.
5357 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5358 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5359 tui-layout.c.
5360 (tui_set_current_layout_to): Remove.
5361
5362 2019-08-13 Tom Tromey <tom@tromey.com>
5363
5364 * tui/tui-layout.c (tui_set_layout): Update.
5365 * tui/tui-data.h (struct tui_layout_def): Remove.
5366 (tui_layout_def): Don't declare.
5367 * tui/tui-data.c (layout_def): Remove.
5368 (tui_layout_def): Remove.
5369
5370 2019-08-13 Tom Tromey <tom@tromey.com>
5371
5372 * tui/tui-winsource.h (struct tui_source_window_base)
5373 <clear_detail>: No longer "override".
5374 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5375 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5376 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5377 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5378 Remove.
5379 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5380
5381 2019-08-13 Tom Tromey <tromey@adacore.com>
5382
5383 * tracepoint.c: Don't include readline.h or history.h.
5384
5385 2019-08-12 Tom Tromey <tom@tromey.com>
5386
5387 * configure: Rebuild.
5388 * configure.ac: Check for readline 7.
5389 * NEWS: Mention readline 7 requirement.
5390 * README: Update.
5391
5392 2019-08-12 Tom Tromey <tom@tromey.com>
5393
5394 * mingw-hdep.c (gdb_select): Remove readline hack.
5395
5396 2019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5397
5398 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5399 when the function fails.
5400
5401 2019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5402
5403 * s390-tdep.c (s390_type_align): New function.
5404 (s390_gdbarch_init): Set it as type_align gdbarch method.
5405
5406 2019-08-09 Tom de Vries <tdevries@suse.de>
5407
5408 PR gdb/24591
5409 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5410 pc_low with relocation offset.
5411
5412 2019-08-07 Tom Tromey <tromey@adacore.com>
5413
5414 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5415 (print_frame_args): Update.
5416 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5417 Update.
5418 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5419 * frame.h (struct frame_arg): Add initializers.
5420 <error>: Now a unique_xmalloc_ptr.
5421
5422 2019-08-07 Alan Hayward <alan.hayward@arm.com>
5423
5424 * NEWS: Expand the Pointer Authentication entry.
5425 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5426 (aarch64_frame_unmask_lr): ... to this.
5427 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5428 Call aarch64_frame_unmask_lr.
5429 * frame.c (struct frame_info): Add "masked" variable.
5430 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5431 (fprint_frame): Check for masked pc.
5432 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5433 declarations.
5434 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5435 * stack.c (print_frame): Check for masked pc.
5436
5437 2019-08-06 Tom Tromey <tom@tromey.com>
5438
5439 * stabsread.c (patch_block_stabs, read_one_struct_field)
5440 (read_enum_type): Use obstack_strndup.
5441 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5442 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5443 * dwarf2read.c (guess_full_die_structure_name)
5444 (anonymous_struct_prefix): Use obstack_strndup.
5445 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5446 * c-exp.y (yylex): Use obstack_strndup.
5447 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5448 (write_var_or_type): Use obstack_strndup.
5449
5450 2019-08-06 Tom Tromey <tom@tromey.com>
5451
5452 * symfile.c (reread_symbols): Use obstack_strdup.
5453 * stabsread.c (read_type): Use obstack_strdup.
5454 * gdb_obstack.h (obstack_strdup): New overload.
5455 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5456 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5457 (dwarf2_canonicalize_name): Use obstack_strdup.
5458 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5459 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5460 Use obstack_strdup.
5461
5462 2019-08-06 Tom Tromey <tom@tromey.com>
5463
5464 * gdb_obstack.h (obstack_strdup): Define.
5465 * gdb_obstack.c (obstack_strdup): Don't define.
5466
5467 2019-08-06 Tom Tromey <tom@tromey.com>
5468
5469 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5470 obstack_strdup.
5471 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5472 obstack_strdup.
5473 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5474 * stabsread.c (common_block_start): Use obstack_strdup.
5475 * objfiles.c (set_objfile_main_name, objfile): Use
5476 obstack_strdup.
5477 * namespace.c (add_using_directive): Use obstack_strdup.
5478 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5479 * jit.c (finalize_symtab): Use obstack_strdup.
5480 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5481 (guess_partial_die_structure_name, partial_die_info::fixup)
5482 (dwarf2_name): Use obstack_strdup.
5483 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5484 obstack_strdup.
5485 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5486 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5487 obstack_strdup.
5488 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5489
5490 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5491
5492 * unittests/help-doc-selftests.c: New file.
5493 * Makefile.in: Add the new file.
5494
5495 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5496
5497 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5498 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5499 the full first line, except when FOR_VALUE_PREFIX. In this case,
5500 the trailing '.' is not output, and the first character is uppercased.
5501 (print_help_for_command): Update call to print_doc_line.
5502 (print_doc_of_command): Likewise.
5503 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5504 * cli/cli-option.c (append_indented_doc): Do not append newline.
5505 (build_help_option): Append newline after first appended_indented_doc
5506 only if a second call is done.
5507 (build_help): Append 2 new lines before each option, except the first
5508 one.
5509 * compile/compile.c (_initialize_compile): Add new lines after
5510 %OPTIONS%, when not at the end of the help.
5511 Change help doc or code
5512 producing the help doc to respect the invariants.
5513 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5514 Also removed the new line after 'Options:', as all other commands
5515 do not put an empty line between 'Options:' and the first option.
5516 * printcmd.c (_initialize_printcmd): Likewise.
5517 * stack.c (_initialize_stack): Likewise.
5518 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5519 incorrectly telling COMMAND is optional.
5520 * ada-lang.c (_initialize_ada_language): Change help doc or code
5521 producing the help doc to respect the invariants.
5522 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5523 * breakpoint.c (_initialize_breakpoint): Likewise.
5524 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5525 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5526 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5527 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5528 _initialize_cli_style): Likewise.
5529 * corelow.c (core_target_info): Likewise.
5530 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5531 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5532 * filesystem.c (_initialize_filesystem): Likewise.
5533 * frame.c (_initialize_frame): Likewise.
5534 * gnu-nat.c (add_task_commands): Likewise.
5535 * infcall.c (_initialize_infcall): Likewise.
5536 * infcmd.c (_initialize_infcmd): Likewise.
5537 * interps.c (_initialize_interpreter): Likewise.
5538 * language.c (_initialize_language): Likewise.
5539 * linux-fork.c (_initialize_linux_fork): Likewise.
5540 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5541 * maint.c (_initialize_maint_cmds): Likewise.
5542 * memattr.c (_initialize_mem): Likewise.
5543 * printcmd.c (_initialize_printcmd): Likewise.
5544 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5545 _RegEx): Likewise.
5546 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5547 * record-btrace.c (_initialize_record_btrace): Likewise.
5548 * record-full.c (_initialize_record_full): Likewise.
5549 * record.c (_initialize_record): Likewise.
5550 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5551 * regcache.c (_initialize_regcache): Likewise.
5552 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5553 _initialize_remote): Likewise.
5554 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5555 * serial.c (_initialize_serial): Likewise.
5556 * skip.c (_initialize_step_skip): Likewise.
5557 * source.c (_initialize_source): Likewise.
5558 * stack.c (_initialize_stack): Likewise.
5559 * symfile.c (_initialize_symfile): Likewise.
5560 * symtab.c (_initialize_symtab): Likewise.
5561 * target-descriptions.c (_initialize_target_descriptions): Likewise.
5562 * top.c (init_main): Likewise.
5563 * tracefile-tfile.c (tfile_target_info): Likewise.
5564 * tracepoint.c (_initialize_tracepoint): Likewise.
5565 * tui/tui-win.c (_initialize_tui_win): Likewise.
5566 * utils.c (add_internal_problem_command): Likewise.
5567 * valprint.c (value_print_option_defs): Likewise.
5568
5569 2019-08-06 Frank Ch. Eigler <fche@redhat.com>
5570
5571 PR build/24886
5572 * configure.ac: Drop enable-libmcheck support.
5573 * configure, config.in: Rebuild.
5574 * libmcheck.m4: Remove.
5575 * acinclude.m4: Don't include it.
5576 * Makefile.in: Don't distribute it.
5577 * top.c (print_gdb_configuration): Don't mention it.
5578
5579 2019-08-06 Tom Tromey <tom@tromey.com>
5580
5581 * utils.c (set_output_style): Sometimes pass stream to
5582 emit_style_escape.
5583 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5584 * record-btrace.c (btrace_insn_history): Update.
5585 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5586 method.
5587 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5588 Update initializers.
5589 <m_uiout>: New field.
5590 <m_di>: Move lower.
5591 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5592 Remove "uiout" parameter.
5593 (dump_insns): Update.
5594 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5595 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5596
5597 2019-08-06 Christian Biesinger <cbiesinger@google.com>
5598
5599 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5600 (error_in_psymtab_expansion): Likewise.
5601 (lookup_symbol_via_quick_fns): Likewise.
5602 (basic_lookup_transparent_type_quick): Likewise.
5603 (basic_lookup_transparent_type_1): Likewise.
5604
5605 2019-08-06 Tom Tromey <tromey@adacore.com>
5606
5607 * source.c (last_source_error): Now bool.
5608 (print_source_lines_base): Make "noprint" bool. Only open
5609 source file when last_source_visited changes.
5610
5611 2019-08-06 Tom Tromey <tromey@adacore.com>
5612
5613 * annotate.c (annotate_source_line): Use g_source_cache.
5614 * source-cache.c (source_cache::get_plain_source_lines): Change
5615 parameters. Populate m_offset_cache.
5616 (source_cache::ensure): New method.
5617 (source_cache::get_line_charpos): New method.
5618 (extract_lines): Move lower. Change parameters.
5619 (source_cache::get_source_lines): Move lower.
5620 * source-cache.h (class source_cache): Update comment.
5621 <get_line_charpos>: New method.
5622 <get_source_lines>: Update comment.
5623 <clear>: Clear m_offset_cache.
5624 <get_plain_source_lines>: Change parameters.
5625 <ensure>: New method
5626 <m_offset_cache>: New member.
5627 * source.c (forget_cached_source_info_for_objfile): Update.
5628 (info_source_command): Use g_source_cache.
5629 (find_source_lines, open_source_file_with_line_charpos): Remove.
5630 (print_source_lines_base, search_command_helper): Use g_source_cache.
5631 * source.h (open_source_file_with_line_charpos): Don't declare.
5632 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5633 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5634 Use g_source_cache.
5635
5636 2019-08-06 Tom Tromey <tromey@adacore.com>
5637
5638 * source-cache.c (source_cache::get_plain_source_lines):
5639 Remove "first_line" and "last_line" parameters.
5640 (source_cache::get_source_lines): Cache plain text.
5641 * source-cache.h (class source_cache)
5642 <get_plain_source_lines>: Update.
5643
5644 2019-08-06 Tom Tromey <tromey@adacore.com>
5645
5646 * source-cache.c (extract_lines): No longer a method.
5647 Changed type of parameter. Include final newline.
5648 (selftests::extract_lines_test): New function.
5649 (_initialize_source_cache): Likewise.
5650 * source-cache.h (class source_cache)
5651 <extract_lines>: Don't declare.
5652
5653 2019-08-06 Tom Tromey <tromey@adacore.com>
5654
5655 * breakpoint.c (init_breakpoint_sal): Update.
5656 (breakpoint): Update.
5657 * breakpoint.h (struct breakpoint) <filter>: Now a
5658 unique_xmalloc_ptr.
5659
5660 2019-08-05 Christian Biesinger <cbiesinger@google.com>
5661
5662 * NEWS: Mention dictionary access on blocks.
5663 * python/py-block.c (blpy_getitem): New function.
5664 (block_object_as_mapping): New struct.
5665 (block_object_type): Use new struct for tp_as_mapping field.
5666
5667 2019-08-05 Christian Biesinger <cbiesinger@google.com>
5668
5669 * objfiles.h (objfile): Add a comment describing partial symbols.
5670
5671 2019-08-05 Tom Tromey <tromey@adacore.com>
5672
5673 * compile/compile.c (_initialize_compile): Use _(), not N_().
5674 * thread.c (_initialize_thread): Use _(), not N_().
5675 * stack.c (_initialize_stack): Use _(), not N_().
5676 * printcmd.c (_initialize_printcmd): Use _(), not N_().
5677
5678 2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
5679
5680 * dwarf2read.c (struct dw2_symtab_iterator):
5681 <want_specific_block>: Remove.
5682 <block_index>: Change type to gdb::optional.
5683 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5684 change type of BLOCK_INDEX parameter to gdb::optional.
5685 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5686 (dw2_lookup_symbol): Don't pass argument for
5687 WANT_SPECIFIC_BLOCK.
5688 (dw2_expand_symtabs_for_function): Don't pass argument for
5689 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5690 (class dw2_debug_names_iterator)
5691 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5692 parameter, change BLOCK_INDEX type to gdb::optional.
5693 <m_want_specific_block>: Remove.
5694 <m_block_index>: Change type to gdb::optional.
5695 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5696 gdb::optional. Re-write in function of gdb::optional.
5697 (dw2_debug_names_lookup_symbol): Don't pass argument for
5698 WANT_SPECIFIC_BLOCK.
5699 (dw2_debug_names_expand_symtabs_for_function): Don't pass
5700 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5701 BLOCK_INDEX.
5702
5703 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5704
5705 * NEWS: Mention changes to "info sources" command.
5706
5707 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5708
5709 * symtab.c (filename_partial_match_opts): New struct type.
5710 (struct output_source_filename_data): New members
5711 regexp, c_regexp, partial_match.
5712 (output_source_filename): Use new members to decide to print file.
5713 (info_sources_option_defs): New variable.
5714 (make_info_sources_options_def_group, print_info_sources_header,
5715 info_sources_command_completer):
5716 New functions.
5717 (info_sources_command): Read new optional arguments.
5718 (_initialize_symtab): Update info sources help.
5719
5720 2019-08-02 Alexandre Oliva <oliva@adacore.com>
5721
5722 * ada-lang.c (exception_support_info_v0): Renamed from...
5723 (default_exception_support_info): ... this. Create new
5724 definition for v1.
5725 (ada_has_this_exception_support): Look up catch_handlers_sym.
5726 (ada_exception_support_info_sniffer): Try v0 after default.
5727
5728 2019-08-01 Tom Tromey <tromey@adacore.com>
5729
5730 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5731 gdbarch.h.
5732
5733 2019-08-01 Christian Biesinger <cbiesinger@google.com>
5734
5735 * s12z-tdep.c: Fix include path for s12z-opc.h.
5736
5737 2019-08-01 Alan Hayward <alan.hayward@arm.com>
5738
5739 * NEWS: Require GNU make 3.82.
5740
5741 2019-07-16 Tom Tromey <tom@tromey.com>
5742
5743 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5744 declare.
5745
5746 2019-07-30 Tom Tromey <tromey@adacore.com>
5747
5748 * block.c (contained_in): Remove BLOCK_FUNCTION check.
5749
5750 2019-07-30 Kevin Buettner <kevinb@redhat.com>
5751
5752 * printcmd.c (print_address_symbolic): Print negative offsets.
5753 (build_address_symbolic): Force signed arithmetic when computing
5754 offset.
5755
5756 2019-07-30 Christian Biesinger <cbiesinger@google.com>
5757
5758 PR/24474: Add a function to lookup static variables.
5759 * NEWS: Mention this new function.
5760 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5761 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5762 * python/python.c (python_GdbMethods): Add new function.
5763
5764 2019-07-29 Christian Biesinger <cbiesinger@google.com>
5765
5766 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5767 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5768 (objfpy_lookup_static_symbol): New function.
5769 (objfile_object_methods): Add new functions.
5770
5771 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5772
5773 * NEWS: Mention 'set|show print frame-info'. Mention new
5774 'presence' value for 'frame-arguments'. Mention new '-frame-info'
5775 backtrace argument. Mention that python frame filtering code
5776 is now consistent with what 'backtrace' command prints.
5777
5778 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5779
5780 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5781 comments.
5782 (print_frame_info_auto, print_frame_info_source_line,
5783 print_frame_info_location, print_frame_info_source_and_location,
5784 print_frame_info_location_and_address, print_frame_info_short_location):
5785 New declarations.
5786 (struct frame_print_options): New member print_frame_info.
5787 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5788 * stack.h (get_user_print_what_frame_info): New declaration.
5789 (frame_show_address): New declaration.
5790 * stack.c (print_frame_arguments_choices): New value 'presence'.
5791 (print_frame_info_auto, print_frame_info_source_line,
5792 print_frame_info_location, print_frame_info_source_and_location,
5793 print_frame_info_location_and_address, print_frame_info_short_location,
5794 print_frame_info_choices, print_frame_info_print_what): New definitions.
5795 (print_frame_args): Only print dots for args if print frame-arguments
5796 is 'presence'.
5797 (frame_print_option_defs): New element for "frame-info".
5798 (get_user_print_what_frame_info): New function.
5799 (frame_show_address): Make non static. Move comment to stack.h.
5800 (print_frame_info_to_print_what): New function.
5801 (print_frame_info): Update comment. Use fp_opts.print_frame_info
5802 to decide what to print.
5803 (backtrace_command_1): Handle the new print_frame_arguments_presence
5804 value.
5805 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5806 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5807 (py_print_frame): In non-mi mode, use LOCATION as default for
5808 print_what, similarly to frame information printed directly by
5809 backtrace command. Handle frame-info user option in non MI mode.
5810
5811 2019-07-27 Kevin Buettner <kevinb@redhat.com>
5812
5813 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5814 Add case for debugging 32-bit target on 64-bit host. Revise
5815 comment.
5816
5817 2019-07-27 Kevin Buettner <kevinb@redhat.com>
5818
5819 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5820 instead of find_function_entry_range_from_pc.
5821
5822 2019-07-27 Kevin Buettner <kevinb@redhat.com>
5823
5824 * stack.c (find_frame_funname): Remove code which preferred
5825 minsym over symtab sym in "certain pathological cases".
5826
5827 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5828 parameter. Change type of "do_demangle" to bool.
5829 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5830 Pass suitable "prefer_sym_over_minsym" flag to
5831 build_address_symbolic(). Don't output "+" for negative offsets.
5832 * printcmd.c (print_address_symbolic): Update invocation of
5833 build_address_symbolic to include a "prefer_sym_over_minsym"
5834 flag.
5835 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5836 Restrict cases in which use of minimal symbol is preferred to that
5837 of a found symbol. Update comments.
5838
5839 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5840 for entry pc when entry pc is out of range for that FDE.
5841
5842 2019-07-26 Brian Callahan <bcallah@openbsd.org>
5843
5844 PR gdb/24839:
5845 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5846 type.
5847
5848 2019-07-25 Christian Biesinger <cbiesinger@google.com>
5849
5850 * python/py-objfile.c (add_separate_debug_file): Fix comment about
5851 this function's Python signature.
5852
5853
5854 2019-07-24 Christian Biesinger <cbiesinger@google.com>
5855
5856 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5857 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5858 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5859 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5860 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5861
5862
5863 2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
5864
5865 * h8300-tdep.c (h8300_register_name_common): New.
5866 h8300_register_name): Use h8300_register_name_common.
5867 (h8300s_register_name): Likewise.
5868 (h8300sx_register_name): Likewise.
5869 (h8300h_register_nam): New.
5870 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5871
5872
5873 2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
5874
5875 * arm-tdep.c (arm_skip_cmse_entry): New function.
5876 (arm_is_sgstubs_section): New function.
5877 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5878
5879 2019-07-22 Tom Tromey <tom@tromey.com>
5880
5881 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5882 Don't self-assign.
5883
5884 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5885
5886 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5887 type_print.
5888
5889 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5890
5891 * symtab.c (search_symbols): Adjust msymbol matching type arrays
5892 so that GDB doesn't match any msymbols when searching in the
5893 TYPES_DOMAIN.
5894 (print_symbol_info): Print using typedef_print or type_print based
5895 on the type of the symbol. Add updated FIXME comment moved from...
5896 (_initialize_symtab): ... move and update FIXME comment to above.
5897
5898 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5899
5900 * NEWS: Mention adding -q option to "info types".
5901 * symtab.c (struct info_types_options): New struct.
5902 (info_types_options_defs): New variable.
5903 (make_info_types_options_def_group): New function.
5904 (info_types_command): Use gdb::option framework to parse options.
5905 (info_types_command_completer): New function.
5906 (_initialize_symtab): Extend the help text on "info types" and
5907 register command completer.
5908
5909 2019-07-21 Christian Biesinger <cbiesinger@google.com>
5910
5911 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
5912 (lookup_symbol_in_objfile): Change int to block_enum and add a
5913 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
5914
5915 2019-07-20 Christian Biesinger <cbiesinger@google.com>
5916
5917 * MAINTAINERS (Write After Approval): Add self.
5918
5919 2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
5920
5921 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
5922 instruction to the dummy code region.
5923
5924 2019-07-19 Tom Tromey <tromey@adacore.com>
5925
5926 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
5927 (ARGSUSED, PARAMS, __func__): Remove rules.
5928
5929 2019-07-19 Alan Hayward <alan.hayward@arm.com>
5930
5931 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
5932 * features/arm/arm-with-iwmmxt.c: Remove.
5933 * features/arm/arm-with-iwmmxt.xml: Remove.
5934 * features/arm/arm-with-m-fpa-layout.c: Remove.
5935 * features/arm/arm-with-m-fpa-layout.xml: Remove.
5936 * features/arm/arm-with-m-vfp-d16.c: Remove.
5937 * features/arm/arm-with-m-vfp-d16.xml: Remove.
5938 * features/arm/arm-with-m.c: Remove.
5939 * features/arm/arm-with-m.xml: Remove.
5940 * features/arm/arm-with-neon.c: Remove.
5941 * features/arm/arm-with-neon.xml: Remove.
5942 * features/arm/arm-with-vfpv2.c: Remove.
5943 * features/arm/arm-with-vfpv2.xml: Remove.
5944 * features/arm/arm-with-vfpv3.c: Remove.
5945 * features/arm/arm-with-vfpv3.xml: Remove.
5946
5947 2019-07-19 Alan Hayward <alan.hayward@arm.com>
5948
5949 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
5950
5951 2019-07-19 Alan Hayward <alan.hayward@arm.com>
5952
5953 * arch/aarch32.c (aarch32_create_target_description): Create
5954 target descriptions using features.
5955 * arch/arm.c (arm_create_target_description)
5956 (arm_create_mprofile_target_description): Likewise.
5957 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
5958
5959 2019-07-19 Alan Hayward <alan.hayward@arm.com>
5960
5961 * Makefile.in: Add new files.
5962 * aarch32-tdep.c: New file.
5963 * aarch32-tdep.h: New file.
5964 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5965 Call aarch32_read_description.
5966 * arch/aarch32.c: New file.
5967 * arch/aarch32.h: New file.
5968 * arch/arm.c (arm_create_target_description)
5969 (arm_create_mprofile_target_description): New function.
5970 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
5971 (arm_create_target_description)
5972 (arm_create_mprofile_target_description): New declaration.
5973 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
5974 read_description functions.
5975 * arm-linux-nat.c (arm_linux_nat_target::read_description):
5976 Likewise.
5977 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5978 * arm-tdep.c (tdesc_arm_list): New variable.
5979 (arm_register_g_packet_guesses): Call create description functions.
5980 (arm_read_description) (arm_read_mprofile_description): New
5981 function.
5982 * arm-tdep.h (arm_read_description)
5983 (arm_read_mprofile_description): Add declaration.
5984 * configure.tgt: Add new files.
5985
5986 2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
5987
5988 * top.c (new_ui_command): Open specified terminal just once.
5989
5990 2019-07-18 Tom Tromey <tromey@adacore.com>
5991
5992 * symtab.c (main_name): Constify return type.
5993 * symfile.c (set_initial_language): Update.
5994 * symtab.h (main_name): Constify return type.
5995
5996 2019-07-17 Tom Tromey <tom@tromey.com>
5997
5998 * tui/tui-winsource.c (tui_update_source_window)
5999 (tui_update_source_window_as_is)
6000 (tui_update_source_windows_with_line): Remove return.
6001 * tui/tui-disasm.c (tui_show_disassem)
6002 (tui_show_disassem_and_update_source): Remove return.
6003 * tui/tui.c (tui_reset): Remove return.
6004 * tui/tui-wingeneral.c
6005 (tui_check_and_display_highlight_if_needed): Remove return.
6006
6007 2019-07-17 Tom Tromey <tom@tromey.com>
6008
6009 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6010
6011 2019-07-17 Tom Tromey <tom@tromey.com>
6012
6013 * tui/tui-winsource.h (struct tui_exec_info_window)
6014 (struct tui_source_window_base): Move from tui-data.h.
6015 * tui/tui-winsource.c: Move many method definitions from
6016 elsewhere. Remove "structuring" comments.
6017 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6018 (tui_source_window_base::refresh_window): Move to
6019 tui-winsource.c.
6020 * tui/tui-win.c (tui_source_window_base::refresh_all)
6021 (tui_source_window_base::update_tab_width)
6022 (tui_source_window_base::set_new_height)
6023 (tui_source_window_base::do_make_visible_with_new_height): Move to
6024 tui-winsource.c.
6025 * tui/tui-source.h: Update.
6026 * tui/tui-source.c (tui_source_window_base::reset): Move to
6027 tui-winsource.c.
6028 * tui/tui-disasm.h: Update.
6029 * tui/tui-data.h (struct tui_exec_info_window): Move to
6030 tui-winsource.h.
6031 (struct tui_source_window_base): Likewise.
6032 * tui/tui-data.c (tui_source_window_base::clear_detail)
6033 (tui_source_window_base, ~tui_source_window_base): Move to
6034 tui-winsource.c.
6035
6036 2019-07-17 Tom Tromey <tom@tromey.com>
6037
6038 * tui/tui-win.c (tui_resize_all)
6039 (tui_source_window_base::update_tab_width)
6040 (tui_adjust_win_heights): Update.
6041 (tui_win_info::make_invisible_and_set_new_height): Rename from
6042 make_invisible_and_set_new_height.
6043 * tui/tui-data.h (struct tui_win_info)
6044 <make_invisible_and_set_new_height>: New method.
6045
6046 2019-07-17 Tom Tromey <tom@tromey.com>
6047
6048 * tui/tui.c: Update.
6049 * tui/tui-source.h (struct tui_source_window): Move from
6050 tui-data.h.
6051 * tui/tui-layout.c: Update.
6052 * tui/tui-disasm.c: Update.
6053 * tui/tui-data.h (struct tui_source_window): Move to
6054 tui-source.h.
6055
6056 2019-07-17 Tom Tromey <tom@tromey.com>
6057
6058 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6059 tui-data.h.
6060 * tui/tui-data.h (struct tui_disasm_window): Move to
6061 tui-disasm.h.
6062
6063 2019-07-17 Tom Tromey <tom@tromey.com>
6064
6065 * tui/tui-regs.h (struct tui_data_item_window): Move from
6066 tui-data.h.
6067 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6068 * tui/tui-data.h (struct tui_data_item_window): Move to
6069 tui-regs.h.
6070 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6071
6072 2019-07-17 Tom Tromey <tom@tromey.com>
6073
6074 * tui/tui.c: Update.
6075 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6076 (tui_cmd_window::max_height): Move to tui-command.c.
6077 * tui/tui-layout.c: Update.
6078 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6079 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6080 tui-command.c.
6081 * tui/tui-command.h (struct tui_cmd_window): Move from
6082 tui-data.h.
6083 * tui/tui-command.c: Remove "structuring" comments.
6084 (tui_cmd_window::clear_detail)
6085 (tui_cmd_window::do_make_visible_with_new_height)
6086 (tui_cmd_window::max_height): Move from elsewhere.
6087
6088 2019-07-17 Tom Tromey <tom@tromey.com>
6089
6090 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6091 Now static.
6092 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6093 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6094
6095 2019-07-17 Tom Tromey <tom@tromey.com>
6096
6097 * tui/tui.c: Update.
6098 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6099 tui-regs.c.
6100 * tui/tui-windata.h: Remove file.
6101 * tui/tui-windata.c: Remove file.
6102 * tui/tui-win.c (tui_data_window::set_new_height)
6103 (tui_data_window::do_make_visible_with_new_height): Move to
6104 tui-regs.c.
6105 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6106 * tui/tui-regs.c: Remove "structuring" comments.
6107 (tui_data_window::first_data_item_displayed)
6108 (tui_data_window::delete_data_content_windows)
6109 (tui_data_window::erase_data_content)
6110 (tui_data_window::display_all_data)
6111 (tui_data_window::refresh_all)
6112 (tui_data_window::do_scroll_vertical)
6113 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6114 (tui_data_window::do_make_visible_with_new_height)
6115 (tui_data_window::refresh_window): Move from elsewhere.
6116 (_initialize_tui_regs): Move to end of file.
6117 * tui/tui-layout.c: Update.
6118 * tui/tui-hooks.c: Update.
6119 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6120 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6121 tui-regs.c.
6122 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6123
6124 2019-07-17 Tom Tromey <tom@tromey.com>
6125
6126 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6127 seen.
6128
6129 2019-07-17 Tom Tromey <tom@tromey.com>
6130
6131 * tui/tui-win.c (tui_source_window_base::set_new_height)
6132 (tui_source_window_base::do_make_visible_with_new_height): Use
6133 m_has_locator field directly.
6134 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6135 method.
6136 (struct tui_source_window_base) <has_locator>: Likewise.
6137
6138 2019-07-17 Tom Tromey <tom@tromey.com>
6139
6140 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6141 Don't declare.
6142 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6143 Remove.
6144 * tui/tui-win.c (tui_source_window_base::set_new_height)
6145 (tui_source_window_base::set_new_height)
6146 (make_invisible_and_set_new_height)
6147 (tui_source_window_base::do_make_visible_with_new_height)
6148 (tui_source_window_base::do_make_visible_with_new_height):
6149 Update.
6150 * tui/tui-layout.c (show_source_disasm_command, show_data)
6151 (show_source_or_disasm_and_command): Update.
6152 * tui/tui-layout.c (show_layout): Update.
6153
6154 2019-07-17 Tom Tromey <tom@tromey.com>
6155
6156 * tui/tui-layout.c (make_data_window): Remove.
6157 (show_data): Unify creation and re-initialization cases.
6158
6159 2019-07-17 Tom Tromey <tom@tromey.com>
6160
6161 * tui/tui-layout.c (make_source_window, make_disasm_window):
6162 Remove.
6163 (show_data): Unify creation and re-initialization cases.
6164
6165 2019-07-17 Tom Tromey <tom@tromey.com>
6166
6167 * tui/tui-layout.c (make_command_window): Remove.
6168 (show_source_disasm_command, show_source_or_disasm_and_command):
6169 Unify creation and re-initialization cases.
6170
6171 2019-07-17 Tom Tromey <tom@tromey.com>
6172
6173 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6174 creation and re-initialization cases.
6175
6176 2019-07-17 Tom Tromey <tom@tromey.com>
6177
6178 * tui/tui-regs.c (tui_get_register): Return void.
6179
6180 2019-07-17 Tom Tromey <tom@tromey.com>
6181
6182 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6183 Simplify.
6184
6185 2019-07-17 Tom Tromey <tom@tromey.com>
6186
6187 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6188 resetting.
6189
6190 2019-07-17 Tom Tromey <tom@tromey.com>
6191
6192 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6193 * tui/tui-regs.c (tui_reg_layout): New function.
6194 (tui_show_registers, tui_reg_command): Use it.
6195 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6196 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6197 parameters.
6198 (tui_layout_command): Remove.
6199
6200 2019-07-17 Tom Tromey <tom@tromey.com>
6201
6202 * tui/tui-layout.h (tui/tui-layout): Return void.
6203 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6204
6205 2019-07-17 Tom Tromey <tom@tromey.com>
6206
6207 * tui/tui-layout.c (show_source_disasm_command, show_data):
6208 Update.
6209 (reset_locator): Remove.
6210 (show_source_or_disasm_and_command): Update.
6211
6212 2019-07-17 Tom Tromey <tom@tromey.com>
6213
6214 * tui/tui-source.c (tui_source_window_base::reset): Remove
6215 win_type parameter.
6216 * tui/tui-layout.c (make_command_window, make_source_window)
6217 (make_disasm_window, make_data_window)
6218 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6219 (reset_locator, show_source_or_disasm_and_command): Update.
6220 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6221 win_type parameter.
6222 (struct tui_source_window_base) <reset>: Likewise.
6223
6224 2019-07-17 Tom Tromey <tom@tromey.com>
6225
6226 * tui/tui-layout.c (show_source_disasm_command): Use
6227 reset_locator.
6228 (reset_locator): New function.
6229 (init_and_make_win): Remove.
6230 (show_source_or_disasm_and_command): Use reset_locator.
6231
6232 2019-07-17 Tom Tromey <tom@tromey.com>
6233
6234 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6235 condition.
6236 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6237 Remove condition.
6238 * tui/tui-source.c (tui_source_window_base::reset): New method.
6239 * tui/tui-layout.c (make_command_window): Don't call
6240 init_and_make_win.
6241 (make_source_window, make_disasm_window): Don't call
6242 make_source_or_disasm_window.
6243 (make_data_window): Don't call init_and_make_win. Change calling
6244 convention.
6245 (show_source_disasm_command, show_data): Simplify.
6246 (make_source_or_disasm_window): Remove.
6247 (show_source_or_disasm_and_command): Simplify.
6248 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6249 (struct tui_source_window_base) <reset>: Likewise.
6250 <execution_info>: Remove initializer.
6251 * tui/tui-data.c (tui_source_window_base): Initialize
6252 execution_info.
6253
6254 2019-07-17 Tom Tromey <tom@tromey.com>
6255
6256 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6257 variable.
6258
6259 2019-07-17 Tom Tromey <tom@tromey.com>
6260
6261 * tui/tui.c (tui_rl_other_window): Update.
6262 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6263 superclass method first. Always iterate over regs_content.
6264 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6265 method.
6266 * tui/tui-win.c (tui_set_focus_command): Update.
6267
6268 2019-07-17 Tom Tromey <tom@tromey.com>
6269
6270 * tui/tui-win.c (tui_set_focus_command): Rename from
6271 tui_set_focus. Call tui_enable.
6272 (tui_set_focus_command): Remove.
6273
6274 2019-07-17 Tom Tromey <tom@tromey.com>
6275
6276 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6277 refresh_window.
6278 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6279 touchwin.
6280 (tui_data_window::refresh_window): Call refresh_window on data
6281 items. Always call superclass refresh_window.
6282 (tui_win_info::refresh): Remove.
6283 (tui_source_window_base::refresh_window): Update.
6284 (tui_refresh_all): Update.
6285 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6286 refresh_window.
6287 (show_source_or_disasm_and_command): Likewise.
6288 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6289 (struct tui_source_window_base) <refresh>: Likewise.
6290
6291 2019-07-17 Tom Tromey <tom@tromey.com>
6292
6293 * tui/tui-winsource.c (tui_clear_source_content)
6294 (tui_show_source_content): Update.
6295 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6296 whether content is empty.
6297 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6298 Remove.
6299
6300 2019-07-17 Tom Tromey <tom@tromey.com>
6301
6302 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6303 window's contents.
6304 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6305 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6306
6307 2019-07-17 Tom Tromey <tom@tromey.com>
6308
6309 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6310 (struct tui_data_item_window): Update.
6311
6312 2019-07-17 Tom Tromey <tom@tromey.com>
6313
6314 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6315 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6316 defines.
6317
6318 2019-07-17 Tom Tromey <tom@tromey.com>
6319
6320 * tui/tui-winsource.h (tui_erase_source_content)
6321 (tui_clear_source_content): Remove "display_prompt" parameter.
6322 * tui/tui-winsource.c (tui_update_source_window_as_is)
6323 (tui_update_source_windows_with_addr): Update.
6324 (tui_clear_source_content): Remove "display_prompt" parameter.
6325 (tui_erase_source_content): Likewise. Simplify.
6326 (tui_show_source_content): Update.
6327 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6328 * tui/tui-stack.c (tui_show_frame_info): Update.
6329 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6330 Remove defines.
6331
6332 2019-07-17 Tom Tromey <tom@tromey.com>
6333
6334 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6335 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6336 parameter.
6337 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6338 parameter.
6339
6340 2019-07-17 Tom Tromey <tom@tromey.com>
6341
6342 * tui/tui-winsource.c (tui_clear_source_content)
6343 (tui_show_source_content, tui_show_exec_info_content)
6344 (tui_clear_exec_info_content): Update.
6345 * tui/tui-stack.c (tui_show_locator_content): Update.
6346 (tui_show_frame_info): Update.
6347 * tui/tui-source.h (tui_source_window): Don't declare.
6348 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6349 from tui_source_is_displayed.
6350 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6351 Remove field.
6352 (struct tui_source_window_base) <content_in_use>: New field. Now
6353 bool.
6354 (struct tui_source_window) <showing_source_p>: New method.
6355 (TUI_SRC_WIN): Change cast.
6356 * tui/tui-data.c (tui_initialize_static_data): Update.
6357
6358 2019-07-17 Tom Tromey <tom@tromey.com>
6359
6360 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6361 location_matches_p.
6362 * tui/tui-source.c (tui_source_window::location_matches_p): New
6363 method.
6364 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6365 method.
6366 * tui/tui-data.h (struct tui_source_window_base)
6367 <location_matches_p>: New method.
6368 (struct tui_source_window, struct tui_disasm_window)
6369 <location_matches_p>: Likewise.
6370
6371 2019-07-17 Tom Tromey <tom@tromey.com>
6372
6373 * tui/tui-win.c (tui_set_win_height_command): Rename from
6374 tui_set_win_height.
6375 (tui_set_win_height_command): Remove.
6376
6377 2019-07-17 Tom Tromey <tom@tromey.com>
6378
6379 * tui/tui-source.c (tui_source_window): New constructor. Add
6380 observer.
6381 (~tui_source_window): New destructor.
6382 (tui_source_window::style_changed): New method.
6383 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6384 (tui_attach_detach_observers): Update.
6385 * tui/tui-data.h (struct tui_source_window): Make constructor not
6386 inline. Add destructor.
6387 (struct tui_source_window) <style_changed>: New method.
6388 <m_observable>: New member.
6389
6390 2019-07-17 Tom Tromey <tom@tromey.com>
6391
6392 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6393 * tui/tui-win.c (tui_resize_all): Fix typo.
6394
6395 2019-07-17 Tom Tromey <tom@tromey.com>
6396
6397 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6398 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6399 (tui_refresh_all): Remove "list" parameter. Use foreach.
6400 * tui/tui-win.c (window_name_completer): Use foreach.
6401 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6402 (update_tab_width): Likewise.
6403 * tui/tui-layout.c (show_layout): Update.
6404 * tui/tui-data.h (class tui_window_iterator): New.
6405 (struct all_tui_windows): New.
6406 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6407
6408 2019-07-17 Tom Tromey <tom@tromey.com>
6409
6410 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6411 parameter. Don't reference globals.
6412 (tui_reg_command): Update.
6413
6414 2019-07-17 Tom Tromey <tom@tromey.com>
6415
6416 * tui/tui-regs.c (tui_show_registers): Simplify.
6417
6418 2019-07-17 Tom Tromey <tom@tromey.com>
6419
6420 * tui/tui-regs.c (tui_show_registers): Update.
6421 (tui_show_register_group): Add win_info parameter.
6422
6423 2019-07-17 Tom Tromey <tom@tromey.com>
6424
6425 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6426 Rename from tui_display_reg_element_at_line.
6427 (tui_data_window::display_registers_from_line): Update.
6428 * tui/tui-data.h (struct tui_data_window)
6429 <display_reg_element_at_line>: New method.
6430
6431 2019-07-17 Tom Tromey <tom@tromey.com>
6432
6433 * tui/tui-regs.h (tui_display_registers_from)
6434 (tui_display_registers_from_line): Don't declare.
6435 * tui/tui-windata.c (tui_data_window::display_all_data)
6436 (tui_data_window::refresh_all)
6437 (tui_data_window::do_scroll_vertical): Update.
6438 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6439 from tui_display_registers_from.
6440 (tui_display_reg_element_at_line): Update.
6441 (tui_data_window::display_registers_from_line): Rename from
6442 tui_display_registers_from_line.
6443 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6444 display_registers_from_line>: New methods.
6445
6446 2019-07-17 Tom Tromey <tom@tromey.com>
6447
6448 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6449 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6450 from tui_erase_data_content.
6451 (tui_data_window::display_all_data)
6452 (tui_data_window::refresh_all)
6453 (tui_data_window::do_scroll_vertical): Update.
6454 * tui/tui-regs.c (tui_show_registers): Update.
6455 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6456 New method.
6457
6458 2019-07-17 Tom Tromey <tom@tromey.com>
6459
6460 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6461 declare.
6462 * tui/tui-windata.c
6463 (tui_data_window::delete_data_content_windows): Rename from
6464 tui_delete_data_content_windows.
6465 (tui_data_window::display_all_data)
6466 (tui_data_window::do_scroll_vertical): Update.
6467 * tui/tui-data.h (struct tui_data_window)
6468 <delete_data_content_windows>: New method.
6469
6470 2019-07-17 Tom Tromey <tom@tromey.com>
6471
6472 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6473 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6474
6475 2019-07-17 Tom Tromey <tom@tromey.com>
6476
6477 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6478 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6479 from tui_display_all_data.
6480 * tui/tui-win.c
6481 (tui_data_window::do_make_visible_with_new_height): Update.
6482 * tui/tui-regs.c (tui_show_registers): Update.
6483 * tui/tui-layout.c (tui_set_layout): Update.
6484 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6485 method.
6486
6487 2019-07-17 Tom Tromey <tom@tromey.com>
6488
6489 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6490 * tui/tui-windata.c (tui_display_data_from): Remove.
6491 (tui_data_window::refresh_all): Update.
6492
6493 2019-07-17 Tom Tromey <tom@tromey.com>
6494
6495 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6496 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6497 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6498 tui_display_registers_from_line.
6499 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6500 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6501 "force_display" parameter.
6502
6503 2019-07-17 Tom Tromey <tom@tromey.com>
6504
6505 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6506 declare.
6507 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6508 Rename from tui_first_reg_element_no_inline.
6509 (tui_display_reg_element_at_line)
6510 (tui_display_registers_from_line): Update.
6511 * tui/tui-data.h (struct tui_data_window)
6512 <first_reg_element_no_inline>: New method.
6513
6514 2019-07-17 Tom Tromey <tom@tromey.com>
6515
6516 * tui/tui-windata.c (tui_display_data_from)
6517 (tui_data_window::do_scroll_vertical): Update.
6518 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6519 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6520 Rename from tui_line_from_reg_element_no.
6521 (tui_display_registers_from_line): Update.
6522 * tui/tui-data.h (struct tui_data_window)
6523 <line_from_reg_element_no>: New method.
6524
6525 2019-07-17 Tom Tromey <tom@tromey.com>
6526
6527 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6528 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6529 tui_last_regs_line_no.
6530 (tui_display_reg_element_at_line)
6531 (tui_display_registers_from_line): Update.
6532 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6533 method.
6534
6535 2019-07-17 Tom Tromey <tom@tromey.com>
6536
6537 PR tui/24722:
6538 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6539 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6540 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6541 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6542 (tui_update_breakpoint_info): Likewise.
6543 * tui/tui-hooks.c (tui_event_create_breakpoint)
6544 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6545 Update.
6546
6547 2019-07-17 Tom Tromey <tom@tromey.com>
6548
6549 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6550
6551 2019-07-17 Tom Tromey <tom@tromey.com>
6552
6553 * tui/tui-winsource.c (tui_update_source_window_as_is)
6554 (tui_update_source_windows_with_addr): Update.
6555 * tui/tui-source.h (tui_set_source_content)
6556 (tui_show_symtab_source): Add "win_info" parameter.
6557 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6558 parameter.
6559 (tui_show_symtab_source): Likewise.
6560
6561 2019-07-17 Tom Tromey <tom@tromey.com>
6562
6563 * tui/tui-wingeneral.c
6564 (tui_check_and_display_highlight_if_needed): Check can_highlight.
6565
6566 2019-07-17 Tom Tromey <tom@tromey.com>
6567
6568 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6569 (struct tui_cmd_window) <can_scroll>: New method.
6570 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6571 method.
6572
6573 2019-07-17 Tom Tromey <tromey@adacore.com>
6574
6575 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6576 do_field_signed>: Rename. Change type of "value".
6577 * ui-out.c (ui_out::field_signed): Rename from field_int.
6578 Change type of "value".
6579 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
6580 type of "value".
6581 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6582 do_field_int. Change type of "value".
6583 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6584 do_field_int. Change type of "value".
6585 * tracepoint.c (trace_status_mi, tfind_1)
6586 (print_one_static_tracepoint_marker): Update.
6587 * thread.c (print_thread_info_1, print_selected_thread_frame):
6588 Update.
6589 * stack.c (print_frame, print_frame_info): Update.
6590 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6591 Update.
6592 * source.c (print_source_lines_base): Update.
6593 * skip.c (info_skip_command): Update.
6594 * record-btrace.c (btrace_ui_out_decode_error)
6595 (btrace_call_history_src_line): Update.
6596 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6597 Update.
6598 * progspace.c (print_program_space): Update.
6599 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6600 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6601 do_field_int. Change type of "value".
6602 * mi/mi-out.c (mi_ui_out::do_table_begin)
6603 (mi_ui_out::do_table_header): Update.
6604 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
6605 type of "value".
6606 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6607 (mi_cmd_data_list_changed_registers, output_register)
6608 (mi_cmd_data_read_memory, mi_load_progress)
6609 (mi_cmd_trace_frame_collected): Update.
6610 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6611 Update.
6612 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6613 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6614 (mi_cmd_var_list_children, varobj_update_one): Update.
6615 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6616 (mi_cmd_stack_list_args, list_arg_or_local): Update.
6617 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6618 * inferior.c (print_inferior): Update.
6619 * gdb_bfd.c (print_one_bfd): Update.
6620 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6621 Update.
6622 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6623 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6624 do_field_int. Change type of "value".
6625 * cli-out.c (cli_ui_out::do_field_signed): Rename from
6626 do_field_int. Change type of "value".
6627 * breakpoint.c (watchpoint_check, print_breakpoint_location)
6628 (print_one_breakpoint_location, print_it_catch_fork)
6629 (print_one_catch_fork, print_it_catch_vfork)
6630 (print_one_catch_vfork, print_it_catch_solib)
6631 (print_it_catch_exec, print_it_ranged_breakpoint)
6632 (print_mention_watchpoint, print_mention_masked_watchpoint)
6633 (bkpt_print_it, update_static_tracepoint): Update.
6634 * break-catch-throw.c (print_it_exception_catchpoint): Update.
6635 * break-catch-syscall.c (print_it_catch_syscall): Update.
6636 * ada-tasks.c (print_ada_task_info): Update.
6637 * ada-lang.c (print_it_exception, print_mention_exception):
6638 Update.
6639
6640 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
6641
6642 PR breakpoints/24541
6643 * gdbarch.c: Regenerate.
6644 * gdbarch.h: Regenerate.
6645 * gdbarch.sh: Adjust return type and parameter types for
6646 'stap_adjust_register'.
6647 (i386_stap_adjust_register): Adjust signature and return new
6648 register name.
6649 * stap-probe.c (stap_parse_register_operand): Adjust use of
6650 'gdbarch_stap_adjust_register'.
6651
6652 2019-07-17 Tom Tromey <tromey@adacore.com>
6653
6654 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
6655 declare VEC.
6656 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6657 std::vector.
6658 (struct s390_process_info): Add initializers.
6659 (s390_add_process): Use new.
6660 (s390_linux_nat_target::low_forget_process): Use delete.
6661 (s390_linux_nat_target::low_new_fork)
6662 (s390_linux_nat_target::stopped_by_watchpoint)
6663 (s390_linux_nat_target::low_prepare_to_resume)
6664 (s390_linux_nat_target::insert_watchpoint)
6665 (s390_linux_nat_target::insert_hw_breakpoint)
6666 (s390_linux_nat_target::remove_watchpoint)
6667 (s390_linux_nat_target::remove_hw_breakpoint): Update.
6668
6669 2019-07-16 John Baldwin <jhb@FreeBSD.org>
6670
6671 * aarch64-fbsd-nat.c: Include regcache.h.
6672 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6673 argument.
6674 (aarch64_fbsd_nat_target::fetch_registers)
6675 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6676 variable.
6677 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6678
6679 2019-07-16 John Baldwin <jhb@FreeBSD.org>
6680
6681 * fbsd-nat.c: Include gdbarch.h.
6682
6683 2019-07-15 Tom Tromey <tromey@adacore.com>
6684
6685 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6686
6687 2019-07-15 Tom Tromey <tromey@adacore.com>
6688
6689 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6690 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6691 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6692 * cli-out.c (cli_ui_out::do_field_int): New method.
6693 * ui-out.c (ui_out::field_unsigned): New method.
6694 * symfile.c (generic_load): Use field_unsigned.
6695 (print_transfer_performance): Likewise.
6696 * record-btrace.c (ui_out_field_uint): Remove.
6697 (btrace_call_history_insn_range, btrace_call_history): Use
6698 field_unsigned.
6699 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6700 field_unsigned.
6701 * ui-out.h (class ui_out) <field_unsigned>: New method.
6702 <do_field_unsigned>: Likewise.
6703
6704 2019-07-15 Tom Tromey <tromey@adacore.com>
6705
6706 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6707 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6708 * target.c (flash_erase_command): Use field_string.
6709 * infrun.c (print_signal_received_reason): Use field_string.
6710 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6711 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6712 field_string.
6713 * ada-tasks.c (print_ada_task_info): Use field_string.
6714
6715 2019-07-15 Tom Tromey <tromey@adacore.com>
6716
6717 * target.c (flash_erase_command): Use field_core_addr.
6718 * symfile.c (generic_load): Use field_core_addr.
6719 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6720 Use field_core_addr.
6721 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6722 field_core_addr.
6723
6724 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6725
6726 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6727 value if its desired type is smaller than a CORE_ADDR and signed.
6728
6729 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6730
6731 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6732 of changes to field names, and use new is_reference field to
6733 decide if a property is a reference or not.
6734 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6735 field.
6736 (struct dwarf2_property_baton): Update header comment, rename
6737 'referenced_type' to 'property_type' and update comments.
6738 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6739 default property type, store in property baton, update to take
6740 accound of renamed field.
6741 (read_func_scope): Update call to attr_to_dynamic_prop.
6742 (read_array_type): Likewise.
6743 (dwarf2_per_cu_addr_sized_int_type): New function.
6744 (read_subrange_index_type): Move type finding code to
6745 dwarf2_per_cu_addr_sized_int_type.
6746 (read_subrange_type): Update calls to attr_to_dynamic_prop.
6747 (dwarf2_per_cu_addr_type): New function.
6748 (set_die_type): Update calls to attr_to_dynamic_prop.
6749
6750 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6751
6752 * dwarf2read.c (read_subrange_index_type): New function.
6753 (read_subrange_type): Move code into new function and call it.
6754 * gdbtypes.c (create_range_type): Add some asserts.
6755
6756 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6757
6758 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6759 update return statements.
6760 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6761 declaration, and update comment to match.
6762 * gdbtypes.c (resolve_dynamic_array): Update call to
6763 dwarf2_evaluate_property to match new return type.
6764
6765 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6766
6767 * valarith.c (value_subscripted_rvalue): Change lowerbound
6768 parameter type from int to LONGEST.
6769 * value.h (value_subscripted_rvalue): Likewise in declaration.
6770
6771 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6772
6773 * cli/cli-utils.c (info_print_command_completer): New function.
6774 * cli/cli-utils.h: Add 'completer.h' include, and forward
6775 declaration for 'struct cmd_list_element'.
6776 (info_print_command_completer): Declare.
6777 * stack.c (_initialize_stack): Add completer for 'info locals' and
6778 'info args'.
6779 * symtab.c (_initialize_symtab): Add completer for 'info
6780 variables' and 'info functions'.
6781 * NEWS: Mention completion for additional info commands.
6782
6783 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6784
6785 * cli/cli-utils.c (extract_info_print_args): Delete.
6786 (extract_arg_maybe_quoted): Delete.
6787 (info_print_options_defs): New variable.
6788 (make_info_print_options_def_group): New function.
6789 (extract_info_print_options): Define new function.
6790 * cli/cli-utils.h (extract_info_print_args): Delete.
6791 (struct info_print_options): New structure.
6792 (extract_info_print_options): Declare new function.
6793 * stack.c (info_locals_command): Update to use new
6794 extract_info_print_options, also add a header comment.
6795 (info_args_command): Likewise.
6796 * symtab.c (info_variables_command): Likewise.
6797 (info_functions_command): Likewise.
6798
6799 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6800
6801 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6802 to extract string arguments.
6803 * common/common-utils.c (extract_string_maybe_quoted): New function.
6804 * common/common-utils.h (extract_string_maybe_quoted): Declare.
6805
6806 2019-07-11 Tom Tromey <tromey@adacore.com>
6807
6808 * main.c (get_init_files): Use GDBINIT, not gdbinit.
6809 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6810 * top.h (gdbinit): Don't declare.
6811 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6812 into...
6813 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
6814 * top.c (gdb_init): Don't call init_cli_cmds.
6815 (gdbinit): Remove.
6816 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6817
6818 2019-07-11 Tom Tromey <tromey@adacore.com>
6819
6820 * python/py-inferior.c (add_thread_object): Don't use thread_obj
6821 after it has been moved.
6822
6823 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6824
6825 * valops.c (value_must_coerce_to_target): Change return type to
6826 bool.
6827 * value.h (value_must_coerce_to_target): Likewise.
6828
6829 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
6830
6831 * breakpoint.c (is_hardware_watchpoint): Remove
6832 forward-declaration.
6833 (is_masked_watchpoint): Change return type to bool.
6834 (is_tracepoint): Likewise.
6835 (is_breakpoint): Likewise.
6836 (is_hardware_watchpoint): Likewise.
6837 (is_watchpoint): Likewise.
6838 (is_no_memory_software_watchpoint): Likewise.
6839 (is_catchpoint): Likewise.
6840 (breakpoint_1): Make FILTER parameter's return type bool.
6841 is_masked_watchpoint): Change return type to bool.
6842 (save_breakpoints): Make FILTER parameter's return type bool.
6843 * breakpoint.h (is_breakpoint): Change return type to bool.
6844 (is_watchpoint): Likewise.
6845 (is_catchpoint): Likewise.
6846 (is_tracepoint): Likewise.
6847
6848 2019-07-10 Tom Tromey <tom@tromey.com>
6849
6850 * defs.h: Don't include gdbarch.h.
6851 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6852 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6853 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6854 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6855 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6856 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6857 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6858 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6859 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6860 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6861 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6862 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6863 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6864 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6865 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6866 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6867 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6868 record-btrace.c, record.h, regcache-dump.c, regcache.h,
6869 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6870 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6871 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6872 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6873 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6874 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6875 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6876 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6877 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6878
6879 2019-07-10 Tom Tromey <tromey@adacore.com>
6880
6881 * ada-lang.h (is_ada_exception_catchpoint): Declare.
6882 * breakpoint.c (init_ada_exception_breakpoint): Register as
6883 bp_catchpoint.
6884 (print_one_breakpoint_location, print_one_breakpoint): Use
6885 is_ada_exception_catchpoint.
6886 * ada-lang.c (class ada_catchpoint_location): Pass
6887 bp_loc_software_breakpoint to bp_location constructor.
6888 (is_ada_exception_catchpoint): New function.
6889
6890 2019-07-10 Tom Tromey <tromey@adacore.com>
6891
6892 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
6893 VEC.
6894 (struct arm_exidx_entry): New method operator<.
6895 (struct arm_exidx_data) <section_maps>: Change type.
6896 (arm_exidx_data_free): Remove.
6897 (arm_exidx_data_key): Change type. Move lower.
6898 (arm_exidx_new_objfile): Update.
6899 (arm_compare_exidx_entries): Remove.
6900 (arm_find_exidx_entry, _initialize_arm_tdep)
6901
6902 2019-07-10 Tom Tromey <tromey@adacore.com>
6903
6904 * solib-spu.c (ocl_program_data_key): Change type.
6905 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6906 Update.
6907
6908 2019-07-10 Tom Tromey <tromey@adacore.com>
6909
6910 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
6911 (struct solib_aix_inferior_data) <library_list>: Change type.
6912 (solib_aix_inferior_data_handle): Change type.
6913 (get_solib_aix_inferior_data): Update.
6914 (solib_aix_free_library_list): Remove.
6915 (library_list_start_library): Update.
6916 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
6917 return type.
6918 (solib_aix_get_library_list)
6919 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
6920 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
6921
6922 2019-07-10 Tom Tromey <tromey@adacore.com>
6923
6924 * solib-dsbt.c (struct dsbt_info): Add initializers.
6925 (solib_dsbt_pspace_data): Change type.
6926 (dsbt_pspace_data_cleanup): Remove.
6927 (get_dsbt_info, _initialize_dsbt_solib): Update.
6928
6929 2019-07-10 Tom Tromey <tromey@adacore.com>
6930
6931 * spu-tdep.c (spu_overlay_data): Change type.
6932 (spu_get_overlay_table, spu_overlay_new_objfile)
6933 (_initialize_spu_tdep): Update.
6934
6935 2019-07-10 Tom Tromey <tromey@adacore.com>
6936
6937 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
6938 destructor.
6939 (dbx_objfile_data_key): Change type and declare later.
6940 (DBX_SYMFILE_INFO): Rewrite.
6941 * dbxread.c (dbx_objfile_data_key): Change type.
6942 (dbx_symfile_init): Update.
6943 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
6944 (coffstab_build_psymtabs, elfstab_build_psymtabs)
6945 (stabsect_build_psymtabs, _initialize_dbxread): Update.
6946
6947 2019-07-10 Tom Tromey <tromey@adacore.com>
6948
6949 * jit.c (jit_program_space_key): Change type. Move lower.
6950 (get_jit_program_space_data): Update.
6951 (jit_program_space_data_cleanup): Remove.
6952 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
6953 Update.
6954 (struct jit_program_space_data): Add initializers.
6955
6956 2019-07-10 Tom Tromey <tromey@adacore.com>
6957
6958 * solib-darwin.c (struct darwin_info): Add initializers.
6959 (solib_darwin_pspace_data): Change type.
6960 (darwin_pspace_data_cleanup): Remove.
6961 (get_darwin_info, _initialize_darwin_solib): Update.
6962
6963 2019-07-10 Tom Tromey <tromey@adacore.com>
6964
6965 * remote-sim.c (struct sim_inferior_data): Add initializers,
6966 constructor, and destructor.
6967 (sim_inferior_data_key): Change type. Move lower.
6968 (check_for_duplicate_sim_descriptor): Update.
6969 (get_sim_inferior_data): Use new. Update.
6970 (~sim_inferior_data_cleanup): Rename from
6971 sim_inferior_data_cleanup. Simplify.
6972 (gdbsim_close_inferior, simulator_command)
6973 (sim_command_completer, _initialize_remote_sim): Update.
6974 (next_pid, INITIAL_PID): Move earlier.
6975
6976 2019-07-10 Tom Tromey <tromey@adacore.com>
6977
6978 * python/python-internal.h (create_thread_object): Return
6979 gdbpy_ref.
6980 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
6981 * python/py-inferior.c (struct threadlist_entry): Add
6982 constructor.
6983 <thread_obj>: Now a gdbpy_ref.
6984 (thread_to_thread_object): Update.
6985 (add_thread_object): Use new.
6986 (delete_thread_object): Use delete.
6987 (infpy_threads): Update.
6988 (py_free_inferior): Update. Construct "inf_obj" after acquiring
6989 GIL.
6990
6991 2019-07-10 Tom Tromey <tromey@adacore.com>
6992
6993 * valops.c (value_cast): Specialize error message for Ada.
6994
6995 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6996
6997 * breakpoint.c (breakpoint_1): Update doc and parameter names.
6998
6999 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7000
7001 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7002 bpstat_should_step): Return bool, adjust comments.
7003 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7004 bpstat_should_step): Likewise.
7005
7006 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7007
7008 * features/Makefile: Use feature target descriptions for Arm.
7009 * features/arm/arm-core.c: Generate new file.
7010 * features/arm/arm-fpa.c: Likewise.
7011 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7012 * features/arm/arm-m-profile.c: Likewise.
7013 * features/arm/arm-vfpv2.c: Likewise.
7014 * features/arm/arm-vfpv3.c: Likewise.
7015 * features/arm/xscale-iwmmxt.c: Likewise.
7016 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7017
7018 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7019
7020 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7021 ptrace earlier.
7022
7023 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7024
7025 * features/aarch64-pauth.c: Regenerate.
7026
7027 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7028
7029 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7030 bool.
7031 (bpstat_what): Use false instead of 0.
7032
7033 2019-07-09 Pedro Alves <palves@redhat.com>
7034
7035 * break-catch-throw.c (is_exception_catchpoint): New.
7036 * breakpoint.c (print_one_breakpoint_location): New parameter
7037 'raw_loc'. Handle it. Use
7038 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7039 looking at the breakpoint's type.
7040 (print_one_breakpoint): If handling "maint info breakpoints", also
7041 print locations of exception catchpoints.
7042 * breakpoint.h (is_exception_catchpoint): Declare.
7043
7044 2019-07-09 Pedro Alves <palves@redhat.com>
7045
7046 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7047 "addr" field.
7048 (allocate_location_exception_catchpoint): New.
7049 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7050 (initialize_throw_catchpoint_ops): Install
7051 allocate_location_exception_catchpoint as allocate_location
7052 method.
7053 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7054 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7055 bp_loc_other.
7056 (breakpoint_address_is_meaningful): Delete.
7057 (bl_address_is_meaningful): New.
7058 (breakpoint_locations_match): Adjust comment.
7059 (bp_location_from_bp_type): New, factored out of...
7060 (bp_location::bp_location(breakpoint *)): ... this.
7061 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7062 factored out of...
7063 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7064 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7065 breakpoint_address_is_meaningful.
7066 (bp_locations_compare): Adjust comment.
7067 (update_global_location_list): Use bl_address_is_meaningful
7068 instead of breakpoint_address_is_meaningful.
7069 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7070 explicit.
7071 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7072 * python/py-breakpoint.c (bppy_get_location): No longer check
7073 whether location is null.
7074
7075 2019-07-09 Pedro Alves <palves@redhat.com>
7076
7077 PR c++/15468
7078 * breakpoint.c (print_one_breakpoint_location): Remove
7079 single-location assert.
7080
7081 2019-07-09 Tom Tromey <tom@tromey.com>
7082
7083 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7084 * configure: Rebuild.
7085 * configure.ac: Change common to gdbsupport.
7086 * gdbsupport: Rename from common.
7087 * acinclude.m4: Change common to gdbsupport.
7088 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7089 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7090 gdbsupport.
7091 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7092 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7093 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7094 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7095 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7096 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7097 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7098 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7099 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7100 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7101 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7102 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7103 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7104 coff-pe-read.c, command.h, compile/compile-c-support.c,
7105 compile/compile-c.h, compile/compile-cplus-symbols.c,
7106 compile/compile-cplus-types.c, compile/compile-cplus.h,
7107 compile/compile-loc2c.c, compile/compile.c, completer.c,
7108 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7109 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7110 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7111 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7112 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7113 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7114 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7115 features/aarch64-core.c, features/aarch64-fpu.c,
7116 features/aarch64-pauth.c, features/aarch64-sve.c,
7117 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7118 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7119 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7120 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7121 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7122 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7123 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7124 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7125 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7126 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7127 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7128 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7129 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7130 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7131 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7132 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7133 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7134 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7135 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7136 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7137 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7138 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7139 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7140 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7141 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7142 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7143 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7144 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7145 minsyms.c, mips-linux-tdep.c, namespace.h,
7146 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7147 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7148 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7149 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7150 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7151 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7152 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7153 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7154 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7155 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7156 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7157 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7158 procfs.c, producer.c, progspace.h, psymtab.h,
7159 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7160 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7161 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7162 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7163 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7164 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7165 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7166 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7167 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7168 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7169 target-memory.c, target.c, target.h, target/waitstatus.c,
7170 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7171 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7172 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7173 unittests/array-view-selftests.c,
7174 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7175 unittests/common-utils-selftests.c,
7176 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7177 unittests/format_pieces-selftests.c,
7178 unittests/function-view-selftests.c,
7179 unittests/lookup_name_info-selftests.c,
7180 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7181 unittests/mkdir-recursive-selftests.c,
7182 unittests/observable-selftests.c,
7183 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7184 unittests/parse-connection-spec-selftests.c,
7185 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7186 unittests/scoped_fd-selftests.c,
7187 unittests/scoped_mmap-selftests.c,
7188 unittests/scoped_restore-selftests.c,
7189 unittests/string_view-selftests.c, unittests/style-selftests.c,
7190 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7191 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7192 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7193 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7194 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7195 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7196
7197 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7198
7199 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7200 bool value.
7201 (decode_digits_ordinary): Set explicit_line field in sal.
7202 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7203 symtab_and_line that was set on an explicit line number in
7204 assembler code. Do always update the recorded symtab and line if
7205 we do skip the prologue.
7206
7207 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7208
7209 * breakpoint.c (set_breakpoint_location_function): Remove
7210 explicit_loc parameter.
7211 (momentary_breakpoint_from_master): Update call to
7212 set_breakpoint_location_function.
7213 (add_location_to_breakpoint): Likewise.
7214
7215 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7216
7217 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7218 required features based on default bfd type when no specific bfd
7219 is present.
7220
7221 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7222
7223 * NEWS: Mention that GDB printf and eval commands can now print
7224 C-style and Ada-style convenience var strings without
7225 calling the inferior.
7226 * printcmd.c (printf_c_string): Locally print GDB internal var
7227 instead of transiting via the inferior.
7228 (printf_wide_c_string): Likewise.
7229
7230 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7231
7232 PR breakpoints/25011
7233 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7234
7235 2019-07-04 Tom Tromey <tom@tromey.com>
7236
7237 PR tui/24724:
7238 * tui/tui-winsource.c (tui_clear_source_content): Update.
7239 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7240 (tui_update_breakpoint_info): Update.
7241 (tui_set_exec_info_content): Update.
7242 * tui/tui-source.c (tui_set_source_content_nil): Update.
7243 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7244 has_break.
7245 * tui/tui-data.h (enum tui_bp_flag): New.
7246 (tui_bp_flags): New enum flags type.
7247 (struct tui_source_element) <break_mode>: Change type. Rename
7248 from has_break.
7249 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7250 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7251 constants.
7252 * tui/tui-winsource.h: Fix comment.
7253
7254 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7255
7256 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7257 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7258 (store_fpregs_to_thread)
7259 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7260 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7261 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7262 (IWMMXT_REGS_SIZE): Add define.
7263 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7264 (fetch_vfp_regs, store_vfp_regs)
7265 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7266 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7267
7268 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7269
7270 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7271 defines.
7272 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7273 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7274 (ARM_INT_REGISTER_SIZE): ...to this.
7275 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7276 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7277 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7278 (arm_linux_collect_gregset, supply_nwfpe_register)
7279 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7280 defines.
7281 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7282 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7283 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7284 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7285 (arm_return_in_memory, arm_store_return_value)
7286 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7287 (arm_record_ld_st_multiple): Likewise.
7288 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7289 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7290
7291 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7292
7293 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7294 AARCH64_DISPLACED_MODIFIED_INSNS.
7295 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7296 (aarch64_displaced_step_copy_insn): Likewise.
7297 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7298 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7299 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7300 ARM_DISPLACED_MODIFIED_INSNS.
7301 * arm-tdep.c (arm_gdbarch_init): Likewise.
7302 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7303 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7304 (struct arm_displaced_step_closure): Use
7305 ARM_DISPLACED_MODIFIED_INSNS.
7306
7307 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7308
7309 * features/Makefile: Remove unused xml files.
7310 * features/aarch64.xml: Remove.
7311 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7312 * features/i386/amd64-avx-avx512.xml: Remove.
7313 * features/i386/amd64-avx-linux.xml: Remove.
7314 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7315 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7316 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7317 * features/i386/amd64-avx-mpx.xml: Remove.
7318 * features/i386/amd64-avx.xml: Remove.
7319 * features/i386/amd64-linux.xml: Remove.
7320 * features/i386/amd64-mpx-linux.xml: Remove.
7321 * features/i386/amd64-mpx.xml: Remove.
7322 * features/i386/amd64.xml: Remove.
7323 * features/i386/i386-avx-avx512-linux.xml: Remove.
7324 * features/i386/i386-avx-avx512.xml: Remove.
7325 * features/i386/i386-avx-linux.xml: Remove.
7326 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7327 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7328 * features/i386/i386-avx-mpx-linux.xml: Remove.
7329 * features/i386/i386-avx-mpx.xml: Remove.
7330 * features/i386/i386-avx.xml: Remove.
7331 * features/i386/i386-linux.xml: Remove.
7332 * features/i386/i386-mmx-linux.xml: Remove.
7333 * features/i386/i386-mmx.xml: Remove.
7334 * features/i386/i386-mpx-linux.xml: Remove.
7335 * features/i386/i386-mpx.xml: Remove.
7336 * features/i386/i386.xml: Remove.
7337 * features/i386/x32-avx-avx512-linux.xml: Remove.
7338 * features/i386/x32-avx-linux.xml: Remove.
7339 * features/i386/x32-linux.xml: Remove.
7340
7341 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7342
7343 * regformats/aarch64.dat: Remove.
7344 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7345 * regformats/i386/amd64-avx-linux.dat: Remove.
7346 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7347 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7348 * regformats/i386/amd64-linux.dat: Remove.
7349 * regformats/i386/amd64-mpx-linux.dat: Remove.
7350 * regformats/i386/amd64.dat: Remove.
7351 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7352 * regformats/i386/i386-avx-linux.dat: Remove.
7353 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7354 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7355 * regformats/i386/i386-linux.dat: Remove.
7356 * regformats/i386/i386-mmx-linux.dat: Remove.
7357 * regformats/i386/i386-mpx-linux.dat: Remove.
7358 * regformats/i386/i386.dat: Remove.
7359 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7360 * regformats/i386/x32-avx-linux.dat: Remove.
7361 * regformats/i386/x32-linux.dat: Remove.
7362
7363 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7364
7365 * aarch64-tdep.c: Remove xml self tests.
7366 * amd64-linux-tdep.c: Likewise.
7367 * amd64-tdep.c: Likewise.
7368 * i386-linux-tdep.c: Likewise.
7369 * i386-tdep.c: Likewise.
7370
7371 2019-07-03 Pedro Alves <palves@redhat.com>
7372
7373 PR cli/24732
7374 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7375 (pipe_cmd_option_defs): New.
7376 (make_pipe_cmd_options_def_group): New.
7377 (pipe_command): Use gdb::option::process_options.
7378 (pipe_command_completer): New function.
7379 (_initialize_cli_cmds): Install completer for "pipe" command.
7380
7381 2019-07-03 Pedro Alves <palves@redhat.com>
7382
7383 * cli/cli-option.c (union option_value) <string>: New field.
7384 (struct option_def_and_value): Add ctor, move ctor, dtor and
7385 use DISABLE_COPY_AND_ASSIGN.
7386 (option_def_and_value::clear_value): New.
7387 (parse_option, save_option_value_in_ctx, get_val_type_str)
7388 (add_setshow_cmds_for_options): Handle var_string.
7389 * cli-option.h (union option_def::var_address) <string>: New
7390 field.
7391 (struct string_option_def): New.
7392 * maint-test-options.c (struct test_options_opts): Add default
7393 ctor and use DISABLE_COPY_AND_ASSIGN.
7394 <string_opt>: New field.
7395 (test_options_opts::~test_options_opts): New.
7396 (test_options_opts::dump): Also dump "-string".
7397 (test_options_option_defs): Install "string.
7398
7399 2019-07-03 Pedro Alves <palves@redhat.com>
7400
7401 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7402 option_value with a null enumeration.
7403 (complete_options): Save the option values in the context.
7404 (save_option_value_in_ctx): New, factored out from ...
7405 (process_options): ... here.
7406 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7407 of the function.
7408 * maint-test-options.c (test_options_opts::dump): New, factored
7409 out from ...
7410 (maintenance_test_options_command_mode): ... here.
7411 (maintenance_test_options_command_completion_result): Delete.
7412 (maintenance_test_options_command_completion_text): Update
7413 comment.
7414 (maintenance_show_test_options_completion_result): Change
7415 prototype. Just print
7416 maintenance_test_options_command_completion_text.
7417 (save_completion_result): New.
7418 (maintenance_test_options_completer_mode): Pass options context to
7419 complete_options, and then save a dump.
7420 (_initialize_maint_test_options): Use add_cmd to install "maint
7421 show test-options-completion-result".
7422
7423 2019-07-03 Pedro Alves <palves@redhat.com>
7424
7425 * NEWS (New commands): Mention "with" and "maint with".
7426 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7427 (with_command, with_command_completer): New.
7428 (pipe_command): Adjust to new repeat_previous
7429 interface.
7430 (_initialize_cli_cmds): Install the "with" command and its "w"
7431 alias.
7432 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7433 declarations.
7434 * cli/cli-setshow.c (parse_cli_var_uinteger)
7435 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7436 argument strings for all var_types.
7437 (get_setshow_command_value_string): New, factored out from ...
7438 (do_show_command): ... this.
7439 * cli/cli-setshow.h: Include <string>.
7440 (get_setshow_command_value_string): Declare.
7441 * command.h (repeat_previous): Now returns const char *. Adjust
7442 comment.
7443 * maint.c: Include "cli/cli-cmds.h".
7444 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7445 (_initialize_maint_cmds): Register the "maintenance with" command.
7446 * top.c (repeat_previous): Move bits from pipe_command here:
7447 Return the saved command line, if any; error out if there's no
7448 command to relaunch.
7449
7450 2019-07-03 Pedro Alves <palves@redhat.com>
7451
7452 * NEWS (New commands): Mention "maint set/show test-settings"
7453 instead of "maint test-settings".
7454 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7455 (maintenance_test_settings_set_list): Rename to ...
7456 (maintenance_set_test_settings_list): ... this.
7457 (maintenance_test_settings_show_list): Rename to ...
7458 (maintenance_show_test_settings_list): ... this.
7459 (maintenance_test_settings_cmd): Delete.
7460 (maintenance_test_settings_set_cmd): ...
7461 (maintenance_set_test_settings_cmd): ... this.
7462 (maintenance_test_settings_show_cmd): ...
7463 (maintenance_show_test_settings_cmd): ... this.
7464 (maintenance_test_settings_show_value_cmd):
7465 (maintenance_show_test_settings_value_cmd): ... this.
7466 (_initialize_maint_test_settings): No longer install the "maint
7467 test-settings" prefix command. Rename "maint test-settings set"
7468 to "maint set test-settings", and "maint test-settings show" to
7469 "maint show test-settings". Adjust all subcommands.
7470
7471 2019-07-03 Pedro Alves <palves@redhat.com>
7472
7473 * maint-test-settings.c: Fix file's intro comment. Replace all
7474 references to "test-options" with references to "test-settings",
7475 in comments.
7476
7477 2019-07-03 Pedro Alves <palves@redhat.com>
7478
7479 * maint-test-settings.c (maintenance_test_settings_xxx)
7480 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7481 New.
7482 (maintenance_test_settings_enums): Use them.
7483 (maintenance_test_settings_enum): Default to
7484 maintenance_test_settings_xxx.
7485 (_initialize_maint_test_settings): Initialize
7486 MAINTENANCE_TEST_SETTINGS_FILENAME.
7487
7488 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7489
7490 * breakpoint.h (remove_breakpoints_inf): Change return type to
7491 void, move function documentation here.
7492 * breakpoint.c (remove_breakpoints_inf): Change return type to
7493 void, move function documentation to header.
7494
7495 2019-07-02 Pedro Alves <palves@redhat.com>
7496
7497 * NEWS (Completion improvements): Mention "info threads".
7498 * thread.c (struct info_threads_opts, info_threads_option_defs)
7499 (make_info_threads_options_def_group): New.
7500 (info_threads_command): Use gdb::option::process_options.
7501 (info_threads_command_completer): New.
7502 (_initialize_thread): Use gdb::option::build_help to build the
7503 help text for "info threads".
7504
7505 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7506
7507 * defs.h (generic_load): Move from here...
7508 * symfile.h (generic_load): ... to here. Rename name parameter
7509 to args.
7510 * symfile.c (generic_load): Add comment.
7511
7512 2019-07-01 Tom Tromey <tromey@adacore.com>
7513
7514 * dwarf2read.c
7515 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7516 declaration of without_params. Fix formatting.
7517
7518 2019-07-01 Tom Tromey <tromey@adacore.com>
7519
7520 * ada-exp.y (find_primitive_type): Update.
7521 * ada-lang.h (ada_lookup_symbol): Update.
7522 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7523 parameter.
7524 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7525
7526 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7527
7528 PR breakpoints/24541
7529 * gdbarch.c: Regenerate.
7530 * gdbarch.h: Regenerate.
7531 * gdbarch.sh: Add 'stap_adjust_register'.
7532 * i386-tdep.c: Include '<unordered_set>'.
7533 (i386_stap_adjust_register): New function.
7534 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7535 * stap-probe.c (stap_parse_register_operand): Call
7536 'gdbarch_stap_adjust_register'.
7537
7538 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7539
7540 PR python/24742
7541 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7542 * python/python.c (do_start_initialization): Use 'xmalloc'
7543 instead of 'PyMem_Malloc'.
7544
7545 2019-06-28 Tom Tromey <tromey@adacore.com>
7546
7547 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7548 for Ada.
7549
7550 2019-06-27 Tom Tromey <tromey@adacore.com>
7551
7552 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7553 objfile_key.
7554 (arm_find_mapping_symbol, arm_record_special_symbol)
7555 (_initialize_arm_tdep): Update.
7556 (arm_objfile_data_free): Remove.
7557
7558 2019-06-27 Tom Tromey <tromey@adacore.com>
7559
7560 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7561 to cp_print_static_field.
7562
7563 2019-06-26 Tom Tromey <tromey@adacore.com>
7564
7565 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7566 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7567 declare.
7568
7569 2019-06-26 Alan Hayward <alan.hayward@arm.com>
7570
7571 * features/aarch64-core.c (create_feature_aarch64_core):
7572 Regenerate.
7573 * features/aarch64-core.xml: Add cpsr flags.
7574
7575 2019-06-26 Alan Hayward <alan.hayward@arm.com>
7576
7577 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7578 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7579
7580 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7581
7582 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7583 field.
7584 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7585 use.
7586 (arm_record_special_symbol): Don't insert new symbol in sorted
7587 position, push it at the end.
7588
7589 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7590
7591 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7592 (arm_mapping_symbol_s): Remove.
7593 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7594 (arm_mapping_symbol_vec): New typedef.
7595 (struct arm_per_objfile): Add constructor.
7596 <section_maps>: Change type to
7597 std::unique_ptr<arm_mapping_symbol_vec[]>.
7598 (arm_compare_mapping_symbols): Remove.
7599 (arm_find_mapping_symbol): Adjust to section_maps type change.
7600 (arm_objfile_data_free): Call delete on arm_per_objfile.
7601 (arm_record_special_symbol): Adjust to section_maps type change.
7602 Allocate arm_per_objfile with new.
7603
7604 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7605
7606 * cli/cli-cmds.c (alias_command): Compare the alias prefix
7607 with the command prefix.
7608
7609 2019-06-25 Tom Tromey <tom@tromey.com>
7610
7611 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7612 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7613
7614 2019-06-25 Tom Tromey <tom@tromey.com>
7615
7616 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7617 type.
7618 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7619 protected.
7620
7621 2019-06-25 Tom Tromey <tom@tromey.com>
7622
7623 * tui/tui-winsource.c
7624 (tui_source_window_base::set_is_exec_point_at): Add check against
7625 LOA_ADDRESS.
7626
7627 2019-06-25 Tom Tromey <tom@tromey.com>
7628
7629 * tui/tui-source.c (tui_set_source_content): Don't check before
7630 xfree.
7631 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7632
7633 2019-06-25 Tom Tromey <tom@tromey.com>
7634
7635 * tui/tui-winsource.h (tui_update_source_window_as_is)
7636 (tui_alloc_source_buffer, tui_line_is_displayed)
7637 (tui_addr_is_displayed): Change type of win_info.
7638 * tui/tui-winsource.c (tui_update_source_window_as_is)
7639 (tui_clear_source_content, tui_show_source_line)
7640 (tui_show_source_content, tui_source_window_base::refill)
7641 (tui_source_window_base::set_is_exec_point_at)
7642 (tui_source_window_base::set_is_exec_point_at)
7643 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7644 (tui_alloc_source_buffer, tui_line_is_displayed)
7645 (tui_addr_is_displayed): Change type of win_info. Update.
7646 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7647 (tui_source_window_base::do_make_visible_with_new_height):
7648 Update.
7649 * tui/tui-source.c (tui_set_source_content)
7650 (tui_set_source_content_nil)
7651 (tui_source_window::do_scroll_vertical): Update.
7652 * tui/tui-layout.c (show_layout): Update.
7653 * tui/tui-disasm.c (tui_set_disassem_content)
7654 (tui_disasm_window::do_scroll_vertical): Update.
7655 * tui/tui-data.h (tui_win_content): Remove.
7656 (struct tui_gen_win_info) <content, content_size>: Remove.
7657 (struct tui_source_element): Add initializers and destructor.
7658 (union tui_which_element, struct tui_win_element): Remove.
7659 (struct tui_source_window_base) <content>: New field.
7660 (struct tui_data_window): Remove destructor.
7661 (tui_alloc_content, tui_free_win_content)
7662 (tui_free_all_source_wins_content): Don't declare.
7663 * tui/tui-data.c (tui_initialize_static_data): Update.
7664 (init_content_element, tui_alloc_content): Remove.
7665 (~tui_gen_win_info): Update.
7666 (~tui_data_window, tui_free_all_source_wins_content)
7667 (tui_free_win_content, free_content, free_content_elements):
7668 Remove.
7669
7670 2019-06-25 Tom Tromey <tom@tromey.com>
7671
7672 * tui/tui-winsource.h (tui_clear_source_content)
7673 (tui_erase_source_content, tui_show_source_content): Change type
7674 of win_info.
7675 * tui/tui-winsource.c (tui_clear_source_content)
7676 (tui_erase_source_content, tui_show_source_content): Change type
7677 of win_info.
7678 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7679 * tui/tui-source.h (tui_set_source_content_nil): Change type of
7680 win_info.
7681 * tui/tui-source.c (tui_set_source_content_nil): Change type of
7682 win_info.
7683 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7684
7685 2019-06-25 Tom Tromey <tom@tromey.com>
7686
7687 * tui/tui-winsource.c (tui_clear_source_content)
7688 (tui_source_window_base::set_is_exec_point_at): Update.
7689 * tui/tui-source.c (tui_set_source_content_nil): Update.
7690 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7691 a bool.
7692 * tui/tui-data.c (init_content_element): Update.
7693
7694 2019-06-25 Tom Tromey <tom@tromey.com>
7695
7696 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7697 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7698 * tui/tui-layout.c (init_and_make_win): Update.
7699 * tui/tui.h (enum tui_win_type): Update.
7700 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7701 tui_win_is_auxillary.
7702 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7703 tui_win_is_auxillary.
7704
7705 2019-06-25 Tom Tromey <tom@tromey.com>
7706
7707 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7708 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7709 (tui_delete_data_content_windows, tui_display_all_data)
7710 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7711 Update.
7712 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7713 * tui/tui-regs.c (tui_last_regs_line_no)
7714 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7715 (tui_show_registers): Update.
7716 (tui_show_register_group): Return void. Update.
7717 (tui_display_registers_from, tui_display_reg_element_at_line)
7718 (tui_display_registers_from_line, tui_check_register_values):
7719 Update.
7720 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7721 member.
7722 (struct tui_data_window) <regs_content>: Now a std::vector.
7723 <regs_content_count>: Remove.
7724 (tui_add_content_elements, tui_free_data_content): Don't declare.
7725 * tui/tui-data.c (tui_data_window::clear_detail): Update.
7726 (init_content_element): Remove DATA_WIN case. Add assert.
7727 (tui_add_content_elements): Remove.
7728 (tui_data_window): Update.
7729 (tui_free_data_content): Remove.
7730 (free_content_elements): Remove DATA_WIN case.
7731
7732 2019-06-25 Tom Tromey <tom@tromey.com>
7733
7734 * tui/tui-data.c (tui_data_item_window): Update.
7735 * tui/tui-windata.h (tui_check_data_values): Don't declare.
7736 * tui/tui-windata.c (tui_display_all_data)
7737 (tui_display_data_from_line): Update.
7738 (tui_check_data_values): Remove.
7739 * tui/tui-regs.c (tui_show_register_group)
7740 (tui_display_reg_element_at_line): Update.
7741 * tui/tui-hooks.c (tui_register_changed)
7742 (tui_refresh_frame_and_register_information): Call
7743 tui_check_register_values.
7744 * tui/tui-data.h (struct tui_data_window) <data_content,
7745 data_content_count, data_type>: Remove.
7746 (enum tui_data_type): Remove.
7747
7748 * tui/tui-data.c (tui_data_window::clear_detail)
7749 (~tui_data_window): Update.
7750
7751 2019-06-25 Tom Tromey <tom@tromey.com>
7752
7753 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7754 declare.
7755 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7756 Rename from tui_first_data_item_displayed. Update.
7757 (tui_data_window::refresh_all)
7758 (tui_data_window::do_scroll_vertical): Update.
7759 * tui/tui-data.h (struct tui_data_window)
7760 <first_data_item_displayed>: Declare new method.
7761
7762 2019-06-25 Tom Tromey <tom@tromey.com>
7763
7764 * tui/tui-data.h (tui_init_generic_part): Don't declare.
7765 * tui/tui-data.c (tui_init_generic_part): Remove, moving
7766 contents...
7767 (tui_initialize_static_data): ...here.
7768
7769 2019-06-25 Tom Tromey <tom@tromey.com>
7770
7771 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7772 (tui_display_registers_from, tui_check_register_values): Update.
7773 (tui_display_register): Remove win_info parameter; update.
7774 (tui_get_register): Change type of parameters.
7775 * tui/tui-data.h (struct tui_data_element): Remove.
7776 (union tui_which_element) <data>: Remove.
7777 <data_window>: Change type.
7778 (struct tui_data_item_window): New.
7779 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7780 case. Add assert.
7781 (~tui_data_item_window): New destructor.
7782 (free_content_elements): Remove DATA_ITEM_WIN case.
7783
7784 2019-06-25 Tom Tromey <tom@tromey.com>
7785
7786 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7787 Remove.
7788
7789 2019-06-25 Tom Tromey <tom@tromey.com>
7790
7791 * tui/tui-data.h (struct tui_command_element): Remove.
7792 (union tui_which_element) <command>: Remove.
7793 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
7794 assert.
7795 (free_content_elements): Remove CMD_WIN case.
7796
7797 2019-06-25 Tom Tromey <tom@tromey.com>
7798
7799 * tui/tui-layout.c (tui_set_layout): Update.
7800 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7801 * tui/tui-data.c (layout_def): Update.
7802
7803 2019-06-25 Tom Tromey <tom@tromey.com>
7804
7805 * tui/tui-wingeneral.c (tui_refresh_all): Update.
7806 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7807 (tui_source_window_base::set_new_height): Update.
7808 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7809 Update.
7810 (tui_set_locator_fullname, tui_set_locator_info)
7811 (tui_show_frame_info): Update.
7812 * tui/tui-source.c (tui_set_source_content)
7813 (tui_source_is_displayed): Update.
7814 * tui/tui-layout.c (show_source_disasm_command, show_data)
7815 (show_source_or_disasm_and_command): Update.
7816 * tui/tui-disasm.c (tui_set_disassem_content)
7817 (tui_get_begin_asm_address): Update.
7818 * tui/tui-data.h (struct tui_locator_element): Remove.
7819 (union tui_which_element) <locator>: Remove.
7820 (struct tui_locator_window): New.
7821 (tui_locator_win_info_ptr): Change return type.
7822 * tui/tui-data.c (_locator): Change type.
7823 (tui_locator_win_info_ptr): Change return type.
7824 (init_content_element): Remove LOCATOR_WIN case. Add assert.
7825 (tui_alloc_content): Add assert.
7826
7827 2019-06-25 Tom Tromey <tom@tromey.com>
7828
7829 * tui/tui-winsource.c
7830 (tui_exec_info_window::maybe_allocate_content): New method.
7831 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7832 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7833 (make_source_or_disasm_window): Add cast.
7834 * tui/tui-data.h (union tui_which_element) <simple_string>:
7835 Remove.
7836 (struct tui_source_info): New.
7837 (struct tui_source_window_base) <execution_info>: Change type.
7838 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7839 case, and add assert.
7840 (tui_alloc_content): Add assert.
7841
7842 2019-06-25 Tom Tromey <tom@tromey.com>
7843
7844 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7845 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7846 * tui/tui-data.c (tui_alloc_win_info): Remove.
7847
7848 2019-06-25 Tom Tromey <tom@tromey.com>
7849
7850 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7851 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7852 can_highlight.
7853
7854 2019-06-25 Tom Tromey <tom@tromey.com>
7855
7856 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7857 make_visible_with_new_height method.
7858 (tui_win_info::make_visible_with_new_height): New method.
7859 (tui_source_window_base::do_make_visible_with_new_height)
7860 (tui_data_window::do_make_visible_with_new_height)
7861 (tui_cmd_window::do_make_visible_with_new_height): New methods.
7862 (make_visible_with_new_height): Remove.
7863 (tui_resize_all, tui_adjust_win_heights): Use
7864 make_visible_with_new_height method.
7865 * tui/tui-data.h (struct tui_win_info)
7866 <do_make_visible_with_new_height, make_visible_with_new_height>:
7867 New methods.
7868 (struct tui_source_window_base, struct tui_data_window)
7869 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7870 methods.
7871
7872 2019-06-25 Tom Tromey <tom@tromey.com>
7873
7874 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7875 method.
7876 (update_tab_width): Call update_tab_width method.
7877 * tui/tui-data.h (struct tui_win_info)
7878 (struct tui_source_window_base) <update_tab_width>: New methods.
7879
7880 2019-06-25 Tom Tromey <tom@tromey.com>
7881
7882 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7883 parameter.
7884 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7885 parameter.
7886 (tui_gen_win_info::make_visible): Update.
7887 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7888 parameter.
7889 * tui/tui-data.h (enum tui_box): New enum.
7890 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7891
7892 2019-06-25 Tom Tromey <tom@tromey.com>
7893
7894 * tui/tui-layout.c (make_source_or_disasm_window): Always use
7895 init_and_make_win for EXEC_INFO_WIN.
7896 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7897 longer inline.
7898 (struct tui_win_info) <~tui_win_info>: Inline.
7899 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7900 Don't declare.
7901 * tui/tui-data.c (source_win, disasm_win): Remove globals.
7902 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7903 Remove.
7904 (tui_initialize_static_data): Update.
7905 (~tui_gen_win_info): Handle more cleanup here.
7906 (~tui_source_window_base): Delete "execution_info".
7907 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7908
7909 2019-06-25 Tom Tromey <tom@tromey.com>
7910
7911 * tui/tui-layout.c (make_command_window): Don't set
7912 can_highlight.
7913 (show_source_disasm_command): Call the reset method.
7914 (show_data): Don't set can_highlight. Call the reset method.
7915 (tui_gen_win_info::reset): Rename from init_gen_win_info
7916 (init_and_make_win): Simplify. Return tui_gen_win_info.
7917 (show_source_or_disasm_and_command): Call the reset method.
7918 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
7919 (struct tui_cmd_window): Set can_highlight.
7920
7921 2019-06-25 Tom Tromey <tom@tromey.com>
7922
7923 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
7924 from make_visible.
7925 (tui_make_visible, tui_make_invisible): Rewrite.
7926 (tui_win_info::make_visible): Remove.
7927 (tui_source_window_base::make_visible): Update.
7928 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
7929 method. Moved from...
7930 (struct tui_win_info) <make_visible>: ...here.
7931
7932 2019-06-25 Tom Tromey <tom@tromey.com>
7933
7934 * tui/tui-winsource.c
7935 (tui_source_window_base::do_scroll_horizontal): Remove direction
7936 parameter.
7937 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
7938 direction parameter.
7939 * tui/tui-win.c (tui_win_info::forward_scroll)
7940 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7941 (tui_win_info::right_scroll): Update.
7942 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
7943 direction parameter.
7944 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
7945 direction parameter.
7946 * tui/tui-data.h (enum tui_scroll_direction): Remove.
7947 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
7948 Remove direction parameter.
7949 (struct tui_source_window_base, struct tui_source_window)
7950 (struct tui_disasm_window, struct tui_data_window)
7951 (struct tui_cmd_window): Update.
7952
7953 2019-06-25 Tom Tromey <tom@tromey.com>
7954
7955 * tui/tui-winsource.h (tui_set_exec_info_content)
7956 (tui_show_exec_info_content, tui_erase_exec_info_content)
7957 (tui_clear_exec_info_content, tui_update_exec_info): Change
7958 argument to tui_source_window_base.
7959 * tui/tui-winsource.c (tui_set_exec_info_content)
7960 (tui_show_exec_info_content, tui_erase_exec_info_content)
7961 (tui_clear_exec_info_content, tui_update_exec_info): Change
7962 argument to tui_source_window_base.
7963
7964 2019-06-25 Tom Tromey <tom@tromey.com>
7965
7966 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
7967 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
7968
7969 2019-06-25 Tom Tromey <tom@tromey.com>
7970
7971 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
7972 check.
7973
7974 2019-06-25 Tom Tromey <tom@tromey.com>
7975
7976 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
7977 type to void.
7978 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
7979 type to void.
7980 * tui/tui-source.c (tui_set_source_content): Update.
7981 * tui/tui-disasm.c (tui_set_disassem_content): Update.
7982
7983 2019-06-25 Tom Tromey <tom@tromey.com>
7984
7985 * tui/tui-win.c (window_name_completer, tui_set_focus)
7986 (tui_all_windows_info): Use name method.
7987 * tui/tui-data.h (struct tui_gen_win_info)
7988 (struct tui_source_window, struct tui_disasm_window)
7989 (struct tui_data_window, struct tui_cmd_window) <name>: New
7990 method.
7991 (tui_win_name): Don't declare.
7992 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
7993 (tui_win_name): Remove.
7994
7995 2019-06-25 Tom Tromey <tom@tromey.com>
7996
7997 * tui/tui-winsource.h (tui_update_source_window)
7998 (tui_update_source_window_as_is): Change parameter type.
7999 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8000 to be a tui_source_window_base.
8001 (tui_update_source_window_as_is): Likewise.
8002 * tui/tui-win.c (make_visible_with_new_height): Update.
8003
8004 2019-06-25 Tom Tromey <tom@tromey.com>
8005
8006 * tui/tui-winsource.c (tui_erase_source_content)
8007 (tui_show_source_content, tui_show_exec_info_content)
8008 (tui_erase_exec_info_content): Use refresh_window method.
8009 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8010 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8011 from tui_refresh_win.
8012 (tui_data_window::refresh_window): New method.
8013 (tui_win_info::refresh, tui_source_window_base::refresh)
8014 (tui_refresh_all): Use refresh_window method.
8015 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8016 method.
8017 * tui/tui-regs.c (tui_display_register): Call refresh_window
8018 method.
8019 * tui/tui-layout.c (show_source_disasm_command)
8020 (show_source_or_disasm_and_command): Call refresh_window method.
8021 * tui/tui-data.h (struct tui_gen_win_info)
8022 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8023 New method.
8024
8025 2019-06-25 Tom Tromey <tom@tromey.com>
8026
8027 * tui/tui.c (tui_rl_other_window, tui_enable)
8028 (tui_is_window_visible, tui_get_command_dimension): Update.
8029 * tui/tui-winsource.c (tui_update_source_window_as_is)
8030 (tui_clear_source_content, tui_erase_source_content)
8031 (tui_show_source_line, tui_source_window_base::refill)
8032 (tui_source_window_base::do_scroll_horizontal)
8033 (tui_source_window_base::set_is_exec_point_at)
8034 (tui_update_breakpoint_info, tui_set_exec_info_content)
8035 (tui_alloc_source_buffer, tui_line_is_displayed)
8036 (tui_addr_is_displayed): Update.
8037 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8038 (tui_check_and_display_highlight_if_needed)
8039 (tui_win_info::make_visible, tui_win_info::refresh)
8040 (tui_refresh_all): Update.
8041 * tui/tui-windata.c (tui_first_data_item_displayed)
8042 (tui_delete_data_content_windows, tui_erase_data_content)
8043 (tui_display_all_data, tui_data_window::refresh_all)
8044 (tui_check_data_values): Update.
8045 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8046 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8047 (tui_win_info::backward_scroll, tui_refresh_all_win)
8048 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8049 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8050 (tui_source_window_base::set_new_height)
8051 (tui_data_window::set_new_height)
8052 (make_invisible_and_set_new_height)
8053 (make_visible_with_new_height, new_height_ok)
8054 (parse_scrolling_args): Update.
8055 * tui/tui-stack.c (tui_show_frame_info): Update.
8056 * tui/tui-source.c (tui_set_source_content)
8057 (tui_set_source_content_nil, tui_source_is_displayed)
8058 (tui_source_window::do_scroll_vertical): Update.
8059 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8060 (tui_display_registers_from, tui_display_reg_element_at_line)
8061 (tui_check_register_values, tui_reg_command): Update.
8062 * tui/tui-layout.c (tui_default_win_height)
8063 (show_source_disasm_command, show_data, init_and_make_win)
8064 (show_source_or_disasm_and_command): Update.
8065 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8066 (tui_redisplay_readline, tui_mld_flush)
8067 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8068 (tui_getc): Update.
8069 * tui/tui-disasm.c (tui_set_disassem_content)
8070 (tui_disasm_window::do_scroll_vertical): Update.
8071 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8072 Now virtual.
8073 (struct tui_win_info): Derive from tui_gen_win_info.
8074 <~tui_win_info>: Mark as override.
8075 <generic>: Remove member.
8076 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8077 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8078 (~tui_data_window, ~tui_win_info)
8079 (tui_free_all_source_wins_content): Update.
8080 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8081
8082 2019-06-25 Tom Tromey <tom@tromey.com>
8083
8084 * tui/tui-layout.c (init_and_make_win): Use new.
8085 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8086 destructor, initializers.
8087 (tui_alloc_generic_win_info): Don't declare.
8088 * tui/tui-data.c (_locator): Add argument to constructor.
8089 (source_win, disasm_win): New globals.
8090 (exec_info): Remove.
8091 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8092 Update.
8093 (tui_alloc_generic_win_info): Remove.
8094 (init_content_element): Use new.
8095 (tui_win_info::tui_win_info): Update.
8096 (free_content_elements) <case DATA_WIN>: Use delete.
8097
8098 2019-06-25 Tom Tromey <tom@tromey.com>
8099
8100 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8101 * tui/tui-windata.c (tui_first_data_item_displayed)
8102 (tui_delete_data_content_windows): Update.
8103 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8104 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8105 (tui_display_registers_from, tui_check_register_values): Update.
8106 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8107 pointer.
8108 * tui/tui-data.c (init_content_element): Update. Allocate the new
8109 window.
8110 (tui_free_data_content): Update.
8111 (free_content_elements) <case DATA_WIN>: Free the window.
8112
8113 2019-06-25 Tom Tromey <tom@tromey.com>
8114
8115 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8116 Update.
8117 * tui/tui-layout.c (make_command_window)
8118 (show_source_disasm_command, show_data, init_and_make_win)
8119 (show_source_or_disasm_and_command): Update.
8120 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8121 method.
8122 <can_highight, is_highlighted>: Now bool.
8123 (tui_set_win_highlight): Don't declare.
8124 * tui/tui-data.c (tui_set_win_highlight): Remove.
8125
8126 2019-06-25 Tom Tromey <tom@tromey.com>
8127
8128 * tui/tui-wingeneral.c (make_visible): Remove check of window
8129 type.
8130
8131 2019-06-25 Tom Tromey <tom@tromey.com>
8132
8133 * tui/tui-win.c (tui_win_info::max_height)
8134 (tui_cmd_window::max_height): New methods.
8135 (new_height_ok): Call max_height.
8136 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8137 <max_height>: New method.
8138
8139 2019-06-25 Tom Tromey <tom@tromey.com>
8140
8141 * tui/tui-win.c (tui_source_window_base::set_new_height)
8142 (tui_data_window::set_new_height): New methods.
8143 (make_invisible_and_set_new_height): Call set_new_height method.
8144 * tui/tui-data.h (struct tui_win_info)
8145 (struct tui_source_window_base, struct tui_data_window)
8146 <set_new_height>: New method.
8147
8148 2019-06-25 Tom Tromey <tom@tromey.com>
8149
8150 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8151 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8152 tui_refresh_data_win.
8153 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8154 method.
8155 (tui_refresh_all_win): Call the refresh_all method.
8156 (tui_set_focus): Likewise.
8157 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8158 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8159 Likewise.
8160
8161 2019-06-25 Tom Tromey <tom@tromey.com>
8162
8163 * tui/tui-winsource.h (tui_refill_source_window)
8164 (tui_set_is_exec_point_at): Don't declare.
8165 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8166 (tui_source_window_base::refill): Rename from
8167 tui_refill_source_window.
8168 (tui_source_window_base::do_scroll_horizontal): Update.
8169 (tui_source_window_base::set_is_exec_point_at): Rename from
8170 tui_set_is_exec_point_at.
8171 (tui_update_all_breakpoint_info): Update.
8172 * tui/tui-stack.c (tui_show_frame_info): Update.
8173 * tui/tui-layout.c (show_data): Add cast.
8174 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8175 * tui/tui-data.h (struct tui_source_window_base) <refill,
8176 set_is_exec_point_at>: New methods.
8177 (tui_source_windows, tui_add_to_source_windows): Update types.
8178 (tui_add_to_source_windows): Remove redundant declaration.
8179 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8180 (tui_source_windows): Change return type.
8181 (tui_clear_source_windows_detail): Update.
8182 (tui_add_to_source_windows): Change type of parameter.
8183 (tui_free_all_source_wins_content): Update.
8184
8185 2019-06-25 Tom Tromey <tom@tromey.com>
8186
8187 * tui/tui-wingeneral.c (tui_win_info::refresh)
8188 (tui_source_window_base::refresh): New methods.
8189 (tui_refresh_all): Call the refresh method.
8190 * tui/tui-data.h (struct tui_win_info)
8191 (struct tui_source_window_base) <refresh>: New method.
8192
8193 2019-06-25 Tom Tromey <tom@tromey.com>
8194
8195 * tui/tui.h (tui_is_window_visible): Return bool.
8196 * tui/tui.c (tui_is_window_visible): Return bool.
8197 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8198 (tui_make_visible, tui_make_invisible)
8199 (tui_win_info::make_visible)
8200 (tui_source_window_base::make_visible, make_all_visible)
8201 (tui_make_all_visible, tui_make_all_invisible): Update.
8202 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8203 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8204 bool.
8205 (struct tui_win_info, struct tui_source_window_base)
8206 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8207 * tui/tui-data.c (tui_init_generic_part): Update.
8208
8209 2019-06-25 Tom Tromey <tom@tromey.com>
8210
8211 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8212 (tui_source_window_base::make_visible): New methods.
8213 (make_all_visible): Make method call.
8214 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8215 (struct tui_source_window_base, struct tui_cmd_window): Override
8216 make_visible.
8217 (tui_win_is_source_type): Don't declare.
8218 * tui/tui-data.c (tui_win_is_source_type): Remove.
8219
8220 2019-06-25 Tom Tromey <tom@tromey.com>
8221
8222 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8223 NULL check.
8224
8225 2019-06-25 Tom Tromey <tom@tromey.com>
8226
8227 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8228 Inline constructor. Add initializers for members.
8229 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8230 constructors; now inline in class.
8231
8232 2019-06-25 Tom Tromey <tom@tromey.com>
8233
8234 * tui/tui-regs.c (tui_show_registers): Update.
8235 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8236 bool.
8237 * tui/tui-data.c (tui_data_window::clear_detail)
8238 (tui_data_window): Update.
8239
8240 2019-06-25 Tom Tromey <tom@tromey.com>
8241
8242 * tui/tui-windata.c (tui_display_all_data)
8243 (tui_display_data_from_line, tui_display_data_from)
8244 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8245 Update.
8246 * tui/tui-regs.c (tui_last_regs_line_no)
8247 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8248 (tui_show_registers, tui_show_register_group)
8249 (tui_display_registers_from, tui_display_reg_element_at_line)
8250 (tui_display_registers_from_line, tui_check_register_values)
8251 (tui_reg_next, tui_reg_prev): Update.
8252 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8253 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8254 tui_data_window.
8255 (struct tui_win_info) <detail>: Remove. Add new fields from
8256 tui_data_info.
8257 (TUI_DATA_WIN): Add cast.
8258 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8259 (~tui_data_window): Simplify.
8260
8261 2019-06-25 Tom Tromey <tom@tromey.com>
8262
8263 * tui/tui-layout.c (show_source_disasm_command)
8264 (show_source_or_disasm_and_command): Update.
8265 * tui/tui-io.c (update_cmdwin_start_line)
8266 (tui_redisplay_readline): Update.
8267 * tui/tui-data.h (struct tui_command_info): Remove.
8268 (struct tui_win_info) <detail>: Remove command_info member.
8269 (struct tui_data_window) <start_line>: New member, from
8270 tui_command_info.
8271 (TUI_CMD_WIN): Add casts.
8272
8273 2019-06-25 Tom Tromey <tom@tromey.com>
8274
8275 * tui/tui-winsource.c (tui_update_source_window)
8276 (tui_refill_source_window)
8277 (tui_source_window_base::do_scroll_horizontal)
8278 (tui_update_breakpoint_info, tui_set_exec_info_content)
8279 (tui_show_exec_info_content, tui_erase_exec_info_content)
8280 (tui_clear_exec_info_content): Update.
8281 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8282 Update.
8283 * tui/tui-win.c (make_invisible_and_set_new_height)
8284 (make_visible_with_new_height): Update.
8285 * tui/tui-source.c (tui_set_source_content)
8286 (tui_show_symtab_source): Update.
8287 * tui/tui-layout.c (extract_display_start_addr)
8288 (show_source_disasm_command, show_data)
8289 (make_source_or_disasm_window)
8290 (show_source_or_disasm_and_command): Update.
8291 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8292 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8293 "gdbarch".
8294 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8295 to tui_source_window_base.
8296 (struct tui_win_info) <detail>: Remove source_info member.
8297 (struct tui_source_window_base) <has_locator>: Inline.
8298 Move contents from tui_source_info; rename has_locator member to
8299 m_has_locator.
8300 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8301 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8302 header file.
8303 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8304 Simplify.
8305 (tui_free_all_source_wins_content): Cast to
8306 tui_source_window_base.
8307
8308 2019-06-25 Tom Tromey <tom@tromey.com>
8309
8310 * tui/tui-win.c (make_invisible_and_set_new_height)
8311 (make_visible_with_new_height): Call has_locator method.
8312 * tui/tui-layout.c (show_source_disasm_command, show_data)
8313 (show_source_or_disasm_and_command): Update for bool change.
8314 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8315 (tui_win_info) <has_locator>: New method.
8316 (struct tui_source_window_base) <has_locator>: New method.
8317 (tui_win_has_locator): Don't declare.
8318 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8319 from tui_win_has_locator.
8320 (tui_source_window_base): Use false, not FALSE.
8321
8322 2019-06-25 Tom Tromey <tom@tromey.com>
8323
8324 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8325 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8326 clear_detail method directly.
8327 (tui_clear_win_detail): Remove.
8328
8329 2019-06-25 Tom Tromey <tom@tromey.com>
8330
8331 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8332 "this", not TUI_DISASM_WIN.
8333
8334 2019-06-25 Tom Tromey <tom@tromey.com>
8335
8336 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8337 declare.
8338 * tui/tui-winsource.c
8339 (tui_source_window_base::do_scroll_horizontal): Rename from
8340 tui_horizontal_source_scroll.
8341 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8342 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8343 from tui_vertical_data_scroll.
8344 * tui/tui-win.h (tui_scroll): Don't declare.
8345 * tui/tui-win.c (tui_win_info::forward_scroll)
8346 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8347 (tui_win_info::right_scroll): Rename and update.
8348 (tui_scroll_forward_command, tui_scroll_backward_command)
8349 (tui_scroll_left_command, tui_scroll_right_command): Update.
8350 (tui_scroll): Remove.
8351 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8352 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8353 from tui_vertical_source_scroll.
8354 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8355 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8356 from tui_vertical_disassem_scroll.
8357 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8358 do_scroll_horizontal>: New methods.
8359 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8360 Likewise.
8361 (struct tui_source_window_base): Add do_scroll_horizontal.
8362 (struct tui_source_window, struct tui_disasm_window): Add
8363 do_scroll_vertical.
8364 (struct tui_data_window, struct tui_cmd_window): Add
8365 do_scroll_horizontal and do_scroll_vertical.
8366 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8367
8368 2019-06-25 Tom Tromey <tom@tromey.com>
8369
8370 * tui/tui-data.h (struct tui_source_window_base): New struct.
8371 (struct tui_source_window): Derive from tui_source_window_base.
8372 (struct tui_disasm_window): New struct.
8373 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8374 from tui_source_window::clear_detail.
8375 (tui_source_window_base): Rename from tui_source_window.
8376 (~tui_source_window_base): Rename from ~tui_source_window.
8377 (tui_alloc_win_info): Create a tui_disasm_window.
8378
8379 2019-06-25 Tom Tromey <tom@tromey.com>
8380
8381 * tui/tui-data.h (struct tui_source_window)
8382 (struct tui_data_window): Declare destructors.
8383 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8384 destructors.
8385 (tui_win_info): Simplify.
8386
8387 2019-06-25 Tom Tromey <tom@tromey.com>
8388
8389 * tui/tui-winsource.c (tui_display_main)
8390 (tui_update_source_windows_with_addr)
8391 (tui_update_all_breakpoint_info): Update.
8392 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8393 (new_height_ok, parse_scrolling_args): Update.
8394 * tui/tui-stack.c (tui_show_frame_info): Update.
8395 * tui/tui-data.h (struct tui_list): Remove.
8396 (tui_source_windows): Return a reference to a std::vector.
8397 * tui/tui-data.c (source_windows): Now a std::vector.
8398 (tui_source_windows): Change return type.
8399 (tui_clear_source_windows): Rewrite.
8400 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8401 (tui_free_all_source_wins_content): Rewrite.
8402
8403 2019-06-25 Tom Tromey <tom@tromey.com>
8404
8405 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8406 (struct tui_data_window, struct tui_cmd_window): Declare
8407 clear_detail method.
8408 * tui/tui-data.c (tui_source_window::clear_detail)
8409 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8410 methods.
8411 (tui_clear_win_detail): Simplify.
8412
8413 2019-06-25 Tom Tromey <tom@tromey.com>
8414
8415 * tui/tui-layout.c (make_source_window, make_disasm_window)
8416 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8417 Return the new window.
8418 (show_source_disasm_command, show_data)
8419 (show_source_or_disasm_and_command): Update.
8420
8421 2019-06-25 Tom Tromey <tom@tromey.com>
8422
8423 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8424 parameter. Return the new window.
8425 (show_source_disasm_command): Update and remove NULL check.
8426 (show_source_or_disasm_and_command): Update.
8427
8428 2019-06-25 Tom Tromey <tom@tromey.com>
8429
8430 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8431
8432 2019-06-25 Tom Tromey <tom@tromey.com>
8433
8434 * tui/tui-data.h (struct tui_win_info): Make constructor
8435 protected. Make destructor virtual. Add initializers.
8436 (tui_source_window, tui_data_window, tui_cmd_window): New
8437 classes.
8438 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8439 constructor. Add "type" parameter.
8440 (tui_source_window, tui_data_window, tui_cmd_window): New
8441 constructors.
8442 (tui_alloc_win_info): Instantiate the appropriate subclass.
8443
8444 2019-06-25 Tom Tromey <tom@tromey.com>
8445
8446 * tui/tui-win.c (tui_resize_all): Use delete.
8447 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8448 destructor.
8449 (tui_free_window): Don't declare.
8450 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8451 Update.
8452
8453 2019-06-25 Tom Tromey <tom@tromey.com>
8454
8455 * tui/tui-data.h (struct tui_win_info): Add constructor.
8456 * tui/tui-data.c (tui_alloc_win_info): Use new.
8457 (tui_free_window): Use delete.
8458
8459 2019-06-22 Tom Tromey <tom@tromey.com>
8460
8461 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8462 declare.
8463 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8464
8465 2019-06-22 Tom Tromey <tom@tromey.com>
8466
8467 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8468 declare.
8469 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8470
8471 2019-06-22 Tom de Vries <tdevries@suse.de>
8472
8473 * dwarf2read.c (create_addrmap_from_aranges)
8474 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8475 instead of '%zu'.
8476
8477 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
8478
8479 * dwarf2read.h (dwarf2_section_info_def): Remove.
8480 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8481 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8482 std::vector<dwarf2_section_info>.
8483 (struct dwo_file) <~dwo_file>: Remove.
8484 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8485 types field.
8486 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8487 (dwarf2_read_debug_names): Likewise.
8488 (create_debug_types_hash_table): Change parameter type to
8489 array_view, adjust code accordingly.
8490 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8491 (partial_die_info::fixup): Likewise.
8492 (determine_prefix): Likewise.
8493 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8494
8495 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8496
8497 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8498 gdb_bfd_ref_ptr.
8499 <~dwo_file>: Remove call to gdb_bfd_unref.
8500 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8501 gdb_bfd_ref_ptr::get.
8502
8503 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8504
8505 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8506 type to htab_up.
8507 * dwarf2read.c (struct dwo_file): Initialize fields.
8508 <~dwo_file>: New.
8509 (free_dwo_file): Remove, move content to ~dwo_file.
8510 (struct dwo_file_deleter): Remove.
8511 (dwo_file_up>: Remove custom deleter.
8512 (free_dwo_files): Remove.
8513 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8514 dwo_files.
8515 (process_skeletonless_type_units): Call unique_ptr::get.
8516 (allocate_dwo_file_hash_table): Add deleter to created hash
8517 table. Change return type to htab_up.
8518 (lookup_dwo_file_slot): Don't memset dwo_file, call
8519 unique_ptr::get.
8520 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8521 (create_dwo_unit_in_dwp_v2): Likewise.
8522 (open_and_init_dwo_file): Likewise.
8523 (free_dwo_file_from_slot): Remove.
8524
8525 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8526
8527 * dwarf2read.h (struct dwarf2_section_info) <readin,
8528 is_virtual>: Change type to bool.
8529 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8530 true instead of 1.
8531
8532 2019-06-19 Tom Tromey <tom@tromey.com>
8533
8534 * tui/tui-data.h (tui_init_content_element): Don't declare.
8535
8536 2019-06-19 Tom Tromey <tom@tromey.com>
8537
8538 * tui/tui-data.h (tui_init_win_info): Don't declare.
8539
8540 2019-06-19 Tom de Vries <tdevries@suse.de>
8541
8542 * dwarf2read.h (abstract_to_concrete): Change type to
8543 std::unordered_map<sect_offset, std::vector<sect_offset>,
8544 gdb::hash_enum<sect_offset>>.
8545
8546 2019-06-19 Tom Tromey <tromey@adacore.com>
8547
8548 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8549 EVAL_AVOID_SIDE_EFFECTS specially.
8550
8551 2019-06-19 Tom Tromey <tromey@adacore.com>
8552
8553 * source-cache.c (highlighter): New global.
8554 (source_cache::get_source_lines): Create a highlighter on demand.
8555
8556 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8557
8558 * defs.h (deprecated_interactive_hook): Delete declaration.
8559 * interps.c (clear_interpreter_hooks): Remove use of
8560 deprecated_interactive_hook.
8561 * top.c (deprecated_interactive_hook): Delete definition.
8562 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8563
8564 2019-06-18 Tom de Vries <tdevries@suse.de>
8565
8566 PR gdb/24515
8567 * dwarf2read.h (abstract_to_concrete): Change type from
8568 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8569 std::unordered_map<sect_offset, std::vector<sect_offset>>.
8570 * dwarf2read.c (read_variable): Update.
8571 (dwarf2_fetch_die_loc_sect_off): Update.
8572
8573 2019-06-17 Tom de Vries <tdevries@suse.de>
8574
8575 PR gdb/24617
8576 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8577 accessing parent[parent_len - 1].
8578
8579 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
8580
8581 PR gdb/24364
8582 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8583 call dtrace_process_dof with NULL dof.
8584
8585 2019-06-16 Tom de Vries <tdevries@suse.de>
8586
8587 PR gdb/24445
8588 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8589
8590 2019-06-16 Tom Tromey <tom@tromey.com>
8591
8592 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8593 (make_all_visible): Use address of member.
8594
8595 2019-06-16 Tom Tromey <tom@tromey.com>
8596
8597 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8598 (tui_free_window, free_content, free_content_elements): Remove
8599 unnecessary cast.
8600 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8601 cast.
8602 * tui/tui-regs.c (tui_show_register_group)
8603 (tui_display_registers_from, tui_display_reg_element_at_line):
8604 Remove unnecessary cast.
8605
8606 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
8607
8608 * linux-nat.c (normal_mask): Delete.
8609 (_initialize_linux_nat): Don't initialise normal_mask.
8610
8611 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
8612
8613 PR gdb/24445
8614 * dwarf-index-write.h (write_psymtabs_to_index): Add
8615 dwz_basename parameter.
8616 * dwarf-index-write.c (write_gdbindex): Move file writing to
8617 write_gdbindex_1. Change return type void.
8618 (assert_file_size): Move up, remove filename parameter.
8619 (write_gdbindex_1): New function.
8620 (write_debug_names): Change return type to void, call
8621 assert_file_size.
8622 (struct index_wip_file): New struct.
8623 (write_psymtabs_to_index): Add dwz_basename parameter. Move
8624 file logic to index_wip_file. Write index for dwz file if
8625 needed.
8626 (save_gdb_index_command): Pass basename of dwz file, if present.
8627 * dwarf-index-cache.c (index_cache::store): Obtain and pass
8628 build-id of dwz file, if present.
8629 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8630 (dwarf2_get_dwz_file): Likewise.
8631 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8632 (dwarf2_get_dwz_file): Likewise.
8633
8634 2019-06-16 Tom Tromey <tom@tromey.com>
8635
8636 * coffread.c (process_coff_symbol): Use xstrdup.
8637 * value.c (create_internalvar): Use xstrdup.
8638
8639 2019-06-16 Tom Tromey <tom@tromey.com>
8640
8641 * valops.c (value_cast, value_slice): Remove unnecessary cast.
8642 * breakpoint.c (stopin_command, stopat_command)
8643 (until_break_command, decode_location_default): Remove unnecessary
8644 cast.
8645 * utils.c (subset_compare): Remove unnecessary cast.
8646 * ada-lang.c (ada_update_initial_language): Remove unnecessary
8647 cast.
8648 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8649 cast.
8650 * infcmd.c (path_command): Remove unnecessary cast.
8651 * coffread.c (decode_type): Remove unnecessary cast.
8652 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8653 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8654 * tui/tui-stack.c (tui_show_locator_content)
8655 (tui_show_frame_info): Remove unnecessary cast.
8656 * tui/tui-win.c (tui_scroll_forward_command)
8657 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8658 (parse_scrolling_args): Remove unnecessary cast.
8659 * tui/tui-data.c (init_win_info, tui_del_window)
8660 (tui_free_window, tui_del_data_windows, tui_free_data_content)
8661 (free_content_elements): Remove unnecessary cast.
8662 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8663 unnecessary cast.
8664 * tui/tui-source.c (tui_set_source_content)
8665 (tui_vertical_source_scroll): Remove unnecessary cast.
8666 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8667 cast.
8668 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8669 * tui/tui-regs.c (tui_display_registers_from)
8670 (tui_display_register): Remove unnecessary cast.
8671 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8672 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8673 (make_visible): Remove unnecessary cast.
8674 * tui/tui-winsource.c (tui_erase_source_content)
8675 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8676 unnecessary cast.
8677 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8678 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8679 * stabsread.c (read_type, read_array_type, read_range_type):
8680 Remove unnecessary cast.
8681 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8682 (parse_symbol, parse_type, upgrade_type, parse_external)
8683 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8684 unnecessary cast.
8685 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8686
8687 2019-06-16 Tom Tromey <tom@tromey.com>
8688
8689 * tui/tui-data.c (tui_alloc_generic_win_info)
8690 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8691 checks.
8692
8693 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
8694 Andrew Burgess <andrew.burgess@embecosm.com>
8695
8696 * f-typeprint.c (f_print_type): Don't return early for not
8697 associated or not allocated types.
8698 (f_type_print_varspec_suffix): Add print_rank parameter and print
8699 ranks of array types in case they dangling.
8700 (f_type_print_base): Add print_rank parameter.
8701
8702 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8703
8704 * NEWS: Mention new MI commands.
8705 * break-catch-throw.c (enum exception_event_kind): Move to
8706 breakpoint.h.
8707 (print_mention_exception_catchpoint): Output text as a single
8708 message.
8709 (catch_exception_command_1): Rename to...
8710 (catch_exception_event): ...this, make non-static, update header
8711 command, and change some parameter types.
8712 (catch_catch_command): Update for changes to
8713 catch_exception_command_1.
8714 (catch_throw_command): Likewise.
8715 (catch_rethrow_command): Likewise.
8716 * breakpoint.c (enum exception_event_kind): Delete.
8717 * breakpoint.h (enum exception_event_kind): Moved here from
8718 break-catch-throw.c.
8719 (catch_exception_event): Declare.
8720 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8721 (mi_cmd_catch_throw): New function.
8722 (mi_cmd_catch_rethrow): New function.
8723 (mi_cmd_catch_catch): New function.
8724 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8725 'catch-catch' entries.
8726 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8727 (mi_cmd_catch_rethrow): Declare.
8728 (mi_cmd_catch_catch): Declare.
8729
8730 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8731
8732 * annotate.c (annotate_source_line): Change return type to void,
8733 update implementation to match.
8734 * annotate.h (annotate_source_line): Change return type to void,
8735 update header comment.
8736 * stack.c (print_frame_info): Don't change what frame information
8737 is printed based on whether annotations are on or not.
8738
8739 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8740
8741 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8742 (annotate_source): Make static.
8743 (annotate_source_line): Moved from source.c and renamed from
8744 identify_source_line. Update the return type.
8745 * annotate.h (annotate_source): Delete declaration.
8746 (annotate_source_line): Declaration moved from source.h, and
8747 renamed from identify_source_line. Return type updated.
8748 * source.c (identify_source_line): Moved to annotate.c and renamed
8749 to annotate_source_line.
8750 (info_line_command): Remove check of annotation_level.
8751 * source.h (identify_source_line): Move declaration to annotate.h
8752 and rename to annotate_source_line.
8753 * stack.c: Add 'annotate.h' include.
8754 (print_frame_info): Remove check of annotation_level before
8755 calling annotate_source_line.
8756
8757 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8758
8759 * source-cache.c (source_cache::get_plain_source_lines): Use
8760 open_source_file_with_line_charpos instead of just
8761 open_source_file, remove call to find_source_lines.
8762 (source_cache::get_source_lines): Likewise.
8763 * source.c (find_source_lines): Make static.
8764 (get_filename_and_charpos): Renamed into...
8765 (open_source_file_with_line_charpos): ..this along with changes to
8766 return a scoped_fd, and some other minor clean ups.
8767 (identify_source_line): Use open_source_file_with_line_charpos.
8768 (search_command_helper): Use open_source_file_with_line_charpos
8769 instead of just open_source_file, remove call to
8770 find_source_lines.
8771 * source.h (open_source_file_with_line_charpos): Declare new
8772 function.
8773 (find_source_lines): Delete declaration.
8774
8775 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8776
8777 * source.c (get_filename_and_charpos): Remove fullname
8778 parameter.
8779 (identify_source_line): Update call to get_filename_and_charpos.
8780
8781 2019-06-14 Tom Tromey <tromey@adacore.com>
8782
8783 PR gdb/24502:
8784 * ui-style.h (skip_ansi_escape): Update comment.
8785 * ui-file.h (class no_terminal_escape_file): New class.
8786 * ui-file.c (no_terminal_escape_file::write)
8787 (no_terminal_escape_file::puts): New methods.
8788 * cli/cli-logging.c (handle_redirections): Use
8789 no_terminal_escape_file.
8790
8791 2019-06-14 Tom Tromey <tromey@adacore.com>
8792
8793 * NEWS: Move convenience variable news above Python news.
8794
8795 2019-06-14 Tom Tromey <tom@tromey.com>
8796
8797 * gnulib: Move directory to top-level.
8798 * configure.ac: Don't configure gnulib.
8799 * configure: Rebuild.
8800 * common/common-defs.h: Use new path to gnulib.
8801 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8802 (GNULIB_H): Remove.
8803 (INCGNU): Look in new gnulib location.
8804 (HFILES_NO_SRCDIR): Remove gnulib files.
8805 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8806 (generated_files): Remove GNULIB_H.
8807 ($(LIBGNU), all-lib): Remove targets.
8808 (distclean): Don't mention GNULIB_BUILDDIR.
8809 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8810
8811 2019-06-14 Tom Tromey <tromey@adacore.com>
8812
8813 * symfile.c (add_symbol_file_command): Remove obsolete comment.
8814 Warn if symbol file does not provide any symbols.
8815
8816 2019-06-14 Tom Tromey <tromey@adacore.com>
8817
8818 * source.c (find_and_open_source): Respect basenames_may_differ.
8819
8820 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
8821
8822 * annotate.c (annotate_breakpoints_invalid): Make use of
8823 scoped_restore_terminal_state.
8824 (annotate_frames_invalid): Likewise.
8825
8826 2019-06-14 Tom Tromey <tromey@adacore.com>
8827
8828 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8829 allow assignment to an internalvar.
8830
8831 2019-06-14 Tom Tromey <tromey@adacore.com>
8832
8833 * ada-lex.l: Allow "_" in attribute names.
8834
8835 2019-06-14 Tom Tromey <tromey@adacore.com>
8836
8837 PR gdb/24653:
8838 * regcache.c (registers_changed): Don't call alloca.
8839 * top.c (execute_command): Don't call alloca.
8840
8841 2019-06-13 Pedro Alves <palves@redhat.com>
8842
8843 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8844 'expression'. When parsing an expression, error out if there's
8845 junk after "unlimited".
8846 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8847 (do_set_command): Adjust calls to is_unlimited_literal.
8848
8849 2019-06-13 Pedro Alves <palves@redhat.com>
8850
8851 * compile/compile.c (make_compile_options_def_group): Add braces
8852 around array_view initializer.
8853 * thread.c (make_thread_apply_all_options_def_group)
8854 (make_thread_apply_all_options_def_group): Likewise.
8855
8856 2019-06-13 Pedro Alves <palves@redhat.com>
8857
8858 * NEWS (New commands): Mention "maint test-options
8859 require-delimiter", "maint test-options unknown-is-error", "maint
8860 test-options unknown-is-operand" and "maint show
8861 test-options-completion-result".
8862 (New command options, command completion): New section.
8863 (Completion improvements): New section.
8864 Mention that you can abbreviate "unlimited".
8865
8866 2019-06-13 Pedro Alves <palves@redhat.com>
8867
8868 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8869 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8870 * unittests/cli-utils-selftests.c (test_parse_flags)
8871 (test_parse_flags_qcs): Delete.
8872 (test_cli_utils): Don't call deleted functions.
8873
8874 2019-06-13 Pedro Alves <palves@redhat.com>
8875
8876 * thread.c: Include "cli/cli-option.h".
8877 (tp_array_compar_ascending): Global.
8878 (tp_array_compar): Delete function.
8879 (tp_array_compar_ascending, tp_array_compar_descending): New
8880 functions.
8881 (ascending_option_def, qcs_flag_option_def)
8882 (thr_qcs_flags_option_defs)
8883 (make_thread_apply_all_options_def_group)
8884 (make_thread_apply_options_def_group): New.
8885 (thread_apply_all_command): Use gdb::option::process_options.
8886 (thread_apply_command_completer)
8887 (thread_apply_all_command_completer): New.
8888 (thread_apply_command): Use gdb::option::process_options.
8889 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8890 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
8891 to generate help text of "thread apply". Adjust "taas"'s help.
8892 * tid-parse.c (tid_range_parser::in_thread_range): New method.
8893 * tid-parse.h (tid_range_parser::in_thread_range): New method.
8894
8895 2019-06-13 Pedro Alves <palves@redhat.com>
8896
8897 * thread.c (thread_apply_command): Check for invalid TID with
8898 isdigit instead of !isalpha.
8899
8900 2019-06-13 Pedro Alves <palves@redhat.com>
8901
8902 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8903 (validate_flags_qcs): New.
8904 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8905 (validate_flags_qcs): Declare.
8906 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8907 (make_frame_apply_options_def_group): New.
8908 (frame_apply_command_count): Process options with
8909 gdb::option::process_options.
8910 (frame_apply_completer): New.
8911 (frame_apply_level_completer, frame_apply_all_completer)
8912 (frame_apply_completer): New.
8913 (_initialize_stack): Update help of "frame apply", "frame apply
8914 level", "frame apply all" and "faas" to mention supported options
8915 and install command completers.
8916 * stack.h (frame_apply_all_completer): Declare.
8917 * thread.c: Include "stack.h".
8918 (tfaas_command): Add "--".
8919 (_initialize_thread): Update help "tfaas" to mention supported
8920 options and install command completer.
8921
8922 2019-06-13 Pedro Alves <palves@redhat.com>
8923
8924 * completer.c (complete_nested_command_line): New.
8925 (gdb_completion_word_break_characters_throw): Add assertion.
8926 * completer.h (complete_nested_command_line): Declare.
8927
8928 2019-06-13 Pedro Alves <palves@redhat.com>
8929
8930 * stack.c (parse_backtrace_qualifiers): New.
8931 (backtrace_command): Use it.
8932 (backtrace_command_completer): Complete on qualifiers.
8933
8934 2019-06-13 Pedro Alves <palves@redhat.com>
8935
8936 * frame.c: Include "cli/cli-option.h.
8937 (user_set_backtrace_options): New.
8938 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
8939 Delete.
8940 (get_prev_frame): Adjust.
8941 (boolean_option_def, uinteger_option_def)
8942 (set_backtrace_option_defs): New.
8943 (_initialize_frame): Adjust and use
8944 gdb::option::add_setshow_cmds_for_options to install "set
8945 backtrace past-main" and "set backtrace past-entry".
8946 * frame.h: Include "cli/cli-option.h".
8947 (struct frame_print_options): Forward declare.
8948 (print_frame_arguments_all, print_frame_arguments_scalars)
8949 (print_frame_arguments_none): Declare.
8950 (print_entry_values): Delete declaration.
8951 (struct frame_print_options, user_frame_print_options): New.
8952 (struct set_backtrace_options): New.
8953 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
8954 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
8955 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
8956 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
8957 (list_args_or_locals): Add frame_print_options parameter.
8958 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8959 * python/py-framefilter.c (enumerate_args): Pass down
8960 USER_FRAME_PRINT_OPTIONS.
8961 * stack.c: Include "cli/cli-option.h".
8962 (print_frame_arguments_all, print_frame_arguments_scalars)
8963 (print_frame_arguments_none): Declare.
8964 (print_raw_frame_arguments, print_entry_values): Delete.
8965 (user_frame_print_options): New.
8966 (boolean_option_def, enum_option_def, frame_print_option_defs):
8967 New.
8968 (struct backtrace_cmd_options): New.
8969 (bt_flag_option_def): New.
8970 (backtrace_command_option_defs): New.
8971 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8972 (print_frame_arg, read_frame_arg, print_frame_args)
8973 (print_frame_info, print_frame): Add frame_print_options parameter
8974 and use it.
8975 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
8976 (backtrace_command_1): Add frame_print_options and
8977 backtrace_cmd_options parameters and use them.
8978 (make_backtrace_options_def_group): New.
8979 (backtrace_command): Process command options with
8980 gdb::option::process_options.
8981 (backtrace_command_completer): New.
8982 (_initialize_stack): Extend "backtrace"'s help to mention
8983 supported options. Install completer for "backtrace".
8984 Install some settings commands with add_setshow_cmds_for_options.
8985
8986 2019-06-13 Pedro Alves <palves@redhat.com>
8987
8988 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
8989 and that "set/show print raw frame-arguments" are now deprecated.
8990
8991 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
8992 command.
8993 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
8994 * stack.c (_initialize_stack): Install "set/show print
8995 raw-frame-arguments", and deprecate "set/show print raw
8996 frame-arguments".
8997 * valprint.c (_initialize_valprint): Deprecate "set/show print
8998 raw".
8999
9000 2019-06-13 Pedro Alves <palves@redhat.com>
9001
9002 * compile/compile.c (struct compile_options): New.
9003 (compile_flag_option_def, compile_command_option_defs)
9004 (make_compile_options_def_group): New.
9005 (compile_file_command): Handle options with
9006 gdb::option::process_options.
9007 (compile_file_command_completer): New function.
9008 (compile_code_command): Handle options with
9009 gdb::option::process_options.
9010 (compile_code_command_completer): New function.
9011 (_initialize_compiler): Install completers for "compile code" and
9012 "compile file". Mention available options in "compile code" and
9013 "compile code"'s help.
9014 * completer.c (advance_to_completion_word): New, factored out from
9015 ...
9016 (advance_to_expression_complete_word_point): ... this.
9017 (advance_to_filename_complete_word_point): New.
9018 * completer.h (advance_to_filename_complete_word_point): New
9019 declaration.
9020
9021 2019-06-13 Pedro Alves <palves@redhat.com>
9022
9023 * compile/compile.c: Include "cli/cli-option.h".
9024 (compile_print_value): Scope data pointer is now a
9025 value_print_options pointer; adjust.
9026 (compile_print_command): Process options. Scope data pointer is
9027 now a value_print_options pointer; adjust.
9028 (_initialize_compile): Update "compile print"'s help to include
9029 supported options. Install a completer for "compile print".
9030 * cp-valprint.c (show_vtblprint, show_objectprint)
9031 (show_static_field_print): Delete.
9032 (_initialize_cp_valprint): Don't install "set print
9033 static-members", "set print vtbl", "set print object" here.
9034 * printcmd.c: Include "cli/cli-option.h" and
9035 "common/gdb_optional.h".
9036 (print_command_parse_format): Rework to fill in a
9037 value_print_options instead of a format_data.
9038 (print_value): Change parameter type from format_data pointer to
9039 value_print_options reference. Adjust.
9040 (print_command_1): Process options. Adjust to pass down a
9041 value_print_options.
9042 (print_command_completer): New.
9043 (_initialize_printcmd): Install print_command_completer as
9044 handle_brkchars completer for the "print" command. Update
9045 "print"'s help to include supported options.
9046 * valprint.c: Include "cli/cli-option.h".
9047 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9048 here from cp-valprint.c.
9049 (boolean_option_def, uinteger_option_def)
9050 (value_print_option_defs, make_value_print_options_def_group):
9051 New. Use gdb::option::add_setshow_cmds_for_options to install
9052 "set print elements", "set print null-stop", "set print repeats",
9053 "set print pretty", "set print union", "set print array", "set
9054 print address", "set print symbol", "set print array-indexes".
9055 * valprint.h: Include <string> and "cli/cli-option.h".
9056 (make_value_print_options_def_group): Declare.
9057 (print_value): Change parameter type from format_data pointer to
9058 value_print_options reference.
9059 (print_command_completer): Declare.
9060
9061 2019-06-13 Pedro Alves <palves@redhat.com>
9062
9063 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9064 (COMMON_SFILES): Add maint-test-settings.c.
9065 * cli/cli-decode.c (boolean_enums): New global, factored out from
9066 ...
9067 (add_setshow_boolean_cmd): ... here.
9068 * cli/cli-decode.h (boolean_enums): Declare.
9069 * cli/cli-option.c: New file.
9070 * cli/cli-option.h: New file.
9071 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9072 factored out from ...
9073 (parse_cli_boolean_value(const char *)): ... this.
9074 (is_unlimited_literal): Change parameter type to pointer to
9075 pointer. Adjust and advance ARG pointer.
9076 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9077 (parse_cli_var_enum): New, factored out from ...
9078 (do_set_command): ... this. Adjust.
9079 * cli/cli-setshow.h (parse_cli_boolean_value)
9080 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9081 (parse_cli_var_enum): Declare.
9082 * cli/cli-utils.c: Include "cli/cli-option.h".
9083 (get_ulongest): New.
9084 * cli/cli-utils.h (get_ulongest): Declare.
9085 (check_for_argument): New overloads.
9086 * maint-test-options.c: New file.
9087
9088 2019-06-13 Pedro Alves <palves@redhat.com>
9089
9090 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9091 parse a range if "-" is at the end of the string.
9092
9093 2019-06-13 Pedro Alves <palves@redhat.com>
9094
9095 * cli/cli-setshow.c (parse_auto_binary_operation)
9096 (parse_cli_boolean_value): Don't allow "o".
9097
9098 2019-06-13 Pedro Alves <palves@redhat.com>
9099
9100 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9101 * NEWS: Mention maint test-settings KIND.
9102 * maint-test-settings.c: New file.
9103
9104 2019-06-13 Pedro Alves <palves@redhat.com>
9105
9106 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9107 completer.
9108 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9109 "set" completers.
9110
9111 2019-06-13 Pedro Alves <palves@redhat.com>
9112
9113 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9114 after item.
9115
9116 2019-06-13 Pedro Alves <palves@redhat.com>
9117
9118 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9119
9120 2019-06-13 Pedro Alves <palves@redhat.com>
9121
9122 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9123 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9124 call.
9125 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9126 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9127 calls.
9128 (check_for_argument): Skip spaces after argument.
9129
9130 2019-06-13 Pedro Alves <palves@redhat.com>
9131
9132 * thread.c (thread_apply_command): Adjust TID parsing.
9133 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9134 detected before end of string.
9135 (tid_is_in_list): Error out if LIST is invalid.
9136
9137 2019-06-13 Pedro Alves <palves@redhat.com>
9138
9139 * completer.c (complete_line_internal_1): Rewind completion word
9140 point.
9141 (completion_tracker::advance_custom_word_point_by): Change
9142 parameter type to int.
9143 * completer.h (completion_tracker::advance_custom_word_point_by):
9144 Likewise.
9145
9146 2019-06-13 Pedro Alves <palves@redhat.com>
9147
9148 * completer.c (advance_to_completion_word): Handle delimiters.
9149
9150 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9151
9152 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9153
9154 2019-06-11 Tom Tromey <tom@tromey.com>
9155
9156 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9157 (xmalloc_failed): Move to alloc.c.
9158 * alloc.c: New file.
9159 * Makefile.in (COMMON_SFILES): Add alloc.c.
9160
9161 2019-06-11 Tom Tromey <tom@tromey.com>
9162
9163 * nat/linux-waitpid.c: Don't include server.h.
9164 (linux_debug): Remove.
9165 (my_waitpid): Update.
9166
9167 2019-06-11 Tom Tromey <tromey@adacore.com>
9168
9169 * infcall.c (_initialize_infcall): Remove trailing newline from
9170 help.
9171 * user-regs.c (_initialize_user_regs): Remove trailing newline
9172 from help.
9173 * typeprint.c (_initialize_typeprint): Remove trailing newline
9174 from help.
9175 * reverse.c (_initialize_reverse): Remove trailing newlines from
9176 help.
9177 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9178 from help.
9179 * language.c (add_set_language_command): Remove trailing newline
9180 from help.
9181 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9182 help.
9183 * disasm.c (_initialize_disasm): Remove trailing newline from
9184 help.
9185 * top.c (init_main): Remove trailing newline from help.
9186 * interps.c (_initialize_interpreter): Remove trailing newline
9187 from help.
9188 * btrace.c (_initialize_btrace): Remove trailing newlines from
9189 help.
9190 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9191 from help.
9192 * python/python.c (_initialize_python): Remove trailing newline
9193 from help.
9194 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9195 help.
9196 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9197 from help. Reformat some text.
9198 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9199 from help.
9200 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9201 newline from help.
9202
9203 2019-06-11 Tom Tromey <tromey@adacore.com>
9204
9205 * darwin-nat.c (darwin_decode_exception_message)
9206 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9207
9208 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9209
9210 * valops.c (value_slice): Check for not allocated or not
9211 associated values.
9212
9213 2019-06-10 Tom de Vries <tdevries@suse.de>
9214
9215 PR gdb/24618
9216 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9217 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9218 invalid.
9219
9220 2019-06-10 Tom de Vries <tdevries@suse.de>
9221
9222 PR gdb/24611
9223 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9224 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9225
9226 2019-06-10 Tom de Vries <tdevries@suse.de>
9227
9228 PR symtab/24545
9229 * symtab.c (struct demangled_name_entry): Add language field.
9230 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9231 static minimal symbol". Set and use language field.
9232
9233 2019-06-10 Tom Tromey <tromey@adacore.com>
9234
9235 * ada-lang.c (_initialize_ada_language): Update help text.
9236
9237 2019-06-10 Tom Tromey <tromey@adacore.com>
9238
9239 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9240 with a newline.
9241 * guile/guile.c (handle_boot_error): Don't end warning with a
9242 newline.
9243 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9244 warning with a newline.
9245 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9246 newline.
9247 (s12z_frame_cache): Likewise.
9248 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9249 a newline.
9250 * solib-svr4.c (disable_probes_interface): Don't end warning with
9251 a newline.
9252 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9253 newline.
9254 * python/python.c (do_finish_initialization): Don't end warning
9255 with a newline.
9256
9257 2019-06-10 Tom Tromey <tom@tromey.com>
9258
9259 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9260 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9261 gdbpy_enter.
9262
9263 2019-06-10 Tom Tromey <tromey@adacore.com>
9264
9265 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9266 data.
9267 (elf_new_init): Don't call stabsread_new_init.
9268 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9269 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9270 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9271
9272 2019-06-10 Tom de Vries <tdevries@suse.de>
9273
9274 PR symtab/16264
9275 PR symtab/24517
9276 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9277
9278 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9279
9280 * source.c (find_and_open_source): Also rewrite relative file
9281 names.
9282
9283 2019-04-26 Amos Bird <amosbird@gmail.com>
9284
9285 * annotate.c (annotate_thread_exited): Add "thread-exited"
9286 annotation.
9287
9288 2019-06-06 Tom Tromey <tromey@adacore.com>
9289
9290 * maint.h (class scoped_command_stats): Use
9291 DISABLE_COPY_AND_ASSIGN.
9292 <print_time>: New method.
9293 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9294 print_time.
9295 (scoped_command_stats::print_time): New method.
9296
9297 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9298
9299 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9300 instructions of lengths 6 or 8 bytes.
9301
9302 2019-06-04 Pedro Alves <palves@redhat.com>
9303
9304 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9305
9306 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9307 * breakpoint.c (condition_completer): Likewise.
9308 * cli/cli-dump.c (scan_expression): Likewise.
9309 * common/filestuff.c (mkdir_recursive): Likewise.
9310 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9311 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9312 (gdb_abspath): Likewise.
9313 * compile/compile-cplus-types.c
9314 (compile_cplus_instance::decl_name): Likewise.
9315 * completer.c (complete_explicit_location):
9316 (signal_completer, reg_or_group_completer_1): Likewise.
9317 * cp-support.c (cp_remove_params_if_any): Likewise.
9318 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9319 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9320 * infcmd.c (strip_bg_char): Likewise.
9321 * linespec.c (copy_token_string): Likewise.
9322 * mi/mi-main.c (output_cores): Likewise.
9323 * psymtab.c (psymtab_search_name):
9324 * symfile.c (test_set_ext_lang_command): Likewise.
9325 * target.c (target_fileio_read_stralloc): Likewise.
9326 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9327 * value.c (complete_internalvar): Likewise.
9328
9329 2019-06-04 Christian Biesinger <cbiesinger@google.com>
9330
9331 Add objfile property to gdb.Type.
9332 * NEWS: Mention Python API addition.
9333 * python/py-type.c (typy_get_objfile): New method.
9334
9335 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9336
9337 * NEWS: Mention the new set|show style [title|highlight].
9338 Mention changes to "show style", "help" and "apropos".
9339
9340 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9341
9342 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9343 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9344 instead of print_help_for_command.
9345 (print_doc_of_command): New function.
9346 (help_list): Add 'apropos -v word' suggestion.
9347 (print_help_for_command): Style the command name using title style.
9348 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9349 (_initialize_cli_cmds): Describe -v in apropos_command help.
9350
9351 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9352
9353 * cli/cli-style.h (cli_style_option): Add name in constructor,
9354 add m_name class member, add constructor with intensity,
9355 add name class function.
9356 (cli_style_option::add_setshow_commands): Remove name argument.
9357 (highlight_style, title_style): New styles.
9358 * cli/cli-style.c (do_show): New function that shows a style
9359 characteristic styling the style name with itself.
9360 (set_style_name): New function.
9361 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9362 Update all callers according to the changes in cli/cli-style.h.
9363 * utils.h (fputs_highlighted): New function.
9364 * utils.c (fputs_highlighted): Likewise.
9365
9366 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9367
9368 * NEWS: Mention new pipe command and new convenience variables.
9369
9370 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9371
9372 * cli/cli-cmds.c (pipe_command): New function.
9373 (_initialize_cli_cmds): Call add_com for pipe_command.
9374 Define | as an alias for pipe.
9375 (exit_status_set_internal_vars): New function.
9376 (shell_escape): Call exit_status_set_internal_vars.
9377 cli/cli-decode.c (find_command_name_length): Recognize | as
9378 a single character command.
9379
9380 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9381
9382 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9383 top.c (execute_command_to_ui_file): New function, mostly a copy
9384 of execute_command_to_string.
9385 (execute_command_to_string): Implement by calling
9386 execute_command_to_ui_file.
9387
9388 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9389
9390 * top.h (saved_command_line): Remove declaration.
9391 * top.c (previous_saved_command_line, previous_repeat_arguments):
9392 New variables.
9393 (saved_command_line): Make static, define together with other
9394 'repeat variables'.
9395 (dont_repeat): Clear repeat_arguments.
9396 (repeat_previous, get_saved_command_line, save_command_line):
9397 New functions.
9398 (gdb_init): Initialize saved_command_line
9399 and previous_saved_command_line.
9400 * main.c (captured_main_1): Remove saved_command_line initialization.
9401 * event-top.c (handle_line_of_input): Update to use
9402 the new 'repeat' related functions instead of direct access to
9403 saved_command_line.
9404 * command.h (repeat_previous, get_saved_command_line,
9405 save_command_line): New declarations.
9406 (dont_repeat): Add comment.
9407
9408 2019-05-30 Tom Tromey <tromey@adacore.com>
9409
9410 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9411 Fix comment.
9412 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9413
9414 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9415
9416 PR cli/24587
9417 * completer.c (complete): Initialize variable word.
9418
9419 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9420
9421 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9422 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9423 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9424 'body' is NULL to the outter 'if', protecting the '!is_define'
9425 situation as well.
9426
9427 2019-05-29 Tom Tromey <tromey@adacore.com>
9428
9429 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9430 (dwarf_unknown): New function.
9431 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9432 (dwarf_type_encoding_name): Use dwarf_unknown.
9433
9434 2019-05-29 Tom Tromey <tromey@adacore.com>
9435
9436 PR c++/20020:
9437 * cp-valprint.c (cp_print_value_fields): Call
9438 cp_print_static_field inside "try".
9439
9440 2019-05-29 Tom Tromey <tromey@adacore.com>
9441
9442 * inflow.c (struct terminal_info): Add default operator=.
9443 * configure: Rebuild.
9444 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9445 -Wdeprecated-copy-dtor, -Wredundant-move.
9446
9447 2019-05-29 Tom Tromey <tromey@adacore.com>
9448
9449 * NEWS: Add entry.
9450 * infcmd.c (print_return_value_1): Handle finish_print
9451 option.
9452 (show_print_finish): New function.
9453 (_initialize_infcmd): Add "set/show print finish" commands.
9454 * valprint.c (user_print_options): Initialize new member.
9455 * valprint.h (struct value_print_options) <finish_print>: New
9456 member.
9457
9458 2019-05-28 Tom Tromey <tromey@adacore.com>
9459
9460 * ada-lang.c (ada_remove_Xbn_suffix)
9461 (find_old_style_renaming_symbol)
9462 (parse_old_style_renaming): Remove.
9463 (ada_find_renaming_symbol): Don't call
9464 find_old_style_renaming_symbol.
9465 (ada_is_renaming_symbol): Rename from
9466 ada_find_renaming_symbol. Remove "block" parameter. Return
9467 bool. Now static.
9468 (ada_read_var_value): Update and simplify.
9469 * ada-exp.y (write_var_or_type): Remove old code.
9470
9471 2019-05-28 Alan Hayward <alan.hayward@arm.com>
9472
9473 PR gdb/25010
9474 * event-top.c: Remove include comment.
9475 * inflow.c (class scoped_ignore_sigttou): Move from here...
9476 * inflow.h (class scoped_ignore_sigttou): ...to here.
9477 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9478 * top.c: Remove include comment.
9479
9480 2019-05-27 Tom Tromey <tom@tromey.com>
9481
9482 * NEWS: Fix typo.
9483
9484 2019-05-22 Tom Tromey <tromey@adacore.com>
9485
9486 * target.c (target_follow_exec): Constify parameter.
9487 * target-delegates.c: Rebuild.
9488 * remote.c (remote_target::follow_exec): Constify parameter.
9489 * infrun.c (follow_exec): Constify parameter.
9490 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9491 (target_follow_exec): Likewise.
9492
9493 2019-05-22 Alan Hayward <alan.hayward@arm.com>
9494
9495 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9496 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9497
9498 2019-05-22 Alan Hayward <alan.hayward@arm.com>
9499
9500 * NEWS: Add debugredirect and testsuite sections.
9501
9502 2019-05-22 Simon Cook <simon.cook@embecosm.com>
9503
9504 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9505 target descriptions using exclusively floating point register name
9506 aliases.
9507
9508 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9509
9510 PR gdb/18644:
9511 * f-lang.c (build_fortran_types): Handle the case where
9512 gdbarch_floatformat_for_type returns a nullptr.
9513
9514 2019-05-21 Tom de Vries <tdevries@suse.de>
9515
9516 PR cli/24587
9517 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9518
9519 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9520
9521 PR gdb/18644:
9522 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9523 16-byte floats.
9524 * i386-tdep.c (i386_floatformat_for_type): Use
9525 floatformats_ia64_quad for the 16-byte floating point component
9526 within a fortran 32-byte complex number.
9527
9528 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9529
9530 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9531 delete default constructor.
9532 (find_partial_die): Update to return const struct.
9533 (partial_die_parent_scope): Move variable declaration into scope
9534 of its use and change its type to auto.
9535 (guess_partial_die_structure_name): Likewise.
9536 (partial_die_info::fixup): Likewise.
9537
9538 2019-05-17 Tom Tromey <tromey@adacore.com>
9539
9540 * source.c (find_and_open_source): Remove cast.
9541
9542 2019-05-17 Tom Tromey <tromey@adacore.com>
9543
9544 * annotate.c (annotate_source): Make "filename" const.
9545 * annotate.h (annotate_source): Use const.
9546
9547 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9548
9549 * disasm.c (set_disassembler_options): Send errors to stderr.
9550
9551 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9552
9553 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9554 (cli_interp_base::set_logging): Check debug_redirect.
9555 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9556 * cli/cli-logging.c (debug_redirect): Add static variable.
9557 (pop_output_files): Add default param.
9558 (handle_redirections): Print debug setting.
9559 (show_logging_command): Likewise.
9560 (_initialize_cli_logging): Add debugredirect command.
9561 * interps.c (current_interp_set_logging): Add debug_redirect
9562 parameter.
9563 * interps.h (set_logging): Add debug_redirect parameter.
9564 (current_interp_set_logging): Likewise.
9565 * mi/mi-common.h: Likewise.
9566 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9567
9568 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9569 Tom Tromey <tromey@adacore.com>
9570
9571 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9572 directly.
9573 * cli/cli-interp.h (make_logging_output): Remove declaration.
9574 * cli/cli-logging.c (make_logging_output): Remove function.
9575 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9576 directly.
9577 * ui-file.c (tee_file::tee_file): Remove bools.
9578 (tee_file::~tee_file): Remove deletes.
9579 * ui-file.h (tee_file): Remove bools.
9580
9581 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
9582
9583 * mi/mi-cmds.h (mi_cmd_complete): New function.
9584 * mi/mi-main.c (mi_cmd_complete): Likewise.
9585 * mi/mi-cmds.c: Define new MI command -complete.
9586 * NEWS: Mention new -complete command.
9587
9588 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
9589
9590 * completer.h (complete): New function.
9591 * completer.c (complete): Likewise.
9592 * cli/cli-cmds.c: (complete_command): Update to use new complete()
9593 function defined in completer.h.
9594
9595 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
9596
9597 * MAINTAINERS (Write After Approval): Add myself.
9598
9599 2019-05-17 Tom de Vries <tdevries@suse.de>
9600
9601 PR gdb/24094
9602 * dwarf2read.c (struct cu_partial_die_info): New struct.
9603 (find_partial_die): Return cu_partial_die_info.
9604 (partial_die_parent_scope, guess_partial_die_structure_name)
9605 (partial_die_info::fixup): Handle new return type of find_partial_die.
9606
9607 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9608
9609 PR breakpoints/24541
9610 * stap-probe.c (stap_parse_register_operand): Make "regname" an
9611 "std::string", simplifying the algorithm.
9612
9613 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9614
9615 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9616 (stap_static_probe_ops::get_probes): Likewise.
9617
9618 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9619
9620 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9621 '-')" and "else if".
9622 (stap_parse_single_operand): Join checks for
9623 "gdbarch_stap_parse_special_token_p" and
9624 "gdbarch_stap_parse_special_token" in the same "if" statement.
9625 Invert check when verifying for operation on register
9626 displacement.
9627
9628 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9629
9630 * stap-probe.c (stap_get_opcode): Update comment.
9631 (stap_get_expected_argument_type): Likewise.
9632 (handle_stap_probe): Likewise.
9633
9634 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9635
9636 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9637 return type to 'bool'. Adjust comment. Use 'bool' when
9638 appropriate.
9639 (i386_stap_parse_special_token_three_arg_disp): Likewise.
9640 * stap-probe.c (stap_parse_argument_1): Likewise.
9641 (stap_is_operator): Likewise.
9642 (stap_is_generic_prefix): Likewise.
9643 (stap_is_register_prefix): Likewise.
9644 (stap_is_register_indirection_prefix): Likewise.
9645 (stap_is_integer_prefix): Likewise.
9646 (stap_generic_check_suffix): Likewise.
9647 (stap_check_integer_suffix): Likewise.
9648 (stap_check_register_suffix): Likewise.
9649 (stap_check_register_indirection_suffix): Likewise.
9650 (stap_parse_register_operand): Likewise.
9651 (stap_parse_single_operand): Likewise.
9652 (stap_parse_argument_1): Likewise.
9653 (stap_probe::get_argument_count): Likewise.
9654 (stap_is_operator): Likewise.
9655
9656 2019-05-16 Tom Tromey <tromey@adacore.com>
9657
9658 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9659 keyword to foreach.
9660
9661 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
9662
9663 * linux-thread-db.c (try_thread_db_load_1): Change return type
9664 to bool.
9665 (try_thread_db_load): Likewise.
9666 (try_thread_db_load_from_pdir_1): Likewise.
9667 (try_thread_db_load_from_pdir): Likewise.
9668 (try_thread_db_load_from_sdir): Likewise.
9669 (try_thread_db_load_from_dir): Likewise.
9670 (thread_db_load_search): Likewise.
9671 (has_libpthread): Likewise.
9672 (thread_db_load): Likewise.
9673
9674 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
9675
9676 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9677 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9678 NULL, and complain/return if that's the case.
9679
9680 2019-05-15 John Darrington <john@darrington.wattle.id.au>
9681
9682 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9683 (advance, posn, abstract_read_memory): New functions.
9684 [struct mem_read_abstraction]: New struct.
9685 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9686
9687 2019-05-14 Tom Tromey <tromey@adacore.com>
9688
9689 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9690 value is not lval_memory.
9691
9692 2019-05-14 Tom Tromey <tromey@adacore.com>
9693
9694 * solib.c (info_sharedlibrary_command): Style the file name.
9695
9696 2019-05-14 Alan Hayward <alan.hayward@arm.com>
9697
9698 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9699 (aarch64_vnv_type): Likewise.
9700 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9701 * common/tdesc.c: Likewise.
9702 * common/tdesc.h (enum tdesc_type_kind): Likewise.
9703 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9704 * features/aarch64-fpu.xml: Add ieee half view.
9705 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9706 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9707 * gdbtypes.h (struct builtin_type): Likewise.
9708 (struct objfile_type): Likewise.
9709
9710 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
9711
9712 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9713 typo.
9714 * location.h (string_to_event_location): Likewise.
9715
9716 2019-05-11 Joel Brobecker <brobecker@adacore.com>
9717
9718 GDB 8.3 released.
9719
9720 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
9721
9722 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9723 New variable declaration.
9724 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9725 New variable.
9726 (print_one_breakpoint): Use ui_out::test_flags and new global
9727 variable to compute use_fixed_output.
9728 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9729 Remove.
9730 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9731 (mi_multi_location_breakpoint_output_fixed): Remove.
9732 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9733 new variable.
9734 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9735 fix_multi_location_breakpoint_output flag if version >= 3.
9736 * ui-out.h (enum ui_out_flag)
9737 <fix_multi_location_breakpoint_output>: New enumerator.
9738
9739 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
9740
9741 * contrib/cc-with-tweaks.sh: Validate dwz's work.
9742
9743 2019-05-10 Tom Tromey <tromey@adacore.com>
9744
9745 * ada-lang.c (catch_ada_completer): New function.
9746 (_initialize_ada_language): Use it.
9747
9748 2019-05-10 Tom Tromey <tromey@adacore.com>
9749
9750 * thread.c (print_thread_info): Make "requested_threads" const.
9751 * gdbthread.h (print_thread_info): Make "requested_threads"
9752 const.
9753 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9754 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9755
9756 2019-05-08 Tom Tromey <tom@tromey.com>
9757
9758 * gdbtypes.c (objfile_type_data): Change type.
9759 (objfile_type, _initialize_gdbtypes): Update.
9760
9761 2019-05-08 Tom Tromey <tom@tromey.com>
9762
9763 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9764 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9765 (_initialize_dwarf2_frame): Update.
9766
9767 2019-05-08 Tom Tromey <tom@tromey.com>
9768
9769 * objc-lang.c (objc_objfile_data): Change type.
9770 (find_methods): Update.
9771 (_initialize_objc_lang): Remove.
9772
9773 2019-05-08 Tom Tromey <tom@tromey.com>
9774
9775 * stabsread.c (rs6000_builtin_type_data): Change type.
9776 (rs6000_builtin_type, _initialize_stabsread): Update.
9777
9778 2019-05-08 Tom Tromey <tom@tromey.com>
9779
9780 * mips-tdep.c (mips_pdr_data): Remove.
9781 (_initialize_mips_tdep): Update.
9782
9783 2019-05-08 Tom Tromey <tom@tromey.com>
9784
9785 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9786 (hppa_init_objfile_priv_data, read_unwind_info)
9787 (find_unwind_entry, _initialize_hppa_tdep): Update.
9788
9789 2019-05-08 Tom Tromey <tom@tromey.com>
9790
9791 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9792 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
9793 on obstack.
9794 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9795
9796 2019-05-08 Tom Tromey <tom@tromey.com>
9797
9798 * mdebugread.c (basic_type_data): Change type.
9799 (basic_type, _initialize_mdebugread): Update.
9800
9801 2019-05-08 Tom Tromey <tom@tromey.com>
9802
9803 * common/gdb_unique_ptr.h (struct noop_deleter): New.
9804
9805 2019-05-08 Tom Tromey <tom@tromey.com>
9806
9807 * nto-tdep.c (nto_inferior_data_reg): Change type.
9808 (nto_inferior_data): Update.
9809 (nto_inferior_data_cleanup, nto_new_inferior_data)
9810 (_initialize_nto_tdep): Remove.
9811 * nto-tdep.h (struct nto_inferior_data): Add initializers.
9812
9813 2019-05-08 Tom Tromey <tom@tromey.com>
9814
9815 * ada-lang.c (struct ada_inferior_data): Add initializers.
9816 (ada_inferior_data): Change type.
9817 (ada_inferior_data_cleanup): Remove.
9818 (get_ada_inferior_data, ada_inferior_exit)
9819 (struct ada_pspace_data): Add initializers, destructor.
9820 (ada_pspace_data_handle): Change type.
9821 (get_ada_pspace_data): Update.
9822 (ada_pspace_data_cleanup): Remove.
9823
9824 2019-05-08 Tom Tromey <tom@tromey.com>
9825
9826 * coffread.c (struct coff_symfile_info): Add initializers.
9827 (coff_objfile_data_key): Move lower. Change type.
9828 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9829 Update.
9830 (coff_free_info): Remove.
9831
9832 2019-05-08 Tom Tromey <tom@tromey.com>
9833
9834 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9835 (fbsd_pspace_data_handle): Move lower. Change type.
9836 (get_fbsd_pspace_data): Update.
9837 (fbsd_pspace_data_cleanup): Remove.
9838 (_initialize_fbsd_tdep): Update.
9839
9840 2019-05-08 Tom Tromey <tom@tromey.com>
9841
9842 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9843 (get_ada_tasks_pspace_data): Update.
9844 (ada_tasks_pspace_data_cleanup): Remove.
9845 (_initialize_tasks): Update.
9846 (ada_tasks_inferior_data_handle): Change type.
9847 (get_ada_tasks_inferior_data): Update.
9848 (ada_tasks_inferior_data_cleanup): Remove.
9849 (struct ada_tasks_pspace_data): Add initializers.
9850
9851 2019-05-08 Tom Tromey <tom@tromey.com>
9852
9853 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9854 * symfile-debug.c (debug_sym_get_probes): Change type.
9855 * stap-probe.c (handle_stap_probe):
9856 (stap_static_probe_ops::get_probes): Change type.
9857 * probe.h (class static_probe_ops) <get_probes>: Change type.
9858 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9859 (parse_probes_in_pspace): Update.
9860 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9861 Update.
9862 (any_static_probe_ops::get_probes): Change type.
9863 * elfread.c (elfread_data): New typedef.
9864 (probe_key): Change type.
9865 (elf_get_probes): Likewise. Update.
9866 (probe_key_free): Remove.
9867 (_initialize_elfread): Update.
9868 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9869 Change type.
9870 (dtrace_process_dof_probe, dtrace_process_dof)
9871 (dtrace_static_probe_ops::get_probe): Change type.
9872
9873 2019-05-08 Tom Tromey <tom@tromey.com>
9874
9875 * xcoffread.c (struct xcoff_symfile_info): Rename from
9876 coff_symfile_info. Add initializers.
9877 (xcoff_objfile_data_key): Move lower. Change type.
9878 (XCOFF_DATA): Rewrite.
9879 (xcoff_free_info): Remove.
9880 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9881 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9882 (xcoff_initial_scan): Update.
9883
9884 2019-05-08 Tom Tromey <tom@tromey.com>
9885
9886 * solib-svr4.c (struct svr4_info): Add initializers and
9887 destructor.
9888 <probes_table>: Now an htab_up.
9889 (solib_svr4_pspace_data): Change type.
9890 (free_probes_table): Simplify.
9891 (~svr4_info): Rename from svr4_pspace_data_cleanup.
9892 (get_svr4_info, probes_table_htab_remove_objfile_probes)
9893 (probes_table_remove_objfile_probes, register_solib_event_probe)
9894 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9895 (_initialize_svr4_solib): Update.
9896
9897 2019-05-08 Tom Tromey <tom@tromey.com>
9898
9899 * remote.c (remote_pspace_data): Change type.
9900 (remote_pspace_data_cleanup): Remove.
9901 (get_remote_exec_file, set_pspace_remote_exec_file)
9902 (_initialize_remote): Update.
9903
9904 2019-05-08 Tom Tromey <tom@tromey.com>
9905
9906 * breakpoint.c (breakpoint_objfile_key): Change type.
9907 (get_breakpoint_objfile_data): Update.
9908 (free_breakpoint_objfile_data): Remove.
9909 (_initialize_breakpoint): Update.
9910
9911 2019-05-08 Tom Tromey <tom@tromey.com>
9912
9913 * linux-tdep.c (struct linux_info): Add initializers.
9914 (linux_inferior_data): Move. Change type.
9915 (invalidate_linux_cache_inf): Update.
9916 (linux_inferior_data_cleanup): Remove.
9917 (get_linux_inferior_data, _initialize_linux_tdep): Update.
9918
9919 2019-05-08 Tom Tromey <tom@tromey.com>
9920
9921 * auxv.c (auxv_inferior_data): Move. Change type.
9922 (auxv_inferior_data_cleanup): Remove.
9923 (invalidate_auxv_cache_inf): Rewrite.
9924 (get_auxv_inferior_data, _initialize_auxv): Update.
9925
9926 2019-05-08 Tom Tromey <tom@tromey.com>
9927
9928 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
9929 (symfile_debug_objfile_data_key): Change type.
9930 (symfile_debug_installed, debug_qf_has_symbols)
9931 (debug_qf_find_last_source_symtab)
9932 (debug_qf_forget_cached_source_info)
9933 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
9934 (debug_qf_print_stats, debug_qf_dump)
9935 (debug_qf_expand_symtabs_for_function)
9936 (debug_qf_expand_all_symtabs)
9937 (debug_qf_expand_symtabs_with_fullname)
9938 (debug_qf_map_matching_symbols)
9939 (debug_qf_expand_symtabs_matching)
9940 (debug_qf_find_pc_sect_compunit_symtab)
9941 (debug_qf_map_symbol_filenames)
9942 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
9943 (debug_sym_new_init, debug_sym_init, debug_sym_read)
9944 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
9945 (debug_sym_read_linetable, debug_sym_relocate): Update.
9946 (symfile_debug_free_objfile): Remove.
9947 (install_symfile_debug_logging, _initialize_symfile_debug):
9948 Update.
9949
9950 2019-05-08 Tom Tromey <tom@tromey.com>
9951
9952 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
9953 allocate_on_obstack.
9954 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
9955 (get_dwarf2_per_objfile): Update.
9956 (set_dwarf2_per_objfile): Remove.
9957 (dwarf2_has_info, dwarf2_get_section_info): Update.
9958 (dwarf2_free_objfile): Remove.
9959 (_initialize_dwarf2_read): Update.
9960
9961 2019-05-08 Tom Tromey <tom@tromey.com>
9962
9963 * auto-load.c (struct auto_load_pspace_info): Add destructor and
9964 initializers.
9965 <unsupported_script_warning_printed,
9966 script_not_found_warning_printed>: Now bool.
9967 (auto_load_pspace_data): Change type.
9968 (~auto_load_pspace_info): Rename from
9969 auto_load_pspace_data_cleanup.
9970 (get_auto_load_pspace_data, init_loaded_scripts_info)
9971 (clear_section_scripts, maybe_print_unsupported_script_warning)
9972 (maybe_print_script_not_found_warning, _initialize_auto_load):
9973 Update.
9974
9975 2019-05-08 Tom Tromey <tom@tromey.com>
9976
9977 * objfiles.c (objfile_pspace_info): Add destructor and
9978 initializers.
9979 (objfiles_pspace_data): Change type.
9980 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
9981 (get_objfile_pspace_data): Update.
9982 (objfiles_bfd_data): Change type.
9983 (get_objfile_bfd_data): Update.
9984 (objfile_bfd_data_free, _initialize_objfiles): Remove.
9985
9986 2019-05-08 Tom Tromey <tom@tromey.com>
9987
9988 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
9989 Change type.
9990 (get_catch_syscall_inferior_data): Update.
9991 (catch_syscall_inferior_data_cleanup): Remove.
9992 (_initialize_break_catch_syscall): Update.
9993
9994 2019-05-08 Tom Tromey <tom@tromey.com>
9995
9996 * inflow.c (struct terminal_info): Add destructor and
9997 initializers.
9998 (inflow_inferior_data): Change type.
9999 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10000 (get_inflow_inferior_data, inflow_inferior_exit)
10001 (swap_terminal_info, _initialize_inflow): Update.
10002
10003 2019-05-08 Tom Tromey <tom@tromey.com>
10004
10005 * target-dcache.c (target_dcache_cleanup): Remove.
10006 (target_dcache_aspace_key): Change type.
10007 (target_dcache_init_p, target_dcache_invalidate)
10008 (target_dcache_get, target_dcache_get_or_init)
10009 (_initialize_target_dcache): Update.
10010 * dcache.h (struct dcache_deleter): New.
10011
10012 2019-05-08 Tom Tromey <tom@tromey.com>
10013
10014 * symtab.c (struct symbol_cache): Add destructor and
10015 initializers.
10016 (symbol_cache_key): Move. Change type.
10017 (make_symbol_cache, free_symbol_cache): Remove.
10018 (get_symbol_cache): Update.
10019 (symbol_cache_cleanup): Remove.
10020 (ALL_PSPACES, symbol_cache_flush)
10021 (maintenance_print_symbol_cache)
10022 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10023 Update.
10024
10025 2019-05-08 Tom Tromey <tom@tromey.com>
10026
10027 * symtab.c (struct main_info): Add destructor and initializers.
10028 (main_progspace_key): Move. Change type.
10029 (get_main_info): Update.
10030 (main_info_cleanup): Remove.
10031 (_initialize_symtab): Update.
10032
10033 2019-05-08 Tom Tromey <tom@tromey.com>
10034
10035 * registry.h (DECLARE_REGISTRY): Define the _key class.
10036
10037 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10038
10039 * NEWS: Merge two 'New commands' sections.
10040
10041 2019-05-08 Joel Brobecker <brobecker@adacore.com>
10042
10043 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10044 parameter and use Ada language definition instead.
10045 (ada_val_print_ptr): Remove unused language parameter.
10046 (ada_val_print_num): Remove language parameter and use Ada language
10047 definition instead.
10048 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10049 parameter.
10050 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10051 parameter and use Ada language definition instead.
10052 (ada_val_print_1): Update all ada_val_print_xxx calls.
10053 Remove language parameter.
10054 (ada_val_print): Update ada_val_print_1 call.
10055
10056 2019-05-08 Tom Tromey <tromey@adacore.com>
10057
10058 * remote.c (remote_hw_watchpoint_limit)
10059 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10060 Now static.
10061
10062 2019-05-08 Tom Tromey <tromey@adacore.com>
10063
10064 * maint.c (_initialize_maint_cmds): Move initialization code to
10065 remote.c.
10066 (watchdog, show_watchdog): Move to remote.c.
10067 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10068 "watchdog" static.
10069 (_initialize_remote): Move initialization code from maint.c.
10070 * defs.h (watchdog): Don't declare.
10071
10072 2019-05-08 Tom Tromey <tromey@adacore.com>
10073
10074 * tui/tui-interp.c: Include main.h.
10075 * interps.c: Include main.h.
10076 * main.h (interpreter_p): Declare.
10077 * defs.h (interpreter_p): Don't declare.
10078
10079 2019-05-08 Tom Tromey <tromey@adacore.com>
10080
10081 * dwarf2loc.c: Include dwarf2read.h.
10082 * defs.h (read_unsigned_leb128): Don't declare.
10083 * dwarf2read.h (read_unsigned_leb128): Declare.
10084
10085 2019-05-08 Tom Tromey <tromey@adacore.com>
10086
10087 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10088 method.
10089
10090 2019-05-08 Tom Tromey <tromey@adacore.com>
10091
10092 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10093 when no wrap column is set.
10094
10095 2019-05-08 Tom Tromey <tromey@adacore.com>
10096
10097 * c-lang.c (c_get_string): Handle non-C-style arrays.
10098
10099 2019-05-08 Tom Tromey <tromey@adacore.com>
10100
10101 * typeprint.c (print_offset_data::update): Print the bit offset,
10102 not the number of bits remaining.
10103
10104 2019-05-08 Tom Tromey <tromey@adacore.com>
10105
10106 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10107 padding at end of comment.
10108
10109 2019-05-08 Tom Tromey <tromey@adacore.com>
10110
10111 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10112 Compare main types.
10113
10114 2019-05-06 Tom Tromey <tom@tromey.com>
10115
10116 * common/scoped_mmap.c: Include common-defs.h.
10117 * common/scoped_mmap.h: Don't include config.h.
10118
10119 2019-05-04 Tom Tromey <tom@tromey.com>
10120
10121 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10122 (struct aarch64_call_info): Add initializers.
10123 <si>: Now a std::vector.
10124 (pass_on_stack, aarch64_push_dummy_call): Update.
10125
10126 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
10127 Tom Tromey <tom@tromey.com>
10128
10129 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10130 (ppc_threads): Now a std::vector. Now static.
10131 (hwdebug_find_thread_points_by_tid)
10132 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10133 Update.
10134
10135 2019-05-04 Tom Tromey <tom@tromey.com>
10136
10137 * arc-tdep.c (arc_tdesc_init): Return bool.
10138
10139 2019-05-04 Tom Tromey <tom@tromey.com>
10140
10141 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10142 Use gdb_assert_not_reached.
10143
10144 2019-05-04 Tom Tromey <tom@tromey.com>
10145
10146 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10147 "false".
10148
10149 2019-05-04 Tom Tromey <tom@tromey.com>
10150
10151 * arc-tdep.c (arc_tdesc_init): Use bool.
10152
10153 2019-05-04 Tom Tromey <tom@tromey.com>
10154
10155 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10156
10157 2019-05-04 Tom Tromey <tom@tromey.com>
10158
10159 * cli/cli-cmds.c (valid_command_p): Return bool.
10160
10161 2019-05-04 Tom Tromey <tom@tromey.com>
10162
10163 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10164 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10165
10166 2019-05-04 Raul Tambre <raul@tambre.ee>
10167
10168 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10169 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10170 operator for comparison.
10171
10172 2019-05-04 Tom Tromey <tom@tromey.com>
10173
10174 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10175 (lookup_partial_symbol, print_partial_symbols)
10176 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10177 (psymbol_compare): Update.
10178 (add_psymbol_to_bcache): Clear the entire psymbol.
10179 (maintenance_check_psymtabs): Update.
10180 * psympriv.h (struct partial_symbol): Don't derive from
10181 general_symbol_info.
10182 <obj_section, unrelocated_address, address,
10183 set_unrelocated_address>: Update.
10184 <ginfo>: New member.
10185 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10186 (debug_names::write_psymbols): Update.
10187
10188 2019-05-04 Tom de Vries <tdevries@suse.de>
10189
10190 * contrib/cc-with-tweaks.sh: Support -n arg.
10191
10192 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10193
10194 * corelow.c (core_target::detach): Ensure frame cache and
10195 register caches are cleared.
10196 inferior.c (exit_inferior_1): Likewise.
10197
10198 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10199 Tom Tromey <tom@tromey.com>
10200
10201 * dictionary.c (collate_pending_symbols_by_language): Remove
10202 "struct" from foreach.
10203 * symtab.c (lookup_global_symbol_from_objfile)
10204 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10205 foreach.
10206 * ser-tcp.c (net_open): Remove "struct" from foreach.
10207 * objfiles.c (objfile_relocate, objfile_rebase)
10208 (objfile_has_symbols): Remove "struct" from foreach.
10209 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10210 from foreach.
10211 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10212 foreach.
10213 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10214 "struct" from foreach.
10215 * ada-lang.c (create_excep_cond_exprs)
10216 (ada_exception_catchpoint_cond_string): Remove "struct" from
10217 foreach.
10218
10219 2019-05-03 Tom Tromey <tromey@adacore.com>
10220
10221 * ada-exp.y (convert_char_literal): Check suffix of each
10222 enumerator.
10223
10224 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10225
10226 PR ada/21406:
10227 * ada-exp.y (yywrap): Don't define.
10228 * ada-lex.l (%option): Add noyywrap
10229 (yywrap): Remove.
10230
10231 2019-05-03 Eli Zaretskii <eliz@gnu.org>
10232
10233 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10234 _WIN32_WINNT to the XP level, unless already defined to a higher
10235 level.
10236
10237 * unittests/parse-connection-spec-selftests.c:
10238 * ser-tcp.c:
10239 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10240 override.
10241
10242 * symfile.c (find_separate_debug_file): Remove colon from the
10243 drive spec of DOS/Windows file names of the target, so that the
10244 file name produced from DEBUGDIR and the target's directory will
10245 be valid on DOS/Windows systems.
10246
10247 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10248
10249 * rust-lang.c (val_print_struct): Handle printing structures
10250 containing strings.
10251
10252 2019-05-02 Tom Tromey <tromey@adacore.com>
10253
10254 * valarith.c (_initialize_valarith): Remove.
10255
10256 2019-05-01 Tom Tromey <tromey@adacore.com>
10257
10258 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10259 bitfields.
10260
10261 2019-05-01 Tom Tromey <tromey@adacore.com>
10262
10263 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10264 for big-endian copies.
10265
10266 2019-04-30 Ali Tamur <tamur@google.com>
10267 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10268 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10269 (read_3_bytes): New function.
10270
10271 2019-04-30 Joel Brobecker <brobecker@adacore.com>
10272
10273 * windows-nat.c (main_thread_id): Delete.
10274 (handle_output_debug_string): Replace main_thread_id by
10275 current_event.dwThreadId.
10276 (fake_create_process): Likewise.
10277 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10278 Do not set main_thread_id.
10279 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10280 current_event.dwThreadId.
10281 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10282
10283 2019-04-30 Joel Brobecker <brobecker@adacore.com>
10284
10285 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10286 Use current_event.dwThreadId instead of main_thread_id.
10287
10288 2019-04-30 Tom Tromey <tromey@adacore.com>
10289
10290 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10291 (create_excep_cond_exprs): Iterate over program spaces.
10292 (ada_exception_catchpoint_cond_string): Examine all minimal
10293 symbols for exception types.
10294
10295 2019-04-30 Tom Tromey <tromey@adacore.com>
10296
10297 PR c++/24470:
10298 * dwarf2read.c (process_structure_scope): Handle case where type
10299 has template parameters but no symbol was created.
10300
10301 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10302 Chris January <chris.january@arm.com>
10303
10304 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10305 qualifier.
10306 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10307
10308 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10309
10310 * f-typeprint.c (f_print_type): Update rules for printing
10311 whitespace.
10312 (f_type_print_varspec_suffix): Likewise.
10313
10314 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10315 Chris January <chris.january@arm.com>
10316
10317 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10318 function arguments.
10319
10320 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10321
10322 * f-lang.c (build_fortran_types): Change name of void type to
10323 lower case.
10324 * f-typeprint.c (f_type_print_base): Print the name of the void
10325 type, rather than a fixed string.
10326 * f-valprint.c (f_decorations): Use lower case void string.
10327
10328 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10329 Chris January <chris.january@arm.com>
10330
10331 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10332 types for Fortran.
10333
10334 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10335 Chris January <chris.january@arm.com>
10336 David Lecomber <david.lecomber@arm.com>
10337
10338 * f-exp.y (BINOP_INTRINSIC): New token.
10339 (exp): New parser rule handling BINOP_INTRINSIC.
10340 (f77_keywords): Add new builtin procedures.
10341 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10342 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10343 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10344 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10345 (print_unop_subexp_f): New function.
10346 (print_binop_subexp_f): New function.
10347 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10348 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10349 (dump_subexp_body_f): Likewise.
10350 (operator_check_f): Likewise.
10351 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10352 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10353
10354 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10355
10356 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10357 UNOP_KIND.
10358 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10359 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10360 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10361 (operator_length_f): New fuction.
10362 (print_subexp_f): New function.
10363 (op_name_f): New function.
10364 (dump_subexp_body_f): New function.
10365 (operator_check_f): New function.
10366 (exp_descriptor_f): Replace standard expression handling functions
10367 with new functions.
10368 * gdb/fortran-operator.def: New file.
10369 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10370 * gdb/std-operator.def: Remove UNOP_KIND.
10371
10372 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10373
10374 * std-operator.def: Remove unbalanced, stray double quote
10375 character.
10376
10377 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10378 Chris January <chris.january@arm.com>
10379 Daniel Everett <daniel.everett@arm.com>
10380 Nick Forrington <nick.forrington@arm.com>
10381 Richard Bunt <richard.bunt@arm.com>
10382
10383 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10384 of depth when printing anonymous structs or unions.
10385 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10386 Don't print either the top-level value, or the children if the
10387 max-depth is exceeded.
10388 (ppscm_print_children): When printing the key of a map, allow one
10389 extra level of depth.
10390 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10391 print either the top-level value, or the children if the max-depth
10392 is exceeded.
10393 (print_children): When printing the key of a map, allow one extra
10394 level of depth.
10395 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10396 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10397 (user_print_options): Initialise max_depth field.
10398 (val_print_scalar_or_string_type_p): New function.
10399 (val_print): Check to see if the max depth has been reached.
10400 (val_print_check_max_depth): Define new function.
10401 (show_print_max_depth): New function.
10402 (_initialize_valprint): Add 'print max-depth' option.
10403 * valprint.h (struct value_print_options) <max_depth>: New field.
10404 (val_print_check_max_depth): Declare new function.
10405 * NEWS: Document new feature.
10406
10407 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10408
10409 * ada-lang.c (ada_language_defn): Initialise new field.
10410 * c-lang.c (c_is_string_type_p): New function.
10411 (c_language_defn): Initialise new field.
10412 (cplus_language_defn): Initialise new field.
10413 (asm_language_defn): Initialise new field.
10414 (minimal_language_defn): Initialise new field.
10415 * c-lang.h (c_is_string_type_p): Declare new function.
10416 * d-lang.c (d_language_defn): Initialise new field.
10417 * f-lang.c (f_is_string_type_p): New function.
10418 (f_language_defn): Initialise new field.
10419 * go-lang.c (go_is_string_type_p): New function.
10420 (go_language_defn): Initialise new field.
10421 * language.c (default_is_string_type_p): New function.
10422 (unknown_language_defn): Initialise new field.
10423 (auto_language_defn): Initialise new field.
10424 * language.h (struct language_defn) <la_is_string_type_p>: New
10425 member variable.
10426 (default_is_string_type_p): Declare new function.
10427 * m2-lang.c (m2_language_defn): Initialise new field.
10428 * objc-lang.c (objc_language_defn): Initialise new field.
10429 * opencl-lang.c (opencl_language_defn): Initialise new field.
10430 * p-lang.c (pascal_is_string_type_p): New function.
10431 (pascal_language_defn): Initialise new field.
10432 * rust-lang.c (rust_is_string_type_p): New function.
10433 (rust_language_defn): Initialise new field.
10434
10435 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10436
10437 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10438 New field.
10439 * ada-lang.c (ada_language_defn): Initialise new field.
10440 * c-lang.c (c_language_defn): Likewise.
10441 (cplus_language_defn): Likewise.
10442 (asm_language_defn): Likewise.
10443 (minimal_language_defn): Likewise.
10444 * d-lang.c (d_language_defn): Likewise.
10445 * f-lang.c (f_language_defn): Likewise.
10446 * go-lang.c (go_language_defn): Likewise.
10447 * language.c (unknown_language_defn): Likewise.
10448 (auto_language_defn): Likewise.
10449 * m2-lang.c (m2_language_defn): Likewise.
10450 * objc-lang.c (objc_language_defn): Likewise.
10451 * opencl-lang.c (opencl_language_defn): Likewise.
10452 * p-lang.c (pascal_language_defn): Likewise.
10453 * rust-lang.c (rust_language_defn): Likewise.
10454
10455 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10456
10457 * ada-lang.c (ada_is_character_type): Change return type to bool.
10458 (ada_is_string_type): Likewise.
10459 * ada-lang.h (ada_is_character_type): Update declaration
10460 (ada_is_string_type): Likewise.
10461
10462 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10463
10464 Support style in 'frame|thread apply'
10465
10466 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10467 * record.c (record_start, record_stop): Update callers of
10468 execute_command_to_string with false.
10469 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10470 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10471 methods.
10472 (class string_file): New constructor with term_out parameter.
10473 Override methods term_out and can_emit_style_escape. New member
10474 term_out.
10475 (class stdio_file): Override can_emit_style_escape.
10476 (class tee_file): Override term_out and can_emit_style_escape.
10477 * utils.h (can_emit_style_escape): Remove.
10478 * utils.c (can_emit_style_escape): Likewise.
10479 Update all callers of can_emit_style_escape (SOMESTREAM) to
10480 SOMESTREAM->can_emit_style_escape.
10481 * source-cache.c (source_cache::get_source_lines): Likewise.
10482 * stack.c (frame_apply_command_count): Call execute_command_to_string
10483 passing the term_out characteristic of the current gdb_stdout.
10484 * thread.c (thr_try_catch_cmd): Likewise.
10485 * top.c (execute_command_to_string): pass term_out parameter
10486 to construct the string_file for the command output.
10487 * ui-file.c (term_cli_styling): New function (most code moved
10488 from utils.c can_emit_style_escape).
10489 (string_file::string_file, string_file::can_emit_style_escape,
10490 stdio_file::can_emit_style_escape, tee_file::term_out,
10491 tee_file::can_emit_style_escape): New functions.
10492
10493 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10494
10495 * NEWS: Mention the new set|show may-call-functions.
10496 * infcall.c (may_call_functions_p): New variable.
10497 (show_may_call_functions_p): New function.
10498 (call_function_by_hand_dummy): Throws an error if not
10499 may-call-functions.
10500 (_initialize_infcall): Call add_setshow_boolean_cmd for
10501 may-call-functions.
10502
10503 2019-04-25 Keith Seitz <keiths@redhat.com>
10504
10505 PR c++/24367
10506 * cp-support.c (inspect_type): Don't attempt substitutions
10507 of symbol with the same name.
10508
10509 2019-04-25 Tom Tromey <tromey@adacore.com>
10510
10511 PR gdb/24475:
10512 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10513 static.
10514
10515 2019-04-25 Tom Tromey <tromey@adacore.com>
10516
10517 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10518 rvalue reference.
10519 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10520 (gdb_xml_parser::parse): Use std::move.
10521 * python/python-internal.h (gdbpy_convert_exception): Take a const
10522 reference.
10523 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10524 std::move.
10525 * python/py-utils.c (gdbpy_convert_exception): Take a const
10526 reference.
10527 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10528 Use std::move.
10529 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10530 Use std::move.
10531 * mi/mi-main.c (mi_print_exception): Take a const reference.
10532 * main.c (handle_command_errors): Take a const reference.
10533 * linespec.c (parse_linespec): Use std::move.
10534 * infcall.c (run_inferior_call): Use std::move.
10535 (call_function_by_hand_dummy): Use std::move.
10536 * exec.c (try_open_exec_file): Use std::move.
10537 * exceptions.h (exception_print, exception_fprintf)
10538 (exception_print_same): Update.
10539 * exceptions.c (print_exception, exception_print)
10540 (exception_fprintf, exception_print_same): Change parameters to
10541 const reference.
10542 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10543 * common/new-op.c: Use std::move.
10544 * common/common-exceptions.h (struct gdb_exception): Add move
10545 constructor.
10546 (struct gdb_exception_error, struct gdb_exception_quit, struct
10547 gdb_quit_bad_alloc): Change constructor to move constructor.
10548 (throw_exception): Change parameter to rvalue reference.
10549 * common/common-exceptions.c (throw_exception): Take rvalue
10550 reference.
10551 * cli/cli-interp.c (safe_execute_command): Use std::move.
10552 * breakpoint.c (insert_bp_location, location_to_sals): Use
10553 std::move.
10554
10555 2019-04-25 Tom Tromey <tromey@adacore.com>
10556
10557 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10558 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10559 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10560 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10561 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10562 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10563 guile/scm-value.c: Use unpack.
10564 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10565 gdbscm_gdb_exception.
10566 (gdbscm_throw_gdb_exception): Likewise.
10567 (struct gdbscm_gdb_exception): New.
10568 (unpack): New function.
10569 (gdbscm_wrap): Use unpack.
10570
10571 2019-04-25 Tom Tromey <tromey@adacore.com>
10572
10573 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10574 (gdb_rl_callback_handler): Use std::move.
10575 * common/common-exceptions.h (struct gdb_exception): Add move
10576 assignment operator.
10577 (throw_exception_sjlj): Change "exception" to const reference.
10578 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10579 (throw_exception_sjlj): Change "exception" to const reference.
10580
10581 2019-04-25 Tom Tromey <tromey@adacore.com>
10582
10583 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10584 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10585 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10586 Update.
10587 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10588 Update.
10589 * mi/mi-interp.c (mi_interp::exec): Update.
10590 * linespec.c (parse_linespec): Update.
10591 * infcall.c (run_inferior_call): Update.
10592 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10593 * guile/scm-symbol.c (gdbscm_lookup_symbol)
10594 (gdbscm_lookup_global_symbol): Update.
10595 * guile/scm-param.c (gdbscm_parameter_value): Update.
10596 * guile/scm-frame.c (gdbscm_frame_read_register)
10597 (gdbscm_frame_read_var): Update.
10598 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10599 * exec.c (try_open_exec_file): Update.
10600 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10601 (gdb_rl_callback_handler): Update.
10602 * common/common-exceptions.h (exception_none): Don't declare.
10603 * common/common-exceptions.c (exception_none): Don't define.
10604 (struct catcher) <exception>: Update.
10605 * cli/cli-interp.c (safe_execute_command): Update.
10606 * breakpoint.c (insert_bp_location, location_to_sals): Update.
10607
10608 2019-04-25 Ali Tamur <tamur@google.com>
10609
10610 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10611 (read_attribute_value): Likewise.
10612 (dwarf2_read_addr_index): Update comment.
10613 (read_str_index): Add DW_FORM_strx.
10614 (dwarf2_string_attr): Likewise.
10615 (dwarf2_const_value_attr): Likewise.
10616 (dump_die_shallow): Likewise.
10617 (dwarf2_fetch_constant_bytes): Likewise.
10618 (skip_form_bytes): Likewise.
10619 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10620
10621 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
10622
10623 PR corefiles/11608
10624 PR corefiles/18187
10625 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10626 OFFSET. Verify if current mapping contains an ELF header.
10627 (linux_find_memory_regions_full): Adjust call to
10628 dump_mapping_p.
10629
10630 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
10631 Kang Li <kanglictf@gmail.com>
10632
10633 PR gdb/21600
10634
10635 * dwarf2-frame.c (read_initial_length): Be consistent about using
10636 unsigned representation of length.
10637 (decode_frame_entry_1): Likewise. Check for wraparound of
10638 end pointer as well as buffer overflow.
10639
10640 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
10641
10642 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10643 "vq".
10644
10645 2019-04-24 Tom Tromey <tromey@adacore.com>
10646
10647 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10648
10649 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10650
10651 * s12z-tdep.c (s12z_unwind_pc): Delete.
10652 (s12z_unwind_sp): Delete.
10653 (s12z_gdbarch_init): Don't register deleted functions with
10654 gdbarch.
10655
10656 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10657
10658 * rl78-tdep.c (rl78_unwind_sp): Delete.
10659 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10660
10661 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10662
10663 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10664 (xstormy16_unwind_pc): Delete.
10665 (xstormy16_dummy_id): Delete.
10666 (xstormy16_gdbarch_init): Don't register deleted functions with
10667 gdbarch.
10668
10669 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10670
10671 * vax-tdep.c (vax_unwind_pc): Delete.
10672 (vax_gdbarch_init): Don't register deleted function with gdbarch.
10673
10674 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10675
10676 * v850-tdep.c (v850_unwind_sp): Delete.
10677 (v850_unwind_pc): Delete.
10678 (v850_dummy_id): Delete.
10679 (v850_gdbarch_init): Don't register deleted functions with
10680 gdbarch.
10681
10682 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10683
10684 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10685 (tilegx_unwind_pc): Delete.
10686 (tilegx_unwind_dummy_id): Delete.
10687 (tilegx_gdbarch_init): Don't register deleted functions with
10688 gdbarch.
10689
10690 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10691
10692 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10693 (tic6x_dummy_id): Delete.
10694 (tic6x_gdbarch_init): Don't register deleted functions with
10695 gdbarch.
10696
10697 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10698
10699 * sparc-tdep.c (sparc_unwind_pc): Delete.
10700 (sparc32_gdbarch_init): Don't register deleted function with
10701 gdbarch.
10702
10703 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10704
10705 * sh-tdep.c (sh_unwind_sp): Delete.
10706 (sh_unwind_pc): Delete.
10707 (sh_dummy_id): Delete.
10708 (sh_gdbarch_init): Don't register deleted functions with
10709 gdbarch.
10710
10711 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10712
10713 * score-tdep.c (score_unwind_sp): Delete.
10714 (score_unwind_pc): Delete.
10715 (score_dummy_id): Delete.
10716 (score_gdbarch_init): Don't register deleted functions with
10717 gdbarch.
10718
10719 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10720
10721 * rx-tdep.c (rx_unwind_pc): Delete.
10722 (rx_unwind_sp): Delete.
10723 (rx_dummy_id): Delete.
10724 (rx_gdbarch_init): Don't register deleted functions with
10725 gdbarch. Update comment.
10726
10727 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10728
10729 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10730 (rs6000_dummy_id): Delete.
10731 (rs6000_gdbarch_init): Don't register deleted functions with
10732 gdbarch.
10733
10734 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10735
10736 * or1k-tdep.c (or1k_dummy_id): Delete.
10737 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10738
10739 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10740
10741 * nios2-tdep.c (nios2_dummy_id): Delete.
10742 (nios2_unwind_sp): Delete.
10743 (nios2_gdbarch_init): Don't register deleted functions with
10744 gdbarch.
10745
10746 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10747
10748 * nds32-tdep.c (nds32_dummy_id): Delete.
10749 (nds32_unwind_pc): Delete.
10750 (nds32_unwind_sp): Delete.
10751 (nds32_gdbarch_init): Don't register deleted functions with
10752 gdbarch.
10753
10754 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10755
10756 * msp430-tdep.c (msp430_unwind_pc): Delete.
10757 (msp430_unwind_sp): Delete.
10758 (msp430_dummy_id): Delete.
10759 (msp430_gdbarch_init): Don't register deleted functions with
10760 gdbarch.
10761
10762 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10763
10764 * moxie-tdep.c (moxie_unwind_sp): Delete.
10765 (moxie_unwind_pc): Delete.
10766 (moxie_dummy_id): Delete.
10767 (moxie_gdbarch_init): Don't register deleted functions with
10768 gdbarch.
10769
10770 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10771
10772 * mn10300-tdep.c (mn10300_dummy_id): Delete.
10773 (mn10300_unwind_pc): Delete.
10774 (mn10300_unwind_sp): Delete.
10775 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10776 mn10300_unwind_sp.
10777 (mn10300_frame_unwind_init): Don't register deleted functions with
10778 gdbarch.
10779
10780 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10781
10782 * mep-tdep.c (mep_unwind_pc): Delete.
10783 (mep_unwind_sp): Delete.
10784 (mep_dummy_id): Delete.
10785 (mep_gdbarch_init): Don't register deleted functions with
10786 gdbarch.
10787
10788 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10789
10790 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10791 (m68hc11_unwind_sp): Delete.
10792 (m68hc11_gdbarch_init): Don't register deleted functions with
10793 gdbarch.
10794
10795 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10796
10797 * m32r-tdep.c (m32r_unwind_sp): Delete.
10798 (m32r_unwind_pc): Delete.
10799 (m32r_dummy_id): Delete.
10800 (m32r_gdbarch_init): Don't register deleted functions with
10801 gdbarch.
10802
10803 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10804
10805 * m32c-tdep.c (m32c_unwind_pc): Delete.
10806 (m32c_unwind_sp): Delete.
10807 (m32c_dummy_id): Delete.
10808 (m32c_gdbarch_init): Don't register deleted functions with
10809 gdbarch.
10810
10811 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10812
10813 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10814 (lm32_unwind_pc): Delete.
10815 (lm32_dummy_id): Delete.
10816 (lm32_gdbarch_init): Don't register deleted functions with
10817 gdbarch.
10818
10819 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10820
10821 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10822 (iq2000_unwind_pc): Delete.
10823 (iq2000_dummy_id): Delete.
10824 (iq2000_gdbarch_init): Don't register deleted functions with
10825 gdbarch.
10826
10827 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10828
10829 * nds32-tdep.c (nds32_type_align): Delete.
10830 (nds32_push_dummy_call): Use type_align instead.
10831
10832 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10833
10834 * arm-tdep.c (arm_type_align): Only handle vector override case.
10835 (arm_push_dummy_call): Use type_align.
10836 (arm_gdbarch_init): Register arm_type_align gdbarch function.
10837
10838 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10839
10840 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10841 case.
10842 (pass_on_stack): Use type_align.
10843 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10844 function.
10845
10846 2019-04-23 Tom Tromey <tromey@adacore.com>
10847
10848 * dwarf2read.c (line_header::file_name_at): Remove unused
10849 overload.
10850
10851 2019-04-23 Tom de Vries <tdevries@suse.de>
10852
10853 PR gdb/24438
10854 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10855 invocation.
10856
10857
10858 2019-03-27 Ali Tamur <tamur@google.com>
10859
10860 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10861 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10862 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10863 (dwarf_expr_context::get_addr_index): Likewise
10864 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10865 (symbol_needs_eval_context::get_addr_index): Likewise
10866 (disassemble_dwarf_expression): Add DW_OP_addrx
10867 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10868 (read_cutu_die_from_dwo): Update comment
10869 (skip_one_die): Add DW_FORM_addrx
10870 (read_attribute_value): Likewise
10871 (var_decode_location): Add DW_OP_addrx
10872 (dwarf2_const_value_attr): Add DW_FORM_addrx
10873 (dump_die_shallow): Likewise
10874 (dwarf2_fetch_constant_bytes): Likewise
10875 (decode_locdesc): Add DW_OP_addrx
10876 (skip_form_bytes): Add DW_FORM_addrx
10877
10878 2019-04-22 Ali Tamur <tamur@google.com>
10879
10880 * MAINTAINERS (Write After Approval): Add self.
10881
10882 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
10883
10884 * solib-svr4.c (get_svr4_info): Add pspace parameter.
10885 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10886 (open_symbol_file_object): Likewise.
10887 (svr4_default_sos): Add info parameter.
10888 (svr4_read_so_list): Likewise.
10889 (svr4_current_sos_direct): Adjust functions calls to pass down
10890 info.
10891 (svr4_current_sos_1): Add info parameter.
10892 (svr4_current_sos): Call get_svr4_info, pass info down to
10893 svr4_current_sos_1.
10894 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10895 get_svr4_info.
10896 (svr4_in_dynsym_resolve_code): Pass current_program_space to
10897 get_svr4_info.
10898 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10899 to get_svr4_info.
10900 (probes_table_remove_objfile_probes): Likewise.
10901 (register_solib_event_probe): Add info parameter.
10902 (solist_update_incremental): Pass info parameter down to
10903 svr4_read_so_list.
10904 (disable_probes_interface): Add info parameter.
10905 (svr4_handle_solib_event): Pass current_program_space to
10906 get_svr4_info. Adjust disable_probes_interface cleanup.
10907 (svr4_create_probe_breakpoints): Add info parameter, pass it
10908 down to register_solib_event_probe.
10909 (svr4_create_solib_event_breakpoints): Add info parameter,
10910 pass it down to svr4_create_probe_breakpoints.
10911 (enable_break): Pass info down to
10912 svr4_create_solib_event_breakpoints.
10913 (svr4_solib_create_inferior_hook): Pass current_program_space to
10914 get_svr4_info.
10915 (svr4_clear_solib): Likewise.
10916
10917 2019-04-22 Pedro Alves <palves@redhat.com>
10918
10919 * solib-svr4.c (svr4_free_objfile_observer): New.
10920 (probe_and_action::objfile): New field.
10921 (probes_table_htab_remove_objfile_probes)
10922 (probes_table_remove_objfile_probes): New functions.
10923 (register_solib_event_probe): Add 'objfile' parameter. Store it
10924 in the new probe_and_action. Don't store the probe in 'lookup'.
10925 (svr4_create_probe_breakpoints): Pass objfile to
10926 register_solib_event_probe.
10927 (_initialize_svr4_solib): Register a free_objfile observer.
10928
10929 2019-04-19 Tom Tromey <tom@tromey.com>
10930
10931 * common/queue.h: Remove.
10932
10933 2019-04-19 Tom Tromey <tom@tromey.com>
10934
10935 * event-loop.c: Don't include "common/queue.h".
10936
10937 2019-04-19 Tom Tromey <tom@tromey.com>
10938
10939 * remote.c (remote_target): Use delete.
10940 * remote-notif.h: Include <list>, not "common/queue.h".
10941 (notif_client_p): Remove typedef.
10942 (remote_notif_state): Add constructor, destructor, initializer.
10943 <notif_queue>: Now a std::list.
10944 (remote_notif_state_xfree): Don't declare.
10945 * remote-notif.c (remote_notif_process, handle_notification)
10946 (remote_notif_state_allocate): Update.
10947 (~remote_notif_state): Rename from remote_notif_state_xfree.
10948
10949 2019-04-19 Tom Tromey <tom@tromey.com>
10950
10951 * symfile.c (reread_symbols): Update.
10952 * objfiles.c (objfile_register_static_link)
10953 (objfile_lookup_static_link): Update
10954 (~objfile) Don't delete static_links.
10955 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
10956
10957 2019-04-19 Tom Tromey <tom@tromey.com>
10958
10959 * type-stack.h (struct type_stack) <insert>: Constify string.
10960 * type-stack.c (type_stack::insert): Constify string.
10961 * gdbtypes.h (lookup_template_type): Update.
10962 (address_space_name_to_int): Update.
10963 * gdbtypes.c (address_space_name_to_int): Make space_identifier
10964 const.
10965 (lookup_template_type): Make name const.
10966 * c-exp.y: Update rules.
10967 (lex_one_token, classify_name, classify_inner_name)
10968 (c_print_token): Update.
10969 * p-exp.y: Update rules.
10970 (yylex): Update.
10971 * f-exp.y: Update rules.
10972 (yylex): Update.
10973 * d-exp.y: Update rules.
10974 (lex_one_token, classify_name, classify_inner_name): Update.
10975 * parse.c (write_dollar_variable, copy_name): Return std::string.
10976 * parser-defs.h (copy_name): Change return type.
10977 * m2-exp.y: Update rules.
10978 (yylex): Update.
10979 * go-exp.y (lex_one_token): Update.
10980 Update rules.
10981 (classify_unsafe_function, classify_packaged_name)
10982 (classify_name, yylex): Update.
10983
10984 2019-04-19 Sergei Trofimovich <siarheit@google.com>
10985
10986 * configure.ac: add --enable-source-highlight switch.
10987 * configure: Regenerate.
10988 * top.c (print_gdb_version): plumb --enable-source-highlight
10989 status to "show configuration".
10990
10991 2019-04-19 Tom Tromey <tromey@adacore.com>
10992
10993 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
10994 Check ADA_TYPE_P.
10995 (empty_record, ada_template_to_fixed_record_type_1)
10996 (template_to_static_fixed_type)
10997 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
10998 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
10999 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11000 macros.
11001
11002 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11003
11004 PR symtab/24423:
11005 * source.c (print_source_lines_base): Advance "iter" when a
11006 control character is seen.
11007
11008 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11009
11010 * inferior.h (struct infcall_suspend_state_deleter):
11011 Catch exception in destructor to avoid crash.
11012
11013 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11014
11015 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11016 close to the add_com "shell".
11017
11018 2019-04-18 Tom Tromey <tromey@adacore.com>
11019
11020 * process-stratum-target.h (class process_stratum_target)
11021 <stratum>: Add "final".
11022
11023 2019-04-17 Tom Tromey <tromey@adacore.com>
11024
11025 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11026 against nullptr before use.
11027
11028 2019-04-17 Alan Hayward <alan.hayward@arm.com>
11029
11030 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11031
11032 2019-04-17 Jim Wilson <jimw@sifive.com>
11033 Andrew Burgess <andrew.burgess@embecosm.com>
11034
11035 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11036 code read might fail, assume 4-byte breakpoint in that case.
11037
11038 2019-04-15 Leszek Swirski <leszeks@google.com>
11039
11040 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11041 rather than a hand-rolled POD check when checking for forced MEMORY
11042 classification.
11043
11044 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11045
11046 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11047 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11048 function.
11049 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11050 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11051 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11052 declaration.
11053
11054 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11055
11056 * aarch64-linux-nat.c
11057 (aarch64_linux_nat_target::thread_architecture): Add override.
11058 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11059 each VQ.
11060
11061 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11062
11063 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11064
11065 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11066
11067 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11068 target types of size 96-bits, add some additional comments, and
11069 check that the builtin type we found was the correct size.
11070
11071 2019-04-12 Eli Zaretskii <eliz@gnu.org>
11072
11073 * utils.c (prompt_for_continue): Don't restore the styling at the
11074 end, as applied_style has the wrong value. This fixes styling in
11075 long lists of file names that are interrupted by the "Continue?"
11076 prompt.
11077
11078 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11079
11080 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11081 * c-lang.c (c_language_defn): Likewise.
11082 (cplus_language_defn): Likewise.
11083 (asm_language_defn): Likewise.
11084 (minimal_language_defn): Likewise.
11085 * d-lang.c (d_language_defn): Likewise.
11086 * f-lang.c (f_language_defn): Likewise.
11087 * go-lang.c (go_language_defn): Likewise.
11088 * language.c (unknown_language_defn): Likewise.
11089 (auto_language_defn): Likewise.
11090 * language.h (struct language_defn): Remove la_magic field.
11091 (LANG_MAGIC): Delete.
11092 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11093 * objc-lang.c (objc_language_defn): Likewise.
11094 * opencl-lang.c (opencl_language_defn): Likewise.
11095 * p-lang.c (pascal_language_defn): Likewise.
11096 * rust-lang.c (rust_language_defn): Likewise.
11097
11098 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11099
11100 * riscv-tdep.c (riscv_type_align): New function.
11101 (riscv_type_alignment): Delete.
11102 (riscv_arg_location): Use 'type_align'.
11103 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11104
11105 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11106
11107 * gdbtypes.c (type_align): A struct with no non-static fields also
11108 has alignment of 1.
11109
11110 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11111
11112 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11113 component to 0.
11114 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11115 member.
11116 (riscv_struct_info::analyse): New implementation using new
11117 analyse_inner member function.
11118 (riscv_struct_info::field_offset): New member function.
11119 (riscv_struct_info::m_offsets): New member variable.
11120 (riscv_struct_info::analyse_inner): New private member function,
11121 takes the old implementation of riscv_struct_info::analyse but
11122 extended to track field offsets.
11123 (riscv_call_arg_struct): Update the struct folding special cases
11124 to handle cases where empty C++ structs, which are non-zero
11125 length, are found.
11126 (riscv_arg_location): Initialise the length of each location, a
11127 non-zero length now indicates the location is in use.
11128 (riscv_push_dummy_call): Allow for the first location having a
11129 non-zero offset when setting up arguments.
11130 (riscv_return_value): Likewise, but for return values.
11131
11132 2019-04-11 Tom Tromey <tromey@adacore.com>
11133
11134 * utils.c (internal_vproblem): Make "msg" const.
11135
11136 2019-04-11 Alan Hayward <alan.hayward@arm.com>
11137
11138 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11139 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11140 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11141 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11142
11143 2019-04-10 Kevin Buettner <kevinb@redhat.com>
11144
11145 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11146 function.
11147 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11148 of amd64_collect_native_gregset.
11149 (amd64_linux_nat_target::store_registers): Likewise.
11150
11151 2019-04-10 Tom Tromey <tom@tromey.com>
11152
11153 * symtab.c (lookup_global_symbol_from_objfile)
11154 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11155 * objfiles.h (class separate_debug_iterator): New.
11156 (class separate_debug_range): New.
11157 (struct objfile) <separate_debug_objfiles>: New method.
11158 (objfile_separate_debug_iterate): Don't declare.
11159 * objfiles.c (separate_debug_iterator::operator++): Rename from
11160 objfile_separate_debug_iterate.
11161 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11162 iterator.
11163 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11164 iterator.
11165
11166 2019-04-10 Tom Tromey <tom@tromey.com>
11167
11168 * symfile.c (reread_symbols): Remove old comment.
11169 * objfiles.c (free_all_objfiles): Fix a typo.
11170
11171 2019-04-10 Tom Tromey <tom@tromey.com>
11172
11173 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11174 * minsyms.c (lookup_minimal_symbol): Use foreach.
11175 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11176 (lookup_minimal_symbol_solib_trampoline): Likewise.
11177 * symfile.c (reread_symbols): Use foreach.
11178
11179 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
11180 Tom Tromey <tromey@adacore.com>
11181
11182 PR rust/24414:
11183 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11184 (rust_lex_int_test): Change "value" to be LONGEST.
11185 (rust_lex_tests): Add test for long integer literal.
11186
11187 2019-04-09 Tom Tromey <tromey@adacore.com>
11188
11189 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11190 to bool.
11191 (extended_remote_target::attach): Update.
11192 (remote_target::remote_notice_new_inferior): Update.
11193 (remote_target::add_current_inferior_and_thread): Update.
11194 * inferior.c (exit_inferior_1): Use "false".
11195 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11196
11197 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
11198
11199 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11200 the "start" command.
11201
11202 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11203
11204 * python/py-inferior.c (infpy_thread_from_thread_handle):
11205 Adjust comments to reflect renaming of thread_from_thread_handle
11206 to thread_from_handle. Adjust keywords. Fix type error message.
11207 (inferior_object_methods): Add thread_from_handle. Retain
11208 thread_from_thread_handle, but mark it as deprecated.
11209
11210 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11211
11212 * gdbthread.h (find_thread_by_handle): Revise declaration.
11213 * thread.c (find_thread_by_handle): Likewise. Adjust
11214 implementation too.
11215 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11216 support for buffer objects as handles.
11217
11218 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11219
11220 * python/py-infthread.c (thpy_thread_handle): New function.
11221 (thread_object_methods): Register thpy_thread_handle.
11222
11223 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11224
11225 * gdbthread.h (thread_to_thread_handle): Declare.
11226 * thread.c (gdbtypes.h): Include.
11227 (thread_to_thread_handle): New function.
11228
11229 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11230 (target_thread_info_to_thread_handle): Declare.
11231 * target.c (target_thread_info_to_thread_handle): New function.
11232 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11233 * target-delegates.c: Regenerate.
11234
11235 * linux-thread-db.c (class thread_db_target): Add method
11236 thread_info_to_thread_handle.
11237 (thread_db_target::thread_info_to_thread_handle): Define.
11238 * remote.c (class remote_target): Add new method
11239 thread_info_to_thread_handle.
11240 (remote_target::thread_info_to_thread_handle): Define.
11241
11242 2019-04-08 Pedro Alves <palves@redhat.com>
11243
11244 * common/common-exceptions.c (throw_exception): Don't create
11245 named object to throw; throw directly.
11246 (throw_it): Likewise. Don't initialize gdb_exception::message
11247 here, with new; pass FMT and AP to the ctor instead.
11248 * common/common-exceptions.h: Include <string>.
11249 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11250 const char *, va_list)): New ctor. Use std::make_shared.
11251 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11252 errors)): Delete.
11253 (gdb_exception_error::gdb_exception_error(enum errors, const char
11254 *, va_list)): New.
11255 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11256 Add assertion.
11257 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11258 errors)): Delete.
11259 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11260 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11261 Add assertion.
11262
11263 2019-04-08 Tom Tromey <tom@tromey.com>
11264
11265 * valops.c (value_rtti_indirect_type): Replace throw_exception
11266 with throw.
11267 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11268 with throw.
11269 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11270 throw.
11271 * target.c (target_translate_tls_address): Replace throw_exception
11272 with throw.
11273 * stack.c (frame_apply_command_count): Replace throw_exception
11274 with throw.
11275 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11276 throw.
11277 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11278 with throw.
11279 * rs6000-tdep.c (rs6000_frame_cache)
11280 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11281 * remote.c: Replace throw_exception with throw.
11282 * record-full.c (record_full_message, record_full_wait_1)
11283 (record_full_restore): Replace throw_exception with throw.
11284 * record-btrace.c:
11285 (get_thread_current_frame_id, record_btrace_start_replaying)
11286 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11287 (cmd_record_btrace_start): Replace throw_exception with throw.
11288 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11289 throw.
11290 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11291 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11292 * linespec.c:
11293 (find_linespec_symbols): Replace throw_exception with throw.
11294 * infrun.c (displaced_step_prepare, resume): Replace
11295 throw_exception with throw.
11296 * infcmd.c (post_create_inferior): Replace throw_exception with
11297 throw.
11298 * inf-loop.c (inferior_event_handler): Replace throw_exception
11299 with throw.
11300 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11301 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11302 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11303 (get_prev_frame_always, get_frame_pc_if_available)
11304 (get_frame_address_in_block_if_available, get_frame_language):
11305 Replace throw_exception with throw.
11306 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11307 throw_exception with throw.
11308 * eval.c (fetch_subexp_value, evaluate_var_value)
11309 (evaluate_funcall, evaluate_subexp_standard): Replace
11310 throw_exception with throw.
11311 * dwarf2loc.c (call_site_find_chain)
11312 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11313 Replace throw_exception with throw.
11314 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11315 with throw.
11316 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11317 throw.
11318 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11319 * completer.c (complete_line_internal): Replace throw_exception
11320 with throw.
11321 * compile/compile-object-run.c (compile_object_run): Replace
11322 throw_exception with throw.
11323 * cli/cli-script.c (process_next_line): Replace throw_exception
11324 with throw.
11325 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11326 (btrace_enable, btrace_maint_update_pt_packets): Replace
11327 throw_exception with throw.
11328 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11329 throw_exception with throw.
11330 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11331 throw_exception with throw.
11332 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11333 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11334 * aarch64-tdep.c (aarch64_make_prologue_cache)
11335 (aarch64_make_stub_cache): Replace throw_exception with throw.
11336
11337 2019-04-08 Tom Tromey <tom@tromey.com>
11338
11339 * common/common-exceptions.c (throw_exception): Rename from
11340 throw_exception_cxx. Remove old copy. Make argument const.
11341 (throw_it): Create and throw exception objects directly.
11342 * common/common-exceptions.h (throw_exception): Make argument
11343 const.
11344 (struct gdb_exception_error): Add constructor.
11345 (struct gdb_exception_quit): Add constructor.
11346
11347 2019-04-08 Tom Tromey <tom@tromey.com>
11348
11349 * common/common-exceptions.h (exception_rethrow): Don't declare.
11350 (TRY_SJLJ): Update comment.
11351 (TRY, CATCH, END_CATCH): Remove.
11352 * common/common-exceptions.c (exception_rethrow): Remove.
11353
11354 2019-04-08 Tom Tromey <tom@tromey.com>
11355
11356 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11357 Remove.
11358 (gdb_exception_error): Rename from
11359 gdb_exception_RETURN_MASK_ERROR.
11360 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11361 (gdb_quit_bad_alloc): Update.
11362 * aarch64-tdep.c: Update.
11363 * ada-lang.c: Update.
11364 * ada-typeprint.c: Update.
11365 * ada-valprint.c: Update.
11366 * amd64-tdep.c: Update.
11367 * arch-utils.c: Update.
11368 * break-catch-throw.c: Update.
11369 * breakpoint.c: Update.
11370 * btrace.c: Update.
11371 * c-varobj.c: Update.
11372 * cli/cli-cmds.c: Update.
11373 * cli/cli-interp.c: Update.
11374 * cli/cli-script.c: Update.
11375 * common/common-exceptions.c: Update.
11376 * common/new-op.c: Update.
11377 * common/selftest.c: Update.
11378 * compile/compile-c-symbols.c: Update.
11379 * compile/compile-cplus-symbols.c: Update.
11380 * compile/compile-object-load.c: Update.
11381 * compile/compile-object-run.c: Update.
11382 * completer.c: Update.
11383 * corelow.c: Update.
11384 * cp-abi.c: Update.
11385 * cp-support.c: Update.
11386 * cp-valprint.c: Update.
11387 * darwin-nat.c: Update.
11388 * disasm-selftests.c: Update.
11389 * dtrace-probe.c: Update.
11390 * dwarf-index-cache.c: Update.
11391 * dwarf-index-write.c: Update.
11392 * dwarf2-frame-tailcall.c: Update.
11393 * dwarf2-frame.c: Update.
11394 * dwarf2loc.c: Update.
11395 * dwarf2read.c: Update.
11396 * eval.c: Update.
11397 * event-loop.c: Update.
11398 * event-top.c: Update.
11399 * exec.c: Update.
11400 * f-valprint.c: Update.
11401 * fbsd-tdep.c: Update.
11402 * frame-unwind.c: Update.
11403 * frame.c: Update.
11404 * gdbtypes.c: Update.
11405 * gnu-v3-abi.c: Update.
11406 * guile/guile-internal.h: Update.
11407 * guile/scm-block.c: Update.
11408 * guile/scm-breakpoint.c: Update.
11409 * guile/scm-cmd.c: Update.
11410 * guile/scm-disasm.c: Update.
11411 * guile/scm-frame.c: Update.
11412 * guile/scm-lazy-string.c: Update.
11413 * guile/scm-math.c: Update.
11414 * guile/scm-param.c: Update.
11415 * guile/scm-ports.c: Update.
11416 * guile/scm-pretty-print.c: Update.
11417 * guile/scm-symbol.c: Update.
11418 * guile/scm-symtab.c: Update.
11419 * guile/scm-type.c: Update.
11420 * guile/scm-value.c: Update.
11421 * i386-linux-tdep.c: Update.
11422 * i386-tdep.c: Update.
11423 * inf-loop.c: Update.
11424 * infcall.c: Update.
11425 * infcmd.c: Update.
11426 * infrun.c: Update.
11427 * jit.c: Update.
11428 * language.c: Update.
11429 * linespec.c: Update.
11430 * linux-fork.c: Update.
11431 * linux-nat.c: Update.
11432 * linux-tdep.c: Update.
11433 * linux-thread-db.c: Update.
11434 * main.c: Update.
11435 * mi/mi-cmd-break.c: Update.
11436 * mi/mi-cmd-stack.c: Update.
11437 * mi/mi-interp.c: Update.
11438 * mi/mi-main.c: Update.
11439 * objc-lang.c: Update.
11440 * p-valprint.c: Update.
11441 * parse.c: Update.
11442 * ppc-linux-tdep.c: Update.
11443 * printcmd.c: Update.
11444 * python/py-arch.c: Update.
11445 * python/py-breakpoint.c: Update.
11446 * python/py-cmd.c: Update.
11447 * python/py-finishbreakpoint.c: Update.
11448 * python/py-frame.c: Update.
11449 * python/py-framefilter.c: Update.
11450 * python/py-gdb-readline.c: Update.
11451 * python/py-inferior.c: Update.
11452 * python/py-infthread.c: Update.
11453 * python/py-lazy-string.c: Update.
11454 * python/py-linetable.c: Update.
11455 * python/py-objfile.c: Update.
11456 * python/py-param.c: Update.
11457 * python/py-prettyprint.c: Update.
11458 * python/py-progspace.c: Update.
11459 * python/py-record-btrace.c: Update.
11460 * python/py-record.c: Update.
11461 * python/py-symbol.c: Update.
11462 * python/py-type.c: Update.
11463 * python/py-unwind.c: Update.
11464 * python/py-utils.c: Update.
11465 * python/py-value.c: Update.
11466 * python/python.c: Update.
11467 * record-btrace.c: Update.
11468 * record-full.c: Update.
11469 * remote-fileio.c: Update.
11470 * remote.c: Update.
11471 * riscv-tdep.c: Update.
11472 * rs6000-aix-tdep.c: Update.
11473 * rs6000-tdep.c: Update.
11474 * rust-exp.y: Update.
11475 * rust-lang.c: Update.
11476 * s390-tdep.c: Update.
11477 * selftest-arch.c: Update.
11478 * solib-dsbt.c: Update.
11479 * solib-frv.c: Update.
11480 * solib-spu.c: Update.
11481 * solib-svr4.c: Update.
11482 * solib.c: Update.
11483 * sparc64-linux-tdep.c: Update.
11484 * stack.c: Update.
11485 * symfile-mem.c: Update.
11486 * symmisc.c: Update.
11487 * target.c: Update.
11488 * thread.c: Update.
11489 * top.c: Update.
11490 * tracefile-tfile.c: Update.
11491 * tui/tui.c: Update.
11492 * typeprint.c: Update.
11493 * unittests/cli-utils-selftests.c: Update.
11494 * unittests/parse-connection-spec-selftests.c: Update.
11495 * valops.c: Update.
11496 * valprint.c: Update.
11497 * value.c: Update.
11498 * varobj.c: Update.
11499 * windows-nat.c: Update.
11500 * x86-linux-nat.c: Update.
11501 * xml-support.c: Update.
11502
11503 2019-04-08 Tom Tromey <tom@tromey.com>
11504
11505 * xml-support.c: Use C++ exception handling.
11506 * x86-linux-nat.c: Use C++ exception handling.
11507 * windows-nat.c: Use C++ exception handling.
11508 * varobj.c: Use C++ exception handling.
11509 * value.c: Use C++ exception handling.
11510 * valprint.c: Use C++ exception handling.
11511 * valops.c: Use C++ exception handling.
11512 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11513 handling.
11514 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11515 * typeprint.c: Use C++ exception handling.
11516 * tui/tui.c: Use C++ exception handling.
11517 * tracefile-tfile.c: Use C++ exception handling.
11518 * top.c: Use C++ exception handling.
11519 * thread.c: Use C++ exception handling.
11520 * target.c: Use C++ exception handling.
11521 * symmisc.c: Use C++ exception handling.
11522 * symfile-mem.c: Use C++ exception handling.
11523 * stack.c: Use C++ exception handling.
11524 * sparc64-linux-tdep.c: Use C++ exception handling.
11525 * solib.c: Use C++ exception handling.
11526 * solib-svr4.c: Use C++ exception handling.
11527 * solib-spu.c: Use C++ exception handling.
11528 * solib-frv.c: Use C++ exception handling.
11529 * solib-dsbt.c: Use C++ exception handling.
11530 * selftest-arch.c: Use C++ exception handling.
11531 * s390-tdep.c: Use C++ exception handling.
11532 * rust-lang.c: Use C++ exception handling.
11533 * rust-exp.y: Use C++ exception handling.
11534 * rs6000-tdep.c: Use C++ exception handling.
11535 * rs6000-aix-tdep.c: Use C++ exception handling.
11536 * riscv-tdep.c: Use C++ exception handling.
11537 * remote.c: Use C++ exception handling.
11538 * remote-fileio.c: Use C++ exception handling.
11539 * record-full.c: Use C++ exception handling.
11540 * record-btrace.c: Use C++ exception handling.
11541 * python/python.c: Use C++ exception handling.
11542 * python/py-value.c: Use C++ exception handling.
11543 * python/py-utils.c: Use C++ exception handling.
11544 * python/py-unwind.c: Use C++ exception handling.
11545 * python/py-type.c: Use C++ exception handling.
11546 * python/py-symbol.c: Use C++ exception handling.
11547 * python/py-record.c: Use C++ exception handling.
11548 * python/py-record-btrace.c: Use C++ exception handling.
11549 * python/py-progspace.c: Use C++ exception handling.
11550 * python/py-prettyprint.c: Use C++ exception handling.
11551 * python/py-param.c: Use C++ exception handling.
11552 * python/py-objfile.c: Use C++ exception handling.
11553 * python/py-linetable.c: Use C++ exception handling.
11554 * python/py-lazy-string.c: Use C++ exception handling.
11555 * python/py-infthread.c: Use C++ exception handling.
11556 * python/py-inferior.c: Use C++ exception handling.
11557 * python/py-gdb-readline.c: Use C++ exception handling.
11558 * python/py-framefilter.c: Use C++ exception handling.
11559 * python/py-frame.c: Use C++ exception handling.
11560 * python/py-finishbreakpoint.c: Use C++ exception handling.
11561 * python/py-cmd.c: Use C++ exception handling.
11562 * python/py-breakpoint.c: Use C++ exception handling.
11563 * python/py-arch.c: Use C++ exception handling.
11564 * printcmd.c: Use C++ exception handling.
11565 * ppc-linux-tdep.c: Use C++ exception handling.
11566 * parse.c: Use C++ exception handling.
11567 * p-valprint.c: Use C++ exception handling.
11568 * objc-lang.c: Use C++ exception handling.
11569 * mi/mi-main.c: Use C++ exception handling.
11570 * mi/mi-interp.c: Use C++ exception handling.
11571 * mi/mi-cmd-stack.c: Use C++ exception handling.
11572 * mi/mi-cmd-break.c: Use C++ exception handling.
11573 * main.c: Use C++ exception handling.
11574 * linux-thread-db.c: Use C++ exception handling.
11575 * linux-tdep.c: Use C++ exception handling.
11576 * linux-nat.c: Use C++ exception handling.
11577 * linux-fork.c: Use C++ exception handling.
11578 * linespec.c: Use C++ exception handling.
11579 * language.c: Use C++ exception handling.
11580 * jit.c: Use C++ exception handling.
11581 * infrun.c: Use C++ exception handling.
11582 * infcmd.c: Use C++ exception handling.
11583 * infcall.c: Use C++ exception handling.
11584 * inf-loop.c: Use C++ exception handling.
11585 * i386-tdep.c: Use C++ exception handling.
11586 * i386-linux-tdep.c: Use C++ exception handling.
11587 * guile/scm-value.c: Use C++ exception handling.
11588 * guile/scm-type.c: Use C++ exception handling.
11589 * guile/scm-symtab.c: Use C++ exception handling.
11590 * guile/scm-symbol.c: Use C++ exception handling.
11591 * guile/scm-pretty-print.c: Use C++ exception handling.
11592 * guile/scm-ports.c: Use C++ exception handling.
11593 * guile/scm-param.c: Use C++ exception handling.
11594 * guile/scm-math.c: Use C++ exception handling.
11595 * guile/scm-lazy-string.c: Use C++ exception handling.
11596 * guile/scm-frame.c: Use C++ exception handling.
11597 * guile/scm-disasm.c: Use C++ exception handling.
11598 * guile/scm-cmd.c: Use C++ exception handling.
11599 * guile/scm-breakpoint.c: Use C++ exception handling.
11600 * guile/scm-block.c: Use C++ exception handling.
11601 * guile/guile-internal.h: Use C++ exception handling.
11602 * gnu-v3-abi.c: Use C++ exception handling.
11603 * gdbtypes.c: Use C++ exception handling.
11604 * frame.c: Use C++ exception handling.
11605 * frame-unwind.c: Use C++ exception handling.
11606 * fbsd-tdep.c: Use C++ exception handling.
11607 * f-valprint.c: Use C++ exception handling.
11608 * exec.c: Use C++ exception handling.
11609 * event-top.c: Use C++ exception handling.
11610 * event-loop.c: Use C++ exception handling.
11611 * eval.c: Use C++ exception handling.
11612 * dwarf2read.c: Use C++ exception handling.
11613 * dwarf2loc.c: Use C++ exception handling.
11614 * dwarf2-frame.c: Use C++ exception handling.
11615 * dwarf2-frame-tailcall.c: Use C++ exception handling.
11616 * dwarf-index-write.c: Use C++ exception handling.
11617 * dwarf-index-cache.c: Use C++ exception handling.
11618 * dtrace-probe.c: Use C++ exception handling.
11619 * disasm-selftests.c: Use C++ exception handling.
11620 * darwin-nat.c: Use C++ exception handling.
11621 * cp-valprint.c: Use C++ exception handling.
11622 * cp-support.c: Use C++ exception handling.
11623 * cp-abi.c: Use C++ exception handling.
11624 * corelow.c: Use C++ exception handling.
11625 * completer.c: Use C++ exception handling.
11626 * compile/compile-object-run.c: Use C++ exception handling.
11627 * compile/compile-object-load.c: Use C++ exception handling.
11628 * compile/compile-cplus-symbols.c: Use C++ exception handling.
11629 * compile/compile-c-symbols.c: Use C++ exception handling.
11630 * common/selftest.c: Use C++ exception handling.
11631 * common/new-op.c: Use C++ exception handling.
11632 * cli/cli-script.c: Use C++ exception handling.
11633 * cli/cli-interp.c: Use C++ exception handling.
11634 * cli/cli-cmds.c: Use C++ exception handling.
11635 * c-varobj.c: Use C++ exception handling.
11636 * btrace.c: Use C++ exception handling.
11637 * breakpoint.c: Use C++ exception handling.
11638 * break-catch-throw.c: Use C++ exception handling.
11639 * arch-utils.c: Use C++ exception handling.
11640 * amd64-tdep.c: Use C++ exception handling.
11641 * ada-valprint.c: Use C++ exception handling.
11642 * ada-typeprint.c: Use C++ exception handling.
11643 * ada-lang.c: Use C++ exception handling.
11644 * aarch64-tdep.c: Use C++ exception handling.
11645
11646 2019-04-08 Tom Tromey <tom@tromey.com>
11647
11648 * xml-support.c (gdb_xml_parser::parse): Update.
11649 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11650 * value.c (show_convenience): Update.
11651 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11652 (test_parse_flags_qcs): Update.
11653 * thread.c (thr_try_catch_cmd): Update.
11654 * target.c (target_translate_tls_address): Update.
11655 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11656 (info_frame_command_core, frame_apply_command_count): Update.
11657 * rust-exp.y (rust_lex_exception_test): Update.
11658 * riscv-tdep.c (riscv_print_one_register_info): Update.
11659 * remote.c (remote_target::enable_btrace): Update.
11660 * record-btrace.c (record_btrace_enable_warn): Update.
11661 * python/py-utils.c (gdbpy_convert_exception): Update.
11662 * printcmd.c (do_one_display, print_variable_and_value): Update.
11663 * mi/mi-main.c (mi_print_exception): Update.
11664 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11665 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11666 * linux-nat.c (linux_nat_target::attach): Update.
11667 * linux-fork.c (class scoped_switch_fork_info): Update.
11668 * infrun.c (displaced_step_prepare): Update.
11669 * infcall.c (call_function_by_hand_dummy): Update.
11670 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11671 * gnu-v3-abi.c (print_one_vtable): Update.
11672 * frame.c (get_prev_frame_always): Update.
11673 * f-valprint.c (info_common_command_for_block): Update.
11674 * exec.c (try_open_exec_file): Update.
11675 * exceptions.c (print_exception, exception_print)
11676 (exception_fprintf, exception_print_same): Update.
11677 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11678 * dwarf-index-cache.c (index_cache::store)
11679 (index_cache::lookup_gdb_index): Update.
11680 * darwin-nat.c (maybe_cache_shell): Update.
11681 * cp-valprint.c (cp_print_value_fields): Update.
11682 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11683 (gcc_cplus_symbol_address): Update.
11684 * compile/compile-c-symbols.c (gcc_convert_symbol)
11685 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11686 * common/selftest.c: Update.
11687 * common/common-exceptions.h (struct gdb_exception) <message>: Now
11688 a std::string.
11689 (exception_try_scope_entry, exception_try_scope_exit): Don't
11690 declare.
11691 (struct exception_try_scope): Remove.
11692 (TRY): Don't use exception_try_scope.
11693 (struct gdb_exception): Add constructor, operator=.
11694 <what>: New method.
11695 (struct gdb_exception_RETURN_MASK_ALL)
11696 (struct gdb_exception_RETURN_MASK_ERROR)
11697 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11698 (struct gdb_quit_bad_alloc): Update.
11699 * common/common-exceptions.c (exception_none): Change
11700 initializer.
11701 (struct catcher) <state, exception>: Initialize inline.
11702 <prev>: Remove member.
11703 (current_catcher): Remove.
11704 (catchers): New global.
11705 (exceptions_state_mc_init): Simplify.
11706 (catcher_pop): Remove.
11707 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11708 (try_scope_depth, exception_try_scope_entry)
11709 (exception_try_scope_exit): Remove.
11710 (throw_exception_sjlj): Update.
11711 (exception_messages, exception_messages_size): Remove.
11712 (throw_it): Simplify.
11713 (gdb_exception_sliced_copy): Remove.
11714 (throw_exception_cxx): Update.
11715 * cli/cli-script.c (script_from_file): Update.
11716 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11717 Update.
11718 * ada-valprint.c (ada_val_print): Update.
11719 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11720 (create_excep_cond_exprs): Update.
11721
11722 2019-04-08 Tom Tromey <tom@tromey.com>
11723
11724 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11725 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11726 (TRY, CATCH, END_CATCH): Remove some definitions.
11727 * common/common-exceptions.c: Don't use GDB_XCPT.
11728 (catcher_list_size): Remove.
11729 (throw_exception, throw_it): Simplify.
11730
11731 2019-04-05 Tom Tromey <tom@tromey.com>
11732
11733 Revert the header-sorting patch.
11734 * ft32-tdep.c: Revert.
11735 * frv-tdep.c: Revert.
11736 * frv-linux-tdep.c: Revert.
11737 * frame.c: Revert.
11738 * frame-unwind.c: Revert.
11739 * frame-base.c: Revert.
11740 * fork-child.c: Revert.
11741 * findvar.c: Revert.
11742 * findcmd.c: Revert.
11743 * filesystem.c: Revert.
11744 * filename-seen-cache.h: Revert.
11745 * filename-seen-cache.c: Revert.
11746 * fbsd-tdep.c: Revert.
11747 * fbsd-nat.h: Revert.
11748 * fbsd-nat.c: Revert.
11749 * f-valprint.c: Revert.
11750 * f-typeprint.c: Revert.
11751 * f-lang.c: Revert.
11752 * extension.h: Revert.
11753 * extension.c: Revert.
11754 * extension-priv.h: Revert.
11755 * expprint.c: Revert.
11756 * exec.h: Revert.
11757 * exec.c: Revert.
11758 * exceptions.c: Revert.
11759 * event-top.c: Revert.
11760 * event-loop.c: Revert.
11761 * eval.c: Revert.
11762 * elfread.c: Revert.
11763 * dwarf2read.h: Revert.
11764 * dwarf2read.c: Revert.
11765 * dwarf2loc.c: Revert.
11766 * dwarf2expr.h: Revert.
11767 * dwarf2expr.c: Revert.
11768 * dwarf2-frame.c: Revert.
11769 * dwarf2-frame-tailcall.c: Revert.
11770 * dwarf-index-write.h: Revert.
11771 * dwarf-index-write.c: Revert.
11772 * dwarf-index-common.c: Revert.
11773 * dwarf-index-cache.h: Revert.
11774 * dwarf-index-cache.c: Revert.
11775 * dummy-frame.c: Revert.
11776 * dtrace-probe.c: Revert.
11777 * disasm.h: Revert.
11778 * disasm.c: Revert.
11779 * disasm-selftests.c: Revert.
11780 * dictionary.c: Revert.
11781 * dicos-tdep.c: Revert.
11782 * demangle.c: Revert.
11783 * dcache.h: Revert.
11784 * dcache.c: Revert.
11785 * darwin-nat.h: Revert.
11786 * darwin-nat.c: Revert.
11787 * darwin-nat-info.c: Revert.
11788 * d-valprint.c: Revert.
11789 * d-namespace.c: Revert.
11790 * d-lang.c: Revert.
11791 * ctf.c: Revert.
11792 * csky-tdep.c: Revert.
11793 * csky-linux-tdep.c: Revert.
11794 * cris-tdep.c: Revert.
11795 * cris-linux-tdep.c: Revert.
11796 * cp-valprint.c: Revert.
11797 * cp-support.c: Revert.
11798 * cp-namespace.c: Revert.
11799 * cp-abi.c: Revert.
11800 * corelow.c: Revert.
11801 * corefile.c: Revert.
11802 * continuations.c: Revert.
11803 * completer.h: Revert.
11804 * completer.c: Revert.
11805 * complaints.c: Revert.
11806 * coffread.c: Revert.
11807 * coff-pe-read.c: Revert.
11808 * cli-out.h: Revert.
11809 * cli-out.c: Revert.
11810 * charset.c: Revert.
11811 * c-varobj.c: Revert.
11812 * c-valprint.c: Revert.
11813 * c-typeprint.c: Revert.
11814 * c-lang.c: Revert.
11815 * buildsym.c: Revert.
11816 * buildsym-legacy.c: Revert.
11817 * build-id.h: Revert.
11818 * build-id.c: Revert.
11819 * btrace.c: Revert.
11820 * bsd-uthread.c: Revert.
11821 * breakpoint.h: Revert.
11822 * breakpoint.c: Revert.
11823 * break-catch-throw.c: Revert.
11824 * break-catch-syscall.c: Revert.
11825 * break-catch-sig.c: Revert.
11826 * blockframe.c: Revert.
11827 * block.c: Revert.
11828 * bfin-tdep.c: Revert.
11829 * bfin-linux-tdep.c: Revert.
11830 * bfd-target.c: Revert.
11831 * bcache.c: Revert.
11832 * ax-general.c: Revert.
11833 * ax-gdb.h: Revert.
11834 * ax-gdb.c: Revert.
11835 * avr-tdep.c: Revert.
11836 * auxv.c: Revert.
11837 * auto-load.c: Revert.
11838 * arm-wince-tdep.c: Revert.
11839 * arm-tdep.c: Revert.
11840 * arm-symbian-tdep.c: Revert.
11841 * arm-pikeos-tdep.c: Revert.
11842 * arm-obsd-tdep.c: Revert.
11843 * arm-nbsd-tdep.c: Revert.
11844 * arm-nbsd-nat.c: Revert.
11845 * arm-linux-tdep.c: Revert.
11846 * arm-linux-nat.c: Revert.
11847 * arm-fbsd-tdep.c: Revert.
11848 * arm-fbsd-nat.c: Revert.
11849 * arm-bsd-tdep.c: Revert.
11850 * arch-utils.c: Revert.
11851 * arc-tdep.c: Revert.
11852 * arc-newlib-tdep.c: Revert.
11853 * annotate.h: Revert.
11854 * annotate.c: Revert.
11855 * amd64-windows-tdep.c: Revert.
11856 * amd64-windows-nat.c: Revert.
11857 * amd64-tdep.c: Revert.
11858 * amd64-sol2-tdep.c: Revert.
11859 * amd64-obsd-tdep.c: Revert.
11860 * amd64-obsd-nat.c: Revert.
11861 * amd64-nbsd-tdep.c: Revert.
11862 * amd64-nbsd-nat.c: Revert.
11863 * amd64-nat.c: Revert.
11864 * amd64-linux-tdep.c: Revert.
11865 * amd64-linux-nat.c: Revert.
11866 * amd64-fbsd-tdep.c: Revert.
11867 * amd64-fbsd-nat.c: Revert.
11868 * amd64-dicos-tdep.c: Revert.
11869 * amd64-darwin-tdep.c: Revert.
11870 * amd64-bsd-nat.c: Revert.
11871 * alpha-tdep.c: Revert.
11872 * alpha-obsd-tdep.c: Revert.
11873 * alpha-nbsd-tdep.c: Revert.
11874 * alpha-mdebug-tdep.c: Revert.
11875 * alpha-linux-tdep.c: Revert.
11876 * alpha-linux-nat.c: Revert.
11877 * alpha-bsd-tdep.c: Revert.
11878 * alpha-bsd-nat.c: Revert.
11879 * aix-thread.c: Revert.
11880 * agent.c: Revert.
11881 * addrmap.c: Revert.
11882 * ada-varobj.c: Revert.
11883 * ada-valprint.c: Revert.
11884 * ada-typeprint.c: Revert.
11885 * ada-tasks.c: Revert.
11886 * ada-lang.c: Revert.
11887 * aarch64-tdep.c: Revert.
11888 * aarch64-ravenscar-thread.c: Revert.
11889 * aarch64-newlib-tdep.c: Revert.
11890 * aarch64-linux-tdep.c: Revert.
11891 * aarch64-linux-nat.c: Revert.
11892 * aarch64-fbsd-tdep.c: Revert.
11893 * aarch64-fbsd-nat.c: Revert.
11894 * aarch32-linux-nat.c: Revert.
11895
11896 2019-04-05 Tom Tromey <tom@tromey.com>
11897
11898 * ft32-tdep.c: Sort headers.
11899 * frv-tdep.c: Sort headers.
11900 * frv-linux-tdep.c: Sort headers.
11901 * frame.c: Sort headers.
11902 * frame-unwind.c: Sort headers.
11903 * frame-base.c: Sort headers.
11904 * fork-child.c: Sort headers.
11905 * findvar.c: Sort headers.
11906 * findcmd.c: Sort headers.
11907 * filesystem.c: Sort headers.
11908 * filename-seen-cache.h: Sort headers.
11909 * filename-seen-cache.c: Sort headers.
11910 * fbsd-tdep.c: Sort headers.
11911 * fbsd-nat.h: Sort headers.
11912 * fbsd-nat.c: Sort headers.
11913 * f-valprint.c: Sort headers.
11914 * f-typeprint.c: Sort headers.
11915 * f-lang.c: Sort headers.
11916 * extension.h: Sort headers.
11917 * extension.c: Sort headers.
11918 * extension-priv.h: Sort headers.
11919 * expprint.c: Sort headers.
11920 * exec.h: Sort headers.
11921 * exec.c: Sort headers.
11922 * exceptions.c: Sort headers.
11923 * event-top.c: Sort headers.
11924 * event-loop.c: Sort headers.
11925 * eval.c: Sort headers.
11926 * elfread.c: Sort headers.
11927 * dwarf2read.h: Sort headers.
11928 * dwarf2read.c: Sort headers.
11929 * dwarf2loc.c: Sort headers.
11930 * dwarf2expr.h: Sort headers.
11931 * dwarf2expr.c: Sort headers.
11932 * dwarf2-frame.c: Sort headers.
11933 * dwarf2-frame-tailcall.c: Sort headers.
11934 * dwarf-index-write.h: Sort headers.
11935 * dwarf-index-write.c: Sort headers.
11936 * dwarf-index-common.c: Sort headers.
11937 * dwarf-index-cache.h: Sort headers.
11938 * dwarf-index-cache.c: Sort headers.
11939 * dummy-frame.c: Sort headers.
11940 * dtrace-probe.c: Sort headers.
11941 * disasm.h: Sort headers.
11942 * disasm.c: Sort headers.
11943 * disasm-selftests.c: Sort headers.
11944 * dictionary.c: Sort headers.
11945 * dicos-tdep.c: Sort headers.
11946 * demangle.c: Sort headers.
11947 * dcache.h: Sort headers.
11948 * dcache.c: Sort headers.
11949 * darwin-nat.h: Sort headers.
11950 * darwin-nat.c: Sort headers.
11951 * darwin-nat-info.c: Sort headers.
11952 * d-valprint.c: Sort headers.
11953 * d-namespace.c: Sort headers.
11954 * d-lang.c: Sort headers.
11955 * ctf.c: Sort headers.
11956 * csky-tdep.c: Sort headers.
11957 * csky-linux-tdep.c: Sort headers.
11958 * cris-tdep.c: Sort headers.
11959 * cris-linux-tdep.c: Sort headers.
11960 * cp-valprint.c: Sort headers.
11961 * cp-support.c: Sort headers.
11962 * cp-namespace.c: Sort headers.
11963 * cp-abi.c: Sort headers.
11964 * corelow.c: Sort headers.
11965 * corefile.c: Sort headers.
11966 * continuations.c: Sort headers.
11967 * completer.h: Sort headers.
11968 * completer.c: Sort headers.
11969 * complaints.c: Sort headers.
11970 * coffread.c: Sort headers.
11971 * coff-pe-read.c: Sort headers.
11972 * cli-out.h: Sort headers.
11973 * cli-out.c: Sort headers.
11974 * charset.c: Sort headers.
11975 * c-varobj.c: Sort headers.
11976 * c-valprint.c: Sort headers.
11977 * c-typeprint.c: Sort headers.
11978 * c-lang.c: Sort headers.
11979 * buildsym.c: Sort headers.
11980 * buildsym-legacy.c: Sort headers.
11981 * build-id.h: Sort headers.
11982 * build-id.c: Sort headers.
11983 * btrace.c: Sort headers.
11984 * bsd-uthread.c: Sort headers.
11985 * breakpoint.h: Sort headers.
11986 * breakpoint.c: Sort headers.
11987 * break-catch-throw.c: Sort headers.
11988 * break-catch-syscall.c: Sort headers.
11989 * break-catch-sig.c: Sort headers.
11990 * blockframe.c: Sort headers.
11991 * block.c: Sort headers.
11992 * bfin-tdep.c: Sort headers.
11993 * bfin-linux-tdep.c: Sort headers.
11994 * bfd-target.c: Sort headers.
11995 * bcache.c: Sort headers.
11996 * ax-general.c: Sort headers.
11997 * ax-gdb.h: Sort headers.
11998 * ax-gdb.c: Sort headers.
11999 * avr-tdep.c: Sort headers.
12000 * auxv.c: Sort headers.
12001 * auto-load.c: Sort headers.
12002 * arm-wince-tdep.c: Sort headers.
12003 * arm-tdep.c: Sort headers.
12004 * arm-symbian-tdep.c: Sort headers.
12005 * arm-pikeos-tdep.c: Sort headers.
12006 * arm-obsd-tdep.c: Sort headers.
12007 * arm-nbsd-tdep.c: Sort headers.
12008 * arm-nbsd-nat.c: Sort headers.
12009 * arm-linux-tdep.c: Sort headers.
12010 * arm-linux-nat.c: Sort headers.
12011 * arm-fbsd-tdep.c: Sort headers.
12012 * arm-fbsd-nat.c: Sort headers.
12013 * arm-bsd-tdep.c: Sort headers.
12014 * arch-utils.c: Sort headers.
12015 * arc-tdep.c: Sort headers.
12016 * arc-newlib-tdep.c: Sort headers.
12017 * annotate.h: Sort headers.
12018 * annotate.c: Sort headers.
12019 * amd64-windows-tdep.c: Sort headers.
12020 * amd64-windows-nat.c: Sort headers.
12021 * amd64-tdep.c: Sort headers.
12022 * amd64-sol2-tdep.c: Sort headers.
12023 * amd64-obsd-tdep.c: Sort headers.
12024 * amd64-obsd-nat.c: Sort headers.
12025 * amd64-nbsd-tdep.c: Sort headers.
12026 * amd64-nbsd-nat.c: Sort headers.
12027 * amd64-nat.c: Sort headers.
12028 * amd64-linux-tdep.c: Sort headers.
12029 * amd64-linux-nat.c: Sort headers.
12030 * amd64-fbsd-tdep.c: Sort headers.
12031 * amd64-fbsd-nat.c: Sort headers.
12032 * amd64-dicos-tdep.c: Sort headers.
12033 * amd64-darwin-tdep.c: Sort headers.
12034 * amd64-bsd-nat.c: Sort headers.
12035 * alpha-tdep.c: Sort headers.
12036 * alpha-obsd-tdep.c: Sort headers.
12037 * alpha-nbsd-tdep.c: Sort headers.
12038 * alpha-mdebug-tdep.c: Sort headers.
12039 * alpha-linux-tdep.c: Sort headers.
12040 * alpha-linux-nat.c: Sort headers.
12041 * alpha-bsd-tdep.c: Sort headers.
12042 * alpha-bsd-nat.c: Sort headers.
12043 * aix-thread.c: Sort headers.
12044 * agent.c: Sort headers.
12045 * addrmap.c: Sort headers.
12046 * ada-varobj.c: Sort headers.
12047 * ada-valprint.c: Sort headers.
12048 * ada-typeprint.c: Sort headers.
12049 * ada-tasks.c: Sort headers.
12050 * ada-lang.c: Sort headers.
12051 * aarch64-tdep.c: Sort headers.
12052 * aarch64-ravenscar-thread.c: Sort headers.
12053 * aarch64-newlib-tdep.c: Sort headers.
12054 * aarch64-linux-tdep.c: Sort headers.
12055 * aarch64-linux-nat.c: Sort headers.
12056 * aarch64-fbsd-tdep.c: Sort headers.
12057 * aarch64-fbsd-nat.c: Sort headers.
12058 * aarch32-linux-nat.c: Sort headers.
12059
12060 2019-04-04 Tom Tromey <tom@tromey.com>
12061
12062 * varobj.c (varobj_create): Update.
12063 * rust-exp.y (struct rust_parser) <update_innermost_block,
12064 lookup_symbol>: New methods.
12065 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12066 Rename.
12067 (rust_parser::rust_lookup_type)
12068 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12069 * printcmd.c (display_command, do_one_display): Update.
12070 * parser-defs.h (struct parser_state) <parser_state>: Add
12071 "tracker" parameter.
12072 (block_tracker): New member.
12073 (class innermost_block_tracker) <innermost_block_tracker>: Add
12074 "types" parameter.
12075 <reset>: Remove method.
12076 (innermost_block): Don't declare.
12077 (null_post_parser): Update.
12078 * parse.c (innermost_block): Remove global.
12079 (write_dollar_variable): Update.
12080 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12081 Remove "tracker_types" parameter.
12082 (parse_expression): Add "tracker" parameter.
12083 (parse_expression_for_completion): Update.
12084 (null_post_parser): Add "tracker" parameter.
12085 * p-exp.y: Update rules.
12086 * m2-exp.y: Update rules.
12087 * language.h (struct language_defn) <la_post_parser>: Add
12088 "tracker" parameter.
12089 * go-exp.y: Update rules.
12090 * f-exp.y: Update rules.
12091 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12092 parameter.
12093 * d-exp.y: Update rules.
12094 * c-exp.y: Update rules.
12095 * breakpoint.c (set_breakpoint_condition): Create an
12096 innermost_block_tracker.
12097 (watch_command_1): Likewise.
12098 * ada-lang.c (resolve): Add "tracker" parameter.
12099 (resolve_subexp): Likewise.
12100 * ada-exp.y (write_var_from_sym): Update.
12101
12102 2019-04-04 Tom Tromey <tom@tromey.com>
12103
12104 * type-stack.h: New file.
12105 * type-stack.c: New file.
12106 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12107 type-stack.h.
12108 (insert_into_type_stack, insert_type, push_type, push_type_int)
12109 (insert_type_address_space, pop_type, pop_type_int)
12110 (pop_typelist, pop_type_stack, append_type_stack)
12111 (push_type_stack, get_type_stack, push_typelist)
12112 (follow_type_instance_flags, follow_types): Don't declare.
12113 * parse.c (type_stack): Remove global.
12114 (parse_exp_in_context): Update.
12115 (insert_into_type_stack, insert_type, push_type, push_type_int)
12116 (insert_type_address_space, pop_type, pop_type_int)
12117 (pop_typelist, pop_type_stack, append_type_stack)
12118 (push_type_stack, get_type_stack, push_typelist)
12119 (follow_type_instance_flags, follow_types): Remove (moved to
12120 type-stack.c).
12121 * f-exp.y (type_stack): New global.
12122 Update rules.
12123 (push_kind_type, f_parse): Update.
12124 * d-exp.y (type_stack): New global.
12125 Update rules.
12126 (d_parse): Update.
12127 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12128 Update rules.
12129 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12130 (HFILES_NO_SRCDIR): Add type-stack.h.
12131
12132 2019-04-04 Tom Tromey <tom@tromey.com>
12133
12134 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12135 (rust_parser::convert_ast_to_expression, rust_parse)
12136 (rust_lex_test_completion, rust_lex_tests): Update.
12137 * parser-defs.h (struct expr_completion_state): New.
12138 (struct parser_state) <parser_state>: Add completion parameter.
12139 <mark_struct_expression, mark_completion_tag>: New methods.
12140 <parse_completion, m_completion_state>: New members.
12141 (prefixify_expression, null_post_parser): Update.
12142 (mark_struct_expression, mark_completion_tag): Don't declare.
12143 * parse.c (parse_completion, expout_last_struct)
12144 (expout_tag_completion_type, expout_completion_name): Remove
12145 globals.
12146 (parser_state::mark_struct_expression)
12147 (parser_state::mark_completion_tag): Now methods.
12148 (prefixify_expression): Add last_struct parameter.
12149 (prefixify_subexp): Likewise.
12150 (parse_exp_1): Update.
12151 (parse_exp_in_context): Add cstate parameter. Update.
12152 (parse_expression_for_completion): Create an
12153 expr_completion_state.
12154 (null_post_parser): Add "completion" parameter.
12155 * p-exp.y: Update rules.
12156 (yylex): Update.
12157 * language.h (struct language_defn) <la_post_parser>: Add
12158 "completing" parameter.
12159 * go-exp.y: Update rules.
12160 (lex_one_token): Update.
12161 * expression.h (parse_completion): Don't declare.
12162 * d-exp.y: Update rules.
12163 (lex_one_token): Update rules.
12164 * c-exp.y: Update rules.
12165 (lex_one_token): Update.
12166 * ada-lang.c (resolve): Add "parse_completion" parameter.
12167 (resolve_subexp): Likewise.
12168 (ada_resolve_function): Likewise.
12169
12170 2019-04-04 Tom Tromey <tom@tromey.com>
12171
12172 * parser-defs.h (struct parser_state) <start_arglist,
12173 end_arglist>: New methods.
12174 <arglist_len, m_funcall_chain>: New members.
12175 (arglist_len, start_arglist, end_arglist): Don't declare.
12176 * parse.c (arglist_len, funcall_chain): Remove global.
12177 (start_arglist, end_arglist): Remove functions.
12178 (parse_exp_in_context): Update.
12179 * p-exp.y: Update rules.
12180 * m2-exp.y: Update rules.
12181 * go-exp.y: Update rules.
12182 * f-exp.y: Update rules.
12183 * d-exp.y: Update rules.
12184 * c-exp.y: Update rules.
12185
12186 2019-04-04 Tom Tromey <tom@tromey.com>
12187
12188 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12189 lex_operator, push_back>: New methods.
12190 Update all rules.
12191 (rust_parser::lex_hex, lex_escape): Rename and update.
12192 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12193 (rust_parser::lex_operator): Rename and update.
12194 (rust_parser::lex_number, rustyylex, rustyyerror)
12195 (rust_lex_test_init, rust_lex_test_sequence)
12196 (rust_lex_test_push_back, rust_lex_tests): Update.
12197 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12198 parameter.
12199 <lexptr, prev_lexptr>: New members.
12200 (lexptr, prev_lexptr): Don't declare.
12201 * parse.c (lexptr, prev_lexptr): Remove globals.
12202 (parse_exp_in_context): Update.
12203 * p-exp.y (yylex, yyerror): Update.
12204 * m2-exp.y (parse_number, yylex, yyerror): Update.
12205 * go-exp.y (lex_one_token, yyerror): Update.
12206 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12207 * d-exp.y (lex_one_token, yyerror): Update.
12208 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12209 (lex_one_token, yyerror): Update.
12210 * ada-lex.l (YY_INPUT): Update.
12211 (rewind_to_char): Update.
12212 * ada-exp.y (yyerror): Update.
12213
12214 2019-04-04 Tom Tromey <tom@tromey.com>
12215
12216 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12217 * parser-defs.h (struct parser_state) <parser_state>: Add new
12218 parameter.
12219 <comma_terminates>: New member.
12220 (comma_terminates): Don't declare global.
12221 * parse.c (comma_terminates): Remove global.
12222 (parse_exp_in_context): Update.
12223 * p-exp.y (yylex): Update.
12224 * m2-exp.y (yylex): Update.
12225 * go-exp.y (lex_one_token): Update.
12226 * f-exp.y (yylex): Update.
12227 * d-exp.y (lex_one_token): Update.
12228 * c-exp.y (lex_one_token): Update.
12229 * ada-lex.l: Update.
12230
12231 2019-04-04 Tom Tromey <tom@tromey.com>
12232
12233 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12234 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12235 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12236 * parser-defs.h (paren_depth): Don't declare.
12237 * parse.c (paren_depth): Remove global.
12238 (parse_exp_in_context): Update.
12239 * p-exp.y (paren_depth): New global.
12240 (pascal_parse): Initialize it.
12241 * m2-exp.y (paren_depth): New global.
12242 (m2_parse): Initialize it.
12243 * go-exp.y (paren_depth): New global.
12244 (go_parse): Initialize it.
12245 * f-exp.y (paren_depth): New global.
12246 (f_parse): Initialize it.
12247 * d-exp.y (paren_depth): New global.
12248 (d_parse): Initialize it.
12249 * c-exp.y (paren_depth): New global.
12250 (c_parse): Initialize it.
12251 * ada-lex.l (paren_depth): New global.
12252 (lexer_init): Initialize it.
12253
12254 2019-04-04 Tom Tromey <tom@tromey.com>
12255
12256 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12257 (rust_parser::convert_ast_to_type)
12258 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12259 * parser-defs.h (struct parser_state) <parser_state>: Add
12260 parameters. Initialize new members.
12261 <expression_context_block, expression_context_pc>: New members.
12262 * parse.c (expression_context_block, expression_context_pc):
12263 Remove globals.
12264 (parse_exp_in_context): Update.
12265 * p-exp.y: Update all rules.
12266 (yylex): Update.
12267 * m2-exp.y: Update all rules.
12268 (yylex): Update.
12269 * go-exp.y (yylex): Update.
12270 * f-exp.y (yylex): Update.
12271 * d-exp.y: Update all rules.
12272 (yylex): Update.
12273 * c-exp.y: Update all rules.
12274 (lex_one_token, classify_name, yylex, c_parse): Update.
12275 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12276
12277 2019-04-04 Tom Tromey <tom@tromey.com>
12278
12279 * gdbarch.h, gdbarch.c: Rebuild.
12280 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12281 * stap-probe.h:
12282 (struct stap_parse_info): Replace "parser_state" with
12283 "expr_builder".
12284 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12285 (parser_state): New class.
12286 * parse.c (expr_builder): Rename.
12287 (expr_builder::release): Rename.
12288 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12289 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12290 (write_exp_elt_longcst, write_exp_elt_floatcst)
12291 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12292 (write_exp_string_vector, write_exp_bitstring)
12293 (write_exp_msymbol, mark_struct_expression)
12294 (write_dollar_variable)
12295 (insert_type_address_space, increase_expout_size): Replace
12296 "parser_state" with "expr_builder".
12297 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12298 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12299 "parser_state" with "expr_builder".
12300
12301 2019-04-04 Tom Tromey <tom@tromey.com>
12302
12303 * rust-exp.y: Replace "parse_language" with method call.
12304 * p-exp.y:
12305 (yylex): Replace "parse_language" with method call.
12306 * m2-exp.y:
12307 (yylex): Replace "parse_language" with method call.
12308 * go-exp.y (classify_name): Replace "parse_language" with method
12309 call.
12310 * f-exp.y (yylex): Replace "parse_language" with method call.
12311 * d-exp.y (lex_one_token): Replace "parse_language" with method
12312 call.
12313 * c-exp.y:
12314 (lex_one_token, classify_name, yylex): Replace "parse_language"
12315 with method call.
12316 * ada-exp.y (find_primitive_type, type_char)
12317 (type_system_address): Replace "parse_language" with method call.
12318
12319 2019-04-04 Tom Tromey <tom@tromey.com>
12320
12321 * rust-exp.y: Replace "parse_gdbarch" with method call.
12322 * parse.c (write_dollar_variable, insert_type_address_space):
12323 Replace "parse_gdbarch" with method call.
12324 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12325 call.
12326 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12327 call.
12328 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12329 "parse_gdbarch" with method call.
12330 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12331 with method call.
12332 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12333 "parse_gdbarch" with method call.
12334 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12335 "parse_gdbarch" with method call.
12336 * c-exp.y (parse_type, parse_number, classify_name): Replace
12337 "parse_gdbarch" with method call.
12338 * ada-lex.l: Replace "parse_gdbarch" with method call.
12339 * ada-exp.y (parse_type, find_primitive_type, type_char)
12340 (type_system_address): Replace "parse_gdbarch" with method call.
12341
12342 2019-04-04 Tom Tromey <tom@tromey.com>
12343
12344 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12345 * stap-probe.c (stap_parse_argument): Update.
12346 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12347 initial_size parameter.
12348 * rust-exp.y (rust_lex_tests): Update.
12349 * parse.c (parser_state): Update.
12350 (parse_exp_in_context): Update.
12351 * parser-defs.h (struct parser_state) <parser_state>: Remove
12352 "initial_size" parameter.
12353
12354 2019-04-04 Tom Tromey <tom@tromey.com>
12355
12356 * parser-defs.h (increase_expout_size): Don't declare.
12357 * parse.c (increase_expout_size): Now static.
12358
12359 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12360
12361 * gnu-nat.c (gnu_nat_target::wait): Fix
12362 target_waitstatus_to_string call.
12363
12364 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12365
12366 * eval.c (evaluate_subexp_standard): Handle internal functions
12367 during Fortran function call handling.
12368
12369 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12370
12371 * NEWS: Mention new internal functions.
12372 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12373 (read_base_type): Use dwarf2_init_complex_target_type.
12374 * value.c (creal_internal_fn): New function.
12375 (cimag_internal_fn): New function.
12376 (_initialize_values): Register new internal functions.
12377
12378 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12379
12380 * infrun.c (stop_all_threads): If debug_infrun, always
12381 trace the wait status after wait_one, using
12382 target_waitstatus_to_string and target_pid_to_str.
12383 (handle_inferior_event): Replace various trace of
12384 wait status kind by a single trace.
12385 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12386 wait status kind image by target_waitstatus_to_string.
12387 * target/waitstatus.c (target_waitstatus_to_string): Fix
12388 obsolete comment.
12389
12390 2019-04-01 Tom Tromey <tromey@adacore.com>
12391
12392 PR symtab/23331:
12393 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12394
12395 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12396 Pedro Alves <palves@redhat.com>
12397
12398 * top.c (quit_force): Call 'finalize_values'.
12399 * value.c (finalize_values): New function.
12400 * value.h (finalize_values): Declare.
12401
12402 2019-03-30 Eli Zaretskii <eliz@gnu.org>
12403
12404 * NEWS: Announce $_gdb_major and $_gdb_minor.
12405
12406 * top.c (init_gdb_version_vars): New function.
12407 (gdb_init): Call init_gdb_version_vars.
12408
12409 2019-03-29 Tom Tromey <tromey@adacore.com>
12410
12411 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12412 help text. Remove dead code.
12413
12414 2019-03-29 Keith Seitz <keiths@redhat.com>
12415
12416 From Siddhesh Poyarekar:
12417 * f-lang.h (f77_get_upperbound): Return LONGEST.
12418 (f77_get_lowerbound): Likewise.
12419 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12420 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12421 print them.
12422 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12423 plongest to format print it.
12424 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12425 (f77_get_upperbound): Likewise.
12426 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12427 LOWER_BOUND to LONGEST.
12428 (f77_create_arrayprint_offset_tbl): Likewise.
12429
12430 2019-03-29 Keith Seitz <keiths@redhat.com>
12431
12432 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12433 %s/pulongest for TYPE_LENGTH instead of %d in format
12434 strings.
12435 * ada-typerint.c (ada_print_type): Likewise.
12436 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12437 * compile/compile-c-support.c (generate_register_struct): Likewise.
12438 * gdbtypes.c (recursive_dump_type): Likewise.
12439 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12440 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12441 instead of %d in format strings.
12442 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12443 to std::min to ULONGEST.
12444 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12445 instead of %d in format strings.
12446 * tracepoint.c (info_scope_command): Likewise.
12447 * typeprint.c (print_offset_data::update)
12448 (print_offset_data::finish): Likewise.
12449 * xtensa-tdep.c (xtensa_store_return_value)
12450 (xtensa_push_dummy_call): Likewise.
12451
12452 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12453
12454 * windows-nat.c (display_selector): Fixed format specifications
12455 for 64-bit Cygwin.
12456
12457 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12458
12459 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12460
12461 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12462
12463 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12464 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12465 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12466 (nios2_linux_init_abi): Install it.
12467
12468 2019-03-28 Alan Hayward <alan.hayward@arm.com>
12469
12470 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12471
12472 2019-03-28 Alan Hayward <alan.hayward@arm.com>
12473
12474 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12475
12476 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12477 Tom Tromey <tromey@adacore.com>
12478
12479 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12480
12481 2019-03-26 Joel Brobecker <brobecker@adacore.com>
12482
12483 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12484 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12485 method to compute the bounds of range types. Also print "[evaluated]"
12486 if the bounds' values come from a dynamic evaluation.
12487
12488 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12489
12490 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12491 whitespace when pretty printing is on.
12492
12493 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12494
12495 * ppc-linux-nat.c: Add include.
12496
12497 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12498
12499 * NEWS: Mention AArch64 Pointer Authentication.
12500
12501 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12502
12503 * arm-linux-nat.c: Add include.
12504
12505 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12506
12507 * source-cache.c (source_cache::get_source_lines): Re-read
12508 fullname after calling open_source_file.
12509
12510 2019-03-25 John Baldwin <jhb@FreeBSD.org>
12511
12512 * NEWS: Mention TLS support for FreeBSD.
12513
12514 2019-03-25 Tom Tromey <tromey@adacore.com>
12515
12516 * minsyms.c (BUNCH_SIZE): Update comment.
12517 (~minimal_symbol_reader): Remove old comment.
12518 (compact_minimal_symbols): Update comment.
12519 (minimal_symbol_reader::install): Remove old comment. Update
12520 other comments.
12521
12522 2019-03-25 Alan Hayward <alan.hayward@arm.com>
12523
12524 * s390-linux-nat.c: Add include.
12525
12526 2019-03-25 Alan Hayward <alan.hayward@arm.com>
12527
12528 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12529 Call linux_get_hwcap.
12530 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12531 Likewise.
12532 (aarch64_linux_get_hwcap): Remove function.
12533 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12534 declaration.
12535 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12536 linux_get_hwcap.
12537 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12538 * linux-tdep.c (linux_get_hwcap): Add function.
12539 (linux_get_hwcap2): Likewise.
12540 * linux-tdep.h (linux_get_hwcap): Add declaration.
12541 (linux_get_hwcap2): Likewise.
12542 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12543 (ppc_linux_get_hwcap2): Likewise.
12544 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12545 linux_get_hwcap.
12546 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12547 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12548 (ppc_linux_nat_target::read_description): Likewise.
12549 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12550 * s390-linux-nat.c: Likewise.
12551 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12552
12553 2019-03-24 Tom Tromey <tom@tromey.com>
12554
12555 * ada-lang.c (standard_lookup): Simplify initialization.
12556 (ada_lookup_symbol_nonlocal): Simplify return.
12557 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12558 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12559 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12560 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12561 initialization.
12562 * solib.c (solib_global_lookup): Simplify.
12563 * symtab.c (null_block_symbol): Remove.
12564 (symbol_cache_lookup): Simplify returns.
12565 (lookup_language_this): Simplify returns.
12566 (lookup_symbol_aux): Simplify return.
12567 (lookup_local_symbol): Simplify returns.
12568 (lookup_global_symbol_from_objfile): Simplify return.
12569 (lookup_symbol_in_objfile_symtabs)
12570 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12571 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12572 (lookup_static_symbol, lookup_global_symbol): Simplify return.
12573 * cp-namespace.c (cp_lookup_bare_symbol)
12574 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12575 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12576 (cp_lookup_nested_symbol): Don't use null_block_symbol.
12577 (cp_lookup_symbol_via_imports): Simplify initialization.
12578 (find_symbol_in_baseclass): Likewise.
12579 * symtab.h (null_block_symbol): Remove.
12580 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12581 (d_lookup_nested_symbol, d_lookup_symbol_imports)
12582 (d_lookup_symbol_module): Likewise.
12583 (find_symbol_in_baseclass): Simplify initialization.
12584
12585 2019-03-24 Tom Tromey <tom@tromey.com>
12586
12587 * expression.h: Don't include symtab.h.
12588 (struct block): Forward declare.
12589
12590 2019-03-24 Tom Tromey <tom@tromey.com>
12591
12592 * c-exp.y (typebase): Remove casts.
12593 * gdbtypes.c (lookup_unsigned_typename, )
12594 (lookup_signed_typename): Remove cast.
12595 * eval.c (parse_to_comma_and_eval): Remove cast.
12596 * parse.c (write_dollar_variable): Remove cast.
12597 * block.h (struct block) <superblock>: Now const.
12598 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12599 * psymtab.c (psym_map_matching_symbols): Make "block" const.
12600 (map_block): Make "block" const.
12601 * symfile.h (struct quick_symbol_functions)
12602 <map_matching_symbols>: Constify block argument to "callback".
12603 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12604 const.
12605 (find_pc_sect_compunit_symtab): Make "b" const.
12606 (find_symbol_at_address): Likewise.
12607 (search_symbols): Likewise.
12608 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12609 (dw2_debug_names_lookup_symbol): Likewise.
12610 (dw2_map_matching_symbols): Update.
12611 * p-valprint.c (pascal_val_print): Remove "block".
12612 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12613 (aux_add_nonlocal_symbols): Make "block" const.
12614 (resolve_subexp): Remove cast.
12615 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12616 const.
12617 (iterate_over_file_blocks): Likewise.
12618 * f-exp.y (%union) <bval>: Remove.
12619 * coffread.c (patch_opaque_types): Make "b" const.
12620 * spu-tdep.c (spu_catch_start): Make "block" const.
12621 * c-valprint.c (print_unpacked_pointer): Remove "block".
12622 * symmisc.c (dump_symtab_1): Make "b" const.
12623 (block_depth): Make "block" const.
12624 * d-exp.y (%union) <bval>: Remove.
12625 * cp-support.h (cp_lookup_rtti_type): Update.
12626 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12627 * psymtab.c (psym_lookup_symbol): Make "block" const.
12628 (maintenance_check_psymtabs): Make "b" const.
12629 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12630 (enumerate_locals, enumerate_args): Update.
12631 * python/py-symtab.c (stpy_global_block): Make "block" const.
12632 (stpy_static_block): Likewise.
12633 * inline-frame.c (block_starting_point_at): Make "new_block"
12634 const.
12635 * block.c (find_block_in_blockvector): Make return type const.
12636 (blockvector_for_pc_sect): Make "b" const.
12637 (find_block_in_blockvector): Make "b" const.
12638
12639 2019-03-23 Tom Tromey <tom@tromey.com>
12640
12641 * varobj.c (varobj_create): Update.
12642 * symfile.c (clear_symtab_users): Don't reset innermost_block.
12643 * printcmd.c (display_command, do_one_display): Don't reset
12644 innermost_block.
12645 * parser-defs.h (enum innermost_block_tracker_type): Move to
12646 expression.h.
12647 (innermost_block): Update comment.
12648 * parse.c (parse_exp_1): Add tracker_types parameter.
12649 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
12650 tracker_types parameter. Reset innermost_block.
12651 (parse_exp_in_context): Remove.
12652 (parse_expression_for_completion): Update.
12653 * objfiles.c (~objfile): Don't reset expression_context_block or
12654 innermost_block.
12655 * expression.h (enum innermost_block_tracker_type): Move from
12656 parser-defs.h.
12657 (parse_exp_1): Add tracker_types parameter.
12658 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12659 reset innermost_block.
12660
12661 2019-03-23 Tom Tromey <tom@tromey.com>
12662
12663 * objfiles.h: Include bcache.h.
12664
12665 2019-03-23 Tom Tromey <tom@tromey.com>
12666
12667 * linespec.c (get_current_search_block): Use
12668 scoped_restore_current_language.
12669 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12670
12671 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12672 Jiong Wang <jiong.wang@arm.com>
12673
12674 * aarch64-linux-tdep.c
12675 (aarch64_linux_iterate_over_regset_sections): Check for pauth
12676 section.
12677 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12678
12679 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12680 Jiong Wang <jiong.wang@arm.com>
12681
12682 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12683 instructions.
12684 (aarch64_analyze_prologue_test): Add PACIASP test.
12685 (aarch64_prologue_prev_register): Unmask PC value.
12686
12687 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12688 Jiong Wang <jiong.wang@arm.com>
12689
12690 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12691 (aarch64_dwarf2_prev_register): Unmask PC value.
12692 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12693 (aarch64_execute_dwarf_cfa_vendor_op): Check for
12694 DW_CFA_AARCH64_negate_ra_state.
12695 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12696
12697 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12698 Jiong Wang <jiong.wang@arm.com>
12699
12700 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12701 registers.
12702 (aarch64_pseudo_register_name): Likewise.
12703 (aarch64_pseudo_register_type): Likewise.
12704 (aarch64_pseudo_register_reggroup_p): Likewise.
12705 (aarch64_gdbarch_init): Add pauth registers.
12706 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12707 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12708 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12709 (struct gdbarch_tdep): Add regnum for ra_state.
12710
12711 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12712 Jiong Wang <jiong.wang@arm.com>
12713
12714 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12715
12716 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12717 Jiong Wang <jiong.wang@arm.com>
12718
12719 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12720 function.
12721 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12722 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12723 (aarch64_gdbarch_init): Add puth registers.
12724 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12725 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12726 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12727
12728 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12729 Jiong Wang <jiong.wang@arm.com>
12730
12731 * aarch64-linux-nat.c
12732 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12733 * aarch64-linux-tdep.c
12734 (aarch64_linux_core_read_description): Likewise.
12735 (aarch64_linux_get_hwcap): New function.
12736 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12737 (aarch64_linux_get_hwcap): New declaration.
12738
12739 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12740 Jiong Wang <jiong.wang@arm.com>
12741
12742 * aarch64-linux-nat.c
12743 (aarch64_linux_nat_target::read_description): Add pauth param.
12744 * aarch64-linux-tdep.c
12745 (aarch64_linux_core_read_description): Likewise.
12746 * aarch64-tdep.c (struct target_desc): Add in pauth.
12747 (aarch64_read_description): Add pauth param.
12748 (aarch64_gdbarch_init): Likewise.
12749 * aarch64-tdep.h (aarch64_read_description): Likewise.
12750 * arch/aarch64.c (aarch64_create_target_description): Likewise.
12751 * arch/aarch64.h (aarch64_create_target_description): Likewise.
12752 * features/Makefile: Add new files.
12753 * features/aarch64-pauth.c: New file.
12754 * features/aarch64-pauth.xml: New file.
12755
12756 2019-03-20 Tom Tromey <tromey@adacore.com>
12757
12758 * infrun.c (handle_inferior_event): Rename from
12759 handle_inferior_event_1. Create a scoped_value_mark.
12760 (handle_inferior_event): Remove.
12761
12762 2019-03-19 Tom Tromey <tromey@adacore.com>
12763
12764 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12765 * infrun.h (print_stop_event): Add "displays" parameter.
12766 * infrun.c (print_stop_event): Add "displays" parameter.
12767
12768 2019-03-19 Pedro Alves <palves@redhat.com>
12769
12770 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12771 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
12772 to -1. Fix TABs vs spaces.
12773 (tui_ui_out::tui_ui_out): Don't initialize fields here.
12774 * tui/tui-out.h (tui_ui_out) Add intro comments.
12775 <m_line, m_start_of_line>: In-class initialize, and add describing
12776 comment.
12777
12778 2019-03-18 Alan Hayward <alan.hayward@arm.com>
12779
12780 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12781 variable names.
12782 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12783
12784 2019-03-18 Pedro Alves <palves@redhat.com>
12785 Eli Zaretskii <eliz@gnu.org>
12786
12787 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12788 m_line and m_start_of_line.
12789
12790 2019-03-18 Eli Zaretskii <eliz@gnu.org>
12791
12792 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12793 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12794 it returns a newline. This fixes a regression in TU mode, whereby
12795 the next line is output on the same screen line as the user input.
12796
12797 2019-03-18 Tom Tromey <tromey@adacore.com>
12798
12799 * minsyms.c (minimal_symbol_reader::install): Remove call to
12800 obstack_blank.
12801
12802 2019-03-18 Pedro Alves <palves@redhat.com>
12803
12804 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12805 New globals.
12806 (apply_style): New, factored out from ...
12807 (apply_ansi_escape): ... this. Handle reverse video mode.
12808 (tui_set_reverse_mode): New function.
12809 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12810 * tui/tui-winsource.c (tui_show_source_line): Use
12811 tui_set_reverse_mode instead of setting A_STANDOUT.
12812 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12813 New setter methods.
12814
12815 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
12816
12817 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12818 Handle tabs.
12819
12820 2019-03-18 Tom Tromey <tromey@adacore.com>
12821
12822 * ada-lang.c (empty_array): Add "high" parameter.
12823 (ada_evaluate_subexp): Update.
12824
12825 2019-03-17 Sergei Trofimovich <siarheit@google.com>
12826
12827 * unittests/string_view-selftests.c: Define
12828 _initialize_string_view_selftests unconditionally.
12829
12830 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12831
12832 PR gdb/24350
12833 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12834
12835 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12836
12837 PR gdb/24351
12838 * windows-nat.c (display_selector): Fix format specifiers.
12839
12840 2019-03-17 Eli Zaretskii <eliz@gnu.org>
12841
12842 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12843 tui_refill_source_window instead of tui_refresh_win, to update the
12844 current execution line. This fixes redisplay of the current line
12845 when stepping through the code with "next" or "step".
12846
12847 2019-03-16 Eli Zaretskii <eliz@gnu.org>
12848
12849 * source-cache.c (source_cache::get_source_lines): Call
12850 find_source_lines to initialize s->nlines. This fixes vertical
12851 scrolling of TUI source window when the DOWN arrow is pressed.
12852
12853 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12854
12855 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12856 linux-thread-db.c (_initialize_thread_db): Likewise.
12857
12858 2019-03-16 Eli Zaretskii <eliz@gnu.org>
12859
12860 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12861 wclrtoeol in tui_show_source_line". This reverts changes made in
12862 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12863
12864 2019-03-15 Tom Tromey <tom@tromey.com>
12865
12866 * symtab.h (struct minimal_symbol): Derive from
12867 general_symbol_info.
12868 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12869 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12870 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12871 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12872 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12873 (MSYMBOL_SEARCH_NAME): Update.
12874 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12875 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12876 * minsyms.c (minimal_symbol_reader::record_full): Update.
12877
12878 2019-03-15 Tom Tromey <tom@tromey.com>
12879
12880 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12881
12882 2019-03-15 Tom Tromey <tom@tromey.com>
12883
12884 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12885 unique_xmalloc_ptr.
12886 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12887 Update.
12888 * minsyms.c (lookup_minimal_symbol_by_pc_section)
12889 (build_minimal_symbol_hash_tables)
12890 (minimal_symbol_reader::install): Update.
12891
12892 2019-03-15 Tom Tromey <tom@tromey.com>
12893
12894 * symtab.c (create_demangled_names_hash): Update.
12895 (symbol_set_names): Update.
12896 * objfiles.h (struct objfile_per_bfd_storage)
12897 <demangled_names_hash>: Now an htab_up.
12898 * objfiles.c (objfile_per_bfd_storage): Simplify.
12899
12900 2019-03-15 Tom Tromey <tom@tromey.com>
12901
12902 * objfiles.h (struct objfile_per_bfd_storage): Declare
12903 destructor.
12904 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12905 New.
12906 (get_objfile_bfd_data): Use new. Don't initialize
12907 language_of_main.
12908 (free_objfile_per_bfd_storage): Remove.
12909 (objfile_bfd_data_free, objfile::~objfile): Use delete.
12910
12911 2019-03-15 Tom Tromey <tom@tromey.com>
12912
12913 * symfile.c (reread_symbols): Update.
12914 * objfiles.c (objfile::objfile): Update.
12915 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
12916 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
12917 comment.
12918 (minimal_symbol_reader::install): Update.
12919 (terminate_minimal_symbol_table): Remove.
12920 * jit.c (jit_object_close_impl): Update.
12921
12922 2019-03-15 Tom Tromey <tom@tromey.com>
12923
12924 * minsyms.c (minimal_symbol_reader::record_full): Remove some
12925 initializations.
12926
12927 2019-03-15 Tom Tromey <tom@tromey.com>
12928
12929 * objfiles.h (struct objfile_per_bfd_storage)
12930 <demangled_hash_languages>: Now a bitset.
12931 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
12932 (lookup_minimal_symbol): Update.
12933
12934 2019-03-15 Tom Tromey <tom@tromey.com>
12935
12936 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
12937 Don't return the symbol.
12938 * coffread.c (record_minimal_symbol): Use record_full.
12939
12940 2019-03-14 Eli Zaretskii <eliz@gnu.org>
12941
12942 The MS-Windows port of ncurses fails to switch to a color pair if
12943 one or both of the colors are the implicit default colors. This
12944 change records the default colors when TUI is initialized, and
12945 then specifies them explicitly when a color pair uses the default
12946 colors. This allows color styling in TUI mode on MS-Windows.
12947
12948 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
12949 ncurses_norm_attr.
12950 (tui_initialize_io) [__MINGW32__]: Record the default terminal
12951 colors in ncurses_norm_attr.
12952 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
12953 "none", replace it with the default color recorded in
12954 ncurses_norm_attr.
12955
12956 2019-03-14 Tom Tromey <tromey@adacore.com>
12957
12958 * source-cache.h (class source_cache) <get_source_lines>: Return
12959 std::string.
12960 * source-cache.c (source_cache::extract_lines): Handle case where
12961 first_pos==npos. Return std::string.
12962 (source_cache::get_source_lines): Update.
12963
12964 2019-03-14 Tom Tromey <tromey@adacore.com>
12965
12966 * NEWS: Add item for "style sources" commands.
12967 * source-cache.c (source_cache::get_source_lines): Check
12968 source_styling.
12969 * cli/cli-style.c (source_styling): New global.
12970 (_initialize_cli_style): Add "style sources" commands.
12971 (show_style_sources): New function.
12972 * cli/cli-style.h (source_styling): Declare.
12973
12974 2019-03-14 Pedro Alves <palves@redhat.com>
12975 Tom Tromey <tromey@adacore.com>
12976
12977 * tui/tui-winsource.h (tui_refill_source_window): Declare.
12978 * tui/tui-winsource.c (tui_refill_source_window): New function,
12979 from...
12980 (tui_horizontal_source_scroll): ... here. Move some logic.
12981 * cli/cli-style.c (set_style_enabled): Notify new observable.
12982 * tui/tui-hooks.c (tui_redisplay_source): New function.
12983 (tui_attach_detach_observers): Attach or detach
12984 tui_redisplay_source.
12985 * observable.h (source_styling_changed): New observable.
12986 * observable.c: Define source_styling_changed observable.
12987
12988 2019-03-13 Tom Tromey <tromey@adacore.com>
12989
12990 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
12991 (i386_gnu_nat_target::store_registers): Update.
12992 * target-debug.h (target_debug_print_std_string): New macro.
12993 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12994 * windows-tdep.c (display_one_tib): Update.
12995 * tui/tui-stack.c (tui_make_status_line): Update.
12996 * top.c (print_inferior_quit_action): Update.
12997 * thread.c (thr_try_catch_cmd): Update.
12998 (add_thread_with_info): Update.
12999 (thread_target_id_str): Update.
13000 (thr_try_catch_cmd): Update.
13001 (thread_command): Update.
13002 (thread_find_command): Update.
13003 * record-btrace.c (record_btrace_target::info_record)
13004 (record_btrace_resume_thread, record_btrace_target::resume)
13005 (record_btrace_cancel_resume, record_btrace_step_thread)
13006 (record_btrace_target::wait, record_btrace_target::wait)
13007 (record_btrace_target::wait, record_btrace_target::stop): Update.
13008 * progspace.c (print_program_space): Update.
13009 * process-stratum-target.c
13010 (process_stratum_target::thread_address_space): Update.
13011 * linux-fork.c (linux_fork_mourn_inferior)
13012 (detach_checkpoint_command, info_checkpoints_command)
13013 (linux_fork_context): Update.
13014 (linux_fork_detach): Update.
13015 (class scoped_switch_fork_info): Update.
13016 (delete_checkpoint_command): Update.
13017 * infrun.c (follow_fork_inferior): Update.
13018 (follow_fork_inferior): Update.
13019 (proceed_after_vfork_done): Update.
13020 (handle_vfork_child_exec_or_exit): Update.
13021 (follow_exec): Update.
13022 (displaced_step_prepare_throw): Update.
13023 (displaced_step_restore): Update.
13024 (start_step_over): Update.
13025 (resume_1): Update.
13026 (clear_proceed_status_thread): Update.
13027 (proceed): Update.
13028 (print_target_wait_results): Update.
13029 (do_target_wait): Update.
13030 (context_switch): Update.
13031 (stop_all_threads): Update.
13032 (restart_threads): Update.
13033 (finish_step_over): Update.
13034 (handle_signal_stop): Update.
13035 (switch_back_to_stepped_thread): Update.
13036 (keep_going_pass_signal): Update.
13037 (print_exited_reason): Update.
13038 (normal_stop): Update.
13039 * inferior.c (inferior_pid_to_str): Change return type.
13040 (print_selected_inferior): Update.
13041 (add_inferior): Update.
13042 (detach_inferior): Update.
13043 * dummy-frame.c (fprint_dummy_frames): Update.
13044 * dcache.c (dcache_info_1): Update.
13045 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13046 (btrace_fetch, btrace_clear): Update.
13047 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13048 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13049 type.
13050 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13051 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13052 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13053 * gdbarch.c, gdbarch.h: Rebuild.
13054 * gdbarch.sh (core_pid_to_str): Change return type.
13055 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13056 return type.
13057 (windows_nat_target::pid_to_str): Change return type.
13058 (windows_delete_thread): Update.
13059 (windows_nat_target::attach): Update.
13060 (windows_nat_target::files_info): Update.
13061 * target-delegates.c: Rebuild.
13062 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13063 return type.
13064 (sol_thread_target::pid_to_str): Change return type.
13065 * remote.c (class remote_target) <pid_to_str>: Change return
13066 type.
13067 (remote_target::pid_to_str): Change return type.
13068 (extended_remote_target::attach, remote_target::remote_stop_ns)
13069 (remote_target::remote_notif_remove_queued_reply)
13070 (remote_target::push_stop_reply, remote_target::disable_btrace):
13071 Update.
13072 (extended_remote_target::attach): Update.
13073 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13074 type.
13075 (gdbsim_target::pid_to_str): Change return type.
13076 * ravenscar-thread.c (struct ravenscar_thread_target)
13077 <pid_to_str>: Change return type.
13078 (ravenscar_thread_target::pid_to_str): Change return type.
13079 * procfs.c (class procfs_target) <pid_to_str>: Change return
13080 type.
13081 (procfs_target::pid_to_str): Change return type.
13082 (procfs_target::attach): Update.
13083 (procfs_target::detach): Update.
13084 (procfs_target::fetch_registers): Update.
13085 (procfs_target::store_registers): Update.
13086 (procfs_target::wait): Update.
13087 (procfs_target::files_info): Update.
13088 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13089 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13090 return type.
13091 (nto_procfs_target::pid_to_str): Change return type.
13092 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13093 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13094 return type.
13095 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13096 (exit_lwp): Update.
13097 (attach_proc_task_lwp_callback, get_detach_signal)
13098 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13099 (linux_nat_target::resume, wait_lwp, stop_callback)
13100 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13101 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13102 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13103 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13104 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13105 type.
13106 (inf_ptrace_target::attach): Update.
13107 (inf_ptrace_target::files_info): Update.
13108 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13109 type.
13110 (go32_nat_target::pid_to_str): Change return type.
13111 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13112 (gnu_nat_target::wait): Update.
13113 (gnu_nat_target::wait): Update.
13114 (gnu_nat_target::resume): Update.
13115 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13116 (fbsd_nat_target::wait): Update.
13117 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13118 type.
13119 (darwin_nat_target::attach): Update.
13120 * corelow.c (class core_target) <pid_to_str>: Change return type.
13121 (core_target::pid_to_str): Change return type.
13122 * target.c (normal_pid_to_str): Change return type.
13123 (default_pid_to_str): Likewise.
13124 (target_pid_to_str): Change return type.
13125 (target_translate_tls_address): Update.
13126 (target_announce_detach): Update.
13127 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13128 return type.
13129 (bsd_uthread_target::pid_to_str): Change return type.
13130 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13131 type.
13132 (bsd_kvm_target::pid_to_str): Change return type.
13133 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13134 return type.
13135 (aix_thread_target::pid_to_str): Change return type.
13136 * target.h (struct target_ops) <pid_to_str>: Change return type.
13137 (target_pid_to_str, normal_pid_to_str): Likewise.
13138 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13139 type.
13140 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13141 type.
13142 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13143 return type.
13144 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13145 type.
13146 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13147 type.
13148 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13149 return type.
13150
13151 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13152
13153 * NEWS: Mention that the new default MI version is 3. Mention
13154 changes to the output of commands and events that deal with
13155 multi-location breakpoints.
13156 * breakpoint.c: Include "mi/mi-out.h".
13157 (print_one_breakpoint): Change output syntax if using MI version
13158 >= 3.
13159 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13160 New.
13161 (mi_multi_location_breakpoint_output_fixed): New.
13162 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13163 (mi_cmd_fix_multi_location_breakpoint_output): New.
13164 (mi_multi_location_breakpoint_output_fixed): New.
13165 * mi/mi-cmds.c (mi_cmds): Register command
13166 -fix-multi-location-breakpoint-output.
13167 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13168 interpreter "mi".
13169
13170 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13171
13172 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13173 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13174 instantiate mi_ui_out based on interpreter name.
13175 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13176 * mi/mi-main.c (mi_load_progress): Likewise.
13177
13178 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13179
13180 * NEWS: Combine separate "New targets" sections for 8.3.
13181
13182 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13183
13184 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13185 (ppcfbsd_init_abi): Install gdbarch
13186 "fetch_tls_load_module_address" and "get_thread_local_address"
13187 methods.
13188
13189 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13190
13191 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13192 (riscv_fbsd_init_abi): Install gdbarch
13193 "fetch_tls_load_module_address" and "get_thread_local_address"
13194 methods.
13195
13196 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13197
13198 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13199 (i386fbsd_init_abi): Install gdbarch
13200 "fetch_tls_load_module_address" and "get_thread_local_address"
13201 methods.
13202
13203 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13204
13205 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13206 (amd64fbsd_init_abi): Install gdbarch
13207 "fetch_tls_load_module_address" and "get_thread_local_address"
13208 methods.
13209
13210 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13211
13212 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13213 (struct fbsd_pspace_data): New type.
13214 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13215 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13216 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13217 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13218 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13219
13220 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13221
13222 * gdbtypes.c (lookup_struct_elt): New function.
13223 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13224 * gdbtypes.h (struct struct_elt): New type.
13225 (lookup_struct_elt): New prototype.
13226
13227 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13228
13229 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13230 remove disabled code block.
13231
13232 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13233
13234 * gdbarch.sh (get_thread_local_address): New method.
13235 * gdbarch.h, gdbarch.c: Regenerate.
13236 * target.c (target_translate_tls_address): Use
13237 gdbarch_get_thread_local_address if present instead of
13238 target::get_thread_local_address.
13239
13240 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13241
13242 * target.h (target::get_thread_local_address): Update comment.
13243
13244 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13245
13246 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13247 objfile->separate_debug_objfile_backlink if not NULL.
13248
13249 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13250
13251 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13252 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13253 (amd64bsd_store_inferior_registers): Likewise.
13254 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13255 Enable segment base registers.
13256 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13257 PT_GETFSBASE and PT_GETGSBASE.
13258 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13259 PT_SETGSBASE.
13260 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13261 segment base registers.
13262 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13263
13264 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13265
13266 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13267 Update calls to i386_target_description to add 'segments'
13268 parameter.
13269 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13270 add segment base registers.
13271 * arch/i386.c (i386_create_target_description): Add 'segments'
13272 parameter to enable segment base registers.
13273 * arch/i386.h (i386_create_target_description): Likewise.
13274 * features/i386/32bit-segments.xml: New file.
13275 * features/i386/32bit-segments.c: Generate.
13276 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13277 call to i386_target_description to add 'segments' parameter.
13278 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13279 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13280 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13281 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13282 if feature is present.
13283 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13284 Add 'segments' parameter to call to i386_target_description.
13285 (i386_target_description): Add 'segments' parameter to enable
13286 segment base registers.
13287 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13288 to call to i386_target_description.
13289 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13290 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13291 Define I386_NUM_REGS.
13292 (i386_target_description): Add 'segments' parameter to enable
13293 segment base registers.
13294
13295 2019-03-12 Eli Zaretskii <eliz@gnu.org>
13296
13297 PR/24325
13298 * source-cache.c: #undef open and close, to avoid unresolved
13299 externals during linking.
13300
13301 2019-03-12 Tom Tromey <tromey@adacore.com>
13302
13303 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13304 const. Add initializers.
13305 (_initialize_remote): Don't initialize ptid globals.
13306
13307 2019-03-12 Pedro Alves <palves@redhat.com>
13308
13309 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13310
13311 2019-03-12 Pedro Alves <palves@redhat.com>
13312
13313 * cp-name-parser.y (main): Remove unused 'len' variable.
13314
13315 2019-03-12 Tom Tromey <tromey@adacore.com>
13316
13317 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13318 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13319
13320 2019-03-12 Tom Tromey <tromey@adacore.com>
13321
13322 * linux-nat.c (iterate_over_lwps): Update.
13323 (stop_callback): Remove parameter.
13324 (stop_wait_callback, detach_callback, resume_set_callback)
13325 (select_singlestep_lwp_callback, set_ignore_sigint)
13326 (status_callback, resumed_callback, resume_clear_callback)
13327 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13328 data parameter.
13329 (linux_nat_target::detach, linux_nat_target::resume)
13330 (linux_stop_and_wait_all_lwps, select_event_lwp)
13331 (linux_nat_filter_event, linux_nat_wait_1)
13332 (linux_nat_target::kill, linux_nat_target::stop)
13333 (linux_nat_target::stop): Update.
13334 (linux_nat_resume_callback): Change type.
13335 (resume_stopped_resumed_lwps, count_events_callback)
13336 (select_event_lwp_callback): Likewise.
13337 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13338 * arm-linux-nat.c (struct update_registers_data): Remove.
13339 (update_registers_callback): Change type.
13340 (arm_linux_insert_hw_breakpoint1): Update.
13341 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13342 parameter.
13343 (x86_linux_dr_set_addr): Update.
13344 (x86_linux_dr_set_control): Update.
13345 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13346 (iterate_over_lwps): Use gdb::function_view.
13347 * nat/aarch64-linux-hw-point.c (struct
13348 aarch64_dr_update_callback_param): Remove.
13349 (debug_reg_change_callback): Change type.
13350 (aarch64_notify_debug_reg_change): Update.
13351 * s390-linux-nat.c (s390_refresh_per_info): Update.
13352
13353 2019-03-11 Tom Tromey <tromey@adacore.com>
13354
13355 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13356 redundant assignment to "this_cu".
13357
13358 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13359
13360 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13361
13362 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13363
13364 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13365 from...
13366 (rank_one_type): ... this.
13367
13368 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13369
13370 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13371 from...
13372 (rank_one_type): ... this.
13373
13374 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13375
13376 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13377 from...
13378 (rank_one_type): ... this.
13379
13380 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13381
13382 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13383 from...
13384 (rank_one_type): ... this.
13385
13386 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13387
13388 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13389 from...
13390 (rank_one_type): ... this.
13391
13392 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13393
13394 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13395 from...
13396 (rank_one_type): ... this.
13397
13398 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13399
13400 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13401 from...
13402 (rank_one_type): ... this.
13403
13404 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13405
13406 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13407 from...
13408 (rank_one_type): ... this.
13409
13410 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13411
13412 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13413 from...
13414 (rank_one_type): ... this.
13415
13416 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13417
13418 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13419 from...
13420 (rank_one_type): ... this.
13421
13422 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13423
13424 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13425 from...
13426 (rank_one_type): ... this.
13427
13428 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13429
13430 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13431 from...
13432 (rank_one_type): ... this.
13433
13434 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13435
13436 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13437 inferior-events' shows the example events.
13438
13439 2019-03-08 Eli Zaretskii <eliz@gnu.org>
13440
13441 Support styling on native MS-Windows console
13442
13443 PR/24315
13444 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13445 on MS-Windows if $TERM is not defined.
13446
13447 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13448
13449 * posix-hdep.c (gdb_console_fputs):
13450 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13451 functions.
13452 * ui-file.h (gdb_console_fputs): Add prototype.
13453
13454 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13455 back to fputs only if the former returns zero.
13456
13457 2019-03-07 Tom Tromey <tom@tromey.com>
13458
13459 * symmisc.c (print_symbol_bcache_statistics): Update.
13460 (print_objfile_statistics): Update.
13461 * symfile.c (allocate_symtab): Update.
13462 * stabsread.c: Don't include bcache.h.
13463 * psymtab.h (struct psymbol_bcache): Don't declare.
13464 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13465 (psymbol_bcache_init, psymbol_bcache_free)
13466 (psymbol_bcache_get_bcache): Don't declare.
13467 * psymtab.c (struct psymbol_bcache): Remove.
13468 (psymtab_storage::psymtab_storage): Update.
13469 (psymtab_storage::~psymtab_storage): Update.
13470 (psymbol_bcache_init, psymbol_bcache_free)
13471 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13472 (add_psymbol_to_bcache): Update.
13473 (allocate_psymtab): Update.
13474 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13475 macro_cache>: No longer pointers.
13476 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13477 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13478 * macrotab.c (macro_bcache): Update.
13479 * macroexp.c: Don't include bcache.h.
13480 * gdbtypes.c (check_types_worklist): Update.
13481 (types_deeply_equal): Remove TRY/CATCH. Update.
13482 * elfread.c (elf_symtab_read): Update.
13483 * dwarf2read.c: Don't include bcache.h.
13484 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13485 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13486 (print_bcache_statistics, bcache_memory_used): Don't declare.
13487 (struct bcache): Move from bcache.c. Add constructor, destructor,
13488 methods. Rename all data members.
13489 * bcache.c (struct bcache): Move to bcache.h.
13490 (bcache::expand_hash_table): Rename from expand_hash_table.
13491 (bcache): Remove.
13492 (bcache::insert): Rename from bcache_full.
13493 (bcache::compare): Rename from bcache_compare.
13494 (bcache_xmalloc): Remove.
13495 (bcache::~bcache): Rename from bcache_xfree.
13496 (bcache::print_statistics): Rename from print_bcache_statistics.
13497 (bcache::memory_used): Rename from bcache_memory_used.
13498
13499 2019-03-07 Pedro Alves <palves@redhat.com>
13500
13501 * infrun.c (normal_stop): Also check for
13502 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13503
13504 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13505
13506 * f-lang.c (value_from_host_double): Moved to...
13507 * value.c (value_from_host_double): ...here.
13508 * value.h (value_from_host_double): Declare.
13509 * guile/scm-math.c (vlscm_convert_typed_number): Use
13510 value_from_host_double.
13511 (vlscm_convert_number): Likewise.
13512 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13513 * python/py-value.c (convert_value_from_python): Likewise.
13514
13515 2019-03-06 Tom Tromey <tom@tromey.com>
13516
13517 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13518
13519 2019-03-06 Tom Tromey <tom@tromey.com>
13520
13521 * utils.h (free_current_contents): Don't declare.
13522 * utils.c (free_current_contents): Remove.
13523
13524 2019-03-06 Tom Tromey <tom@tromey.com>
13525
13526 * top.c (quit_force): Update.
13527 * main.c (captured_command_loop): Update.
13528 * common/new-op.c (operator new): Update.
13529 * common/common-exceptions.c (struct catcher)
13530 <save_cleanup_chain>: Remove member.
13531 (exceptions_state_mc_init): Update.
13532 (exception_try_scope_entry): Return nullptr.
13533 (exception_try_scope_exit, exception_rethrow)
13534 (throw_exception_sjlj, throw_exception_cxx): Update.
13535 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13536 (all_cleanups, do_cleanups, discard_cleanups)
13537 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13538 (restore_cleanups, restore_final_cleanups): Don't declare.
13539 (do_final_cleanups): Remove parameter.
13540 * common/cleanups.c (cleanup_chain, make_cleanup)
13541 (make_cleanup_dtor, all_cleanups, do_cleanups)
13542 (discard_my_cleanups, discard_cleanups)
13543 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13544 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13545 (null_cleanup): Remove.
13546 (do_final_cleanups): Remove parameter.
13547
13548 2019-03-06 Tom Tromey <tom@tromey.com>
13549
13550 * remote.c (remote_target::remote_parse_stop_reply): Use
13551 unique_xmalloc_ptr.
13552
13553 2019-03-06 Tom Tromey <tom@tromey.com>
13554
13555 * stabsread.c (struct stabs_field_info): Rename from field_info.
13556 <list, fnlist>: Add initializers.
13557 <obstack>: New member.
13558 (read_member_functions, read_struct_fields, read_baseclasses):
13559 Allocate on obstack. Don't use cleanups.
13560 (read_one_struct_field, read_member_functions, read_struct_fields)
13561 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13562 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13563 (read_struct_type): Update.
13564
13565 2019-03-06 Tom Tromey <tom@tromey.com>
13566
13567 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13568 * common/filestuff.h (make_cleanup_close): Don't declare.
13569 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13570 Remove.
13571
13572 2019-03-06 Tom Tromey <tom@tromey.com>
13573
13574 * solib-aix.c: Use make_scope_exit.
13575
13576 2019-03-06 Tom Tromey <tom@tromey.com>
13577
13578 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13579 Use make_scope_exit.
13580
13581 2019-03-06 Tom Tromey <tom@tromey.com>
13582
13583 * solib-svr4.c (disable_probes_interface): Remove parameter.
13584 (svr4_handle_solib_event): Use make_scope_exit.
13585
13586 2019-03-06 Tom Tromey <tom@tromey.com>
13587
13588 * remote.c (struct stop_reply_deleter): Remove.
13589 (stop_reply_up): Update.
13590 (struct stop_reply): Derive from notif_event. Don't typedef.
13591 <regcache>: Now a std::vector.
13592 (stop_reply_xfree): Remove.
13593 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13594 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
13595 (remote_target::discard_pending_stop_replies): Use delete.
13596 (remote_target::remote_parse_stop_reply): Update.
13597 (remote_target::process_stop_reply): Update.
13598 * remote-notif.h (struct notif_event): Add virtual destructor.
13599 Remove "dtr" member.
13600 (struct notif_client) <alloc_event>: Return a unique_ptr.
13601 (notif_event_xfree): Don't declare.
13602 (notif_event_up): New typedef.
13603 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13604 (notif_event_xfree, do_notif_event_xfree): Remove.
13605 (remote_notif_state_xfree): Update.
13606
13607 2019-03-06 Tom Tromey <tom@tromey.com>
13608
13609 * infrun.c (displaced_step_clear_cleanup): Now a
13610 forward_scope_exit type.
13611 (displaced_step_prepare_throw): Update.
13612 (displaced_step_fixup): Update.
13613
13614 2019-03-06 Tom Tromey <tom@tromey.com>
13615
13616 * inferior.h (class inferior): Update comment.
13617 * gdbthread.h (class thread_info): Update comment.
13618
13619 2019-03-06 Joel Brobecker <brobecker@adacore.com>
13620 Tom Tromey <tom@tromey.com>
13621
13622 * stabsread.h (struct stab_section_list): Remove.
13623 (coffstab_build_psymtabs): Update.
13624 * dbxread.c (symbuf_sections): Now a std::vector.
13625 (sect_idx): New global.
13626 (fill_symbuf): Update.
13627 (coffstab_build_psymtabs): Change type of stabsects parameter.
13628 Update.
13629 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13630 std::vector.
13631 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13632 (coff_locate_sections): Update.
13633 (coff_symfile_read): Remove cleanups. Update.
13634 (init_stringtab): Add storage parameter.
13635 (free_stringtab, free_stringtab_cleanup): Remove.
13636 (init_lineno): Add storage parameter.
13637 (free_linetab, free_linetab_cleanup): Remove.
13638
13639 2019-03-06 Pedro Alves <palves@redhat.com>
13640
13641 * linux-fork.c (fork_info::clobber_regs): Delete.
13642 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13643 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
13644 comment. Adjust.
13645 (scoped_switch_fork_info::scoped_switch_fork_info)
13646 (checkpoint_command, linux_fork_context): Adjust
13647 fork_save_infrun_state calls.
13648
13649 2019-03-06 Pedro Alves <palves@redhat.com>
13650
13651 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13652 (inf_has_multiple_threads): Return 'bool' and rewrite using
13653 inferior_info::threads().
13654
13655 2019-03-06 Pedro Alves <palves@redhat.com>
13656
13657 * linux-fork.c: Include <list>.
13658 (fork_list): Now a std::list instance.
13659 (fork_info): Add ctor, dtor, and in-class initialize all fields.
13660 (forks_exist_p, find_last_fork): Adjust.
13661 (new_fork): Delete.
13662 (one_fork_p): New.
13663 (add_fork): Adjust.
13664 (free_fork): Delete, folded into fork_info::~fork_info().
13665 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13666 Adjust.
13667 (init_fork_list): Delete.
13668 (linux_fork_killall, linux_fork_mourn_inferior)
13669 (linux_fork_detach, info_checkpoints_command): Adjust.
13670 (_initialize_linux_fork): No longer call init_fork_list.
13671
13672 2019-03-06 Pedro Alves <palves@redhat.com>
13673
13674 * linux-fork.c (new_fork): New, split out of ...
13675 (add_fork): ... this. Return void. Move "first fork" special
13676 case from here, to ...
13677 (checkpoint_command): ... here.
13678 * linux-linux.h (add_fork): Return void.
13679
13680 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13681
13682 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13683
13684 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13685 Chris January <chris.january@arm.com>
13686 David Lecomber <david.lecomber@arm.com>
13687
13688 * f-exp.y: New token, UNOP_INTRINSIC.
13689 (exp): New pattern using UNOP_INTRINSIC token.
13690 (f77_keywords): Add 'abs' keyword.
13691 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13692 (value_from_host_double): New function.
13693 (evaluate_subexp_f): Support UNOP_ABS.
13694
13695 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13696
13697 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13698 types.
13699
13700 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13701
13702 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13703 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13704 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13705
13706 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13707
13708 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13709
13710 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13711 Chris January <chris.january@arm.com>
13712
13713 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13714 * f-exp.y: Define 'KIND' token.
13715 (exp): New pattern for KIND expressions.
13716 (ptype): Handle types with a kind extension.
13717 (direct_abs_decl): Extend to spot kind extensions.
13718 (f77_keywords): Add 'kind' to the list.
13719 (push_kind_type): New function.
13720 (convert_to_kind_type): New function.
13721 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13722 * parse.c (operator_length_standard): Likewise.
13723 * parser-defs.h (enum type_pieces): Add tp_kind.
13724 * std-operator.def: Add UNOP_KIND.
13725
13726 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13727
13728 * f-exp.y (f_parse): Set yydebug.
13729
13730 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13731
13732 * f-lang.c (evaluate_subexp_f): New function.
13733 (exp_descriptor_f): New global.
13734 (f_language_defn): Use exp_descriptor_f instead of
13735 exp_descriptor_standard.
13736
13737 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13738
13739 * f-exp.y (struct token): Add comments.
13740 (dot_ops): Remove uppercase versions and the end marker.
13741 (f77_keywords): Likewise.
13742 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13743 entries in the dot_ops array are case insensitive, and use
13744 strncasecmp to compare strings. Also some whitespace cleanup in
13745 this area. Similar for the f77_keywords array, except entries in
13746 this list might be case sensitive.
13747
13748 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13749
13750 * f-exp.y (struct f77_boolean_val): Add comments.
13751 (boolean_values): Remove uppercase versions, and end marker.
13752 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13753 and use strncasecmp to achieve case insensitivity. Additionally,
13754 perform whitespace cleanup around this code.
13755
13756 2019-03-06 Tom Tromey <tromey@adacore.com>
13757
13758 * remote-sim.c (gdbsim_target_open): Use result of
13759 gdb_argv::release.
13760
13761 2019-03-06 Richard Bunt <richard.bunt@arm.com>
13762 Dirk Schubert <dirk.schubert@arm.com>
13763 Chris January <chris.january@arm.com>
13764
13765 * eval.c (evaluate_subexp_standard): Call Fortran argument
13766 wrapping logic.
13767 * f-lang.c (struct value): A value which can be passed into a
13768 Fortran function call.
13769 (fortran_argument_convert): Wrap Fortran arguments in a pointer
13770 where appropriate.
13771 (struct type): Value ready for a Fortran function call.
13772 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13773 is needed.
13774 * f-lang.h (fortran_argument_convert): Declaration.
13775 (fortran_preserve_arg_pointer): Declaration.
13776 * infcall.c (value_arg_coerce): Call Fortran argument logic.
13777
13778 2019-03-05 Tom Tromey <tromey@adacore.com>
13779
13780 * python/py-prettyprint.c (print_string_repr): Remove #if.
13781 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13782
13783 2019-03-05 Tom Tromey <tromey@adacore.com>
13784
13785 * target.c (the_dummy_target): Move later. Change type to
13786 "dummy_target".
13787 (initialize_targets): Don't initialize the_dummy_target.
13788
13789 2019-03-05 Tom Tromey <tromey@adacore.com>
13790
13791 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13792 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13793
13794 2019-03-05 Tom Tromey <tromey@adacore.com>
13795
13796 * windows-nat.c (windows_nat_target::attach)
13797 (windows_nat_target::detach): Don't call gdb_flush.
13798 * valprint.c (generic_val_print, val_print, val_print_string):
13799 Don't call gdb_flush.
13800 * utils.c (defaulted_query): Don't call gdb_flush.
13801 * typeprint.c (print_type_scalar): Don't call gdb_flush.
13802 * target.c (target_announce_detach): Don't call gdb_flush.
13803 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13804 * remote.c (extended_remote_target::attach): Don't call
13805 gdb_flush.
13806 * procfs.c (procfs_target::detach): Don't call gdb_flush.
13807 * printcmd.c (do_examine): Don't call gdb_flush.
13808 (info_display_command): Don't call gdb_flush.
13809 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13810 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13811 * memattr.c (info_mem_command): Don't call gdb_flush.
13812 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13813 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13814 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13815 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13816 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13817 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13818 (gnu_nat_target::detach): Don't call gdb_flush.
13819 * f-valprint.c (f_val_print): Don't call gdb_flush.
13820 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13821 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13822 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13823 gdb_flush.
13824 * c-valprint.c (c_val_print): Don't call gdb_flush.
13825 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13826
13827 2019-03-05 Tom Tromey <tromey@adacore.com>
13828
13829 * varobj.c (update_dynamic_varobj_children): Update.
13830 (install_default_visualizer): Use reset, not release.
13831 * value.c (set_internalvar): Update.
13832 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13833 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13834 ATTRIBUTE_UNUSED_RESULT.
13835
13836 2019-03-05 Tom Tromey <tromey@adacore.com>
13837
13838 * remote.c (class scoped_remote_fd) <release>: Add
13839 ATTRIBUTE_UNUSED_RESULT.
13840
13841 2019-03-05 Tom Tromey <tromey@adacore.com>
13842
13843 * macroexp.c (struct macro_buffer) <release>: Add
13844 ATTRIBUTE_UNUSED_RESULT.
13845
13846 2019-03-05 Tom Tromey <tromey@adacore.com>
13847
13848 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13849 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13850 ATTRIBUTE_UNUSED_RESULT.
13851
13852 2019-03-05 Tom Tromey <tromey@adacore.com>
13853
13854 * common/scoped_fd.h (class scoped_fd) <release>: Add
13855 ATTRIBUTE_UNUSED_RESULT.
13856
13857 2019-03-05 Tom Tromey <tromey@adacore.com>
13858
13859 * parser-defs.h (struct parser_state) <release>: Add
13860 ATTRIBUTE_UNUSED_RESULT.
13861
13862 2019-03-05 Tom Tromey <tromey@adacore.com>
13863
13864 * utils.h (class gdb_argv) <release>: Add
13865 ATTRIBUTE_UNUSED_RESULT.
13866 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13867
13868 2019-03-02 Eli Zaretskii <eliz@gnu.org>
13869
13870 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13871 for-loop range, to avoid compiler warnings.
13872
13873 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13874 avoid compiler warnings about unused variables.
13875
13876 * NEWS: Mention end of support for native debugging on MS-Windows
13877 before XP.
13878
13879 PR gdb/24292
13880 * common/netstuff.c:
13881 * gdbserver/gdbreplay.c
13882 * gdbserver/remote-utils.c:
13883 * ser-tcp.c:
13884 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13885 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
13886 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13887 'getaddrinfo' and 'freeaddrinfo' were not available before
13888 Windows XP, and mingw.org's MinGW headers by default define
13889 _WIN32_WINNT to 0x500.
13890
13891 2019-03-01 Gary Benson <gbenson@redhat.com>
13892
13893 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13894
13895 2019-02-28 Brian Vandenberg <phantall@gmail.com>
13896 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
13897
13898 PR gdb/8527
13899 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13900 set_sigint_trap, clear_sigint_trap.
13901
13902 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13903
13904 * target.c (target_detach): Clear the regcache and the
13905 frame cache.
13906
13907 2019-02-27 Pedro Alves <palves@redhat.com>
13908
13909 * utils.c (set_screen_size): When we cap the height/width sizes,
13910 tweak the corresponding command variable to show "unlimited":
13911
13912 2019-02-27 Saagar Jha <saagar@saagarjha.com>
13913 Pedro Alves <palves@redhat.com>
13914
13915 * utils.c (set_screen_size): Reduce "infinite" rows and columns
13916 before calling rl_set_screen_size.
13917
13918 2019-02-27 Tom Tromey <tromey@adacore.com>
13919
13920 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
13921 define.
13922 * python/py-value.c: Remove Python 2.4 workaround.
13923 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
13924 workaround.
13925 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
13926 Python 2.4 workaround.
13927 * python/python-internal.h: Remove Python 2.4 comment.
13928 (Py_ssize_t): Don't define.
13929 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
13930 (gdb_Py_DECREF): Remove Python 2.4 workaround.
13931 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
13932 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
13933 * python/python.c (do_start_initialization): Remove Python 2.4
13934 workaround.
13935 * python/py-prettyprint.c (class dummy_python_frame): Remove.
13936 (print_children): Remove Python 2.4 workaround.
13937 * python/py-inferior.c (buffer_procs): Remove Python 2.4
13938 workaround.
13939 (CHARBUFFERPROC_NAME): Remove.
13940 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
13941 Python 2.4 workaround.
13942
13943 2019-02-27 Kevin Buettner <kevinb@redhat.com>
13944
13945 * NEWS: Note minimum Python version.
13946
13947 2019-02-27 Kevin Buettner <kevinb@redhat.com>
13948
13949 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
13950 code from these functions. Remove corresponding ifdefs. Use
13951 Py_buffer_up instead of explicit calls to PyBuffer_Release.
13952 Remove gotos and target of gotos.
13953 (infpy_search_memory): Likewise.
13954
13955 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13956
13957 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
13958 (hppa_gdbarch_init): Don't register deleted functions with
13959 gdbarch.
13960
13961 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13962
13963 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
13964 (h8300_unwind_sp): Delete.
13965 (h8300_dummy_id): Delete.
13966 (h8300_gdbarch_init): Don't register deleted functions with
13967 gdbarch.
13968
13969 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13970
13971 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
13972 (ft32_unwind_pc): Delete.
13973 (ft32_unwind_sp): Delete.
13974 (ft32_gdbarch_init): Don't register deleted functions with
13975 gdbarch.
13976
13977 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13978
13979 * gdb/frv-tdep.c (frv_dummy_id): Delete.
13980 (frv_unwind_pc): Delete.
13981 (frv_unwind_sp): Delete.
13982 (frv_gdbarch_init): Don't register deleted functions with
13983 gdbarch.
13984
13985 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13986
13987 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
13988 (riscv_unwind_pc): Delete.
13989 (riscv_unwind_sp): Delete.
13990 (riscv_gdbarch_init): Don't register deleted functions with
13991 gdbarch.
13992
13993 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13994
13995 * gdb/csky-tdep.c (csky_dummy_id): Delete.
13996 (csky_unwind_pc): Delete.
13997 (csky_unwind_sp): Delete.
13998 (csky_gdbarch_init): Don't register deleted functions with
13999 gdbarch.
14000
14001 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14002
14003 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14004 (cris_unwind_pc): Delete.
14005 (cris_unwind_sp): Delete.
14006 (cris_gdbarch_init): Don't register deleted functions with
14007 gdbarch.
14008
14009 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14010
14011 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14012 (bfin_unwind_pc): Delete.
14013 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14014
14015 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14016
14017 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14018 (arm_unwind_pc): Delete.
14019 (arm_unwind_sp): Delete.
14020 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14021
14022 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14023
14024 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14025 (arc_unwind_pc): Delete.
14026 (arc_unwind_sp): Delete.
14027 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14028
14029 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14030
14031 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14032 (alpha_unwind_pc): Delete.
14033 (alpha_gdbarch_init): Don't register deleted functions with
14034 gdbarch.
14035
14036 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14037
14038 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14039 (aarch64_unwind_pc): Delete.
14040 (aarch64_unwind_sp): Delete.
14041 (aarch64_gdbarch_init): Don't register deleted functions with
14042 gdbarch.
14043
14044 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14045
14046 * gdbtypes.c (type_align): Don't consider static members when
14047 computing structure alignment.
14048
14049 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14050
14051 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14052 return 0 for other types.
14053 * arch-utils.c (default_type_align): Always return 0.
14054 * gdbarch.h: Regenerate.
14055 * gdbarch.sh (type_align): Extend comment.
14056 * gdbtypes.c (type_align): Add additional comments, always call
14057 gdbarch_type_align before applying the default rules.
14058 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14059 generic code will then apply a suitable default.
14060 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14061 types, return 0 for other types.
14062
14063 2019-02-27 Joel Brobecker <brobecker@adacore.com>
14064
14065 * NEWS: Create a new section for the next release branch.
14066 Rename the section of the current branch, now that it has
14067 been cut.
14068
14069 2019-02-27 Joel Brobecker <brobecker@adacore.com>
14070
14071 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14072 * version.in: Bump version to 8.3.50.DATE-git.
14073
14074 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
14075
14076 * aix-thread.c (ptid_cmp): Remove unused variable.
14077 (get_signaled_thread): Likewise.
14078 (store_regs_user_thread): Likewise.
14079 (store_regs_kernel_thread): Likewise.
14080 (fetch_regs_kernel_thread): Remove shadowed variable.
14081
14082 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14083
14084 * features/riscv/32bit-cpu.xml: Add register numbers.
14085 * features/riscv/32bit-fpu.c: Regenerate.
14086 * features/riscv/32bit-fpu.xml: Add register numbers.
14087 * features/riscv/64bit-cpu.xml: Add register numbers.
14088 * features/riscv/64bit-fpu.c: Regenerate.
14089 * features/riscv/64bit-fpu.xml: Add register numbers.
14090
14091 2019-02-26 Kevin Buettner <kevinb@redhat.com>
14092
14093 * NEWS: Mention two argument form of gdb.Value constructor.
14094 * python/py-value.c (convert_buffer_and_type_to_value): New
14095 function.
14096 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14097 Add support for handling an optional second argument. Call
14098 convert_buffer_and_type_to_value as appropriate.
14099 * python/python-internal.h (Py_buffer_deleter): New struct.
14100 (Py_buffer_up): New typedef.
14101
14102 2019-02-25 John Baldwin <jhb@FreeBSD.org>
14103
14104 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14105 instead of releasing ownership.
14106
14107 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
14108
14109 * dwarf2read.c (open_and_init_dwp_file): Call
14110 elf_numsections instead of bfd_count_sections to initialize
14111 dwp_file->num_sections.
14112
14113 2019-02-25 Tom Tromey <tromey@adacore.com>
14114
14115 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14116
14117 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14118
14119 * gcore.in: Add '--readnever' option when invoking GDB.
14120
14121 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14122
14123 * MAINTAINERS: Update my email address.
14124
14125 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14126
14127 * build-id.c (build_id_to_debug_bfd_1): New function.
14128 (build_id_to_debug_bfd): Look for separate debug file in
14129 sysroot.
14130
14131 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14132
14133 * gdbarch.sh: Update the copyright year range that is placed into
14134 generated files.
14135
14136 2019-02-22 Keith Seitz <keiths@redhat.com>
14137
14138 PR symtab/23853
14139 * linespec.c (create_sals_line_offset): Search for the default
14140 symtab's filename instead of its fullname.
14141
14142 2019-02-21 Alan Hayward <alan.hayward@arm.com>
14143
14144 * NEWS: Update style defaults.
14145
14146 2019-02-21 Alan Hayward <alan.hayward@arm.com>
14147
14148 * main.c (captured_main_1): Disable styling in batch mode.
14149
14150 2019-02-20 Tom Tromey <tom@tromey.com>
14151
14152 * symtab.c (symtab_symbol_info): Fix typos.
14153
14154 2019-02-20 Tom Tromey <tromey@adacore.com>
14155
14156 * findcmd.c (_initialize_mem_search): Use upper case for
14157 metasyntactic variables.
14158
14159 2019-02-20 Alan Hayward <alan.hayward@arm.com>
14160
14161 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14162 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14163
14164 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14165
14166 * top.h (source_file_name): Change to std::string.
14167 * top.c (source_file_name): Likewise.
14168 (command_line_input): Adjust.
14169 * cli/cli-script.c (script_from_file): Adjust.
14170
14171 2019-02-19 Tom Tromey <tromey@adacore.com>
14172
14173 * ravenscar-thread.c
14174 (ravenscar_thread_target::update_thread_list): Don't call
14175 ada_build_task_list.
14176 * ada-lang.h (ada_build_task_list): Don't declare.
14177 * ada-tasks.c (struct ada_tasks_inferior_data)
14178 <task_list_valid_p>: Now bool.
14179 (read_known_tasks, ada_task_list_changed)
14180 (ada_tasks_invalidate_inferior_data): Update.
14181 (read_known_tasks_array): Return bool.
14182 (read_known_tasks_list): Likewise.
14183 (read_known_tasks): Return void.
14184 (ada_build_task_list): Now static.
14185
14186 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14187
14188 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14189 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14190
14191 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14192
14193 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14194 variant for ada_tasks_pspace_data_handle and
14195 ada_tasks_inferior_data_handle.
14196 (ada_tasks_pspace_data_cleanup): New function.
14197 (ada_tasks_inferior_data_cleanup): New function.
14198
14199 2019-02-17 Tom Tromey <tom@tromey.com>
14200
14201 * macrotab.h (macro_source_fullname): Return a std::string.
14202 * macrotab.c (macro_include, check_for_redefinition)
14203 (macro_undef, macro_lookup_definition, foreach_macro)
14204 (foreach_macro_in_scope): Update.
14205 (macro_source_fullname): Return a std::string.
14206 * macrocmd.c (show_pp_source_pos): Update.
14207
14208 2019-02-17 Tom Tromey <tom@tromey.com>
14209
14210 * macrocmd.c (show_pp_source_pos): Style the file names.
14211
14212 2019-02-17 Tom Tromey <tom@tromey.com>
14213
14214 PR tui/24197:
14215 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14216
14217 2019-02-17 Tom Tromey <tom@tromey.com>
14218
14219 * ada-lang.c (user_select_syms): Use filtered printing.
14220 * utils.c (wrap_style): New global.
14221 (desired_style): Remove.
14222 (emit_style_escape): Add stream parameter.
14223 (set_output_style, reset_terminal_style, prompt_for_continue):
14224 Update.
14225 (flush_wrap_buffer): Only flush gdb_stdout.
14226 (wrap_here): Set wrap_style.
14227 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14228 treat escape sequences as a character. Change when wrap buffer is
14229 flushed.
14230 (fputs_styled): Do not set the output style when the default is
14231 requested.
14232 * ui-style.h (struct ui_file_style) <is_default>: New method.
14233 * source.c (print_source_lines_base): Emit escape sequences in one
14234 piece.
14235
14236 2019-02-17 Joel Brobecker <brobecker@adacore.com>
14237
14238 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14239 integers and enumeration types.
14240
14241 2019-02-17 Joel Brobecker <brobecker@adacore.com>
14242
14243 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14244 instead of lookup_symbol_in_language
14245 (do_exact_match): New function.
14246 (ada_get_symbol_name_matcher): Return do_exact_match when
14247 doing a verbatim match.
14248
14249 2019-02-15 Tom Tromey <tromey@adacore.com>
14250
14251 * ravenscar-thread.c (ravenscar_thread_target::resume)
14252 (ravenscar_thread_target::wait): Special case wildcard requests.
14253
14254 2019-02-15 Tom Tromey <tromey@adacore.com>
14255
14256 * ravenscar-thread.c (base_ptid): Remove.
14257 (struct ravenscar_thread_target) <close>: New method.
14258 <m_base_ptid>: New member.
14259 <update_inferior_ptid, active_task, task_is_currently_active,
14260 runtime_initialized>: Declare methods.
14261 <ravenscar_thread_target>: Add constructor.
14262 (ravenscar_thread_target::task_is_currently_active)
14263 (ravenscar_thread_target::update_inferior_ptid)
14264 (ravenscar_runtime_initialized): Rename. Now methods.
14265 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14266 (ravenscar_thread_target::update_thread_list): Update.
14267 (ravenscar_thread_target::active_task): Now method.
14268 (ravenscar_thread_target::store_registers)
14269 (ravenscar_thread_target::prepare_to_store)
14270 (ravenscar_thread_target::prepare_to_store)
14271 (ravenscar_thread_target::mourn_inferior): Update.
14272 (ravenscar_inferior_created): Use "new" to create target.
14273 (ravenscar_thread_target::get_ada_task_ptid): Update.
14274 (_initialize_ravenscar): Don't initialize base_ptid.
14275 (ravenscar_ops): Remove global.
14276
14277 2019-02-15 Tom Tromey <tromey@adacore.com>
14278
14279 * target.h (push_target): Declare new overload.
14280 * target.c (push_target): New overload, taking an rvalue reference.
14281 * remote.c (remote_target::open_1): Use push_target overload.
14282 * corelow.c (core_target_open): Use push_target overload.
14283
14284 2019-02-15 Tom Tromey <tromey@adacore.com>
14285
14286 * ravenscar-thread.c (is_ravenscar_task)
14287 (ravenscar_task_is_currently_active): Return bool.
14288 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14289 (_initialize_ravenscar): Remove "(void)".
14290 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14291 Return bool.
14292
14293 2019-02-15 Tom Tromey <tromey@adacore.com>
14294
14295 * ravenscar-thread.c (ravenscar_runtime_initializer)
14296 (has_ravenscar_runtime, get_running_thread_id)
14297 (ravenscar_thread_target::resume): Fix indentation.
14298
14299 2019-02-15 Tom Tromey <tromey@adacore.com>
14300
14301 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14302 from ravenscar_arch_ops.
14303 (sparc_ravenscar_ops::fetch_registers)
14304 (sparc_ravenscar_ops::store_registers): Now methods.
14305 (sparc_ravenscar_prepare_to_store): Remove.
14306 (sparc_ravenscar_ops): Redefine.
14307 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14308 methods and destructor. Remove members.
14309 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14310 (ravenscar_thread_target::store_registers)
14311 (ravenscar_thread_target::prepare_to_store): Update.
14312 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14313 Remove.
14314 (struct ppc_ravenscar_powerpc_ops): Derive from
14315 ravenscar_arch_ops.
14316 (ppc_ravenscar_powerpc_ops::fetch_registers)
14317 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14318 (ppc_ravenscar_powerpc_ops): Redefine.
14319 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14320 (ppc_ravenscar_e500_ops::fetch_registers)
14321 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14322 (ppc_ravenscar_e500_ops): Redefine.
14323 * aarch64-ravenscar-thread.c
14324 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14325 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14326 (aarch64_ravenscar_fetch_registers)
14327 (aarch64_ravenscar_store_registers): Now methods.
14328 (aarch64_ravenscar_ops): Redefine.
14329
14330 2019-02-15 Tom Tromey <tromey@adacore.com>
14331
14332 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14333 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14334 (ravenscar_thread_target::stopped_by_watchpoint)
14335 (ravenscar_thread_target::stopped_data_address)
14336 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14337
14338 2019-02-15 Tom Tromey <tromey@adacore.com>
14339
14340 * ravenscar-thread.c: Fix some typos.
14341
14342 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14343 Tom Tromey <tromey@adacore.com>
14344
14345 * ada-lang.c (ada_exception_sal): Change addr_string to a
14346 std::string.
14347 (create_ada_exception_catchpoint): Update.
14348
14349 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14350 Tom Tromey <tromey@adacore.com>
14351
14352 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14353 (bp_location_ops): Remove.
14354 (base_breakpoint_allocate_location): Update.
14355 (free_bp_location): Update.
14356 * ada-lang.c (class ada_catchpoint_location)
14357 <ada_catchpoint_location>: Remove ops parameter.
14358 (ada_catchpoint_location_dtor): Remove.
14359 (ada_catchpoint_location_ops): Remove.
14360 (allocate_location_exception): Update.
14361 * breakpoint.h (struct bp_location_ops): Remove.
14362 (class bp_location) <bp_location>: Remove bp_location_ops
14363 parameter.
14364 <~bp_location>: Add destructor.
14365 <ops>: Remove.
14366
14367 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14368 Pedro Alves <palves@redhat.com>
14369
14370 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14371 'PATH_MAX'.
14372
14373 2019-02-14 David Michael <fedora.dm0@gmail.com>
14374 Samuel Thibault <samuel.thibault@gnu.org>
14375 Thomas Schwinge <thomas@codesourcery.com>
14376
14377 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14378 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14379
14380 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14381
14382 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14383 (check_empty): Use "const char *".
14384
14385 * gnu-nat.c (gnu_nat_target::detach): Instead of
14386 'detach_inferior (pid)' call
14387 'detach_inferior (find_inferior_pid (pid))'.
14388
14389 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14390 'nat/fork-inferior.o'.
14391 * gnu-nat.c: #include "nat/fork-inferior.h".
14392
14393 * gnu-nat.c (gnu_nat_target::detach): Instead of
14394 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14395 * gnu-nat.h: #include "inf-child.h".
14396 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14397 'i386_gnu_nat_target::fetch_registers'.
14398 (gnu_store_registers): Rename/move to
14399 'i386_gnu_nat_target::store_registers'.
14400
14401 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14402 * gnu-nat.h (mach_thread_info): New function.
14403 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14404
14405 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14406
14407 2019-02-14 Frederic Konrad <konrad@adacore.com>
14408
14409 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14410
14411 2019-02-14 Joel Brobecker <brobecker@adacore.com>
14412
14413 * windows-nat.c (windows_add_thread): Add new parameter
14414 "main_thread_p" with default value set to false. Update
14415 function documentation as well as all callers.
14416 (windows_delete_thread): Likewise.
14417 (fake_create_process): Update call to windows_add_thread.
14418 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14419 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14420 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14421 call to windows_delete_thread.
14422
14423 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14424
14425 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14426
14427 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14428
14429 * symfile.c (find_separate_debug_file): Use canonical path of
14430 sysroot with child_path instead of gdb_sysroot if it is valid.
14431
14432 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14433
14434 * symfile.c (find_separate_debug_file): Use child_path to
14435 determine if an object file is under a sysroot.
14436
14437 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14438
14439 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14440 unittests/child-path-selftests.c.
14441 * common/pathstuff.c (child_path): New function.
14442 * common/pathstuff.h (child_path): New prototype.
14443 * unittests/child-path-selftests.c: New file.
14444
14445 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14446
14447 * symfile.c (find_separate_debug_file): Look for separate debug
14448 files in debug directories under the sysroot.
14449
14450 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14451
14452 * symtab.h (struct minimal_symbol data_p): New const method.
14453 (struct minimal_symbol text_p): Likewise.
14454 * symtab.c (output_source_filename): Use file name style
14455 to print file name.
14456 (print_symbol_info): Likewise.
14457 (print_msymbol_info): Use address style to print addresses.
14458 Use function name style to print executable text symbols.
14459 (expand_symtab_containing_pc): Use data_p.
14460 (find_pc_sect_compunit_symtab): Likewise.
14461
14462 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14463
14464 * breakpoint.c (describe_other_breakpoints): Use address style
14465 to print addresses.
14466 (say_where): Likewise.
14467
14468 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14469
14470 * ada-typeprint.c (print_func_type): Print function name
14471 style to print function name.
14472 * c-typeprint.c (c_print_type_1): Likewise.
14473
14474 2019-02-11 Alan Hayward <alan.hayward@arm.com>
14475
14476 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14477 for execve.
14478
14479 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14480
14481 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14482 type_stack.
14483
14484 2019-02-10 Joel Brobecker <brobecker@adacore.com>
14485
14486 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14487 TYPE_CODE_REF types.
14488
14489 2019-02-08 Jim Wilson <jimw@sifive.com>
14490
14491 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14492 (riscv_linux_fregset): New.
14493 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14494
14495 2019-02-07 Tom Tromey <tom@tromey.com>
14496
14497 * thread.c (thread_cancel_execution_command): Update.
14498 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14499 methods.
14500 (struct thread_fsm_ops): Remove.
14501 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14502 (thread_fsm_should_stop, thread_fsm_return_value)
14503 (thread_fsm_set_finished, thread_fsm_finished_p)
14504 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14505 Don't declare.
14506 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14507 * infrun.c (clear_proceed_status_thread)
14508 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14509 (print_stop_event): Update.
14510 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14511 Add constructor.
14512 (step_command_fsm_ops): Remove.
14513 (new_step_command_fsm): Remove.
14514 (step_1): Update.
14515 (step_command_fsm::should_stop): Rename from
14516 step_command_fsm_should_stop.
14517 (step_command_fsm::clean_up): Rename from
14518 step_command_fsm_clean_up.
14519 (step_command_fsm::do_async_reply_reason): Rename from
14520 step_command_fsm_async_reply_reason.
14521 (struct until_next_fsm): Inherit from thread_fsm. Add
14522 constructor.
14523 (until_next_fsm_ops): Remove.
14524 (new_until_next_fsm): Remove.
14525 (until_next_fsm::should_stop): Rename from
14526 until_next_fsm_should_stop.
14527 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14528 (until_next_fsm::do_async_reply_reason): Rename from
14529 until_next_fsm_async_reply_reason.
14530 (struct finish_command_fsm): Inherit from thread_fsm. Add
14531 constructor. Change type of breakpoint.
14532 (finish_command_fsm_ops): Remove.
14533 (new_finish_command_fsm): Remove.
14534 (finish_command_fsm::should_stop): Rename from
14535 finish_command_fsm_should_stop.
14536 (finish_command_fsm::clean_up): Rename from
14537 finish_command_fsm_clean_up.
14538 (finish_command_fsm::return_value): Rename from
14539 finish_command_fsm_return_value.
14540 (finish_command_fsm::do_async_reply_reason): Rename from
14541 finish_command_fsm_async_reply_reason.
14542 (finish_command): Update.
14543 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14544 Add constructor.
14545 (call_thread_fsm_ops): Remove.
14546 (call_thread_fsm::call_thread_fsm): Rename from
14547 new_call_thread_fsm.
14548 (call_thread_fsm::should_stop): Rename from
14549 call_thread_fsm_should_stop.
14550 (call_thread_fsm::should_notify_stop): Rename from
14551 call_thread_fsm_should_notify_stop.
14552 (run_inferior_call, call_function_by_hand_dummy): Update.
14553 * cli/cli-interp.c (should_print_stop_to_console): Update.
14554 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14555 Add constructor. Change type of location_breakpoint,
14556 caller_breakpoint.
14557 (until_break_fsm_ops): Remove.
14558 (new_until_break_fsm): Remove.
14559 (until_break_fsm::should_stop): Rename from
14560 until_break_fsm_should_stop.
14561 (until_break_fsm::clean_up): Rename from
14562 until_break_fsm_clean_up.
14563 (until_break_fsm::do_async_reply_reason): Rename from
14564 until_break_fsm_async_reply_reason.
14565 (until_break_command): Update.
14566 * thread-fsm.c: Remove.
14567 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14568
14569 2019-02-07 Tom Tromey <tom@tromey.com>
14570
14571 * yy-remap.h: Add include guard.
14572 * xtensa-tdep.h: Add include guard.
14573 * xcoffread.h: Rename include guard.
14574 * varobj-iter.h: Add include guard.
14575 * tui/tui.h: Rename include guard.
14576 * tui/tui-winsource.h: Rename include guard.
14577 * tui/tui-wingeneral.h: Rename include guard.
14578 * tui/tui-windata.h: Rename include guard.
14579 * tui/tui-win.h: Rename include guard.
14580 * tui/tui-stack.h: Rename include guard.
14581 * tui/tui-source.h: Rename include guard.
14582 * tui/tui-regs.h: Rename include guard.
14583 * tui/tui-out.h: Rename include guard.
14584 * tui/tui-layout.h: Rename include guard.
14585 * tui/tui-io.h: Rename include guard.
14586 * tui/tui-hooks.h: Rename include guard.
14587 * tui/tui-file.h: Rename include guard.
14588 * tui/tui-disasm.h: Rename include guard.
14589 * tui/tui-data.h: Rename include guard.
14590 * tui/tui-command.h: Rename include guard.
14591 * tic6x-tdep.h: Add include guard.
14592 * target/waitstatus.h: Rename include guard.
14593 * target/wait.h: Rename include guard.
14594 * target/target.h: Rename include guard.
14595 * target/resume.h: Rename include guard.
14596 * target-float.h: Rename include guard.
14597 * stabsread.h: Add include guard.
14598 * rs6000-tdep.h: Add include guard.
14599 * riscv-fbsd-tdep.h: Add include guard.
14600 * regformats/regdef.h: Rename include guard.
14601 * record.h: Rename include guard.
14602 * python/python.h: Rename include guard.
14603 * python/python-internal.h: Rename include guard.
14604 * python/py-stopevent.h: Rename include guard.
14605 * python/py-ref.h: Rename include guard.
14606 * python/py-record.h: Rename include guard.
14607 * python/py-record-full.h: Rename include guard.
14608 * python/py-record-btrace.h: Rename include guard.
14609 * python/py-instruction.h: Rename include guard.
14610 * python/py-events.h: Rename include guard.
14611 * python/py-event.h: Rename include guard.
14612 * procfs.h: Add include guard.
14613 * proc-utils.h: Add include guard.
14614 * p-lang.h: Add include guard.
14615 * or1k-tdep.h: Rename include guard.
14616 * observable.h: Rename include guard.
14617 * nto-tdep.h: Rename include guard.
14618 * nat/x86-linux.h: Rename include guard.
14619 * nat/x86-linux-dregs.h: Rename include guard.
14620 * nat/x86-gcc-cpuid.h: Add include guard.
14621 * nat/x86-dregs.h: Rename include guard.
14622 * nat/x86-cpuid.h: Rename include guard.
14623 * nat/ppc-linux.h: Rename include guard.
14624 * nat/mips-linux-watch.h: Rename include guard.
14625 * nat/linux-waitpid.h: Rename include guard.
14626 * nat/linux-ptrace.h: Rename include guard.
14627 * nat/linux-procfs.h: Rename include guard.
14628 * nat/linux-osdata.h: Rename include guard.
14629 * nat/linux-nat.h: Rename include guard.
14630 * nat/linux-namespaces.h: Rename include guard.
14631 * nat/linux-btrace.h: Rename include guard.
14632 * nat/glibc_thread_db.h: Rename include guard.
14633 * nat/gdb_thread_db.h: Rename include guard.
14634 * nat/gdb_ptrace.h: Rename include guard.
14635 * nat/fork-inferior.h: Rename include guard.
14636 * nat/amd64-linux-siginfo.h: Rename include guard.
14637 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14638 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14639 * nat/aarch64-linux.h: Rename include guard.
14640 * nat/aarch64-linux-hw-point.h: Rename include guard.
14641 * mn10300-tdep.h: Add include guard.
14642 * mips-linux-tdep.h: Add include guard.
14643 * mi/mi-parse.h: Rename include guard.
14644 * mi/mi-out.h: Rename include guard.
14645 * mi/mi-main.h: Rename include guard.
14646 * mi/mi-interp.h: Rename include guard.
14647 * mi/mi-getopt.h: Rename include guard.
14648 * mi/mi-console.h: Rename include guard.
14649 * mi/mi-common.h: Rename include guard.
14650 * mi/mi-cmds.h: Rename include guard.
14651 * mi/mi-cmd-break.h: Rename include guard.
14652 * m2-lang.h: Add include guard.
14653 * location.h: Rename include guard.
14654 * linux-record.h: Rename include guard.
14655 * linux-nat.h: Add include guard.
14656 * linux-fork.h: Add include guard.
14657 * i386-darwin-tdep.h: Rename include guard.
14658 * hppa-linux-offsets.h: Add include guard.
14659 * guile/guile.h: Rename include guard.
14660 * guile/guile-internal.h: Rename include guard.
14661 * gnu-nat.h: Rename include guard.
14662 * gdb-stabs.h: Rename include guard.
14663 * frv-tdep.h: Add include guard.
14664 * f-lang.h: Add include guard.
14665 * event-loop.h: Add include guard.
14666 * darwin-nat.h: Rename include guard.
14667 * cp-abi.h: Rename include guard.
14668 * config/sparc/nm-sol2.h: Rename include guard.
14669 * config/nm-nto.h: Rename include guard.
14670 * config/nm-linux.h: Add include guard.
14671 * config/i386/nm-i386gnu.h: Rename include guard.
14672 * config/djgpp/nl_types.h: Rename include guard.
14673 * config/djgpp/langinfo.h: Rename include guard.
14674 * compile/gcc-cp-plugin.h: Add include guard.
14675 * compile/gcc-c-plugin.h: Add include guard.
14676 * compile/compile.h: Rename include guard.
14677 * compile/compile-object-run.h: Rename include guard.
14678 * compile/compile-object-load.h: Rename include guard.
14679 * compile/compile-internal.h: Rename include guard.
14680 * compile/compile-cplus.h: Rename include guard.
14681 * compile/compile-c.h: Rename include guard.
14682 * common/xml-utils.h: Rename include guard.
14683 * common/x86-xstate.h: Rename include guard.
14684 * common/version.h: Rename include guard.
14685 * common/vec.h: Rename include guard.
14686 * common/tdesc.h: Rename include guard.
14687 * common/selftest.h: Rename include guard.
14688 * common/scoped_restore.h: Rename include guard.
14689 * common/scoped_mmap.h: Rename include guard.
14690 * common/scoped_fd.h: Rename include guard.
14691 * common/safe-iterator.h: Rename include guard.
14692 * common/run-time-clock.h: Rename include guard.
14693 * common/refcounted-object.h: Rename include guard.
14694 * common/queue.h: Rename include guard.
14695 * common/ptid.h: Rename include guard.
14696 * common/print-utils.h: Rename include guard.
14697 * common/preprocessor.h: Rename include guard.
14698 * common/pathstuff.h: Rename include guard.
14699 * common/observable.h: Rename include guard.
14700 * common/netstuff.h: Rename include guard.
14701 * common/job-control.h: Rename include guard.
14702 * common/host-defs.h: Rename include guard.
14703 * common/gdb_wait.h: Rename include guard.
14704 * common/gdb_vecs.h: Rename include guard.
14705 * common/gdb_unlinker.h: Rename include guard.
14706 * common/gdb_unique_ptr.h: Rename include guard.
14707 * common/gdb_tilde_expand.h: Rename include guard.
14708 * common/gdb_sys_time.h: Rename include guard.
14709 * common/gdb_string_view.h: Rename include guard.
14710 * common/gdb_splay_tree.h: Rename include guard.
14711 * common/gdb_setjmp.h: Rename include guard.
14712 * common/gdb_ref_ptr.h: Rename include guard.
14713 * common/gdb_optional.h: Rename include guard.
14714 * common/gdb_locale.h: Rename include guard.
14715 * common/gdb_assert.h: Rename include guard.
14716 * common/filtered-iterator.h: Rename include guard.
14717 * common/filestuff.h: Rename include guard.
14718 * common/fileio.h: Rename include guard.
14719 * common/environ.h: Rename include guard.
14720 * common/common-utils.h: Rename include guard.
14721 * common/common-types.h: Rename include guard.
14722 * common/common-regcache.h: Rename include guard.
14723 * common/common-inferior.h: Rename include guard.
14724 * common/common-gdbthread.h: Rename include guard.
14725 * common/common-exceptions.h: Rename include guard.
14726 * common/common-defs.h: Rename include guard.
14727 * common/common-debug.h: Rename include guard.
14728 * common/cleanups.h: Rename include guard.
14729 * common/buffer.h: Rename include guard.
14730 * common/btrace-common.h: Rename include guard.
14731 * common/break-common.h: Rename include guard.
14732 * cli/cli-utils.h: Rename include guard.
14733 * cli/cli-style.h: Rename include guard.
14734 * cli/cli-setshow.h: Rename include guard.
14735 * cli/cli-script.h: Rename include guard.
14736 * cli/cli-interp.h: Rename include guard.
14737 * cli/cli-decode.h: Rename include guard.
14738 * cli/cli-cmds.h: Rename include guard.
14739 * charset-list.h: Add include guard.
14740 * buildsym-legacy.h: Rename include guard.
14741 * bfin-tdep.h: Add include guard.
14742 * ax.h: Rename include guard.
14743 * arm-linux-tdep.h: Add include guard.
14744 * arm-fbsd-tdep.h: Add include guard.
14745 * arch/xtensa.h: Rename include guard.
14746 * arch/tic6x.h: Add include guard.
14747 * arch/i386.h: Add include guard.
14748 * arch/arm.h: Rename include guard.
14749 * arch/arm-linux.h: Rename include guard.
14750 * arch/arm-get-next-pcs.h: Rename include guard.
14751 * arch/amd64.h: Add include guard.
14752 * arch/aarch64-insn.h: Rename include guard.
14753 * arch-utils.h: Rename include guard.
14754 * annotate.h: Add include guard.
14755 * amd64-darwin-tdep.h: Rename include guard.
14756 * aarch64-linux-tdep.h: Add include guard.
14757 * aarch64-fbsd-tdep.h: Add include guard.
14758 * aarch32-linux-nat.h: Add include guard.
14759
14760 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14761
14762 * macrotab.c (macro_define_internal): New function that
14763 factorizes macro_define_object_internal and macro_define_function
14764 code.
14765 (macro_define_object_internal): Use macro_define_internal.
14766 (macro_define_function): Likewise.
14767
14768 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14769
14770 * macrocmd.c (extract_identifier): Return
14771 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14772 callers.
14773
14774 2019-02-06 John Baldwin <jhb@FreeBSD.org>
14775
14776 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14777
14778 2019-02-05 Tom Tromey <tom@tromey.com>
14779
14780 * target.c (target_stack::unpush): Move assertion earlier.
14781
14782 2019-01-30 Tom Tromey <tom@tromey.com>
14783
14784 PR python/23615:
14785 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14786 (gdbpy_parse_and_eval): Likewise.
14787 * python/python-internal.h (gdbpy_allow_threads): New class.
14788
14789 2019-01-28 John Baldwin <jhb@FreeBSD.org>
14790
14791 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14792 (aarch64_fbsd_fpregmap): Move earlier.
14793 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14794 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14795 instead of individual calls to trad_frame_set_reg_addr.
14796 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14797 earlier.
14798 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14799 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14800 instead of individual calls to trad_frame_set_reg_addr.
14801
14802 2019-01-28 Alan Hayward <alan.hayward@arm.com>
14803
14804 * CONTRIBUTE: Replace contribution list with wiki link.
14805
14806 2019-01-25 Tom Tromey <tom@tromey.com>
14807
14808 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14809
14810 2019-01-25 Tom Tromey <tom@tromey.com>
14811
14812 * xtensa-linux-nat.c: Fix common/ includes.
14813 * xml-support.h: Fix common/ includes.
14814 * xml-support.c: Fix common/ includes.
14815 * x86-linux-nat.c: Fix common/ includes.
14816 * windows-nat.c: Fix common/ includes.
14817 * varobj.h: Fix common/ includes.
14818 * varobj.c: Fix common/ includes.
14819 * value.c: Fix common/ includes.
14820 * valops.c: Fix common/ includes.
14821 * utils.c: Fix common/ includes.
14822 * unittests/xml-utils-selftests.c: Fix common/ includes.
14823 * unittests/utils-selftests.c: Fix common/ includes.
14824 * unittests/unpack-selftests.c: Fix common/ includes.
14825 * unittests/tracepoint-selftests.c: Fix common/ includes.
14826 * unittests/style-selftests.c: Fix common/ includes.
14827 * unittests/string_view-selftests.c: Fix common/ includes.
14828 * unittests/scoped_restore-selftests.c: Fix common/ includes.
14829 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14830 * unittests/scoped_fd-selftests.c: Fix common/ includes.
14831 * unittests/rsp-low-selftests.c: Fix common/ includes.
14832 * unittests/parse-connection-spec-selftests.c: Fix common/
14833 includes.
14834 * unittests/optional-selftests.c: Fix common/ includes.
14835 * unittests/offset-type-selftests.c: Fix common/ includes.
14836 * unittests/observable-selftests.c: Fix common/ includes.
14837 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14838 * unittests/memrange-selftests.c: Fix common/ includes.
14839 * unittests/memory-map-selftests.c: Fix common/ includes.
14840 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14841 * unittests/function-view-selftests.c: Fix common/ includes.
14842 * unittests/environ-selftests.c: Fix common/ includes.
14843 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14844 * unittests/common-utils-selftests.c: Fix common/ includes.
14845 * unittests/cli-utils-selftests.c: Fix common/ includes.
14846 * unittests/array-view-selftests.c: Fix common/ includes.
14847 * ui-file.c: Fix common/ includes.
14848 * tui/tui-io.c: Fix common/ includes.
14849 * tracepoint.h: Fix common/ includes.
14850 * tracepoint.c: Fix common/ includes.
14851 * tracefile-tfile.c: Fix common/ includes.
14852 * top.h: Fix common/ includes.
14853 * top.c: Fix common/ includes.
14854 * thread.c: Fix common/ includes.
14855 * target/waitstatus.h: Fix common/ includes.
14856 * target/waitstatus.c: Fix common/ includes.
14857 * target.h: Fix common/ includes.
14858 * target.c: Fix common/ includes.
14859 * target-memory.c: Fix common/ includes.
14860 * target-descriptions.c: Fix common/ includes.
14861 * symtab.h: Fix common/ includes.
14862 * symfile.c: Fix common/ includes.
14863 * stap-probe.c: Fix common/ includes.
14864 * spu-linux-nat.c: Fix common/ includes.
14865 * sparc-nat.c: Fix common/ includes.
14866 * source.c: Fix common/ includes.
14867 * solib.c: Fix common/ includes.
14868 * solib-target.c: Fix common/ includes.
14869 * ser-unix.c: Fix common/ includes.
14870 * ser-tcp.c: Fix common/ includes.
14871 * ser-pipe.c: Fix common/ includes.
14872 * ser-base.c: Fix common/ includes.
14873 * selftest-arch.c: Fix common/ includes.
14874 * s12z-tdep.c: Fix common/ includes.
14875 * rust-exp.y: Fix common/ includes.
14876 * rs6000-aix-tdep.c: Fix common/ includes.
14877 * riscv-tdep.c: Fix common/ includes.
14878 * remote.c: Fix common/ includes.
14879 * remote-notif.h: Fix common/ includes.
14880 * remote-fileio.h: Fix common/ includes.
14881 * remote-fileio.c: Fix common/ includes.
14882 * regcache.h: Fix common/ includes.
14883 * regcache.c: Fix common/ includes.
14884 * record-btrace.c: Fix common/ includes.
14885 * python/python.c: Fix common/ includes.
14886 * python/py-type.c: Fix common/ includes.
14887 * python/py-inferior.c: Fix common/ includes.
14888 * progspace.h: Fix common/ includes.
14889 * producer.c: Fix common/ includes.
14890 * procfs.c: Fix common/ includes.
14891 * proc-api.c: Fix common/ includes.
14892 * printcmd.c: Fix common/ includes.
14893 * ppc-linux-nat.c: Fix common/ includes.
14894 * parser-defs.h: Fix common/ includes.
14895 * osdata.c: Fix common/ includes.
14896 * obsd-nat.c: Fix common/ includes.
14897 * nat/x86-linux.c: Fix common/ includes.
14898 * nat/x86-linux-dregs.c: Fix common/ includes.
14899 * nat/x86-dregs.h: Fix common/ includes.
14900 * nat/x86-dregs.c: Fix common/ includes.
14901 * nat/ppc-linux.c: Fix common/ includes.
14902 * nat/mips-linux-watch.h: Fix common/ includes.
14903 * nat/mips-linux-watch.c: Fix common/ includes.
14904 * nat/linux-waitpid.c: Fix common/ includes.
14905 * nat/linux-ptrace.h: Fix common/ includes.
14906 * nat/linux-ptrace.c: Fix common/ includes.
14907 * nat/linux-procfs.c: Fix common/ includes.
14908 * nat/linux-personality.c: Fix common/ includes.
14909 * nat/linux-osdata.c: Fix common/ includes.
14910 * nat/linux-namespaces.c: Fix common/ includes.
14911 * nat/linux-btrace.h: Fix common/ includes.
14912 * nat/linux-btrace.c: Fix common/ includes.
14913 * nat/fork-inferior.c: Fix common/ includes.
14914 * nat/amd64-linux-siginfo.c: Fix common/ includes.
14915 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
14916 * nat/aarch64-linux.c: Fix common/ includes.
14917 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
14918 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
14919 * namespace.h: Fix common/ includes.
14920 * mips-linux-tdep.c: Fix common/ includes.
14921 * minsyms.c: Fix common/ includes.
14922 * mi/mi-parse.h: Fix common/ includes.
14923 * mi/mi-main.c: Fix common/ includes.
14924 * mi/mi-cmd-env.c: Fix common/ includes.
14925 * memrange.h: Fix common/ includes.
14926 * memattr.c: Fix common/ includes.
14927 * maint.h: Fix common/ includes.
14928 * maint.c: Fix common/ includes.
14929 * main.c: Fix common/ includes.
14930 * machoread.c: Fix common/ includes.
14931 * location.c: Fix common/ includes.
14932 * linux-thread-db.c: Fix common/ includes.
14933 * linux-nat.c: Fix common/ includes.
14934 * linux-fork.c: Fix common/ includes.
14935 * inline-frame.c: Fix common/ includes.
14936 * infrun.c: Fix common/ includes.
14937 * inflow.c: Fix common/ includes.
14938 * inferior.h: Fix common/ includes.
14939 * inferior.c: Fix common/ includes.
14940 * infcmd.c: Fix common/ includes.
14941 * inf-ptrace.c: Fix common/ includes.
14942 * inf-child.c: Fix common/ includes.
14943 * ia64-linux-nat.c: Fix common/ includes.
14944 * i387-tdep.c: Fix common/ includes.
14945 * i386-tdep.c: Fix common/ includes.
14946 * i386-linux-tdep.c: Fix common/ includes.
14947 * i386-linux-nat.c: Fix common/ includes.
14948 * i386-go32-tdep.c: Fix common/ includes.
14949 * i386-fbsd-tdep.c: Fix common/ includes.
14950 * i386-fbsd-nat.c: Fix common/ includes.
14951 * guile/scm-type.c: Fix common/ includes.
14952 * guile/guile.c: Fix common/ includes.
14953 * go32-nat.c: Fix common/ includes.
14954 * gnu-nat.c: Fix common/ includes.
14955 * gdbthread.h: Fix common/ includes.
14956 * gdbarch-selftests.c: Fix common/ includes.
14957 * gdb_usleep.c: Fix common/ includes.
14958 * gdb_select.h: Fix common/ includes.
14959 * gdb_bfd.c: Fix common/ includes.
14960 * gcore.c: Fix common/ includes.
14961 * fork-child.c: Fix common/ includes.
14962 * findvar.c: Fix common/ includes.
14963 * fbsd-nat.c: Fix common/ includes.
14964 * event-top.c: Fix common/ includes.
14965 * event-loop.c: Fix common/ includes.
14966 * dwarf2read.c: Fix common/ includes.
14967 * dwarf2loc.c: Fix common/ includes.
14968 * dwarf2-frame.c: Fix common/ includes.
14969 * dwarf-index-cache.c: Fix common/ includes.
14970 * dtrace-probe.c: Fix common/ includes.
14971 * disasm-selftests.c: Fix common/ includes.
14972 * defs.h: Fix common/ includes.
14973 * csky-tdep.c: Fix common/ includes.
14974 * cp-valprint.c: Fix common/ includes.
14975 * cp-support.h: Fix common/ includes.
14976 * cp-support.c: Fix common/ includes.
14977 * corelow.c: Fix common/ includes.
14978 * completer.h: Fix common/ includes.
14979 * completer.c: Fix common/ includes.
14980 * compile/compile.c: Fix common/ includes.
14981 * compile/compile-loc2c.c: Fix common/ includes.
14982 * compile/compile-cplus-types.c: Fix common/ includes.
14983 * compile/compile-cplus-symbols.c: Fix common/ includes.
14984 * command.h: Fix common/ includes.
14985 * cli/cli-dump.c: Fix common/ includes.
14986 * cli/cli-cmds.c: Fix common/ includes.
14987 * charset.c: Fix common/ includes.
14988 * build-id.c: Fix common/ includes.
14989 * btrace.h: Fix common/ includes.
14990 * btrace.c: Fix common/ includes.
14991 * breakpoint.h: Fix common/ includes.
14992 * breakpoint.c: Fix common/ includes.
14993 * ax.h:
14994 (enum agent_op): Fix common/ includes.
14995 * ax-general.c (struct aop_map): Fix common/ includes.
14996 * ax-gdb.c: Fix common/ includes.
14997 * auxv.c: Fix common/ includes.
14998 * auto-load.c: Fix common/ includes.
14999 * arm-tdep.c: Fix common/ includes.
15000 * arch/riscv.c: Fix common/ includes.
15001 * arch/ppc-linux-common.c: Fix common/ includes.
15002 * arch/i386.c: Fix common/ includes.
15003 * arch/arm.c: Fix common/ includes.
15004 * arch/arm-linux.c: Fix common/ includes.
15005 * arch/arm-get-next-pcs.c: Fix common/ includes.
15006 * arch/amd64.c: Fix common/ includes.
15007 * arch/aarch64.c: Fix common/ includes.
15008 * arch/aarch64-insn.c: Fix common/ includes.
15009 * arch-utils.c: Fix common/ includes.
15010 * amd64-windows-tdep.c: Fix common/ includes.
15011 * amd64-tdep.c: Fix common/ includes.
15012 * amd64-sol2-tdep.c: Fix common/ includes.
15013 * amd64-obsd-tdep.c: Fix common/ includes.
15014 * amd64-nbsd-tdep.c: Fix common/ includes.
15015 * amd64-linux-tdep.c: Fix common/ includes.
15016 * amd64-linux-nat.c: Fix common/ includes.
15017 * amd64-fbsd-tdep.c: Fix common/ includes.
15018 * amd64-fbsd-nat.c: Fix common/ includes.
15019 * amd64-dicos-tdep.c: Fix common/ includes.
15020 * amd64-darwin-tdep.c: Fix common/ includes.
15021 * agent.c: Fix common/ includes.
15022 * ada-lang.h: Fix common/ includes.
15023 * ada-lang.c: Fix common/ includes.
15024 * aarch64-tdep.c: Fix common/ includes.
15025
15026 2019-01-25 Tom Tromey <tom@tromey.com>
15027
15028 * common/create-version.sh: Use common/version.h.
15029
15030 2019-01-24 Pedro Alves <palves@redhat.com>
15031
15032 * infrun.c (signal_stop, signal_print, signal_program)
15033 (signal_catch, signal_pass): Now arrays instead of pointers.
15034 (update_signals_program_target, do_target_resume)
15035 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15036 * linux-nat.c (linux_nat_target::pass_signals)
15037 (linux_nat_target::create_inferior, linux_nat_target::attach):
15038 Adjust.
15039 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15040 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15041 * procfs.c (procfs_target::pass_signals): Adjust.
15042 * record-full.c (record_full_target::resume): Adjust.
15043 * remote.c (remote_target::pass_signals)
15044 (remote_target::program_signals): Adjust.
15045 * target-debug.h (target_debug_print_signals): Now takes a
15046 gdb::array_view as parameter. Adjust.
15047 * target.h (target_ops) <pass_signals, program_signals>: Replace
15048 pointer and length parameters with gdb::array_view.
15049 (target_pass_signals, target_program_signals): Likewise.
15050 * target-delegates.c: Regenerate.
15051
15052 2019-01-24 Pedro Alves <palves@redhat.com>
15053
15054 * common/forward-scope-exit.h
15055 (forward_scope_exit::forward_scope_exit): Pass arguments to
15056 m_bind_function directly, instead of creating a std::bind and
15057 copying that.
15058
15059 2019-01-24 Alan Hayward <alan.hayward@arm.com>
15060
15061 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15062 for static members.
15063 (pass_in_v_vfp_candidate): Likewise.
15064
15065 2019-01-23 Tom Tromey <tom@tromey.com>
15066 Pedro Alves <palves@redhat.com>
15067
15068 * regcache.c (class regcache_invalidator): Remove.
15069 (regcache::raw_write): Use make_scope_exit.
15070
15071 2019-01-23 Tom Tromey <tom@tromey.com>
15072
15073 * ui-out.h (class ui_out_emit_type): Update comment.
15074
15075 2019-01-23 Tom Tromey <tom@tromey.com>
15076
15077 * infrun.c (fetch_inferior_event): Update comment.
15078
15079 2019-01-23 Tom Tromey <tom@tromey.com>
15080 Pedro Alves <palves@redhat.com>
15081
15082 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15083 parameter.
15084 (fetch_inferior_event): Use SCOPE_EXIT.
15085
15086
15087 2019-01-23 Tom Tromey <tom@tromey.com>
15088 Pedro Alves <palves@redhat.com>
15089
15090 * infrun.c (disable_thread_events): Delete.
15091 (stop_all_threads): Use SCOPE_EXIT.
15092
15093 2019-01-23 Tom Tromey <tom@tromey.com>
15094 Pedro Alves <palves@redhat.com>
15095
15096 * symfile.c: Include forward-scope-exit.h.
15097 (clear_symtab_users_cleanup): Replace forward declaration with
15098 a FORWARD_SCOPE_EXIT.
15099 (syms_from_objfile_1): Use the forward_scope_exit and
15100 gdb::optional instead of cleanup_function.
15101 (reread_symbols): Use the forward_scope_exit instead of
15102 cleanup_function.
15103 (clear_symtab_users_cleanup): Remove function.
15104
15105 2019-01-23 Tom Tromey <tom@tromey.com>
15106 Pedro Alves <palves@redhat.com>
15107
15108 * linux-nat.c: Include scope-exit.h.
15109 (cleanup_target_stop): Remove.
15110 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15111 SCOPE_EXIT.
15112
15113 2019-01-23 Tom Tromey <tom@tromey.com>
15114 Pedro Alves <palves@redhat.com>
15115
15116 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15117 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15118
15119 2019-01-23 Tom Tromey <tom@tromey.com>
15120 Andrew Burgess <andrew.burgess@embecosm.com>
15121 Pedro Alves <palves@redhat.com>
15122
15123 * infrun.c (fetch_inferior_event): Use scope_exit.
15124 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15125 * top.c (execute_command): Use scope_exit.
15126 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15127 * utils.c (do_bpstat_clear_actions_cleanup)
15128 (make_bpstat_clear_actions_cleanup): Remove.
15129
15130 2019-01-23 Tom Tromey <tom@tromey.com>
15131 Pedro Alves <palves@redhat.com>
15132
15133 * infrun.c: Include "common/scope-exit.h"
15134 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15135 (wait_for_inferior): Use SCOPE_EXIT.
15136 (fetch_inferior_event): Use scope_exit.
15137
15138 2019-01-23 Tom Tromey <tom@tromey.com>
15139 Pedro Alves <palves@redhat.com>
15140
15141 * breakpoint.c (create_breakpoint): Remove cleanup.
15142
15143 2019-01-23 Tom Tromey <tom@tromey.com>
15144 Andrew Burgess <andrew.burgess@embecosm.com>
15145 Pedro Alves <palves@redhat.com>
15146
15147 2019-01-23 Pedro Alves <palves@redhat.com>
15148
15149 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15150
15151 2019-01-23 Pedro Alves <palves@redhat.com>
15152 Andrew Burgess <andrew.burgess@embecosm.com>
15153
15154 * gdbthread.h: Include "common/forward-scope-exit.h".
15155 (scoped_finish_thread_state): Redefine custom class in terms of
15156 forward_scope_exit.
15157
15158 2019-01-23 Pedro Alves <palves@redhat.com>
15159 Andrew Burgess <andrew.burgess@embecosm.com>
15160
15161 * common/forward-scope-exit.h: New file.
15162
15163 2019-01-23 Pedro Alves <palves@redhat.com>
15164 Andrew Burgess <andrew.burgess@embecosm.com>
15165 Tom Tromey <tom@tromey.com>
15166
15167 * common/scope-exit.h: New file.
15168
15169 2019-01-23 Pedro Alves <palves@redhat.com>
15170
15171 * common/preprocessor.h (ESC): Rename to ...
15172 (ESC_PARENS): ... this.
15173 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15174 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15175
15176 2019-01-23 Tom Tromey <tom@tromey.com>
15177
15178 * language.h (class scoped_switch_to_sym_language_if_auto):
15179 Initialize m_lang in both cases.
15180
15181 2019-01-23 Alan Hayward <alan.hayward@arm.com>
15182
15183 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15184 with XCNEW.
15185
15186 2019-01-22 Tom Tromey <tom@tromey.com>
15187
15188 * corelow.c: Do not include sys/file.h.
15189
15190 2019-01-22 Tom Tromey <tom@tromey.com>
15191
15192 * tui/tui-wingeneral.h: Include gdb_curses.h.
15193
15194 2019-01-22 Tom Tromey <tom@tromey.com>
15195
15196 * source-cache.h (class source_cache) <get_source_lines,
15197 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15198
15199 2019-01-22 Tom Tromey <tom@tromey.com>
15200
15201 * remote-fileio.h (struct remote_target): Declare.
15202
15203 2019-01-22 Tom Tromey <tom@tromey.com>
15204
15205 * python/py-arch.c: Do not include py-ref.h.
15206 * python/py-bpevent.c: Do not include py-ref.h.
15207 * python/py-cmd.c: Do not include py-ref.h.
15208 * python/py-continueevent.c: Do not include py-ref.h.
15209 * python/py-event.h: Do not include py-ref.h.
15210 * python/py-evtregistry.c: Do not include py-ref.h.
15211 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15212 * python/py-frame.c: Do not include py-ref.h.
15213 * python/py-framefilter.c: Do not include py-ref.h.
15214 * python/py-function.c: Do not include py-ref.h.
15215 * python/py-infevents.c: Do not include py-ref.h.
15216 * python/py-linetable.c: Do not include py-ref.h.
15217 * python/py-objfile.c: Do not include py-ref.h.
15218 * python/py-param.c: Do not include py-ref.h.
15219 * python/py-prettyprint.c: Do not include py-ref.h.
15220 * python/py-progspace.c: Do not include py-ref.h.
15221 * python/py-symbol.c: Do not include py-ref.h.
15222 * python/py-symtab.c: Do not include py-ref.h.
15223 * python/py-type.c: Do not include py-ref.h.
15224 * python/py-unwind.c: Do not include py-ref.h.
15225 * python/py-utils.c: Do not include py-ref.h.
15226 * python/py-value.c: Do not include py-ref.h.
15227 * python/py-varobj.c: Do not include py-ref.h.
15228 * python/py-xmethods.c: Do not include py-ref.h.
15229 * python/python.c: Do not include py-ref.h.
15230 * varobj.c: Do not include py-ref.h.
15231
15232 2019-01-22 Tom Tromey <tom@tromey.com>
15233
15234 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15235 keyword for bcache.
15236
15237 2019-01-22 Tom Tromey <tom@tromey.com>
15238
15239 * compile/compile-cplus-types.c: Remove a comment by #include.
15240
15241 2019-01-22 Tom Tromey <tom@tromey.com>
15242
15243 * compile/gcc-c-plugin.h: Include compile-internal.h.
15244
15245 2019-01-22 Tom Tromey <tom@tromey.com>
15246
15247 * stabsread.c (EXTERN): Do not define.
15248 (symnum, next_symbol_text_func, processing_gcc_compilation)
15249 (within_function, global_sym_chain, global_stabs)
15250 (previous_stab_code, this_object_header_files)
15251 (n_this_object_header_files)
15252 (n_allocated_this_object_header_files): Define.
15253 * stabsread.h (EXTERN): Never define. Use "extern".
15254
15255 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15256
15257 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15258 history_value.
15259
15260 2019-01-21 Tom Tromey <tom@tromey.com>
15261
15262 * ui-out.c: Fix includes.
15263 * tui/tui-source.c: Fix includes.
15264 * target.c: Fix includes.
15265 * remote.c: Fix includes.
15266 * regcache.c: Fix includes.
15267 * python/py-block.c: Fix includes.
15268 * printcmd.c: Fix includes.
15269 * or1k-tdep.c: Fix includes.
15270 * mi/mi-main.c: Fix includes.
15271 * m32r-tdep.c: Fix includes.
15272 * csky-tdep.c: Fix includes.
15273 * compile/compile-cplus-types.c: Fix includes.
15274 * cli/cli-interp.c: Fix includes.
15275
15276 2019-01-21 Alan Hayward <alan.hayward@arm.com>
15277
15278 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15279 for padding.
15280
15281 2019-01-16 Tom Tromey <tom@tromey.com>
15282
15283 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15284 earlier.
15285 (struct objfile) <msymbols_range>: Move from top level.
15286 <msymbols>: New method.
15287 (class objfile_msymbols): Remove.
15288 * symtab.c (default_collect_symbol_completion_matches_break_on):
15289 Update.
15290 * symmisc.c (dump_msymbols): Update.
15291 * stabsread.c (scan_file_globals): Update.
15292 * objc-lang.c (info_selectors_command, info_classes_command)
15293 (find_methods): Update.
15294 * minsyms.c (find_solib_trampoline_target): Update.
15295 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15296 * coffread.c (coff_symfile_read): Update.
15297 * ada-lang.c (ada_lookup_simple_minsym)
15298 (ada_collect_symbol_completion_matches): Update.
15299
15300 2019-01-16 Tom Tromey <tom@tromey.com>
15301
15302 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15303 type. Remove no-argument constructor.
15304 <iterator::operator++>: Simplify.
15305 <begin>: Update.
15306 <end>: Use minimal_symbol_count.
15307
15308 2019-01-16 Tom Tromey <tom@tromey.com>
15309
15310 * objfiles.h (struct objfile) <psymtabs>: New method.
15311 (class objfile_psymtabs): Remove.
15312 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15313 typedef.
15314 <range>: New method.
15315 (require_partial_symbols): Change return type.
15316 * psymtab.c (require_partial_symbols)
15317 (psym_expand_symtabs_matching): Update.
15318 * mdebugread.c (parse_partial_symbols): Update.
15319 * dbxread.c (dbx_end_psymtab): Update.
15320
15321 2019-01-15 Tom Tromey <tom@tromey.com>
15322
15323 * symtab.c (lookup_objfile_from_block)
15324 (lookup_symbol_in_objfile_symtabs)
15325 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15326 (find_line_symtab, info_sources_command)
15327 (default_collect_symbol_completion_matches_break_on)
15328 (make_source_files_completion_list): Update.
15329 * symmisc.c (print_objfile_statistics, dump_objfile)
15330 (maintenance_print_symbols, maintenance_info_symtabs)
15331 (maintenance_check_symtabs, maintenance_info_line_tables):
15332 Update.
15333 * source.c (select_source_symtab)
15334 (forget_cached_source_info_for_objfile): Update.
15335 * objfiles.h (class objfile_compunits): Remove.
15336 (struct objfile) <compunits_range>: New typedef.
15337 (compunits): New method.
15338 * objfiles.c (objfile_relocate1): Update.
15339 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15340 * maint.c (count_symtabs_and_blocks): Update.
15341 * linespec.c (iterate_over_all_matching_symtabs): Update.
15342 * cp-support.c (add_symbol_overload_list_qualified): Update.
15343 * coffread.c (coff_symtab_read): Update.
15344 * ada-lang.c (add_nonlocal_symbols)
15345 (ada_collect_symbol_completion_matches)
15346 (ada_add_global_exceptions): Update.
15347
15348 2019-01-15 Tom Tromey <tom@tromey.com>
15349
15350 * progspace.h (program_space) <objfiles_safe_range>: New
15351 typedef.
15352 <objfiles_safe>: New method.
15353 * objfiles.h (class all_objfiles_safe): Remove.
15354 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15355 * jit.c (jit_inferior_exit_hook): Update.
15356
15357 2019-01-17 Tom Tromey <tom@tromey.com>
15358
15359 * progspace.h (program_space) <objfiles_range>: New typedef.
15360 <objfiles>: New method.
15361 <objfiles_head>: Rename from objfiles.
15362 (object_files): Update.
15363 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15364 * guile/scm-pretty-print.c
15365 (ppscm_find_pretty_printer_from_objfiles): Update.
15366 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15367 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15368 Update.
15369 * python/py-progspace.c (pspy_get_objfiles): Update.
15370 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15371 Update.
15372 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15373 (objfpy_lookup_objfile_by_build_id): Update.
15374 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15375 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15376 Update.
15377 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15378 (expand_symtab_containing_pc, lookup_objfile_from_block)
15379 (lookup_static_symbol, basic_lookup_transparent_type)
15380 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15381 (find_line_symtab, info_sources_command)
15382 (default_collect_symbol_completion_matches_break_on)
15383 (make_source_files_completion_list, find_main_name): Update.
15384 * symmisc.c (print_symbol_bcache_statistics)
15385 (print_objfile_statistics, maintenance_print_symbols)
15386 (maintenance_print_msymbols, maintenance_print_objfiles)
15387 (maintenance_info_symtabs, maintenance_check_symtabs)
15388 (maintenance_expand_symtabs, maintenance_info_line_tables):
15389 Update.
15390 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15391 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15392 (map_overlay_command, unmap_overlay_command)
15393 (simple_overlay_update, expand_symtabs_matching)
15394 (map_symbol_filenames): Update.
15395 * symfile-debug.c (set_debug_symfile): Update.
15396 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15397 Update.
15398 * source.c (select_source_symtab, forget_cached_source_info):
15399 Update.
15400 * solib.c (solib_read_symbols): Update.
15401 * solib-spu.c (append_ocl_sos): Update.
15402 * psymtab.c (maintenance_print_psymbols)
15403 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15404 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15405 * printcmd.c (info_symbol_command): Update.
15406 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15407 Update.
15408 * objfiles.h (class all_objfiles): Remove.
15409 * objfiles.c (have_partial_symbols, have_full_symbols)
15410 (have_minimal_symbols, qsort_cmp, update_section_map)
15411 (shared_objfile_contains_address_p)
15412 (default_iterate_over_objfiles_in_search_order): Update.
15413 * objc-lang.c (info_selectors_command, info_classes_command)
15414 (find_methods): Update.
15415 * minsyms.c (find_solib_trampoline_target): Update.
15416 * maint.c (maintenance_info_sections)
15417 (maintenance_translate_address, count_symtabs_and_blocks):
15418 Update.
15419 * main.c (captured_main_1): Update.
15420 * linux-thread-db.c (try_thread_db_load_from_pdir)
15421 (has_libpthread): Update.
15422 * linespec.c (iterate_over_all_matching_symtabs)
15423 (search_minsyms_for_name): Update.
15424 * jit.c (jit_find_objf_with_entry_addr): Update.
15425 * hppa-tdep.c (find_unwind_entry)
15426 (hppa_lookup_stub_minimal_symbol): Update.
15427 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15428 Update.
15429 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15430 (elf_gnu_ifunc_resolve_by_got): Update.
15431 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15432 * dwarf-index-write.c (save_gdb_index_command): Update.
15433 * cp-support.c (add_symbol_overload_list_qualified): Update.
15434 * breakpoint.c (create_overlay_event_breakpoint)
15435 (create_longjmp_master_breakpoint)
15436 (create_std_terminate_master_breakpoint)
15437 (create_exception_master_breakpoint): Update.
15438 * blockframe.c (find_pc_partial_function): Update.
15439 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15440 (ada_collect_symbol_completion_matches)
15441 (ada_add_global_exceptions): Update.
15442
15443 2019-01-17 Tom Tromey <tom@tromey.com>
15444
15445 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15446 declare VEC.
15447 (solib_target_parse_libraries): Change return type.
15448 (library_list_start_segment, library_list_start_section)
15449 (library_list_end_library, library_list_start_library); Update.
15450 (solib_target_free_library_list): Remove.
15451 (solib_target_parse_libraries): Remove cleanup. Change return
15452 type.
15453 (solib_target_current_sos): Update.
15454
15455 2019-01-17 Tom Tromey <tromey@bapiya>
15456
15457 * valprint.c: Replace "the the" with "the".
15458 * symtab.c: Replace "the the" with "the".
15459 * solib.c: Replace "the the" with "the".
15460 * solib-dsbt.c: Replace "the the" with "the".
15461 * linespec.c: Replace "the the" with "the".
15462 * dwarf2loc.h: Replace "the the" with "the".
15463 * amd64-windows-tdep.c: Replace "the the" with "the".
15464 * aarch64-tdep.c: Replace "the the" with "the".
15465
15466 2019-01-16 Keith Seitz <keiths@redhat.com>
15467
15468 PR gdb/23773
15469 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15470 <builder>: Rename to ..
15471 <m_builder>: ... this and make private.
15472 (dwarf2_cu::get_builder): New method. Change all users of
15473 `builder' to use this method.
15474 (dwarf2_start_symtab): Move to ...
15475 (dwarf2_cu::start_symtab): ... here. Update all callers
15476 (setup_type_unit_groups): Move to ...
15477 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15478 callers.
15479 (dwarf2_cu::reset_builder): New method.
15480 (process_full_compunit, process_full_type_unit): Use
15481 dwarf2_cu::reset_builder.
15482 (follow_die_offset): Record the ancestor CU if it is different
15483 from the followed DIE's CU.
15484 (follow_die_sig_1): Likewise.
15485
15486 2019-01-15 Tom Tromey <tom@tromey.com>
15487
15488 * remote.c (class remote_state) <buf>: Now a char_vector.
15489 <buf_size>: Remove.
15490 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15491 parameter.
15492 (remote_target::getpkt_or_notif_sane_1)
15493 (remote_target::getpkt_sane)
15494 (remote_target::getpkt_or_notif_sane): Likewise.
15495 (class remote_target) <putpkt>: New overload.
15496 (remote_target::read_frame): Change type of "buf_p". Remove
15497 sizeof_p parameter.
15498 (packet_ok): New overload.
15499 (packet_check_result): New overload.
15500 Update all uses.
15501
15502 2019-01-14 Tom Tromey <tom@tromey.com>
15503
15504 * remote-notif.c (handle_notification, remote_notif_ack)
15505 (remote_notif_parse): Make "buf" const.
15506 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15507 const.
15508 (remote_notif_parse, remote_notif_ack, handle_notification):
15509 Likewise.
15510 * remote.c (remote_notif_stop_parse): Make "buf" const.
15511 (remote_target::remote_parse_stop_reply): Make "buf" const.
15512 (remote_notif_stop_ack): Make "buf" const.
15513
15514 2019-01-14 Tom Tromey <tom@tromey.com>
15515
15516 * remote.c (remote_console_output): Make parameter const.
15517
15518 2019-01-14 Tom Tromey <tom@tromey.com>
15519
15520 * target-debug.h (target_debug_print_signals): Constify.
15521 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15522 * procfs.c (procfs_target::pass_signals): Update.
15523 * linux-nat.c (linux_nat_target::pass_signals): Update.
15524 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15525 * target-delegates.c: Rebuild.
15526 * remote.c (remote_target::program_signals): Update.
15527 (remote_target::pass_signals): Update.
15528 * target.c (target_pass_signals): Constify argument.
15529 (target_program_signals): Likewise.
15530 * target.h (struct target_ops) <pass_signals, program_signals>:
15531 Constify argument.
15532 (target_pass_signals, target_program_signals): Constify argument.
15533
15534 2019-01-14 Tom Tromey <tom@tromey.com>
15535
15536 PR tui/28819:
15537 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15538
15539 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15540
15541 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15542 field.
15543 * rs6000-tdep.c: Include reggroups.h.
15544 (IS_V_ALIAS_PSEUDOREG): Define.
15545 (rs6000_register_name): Return names for the "vX" aliases.
15546 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15547 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15548 aliases. Call default_register_reggroup_p for all other
15549 pseudo-registers.
15550 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15551 New functions.
15552 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15553 Handle "vX" aliases.
15554 (v_alias_pseudo_register_collect): New function.
15555 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15556 (rs6000_gdbarch_init): Initialize "vX" aliases as
15557 pseudo-registers. Restore registration of
15558 rs6000_pseudo_register_reggroup_p with
15559 set_tdesc_pseudo_register_reggroup_p.
15560
15561 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
15562
15563 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15564 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15565 set_gdbarch_num_pseudo_regs.
15566
15567 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15568
15569 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15570 Remove arg prefixname, add do_set and do_show.
15571 Add member functions set_list and show_list.
15572 * cli/cli-style.c (class cli_style_option): Update accordingly.
15573 (style_set_list): Move to file scope.
15574 (style_show_list): Likewise.
15575 (set_style): Call help_list.
15576 (show_style): Call cmd_show_list.
15577 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15578 Update to use the new macro.
15579
15580 2019-10-12 Joel Brobecker <brobecker@adacore.com>
15581
15582 * ada-lang.c (_initialize_ada_language): Expand the help text
15583 for the "catch exception" command.
15584
15585 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15586
15587 * symtab.c (matching_obj_sections): Initialize obj,
15588 declare it closer to its usage.
15589
15590 2019-01-10 Tom Tromey <tom@tromey.com>
15591
15592 * thread-iter.h (inf_threads_iterator): Use next_iterator.
15593 (basic_inf_threads_range): Remove.
15594 (inf_threads_range, inf_non_exited_threads_range)
15595 (safe_inf_threads_range): Use next_adapter.
15596
15597 2019-01-10 Keith Seitz <keiths@redhat.com>
15598
15599 PR gdb/23712
15600 PR symtab/23010
15601 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15602 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15603
15604 2019-01-10 Keith Seitz <keiths@redhat.com>
15605
15606 PR gdb/23712
15607 PR symtab/23010
15608 * dictionary.c (pending_to_vector): Remove.
15609 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15610 Remove _1 suffix, replacing functions of the same name. Update
15611 all callers.
15612 (dict_create_hashed, dict_create_hashed_expandable)
15613 (dict_create_linear, dict_create_linear_expandable, dict_free)
15614 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15615 Make functions static.
15616
15617 2019-01-10 Keith Seitz <keiths@redhat.com>
15618
15619 PR gdb/23712
15620 PR symtab/23010
15621 * dictionary.h (struct dictionary): Replace declaration with
15622 multidictionary.
15623 (dict_create_hashed, dict_create_hashed_expandable)
15624 (dict_create_linear, dict_create_linear_expandable)
15625 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15626 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15627 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15628 taking multidictionary argument.
15629 [ALL_DICT_SYMBOLS]: Update for multidictionary.
15630 * block.h (struct block) <dict>: Change to multidictionary
15631 and rename `multidict'.
15632 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15633 symmisc.c: Update all dictionary references to multidictionary.
15634
15635 2019-01-10 Keith Seitz <keiths@redhat.com>
15636
15637 PR gdb/23712
15638 PR symtab/23010
15639 * dictionary.c: Include unordered_map.
15640 (pending_to_vector): New function.
15641 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15642 Rewrite the non-"_1" functions to take vector instead
15643 of linked list.
15644 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15645 "new" _1 versions of the same name.
15646 (multidictionary): Define.
15647 (std::hash<enum language): New definition.
15648 (collate_pending_symbols_by_language, mdict_create_hashed)
15649 (mdict_create_hashed_expandable, mdict_create_linear)
15650 (mdict_create_linear_expandable, mdict_free)
15651 (find_language_dictionary, create_new_language_dictionary)
15652 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15653 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15654 (mdict_size, mdict_empty): New functions.
15655 * dictionary.h (mdict_iterator): Define.
15656
15657 2019-01-10 Pedro Alves <palves@redhat.com>
15658
15659 * breakpoint.c (read_uploaded_action)
15660 (create_tracepoint_from_upload): Adjust to use
15661 gdb::unique_xmalloc_ptr.
15662 * ctf.c (ctf_write_uploaded_tp):
15663 (SET_ARRAY_FIELD): Use emplace_back.
15664 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15665 * tracefile-tfile.c (tfile_write_uploaded_tp):
15666 * tracepoint.c (parse_tracepoint_definition): Adjust to use
15667 gdb::unique_xmalloc_ptr.
15668 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15669 at_string, cond_string, cmd_strings>: Replace char pointers
15670 with gdb::unique_xmalloc_ptr.
15671
15672 2019-01-10 Pedro Alves <palves@redhat.com>
15673
15674 * solib-target.c (library_list_start_library): Don't xstrdup name.
15675
15676 2019-01-10 Pedro Alves <palves@redhat.com>
15677
15678 * mdebugread.c (parse_partial_symbols): Use
15679 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15680
15681 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15682
15683 * linux-fork.c (scoped_switch_fork_info)
15684 <~scoped_switch_fork_info>: Fix incorrect variable name.
15685
15686 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15687
15688 * linux-fork.c (scoped_switch_fork_info)
15689 <scoped_switch_fork_info>: Make explicit.
15690 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15691
15692 2019-01-10 Tom Tromey <tom@tromey.com>
15693
15694 * objfiles.h (objfile::reset_psymtabs): Update.
15695 * objfiles.c (objfile::objfile): Update.
15696 * psymtab.h (psymtab_storage::obstack): Update.
15697 (psymtab_storage::m_obstack): Use gdb::optional.
15698 (class psymtab_storage): Update comment. Remove objfile
15699 parameter.
15700 * psymtab.c (psymtab_storage::psymtab_storage): Update.
15701
15702 2019-01-10 Tom Tromey <tom@tromey.com>
15703
15704 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15705 <free_psymtabs>: Now private.
15706 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15707 (allocate_psymtab): Use new method.
15708
15709 2019-01-10 Tom Tromey <tom@tromey.com>
15710
15711 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15712 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15713 * mdebugread.c (parse_partial_symbols): Use
15714 allocate_dependencies.
15715 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15716 allocate_dependencies.
15717 (process_psymtab_comp_unit_reader)
15718 (build_type_psymtab_dependencies): Likewise.
15719 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15720
15721 2019-01-10 Tom Tromey <tom@tromey.com>
15722
15723 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15724 PSYMBOL_SET_LANGUAGE.
15725 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15726
15727 2019-01-10 Tom Tromey <tom@tromey.com>
15728
15729 * psymtab.h (psymtab_storage::obstack): New method.
15730 <m_obstack>: Rename from obstack; now private.
15731 * psymtab.c (psymtab_storage): Update.
15732 * dwarf2read.c (create_addrmap_from_index)
15733 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15734 Update.
15735
15736 2019-01-10 Tom Tromey <tom@tromey.com>
15737
15738 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15739 * objfiles.h (objfile::reset_psymtabs): New method.
15740
15741 2019-01-10 Tom Tromey <tom@tromey.com>
15742
15743 * symmisc.c (print_symbol_bcache_statistics): Update.
15744 (print_objfile_statistics): Update.
15745 * symfile.c (reread_symbols): Update.
15746 * psymtab.h (class psymtab_storage): New.
15747 * psymtab.c (psymtab_storage): New constructor.
15748 (~psymtab_storage): New destructor.
15749 (require_partial_symbols): Update.
15750 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15751 (find_pc_sect_psymtab, find_pc_sect_psymbol)
15752 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15753 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15754 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15755 (start_psymtab_common, end_psymtab_common)
15756 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15757 (allocate_psymtab): Update.
15758 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15759 Update.
15760 (dump_psymtab_addrmap, maintenance_print_psymbols)
15761 (maintenance_check_psymtabs): Update.
15762 (class objfile_psymtabs): Move to objfiles.h.
15763 * psympriv.h (discard_psymtab): Now inline.
15764 (psymtab_discarder::psymtab_discarder): Update.
15765 (psymtab_discarder::~psymtab_discarder): Update.
15766 (ALL_OBJFILE_PSYMTABS): Rewrite.
15767 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15768 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15769 Remove fields.
15770 <partial_symtabs>: New field.
15771 (class objfile_psymtabs): Move from psymtab.h. Update.
15772 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15773 psymbol_cache.
15774 (objfile::~objfile): Don't destroy psymbol_cache.
15775 * mdebugread.c (parse_partial_symbols): Update.
15776 * dwarf2read.c (create_addrmap_from_index)
15777 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15778 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15779 (add_partial_subprogram, dwarf2_ranges_read): Update.
15780 * dwarf-index-write.c (write_address_map)
15781 (write_one_signatured_type, recursively_write_psymbols)
15782 (class debug_names, class debug_names, write_psymtabs_to_index):
15783 Update.
15784
15785 2019-01-10 Tom Tromey <tom@tromey.com>
15786
15787 * symtab.h (SYMBOL_SET_NAMES): Update.
15788 (symbol_set_names): Update.
15789 (MSYMBOL_SET_NAMES): Update.
15790 * symtab.c (symbol_set_names): Change argument to be an
15791 objfile_per_bfd_storage.
15792 * psymtab.c (add_psymbol_to_bcache): Update.
15793 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15794
15795 2019-01-10 Tom Tromey <tom@tromey.com>
15796
15797 * symtab.c (create_demangled_names_hash): Change argument to be an
15798 objfile_per_bfd_storage.
15799 (symbol_set_names): Update.
15800
15801 2019-01-10 Tom Tromey <tom@tromey.com>
15802
15803 * xcoffread.c (xcoff_initial_scan): Unconditionally call
15804 init_psymbol_list.
15805 * psymtab.c (init_psymbol_list): Do nothing if already called.
15806 * psympriv.h (init_psymbol_list): Add comment.
15807 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15808 init_psymbol_list.
15809 * dbxread.c (dbx_symfile_read): Unconditionally call
15810 init_psymbol_list.
15811
15812 2019-01-10 Tom Tromey <tom@tromey.com>
15813
15814 * xcoffread.c (scan_xcoff_symtab): Update.
15815 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15816 "where".
15817 * mdebugread.c (parse_partial_symbols)
15818 (handle_psymbol_enumerators): Update.
15819 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15820 * dbxread.c (read_dbx_symtab): Update.
15821 * psympriv.h (psymbol_placement): New enum.
15822 (add_psymbol_to_list): Update.
15823
15824 2019-01-10 Tom Tromey <tom@tromey.com>
15825
15826 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15827 static_psymbols parameters.
15828 (scan_xcoff_symtab): Update.
15829 * psymtab.c (start_psymtab_common): Remove global_psymbols and
15830 static_psymbols parameters.
15831 * psympriv.h (start_psymtab_common): Update.
15832 * mdebugread.c (parse_partial_symbols): Update.
15833 * dwarf2read.c (create_partial_symtab): Update.
15834 * dbxread.c (read_dbx_symtab): Update.
15835 (start_psymtab): Remove global_psymbols and static_psymbols
15836 parameters.
15837
15838 2019-01-10 Tom Tromey <tom@tromey.com>
15839
15840 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15841 * psymtab.c (allocate_psymtab): Add comment.
15842 * psympriv.h (allocate_psymtab): Add comment.
15843 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15844 initializations.
15845 * dbxread.c (dbx_end_psymtab): Remove some initializations.
15846
15847 2019-01-10 Tom Tromey <tom@tromey.com>
15848
15849 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15850 Don't declare.
15851 * mipsread.c: Include mdebugread.h.
15852 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15853 Declare.
15854 * elfread.c: Include mdebugread.h.
15855
15856 2019-01-09 Tom Tromey <tom@tromey.com>
15857
15858 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15859 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15860 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15861 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15862 (psym_lookup_symbol, psym_find_last_source_symtab)
15863 (psym_forget_cached_source_info, psym_print_stats)
15864 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15865 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15866 (psym_map_matching_symbols, psym_expand_symtabs_matching)
15867 (psym_find_compunit_symtab_by_address)
15868 (maintenance_print_psymbols, maintenance_info_psymtabs)
15869 (maintenance_check_psymtabs): Use ranged for.
15870 * psymtab.h (class objfile_psymtabs): New.
15871 (require_partial_symbols): Return objfile_psymtabs.
15872 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15873
15874 2019-01-09 Tom Tromey <tom@tromey.com>
15875
15876 * symfile.c (overlay_invalidate_all, find_pc_overlay)
15877 (find_pc_mapped_section, list_overlays_command)
15878 (map_overlay_command, unmap_overlay_command)
15879 (simple_overlay_update): Use all_objfiles.
15880 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15881 * printcmd.c (info_symbol_command): Use all_objfiles.
15882 * objfiles.h (ALL_OBJSECTIONS): Remove.
15883 * maint.c (maintenance_translate_address): Use all_objfiles.
15884 * gcore.c (gcore_create_callback): Use all_objfiles.
15885 (objfile_find_memory_regions): Likewise.
15886
15887 2019-01-09 Tom Tromey <tom@tromey.com>
15888
15889 * symtab.c (find_line_symtab, info_sources_command)
15890 (make_source_files_completion_list): Use objfile_compunits.
15891 * source.c (select_source_symtab): Use objfile_compunits.
15892 * objfiles.h (struct objfile): Update comment.
15893 (ALL_OBJFILES): Remove.
15894 (ALL_FILETABS): Remove.
15895 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15896 objfile_compunits.
15897
15898 2019-01-09 Tom Tromey <tom@tromey.com>
15899
15900 * symmisc.c (print_objfile_statistics, dump_objfile)
15901 (maintenance_print_symbols): Use compunit_filetabs.
15902 * source.c (forget_cached_source_info_for_objfile): Use
15903 compunit_filetabs.
15904 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15905 (ALL_FILETABS): Use compunit_filetabs.
15906 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15907 * coffread.c (coff_symtab_read): Use compunit_filetabs.
15908
15909 2019-01-09 Tom Tromey <tom@tromey.com>
15910
15911 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
15912 (compunit_filetabs): New.
15913 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
15914 compunit_filetabs.
15915 (info_sources_command, make_source_files_completion_list): Remove
15916 declaration.
15917 * symmisc.c (print_objfile_statistics, dump_objfile)
15918 (maintenance_print_symbols): Remove declaration.
15919 (maintenance_info_symtabs): Use compunit_filetabs.
15920 (maintenance_info_line_tables): Likewise.
15921 * source.c (select_source_symtab): Change local variable name.
15922 (forget_cached_source_info_for_objfile): Remove declaration.
15923 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
15924 * objfiles.c (objfile_relocate1): Remove declaration.
15925 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15926 declaration.
15927 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
15928 * coffread.c (coff_symtab_read): Remove declaration.
15929 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
15930 compunit_filetabs.
15931
15932 2019-01-09 Tom Tromey <tom@tromey.com>
15933
15934 * symtab.c (lookup_objfile_from_block)
15935 (find_pc_sect_compunit_symtab, search_symbols)
15936 (default_collect_symbol_completion_matches_break_on): Use
15937 objfile_compunits.
15938 * objfiles.h (ALL_COMPUNITS): Remove.
15939 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
15940 * cp-support.c (add_symbol_overload_list_qualified): Use
15941 objfile_compunits.
15942 * ada-lang.c (ada_collect_symbol_completion_matches)
15943 (ada_add_global_exceptions): Use objfile_compunits.
15944
15945 2019-01-09 Tom Tromey <tom@tromey.com>
15946
15947 * source.c (select_source_symtab)
15948 (forget_cached_source_info_for_objfile): Remove declaration.
15949 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15950 declaration.
15951 * maint.c (count_symtabs_and_blocks): Remove declaration.
15952 * cp-support.c (add_symbol_overload_list_qualified): Remove
15953 declaration.
15954 * coffread.c (coff_symtab_read): Remove declaration.
15955 * symtab.c (lookup_symbol_in_objfile_symtabs)
15956 (basic_lookup_transparent_type_1): Use objfile_compunits.
15957 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
15958 (info_sources_command, search_symbols)
15959 (default_collect_symbol_completion_matches_break_on)
15960 (make_source_files_completion_list): Remove declaration.
15961 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
15962 (ada_collect_symbol_completion_matches)
15963 (ada_add_global_exceptions): Remove declaration.
15964 * linespec.c (iterate_over_all_matching_symtabs): Use
15965 objfile_compunits.
15966 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
15967 (class objfile_compunits): New.
15968 (ALL_COMPUNITS): Use objfile_compunits.
15969 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
15970 (maintenance_check_symtabs, maintenance_info_line_tables): Use
15971 objfile_compunits.
15972 * objfiles.c (objfile_relocate1): Use objfile_compunits.
15973
15974 2019-01-09 Tom Tromey <tom@tromey.com>
15975
15976 * symtab.c (search_symbols)
15977 (default_collect_symbol_completion_matches_break_on): Use
15978 objfile_msymbols.
15979 * ada-lang.c (ada_lookup_simple_minsym)
15980 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
15981 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
15982 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
15983 objfile_msymbols.
15984 * coffread.c (coff_symfile_read): Use objfile_msymbols.
15985 * symmisc.c (dump_msymbols): Use objfile_msymbols.
15986 * objc-lang.c (find_methods): Use objfile_msymbols.
15987 (info_selectors_command, info_classes_command): Likewise.
15988 * stabsread.c (scan_file_globals): Use objfile_msymbols.
15989 * objfiles.h (class objfile_msymbols): New.
15990 (ALL_OBJFILE_MSYMBOLS): Remove.
15991 (ALL_MSYMBOLS): Remove.
15992
15993 2019-01-09 Tom Tromey <tom@tromey.com>
15994
15995 * common/next-iterator.h (next_adapter): Add Iterator template
15996 parameter.
15997 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
15998 (class all_objfiles_safe): New.
15999 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16000 * objfiles.c (put_objfile_before): Update comment.
16001 (add_separate_debug_objfile): Likewise.
16002 (free_all_objfiles): Use all_objfiles_safe.
16003 (objfile_purge_solibs): Likewise.
16004
16005 2019-01-09 Tom Tromey <tom@tromey.com>
16006
16007 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16008 (expand_symtab_containing_pc, lookup_static_symbol)
16009 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16010 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16011 all_objfiles.
16012 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16013 * breakpoint.c (create_overlay_event_breakpoint)
16014 (create_longjmp_master_breakpoint)
16015 (create_std_terminate_master_breakpoint)
16016 (create_exception_master_breakpoint): Use all_objfiles.
16017 * linux-thread-db.c (try_thread_db_load_from_pdir)
16018 (has_libpthread): Use all_objfiles.
16019 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16020 * linespec.c (iterate_over_all_matching_symtabs)
16021 (search_minsyms_for_name): Use all_objfiles.
16022 * maint.c (maintenance_info_sections): Use all_objfiles.
16023 * main.c (captured_main_1): Use all_objfiles.
16024 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16025 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16026 * guile/scm-pretty-print.c
16027 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16028 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16029 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16030 (maintenance_print_msymbols): Use all_objfiles.
16031 * source.c (select_source_symtab): Use all_objfiles.
16032 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16033 * symfile.c (remove_symbol_file_command)
16034 (expand_symtabs_matching, map_symbol_filenames): Use
16035 all_objfiles.
16036 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16037 all_objfiles.
16038 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16039 * objc-lang.c (find_methods): Use all_objfiles.
16040 * objfiles.c (have_partial_symbols, have_full_symbols)
16041 (have_minimal_symbols, qsort_cmp)
16042 (default_iterate_over_objfiles_in_search_order): Use
16043 all_objfiles.
16044 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16045 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16046 (maintenance_check_psymtabs): Use all_objfiles.
16047 (ALL_PSYMTABS): Remove.
16048 * compile/compile-object-run.c (do_module_cleanup): Use
16049 all_objfiles.
16050 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16051 * cp-support.c (add_symbol_overload_list_qualified): Use
16052 all_objfiles.
16053 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16054 Use all_objfiles.
16055 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16056 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16057 all_objfiles.
16058 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16059 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16060 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16061 Uses all_objfiles.
16062 * solib.c (solib_read_symbols): Use all_objfiles
16063
16064 2019-01-09 Tom Tromey <tom@tromey.com>
16065
16066 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16067 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16068 all_objfiles.
16069 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16070 * symmisc.c (print_symbol_bcache_statistics)
16071 (print_objfile_statistics, maintenance_print_objfiles)
16072 (maintenance_info_symtabs, maintenance_check_symtabs)
16073 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16074 all_objfiles.
16075 * source.c (forget_cached_source_info): Use all_objfiles.
16076 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16077 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16078 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16079 * objfiles.c (update_section_map): Use all_objfiles.
16080 (shared_objfile_contains_address_p): Likewise.
16081 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16082 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16083
16084 2019-01-09 Tom Tromey <tom@tromey.com>
16085
16086 * common/next-iterator.h: New file.
16087 * objfiles.h (class all_objfiles): New.
16088 (struct objfile_iterator): New.
16089
16090 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16091
16092 * NEWS: Move the description of the changed "frame", "select-frame",
16093 and "info frame" commands to the Changed commands section.
16094
16095 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16096
16097 * gdbtypes.c (check_stub_method_group): Remove handling of old
16098 mangling schemes.
16099 * linespec.c (find_methods): Likewise.
16100 * stabsread.c (read_member_functions): Likewise.
16101 * valops.c (search_struct_method): Likewise.
16102 (value_struct_elt_for_reference): Likewise.
16103 * NEWS: Mention this change.
16104
16105 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16106
16107 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16108 print_source_lines.
16109 * source.c (print_source_lines_base): Update line number check.
16110 (print_source_lines): New function.
16111 (source_lines_range::source_lines_range): New function.
16112 * source.h (class source_lines_range): New class.
16113 (print_source_lines): New declaration.
16114
16115 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16116
16117 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16118
16119 2019-01-08 Tom Tromey <tom@tromey.com>
16120 Simon Marchi <simon.marchi@ericsson.com>
16121
16122 PR gdb/24060
16123 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16124 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16125 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16126 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16127 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16128 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16129
16130 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16131
16132 * source.c (select_source_symtab): Move header comment to
16133 declaration in source.h.
16134 (forget_cached_source_info_for_objfile): Likewise.
16135 (forget_cached_source_info): Likewise.
16136 (identify_source_line): Likewise.
16137 * source.h (identify_source_line): Move declaration from symtab.h
16138 and add comment from source.c
16139 (print_source_lines): Likewise.
16140 (forget_cached_source_info_for_objfile): Likewise.
16141 (forget_cached_source_info): Likewise.
16142 (select_source_symtab): Likewise.
16143 (enum print_source_lines_flag): Move definition from symtab.h.
16144 * symtab.h (identify_source_line): Move declaration to source.h.
16145 (print_source_lines): Likewise.
16146 (forget_cached_source_info_for_objfile): Likewise.
16147 (forget_cached_source_info): Likewise.
16148 (select_source_symtab): Likewise.
16149 (enum print_source_lines_flag): Move definition to source.h.
16150 * tui/tui-hooks.c: Add 'source.h' include.
16151
16152 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16153
16154 * source.c (print_source_lines_base): Handle requests to print
16155 reverse line number sequences, and guard against empty lines
16156 string.
16157
16158 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16159
16160 * source.c (print_source_lines_base): Fix skip of '\r' if next
16161 character is '\n'.
16162
16163 2019-01-06 Tom Tromey <tom@tromey.com>
16164
16165 * c-exp.y (struct c_parse_state) <macro_original_text,
16166 expansion_obstack>: New member.
16167 (macro_original_text, expansion_obstack): Remove globals.
16168 (scan_macro_expansion, scanning_macro_expansion)
16169 (finished_macro_expansion): Update.
16170 (scan_macro_cleanup): Remove.
16171 (yylex, c_parse): Update.
16172
16173 2019-01-06 Tom Tromey <tom@tromey.com>
16174
16175 * c-exp.y (struct c_parse_state) <strings>: New member.
16176 (operator_stoken): Update.
16177
16178 2019-01-06 Tom Tromey <tom@tromey.com>
16179
16180 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16181 (union type_stack_elt) <typelist_val>: Now a pointer to
16182 std::vector.
16183 (type_stack_cleanup): Don't declare.
16184 (push_typelist): Update.
16185 * parse.c (pop_typelist): Return a std::vector.
16186 (push_typelist): Take a std::vector.
16187 (follow_types): Update. Do not free args.
16188 (type_stack_cleanup): Remove.
16189 * c-exp.y (struct c_parse_state): New.
16190 (cpstate): New global.
16191 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16192 (nonempty_typelist): Update.
16193 (func_mod): Create a new vector.
16194 (c_parse): Create a c_parse_state.
16195 (check_parameter_typelist): Do not delete params.
16196 (function_method): Update. Do not delete type_list.
16197
16198 2019-01-06 Tom Tromey <tom@tromey.com>
16199
16200 PR gdb/28155:
16201 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16202 check_typedef.
16203 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16204 (print_return_value): Likewise.
16205
16206 2019-01-05 Tom Tromey <tom@tromey.com>
16207
16208 * contrib/cleanup_check.py: Remove.
16209 * contrib/gcc-with-excheck: Remove.
16210 * contrib/exsummary.py: Remove.
16211 * contrib/excheck.py: Remove.
16212
16213 2019-01-05 Joel Brobecker <brobecker@adacore.com>
16214
16215 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16216 NULL. Initialize tpprev to NULL instead of assigning it
16217 to NULL on the next statement.
16218 * windows-nat.c (windows_delete_thread): Remove check for
16219 main_thread_id before printing thread exit notifications.
16220 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16221 Remove thread ID check against main_thread_id.
16222 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16223 windows_delete_thread.
16224 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16225
16226 2019-01-04 Tom Tromey <tom@tromey.com>
16227
16228 * compile/compile.c (_initialize_compile): Use upper case for
16229 metasyntactic variables.
16230 * symmisc.c (_initialize_symmisc): Use upper case for
16231 metasyntactic variables.
16232 * psymtab.c (_initialize_psymtab): Use upper case for
16233 metasyntactic variables.
16234 * demangle.c (demangle_command): Use upper case for metasyntactic
16235 variables.
16236 (_initialize_demangler): Likewise.
16237 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16238 variables.
16239
16240 2019-01-03 Tom Tromey <tom@tromey.com>
16241
16242 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16243
16244 2019-01-03 Tom Tromey <tom@tromey.com>
16245
16246 * python/py-symtab.c (salpy_str): Update.
16247 (struct salpy_sal_object) <symtab>: Now a PyObject.
16248 (salpy_dealloc): Update.
16249 (del_objfile_sal): Use gdbpy_ref.
16250
16251 2019-01-03 Tom Tromey <tom@tromey.com>
16252
16253 * python/py-type.c (convert_field): Use new_reference. Return
16254 gdbpy_ref.
16255 (make_fielditem): Return gdbpy_ref.
16256 (typy_fields): Update.
16257 (typy_getitem): Update.
16258 (field_name): Return gdbpy_ref. Use new_reference.
16259 (typy_iterator_iternext): Update.
16260
16261 2019-01-03 Tom Tromey <tom@tromey.com>
16262
16263 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16264
16265 2019-01-03 Tom Tromey <tom@tromey.com>
16266
16267 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16268 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16269 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16270 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16271 (pspy_set_type_printers): Likewise.
16272 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16273 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16274 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16275 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16276 (objfpy_set_type_printers): Likewise.
16277
16278 2019-01-03 Tom Tromey <tom@tromey.com>
16279
16280 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16281 (gdbpy_print_stack): Use gdbpy_err_fetch.
16282 * python/python-internal.h (class gdbpy_err_fetch): New class.
16283 (class gdbpy_enter) <m_error_type, m_error_value,
16284 m_error_traceback>: Remove.
16285 <m_error>: New member.
16286 (gdbpy_exception_to_string): Don't declare.
16287 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16288 * python/py-value.c (convert_value_from_python): Use
16289 gdbpy_err_fetch.
16290 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16291 gdbpy_exception_to_string.
16292 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16293 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16294 gdbpy_err_fetch.
16295
16296 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16297
16298 * linux-nat.c (delete_lwp_cleanup): Delete.
16299 (struct lwp_deleter): New struct.
16300 (lwp_info_up): New typedef.
16301 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16302 lwp_info_up.
16303
16304 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16305
16306 * linux-fork.c (class scoped_switch_fork_info): New class.
16307 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16308
16309 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16310
16311 * valops.c (find_overload_match): Remove use of null_cleanup, and
16312 calls to do_cleanups.
16313
16314 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16315
16316 * compile/compile-cplus-types.c
16317 (compile_cplus_instance::decl_name): Handle changes to
16318 cp_func_name.
16319 * cp-support.c (cp_func_name): Update header comment, update
16320 return type.
16321 * cp-support.h (cp_func_name): Update return type in declaration.
16322 * valops.c (find_overload_match): Move temp_func local to top
16323 level of function and change its type. Use temp_func to hold and
16324 delete temporary string obtained from cp_func_name.
16325
16326 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16327
16328 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16329 gdb::char_vector, remove cleanup, and update uses of `msg`.
16330
16331 2019-01-03 Jim Wilson <jimw@sifive.com>
16332
16333 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16334
16335 2019-01-02 Tom Tromey <tom@tromey.com>
16336
16337 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16338 (tdesc_parse_xml): Remove cleanups.
16339 * target-descriptions.h (make_cleanup_free_target_description):
16340 Don't declare.
16341 (target_desc_deleter): New struct.
16342 (target_desc_up): New typedef.
16343 * target-descriptions.c (target_desc_deleter::operator()): Rename
16344 from free_target_description.
16345 (make_cleanup_free_target_description): Remove.
16346
16347 2019-01-02 Tom Tromey <tom@tromey.com>
16348
16349 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16350 constructor, destructor.
16351 (linespec_parser): Remove typedef.
16352 (~linespec_parser): Rename from linespec_parser_delete.
16353 (linespec_lex_to_end, linespec_complete_label)
16354 (linespec_complete): Update.
16355 (decode_line_full): Remove cleanups.
16356 (decode_line_1): Update.
16357
16358 2019-01-02 Tom Tromey <tom@tromey.com>
16359
16360 * python/python-internal.h (inferior_to_inferior_object): Change
16361 return type.
16362 * python/py-exitedevent.c (create_exited_event_object): Update.
16363 * python/py-inferior.c (inferior_to_inferior_object): Return
16364 gdbpy_ref.
16365 (python_new_inferior, python_inferior_deleted)
16366 (thread_to_thread_object, delete_thread_object)
16367 (build_inferior_list, gdbpy_selected_inferior): Update.
16368 * python/py-infthread.c (create_thread_object): Update. Also fail
16369 if inferior_to_inferior_object fails.
16370
16371 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16372
16373 * inferior.h (class inferior) <displaced_step_state>: New field.
16374 * infrun.h (struct displaced_step_state): Move here from
16375 infrun.c. Initialize fields, add constructor.
16376 <inf>: Remove field.
16377 <reset>: New method.
16378 * infrun.c (struct displaced_step_inferior_state): Move to
16379 infrun.h.
16380 (displaced_step_inferior_states): Remove.
16381 (get_displaced_stepping_state): Adust.
16382 (displaced_step_in_progress_any_inferior): Adjust.
16383 (displaced_step_in_progress_thread): Adjust.
16384 (displaced_step_in_progress): Adjust.
16385 (add_displaced_stepping_state): Remove.
16386 (get_displaced_step_closure_by_addr): Adjust.
16387 (remove_displaced_stepping_state): Remove.
16388 (infrun_inferior_exit): Call displaced_step_state.reset.
16389 (use_displaced_stepping): Don't check for NULL.
16390 (displaced_step_prepare_throw): Call
16391 get_displaced_stepping_state.
16392 (displaced_step_fixup): Don't check for NULL.
16393 (prepare_for_detach): Don't check for NULL.
16394
16395 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16396
16397 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16398 in case of call that did not complete.
16399
16400 2019-01-02 Andrey Utkin <autkin@undo.io>
16401
16402 * symfile.c (find_separate_debug_file): Fix search of debug files for
16403 remote debuggee.
16404
16405 2019-01-02 Tom Tromey <tom@tromey.com>
16406
16407 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16408 indentation.
16409 * python/py-frame.c (frapy_older): Remove cast.
16410 (frapy_newer): Likewise.
16411 * python/py-breakpoint.c (local_setattro): Remove cast.
16412 * python/py-arch.c (archpy_name): Remove local variable.
16413 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16414
16415 2019-01-02 Joel Brobecker <brobecker@adacore.com>
16416
16417 * unittests/basic_string_view/element_access/char/empty.cc:
16418 Fix year range in copyright header.
16419
16420 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16421
16422 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16423 Delete.
16424 <operator==>: Update with for removed field.
16425 <hash>: Likewise.
16426 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16427 <isa_features>: ...this.
16428 <abi_features>: New field.
16429 (riscv_isa_flen): Update comment.
16430 (riscv_abi_xlen): New declaration.
16431 (riscv_abi_flen): New declaration.
16432 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16433 isa_features.
16434 (riscv_abi_xlen): New function.
16435 (riscv_isa_flen): Update to get answer from isa_features.
16436 (riscv_abi_flen): New function.
16437 (riscv_has_fp_abi): Update to get answer from abi_features.
16438 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16439 xlen and flen.
16440 (riscv_call_info) <xlen, flen>: Update comment.
16441 (riscv_call_arg_struct): Remove invalid assertions
16442 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16443 is removed.
16444 (riscv_gdbarch_init): Gather isa features and abi features
16445 separately, ensure both match on the gdbarch when reusing an old
16446 gdbarch. Relax an error check to allow 32-bit abi float to run on
16447 a target with 64-bit float hardware.
16448
16449 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16450
16451 * source.c (search_command_helper): Stop reverse search
16452 when line 1 has been searched.
16453
16454 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16455
16456 * record-full.c (record_full_base_target::close): Rewrite
16457 record_full_core_buf_list free logic.
16458
16459 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16460
16461 * break-catch-syscall.c (print_one_catch_syscall): xfree
16462 the last text.
16463
16464 2019-01-01 Joel Brobecker <brobecker@adacore.com>
16465
16466 * top.c (print_gdb_version): Update Copyright year in version
16467 message.
16468
16469 2019-01-01 Joel Brobecker <brobecker@adacore.com>
16470
16471 Update copyright year range in all GDB files.
16472
16473 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
16474
16475 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16476
16477 For older changes see ChangeLog-2018.
16478 \f
16479 Local Variables:
16480 mode: change-log
16481 left-margin: 8
16482 fill-column: 74
16483 version-control: never
16484 coding: utf-8
16485 End:
16486