gdb/ChangeLog

   1 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
   2
   3         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
   4         instead of lookup_symbol_in_language
   5         (do_exact_match): New function.
   6         (ada_get_symbol_name_matcher): Return do_exact_match when
   7         doing a verbatim match.
   8
   9 2019-02-15  Tom Tromey  <tromey@adacore.com>
  10
  11         * ravenscar-thread.c (ravenscar_thread_target::resume)
  12         (ravenscar_thread_target::wait): Special case wildcard requests.
  13
  14 2019-02-15  Tom Tromey  <tromey@adacore.com>
  15
  16         * ravenscar-thread.c (base_ptid): Remove.
  17         (struct ravenscar_thread_target) <close>: New method.
  18         <m_base_ptid>: New member.
  19         <update_inferior_ptid, active_task, task_is_currently_active,
  20         runtime_initialized>: Declare methods.
  21         <ravenscar_thread_target>: Add constructor.
  22         (ravenscar_thread_target::task_is_currently_active)
  23         (ravenscar_thread_target::update_inferior_ptid)
  24         (ravenscar_runtime_initialized): Rename.  Now methods.
  25         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
  26         (ravenscar_thread_target::update_thread_list): Update.
  27         (ravenscar_thread_target::active_task): Now method.
  28         (ravenscar_thread_target::store_registers)
  29         (ravenscar_thread_target::prepare_to_store)
  30         (ravenscar_thread_target::prepare_to_store)
  31         (ravenscar_thread_target::mourn_inferior): Update.
  32         (ravenscar_inferior_created): Use "new" to create target.
  33         (ravenscar_thread_target::get_ada_task_ptid): Update.
  34         (_initialize_ravenscar): Don't initialize base_ptid.
  35         (ravenscar_ops): Remove global.
  36
  37 2019-02-15  Tom Tromey  <tromey@adacore.com>
  38
  39         * target.h (push_target): Declare new overload.
  40         * target.c (push_target): New overload, taking an rvalue reference.
  41         * remote.c (remote_target::open_1): Use push_target overload.
  42         * corelow.c (core_target_open): Use push_target overload.
  43
  44 2019-02-15  Tom Tromey  <tromey@adacore.com>
  45
  46         * ravenscar-thread.c (is_ravenscar_task)
  47         (ravenscar_task_is_currently_active): Return bool.
  48         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
  49         (_initialize_ravenscar): Remove "(void)".
  50         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
  51         Return bool.
  52
  53 2019-02-15  Tom Tromey  <tromey@adacore.com>
  54
  55         * ravenscar-thread.c (ravenscar_runtime_initializer)
  56         (has_ravenscar_runtime, get_running_thread_id)
  57         (ravenscar_thread_target::resume): Fix indentation.
  58
  59 2019-02-15  Tom Tromey  <tromey@adacore.com>
  60
  61         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
  62         from ravenscar_arch_ops.
  63         (sparc_ravenscar_ops::fetch_registers)
  64         (sparc_ravenscar_ops::store_registers): Now methods.
  65         (sparc_ravenscar_prepare_to_store): Remove.
  66         (sparc_ravenscar_ops): Redefine.
  67         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
  68         methods and destructor.  Remove members.
  69         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
  70         (ravenscar_thread_target::store_registers)
  71         (ravenscar_thread_target::prepare_to_store): Update.
  72         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
  73         Remove.
  74         (struct ppc_ravenscar_powerpc_ops): Derive from
  75         ravenscar_arch_ops.
  76         (ppc_ravenscar_powerpc_ops::fetch_registers)
  77         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
  78         (ppc_ravenscar_powerpc_ops): Redefine.
  79         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
  80         (ppc_ravenscar_e500_ops::fetch_registers)
  81         (ppc_ravenscar_e500_ops::store_registers): Now methods.
  82         (ppc_ravenscar_e500_ops): Redefine.
  83         * aarch64-ravenscar-thread.c
  84         (aarch64_ravenscar_generic_prepare_to_store): Remove.
  85         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
  86         (aarch64_ravenscar_fetch_registers)
  87         (aarch64_ravenscar_store_registers): Now methods.
  88         (aarch64_ravenscar_ops): Redefine.
  89
  90 2019-02-15  Tom Tromey  <tromey@adacore.com>
  91
  92         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
  93         (ravenscar_thread_target::stopped_by_hw_breakpoint)
  94         (ravenscar_thread_target::stopped_by_watchpoint)
  95         (ravenscar_thread_target::stopped_data_address)
  96         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
  97
  98 2019-02-15  Tom Tromey  <tromey@adacore.com>
  99
 100         * ravenscar-thread.c: Fix some typos.
 101
 102 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 103             Tom Tromey  <tromey@adacore.com>
 104
 105         * ada-lang.c (ada_exception_sal): Change addr_string to a
 106         std::string.
 107         (create_ada_exception_catchpoint): Update.
 108
 109 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 110             Tom Tromey  <tromey@adacore.com>
 111
 112         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 113         (bp_location_ops): Remove.
 114         (base_breakpoint_allocate_location): Update.
 115         (free_bp_location): Update.
 116         * ada-lang.c (class ada_catchpoint_location)
 117         <ada_catchpoint_location>: Remove ops parameter.
 118         (ada_catchpoint_location_dtor): Remove.
 119         (ada_catchpoint_location_ops): Remove.
 120         (allocate_location_exception): Update.
 121         * breakpoint.h (struct bp_location_ops): Remove.
 122         (class bp_location) <bp_location>: Remove bp_location_ops
 123         parameter.
 124         <~bp_location>: Add destructor.
 125         <ops>: Remove.
 126
 127 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 128             Pedro Alves  <palves@redhat.com>
 129
 130         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 131         'PATH_MAX'.
 132
 133 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 134             Samuel Thibault  <samuel.thibault@gnu.org>
 135             Thomas Schwinge  <thomas@codesourcery.com>
 136
 137         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 138         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 139
 140 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 141
 142         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 143         (check_empty): Use "const char *".
 144
 145         * gnu-nat.c (gnu_nat_target::detach): Instead of
 146         'detach_inferior (pid)' call
 147         'detach_inferior (find_inferior_pid (pid))'.
 148
 149         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 150         'nat/fork-inferior.o'.
 151         * gnu-nat.c: #include "nat/fork-inferior.h".
 152
 153         * gnu-nat.c (gnu_nat_target::detach): Instead of
 154         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 155         * gnu-nat.h: #include "inf-child.h".
 156         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 157         'i386_gnu_nat_target::fetch_registers'.
 158         (gnu_store_registers): Rename/move to
 159         'i386_gnu_nat_target::store_registers'.
 160
 161         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 162         * gnu-nat.h (mach_thread_info): New function.
 163         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 164
 165         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 166
 167 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 168
 169         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 170
 171 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 172
 173         * windows-nat.c (windows_add_thread): Add new parameter
 174         "main_thread_p" with default value set to false.  Update
 175         function documentation as well as all callers.
 176         (windows_delete_thread): Likewise.
 177         (fake_create_process): Update call to windows_add_thread.
 178         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 179         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 180         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 181         call to windows_delete_thread.
 182
 183 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 184
 185         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 186
 187 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 188
 189         * symfile.c (find_separate_debug_file): Use canonical path of
 190         sysroot with child_path instead of gdb_sysroot if it is valid.
 191
 192 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 193
 194         * symfile.c (find_separate_debug_file): Use child_path to
 195         determine if an object file is under a sysroot.
 196
 197 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 198
 199         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 200         unittests/child-path-selftests.c.
 201         * common/pathstuff.c (child_path): New function.
 202         * common/pathstuff.h (child_path): New prototype.
 203         * unittests/child-path-selftests.c: New file.
 204
 205 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 206
 207         * symfile.c (find_separate_debug_file): Look for separate debug
 208         files in debug directories under the sysroot.
 209
 210 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 211
 212         * symtab.h (struct minimal_symbol data_p): New const method.
 213         (struct minimal_symbol text_p): Likewise.
 214         * symtab.c (output_source_filename): Use file name style
 215         to print file name.
 216         (print_symbol_info): Likewise.
 217         (print_msymbol_info): Use address style to print addresses.
 218         Use function name style to print executable text symbols.
 219         (expand_symtab_containing_pc): Use data_p.
 220         (find_pc_sect_compunit_symtab): Likewise.
 221
 222 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 223
 224         * breakpoint.c (describe_other_breakpoints): Use address style
 225         to print addresses.
 226         (say_where): Likewise.
 227
 228 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 229
 230         * ada-typeprint.c (print_func_type): Print function name
 231         style to print function name.
 232         * c-typeprint.c (c_print_type_1): Likewise.
 233
 234 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 235
 236         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 237         for execve.
 238
 239 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 240
 241         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 242         type_stack.
 243
 244 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 245
 246         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 247         TYPE_CODE_REF types.
 248
 249 2019-02-08  Jim Wilson  <jimw@sifive.com>
 250
 251         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 252         (riscv_linux_fregset): New.
 253         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 254
 255 2019-02-07  Tom Tromey  <tom@tromey.com>
 256
 257         * thread.c (thread_cancel_execution_command): Update.
 258         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 259         methods.
 260         (struct thread_fsm_ops): Remove.
 261         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 262         (thread_fsm_should_stop, thread_fsm_return_value)
 263         (thread_fsm_set_finished, thread_fsm_finished_p)
 264         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 265         Don't declare.
 266         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 267         * infrun.c (clear_proceed_status_thread)
 268         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 269         (print_stop_event): Update.
 270         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 271         Add constructor.
 272         (step_command_fsm_ops): Remove.
 273         (new_step_command_fsm): Remove.
 274         (step_1): Update.
 275         (step_command_fsm::should_stop): Rename from
 276         step_command_fsm_should_stop.
 277         (step_command_fsm::clean_up): Rename from
 278         step_command_fsm_clean_up.
 279         (step_command_fsm::do_async_reply_reason): Rename from
 280         step_command_fsm_async_reply_reason.
 281         (struct until_next_fsm): Inherit from thread_fsm.  Add
 282         constructor.
 283         (until_next_fsm_ops): Remove.
 284         (new_until_next_fsm): Remove.
 285         (until_next_fsm::should_stop): Rename from
 286         until_next_fsm_should_stop.
 287         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 288         (until_next_fsm::do_async_reply_reason): Rename from
 289         until_next_fsm_async_reply_reason.
 290         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 291         constructor.  Change type of breakpoint.
 292         (finish_command_fsm_ops): Remove.
 293         (new_finish_command_fsm): Remove.
 294         (finish_command_fsm::should_stop): Rename from
 295         finish_command_fsm_should_stop.
 296         (finish_command_fsm::clean_up): Rename from
 297         finish_command_fsm_clean_up.
 298         (finish_command_fsm::return_value): Rename from
 299         finish_command_fsm_return_value.
 300         (finish_command_fsm::do_async_reply_reason): Rename from
 301         finish_command_fsm_async_reply_reason.
 302         (finish_command): Update.
 303         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 304         Add constructor.
 305         (call_thread_fsm_ops): Remove.
 306         (call_thread_fsm::call_thread_fsm): Rename from
 307         new_call_thread_fsm.
 308         (call_thread_fsm::should_stop): Rename from
 309         call_thread_fsm_should_stop.
 310         (call_thread_fsm::should_notify_stop): Rename from
 311         call_thread_fsm_should_notify_stop.
 312         (run_inferior_call, call_function_by_hand_dummy): Update.
 313         * cli/cli-interp.c (should_print_stop_to_console): Update.
 314         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 315         Add constructor.  Change type of location_breakpoint,
 316         caller_breakpoint.
 317         (until_break_fsm_ops): Remove.
 318         (new_until_break_fsm): Remove.
 319         (until_break_fsm::should_stop): Rename from
 320         until_break_fsm_should_stop.
 321         (until_break_fsm::clean_up): Rename from
 322         until_break_fsm_clean_up.
 323         (until_break_fsm::do_async_reply_reason): Rename from
 324         until_break_fsm_async_reply_reason.
 325         (until_break_command): Update.
 326         * thread-fsm.c: Remove.
 327         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 328
 329 2019-02-07  Tom Tromey  <tom@tromey.com>
 330
 331         * yy-remap.h: Add include guard.
 332         * xtensa-tdep.h: Add include guard.
 333         * xcoffread.h: Rename include guard.
 334         * varobj-iter.h: Add include guard.
 335         * tui/tui.h: Rename include guard.
 336         * tui/tui-winsource.h: Rename include guard.
 337         * tui/tui-wingeneral.h: Rename include guard.
 338         * tui/tui-windata.h: Rename include guard.
 339         * tui/tui-win.h: Rename include guard.
 340         * tui/tui-stack.h: Rename include guard.
 341         * tui/tui-source.h: Rename include guard.
 342         * tui/tui-regs.h: Rename include guard.
 343         * tui/tui-out.h: Rename include guard.
 344         * tui/tui-layout.h: Rename include guard.
 345         * tui/tui-io.h: Rename include guard.
 346         * tui/tui-hooks.h: Rename include guard.
 347         * tui/tui-file.h: Rename include guard.
 348         * tui/tui-disasm.h: Rename include guard.
 349         * tui/tui-data.h: Rename include guard.
 350         * tui/tui-command.h: Rename include guard.
 351         * tic6x-tdep.h: Add include guard.
 352         * target/waitstatus.h: Rename include guard.
 353         * target/wait.h: Rename include guard.
 354         * target/target.h: Rename include guard.
 355         * target/resume.h: Rename include guard.
 356         * target-float.h: Rename include guard.
 357         * stabsread.h: Add include guard.
 358         * rs6000-tdep.h: Add include guard.
 359         * riscv-fbsd-tdep.h: Add include guard.
 360         * regformats/regdef.h: Rename include guard.
 361         * record.h: Rename include guard.
 362         * python/python.h: Rename include guard.
 363         * python/python-internal.h: Rename include guard.
 364         * python/py-stopevent.h: Rename include guard.
 365         * python/py-ref.h: Rename include guard.
 366         * python/py-record.h: Rename include guard.
 367         * python/py-record-full.h: Rename include guard.
 368         * python/py-record-btrace.h: Rename include guard.
 369         * python/py-instruction.h: Rename include guard.
 370         * python/py-events.h: Rename include guard.
 371         * python/py-event.h: Rename include guard.
 372         * procfs.h: Add include guard.
 373         * proc-utils.h: Add include guard.
 374         * p-lang.h: Add include guard.
 375         * or1k-tdep.h: Rename include guard.
 376         * observable.h: Rename include guard.
 377         * nto-tdep.h: Rename include guard.
 378         * nat/x86-linux.h: Rename include guard.
 379         * nat/x86-linux-dregs.h: Rename include guard.
 380         * nat/x86-gcc-cpuid.h: Add include guard.
 381         * nat/x86-dregs.h: Rename include guard.
 382         * nat/x86-cpuid.h: Rename include guard.
 383         * nat/ppc-linux.h: Rename include guard.
 384         * nat/mips-linux-watch.h: Rename include guard.
 385         * nat/linux-waitpid.h: Rename include guard.
 386         * nat/linux-ptrace.h: Rename include guard.
 387         * nat/linux-procfs.h: Rename include guard.
 388         * nat/linux-osdata.h: Rename include guard.
 389         * nat/linux-nat.h: Rename include guard.
 390         * nat/linux-namespaces.h: Rename include guard.
 391         * nat/linux-btrace.h: Rename include guard.
 392         * nat/glibc_thread_db.h: Rename include guard.
 393         * nat/gdb_thread_db.h: Rename include guard.
 394         * nat/gdb_ptrace.h: Rename include guard.
 395         * nat/fork-inferior.h: Rename include guard.
 396         * nat/amd64-linux-siginfo.h: Rename include guard.
 397         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 398         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 399         * nat/aarch64-linux.h: Rename include guard.
 400         * nat/aarch64-linux-hw-point.h: Rename include guard.
 401         * mn10300-tdep.h: Add include guard.
 402         * mips-linux-tdep.h: Add include guard.
 403         * mi/mi-parse.h: Rename include guard.
 404         * mi/mi-out.h: Rename include guard.
 405         * mi/mi-main.h: Rename include guard.
 406         * mi/mi-interp.h: Rename include guard.
 407         * mi/mi-getopt.h: Rename include guard.
 408         * mi/mi-console.h: Rename include guard.
 409         * mi/mi-common.h: Rename include guard.
 410         * mi/mi-cmds.h: Rename include guard.
 411         * mi/mi-cmd-break.h: Rename include guard.
 412         * m2-lang.h: Add include guard.
 413         * location.h: Rename include guard.
 414         * linux-record.h: Rename include guard.
 415         * linux-nat.h: Add include guard.
 416         * linux-fork.h: Add include guard.
 417         * i386-darwin-tdep.h: Rename include guard.
 418         * hppa-linux-offsets.h: Add include guard.
 419         * guile/guile.h: Rename include guard.
 420         * guile/guile-internal.h: Rename include guard.
 421         * gnu-nat.h: Rename include guard.
 422         * gdb-stabs.h: Rename include guard.
 423         * frv-tdep.h: Add include guard.
 424         * f-lang.h: Add include guard.
 425         * event-loop.h: Add include guard.
 426         * darwin-nat.h: Rename include guard.
 427         * cp-abi.h: Rename include guard.
 428         * config/sparc/nm-sol2.h: Rename include guard.
 429         * config/nm-nto.h: Rename include guard.
 430         * config/nm-linux.h: Add include guard.
 431         * config/i386/nm-i386gnu.h: Rename include guard.
 432         * config/djgpp/nl_types.h: Rename include guard.
 433         * config/djgpp/langinfo.h: Rename include guard.
 434         * compile/gcc-cp-plugin.h: Add include guard.
 435         * compile/gcc-c-plugin.h: Add include guard.
 436         * compile/compile.h: Rename include guard.
 437         * compile/compile-object-run.h: Rename include guard.
 438         * compile/compile-object-load.h: Rename include guard.
 439         * compile/compile-internal.h: Rename include guard.
 440         * compile/compile-cplus.h: Rename include guard.
 441         * compile/compile-c.h: Rename include guard.
 442         * common/xml-utils.h: Rename include guard.
 443         * common/x86-xstate.h: Rename include guard.
 444         * common/version.h: Rename include guard.
 445         * common/vec.h: Rename include guard.
 446         * common/tdesc.h: Rename include guard.
 447         * common/selftest.h: Rename include guard.
 448         * common/scoped_restore.h: Rename include guard.
 449         * common/scoped_mmap.h: Rename include guard.
 450         * common/scoped_fd.h: Rename include guard.
 451         * common/safe-iterator.h: Rename include guard.
 452         * common/run-time-clock.h: Rename include guard.
 453         * common/refcounted-object.h: Rename include guard.
 454         * common/queue.h: Rename include guard.
 455         * common/ptid.h: Rename include guard.
 456         * common/print-utils.h: Rename include guard.
 457         * common/preprocessor.h: Rename include guard.
 458         * common/pathstuff.h: Rename include guard.
 459         * common/observable.h: Rename include guard.
 460         * common/netstuff.h: Rename include guard.
 461         * common/job-control.h: Rename include guard.
 462         * common/host-defs.h: Rename include guard.
 463         * common/gdb_wait.h: Rename include guard.
 464         * common/gdb_vecs.h: Rename include guard.
 465         * common/gdb_unlinker.h: Rename include guard.
 466         * common/gdb_unique_ptr.h: Rename include guard.
 467         * common/gdb_tilde_expand.h: Rename include guard.
 468         * common/gdb_sys_time.h: Rename include guard.
 469         * common/gdb_string_view.h: Rename include guard.
 470         * common/gdb_splay_tree.h: Rename include guard.
 471         * common/gdb_setjmp.h: Rename include guard.
 472         * common/gdb_ref_ptr.h: Rename include guard.
 473         * common/gdb_optional.h: Rename include guard.
 474         * common/gdb_locale.h: Rename include guard.
 475         * common/gdb_assert.h: Rename include guard.
 476         * common/filtered-iterator.h: Rename include guard.
 477         * common/filestuff.h: Rename include guard.
 478         * common/fileio.h: Rename include guard.
 479         * common/environ.h: Rename include guard.
 480         * common/common-utils.h: Rename include guard.
 481         * common/common-types.h: Rename include guard.
 482         * common/common-regcache.h: Rename include guard.
 483         * common/common-inferior.h: Rename include guard.
 484         * common/common-gdbthread.h: Rename include guard.
 485         * common/common-exceptions.h: Rename include guard.
 486         * common/common-defs.h: Rename include guard.
 487         * common/common-debug.h: Rename include guard.
 488         * common/cleanups.h: Rename include guard.
 489         * common/buffer.h: Rename include guard.
 490         * common/btrace-common.h: Rename include guard.
 491         * common/break-common.h: Rename include guard.
 492         * cli/cli-utils.h: Rename include guard.
 493         * cli/cli-style.h: Rename include guard.
 494         * cli/cli-setshow.h: Rename include guard.
 495         * cli/cli-script.h: Rename include guard.
 496         * cli/cli-interp.h: Rename include guard.
 497         * cli/cli-decode.h: Rename include guard.
 498         * cli/cli-cmds.h: Rename include guard.
 499         * charset-list.h: Add include guard.
 500         * buildsym-legacy.h: Rename include guard.
 501         * bfin-tdep.h: Add include guard.
 502         * ax.h: Rename include guard.
 503         * arm-linux-tdep.h: Add include guard.
 504         * arm-fbsd-tdep.h: Add include guard.
 505         * arch/xtensa.h: Rename include guard.
 506         * arch/tic6x.h: Add include guard.
 507         * arch/i386.h: Add include guard.
 508         * arch/arm.h: Rename include guard.
 509         * arch/arm-linux.h: Rename include guard.
 510         * arch/arm-get-next-pcs.h: Rename include guard.
 511         * arch/amd64.h: Add include guard.
 512         * arch/aarch64-insn.h: Rename include guard.
 513         * arch-utils.h: Rename include guard.
 514         * annotate.h: Add include guard.
 515         * amd64-darwin-tdep.h: Rename include guard.
 516         * aarch64-linux-tdep.h: Add include guard.
 517         * aarch64-fbsd-tdep.h: Add include guard.
 518         * aarch32-linux-nat.h: Add include guard.
 519
 520 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 521
 522         * macrotab.c (macro_define_internal): New function that
 523         factorizes macro_define_object_internal and macro_define_function
 524         code.
 525         (macro_define_object_internal): Use macro_define_internal.
 526         (macro_define_function): Likewise.
 527
 528 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 529
 530         * macrocmd.c (extract_identifier): Return
 531         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 532         callers.
 533
 534 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 535
 536         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 537
 538 2019-02-05  Tom Tromey  <tom@tromey.com>
 539
 540         * target.c (target_stack::unpush): Move assertion earlier.
 541
 542 2019-01-30  Tom Tromey  <tom@tromey.com>
 543
 544         PR python/23615:
 545         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 546         (gdbpy_parse_and_eval): Likewise.
 547         * python/python-internal.h (gdbpy_allow_threads): New class.
 548
 549 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 550
 551         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 552         (aarch64_fbsd_fpregmap): Move earlier.
 553         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 554         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 555         instead of individual calls to trad_frame_set_reg_addr.
 556         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 557         earlier.
 558         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 559         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 560         instead of individual calls to trad_frame_set_reg_addr.
 561
 562 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 563
 564         * CONTRIBUTE: Replace contribution list with wiki link.
 565
 566 2019-01-25  Tom Tromey  <tom@tromey.com>
 567
 568         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 569
 570 2019-01-25  Tom Tromey  <tom@tromey.com>
 571
 572         * xtensa-linux-nat.c: Fix common/ includes.
 573         * xml-support.h: Fix common/ includes.
 574         * xml-support.c: Fix common/ includes.
 575         * x86-linux-nat.c: Fix common/ includes.
 576         * windows-nat.c: Fix common/ includes.
 577         * varobj.h: Fix common/ includes.
 578         * varobj.c: Fix common/ includes.
 579         * value.c: Fix common/ includes.
 580         * valops.c: Fix common/ includes.
 581         * utils.c: Fix common/ includes.
 582         * unittests/xml-utils-selftests.c: Fix common/ includes.
 583         * unittests/utils-selftests.c: Fix common/ includes.
 584         * unittests/unpack-selftests.c: Fix common/ includes.
 585         * unittests/tracepoint-selftests.c: Fix common/ includes.
 586         * unittests/style-selftests.c: Fix common/ includes.
 587         * unittests/string_view-selftests.c: Fix common/ includes.
 588         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 589         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 590         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 591         * unittests/rsp-low-selftests.c: Fix common/ includes.
 592         * unittests/parse-connection-spec-selftests.c: Fix common/
 593         includes.
 594         * unittests/optional-selftests.c: Fix common/ includes.
 595         * unittests/offset-type-selftests.c: Fix common/ includes.
 596         * unittests/observable-selftests.c: Fix common/ includes.
 597         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 598         * unittests/memrange-selftests.c: Fix common/ includes.
 599         * unittests/memory-map-selftests.c: Fix common/ includes.
 600         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 601         * unittests/function-view-selftests.c: Fix common/ includes.
 602         * unittests/environ-selftests.c: Fix common/ includes.
 603         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 604         * unittests/common-utils-selftests.c: Fix common/ includes.
 605         * unittests/cli-utils-selftests.c: Fix common/ includes.
 606         * unittests/array-view-selftests.c: Fix common/ includes.
 607         * ui-file.c: Fix common/ includes.
 608         * tui/tui-io.c: Fix common/ includes.
 609         * tracepoint.h: Fix common/ includes.
 610         * tracepoint.c: Fix common/ includes.
 611         * tracefile-tfile.c: Fix common/ includes.
 612         * top.h: Fix common/ includes.
 613         * top.c: Fix common/ includes.
 614         * thread.c: Fix common/ includes.
 615         * target/waitstatus.h: Fix common/ includes.
 616         * target/waitstatus.c: Fix common/ includes.
 617         * target.h: Fix common/ includes.
 618         * target.c: Fix common/ includes.
 619         * target-memory.c: Fix common/ includes.
 620         * target-descriptions.c: Fix common/ includes.
 621         * symtab.h: Fix common/ includes.
 622         * symfile.c: Fix common/ includes.
 623         * stap-probe.c: Fix common/ includes.
 624         * spu-linux-nat.c: Fix common/ includes.
 625         * sparc-nat.c: Fix common/ includes.
 626         * source.c: Fix common/ includes.
 627         * solib.c: Fix common/ includes.
 628         * solib-target.c: Fix common/ includes.
 629         * ser-unix.c: Fix common/ includes.
 630         * ser-tcp.c: Fix common/ includes.
 631         * ser-pipe.c: Fix common/ includes.
 632         * ser-base.c: Fix common/ includes.
 633         * selftest-arch.c: Fix common/ includes.
 634         * s12z-tdep.c: Fix common/ includes.
 635         * rust-exp.y: Fix common/ includes.
 636         * rs6000-aix-tdep.c: Fix common/ includes.
 637         * riscv-tdep.c: Fix common/ includes.
 638         * remote.c: Fix common/ includes.
 639         * remote-notif.h: Fix common/ includes.
 640         * remote-fileio.h: Fix common/ includes.
 641         * remote-fileio.c: Fix common/ includes.
 642         * regcache.h: Fix common/ includes.
 643         * regcache.c: Fix common/ includes.
 644         * record-btrace.c: Fix common/ includes.
 645         * python/python.c: Fix common/ includes.
 646         * python/py-type.c: Fix common/ includes.
 647         * python/py-inferior.c: Fix common/ includes.
 648         * progspace.h: Fix common/ includes.
 649         * producer.c: Fix common/ includes.
 650         * procfs.c: Fix common/ includes.
 651         * proc-api.c: Fix common/ includes.
 652         * printcmd.c: Fix common/ includes.
 653         * ppc-linux-nat.c: Fix common/ includes.
 654         * parser-defs.h: Fix common/ includes.
 655         * osdata.c: Fix common/ includes.
 656         * obsd-nat.c: Fix common/ includes.
 657         * nat/x86-linux.c: Fix common/ includes.
 658         * nat/x86-linux-dregs.c: Fix common/ includes.
 659         * nat/x86-dregs.h: Fix common/ includes.
 660         * nat/x86-dregs.c: Fix common/ includes.
 661         * nat/ppc-linux.c: Fix common/ includes.
 662         * nat/mips-linux-watch.h: Fix common/ includes.
 663         * nat/mips-linux-watch.c: Fix common/ includes.
 664         * nat/linux-waitpid.c: Fix common/ includes.
 665         * nat/linux-ptrace.h: Fix common/ includes.
 666         * nat/linux-ptrace.c: Fix common/ includes.
 667         * nat/linux-procfs.c: Fix common/ includes.
 668         * nat/linux-personality.c: Fix common/ includes.
 669         * nat/linux-osdata.c: Fix common/ includes.
 670         * nat/linux-namespaces.c: Fix common/ includes.
 671         * nat/linux-btrace.h: Fix common/ includes.
 672         * nat/linux-btrace.c: Fix common/ includes.
 673         * nat/fork-inferior.c: Fix common/ includes.
 674         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 675         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 676         * nat/aarch64-linux.c: Fix common/ includes.
 677         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 678         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 679         * namespace.h: Fix common/ includes.
 680         * mips-linux-tdep.c: Fix common/ includes.
 681         * minsyms.c: Fix common/ includes.
 682         * mi/mi-parse.h: Fix common/ includes.
 683         * mi/mi-main.c: Fix common/ includes.
 684         * mi/mi-cmd-env.c: Fix common/ includes.
 685         * memrange.h: Fix common/ includes.
 686         * memattr.c: Fix common/ includes.
 687         * maint.h: Fix common/ includes.
 688         * maint.c: Fix common/ includes.
 689         * main.c: Fix common/ includes.
 690         * machoread.c: Fix common/ includes.
 691         * location.c: Fix common/ includes.
 692         * linux-thread-db.c: Fix common/ includes.
 693         * linux-nat.c: Fix common/ includes.
 694         * linux-fork.c: Fix common/ includes.
 695         * inline-frame.c: Fix common/ includes.
 696         * infrun.c: Fix common/ includes.
 697         * inflow.c: Fix common/ includes.
 698         * inferior.h: Fix common/ includes.
 699         * inferior.c: Fix common/ includes.
 700         * infcmd.c: Fix common/ includes.
 701         * inf-ptrace.c: Fix common/ includes.
 702         * inf-child.c: Fix common/ includes.
 703         * ia64-linux-nat.c: Fix common/ includes.
 704         * i387-tdep.c: Fix common/ includes.
 705         * i386-tdep.c: Fix common/ includes.
 706         * i386-linux-tdep.c: Fix common/ includes.
 707         * i386-linux-nat.c: Fix common/ includes.
 708         * i386-go32-tdep.c: Fix common/ includes.
 709         * i386-fbsd-tdep.c: Fix common/ includes.
 710         * i386-fbsd-nat.c: Fix common/ includes.
 711         * guile/scm-type.c: Fix common/ includes.
 712         * guile/guile.c: Fix common/ includes.
 713         * go32-nat.c: Fix common/ includes.
 714         * gnu-nat.c: Fix common/ includes.
 715         * gdbthread.h: Fix common/ includes.
 716         * gdbarch-selftests.c: Fix common/ includes.
 717         * gdb_usleep.c: Fix common/ includes.
 718         * gdb_select.h: Fix common/ includes.
 719         * gdb_bfd.c: Fix common/ includes.
 720         * gcore.c: Fix common/ includes.
 721         * fork-child.c: Fix common/ includes.
 722         * findvar.c: Fix common/ includes.
 723         * fbsd-nat.c: Fix common/ includes.
 724         * event-top.c: Fix common/ includes.
 725         * event-loop.c: Fix common/ includes.
 726         * dwarf2read.c: Fix common/ includes.
 727         * dwarf2loc.c: Fix common/ includes.
 728         * dwarf2-frame.c: Fix common/ includes.
 729         * dwarf-index-cache.c: Fix common/ includes.
 730         * dtrace-probe.c: Fix common/ includes.
 731         * disasm-selftests.c: Fix common/ includes.
 732         * defs.h: Fix common/ includes.
 733         * csky-tdep.c: Fix common/ includes.
 734         * cp-valprint.c: Fix common/ includes.
 735         * cp-support.h: Fix common/ includes.
 736         * cp-support.c: Fix common/ includes.
 737         * corelow.c: Fix common/ includes.
 738         * completer.h: Fix common/ includes.
 739         * completer.c: Fix common/ includes.
 740         * compile/compile.c: Fix common/ includes.
 741         * compile/compile-loc2c.c: Fix common/ includes.
 742         * compile/compile-cplus-types.c: Fix common/ includes.
 743         * compile/compile-cplus-symbols.c: Fix common/ includes.
 744         * command.h: Fix common/ includes.
 745         * cli/cli-dump.c: Fix common/ includes.
 746         * cli/cli-cmds.c: Fix common/ includes.
 747         * charset.c: Fix common/ includes.
 748         * build-id.c: Fix common/ includes.
 749         * btrace.h: Fix common/ includes.
 750         * btrace.c: Fix common/ includes.
 751         * breakpoint.h: Fix common/ includes.
 752         * breakpoint.c: Fix common/ includes.
 753         * ax.h:
 754         (enum agent_op): Fix common/ includes.
 755         * ax-general.c (struct aop_map): Fix common/ includes.
 756         * ax-gdb.c: Fix common/ includes.
 757         * auxv.c: Fix common/ includes.
 758         * auto-load.c: Fix common/ includes.
 759         * arm-tdep.c: Fix common/ includes.
 760         * arch/riscv.c: Fix common/ includes.
 761         * arch/ppc-linux-common.c: Fix common/ includes.
 762         * arch/i386.c: Fix common/ includes.
 763         * arch/arm.c: Fix common/ includes.
 764         * arch/arm-linux.c: Fix common/ includes.
 765         * arch/arm-get-next-pcs.c: Fix common/ includes.
 766         * arch/amd64.c: Fix common/ includes.
 767         * arch/aarch64.c: Fix common/ includes.
 768         * arch/aarch64-insn.c: Fix common/ includes.
 769         * arch-utils.c: Fix common/ includes.
 770         * amd64-windows-tdep.c: Fix common/ includes.
 771         * amd64-tdep.c: Fix common/ includes.
 772         * amd64-sol2-tdep.c: Fix common/ includes.
 773         * amd64-obsd-tdep.c: Fix common/ includes.
 774         * amd64-nbsd-tdep.c: Fix common/ includes.
 775         * amd64-linux-tdep.c: Fix common/ includes.
 776         * amd64-linux-nat.c: Fix common/ includes.
 777         * amd64-fbsd-tdep.c: Fix common/ includes.
 778         * amd64-fbsd-nat.c: Fix common/ includes.
 779         * amd64-dicos-tdep.c: Fix common/ includes.
 780         * amd64-darwin-tdep.c: Fix common/ includes.
 781         * agent.c: Fix common/ includes.
 782         * ada-lang.h: Fix common/ includes.
 783         * ada-lang.c: Fix common/ includes.
 784         * aarch64-tdep.c: Fix common/ includes.
 785
 786 2019-01-25  Tom Tromey  <tom@tromey.com>
 787
 788         * common/create-version.sh: Use common/version.h.
 789
 790 2019-01-24  Pedro Alves  <palves@redhat.com>
 791
 792         * infrun.c (signal_stop, signal_print, signal_program)
 793         (signal_catch, signal_pass): Now arrays instead of pointers.
 794         (update_signals_program_target, do_target_resume)
 795         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 796         * linux-nat.c (linux_nat_target::pass_signals)
 797         (linux_nat_target::create_inferior, linux_nat_target::attach):
 798         Adjust.
 799         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 800         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 801         * procfs.c (procfs_target::pass_signals): Adjust.
 802         * record-full.c (record_full_target::resume): Adjust.
 803         * remote.c (remote_target::pass_signals)
 804         (remote_target::program_signals): Adjust.
 805         * target-debug.h (target_debug_print_signals): Now takes a
 806         gdb::array_view as parameter.  Adjust.
 807         * target.h (target_ops) <pass_signals, program_signals>: Replace
 808         pointer and length parameters with gdb::array_view.
 809         (target_pass_signals, target_program_signals): Likewise.
 810         * target-delegates.c: Regenerate.
 811
 812 2019-01-24  Pedro Alves  <palves@redhat.com>
 813
 814         * common/forward-scope-exit.h
 815         (forward_scope_exit::forward_scope_exit): Pass arguments to
 816         m_bind_function directly, instead of creating a std::bind and
 817         copying that.
 818
 819 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 820
 821         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 822         for static members.
 823         (pass_in_v_vfp_candidate): Likewise.
 824
 825 2019-01-23  Tom Tromey  <tom@tromey.com>
 826             Pedro Alves  <palves@redhat.com>
 827
 828         * regcache.c (class regcache_invalidator): Remove.
 829         (regcache::raw_write): Use make_scope_exit.
 830
 831 2019-01-23  Tom Tromey  <tom@tromey.com>
 832
 833         * ui-out.h (class ui_out_emit_type): Update comment.
 834
 835 2019-01-23  Tom Tromey  <tom@tromey.com>
 836
 837         * infrun.c (fetch_inferior_event): Update comment.
 838
 839 2019-01-23  Tom Tromey  <tom@tromey.com>
 840             Pedro Alves  <palves@redhat.com>
 841
 842         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 843         parameter.
 844         (fetch_inferior_event): Use SCOPE_EXIT.
 845
 846
 847 2019-01-23  Tom Tromey  <tom@tromey.com>
 848             Pedro Alves  <palves@redhat.com>
 849
 850         * infrun.c (disable_thread_events): Delete.
 851         (stop_all_threads): Use SCOPE_EXIT.
 852
 853 2019-01-23  Tom Tromey  <tom@tromey.com>
 854             Pedro Alves  <palves@redhat.com>
 855
 856         * symfile.c: Include forward-scope-exit.h.
 857         (clear_symtab_users_cleanup): Replace forward declaration with
 858         a FORWARD_SCOPE_EXIT.
 859         (syms_from_objfile_1): Use the forward_scope_exit and
 860         gdb::optional instead of cleanup_function.
 861         (reread_symbols): Use the forward_scope_exit instead of
 862         cleanup_function.
 863         (clear_symtab_users_cleanup): Remove function.
 864
 865 2019-01-23  Tom Tromey  <tom@tromey.com>
 866             Pedro Alves  <palves@redhat.com>
 867
 868         * linux-nat.c: Include scope-exit.h.
 869         (cleanup_target_stop): Remove.
 870         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 871         SCOPE_EXIT.
 872
 873 2019-01-23  Tom Tromey  <tom@tromey.com>
 874             Pedro Alves  <palves@redhat.com>
 875
 876         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 877         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 878
 879 2019-01-23  Tom Tromey  <tom@tromey.com>
 880             Andrew Burgess  <andrew.burgess@embecosm.com>
 881             Pedro Alves  <palves@redhat.com>
 882
 883         * infrun.c (fetch_inferior_event): Use scope_exit.
 884         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 885         * top.c (execute_command): Use scope_exit.
 886         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 887         * utils.c (do_bpstat_clear_actions_cleanup)
 888         (make_bpstat_clear_actions_cleanup): Remove.
 889
 890 2019-01-23  Tom Tromey  <tom@tromey.com>
 891             Pedro Alves  <palves@redhat.com>
 892
 893         * infrun.c: Include "common/scope-exit.h"
 894         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 895         (wait_for_inferior): Use SCOPE_EXIT.
 896         (fetch_inferior_event): Use scope_exit.
 897
 898 2019-01-23  Tom Tromey  <tom@tromey.com>
 899             Pedro Alves  <palves@redhat.com>
 900
 901         * breakpoint.c (create_breakpoint): Remove cleanup.
 902
 903 2019-01-23  Tom Tromey  <tom@tromey.com>
 904             Andrew Burgess  <andrew.burgess@embecosm.com>
 905             Pedro Alves  <palves@redhat.com>
 906
 907 2019-01-23  Pedro Alves  <palves@redhat.com>
 908
 909         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 910
 911 2019-01-23  Pedro Alves  <palves@redhat.com>
 912             Andrew Burgess  <andrew.burgess@embecosm.com>
 913
 914         * gdbthread.h: Include "common/forward-scope-exit.h".
 915         (scoped_finish_thread_state): Redefine custom class in terms of
 916         forward_scope_exit.
 917
 918 2019-01-23  Pedro Alves  <palves@redhat.com>
 919             Andrew Burgess  <andrew.burgess@embecosm.com>
 920
 921         * common/forward-scope-exit.h: New file.
 922
 923 2019-01-23  Pedro Alves  <palves@redhat.com>
 924             Andrew Burgess  <andrew.burgess@embecosm.com>
 925             Tom Tromey  <tom@tromey.com>
 926
 927         * common/scope-exit.h: New file.
 928
 929 2019-01-23  Pedro Alves  <palves@redhat.com>
 930
 931         * common/preprocessor.h (ESC): Rename to ...
 932         (ESC_PARENS): ... this.
 933         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 934         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 935
 936 2019-01-23  Tom Tromey  <tom@tromey.com>
 937
 938         * language.h (class scoped_switch_to_sym_language_if_auto):
 939         Initialize m_lang in both cases.
 940
 941 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 942
 943         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 944         with XCNEW.
 945
 946 2019-01-22  Tom Tromey  <tom@tromey.com>
 947
 948         * corelow.c: Do not include sys/file.h.
 949
 950 2019-01-22  Tom Tromey  <tom@tromey.com>
 951
 952         * tui/tui-wingeneral.h: Include gdb_curses.h.
 953
 954 2019-01-22  Tom Tromey  <tom@tromey.com>
 955
 956         * source-cache.h (class source_cache) <get_source_lines,
 957         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 958
 959 2019-01-22  Tom Tromey  <tom@tromey.com>
 960
 961         * remote-fileio.h (struct remote_target): Declare.
 962
 963 2019-01-22  Tom Tromey  <tom@tromey.com>
 964
 965         * python/py-arch.c: Do not include py-ref.h.
 966         * python/py-bpevent.c: Do not include py-ref.h.
 967         * python/py-cmd.c: Do not include py-ref.h.
 968         * python/py-continueevent.c: Do not include py-ref.h.
 969         * python/py-event.h: Do not include py-ref.h.
 970         * python/py-evtregistry.c: Do not include py-ref.h.
 971         * python/py-finishbreakpoint.c: Do not include py-ref.h.
 972         * python/py-frame.c: Do not include py-ref.h.
 973         * python/py-framefilter.c: Do not include py-ref.h.
 974         * python/py-function.c: Do not include py-ref.h.
 975         * python/py-infevents.c: Do not include py-ref.h.
 976         * python/py-linetable.c: Do not include py-ref.h.
 977         * python/py-objfile.c: Do not include py-ref.h.
 978         * python/py-param.c: Do not include py-ref.h.
 979         * python/py-prettyprint.c: Do not include py-ref.h.
 980         * python/py-progspace.c: Do not include py-ref.h.
 981         * python/py-symbol.c: Do not include py-ref.h.
 982         * python/py-symtab.c: Do not include py-ref.h.
 983         * python/py-type.c: Do not include py-ref.h.
 984         * python/py-unwind.c: Do not include py-ref.h.
 985         * python/py-utils.c: Do not include py-ref.h.
 986         * python/py-value.c: Do not include py-ref.h.
 987         * python/py-varobj.c: Do not include py-ref.h.
 988         * python/py-xmethods.c: Do not include py-ref.h.
 989         * python/python.c: Do not include py-ref.h.
 990         * varobj.c: Do not include py-ref.h.
 991
 992 2019-01-22  Tom Tromey  <tom@tromey.com>
 993
 994         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
 995         keyword for bcache.
 996
 997 2019-01-22  Tom Tromey  <tom@tromey.com>
 998
 999         * compile/compile-cplus-types.c: Remove a comment by #include.
1000
1001 2019-01-22  Tom Tromey  <tom@tromey.com>
1002
1003         * compile/gcc-c-plugin.h: Include compile-internal.h.
1004
1005 2019-01-22  Tom Tromey  <tom@tromey.com>
1006
1007         * stabsread.c (EXTERN): Do not define.
1008         (symnum, next_symbol_text_func, processing_gcc_compilation)
1009         (within_function, global_sym_chain, global_stabs)
1010         (previous_stab_code, this_object_header_files)
1011         (n_this_object_header_files)
1012         (n_allocated_this_object_header_files): Define.
1013         * stabsread.h (EXTERN): Never define.  Use "extern".
1014
1015 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1016
1017         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1018         history_value.
1019
1020 2019-01-21  Tom Tromey  <tom@tromey.com>
1021
1022         * ui-out.c: Fix includes.
1023         * tui/tui-source.c: Fix includes.
1024         * target.c: Fix includes.
1025         * remote.c: Fix includes.
1026         * regcache.c: Fix includes.
1027         * python/py-block.c: Fix includes.
1028         * printcmd.c: Fix includes.
1029         * or1k-tdep.c: Fix includes.
1030         * mi/mi-main.c: Fix includes.
1031         * m32r-tdep.c: Fix includes.
1032         * csky-tdep.c: Fix includes.
1033         * compile/compile-cplus-types.c: Fix includes.
1034         * cli/cli-interp.c: Fix includes.
1035
1036 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1037
1038         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1039         for padding.
1040
1041 2019-01-16  Tom Tromey  <tom@tromey.com>
1042
1043         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1044         earlier.
1045         (struct objfile) <msymbols_range>: Move from top level.
1046         <msymbols>: New method.
1047         (class objfile_msymbols): Remove.
1048         * symtab.c (default_collect_symbol_completion_matches_break_on):
1049         Update.
1050         * symmisc.c (dump_msymbols): Update.
1051         * stabsread.c (scan_file_globals): Update.
1052         * objc-lang.c (info_selectors_command, info_classes_command)
1053         (find_methods): Update.
1054         * minsyms.c (find_solib_trampoline_target): Update.
1055         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1056         * coffread.c (coff_symfile_read): Update.
1057         * ada-lang.c (ada_lookup_simple_minsym)
1058         (ada_collect_symbol_completion_matches): Update.
1059
1060 2019-01-16  Tom Tromey  <tom@tromey.com>
1061
1062         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1063         type.  Remove no-argument constructor.
1064         <iterator::operator++>: Simplify.
1065         <begin>: Update.
1066         <end>: Use minimal_symbol_count.
1067
1068 2019-01-16  Tom Tromey  <tom@tromey.com>
1069
1070         * objfiles.h (struct objfile) <psymtabs>: New method.
1071         (class objfile_psymtabs): Remove.
1072         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1073         typedef.
1074         <range>: New method.
1075         (require_partial_symbols): Change return type.
1076         * psymtab.c (require_partial_symbols)
1077         (psym_expand_symtabs_matching): Update.
1078         * mdebugread.c (parse_partial_symbols): Update.
1079         * dbxread.c (dbx_end_psymtab): Update.
1080
1081 2019-01-15  Tom Tromey  <tom@tromey.com>
1082
1083         * symtab.c (lookup_objfile_from_block)
1084         (lookup_symbol_in_objfile_symtabs)
1085         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1086         (find_line_symtab, info_sources_command)
1087         (default_collect_symbol_completion_matches_break_on)
1088         (make_source_files_completion_list): Update.
1089         * symmisc.c (print_objfile_statistics, dump_objfile)
1090         (maintenance_print_symbols, maintenance_info_symtabs)
1091         (maintenance_check_symtabs, maintenance_info_line_tables):
1092         Update.
1093         * source.c (select_source_symtab)
1094         (forget_cached_source_info_for_objfile): Update.
1095         * objfiles.h (class objfile_compunits): Remove.
1096         (struct objfile) <compunits_range>: New typedef.
1097         (compunits): New method.
1098         * objfiles.c (objfile_relocate1): Update.
1099         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1100         * maint.c (count_symtabs_and_blocks): Update.
1101         * linespec.c (iterate_over_all_matching_symtabs): Update.
1102         * cp-support.c (add_symbol_overload_list_qualified): Update.
1103         * coffread.c (coff_symtab_read): Update.
1104         * ada-lang.c (add_nonlocal_symbols)
1105         (ada_collect_symbol_completion_matches)
1106         (ada_add_global_exceptions): Update.
1107
1108 2019-01-15  Tom Tromey  <tom@tromey.com>
1109
1110         * progspace.h (program_space) <objfiles_safe_range>: New
1111         typedef.
1112         <objfiles_safe>: New method.
1113         * objfiles.h (class all_objfiles_safe): Remove.
1114         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1115         * jit.c (jit_inferior_exit_hook): Update.
1116
1117 2019-01-17  Tom Tromey  <tom@tromey.com>
1118
1119         * progspace.h (program_space) <objfiles_range>: New typedef.
1120         <objfiles>: New method.
1121         <objfiles_head>: Rename from objfiles.
1122         (object_files): Update.
1123         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1124         * guile/scm-pretty-print.c
1125         (ppscm_find_pretty_printer_from_objfiles): Update.
1126         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1127         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1128         Update.
1129         * python/py-progspace.c (pspy_get_objfiles): Update.
1130         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1131         Update.
1132         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1133         (objfpy_lookup_objfile_by_build_id): Update.
1134         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1135         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1136         Update.
1137         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1138         (expand_symtab_containing_pc, lookup_objfile_from_block)
1139         (lookup_static_symbol, basic_lookup_transparent_type)
1140         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1141         (find_line_symtab, info_sources_command)
1142         (default_collect_symbol_completion_matches_break_on)
1143         (make_source_files_completion_list, find_main_name): Update.
1144         * symmisc.c (print_symbol_bcache_statistics)
1145         (print_objfile_statistics, maintenance_print_symbols)
1146         (maintenance_print_msymbols, maintenance_print_objfiles)
1147         (maintenance_info_symtabs, maintenance_check_symtabs)
1148         (maintenance_expand_symtabs, maintenance_info_line_tables):
1149         Update.
1150         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1151         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1152         (map_overlay_command, unmap_overlay_command)
1153         (simple_overlay_update, expand_symtabs_matching)
1154         (map_symbol_filenames): Update.
1155         * symfile-debug.c (set_debug_symfile): Update.
1156         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1157         Update.
1158         * source.c (select_source_symtab, forget_cached_source_info):
1159         Update.
1160         * solib.c (solib_read_symbols): Update.
1161         * solib-spu.c (append_ocl_sos): Update.
1162         * psymtab.c (maintenance_print_psymbols)
1163         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1164         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1165         * printcmd.c (info_symbol_command): Update.
1166         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1167         Update.
1168         * objfiles.h (class all_objfiles): Remove.
1169         * objfiles.c (have_partial_symbols, have_full_symbols)
1170         (have_minimal_symbols, qsort_cmp, update_section_map)
1171         (shared_objfile_contains_address_p)
1172         (default_iterate_over_objfiles_in_search_order): Update.
1173         * objc-lang.c (info_selectors_command, info_classes_command)
1174         (find_methods): Update.
1175         * minsyms.c (find_solib_trampoline_target): Update.
1176         * maint.c (maintenance_info_sections)
1177         (maintenance_translate_address, count_symtabs_and_blocks):
1178         Update.
1179         * main.c (captured_main_1): Update.
1180         * linux-thread-db.c (try_thread_db_load_from_pdir)
1181         (has_libpthread): Update.
1182         * linespec.c (iterate_over_all_matching_symtabs)
1183         (search_minsyms_for_name): Update.
1184         * jit.c (jit_find_objf_with_entry_addr): Update.
1185         * hppa-tdep.c (find_unwind_entry)
1186         (hppa_lookup_stub_minimal_symbol): Update.
1187         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1188         Update.
1189         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1190         (elf_gnu_ifunc_resolve_by_got): Update.
1191         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1192         * dwarf-index-write.c (save_gdb_index_command): Update.
1193         * cp-support.c (add_symbol_overload_list_qualified): Update.
1194         * breakpoint.c (create_overlay_event_breakpoint)
1195         (create_longjmp_master_breakpoint)
1196         (create_std_terminate_master_breakpoint)
1197         (create_exception_master_breakpoint): Update.
1198         * blockframe.c (find_pc_partial_function): Update.
1199         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1200         (ada_collect_symbol_completion_matches)
1201         (ada_add_global_exceptions): Update.
1202
1203 2019-01-17  Tom Tromey  <tom@tromey.com>
1204
1205         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1206         declare VEC.
1207         (solib_target_parse_libraries): Change return type.
1208         (library_list_start_segment, library_list_start_section)
1209         (library_list_end_library, library_list_start_library); Update.
1210         (solib_target_free_library_list): Remove.
1211         (solib_target_parse_libraries): Remove cleanup.  Change return
1212         type.
1213         (solib_target_current_sos): Update.
1214
1215 2019-01-17  Tom Tromey  <tromey@bapiya>
1216
1217         * valprint.c: Replace "the the" with "the".
1218         * symtab.c: Replace "the the" with "the".
1219         * solib.c: Replace "the the" with "the".
1220         * solib-dsbt.c: Replace "the the" with "the".
1221         * linespec.c: Replace "the the" with "the".
1222         * dwarf2loc.h: Replace "the the" with "the".
1223         * amd64-windows-tdep.c: Replace "the the" with "the".
1224         * aarch64-tdep.c: Replace "the the" with "the".
1225
1226 2019-01-16  Keith Seitz  <keiths@redhat.com>
1227
1228         PR gdb/23773
1229         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1230         <builder>: Rename to ..
1231         <m_builder>: ... this and make private.
1232         (dwarf2_cu::get_builder): New method.  Change all users of
1233         `builder' to use this method.
1234         (dwarf2_start_symtab): Move to ...
1235         (dwarf2_cu::start_symtab): ... here.  Update all callers
1236         (setup_type_unit_groups): Move to ...
1237         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1238         callers.
1239         (dwarf2_cu::reset_builder): New method.
1240         (process_full_compunit, process_full_type_unit): Use
1241         dwarf2_cu::reset_builder.
1242         (follow_die_offset): Record the ancestor CU if it is different
1243         from the followed DIE's CU.
1244         (follow_die_sig_1): Likewise.
1245
1246 2019-01-15  Tom Tromey  <tom@tromey.com>
1247
1248         * remote.c (class remote_state) <buf>: Now a char_vector.
1249         <buf_size>: Remove.
1250         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1251         parameter.
1252         (remote_target::getpkt_or_notif_sane_1)
1253         (remote_target::getpkt_sane)
1254         (remote_target::getpkt_or_notif_sane): Likewise.
1255         (class remote_target) <putpkt>: New overload.
1256         (remote_target::read_frame): Change type of "buf_p".  Remove
1257         sizeof_p parameter.
1258         (packet_ok): New overload.
1259         (packet_check_result): New overload.
1260         Update all uses.
1261
1262 2019-01-14  Tom Tromey  <tom@tromey.com>
1263
1264         * remote-notif.c (handle_notification, remote_notif_ack)
1265         (remote_notif_parse): Make "buf" const.
1266         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1267         const.
1268         (remote_notif_parse, remote_notif_ack, handle_notification):
1269         Likewise.
1270         * remote.c (remote_notif_stop_parse): Make "buf" const.
1271         (remote_target::remote_parse_stop_reply): Make "buf" const.
1272         (remote_notif_stop_ack): Make "buf" const.
1273
1274 2019-01-14  Tom Tromey  <tom@tromey.com>
1275
1276         * remote.c (remote_console_output): Make parameter const.
1277
1278 2019-01-14  Tom Tromey  <tom@tromey.com>
1279
1280         * target-debug.h (target_debug_print_signals): Constify.
1281         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1282         * procfs.c (procfs_target::pass_signals): Update.
1283         * linux-nat.c (linux_nat_target::pass_signals): Update.
1284         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1285         * target-delegates.c: Rebuild.
1286         * remote.c (remote_target::program_signals): Update.
1287         (remote_target::pass_signals): Update.
1288         * target.c (target_pass_signals): Constify argument.
1289         (target_program_signals): Likewise.
1290         * target.h (struct target_ops) <pass_signals, program_signals>:
1291         Constify argument.
1292         (target_pass_signals, target_program_signals): Constify argument.
1293
1294 2019-01-14  Tom Tromey  <tom@tromey.com>
1295
1296         PR tui/28819:
1297         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1298
1299 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1300
1301         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1302         field.
1303         * rs6000-tdep.c: Include reggroups.h.
1304         (IS_V_ALIAS_PSEUDOREG): Define.
1305         (rs6000_register_name): Return names for the "vX" aliases.
1306         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1307         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1308         aliases.  Call default_register_reggroup_p for all other
1309         pseudo-registers.
1310         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1311         New functions.
1312         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1313         Handle "vX" aliases.
1314         (v_alias_pseudo_register_collect): New function.
1315         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1316         (rs6000_gdbarch_init): Initialize "vX" aliases as
1317         pseudo-registers.  Restore registration of
1318         rs6000_pseudo_register_reggroup_p with
1319         set_tdesc_pseudo_register_reggroup_p.
1320
1321 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1322
1323         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1324         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1325         set_gdbarch_num_pseudo_regs.
1326
1327 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1328
1329         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1330         Remove arg prefixname, add do_set and do_show.
1331         Add member functions set_list and show_list.
1332         * cli/cli-style.c (class cli_style_option): Update accordingly.
1333         (style_set_list): Move to file scope.
1334         (style_show_list): Likewise.
1335         (set_style): Call help_list.
1336         (show_style): Call cmd_show_list.
1337         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1338         Update to use the new macro.
1339
1340 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1341
1342         * ada-lang.c (_initialize_ada_language): Expand the help text
1343         for the "catch exception" command.
1344
1345 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1346
1347         * symtab.c (matching_obj_sections): Initialize obj,
1348         declare it closer to its usage.
1349
1350 2019-01-10  Tom Tromey  <tom@tromey.com>
1351
1352         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1353         (basic_inf_threads_range): Remove.
1354         (inf_threads_range, inf_non_exited_threads_range)
1355         (safe_inf_threads_range): Use next_adapter.
1356
1357 2019-01-10  Keith Seitz  <keiths@redhat.com>
1358
1359         PR gdb/23712
1360         PR symtab/23010
1361         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1362         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1363
1364 2019-01-10  Keith Seitz  <keiths@redhat.com>
1365
1366         PR gdb/23712
1367         PR symtab/23010
1368         * dictionary.c (pending_to_vector): Remove.
1369         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1370         Remove _1 suffix, replacing functions of the same name.  Update
1371         all callers.
1372         (dict_create_hashed, dict_create_hashed_expandable)
1373         (dict_create_linear, dict_create_linear_expandable, dict_free)
1374         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1375         Make functions static.
1376
1377 2019-01-10  Keith Seitz  <keiths@redhat.com>
1378
1379         PR gdb/23712
1380         PR symtab/23010
1381         * dictionary.h (struct dictionary): Replace declaration with
1382         multidictionary.
1383         (dict_create_hashed, dict_create_hashed_expandable)
1384         (dict_create_linear, dict_create_linear_expandable)
1385         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1386         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1387         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1388         taking multidictionary argument.
1389         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1390         * block.h (struct block) <dict>: Change to multidictionary
1391         and rename `multidict'.
1392         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1393         symmisc.c: Update all dictionary references to multidictionary.
1394
1395 2019-01-10  Keith Seitz  <keiths@redhat.com>
1396
1397         PR gdb/23712
1398         PR symtab/23010
1399         * dictionary.c: Include unordered_map.
1400         (pending_to_vector): New function.
1401         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1402         Rewrite the non-"_1" functions to take vector instead
1403         of linked list.
1404         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1405         "new" _1 versions of the same name.
1406         (multidictionary): Define.
1407         (std::hash<enum language): New definition.
1408         (collate_pending_symbols_by_language, mdict_create_hashed)
1409         (mdict_create_hashed_expandable, mdict_create_linear)
1410         (mdict_create_linear_expandable, mdict_free)
1411         (find_language_dictionary, create_new_language_dictionary)
1412         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1413         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1414         (mdict_size, mdict_empty): New functions.
1415         * dictionary.h (mdict_iterator): Define.
1416
1417 2019-01-10  Pedro Alves  <palves@redhat.com>
1418
1419         * breakpoint.c (read_uploaded_action)
1420         (create_tracepoint_from_upload): Adjust to use
1421         gdb::unique_xmalloc_ptr.
1422         * ctf.c (ctf_write_uploaded_tp):
1423         (SET_ARRAY_FIELD): Use emplace_back.
1424         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1425         * tracefile-tfile.c (tfile_write_uploaded_tp):
1426         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1427         gdb::unique_xmalloc_ptr.
1428         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1429         at_string, cond_string, cmd_strings>: Replace char pointers
1430         with gdb::unique_xmalloc_ptr.
1431
1432 2019-01-10  Pedro Alves  <palves@redhat.com>
1433
1434         * solib-target.c (library_list_start_library): Don't xstrdup name.
1435
1436 2019-01-10  Pedro Alves  <palves@redhat.com>
1437
1438         * mdebugread.c (parse_partial_symbols): Use
1439         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1440
1441 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1442
1443         * linux-fork.c (scoped_switch_fork_info)
1444         <~scoped_switch_fork_info>: Fix incorrect variable name.
1445
1446 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1447
1448         * linux-fork.c (scoped_switch_fork_info)
1449         <scoped_switch_fork_info>: Make explicit.
1450         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1451
1452 2019-01-10  Tom Tromey  <tom@tromey.com>
1453
1454         * objfiles.h (objfile::reset_psymtabs): Update.
1455         * objfiles.c (objfile::objfile): Update.
1456         * psymtab.h (psymtab_storage::obstack): Update.
1457         (psymtab_storage::m_obstack): Use gdb::optional.
1458         (class psymtab_storage): Update comment.  Remove objfile
1459         parameter.
1460         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1461
1462 2019-01-10  Tom Tromey  <tom@tromey.com>
1463
1464         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1465         <free_psymtabs>: Now private.
1466         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1467         (allocate_psymtab): Use new method.
1468
1469 2019-01-10  Tom Tromey  <tom@tromey.com>
1470
1471         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1472         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1473         * mdebugread.c (parse_partial_symbols): Use
1474         allocate_dependencies.
1475         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1476         allocate_dependencies.
1477         (process_psymtab_comp_unit_reader)
1478         (build_type_psymtab_dependencies): Likewise.
1479         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1480
1481 2019-01-10  Tom Tromey  <tom@tromey.com>
1482
1483         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1484         PSYMBOL_SET_LANGUAGE.
1485         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1486
1487 2019-01-10  Tom Tromey  <tom@tromey.com>
1488
1489         * psymtab.h (psymtab_storage::obstack): New method.
1490         <m_obstack>: Rename from obstack; now private.
1491         * psymtab.c (psymtab_storage): Update.
1492         * dwarf2read.c (create_addrmap_from_index)
1493         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1494         Update.
1495
1496 2019-01-10  Tom Tromey  <tom@tromey.com>
1497
1498         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1499         * objfiles.h (objfile::reset_psymtabs): New method.
1500
1501 2019-01-10  Tom Tromey  <tom@tromey.com>
1502
1503         * symmisc.c (print_symbol_bcache_statistics): Update.
1504         (print_objfile_statistics): Update.
1505         * symfile.c (reread_symbols): Update.
1506         * psymtab.h (class psymtab_storage): New.
1507         * psymtab.c (psymtab_storage): New constructor.
1508         (~psymtab_storage): New destructor.
1509         (require_partial_symbols): Update.
1510         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1511         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1512         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1513         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1514         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1515         (start_psymtab_common, end_psymtab_common)
1516         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1517         (allocate_psymtab): Update.
1518         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1519         Update.
1520         (dump_psymtab_addrmap, maintenance_print_psymbols)
1521         (maintenance_check_psymtabs): Update.
1522         (class objfile_psymtabs): Move to objfiles.h.
1523         * psympriv.h (discard_psymtab): Now inline.
1524         (psymtab_discarder::psymtab_discarder): Update.
1525         (psymtab_discarder::~psymtab_discarder): Update.
1526         (ALL_OBJFILE_PSYMTABS): Rewrite.
1527         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1528         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1529         Remove fields.
1530         <partial_symtabs>: New field.
1531         (class objfile_psymtabs): Move from psymtab.h.  Update.
1532         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1533         psymbol_cache.
1534         (objfile::~objfile): Don't destroy psymbol_cache.
1535         * mdebugread.c (parse_partial_symbols): Update.
1536         * dwarf2read.c (create_addrmap_from_index)
1537         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1538         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1539         (add_partial_subprogram, dwarf2_ranges_read): Update.
1540         * dwarf-index-write.c (write_address_map)
1541         (write_one_signatured_type, recursively_write_psymbols)
1542         (class debug_names, class debug_names, write_psymtabs_to_index):
1543         Update.
1544
1545 2019-01-10  Tom Tromey  <tom@tromey.com>
1546
1547         * symtab.h (SYMBOL_SET_NAMES): Update.
1548         (symbol_set_names): Update.
1549         (MSYMBOL_SET_NAMES): Update.
1550         * symtab.c (symbol_set_names): Change argument to be an
1551         objfile_per_bfd_storage.
1552         * psymtab.c (add_psymbol_to_bcache): Update.
1553         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1554
1555 2019-01-10  Tom Tromey  <tom@tromey.com>
1556
1557         * symtab.c (create_demangled_names_hash): Change argument to be an
1558         objfile_per_bfd_storage.
1559         (symbol_set_names): Update.
1560
1561 2019-01-10  Tom Tromey  <tom@tromey.com>
1562
1563         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1564         init_psymbol_list.
1565         * psymtab.c (init_psymbol_list): Do nothing if already called.
1566         * psympriv.h (init_psymbol_list): Add comment.
1567         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1568         init_psymbol_list.
1569         * dbxread.c (dbx_symfile_read): Unconditionally call
1570         init_psymbol_list.
1571
1572 2019-01-10  Tom Tromey  <tom@tromey.com>
1573
1574         * xcoffread.c (scan_xcoff_symtab): Update.
1575         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1576         "where".
1577         * mdebugread.c (parse_partial_symbols)
1578         (handle_psymbol_enumerators): Update.
1579         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1580         * dbxread.c (read_dbx_symtab): Update.
1581         * psympriv.h (psymbol_placement): New enum.
1582         (add_psymbol_to_list): Update.
1583
1584 2019-01-10  Tom Tromey  <tom@tromey.com>
1585
1586         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1587         static_psymbols parameters.
1588         (scan_xcoff_symtab): Update.
1589         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1590         static_psymbols parameters.
1591         * psympriv.h (start_psymtab_common): Update.
1592         * mdebugread.c (parse_partial_symbols): Update.
1593         * dwarf2read.c (create_partial_symtab): Update.
1594         * dbxread.c (read_dbx_symtab): Update.
1595         (start_psymtab): Remove global_psymbols and static_psymbols
1596         parameters.
1597
1598 2019-01-10  Tom Tromey  <tom@tromey.com>
1599
1600         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1601         * psymtab.c (allocate_psymtab): Add comment.
1602         * psympriv.h (allocate_psymtab): Add comment.
1603         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1604         initializations.
1605         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1606
1607 2019-01-10  Tom Tromey  <tom@tromey.com>
1608
1609         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1610         Don't declare.
1611         * mipsread.c: Include mdebugread.h.
1612         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1613         Declare.
1614         * elfread.c: Include mdebugread.h.
1615
1616 2019-01-09  Tom Tromey  <tom@tromey.com>
1617
1618         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1619         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1620         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1621         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1622         (psym_lookup_symbol, psym_find_last_source_symtab)
1623         (psym_forget_cached_source_info, psym_print_stats)
1624         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1625         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1626         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1627         (psym_find_compunit_symtab_by_address)
1628         (maintenance_print_psymbols, maintenance_info_psymtabs)
1629         (maintenance_check_psymtabs): Use ranged for.
1630         * psymtab.h (class objfile_psymtabs): New.
1631         (require_partial_symbols): Return objfile_psymtabs.
1632         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1633
1634 2019-01-09  Tom Tromey  <tom@tromey.com>
1635
1636         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1637         (find_pc_mapped_section, list_overlays_command)
1638         (map_overlay_command, unmap_overlay_command)
1639         (simple_overlay_update): Use all_objfiles.
1640         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1641         * printcmd.c (info_symbol_command): Use all_objfiles.
1642         * objfiles.h (ALL_OBJSECTIONS): Remove.
1643         * maint.c (maintenance_translate_address): Use all_objfiles.
1644         * gcore.c (gcore_create_callback): Use all_objfiles.
1645         (objfile_find_memory_regions): Likewise.
1646
1647 2019-01-09  Tom Tromey  <tom@tromey.com>
1648
1649         * symtab.c (find_line_symtab, info_sources_command)
1650         (make_source_files_completion_list): Use objfile_compunits.
1651         * source.c (select_source_symtab): Use objfile_compunits.
1652         * objfiles.h (struct objfile): Update comment.
1653         (ALL_OBJFILES): Remove.
1654         (ALL_FILETABS): Remove.
1655         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1656         objfile_compunits.
1657
1658 2019-01-09  Tom Tromey  <tom@tromey.com>
1659
1660         * symmisc.c (print_objfile_statistics, dump_objfile)
1661         (maintenance_print_symbols): Use compunit_filetabs.
1662         * source.c (forget_cached_source_info_for_objfile): Use
1663         compunit_filetabs.
1664         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1665         (ALL_FILETABS): Use compunit_filetabs.
1666         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1667         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1668
1669 2019-01-09  Tom Tromey  <tom@tromey.com>
1670
1671         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1672         (compunit_filetabs): New.
1673         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1674         compunit_filetabs.
1675         (info_sources_command, make_source_files_completion_list): Remove
1676         declaration.
1677         * symmisc.c (print_objfile_statistics, dump_objfile)
1678         (maintenance_print_symbols): Remove declaration.
1679         (maintenance_info_symtabs): Use compunit_filetabs.
1680         (maintenance_info_line_tables): Likewise.
1681         * source.c (select_source_symtab): Change local variable name.
1682         (forget_cached_source_info_for_objfile): Remove declaration.
1683         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1684         * objfiles.c (objfile_relocate1): Remove declaration.
1685         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1686         declaration.
1687         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1688         * coffread.c (coff_symtab_read): Remove declaration.
1689         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1690         compunit_filetabs.
1691
1692 2019-01-09  Tom Tromey  <tom@tromey.com>
1693
1694         * symtab.c (lookup_objfile_from_block)
1695         (find_pc_sect_compunit_symtab, search_symbols)
1696         (default_collect_symbol_completion_matches_break_on): Use
1697         objfile_compunits.
1698         * objfiles.h (ALL_COMPUNITS): Remove.
1699         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1700         * cp-support.c (add_symbol_overload_list_qualified): Use
1701         objfile_compunits.
1702         * ada-lang.c (ada_collect_symbol_completion_matches)
1703         (ada_add_global_exceptions): Use objfile_compunits.
1704
1705 2019-01-09  Tom Tromey  <tom@tromey.com>
1706
1707         * source.c (select_source_symtab)
1708         (forget_cached_source_info_for_objfile): Remove declaration.
1709         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1710         declaration.
1711         * maint.c (count_symtabs_and_blocks): Remove declaration.
1712         * cp-support.c (add_symbol_overload_list_qualified): Remove
1713         declaration.
1714         * coffread.c (coff_symtab_read): Remove declaration.
1715         * symtab.c (lookup_symbol_in_objfile_symtabs)
1716         (basic_lookup_transparent_type_1): Use objfile_compunits.
1717         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1718         (info_sources_command, search_symbols)
1719         (default_collect_symbol_completion_matches_break_on)
1720         (make_source_files_completion_list): Remove declaration.
1721         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1722         (ada_collect_symbol_completion_matches)
1723         (ada_add_global_exceptions): Remove declaration.
1724         * linespec.c (iterate_over_all_matching_symtabs): Use
1725         objfile_compunits.
1726         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1727         (class objfile_compunits): New.
1728         (ALL_COMPUNITS): Use objfile_compunits.
1729         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1730         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1731         objfile_compunits.
1732         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1733
1734 2019-01-09  Tom Tromey  <tom@tromey.com>
1735
1736         * symtab.c (search_symbols)
1737         (default_collect_symbol_completion_matches_break_on): Use
1738         objfile_msymbols.
1739         * ada-lang.c (ada_lookup_simple_minsym)
1740         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1741         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1742         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1743         objfile_msymbols.
1744         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1745         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1746         * objc-lang.c (find_methods): Use objfile_msymbols.
1747         (info_selectors_command, info_classes_command): Likewise.
1748         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1749         * objfiles.h (class objfile_msymbols): New.
1750         (ALL_OBJFILE_MSYMBOLS): Remove.
1751         (ALL_MSYMBOLS): Remove.
1752
1753 2019-01-09  Tom Tromey  <tom@tromey.com>
1754
1755         * common/next-iterator.h (next_adapter): Add Iterator template
1756         parameter.
1757         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1758         (class all_objfiles_safe): New.
1759         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1760         * objfiles.c (put_objfile_before): Update comment.
1761         (add_separate_debug_objfile): Likewise.
1762         (free_all_objfiles): Use all_objfiles_safe.
1763         (objfile_purge_solibs): Likewise.
1764
1765 2019-01-09  Tom Tromey  <tom@tromey.com>
1766
1767         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1768         (expand_symtab_containing_pc, lookup_static_symbol)
1769         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1770         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1771         all_objfiles.
1772         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1773         * breakpoint.c (create_overlay_event_breakpoint)
1774         (create_longjmp_master_breakpoint)
1775         (create_std_terminate_master_breakpoint)
1776         (create_exception_master_breakpoint): Use all_objfiles.
1777         * linux-thread-db.c (try_thread_db_load_from_pdir)
1778         (has_libpthread): Use all_objfiles.
1779         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1780         * linespec.c (iterate_over_all_matching_symtabs)
1781         (search_minsyms_for_name): Use all_objfiles.
1782         * maint.c (maintenance_info_sections): Use all_objfiles.
1783         * main.c (captured_main_1): Use all_objfiles.
1784         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1785         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1786         * guile/scm-pretty-print.c
1787         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1788         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1789         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1790         (maintenance_print_msymbols): Use all_objfiles.
1791         * source.c (select_source_symtab): Use all_objfiles.
1792         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1793         * symfile.c (remove_symbol_file_command)
1794         (expand_symtabs_matching, map_symbol_filenames): Use
1795         all_objfiles.
1796         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1797         all_objfiles.
1798         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1799         * objc-lang.c (find_methods): Use all_objfiles.
1800         * objfiles.c (have_partial_symbols, have_full_symbols)
1801         (have_minimal_symbols, qsort_cmp)
1802         (default_iterate_over_objfiles_in_search_order): Use
1803         all_objfiles.
1804         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1805         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1806         (maintenance_check_psymtabs): Use all_objfiles.
1807         (ALL_PSYMTABS): Remove.
1808         * compile/compile-object-run.c (do_module_cleanup): Use
1809         all_objfiles.
1810         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1811         * cp-support.c (add_symbol_overload_list_qualified): Use
1812         all_objfiles.
1813         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1814         Use all_objfiles.
1815         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1816         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1817         all_objfiles.
1818         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1819         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1820         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1821         Uses all_objfiles.
1822         * solib.c (solib_read_symbols): Use all_objfiles
1823
1824 2019-01-09  Tom Tromey  <tom@tromey.com>
1825
1826         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1827         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1828         all_objfiles.
1829         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1830         * symmisc.c (print_symbol_bcache_statistics)
1831         (print_objfile_statistics, maintenance_print_objfiles)
1832         (maintenance_info_symtabs, maintenance_check_symtabs)
1833         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1834         all_objfiles.
1835         * source.c (forget_cached_source_info): Use all_objfiles.
1836         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1837         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1838         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1839         * objfiles.c (update_section_map): Use all_objfiles.
1840         (shared_objfile_contains_address_p): Likewise.
1841         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1842         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1843
1844 2019-01-09  Tom Tromey  <tom@tromey.com>
1845
1846         * common/next-iterator.h: New file.
1847         * objfiles.h (class all_objfiles): New.
1848         (struct objfile_iterator): New.
1849
1850 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1851
1852         * NEWS: Move the description of the changed "frame", "select-frame",
1853          and "info frame" commands to the Changed commands section.
1854
1855 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1856
1857         * gdbtypes.c (check_stub_method_group): Remove handling of old
1858         mangling schemes.
1859         * linespec.c (find_methods): Likewise.
1860         * stabsread.c (read_member_functions): Likewise.
1861         * valops.c (search_struct_method): Likewise.
1862         (value_struct_elt_for_reference): Likewise.
1863         * NEWS: Mention this change.
1864
1865 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1866
1867         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1868         print_source_lines.
1869         * source.c (print_source_lines_base): Update line number check.
1870         (print_source_lines): New function.
1871         (source_lines_range::source_lines_range): New function.
1872         * source.h (class source_lines_range): New class.
1873         (print_source_lines): New declaration.
1874
1875 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1876
1877         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1878
1879 2019-01-08  Tom Tromey  <tom@tromey.com>
1880             Simon Marchi  <simon.marchi@ericsson.com>
1881
1882         PR gdb/24060
1883         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1884         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1885         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1886         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1887         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1888         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1889
1890 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1891
1892         * source.c (select_source_symtab): Move header comment to
1893         declaration in source.h.
1894         (forget_cached_source_info_for_objfile): Likewise.
1895         (forget_cached_source_info): Likewise.
1896         (identify_source_line): Likewise.
1897         * source.h (identify_source_line): Move declaration from symtab.h
1898         and add comment from source.c
1899         (print_source_lines): Likewise.
1900         (forget_cached_source_info_for_objfile): Likewise.
1901         (forget_cached_source_info): Likewise.
1902         (select_source_symtab): Likewise.
1903         (enum print_source_lines_flag): Move definition from symtab.h.
1904         * symtab.h (identify_source_line): Move declaration to source.h.
1905         (print_source_lines): Likewise.
1906         (forget_cached_source_info_for_objfile): Likewise.
1907         (forget_cached_source_info): Likewise.
1908         (select_source_symtab): Likewise.
1909         (enum print_source_lines_flag): Move definition to source.h.
1910         * tui/tui-hooks.c: Add 'source.h' include.
1911
1912 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1913
1914         * source.c (print_source_lines_base): Handle requests to print
1915         reverse line number sequences, and guard against empty lines
1916         string.
1917
1918 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1919
1920         * source.c (print_source_lines_base): Fix skip of '\r' if next
1921         character is '\n'.
1922
1923 2019-01-06  Tom Tromey  <tom@tromey.com>
1924
1925         * c-exp.y (struct c_parse_state) <macro_original_text,
1926         expansion_obstack>: New member.
1927         (macro_original_text, expansion_obstack): Remove globals.
1928         (scan_macro_expansion, scanning_macro_expansion)
1929         (finished_macro_expansion): Update.
1930         (scan_macro_cleanup): Remove.
1931         (yylex, c_parse): Update.
1932
1933 2019-01-06  Tom Tromey  <tom@tromey.com>
1934
1935         * c-exp.y (struct c_parse_state) <strings>: New member.
1936         (operator_stoken): Update.
1937
1938 2019-01-06  Tom Tromey  <tom@tromey.com>
1939
1940         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1941         (union type_stack_elt) <typelist_val>: Now a pointer to
1942         std::vector.
1943         (type_stack_cleanup): Don't declare.
1944         (push_typelist): Update.
1945         * parse.c (pop_typelist): Return a std::vector.
1946         (push_typelist): Take a std::vector.
1947         (follow_types): Update.  Do not free args.
1948         (type_stack_cleanup): Remove.
1949         * c-exp.y (struct c_parse_state): New.
1950         (cpstate): New global.
1951         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1952         (nonempty_typelist): Update.
1953         (func_mod): Create a new vector.
1954         (c_parse): Create a c_parse_state.
1955         (check_parameter_typelist): Do not delete params.
1956         (function_method): Update.  Do not delete type_list.
1957
1958 2019-01-06  Tom Tromey  <tom@tromey.com>
1959
1960         PR gdb/28155:
1961         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1962         check_typedef.
1963         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1964         (print_return_value): Likewise.
1965
1966 2019-01-05  Tom Tromey  <tom@tromey.com>
1967
1968         * contrib/cleanup_check.py: Remove.
1969         * contrib/gcc-with-excheck: Remove.
1970         * contrib/exsummary.py: Remove.
1971         * contrib/excheck.py: Remove.
1972
1973 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1974
1975         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1976         NULL. Initialize tpprev to NULL instead of assigning it
1977         to NULL on the next statement.
1978         * windows-nat.c (windows_delete_thread): Remove check for
1979         main_thread_id before printing thread exit notifications.
1980         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1981         Remove thread ID check against main_thread_id.
1982         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1983         windows_delete_thread.
1984         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1985
1986 2019-01-04  Tom Tromey  <tom@tromey.com>
1987
1988         * compile/compile.c (_initialize_compile): Use upper case for
1989         metasyntactic variables.
1990         * symmisc.c (_initialize_symmisc): Use upper case for
1991         metasyntactic variables.
1992         * psymtab.c (_initialize_psymtab): Use upper case for
1993         metasyntactic variables.
1994         * demangle.c (demangle_command): Use upper case for metasyntactic
1995         variables.
1996         (_initialize_demangler): Likewise.
1997         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1998         variables.
1999
2000 2019-01-03  Tom Tromey  <tom@tromey.com>
2001
2002         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2003
2004 2019-01-03  Tom Tromey  <tom@tromey.com>
2005
2006         * python/py-symtab.c (salpy_str): Update.
2007         (struct salpy_sal_object) <symtab>: Now a PyObject.
2008         (salpy_dealloc): Update.
2009         (del_objfile_sal): Use gdbpy_ref.
2010
2011 2019-01-03  Tom Tromey  <tom@tromey.com>
2012
2013         * python/py-type.c (convert_field): Use new_reference.  Return
2014         gdbpy_ref.
2015         (make_fielditem): Return gdbpy_ref.
2016         (typy_fields): Update.
2017         (typy_getitem): Update.
2018         (field_name): Return gdbpy_ref.  Use new_reference.
2019         (typy_iterator_iternext): Update.
2020
2021 2019-01-03  Tom Tromey  <tom@tromey.com>
2022
2023         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2024
2025 2019-01-03  Tom Tromey  <tom@tromey.com>
2026
2027         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2028         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2029         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2030         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2031         (pspy_set_type_printers): Likewise.
2032         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2033         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2034         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2035         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2036         (objfpy_set_type_printers): Likewise.
2037
2038 2019-01-03  Tom Tromey  <tom@tromey.com>
2039
2040         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2041         (gdbpy_print_stack): Use gdbpy_err_fetch.
2042         * python/python-internal.h (class gdbpy_err_fetch): New class.
2043         (class gdbpy_enter) <m_error_type, m_error_value,
2044         m_error_traceback>: Remove.
2045         <m_error>: New member.
2046         (gdbpy_exception_to_string): Don't declare.
2047         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2048         * python/py-value.c (convert_value_from_python): Use
2049         gdbpy_err_fetch.
2050         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2051         gdbpy_exception_to_string.
2052         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2053         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2054         gdbpy_err_fetch.
2055
2056 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2057
2058         * linux-nat.c (delete_lwp_cleanup): Delete.
2059         (struct lwp_deleter): New struct.
2060         (lwp_info_up): New typedef.
2061         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2062         lwp_info_up.
2063
2064 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2065
2066         * linux-fork.c (class scoped_switch_fork_info): New class.
2067         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2068
2069 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2070
2071         * valops.c (find_overload_match): Remove use of null_cleanup, and
2072         calls to do_cleanups.
2073
2074 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2075
2076         * compile/compile-cplus-types.c
2077         (compile_cplus_instance::decl_name): Handle changes to
2078         cp_func_name.
2079         * cp-support.c (cp_func_name): Update header comment, update
2080         return type.
2081         * cp-support.h (cp_func_name): Update return type in declaration.
2082         * valops.c (find_overload_match): Move temp_func local to top
2083         level of function and change its type.  Use temp_func to hold and
2084         delete temporary string obtained from cp_func_name.
2085
2086 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2087
2088         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2089         gdb::char_vector, remove cleanup, and update uses of `msg`.
2090
2091 2019-01-03  Jim Wilson  <jimw@sifive.com>
2092
2093         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2094
2095 2019-01-02  Tom Tromey  <tom@tromey.com>
2096
2097         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2098         (tdesc_parse_xml): Remove cleanups.
2099         * target-descriptions.h (make_cleanup_free_target_description):
2100         Don't declare.
2101         (target_desc_deleter): New struct.
2102         (target_desc_up): New typedef.
2103         * target-descriptions.c (target_desc_deleter::operator()): Rename
2104         from free_target_description.
2105         (make_cleanup_free_target_description): Remove.
2106
2107 2019-01-02  Tom Tromey  <tom@tromey.com>
2108
2109         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2110         constructor, destructor.
2111         (linespec_parser): Remove typedef.
2112         (~linespec_parser): Rename from linespec_parser_delete.
2113         (linespec_lex_to_end, linespec_complete_label)
2114         (linespec_complete): Update.
2115         (decode_line_full): Remove cleanups.
2116         (decode_line_1): Update.
2117
2118 2019-01-02  Tom Tromey  <tom@tromey.com>
2119
2120         * python/python-internal.h (inferior_to_inferior_object): Change
2121         return type.
2122         * python/py-exitedevent.c (create_exited_event_object): Update.
2123         * python/py-inferior.c (inferior_to_inferior_object): Return
2124         gdbpy_ref.
2125         (python_new_inferior, python_inferior_deleted)
2126         (thread_to_thread_object, delete_thread_object)
2127         (build_inferior_list, gdbpy_selected_inferior): Update.
2128         * python/py-infthread.c (create_thread_object): Update.  Also fail
2129         if inferior_to_inferior_object fails.
2130
2131 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2132
2133         * inferior.h (class inferior) <displaced_step_state>: New field.
2134         * infrun.h (struct displaced_step_state): Move here from
2135         infrun.c.  Initialize fields, add constructor.
2136         <inf>: Remove field.
2137         <reset>: New method.
2138         * infrun.c (struct displaced_step_inferior_state): Move to
2139         infrun.h.
2140         (displaced_step_inferior_states): Remove.
2141         (get_displaced_stepping_state): Adust.
2142         (displaced_step_in_progress_any_inferior): Adjust.
2143         (displaced_step_in_progress_thread): Adjust.
2144         (displaced_step_in_progress): Adjust.
2145         (add_displaced_stepping_state): Remove.
2146         (get_displaced_step_closure_by_addr): Adjust.
2147         (remove_displaced_stepping_state): Remove.
2148         (infrun_inferior_exit): Call displaced_step_state.reset.
2149         (use_displaced_stepping): Don't check for NULL.
2150         (displaced_step_prepare_throw): Call
2151         get_displaced_stepping_state.
2152         (displaced_step_fixup): Don't check for NULL.
2153         (prepare_for_detach): Don't check for NULL.
2154
2155 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2156
2157         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2158          in case of call that did not complete.
2159
2160 2019-01-02  Andrey Utkin  <autkin@undo.io>
2161
2162         * symfile.c (find_separate_debug_file): Fix search of debug files for
2163         remote debuggee.
2164
2165 2019-01-02  Tom Tromey  <tom@tromey.com>
2166
2167         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2168         indentation.
2169         * python/py-frame.c (frapy_older): Remove cast.
2170         (frapy_newer): Likewise.
2171         * python/py-breakpoint.c (local_setattro): Remove cast.
2172         * python/py-arch.c (archpy_name): Remove local variable.
2173         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2174
2175 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2176
2177         * unittests/basic_string_view/element_access/char/empty.cc:
2178         Fix year range in copyright header.
2179
2180 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2181
2182         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2183         Delete.
2184         <operator==>: Update with for removed field.
2185         <hash>: Likewise.
2186         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2187         <isa_features>: ...this.
2188         <abi_features>: New field.
2189         (riscv_isa_flen): Update comment.
2190         (riscv_abi_xlen): New declaration.
2191         (riscv_abi_flen): New declaration.
2192         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2193         isa_features.
2194         (riscv_abi_xlen): New function.
2195         (riscv_isa_flen): Update to get answer from isa_features.
2196         (riscv_abi_flen): New function.
2197         (riscv_has_fp_abi): Update to get answer from abi_features.
2198         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2199         xlen and flen.
2200         (riscv_call_info) <xlen, flen>: Update comment.
2201         (riscv_call_arg_struct): Remove invalid assertions
2202         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2203         is removed.
2204         (riscv_gdbarch_init): Gather isa features and abi features
2205         separately, ensure both match on the gdbarch when reusing an old
2206         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2207         a target with 64-bit float hardware.
2208
2209 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2210
2211         * source.c (search_command_helper): Stop reverse search
2212         when line 1 has been searched.
2213
2214 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2215
2216         * record-full.c (record_full_base_target::close): Rewrite
2217         record_full_core_buf_list free logic.
2218
2219 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2220
2221         * break-catch-syscall.c (print_one_catch_syscall): xfree
2222         the last text.
2223
2224 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2225
2226         * top.c (print_gdb_version): Update Copyright year in version
2227         message.
2228
2229 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2230
2231         Update copyright year range in all GDB files.
2232
2233 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2234
2235         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2236
2237 For older changes see ChangeLog-2018.
2238 \f
2239 Local Variables:
2240 mode: change-log
2241 left-margin: 8
2242 fill-column: 74
2243 version-control: never
2244 coding: utf-8
2245 End:
2246