1 From df997abeebadaa4824271009e2d2b526a70a11cb Mon Sep 17 00:00:00 2001
2 From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
3 Date: Mon, 11 Feb 2019 12:43:23 -0600
4 Subject: iscsi_ibft: Fix missing break in switch statement
6 From: Gustavo A. R. Silva <gustavo@embeddedor.com>
8 commit df997abeebadaa4824271009e2d2b526a70a11cb upstream.
10 Add missing break statement in order to prevent the code from falling
11 through to case ISCSI_BOOT_TGT_NAME, which is unnecessary.
13 This bug was found thanks to the ongoing efforts to enable
14 -Wimplicit-fallthrough.
16 Fixes: b33a84a38477 ("ibft: convert iscsi_ibft module to iscsi boot lib")
17 Cc: stable@vger.kernel.org
18 Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
19 Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
20 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
23 drivers/firmware/iscsi_ibft.c | 1 +
24 1 file changed, 1 insertion(+)
26 --- a/drivers/firmware/iscsi_ibft.c
27 +++ b/drivers/firmware/iscsi_ibft.c
28 @@ -542,6 +542,7 @@ static umode_t __init ibft_check_tgt_for
29 case ISCSI_BOOT_TGT_NIC_ASSOC:
30 case ISCSI_BOOT_TGT_CHAP_TYPE:
33 case ISCSI_BOOT_TGT_NAME:
34 if (tgt->tgt_name_len)