1 From 1c8d723db3d30a0a959ea31a1b390d044b49df16 Mon Sep 17 00:00:00 2001
2 From: Luca Ceresoli <luca@lucaceresoli.net>
3 Date: Tue, 14 May 2019 15:23:07 +0200
4 Subject: net: macb: fix error format in dev_err()
6 [ Upstream commit f413cbb332a0b5251a790f396d0eb4ebcade5dec ]
8 Errors are negative numbers. Using %u shows them as very large positive
9 numbers such as 4294967277 that don't make sense. Use the %d format
10 instead, and get a much nicer -19.
12 Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
13 Fixes: b48e0bab142f ("net: macb: Migrate to devm clock interface")
14 Fixes: 93b31f48b3ba ("net/macb: unify clock management")
15 Fixes: 421d9df0628b ("net/macb: merge at91_ether driver into macb driver")
16 Fixes: aead88bd0e99 ("net: ethernet: macb: Add support for rx_clk")
17 Fixes: f5473d1d44e4 ("net: macb: Support clock management for tsu_clk")
18 Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
19 Reviewed-by: Andrew Lunn <andrew@lunn.ch>
20 Signed-off-by: David S. Miller <davem@davemloft.net>
21 Signed-off-by: Sasha Levin <sashal@kernel.org>
23 drivers/net/ethernet/cadence/macb_main.c | 16 ++++++++--------
24 1 file changed, 8 insertions(+), 8 deletions(-)
26 diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
27 index a6535e226d84..d005ed12b4d1 100644
28 --- a/drivers/net/ethernet/cadence/macb_main.c
29 +++ b/drivers/net/ethernet/cadence/macb_main.c
30 @@ -3377,7 +3377,7 @@ static int macb_clk_init(struct platform_device *pdev, struct clk **pclk,
34 - dev_err(&pdev->dev, "failed to get macb_clk (%u)\n", err);
35 + dev_err(&pdev->dev, "failed to get macb_clk (%d)\n", err);
39 @@ -3386,7 +3386,7 @@ static int macb_clk_init(struct platform_device *pdev, struct clk **pclk,
43 - dev_err(&pdev->dev, "failed to get hclk (%u)\n", err);
44 + dev_err(&pdev->dev, "failed to get hclk (%d)\n", err);
48 @@ -3404,31 +3404,31 @@ static int macb_clk_init(struct platform_device *pdev, struct clk **pclk,
50 err = clk_prepare_enable(*pclk);
52 - dev_err(&pdev->dev, "failed to enable pclk (%u)\n", err);
53 + dev_err(&pdev->dev, "failed to enable pclk (%d)\n", err);
57 err = clk_prepare_enable(*hclk);
59 - dev_err(&pdev->dev, "failed to enable hclk (%u)\n", err);
60 + dev_err(&pdev->dev, "failed to enable hclk (%d)\n", err);
61 goto err_disable_pclk;
64 err = clk_prepare_enable(*tx_clk);
66 - dev_err(&pdev->dev, "failed to enable tx_clk (%u)\n", err);
67 + dev_err(&pdev->dev, "failed to enable tx_clk (%d)\n", err);
68 goto err_disable_hclk;
71 err = clk_prepare_enable(*rx_clk);
73 - dev_err(&pdev->dev, "failed to enable rx_clk (%u)\n", err);
74 + dev_err(&pdev->dev, "failed to enable rx_clk (%d)\n", err);
75 goto err_disable_txclk;
78 err = clk_prepare_enable(*tsu_clk);
80 - dev_err(&pdev->dev, "failed to enable tsu_clk (%u)\n", err);
81 + dev_err(&pdev->dev, "failed to enable tsu_clk (%d)\n", err);
82 goto err_disable_rxclk;
85 @@ -3902,7 +3902,7 @@ static int at91ether_clk_init(struct platform_device *pdev, struct clk **pclk,
87 err = clk_prepare_enable(*pclk);
89 - dev_err(&pdev->dev, "failed to enable pclk (%u)\n", err);
90 + dev_err(&pdev->dev, "failed to enable pclk (%d)\n", err);