1 From b42a7b1bc7c0f535dfe35b2c934f239c60bb8d30 Mon Sep 17 00:00:00 2001
2 From: Kalle Valo <kvalo@qca.qualcomm.com>
3 Date: Mon, 13 Jun 2011 11:54:18 +0300
4 Subject: ath6kl: cache firmware
6 From: Kalle Valo <kvalo@qca.qualcomm.com>
8 commit b42a7b1bc7c0f535dfe35b2c934f239c60bb8d30 upstream.
10 Drivers should not request firmware during resume. Fix ath6kl to
11 cache the firmware instead.
13 Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
14 Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
17 drivers/staging/ath6kl/os/linux/ar6000_drv.c | 49 +++++++++++++------
18 drivers/staging/ath6kl/os/linux/include/ar6000_drv.h | 9 +++
19 2 files changed, 43 insertions(+), 15 deletions(-)
21 --- a/drivers/staging/ath6kl/os/linux/ar6000_drv.c
22 +++ b/drivers/staging/ath6kl/os/linux/ar6000_drv.c
23 @@ -954,9 +954,13 @@ ar6000_transfer_bin_file(struct ar6_soft
25 const struct firmware *fw_entry;
33 + buf_len = &ar->fw_otp_len;
34 if (ar->arVersion.target_ver == AR6003_REV1_VERSION) {
35 filename = AR6003_REV1_OTP_FILE;
36 } else if (ar->arVersion.target_ver == AR6003_REV2_VERSION) {
37 @@ -970,6 +974,8 @@ ar6000_transfer_bin_file(struct ar6_soft
40 case AR6K_FIRMWARE_FILE:
42 + buf_len = &ar->fw_len;
43 if (ar->arVersion.target_ver == AR6003_REV1_VERSION) {
44 filename = AR6003_REV1_FIRMWARE_FILE;
45 } else if (ar->arVersion.target_ver == AR6003_REV2_VERSION) {
46 @@ -1028,6 +1034,8 @@ ar6000_transfer_bin_file(struct ar6_soft
50 + buf = &ar->fw_patch;
51 + buf_len = &ar->fw_patch_len;
52 if (ar->arVersion.target_ver == AR6003_REV1_VERSION) {
53 filename = AR6003_REV1_PATCH_FILE;
54 } else if (ar->arVersion.target_ver == AR6003_REV2_VERSION) {
55 @@ -1041,6 +1049,8 @@ ar6000_transfer_bin_file(struct ar6_soft
58 case AR6K_BOARD_DATA_FILE:
60 + buf_len = &ar->fw_data_len;
61 if (ar->arVersion.target_ver == AR6003_REV1_VERSION) {
62 filename = AR6003_REV1_BOARD_DATA_FILE;
63 } else if (ar->arVersion.target_ver == AR6003_REV2_VERSION) {
64 @@ -1057,23 +1067,29 @@ ar6000_transfer_bin_file(struct ar6_soft
65 AR_DEBUG_PRINTF(ATH_DEBUG_ERR, ("Unknown file type: %d\n", file));
68 - if ((A_REQUEST_FIRMWARE(&fw_entry, filename, ((struct device *)ar->osDevInfo.pOSDevice))) != 0)
70 - AR_DEBUG_PRINTF(ATH_DEBUG_ERR, ("Failed to get %s\n", filename));
74 + if ((A_REQUEST_FIRMWARE(&fw_entry, filename, ((struct device *)ar->osDevInfo.pOSDevice))) != 0) {
75 + AR_DEBUG_PRINTF(ATH_DEBUG_ERR, ("Failed to get %s\n", filename));
79 + *buf = kmemdup(fw_entry->data, fw_entry->size, GFP_KERNEL);
80 + *buf_len = fw_entry->size;
81 + A_RELEASE_FIRMWARE(fw_entry);
84 #ifdef SOFTMAC_FILE_USED
85 - if (file==AR6K_BOARD_DATA_FILE && fw_entry->data) {
86 - ar6000_softmac_update(ar, (u8 *)fw_entry->data, fw_entry->size);
87 + if (file==AR6K_BOARD_DATA_FILE && *buf_len) {
88 + ar6000_softmac_update(ar, *buf, *buf_len);
93 - fw_entry_size = fw_entry->size;
94 + fw_entry_size = *buf_len;
96 /* Load extended board data for AR6003 */
97 - if ((file==AR6K_BOARD_DATA_FILE) && (fw_entry->data)) {
98 + if ((file==AR6K_BOARD_DATA_FILE) && *buf) {
99 u32 board_ext_address;
100 u32 board_ext_data_size;
102 @@ -1089,14 +1105,13 @@ ar6000_transfer_bin_file(struct ar6_soft
103 AR_DEBUG_PRINTF(ATH_DEBUG_INFO, ("Board extended Data download address: 0x%x\n", board_ext_address));
105 /* check whether the target has allocated memory for extended board data and file contains extended board data */
106 - if ((board_ext_address) && (fw_entry->size == (board_data_size + board_ext_data_size))) {
107 + if ((board_ext_address) && (*buf_len == (board_data_size + board_ext_data_size))) {
110 - status = BMIWriteMemory(ar->arHifDevice, board_ext_address, (u8 *)(fw_entry->data + board_data_size), board_ext_data_size);
111 + status = BMIWriteMemory(ar->arHifDevice, board_ext_address, (u8 *)(*buf + board_data_size), board_ext_data_size);
114 AR_DEBUG_PRINTF(ATH_DEBUG_ERR, ("BMI operation failed: %d\n", __LINE__));
115 - A_RELEASE_FIRMWARE(fw_entry);
119 @@ -1110,17 +1125,16 @@ ar6000_transfer_bin_file(struct ar6_soft
123 - status = BMIFastDownload(ar->arHifDevice, address, (u8 *)fw_entry->data, fw_entry_size);
124 + status = BMIFastDownload(ar->arHifDevice, address, *buf, fw_entry_size);
126 - status = BMIWriteMemory(ar->arHifDevice, address, (u8 *)fw_entry->data, fw_entry_size);
127 + status = BMIWriteMemory(ar->arHifDevice, address, *buf, fw_entry_size);
131 AR_DEBUG_PRINTF(ATH_DEBUG_ERR, ("BMI operation failed: %d\n", __LINE__));
132 - A_RELEASE_FIRMWARE(fw_entry);
135 - A_RELEASE_FIRMWARE(fw_entry);
140 @@ -2088,6 +2102,11 @@ ar6000_destroy(struct net_device *dev, u
141 ar6000_remove_ap_interface();
142 #endif /*CONFIG_AP_VIRTUAL_ADAPTER_SUPPORT */
146 + kfree(ar->fw_patch);
147 + kfree(ar->fw_data);
149 AR_DEBUG_PRINTF(ATH_DEBUG_INFO,("-ar6000_destroy \n"));
152 --- a/drivers/staging/ath6kl/os/linux/include/ar6000_drv.h
153 +++ b/drivers/staging/ath6kl/os/linux/include/ar6000_drv.h
154 @@ -651,6 +651,15 @@ struct ar6_softc {
164 + size_t fw_patch_len;
166 + size_t fw_data_len;
169 #ifdef CONFIG_AP_VIRTUAL_ADAPTER_SUPPORT