1 From a7ea19926ffba86f373f6050a106cd162dbb9a78 Mon Sep 17 00:00:00 2001
2 From: David Herrmann <dh.herrmann@googlemail.com>
3 Date: Tue, 20 Sep 2011 09:16:12 -0700
4 Subject: Platform: Fix error path in samsung-laptop init
6 From: David Herrmann <dh.herrmann@googlemail.com>
8 commit a7ea19926ffba86f373f6050a106cd162dbb9a78 upstream.
10 samsung_init() should not return success if not all devices are initialized.
11 Otherwise, samsung_exit() will dereference sdev NULL pointers and others.
13 Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
14 Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 Signed-off-by: Matthew Garrett <mjg@redhat.com>
18 drivers/platform/x86/samsung-laptop.c | 3 +--
19 1 file changed, 1 insertion(+), 2 deletions(-)
21 --- a/drivers/platform/x86/samsung-laptop.c
22 +++ b/drivers/platform/x86/samsung-laptop.c
23 @@ -799,7 +799,7 @@ static int __init samsung_init(void)
24 sabi_iface = ioremap_nocache(ifaceP, 16);
26 pr_err("Can't remap %x\n", ifaceP);
28 + goto error_no_signature;
31 printk(KERN_DEBUG "ifaceP = 0x%08x\n", ifaceP);
32 @@ -851,7 +851,6 @@ static int __init samsung_init(void)
34 goto error_file_create;