]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/blob - releases/3.18.51/brcmfmac-avoid-gcc-5.1-warning.patch
4.9-stable patches
[thirdparty/kernel/stable-queue.git] / releases / 3.18.51 / brcmfmac-avoid-gcc-5.1-warning.patch
1 From 22f44150aad7a1d6b074ab6cf59abee61c7187c6 Mon Sep 17 00:00:00 2001
2 From: Arnd Bergmann <arnd@arndb.de>
3 Date: Tue, 12 May 2015 23:54:25 +0200
4 Subject: brcmfmac: avoid gcc-5.1 warning
5
6 From: Arnd Bergmann <arnd@arndb.de>
7
8 commit 22f44150aad7a1d6b074ab6cf59abee61c7187c6 upstream.
9
10 gcc-5.0 gained a new warning in the fwsignal portion of the brcmfmac
11 driver:
12
13 drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c: In function 'brcmf_fws_txs_process':
14 drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c:1478:8: warning: 'skb' may be used uninitialized in this function [-Wmaybe-uninitialized]
15
16 This is a false positive, and marking the brcmf_fws_hanger_poppkt function
17 as 'static inline' makes the warning go away. I have checked the object
18 file output and while a little code gets moved around, the size of
19 the binary remains identical.
20
21 Signed-off-by: Arnd Bergmann <arnd@arndb.de>
22 Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
23 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
24
25 ---
26 drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c | 2 +-
27 1 file changed, 1 insertion(+), 1 deletion(-)
28
29 --- a/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
30 +++ b/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
31 @@ -635,7 +635,7 @@ static int brcmf_fws_hanger_pushpkt(stru
32 return 0;
33 }
34
35 -static int brcmf_fws_hanger_poppkt(struct brcmf_fws_hanger *h,
36 +static inline int brcmf_fws_hanger_poppkt(struct brcmf_fws_hanger *h,
37 u32 slot_id, struct sk_buff **pktout,
38 bool remove_item)
39 {