releases/3.18.85/staging-iio-cdc-fix-improper-return-value.patch

   1 From foo@baz Tue Nov 28 10:58:31 CET 2017
   2 From: Pan Bian <bianpan2016@163.com>
   3 Date: Sat, 3 Dec 2016 21:44:30 +0800
   4 Subject: staging: iio: cdc: fix improper return value
   5
   6 From: Pan Bian <bianpan2016@163.com>
   7
   8
   9 [ Upstream commit 91ca1a8c584f55857b1f6ab20a1d3a1ce7a559bb ]
  10
  11 At the end of function ad7150_write_event_config(), directly returns 0.
  12 As a result, the errors will be ignored by the callers. It may be better
  13 to return variable "ret".
  14
  15 Signed-off-by: Pan Bian <bianpan2016@163.com>
  16 Signed-off-by: Jonathan Cameron <jic23@kernel.org>
  17 Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
  18 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  19 ---
  20  drivers/staging/iio/cdc/ad7150.c |    2 +-
  21  1 file changed, 1 insertion(+), 1 deletion(-)
  22
  23 --- a/drivers/staging/iio/cdc/ad7150.c
  24 +++ b/drivers/staging/iio/cdc/ad7150.c
  25 @@ -275,7 +275,7 @@ static int ad7150_write_event_config(str
  26  error_ret:
  27         mutex_unlock(&chip->state_lock);
  28
  29 -       return 0;
  30 +       return ret;
  31  }
  32
  33  static int ad7150_read_event_value(struct iio_dev *indio_dev,