1 From 26fd12209c08fe947be1828896ef4ffc5bd0e6df Mon Sep 17 00:00:00 2001
2 From: Barry Song <Baohua.Song@csr.com>
3 Date: Thu, 27 Sep 2012 16:36:10 +0800
4 Subject: dmaengine: sirf: fix a typo in moving running dma_desc to active queue
6 From: Barry Song <Baohua.Song@csr.com>
8 commit 26fd12209c08fe947be1828896ef4ffc5bd0e6df upstream.
10 list_move_tail(&schan->queued, &schan->active) makes the list_empty(schan->queued)
11 undefined, we either should change it to:
12 list_move_tail(schan->queued.next, &schan->active)
14 list_move_tail(&sdesc->node, &schan->active)
16 Signed-off-by: Barry Song <Baohua.Song@csr.com>
17 Signed-off-by: Vinod Koul <vinod.koul@linux.intel.com>
18 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
21 drivers/dma/sirf-dma.c | 2 +-
22 1 file changed, 1 insertion(+), 1 deletion(-)
24 --- a/drivers/dma/sirf-dma.c
25 +++ b/drivers/dma/sirf-dma.c
26 @@ -109,7 +109,7 @@ static void sirfsoc_dma_execute(struct s
27 sdesc = list_first_entry(&schan->queued, struct sirfsoc_dma_desc,
29 /* Move the first queued descriptor to active list */
30 - list_move_tail(&schan->queued, &schan->active);
31 + list_move_tail(&sdesc->node, &schan->active);
33 /* Start the DMA transfer */
34 writel_relaxed(sdesc->width, sdma->base + SIRFSOC_DMA_WIDTH_0 +