releases/3.4.39/bonding-remove-already-created-master-sysfs-link-on-failure.patch

   1 From 80213f2c67f0e0601b6616f455660c9b046d36a7 Mon Sep 17 00:00:00 2001
   2 From: Veaceslav Falico <vfalico@redhat.com>
   3 Date: Tue, 26 Mar 2013 17:43:28 +0100
   4 Subject: bonding: remove already created master sysfs link on failure
   5
   6
   7 From: Veaceslav Falico <vfalico@redhat.com>
   8
   9 [ Upstream commit 9fe16b78ee17579cb4f333534cf7043e94c67024 ]
  10
  11 If slave sysfs symlink failes to be created - we end up without removing
  12 the master sysfs symlink. Remove it in case of failure.
  13
  14 Signed-off-by: Veaceslav Falico <vfalico@redhat.com>
  15 Signed-off-by: David S. Miller <davem@davemloft.net>
  16 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  17 ---
  18  drivers/net/bonding/bond_sysfs.c |    5 +++++
  19  1 file changed, 5 insertions(+)
  20
  21 --- a/drivers/net/bonding/bond_sysfs.c
  22 +++ b/drivers/net/bonding/bond_sysfs.c
  23 @@ -183,6 +183,11 @@ int bond_create_slave_symlinks(struct ne
  24         sprintf(linkname, "slave_%s", slave->name);
  25         ret = sysfs_create_link(&(master->dev.kobj), &(slave->dev.kobj),
  26                                 linkname);
  27 +
  28 +       /* free the master link created earlier in case of error */
  29 +       if (ret)
  30 +               sysfs_remove_link(&(slave->dev.kobj), "master");
  31 +
  32         return ret;
  33
  34  }