]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/blob - releases/4.14.113/alsa-sb8-add-a-check-for-request_region.patch
Linux 4.9.170
[thirdparty/kernel/stable-queue.git] / releases / 4.14.113 / alsa-sb8-add-a-check-for-request_region.patch
1 From 682f852a5e86fe259240deeca5c0499fa2f31178 Mon Sep 17 00:00:00 2001
2 From: Kangjie Lu <kjlu@umn.edu>
3 Date: Thu, 14 Mar 2019 23:04:14 -0500
4 Subject: ALSA: sb8: add a check for request_region
5
6 [ Upstream commit dcd0feac9bab901d5739de51b3f69840851f8919 ]
7
8 In case request_region fails, the fix returns an error code to
9 avoid NULL pointer dereference.
10
11 Signed-off-by: Kangjie Lu <kjlu@umn.edu>
12 Signed-off-by: Takashi Iwai <tiwai@suse.de>
13 Signed-off-by: Sasha Levin <sashal@kernel.org>
14 ---
15 sound/isa/sb/sb8.c | 4 ++++
16 1 file changed, 4 insertions(+)
17
18 diff --git a/sound/isa/sb/sb8.c b/sound/isa/sb/sb8.c
19 index d77dcba276b5..1eb8b61a185b 100644
20 --- a/sound/isa/sb/sb8.c
21 +++ b/sound/isa/sb/sb8.c
22 @@ -111,6 +111,10 @@ static int snd_sb8_probe(struct device *pdev, unsigned int dev)
23
24 /* block the 0x388 port to avoid PnP conflicts */
25 acard->fm_res = request_region(0x388, 4, "SoundBlaster FM");
26 + if (!acard->fm_res) {
27 + err = -EBUSY;
28 + goto _err;
29 + }
30
31 if (port[dev] != SNDRV_AUTO_PORT) {
32 if ((err = snd_sbdsp_create(card, port[dev], irq[dev],
33 --
34 2.19.1
35