releases/4.14.82/drm-nouveau-check-backlight-ids-are-0-not-0.patch

   1 From dc854914999d5d52ac1b31740cb0ea8d89d0372e Mon Sep 17 00:00:00 2001
   2 From: Lyude Paul <lyude@redhat.com>
   3 Date: Thu, 6 Sep 2018 17:43:21 -0400
   4 Subject: drm/nouveau: Check backlight IDs are >= 0, not > 0
   5
   6 From: Lyude Paul <lyude@redhat.com>
   7
   8 commit dc854914999d5d52ac1b31740cb0ea8d89d0372e upstream.
   9
  10 Remember, ida IDs start at 0, not 1!
  11
  12 Signed-off-by: Lyude Paul <lyude@redhat.com>
  13 Reviewed-by: Karol Herbst <kherbst@redhat.com>
  14 Cc: stable@vger.kernel.org
  15 Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
  16 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  17
  18 ---
  19  drivers/gpu/drm/nouveau/nouveau_backlight.c |    4 ++--
  20  1 file changed, 2 insertions(+), 2 deletions(-)
  21
  22 --- a/drivers/gpu/drm/nouveau/nouveau_backlight.c
  23 +++ b/drivers/gpu/drm/nouveau/nouveau_backlight.c
  24 @@ -116,7 +116,7 @@ nv40_backlight_init(struct drm_connector
  25                                        &nv40_bl_ops, &props);
  26
  27         if (IS_ERR(bd)) {
  28 -               if (bl_connector.id > 0)
  29 +               if (bl_connector.id >= 0)
  30                         ida_simple_remove(&bl_ida, bl_connector.id);
  31                 return PTR_ERR(bd);
  32         }
  33 @@ -249,7 +249,7 @@ nv50_backlight_init(struct drm_connector
  34                                        nv_encoder, ops, &props);
  35
  36         if (IS_ERR(bd)) {
  37 -               if (bl_connector.id > 0)
  38 +               if (bl_connector.id >= 0)
  39                         ida_simple_remove(&bl_ida, bl_connector.id);
  40                 return PTR_ERR(bd);
  41         }