releases/4.16.4/cifs-fix-sha512-check-in-cifs_crypto_secmech_release.patch

   1 From 70e80655f58e17a2e38e577e1b4fa7a8c99619a0 Mon Sep 17 00:00:00 2001
   2 From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
   3 Date: Mon, 19 Feb 2018 11:11:13 -0600
   4 Subject: CIFS: fix sha512 check in cifs_crypto_secmech_release
   5
   6 From: Gustavo A. R. Silva <gustavo@embeddedor.com>
   7
   8 commit 70e80655f58e17a2e38e577e1b4fa7a8c99619a0 upstream.
   9
  10 It seems this is a copy-paste error and that the proper variable to use
  11 in this particular case is _sha512_ instead of _md5_.
  12
  13 Addresses-Coverity-ID: 1465358 ("Copy-paste error")
  14 Fixes: 1c6614d229e7 ("CIFS: add sha512 secmech")
  15 Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
  16 Reviewed-by: Aurelien Aptel <aaptel@suse.com>
  17 CC: Stable <stable@vger.kernel.org>
  18 Signed-off-by: Steve French <smfrench@gmail.com>
  19 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  20
  21 ---
  22  fs/cifs/cifsencrypt.c |    2 +-
  23  1 file changed, 1 insertion(+), 1 deletion(-)
  24
  25 --- a/fs/cifs/cifsencrypt.c
  26 +++ b/fs/cifs/cifsencrypt.c
  27 @@ -829,7 +829,7 @@ cifs_crypto_secmech_release(struct TCP_S
  28                 server->secmech.md5 = NULL;
  29         }
  30
  31 -       if (server->secmech.md5) {
  32 +       if (server->secmech.sha512) {
  33                 crypto_free_shash(server->secmech.sha512);
  34                 server->secmech.sha512 = NULL;
  35         }