releases/4.4.152/net-qca_spi-fix-log-level-if-probe-fails.patch

   1 From foo@baz Wed Aug 22 10:28:26 CEST 2018
   2 From: Stefan Wahren <stefan.wahren@i2se.com>
   3 Date: Wed, 18 Jul 2018 08:31:45 +0200
   4 Subject: net: qca_spi: Fix log level if probe fails
   5
   6 From: Stefan Wahren <stefan.wahren@i2se.com>
   7
   8 [ Upstream commit 50973993260a6934f0a00da53d9b746cfbea89ab ]
   9
  10 In cases the probing fails the log level of the messages should
  11 be an error.
  12
  13 Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
  14 Signed-off-by: David S. Miller <davem@davemloft.net>
  15 Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
  16 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  17 ---
  18  drivers/net/ethernet/qualcomm/qca_spi.c |   16 ++++++++--------
  19  1 file changed, 8 insertions(+), 8 deletions(-)
  20
  21 --- a/drivers/net/ethernet/qualcomm/qca_spi.c
  22 +++ b/drivers/net/ethernet/qualcomm/qca_spi.c
  23 @@ -868,22 +868,22 @@ qca_spi_probe(struct spi_device *spi)
  24
  25         if ((qcaspi_clkspeed < QCASPI_CLK_SPEED_MIN) ||
  26             (qcaspi_clkspeed > QCASPI_CLK_SPEED_MAX)) {
  27 -               dev_info(&spi->dev, "Invalid clkspeed: %d\n",
  28 -                        qcaspi_clkspeed);
  29 +               dev_err(&spi->dev, "Invalid clkspeed: %d\n",
  30 +                       qcaspi_clkspeed);
  31                 return -EINVAL;
  32         }
  33
  34         if ((qcaspi_burst_len < QCASPI_BURST_LEN_MIN) ||
  35             (qcaspi_burst_len > QCASPI_BURST_LEN_MAX)) {
  36 -               dev_info(&spi->dev, "Invalid burst len: %d\n",
  37 -                        qcaspi_burst_len);
  38 +               dev_err(&spi->dev, "Invalid burst len: %d\n",
  39 +                       qcaspi_burst_len);
  40                 return -EINVAL;
  41         }
  42
  43         if ((qcaspi_pluggable < QCASPI_PLUGGABLE_MIN) ||
  44             (qcaspi_pluggable > QCASPI_PLUGGABLE_MAX)) {
  45 -               dev_info(&spi->dev, "Invalid pluggable: %d\n",
  46 -                        qcaspi_pluggable);
  47 +               dev_err(&spi->dev, "Invalid pluggable: %d\n",
  48 +                       qcaspi_pluggable);
  49                 return -EINVAL;
  50         }
  51
  52 @@ -944,8 +944,8 @@ qca_spi_probe(struct spi_device *spi)
  53         }
  54
  55         if (register_netdev(qcaspi_devs)) {
  56 -               dev_info(&spi->dev, "Unable to register net device %s\n",
  57 -                        qcaspi_devs->name);
  58 +               dev_err(&spi->dev, "Unable to register net device %s\n",
  59 +                       qcaspi_devs->name);
  60                 free_netdev(qcaspi_devs);
  61                 return -EFAULT;
  62         }