releases/4.4.165/um-give-start_idle_thread-a-return-code.patch

   1 From 6a29d250af766db1e5163b1afba98170ec5b4314 Mon Sep 17 00:00:00 2001
   2 From: Richard Weinberger <richard@nod.at>
   3 Date: Fri, 15 Jun 2018 16:42:56 +0200
   4 Subject: um: Give start_idle_thread() a return code
   5
   6 [ Upstream commit 7ff1e34bbdc15acab823b1ee4240e94623d50ee8 ]
   7
   8 Fixes:
   9 arch/um/os-Linux/skas/process.c:613:1: warning: control reaches end of
  10 non-void function [-Wreturn-type]
  11
  12 longjmp() never returns but gcc still warns that the end of the function
  13 can be reached.
  14 Add a return code and debug aid to detect this impossible case.
  15
  16 Signed-off-by: Richard Weinberger <richard@nod.at>
  17 Signed-off-by: Sasha Levin <sashal@kernel.org>
  18 ---
  19  arch/um/os-Linux/skas/process.c | 5 +++++
  20  1 file changed, 5 insertions(+)
  21
  22 diff --git a/arch/um/os-Linux/skas/process.c b/arch/um/os-Linux/skas/process.c
  23 index b856c66ebd3a..6dbf27ffafc8 100644
  24 --- a/arch/um/os-Linux/skas/process.c
  25 +++ b/arch/um/os-Linux/skas/process.c
  26 @@ -585,6 +585,11 @@ int start_idle_thread(void *stack, jmp_buf *switch_buf)
  27                 fatal_sigsegv();
  28         }
  29         longjmp(*switch_buf, 1);
  30 +
  31 +       /* unreachable */
  32 +       printk(UM_KERN_ERR "impossible long jump!");
  33 +       fatal_sigsegv();
  34 +       return 0;
  35  }
  36
  37  void initial_thread_cb_skas(void (*proc)(void *), void *arg)
  38 --
  39 2.17.1
  40