]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/blob - releases/4.4.170/alsa-cs46xx-potential-null-dereference-in-probe.patch
fixes for 4.19
[thirdparty/kernel/stable-queue.git] / releases / 4.4.170 / alsa-cs46xx-potential-null-dereference-in-probe.patch
1 From 1524f4e47f90b27a3ac84efbdd94c63172246a6f Mon Sep 17 00:00:00 2001
2 From: Dan Carpenter <dan.carpenter@oracle.com>
3 Date: Tue, 8 Jan 2019 10:43:30 +0300
4 Subject: ALSA: cs46xx: Potential NULL dereference in probe
5
6 From: Dan Carpenter <dan.carpenter@oracle.com>
7
8 commit 1524f4e47f90b27a3ac84efbdd94c63172246a6f upstream.
9
10 The "chip->dsp_spos_instance" can be NULL on some of the ealier error
11 paths in snd_cs46xx_create().
12
13 Reported-by: "Yavuz, Tuba" <tuba@ece.ufl.edu>
14 Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
15 Cc: <stable@vger.kernel.org>
16 Signed-off-by: Takashi Iwai <tiwai@suse.de>
17 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
18
19 ---
20 sound/pci/cs46xx/dsp_spos.c | 3 +++
21 1 file changed, 3 insertions(+)
22
23 --- a/sound/pci/cs46xx/dsp_spos.c
24 +++ b/sound/pci/cs46xx/dsp_spos.c
25 @@ -899,6 +899,9 @@ int cs46xx_dsp_proc_done (struct snd_cs4
26 struct dsp_spos_instance * ins = chip->dsp_spos_instance;
27 int i;
28
29 + if (!ins)
30 + return 0;
31 +
32 snd_info_free_entry(ins->proc_sym_info_entry);
33 ins->proc_sym_info_entry = NULL;
34