releases/4.9.130/alsa-fireworks-fix-memory-leak-of-response-buffer-at-error-path.patch

   1 From c3b55e2ec9c76e7a0de2a0b1dc851fdc9440385b Mon Sep 17 00:00:00 2001
   2 From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
   3 Date: Mon, 17 Sep 2018 17:26:41 +0900
   4 Subject: ALSA: fireworks: fix memory leak of response buffer at error path
   5
   6 From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
   7
   8 commit c3b55e2ec9c76e7a0de2a0b1dc851fdc9440385b upstream.
   9
  10 After allocating memory object for response buffer, ALSA fireworks
  11 driver has leak of the memory object at error path.
  12
  13 This commit releases the object at the error path.
  14
  15 Fixes: 7d3c1d5901aa('ALSA: fireworks: delayed registration of sound card')
  16 Cc: <stable@vger.kernel.org> # v4.7+
  17 Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
  18 Signed-off-by: Takashi Iwai <tiwai@suse.de>
  19 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  20
  21 ---
  22  sound/firewire/fireworks/fireworks.c |    2 ++
  23  1 file changed, 2 insertions(+)
  24
  25 --- a/sound/firewire/fireworks/fireworks.c
  26 +++ b/sound/firewire/fireworks/fireworks.c
  27 @@ -301,6 +301,8 @@ error:
  28         snd_efw_transaction_remove_instance(efw);
  29         snd_efw_stream_destroy_duplex(efw);
  30         snd_card_free(efw->card);
  31 +       kfree(efw->resp_buf);
  32 +       efw->resp_buf = NULL;
  33         dev_info(&efw->unit->device,
  34                  "Sound card registration failed: %d\n", err);
  35  }