releases/4.9.175/drm-mediatek-fix-possible-object-reference-leak.patch

   1 From 307d2b2abd46dd886a3e7c8f1a489cf2d5ad9a92 Mon Sep 17 00:00:00 2001
   2 From: Wen Yang <wen.yang99@zte.com.cn>
   3 Date: Thu, 4 Apr 2019 00:04:09 +0800
   4 Subject: drm/mediatek: fix possible object reference leak
   5
   6 [ Upstream commit 2ae2c3316fb77dcf64275d011596b60104c45426 ]
   7
   8 The call to of_parse_phandle returns a node pointer with refcount
   9 incremented thus it must be explicitly decremented after the last
  10 usage.
  11
  12 Detected by coccinelle with the following warnings:
  13 drivers/gpu/drm/mediatek/mtk_hdmi.c:1521:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 1509, but without a corresponding object release within this function.
  14 drivers/gpu/drm/mediatek/mtk_hdmi.c:1524:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 1509, but without a corresponding object release within this function.
  15
  16 Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
  17 Cc: CK Hu <ck.hu@mediatek.com>
  18 Cc: Philipp Zabel <p.zabel@pengutronix.de>
  19 Cc: David Airlie <airlied@linux.ie>
  20 Cc: Daniel Vetter <daniel@ffwll.ch>
  21 Cc: Matthias Brugger <matthias.bgg@gmail.com>
  22 Cc: dri-devel@lists.freedesktop.org
  23 Cc: linux-arm-kernel@lists.infradead.org
  24 Cc: linux-mediatek@lists.infradead.org
  25 Cc: linux-kernel@vger.kernel.org
  26 Signed-off-by: CK Hu <ck.hu@mediatek.com>
  27 Signed-off-by: Sasha Levin <sashal@kernel.org>
  28 ---
  29  drivers/gpu/drm/mediatek/mtk_hdmi.c | 1 +
  30  1 file changed, 1 insertion(+)
  31
  32 diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
  33 index 200f75e1d6198..e7a6651ceeab1 100644
  34 --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
  35 +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
  36 @@ -1528,6 +1528,7 @@ static int mtk_hdmi_dt_parse_pdata(struct mtk_hdmi *hdmi,
  37         of_node_put(remote);
  38
  39         hdmi->ddc_adpt = of_find_i2c_adapter_by_node(i2c_np);
  40 +       of_node_put(i2c_np);
  41         if (!hdmi->ddc_adpt) {
  42                 dev_err(dev, "Failed to get ddc i2c adapter by node\n");
  43                 return -EINVAL;
  44 --
  45 2.20.1
  46