]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/blob - releases/4.9.28/power-supply-bq24190_charger-fix-irq-trigger-to-irqf_trigger_falling.patch
5.1-stable patches
[thirdparty/kernel/stable-queue.git] / releases / 4.9.28 / power-supply-bq24190_charger-fix-irq-trigger-to-irqf_trigger_falling.patch
1 From 767eee362fd72bb2ca44cc80419ca4b38c6d8369 Mon Sep 17 00:00:00 2001
2 From: Liam Breck <liam@networkimprov.net>
3 Date: Wed, 18 Jan 2017 09:26:48 -0800
4 Subject: power: supply: bq24190_charger: Fix irq trigger to IRQF_TRIGGER_FALLING
5
6 From: Liam Breck <liam@networkimprov.net>
7
8 commit 767eee362fd72bb2ca44cc80419ca4b38c6d8369 upstream.
9
10 The interrupt signal is TRIGGER_FALLING. This is is specified in the
11 data sheet PIN FUNCTIONS: "The INT pin sends active low, 256us
12 pulse to host to report charger device status and fault."
13
14 Also the direction can be seen in the data sheet Figure 37 "BQ24190
15 with D+/D- Detection and USB On-The-Go (OTG)" which shows a 10k
16 pull-up resistor installed for the sample configurations.
17
18 Fixes: d7bf353fd0aa3 ("bq24190_charger: Add support for TI BQ24190 Battery Charger")
19 Signed-off-by: Liam Breck <kernel@networkimprov.net>
20 Acked-by: Mark Greer <mgreer@animalcreek.com>
21 Acked-by: Tony Lindgren <tony@atomide.com>
22 Signed-off-by: Sebastian Reichel <sre@kernel.org>
23 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
24
25 ---
26 drivers/power/supply/bq24190_charger.c | 2 +-
27 1 file changed, 1 insertion(+), 1 deletion(-)
28
29 --- a/drivers/power/supply/bq24190_charger.c
30 +++ b/drivers/power/supply/bq24190_charger.c
31 @@ -1394,7 +1394,7 @@ static int bq24190_probe(struct i2c_clie
32
33 ret = devm_request_threaded_irq(dev, bdi->irq, NULL,
34 bq24190_irq_handler_thread,
35 - IRQF_TRIGGER_RISING | IRQF_ONESHOT,
36 + IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
37 "bq24190-charger", bdi);
38 if (ret < 0) {
39 dev_err(dev, "Can't set up irq handler\n");