releases/5.1.3/rtlwifi-rtl8723ae-fix-missing-break-in-switch-statement.patch

   1 From 84242b82d81c54e009a2aaa74d3d9eff70babf56 Mon Sep 17 00:00:00 2001
   2 From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
   3 Date: Tue, 16 Apr 2019 10:17:22 -0500
   4 Subject: rtlwifi: rtl8723ae: Fix missing break in switch statement
   5
   6 From: Gustavo A. R. Silva <gustavo@embeddedor.com>
   7
   8 commit 84242b82d81c54e009a2aaa74d3d9eff70babf56 upstream.
   9
  10 Add missing break statement in order to prevent the code from falling
  11 through to case 0x1025, and erroneously setting rtlhal->oem_id to
  12 RT_CID_819X_ACER when rtlefuse->eeprom_svid is equal to 0x10EC and
  13 none of the cases in switch (rtlefuse->eeprom_smid) match.
  14
  15 This bug was found thanks to the ongoing efforts to enable
  16 -Wimplicit-fallthrough.
  17
  18 Fixes: 238ad2ddf34b ("rtlwifi: rtl8723ae: Clean up the hardware info routine")
  19 Cc: stable@vger.kernel.org
  20 Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
  21 Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
  22 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  23
  24 ---
  25  drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c |    1 +
  26  1 file changed, 1 insertion(+)
  27
  28 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c
  29 +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c
  30 @@ -1675,6 +1675,7 @@ static void _rtl8723e_read_adapter_info(
  31                                         rtlhal->oem_id = RT_CID_819X_LENOVO;
  32                                         break;
  33                                 }
  34 +                               break;
  35                         case 0x1025:
  36                                 rtlhal->oem_id = RT_CID_819X_ACER;
  37                                 break;