releases/6.6.26/net-dsa-sja1105-fix-parameters-order-in-sja1110_pcs_mdio_write_c45.patch

   1 From c120209bce34c49dcaba32f15679574327d09f63 Mon Sep 17 00:00:00 2001
   2 From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
   3 Date: Tue, 2 Apr 2024 20:33:56 +0200
   4 Subject: net: dsa: sja1105: Fix parameters order in sja1110_pcs_mdio_write_c45()
   5
   6 From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
   7
   8 commit c120209bce34c49dcaba32f15679574327d09f63 upstream.
   9
  10 The definition and declaration of sja1110_pcs_mdio_write_c45() don't have
  11 parameters in the same order.
  12
  13 Knowing that sja1110_pcs_mdio_write_c45() is used as a function pointer
  14 in 'sja1105_info' structure with .pcs_mdio_write_c45, and that we have:
  15
  16    int (*pcs_mdio_write_c45)(struct mii_bus *bus, int phy, int mmd,
  17                                   int reg, u16 val);
  18
  19 it is likely that the definition is the one to change.
  20
  21 Found with cppcheck, funcArgOrderDifferent.
  22
  23 Fixes: ae271547bba6 ("net: dsa: sja1105: C45 only transactions for PCS")
  24 Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  25 Reviewed-by: Michael Walle <mwalle@kernel.org>
  26 Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
  27 Link: https://lore.kernel.org/r/ff2a5af67361988b3581831f7bd1eddebfb4c48f.1712082763.git.christophe.jaillet@wanadoo.fr
  28 Signed-off-by: Paolo Abeni <pabeni@redhat.com>
  29 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  30 ---
  31  drivers/net/dsa/sja1105/sja1105_mdio.c |    2 +-
  32  1 file changed, 1 insertion(+), 1 deletion(-)
  33
  34 --- a/drivers/net/dsa/sja1105/sja1105_mdio.c
  35 +++ b/drivers/net/dsa/sja1105/sja1105_mdio.c
  36 @@ -94,7 +94,7 @@ int sja1110_pcs_mdio_read_c45(struct mii
  37         return tmp & 0xffff;
  38  }
  39
  40 -int sja1110_pcs_mdio_write_c45(struct mii_bus *bus, int phy, int reg, int mmd,
  41 +int sja1110_pcs_mdio_write_c45(struct mii_bus *bus, int phy, int mmd, int reg,
  42                                u16 val)
  43  {
  44         struct sja1105_mdio_private *mdio_priv = bus->priv;