git.ipfire.org Git - thirdparty/kernel/stable-queue.git/blob

   1 From foo@baz Tue May 10 01:59:12 PM CEST 2022
   2 From: "Marek Behún" <kabel@kernel.org>
   3 Date: Wed,  4 May 2022 18:57:39 +0200
   4 Subject: PCI: aardvark: Check return value of generic_handle_domain_irq() when processing INTx IRQ
   5 To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sasha Levin <sashal@kernel.org>
   6 Cc: stable@vger.kernel.org, pali@kernel.org, "Marek Behún" <kabel@kernel.org>
   7 Message-ID: <20220504165755.30002-15-kabel@kernel.org>
   8
   9 From: Pali Rohár <pali@kernel.org>
  10
  11 commit 51f96e287c6f003d3bb29672811c757c5fbf0028 upstream.
  12
  13 It is possible that we receive spurious INTx interrupt. Check for the
  14 return value of generic_handle_domain_irq() when processing INTx IRQ.
  15
  16 Link: https://lore.kernel.org/r/20220110015018.26359-6-kabel@kernel.org
  17 Signed-off-by: Pali Rohár <pali@kernel.org>
  18 Signed-off-by: Marek Behún <kabel@kernel.org>
  19 Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
  20 Signed-off-by: Marek Behún <kabel@kernel.org>
  21 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  22 ---
  23  drivers/pci/controller/pci-aardvark.c |    4 +++-
  24  1 file changed, 3 insertions(+), 1 deletion(-)
  25
  26 --- a/drivers/pci/controller/pci-aardvark.c
  27 +++ b/drivers/pci/controller/pci-aardvark.c
  28 @@ -1429,7 +1429,9 @@ static void advk_pcie_handle_int(struct
  29                 advk_writel(pcie, PCIE_ISR1_INTX_ASSERT(i),
  30                             PCIE_ISR1_REG);
  31
  32 -               generic_handle_domain_irq(pcie->irq_domain, i);
  33 +               if (generic_handle_domain_irq(pcie->irq_domain, i) == -EINVAL)
  34 +                       dev_err_ratelimited(&pcie->pdev->dev, "unexpected INT%c IRQ\n",
  35 +                                           (char)i + 'A');
  36         }
  37  }
  38