git.ipfire.org Git - thirdparty/kernel/stable-queue.git/blob

   1 From 9bba96275576da0cf78ede62aeb2fc975ed8a32d Mon Sep 17 00:00:00 2001
   2 From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
   3 Date: Wed, 23 Dec 2020 17:36:44 +0300
   4 Subject: platform/x86: i2c-multi-instantiate: Don't create platform device for INT3515 ACPI nodes
   5
   6 From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
   7
   8 commit 9bba96275576da0cf78ede62aeb2fc975ed8a32d upstream.
   9
  10 There are several reports about the tps6598x causing
  11 interrupt flood on boards with the INT3515 ACPI node, which
  12 then causes instability. There appears to be several
  13 problems with the interrupt. One problem is that the
  14 I2CSerialBus resources do not always map to the Interrupt
  15 resource with the same index, but that is not the only
  16 problem. We have not been able to come up with a solution
  17 for all the issues, and because of that disabling the device
  18 for now.
  19
  20 The PD controller on these platforms is autonomous, and the
  21 purpose for the driver is primarily to supply status to the
  22 userspace, so this will not affect any functionality.
  23
  24 Reported-by: Moody Salem <moody@uniswap.org>
  25 Fixes: a3dd034a1707 ("ACPI / scan: Create platform device for INT3515 ACPI nodes")
  26 Cc: stable@vger.kernel.org
  27 BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1883511
  28 Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
  29 Link: https://lore.kernel.org/r/20201223143644.33341-1-heikki.krogerus@linux.intel.com
  30 Signed-off-by: Hans de Goede <hdegoede@redhat.com>
  31 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  32
  33 ---
  34  drivers/platform/x86/i2c-multi-instantiate.c |   31 ++++++++++++++++++++-------
  35  1 file changed, 23 insertions(+), 8 deletions(-)
  36
  37 --- a/drivers/platform/x86/i2c-multi-instantiate.c
  38 +++ b/drivers/platform/x86/i2c-multi-instantiate.c
  39 @@ -166,13 +166,29 @@ static const struct i2c_inst_data bsg215
  40         {}
  41  };
  42
  43 -static const struct i2c_inst_data int3515_data[]  = {
  44 -       { "tps6598x", IRQ_RESOURCE_APIC, 0 },
  45 -       { "tps6598x", IRQ_RESOURCE_APIC, 1 },
  46 -       { "tps6598x", IRQ_RESOURCE_APIC, 2 },
  47 -       { "tps6598x", IRQ_RESOURCE_APIC, 3 },
  48 -       {}
  49 -};
  50 +/*
  51 + * Device with _HID INT3515 (TI PD controllers) has some unresolved interrupt
  52 + * issues. The most common problem seen is interrupt flood.
  53 + *
  54 + * There are at least two known causes. Firstly, on some boards, the
  55 + * I2CSerialBus resource index does not match the Interrupt resource, i.e. they
  56 + * are not one-to-one mapped like in the array below. Secondly, on some boards
  57 + * the IRQ line from the PD controller is not actually connected at all. But the
  58 + * interrupt flood is also seen on some boards where those are not a problem, so
  59 + * there are some other problems as well.
  60 + *
  61 + * Because of the issues with the interrupt, the device is disabled for now. If
  62 + * you wish to debug the issues, uncomment the below, and add an entry for the
  63 + * INT3515 device to the i2c_multi_instance_ids table.
  64 + *
  65 + * static const struct i2c_inst_data int3515_data[]  = {
  66 + *     { "tps6598x", IRQ_RESOURCE_APIC, 0 },
  67 + *     { "tps6598x", IRQ_RESOURCE_APIC, 1 },
  68 + *     { "tps6598x", IRQ_RESOURCE_APIC, 2 },
  69 + *     { "tps6598x", IRQ_RESOURCE_APIC, 3 },
  70 + *     { }
  71 + * };
  72 + */
  73
  74  /*
  75   * Note new device-ids must also be added to i2c_multi_instantiate_ids in
  76 @@ -181,7 +197,6 @@ static const struct i2c_inst_data int351
  77  static const struct acpi_device_id i2c_multi_inst_acpi_ids[] = {
  78         { "BSG1160", (unsigned long)bsg1160_data },
  79         { "BSG2150", (unsigned long)bsg2150_data },
  80 -       { "INT3515", (unsigned long)int3515_data },
  81         { }
  82  };
  83  MODULE_DEVICE_TABLE(acpi, i2c_multi_inst_acpi_ids);