git.ipfire.org Git - thirdparty/openwrt.git/blob

   1 From 22ccaaca43440e90a3b68d2183045b42247dc4be Mon Sep 17 00:00:00 2001
   2 From: =?UTF-8?q?=C3=81lvaro=20Fern=C3=A1ndez=20Rojas?= <noltari@gmail.com>
   3 Date: Sat, 14 Jun 2025 09:59:53 +0200
   4 Subject: [PATCH] net: dsa: b53: prevent SWITCH_CTRL access on BCM5325
   5 MIME-Version: 1.0
   6 Content-Type: text/plain; charset=UTF-8
   7 Content-Transfer-Encoding: 8bit
   8
   9 BCM5325 doesn't implement SWITCH_CTRL register so we should avoid reading
  10 or writing it.
  11
  12 Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
  13 Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
  14 Link: https://patch.msgid.link/20250614080000.1884236-8-noltari@gmail.com
  15 Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  16 ---
  17  drivers/net/dsa/b53/b53_common.c | 11 ++++++-----
  18  1 file changed, 6 insertions(+), 5 deletions(-)
  19
  20 --- a/drivers/net/dsa/b53/b53_common.c
  21 +++ b/drivers/net/dsa/b53/b53_common.c
  22 @@ -361,11 +361,12 @@ static void b53_set_forwarding(struct b5
  23
  24         b53_write8(dev, B53_CTRL_PAGE, B53_SWITCH_MODE, mgmt);
  25
  26 -       /* Include IMP port in dumb forwarding mode
  27 -        */
  28 -       b53_read8(dev, B53_CTRL_PAGE, B53_SWITCH_CTRL, &mgmt);
  29 -       mgmt |= B53_MII_DUMB_FWDG_EN;
  30 -       b53_write8(dev, B53_CTRL_PAGE, B53_SWITCH_CTRL, mgmt);
  31 +       if (!is5325(dev)) {
  32 +               /* Include IMP port in dumb forwarding mode */
  33 +               b53_read8(dev, B53_CTRL_PAGE, B53_SWITCH_CTRL, &mgmt);
  34 +               mgmt |= B53_MII_DUMB_FWDG_EN;
  35 +               b53_write8(dev, B53_CTRL_PAGE, B53_SWITCH_CTRL, mgmt);
  36 +       }
  37
  38         /* Look at B53_UC_FWD_EN and B53_MC_FWD_EN to decide whether
  39          * frames should be flooded or not.