git.ipfire.org Git - thirdparty/kernel/stable-queue.git/blob

   1 From 53f68607caba85db9a73846ccd289e4b7fa96295 Mon Sep 17 00:00:00 2001
   2 From: Martin Fuzzey <mfuzzey@gmail.com>
   3 Date: Thu, 11 Feb 2010 10:50:31 -0300
   4 Subject: V4L/DVB: Video : pwc : Fix regression in pwc_set_shutter_speed caused by bad   constant => sizeof conversion.
   5
   6 From: Martin Fuzzey <mfuzzey@gmail.com>
   7
   8 commit 53f68607caba85db9a73846ccd289e4b7fa96295 upstream.
   9
  10 Regression was caused by my commit 6b35ca0d3d586b8ecb8396821af21186e20afaf0
  11 which determined message size using sizeof rather than hardcoded constants.
  12
  13 Unfortunately pwc_set_shutter_speed reuses a 2 byte buffer for a one byte
  14 message too so the sizeof was bogus in this case.
  15
  16 All other uses of sizeof checked and are ok.
  17
  18 Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
  19 Signed-off-by: Martin Fuzzey <mfuzzey@gmail.com>
  20 Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  21 Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  22
  23 ---
  24  drivers/media/video/pwc/pwc-ctrl.c |    2 +-
  25  1 file changed, 1 insertion(+), 1 deletion(-)
  26
  27 --- a/drivers/media/video/pwc/pwc-ctrl.c
  28 +++ b/drivers/media/video/pwc/pwc-ctrl.c
  29 @@ -753,7 +753,7 @@ int pwc_set_shutter_speed(struct pwc_dev
  30                 buf[0] = 0xff; /* fixed */
  31
  32         ret = send_control_msg(pdev,
  33 -               SET_LUM_CTL, SHUTTER_MODE_FORMATTER, &buf, sizeof(buf));
  34 +               SET_LUM_CTL, SHUTTER_MODE_FORMATTER, &buf, 1);
  35
  36         if (!mode && ret >= 0) {
  37                 if (value < 0)