*/
#include "mdadm.h"
-#include "md_u.h"
-#include "md_p.h"
-int Assemble(char *mddev, int mdfd,
+int Assemble(struct supertype *st, char *mddev, int mdfd,
mddev_ident_t ident, char *conffile,
mddev_dev_t devlist,
int readonly, int runstop,
* Much of the work of Assemble is in finding and/or
* checking the disks to make sure they look right.
*
- * If mddev is not set, then scan must be and we
+ * If mddev is not set, then scan must be set and we
* read through the config file for dev+uuid mapping
* We recurse, setting mddev, for each device that
* - isn't running
- * - has a valid uuid (or any uuid if !uuidset
+ * - has a valid uuid (or any uuid if !uuidset)
*
* If mddev is set, we try to determine state of md.
* check version - must be at least 0.90.0
* Check superblock - discard if bad
* Check uuid (set if we don't have one) - discard if no match
* Check superblock similarity if we have a superblock - discard if different
- * Record events, devicenum, utime
+ * Record events, devicenum
* This should give us a list of devices for the array
- * We should collect the most recent event and utime numbers
+ * We should collect the most recent event number
*
* Count disks with recent enough event count
* While force && !enough disks
*/
int old_linux = 0;
int vers;
- mdu_array_info_t array;
- mdp_super_t first_super, super;
+ void *first_super = NULL, *super = NULL;
struct {
char *devname;
- int major, minor;
- int oldmajor, oldminor;
+ unsigned int major, minor;
+ unsigned int oldmajor, oldminor;
long long events;
- time_t utime;
int uptodate;
int state;
int raid_disk;
+ int disk_nr;
} *devices;
int *best = NULL; /* indexed by raid_disk */
- int bestcnt = 0;
- int devcnt = 0, okcnt, sparecnt;
- int req_cnt;
- int i;
+ unsigned int bestcnt = 0;
+ int devcnt = 0;
+ unsigned int okcnt, sparecnt;
+ unsigned int req_cnt;
+ unsigned int i;
int most_recent = 0;
int chosen_drive;
int change = 0;
int inargv = 0;
int start_partial_ok = force || devlist==NULL;
- int num_devs;
+ unsigned int num_devs;
mddev_dev_t tmpdev;
+ struct mdinfo info;
+ struct mddev_ident_s ident2;
+ char *avail;
+ int nextspare = 0;
vers = md_get_version(mdfd);
if (vers <= 0) {
if (get_linux_version() < 2004000)
old_linux = 1;
- if (ioctl(mdfd, GET_ARRAY_INFO, &array)>=0) {
+ if (ioctl(mdfd, GET_ARRAY_INFO, &info.array)>=0) {
fprintf(stderr, Name ": device %s already active - cannot assemble it\n",
mddev);
return 1;
num_devs++;
tmpdev = tmpdev->next;
}
- best = malloc(num_devs * sizeof(*best));
devices = malloc(num_devs * sizeof(*devices));
- first_super.md_magic = 0;
- for (i=0; i<num_devs; i++)
- best[i] = -1;
+ if (!st && ident->st) st = ident->st;
- if (verbose)
+ if (verbose>0)
fprintf(stderr, Name ": looking for devices for %s\n",
mddev);
while ( devlist) {
char *devname;
- int this_uuid[4];
int dfd;
struct stat stb;
- int havesuper=0;
+ struct supertype *tst = st;
devname = devlist->devname;
devlist = devlist->next;
if (ident->devices &&
!match_oneof(ident->devices, devname)) {
- if (inargv || verbose)
+ if ((inargv && verbose>=0) || verbose > 0)
fprintf(stderr, Name ": %s is not one of %s\n", devname, ident->devices);
continue;
}
+
+ if (super) {
+ free(super);
+ super = NULL;
+ }
- dfd = open(devname, O_RDONLY, 0);
+ dfd = dev_open(devname, O_RDONLY|O_EXCL);
if (dfd < 0) {
- if (inargv || verbose)
+ if ((inargv && verbose >= 0) || verbose > 0)
fprintf(stderr, Name ": cannot open device %s: %s\n",
devname, strerror(errno));
} else if (fstat(dfd, &stb)< 0) {
/* Impossible! */
fprintf(stderr, Name ": fstat failed for %s: %s\n",
devname, strerror(errno));
- close(dfd);
} else if ((stb.st_mode & S_IFMT) != S_IFBLK) {
fprintf(stderr, Name ": %s is not a block device.\n",
devname);
- close(dfd);
- } else if (load_super(dfd, &super)) {
- if (inargv || verbose)
+ } else if (!tst && (tst = guess_super(dfd)) == NULL) {
+ if ((inargv && verbose >= 0) || verbose > 0)
+ fprintf(stderr, Name ": no recogniseable superblock\n");
+ } else if (tst->ss->load_super(tst,dfd, &super, NULL)) {
+ if ((inargv && verbose >= 0) || verbose > 0)
fprintf( stderr, Name ": no RAID superblock on %s\n",
devname);
- close(dfd);
} else {
- havesuper =1;
- uuid_from_super(this_uuid, &super);
- close(dfd);
+ tst->ss->getinfo_super(&info, &ident2, super);
}
+ if (dfd >= 0) close(dfd);
- if (ident->uuid_set &&
- (!havesuper || same_uuid(this_uuid, ident->uuid)==0)) {
- if (inargv || verbose)
+ if (ident->uuid_set && (!update || strcmp(update, "uuid")!= 0) &&
+ (!super || same_uuid(info.uuid, ident->uuid, tst->ss->swapuuid)==0)) {
+ if ((inargv && verbose >= 0) || verbose > 0)
fprintf(stderr, Name ": %s has wrong uuid.\n",
devname);
continue;
}
- if (ident->super_minor >= 0 &&
- (!havesuper || ident->super_minor != super.md_minor)) {
- if (inargv || verbose)
+ if (ident->name[0] &&
+ (!super || strncmp(ident2.name, ident->name, 32)!=0)) {
+ if ((inargv && verbose >= 0) || verbose > 0)
+ fprintf(stderr, Name ": %s has wrong name.\n",
+ devname);
+ continue;
+ }
+ if (ident->super_minor != UnSet &&
+ (!super || ident->super_minor != info.array.md_minor)) {
+ if ((inargv && verbose >= 0) || verbose > 0)
fprintf(stderr, Name ": %s has wrong super-minor.\n",
devname);
continue;
}
- if (ident->level != -10 &&
- (!havesuper|| ident->level != super.level)) {
- if (inargv || verbose)
+ if (ident->level != UnSet &&
+ (!super|| ident->level != info.array.level)) {
+ if ((inargv && verbose >= 0) || verbose > 0)
fprintf(stderr, Name ": %s has wrong raid level.\n",
devname);
continue;
}
- if (ident->raid_disks != -1 &&
- (!havesuper || ident->raid_disks!= super.raid_disks)) {
- if (inargv || verbose)
+ if (ident->raid_disks != UnSet &&
+ (!super || ident->raid_disks!= info.array.raid_disks)) {
+ if ((inargv && verbose >= 0) || verbose > 0)
fprintf(stderr, Name ": %s requires wrong number of drives.\n",
devname);
continue;
* then we cannot continue
*/
- if (!havesuper) {
+ if (!super) {
fprintf(stderr, Name ": %s has no superblock - assembly aborted\n",
devname);
+ free(first_super);
return 1;
}
- if (compare_super(&first_super, &super)) {
+
+
+ st = tst; /* commit to this format, if haven't already */
+ if (st->ss->compare_super(&first_super, super)) {
fprintf(stderr, Name ": superblock on %s doesn't match others - assembly aborted\n",
devname);
+ free(super);
+ free(first_super);
return 1;
}
-
- /* this is needed until we get a more relaxed super block format */
- if (devcnt >= MD_SB_DISKS) {
- fprintf(stderr, Name ": ouch - too many devices appear to be in this array. Ignoring %s\n",
- devname);
- continue;
- }
-
/* looks like a good enough match to update the super block if needed */
if (update) {
- if (strcmp(update, "sparc2.2")==0 ) {
- /* 2.2 sparc put the events in the wrong place
- * So we copy the tail of the superblock
- * up 4 bytes before continuing
- */
- __u32 *sb32 = (__u32*)&super;
- memcpy(sb32+MD_SB_GENERIC_CONSTANT_WORDS+7,
- sb32+MD_SB_GENERIC_CONSTANT_WORDS+7+1,
- (MD_SB_WORDS - (MD_SB_GENERIC_CONSTANT_WORDS+7+1))*4);
- fprintf (stderr, Name ": adjusting superblock of %s for 2.2/sparc compatability.\n",
- devname);
- }
- if (strcmp(update, "super-minor") ==0) {
- struct stat stb2;
- fstat(mdfd, &stb2);
- super.md_minor = MINOR(stb2.st_rdev);
- if (verbose)
- fprintf(stderr, Name ": updating superblock of %s with minor number %d\n",
- devname, super.md_minor);
+ /* prepare useful information in info structures */
+ struct stat stb2;
+ fstat(mdfd, &stb2);
+ info.array.md_minor = minor(stb2.st_rdev);
+
+ if (strcmp(update, "uuid")==0 &&
+ !ident->uuid_set) {
+ int rfd;
+ if ((rfd = open("/dev/urandom", O_RDONLY)) < 0 ||
+ read(rfd, ident->uuid, 16) != 16) {
+ *(__u32*)(ident->uuid) = random();
+ *(__u32*)(ident->uuid+1) = random();
+ *(__u32*)(ident->uuid+2) = random();
+ *(__u32*)(ident->uuid+3) = random();
+ }
+ if (rfd >= 0) close(rfd);
+ ident->uuid_set = 1;
}
- super.sb_csum = calc_sb_csum(&super);
- dfd = open(devname, O_RDWR, 0);
+ memcpy(info.uuid, ident->uuid, 16);
+ st->ss->update_super(&info, super, update, devname, verbose);
+
+ dfd = dev_open(devname, O_RDWR|O_EXCL);
if (dfd < 0)
fprintf(stderr, Name ": Cannot open %s for superblock update\n",
devname);
- else if (store_super(dfd, &super))
+ else if (st->ss->store_super(st, dfd, super))
fprintf(stderr, Name ": Could not re-write superblock on %s.\n",
devname);
if (dfd >= 0)
close(dfd);
}
- if (verbose)
+ if (verbose > 0)
fprintf(stderr, Name ": %s is identified as a member of %s, slot %d.\n",
- devname, mddev, super.this_disk.raid_disk);
+ devname, mddev, info.disk.raid_disk);
devices[devcnt].devname = devname;
- devices[devcnt].major = MAJOR(stb.st_rdev);
- devices[devcnt].minor = MINOR(stb.st_rdev);
- devices[devcnt].oldmajor = super.this_disk.major;
- devices[devcnt].oldminor = super.this_disk.minor;
- devices[devcnt].events = md_event(&super);
- devices[devcnt].utime = super.utime;
- devices[devcnt].raid_disk = super.this_disk.raid_disk;
+ devices[devcnt].major = major(stb.st_rdev);
+ devices[devcnt].minor = minor(stb.st_rdev);
+ devices[devcnt].oldmajor = info.disk.major;
+ devices[devcnt].oldminor = info.disk.minor;
+ devices[devcnt].events = info.events;
+ devices[devcnt].raid_disk = info.disk.raid_disk;
+ devices[devcnt].disk_nr = info.disk.number;
devices[devcnt].uptodate = 0;
- devices[devcnt].state = super.this_disk.state;
+ devices[devcnt].state = info.disk.state;
if (most_recent < devcnt) {
if (devices[devcnt].events
> devices[most_recent].events)
most_recent = devcnt;
}
- if (super.level == -4)
+ if (info.array.level == -4)
/* with multipath, the raid_disk from the superblock is meaningless */
i = devcnt;
else
i = devices[devcnt].raid_disk;
- if (i>=0 && i < 10000) {
+ if (i+1 == 0) {
+ if (nextspare < info.array.raid_disks)
+ nextspare = info.array.raid_disks;
+ i = nextspare++;
+ }
+ if (i < 10000) {
if (i >= bestcnt) {
- int newbestcnt = i+10;
+ unsigned int newbestcnt = i+10;
int *newbest = malloc(sizeof(int)*newbestcnt);
- int c;
+ unsigned int c;
for (c=0; c < newbestcnt; c++)
if (c < bestcnt)
newbest[c] = best[c];
devcnt++;
}
+ if (super)
+ free(super);
+ super = NULL;
+
+ if (update && strcmp(update, "byteorder")==0)
+ st->minor_version = 90;
+
if (devcnt == 0) {
fprintf(stderr, Name ": no devices found for %s\n",
mddev);
+ free(first_super);
return 1;
}
+
+ st->ss->getinfo_super(&info, &ident2, first_super);
+
/* now we have some devices that might be suitable.
* I wonder how many
*/
+ avail = malloc(info.array.raid_disks);
+ memset(avail, 0, info.array.raid_disks);
okcnt = 0;
sparecnt=0;
for (i=0; i< bestcnt ;i++) {
int j = best[i];
- int event_margin = !force;
+ int event_margin = 1; /* always allow a difference of '1'
+ * like the kernel does
+ */
if (j < 0) continue;
/* note: we ignore error flags in multipath arrays
* as they don't make sense
*/
- if (first_super.level != -4)
+ if (info.array.level != -4)
if (!(devices[j].state & (1<<MD_DISK_SYNC))) {
if (!(devices[j].state & (1<<MD_DISK_FAULTY)))
sparecnt++;
if (devices[j].events+event_margin >=
devices[most_recent].events) {
devices[j].uptodate = 1;
- if (i < first_super.raid_disks)
+ if (i < info.array.raid_disks) {
okcnt++;
- else
+ avail[i]=1;
+ } else
sparecnt++;
}
}
- while (force && !enough(first_super.level, first_super.raid_disks, okcnt)) {
+ while (force && !enough(info.array.level, info.array.raid_disks,
+ info.array.layout,
+ avail, okcnt)) {
/* Choose the newest best drive which is
* not up-to-date, update the superblock
* and add it.
*/
int fd;
chosen_drive = -1;
- for (i=0; i<first_super.raid_disks && i < bestcnt; i++) {
+ for (i=0; i<info.array.raid_disks && i < bestcnt; i++) {
int j = best[i];
if (j>=0 &&
!devices[j].uptodate &&
}
if (chosen_drive < 0)
break;
- fprintf(stderr, Name ": forcing event count in %s(%d) from %d upto %d\n",
- devices[chosen_drive].devname, devices[chosen_drive].raid_disk,
- (int)(devices[chosen_drive].events),
- (int)(devices[most_recent].events));
- fd = open(devices[chosen_drive].devname, O_RDWR);
+ if (verbose >= 0)
+ fprintf(stderr, Name ": forcing event count in %s(%d) from %d upto %d\n",
+ devices[chosen_drive].devname, devices[chosen_drive].raid_disk,
+ (int)(devices[chosen_drive].events),
+ (int)(devices[most_recent].events));
+ fd = dev_open(devices[chosen_drive].devname, O_RDWR|O_EXCL);
if (fd < 0) {
fprintf(stderr, Name ": Couldn't open %s for write - not updating\n",
devices[chosen_drive].devname);
devices[chosen_drive].events = 0;
continue;
}
- if (load_super(fd, &super)) {
+ if (st->ss->load_super(st,fd, &super, NULL)) {
close(fd);
fprintf(stderr, Name ": RAID superblock disappeared from %s - not updating.\n",
devices[chosen_drive].devname);
devices[chosen_drive].events = 0;
continue;
}
- super.events_hi = (devices[most_recent].events>>32)&0xFFFFFFFF;
- super.events_lo = (devices[most_recent].events)&0xFFFFFFFF;
- if (super.level == 5 || super.level == 4) {
- /* need to force clean */
- super.state = (1<<MD_SB_CLEAN);
- }
- super.sb_csum = calc_sb_csum(&super);
-/*DRYRUN*/ if (store_super(fd, &super)) {
+ info.events = devices[most_recent].events;
+ st->ss->update_super(&info, super, "force", devices[chosen_drive].devname, verbose);
+
+ if (st->ss->store_super(st, fd, super)) {
close(fd);
fprintf(stderr, Name ": Could not re-write superblock on %s\n",
devices[chosen_drive].devname);
devices[chosen_drive].events = 0;
+ free(super);
continue;
}
close(fd);
devices[chosen_drive].events = devices[most_recent].events;
devices[chosen_drive].uptodate = 1;
+ avail[chosen_drive] = 1;
okcnt++;
+ free(super);
}
/* Now we want to look at the superblock which the kernel will base things on
* superblock.
*/
chosen_drive = -1;
+ super = NULL;
for (i=0; chosen_drive < 0 && i<bestcnt; i++) {
int j = best[i];
int fd;
+
if (j<0)
continue;
if (!devices[j].uptodate)
continue;
chosen_drive = j;
- if ((fd=open(devices[j].devname, O_RDONLY))< 0) {
+ if ((fd=dev_open(devices[j].devname, O_RDONLY|O_EXCL))< 0) {
fprintf(stderr, Name ": Cannot open %s: %s\n",
devices[j].devname, strerror(errno));
return 1;
}
- if (load_super(fd, &super)) {
+ if (st->ss->load_super(st,fd, &super, NULL)) {
close(fd);
fprintf(stderr, Name ": RAID superblock has disappeared from %s\n",
devices[j].devname);
}
close(fd);
}
-
+ if (super == NULL) {
+ fprintf(stderr, Name ": No suitable drives found for %s\n", mddev);
+ return 1;
+ }
+ st->ss->getinfo_super(&info, &ident2, super);
for (i=0; i<bestcnt; i++) {
int j = best[i];
- int desired_state;
+ unsigned int desired_state;
- if (i < super.raid_disks)
+ if (i < info.array.raid_disks)
desired_state = (1<<MD_DISK_ACTIVE) | (1<<MD_DISK_SYNC);
else
desired_state = 0;
continue;
if (!devices[j].uptodate)
continue;
-#if 0
-This doesnt work yet
- if (devices[j].major != super.disks[i].major ||
- devices[j].minor != super.disks[i].minor) {
- change |= 1;
- super.disks[i].major = devices[j].major;
- super.disks[i].minor = devices[j].minor;
- }
-#endif
- if (devices[j].oldmajor != super.disks[i].major ||
- devices[j].oldminor != super.disks[i].minor) {
- change |= 2;
- super.disks[i].major = devices[j].oldmajor;
- super.disks[i].minor = devices[j].oldminor;
- }
+ info.disk.number = devices[j].disk_nr;
+ info.disk.raid_disk = i;
+ info.disk.state = desired_state;
+
if (devices[j].uptodate &&
- (super.disks[i].state != desired_state)) {
+ st->ss->update_super(&info, super, "assemble", NULL, verbose)) {
if (force) {
- fprintf(stderr, Name ": "
- "clearing FAULTY flag for device %d in %s for %s\n",
- j, mddev, devices[j].devname);
- super.disks[i].state = desired_state;
- change |= 2;
+ if (verbose >= 0)
+ fprintf(stderr, Name ": "
+ "clearing FAULTY flag for device %d in %s for %s\n",
+ j, mddev, devices[j].devname);
+ change = 1;
} else {
- fprintf(stderr, Name ": "
- "device %d in %s has wrong state in superblock, but %s seems ok\n",
- i, mddev, devices[j].devname);
+ if (verbose >= -1)
+ fprintf(stderr, Name ": "
+ "device %d in %s has wrong state in superblock, but %s seems ok\n",
+ i, mddev, devices[j].devname);
}
}
+#if 0
if (!devices[j].uptodate &&
!(super.disks[i].state & (1 << MD_DISK_FAULTY))) {
fprintf(stderr, Name ": devices %d of %s is not marked FAULTY in superblock, but cannot be found\n",
i, mddev);
}
+#endif
}
- if (force && (super.level == 4 || super.level == 5) &&
- okcnt == super.raid_disks-1) {
- super.state = (1<< MD_SB_CLEAN);
- change |= 2;
+ if (force && okcnt == info.array.raid_disks-1) {
+ /* FIXME check event count */
+ change += st->ss->update_super(&info, super, "force",
+ devices[chosen_drive].devname, verbose);
}
- if ((force && (change & 2))
- || (old_linux && (change & 1))) {
+ if (change) {
int fd;
- super.sb_csum = calc_sb_csum(&super);
- fd = open(devices[chosen_drive].devname, O_RDWR);
+ fd = dev_open(devices[chosen_drive].devname, O_RDWR|O_EXCL);
if (fd < 0) {
fprintf(stderr, Name ": Could open %s for write - cannot Assemble array.\n",
devices[chosen_drive].devname);
return 1;
}
- if (store_super(fd, &super)) {
+ if (st->ss->store_super(st, fd, super)) {
close(fd);
fprintf(stderr, Name ": Could not re-write superblock on %s\n",
devices[chosen_drive].devname);
return 1;
}
close(fd);
- change = 0;
}
/* count number of in-sync devices according to the superblock.
* We must have this number to start the array without -s or -R
*/
- req_cnt = 0;
- for (i=0; i<MD_SB_DISKS; i++)
- if ((first_super.disks[i].state & (1<<MD_DISK_SYNC)) &&
- (first_super.disks[i].state & (1<<MD_DISK_ACTIVE)) &&
- !(first_super.disks[i].state & (1<<MD_DISK_FAULTY)))
- req_cnt ++;
-
+ req_cnt = info.array.working_disks;
/* Almost ready to actually *do* something */
if (!old_linux) {
- if (ioctl(mdfd, SET_ARRAY_INFO, NULL) != 0) {
+ int rv;
+ if ((vers % 100) >= 1) { /* can use different versions */
+ mdu_array_info_t inf;
+ memset(&inf, 0, sizeof(inf));
+ inf.major_version = st->ss->major;
+ inf.minor_version = st->minor_version;
+ rv = ioctl(mdfd, SET_ARRAY_INFO, &inf);
+ } else
+ rv = ioctl(mdfd, SET_ARRAY_INFO, NULL);
+
+ if (rv) {
fprintf(stderr, Name ": SET_ARRAY_INFO failed for %s: %s\n",
mddev, strerror(errno));
return 1;
}
+ if (ident->bitmap_fd >= 0) {
+ if (ioctl(mdfd, SET_BITMAP_FILE, ident->bitmap_fd) != 0) {
+ fprintf(stderr, Name ": SET_BITMAP_FILE failed.\n");
+ return 1;
+ }
+ }
+
/* First, add the raid disks, but add the chosen one last */
for (i=0; i<= bestcnt; i++) {
int j;
devices[j].devname,
mddev,
strerror(errno));
- if (i < first_super.raid_disks)
+ if (i < info.array.raid_disks || i == bestcnt)
okcnt--;
else
sparecnt--;
- } else if (verbose)
+ } else if (verbose > 0)
fprintf(stderr, Name ": added %s to %s as %d\n",
devices[j].devname, mddev, devices[j].raid_disk);
- } else if (verbose && i < first_super.raid_disks)
+ } else if (verbose > 0 && i < info.array.raid_disks)
fprintf(stderr, Name ": no uptodate device for slot %d of %s\n",
i, mddev);
}
if (runstop == 1 ||
(runstop == 0 &&
- ( enough(first_super.level, first_super.raid_disks, okcnt) &&
+ ( enough(info.array.level, info.array.raid_disks, info.array.layout, avail, okcnt) &&
(okcnt >= req_cnt || start_partial_ok)
))) {
if (ioctl(mdfd, RUN_ARRAY, NULL)==0) {
- fprintf(stderr, Name ": %s has been started with %d drive%s",
- mddev, okcnt, okcnt==1?"":"s");
- if (okcnt < first_super.raid_disks)
- fprintf(stderr, " (out of %d)", first_super.raid_disks);
- if (sparecnt)
- fprintf(stderr, " and %d spare%s", sparecnt, sparecnt==1?"":"s");
- fprintf(stderr, ".\n");
+ if (verbose >= 0) {
+ fprintf(stderr, Name ": %s has been started with %d drive%s",
+ mddev, okcnt, okcnt==1?"":"s");
+ if (okcnt < info.array.raid_disks)
+ fprintf(stderr, " (out of %d)", info.array.raid_disks);
+ if (sparecnt)
+ fprintf(stderr, " and %d spare%s", sparecnt, sparecnt==1?"":"s");
+ fprintf(stderr, ".\n");
+ }
return 0;
}
fprintf(stderr, Name ": failed to RUN_ARRAY %s: %s\n",
mddev, okcnt, okcnt==1?"":"s");
return 0;
}
- fprintf(stderr, Name ": %s assembled from %d drive%s", mddev, okcnt, okcnt==1?"":"s");
- if (sparecnt)
- fprintf(stderr, " and %d spare%s", sparecnt, sparecnt==1?"":"s");
- if (!enough(first_super.level, first_super.raid_disks, okcnt))
- fprintf(stderr, " - not enough to start the array.\n");
- else {
- if (req_cnt == first_super.raid_disks)
- fprintf(stderr, " - need all %d to start it", req_cnt);
- else
- fprintf(stderr, " - need %d of %d to start", req_cnt, first_super.raid_disks);
- fprintf(stderr, " (use --run to insist).\n");
+ if (verbose >= 0) {
+ fprintf(stderr, Name ": %s assembled from %d drive%s", mddev, okcnt, okcnt==1?"":"s");
+ if (sparecnt)
+ fprintf(stderr, " and %d spare%s", sparecnt, sparecnt==1?"":"s");
+ if (!enough(info.array.level, info.array.raid_disks, info.array.layout, avail, okcnt))
+ fprintf(stderr, " - not enough to start the array.\n");
+ else {
+ if (req_cnt == info.array.raid_disks)
+ fprintf(stderr, " - need all %d to start it", req_cnt);
+ else
+ fprintf(stderr, " - need %d of %d to start", req_cnt, info.array.raid_disks);
+ fprintf(stderr, " (use --run to insist).\n");
+ }
}
return 1;
} else {
* so we can just start the array
*/
unsigned long dev;
- dev = MKDEV(devices[chosen_drive].major,
+ dev = makedev(devices[chosen_drive].major,
devices[chosen_drive].minor);
if (ioctl(mdfd, START_ARRAY, dev)) {
fprintf(stderr, Name ": Cannot start array: %s\n",