Merge branch 'tb/t5318-cleanup'

[thirdparty/git.git] / Documentation / CodingGuidelines

diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
index a89e8dcfbc70541280173973acff2020e6e92fb6..227f46ae403ea85a1bea17892aa4b038820b5f9b 100644 (file)
--- a/Documentation/CodingGuidelines
+++ b/Documentation/CodingGuidelines
@@ -232,6 +232,18 @@ For C programs:
         while( condition )
                func (bar+1);
 
+ - Do not explicitly compare an integral value with constant 0 or '\0',
+   or a pointer value with constant NULL.  For instance, to validate that
+   counted array <ptr, cnt> is initialized but has no elements, write:
+
+       if (!ptr || cnt)
+               BUG("empty array expected");
+
+   and not:
+
+       if (ptr == NULL || cnt != 0);
+               BUG("empty array expected");
+
  - We avoid using braces unnecessarily.  I.e.
 
        if (bla) {