cmd_usage(): simplify return code handling

[people/ms/u-boot.git] / board / renesas / sh7785lcr / selfcheck.c

diff --git a/board/renesas/sh7785lcr/selfcheck.c b/board/renesas/sh7785lcr/selfcheck.c
index ce0620f6878d8a91e52672fe933fa80b2c1a9d2c..6d92c8362e796f66a955f0746f8c3268e2660091 100644 (file)
--- a/board/renesas/sh7785lcr/selfcheck.c
+++ b/board/renesas/sh7785lcr/selfcheck.c
@@ -108,14 +108,12 @@ static void test_pci(void)
        printf("PCI CN2 ID = %08x\n", readl(0xfe040220));
 }
 
-int do_hw_test(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
+int do_hw_test(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 {
        char *cmd;
 
-       if (argc != 2) {
-               printf("Usage:\n%s\n", cmdtp->usage);
-               return 1;
-       }
+       if (argc != 2)
+               return cmd_usage(cmdtp);
 
        cmd = argv[1];
        switch (cmd[0]) {
@@ -150,8 +148,7 @@ int do_hw_test(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
                test_net();
                break;
        default:
-               printf("Usage:\n%s\n", cmdtp->usage);
-               return 1;
+               return cmd_usage(cmdtp);
        }
 
        return 0;
@@ -159,7 +156,7 @@ int do_hw_test(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 
 U_BOOT_CMD(
        hwtest, 2,      1,      do_hw_test,
-       "hwtest - hardware test for R0P7785LC0011RL board\n",
+       "hardware test for R0P7785LC0011RL board",
        "\n"
        "hwtest all   - test all hardware\n"
        "hwtest pld   - output PLD version\n"
@@ -168,5 +165,5 @@ U_BOOT_CMD(
        "hwtest sm107 - output SM107 version\n"
        "hwtest net   - check RTL8110 ID\n"
        "hwtest sata  - check SiI3512 ID\n"
-       "hwtest pci   - output PCI slot device ID\n"
+       "hwtest pci   - output PCI slot device ID"
 );