]> git.ipfire.org Git - people/ms/u-boot.git/blobdiff - drivers/i2c/omap24xx_i2c.c
Merge branch 'master' of git://git.denx.de/u-boot-cfi-flash
[people/ms/u-boot.git] / drivers / i2c / omap24xx_i2c.c
index 71251d8007f6bb89e35be1ffdc92dc4ef8f87eb6..f06af02ba31336954ace8cd312a0da07b93c000e 100644 (file)
 
 DECLARE_GLOBAL_DATA_PTR;
 
-#define I2C_TIMEOUT    1000
+#define I2C_STAT_TIMEO (1 << 31)
+#define I2C_TIMEOUT    10
 
-static void wait_for_bb (void);
-static u16 wait_for_pin (void);
+static u32 wait_for_bb(void);
+static u32 wait_for_status_mask(u16 mask);
 static void flush_fifo(void);
 
-static struct i2c *i2c_base = (struct i2c *)I2C_DEFAULT_BASE;
-
-static unsigned int bus_initialized[I2C_BUS_MAX];
-static unsigned int current_bus;
+/*
+ * For SPL boot some boards need i2c before SDRAM is initialised so force
+ * variables to live in SRAM
+ */
+static struct i2c __attribute__((section (".data"))) *i2c_base =
+                                       (struct i2c *)I2C_DEFAULT_BASE;
+static unsigned int __attribute__((section (".data"))) bus_initialized[I2C_BUS_MAX] =
+                                       { [0 ... (I2C_BUS_MAX-1)] = 0 };
+static unsigned int __attribute__((section (".data"))) current_bus = 0;
 
-void i2c_init (int speed, int slaveadd)
+void i2c_init(int speed, int slaveadd)
 {
        int psc, fsscll, fssclh;
        int hsscll = 0, hssclh = 0;
        u32 scll, sclh;
-       int timeout = I2C_TIMEOUT;
 
        /* Only handle standard, fast and high speeds */
        if ((speed != OMAP_I2C_STANDARD) &&
@@ -73,7 +78,7 @@ void i2c_init (int speed, int slaveadd)
                fssclh -= I2C_HIGHSPEED_PHASE_ONE_SCLH_TRIM;
                if (((fsscll < 0) || (fssclh < 0)) ||
                    ((fsscll > 255) || (fssclh > 255))) {
-                       printf("Error : I2C initializing first phase clock\n");
+                       puts("Error : I2C initializing first phase clock\n");
                        return;
                }
 
@@ -84,7 +89,7 @@ void i2c_init (int speed, int slaveadd)
                hssclh -= I2C_HIGHSPEED_PHASE_TWO_SCLH_TRIM;
                if (((fsscll < 0) || (fssclh < 0)) ||
                    ((fsscll > 255) || (fssclh > 255))) {
-                       printf("Error : I2C initializing second phase clock\n");
+                       puts("Error : I2C initializing second phase clock\n");
                        return;
                }
 
@@ -99,7 +104,7 @@ void i2c_init (int speed, int slaveadd)
                fssclh -= I2C_FASTSPEED_SCLH_TRIM;
                if (((fsscll < 0) || (fssclh < 0)) ||
                    ((fsscll > 255) || (fssclh > 255))) {
-                       printf("Error : I2C initializing clock\n");
+                       puts("Error : I2C initializing clock\n");
                        return;
                }
 
@@ -107,331 +112,439 @@ void i2c_init (int speed, int slaveadd)
                sclh = (unsigned int)fssclh;
        }
 
-       if (readw (&i2c_base->con) & I2C_CON_EN) {
-               writew (0, &i2c_base->con);
-               udelay (50000);
-       }
-
-       writew(0x2, &i2c_base->sysc); /* for ES2 after soft reset */
-       udelay(1000);
+       if (gd->flags & GD_FLG_RELOC)
+               bus_initialized[current_bus] = 1;
 
-       writew(I2C_CON_EN, &i2c_base->con);
-       while (!(readw(&i2c_base->syss) & I2C_SYSS_RDONE) && timeout--) {
-               if (timeout <= 0) {
-                       printf("ERROR: Timeout in soft-reset\n");
-                       return;
-               }
-               udelay(1000);
+       if (readw(&i2c_base->con) & I2C_CON_EN) {
+               writew(0, &i2c_base->con);
+               udelay(50000);
        }
 
-       writew(0, &i2c_base->con);
        writew(psc, &i2c_base->psc);
        writew(scll, &i2c_base->scll);
        writew(sclh, &i2c_base->sclh);
 
        /* own address */
-       writew (slaveadd, &i2c_base->oa);
-       writew (I2C_CON_EN, &i2c_base->con);
+       writew(slaveadd, &i2c_base->oa);
+       writew(I2C_CON_EN, &i2c_base->con);
 
        /* have to enable intrrupts or OMAP i2c module doesn't work */
-       writew (I2C_IE_XRDY_IE | I2C_IE_RRDY_IE | I2C_IE_ARDY_IE |
+       writew(I2C_IE_XRDY_IE | I2C_IE_RRDY_IE | I2C_IE_ARDY_IE |
                I2C_IE_NACK_IE | I2C_IE_AL_IE, &i2c_base->ie);
-       udelay (1000);
+       udelay(1000);
        flush_fifo();
-       writew (0xFFFF, &i2c_base->stat);
-       writew (0, &i2c_base->cnt);
-
-       if (gd->flags & GD_FLG_RELOC)
-               bus_initialized[current_bus] = 1;
+       writew(0xFFFF, &i2c_base->stat);
+       writew(0, &i2c_base->cnt);
 }
 
-static int i2c_read_byte (u8 devaddr, u8 regoffset, u8 * value)
-{
-       int i2c_error = 0;
-       u16 status;
-
-       /* wait until bus not busy */
-       wait_for_bb ();
-
-       /* one byte only */
-       writew (1, &i2c_base->cnt);
-       /* set slave address */
-       writew (devaddr, &i2c_base->sa);
-       /* no stop bit needed here */
-       writew (I2C_CON_EN | I2C_CON_MST | I2C_CON_STT | I2C_CON_TRX, &i2c_base->con);
-
-       /* send register offset */
-       while (1) {
-               status = wait_for_pin();
-               if (status == 0 || status & I2C_STAT_NACK) {
-                       i2c_error = 1;
-                       goto read_exit;
-               }
-               if (status & I2C_STAT_XRDY) {
-                       /* Important: have to use byte access */
-                       writeb(regoffset, &i2c_base->data);
-                       writew(I2C_STAT_XRDY, &i2c_base->stat);
-               }
-               if (status & I2C_STAT_ARDY) {
-                       writew(I2C_STAT_ARDY, &i2c_base->stat);
-                       break;
-               }
-       }
-
-       /* set slave address */
-       writew(devaddr, &i2c_base->sa);
-       /* read one byte from slave */
-       writew(1, &i2c_base->cnt);
-       /* need stop bit here */
-       writew(I2C_CON_EN | I2C_CON_MST |
-               I2C_CON_STT | I2C_CON_STP,
-               &i2c_base->con);
+static void flush_fifo(void)
+{      u16 stat;
 
-       /* receive data */
+       /* note: if you try and read data when its not there or ready
+        * you get a bus error
+        */
        while (1) {
-               status = wait_for_pin();
-               if (status == 0 || status & I2C_STAT_NACK) {
-                       i2c_error = 1;
-                       goto read_exit;
-               }
-               if (status & I2C_STAT_RRDY) {
+               stat = readw(&i2c_base->stat);
+               if (stat == I2C_STAT_RRDY) {
 #if defined(CONFIG_OMAP243X) || defined(CONFIG_OMAP34XX) || \
-    defined(CONFIG_OMAP44XX)
-                       *value = readb(&i2c_base->data);
+       defined(CONFIG_OMAP44XX) || defined(CONFIG_AM33XX)
+                       readb(&i2c_base->data);
 #else
-                       *value = readw(&i2c_base->data);
+                       readw(&i2c_base->data);
 #endif
                        writew(I2C_STAT_RRDY, &i2c_base->stat);
-               }
-               if (status & I2C_STAT_ARDY) {
-                       writew(I2C_STAT_ARDY, &i2c_base->stat);
+                       udelay(1000);
+               } else
                        break;
-               }
        }
+}
+
+int i2c_probe(uchar chip)
+{
+       u32 status;
+       int res = 1; /* default = fail */
+
+       if (chip == readw(&i2c_base->oa))
+               return res;
+
+       /* wait until bus not busy */
+       status = wait_for_bb();
+       /* exit on BUS busy */
+       if (status & I2C_STAT_TIMEO)
+               return res;
 
-read_exit:
+       /* try to write one byte */
+       writew(1, &i2c_base->cnt);
+       /* set slave address */
+       writew(chip, &i2c_base->sa);
+       /* stop bit needed here */
+       writew(I2C_CON_EN | I2C_CON_MST | I2C_CON_STT
+                       | I2C_CON_STP, &i2c_base->con);
+       /* enough delay for the NACK bit set */
+       udelay(9000);
+
+       if (!(readw(&i2c_base->stat) & I2C_STAT_NACK)) {
+               res = 0;      /* success case */
+               flush_fifo();
+               writew(0xFFFF, &i2c_base->stat);
+       } else {
+               /* failure, clear sources*/
+               writew(0xFFFF, &i2c_base->stat);
+               /* finish up xfer */
+               writew(readw(&i2c_base->con) | I2C_CON_STP, &i2c_base->con);
+               status = wait_for_bb();
+               /* exit on BUS busy */
+               if (status & I2C_STAT_TIMEO)
+                       return res;
+       }
        flush_fifo();
-       writew (0xFFFF, &i2c_base->stat);
-       writew (0, &i2c_base->cnt);
-       return i2c_error;
+       /* don't allow any more data in... we don't want it. */
+       writew(0, &i2c_base->cnt);
+       writew(0xFFFF, &i2c_base->stat);
+       return res;
 }
 
-static int i2c_write_byte (u8 devaddr, u8 regoffset, u8 value)
+int i2c_read(uchar chip, uint addr, int alen, uchar *buffer, int len)
 {
-       int i2c_error = 0;
-       u16 status;
+       int i2c_error = 0, i;
+       u32 status;
+
+       if ((alen > 2) || (alen < 0))
+               return 1;
+
+       if (alen < 2) {
+               if (addr + len > 256)
+                       return 1;
+       } else if (addr + len > 0xFFFF) {
+               return 1;
+       }
 
        /* wait until bus not busy */
-       wait_for_bb ();
+       status = wait_for_bb();
 
-       /* two bytes */
-       writew (2, &i2c_base->cnt);
+       /* exit on BUS busy */
+       if (status & I2C_STAT_TIMEO)
+               return 1;
+
+       writew((alen & 0xFF), &i2c_base->cnt);
        /* set slave address */
-       writew (devaddr, &i2c_base->sa);
-       /* stop bit needed here */
-       writew (I2C_CON_EN | I2C_CON_MST | I2C_CON_STT | I2C_CON_TRX |
-               I2C_CON_STP, &i2c_base->con);
+       writew(chip, &i2c_base->sa);
+       /* Clear the Tx & Rx FIFOs */
+       writew((readw(&i2c_base->buf) | I2C_RXFIFO_CLEAR |
+               I2C_TXFIFO_CLEAR), &i2c_base->buf);
+       /* no stop bit needed here */
+       writew(I2C_CON_EN | I2C_CON_MST | I2C_CON_TRX |
+               I2C_CON_STT, &i2c_base->con);
 
-       while (1) {
-               status = wait_for_pin();
-               if (status == 0 || status & I2C_STAT_NACK) {
-                       i2c_error = 1;
-                       goto write_exit;
-               }
+       /* wait for Transmit ready condition */
+       status = wait_for_status_mask(I2C_STAT_XRDY | I2C_STAT_NACK);
+
+       if (status & (I2C_STAT_NACK | I2C_STAT_TIMEO))
+               i2c_error = 1;
+
+       if (!i2c_error) {
                if (status & I2C_STAT_XRDY) {
+                       switch (alen) {
+                       case 2:
+                               /* Send address MSByte */
 #if defined(CONFIG_OMAP243X) || defined(CONFIG_OMAP34XX) || \
-    defined(CONFIG_OMAP44XX)
-                       /* send register offset */
-                       writeb(regoffset, &i2c_base->data);
-                       writew(I2C_STAT_XRDY, &i2c_base->stat);
-
-                       while (1) {
-                               status = wait_for_pin();
-                               if (status == 0 || status & I2C_STAT_NACK) {
+                       defined(CONFIG_AM33XX)
+                               writew(((addr >> 8) & 0xFF), &i2c_base->data);
+
+                               /* Clearing XRDY event */
+                               writew((status & I2C_STAT_XRDY),
+                                               &i2c_base->stat);
+                               /* wait for Transmit ready condition */
+                               status = wait_for_status_mask(I2C_STAT_XRDY |
+                                               I2C_STAT_NACK);
+
+                               if (status & (I2C_STAT_NACK |
+                                               I2C_STAT_TIMEO)) {
                                        i2c_error = 1;
-                                       goto write_exit;
-                               }
-                               if (status & I2C_STAT_XRDY) {
-                                       /* send data */
-                                       writeb(value, &i2c_base->data);
-                                       writew(I2C_STAT_XRDY, &i2c_base->stat);
+                                       break;
                                }
-                               if (status & I2C_STAT_ARDY) {
-                                       writew(I2C_STAT_ARDY, &i2c_base->stat);
+#endif
+                       case 1:
+#if defined(CONFIG_OMAP243X) || defined(CONFIG_OMAP34XX) || \
+                       defined(CONFIG_AM33XX)
+                               /* Send address LSByte */
+                               writew((addr & 0xFF), &i2c_base->data);
+#else
+                               /* Send address Short word */
+                               writew((addr & 0xFFFF), &i2c_base->data);
+#endif
+                               /* Clearing XRDY event */
+                               writew((status & I2C_STAT_XRDY),
+                                       &i2c_base->stat);
+                               /*wait for Transmit ready condition */
+                               status = wait_for_status_mask(I2C_STAT_ARDY |
+                                               I2C_STAT_NACK);
+
+                               if (status & (I2C_STAT_NACK |
+                                       I2C_STAT_TIMEO)) {
+                                       i2c_error = 1;
                                        break;
                                }
                        }
-                       break;
+               } else
+                       i2c_error = 1;
+       }
+
+       /* Wait for ARDY to set */
+       status = wait_for_status_mask(I2C_STAT_ARDY | I2C_STAT_NACK
+                       | I2C_STAT_AL);
+
+       if (!i2c_error) {
+               /* set slave address */
+               writew(chip, &i2c_base->sa);
+               writew((len & 0xFF), &i2c_base->cnt);
+               /* Clear the Tx & Rx FIFOs */
+               writew((readw(&i2c_base->buf) | I2C_RXFIFO_CLEAR |
+                       I2C_TXFIFO_CLEAR), &i2c_base->buf);
+               /* need stop bit here */
+               writew(I2C_CON_EN | I2C_CON_MST | I2C_CON_STT | I2C_CON_STP,
+                       &i2c_base->con);
+
+               for (i = 0; i < len; i++) {
+                       /* wait for Receive condition */
+                       status = wait_for_status_mask(I2C_STAT_RRDY |
+                               I2C_STAT_NACK);
+                       if (status & (I2C_STAT_NACK | I2C_STAT_TIMEO)) {
+                               i2c_error = 1;
+                               break;
+                       }
+
+                       if (status & I2C_STAT_RRDY) {
+#if defined(CONFIG_OMAP243X) || defined(CONFIG_OMAP34XX) || \
+                       defined(CONFIG_AM33XX)
+                               buffer[i] = readb(&i2c_base->data);
 #else
-                       /* send out two bytes */
-                       writew((value << 8) + regoffset, &i2c_base->data);
-                       writew(I2C_STAT_XRDY, &i2c_base->stat);
+                               *((u16 *)&buffer[i]) =
+                                       readw(&i2c_base->data) & 0xFFFF;
+                               i++;
 #endif
-               }
-               if (status & I2C_STAT_ARDY) {
-                       writew(I2C_STAT_ARDY, &i2c_base->stat);
-                       break;
+                               writew((status & I2C_STAT_RRDY),
+                                       &i2c_base->stat);
+                               udelay(1000);
+                       } else {
+                               i2c_error = 1;
+                       }
                }
        }
 
-       wait_for_bb();
-
-       status = readw(&i2c_base->stat);
-       if (status & I2C_STAT_NACK)
-               i2c_error = 1;
+       /* Wait for ARDY to set */
+       status = wait_for_status_mask(I2C_STAT_ARDY | I2C_STAT_NACK
+                       | I2C_STAT_AL);
 
-write_exit:
-       flush_fifo();
-       writew (0xFFFF, &i2c_base->stat);
-       writew (0, &i2c_base->cnt);
-       return i2c_error;
-}
+       if (i2c_error) {
+               writew(0, &i2c_base->con);
+               return 1;
+       }
 
-static void flush_fifo(void)
-{      u16 stat;
+       writew(I2C_CON_EN, &i2c_base->con);
 
-       /* note: if you try and read data when its not there or ready
-        * you get a bus error
-        */
-       while(1){
-               stat = readw(&i2c_base->stat);
-               if(stat == I2C_STAT_RRDY){
-#if defined(CONFIG_OMAP243X) || defined(CONFIG_OMAP34XX) || \
-    defined(CONFIG_OMAP44XX)
-                       readb(&i2c_base->data);
-#else
-                       readw(&i2c_base->data);
-#endif
-                       writew(I2C_STAT_RRDY,&i2c_base->stat);
-                       udelay(1000);
-               }else
-                       break;
+       while (readw(&i2c_base->stat)
+               || (readw(&i2c_base->con) & I2C_CON_MST)) {
+               udelay(10000);
+               writew(0xFFFF, &i2c_base->stat);
        }
+
+       writew(I2C_CON_EN, &i2c_base->con);
+       flush_fifo();
+       writew(0xFFFF, &i2c_base->stat);
+       writew(0, &i2c_base->cnt);
+
+       return 0;
 }
 
-int i2c_probe (uchar chip)
+int i2c_write(uchar chip, uint addr, int alen, uchar *buffer, int len)
 {
-       u16 status;
-       int res = 1; /* default = fail */
 
-       if (chip == readw (&i2c_base->oa)) {
-               return res;
+       int i, i2c_error = 0;
+       u32 status;
+       u16 writelen;
+
+       if (alen > 2)
+               return 1;
+
+       if (alen < 2) {
+               if (addr + len > 256)
+                       return 1;
+       } else if (addr + len > 0xFFFF) {
+               return 1;
        }
 
        /* wait until bus not busy */
-       wait_for_bb ();
+       status = wait_for_bb();
 
-       /* try to write one byte */
-       writew (1, &i2c_base->cnt);
+       /* exiting on BUS busy */
+       if (status & I2C_STAT_TIMEO)
+               return 1;
+
+       writelen = (len & 0xFFFF) + alen;
+
+       /* two bytes */
+       writew((writelen & 0xFFFF), &i2c_base->cnt);
+       /* Clear the Tx & Rx FIFOs */
+       writew((readw(&i2c_base->buf) | I2C_RXFIFO_CLEAR |
+                       I2C_TXFIFO_CLEAR), &i2c_base->buf);
        /* set slave address */
-       writew (chip, &i2c_base->sa);
+       writew(chip, &i2c_base->sa);
        /* stop bit needed here */
        writew(I2C_CON_EN | I2C_CON_MST | I2C_CON_STT | I2C_CON_TRX |
-              I2C_CON_STP, &i2c_base->con);
+               I2C_CON_STP, &i2c_base->con);
 
-       status = wait_for_pin();
+       /* wait for Transmit ready condition */
+       status = wait_for_status_mask(I2C_STAT_XRDY | I2C_STAT_NACK);
 
-       /* check for ACK (!NAK) */
-       if (!(status & I2C_STAT_NACK))
-               res = 0;
+       if (status & (I2C_STAT_NACK | I2C_STAT_TIMEO))
+               i2c_error = 1;
 
-       /* abort transfer (force idle state) */
-       writew(0, &i2c_base->con);
+       if (!i2c_error) {
+               if (status & I2C_STAT_XRDY) {
+                       switch (alen) {
+#if defined(CONFIG_OMAP243X) || defined(CONFIG_OMAP34XX) || \
+                       defined(CONFIG_AM33XX)
+                       case 2:
+                               /* send out MSB byte */
+                               writeb(((addr >> 8) & 0xFF), &i2c_base->data);
+#else
+                               writeb((addr  & 0xFFFF), &i2c_base->data);
+                               break;
+#endif
+                               /* Clearing XRDY event */
+                               writew((status & I2C_STAT_XRDY),
+                                       &i2c_base->stat);
+                               /*waiting for Transmit ready * condition */
+                               status = wait_for_status_mask(I2C_STAT_XRDY |
+                                               I2C_STAT_NACK);
+
+                               if (status & (I2C_STAT_NACK | I2C_STAT_TIMEO)) {
+                                       i2c_error = 1;
+                                       break;
+                               }
+                       case 1:
+#if defined(CONFIG_OMAP243X) || defined(CONFIG_OMAP34XX) || \
+                       defined(CONFIG_AM33XX)
+                               /* send out MSB byte */
+                               writeb((addr  & 0xFF), &i2c_base->data);
+#else
+                               writew(((buffer[0] << 8) | (addr & 0xFF)),
+                                       &i2c_base->data);
+#endif
+                       }
 
-       flush_fifo();
-       writew (0, &i2c_base->cnt); /* don't allow any more data in...we don't want it.*/
-       writew(0xFFFF, &i2c_base->stat);
-       return res;
-}
+                       /* Clearing XRDY event */
+                       writew((status & I2C_STAT_XRDY), &i2c_base->stat);
+               }
 
-int i2c_read (uchar chip, uint addr, int alen, uchar * buffer, int len)
-{
-       int i;
+               /* waiting for Transmit ready condition */
+               status = wait_for_status_mask(I2C_STAT_XRDY | I2C_STAT_NACK);
 
-       if (alen > 1) {
-               printf ("I2C read: addr len %d not supported\n", alen);
-               return 1;
-       }
-
-       if (addr + len > 256) {
-               printf ("I2C read: address out of range\n");
-               return 1;
-       }
+               if (status & (I2C_STAT_NACK | I2C_STAT_TIMEO))
+                       i2c_error = 1;
 
-       for (i = 0; i < len; i++) {
-               if (i2c_read_byte (chip, addr + i, &buffer[i])) {
-                       printf ("I2C read: I/O error\n");
-                       i2c_init (CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE);
-                       return 1;
+               if (!i2c_error) {
+                       for (i = ((alen > 1) ? 0 : 1); i < len; i++) {
+                               if (status & I2C_STAT_XRDY) {
+#if defined(CONFIG_OMAP243X) || defined(CONFIG_OMAP34XX) || \
+                               defined(CONFIG_AM33XX)
+                                       writeb((buffer[i] & 0xFF),
+                                               &i2c_base->data);
+#else
+                                       writew((((buffer[i] << 8) |
+                                       buffer[i + 1]) & 0xFFFF),
+                                               &i2c_base->data);
+                                       i++;
+#endif
+                               } else
+                                       i2c_error = 1;
+                                       /* Clearing XRDY event */
+                                       writew((status & I2C_STAT_XRDY),
+                                               &i2c_base->stat);
+                                       /* waiting for XRDY condition */
+                                       status = wait_for_status_mask(
+                                               I2C_STAT_XRDY |
+                                               I2C_STAT_ARDY |
+                                               I2C_STAT_NACK);
+                                       if (status & (I2C_STAT_NACK |
+                                               I2C_STAT_TIMEO)) {
+                                               i2c_error = 1;
+                                               break;
+                                       }
+                                       if (status & I2C_STAT_ARDY)
+                                               break;
+                       }
                }
        }
 
-       return 0;
-}
+       status = wait_for_status_mask(I2C_STAT_ARDY | I2C_STAT_NACK |
+                               I2C_STAT_AL);
 
-int i2c_write (uchar chip, uint addr, int alen, uchar * buffer, int len)
-{
-       int i;
+       if (status & (I2C_STAT_NACK | I2C_STAT_TIMEO))
+               i2c_error = 1;
 
-       if (alen > 1) {
-               printf ("I2C read: addr len %d not supported\n", alen);
+       if (i2c_error) {
+               writew(0, &i2c_base->con);
                return 1;
        }
 
-       if (addr + len > 256) {
-               printf ("I2C read: address out of range\n");
-               return 1;
-       }
+       if (!i2c_error) {
+               int eout = 200;
 
-       for (i = 0; i < len; i++) {
-               if (i2c_write_byte (chip, addr + i, buffer[i])) {
-                       printf ("I2C read: I/O error\n");
-                       i2c_init (CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE);
-                       return 1;
+               writew(I2C_CON_EN, &i2c_base->con);
+               while ((status = readw(&i2c_base->stat)) ||
+                               (readw(&i2c_base->con) & I2C_CON_MST)) {
+                       udelay(1000);
+                       /* have to read to clear intrrupt */
+                       writew(0xFFFF, &i2c_base->stat);
+                       if (--eout == 0)
+                               /* better leave with error than hang */
+                               break;
                }
        }
 
+       flush_fifo();
+       writew(0xFFFF, &i2c_base->stat);
+       writew(0, &i2c_base->cnt);
        return 0;
 }
 
-static void wait_for_bb (void)
+static u32 wait_for_bb(void)
 {
        int timeout = I2C_TIMEOUT;
-       u16 stat;
+       u32 stat;
 
-       writew(0xFFFF, &i2c_base->stat);         /* clear current interruts...*/
-       while ((stat = readw (&i2c_base->stat) & I2C_STAT_BB) && timeout--) {
-               writew (stat, &i2c_base->stat);
+       while ((stat = readw(&i2c_base->stat) & I2C_STAT_BB) && timeout--) {
+               writew(stat, &i2c_base->stat);
                udelay(1000);
        }
 
        if (timeout <= 0) {
-               printf ("timed out in wait_for_bb: I2C_STAT=%x\n",
-                       readw (&i2c_base->stat));
+               printf("timed out in wait_for_bb: I2C_STAT=%x\n",
+                       readw(&i2c_base->stat));
+               stat |= I2C_STAT_TIMEO;
        }
        writew(0xFFFF, &i2c_base->stat);         /* clear delayed stuff*/
+       return stat;
 }
 
-static u16 wait_for_pin (void)
+static u32 wait_for_status_mask(u16 mask)
 {
-       u16 status;
+       u32 status;
        int timeout = I2C_TIMEOUT;
 
        do {
-               udelay (1000);
-               status = readw (&i2c_base->stat);
-       } while (  !(status &
-                  (I2C_STAT_ROVR | I2C_STAT_XUDF | I2C_STAT_XRDY |
-                   I2C_STAT_RRDY | I2C_STAT_ARDY | I2C_STAT_NACK |
-                   I2C_STAT_AL)) && timeout--);
+               udelay(1000);
+               status = readw(&i2c_base->stat);
+       } while (!(status & mask) && timeout--);
 
        if (timeout <= 0) {
-               printf ("timed out in wait_for_pin: I2C_STAT=%x\n",
-                       readw (&i2c_base->stat));
+               printf("timed out in wait_for_status_mask: I2C_STAT=%x\n",
+                       readw(&i2c_base->stat));
                writew(0xFFFF, &i2c_base->stat);
-               status = 0;
+               status |= I2C_STAT_TIMEO;
        }
-
        return status;
 }
 
@@ -442,7 +555,7 @@ int i2c_set_bus_num(unsigned int bus)
                return -1;
        }
 
-#if I2C_BUS_MAX==3
+#if I2C_BUS_MAX == 3
        if (bus == 2)
                i2c_base = (struct i2c *)I2C_BASE3;
        else
@@ -454,7 +567,7 @@ int i2c_set_bus_num(unsigned int bus)
 
        current_bus = bus;
 
-       if(!bus_initialized[current_bus])
+       if (!bus_initialized[current_bus])
                i2c_init(CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE);
 
        return 0;