cmd_usage(): simplify return code handling

[people/ms/u-boot.git] / drivers / misc / fsl_pmic.c

diff --git a/drivers/misc/fsl_pmic.c b/drivers/misc/fsl_pmic.c
index 87f0aedeb6813f04f9b186c370520a69b23641de..dca0a1d57e7d9ff81348261799b3f1266e208463 100644 (file)
--- a/drivers/misc/fsl_pmic.c
+++ b/drivers/misc/fsl_pmic.c
@@ -156,33 +156,29 @@ static void pmic_dump(int numregs)
        puts("\n");
 }
 
-int do_pmic(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
+int do_pmic(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 {
        char *cmd;
        int nregs;
        u32 val;
 
        /* at least two arguments please */
-       if (argc < 2) {
-               cmd_usage(cmdtp);
-               return 1;
-       }
+       if (argc < 2)
+               return cmd_usage(cmdtp);
 
        cmd = argv[1];
        if (strcmp(cmd, "dump") == 0) {
-               if (argc < 3) {
-                       cmd_usage(cmdtp);
-                       return 1;
-               }
+               if (argc < 3)
+                       return cmd_usage(cmdtp);
+
                nregs = simple_strtoul(argv[2], NULL, 16);
                pmic_dump(nregs);
                return 0;
        }
        if (strcmp(cmd, "write") == 0) {
-               if (argc < 4) {
-                       cmd_usage(cmdtp);
-                       return 1;
-               }
+               if (argc < 4)
+                       return cmd_usage(cmdtp);
+
                nregs = simple_strtoul(argv[2], NULL, 16);
                val = simple_strtoul(argv[3], NULL, 16);
                pmic_reg_write(nregs, val);