]> git.ipfire.org Git - thirdparty/git.git/blobdiff - fetch-pack.c
Documentation: typofix --column description
[thirdparty/git.git] / fetch-pack.c
index 5eb6ed6165511c249f2604f6a6e7428286482d69..876f90c759a09334bb4a47575c236d27f2887b98 100644 (file)
@@ -35,6 +35,7 @@ static int fetch_fsck_objects = -1;
 static int transfer_fsck_objects = -1;
 static int agent_supported;
 static int server_supports_filtering;
+static int advertise_sid;
 static struct shallow_lock shallow_lock;
 static const char *alternate_shallow_file;
 static struct strbuf fsck_msg_types = STRBUF_INIT;
@@ -108,24 +109,48 @@ static void for_each_cached_alternate(struct fetch_negotiator *negotiator,
                cb(negotiator, cache.items[i]);
 }
 
+static struct commit *deref_without_lazy_fetch(const struct object_id *oid,
+                                              int mark_tags_complete)
+{
+       enum object_type type;
+       struct object_info info = { .typep = &type };
+
+       while (1) {
+               if (oid_object_info_extended(the_repository, oid, &info,
+                                            OBJECT_INFO_SKIP_FETCH_OBJECT | OBJECT_INFO_QUICK))
+                       return NULL;
+               if (type == OBJ_TAG) {
+                       struct tag *tag = (struct tag *)
+                               parse_object(the_repository, oid);
+
+                       if (!tag->tagged)
+                               return NULL;
+                       if (mark_tags_complete)
+                               tag->object.flags |= COMPLETE;
+                       oid = &tag->tagged->oid;
+               } else {
+                       break;
+               }
+       }
+       if (type == OBJ_COMMIT)
+               return (struct commit *) parse_object(the_repository, oid);
+       return NULL;
+}
+
 static int rev_list_insert_ref(struct fetch_negotiator *negotiator,
-                              const char *refname,
                               const struct object_id *oid)
 {
-       struct object *o = deref_tag(the_repository,
-                                    parse_object(the_repository, oid),
-                                    refname, 0);
-
-       if (o && o->type == OBJ_COMMIT)
-               negotiator->add_tip(negotiator, (struct commit *)o);
+       struct commit *c = deref_without_lazy_fetch(oid, 0);
 
+       if (c)
+               negotiator->add_tip(negotiator, c);
        return 0;
 }
 
 static int rev_list_insert_ref_oid(const char *refname, const struct object_id *oid,
                                   int flag, void *cb_data)
 {
-       return rev_list_insert_ref(cb_data, refname, oid);
+       return rev_list_insert_ref(cb_data, oid);
 }
 
 enum ack_type {
@@ -201,7 +226,7 @@ static void send_request(struct fetch_pack_args *args,
 static void insert_one_alternate_object(struct fetch_negotiator *negotiator,
                                        struct object *obj)
 {
-       rev_list_insert_ref(negotiator, NULL, &obj->oid);
+       rev_list_insert_ref(negotiator, &obj->oid);
 }
 
 #define INITIAL_FLUSH 16
@@ -230,13 +255,12 @@ static void mark_tips(struct fetch_negotiator *negotiator,
        int i;
 
        if (!negotiation_tips) {
-               for_each_ref(rev_list_insert_ref_oid, negotiator);
+               for_each_rawref(rev_list_insert_ref_oid, negotiator);
                return;
        }
 
        for (i = 0; i < negotiation_tips->nr; i++)
-               rev_list_insert_ref(negotiator, NULL,
-                                   &negotiation_tips->oid[i]);
+               rev_list_insert_ref(negotiator, &negotiation_tips->oid[i]);
        return;
 }
 
@@ -262,10 +286,8 @@ static int find_common(struct fetch_negotiator *negotiator,
                           PACKET_READ_CHOMP_NEWLINE |
                           PACKET_READ_DIE_ON_ERR_PACKET);
 
-       if (!args->no_dependents) {
-               mark_tips(negotiator, args->negotiation_tips);
-               for_each_cached_alternate(negotiator, insert_one_alternate_object);
-       }
+       mark_tips(negotiator, args->negotiation_tips);
+       for_each_cached_alternate(negotiator, insert_one_alternate_object);
 
        fetching = 0;
        for ( ; refs ; refs = refs->next) {
@@ -282,12 +304,8 @@ static int find_common(struct fetch_negotiator *negotiator,
                 * We use lookup_object here because we are only
                 * interested in the case we *know* the object is
                 * reachable and we have already scanned it.
-                *
-                * Do this only if args->no_dependents is false (if it is true,
-                * we cannot trust the object flags).
                 */
-               if (!args->no_dependents &&
-                   ((o = lookup_object(the_repository, remote)) != NULL) &&
+               if (((o = lookup_object(the_repository, remote)) != NULL) &&
                                (o->flags & COMPLETE)) {
                        continue;
                }
@@ -309,6 +327,8 @@ static int find_common(struct fetch_negotiator *negotiator,
                        if (deepen_not_ok)      strbuf_addstr(&c, " deepen-not");
                        if (agent_supported)    strbuf_addf(&c, " agent=%s",
                                                            git_user_agent_sanitized());
+                       if (advertise_sid)
+                               strbuf_addf(&c, " session-id=%s", trace2_session_id());
                        if (args->filter_options.choice)
                                strbuf_addstr(&c, " filter");
                        packet_buf_write(&req_buf, "want %s%s\n", remote_hex, c.buf);
@@ -387,8 +407,6 @@ static int find_common(struct fetch_negotiator *negotiator,
        trace2_region_enter("fetch-pack", "negotiation_v0_v1", the_repository);
        flushes = 0;
        retval = -1;
-       if (args->no_dependents)
-               goto done;
        while ((oid = negotiator->next(negotiator))) {
                packet_buf_write(&req_buf, "have %s\n", oid_to_hex(oid));
                print_verbose(args, "have %s", oid_to_hex(oid));
@@ -503,21 +521,11 @@ static struct commit_list *complete;
 
 static int mark_complete(const struct object_id *oid)
 {
-       struct object *o = parse_object(the_repository, oid);
-
-       while (o && o->type == OBJ_TAG) {
-               struct tag *t = (struct tag *) o;
-               if (!t->tagged)
-                       break; /* broken repository */
-               o->flags |= COMPLETE;
-               o = parse_object(the_repository, &t->tagged->oid);
-       }
-       if (o && o->type == OBJ_COMMIT) {
-               struct commit *commit = (struct commit *)o;
-               if (!(commit->object.flags & COMPLETE)) {
-                       commit->object.flags |= COMPLETE;
-                       commit_list_insert(commit, &complete);
-               }
+       struct commit *commit = deref_without_lazy_fetch(oid, 1);
+
+       if (commit && !(commit->object.flags & COMPLETE)) {
+               commit->object.flags |= COMPLETE;
+               commit_list_insert(commit, &complete);
        }
        return 0;
 }
@@ -653,9 +661,7 @@ struct loose_object_iter {
 
 /*
  * Mark recent commits available locally and reachable from a local ref as
- * COMPLETE. If args->no_dependents is false, also mark COMPLETE remote refs as
- * COMMON_REF (otherwise, we are not planning to participate in negotiation, and
- * thus do not need COMMON_REF marks).
+ * COMPLETE.
  *
  * The cutoff time for recency is determined by this heuristic: it is the
  * earliest commit time of the objects in refs that are commits and that we know
@@ -702,7 +708,7 @@ static void mark_complete_and_common_ref(struct fetch_negotiator *negotiator,
         */
        trace2_region_enter("fetch-pack", "mark_complete_local_refs", NULL);
        if (!args->deepen) {
-               for_each_ref(mark_complete_oid, NULL);
+               for_each_rawref(mark_complete_oid, NULL);
                for_each_cached_alternate(NULL, mark_alternate_complete);
                commit_list_sort_by_date(&complete);
                if (cutoff)
@@ -716,16 +722,12 @@ static void mark_complete_and_common_ref(struct fetch_negotiator *negotiator,
         */
        trace2_region_enter("fetch-pack", "mark_common_remote_refs", NULL);
        for (ref = *refs; ref; ref = ref->next) {
-               struct object *o = deref_tag(the_repository,
-                                            lookup_object(the_repository,
-                                            &ref->old_oid),
-                                            NULL, 0);
+               struct commit *c = deref_without_lazy_fetch(&ref->old_oid, 0);
 
-               if (!o || o->type != OBJ_COMMIT || !(o->flags & COMPLETE))
+               if (!c || !(c->object.flags & COMPLETE))
                        continue;
 
-               negotiator->known_common(negotiator,
-                                        (struct commit *)o);
+               negotiator->known_common(negotiator, c);
        }
        trace2_region_leave("fetch-pack", "mark_common_remote_refs", NULL);
 
@@ -916,8 +918,9 @@ static int get_pack(struct fetch_pack_args *args,
        if (start_command(&cmd))
                die(_("fetch-pack: unable to fork off %s"), cmd_name);
        if (do_keep && pack_lockfiles) {
-               string_list_append_nodup(pack_lockfiles,
-                                        index_pack_lockfile(cmd.out));
+               char *pack_lockfile = index_pack_lockfile(cmd.out);
+               if (pack_lockfile)
+                       string_list_append_nodup(pack_lockfiles, pack_lockfile);
                close(cmd.out);
        }
 
@@ -967,12 +970,8 @@ static struct ref *do_fetch_pack(struct fetch_pack_args *args,
        struct fetch_negotiator negotiator_alloc;
        struct fetch_negotiator *negotiator;
 
-       if (args->no_dependents) {
-               negotiator = NULL;
-       } else {
-               negotiator = &negotiator_alloc;
-               fetch_negotiator_init(r, negotiator);
-       }
+       negotiator = &negotiator_alloc;
+       fetch_negotiator_init(r, negotiator);
 
        sort_ref_list(&ref, ref_compare_name);
        QSORT(sought, nr_sought, cmp_ref_by_name);
@@ -984,6 +983,9 @@ static struct ref *do_fetch_pack(struct fetch_pack_args *args,
                                      agent_len, agent_feature);
        }
 
+       if (!server_supports("session-id"))
+               advertise_sid = 0;
+
        if (server_supports("shallow"))
                print_verbose(args, _("Server supports %s"), "shallow");
        else if (args->depth > 0 || is_repository_shallow(r))
@@ -1060,15 +1062,11 @@ static struct ref *do_fetch_pack(struct fetch_pack_args *args,
        if (!server_supports_hash(the_hash_algo->name, NULL))
                die(_("Server does not support this repository's object format"));
 
-       if (!args->no_dependents) {
-               mark_complete_and_common_ref(negotiator, args, &ref);
-               filter_refs(args, &ref, sought, nr_sought);
-               if (everything_local(args, &ref)) {
-                       packet_flush(fd[1]);
-                       goto all_done;
-               }
-       } else {
-               filter_refs(args, &ref, sought, nr_sought);
+       mark_complete_and_common_ref(negotiator, args, &ref);
+       filter_refs(args, &ref, sought, nr_sought);
+       if (everything_local(args, &ref)) {
+               packet_flush(fd[1]);
+               goto all_done;
        }
        if (find_common(negotiator, args, fd, &oid, ref) < 0)
                if (!args->keep_pack)
@@ -1117,7 +1115,7 @@ static void add_shallow_requests(struct strbuf *req_buf,
                packet_buf_write(req_buf, "deepen-relative\n");
 }
 
-static void add_wants(int no_dependents, const struct ref *wants, struct strbuf *req_buf)
+static void add_wants(const struct ref *wants, struct strbuf *req_buf)
 {
        int use_ref_in_want = server_supports_feature("fetch", "ref-in-want", 0);
 
@@ -1134,12 +1132,8 @@ static void add_wants(int no_dependents, const struct ref *wants, struct strbuf
                 * We use lookup_object here because we are only
                 * interested in the case we *know* the object is
                 * reachable and we have already scanned it.
-                *
-                * Do this only if args->no_dependents is false (if it is true,
-                * we cannot trust the object flags).
                 */
-               if (!no_dependents &&
-                   ((o = lookup_object(the_repository, remote)) != NULL) &&
+               if (((o = lookup_object(the_repository, remote)) != NULL) &&
                    (o->flags & COMPLETE)) {
                        continue;
                }
@@ -1204,6 +1198,8 @@ static int send_fetch_request(struct fetch_negotiator *negotiator, int fd_out,
                packet_buf_write(&req_buf, "command=fetch");
        if (server_supports_v2("agent", 0))
                packet_buf_write(&req_buf, "agent=%s", git_user_agent_sanitized());
+       if (advertise_sid && server_supports_v2("session-id", 0))
+               packet_buf_write(&req_buf, "session-id=%s", trace2_session_id());
        if (args->server_options && args->server_options->nr &&
            server_supports_v2("server-option", 1)) {
                int i;
@@ -1273,19 +1269,14 @@ static int send_fetch_request(struct fetch_negotiator *negotiator, int fd_out,
        }
 
        /* add wants */
-       add_wants(args->no_dependents, wants, &req_buf);
+       add_wants(wants, &req_buf);
 
-       if (args->no_dependents) {
-               packet_buf_write(&req_buf, "done");
-               ret = 1;
-       } else {
-               /* Add all of the common commits we've found in previous rounds */
-               add_common(&req_buf, common);
+       /* Add all of the common commits we've found in previous rounds */
+       add_common(&req_buf, common);
 
-               /* Add initial haves */
-               ret = add_haves(negotiator, seen_ack, &req_buf,
-                               haves_to_send, in_vain);
-       }
+       /* Add initial haves */
+       ret = add_haves(negotiator, seen_ack, &req_buf,
+                       haves_to_send, in_vain);
 
        /* Send request */
        packet_buf_flush(&req_buf);
@@ -1545,12 +1536,8 @@ static struct ref *do_fetch_pack_v2(struct fetch_pack_args *args,
        struct string_list packfile_uris = STRING_LIST_INIT_DUP;
        int i;
 
-       if (args->no_dependents) {
-               negotiator = NULL;
-       } else {
-               negotiator = &negotiator_alloc;
-               fetch_negotiator_init(r, negotiator);
-       }
+       negotiator = &negotiator_alloc;
+       fetch_negotiator_init(r, negotiator);
 
        packet_reader_init(&reader, fd[0], NULL, 0,
                           PACKET_READ_CHOMP_NEWLINE |
@@ -1574,21 +1561,16 @@ static struct ref *do_fetch_pack_v2(struct fetch_pack_args *args,
                                args->deepen = 1;
 
                        /* Filter 'ref' by 'sought' and those that aren't local */
-                       if (!args->no_dependents) {
-                               mark_complete_and_common_ref(negotiator, args, &ref);
-                               filter_refs(args, &ref, sought, nr_sought);
-                               if (everything_local(args, &ref))
-                                       state = FETCH_DONE;
-                               else
-                                       state = FETCH_SEND_REQUEST;
-
-                               mark_tips(negotiator, args->negotiation_tips);
-                               for_each_cached_alternate(negotiator,
-                                                         insert_one_alternate_object);
-                       } else {
-                               filter_refs(args, &ref, sought, nr_sought);
+                       mark_complete_and_common_ref(negotiator, args, &ref);
+                       filter_refs(args, &ref, sought, nr_sought);
+                       if (everything_local(args, &ref))
+                               state = FETCH_DONE;
+                       else
                                state = FETCH_SEND_REQUEST;
-                       }
+
+                       mark_tips(negotiator, args->negotiation_tips);
+                       for_each_cached_alternate(negotiator,
+                                                 insert_one_alternate_object);
                        break;
                case FETCH_SEND_REQUEST:
                        if (!negotiation_started) {
@@ -1738,6 +1720,7 @@ static void fetch_pack_config(void)
        git_config_get_bool("repack.usedeltabaseoffset", &prefer_ofs_delta);
        git_config_get_bool("fetch.fsckobjects", &fetch_fsck_objects);
        git_config_get_bool("transfer.fsckobjects", &transfer_fsck_objects);
+       git_config_get_bool("transfer.advertisesid", &advertise_sid);
        if (!uri_protocols.nr) {
                char *str;
 
@@ -1909,20 +1892,6 @@ struct ref *fetch_pack(struct fetch_pack_args *args,
        if (nr_sought)
                nr_sought = remove_duplicates_in_refs(sought, nr_sought);
 
-       if (args->no_dependents && !args->filter_options.choice) {
-               /*
-                * The protocol does not support requesting that only the
-                * wanted objects be sent, so approximate this by setting a
-                * "blob:none" filter if no filter is already set. This works
-                * for all object types: note that wanted blobs will still be
-                * sent because they are directly specified as a "want".
-                *
-                * NEEDSWORK: Add an option in the protocol to request that
-                * only the wanted objects be sent, and implement it.
-                */
-               parse_list_objects_filter(&args->filter_options, "blob:none");
-       }
-
        if (version != protocol_v2 && !ref) {
                packet_flush(fd[1]);
                die(_("no matching remote head"));