]> git.ipfire.org Git - thirdparty/u-boot.git/blobdiff - lib/smbios.c
Merge tag 'doc-2024-10-rc6' of https://source.denx.de/u-boot/custodians/u-boot-efi
[thirdparty/u-boot.git] / lib / smbios.c
index 7bd9805fec0353067d040372d7f434844bcede03..7c24ea129eb5fce3540d72ada56a21547a9c7dc7 100644 (file)
@@ -5,6 +5,8 @@
  * Adapted from coreboot src/arch/x86/smbios.c
  */
 
+#define LOG_CATEGORY   LOGC_BOARD
+
 #include <dm.h>
 #include <env.h>
 #include <linux/stringify.h>
@@ -20,6 +22,7 @@
 #include <cpu.h>
 #include <dm/uclass-internal.h>
 #endif
+#include <linux/sizes.h>
 
 /* Safeguard for checking that U_BOOT_VERSION_NUM macros are compatible with U_BOOT_DMI */
 #if U_BOOT_VERSION_NUM < 2000 || U_BOOT_VERSION_NUM > 2099 || \
@@ -135,13 +138,16 @@ static const struct map_sysinfo *convert_sysinfo_to_dt(const char *node, const c
  *
  * @ctx:       SMBIOS context
  * @str:       string to add
- * Return:     string number in the string area (1 or more)
+ * Return:     string number in the string area. 0 if str is NULL.
  */
 static int smbios_add_string(struct smbios_ctx *ctx, const char *str)
 {
        int i = 1;
        char *p = ctx->eos;
 
+       if (!str)
+               return 0;
+
        for (;;) {
                if (!*p) {
                        ctx->last_str = p;
@@ -207,6 +213,7 @@ void get_str_from_dt(const struct map_sysinfo *nprop, char *str, size_t size)
  *
  * @ctx:       context for writing the tables
  * @prop:      property to write
+ * @sysinfo_id: unique identifier for the string value to be read
  * @dval:      Default value to use if the string is not found or is empty
  * Return:     0 if not found, else SMBIOS string number (1 or more)
  */
@@ -216,7 +223,7 @@ static int smbios_add_prop_si(struct smbios_ctx *ctx, const char *prop,
        int ret;
 
        if (!dval || !*dval)
-               dval = "Unknown";
+               dval = NULL;
 
        if (!prop)
                return smbios_add_string(ctx, dval);
@@ -311,6 +318,10 @@ int smbios_update_version(const char *version)
  */
 static int smbios_string_table_len(const struct smbios_ctx *ctx)
 {
+       /* In case no string is defined we have to return two \0 */
+       if (ctx->next_ptr == ctx->eos)
+               return 2;
+
        /* Allow for the final \0 after all strings */
        return (ctx->next_ptr + 1) - ctx->eos;
 }
@@ -338,7 +349,13 @@ static int smbios_write_type0(ulong *current, int handle,
 #endif
        t->bios_release_date = smbios_add_prop(ctx, NULL, U_BOOT_DMI_DATE);
 #ifdef CONFIG_ROM_SIZE
-       t->bios_rom_size = (CONFIG_ROM_SIZE / 65536) - 1;
+       if (CONFIG_ROM_SIZE < SZ_16M) {
+               t->bios_rom_size = (CONFIG_ROM_SIZE / 65536) - 1;
+       } else {
+               /* CONFIG_ROM_SIZE < 8 GiB */
+               t->bios_rom_size = 0xff;
+               t->extended_bios_rom_size = CONFIG_ROM_SIZE >> 20;
+       }
 #endif
        t->bios_characteristics = BIOS_CHARACTERISTICS_PCI_SUPPORTED |
                                  BIOS_CHARACTERISTICS_SELECTABLE_BOOT |
@@ -375,19 +392,28 @@ static int smbios_write_type1(ulong *current, int handle,
        memset(t, 0, sizeof(struct smbios_type1));
        fill_smbios_header(t, SMBIOS_SYSTEM_INFORMATION, len, handle);
        smbios_set_eos(ctx, t->eos);
-       t->manufacturer = smbios_add_prop(ctx, "manufacturer", "Unknown");
-       t->product_name = smbios_add_prop(ctx, "product", "Unknown");
+       t->manufacturer = smbios_add_prop_si(ctx, "manufacturer",
+                                            SYSINFO_ID_SMBIOS_SYSTEM_MANUFACTURER,
+                                            NULL);
+       t->product_name = smbios_add_prop_si(ctx, "product",
+                                            SYSINFO_ID_SMBIOS_SYSTEM_PRODUCT,
+                                            NULL);
        t->version = smbios_add_prop_si(ctx, "version",
                                        SYSINFO_ID_SMBIOS_SYSTEM_VERSION,
-                                       "Unknown");
+                                       NULL);
        if (serial_str) {
                t->serial_number = smbios_add_prop(ctx, NULL, serial_str);
                strncpy((char *)t->uuid, serial_str, sizeof(t->uuid));
        } else {
-               t->serial_number = smbios_add_prop(ctx, "serial", "Unknown");
+               t->serial_number = smbios_add_prop_si(ctx, "serial",
+                                                     SYSINFO_ID_SMBIOS_SYSTEM_SERIAL,
+                                                     NULL);
        }
-       t->sku_number = smbios_add_prop(ctx, "sku", "Unknown");
-       t->family = smbios_add_prop(ctx, "family", "Unknown");
+       t->wakeup_type = SMBIOS_WAKEUP_TYPE_UNKNOWN;
+       t->sku_number = smbios_add_prop_si(ctx, "sku",
+                                          SYSINFO_ID_SMBIOS_SYSTEM_SKU, NULL);
+       t->family = smbios_add_prop_si(ctx, "family",
+                                      SYSINFO_ID_SMBIOS_SYSTEM_FAMILY, NULL);
 
        len = t->length + smbios_string_table_len(ctx);
        *current += len;
@@ -406,14 +432,25 @@ static int smbios_write_type2(ulong *current, int handle,
        memset(t, 0, sizeof(struct smbios_type2));
        fill_smbios_header(t, SMBIOS_BOARD_INFORMATION, len, handle);
        smbios_set_eos(ctx, t->eos);
-       t->manufacturer = smbios_add_prop(ctx, "manufacturer", "Unknown");
-       t->product_name = smbios_add_prop(ctx, "product", "Unknown");
+       t->manufacturer = smbios_add_prop_si(ctx, "manufacturer",
+                                            SYSINFO_ID_SMBIOS_BASEBOARD_MANUFACTURER,
+                                            NULL);
+       t->product_name = smbios_add_prop_si(ctx, "product",
+                                            SYSINFO_ID_SMBIOS_BASEBOARD_PRODUCT,
+                                            NULL);
        t->version = smbios_add_prop_si(ctx, "version",
                                        SYSINFO_ID_SMBIOS_BASEBOARD_VERSION,
-                                       "Unknown");
-       t->asset_tag_number = smbios_add_prop(ctx, "asset-tag", "Unknown");
+                                       NULL);
+
+       t->serial_number = smbios_add_prop_si(ctx, "serial",
+                                             SYSINFO_ID_SMBIOS_BASEBOARD_SERIAL,
+                                             NULL);
+       t->asset_tag_number = smbios_add_prop_si(ctx, "asset-tag",
+                                                SYSINFO_ID_SMBIOS_BASEBOARD_ASSET_TAG,
+                                                NULL);
        t->feature_flags = SMBIOS_BOARD_FEATURE_HOSTING;
        t->board_type = SMBIOS_BOARD_MOTHERBOARD;
+       t->chassis_handle = handle + 1;
 
        len = t->length + smbios_string_table_len(ctx);
        *current += len;
@@ -432,7 +469,7 @@ static int smbios_write_type3(ulong *current, int handle,
        memset(t, 0, sizeof(struct smbios_type3));
        fill_smbios_header(t, SMBIOS_SYSTEM_ENCLOSURE, len, handle);
        smbios_set_eos(ctx, t->eos);
-       t->manufacturer = smbios_add_prop(ctx, "manufacturer", "Unknown");
+       t->manufacturer = smbios_add_prop(ctx, "manufacturer", NULL);
        t->chassis_type = SMBIOS_ENCLOSURE_DESKTOP;
        t->bootup_state = SMBIOS_STATE_SAFE;
        t->power_supply_state = SMBIOS_STATE_SAFE;
@@ -450,8 +487,8 @@ static void smbios_write_type4_dm(struct smbios_type4 *t,
                                  struct smbios_ctx *ctx)
 {
        u16 processor_family = SMBIOS_PROCESSOR_FAMILY_UNKNOWN;
-       const char *vendor = "Unknown";
-       const char *name = "Unknown";
+       const char *vendor = NULL;
+       const char *name = NULL;
 
 #ifdef CONFIG_CPU
        char processor_name[49];
@@ -542,6 +579,7 @@ static struct smbios_write_method smbios_write_funcs[] = {
        { smbios_write_type0, "bios", },
        { smbios_write_type1, "system", },
        { smbios_write_type2, "baseboard", },
+       /* Type 3 must immediately follow type 2 due to chassis handle. */
        { smbios_write_type3, "chassis", },
        { smbios_write_type4, },
        { smbios_write_type32, },
@@ -556,15 +594,24 @@ ulong write_smbios_table(ulong addr)
        struct smbios_ctx ctx;
        ulong tables;
        int len = 0;
-       int max_struct_size = 0;
        int handle = 0;
        int i;
 
        ctx.node = ofnode_null();
-       if (IS_ENABLED(CONFIG_OF_CONTROL)) {
+       if (IS_ENABLED(CONFIG_OF_CONTROL) && CONFIG_IS_ENABLED(SYSINFO)) {
                uclass_first_device(UCLASS_SYSINFO, &ctx.dev);
-               if (ctx.dev)
+               if (ctx.dev) {
+                       int ret;
+
                        parent_node = dev_read_subnode(ctx.dev, "smbios");
+                       ret = sysinfo_detect(ctx.dev);
+
+                       /*
+                        * ignore the error since many boards don't implement
+                        * this and we can still use the info in the devicetree
+                        */
+                       ret = log_msg_ret("sys", ret);
+               }
        } else {
                ctx.dev = NULL;
        }
@@ -578,7 +625,6 @@ ulong write_smbios_table(ulong addr)
        /* populate minimum required tables */
        for (i = 0; i < ARRAY_SIZE(smbios_write_funcs); i++) {
                const struct smbios_write_method *method;
-               int tmp;
 
                method = &smbios_write_funcs[i];
                ctx.subnode_name = NULL;
@@ -588,10 +634,7 @@ ulong write_smbios_table(ulong addr)
                                ctx.node = ofnode_find_subnode(parent_node,
                                                               method->subnode_name);
                }
-               tmp = method->write((ulong *)&addr, handle++, &ctx);
-
-               max_struct_size = max(max_struct_size, tmp);
-               len += tmp;
+               len += method->write((ulong *)&addr, handle++, &ctx);
        }
 
        /*
@@ -610,7 +653,7 @@ ulong write_smbios_table(ulong addr)
        se->minor_ver = SMBIOS_MINOR_VER;
        se->doc_rev = 0;
        se->entry_point_rev = 1;
-       se->max_struct_size = len;
+       se->table_maximum_size = len;
        se->struct_table_address = table_addr;
        se->checksum = table_compute_checksum(se, sizeof(struct smbios3_entry));
        unmap_sysmem(se);