]> git.ipfire.org Git - thirdparty/hostap.git/blobdiff - src/common/dpp.c
DPP: Fix a memory leak on duplicate Authentication Response
[thirdparty/hostap.git] / src / common / dpp.c
index ae5fbd384748cdad4c2e6ee033e693390426bc77..4b8d83811dbd9681f0f7e0f95165b983592399ee 100644 (file)
@@ -1,35 +1,56 @@
 /*
  * DPP functionality shared between hostapd and wpa_supplicant
  * Copyright (c) 2017, Qualcomm Atheros, Inc.
+ * Copyright (c) 2018-2019, The Linux Foundation
  *
  * This software may be distributed under the terms of the BSD license.
  * See README for more details.
  */
 
 #include "utils/includes.h"
+#include <fcntl.h>
 #include <openssl/opensslv.h>
 #include <openssl/err.h>
+#include <openssl/asn1.h>
+#include <openssl/asn1t.h>
 
 #include "utils/common.h"
 #include "utils/base64.h"
 #include "utils/json.h"
+#include "utils/ip_addr.h"
+#include "utils/eloop.h"
 #include "common/ieee802_11_common.h"
 #include "common/ieee802_11_defs.h"
 #include "common/wpa_ctrl.h"
+#include "common/gas.h"
 #include "crypto/crypto.h"
 #include "crypto/random.h"
 #include "crypto/aes.h"
 #include "crypto/aes_siv.h"
 #include "crypto/sha384.h"
 #include "crypto/sha512.h"
+#include "drivers/driver.h"
 #include "dpp.h"
 
 
 #ifdef CONFIG_TESTING_OPTIONS
 enum dpp_test_behavior dpp_test = DPP_TEST_DISABLED;
+u8 dpp_pkex_own_mac_override[ETH_ALEN] = { 0, 0, 0, 0, 0, 0 };
+u8 dpp_pkex_peer_mac_override[ETH_ALEN] = { 0, 0, 0, 0, 0, 0 };
+u8 dpp_pkex_ephemeral_key_override[600];
+size_t dpp_pkex_ephemeral_key_override_len = 0;
+u8 dpp_protocol_key_override[600];
+size_t dpp_protocol_key_override_len = 0;
+u8 dpp_nonce_override[DPP_MAX_NONCE_LEN];
+size_t dpp_nonce_override_len = 0;
+
+static int dpp_test_gen_invalid_key(struct wpabuf *msg,
+                                   const struct dpp_curve_params *curve);
 #endif /* CONFIG_TESTING_OPTIONS */
 
-#if OPENSSL_VERSION_NUMBER < 0x10100000L
+#if OPENSSL_VERSION_NUMBER < 0x10100000L || \
+       (defined(LIBRESSL_VERSION_NUMBER) && \
+        LIBRESSL_VERSION_NUMBER < 0x20700000L)
 /* Compatibility wrappers for older versions. */
 
 static int ECDSA_SIG_set0(ECDSA_SIG *sig, BIGNUM *r, BIGNUM *s)
@@ -52,6 +73,64 @@ static void ECDSA_SIG_get0(const ECDSA_SIG *sig, const BIGNUM **pr,
 #endif
 
 
+struct dpp_connection {
+       struct dl_list list;
+       struct dpp_controller *ctrl;
+       struct dpp_relay_controller *relay;
+       struct dpp_global *global;
+       struct dpp_authentication *auth;
+       int sock;
+       u8 mac_addr[ETH_ALEN];
+       unsigned int freq;
+       u8 msg_len[4];
+       size_t msg_len_octets;
+       struct wpabuf *msg;
+       struct wpabuf *msg_out;
+       size_t msg_out_pos;
+       unsigned int read_eloop:1;
+       unsigned int write_eloop:1;
+       unsigned int on_tcp_tx_complete_gas_done:1;
+       unsigned int on_tcp_tx_complete_remove:1;
+       unsigned int on_tcp_tx_complete_auth_ok:1;
+};
+
+/* Remote Controller */
+struct dpp_relay_controller {
+       struct dl_list list;
+       struct dpp_global *global;
+       u8 pkhash[SHA256_MAC_LEN];
+       struct hostapd_ip_addr ipaddr;
+       void *cb_ctx;
+       void (*tx)(void *ctx, const u8 *addr, unsigned int freq, const u8 *msg,
+                  size_t len);
+       void (*gas_resp_tx)(void *ctx, const u8 *addr, u8 dialog_token,
+                           int prot, struct wpabuf *buf);
+       struct dl_list conn; /* struct dpp_connection */
+};
+
+/* Local Controller */
+struct dpp_controller {
+       struct dpp_global *global;
+       u8 allowed_roles;
+       int qr_mutual;
+       int sock;
+       struct dl_list conn; /* struct dpp_connection */
+       char *configurator_params;
+};
+
+struct dpp_global {
+       void *msg_ctx;
+       struct dl_list bootstrap; /* struct dpp_bootstrap_info */
+       struct dl_list configurator; /* struct dpp_configurator */
+#ifdef CONFIG_DPP2
+       struct dl_list controllers; /* struct dpp_relay_controller */
+       struct dpp_controller *controller;
+       struct dl_list tcp_init; /* struct dpp_connection */
+       void *cb_ctx;
+       int (*process_conf_obj)(void *ctx, struct dpp_authentication *auth);
+#endif /* CONFIG_DPP2 */
+};
+
 static const struct dpp_curve_params dpp_curves[] = {
        /* The mandatory to support and the default NIST P-256 curve needs to
         * be the first entry on this list. */
@@ -87,10 +166,10 @@ static const u8 pkex_resp_x_p256[32] = {
        0x59, 0x91, 0x52, 0x33, 0xac, 0x19, 0x9d, 0x76
 };
 static const u8 pkex_resp_y_p256[32] = {
-       0x26, 0x04, 0x09, 0x45, 0x0a, 0x05, 0x20, 0xe7,
-       0xa7, 0x27, 0xc1, 0x36, 0x76, 0x85, 0xca, 0x3e,
-       0x42, 0x16, 0xf4, 0x89, 0x85, 0x34, 0x6e, 0xd5,
-       0x17, 0xde, 0xc0, 0xb8, 0xad, 0xfd, 0xb2, 0x98
+       0xd9, 0xfb, 0xf6, 0xb9, 0xf5, 0xfa, 0xdf, 0x19,
+       0x58, 0xd8, 0x3e, 0xc9, 0x89, 0x7a, 0x35, 0xc1,
+       0xbd, 0xe9, 0x0b, 0x77, 0x7a, 0xcb, 0x91, 0x2a,
+       0xe8, 0x21, 0x3f, 0x47, 0x52, 0x02, 0x4d, 0x67
 };
 
 /* NIST P-384 */
@@ -103,12 +182,12 @@ static const u8 pkex_init_x_p384[48] = {
        0x81, 0xac, 0x38, 0x5d, 0x41, 0xe6, 0xb9, 0xa3
 };
 static const u8 pkex_init_y_p384[48] = {
-       0x89, 0xd0, 0x97, 0x7b, 0x59, 0x4f, 0xa6, 0xd6,
-       0x7c, 0x5d, 0x93, 0x5b, 0x93, 0xc4, 0x07, 0xa9,
-       0x89, 0xee, 0xd5, 0xcd, 0x6f, 0x42, 0xf8, 0x38,
-       0xc8, 0xc6, 0x62, 0x24, 0x69, 0x0c, 0xd4, 0x48,
-       0xd8, 0x44, 0xd6, 0xc2, 0xe8, 0xcc, 0x62, 0x6b,
-       0x3c, 0x25, 0x53, 0xba, 0x4f, 0x71, 0xf8, 0xe7
+       0x76, 0x2f, 0x68, 0x84, 0xa6, 0xb0, 0x59, 0x29,
+       0x83, 0xa2, 0x6c, 0xa4, 0x6c, 0x3b, 0xf8, 0x56,
+       0x76, 0x11, 0x2a, 0x32, 0x90, 0xbd, 0x07, 0xc7,
+       0x37, 0x39, 0x9d, 0xdb, 0x96, 0xf3, 0x2b, 0xb6,
+       0x27, 0xbb, 0x29, 0x3c, 0x17, 0x33, 0x9d, 0x94,
+       0xc3, 0xda, 0xac, 0x46, 0xb0, 0x8e, 0x07, 0x18
 };
 static const u8 pkex_resp_x_p384[48] = {
        0xad, 0xbe, 0xd7, 0x1d, 0x3a, 0x71, 0x64, 0x98,
@@ -119,12 +198,12 @@ static const u8 pkex_resp_x_p384[48] = {
        0xe0, 0xbb, 0xd7, 0xb1, 0x29, 0x20, 0x72, 0xdf
 };
 static const u8 pkex_resp_y_p384[48] = {
-       0x54, 0x58, 0x20, 0xad, 0x55, 0x1d, 0xca, 0xf3,
-       0x1c, 0x8a, 0xcd, 0x19, 0x40, 0xf9, 0x37, 0x83,
-       0xc7, 0xd6, 0xb3, 0x13, 0x7d, 0x53, 0x28, 0x5c,
-       0xf6, 0x2d, 0xf1, 0xdd, 0xa5, 0x8b, 0xad, 0x5d,
-       0x81, 0xab, 0xb1, 0x00, 0x39, 0xd6, 0xcc, 0x9c,
-       0xea, 0x1e, 0x84, 0x1d, 0xbf, 0xe3, 0x35, 0xf9
+       0xab, 0xa7, 0xdf, 0x52, 0xaa, 0xe2, 0x35, 0x0c,
+       0xe3, 0x75, 0x32, 0xe6, 0xbf, 0x06, 0xc8, 0x7c,
+       0x38, 0x29, 0x4c, 0xec, 0x82, 0xac, 0xd7, 0xa3,
+       0x09, 0xd2, 0x0e, 0x22, 0x5a, 0x74, 0x52, 0xa1,
+       0x7e, 0x54, 0x4e, 0xfe, 0xc6, 0x29, 0x33, 0x63,
+       0x15, 0xe1, 0x7b, 0xe3, 0x40, 0x1c, 0xca, 0x06
 };
 
 /* NIST P-521 */
@@ -140,15 +219,15 @@ static const u8 pkex_init_x_p521[66] = {
        0x97, 0x76
 };
 static const u8 pkex_init_y_p521[66] = {
-       0x01, 0x4c, 0x71, 0xfd, 0x1b, 0xd5, 0x9c, 0xa6,
-       0xed, 0x39, 0xef, 0x45, 0xc5, 0x06, 0xfd, 0x66,
-       0xc0, 0xeb, 0x0f, 0xbf, 0x21, 0xa3, 0x36, 0x74,
-       0xfd, 0xaa, 0x05, 0x6e, 0x4e, 0x33, 0x95, 0x42,
-       0x1a, 0x9d, 0x3f, 0x3a, 0x1c, 0x5e, 0xa8, 0x60,
-       0xf7, 0xe5, 0x59, 0x1d, 0x07, 0xaa, 0x6f, 0x40,
-       0x0a, 0x59, 0x3c, 0x27, 0xad, 0xe0, 0x48, 0xfd,
-       0xd1, 0x83, 0x37, 0x4c, 0xdf, 0xe1, 0x86, 0x72,
-       0xfc, 0x57
+       0x00, 0xb3, 0x8e, 0x02, 0xe4, 0x2a, 0x63, 0x59,
+       0x12, 0xc6, 0x10, 0xba, 0x3a, 0xf9, 0x02, 0x99,
+       0x3f, 0x14, 0xf0, 0x40, 0xde, 0x5c, 0xc9, 0x8b,
+       0x02, 0x55, 0xfa, 0x91, 0xb1, 0xcc, 0x6a, 0xbd,
+       0xe5, 0x62, 0xc0, 0xc5, 0xe3, 0xa1, 0x57, 0x9f,
+       0x08, 0x1a, 0xa6, 0xe2, 0xf8, 0x55, 0x90, 0xbf,
+       0xf5, 0xa6, 0xc3, 0xd8, 0x52, 0x1f, 0xb7, 0x02,
+       0x2e, 0x7c, 0xc8, 0xb3, 0x20, 0x1e, 0x79, 0x8d,
+       0x03, 0xa8
 };
 static const u8 pkex_resp_x_p521[66] = {
        0x00, 0x79, 0xe4, 0x4d, 0x6b, 0x5e, 0x12, 0x0a,
@@ -162,15 +241,15 @@ static const u8 pkex_resp_x_p521[66] = {
        0x84, 0xb4
 };
 static const u8 pkex_resp_y_p521[66] = {
-       0x01, 0xb9, 0x9c, 0xc6, 0x41, 0x32, 0x5b, 0xd2,
-       0x35, 0xd8, 0x8b, 0x2b, 0xe4, 0x6e, 0xcc, 0xdf,
-       0x7c, 0x38, 0xc4, 0x5b, 0xf6, 0x74, 0x71, 0x5c,
-       0x77, 0x16, 0x8a, 0x80, 0xa9, 0x84, 0xc7, 0x7b,
-       0x9d, 0xfd, 0x83, 0x6f, 0xae, 0xf8, 0x24, 0x16,
-       0x2f, 0x21, 0x25, 0x65, 0xa2, 0x1a, 0x6b, 0x2d,
-       0x30, 0x62, 0xb3, 0xcc, 0x6e, 0x59, 0x3c, 0x7f,
-       0x58, 0x91, 0x81, 0x72, 0x07, 0x8c, 0x91, 0xac,
-       0x31, 0x1e
+       0x00, 0x46, 0x63, 0x39, 0xbe, 0xcd, 0xa4, 0x2d,
+       0xca, 0x27, 0x74, 0xd4, 0x1b, 0x91, 0x33, 0x20,
+       0x83, 0xc7, 0x3b, 0xa4, 0x09, 0x8b, 0x8e, 0xa3,
+       0x88, 0xe9, 0x75, 0x7f, 0x56, 0x7b, 0x38, 0x84,
+       0x62, 0x02, 0x7c, 0x90, 0x51, 0x07, 0xdb, 0xe9,
+       0xd0, 0xde, 0xda, 0x9a, 0x5d, 0xe5, 0x94, 0xd2,
+       0xcf, 0x9d, 0x4c, 0x33, 0x91, 0xa6, 0xc3, 0x80,
+       0xa7, 0x6e, 0x7e, 0x8d, 0xf8, 0x73, 0x6e, 0x53,
+       0xce, 0xe1
 };
 
 /* Brainpool P-256r1 */
@@ -181,10 +260,10 @@ static const u8 pkex_init_x_bp_p256r1[32] = {
        0xac, 0xc7, 0xe9, 0x8d, 0xc2, 0x6f, 0xec, 0xd8
 };
 static const u8 pkex_init_y_bp_p256r1[32] = {
-       0x16, 0x30, 0x68, 0x32, 0x3b, 0xb0, 0x21, 0xee,
-       0xeb, 0xf7, 0xb6, 0x7c, 0xae, 0x52, 0x26, 0x42,
-       0x59, 0x28, 0x58, 0xb6, 0x14, 0x90, 0xed, 0x69,
-       0xd0, 0x67, 0xea, 0x25, 0x60, 0x0f, 0xa9, 0x6c
+       0x93, 0xca, 0xef, 0xa9, 0x66, 0x3e, 0x87, 0xcd,
+       0x52, 0x6e, 0x54, 0x13, 0xef, 0x31, 0x67, 0x30,
+       0x15, 0x13, 0x9d, 0x6d, 0xc0, 0x95, 0x32, 0xbe,
+       0x4f, 0xab, 0x5d, 0xf7, 0xbf, 0x5e, 0xaa, 0x0b
 };
 static const u8 pkex_resp_x_bp_p256r1[32] = {
        0x90, 0x18, 0x84, 0xc9, 0xdc, 0xcc, 0xb5, 0x2f,
@@ -245,14 +324,14 @@ static const u8 pkex_init_x_bp_p512r1[64] = {
        0x63, 0xe4, 0xd1, 0x0e, 0x75, 0x45, 0x69, 0x0f
 };
 static const u8 pkex_init_y_bp_p512r1[64] = {
-       0x5a, 0x28, 0x01, 0xbe, 0x96, 0x82, 0x4e, 0xf6,
-       0xfa, 0xed, 0x7d, 0xfd, 0x48, 0x8b, 0x48, 0x4e,
-       0xd1, 0x97, 0x87, 0xc4, 0x05, 0x5d, 0x15, 0x2a,
-       0xf4, 0x91, 0x4b, 0x75, 0x90, 0xd9, 0x34, 0x2c,
-       0x3c, 0x12, 0xf2, 0xf5, 0x25, 0x94, 0x24, 0x34,
-       0xa7, 0x6d, 0x66, 0xbc, 0x27, 0xa4, 0xa0, 0x8d,
-       0xd5, 0xe1, 0x54, 0xa3, 0x55, 0x26, 0xd4, 0x14,
-       0x17, 0x0f, 0xc1, 0xc7, 0x3d, 0x68, 0x7f, 0x5a
+       0x50, 0xb5, 0x9b, 0xfa, 0x45, 0x67, 0x75, 0x94,
+       0x44, 0xe7, 0x68, 0xb0, 0xeb, 0x3e, 0xb3, 0xb8,
+       0xf9, 0x99, 0x05, 0xef, 0xae, 0x6c, 0xbc, 0xe3,
+       0xe1, 0xd2, 0x51, 0x54, 0xdf, 0x59, 0xd4, 0x45,
+       0x41, 0x3a, 0xa8, 0x0b, 0x76, 0x32, 0x44, 0x0e,
+       0x07, 0x60, 0x3a, 0x6e, 0xbe, 0xfe, 0xe0, 0x58,
+       0x52, 0xa0, 0xaa, 0x8b, 0xd8, 0x5b, 0xf2, 0x71,
+       0x11, 0x9a, 0x9e, 0x8f, 0x1a, 0xd1, 0xc9, 0x99
 };
 static const u8 pkex_resp_x_bp_p512r1[64] = {
        0x2a, 0x60, 0x32, 0x27, 0xa1, 0xe6, 0x94, 0x72,
@@ -265,17 +344,50 @@ static const u8 pkex_resp_x_bp_p512r1[64] = {
        0x8e, 0x6e, 0x23, 0x47, 0xd4, 0x4b, 0x70, 0x3e
 };
 static const u8 pkex_resp_y_bp_p512r1[64] = {
-       0x2a, 0xbe, 0x59, 0xe6, 0xc4, 0xb3, 0xd8, 0x09,
-       0x66, 0x89, 0x0a, 0x2d, 0x19, 0xf0, 0x9c, 0x9f,
-       0xb4, 0xab, 0x8f, 0x50, 0x68, 0x3c, 0x74, 0x64,
-       0x4e, 0x19, 0x55, 0x81, 0x9b, 0x48, 0x5c, 0xf4,
-       0x12, 0x8d, 0xb9, 0xd8, 0x02, 0x5b, 0xe1, 0x26,
-       0x7e, 0x19, 0x5c, 0xfd, 0x70, 0xf7, 0x4b, 0xdc,
-       0xb5, 0x5d, 0xc1, 0x7a, 0xe9, 0xd1, 0x05, 0x2e,
-       0xd1, 0xfd, 0x2f, 0xce, 0x63, 0x77, 0x48, 0x2c
+       0x80, 0x1f, 0x43, 0xd2, 0x17, 0x35, 0xec, 0x81,
+       0xd9, 0x4b, 0xdc, 0x81, 0x19, 0xd9, 0x5f, 0x68,
+       0x16, 0x84, 0xfe, 0x63, 0x4b, 0x8d, 0x5d, 0xaa,
+       0x88, 0x4a, 0x47, 0x48, 0xd4, 0xea, 0xab, 0x7d,
+       0x6a, 0xbf, 0xe1, 0x28, 0x99, 0x6a, 0x87, 0x1c,
+       0x30, 0xb4, 0x44, 0x2d, 0x75, 0xac, 0x35, 0x09,
+       0x73, 0x24, 0x3d, 0xb4, 0x43, 0xb1, 0xc1, 0x56,
+       0x56, 0xad, 0x30, 0x87, 0xf4, 0xc3, 0x00, 0xc7
 };
 
 
+static void dpp_debug_print_point(const char *title, const EC_GROUP *group,
+                                 const EC_POINT *point)
+{
+       BIGNUM *x, *y;
+       BN_CTX *ctx;
+       char *x_str = NULL, *y_str = NULL;
+
+       if (!wpa_debug_show_keys)
+               return;
+
+       ctx = BN_CTX_new();
+       x = BN_new();
+       y = BN_new();
+       if (!ctx || !x || !y ||
+           EC_POINT_get_affine_coordinates_GFp(group, point, x, y, ctx) != 1)
+               goto fail;
+
+       x_str = BN_bn2hex(x);
+       y_str = BN_bn2hex(y);
+       if (!x_str || !y_str)
+               goto fail;
+
+       wpa_printf(MSG_DEBUG, "%s (%s,%s)", title, x_str, y_str);
+
+fail:
+       OPENSSL_free(x_str);
+       OPENSSL_free(y_str);
+       BN_free(x);
+       BN_free(y);
+       BN_CTX_free(ctx);
+}
+
+
 static int dpp_hash_vector(const struct dpp_curve_params *curve,
                           size_t num_elem, const u8 *addr[], const size_t *len,
                           u8 *mac)
@@ -339,6 +451,20 @@ static int dpp_hmac(size_t hash_len, const u8 *key, size_t key_len,
 }
 
 
+static int dpp_bn2bin_pad(const BIGNUM *bn, u8 *pos, size_t len)
+{
+       int num_bytes, offset;
+
+       num_bytes = BN_num_bytes(bn);
+       if ((size_t) num_bytes > len)
+               return -1;
+       offset = len - num_bytes;
+       os_memset(pos, 0, offset);
+       BN_bn2bin(bn, pos + offset);
+       return 0;
+}
+
+
 static struct wpabuf * dpp_get_pubkey_point(EVP_PKEY *pkey, int prefix)
 {
        int len, res;
@@ -422,6 +548,7 @@ static EVP_PKEY * dpp_set_pubkey_point_group(const EC_GROUP *group,
                wpa_printf(MSG_ERROR, "DPP: Invalid point");
                goto fail;
        }
+       dpp_debug_print_point("DPP: dpp_set_pubkey_point_group", group, point);
 
        eckey = EC_KEY_new();
        if (!eckey ||
@@ -749,7 +876,9 @@ static int dpp_parse_uri_pk(struct dpp_bootstrap_info *bi, const char *info)
        const unsigned char *pk;
        int ppklen;
        X509_ALGOR *pa;
-#if OPENSSL_VERSION_NUMBER < 0x10100000L
+#if OPENSSL_VERSION_NUMBER < 0x10100000L || \
+       (defined(LIBRESSL_VERSION_NUMBER) && \
+        LIBRESSL_VERSION_NUMBER < 0x20800000L)
        ASN1_OBJECT *pa_oid;
 #else
        const ASN1_OBJECT *pa_oid;
@@ -776,6 +905,7 @@ static int dpp_parse_uri_pk(struct dpp_bootstrap_info *bi, const char *info)
        if (sha256_vector(1, (const u8 **) &data, &data_len,
                          bi->pubkey_hash) < 0) {
                wpa_printf(MSG_DEBUG, "DPP: Failed to hash public key");
+               os_free(data);
                return -1;
        }
        wpa_hexdump(MSG_DEBUG, "DPP: Public key hash",
@@ -957,6 +1087,8 @@ static void dpp_debug_print_key(const char *title, EVP_PKEY *key)
        int res;
        unsigned char *der = NULL;
        int der_len;
+       const EC_GROUP *group;
+       const EC_POINT *point;
 
        out = BIO_new(BIO_s_mem());
        if (!out)
@@ -979,6 +1111,11 @@ static void dpp_debug_print_key(const char *title, EVP_PKEY *key)
        if (!eckey)
                return;
 
+       group = EC_KEY_get0_group(eckey);
+       point = EC_KEY_get0_public_key(eckey);
+       if (group && point)
+               dpp_debug_print_point(title, group, point);
+
        der_len = i2d_ECPrivateKey(eckey, &der);
        if (der_len > 0)
                wpa_hexdump_key(MSG_DEBUG, "DPP: ECPrivateKey", der, der_len);
@@ -997,13 +1134,8 @@ static void dpp_debug_print_key(const char *title, EVP_PKEY *key)
 
 static EVP_PKEY * dpp_gen_keypair(const struct dpp_curve_params *curve)
 {
-#ifdef OPENSSL_IS_BORINGSSL
        EVP_PKEY_CTX *kctx = NULL;
-       const EC_GROUP *group;
-       EC_KEY *ec_params;
-#else
-       EVP_PKEY_CTX *pctx, *kctx = NULL;
-#endif
+       EC_KEY *ec_params = NULL;
        EVP_PKEY *params = NULL, *key = NULL;
        int nid;
 
@@ -1014,10 +1146,9 @@ static EVP_PKEY * dpp_gen_keypair(const struct dpp_curve_params *curve)
                wpa_printf(MSG_INFO, "DPP: Unsupported curve %s", curve->name);
                return NULL;
        }
-#ifdef OPENSSL_IS_BORINGSSL
-       group = EC_GROUP_new_by_curve_name(nid);
-       ec_params = EC_KEY_new();
-       if (!ec_params || EC_KEY_set_group(ec_params, group) != 1) {
+
+       ec_params = EC_KEY_new_by_curve_name(nid);
+       if (!ec_params) {
                wpa_printf(MSG_ERROR,
                           "DPP: Failed to generate EC_KEY parameters");
                goto fail;
@@ -1029,39 +1160,24 @@ static EVP_PKEY * dpp_gen_keypair(const struct dpp_curve_params *curve)
                           "DPP: Failed to generate EVP_PKEY parameters");
                goto fail;
        }
-#else
-       pctx = EVP_PKEY_CTX_new_id(EVP_PKEY_EC, NULL);
-       if (!pctx ||
-           EVP_PKEY_paramgen_init(pctx) != 1 ||
-           EVP_PKEY_CTX_set_ec_paramgen_curve_nid(pctx, nid) != 1 ||
-           EVP_PKEY_CTX_set_ec_param_enc(pctx, OPENSSL_EC_NAMED_CURVE) != 1 ||
-           EVP_PKEY_paramgen(pctx, &params) != 1) {
-               wpa_printf(MSG_ERROR,
-                          "DPP: Failed to generate EVP_PKEY parameters");
-               EVP_PKEY_CTX_free(pctx);
-               goto fail;
-       }
-       EVP_PKEY_CTX_free(pctx);
-#endif
 
        kctx = EVP_PKEY_CTX_new(params, NULL);
        if (!kctx ||
            EVP_PKEY_keygen_init(kctx) != 1 ||
            EVP_PKEY_keygen(kctx, &key) != 1) {
                wpa_printf(MSG_ERROR, "DPP: Failed to generate EC key");
+               key = NULL;
                goto fail;
        }
 
        if (wpa_debug_show_keys)
                dpp_debug_print_key("Own generated key", key);
 
+fail:
+       EC_KEY_free(ec_params);
        EVP_PKEY_free(params);
        EVP_PKEY_CTX_free(kctx);
        return key;
-fail:
-       EVP_PKEY_CTX_free(kctx);
-       EVP_PKEY_free(params);
-       return NULL;
 }
 
 
@@ -1139,34 +1255,111 @@ static EVP_PKEY * dpp_set_keypair(const struct dpp_curve_params **curve,
 }
 
 
-int dpp_bootstrap_key_hash(struct dpp_bootstrap_info *bi)
+typedef struct {
+       /* AlgorithmIdentifier ecPublicKey with optional parameters present
+        * as an OID identifying the curve */
+       X509_ALGOR *alg;
+       /* Compressed format public key per ANSI X9.63 */
+       ASN1_BIT_STRING *pub_key;
+} DPP_BOOTSTRAPPING_KEY;
+
+ASN1_SEQUENCE(DPP_BOOTSTRAPPING_KEY) = {
+       ASN1_SIMPLE(DPP_BOOTSTRAPPING_KEY, alg, X509_ALGOR),
+       ASN1_SIMPLE(DPP_BOOTSTRAPPING_KEY, pub_key, ASN1_BIT_STRING)
+} ASN1_SEQUENCE_END(DPP_BOOTSTRAPPING_KEY);
+
+IMPLEMENT_ASN1_FUNCTIONS(DPP_BOOTSTRAPPING_KEY);
+
+
+static struct wpabuf * dpp_bootstrap_key_der(EVP_PKEY *key)
 {
        unsigned char *der = NULL;
        int der_len;
        EC_KEY *eckey;
-       int res;
+       struct wpabuf *ret = NULL;
        size_t len;
+       const EC_GROUP *group;
+       const EC_POINT *point;
+       BN_CTX *ctx;
+       DPP_BOOTSTRAPPING_KEY *bootstrap = NULL;
+       int nid;
 
-       /* Need to get the compressed form of the public key through EC_KEY, so
-        * cannot use the simpler i2d_PUBKEY() here. */
-       eckey = EVP_PKEY_get1_EC_KEY(bi->pubkey);
-       if (!eckey)
-               return -1;
-       EC_KEY_set_conv_form(eckey, POINT_CONVERSION_COMPRESSED);
-       der_len = i2d_EC_PUBKEY(eckey, &der);
-       EC_KEY_free(eckey);
+       ctx = BN_CTX_new();
+       eckey = EVP_PKEY_get1_EC_KEY(key);
+       if (!ctx || !eckey)
+               goto fail;
+
+       group = EC_KEY_get0_group(eckey);
+       point = EC_KEY_get0_public_key(eckey);
+       if (!group || !point)
+               goto fail;
+       dpp_debug_print_point("DPP: bootstrap public key", group, point);
+       nid = EC_GROUP_get_curve_name(group);
+
+       bootstrap = DPP_BOOTSTRAPPING_KEY_new();
+       if (!bootstrap ||
+           X509_ALGOR_set0(bootstrap->alg, OBJ_nid2obj(EVP_PKEY_EC),
+                           V_ASN1_OBJECT, (void *) OBJ_nid2obj(nid)) != 1)
+               goto fail;
+
+       len = EC_POINT_point2oct(group, point, POINT_CONVERSION_COMPRESSED,
+                                NULL, 0, ctx);
+       if (len == 0)
+               goto fail;
+
+       der = OPENSSL_malloc(len);
+       if (!der)
+               goto fail;
+       len = EC_POINT_point2oct(group, point, POINT_CONVERSION_COMPRESSED,
+                                der, len, ctx);
+
+       OPENSSL_free(bootstrap->pub_key->data);
+       bootstrap->pub_key->data = der;
+       der = NULL;
+       bootstrap->pub_key->length = len;
+       /* No unused bits */
+       bootstrap->pub_key->flags &= ~(ASN1_STRING_FLAG_BITS_LEFT | 0x07);
+       bootstrap->pub_key->flags |= ASN1_STRING_FLAG_BITS_LEFT;
+
+       der_len = i2d_DPP_BOOTSTRAPPING_KEY(bootstrap, &der);
        if (der_len <= 0) {
                wpa_printf(MSG_ERROR,
                           "DDP: Failed to build DER encoded public key");
-               OPENSSL_free(der);
-               return -1;
+               goto fail;
        }
 
-       len = der_len;
-       res = sha256_vector(1, (const u8 **) &der, &len, bi->pubkey_hash);
+       ret = wpabuf_alloc_copy(der, der_len);
+fail:
+       DPP_BOOTSTRAPPING_KEY_free(bootstrap);
        OPENSSL_free(der);
+       EC_KEY_free(eckey);
+       BN_CTX_free(ctx);
+       return ret;
+}
+
+
+int dpp_bootstrap_key_hash(struct dpp_bootstrap_info *bi)
+{
+       struct wpabuf *der;
+       int res;
+       const u8 *addr[1];
+       size_t len[1];
+
+       der = dpp_bootstrap_key_der(bi->pubkey);
+       if (!der)
+               return -1;
+       wpa_hexdump_buf(MSG_DEBUG, "DPP: Compressed public key (DER)",
+                       der);
+
+       addr[0] = wpabuf_head(der);
+       len[0] = wpabuf_len(der);
+       res = sha256_vector(1, addr, len, bi->pubkey_hash);
        if (res < 0)
                wpa_printf(MSG_DEBUG, "DPP: Failed to hash public key");
+       else
+               wpa_hexdump(MSG_DEBUG, "DPP: Public key hash", bi->pubkey_hash,
+                           SHA256_MAC_LEN);
+       wpabuf_free(der);
        return res;
 }
 
@@ -1177,9 +1370,9 @@ char * dpp_keygen(struct dpp_bootstrap_info *bi, const char *curve,
        unsigned char *base64 = NULL;
        char *pos, *end;
        size_t len;
-       unsigned char *der = NULL;
-       int der_len;
-       EC_KEY *eckey;
+       struct wpabuf *der = NULL;
+       const u8 *addr[1];
+       int res;
 
        if (!curve) {
                bi->curve = &dpp_curves[0];
@@ -1199,28 +1392,24 @@ char * dpp_keygen(struct dpp_bootstrap_info *bi, const char *curve,
                goto fail;
        bi->own = 1;
 
-       /* Need to get the compressed form of the public key through EC_KEY, so
-        * cannot use the simpler i2d_PUBKEY() here. */
-       eckey = EVP_PKEY_get1_EC_KEY(bi->pubkey);
-       if (!eckey)
-               goto fail;
-       EC_KEY_set_conv_form(eckey, POINT_CONVERSION_COMPRESSED);
-       der_len = i2d_EC_PUBKEY(eckey, &der);
-       EC_KEY_free(eckey);
-       if (der_len <= 0) {
-               wpa_printf(MSG_ERROR,
-                          "DDP: Failed to build DER encoded public key");
+       der = dpp_bootstrap_key_der(bi->pubkey);
+       if (!der)
                goto fail;
-       }
+       wpa_hexdump_buf(MSG_DEBUG, "DPP: Compressed public key (DER)",
+                       der);
 
-       len = der_len;
-       if (sha256_vector(1, (const u8 **) &der, &len, bi->pubkey_hash) < 0) {
+       addr[0] = wpabuf_head(der);
+       len = wpabuf_len(der);
+       res = sha256_vector(1, addr, &len, bi->pubkey_hash);
+       if (res < 0) {
                wpa_printf(MSG_DEBUG, "DPP: Failed to hash public key");
                goto fail;
        }
+       wpa_hexdump(MSG_DEBUG, "DPP: Public key hash", bi->pubkey_hash,
+                   SHA256_MAC_LEN);
 
-       base64 = base64_encode(der, der_len, &len);
-       OPENSSL_free(der);
+       base64 = base64_encode(wpabuf_head(der), wpabuf_len(der), &len);
+       wpabuf_free(der);
        der = NULL;
        if (!base64)
                goto fail;
@@ -1235,7 +1424,7 @@ char * dpp_keygen(struct dpp_bootstrap_info *bi, const char *curve,
        return (char *) base64;
 fail:
        os_free(base64);
-       OPENSSL_free(der);
+       wpabuf_free(der);
        return NULL;
 }
 
@@ -1309,6 +1498,12 @@ static int dpp_derive_ke(struct dpp_authentication *auth, u8 *ke,
        size_t len[3];
        size_t num_elem = 0;
 
+       if (!auth->Mx_len || !auth->Nx_len) {
+               wpa_printf(MSG_DEBUG,
+                          "DPP: Mx/Nx not available - cannot derive ke");
+               return -1;
+       }
+
        /* ke = HKDF(I-nonce | R-nonce, "DPP Key", M.x | N.x [| L.x]) */
 
        /* HKDF-Extract(I-nonce | R-nonce, M.x | N.x [| L.x]) */
@@ -1316,12 +1511,17 @@ static int dpp_derive_ke(struct dpp_authentication *auth, u8 *ke,
        os_memcpy(nonces, auth->i_nonce, nonce_len);
        os_memcpy(&nonces[nonce_len], auth->r_nonce, nonce_len);
        addr[num_elem] = auth->Mx;
-       len[num_elem] = auth->secret_len;
+       len[num_elem] = auth->Mx_len;
        num_elem++;
        addr[num_elem] = auth->Nx;
-       len[num_elem] = auth->secret_len;
+       len[num_elem] = auth->Nx_len;
        num_elem++;
        if (auth->peer_bi && auth->own_bi) {
+               if (!auth->Lx_len) {
+                       wpa_printf(MSG_DEBUG,
+                                  "DPP: Lx not available - cannot derive ke");
+                       return -1;
+               }
                addr[num_elem] = auth->Lx;
                len[num_elem] = auth->secret_len;
                num_elem++;
@@ -1345,11 +1545,46 @@ static int dpp_derive_ke(struct dpp_authentication *auth, u8 *ke,
 }
 
 
+static void dpp_build_attr_status(struct wpabuf *msg,
+                                 enum dpp_status_error status)
+{
+       wpa_printf(MSG_DEBUG, "DPP: Status %d", status);
+       wpabuf_put_le16(msg, DPP_ATTR_STATUS);
+       wpabuf_put_le16(msg, 1);
+       wpabuf_put_u8(msg, status);
+}
+
+
+static void dpp_build_attr_r_bootstrap_key_hash(struct wpabuf *msg,
+                                               const u8 *hash)
+{
+       if (hash) {
+               wpa_printf(MSG_DEBUG, "DPP: R-Bootstrap Key Hash");
+               wpabuf_put_le16(msg, DPP_ATTR_R_BOOTSTRAP_KEY_HASH);
+               wpabuf_put_le16(msg, SHA256_MAC_LEN);
+               wpabuf_put_data(msg, hash, SHA256_MAC_LEN);
+       }
+}
+
+
+static void dpp_build_attr_i_bootstrap_key_hash(struct wpabuf *msg,
+                                               const u8 *hash)
+{
+       if (hash) {
+               wpa_printf(MSG_DEBUG, "DPP: I-Bootstrap Key Hash");
+               wpabuf_put_le16(msg, DPP_ATTR_I_BOOTSTRAP_KEY_HASH);
+               wpabuf_put_le16(msg, SHA256_MAC_LEN);
+               wpabuf_put_data(msg, hash, SHA256_MAC_LEN);
+       }
+}
+
+
 static struct wpabuf * dpp_auth_build_req(struct dpp_authentication *auth,
                                          const struct wpabuf *pi,
                                          size_t nonce_len,
                                          const u8 *r_pubkey_hash,
-                                         const u8 *i_pubkey_hash)
+                                         const u8 *i_pubkey_hash,
+                                         unsigned int neg_freq)
 {
        struct wpabuf *msg;
        u8 clear[4 + DPP_MAX_NONCE_LEN + 4 + 1];
@@ -1362,9 +1597,14 @@ static struct wpabuf * dpp_auth_build_req(struct dpp_authentication *auth,
        /* Build DPP Authentication Request frame attributes */
        attr_len = 2 * (4 + SHA256_MAC_LEN) + 4 + (pi ? wpabuf_len(pi) : 0) +
                4 + sizeof(wrapped_data);
+       if (neg_freq > 0)
+               attr_len += 4 + 2;
+#ifdef CONFIG_DPP2
+       attr_len += 5;
+#endif /* CONFIG_DPP2 */
 #ifdef CONFIG_TESTING_OPTIONS
        if (dpp_test == DPP_TEST_AFTER_WRAPPED_DATA_AUTH_REQ)
-               attr_len += 4;
+               attr_len += 5;
 #endif /* CONFIG_TESTING_OPTIONS */
        msg = dpp_alloc_msg(DPP_PA_AUTHENTICATION_REQ, attr_len);
        if (!msg)
@@ -1373,18 +1613,10 @@ static struct wpabuf * dpp_auth_build_req(struct dpp_authentication *auth,
        attr_start = wpabuf_put(msg, 0);
 
        /* Responder Bootstrapping Key Hash */
-       if (r_pubkey_hash) {
-               wpabuf_put_le16(msg, DPP_ATTR_R_BOOTSTRAP_KEY_HASH);
-               wpabuf_put_le16(msg, SHA256_MAC_LEN);
-               wpabuf_put_data(msg, r_pubkey_hash, SHA256_MAC_LEN);
-       }
+       dpp_build_attr_r_bootstrap_key_hash(msg, r_pubkey_hash);
 
        /* Initiator Bootstrapping Key Hash */
-       if (i_pubkey_hash) {
-               wpabuf_put_le16(msg, DPP_ATTR_I_BOOTSTRAP_KEY_HASH);
-               wpabuf_put_le16(msg, SHA256_MAC_LEN);
-               wpabuf_put_data(msg, i_pubkey_hash, SHA256_MAC_LEN);
-       }
+       dpp_build_attr_i_bootstrap_key_hash(msg, i_pubkey_hash);
 
        /* Initiator Protocol Key */
        if (pi) {
@@ -1393,6 +1625,32 @@ static struct wpabuf * dpp_auth_build_req(struct dpp_authentication *auth,
                wpabuf_put_buf(msg, pi);
        }
 
+       /* Channel */
+       if (neg_freq > 0) {
+               u8 op_class, channel;
+
+               if (ieee80211_freq_to_channel_ext(neg_freq, 0, 0, &op_class,
+                                                 &channel) ==
+                   NUM_HOSTAPD_MODES) {
+                       wpa_printf(MSG_INFO,
+                                  "DPP: Unsupported negotiation frequency request: %d",
+                                  neg_freq);
+                       wpabuf_free(msg);
+                       return NULL;
+               }
+               wpabuf_put_le16(msg, DPP_ATTR_CHANNEL);
+               wpabuf_put_le16(msg, 2);
+               wpabuf_put_u8(msg, op_class);
+               wpabuf_put_u8(msg, channel);
+       }
+
+#ifdef CONFIG_DPP2
+       /* Protocol Version */
+       wpabuf_put_le16(msg, DPP_ATTR_PROTOCOL_VERSION);
+       wpabuf_put_le16(msg, 1);
+       wpabuf_put_u8(msg, 2);
+#endif /* CONFIG_DPP2 */
+
 #ifdef CONFIG_TESTING_OPTIONS
        if (dpp_test == DPP_TEST_NO_WRAPPED_DATA_AUTH_REQ) {
                wpa_printf(MSG_INFO, "DPP: TESTING - no Wrapped Data");
@@ -1408,6 +1666,16 @@ static struct wpabuf * dpp_auth_build_req(struct dpp_authentication *auth,
                wpa_printf(MSG_INFO, "DPP: TESTING - no I-nonce");
                goto skip_i_nonce;
        }
+       if (dpp_test == DPP_TEST_INVALID_I_NONCE_AUTH_REQ) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - invalid I-nonce");
+               WPA_PUT_LE16(pos, DPP_ATTR_I_NONCE);
+               pos += 2;
+               WPA_PUT_LE16(pos, nonce_len - 1);
+               pos += 2;
+               os_memcpy(pos, auth->i_nonce, nonce_len - 1);
+               pos += nonce_len - 1;
+               goto skip_i_nonce;
+       }
 #endif /* CONFIG_TESTING_OPTIONS */
 
        /* I-nonce */
@@ -1431,8 +1699,7 @@ skip_i_nonce:
        pos += 2;
        WPA_PUT_LE16(pos, 1);
        pos += 2;
-       auth->i_capab = auth->configurator ? DPP_CAPAB_CONFIGURATOR :
-               DPP_CAPAB_ENROLLEE;
+       auth->i_capab = auth->allowed_roles;
        *pos++ = auth->i_capab;
 #ifdef CONFIG_TESTING_OPTIONS
        if (dpp_test == DPP_TEST_ZERO_I_CAPAB) {
@@ -1472,8 +1739,7 @@ skip_i_capab:
 #ifdef CONFIG_TESTING_OPTIONS
        if (dpp_test == DPP_TEST_AFTER_WRAPPED_DATA_AUTH_REQ) {
                wpa_printf(MSG_INFO, "DPP: TESTING - attr after Wrapped Data");
-               wpabuf_put_le16(msg, DPP_ATTR_TESTING);
-               wpabuf_put_le16(msg, 0);
+               dpp_build_attr_status(msg, DPP_STATUS_OK);
        }
 skip_wrapped_data:
 #endif /* CONFIG_TESTING_OPTIONS */
@@ -1505,42 +1771,34 @@ static struct wpabuf * dpp_auth_build_resp(struct dpp_authentication *auth,
        size_t len[2], siv_len, attr_len;
        u8 *attr_start, *attr_end, *pos;
 
+       auth->waiting_auth_conf = 1;
+       auth->auth_resp_tries = 0;
+
        /* Build DPP Authentication Response frame attributes */
        attr_len = 4 + 1 + 2 * (4 + SHA256_MAC_LEN) +
                4 + (pr ? wpabuf_len(pr) : 0) + 4 + sizeof(wrapped_data);
+#ifdef CONFIG_DPP2
+       attr_len += 5;
+#endif /* CONFIG_DPP2 */
 #ifdef CONFIG_TESTING_OPTIONS
        if (dpp_test == DPP_TEST_AFTER_WRAPPED_DATA_AUTH_RESP)
-               attr_len += 4;
+               attr_len += 5;
 #endif /* CONFIG_TESTING_OPTIONS */
        msg = dpp_alloc_msg(DPP_PA_AUTHENTICATION_RESP, attr_len);
        if (!msg)
                return NULL;
-       wpabuf_free(auth->resp_msg);
 
        attr_start = wpabuf_put(msg, 0);
 
        /* DPP Status */
-       if (status != 255) {
-               wpa_printf(MSG_DEBUG, "DPP: Status %d", status);
-               wpabuf_put_le16(msg, DPP_ATTR_STATUS);
-               wpabuf_put_le16(msg, 1);
-               wpabuf_put_u8(msg, status);
-       }
+       if (status != 255)
+               dpp_build_attr_status(msg, status);
 
        /* Responder Bootstrapping Key Hash */
-       if (r_pubkey_hash) {
-               wpabuf_put_le16(msg, DPP_ATTR_R_BOOTSTRAP_KEY_HASH);
-               wpabuf_put_le16(msg, SHA256_MAC_LEN);
-               wpabuf_put_data(msg, r_pubkey_hash, SHA256_MAC_LEN);
-       }
+       dpp_build_attr_r_bootstrap_key_hash(msg, r_pubkey_hash);
 
-       /* Initiator Bootstrapping Key Hash */
-       if (i_pubkey_hash) {
-               /* Mutual authentication */
-               wpabuf_put_le16(msg, DPP_ATTR_I_BOOTSTRAP_KEY_HASH);
-               wpabuf_put_le16(msg, SHA256_MAC_LEN);
-               wpabuf_put_data(msg, i_pubkey_hash, SHA256_MAC_LEN);
-       }
+       /* Initiator Bootstrapping Key Hash (mutual authentication) */
+       dpp_build_attr_i_bootstrap_key_hash(msg, i_pubkey_hash);
 
        /* Responder Protocol Key */
        if (pr) {
@@ -1549,6 +1807,13 @@ static struct wpabuf * dpp_auth_build_resp(struct dpp_authentication *auth,
                wpabuf_put_buf(msg, pr);
        }
 
+#ifdef CONFIG_DPP2
+       /* Protocol Version */
+       wpabuf_put_le16(msg, DPP_ATTR_PROTOCOL_VERSION);
+       wpabuf_put_le16(msg, 1);
+       wpabuf_put_u8(msg, 2);
+#endif /* CONFIG_DPP2 */
+
        attr_end = wpabuf_put(msg, 0);
 
 #ifdef CONFIG_TESTING_OPTIONS
@@ -1609,8 +1874,12 @@ static struct wpabuf * dpp_auth_build_resp(struct dpp_authentication *auth,
        } else if (dpp_test == DPP_TEST_INCOMPATIBLE_R_CAPAB_AUTH_RESP) {
                wpa_printf(MSG_INFO,
                           "DPP: TESTING - incompatible R-capabilities");
-               pos[-1] = auth->configurator ? DPP_CAPAB_ENROLLEE :
-                       DPP_CAPAB_CONFIGURATOR;
+               if ((auth->i_capab & DPP_CAPAB_ROLE_MASK) ==
+                   (DPP_CAPAB_CONFIGURATOR | DPP_CAPAB_ENROLLEE))
+                       pos[-1] = 0;
+               else
+                       pos[-1] = auth->configurator ? DPP_CAPAB_ENROLLEE :
+                               DPP_CAPAB_CONFIGURATOR;
        }
 skip_r_capab:
 #endif /* CONFIG_TESTING_OPTIONS */
@@ -1653,8 +1922,7 @@ skip_r_capab:
 #ifdef CONFIG_TESTING_OPTIONS
        if (dpp_test == DPP_TEST_AFTER_WRAPPED_DATA_AUTH_RESP) {
                wpa_printf(MSG_INFO, "DPP: TESTING - attr after Wrapped Data");
-               wpabuf_put_le16(msg, DPP_ATTR_TESTING);
-               wpabuf_put_le16(msg, 0);
+               dpp_build_attr_status(msg, DPP_STATUS_OK);
        }
 skip_wrapped_data:
 #endif /* CONFIG_TESTING_OPTIONS */
@@ -1665,93 +1933,343 @@ skip_wrapped_data:
 }
 
 
-struct dpp_authentication * dpp_auth_init(void *msg_ctx,
-                                         struct dpp_bootstrap_info *peer_bi,
-                                         struct dpp_bootstrap_info *own_bi,
-                                         int configurator)
+static int dpp_channel_ok_init(struct hostapd_hw_modes *own_modes,
+                              u16 num_modes, unsigned int freq)
 {
-       struct dpp_authentication *auth;
-       size_t nonce_len;
-       EVP_PKEY_CTX *ctx = NULL;
-       size_t secret_len;
-       struct wpabuf *pi = NULL;
-       u8 zero[SHA256_MAC_LEN];
-       const u8 *r_pubkey_hash, *i_pubkey_hash;
+       u16 m;
+       int c, flag;
 
-       auth = os_zalloc(sizeof(*auth));
-       if (!auth)
-               return NULL;
-       auth->msg_ctx = msg_ctx;
-       auth->initiator = 1;
-       auth->configurator = configurator;
-       auth->peer_bi = peer_bi;
-       auth->own_bi = own_bi;
-       auth->curve = peer_bi->curve;
+       if (!own_modes || !num_modes)
+               return 1;
 
-       nonce_len = auth->curve->nonce_len;
-       if (random_get_bytes(auth->i_nonce, nonce_len)) {
-               wpa_printf(MSG_ERROR, "DPP: Failed to generate I-nonce");
-               goto fail;
+       for (m = 0; m < num_modes; m++) {
+               for (c = 0; c < own_modes[m].num_channels; c++) {
+                       if ((unsigned int) own_modes[m].channels[c].freq !=
+                           freq)
+                               continue;
+                       flag = own_modes[m].channels[c].flag;
+                       if (!(flag & (HOSTAPD_CHAN_DISABLED |
+                                     HOSTAPD_CHAN_NO_IR |
+                                     HOSTAPD_CHAN_RADAR)))
+                               return 1;
+               }
        }
-       wpa_hexdump(MSG_DEBUG, "DPP: I-nonce", auth->i_nonce, nonce_len);
 
-       auth->own_protocol_key = dpp_gen_keypair(auth->curve);
-       if (!auth->own_protocol_key)
-               goto fail;
+       wpa_printf(MSG_DEBUG, "DPP: Peer channel %u MHz not supported", freq);
+       return 0;
+}
 
-       pi = dpp_get_pubkey_point(auth->own_protocol_key, 0);
-       if (!pi)
-               goto fail;
 
-       /* ECDH: M = pI * BR */
-       ctx = EVP_PKEY_CTX_new(auth->own_protocol_key, NULL);
-       if (!ctx ||
-           EVP_PKEY_derive_init(ctx) != 1 ||
-           EVP_PKEY_derive_set_peer(ctx, auth->peer_bi->pubkey) != 1 ||
-           EVP_PKEY_derive(ctx, NULL, &secret_len) != 1 ||
-           secret_len > DPP_MAX_SHARED_SECRET_LEN ||
-           EVP_PKEY_derive(ctx, auth->Mx, &secret_len) != 1) {
-               wpa_printf(MSG_ERROR,
-                          "DPP: Failed to derive ECDH shared secret: %s",
-                          ERR_error_string(ERR_get_error(), NULL));
-               goto fail;
+static int freq_included(const unsigned int freqs[], unsigned int num,
+                        unsigned int freq)
+{
+       while (num > 0) {
+               if (freqs[--num] == freq)
+                       return 1;
        }
-       auth->secret_len = secret_len;
-       EVP_PKEY_CTX_free(ctx);
-       ctx = NULL;
+       return 0;
+}
 
-       wpa_hexdump_key(MSG_DEBUG, "DPP: ECDH shared secret (M.x)",
-                       auth->Mx, auth->secret_len);
 
-       if (dpp_derive_k1(auth->Mx, auth->secret_len, auth->k1,
-                         auth->curve->hash_len) < 0)
-               goto fail;
+static void freq_to_start(unsigned int freqs[], unsigned int num,
+                         unsigned int freq)
+{
+       unsigned int i;
 
-       r_pubkey_hash = auth->peer_bi->pubkey_hash;
+       for (i = 0; i < num; i++) {
+               if (freqs[i] == freq)
+                       break;
+       }
+       if (i == 0 || i >= num)
+               return;
+       os_memmove(&freqs[1], &freqs[0], i * sizeof(freqs[0]));
+       freqs[0] = freq;
+}
 
-       if (auth->own_bi) {
-               i_pubkey_hash = auth->own_bi->pubkey_hash;
-       } else {
-               os_memset(zero, 0, SHA256_MAC_LEN);
-               i_pubkey_hash = zero;
+
+static int dpp_channel_intersect(struct dpp_authentication *auth,
+                                struct hostapd_hw_modes *own_modes,
+                                u16 num_modes)
+{
+       struct dpp_bootstrap_info *peer_bi = auth->peer_bi;
+       unsigned int i, freq;
+
+       for (i = 0; i < peer_bi->num_freq; i++) {
+               freq = peer_bi->freq[i];
+               if (freq_included(auth->freq, auth->num_freq, freq))
+                       continue;
+               if (dpp_channel_ok_init(own_modes, num_modes, freq))
+                       auth->freq[auth->num_freq++] = freq;
+       }
+       if (!auth->num_freq) {
+               wpa_printf(MSG_INFO,
+                          "DPP: No available channels for initiating DPP Authentication");
+               return -1;
        }
+       auth->curr_freq = auth->freq[0];
+       return 0;
+}
+
+
+static int dpp_channel_local_list(struct dpp_authentication *auth,
+                                 struct hostapd_hw_modes *own_modes,
+                                 u16 num_modes)
+{
+       u16 m;
+       int c, flag;
+       unsigned int freq;
+
+       auth->num_freq = 0;
+
+       if (!own_modes || !num_modes) {
+               auth->freq[0] = 2412;
+               auth->freq[1] = 2437;
+               auth->freq[2] = 2462;
+               auth->num_freq = 3;
+               return 0;
+       }
+
+       for (m = 0; m < num_modes; m++) {
+               for (c = 0; c < own_modes[m].num_channels; c++) {
+                       freq = own_modes[m].channels[c].freq;
+                       flag = own_modes[m].channels[c].flag;
+                       if (flag & (HOSTAPD_CHAN_DISABLED |
+                                   HOSTAPD_CHAN_NO_IR |
+                                   HOSTAPD_CHAN_RADAR))
+                               continue;
+                       if (freq_included(auth->freq, auth->num_freq, freq))
+                               continue;
+                       auth->freq[auth->num_freq++] = freq;
+                       if (auth->num_freq == DPP_BOOTSTRAP_MAX_FREQ) {
+                               m = num_modes;
+                               break;
+                       }
+               }
+       }
+
+       return auth->num_freq == 0 ? -1 : 0;
+}
+
+
+static int dpp_prepare_channel_list(struct dpp_authentication *auth,
+                                   struct hostapd_hw_modes *own_modes,
+                                   u16 num_modes)
+{
+       int res;
+       char freqs[DPP_BOOTSTRAP_MAX_FREQ * 6 + 10], *pos, *end;
+       unsigned int i;
+
+       if (auth->peer_bi->num_freq > 0)
+               res = dpp_channel_intersect(auth, own_modes, num_modes);
+       else
+               res = dpp_channel_local_list(auth, own_modes, num_modes);
+       if (res < 0)
+               return res;
+
+       /* Prioritize 2.4 GHz channels 6, 1, 11 (in this order) to hit the most
+        * likely channels first. */
+       freq_to_start(auth->freq, auth->num_freq, 2462);
+       freq_to_start(auth->freq, auth->num_freq, 2412);
+       freq_to_start(auth->freq, auth->num_freq, 2437);
+
+       auth->freq_idx = 0;
+       auth->curr_freq = auth->freq[0];
+
+       pos = freqs;
+       end = pos + sizeof(freqs);
+       for (i = 0; i < auth->num_freq; i++) {
+               res = os_snprintf(pos, end - pos, " %u", auth->freq[i]);
+               if (os_snprintf_error(end - pos, res))
+                       break;
+               pos += res;
+       }
+       *pos = '\0';
+       wpa_printf(MSG_DEBUG, "DPP: Possible frequencies for initiating:%s",
+                  freqs);
+
+       return 0;
+}
+
+
+static int dpp_autogen_bootstrap_key(struct dpp_authentication *auth)
+{
+       struct dpp_bootstrap_info *bi;
+       char *pk = NULL;
+       size_t len;
+
+       if (auth->own_bi)
+               return 0; /* already generated */
+
+       bi = os_zalloc(sizeof(*bi));
+       if (!bi)
+               return -1;
+       bi->type = DPP_BOOTSTRAP_QR_CODE;
+       pk = dpp_keygen(bi, auth->peer_bi->curve->name, NULL, 0);
+       if (!pk)
+               goto fail;
+
+       len = 4; /* "DPP:" */
+       len += 4 + os_strlen(pk);
+       bi->uri = os_malloc(len + 1);
+       if (!bi->uri)
+               goto fail;
+       os_snprintf(bi->uri, len + 1, "DPP:K:%s;;", pk);
+       wpa_printf(MSG_DEBUG,
+                  "DPP: Auto-generated own bootstrapping key info: URI %s",
+                  bi->uri);
+
+       auth->tmp_own_bi = auth->own_bi = bi;
+
+       os_free(pk);
+
+       return 0;
+fail:
+       os_free(pk);
+       dpp_bootstrap_info_free(bi);
+       return -1;
+}
+
+
+struct dpp_authentication * dpp_auth_init(void *msg_ctx,
+                                         struct dpp_bootstrap_info *peer_bi,
+                                         struct dpp_bootstrap_info *own_bi,
+                                         u8 dpp_allowed_roles,
+                                         unsigned int neg_freq,
+                                         struct hostapd_hw_modes *own_modes,
+                                         u16 num_modes)
+{
+       struct dpp_authentication *auth;
+       size_t nonce_len;
+       EVP_PKEY_CTX *ctx = NULL;
+       size_t secret_len;
+       struct wpabuf *pi = NULL;
+       const u8 *r_pubkey_hash, *i_pubkey_hash;
+#ifdef CONFIG_TESTING_OPTIONS
+       u8 test_hash[SHA256_MAC_LEN];
+#endif /* CONFIG_TESTING_OPTIONS */
+
+       auth = os_zalloc(sizeof(*auth));
+       if (!auth)
+               return NULL;
+       auth->msg_ctx = msg_ctx;
+       auth->initiator = 1;
+       auth->waiting_auth_resp = 1;
+       auth->allowed_roles = dpp_allowed_roles;
+       auth->configurator = !!(dpp_allowed_roles & DPP_CAPAB_CONFIGURATOR);
+       auth->peer_bi = peer_bi;
+       auth->own_bi = own_bi;
+       auth->curve = peer_bi->curve;
+
+       if (dpp_autogen_bootstrap_key(auth) < 0 ||
+           dpp_prepare_channel_list(auth, own_modes, num_modes) < 0)
+               goto fail;
+
+#ifdef CONFIG_TESTING_OPTIONS
+       if (dpp_nonce_override_len > 0) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - override I-nonce");
+               nonce_len = dpp_nonce_override_len;
+               os_memcpy(auth->i_nonce, dpp_nonce_override, nonce_len);
+       } else {
+               nonce_len = auth->curve->nonce_len;
+               if (random_get_bytes(auth->i_nonce, nonce_len)) {
+                       wpa_printf(MSG_ERROR,
+                                  "DPP: Failed to generate I-nonce");
+                       goto fail;
+               }
+       }
+#else /* CONFIG_TESTING_OPTIONS */
+       nonce_len = auth->curve->nonce_len;
+       if (random_get_bytes(auth->i_nonce, nonce_len)) {
+               wpa_printf(MSG_ERROR, "DPP: Failed to generate I-nonce");
+               goto fail;
+       }
+#endif /* CONFIG_TESTING_OPTIONS */
+       wpa_hexdump(MSG_DEBUG, "DPP: I-nonce", auth->i_nonce, nonce_len);
+
+#ifdef CONFIG_TESTING_OPTIONS
+       if (dpp_protocol_key_override_len) {
+               const struct dpp_curve_params *tmp_curve;
+
+               wpa_printf(MSG_INFO,
+                          "DPP: TESTING - override protocol key");
+               auth->own_protocol_key = dpp_set_keypair(
+                       &tmp_curve, dpp_protocol_key_override,
+                       dpp_protocol_key_override_len);
+       } else {
+               auth->own_protocol_key = dpp_gen_keypair(auth->curve);
+       }
+#else /* CONFIG_TESTING_OPTIONS */
+       auth->own_protocol_key = dpp_gen_keypair(auth->curve);
+#endif /* CONFIG_TESTING_OPTIONS */
+       if (!auth->own_protocol_key)
+               goto fail;
+
+       pi = dpp_get_pubkey_point(auth->own_protocol_key, 0);
+       if (!pi)
+               goto fail;
+
+       /* ECDH: M = pI * BR */
+       ctx = EVP_PKEY_CTX_new(auth->own_protocol_key, NULL);
+       if (!ctx ||
+           EVP_PKEY_derive_init(ctx) != 1 ||
+           EVP_PKEY_derive_set_peer(ctx, auth->peer_bi->pubkey) != 1 ||
+           EVP_PKEY_derive(ctx, NULL, &secret_len) != 1 ||
+           secret_len > DPP_MAX_SHARED_SECRET_LEN ||
+           EVP_PKEY_derive(ctx, auth->Mx, &secret_len) != 1) {
+               wpa_printf(MSG_ERROR,
+                          "DPP: Failed to derive ECDH shared secret: %s",
+                          ERR_error_string(ERR_get_error(), NULL));
+               goto fail;
+       }
+       auth->secret_len = secret_len;
+       EVP_PKEY_CTX_free(ctx);
+       ctx = NULL;
+
+       wpa_hexdump_key(MSG_DEBUG, "DPP: ECDH shared secret (M.x)",
+                       auth->Mx, auth->secret_len);
+       auth->Mx_len = auth->secret_len;
+
+       if (dpp_derive_k1(auth->Mx, auth->secret_len, auth->k1,
+                         auth->curve->hash_len) < 0)
+               goto fail;
+
+       r_pubkey_hash = auth->peer_bi->pubkey_hash;
+       i_pubkey_hash = auth->own_bi->pubkey_hash;
 
 #ifdef CONFIG_TESTING_OPTIONS
        if (dpp_test == DPP_TEST_NO_R_BOOTSTRAP_KEY_HASH_AUTH_REQ) {
                wpa_printf(MSG_INFO, "DPP: TESTING - no R-Bootstrap Key Hash");
                r_pubkey_hash = NULL;
+       } else if (dpp_test == DPP_TEST_INVALID_R_BOOTSTRAP_KEY_HASH_AUTH_REQ) {
+               wpa_printf(MSG_INFO,
+                          "DPP: TESTING - invalid R-Bootstrap Key Hash");
+               os_memcpy(test_hash, r_pubkey_hash, SHA256_MAC_LEN);
+               test_hash[SHA256_MAC_LEN - 1] ^= 0x01;
+               r_pubkey_hash = test_hash;
        } else if (dpp_test == DPP_TEST_NO_I_BOOTSTRAP_KEY_HASH_AUTH_REQ) {
                wpa_printf(MSG_INFO, "DPP: TESTING - no I-Bootstrap Key Hash");
                i_pubkey_hash = NULL;
+       } else if (dpp_test == DPP_TEST_INVALID_I_BOOTSTRAP_KEY_HASH_AUTH_REQ) {
+               wpa_printf(MSG_INFO,
+                          "DPP: TESTING - invalid I-Bootstrap Key Hash");
+               os_memcpy(test_hash, i_pubkey_hash, SHA256_MAC_LEN);
+               test_hash[SHA256_MAC_LEN - 1] ^= 0x01;
+               i_pubkey_hash = test_hash;
        } else if (dpp_test == DPP_TEST_NO_I_PROTO_KEY_AUTH_REQ) {
                wpa_printf(MSG_INFO, "DPP: TESTING - no I-Proto Key");
                wpabuf_free(pi);
                pi = NULL;
+       } else if (dpp_test == DPP_TEST_INVALID_I_PROTO_KEY_AUTH_REQ) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - invalid I-Proto Key");
+               wpabuf_free(pi);
+               pi = wpabuf_alloc(2 * auth->curve->prime_len);
+               if (!pi || dpp_test_gen_invalid_key(pi, auth->curve) < 0)
+                       goto fail;
        }
 #endif /* CONFIG_TESTING_OPTIONS */
 
        auth->req_msg = dpp_auth_build_req(auth, pi, nonce_len, r_pubkey_hash,
-                                          i_pubkey_hash);
+                                          i_pubkey_hash, neg_freq);
        if (!auth->req_msg)
                goto fail;
 
@@ -1766,8 +2284,8 @@ fail:
 }
 
 
-struct wpabuf * dpp_build_conf_req(struct dpp_authentication *auth,
-                                  const char *json)
+static struct wpabuf * dpp_build_conf_req_attr(struct dpp_authentication *auth,
+                                              const char *json)
 {
        size_t nonce_len;
        size_t json_len, clear_len;
@@ -1792,22 +2310,52 @@ struct wpabuf * dpp_build_conf_req(struct dpp_authentication *auth,
        attr_len = 4 + clear_len + AES_BLOCK_SIZE;
 #ifdef CONFIG_TESTING_OPTIONS
        if (dpp_test == DPP_TEST_AFTER_WRAPPED_DATA_CONF_REQ)
-               attr_len += 4;
+               attr_len += 5;
 #endif /* CONFIG_TESTING_OPTIONS */
        msg = wpabuf_alloc(attr_len);
        if (!clear || !msg)
                goto fail;
 
+#ifdef CONFIG_TESTING_OPTIONS
+       if (dpp_test == DPP_TEST_NO_E_NONCE_CONF_REQ) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - no E-nonce");
+               goto skip_e_nonce;
+       }
+       if (dpp_test == DPP_TEST_INVALID_E_NONCE_CONF_REQ) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - invalid E-nonce");
+               wpabuf_put_le16(clear, DPP_ATTR_ENROLLEE_NONCE);
+               wpabuf_put_le16(clear, nonce_len - 1);
+               wpabuf_put_data(clear, auth->e_nonce, nonce_len - 1);
+               goto skip_e_nonce;
+       }
+       if (dpp_test == DPP_TEST_NO_WRAPPED_DATA_CONF_REQ) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - no Wrapped Data");
+               goto skip_wrapped_data;
+       }
+#endif /* CONFIG_TESTING_OPTIONS */
+
        /* E-nonce */
        wpabuf_put_le16(clear, DPP_ATTR_ENROLLEE_NONCE);
        wpabuf_put_le16(clear, nonce_len);
        wpabuf_put_data(clear, auth->e_nonce, nonce_len);
 
+#ifdef CONFIG_TESTING_OPTIONS
+skip_e_nonce:
+       if (dpp_test == DPP_TEST_NO_CONFIG_ATTR_OBJ_CONF_REQ) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - no configAttrib");
+               goto skip_conf_attr_obj;
+       }
+#endif /* CONFIG_TESTING_OPTIONS */
+
        /* configAttrib */
        wpabuf_put_le16(clear, DPP_ATTR_CONFIG_ATTR_OBJ);
        wpabuf_put_le16(clear, json_len);
        wpabuf_put_data(clear, json, json_len);
 
+#ifdef CONFIG_TESTING_OPTIONS
+skip_conf_attr_obj:
+#endif /* CONFIG_TESTING_OPTIONS */
+
        wpabuf_put_le16(msg, DPP_ATTR_WRAPPED_DATA);
        wpabuf_put_le16(msg, wpabuf_len(clear) + AES_BLOCK_SIZE);
        wrapped = wpabuf_put(msg, wpabuf_len(clear) + AES_BLOCK_SIZE);
@@ -1824,9 +2372,9 @@ struct wpabuf * dpp_build_conf_req(struct dpp_authentication *auth,
 #ifdef CONFIG_TESTING_OPTIONS
        if (dpp_test == DPP_TEST_AFTER_WRAPPED_DATA_CONF_REQ) {
                wpa_printf(MSG_INFO, "DPP: TESTING - attr after Wrapped Data");
-               wpabuf_put_le16(msg, DPP_ATTR_TESTING);
-               wpabuf_put_le16(msg, 0);
+               dpp_build_attr_status(msg, DPP_STATUS_OK);
        }
+skip_wrapped_data:
 #endif /* CONFIG_TESTING_OPTIONS */
 
        wpa_hexdump_buf(MSG_DEBUG,
@@ -1841,13 +2389,65 @@ fail:
 }
 
 
+static void dpp_write_adv_proto(struct wpabuf *buf)
+{
+       /* Advertisement Protocol IE */
+       wpabuf_put_u8(buf, WLAN_EID_ADV_PROTO);
+       wpabuf_put_u8(buf, 8); /* Length */
+       wpabuf_put_u8(buf, 0x7f);
+       wpabuf_put_u8(buf, WLAN_EID_VENDOR_SPECIFIC);
+       wpabuf_put_u8(buf, 5);
+       wpabuf_put_be24(buf, OUI_WFA);
+       wpabuf_put_u8(buf, DPP_OUI_TYPE);
+       wpabuf_put_u8(buf, 0x01);
+}
+
+
+static void dpp_write_gas_query(struct wpabuf *buf, struct wpabuf *query)
+{
+       /* GAS Query */
+       wpabuf_put_le16(buf, wpabuf_len(query));
+       wpabuf_put_buf(buf, query);
+}
+
+
+struct wpabuf * dpp_build_conf_req(struct dpp_authentication *auth,
+                                  const char *json)
+{
+       struct wpabuf *buf, *conf_req;
+
+       conf_req = dpp_build_conf_req_attr(auth, json);
+       if (!conf_req) {
+               wpa_printf(MSG_DEBUG,
+                          "DPP: No configuration request data available");
+               return NULL;
+       }
+
+       buf = gas_build_initial_req(0, 10 + 2 + wpabuf_len(conf_req));
+       if (!buf) {
+               wpabuf_free(conf_req);
+               return NULL;
+       }
+
+       dpp_write_adv_proto(buf);
+       dpp_write_gas_query(buf, conf_req);
+       wpabuf_free(conf_req);
+       wpa_hexdump_buf(MSG_MSGDUMP, "DPP: GAS Config Request", buf);
+
+       return buf;
+}
+
+
 static void dpp_auth_success(struct dpp_authentication *auth)
 {
        wpa_printf(MSG_DEBUG,
                   "DPP: Authentication success - clear temporary keys");
        os_memset(auth->Mx, 0, sizeof(auth->Mx));
+       auth->Mx_len = 0;
        os_memset(auth->Nx, 0, sizeof(auth->Nx));
+       auth->Nx_len = 0;
        os_memset(auth->Lx, 0, sizeof(auth->Lx));
+       auth->Lx_len = 0;
        os_memset(auth->k1, 0, sizeof(auth->k1));
        os_memset(auth->k2, 0, sizeof(auth->k2));
 
@@ -2027,7 +2627,6 @@ static int dpp_auth_derive_l_responder(struct dpp_authentication *auth)
        BIGNUM *lx, *sum, *q;
        const BIGNUM *bR_bn, *pR_bn;
        int ret = -1;
-       int num_bytes, offset;
 
        /* L = ((bR + pR) modulo q) * BI */
 
@@ -2067,17 +2666,10 @@ static int dpp_auth_derive_l_responder(struct dpp_authentication *auth)
                goto fail;
        }
 
-       num_bytes = BN_num_bytes(lx);
-       if ((size_t) num_bytes > auth->secret_len)
+       if (dpp_bn2bin_pad(lx, auth->Lx, auth->secret_len) < 0)
                goto fail;
-       if (auth->secret_len > (size_t) num_bytes)
-               offset = auth->secret_len - num_bytes;
-       else
-               offset = 0;
-
-       os_memset(auth->Lx, 0, offset);
-       BN_bn2bin(lx, auth->Lx + offset);
        wpa_hexdump_key(MSG_DEBUG, "DPP: L.x", auth->Lx, auth->secret_len);
+       auth->Lx_len = auth->secret_len;
        ret = 0;
 fail:
        EC_POINT_clear_free(l);
@@ -2102,7 +2694,6 @@ static int dpp_auth_derive_l_initiator(struct dpp_authentication *auth)
        BIGNUM *lx;
        const BIGNUM *bI_bn;
        int ret = -1;
-       int num_bytes, offset;
 
        /* L = bI * (BR + PR) */
 
@@ -2137,20 +2728,14 @@ static int dpp_auth_derive_l_initiator(struct dpp_authentication *auth)
                goto fail;
        }
 
-       num_bytes = BN_num_bytes(lx);
-       if ((size_t) num_bytes > auth->secret_len)
+       if (dpp_bn2bin_pad(lx, auth->Lx, auth->secret_len) < 0)
                goto fail;
-       if (auth->secret_len > (size_t) num_bytes)
-               offset = auth->secret_len - num_bytes;
-       else
-               offset = 0;
-
-       os_memset(auth->Lx, 0, offset);
-       BN_bn2bin(lx, auth->Lx + offset);
        wpa_hexdump_key(MSG_DEBUG, "DPP: L.x", auth->Lx, auth->secret_len);
+       auth->Lx_len = auth->secret_len;
        ret = 0;
 fail:
        EC_POINT_clear_free(l);
+       EC_POINT_clear_free(sum);
        EC_KEY_free(bI);
        EC_KEY_free(BR);
        EC_KEY_free(PR);
@@ -2172,17 +2757,51 @@ static int dpp_auth_build_resp_ok(struct dpp_authentication *auth)
        int ret = -1;
        const u8 *r_pubkey_hash, *i_pubkey_hash, *r_nonce, *i_nonce;
        enum dpp_status_error status = DPP_STATUS_OK;
+#ifdef CONFIG_TESTING_OPTIONS
+       u8 test_hash[SHA256_MAC_LEN];
+#endif /* CONFIG_TESTING_OPTIONS */
 
        wpa_printf(MSG_DEBUG, "DPP: Build Authentication Response");
+       if (!auth->own_bi)
+               return -1;
 
+#ifdef CONFIG_TESTING_OPTIONS
+       if (dpp_nonce_override_len > 0) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - override R-nonce");
+               nonce_len = dpp_nonce_override_len;
+               os_memcpy(auth->r_nonce, dpp_nonce_override, nonce_len);
+       } else {
+               nonce_len = auth->curve->nonce_len;
+               if (random_get_bytes(auth->r_nonce, nonce_len)) {
+                       wpa_printf(MSG_ERROR,
+                                  "DPP: Failed to generate R-nonce");
+                       goto fail;
+               }
+       }
+#else /* CONFIG_TESTING_OPTIONS */
        nonce_len = auth->curve->nonce_len;
        if (random_get_bytes(auth->r_nonce, nonce_len)) {
                wpa_printf(MSG_ERROR, "DPP: Failed to generate R-nonce");
                goto fail;
        }
+#endif /* CONFIG_TESTING_OPTIONS */
        wpa_hexdump(MSG_DEBUG, "DPP: R-nonce", auth->r_nonce, nonce_len);
 
+#ifdef CONFIG_TESTING_OPTIONS
+       if (dpp_protocol_key_override_len) {
+               const struct dpp_curve_params *tmp_curve;
+
+               wpa_printf(MSG_INFO,
+                          "DPP: TESTING - override protocol key");
+               auth->own_protocol_key = dpp_set_keypair(
+                       &tmp_curve, dpp_protocol_key_override,
+                       dpp_protocol_key_override_len);
+       } else {
+               auth->own_protocol_key = dpp_gen_keypair(auth->curve);
+       }
+#else /* CONFIG_TESTING_OPTIONS */
        auth->own_protocol_key = dpp_gen_keypair(auth->curve);
+#endif /* CONFIG_TESTING_OPTIONS */
        if (!auth->own_protocol_key)
                goto fail;
 
@@ -2208,6 +2827,7 @@ static int dpp_auth_build_resp_ok(struct dpp_authentication *auth)
 
        wpa_hexdump_key(MSG_DEBUG, "DPP: ECDH shared secret (N.x)",
                        auth->Nx, auth->secret_len);
+       auth->Nx_len = auth->secret_len;
 
        if (dpp_derive_k2(auth->Nx, auth->secret_len, auth->k2,
                          auth->curve->hash_len) < 0)
@@ -2255,13 +2875,36 @@ static int dpp_auth_build_resp_ok(struct dpp_authentication *auth)
        if (dpp_test == DPP_TEST_NO_R_BOOTSTRAP_KEY_HASH_AUTH_RESP) {
                wpa_printf(MSG_INFO, "DPP: TESTING - no R-Bootstrap Key Hash");
                r_pubkey_hash = NULL;
+       } else if (dpp_test ==
+                  DPP_TEST_INVALID_R_BOOTSTRAP_KEY_HASH_AUTH_RESP) {
+               wpa_printf(MSG_INFO,
+                          "DPP: TESTING - invalid R-Bootstrap Key Hash");
+               os_memcpy(test_hash, r_pubkey_hash, SHA256_MAC_LEN);
+               test_hash[SHA256_MAC_LEN - 1] ^= 0x01;
+               r_pubkey_hash = test_hash;
        } else if (dpp_test == DPP_TEST_NO_I_BOOTSTRAP_KEY_HASH_AUTH_RESP) {
                wpa_printf(MSG_INFO, "DPP: TESTING - no I-Bootstrap Key Hash");
                i_pubkey_hash = NULL;
+       } else if (dpp_test ==
+                  DPP_TEST_INVALID_I_BOOTSTRAP_KEY_HASH_AUTH_RESP) {
+               wpa_printf(MSG_INFO,
+                          "DPP: TESTING - invalid I-Bootstrap Key Hash");
+               if (i_pubkey_hash)
+                       os_memcpy(test_hash, i_pubkey_hash, SHA256_MAC_LEN);
+               else
+                       os_memset(test_hash, 0, SHA256_MAC_LEN);
+               test_hash[SHA256_MAC_LEN - 1] ^= 0x01;
+               i_pubkey_hash = test_hash;
        } else if (dpp_test == DPP_TEST_NO_R_PROTO_KEY_AUTH_RESP) {
                wpa_printf(MSG_INFO, "DPP: TESTING - no R-Proto Key");
                wpabuf_free(pr);
                pr = NULL;
+       } else if (dpp_test == DPP_TEST_INVALID_R_PROTO_KEY_AUTH_RESP) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - invalid R-Proto Key");
+               wpabuf_free(pr);
+               pr = wpabuf_alloc(2 * auth->curve->prime_len);
+               if (!pr || dpp_test_gen_invalid_key(pr, auth->curve) < 0)
+                       goto fail;
        } else if (dpp_test == DPP_TEST_NO_R_AUTH_AUTH_RESP) {
                wpa_printf(MSG_INFO, "DPP: TESTING - no R-Auth");
                w_r_auth = NULL;
@@ -2269,6 +2912,9 @@ static int dpp_auth_build_resp_ok(struct dpp_authentication *auth)
        } else if (dpp_test == DPP_TEST_NO_STATUS_AUTH_RESP) {
                wpa_printf(MSG_INFO, "DPP: TESTING - no Status");
                status = 255;
+       } else if (dpp_test == DPP_TEST_INVALID_STATUS_AUTH_RESP) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - invalid Status");
+               status = 254;
        } else if (dpp_test == DPP_TEST_NO_R_NONCE_AUTH_RESP) {
                wpa_printf(MSG_INFO, "DPP: TESTING - no R-nonce");
                r_nonce = NULL;
@@ -2285,6 +2931,7 @@ static int dpp_auth_build_resp_ok(struct dpp_authentication *auth)
                                  auth->k2);
        if (!msg)
                goto fail;
+       wpabuf_free(auth->resp_msg);
        auth->resp_msg = msg;
        ret = 0;
 fail:
@@ -2298,7 +2945,12 @@ static int dpp_auth_build_resp_status(struct dpp_authentication *auth,
 {
        struct wpabuf *msg;
        const u8 *r_pubkey_hash, *i_pubkey_hash, *i_nonce;
+#ifdef CONFIG_TESTING_OPTIONS
+       u8 test_hash[SHA256_MAC_LEN];
+#endif /* CONFIG_TESTING_OPTIONS */
 
+       if (!auth->own_bi)
+               return -1;
        wpa_printf(MSG_DEBUG, "DPP: Build Authentication Response");
 
        r_pubkey_hash = auth->own_bi->pubkey_hash;
@@ -2313,12 +2965,29 @@ static int dpp_auth_build_resp_status(struct dpp_authentication *auth,
        if (dpp_test == DPP_TEST_NO_R_BOOTSTRAP_KEY_HASH_AUTH_RESP) {
                wpa_printf(MSG_INFO, "DPP: TESTING - no R-Bootstrap Key Hash");
                r_pubkey_hash = NULL;
+       } else if (dpp_test ==
+                  DPP_TEST_INVALID_R_BOOTSTRAP_KEY_HASH_AUTH_RESP) {
+               wpa_printf(MSG_INFO,
+                          "DPP: TESTING - invalid R-Bootstrap Key Hash");
+               os_memcpy(test_hash, r_pubkey_hash, SHA256_MAC_LEN);
+               test_hash[SHA256_MAC_LEN - 1] ^= 0x01;
+               r_pubkey_hash = test_hash;
        } else if (dpp_test == DPP_TEST_NO_I_BOOTSTRAP_KEY_HASH_AUTH_RESP) {
                wpa_printf(MSG_INFO, "DPP: TESTING - no I-Bootstrap Key Hash");
                i_pubkey_hash = NULL;
+       } else if (dpp_test ==
+                  DPP_TEST_INVALID_I_BOOTSTRAP_KEY_HASH_AUTH_RESP) {
+               wpa_printf(MSG_INFO,
+                          "DPP: TESTING - invalid I-Bootstrap Key Hash");
+               if (i_pubkey_hash)
+                       os_memcpy(test_hash, i_pubkey_hash, SHA256_MAC_LEN);
+               else
+                       os_memset(test_hash, 0, SHA256_MAC_LEN);
+               test_hash[SHA256_MAC_LEN - 1] ^= 0x01;
+               i_pubkey_hash = test_hash;
        } else if (dpp_test == DPP_TEST_NO_STATUS_AUTH_RESP) {
                wpa_printf(MSG_INFO, "DPP: TESTING - no Status");
-               status = -1;
+               status = 255;
        } else if (dpp_test == DPP_TEST_NO_I_NONCE_AUTH_RESP) {
                wpa_printf(MSG_INFO, "DPP: TESTING - no I-nonce");
                i_nonce = NULL;
@@ -2330,6 +2999,7 @@ static int dpp_auth_build_resp_status(struct dpp_authentication *auth,
                                  NULL, i_nonce, NULL, 0, auth->k1);
        if (!msg)
                return -1;
+       wpabuf_free(auth->resp_msg);
        auth->resp_msg = msg;
        return 0;
 }
@@ -2349,10 +3019,23 @@ dpp_auth_req_rx(void *msg_ctx, u8 dpp_allowed_roles, int qr_mutual,
        size_t len[2];
        u8 *unwrapped = NULL;
        size_t unwrapped_len = 0;
-       const u8 *wrapped_data, *i_proto, *i_nonce, *i_capab, *i_bootstrap;
+       const u8 *wrapped_data, *i_proto, *i_nonce, *i_capab, *i_bootstrap,
+               *channel;
        u16 wrapped_data_len, i_proto_len, i_nonce_len, i_capab_len,
-               i_bootstrap_len;
+               i_bootstrap_len, channel_len;
        struct dpp_authentication *auth = NULL;
+#ifdef CONFIG_DPP2
+       const u8 *version;
+       u16 version_len;
+#endif /* CONFIG_DPP2 */
+
+#ifdef CONFIG_TESTING_OPTIONS
+       if (dpp_test == DPP_TEST_STOP_AT_AUTH_REQ) {
+               wpa_printf(MSG_INFO,
+                          "DPP: TESTING - stop at Authentication Request");
+               return NULL;
+       }
+#endif /* CONFIG_TESTING_OPTIONS */
 
        wrapped_data = dpp_get_attr(attr_start, attr_len, DPP_ATTR_WRAPPED_DATA,
                                    &wrapped_data_len);
@@ -2374,6 +3057,50 @@ dpp_auth_req_rx(void *msg_ctx, u8 dpp_allowed_roles, int qr_mutual,
        auth->curve = own_bi->curve;
        auth->curr_freq = freq;
 
+       auth->peer_version = 1; /* default to the first version */
+#ifdef CONFIG_DPP2
+       version = dpp_get_attr(attr_start, attr_len, DPP_ATTR_PROTOCOL_VERSION,
+                              &version_len);
+       if (version) {
+               if (version_len < 1 || version[0] == 0) {
+                       dpp_auth_fail(auth,
+                                     "Invalid Protocol Version attribute");
+                       goto fail;
+               }
+               auth->peer_version = version[0];
+               wpa_printf(MSG_DEBUG, "DPP: Peer protocol version %u",
+                          auth->peer_version);
+       }
+#endif /* CONFIG_DPP2 */
+
+       channel = dpp_get_attr(attr_start, attr_len, DPP_ATTR_CHANNEL,
+                              &channel_len);
+       if (channel) {
+               int neg_freq;
+
+               if (channel_len < 2) {
+                       dpp_auth_fail(auth, "Too short Channel attribute");
+                       goto fail;
+               }
+
+               neg_freq = ieee80211_chan_to_freq(NULL, channel[0], channel[1]);
+               wpa_printf(MSG_DEBUG,
+                          "DPP: Initiator requested different channel for negotiation: op_class=%u channel=%u --> freq=%d",
+                          channel[0], channel[1], neg_freq);
+               if (neg_freq < 0) {
+                       dpp_auth_fail(auth,
+                                     "Unsupported Channel attribute value");
+                       goto fail;
+               }
+
+               if (auth->curr_freq != (unsigned int) neg_freq) {
+                       wpa_printf(MSG_DEBUG,
+                                  "DPP: Changing negotiation channel from %u MHz to %u MHz",
+                                  freq, neg_freq);
+                       auth->curr_freq = neg_freq;
+               }
+       }
+
        i_proto = dpp_get_attr(attr_start, attr_len, DPP_ATTR_I_PROTOCOL_KEY,
                               &i_proto_len);
        if (!i_proto) {
@@ -2411,6 +3138,7 @@ dpp_auth_req_rx(void *msg_ctx, u8 dpp_allowed_roles, int qr_mutual,
 
        wpa_hexdump_key(MSG_DEBUG, "DPP: ECDH shared secret (M.x)",
                        auth->Mx, auth->secret_len);
+       auth->Mx_len = auth->secret_len;
 
        if (dpp_derive_k1(auth->Mx, auth->secret_len, auth->k1,
                          auth->curve->hash_len) < 0)
@@ -2483,6 +3211,19 @@ dpp_auth_req_rx(void *msg_ctx, u8 dpp_allowed_roles, int qr_mutual,
                wpa_printf(MSG_DEBUG, "DPP: Acting as Enrollee");
                auth->configurator = 0;
                break;
+       case DPP_CAPAB_CONFIGURATOR | DPP_CAPAB_ENROLLEE:
+               if (dpp_allowed_roles & DPP_CAPAB_ENROLLEE) {
+                       wpa_printf(MSG_DEBUG, "DPP: Acting as Enrollee");
+                       auth->configurator = 0;
+               } else if (dpp_allowed_roles & DPP_CAPAB_CONFIGURATOR) {
+                       wpa_printf(MSG_DEBUG, "DPP: Acting as Configurator");
+                       auth->configurator = 1;
+               } else {
+                       wpa_printf(MSG_DEBUG,
+                                  "DPP: Local policy does not allow Configurator/Enrollee role");
+                       goto not_compatible;
+               }
+               break;
        default:
                wpa_printf(MSG_DEBUG, "DPP: Unexpected role in I-capabilities");
                wpa_msg(auth->msg_ctx, MSG_INFO,
@@ -2579,6 +3320,10 @@ static struct wpabuf * dpp_auth_build_conf(struct dpp_authentication *auth,
        u8 *wrapped_i_auth;
        u8 *wrapped_r_nonce;
        u8 *attr_start, *attr_end;
+       const u8 *r_pubkey_hash, *i_pubkey_hash;
+#ifdef CONFIG_TESTING_OPTIONS
+       u8 test_hash[SHA256_MAC_LEN];
+#endif /* CONFIG_TESTING_OPTIONS */
 
        wpa_printf(MSG_DEBUG, "DPP: Build Authentication Confirmation");
 
@@ -2589,7 +3334,7 @@ static struct wpabuf * dpp_auth_build_conf(struct dpp_authentication *auth,
                4 + i_auth_len + r_nonce_len + AES_BLOCK_SIZE;
 #ifdef CONFIG_TESTING_OPTIONS
        if (dpp_test == DPP_TEST_AFTER_WRAPPED_DATA_AUTH_CONF)
-               attr_len += 4;
+               attr_len += 5;
 #endif /* CONFIG_TESTING_OPTIONS */
        msg = dpp_alloc_msg(DPP_PA_AUTHENTICATION_CONF, attr_len);
        if (!msg)
@@ -2597,43 +3342,60 @@ static struct wpabuf * dpp_auth_build_conf(struct dpp_authentication *auth,
 
        attr_start = wpabuf_put(msg, 0);
 
+       r_pubkey_hash = auth->peer_bi->pubkey_hash;
+       if (auth->own_bi)
+               i_pubkey_hash = auth->own_bi->pubkey_hash;
+       else
+               i_pubkey_hash = NULL;
+
 #ifdef CONFIG_TESTING_OPTIONS
-       if (dpp_test == DPP_TEST_NO_STATUS_AUTH_CONF)
+       if (dpp_test == DPP_TEST_NO_STATUS_AUTH_CONF) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - no Status");
                goto skip_status;
+       } else if (dpp_test == DPP_TEST_INVALID_STATUS_AUTH_CONF) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - invalid Status");
+               status = 254;
+       }
 #endif /* CONFIG_TESTING_OPTIONS */
 
        /* DPP Status */
-       wpabuf_put_le16(msg, DPP_ATTR_STATUS);
-       wpabuf_put_le16(msg, 1);
-       wpabuf_put_u8(msg, status);
+       dpp_build_attr_status(msg, status);
 
 #ifdef CONFIG_TESTING_OPTIONS
 skip_status:
-       if (dpp_test == DPP_TEST_NO_R_BOOTSTRAP_KEY_HASH_AUTH_CONF)
-               goto skip_r_bootstrap_key;
-#endif /* CONFIG_TESTING_OPTIONS */
-
-       /* Responder Bootstrapping Key Hash */
-       wpabuf_put_le16(msg, DPP_ATTR_R_BOOTSTRAP_KEY_HASH);
-       wpabuf_put_le16(msg, SHA256_MAC_LEN);
-       wpabuf_put_data(msg, auth->peer_bi->pubkey_hash, SHA256_MAC_LEN);
-
-#ifdef CONFIG_TESTING_OPTIONS
-skip_r_bootstrap_key:
-       if (dpp_test == DPP_TEST_NO_I_BOOTSTRAP_KEY_HASH_AUTH_CONF)
-               goto skip_i_bootstrap_key;
-#endif /* CONFIG_TESTING_OPTIONS */
-
-       if (auth->own_bi) {
-               /* Mutual authentication */
-               /* Initiator Bootstrapping Key Hash */
-               wpabuf_put_le16(msg, DPP_ATTR_I_BOOTSTRAP_KEY_HASH);
-               wpabuf_put_le16(msg, SHA256_MAC_LEN);
-               wpabuf_put_data(msg, auth->own_bi->pubkey_hash, SHA256_MAC_LEN);
+       if (dpp_test == DPP_TEST_NO_R_BOOTSTRAP_KEY_HASH_AUTH_CONF) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - no R-Bootstrap Key Hash");
+               r_pubkey_hash = NULL;
+       } else if (dpp_test ==
+                  DPP_TEST_INVALID_R_BOOTSTRAP_KEY_HASH_AUTH_CONF) {
+               wpa_printf(MSG_INFO,
+                          "DPP: TESTING - invalid R-Bootstrap Key Hash");
+               os_memcpy(test_hash, r_pubkey_hash, SHA256_MAC_LEN);
+               test_hash[SHA256_MAC_LEN - 1] ^= 0x01;
+               r_pubkey_hash = test_hash;
+       } else if (dpp_test == DPP_TEST_NO_I_BOOTSTRAP_KEY_HASH_AUTH_CONF) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - no I-Bootstrap Key Hash");
+               i_pubkey_hash = NULL;
+       } else if (dpp_test ==
+                  DPP_TEST_INVALID_I_BOOTSTRAP_KEY_HASH_AUTH_CONF) {
+               wpa_printf(MSG_INFO,
+                          "DPP: TESTING - invalid I-Bootstrap Key Hash");
+               if (i_pubkey_hash)
+                       os_memcpy(test_hash, i_pubkey_hash, SHA256_MAC_LEN);
+               else
+                       os_memset(test_hash, 0, SHA256_MAC_LEN);
+               test_hash[SHA256_MAC_LEN - 1] ^= 0x01;
+               i_pubkey_hash = test_hash;
        }
+#endif /* CONFIG_TESTING_OPTIONS */
+
+       /* Responder Bootstrapping Key Hash */
+       dpp_build_attr_r_bootstrap_key_hash(msg, r_pubkey_hash);
+
+       /* Initiator Bootstrapping Key Hash (mutual authentication) */
+       dpp_build_attr_i_bootstrap_key_hash(msg, i_pubkey_hash);
 
 #ifdef CONFIG_TESTING_OPTIONS
-skip_i_bootstrap_key:
        if (dpp_test == DPP_TEST_NO_WRAPPED_DATA_AUTH_CONF)
                goto skip_wrapped_data;
        if (dpp_test == DPP_TEST_NO_I_AUTH_AUTH_CONF)
@@ -2704,8 +3466,7 @@ skip_i_auth:
 #ifdef CONFIG_TESTING_OPTIONS
        if (dpp_test == DPP_TEST_AFTER_WRAPPED_DATA_AUTH_CONF) {
                wpa_printf(MSG_INFO, "DPP: TESTING - attr after Wrapped Data");
-               wpabuf_put_le16(msg, DPP_ATTR_TESTING);
-               wpabuf_put_le16(msg, 0);
+               dpp_build_attr_status(msg, DPP_STATUS_OK);
        }
 skip_wrapped_data:
 #endif /* CONFIG_TESTING_OPTIONS */
@@ -2719,6 +3480,7 @@ skip_wrapped_data:
        return msg;
 
 fail:
+       wpabuf_free(msg);
        return NULL;
 }
 
@@ -2811,7 +3573,9 @@ dpp_auth_resp_rx_status(struct dpp_authentication *auth, const u8 *hdr,
                } else {
                        wpa_printf(MSG_DEBUG,
                                   "DPP: Continue waiting for full DPP Authentication Response");
-                       wpa_msg(auth->msg_ctx, MSG_INFO, DPP_EVENT_RESPONSE_PENDING);
+                       wpa_msg(auth->msg_ctx, MSG_INFO,
+                               DPP_EVENT_RESPONSE_PENDING "%s",
+                               auth->tmp_own_bi ? auth->tmp_own_bi->uri : "");
                }
        }
 fail:
@@ -2837,6 +3601,25 @@ dpp_auth_resp_rx(struct dpp_authentication *auth, const u8 *hdr,
                wrapped2_len, r_auth_len;
        u8 r_auth2[DPP_MAX_HASH_LEN];
        u8 role;
+#ifdef CONFIG_DPP2
+       const u8 *version;
+       u16 version_len;
+#endif /* CONFIG_DPP2 */
+
+#ifdef CONFIG_TESTING_OPTIONS
+       if (dpp_test == DPP_TEST_STOP_AT_AUTH_RESP) {
+               wpa_printf(MSG_INFO,
+                          "DPP: TESTING - stop at Authentication Response");
+               return NULL;
+       }
+#endif /* CONFIG_TESTING_OPTIONS */
+
+       if (!auth->initiator || !auth->peer_bi) {
+               dpp_auth_fail(auth, "Unexpected Authentication Response");
+               return NULL;
+       }
+
+       auth->waiting_auth_resp = 0;
 
        wrapped_data = dpp_get_attr(attr_start, attr_len, DPP_ATTR_WRAPPED_DATA,
                                    &wrapped_data_len);
@@ -2896,6 +3679,22 @@ dpp_auth_resp_rx(struct dpp_authentication *auth, const u8 *hdr,
                return NULL;
        }
 
+       auth->peer_version = 1; /* default to the first version */
+#ifdef CONFIG_DPP2
+       version = dpp_get_attr(attr_start, attr_len, DPP_ATTR_PROTOCOL_VERSION,
+                              &version_len);
+       if (version) {
+               if (version_len < 1 || version[0] == 0) {
+                       dpp_auth_fail(auth,
+                                     "Invalid Protocol Version attribute");
+                       return NULL;
+               }
+               auth->peer_version = version[0];
+               wpa_printf(MSG_DEBUG, "DPP: Peer protocol version %u",
+                          auth->peer_version);
+       }
+#endif /* CONFIG_DPP2 */
+
        status = dpp_get_attr(attr_start, attr_len, DPP_ATTR_STATUS,
                              &status_len);
        if (!status || status_len < 1) {
@@ -2918,6 +3717,9 @@ dpp_auth_resp_rx(struct dpp_authentication *auth, const u8 *hdr,
                auth->own_bi = NULL;
        }
 
+       wpa_msg(auth->msg_ctx, MSG_INFO, DPP_EVENT_AUTH_DIRECTION "mutual=%d",
+               auth->own_bi != NULL);
+
        r_proto = dpp_get_attr(attr_start, attr_len, DPP_ATTR_R_PROTOCOL_KEY,
                               &r_proto_len);
        if (!r_proto) {
@@ -2951,11 +3753,13 @@ dpp_auth_resp_rx(struct dpp_authentication *auth, const u8 *hdr,
        }
        EVP_PKEY_CTX_free(ctx);
        ctx = NULL;
+       EVP_PKEY_free(auth->peer_protocol_key);
        auth->peer_protocol_key = pr;
        pr = NULL;
 
        wpa_hexdump_key(MSG_DEBUG, "DPP: ECDH shared secret (N.x)",
                        auth->Nx, auth->secret_len);
+       auth->Nx_len = auth->secret_len;
 
        if (dpp_derive_k2(auth->Nx, auth->secret_len, auth->k2,
                          auth->curve->hash_len) < 0)
@@ -3008,7 +3812,7 @@ dpp_auth_resp_rx(struct dpp_authentication *auth, const u8 *hdr,
                goto fail;
        }
 
-       if (auth->own_bi && auth->peer_bi) {
+       if (auth->own_bi) {
                /* Mutual authentication */
                if (dpp_auth_derive_l_initiator(auth) < 0)
                        goto fail;
@@ -3024,8 +3828,16 @@ dpp_auth_resp_rx(struct dpp_authentication *auth, const u8 *hdr,
        auth->r_capab = r_capab[0];
        wpa_printf(MSG_DEBUG, "DPP: R-capabilities: 0x%02x", auth->r_capab);
        role = auth->r_capab & DPP_CAPAB_ROLE_MASK;
-       if ((auth->configurator && role != DPP_CAPAB_ENROLLEE) ||
-           (!auth->configurator && role != DPP_CAPAB_CONFIGURATOR)) {
+       if ((auth->allowed_roles ==
+            (DPP_CAPAB_CONFIGURATOR | DPP_CAPAB_ENROLLEE)) &&
+           (role == DPP_CAPAB_CONFIGURATOR || role == DPP_CAPAB_ENROLLEE)) {
+               /* Peer selected its role, so move from "either role" to the
+                * role that is compatible with peer's selection. */
+               auth->configurator = role == DPP_CAPAB_ENROLLEE;
+               wpa_printf(MSG_DEBUG, "DPP: Acting as %s",
+                          auth->configurator ? "Configurator" : "Enrollee");
+       } else if ((auth->configurator && role != DPP_CAPAB_ENROLLEE) ||
+                  (!auth->configurator && role != DPP_CAPAB_CONFIGURATOR)) {
                wpa_printf(MSG_DEBUG, "DPP: Incompatible role selection");
                wpa_msg(auth->msg_ctx, MSG_INFO, DPP_EVENT_FAIL
                        "Unexpected role in R-capabilities 0x%02x",
@@ -3096,6 +3908,16 @@ dpp_auth_resp_rx(struct dpp_authentication *auth, const u8 *hdr,
        bin_clear_free(unwrapped, unwrapped_len);
        bin_clear_free(unwrapped2, unwrapped2_len);
 
+#ifdef CONFIG_TESTING_OPTIONS
+       if (dpp_test == DPP_TEST_AUTH_RESP_IN_PLACE_OF_CONF) {
+               wpa_printf(MSG_INFO,
+                          "DPP: TESTING - Authentication Response in place of Confirm");
+               if (dpp_auth_build_resp_ok(auth) < 0)
+                       return NULL;
+               return wpabuf_dup(auth->resp_msg);
+       }
+#endif /* CONFIG_TESTING_OPTIONS */
+
        return dpp_auth_build_conf(auth, DPP_STATUS_OK);
 
 fail:
@@ -3190,6 +4012,21 @@ int dpp_auth_conf_rx(struct dpp_authentication *auth, const u8 *hdr,
        size_t unwrapped_len = 0;
        u8 i_auth2[DPP_MAX_HASH_LEN];
 
+#ifdef CONFIG_TESTING_OPTIONS
+       if (dpp_test == DPP_TEST_STOP_AT_AUTH_CONF) {
+               wpa_printf(MSG_INFO,
+                          "DPP: TESTING - stop at Authentication Confirm");
+               return -1;
+       }
+#endif /* CONFIG_TESTING_OPTIONS */
+
+       if (auth->initiator || !auth->own_bi) {
+               dpp_auth_fail(auth, "Unexpected Authentication Confirm");
+               return -1;
+       }
+
+       auth->waiting_auth_conf = 0;
+
        wrapped_data = dpp_get_attr(attr_start, attr_len, DPP_ATTR_WRAPPED_DATA,
                                    &wrapped_data_len);
        if (!wrapped_data || wrapped_data_len < AES_BLOCK_SIZE) {
@@ -3241,7 +4078,7 @@ int dpp_auth_conf_rx(struct dpp_authentication *auth, const u8 *hdr,
                                      "Initiator Bootstrapping Key Hash mismatch");
                        return -1;
                }
-       } else if (auth->own_bi && auth->peer_bi) {
+       } else if (auth->peer_bi) {
                /* Mutual authentication and peer did not include its
                 * Bootstrapping Key Hash attribute. */
                dpp_auth_fail(auth,
@@ -3322,15 +4159,265 @@ fail:
 }
 
 
+static int bin_str_eq(const char *val, size_t len, const char *cmp)
+{
+       return os_strlen(cmp) == len && os_memcmp(val, cmp, len) == 0;
+}
+
+
+struct dpp_configuration * dpp_configuration_alloc(const char *type)
+{
+       struct dpp_configuration *conf;
+       const char *end;
+       size_t len;
+
+       conf = os_zalloc(sizeof(*conf));
+       if (!conf)
+               goto fail;
+
+       end = os_strchr(type, ' ');
+       if (end)
+               len = end - type;
+       else
+               len = os_strlen(type);
+
+       if (bin_str_eq(type, len, "psk"))
+               conf->akm = DPP_AKM_PSK;
+       else if (bin_str_eq(type, len, "sae"))
+               conf->akm = DPP_AKM_SAE;
+       else if (bin_str_eq(type, len, "psk-sae") ||
+                bin_str_eq(type, len, "psk+sae"))
+               conf->akm = DPP_AKM_PSK_SAE;
+       else if (bin_str_eq(type, len, "sae-dpp") ||
+                bin_str_eq(type, len, "dpp+sae"))
+               conf->akm = DPP_AKM_SAE_DPP;
+       else if (bin_str_eq(type, len, "psk-sae-dpp") ||
+                bin_str_eq(type, len, "dpp+psk+sae"))
+               conf->akm = DPP_AKM_PSK_SAE_DPP;
+       else if (bin_str_eq(type, len, "dpp"))
+               conf->akm = DPP_AKM_DPP;
+       else
+               goto fail;
+
+       return conf;
+fail:
+       dpp_configuration_free(conf);
+       return NULL;
+}
+
+
+int dpp_akm_psk(enum dpp_akm akm)
+{
+       return akm == DPP_AKM_PSK || akm == DPP_AKM_PSK_SAE ||
+               akm == DPP_AKM_PSK_SAE_DPP;
+}
+
+
+int dpp_akm_sae(enum dpp_akm akm)
+{
+       return akm == DPP_AKM_SAE || akm == DPP_AKM_PSK_SAE ||
+               akm == DPP_AKM_SAE_DPP || akm == DPP_AKM_PSK_SAE_DPP;
+}
+
+
+int dpp_akm_legacy(enum dpp_akm akm)
+{
+       return akm == DPP_AKM_PSK || akm == DPP_AKM_PSK_SAE ||
+               akm == DPP_AKM_SAE;
+}
+
+
+int dpp_akm_dpp(enum dpp_akm akm)
+{
+       return akm == DPP_AKM_DPP || akm == DPP_AKM_SAE_DPP ||
+               akm == DPP_AKM_PSK_SAE_DPP;
+}
+
+
+int dpp_akm_ver2(enum dpp_akm akm)
+{
+       return akm == DPP_AKM_SAE_DPP || akm == DPP_AKM_PSK_SAE_DPP;
+}
+
+
+int dpp_configuration_valid(const struct dpp_configuration *conf)
+{
+       if (conf->ssid_len == 0)
+               return 0;
+       if (dpp_akm_psk(conf->akm) && !conf->passphrase && !conf->psk_set)
+               return 0;
+       if (dpp_akm_sae(conf->akm) && !conf->passphrase)
+               return 0;
+       return 1;
+}
+
+
 void dpp_configuration_free(struct dpp_configuration *conf)
 {
        if (!conf)
                return;
        str_clear_free(conf->passphrase);
+       os_free(conf->group_id);
        bin_clear_free(conf, sizeof(*conf));
 }
 
 
+static int dpp_configuration_parse(struct dpp_authentication *auth,
+                                  const char *cmd)
+{
+       const char *pos, *end;
+       struct dpp_configuration *conf_sta = NULL, *conf_ap = NULL;
+       struct dpp_configuration *conf = NULL;
+
+       pos = os_strstr(cmd, " conf=sta-");
+       if (pos) {
+               conf_sta = dpp_configuration_alloc(pos + 10);
+               if (!conf_sta)
+                       goto fail;
+               conf = conf_sta;
+       }
+
+       pos = os_strstr(cmd, " conf=ap-");
+       if (pos) {
+               conf_ap = dpp_configuration_alloc(pos + 9);
+               if (!conf_ap)
+                       goto fail;
+               conf = conf_ap;
+       }
+
+       if (!conf)
+               return 0;
+
+       pos = os_strstr(cmd, " ssid=");
+       if (pos) {
+               pos += 6;
+               end = os_strchr(pos, ' ');
+               conf->ssid_len = end ? (size_t) (end - pos) : os_strlen(pos);
+               conf->ssid_len /= 2;
+               if (conf->ssid_len > sizeof(conf->ssid) ||
+                   hexstr2bin(pos, conf->ssid, conf->ssid_len) < 0)
+                       goto fail;
+       } else {
+#ifdef CONFIG_TESTING_OPTIONS
+               /* use a default SSID for legacy testing reasons */
+               os_memcpy(conf->ssid, "test", 4);
+               conf->ssid_len = 4;
+#else /* CONFIG_TESTING_OPTIONS */
+               goto fail;
+#endif /* CONFIG_TESTING_OPTIONS */
+       }
+
+       pos = os_strstr(cmd, " pass=");
+       if (pos) {
+               size_t pass_len;
+
+               pos += 6;
+               end = os_strchr(pos, ' ');
+               pass_len = end ? (size_t) (end - pos) : os_strlen(pos);
+               pass_len /= 2;
+               if (pass_len > 63 || pass_len < 8)
+                       goto fail;
+               conf->passphrase = os_zalloc(pass_len + 1);
+               if (!conf->passphrase ||
+                   hexstr2bin(pos, (u8 *) conf->passphrase, pass_len) < 0)
+                       goto fail;
+       }
+
+       pos = os_strstr(cmd, " psk=");
+       if (pos) {
+               pos += 5;
+               if (hexstr2bin(pos, conf->psk, PMK_LEN) < 0)
+                       goto fail;
+               conf->psk_set = 1;
+       }
+
+       pos = os_strstr(cmd, " group_id=");
+       if (pos) {
+               size_t group_id_len;
+
+               pos += 10;
+               end = os_strchr(pos, ' ');
+               group_id_len = end ? (size_t) (end - pos) : os_strlen(pos);
+               conf->group_id = os_malloc(group_id_len + 1);
+               if (!conf->group_id)
+                       goto fail;
+               os_memcpy(conf->group_id, pos, group_id_len);
+               conf->group_id[group_id_len] = '\0';
+       }
+
+       pos = os_strstr(cmd, " expiry=");
+       if (pos) {
+               long int val;
+
+               pos += 8;
+               val = strtol(pos, NULL, 0);
+               if (val <= 0)
+                       goto fail;
+               conf->netaccesskey_expiry = val;
+       }
+
+       if (!dpp_configuration_valid(conf))
+               goto fail;
+
+       auth->conf_sta = conf_sta;
+       auth->conf_ap = conf_ap;
+       return 0;
+
+fail:
+       dpp_configuration_free(conf_sta);
+       dpp_configuration_free(conf_ap);
+       return -1;
+}
+
+
+static struct dpp_configurator *
+dpp_configurator_get_id(struct dpp_global *dpp, unsigned int id)
+{
+       struct dpp_configurator *conf;
+
+       if (!dpp)
+               return NULL;
+
+       dl_list_for_each(conf, &dpp->configurator,
+                        struct dpp_configurator, list) {
+               if (conf->id == id)
+                       return conf;
+       }
+       return NULL;
+}
+
+
+int dpp_set_configurator(struct dpp_global *dpp, void *msg_ctx,
+                        struct dpp_authentication *auth,
+                        const char *cmd)
+{
+       const char *pos;
+
+       if (!cmd)
+               return 0;
+
+       wpa_printf(MSG_DEBUG, "DPP: Set configurator parameters: %s", cmd);
+
+       pos = os_strstr(cmd, " configurator=");
+       if (pos) {
+               pos += 14;
+               auth->conf = dpp_configurator_get_id(dpp, atoi(pos));
+               if (!auth->conf) {
+                       wpa_printf(MSG_INFO,
+                                  "DPP: Could not find the specified configurator");
+                       return -1;
+               }
+       }
+
+       if (dpp_configuration_parse(auth, cmd) < 0) {
+               wpa_msg(msg_ctx, MSG_INFO,
+                       "DPP: Failed to set configurator parameters");
+               return -1;
+       }
+       return 0;
+}
+
+
 void dpp_auth_deinit(struct dpp_authentication *auth)
 {
        if (!auth)
@@ -3345,6 +4432,7 @@ void dpp_auth_deinit(struct dpp_authentication *auth)
        os_free(auth->connector);
        wpabuf_free(auth->net_access_key);
        wpabuf_free(auth->c_sign_key);
+       dpp_bootstrap_info_free(auth->tmp_own_bi);
 #ifdef CONFIG_TESTING_OPTIONS
        os_free(auth->config_obj_override);
        os_free(auth->discovery_override);
@@ -3383,28 +4471,12 @@ dpp_build_conf_start(struct dpp_authentication *auth,
        json_escape_string(ssid, sizeof(ssid),
                           (const char *) conf->ssid, conf->ssid_len);
        wpabuf_put_str(buf, ssid);
-       wpabuf_put_str(buf, "\"");
-       /* TODO: optional channel information */
-       wpabuf_put_str(buf, "},");
+       wpabuf_put_str(buf, "\"},");
 
        return buf;
 }
 
 
-static int dpp_bn2bin_pad(const BIGNUM *bn, u8 *pos, size_t len)
-{
-       int num_bytes, offset;
-
-       num_bytes = BN_num_bytes(bn);
-       if ((size_t) num_bytes > len)
-               return -1;
-       offset = len - num_bytes;
-       os_memset(pos, 0, offset);
-       BN_bn2bin(bn, pos + offset);
-       return 0;
-}
-
-
 static int dpp_build_jwk(struct wpabuf *buf, const char *name, EVP_PKEY *key,
                         const char *kid, const struct dpp_curve_params *curve)
 {
@@ -3445,6 +4517,31 @@ fail:
 }
 
 
+static void dpp_build_legacy_cred_params(struct wpabuf *buf,
+                                        struct dpp_configuration *conf)
+{
+       if (conf->passphrase && os_strlen(conf->passphrase) < 64) {
+               char pass[63 * 6 + 1];
+
+               json_escape_string(pass, sizeof(pass), conf->passphrase,
+                                  os_strlen(conf->passphrase));
+               wpabuf_put_str(buf, "\"pass\":\"");
+               wpabuf_put_str(buf, pass);
+               wpabuf_put_str(buf, "\"");
+               os_memset(pass, 0, sizeof(pass));
+       } else if (conf->psk_set) {
+               char psk[2 * sizeof(conf->psk) + 1];
+
+               wpa_snprintf_hex(psk, sizeof(psk),
+                                conf->psk, sizeof(conf->psk));
+               wpabuf_put_str(buf, "\"psk_hex\":\"");
+               wpabuf_put_str(buf, psk);
+               wpabuf_put_str(buf, "\"");
+               os_memset(psk, 0, sizeof(psk));
+       }
+}
+
+
 static struct wpabuf *
 dpp_build_conf_obj_dpp(struct dpp_authentication *auth, int ap,
                       struct dpp_configuration *conf)
@@ -3465,6 +4562,8 @@ dpp_build_conf_obj_dpp(struct dpp_authentication *auth, int ap,
        const EVP_MD *sign_md;
        const BIGNUM *r, *s;
        size_t extra_len = 1000;
+       int incl_legacy;
+       enum dpp_akm akm;
 
        if (!auth->conf) {
                wpa_printf(MSG_INFO,
@@ -3483,11 +4582,21 @@ dpp_build_conf_obj_dpp(struct dpp_authentication *auth, int ap,
                goto fail;
        }
 
+       akm = conf->akm;
+       if (dpp_akm_ver2(akm) && auth->peer_version < 2) {
+               wpa_printf(MSG_DEBUG,
+                          "DPP: Convert DPP+legacy credential to DPP-only for peer that does not support version 2");
+               akm = DPP_AKM_DPP;
+       }
+
 #ifdef CONFIG_TESTING_OPTIONS
        if (auth->groups_override)
                extra_len += os_strlen(auth->groups_override);
 #endif /* CONFIG_TESTING_OPTIONS */
 
+       if (conf->group_id)
+               extra_len += os_strlen(conf->group_id);
+
        /* Connector (JSON dppCon object) */
        dppcon = wpabuf_alloc(extra_len + 2 * auth->curve->prime_len * 4 / 3);
        if (!dppcon)
@@ -3506,7 +4615,8 @@ dpp_build_conf_obj_dpp(struct dpp_authentication *auth, int ap,
                goto skip_groups;
        }
 #endif /* CONFIG_TESTING_OPTIONS */
-       wpabuf_put_str(dppcon, "{\"groups\":[{\"groupId\":\"*\",");
+       wpabuf_printf(dppcon, "{\"groups\":[{\"groupId\":\"%s\",",
+                     conf->group_id ? conf->group_id : "*");
        wpabuf_printf(dppcon, "\"netRole\":\"%s\"}],", ap ? "ap" : "sta");
 #ifdef CONFIG_TESTING_OPTIONS
 skip_groups:
@@ -3596,14 +4706,22 @@ skip_groups:
        if (!signed3)
                goto fail;
 
+       incl_legacy = dpp_akm_psk(akm) || dpp_akm_sae(akm);
        tailroom = 1000;
        tailroom += 2 * curve->prime_len * 4 / 3 + os_strlen(auth->conf->kid);
        tailroom += signed1_len + signed2_len + signed3_len;
+       if (incl_legacy)
+               tailroom += 1000;
        buf = dpp_build_conf_start(auth, conf, tailroom);
        if (!buf)
-               return NULL;
+               goto fail;
 
-       wpabuf_put_str(buf, "\"cred\":{\"akm\":\"dpp\",\"signedConnector\":\"");
+       wpabuf_printf(buf, "\"cred\":{\"akm\":\"%s\",", dpp_akm_str(akm));
+       if (incl_legacy) {
+               dpp_build_legacy_cred_params(buf, conf);
+               wpabuf_put_str(buf, ",");
+       }
+       wpabuf_put_str(buf, "\"signedConnector\":\"");
        wpabuf_put_str(buf, signed1);
        wpabuf_put_u8(buf, '.');
        wpabuf_put_str(buf, signed2);
@@ -3648,29 +4766,8 @@ dpp_build_conf_obj_legacy(struct dpp_authentication *auth, int ap,
        if (!buf)
                return NULL;
 
-       wpabuf_put_str(buf, "\"cred\":{\"akm\":\"psk\",");
-       if (conf->passphrase) {
-               char pass[63 * 6 + 1];
-
-               if (os_strlen(conf->passphrase) > 63) {
-                       wpabuf_free(buf);
-                       return NULL;
-               }
-
-               json_escape_string(pass, sizeof(pass), conf->passphrase,
-                                  os_strlen(conf->passphrase));
-               wpabuf_put_str(buf, "\"pass\":\"");
-               wpabuf_put_str(buf, pass);
-               wpabuf_put_str(buf, "\"");
-       } else {
-               char psk[2 * sizeof(conf->psk) + 1];
-
-               wpa_snprintf_hex(psk, sizeof(psk),
-                                conf->psk, sizeof(conf->psk));
-               wpabuf_put_str(buf, "\"psk_hex\":\"");
-               wpabuf_put_str(buf, psk);
-               wpabuf_put_str(buf, "\"");
-       }
+       wpabuf_printf(buf, "\"cred\":{\"akm\":\"%s\",", dpp_akm_str(conf->akm));
+       dpp_build_legacy_cred_params(buf, conf);
        wpabuf_put_str(buf, "}}");
 
        wpa_hexdump_ascii_key(MSG_DEBUG, "DPP: Configuration Object (legacy)",
@@ -3701,7 +4798,7 @@ dpp_build_conf_obj(struct dpp_authentication *auth, int ap)
                return NULL;
        }
 
-       if (conf->dpp)
+       if (dpp_akm_dpp(conf->akm))
                return dpp_build_conf_obj_dpp(auth, ap, conf);
        return dpp_build_conf_obj_legacy(auth, ap, conf);
 }
@@ -3725,6 +4822,7 @@ dpp_build_conf_resp(struct dpp_authentication *auth, const u8 *e_nonce,
                                  wpabuf_head(conf), wpabuf_len(conf));
        }
        status = conf ? DPP_STATUS_OK : DPP_STATUS_CONFIGURE_FAILURE;
+       auth->conf_resp_status = status;
 
        /* { E-nonce, configurationObject}ke */
        clear_len = 4 + e_nonce_len;
@@ -3734,32 +4832,71 @@ dpp_build_conf_resp(struct dpp_authentication *auth, const u8 *e_nonce,
        attr_len = 4 + 1 + 4 + clear_len + AES_BLOCK_SIZE;
 #ifdef CONFIG_TESTING_OPTIONS
        if (dpp_test == DPP_TEST_AFTER_WRAPPED_DATA_CONF_RESP)
-               attr_len += 4;
+               attr_len += 5;
 #endif /* CONFIG_TESTING_OPTIONS */
        msg = wpabuf_alloc(attr_len);
        if (!clear || !msg)
                goto fail;
 
+#ifdef CONFIG_TESTING_OPTIONS
+       if (dpp_test == DPP_TEST_NO_E_NONCE_CONF_RESP) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - no E-nonce");
+               goto skip_e_nonce;
+       }
+       if (dpp_test == DPP_TEST_E_NONCE_MISMATCH_CONF_RESP) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - E-nonce mismatch");
+               wpabuf_put_le16(clear, DPP_ATTR_ENROLLEE_NONCE);
+               wpabuf_put_le16(clear, e_nonce_len);
+               wpabuf_put_data(clear, e_nonce, e_nonce_len - 1);
+               wpabuf_put_u8(clear, e_nonce[e_nonce_len - 1] ^ 0x01);
+               goto skip_e_nonce;
+       }
+       if (dpp_test == DPP_TEST_NO_WRAPPED_DATA_CONF_RESP) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - no Wrapped Data");
+               goto skip_wrapped_data;
+       }
+#endif /* CONFIG_TESTING_OPTIONS */
+
        /* E-nonce */
        wpabuf_put_le16(clear, DPP_ATTR_ENROLLEE_NONCE);
        wpabuf_put_le16(clear, e_nonce_len);
        wpabuf_put_data(clear, e_nonce, e_nonce_len);
 
+#ifdef CONFIG_TESTING_OPTIONS
+skip_e_nonce:
+       if (dpp_test == DPP_TEST_NO_CONFIG_OBJ_CONF_RESP) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - Config Object");
+               goto skip_config_obj;
+       }
+#endif /* CONFIG_TESTING_OPTIONS */
+
        if (conf) {
                wpabuf_put_le16(clear, DPP_ATTR_CONFIG_OBJ);
                wpabuf_put_le16(clear, wpabuf_len(conf));
                wpabuf_put_buf(clear, conf);
-               wpabuf_free(conf);
-               conf = NULL;
        }
 
+#ifdef CONFIG_TESTING_OPTIONS
+skip_config_obj:
+       if (dpp_test == DPP_TEST_NO_STATUS_CONF_RESP) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - Status");
+               goto skip_status;
+       }
+       if (dpp_test == DPP_TEST_INVALID_STATUS_CONF_RESP) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - invalid Status");
+               status = 255;
+       }
+#endif /* CONFIG_TESTING_OPTIONS */
+
        /* DPP Status */
-       wpabuf_put_le16(msg, DPP_ATTR_STATUS);
-       wpabuf_put_le16(msg, 1);
-       wpabuf_put_u8(msg, status);
+       dpp_build_attr_status(msg, status);
 
-       addr[0] = wpabuf_head(msg);
-       len[0] = wpabuf_len(msg);
+#ifdef CONFIG_TESTING_OPTIONS
+skip_status:
+#endif /* CONFIG_TESTING_OPTIONS */
+
+       addr[0] = wpabuf_head(msg);
+       len[0] = wpabuf_len(msg);
        wpa_hexdump(MSG_DEBUG, "DDP: AES-SIV AD", addr[0], len[0]);
 
        wpabuf_put_le16(msg, DPP_ATTR_WRAPPED_DATA);
@@ -3773,25 +4910,26 @@ dpp_build_conf_resp(struct dpp_authentication *auth, const u8 *e_nonce,
                goto fail;
        wpa_hexdump(MSG_DEBUG, "DPP: AES-SIV ciphertext",
                    wrapped, wpabuf_len(clear) + AES_BLOCK_SIZE);
-       wpabuf_free(clear);
-       clear = NULL;
 
 #ifdef CONFIG_TESTING_OPTIONS
        if (dpp_test == DPP_TEST_AFTER_WRAPPED_DATA_CONF_RESP) {
                wpa_printf(MSG_INFO, "DPP: TESTING - attr after Wrapped Data");
-               wpabuf_put_le16(msg, DPP_ATTR_TESTING);
-               wpabuf_put_le16(msg, 0);
+               dpp_build_attr_status(msg, DPP_STATUS_OK);
        }
+skip_wrapped_data:
 #endif /* CONFIG_TESTING_OPTIONS */
 
        wpa_hexdump_buf(MSG_DEBUG,
                        "DPP: Configuration Response attributes", msg);
-       return msg;
-fail:
+out:
        wpabuf_free(conf);
        wpabuf_free(clear);
+
+       return msg;
+fail:
        wpabuf_free(msg);
-       return NULL;
+       msg = NULL;
+       goto out;
 }
 
 
@@ -3807,17 +4945,24 @@ dpp_conf_req_rx(struct dpp_authentication *auth, const u8 *attr_start,
        struct json_token *root = NULL, *token;
        int ap;
 
+#ifdef CONFIG_TESTING_OPTIONS
+       if (dpp_test == DPP_TEST_STOP_AT_CONF_REQ) {
+               wpa_printf(MSG_INFO,
+                          "DPP: TESTING - stop at Config Request");
+               return NULL;
+       }
+#endif /* CONFIG_TESTING_OPTIONS */
+
        if (dpp_check_attrs(attr_start, attr_len) < 0) {
-               wpa_printf(MSG_DEBUG,
-                          "DPP: Invalid attribute in config request");
+               dpp_auth_fail(auth, "Invalid attribute in config request");
                return NULL;
        }
 
        wrapped_data = dpp_get_attr(attr_start, attr_len, DPP_ATTR_WRAPPED_DATA,
                                    &wrapped_data_len);
        if (!wrapped_data || wrapped_data_len < AES_BLOCK_SIZE) {
-               wpa_printf(MSG_DEBUG,
-                          "DPP: Missing or invalid required Wrapped data attribute");
+               dpp_auth_fail(auth,
+                             "Missing or invalid required Wrapped Data attribute");
                return NULL;
        }
 
@@ -3830,15 +4975,14 @@ dpp_conf_req_rx(struct dpp_authentication *auth, const u8 *attr_start,
        if (aes_siv_decrypt(auth->ke, auth->curve->hash_len,
                            wrapped_data, wrapped_data_len,
                            0, NULL, NULL, unwrapped) < 0) {
-               wpa_printf(MSG_DEBUG, "DPP: AES-SIV decryption failed");
+               dpp_auth_fail(auth, "AES-SIV decryption failed");
                goto fail;
        }
        wpa_hexdump(MSG_DEBUG, "DPP: AES-SIV cleartext",
                    unwrapped, unwrapped_len);
 
        if (dpp_check_attrs(unwrapped, unwrapped_len) < 0) {
-               wpa_printf(MSG_DEBUG,
-                          "DPP: Invalid attribute in unwrapped data");
+               dpp_auth_fail(auth, "Invalid attribute in unwrapped data");
                goto fail;
        }
 
@@ -3846,18 +4990,19 @@ dpp_conf_req_rx(struct dpp_authentication *auth, const u8 *attr_start,
                               DPP_ATTR_ENROLLEE_NONCE,
                               &e_nonce_len);
        if (!e_nonce || e_nonce_len != auth->curve->nonce_len) {
-               wpa_printf(MSG_DEBUG,
-                          "DPP: Missing or invalid Enrollee Nonce attribute");
+               dpp_auth_fail(auth,
+                             "Missing or invalid Enrollee Nonce attribute");
                goto fail;
        }
        wpa_hexdump(MSG_DEBUG, "DPP: Enrollee Nonce", e_nonce, e_nonce_len);
+       os_memcpy(auth->e_nonce, e_nonce, e_nonce_len);
 
        config_attr = dpp_get_attr(unwrapped, unwrapped_len,
                                   DPP_ATTR_CONFIG_ATTR_OBJ,
                                   &config_attr_len);
        if (!config_attr) {
-               wpa_printf(MSG_DEBUG,
-                          "DPP: Missing or invalid Config Attributes attribute");
+               dpp_auth_fail(auth,
+                             "Missing or invalid Config Attributes attribute");
                goto fail;
        }
        wpa_hexdump_ascii(MSG_DEBUG, "DPP: Config Attributes",
@@ -3865,32 +5010,33 @@ dpp_conf_req_rx(struct dpp_authentication *auth, const u8 *attr_start,
 
        root = json_parse((const char *) config_attr, config_attr_len);
        if (!root) {
-               wpa_printf(MSG_DEBUG, "DPP: Could not parse Config Attributes");
+               dpp_auth_fail(auth, "Could not parse Config Attributes");
                goto fail;
        }
 
        token = json_get_member(root, "name");
        if (!token || token->type != JSON_STRING) {
-               wpa_printf(MSG_DEBUG, "DPP: No Config Attributes - name");
+               dpp_auth_fail(auth, "No Config Attributes - name");
                goto fail;
        }
        wpa_printf(MSG_DEBUG, "DPP: Enrollee name = '%s'", token->string);
 
        token = json_get_member(root, "wi-fi_tech");
        if (!token || token->type != JSON_STRING) {
-               wpa_printf(MSG_DEBUG, "DPP: No Config Attributes - wi-fi_tech");
+               dpp_auth_fail(auth, "No Config Attributes - wi-fi_tech");
                goto fail;
        }
        wpa_printf(MSG_DEBUG, "DPP: wi-fi_tech = '%s'", token->string);
        if (os_strcmp(token->string, "infra") != 0) {
                wpa_printf(MSG_DEBUG, "DPP: Unsupported wi-fi_tech '%s'",
                           token->string);
+               dpp_auth_fail(auth, "Unsupported wi-fi_tech");
                goto fail;
        }
 
        token = json_get_member(root, "netRole");
        if (!token || token->type != JSON_STRING) {
-               wpa_printf(MSG_DEBUG, "DPP: No Config Attributes - netRole");
+               dpp_auth_fail(auth, "No Config Attributes - netRole");
                goto fail;
        }
        wpa_printf(MSG_DEBUG, "DPP: netRole = '%s'", token->string);
@@ -3901,6 +5047,7 @@ dpp_conf_req_rx(struct dpp_authentication *auth, const u8 *attr_start,
        } else {
                wpa_printf(MSG_DEBUG, "DPP: Unsupported netRole '%s'",
                           token->string);
+               dpp_auth_fail(auth, "Unsupported netRole");
                goto fail;
        }
 
@@ -4013,6 +5160,11 @@ static int dpp_parse_cred_legacy(struct dpp_authentication *auth,
                os_strlcpy(auth->passphrase, pass->string,
                           sizeof(auth->passphrase));
        } else if (psk_hex && psk_hex->type == JSON_STRING) {
+               if (dpp_akm_sae(auth->akm) && !dpp_akm_psk(auth->akm)) {
+                       wpa_printf(MSG_DEBUG,
+                                  "DPP: Unexpected psk_hex with akm=sae");
+                       return -1;
+               }
                if (os_strlen(psk_hex->string) != PMK_LEN * 2 ||
                    hexstr2bin(psk_hex->string, auth->psk, PMK_LEN) < 0) {
                        wpa_printf(MSG_DEBUG, "DPP: Invalid psk_hex encoding");
@@ -4026,6 +5178,11 @@ static int dpp_parse_cred_legacy(struct dpp_authentication *auth,
                return -1;
        }
 
+       if (dpp_akm_sae(auth->akm) && !auth->passphrase[0]) {
+               wpa_printf(MSG_DEBUG, "DPP: No pass for sae found");
+               return -1;
+       }
+
        return 0;
 }
 
@@ -4045,7 +5202,7 @@ static EVP_PKEY * dpp_parse_jwk(struct json_token *jwk,
                goto fail;
        }
        if (os_strcmp(token->string, "EC") != 0) {
-               wpa_printf(MSG_DEBUG, "DPP: Unexpected JWK kty '%s",
+               wpa_printf(MSG_DEBUG, "DPP: Unexpected JWK kty '%s'",
                           token->string);
                goto fail;
        }
@@ -4098,6 +5255,7 @@ static EVP_PKEY * dpp_parse_jwk(struct json_token *jwk,
 
        pkey = dpp_set_pubkey_point_group(group, wpabuf_head(x), wpabuf_head(y),
                                          wpabuf_len(x));
+       EC_GROUP_free(group);
        *key_curve = curve;
 
 fail:
@@ -4356,11 +5514,11 @@ struct dpp_signed_connector_info {
        size_t payload_len;
 };
 
-static int
+static enum dpp_status_error
 dpp_process_signed_connector(struct dpp_signed_connector_info *info,
                             EVP_PKEY *csign_pub, const char *connector)
 {
-       int ret = -1;
+       enum dpp_status_error ret = 255;
        const char *pos, *end, *signed_start, *signed_end;
        struct wpabuf *kid = NULL;
        unsigned char *prot_hdr = NULL, *signature = NULL;
@@ -4394,6 +5552,7 @@ dpp_process_signed_connector(struct dpp_signed_connector_info *info,
        end = os_strchr(pos, '.');
        if (!end) {
                wpa_printf(MSG_DEBUG, "DPP: Missing dot(1) in signedConnector");
+               ret = DPP_STATUS_INVALID_CONNECTOR;
                goto fail;
        }
        prot_hdr = base64_url_decode((const unsigned char *) pos,
@@ -4401,18 +5560,22 @@ dpp_process_signed_connector(struct dpp_signed_connector_info *info,
        if (!prot_hdr) {
                wpa_printf(MSG_DEBUG,
                           "DPP: Failed to base64url decode signedConnector JWS Protected Header");
+               ret = DPP_STATUS_INVALID_CONNECTOR;
                goto fail;
        }
        wpa_hexdump_ascii(MSG_DEBUG,
                          "DPP: signedConnector - JWS Protected Header",
                          prot_hdr, prot_hdr_len);
        kid = dpp_parse_jws_prot_hdr(curve, prot_hdr, prot_hdr_len, &sign_md);
-       if (!kid)
+       if (!kid) {
+               ret = DPP_STATUS_INVALID_CONNECTOR;
                goto fail;
+       }
        if (wpabuf_len(kid) != SHA256_MAC_LEN) {
                wpa_printf(MSG_DEBUG,
                           "DPP: Unexpected signedConnector JWS Protected Header kid length: %u (expected %u)",
                           (unsigned int) wpabuf_len(kid), SHA256_MAC_LEN);
+               ret = DPP_STATUS_INVALID_CONNECTOR;
                goto fail;
        }
 
@@ -4421,6 +5584,7 @@ dpp_process_signed_connector(struct dpp_signed_connector_info *info,
        if (!end) {
                wpa_printf(MSG_DEBUG,
                           "DPP: Missing dot(2) in signedConnector");
+               ret = DPP_STATUS_INVALID_CONNECTOR;
                goto fail;
        }
        signed_end = end - 1;
@@ -4429,6 +5593,7 @@ dpp_process_signed_connector(struct dpp_signed_connector_info *info,
        if (!info->payload) {
                wpa_printf(MSG_DEBUG,
                           "DPP: Failed to base64url decode signedConnector JWS Payload");
+               ret = DPP_STATUS_INVALID_CONNECTOR;
                goto fail;
        }
        wpa_hexdump_ascii(MSG_DEBUG,
@@ -4440,18 +5605,22 @@ dpp_process_signed_connector(struct dpp_signed_connector_info *info,
        if (!signature) {
                wpa_printf(MSG_DEBUG,
                           "DPP: Failed to base64url decode signedConnector signature");
+               ret = DPP_STATUS_INVALID_CONNECTOR;
                goto fail;
                }
        wpa_hexdump(MSG_DEBUG, "DPP: signedConnector - signature",
                    signature, signature_len);
 
-       if (dpp_check_pubkey_match(csign_pub, kid) < 0)
+       if (dpp_check_pubkey_match(csign_pub, kid) < 0) {
+               ret = DPP_STATUS_NO_MATCH;
                goto fail;
+       }
 
        if (signature_len & 0x01) {
                wpa_printf(MSG_DEBUG,
                           "DPP: Unexpected signedConnector signature length (%d)",
                           (int) signature_len);
+               ret = DPP_STATUS_INVALID_CONNECTOR;
                goto fail;
        }
 
@@ -4492,10 +5661,11 @@ dpp_process_signed_connector(struct dpp_signed_connector_info *info,
                wpa_printf(MSG_DEBUG,
                           "DPP: EVP_DigestVerifyFinal failed (res=%d): %s",
                           res, ERR_error_string(ERR_get_error(), NULL));
+               ret = DPP_STATUS_INVALID_CONNECTOR;
                goto fail;
        }
 
-       ret = 0;
+       ret = DPP_STATUS_OK;
 fail:
        EC_KEY_free(eckey);
        EVP_MD_CTX_destroy(md_ctx);
@@ -4522,6 +5692,13 @@ static int dpp_parse_cred_dpp(struct dpp_authentication *auth,
 
        os_memset(&info, 0, sizeof(info));
 
+       if (dpp_akm_psk(auth->akm) || dpp_akm_sae(auth->akm)) {
+               wpa_printf(MSG_DEBUG,
+                          "DPP: Legacy credential included in Connector credential");
+               if (dpp_parse_cred_legacy(auth, cred) < 0)
+                       return -1;
+       }
+
        wpa_printf(MSG_DEBUG, "DPP: Connector credential");
 
        csign = json_get_member(cred, "csign");
@@ -4554,7 +5731,7 @@ static int dpp_parse_cred_dpp(struct dpp_authentication *auth,
        }
 
        if (dpp_process_signed_connector(&info, csign_pub,
-                                        signed_connector) < 0)
+                                        signed_connector) != DPP_STATUS_OK)
                goto fail;
 
        if (dpp_parse_connector(auth, info.payload, info.payload_len) < 0) {
@@ -4576,6 +5753,45 @@ fail:
 }
 
 
+const char * dpp_akm_str(enum dpp_akm akm)
+{
+       switch (akm) {
+       case DPP_AKM_DPP:
+               return "dpp";
+       case DPP_AKM_PSK:
+               return "psk";
+       case DPP_AKM_SAE:
+               return "sae";
+       case DPP_AKM_PSK_SAE:
+               return "psk+sae";
+       case DPP_AKM_SAE_DPP:
+               return "dpp+sae";
+       case DPP_AKM_PSK_SAE_DPP:
+               return "dpp+psk+sae";
+       default:
+               return "??";
+       }
+}
+
+
+static enum dpp_akm dpp_akm_from_str(const char *akm)
+{
+       if (os_strcmp(akm, "psk") == 0)
+               return DPP_AKM_PSK;
+       if (os_strcmp(akm, "sae") == 0)
+               return DPP_AKM_SAE;
+       if (os_strcmp(akm, "psk+sae") == 0)
+               return DPP_AKM_PSK_SAE;
+       if (os_strcmp(akm, "dpp") == 0)
+               return DPP_AKM_DPP;
+       if (os_strcmp(akm, "dpp+sae") == 0)
+               return DPP_AKM_SAE_DPP;
+       if (os_strcmp(akm, "dpp+psk+sae") == 0)
+               return DPP_AKM_PSK_SAE_DPP;
+       return DPP_AKM_UNKNOWN;
+}
+
+
 static int dpp_parse_conf_obj(struct dpp_authentication *auth,
                              const u8 *conf_obj, u16 conf_obj_len)
 {
@@ -4586,38 +5802,37 @@ static int dpp_parse_conf_obj(struct dpp_authentication *auth,
        if (!root)
                return -1;
        if (root->type != JSON_OBJECT) {
-               wpa_printf(MSG_DEBUG, "DPP: JSON root is not an object");
+               dpp_auth_fail(auth, "JSON root is not an object");
                goto fail;
        }
 
        token = json_get_member(root, "wi-fi_tech");
        if (!token || token->type != JSON_STRING) {
-               wpa_printf(MSG_DEBUG, "DPP: No wi-fi_tech string value found");
+               dpp_auth_fail(auth, "No wi-fi_tech string value found");
                goto fail;
        }
        if (os_strcmp(token->string, "infra") != 0) {
                wpa_printf(MSG_DEBUG, "DPP: Unsupported wi-fi_tech value: '%s'",
                           token->string);
+               dpp_auth_fail(auth, "Unsupported wi-fi_tech value");
                goto fail;
        }
 
        discovery = json_get_member(root, "discovery");
        if (!discovery || discovery->type != JSON_OBJECT) {
-               wpa_printf(MSG_DEBUG, "DPP: No discovery object in JSON");
+               dpp_auth_fail(auth, "No discovery object in JSON");
                goto fail;
        }
 
        token = json_get_member(discovery, "ssid");
        if (!token || token->type != JSON_STRING) {
-               wpa_printf(MSG_DEBUG,
-                          "DPP: No discovery::ssid string value found");
+               dpp_auth_fail(auth, "No discovery::ssid string value found");
                goto fail;
        }
        wpa_hexdump_ascii(MSG_DEBUG, "DPP: discovery::ssid",
                          token->string, os_strlen(token->string));
        if (os_strlen(token->string) > SSID_MAX_LEN) {
-               wpa_printf(MSG_DEBUG,
-                          "DPP: Too long discovery::ssid string value");
+               dpp_auth_fail(auth, "Too long discovery::ssid string value");
                goto fail;
        }
        auth->ssid_len = os_strlen(token->string);
@@ -4625,25 +5840,27 @@ static int dpp_parse_conf_obj(struct dpp_authentication *auth,
 
        cred = json_get_member(root, "cred");
        if (!cred || cred->type != JSON_OBJECT) {
-               wpa_printf(MSG_DEBUG, "DPP: No cred object in JSON");
+               dpp_auth_fail(auth, "No cred object in JSON");
                goto fail;
        }
 
        token = json_get_member(cred, "akm");
        if (!token || token->type != JSON_STRING) {
-               wpa_printf(MSG_DEBUG,
-                          "DPP: No cred::akm string value found");
+               dpp_auth_fail(auth, "No cred::akm string value found");
                goto fail;
        }
-       if (os_strcmp(token->string, "psk") == 0) {
+       auth->akm = dpp_akm_from_str(token->string);
+
+       if (dpp_akm_legacy(auth->akm)) {
                if (dpp_parse_cred_legacy(auth, cred) < 0)
                        goto fail;
-       } else if (os_strcmp(token->string, "dpp") == 0) {
+       } else if (dpp_akm_dpp(auth->akm)) {
                if (dpp_parse_cred_dpp(auth, cred) < 0)
                        goto fail;
        } else {
                wpa_printf(MSG_DEBUG, "DPP: Unsupported akm: %s",
                           token->string);
+               dpp_auth_fail(auth, "Unsupported akm");
                goto fail;
        }
 
@@ -4666,9 +5883,10 @@ int dpp_conf_resp_rx(struct dpp_authentication *auth,
        size_t unwrapped_len = 0;
        int ret = -1;
 
+       auth->conf_resp_status = 255;
+
        if (dpp_check_attrs(wpabuf_head(resp), wpabuf_len(resp)) < 0) {
-               wpa_printf(MSG_DEBUG,
-                          "DPP: Invalid attribute in config response");
+               dpp_auth_fail(auth, "Invalid attribute in config response");
                return -1;
        }
 
@@ -4676,8 +5894,8 @@ int dpp_conf_resp_rx(struct dpp_authentication *auth,
                                    DPP_ATTR_WRAPPED_DATA,
                                    &wrapped_data_len);
        if (!wrapped_data || wrapped_data_len < AES_BLOCK_SIZE) {
-               wpa_printf(MSG_DEBUG,
-                          "DPP: Missing or invalid required Wrapped data attribute");
+               dpp_auth_fail(auth,
+                             "Missing or invalid required Wrapped Data attribute");
                return -1;
        }
 
@@ -4695,15 +5913,14 @@ int dpp_conf_resp_rx(struct dpp_authentication *auth,
        if (aes_siv_decrypt(auth->ke, auth->curve->hash_len,
                            wrapped_data, wrapped_data_len,
                            1, addr, len, unwrapped) < 0) {
-               wpa_printf(MSG_DEBUG, "DPP: AES-SIV decryption failed");
+               dpp_auth_fail(auth, "AES-SIV decryption failed");
                goto fail;
        }
        wpa_hexdump(MSG_DEBUG, "DPP: AES-SIV cleartext",
                    unwrapped, unwrapped_len);
 
        if (dpp_check_attrs(unwrapped, unwrapped_len) < 0) {
-               wpa_printf(MSG_DEBUG,
-                          "DPP: Invalid attribute in unwrapped data");
+               dpp_auth_fail(auth, "Invalid attribute in unwrapped data");
                goto fail;
        }
 
@@ -4711,34 +5928,35 @@ int dpp_conf_resp_rx(struct dpp_authentication *auth,
                               DPP_ATTR_ENROLLEE_NONCE,
                               &e_nonce_len);
        if (!e_nonce || e_nonce_len != auth->curve->nonce_len) {
-               wpa_printf(MSG_DEBUG,
-                          "DPP: Missing or invalid Enrollee Nonce attribute");
+               dpp_auth_fail(auth,
+                             "Missing or invalid Enrollee Nonce attribute");
                goto fail;
        }
        wpa_hexdump(MSG_DEBUG, "DPP: Enrollee Nonce", e_nonce, e_nonce_len);
        if (os_memcmp(e_nonce, auth->e_nonce, e_nonce_len) != 0) {
-               wpa_printf(MSG_DEBUG, "Enrollee Nonce mismatch");
+               dpp_auth_fail(auth, "Enrollee Nonce mismatch");
                goto fail;
        }
 
        status = dpp_get_attr(wpabuf_head(resp), wpabuf_len(resp),
                              DPP_ATTR_STATUS, &status_len);
        if (!status || status_len < 1) {
-               wpa_printf(MSG_DEBUG,
-                          "DPP: Missing or invalid required DPP Status attribute");
+               dpp_auth_fail(auth,
+                             "Missing or invalid required DPP Status attribute");
                goto fail;
        }
+       auth->conf_resp_status = status[0];
        wpa_printf(MSG_DEBUG, "DPP: Status %u", status[0]);
        if (status[0] != DPP_STATUS_OK) {
-               wpa_printf(MSG_DEBUG, "DPP: Configuration failed");
+               dpp_auth_fail(auth, "Configurator rejected configuration");
                goto fail;
        }
 
        conf_obj = dpp_get_attr(unwrapped, unwrapped_len,
                                DPP_ATTR_CONFIG_OBJ, &conf_obj_len);
        if (!conf_obj) {
-               wpa_printf(MSG_DEBUG,
-                          "DPP: Missing required Configuration Object attribute");
+               dpp_auth_fail(auth,
+                             "Missing required Configuration Object attribute");
                goto fail;
        }
        wpa_hexdump_ascii(MSG_DEBUG, "DPP: configurationObject JSON",
@@ -4754,6 +5972,146 @@ fail:
 }
 
 
+#ifdef CONFIG_DPP2
+enum dpp_status_error dpp_conf_result_rx(struct dpp_authentication *auth,
+                                        const u8 *hdr,
+                                        const u8 *attr_start, size_t attr_len)
+{
+       const u8 *wrapped_data, *status, *e_nonce;
+       u16 wrapped_data_len, status_len, e_nonce_len;
+       const u8 *addr[2];
+       size_t len[2];
+       u8 *unwrapped = NULL;
+       size_t unwrapped_len = 0;
+       enum dpp_status_error ret = 256;
+
+       wrapped_data = dpp_get_attr(attr_start, attr_len, DPP_ATTR_WRAPPED_DATA,
+                                   &wrapped_data_len);
+       if (!wrapped_data || wrapped_data_len < AES_BLOCK_SIZE) {
+               dpp_auth_fail(auth,
+                             "Missing or invalid required Wrapped Data attribute");
+               goto fail;
+       }
+       wpa_hexdump(MSG_DEBUG, "DPP: Wrapped data",
+                   wrapped_data, wrapped_data_len);
+
+       attr_len = wrapped_data - 4 - attr_start;
+
+       addr[0] = hdr;
+       len[0] = DPP_HDR_LEN;
+       addr[1] = attr_start;
+       len[1] = attr_len;
+       wpa_hexdump(MSG_DEBUG, "DDP: AES-SIV AD[0]", addr[0], len[0]);
+       wpa_hexdump(MSG_DEBUG, "DDP: AES-SIV AD[1]", addr[1], len[1]);
+       wpa_hexdump(MSG_DEBUG, "DPP: AES-SIV ciphertext",
+                   wrapped_data, wrapped_data_len);
+       unwrapped_len = wrapped_data_len - AES_BLOCK_SIZE;
+       unwrapped = os_malloc(unwrapped_len);
+       if (!unwrapped)
+               goto fail;
+       if (aes_siv_decrypt(auth->ke, auth->curve->hash_len,
+                           wrapped_data, wrapped_data_len,
+                           2, addr, len, unwrapped) < 0) {
+               dpp_auth_fail(auth, "AES-SIV decryption failed");
+               goto fail;
+       }
+       wpa_hexdump(MSG_DEBUG, "DPP: AES-SIV cleartext",
+                   unwrapped, unwrapped_len);
+
+       if (dpp_check_attrs(unwrapped, unwrapped_len) < 0) {
+               dpp_auth_fail(auth, "Invalid attribute in unwrapped data");
+               goto fail;
+       }
+
+       e_nonce = dpp_get_attr(unwrapped, unwrapped_len,
+                              DPP_ATTR_ENROLLEE_NONCE,
+                              &e_nonce_len);
+       if (!e_nonce || e_nonce_len != auth->curve->nonce_len) {
+               dpp_auth_fail(auth,
+                             "Missing or invalid Enrollee Nonce attribute");
+               goto fail;
+       }
+       wpa_hexdump(MSG_DEBUG, "DPP: Enrollee Nonce", e_nonce, e_nonce_len);
+       if (os_memcmp(e_nonce, auth->e_nonce, e_nonce_len) != 0) {
+               dpp_auth_fail(auth, "Enrollee Nonce mismatch");
+               wpa_hexdump(MSG_DEBUG, "DPP: Expected Enrollee Nonce",
+                           auth->e_nonce, e_nonce_len);
+               goto fail;
+       }
+
+       status = dpp_get_attr(unwrapped, unwrapped_len, DPP_ATTR_STATUS,
+                             &status_len);
+       if (!status || status_len < 1) {
+               dpp_auth_fail(auth,
+                             "Missing or invalid required DPP Status attribute");
+               goto fail;
+       }
+       wpa_printf(MSG_DEBUG, "DPP: Status %u", status[0]);
+       ret = status[0];
+
+fail:
+       bin_clear_free(unwrapped, unwrapped_len);
+       return ret;
+}
+#endif /* CONFIG_DPP2 */
+
+
+struct wpabuf * dpp_build_conf_result(struct dpp_authentication *auth,
+                                     enum dpp_status_error status)
+{
+       struct wpabuf *msg, *clear;
+       size_t nonce_len, clear_len, attr_len;
+       const u8 *addr[2];
+       size_t len[2];
+       u8 *wrapped;
+
+       nonce_len = auth->curve->nonce_len;
+       clear_len = 5 + 4 + nonce_len;
+       attr_len = 4 + clear_len + AES_BLOCK_SIZE;
+       clear = wpabuf_alloc(clear_len);
+       msg = dpp_alloc_msg(DPP_PA_CONFIGURATION_RESULT, attr_len);
+       if (!clear || !msg)
+               return NULL;
+
+       /* DPP Status */
+       dpp_build_attr_status(clear, status);
+
+       /* E-nonce */
+       wpabuf_put_le16(clear, DPP_ATTR_ENROLLEE_NONCE);
+       wpabuf_put_le16(clear, nonce_len);
+       wpabuf_put_data(clear, auth->e_nonce, nonce_len);
+
+       /* OUI, OUI type, Crypto Suite, DPP frame type */
+       addr[0] = wpabuf_head_u8(msg) + 2;
+       len[0] = 3 + 1 + 1 + 1;
+       wpa_hexdump(MSG_DEBUG, "DDP: AES-SIV AD[0]", addr[0], len[0]);
+
+       /* Attributes before Wrapped Data (none) */
+       addr[1] = wpabuf_put(msg, 0);
+       len[1] = 0;
+       wpa_hexdump(MSG_DEBUG, "DDP: AES-SIV AD[1]", addr[1], len[1]);
+
+       /* Wrapped Data */
+       wpabuf_put_le16(msg, DPP_ATTR_WRAPPED_DATA);
+       wpabuf_put_le16(msg, wpabuf_len(clear) + AES_BLOCK_SIZE);
+       wrapped = wpabuf_put(msg, wpabuf_len(clear) + AES_BLOCK_SIZE);
+
+       wpa_hexdump_buf(MSG_DEBUG, "DPP: AES-SIV cleartext", clear);
+       if (aes_siv_encrypt(auth->ke, auth->curve->hash_len,
+                           wpabuf_head(clear), wpabuf_len(clear),
+                           2, addr, len, wrapped) < 0)
+               goto fail;
+
+       wpa_hexdump_buf(MSG_DEBUG, "DPP: Configuration Result attributes", msg);
+       wpabuf_free(clear);
+       return msg;
+fail:
+       wpabuf_free(clear);
+       wpabuf_free(msg);
+       return NULL;
+}
+
+
 void dpp_configurator_free(struct dpp_configurator *conf)
 {
        if (!conf)
@@ -4764,6 +6122,30 @@ void dpp_configurator_free(struct dpp_configurator *conf)
 }
 
 
+int dpp_configurator_get_key(const struct dpp_configurator *conf, char *buf,
+                            size_t buflen)
+{
+       EC_KEY *eckey;
+       int key_len, ret = -1;
+       unsigned char *key = NULL;
+
+       if (!conf->csign)
+               return -1;
+
+       eckey = EVP_PKEY_get1_EC_KEY(conf->csign);
+       if (!eckey)
+               return -1;
+
+       key_len = i2d_ECPrivateKey(eckey, &key);
+       if (key_len > 0)
+               ret = wpa_snprintf_hex(buf, buflen, key, key_len);
+
+       EC_KEY_free(eckey);
+       OPENSSL_free(key);
+       return ret;
+}
+
+
 struct dpp_configurator *
 dpp_keygen_configurator(const char *curve, const u8 *privkey,
                        size_t privkey_len)
@@ -4785,6 +6167,7 @@ dpp_keygen_configurator(const char *curve, const u8 *privkey,
                if (!conf->curve) {
                        wpa_printf(MSG_INFO, "DPP: Unsupported curve: %s",
                                   curve);
+                       os_free(conf);
                        return NULL;
                }
        }
@@ -4827,7 +6210,7 @@ fail:
 
 
 int dpp_configurator_own_config(struct dpp_authentication *auth,
-                               const char *curve)
+                               const char *curve, int ap)
 {
        struct wpabuf *conf_obj;
        int ret = -1;
@@ -4858,7 +6241,7 @@ int dpp_configurator_own_config(struct dpp_authentication *auth,
        auth->peer_protocol_key = auth->own_protocol_key;
        dpp_copy_csign(auth, auth->conf->csign);
 
-       conf_obj = dpp_build_conf_obj(auth, 0);
+       conf_obj = dpp_build_conf_obj(auth, ap);
        if (!conf_obj)
                goto fail;
        ret = dpp_parse_conf_obj(auth, wpabuf_head(conf_obj),
@@ -5021,15 +6404,16 @@ fail:
 }
 
 
-int dpp_peer_intro(struct dpp_introduction *intro, const char *own_connector,
-                  const u8 *net_access_key, size_t net_access_key_len,
-                  const u8 *csign_key, size_t csign_key_len,
-                  const u8 *peer_connector, size_t peer_connector_len,
-                  os_time_t *expiry)
+enum dpp_status_error
+dpp_peer_intro(struct dpp_introduction *intro, const char *own_connector,
+              const u8 *net_access_key, size_t net_access_key_len,
+              const u8 *csign_key, size_t csign_key_len,
+              const u8 *peer_connector, size_t peer_connector_len,
+              os_time_t *expiry)
 {
        struct json_token *root = NULL, *netkey, *token;
        struct json_token *own_root = NULL;
-       int ret = -1;
+       enum dpp_status_error ret = 255, res;
        EVP_PKEY *own_key = NULL, *peer_key = NULL;
        struct wpabuf *own_key_pub = NULL;
        const struct dpp_curve_params *curve, *own_curve;
@@ -5097,18 +6481,23 @@ int dpp_peer_intro(struct dpp_introduction *intro, const char *own_connector,
        os_memcpy(signed_connector, peer_connector, peer_connector_len);
        signed_connector[peer_connector_len] = '\0';
 
-       if (dpp_process_signed_connector(&info, csign, signed_connector) < 0)
+       res = dpp_process_signed_connector(&info, csign, signed_connector);
+       if (res != DPP_STATUS_OK) {
+               ret = res;
                goto fail;
+       }
 
        root = json_parse((const char *) info.payload, info.payload_len);
        if (!root) {
                wpa_printf(MSG_DEBUG, "DPP: JSON parsing of connector failed");
+               ret = DPP_STATUS_INVALID_CONNECTOR;
                goto fail;
        }
 
        if (!dpp_connector_match_groups(own_root, root)) {
                wpa_printf(MSG_DEBUG,
                           "DPP: Peer connector does not include compatible group netrole with own connector");
+               ret = DPP_STATUS_NO_MATCH;
                goto fail;
        }
 
@@ -5121,6 +6510,7 @@ int dpp_peer_intro(struct dpp_introduction *intro, const char *own_connector,
                if (dpp_key_expired(token->string, expiry)) {
                        wpa_printf(MSG_DEBUG,
                                   "DPP: Connector (netAccessKey) has expired");
+                       ret = DPP_STATUS_INVALID_CONNECTOR;
                        goto fail;
                }
        }
@@ -5128,18 +6518,22 @@ int dpp_peer_intro(struct dpp_introduction *intro, const char *own_connector,
        netkey = json_get_member(root, "netAccessKey");
        if (!netkey || netkey->type != JSON_OBJECT) {
                wpa_printf(MSG_DEBUG, "DPP: No netAccessKey object found");
+               ret = DPP_STATUS_INVALID_CONNECTOR;
                goto fail;
        }
 
        peer_key = dpp_parse_jwk(netkey, &curve);
-       if (!peer_key)
+       if (!peer_key) {
+               ret = DPP_STATUS_INVALID_CONNECTOR;
                goto fail;
+       }
        dpp_debug_print_key("DPP: Received netAccessKey", peer_key);
 
        if (own_curve != curve) {
                wpa_printf(MSG_DEBUG,
                           "DPP: Mismatching netAccessKey curves (%s != %s)",
                           own_curve->name, curve->name);
+               ret = DPP_STATUS_INVALID_CONNECTOR;
                goto fail;
        }
 
@@ -5173,9 +6567,9 @@ int dpp_peer_intro(struct dpp_introduction *intro, const char *own_connector,
                goto fail;
        }
 
-       ret = 0;
+       ret = DPP_STATUS_OK;
 fail:
-       if (ret < 0)
+       if (ret != DPP_STATUS_OK)
                os_memset(intro, 0, sizeof(*intro));
        os_memset(Nx, 0, sizeof(Nx));
        EVP_PKEY_CTX_free(ctx);
@@ -5198,6 +6592,7 @@ static EVP_PKEY * dpp_pkex_get_role_elem(const struct dpp_curve_params *curve,
        EC_GROUP *group;
        size_t len = curve->prime_len;
        const u8 *x, *y;
+       EVP_PKEY *res;
 
        switch (curve->ike_group) {
        case 19:
@@ -5231,14 +6626,16 @@ static EVP_PKEY * dpp_pkex_get_role_elem(const struct dpp_curve_params *curve,
        group = EC_GROUP_new_by_curve_name(OBJ_txt2nid(curve->name));
        if (!group)
                return NULL;
-       return dpp_set_pubkey_point_group(group, x, y, len);
+       res = dpp_set_pubkey_point_group(group, x, y, len);
+       EC_GROUP_free(group);
+       return res;
 }
 
 
 static EC_POINT * dpp_pkex_derive_Qi(const struct dpp_curve_params *curve,
                                     const u8 *mac_init, const char *code,
                                     const char *identifier, BN_CTX *bnctx,
-                                    const EC_GROUP **ret_group)
+                                    EC_GROUP **ret_group)
 {
        u8 hash[DPP_MAX_HASH_LEN];
        const u8 *addr[3];
@@ -5299,15 +6696,18 @@ static EC_POINT * dpp_pkex_derive_Qi(const struct dpp_curve_params *curve,
            EC_POINT_mul(group2, Qi, NULL, Pi_point, hash_bn, bnctx) != 1)
                goto fail;
        if (EC_POINT_is_at_infinity(group, Qi)) {
-               wpa_printf(MSG_INFO, "PDP: Qi is the point-at-infinity");
+               wpa_printf(MSG_INFO, "DPP: Qi is the point-at-infinity");
                goto fail;
        }
+       dpp_debug_print_point("DPP: Qi", group, Qi);
 out:
        EC_KEY_free(Pi_ec);
        EVP_PKEY_free(Pi);
        BN_clear_free(hash_bn);
-       if (ret_group)
+       if (ret_group && Qi)
                *ret_group = group2;
+       else
+               EC_GROUP_free(group2);
        return Qi;
 fail:
        EC_POINT_free(Qi);
@@ -5319,7 +6719,7 @@ fail:
 static EC_POINT * dpp_pkex_derive_Qr(const struct dpp_curve_params *curve,
                                     const u8 *mac_resp, const char *code,
                                     const char *identifier, BN_CTX *bnctx,
-                                    const EC_GROUP **ret_group)
+                                    EC_GROUP **ret_group)
 {
        u8 hash[DPP_MAX_HASH_LEN];
        const u8 *addr[3];
@@ -5379,12 +6779,19 @@ static EC_POINT * dpp_pkex_derive_Qr(const struct dpp_curve_params *curve,
        if (!hash_bn ||
            EC_POINT_mul(group2, Qr, NULL, Pr_point, hash_bn, bnctx) != 1)
                goto fail;
+       if (EC_POINT_is_at_infinity(group, Qr)) {
+               wpa_printf(MSG_INFO, "DPP: Qr is the point-at-infinity");
+               goto fail;
+       }
+       dpp_debug_print_point("DPP: Qr", group, Qr);
 out:
        EC_KEY_free(Pr_ec);
        EVP_PKEY_free(Pr);
        BN_clear_free(hash_bn);
-       if (ret_group)
+       if (ret_group && Qr)
                *ret_group = group2;
+       else
+               EC_GROUP_free(group2);
        return Qr;
 fail:
        EC_POINT_free(Qr);
@@ -5393,43 +6800,124 @@ fail:
 }
 
 
-static struct wpabuf * dpp_pkex_build_exchange_req(struct dpp_pkex *pkex)
+#ifdef CONFIG_TESTING_OPTIONS
+static int dpp_test_gen_invalid_key(struct wpabuf *msg,
+                                   const struct dpp_curve_params *curve)
 {
-       EC_KEY *X_ec = NULL;
-       const EC_POINT *X_point;
-       BN_CTX *bnctx = NULL;
-       const EC_GROUP *group;
-       EC_POINT *Qi = NULL, *M = NULL;
-       struct wpabuf *M_buf = NULL;
-       BIGNUM *Mx = NULL, *My = NULL;
-       struct wpabuf *msg = NULL;
-       size_t attr_len;
-       const struct dpp_curve_params *curve = pkex->own_bi->curve;
-       int num_bytes, offset;
+       BN_CTX *ctx;
+       BIGNUM *x, *y;
+       int ret = -1;
+       EC_GROUP *group;
+       EC_POINT *point;
 
-       wpa_printf(MSG_DEBUG, "DPP: Build PKEX Exchange Request");
+       group = EC_GROUP_new_by_curve_name(OBJ_txt2nid(curve->name));
+       if (!group)
+               return -1;
 
-       /* Qi = H(MAC-Initiator | [identifier |] code) * Pi */
-       bnctx = BN_CTX_new();
-       if (!bnctx)
-               goto fail;
-       Qi = dpp_pkex_derive_Qi(curve, pkex->own_mac, pkex->code,
-                               pkex->identifier, bnctx, &group);
-       if (!Qi)
+       ctx = BN_CTX_new();
+       point = EC_POINT_new(group);
+       x = BN_new();
+       y = BN_new();
+       if (!ctx || !point || !x || !y)
                goto fail;
 
-       /* Generate a random ephemeral keypair x/X */
-       pkex->x = dpp_gen_keypair(curve);
-       if (!pkex->x)
+       if (BN_rand(x, curve->prime_len * 8, 0, 0) != 1)
                goto fail;
 
-       /* M = X + Qi */
-       X_ec = EVP_PKEY_get1_EC_KEY(pkex->x);
-       if (!X_ec)
+       /* Generate a random y coordinate that results in a point that is not
+        * on the curve. */
+       for (;;) {
+               if (BN_rand(y, curve->prime_len * 8, 0, 0) != 1)
+                       goto fail;
+
+               if (EC_POINT_set_affine_coordinates_GFp(group, point, x, y,
+                                                       ctx) != 1) {
+#if OPENSSL_VERSION_NUMBER >= 0x10100000L || defined(OPENSSL_IS_BORINGSSL)
+               /* Unlike older OpenSSL versions, OpenSSL 1.1.1 and BoringSSL
+                * return an error from EC_POINT_set_affine_coordinates_GFp()
+                * when the point is not on the curve. */
+                       break;
+#else /* >=1.1.0 or OPENSSL_IS_BORINGSSL */
+                       goto fail;
+#endif /* >= 1.1.0 or OPENSSL_IS_BORINGSSL */
+               }
+
+               if (!EC_POINT_is_on_curve(group, point, ctx))
+                       break;
+       }
+
+       if (dpp_bn2bin_pad(x, wpabuf_put(msg, curve->prime_len),
+                          curve->prime_len) < 0 ||
+           dpp_bn2bin_pad(y, wpabuf_put(msg, curve->prime_len),
+                          curve->prime_len) < 0)
+               goto fail;
+
+       ret = 0;
+fail:
+       if (ret < 0)
+               wpa_printf(MSG_INFO, "DPP: Failed to generate invalid key");
+       BN_free(x);
+       BN_free(y);
+       EC_POINT_free(point);
+       BN_CTX_free(ctx);
+       EC_GROUP_free(group);
+
+       return ret;
+}
+#endif /* CONFIG_TESTING_OPTIONS */
+
+
+static struct wpabuf * dpp_pkex_build_exchange_req(struct dpp_pkex *pkex)
+{
+       EC_KEY *X_ec = NULL;
+       const EC_POINT *X_point;
+       BN_CTX *bnctx = NULL;
+       EC_GROUP *group = NULL;
+       EC_POINT *Qi = NULL, *M = NULL;
+       struct wpabuf *M_buf = NULL;
+       BIGNUM *Mx = NULL, *My = NULL;
+       struct wpabuf *msg = NULL;
+       size_t attr_len;
+       const struct dpp_curve_params *curve = pkex->own_bi->curve;
+
+       wpa_printf(MSG_DEBUG, "DPP: Build PKEX Exchange Request");
+
+       /* Qi = H(MAC-Initiator | [identifier |] code) * Pi */
+       bnctx = BN_CTX_new();
+       if (!bnctx)
+               goto fail;
+       Qi = dpp_pkex_derive_Qi(curve, pkex->own_mac, pkex->code,
+                               pkex->identifier, bnctx, &group);
+       if (!Qi)
+               goto fail;
+
+       /* Generate a random ephemeral keypair x/X */
+#ifdef CONFIG_TESTING_OPTIONS
+       if (dpp_pkex_ephemeral_key_override_len) {
+               const struct dpp_curve_params *tmp_curve;
+
+               wpa_printf(MSG_INFO,
+                          "DPP: TESTING - override ephemeral key x/X");
+               pkex->x = dpp_set_keypair(&tmp_curve,
+                                         dpp_pkex_ephemeral_key_override,
+                                         dpp_pkex_ephemeral_key_override_len);
+       } else {
+               pkex->x = dpp_gen_keypair(curve);
+       }
+#else /* CONFIG_TESTING_OPTIONS */
+       pkex->x = dpp_gen_keypair(curve);
+#endif /* CONFIG_TESTING_OPTIONS */
+       if (!pkex->x)
+               goto fail;
+
+       /* M = X + Qi */
+       X_ec = EVP_PKEY_get1_EC_KEY(pkex->x);
+       if (!X_ec)
                goto fail;
        X_point = EC_KEY_get0_public_key(X_ec);
        if (!X_point)
                goto fail;
+       dpp_debug_print_point("DPP: X", group, X_point);
        M = EC_POINT_new(group);
        Mx = BN_new();
        My = BN_new();
@@ -5437,6 +6925,7 @@ static struct wpabuf * dpp_pkex_build_exchange_req(struct dpp_pkex *pkex)
            EC_POINT_add(group, M, X_point, Qi, bnctx) != 1 ||
            EC_POINT_get_affine_coordinates_GFp(group, M, Mx, My, bnctx) != 1)
                goto fail;
+       dpp_debug_print_point("DPP: M", group, M);
 
        /* Initiator -> Responder: group, [identifier,] M */
        attr_len = 4 + 2;
@@ -5447,11 +6936,22 @@ static struct wpabuf * dpp_pkex_build_exchange_req(struct dpp_pkex *pkex)
        if (!msg)
                goto fail;
 
+#ifdef CONFIG_TESTING_OPTIONS
+       if (dpp_test == DPP_TEST_NO_FINITE_CYCLIC_GROUP_PKEX_EXCHANGE_REQ) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - no Finite Cyclic Group");
+               goto skip_finite_cyclic_group;
+       }
+#endif /* CONFIG_TESTING_OPTIONS */
+
        /* Finite Cyclic Group attribute */
        wpabuf_put_le16(msg, DPP_ATTR_FINITE_CYCLIC_GROUP);
        wpabuf_put_le16(msg, 2);
        wpabuf_put_le16(msg, curve->ike_group);
 
+#ifdef CONFIG_TESTING_OPTIONS
+skip_finite_cyclic_group:
+#endif /* CONFIG_TESTING_OPTIONS */
+
        /* Code Identifier attribute */
        if (pkex->identifier) {
                wpabuf_put_le16(msg, DPP_ATTR_CODE_IDENTIFIER);
@@ -5459,31 +6959,32 @@ static struct wpabuf * dpp_pkex_build_exchange_req(struct dpp_pkex *pkex)
                wpabuf_put_str(msg, pkex->identifier);
        }
 
+#ifdef CONFIG_TESTING_OPTIONS
+       if (dpp_test == DPP_TEST_NO_ENCRYPTED_KEY_PKEX_EXCHANGE_REQ) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - no Encrypted Key");
+               goto out;
+       }
+#endif /* CONFIG_TESTING_OPTIONS */
+
        /* M in Encrypted Key attribute */
        wpabuf_put_le16(msg, DPP_ATTR_ENCRYPTED_KEY);
        wpabuf_put_le16(msg, 2 * curve->prime_len);
 
-       num_bytes = BN_num_bytes(Mx);
-       if ((size_t) num_bytes > curve->prime_len)
-               goto fail;
-       if (curve->prime_len > (size_t) num_bytes)
-               offset = curve->prime_len - num_bytes;
-       else
-               offset = 0;
-       os_memset(wpabuf_put(msg, offset), 0, offset);
-       BN_bn2bin(Mx, wpabuf_put(msg, num_bytes));
-       os_memset(pkex->Mx, 0, offset);
-       BN_bn2bin(Mx, pkex->Mx + offset);
+#ifdef CONFIG_TESTING_OPTIONS
+       if (dpp_test == DPP_TEST_INVALID_ENCRYPTED_KEY_PKEX_EXCHANGE_REQ) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - invalid Encrypted Key");
+               if (dpp_test_gen_invalid_key(msg, curve) < 0)
+                       goto fail;
+               goto out;
+       }
+#endif /* CONFIG_TESTING_OPTIONS */
 
-       num_bytes = BN_num_bytes(My);
-       if ((size_t) num_bytes > curve->prime_len)
+       if (dpp_bn2bin_pad(Mx, wpabuf_put(msg, curve->prime_len),
+                          curve->prime_len) < 0 ||
+           dpp_bn2bin_pad(Mx, pkex->Mx, curve->prime_len) < 0 ||
+           dpp_bn2bin_pad(My, wpabuf_put(msg, curve->prime_len),
+                          curve->prime_len) < 0)
                goto fail;
-       if (curve->prime_len > (size_t) num_bytes)
-               offset = curve->prime_len - num_bytes;
-       else
-               offset = 0;
-       os_memset(wpabuf_put(msg, offset), 0, offset);
-       BN_bn2bin(My, wpabuf_put(msg, num_bytes));
 
 out:
        wpabuf_free(M_buf);
@@ -5493,6 +6994,7 @@ out:
        BN_clear_free(Mx);
        BN_clear_free(My);
        BN_CTX_free(bnctx);
+       EC_GROUP_free(group);
        return msg;
 fail:
        wpa_printf(MSG_INFO, "DPP: Failed to build PKEX Exchange Request");
@@ -5502,16 +7004,31 @@ fail:
 }
 
 
-struct dpp_pkex * dpp_pkex_init(struct dpp_bootstrap_info *bi,
+static void dpp_pkex_fail(struct dpp_pkex *pkex, const char *txt)
+{
+       wpa_msg(pkex->msg_ctx, MSG_INFO, DPP_EVENT_FAIL "%s", txt);
+}
+
+
+struct dpp_pkex * dpp_pkex_init(void *msg_ctx, struct dpp_bootstrap_info *bi,
                                const u8 *own_mac,
                                const char *identifier,
                                const char *code)
 {
        struct dpp_pkex *pkex;
 
+#ifdef CONFIG_TESTING_OPTIONS
+       if (!is_zero_ether_addr(dpp_pkex_own_mac_override)) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - own_mac override " MACSTR,
+                          MAC2STR(dpp_pkex_own_mac_override));
+               own_mac = dpp_pkex_own_mac_override;
+       }
+#endif /* CONFIG_TESTING_OPTIONS */
+
        pkex = os_zalloc(sizeof(*pkex));
        if (!pkex)
                return NULL;
+       pkex->msg_ctx = msg_ctx;
        pkex->initiator = 1;
        pkex->own_bi = bi;
        os_memcpy(pkex->own_mac, own_mac, ETH_ALEN);
@@ -5533,158 +7050,42 @@ fail:
 }
 
 
-struct dpp_pkex * dpp_pkex_rx_exchange_req(struct dpp_bootstrap_info *bi,
-                                          const u8 *own_mac,
-                                          const u8 *peer_mac,
-                                          const char *identifier,
-                                          const char *code,
-                                          const u8 *buf, size_t len)
+static struct wpabuf *
+dpp_pkex_build_exchange_resp(struct dpp_pkex *pkex,
+                            enum dpp_status_error status,
+                            const BIGNUM *Nx, const BIGNUM *Ny)
 {
-       const u8 *attr_group, *attr_id, *attr_key;
-       u16 attr_group_len, attr_id_len, attr_key_len;
-       const struct dpp_curve_params *curve = bi->curve;
-       u16 ike_group;
-       struct dpp_pkex *pkex = NULL;
-       EC_POINT *Qi = NULL, *Qr = NULL, *M = NULL, *X = NULL, *N = NULL;
-       BN_CTX *bnctx = NULL;
-       const EC_GROUP *group;
-       BIGNUM *Mx = NULL, *My = NULL;
-       EC_KEY *Y_ec = NULL, *X_ec = NULL;;
-       const EC_POINT *Y_point;
-       BIGNUM *Nx = NULL, *Ny = NULL;
        struct wpabuf *msg = NULL;
        size_t attr_len;
-       int num_bytes, offset;
-
-       attr_id = dpp_get_attr(buf, len, DPP_ATTR_CODE_IDENTIFIER,
-                              &attr_id_len);
-       if (!attr_id && identifier) {
-               wpa_printf(MSG_DEBUG,
-                          "DPP: No PKEX code identifier received, but expected one");
-               return NULL;
-       }
-       if (attr_id && identifier &&
-           (os_strlen(identifier) != attr_id_len ||
-            os_memcmp(identifier, attr_id, attr_id_len) != 0)) {
-               wpa_printf(MSG_DEBUG, "DPP: PKEX code identifier mismatch");
-               return NULL;
-       }
-
-       attr_group = dpp_get_attr(buf, len, DPP_ATTR_FINITE_CYCLIC_GROUP,
-                                 &attr_group_len);
-       if (!attr_group || attr_group_len != 2) {
-               wpa_printf(MSG_DEBUG,
-                          "DPP: Missing or invalid Finite Cyclic Group attribute");
-               return NULL;
-       }
-       ike_group = WPA_GET_LE16(attr_group);
-       if (ike_group != curve->ike_group) {
-               wpa_printf(MSG_DEBUG,
-                          "DPP: Mismatching PKEX curve: peer=%u own=%u",
-                          ike_group, curve->ike_group);
-               /* TODO: error response with suggested curve:
-                * DPP Status, group */
-               return NULL;
-       }
-
-       /* M in Encrypted Key attribute */
-       attr_key = dpp_get_attr(buf, len, DPP_ATTR_ENCRYPTED_KEY,
-                               &attr_key_len);
-       if (!attr_key || attr_key_len & 0x01 || attr_key_len < 2 ||
-           attr_key_len / 2 > DPP_MAX_SHARED_SECRET_LEN) {
-               wpa_printf(MSG_DEBUG, "DPP: Missing Encrypted Key attribute");
-               return NULL;
-       }
-
-       /* Qi = H(MAC-Initiator | [identifier |] code) * Pi */
-       bnctx = BN_CTX_new();
-       if (!bnctx)
-               goto fail;
-       Qi = dpp_pkex_derive_Qi(curve, peer_mac, code, identifier, bnctx,
-                               &group);
-       if (!Qi)
-               goto fail;
-
-       /* X' = M - Qi */
-       X = EC_POINT_new(group);
-       M = EC_POINT_new(group);
-       Mx = BN_bin2bn(attr_key, attr_key_len / 2, NULL);
-       My = BN_bin2bn(attr_key + attr_key_len / 2, attr_key_len / 2, NULL);
-       if (!X || !M || !Mx || !My ||
-           EC_POINT_set_affine_coordinates_GFp(group, M, Mx, My, bnctx) != 1 ||
-           EC_POINT_is_at_infinity(group, M) ||
-           !EC_POINT_is_on_curve(group, M, bnctx) ||
-           EC_POINT_invert(group, Qi, bnctx) != 1 ||
-           EC_POINT_add(group, X, M, Qi, bnctx) != 1 ||
-           EC_POINT_is_at_infinity(group, X) ||
-           !EC_POINT_is_on_curve(group, X, bnctx))
-               goto fail;
-
-       pkex = os_zalloc(sizeof(*pkex));
-       if (!pkex)
-               goto fail;
-       pkex->own_bi = bi;
-       os_memcpy(pkex->own_mac, own_mac, ETH_ALEN);
-       os_memcpy(pkex->peer_mac, peer_mac, ETH_ALEN);
-       if (identifier) {
-               pkex->identifier = os_strdup(identifier);
-               if (!pkex->identifier)
-                       goto fail;
-       }
-       pkex->code = os_strdup(code);
-       if (!pkex->code)
-               goto fail;
-
-       os_memcpy(pkex->Mx, attr_key, attr_key_len / 2);
-
-       X_ec = EC_KEY_new();
-       if (!X_ec ||
-           EC_KEY_set_group(X_ec, group) != 1 ||
-           EC_KEY_set_public_key(X_ec, X) != 1)
-               goto fail;
-       pkex->x = EVP_PKEY_new();
-       if (!pkex->x ||
-           EVP_PKEY_set1_EC_KEY(pkex->x, X_ec) != 1)
-               goto fail;
-
-       /* Qr = H(MAC-Responder | | [identifier | ] code) * Pr */
-       Qr = dpp_pkex_derive_Qr(curve, own_mac, code, identifier, bnctx, NULL);
-       if (!Qr)
-               goto fail;
-
-       /* Generate a random ephemeral keypair y/Y */
-       pkex->y = dpp_gen_keypair(curve);
-       if (!pkex->y)
-               goto fail;
-
-       /* N = Y + Qr */
-       Y_ec = EVP_PKEY_get1_EC_KEY(pkex->y);
-       if (!Y_ec)
-               goto fail;
-       Y_point = EC_KEY_get0_public_key(Y_ec);
-       if (!Y_point)
-               goto fail;
-       N = EC_POINT_new(group);
-       Nx = BN_new();
-       Ny = BN_new();
-       if (!N || !Nx || !Ny ||
-           EC_POINT_add(group, N, Y_point, Qr, bnctx) != 1 ||
-           EC_POINT_get_affine_coordinates_GFp(group, N, Nx, Ny, bnctx) != 1)
-               goto fail;
+       const struct dpp_curve_params *curve = pkex->own_bi->curve;
 
        /* Initiator -> Responder: DPP Status, [identifier,] N */
        attr_len = 4 + 1;
-       if (identifier)
-               attr_len += 4 + os_strlen(identifier);
+       if (pkex->identifier)
+               attr_len += 4 + os_strlen(pkex->identifier);
        attr_len += 4 + 2 * curve->prime_len;
        msg = dpp_alloc_msg(DPP_PA_PKEX_EXCHANGE_RESP, attr_len);
        if (!msg)
                goto fail;
 
+#ifdef CONFIG_TESTING_OPTIONS
+       if (dpp_test == DPP_TEST_NO_STATUS_PKEX_EXCHANGE_RESP) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - no Status");
+               goto skip_status;
+       }
+
+       if (dpp_test == DPP_TEST_INVALID_STATUS_PKEX_EXCHANGE_RESP) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - invalid Status");
+               status = 255;
+       }
+#endif /* CONFIG_TESTING_OPTIONS */
+
        /* DPP Status */
-       wpabuf_put_le16(msg, DPP_ATTR_STATUS);
-       wpabuf_put_le16(msg, 1);
-       wpabuf_put_u8(msg, DPP_STATUS_OK);
+       dpp_build_attr_status(msg, status);
+
+#ifdef CONFIG_TESTING_OPTIONS
+skip_status:
+#endif /* CONFIG_TESTING_OPTIONS */
 
        /* Code Identifier attribute */
        if (pkex->identifier) {
@@ -5693,56 +7094,48 @@ struct dpp_pkex * dpp_pkex_rx_exchange_req(struct dpp_bootstrap_info *bi,
                wpabuf_put_str(msg, pkex->identifier);
        }
 
+       if (status != DPP_STATUS_OK)
+               goto skip_encrypted_key;
+
+#ifdef CONFIG_TESTING_OPTIONS
+       if (dpp_test == DPP_TEST_NO_ENCRYPTED_KEY_PKEX_EXCHANGE_RESP) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - no Encrypted Key");
+               goto skip_encrypted_key;
+       }
+#endif /* CONFIG_TESTING_OPTIONS */
+
        /* N in Encrypted Key attribute */
        wpabuf_put_le16(msg, DPP_ATTR_ENCRYPTED_KEY);
        wpabuf_put_le16(msg, 2 * curve->prime_len);
 
-       num_bytes = BN_num_bytes(Nx);
-       if ((size_t) num_bytes > curve->prime_len)
-               goto fail;
-       if (curve->prime_len > (size_t) num_bytes)
-               offset = curve->prime_len - num_bytes;
-       else
-               offset = 0;
-       os_memset(wpabuf_put(msg, offset), 0, offset);
-       BN_bn2bin(Nx, wpabuf_put(msg, num_bytes));
-       os_memset(pkex->Nx, 0, offset);
-       BN_bn2bin(Nx, pkex->Nx + offset);
+#ifdef CONFIG_TESTING_OPTIONS
+       if (dpp_test == DPP_TEST_INVALID_ENCRYPTED_KEY_PKEX_EXCHANGE_RESP) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - invalid Encrypted Key");
+               if (dpp_test_gen_invalid_key(msg, curve) < 0)
+                       goto fail;
+               goto skip_encrypted_key;
+       }
+#endif /* CONFIG_TESTING_OPTIONS */
 
-       num_bytes = BN_num_bytes(Ny);
-       if ((size_t) num_bytes > curve->prime_len)
+       if (dpp_bn2bin_pad(Nx, wpabuf_put(msg, curve->prime_len),
+                          curve->prime_len) < 0 ||
+           dpp_bn2bin_pad(Nx, pkex->Nx, curve->prime_len) < 0 ||
+           dpp_bn2bin_pad(Ny, wpabuf_put(msg, curve->prime_len),
+                          curve->prime_len) < 0)
                goto fail;
-       if (curve->prime_len > (size_t) num_bytes)
-               offset = curve->prime_len - num_bytes;
-       else
-               offset = 0;
-       os_memset(wpabuf_put(msg, offset), 0, offset);
-       BN_bn2bin(Ny, wpabuf_put(msg, num_bytes));
 
-       pkex->exchange_resp = msg;
-       msg = NULL;
-       pkex->exchange_done = 1;
+skip_encrypted_key:
+       if (status == DPP_STATUS_BAD_GROUP) {
+               /* Finite Cyclic Group attribute */
+               wpabuf_put_le16(msg, DPP_ATTR_FINITE_CYCLIC_GROUP);
+               wpabuf_put_le16(msg, 2);
+               wpabuf_put_le16(msg, curve->ike_group);
+       }
 
-out:
+       return msg;
+fail:
        wpabuf_free(msg);
-       BN_CTX_free(bnctx);
-       EC_POINT_free(Qi);
-       EC_POINT_free(Qr);
-       BN_free(Mx);
-       BN_free(My);
-       BN_free(Nx);
-       BN_free(Ny);
-       EC_POINT_free(M);
-       EC_POINT_free(N);
-       EC_POINT_free(X);
-       EC_KEY_free(X_ec);
-       EC_KEY_free(Y_ec);
-       return pkex;
-fail:
-       wpa_printf(MSG_DEBUG, "DPP: PKEX Exchange Request processing faileed");
-       dpp_pkex_free(pkex);
-       pkex = NULL;
-       goto out;
+       return NULL;
 }
 
 
@@ -5805,140 +7198,226 @@ static int dpp_pkex_derive_z(const u8 *mac_init, const u8 *mac_resp,
 }
 
 
-struct wpabuf * dpp_pkex_rx_exchange_resp(struct dpp_pkex *pkex,
-                                         const u8 *buf, size_t buflen)
+static int dpp_pkex_identifier_match(const u8 *attr_id, u16 attr_id_len,
+                                    const char *identifier)
 {
-       const u8 *attr_status, *attr_id, *attr_key;
-       u16 attr_status_len, attr_id_len, attr_key_len;
-       const EC_GROUP *group;
+       if (!attr_id && identifier) {
+               wpa_printf(MSG_DEBUG,
+                          "DPP: No PKEX code identifier received, but expected one");
+               return 0;
+       }
+
+       if (attr_id && !identifier) {
+               wpa_printf(MSG_DEBUG,
+                          "DPP: PKEX code identifier received, but not expecting one");
+               return 0;
+       }
+
+       if (attr_id && identifier &&
+           (os_strlen(identifier) != attr_id_len ||
+            os_memcmp(identifier, attr_id, attr_id_len) != 0)) {
+               wpa_printf(MSG_DEBUG, "DPP: PKEX code identifier mismatch");
+               return 0;
+       }
+
+       return 1;
+}
+
+
+struct dpp_pkex * dpp_pkex_rx_exchange_req(void *msg_ctx,
+                                          struct dpp_bootstrap_info *bi,
+                                          const u8 *own_mac,
+                                          const u8 *peer_mac,
+                                          const char *identifier,
+                                          const char *code,
+                                          const u8 *buf, size_t len)
+{
+       const u8 *attr_group, *attr_id, *attr_key;
+       u16 attr_group_len, attr_id_len, attr_key_len;
+       const struct dpp_curve_params *curve = bi->curve;
+       u16 ike_group;
+       struct dpp_pkex *pkex = NULL;
+       EC_POINT *Qi = NULL, *Qr = NULL, *M = NULL, *X = NULL, *N = NULL;
        BN_CTX *bnctx = NULL;
-       size_t clear_len, attr_len;
-       struct wpabuf *clear = NULL;
-       u8 *wrapped;
-       struct wpabuf *msg = NULL, *A_pub = NULL, *X_pub = NULL, *Y_pub = NULL;
-       const struct dpp_curve_params *curve = pkex->own_bi->curve;
-       EC_POINT *Qr = NULL, *Y = NULL, *N = NULL;
+       EC_GROUP *group = NULL;
+       BIGNUM *Mx = NULL, *My = NULL;
+       EC_KEY *Y_ec = NULL, *X_ec = NULL;;
+       const EC_POINT *Y_point;
        BIGNUM *Nx = NULL, *Ny = NULL;
-       EVP_PKEY_CTX *ctx = NULL;
-       EC_KEY *Y_ec = NULL;
-       size_t Jx_len, Kx_len;
-       u8 Jx[DPP_MAX_SHARED_SECRET_LEN], Kx[DPP_MAX_SHARED_SECRET_LEN];
-       const u8 *addr[4];
-       size_t len[4];
-       u8 u[DPP_MAX_HASH_LEN];
-       u8 octet;
+       u8 Kx[DPP_MAX_SHARED_SECRET_LEN];
+       size_t Kx_len;
        int res;
+       EVP_PKEY_CTX *ctx = NULL;
 
-       attr_status = dpp_get_attr(buf, buflen, DPP_ATTR_STATUS,
-                                  &attr_status_len);
-       if (!attr_status || attr_status_len != 1) {
-               wpa_printf(MSG_DEBUG, "DPP: No DPP Status attribute");
+       if (bi->pkex_t >= PKEX_COUNTER_T_LIMIT) {
+               wpa_msg(msg_ctx, MSG_INFO, DPP_EVENT_FAIL
+                       "PKEX counter t limit reached - ignore message");
                return NULL;
        }
-       wpa_printf(MSG_DEBUG, "DPP: Status %u", attr_status[0]);
-       if (attr_status[0] != DPP_STATUS_OK) {
-               wpa_printf(MSG_DEBUG, "DPP: PKEX failed");
-               return NULL;
+
+#ifdef CONFIG_TESTING_OPTIONS
+       if (!is_zero_ether_addr(dpp_pkex_peer_mac_override)) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - peer_mac override " MACSTR,
+                          MAC2STR(dpp_pkex_peer_mac_override));
+               peer_mac = dpp_pkex_peer_mac_override;
+       }
+       if (!is_zero_ether_addr(dpp_pkex_own_mac_override)) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - own_mac override " MACSTR,
+                          MAC2STR(dpp_pkex_own_mac_override));
+               own_mac = dpp_pkex_own_mac_override;
        }
+#endif /* CONFIG_TESTING_OPTIONS */
 
-       attr_id = dpp_get_attr(buf, buflen, DPP_ATTR_CODE_IDENTIFIER,
+       attr_id_len = 0;
+       attr_id = dpp_get_attr(buf, len, DPP_ATTR_CODE_IDENTIFIER,
                               &attr_id_len);
-       if (!attr_id && pkex->identifier) {
-               wpa_printf(MSG_DEBUG,
-                          "DPP: No PKEX code identifier received, but expected one");
+       if (!dpp_pkex_identifier_match(attr_id, attr_id_len, identifier))
                return NULL;
-       }
-       if (attr_id && pkex->identifier &&
-           (os_strlen(pkex->identifier) != attr_id_len ||
-            os_memcmp(pkex->identifier, attr_id, attr_id_len) != 0)) {
-               wpa_printf(MSG_DEBUG, "DPP: PKEX code identifier mismatch");
+
+       attr_group = dpp_get_attr(buf, len, DPP_ATTR_FINITE_CYCLIC_GROUP,
+                                 &attr_group_len);
+       if (!attr_group || attr_group_len != 2) {
+               wpa_msg(msg_ctx, MSG_INFO, DPP_EVENT_FAIL
+                       "Missing or invalid Finite Cyclic Group attribute");
                return NULL;
        }
+       ike_group = WPA_GET_LE16(attr_group);
+       if (ike_group != curve->ike_group) {
+               wpa_msg(msg_ctx, MSG_INFO, DPP_EVENT_FAIL
+                       "Mismatching PKEX curve: peer=%u own=%u",
+                       ike_group, curve->ike_group);
+               pkex = os_zalloc(sizeof(*pkex));
+               if (!pkex)
+                       goto fail;
+               pkex->own_bi = bi;
+               pkex->failed = 1;
+               pkex->exchange_resp = dpp_pkex_build_exchange_resp(
+                       pkex, DPP_STATUS_BAD_GROUP, NULL, NULL);
+               if (!pkex->exchange_resp)
+                       goto fail;
+               return pkex;
+       }
 
-       /* N in Encrypted Key attribute */
-       attr_key = dpp_get_attr(buf, buflen, DPP_ATTR_ENCRYPTED_KEY,
+       /* M in Encrypted Key attribute */
+       attr_key = dpp_get_attr(buf, len, DPP_ATTR_ENCRYPTED_KEY,
                                &attr_key_len);
-       if (!attr_key || attr_key_len & 0x01 || attr_key_len < 2) {
-               wpa_printf(MSG_DEBUG, "DPP: Missing Encrypted Key attribute");
+       if (!attr_key || attr_key_len & 0x01 || attr_key_len < 2 ||
+           attr_key_len / 2 > DPP_MAX_SHARED_SECRET_LEN) {
+               wpa_msg(msg_ctx, MSG_INFO, DPP_EVENT_FAIL
+                       "Missing Encrypted Key attribute");
                return NULL;
        }
 
-       /* Qr = H(MAC-Responder | [identifier |] code) * Pr */
+       /* Qi = H(MAC-Initiator | [identifier |] code) * Pi */
        bnctx = BN_CTX_new();
        if (!bnctx)
                goto fail;
-       Qr = dpp_pkex_derive_Qr(curve, pkex->peer_mac, pkex->code,
-                               pkex->identifier, bnctx, &group);
-       if (!Qr)
+       Qi = dpp_pkex_derive_Qi(curve, peer_mac, code, identifier, bnctx,
+                               &group);
+       if (!Qi)
                goto fail;
 
-       /* Y' = N - Qr */
-       Y = EC_POINT_new(group);
-       N = EC_POINT_new(group);
-       Nx = BN_bin2bn(attr_key, attr_key_len / 2, NULL);
-       Ny = BN_bin2bn(attr_key + attr_key_len / 2, attr_key_len / 2, NULL);
-       if (!Y || !N || !Nx || !Ny ||
-           EC_POINT_set_affine_coordinates_GFp(group, N, Nx, Ny, bnctx) != 1 ||
-           EC_POINT_is_at_infinity(group, N) ||
-           !EC_POINT_is_on_curve(group, N, bnctx) ||
-           EC_POINT_invert(group, Qr, bnctx) != 1 ||
-           EC_POINT_add(group, Y, N, Qr, bnctx) != 1 ||
-           EC_POINT_is_at_infinity(group, Y) ||
-           !EC_POINT_is_on_curve(group, Y, bnctx))
+       /* X' = M - Qi */
+       X = EC_POINT_new(group);
+       M = EC_POINT_new(group);
+       Mx = BN_bin2bn(attr_key, attr_key_len / 2, NULL);
+       My = BN_bin2bn(attr_key + attr_key_len / 2, attr_key_len / 2, NULL);
+       if (!X || !M || !Mx || !My ||
+           EC_POINT_set_affine_coordinates_GFp(group, M, Mx, My, bnctx) != 1 ||
+           EC_POINT_is_at_infinity(group, M) ||
+           !EC_POINT_is_on_curve(group, M, bnctx) ||
+           EC_POINT_invert(group, Qi, bnctx) != 1 ||
+           EC_POINT_add(group, X, M, Qi, bnctx) != 1 ||
+           EC_POINT_is_at_infinity(group, X) ||
+           !EC_POINT_is_on_curve(group, X, bnctx)) {
+               wpa_msg(msg_ctx, MSG_INFO, DPP_EVENT_FAIL
+                       "Invalid Encrypted Key value");
+               bi->pkex_t++;
                goto fail;
+       }
+       dpp_debug_print_point("DPP: M", group, M);
+       dpp_debug_print_point("DPP: X'", group, X);
 
-       pkex->exchange_done = 1;
+       pkex = os_zalloc(sizeof(*pkex));
+       if (!pkex)
+               goto fail;
+       pkex->t = bi->pkex_t;
+       pkex->msg_ctx = msg_ctx;
+       pkex->own_bi = bi;
+       os_memcpy(pkex->own_mac, own_mac, ETH_ALEN);
+       os_memcpy(pkex->peer_mac, peer_mac, ETH_ALEN);
+       if (identifier) {
+               pkex->identifier = os_strdup(identifier);
+               if (!pkex->identifier)
+                       goto fail;
+       }
+       pkex->code = os_strdup(code);
+       if (!pkex->code)
+               goto fail;
 
-       /* ECDH: J = a * Y’ */
-       Y_ec = EC_KEY_new();
-       if (!Y_ec ||
-           EC_KEY_set_group(Y_ec, group) != 1 ||
-           EC_KEY_set_public_key(Y_ec, Y) != 1)
+       os_memcpy(pkex->Mx, attr_key, attr_key_len / 2);
+
+       X_ec = EC_KEY_new();
+       if (!X_ec ||
+           EC_KEY_set_group(X_ec, group) != 1 ||
+           EC_KEY_set_public_key(X_ec, X) != 1)
                goto fail;
-       pkex->y = EVP_PKEY_new();
-       if (!pkex->y ||
-           EVP_PKEY_set1_EC_KEY(pkex->y, Y_ec) != 1)
+       pkex->x = EVP_PKEY_new();
+       if (!pkex->x ||
+           EVP_PKEY_set1_EC_KEY(pkex->x, X_ec) != 1)
                goto fail;
-       ctx = EVP_PKEY_CTX_new(pkex->own_bi->pubkey, NULL);
-       if (!ctx ||
-           EVP_PKEY_derive_init(ctx) != 1 ||
-           EVP_PKEY_derive_set_peer(ctx, pkex->y) != 1 ||
-           EVP_PKEY_derive(ctx, NULL, &Jx_len) != 1 ||
-           Jx_len > DPP_MAX_SHARED_SECRET_LEN ||
-           EVP_PKEY_derive(ctx, Jx, &Jx_len) != 1) {
-               wpa_printf(MSG_ERROR,
-                          "DPP: Failed to derive ECDH shared secret: %s",
-                          ERR_error_string(ERR_get_error(), NULL));
+
+       /* Qr = H(MAC-Responder | | [identifier | ] code) * Pr */
+       Qr = dpp_pkex_derive_Qr(curve, own_mac, code, identifier, bnctx, NULL);
+       if (!Qr)
                goto fail;
-       }
 
-       wpa_hexdump_key(MSG_DEBUG, "DPP: ECDH shared secret (J.x)",
-                       Jx, Jx_len);
+       /* Generate a random ephemeral keypair y/Y */
+#ifdef CONFIG_TESTING_OPTIONS
+       if (dpp_pkex_ephemeral_key_override_len) {
+               const struct dpp_curve_params *tmp_curve;
 
-       /* u = HMAC(J.x,  MAC-Initiator | A.x | Y’.x | X.x ) */
-       A_pub = dpp_get_pubkey_point(pkex->own_bi->pubkey, 0);
-       Y_pub = dpp_get_pubkey_point(pkex->y, 0);
-       X_pub = dpp_get_pubkey_point(pkex->x, 0);
-       if (!A_pub || !Y_pub || !X_pub)
+               wpa_printf(MSG_INFO,
+                          "DPP: TESTING - override ephemeral key y/Y");
+               pkex->y = dpp_set_keypair(&tmp_curve,
+                                         dpp_pkex_ephemeral_key_override,
+                                         dpp_pkex_ephemeral_key_override_len);
+       } else {
+               pkex->y = dpp_gen_keypair(curve);
+       }
+#else /* CONFIG_TESTING_OPTIONS */
+       pkex->y = dpp_gen_keypair(curve);
+#endif /* CONFIG_TESTING_OPTIONS */
+       if (!pkex->y)
                goto fail;
-       addr[0] = pkex->own_mac;
-       len[0] = ETH_ALEN;
-       addr[1] = wpabuf_head(A_pub);
-       len[1] = wpabuf_len(A_pub) / 2;
-       addr[2] = wpabuf_head(Y_pub);
-       len[2] = wpabuf_len(Y_pub) / 2;
-       addr[3] = wpabuf_head(X_pub);
-       len[3] = wpabuf_len(X_pub) / 2;
-       if (dpp_hmac_vector(curve->hash_len, Jx, Jx_len, 4, addr, len, u) < 0)
+
+       /* N = Y + Qr */
+       Y_ec = EVP_PKEY_get1_EC_KEY(pkex->y);
+       if (!Y_ec)
                goto fail;
-       wpa_hexdump(MSG_DEBUG, "DPP: u", u, curve->hash_len);
+       Y_point = EC_KEY_get0_public_key(Y_ec);
+       if (!Y_point)
+               goto fail;
+       dpp_debug_print_point("DPP: Y", group, Y_point);
+       N = EC_POINT_new(group);
+       Nx = BN_new();
+       Ny = BN_new();
+       if (!N || !Nx || !Ny ||
+           EC_POINT_add(group, N, Y_point, Qr, bnctx) != 1 ||
+           EC_POINT_get_affine_coordinates_GFp(group, N, Nx, Ny, bnctx) != 1)
+               goto fail;
+       dpp_debug_print_point("DPP: N", group, N);
 
-       /* K = x * Y’ */
-       EVP_PKEY_CTX_free(ctx);
-       ctx = EVP_PKEY_CTX_new(pkex->x, NULL);
+       pkex->exchange_resp = dpp_pkex_build_exchange_resp(pkex, DPP_STATUS_OK,
+                                                          Nx, Ny);
+       if (!pkex->exchange_resp)
+               goto fail;
+
+       /* K = y * X' */
+       ctx = EVP_PKEY_CTX_new(pkex->y, NULL);
        if (!ctx ||
            EVP_PKEY_derive_init(ctx) != 1 ||
-           EVP_PKEY_derive_set_peer(ctx, pkex->y) != 1 ||
+           EVP_PKEY_derive_set_peer(ctx, pkex->x) != 1 ||
            EVP_PKEY_derive(ctx, NULL, &Kx_len) != 1 ||
            Kx_len > DPP_MAX_SHARED_SECRET_LEN ||
            EVP_PKEY_derive(ctx, Kx, &Kx_len) != 1) {
@@ -5953,37 +7432,114 @@ struct wpabuf * dpp_pkex_rx_exchange_resp(struct dpp_pkex *pkex,
 
        /* z = HKDF(<>, MAC-Initiator | MAC-Responder | M.x | N.x | code, K.x)
         */
-       res = dpp_pkex_derive_z(pkex->own_mac, pkex->peer_mac,
+       res = dpp_pkex_derive_z(pkex->peer_mac, pkex->own_mac,
                                pkex->Mx, curve->prime_len,
-                               attr_key /* N.x */, attr_key_len / 2,
-                               pkex->code, Kx, Kx_len,
-                               pkex->z, curve->hash_len);
+                               pkex->Nx, curve->prime_len, pkex->code,
+                               Kx, Kx_len, pkex->z, curve->hash_len);
        os_memset(Kx, 0, Kx_len);
        if (res < 0)
                goto fail;
 
-       /* {A, u, [bootstrapping info]}z */
-       clear_len = 4 + 2 * curve->prime_len + 4 + curve->hash_len;
-       clear = wpabuf_alloc(clear_len);
-       attr_len = 4 + clear_len + AES_BLOCK_SIZE;
-#ifdef CONFIG_TESTING_OPTIONS
-       if (dpp_test == DPP_TEST_AFTER_WRAPPED_DATA_PKEX_CR_REQ)
-               attr_len += 4;
-#endif /* CONFIG_TESTING_OPTIONS */
-       msg = dpp_alloc_msg(DPP_PA_PKEX_COMMIT_REVEAL_REQ, attr_len);
-       if (!clear || !msg)
-               goto fail;
+       pkex->exchange_done = 1;
+
+out:
+       EVP_PKEY_CTX_free(ctx);
+       BN_CTX_free(bnctx);
+       EC_POINT_free(Qi);
+       EC_POINT_free(Qr);
+       BN_free(Mx);
+       BN_free(My);
+       BN_free(Nx);
+       BN_free(Ny);
+       EC_POINT_free(M);
+       EC_POINT_free(N);
+       EC_POINT_free(X);
+       EC_KEY_free(X_ec);
+       EC_KEY_free(Y_ec);
+       EC_GROUP_free(group);
+       return pkex;
+fail:
+       wpa_printf(MSG_DEBUG, "DPP: PKEX Exchange Request processing failed");
+       dpp_pkex_free(pkex);
+       pkex = NULL;
+       goto out;
+}
+
+
+static struct wpabuf *
+dpp_pkex_build_commit_reveal_req(struct dpp_pkex *pkex,
+                                const struct wpabuf *A_pub, const u8 *u)
+{
+       const struct dpp_curve_params *curve = pkex->own_bi->curve;
+       struct wpabuf *msg = NULL;
+       size_t clear_len, attr_len;
+       struct wpabuf *clear = NULL;
+       u8 *wrapped;
+       u8 octet;
+       const u8 *addr[2];
+       size_t len[2];
+
+       /* {A, u, [bootstrapping info]}z */
+       clear_len = 4 + 2 * curve->prime_len + 4 + curve->hash_len;
+       clear = wpabuf_alloc(clear_len);
+       attr_len = 4 + clear_len + AES_BLOCK_SIZE;
+#ifdef CONFIG_TESTING_OPTIONS
+       if (dpp_test == DPP_TEST_AFTER_WRAPPED_DATA_PKEX_CR_REQ)
+               attr_len += 5;
+#endif /* CONFIG_TESTING_OPTIONS */
+       msg = dpp_alloc_msg(DPP_PA_PKEX_COMMIT_REVEAL_REQ, attr_len);
+       if (!clear || !msg)
+               goto fail;
+
+#ifdef CONFIG_TESTING_OPTIONS
+       if (dpp_test == DPP_TEST_NO_BOOTSTRAP_KEY_PKEX_CR_REQ) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - no Bootstrap Key");
+               goto skip_bootstrap_key;
+       }
+       if (dpp_test == DPP_TEST_INVALID_BOOTSTRAP_KEY_PKEX_CR_REQ) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - invalid Bootstrap Key");
+               wpabuf_put_le16(clear, DPP_ATTR_BOOTSTRAP_KEY);
+               wpabuf_put_le16(clear, 2 * curve->prime_len);
+               if (dpp_test_gen_invalid_key(clear, curve) < 0)
+                       goto fail;
+               goto skip_bootstrap_key;
+       }
+#endif /* CONFIG_TESTING_OPTIONS */
 
        /* A in Bootstrap Key attribute */
        wpabuf_put_le16(clear, DPP_ATTR_BOOTSTRAP_KEY);
        wpabuf_put_le16(clear, wpabuf_len(A_pub));
        wpabuf_put_buf(clear, A_pub);
 
+#ifdef CONFIG_TESTING_OPTIONS
+skip_bootstrap_key:
+       if (dpp_test == DPP_TEST_NO_I_AUTH_TAG_PKEX_CR_REQ) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - no I-Auth tag");
+               goto skip_i_auth_tag;
+       }
+       if (dpp_test == DPP_TEST_I_AUTH_TAG_MISMATCH_PKEX_CR_REQ) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - I-Auth tag mismatch");
+               wpabuf_put_le16(clear, DPP_ATTR_I_AUTH_TAG);
+               wpabuf_put_le16(clear, curve->hash_len);
+               wpabuf_put_data(clear, u, curve->hash_len - 1);
+               wpabuf_put_u8(clear, u[curve->hash_len - 1] ^ 0x01);
+               goto skip_i_auth_tag;
+       }
+#endif /* CONFIG_TESTING_OPTIONS */
+
        /* u in I-Auth tag attribute */
        wpabuf_put_le16(clear, DPP_ATTR_I_AUTH_TAG);
        wpabuf_put_le16(clear, curve->hash_len);
        wpabuf_put_data(clear, u, curve->hash_len);
 
+#ifdef CONFIG_TESTING_OPTIONS
+skip_i_auth_tag:
+       if (dpp_test == DPP_TEST_NO_WRAPPED_DATA_PKEX_CR_REQ) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - no Wrapped Data");
+               goto skip_wrapped_data;
+       }
+#endif /* CONFIG_TESTING_OPTIONS */
+
        addr[0] = wpabuf_head_u8(msg) + 2;
        len[0] = DPP_HDR_LEN;
        octet = 0;
@@ -6007,142 +7563,150 @@ struct wpabuf * dpp_pkex_rx_exchange_resp(struct dpp_pkex *pkex,
 #ifdef CONFIG_TESTING_OPTIONS
        if (dpp_test == DPP_TEST_AFTER_WRAPPED_DATA_PKEX_CR_REQ) {
                wpa_printf(MSG_INFO, "DPP: TESTING - attr after Wrapped Data");
-               wpabuf_put_le16(msg, DPP_ATTR_TESTING);
-               wpabuf_put_le16(msg, 0);
+               dpp_build_attr_status(msg, DPP_STATUS_OK);
        }
+skip_wrapped_data:
 #endif /* CONFIG_TESTING_OPTIONS */
 
 out:
        wpabuf_free(clear);
-       wpabuf_free(A_pub);
-       wpabuf_free(X_pub);
-       wpabuf_free(Y_pub);
-       EC_POINT_free(Qr);
-       EC_POINT_free(Y);
-       EC_POINT_free(N);
-       BN_free(Nx);
-       BN_free(Ny);
-       EC_KEY_free(Y_ec);
-       EVP_PKEY_CTX_free(ctx);
-       BN_CTX_free(bnctx);
        return msg;
+
 fail:
-       wpa_printf(MSG_DEBUG, "DPP: PKEX Exchange Response processing faileed");
        wpabuf_free(msg);
        msg = NULL;
        goto out;
 }
 
 
-struct wpabuf * dpp_pkex_rx_commit_reveal_req(struct dpp_pkex *pkex,
-                                             const u8 *hdr,
-                                             const u8 *buf, size_t buflen)
+struct wpabuf * dpp_pkex_rx_exchange_resp(struct dpp_pkex *pkex,
+                                         const u8 *peer_mac,
+                                         const u8 *buf, size_t buflen)
 {
+       const u8 *attr_status, *attr_id, *attr_key, *attr_group;
+       u16 attr_status_len, attr_id_len, attr_key_len, attr_group_len;
+       EC_GROUP *group = NULL;
+       BN_CTX *bnctx = NULL;
+       struct wpabuf *msg = NULL, *A_pub = NULL, *X_pub = NULL, *Y_pub = NULL;
        const struct dpp_curve_params *curve = pkex->own_bi->curve;
-       EVP_PKEY_CTX *ctx;
-       size_t Jx_len, Kx_len, Lx_len;
+       EC_POINT *Qr = NULL, *Y = NULL, *N = NULL;
+       BIGNUM *Nx = NULL, *Ny = NULL;
+       EVP_PKEY_CTX *ctx = NULL;
+       EC_KEY *Y_ec = NULL;
+       size_t Jx_len, Kx_len;
        u8 Jx[DPP_MAX_SHARED_SECRET_LEN], Kx[DPP_MAX_SHARED_SECRET_LEN];
-       u8 Lx[DPP_MAX_SHARED_SECRET_LEN];
-       const u8 *wrapped_data, *b_key, *peer_u;
-       u16 wrapped_data_len, b_key_len, peer_u_len = 0;
        const u8 *addr[4];
        size_t len[4];
-       u8 octet;
-       u8 *unwrapped = NULL;
-       size_t unwrapped_len = 0;
-       struct wpabuf *msg = NULL, *A_pub = NULL, *X_pub = NULL, *Y_pub = NULL;
-       struct wpabuf *B_pub = NULL;
-       u8 u[DPP_MAX_HASH_LEN], v[DPP_MAX_HASH_LEN];
-       size_t clear_len, attr_len;
-       struct wpabuf *clear = NULL;
-       u8 *wrapped;
+       u8 u[DPP_MAX_HASH_LEN];
        int res;
 
-       /* K = y * X' */
-       ctx = EVP_PKEY_CTX_new(pkex->y, NULL);
-       if (!ctx ||
-           EVP_PKEY_derive_init(ctx) != 1 ||
-           EVP_PKEY_derive_set_peer(ctx, pkex->x) != 1 ||
-           EVP_PKEY_derive(ctx, NULL, &Kx_len) != 1 ||
-           Kx_len > DPP_MAX_SHARED_SECRET_LEN ||
-           EVP_PKEY_derive(ctx, Kx, &Kx_len) != 1) {
-               wpa_printf(MSG_ERROR,
-                          "DPP: Failed to derive ECDH shared secret: %s",
-                          ERR_error_string(ERR_get_error(), NULL));
-               goto fail;
+       if (pkex->failed || pkex->t >= PKEX_COUNTER_T_LIMIT || !pkex->initiator)
+               return NULL;
+
+#ifdef CONFIG_TESTING_OPTIONS
+       if (dpp_test == DPP_TEST_STOP_AT_PKEX_EXCHANGE_RESP) {
+               wpa_printf(MSG_INFO,
+                          "DPP: TESTING - stop at PKEX Exchange Response");
+               pkex->failed = 1;
+               return NULL;
        }
 
-       wpa_hexdump_key(MSG_DEBUG, "DPP: ECDH shared secret (K.x)",
-                       Kx, Kx_len);
+       if (!is_zero_ether_addr(dpp_pkex_peer_mac_override)) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - peer_mac override " MACSTR,
+                          MAC2STR(dpp_pkex_peer_mac_override));
+               peer_mac = dpp_pkex_peer_mac_override;
+       }
+#endif /* CONFIG_TESTING_OPTIONS */
 
-       /* z = HKDF(<>, MAC-Initiator | MAC-Responder | M.x | N.x | code, K.x)
-        */
-       res = dpp_pkex_derive_z(pkex->peer_mac, pkex->own_mac,
-                               pkex->Mx, curve->prime_len,
-                               pkex->Nx, curve->prime_len, pkex->code,
-                               Kx, Kx_len, pkex->z, curve->hash_len);
-       os_memset(Kx, 0, Kx_len);
-       if (res < 0)
-               goto fail;
+       os_memcpy(pkex->peer_mac, peer_mac, ETH_ALEN);
 
-       wrapped_data = dpp_get_attr(buf, buflen, DPP_ATTR_WRAPPED_DATA,
-                                   &wrapped_data_len);
-       if (!wrapped_data || wrapped_data_len < AES_BLOCK_SIZE) {
-               wpa_printf(MSG_DEBUG,
-                          "DPP: Missing or invalid required Wrapped data attribute");
-               goto fail;
+       attr_status = dpp_get_attr(buf, buflen, DPP_ATTR_STATUS,
+                                  &attr_status_len);
+       if (!attr_status || attr_status_len != 1) {
+               dpp_pkex_fail(pkex, "No DPP Status attribute");
+               return NULL;
        }
+       wpa_printf(MSG_DEBUG, "DPP: Status %u", attr_status[0]);
 
-       wpa_hexdump(MSG_DEBUG, "DPP: AES-SIV ciphertext",
-                   wrapped_data, wrapped_data_len);
-       unwrapped_len = wrapped_data_len - AES_BLOCK_SIZE;
-       unwrapped = os_malloc(unwrapped_len);
-       if (!unwrapped)
-               goto fail;
+       if (attr_status[0] == DPP_STATUS_BAD_GROUP) {
+               attr_group = dpp_get_attr(buf, buflen,
+                                         DPP_ATTR_FINITE_CYCLIC_GROUP,
+                                         &attr_group_len);
+               if (attr_group && attr_group_len == 2) {
+                       wpa_msg(pkex->msg_ctx, MSG_INFO, DPP_EVENT_FAIL
+                               "Peer indicated mismatching PKEX group - proposed %u",
+                               WPA_GET_LE16(attr_group));
+                       return NULL;
+               }
+       }
 
-       addr[0] = hdr;
-       len[0] = DPP_HDR_LEN;
-       octet = 0;
-       addr[1] = &octet;
-       len[1] = sizeof(octet);
-       wpa_hexdump(MSG_DEBUG, "DDP: AES-SIV AD[0]", addr[0], len[0]);
-       wpa_hexdump(MSG_DEBUG, "DDP: AES-SIV AD[1]", addr[1], len[1]);
+       if (attr_status[0] != DPP_STATUS_OK) {
+               dpp_pkex_fail(pkex, "PKEX failed (peer indicated failure)");
+               return NULL;
+       }
 
-       if (aes_siv_decrypt(pkex->z, curve->hash_len,
-                           wrapped_data, wrapped_data_len,
-                           2, addr, len, unwrapped) < 0) {
-               wpa_printf(MSG_DEBUG, "DPP: AES-SIV decryption failed");
-               goto fail;
+       attr_id_len = 0;
+       attr_id = dpp_get_attr(buf, buflen, DPP_ATTR_CODE_IDENTIFIER,
+                              &attr_id_len);
+       if (!dpp_pkex_identifier_match(attr_id, attr_id_len,
+                                      pkex->identifier)) {
+               dpp_pkex_fail(pkex, "PKEX code identifier mismatch");
+               return NULL;
        }
-       wpa_hexdump(MSG_DEBUG, "DPP: AES-SIV cleartext",
-                   unwrapped, unwrapped_len);
 
-       if (dpp_check_attrs(unwrapped, unwrapped_len) < 0) {
-               wpa_printf(MSG_DEBUG,
-                          "DPP: Invalid attribute in unwrapped data");
-               goto fail;
+       /* N in Encrypted Key attribute */
+       attr_key = dpp_get_attr(buf, buflen, DPP_ATTR_ENCRYPTED_KEY,
+                               &attr_key_len);
+       if (!attr_key || attr_key_len & 0x01 || attr_key_len < 2) {
+               dpp_pkex_fail(pkex, "Missing Encrypted Key attribute");
+               return NULL;
        }
 
-       b_key = dpp_get_attr(unwrapped, unwrapped_len, DPP_ATTR_BOOTSTRAP_KEY,
-                            &b_key_len);
-       if (!b_key || b_key_len != 2 * curve->prime_len) {
-               wpa_printf(MSG_DEBUG,
-                          "DPP: No valid peer bootstrapping key found");
+       /* Qr = H(MAC-Responder | [identifier |] code) * Pr */
+       bnctx = BN_CTX_new();
+       if (!bnctx)
                goto fail;
-       }
-       pkex->peer_bootstrap_key = dpp_set_pubkey_point(pkex->x, b_key,
-                                                       b_key_len);
-       if (!pkex->peer_bootstrap_key)
+       Qr = dpp_pkex_derive_Qr(curve, pkex->peer_mac, pkex->code,
+                               pkex->identifier, bnctx, &group);
+       if (!Qr)
                goto fail;
-       dpp_debug_print_key("DPP: Peer bootstrap public key",
-                           pkex->peer_bootstrap_key);
 
-       /* ECDH: J' = y * A' */
-       EVP_PKEY_CTX_free(ctx);
-       ctx = EVP_PKEY_CTX_new(pkex->y, NULL);
+       /* Y' = N - Qr */
+       Y = EC_POINT_new(group);
+       N = EC_POINT_new(group);
+       Nx = BN_bin2bn(attr_key, attr_key_len / 2, NULL);
+       Ny = BN_bin2bn(attr_key + attr_key_len / 2, attr_key_len / 2, NULL);
+       if (!Y || !N || !Nx || !Ny ||
+           EC_POINT_set_affine_coordinates_GFp(group, N, Nx, Ny, bnctx) != 1 ||
+           EC_POINT_is_at_infinity(group, N) ||
+           !EC_POINT_is_on_curve(group, N, bnctx) ||
+           EC_POINT_invert(group, Qr, bnctx) != 1 ||
+           EC_POINT_add(group, Y, N, Qr, bnctx) != 1 ||
+           EC_POINT_is_at_infinity(group, Y) ||
+           !EC_POINT_is_on_curve(group, Y, bnctx)) {
+               dpp_pkex_fail(pkex, "Invalid Encrypted Key value");
+               pkex->t++;
+               goto fail;
+       }
+       dpp_debug_print_point("DPP: N", group, N);
+       dpp_debug_print_point("DPP: Y'", group, Y);
+
+       pkex->exchange_done = 1;
+
+       /* ECDH: J = a * Y’ */
+       Y_ec = EC_KEY_new();
+       if (!Y_ec ||
+           EC_KEY_set_group(Y_ec, group) != 1 ||
+           EC_KEY_set_public_key(Y_ec, Y) != 1)
+               goto fail;
+       pkex->y = EVP_PKEY_new();
+       if (!pkex->y ||
+           EVP_PKEY_set1_EC_KEY(pkex->y, Y_ec) != 1)
+               goto fail;
+       ctx = EVP_PKEY_CTX_new(pkex->own_bi->pubkey, NULL);
        if (!ctx ||
            EVP_PKEY_derive_init(ctx) != 1 ||
-           EVP_PKEY_derive_set_peer(ctx, pkex->peer_bootstrap_key) != 1 ||
+           EVP_PKEY_derive_set_peer(ctx, pkex->y) != 1 ||
            EVP_PKEY_derive(ctx, NULL, &Jx_len) != 1 ||
            Jx_len > DPP_MAX_SHARED_SECRET_LEN ||
            EVP_PKEY_derive(ctx, Jx, &Jx_len) != 1) {
@@ -6155,13 +7719,13 @@ struct wpabuf * dpp_pkex_rx_commit_reveal_req(struct dpp_pkex *pkex,
        wpa_hexdump_key(MSG_DEBUG, "DPP: ECDH shared secret (J.x)",
                        Jx, Jx_len);
 
-       /* u' = HMAC(J'.x, MAC-Initiator | A'.x | Y.x | X'.x) */
-       A_pub = dpp_get_pubkey_point(pkex->peer_bootstrap_key, 0);
+       /* u = HMAC(J.x,  MAC-Initiator | A.x | Y’.x | X.x ) */
+       A_pub = dpp_get_pubkey_point(pkex->own_bi->pubkey, 0);
        Y_pub = dpp_get_pubkey_point(pkex->y, 0);
        X_pub = dpp_get_pubkey_point(pkex->x, 0);
        if (!A_pub || !Y_pub || !X_pub)
                goto fail;
-       addr[0] = pkex->peer_mac;
+       addr[0] = pkex->own_mac;
        len[0] = ETH_ALEN;
        addr[1] = wpabuf_head(A_pub);
        len[1] = wpabuf_len(A_pub) / 2;
@@ -6171,52 +7735,73 @@ struct wpabuf * dpp_pkex_rx_commit_reveal_req(struct dpp_pkex *pkex,
        len[3] = wpabuf_len(X_pub) / 2;
        if (dpp_hmac_vector(curve->hash_len, Jx, Jx_len, 4, addr, len, u) < 0)
                goto fail;
+       wpa_hexdump(MSG_DEBUG, "DPP: u", u, curve->hash_len);
 
-       peer_u = dpp_get_attr(unwrapped, unwrapped_len, DPP_ATTR_I_AUTH_TAG,
-                             &peer_u_len);
-       if (!peer_u || peer_u_len != curve->hash_len ||
-           os_memcmp(peer_u, u, curve->hash_len) != 0) {
-               wpa_printf(MSG_DEBUG, "DPP: No valid u (I-Auth tag) found");
-               wpa_hexdump(MSG_DEBUG, "DPP: Calculated u'",
-                           u, curve->hash_len);
-               wpa_hexdump(MSG_DEBUG, "DPP: Received u", peer_u, peer_u_len);
-               goto fail;
-       }
-       wpa_printf(MSG_DEBUG, "DPP: Valid u (I-Auth tag) received");
-
-       /* ECDH: L = b * X' */
+       /* K = x * Y’ */
        EVP_PKEY_CTX_free(ctx);
-       ctx = EVP_PKEY_CTX_new(pkex->own_bi->pubkey, NULL);
+       ctx = EVP_PKEY_CTX_new(pkex->x, NULL);
        if (!ctx ||
            EVP_PKEY_derive_init(ctx) != 1 ||
-           EVP_PKEY_derive_set_peer(ctx, pkex->x) != 1 ||
-           EVP_PKEY_derive(ctx, NULL, &Lx_len) != 1 ||
-           Lx_len > DPP_MAX_SHARED_SECRET_LEN ||
-           EVP_PKEY_derive(ctx, Lx, &Lx_len) != 1) {
+           EVP_PKEY_derive_set_peer(ctx, pkex->y) != 1 ||
+           EVP_PKEY_derive(ctx, NULL, &Kx_len) != 1 ||
+           Kx_len > DPP_MAX_SHARED_SECRET_LEN ||
+           EVP_PKEY_derive(ctx, Kx, &Kx_len) != 1) {
                wpa_printf(MSG_ERROR,
                           "DPP: Failed to derive ECDH shared secret: %s",
                           ERR_error_string(ERR_get_error(), NULL));
                goto fail;
        }
 
-       wpa_hexdump_key(MSG_DEBUG, "DPP: ECDH shared secret (L.x)",
-                       Lx, Lx_len);
+       wpa_hexdump_key(MSG_DEBUG, "DPP: ECDH shared secret (K.x)",
+                       Kx, Kx_len);
 
-       /* v = HMAC(L.x, MAC-Responder | B.x | X'.x | Y.x) */
-       B_pub = dpp_get_pubkey_point(pkex->own_bi->pubkey, 0);
-       if (!B_pub)
+       /* z = HKDF(<>, MAC-Initiator | MAC-Responder | M.x | N.x | code, K.x)
+        */
+       res = dpp_pkex_derive_z(pkex->own_mac, pkex->peer_mac,
+                               pkex->Mx, curve->prime_len,
+                               attr_key /* N.x */, attr_key_len / 2,
+                               pkex->code, Kx, Kx_len,
+                               pkex->z, curve->hash_len);
+       os_memset(Kx, 0, Kx_len);
+       if (res < 0)
                goto fail;
-       addr[0] = pkex->own_mac;
-       len[0] = ETH_ALEN;
-       addr[1] = wpabuf_head(B_pub);
-       len[1] = wpabuf_len(B_pub) / 2;
-       addr[2] = wpabuf_head(X_pub);
-       len[2] = wpabuf_len(X_pub) / 2;
-       addr[3] = wpabuf_head(Y_pub);
-       len[3] = wpabuf_len(Y_pub) / 2;
-       if (dpp_hmac_vector(curve->hash_len, Lx, Lx_len, 4, addr, len, v) < 0)
+
+       msg = dpp_pkex_build_commit_reveal_req(pkex, A_pub, u);
+       if (!msg)
                goto fail;
-       wpa_hexdump(MSG_DEBUG, "DPP: v", v, curve->hash_len);
+
+out:
+       wpabuf_free(A_pub);
+       wpabuf_free(X_pub);
+       wpabuf_free(Y_pub);
+       EC_POINT_free(Qr);
+       EC_POINT_free(Y);
+       EC_POINT_free(N);
+       BN_free(Nx);
+       BN_free(Ny);
+       EC_KEY_free(Y_ec);
+       EVP_PKEY_CTX_free(ctx);
+       BN_CTX_free(bnctx);
+       EC_GROUP_free(group);
+       return msg;
+fail:
+       wpa_printf(MSG_DEBUG, "DPP: PKEX Exchange Response processing failed");
+       goto out;
+}
+
+
+static struct wpabuf *
+dpp_pkex_build_commit_reveal_resp(struct dpp_pkex *pkex,
+                                 const struct wpabuf *B_pub, const u8 *v)
+{
+       const struct dpp_curve_params *curve = pkex->own_bi->curve;
+       struct wpabuf *msg = NULL;
+       const u8 *addr[2];
+       size_t len[2];
+       u8 octet;
+       u8 *wrapped;
+       struct wpabuf *clear = NULL;
+       size_t clear_len, attr_len;
 
        /* {B, v [bootstrapping info]}z */
        clear_len = 4 + 2 * curve->prime_len + 4 + curve->hash_len;
@@ -6224,22 +7809,61 @@ struct wpabuf * dpp_pkex_rx_commit_reveal_req(struct dpp_pkex *pkex,
        attr_len = 4 + clear_len + AES_BLOCK_SIZE;
 #ifdef CONFIG_TESTING_OPTIONS
        if (dpp_test == DPP_TEST_AFTER_WRAPPED_DATA_PKEX_CR_RESP)
-               attr_len += 4;
+               attr_len += 5;
 #endif /* CONFIG_TESTING_OPTIONS */
        msg = dpp_alloc_msg(DPP_PA_PKEX_COMMIT_REVEAL_RESP, attr_len);
        if (!clear || !msg)
                goto fail;
 
-       /* A in Bootstrap Key attribute */
+#ifdef CONFIG_TESTING_OPTIONS
+       if (dpp_test == DPP_TEST_NO_BOOTSTRAP_KEY_PKEX_CR_RESP) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - no Bootstrap Key");
+               goto skip_bootstrap_key;
+       }
+       if (dpp_test == DPP_TEST_INVALID_BOOTSTRAP_KEY_PKEX_CR_RESP) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - invalid Bootstrap Key");
+               wpabuf_put_le16(clear, DPP_ATTR_BOOTSTRAP_KEY);
+               wpabuf_put_le16(clear, 2 * curve->prime_len);
+               if (dpp_test_gen_invalid_key(clear, curve) < 0)
+                       goto fail;
+               goto skip_bootstrap_key;
+       }
+#endif /* CONFIG_TESTING_OPTIONS */
+
+       /* B in Bootstrap Key attribute */
        wpabuf_put_le16(clear, DPP_ATTR_BOOTSTRAP_KEY);
        wpabuf_put_le16(clear, wpabuf_len(B_pub));
        wpabuf_put_buf(clear, B_pub);
 
+#ifdef CONFIG_TESTING_OPTIONS
+skip_bootstrap_key:
+       if (dpp_test == DPP_TEST_NO_R_AUTH_TAG_PKEX_CR_RESP) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - no R-Auth tag");
+               goto skip_r_auth_tag;
+       }
+       if (dpp_test == DPP_TEST_R_AUTH_TAG_MISMATCH_PKEX_CR_RESP) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - R-Auth tag mismatch");
+               wpabuf_put_le16(clear, DPP_ATTR_R_AUTH_TAG);
+               wpabuf_put_le16(clear, curve->hash_len);
+               wpabuf_put_data(clear, v, curve->hash_len - 1);
+               wpabuf_put_u8(clear, v[curve->hash_len - 1] ^ 0x01);
+               goto skip_r_auth_tag;
+       }
+#endif /* CONFIG_TESTING_OPTIONS */
+
        /* v in R-Auth tag attribute */
        wpabuf_put_le16(clear, DPP_ATTR_R_AUTH_TAG);
        wpabuf_put_le16(clear, curve->hash_len);
        wpabuf_put_data(clear, v, curve->hash_len);
 
+#ifdef CONFIG_TESTING_OPTIONS
+skip_r_auth_tag:
+       if (dpp_test == DPP_TEST_NO_WRAPPED_DATA_PKEX_CR_RESP) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - no Wrapped Data");
+               goto skip_wrapped_data;
+       }
+#endif /* CONFIG_TESTING_OPTIONS */
+
        addr[0] = wpabuf_head_u8(msg) + 2;
        len[0] = DPP_HDR_LEN;
        octet = 1;
@@ -6263,10 +7887,195 @@ struct wpabuf * dpp_pkex_rx_commit_reveal_req(struct dpp_pkex *pkex,
 #ifdef CONFIG_TESTING_OPTIONS
        if (dpp_test == DPP_TEST_AFTER_WRAPPED_DATA_PKEX_CR_RESP) {
                wpa_printf(MSG_INFO, "DPP: TESTING - attr after Wrapped Data");
-               wpabuf_put_le16(msg, DPP_ATTR_TESTING);
-               wpabuf_put_le16(msg, 0);
+               dpp_build_attr_status(msg, DPP_STATUS_OK);
+       }
+skip_wrapped_data:
+#endif /* CONFIG_TESTING_OPTIONS */
+
+out:
+       wpabuf_free(clear);
+       return msg;
+
+fail:
+       wpabuf_free(msg);
+       msg = NULL;
+       goto out;
+}
+
+
+struct wpabuf * dpp_pkex_rx_commit_reveal_req(struct dpp_pkex *pkex,
+                                             const u8 *hdr,
+                                             const u8 *buf, size_t buflen)
+{
+       const struct dpp_curve_params *curve = pkex->own_bi->curve;
+       EVP_PKEY_CTX *ctx = NULL;
+       size_t Jx_len, Lx_len;
+       u8 Jx[DPP_MAX_SHARED_SECRET_LEN];
+       u8 Lx[DPP_MAX_SHARED_SECRET_LEN];
+       const u8 *wrapped_data, *b_key, *peer_u;
+       u16 wrapped_data_len, b_key_len, peer_u_len = 0;
+       const u8 *addr[4];
+       size_t len[4];
+       u8 octet;
+       u8 *unwrapped = NULL;
+       size_t unwrapped_len = 0;
+       struct wpabuf *msg = NULL, *A_pub = NULL, *X_pub = NULL, *Y_pub = NULL;
+       struct wpabuf *B_pub = NULL;
+       u8 u[DPP_MAX_HASH_LEN], v[DPP_MAX_HASH_LEN];
+
+#ifdef CONFIG_TESTING_OPTIONS
+       if (dpp_test == DPP_TEST_STOP_AT_PKEX_CR_REQ) {
+               wpa_printf(MSG_INFO,
+                          "DPP: TESTING - stop at PKEX CR Request");
+               pkex->failed = 1;
+               return NULL;
        }
 #endif /* CONFIG_TESTING_OPTIONS */
+
+       if (!pkex->exchange_done || pkex->failed ||
+           pkex->t >= PKEX_COUNTER_T_LIMIT || pkex->initiator)
+               goto fail;
+
+       wrapped_data = dpp_get_attr(buf, buflen, DPP_ATTR_WRAPPED_DATA,
+                                   &wrapped_data_len);
+       if (!wrapped_data || wrapped_data_len < AES_BLOCK_SIZE) {
+               dpp_pkex_fail(pkex,
+                             "Missing or invalid required Wrapped Data attribute");
+               goto fail;
+       }
+
+       wpa_hexdump(MSG_DEBUG, "DPP: AES-SIV ciphertext",
+                   wrapped_data, wrapped_data_len);
+       unwrapped_len = wrapped_data_len - AES_BLOCK_SIZE;
+       unwrapped = os_malloc(unwrapped_len);
+       if (!unwrapped)
+               goto fail;
+
+       addr[0] = hdr;
+       len[0] = DPP_HDR_LEN;
+       octet = 0;
+       addr[1] = &octet;
+       len[1] = sizeof(octet);
+       wpa_hexdump(MSG_DEBUG, "DDP: AES-SIV AD[0]", addr[0], len[0]);
+       wpa_hexdump(MSG_DEBUG, "DDP: AES-SIV AD[1]", addr[1], len[1]);
+
+       if (aes_siv_decrypt(pkex->z, curve->hash_len,
+                           wrapped_data, wrapped_data_len,
+                           2, addr, len, unwrapped) < 0) {
+               dpp_pkex_fail(pkex,
+                             "AES-SIV decryption failed - possible PKEX code mismatch");
+               pkex->failed = 1;
+               pkex->t++;
+               goto fail;
+       }
+       wpa_hexdump(MSG_DEBUG, "DPP: AES-SIV cleartext",
+                   unwrapped, unwrapped_len);
+
+       if (dpp_check_attrs(unwrapped, unwrapped_len) < 0) {
+               dpp_pkex_fail(pkex, "Invalid attribute in unwrapped data");
+               goto fail;
+       }
+
+       b_key = dpp_get_attr(unwrapped, unwrapped_len, DPP_ATTR_BOOTSTRAP_KEY,
+                            &b_key_len);
+       if (!b_key || b_key_len != 2 * curve->prime_len) {
+               dpp_pkex_fail(pkex, "No valid peer bootstrapping key found");
+               goto fail;
+       }
+       pkex->peer_bootstrap_key = dpp_set_pubkey_point(pkex->x, b_key,
+                                                       b_key_len);
+       if (!pkex->peer_bootstrap_key) {
+               dpp_pkex_fail(pkex, "Peer bootstrapping key is invalid");
+               goto fail;
+       }
+       dpp_debug_print_key("DPP: Peer bootstrap public key",
+                           pkex->peer_bootstrap_key);
+
+       /* ECDH: J' = y * A' */
+       ctx = EVP_PKEY_CTX_new(pkex->y, NULL);
+       if (!ctx ||
+           EVP_PKEY_derive_init(ctx) != 1 ||
+           EVP_PKEY_derive_set_peer(ctx, pkex->peer_bootstrap_key) != 1 ||
+           EVP_PKEY_derive(ctx, NULL, &Jx_len) != 1 ||
+           Jx_len > DPP_MAX_SHARED_SECRET_LEN ||
+           EVP_PKEY_derive(ctx, Jx, &Jx_len) != 1) {
+               wpa_printf(MSG_ERROR,
+                          "DPP: Failed to derive ECDH shared secret: %s",
+                          ERR_error_string(ERR_get_error(), NULL));
+               goto fail;
+       }
+
+       wpa_hexdump_key(MSG_DEBUG, "DPP: ECDH shared secret (J.x)",
+                       Jx, Jx_len);
+
+       /* u' = HMAC(J'.x, MAC-Initiator | A'.x | Y.x | X'.x) */
+       A_pub = dpp_get_pubkey_point(pkex->peer_bootstrap_key, 0);
+       Y_pub = dpp_get_pubkey_point(pkex->y, 0);
+       X_pub = dpp_get_pubkey_point(pkex->x, 0);
+       if (!A_pub || !Y_pub || !X_pub)
+               goto fail;
+       addr[0] = pkex->peer_mac;
+       len[0] = ETH_ALEN;
+       addr[1] = wpabuf_head(A_pub);
+       len[1] = wpabuf_len(A_pub) / 2;
+       addr[2] = wpabuf_head(Y_pub);
+       len[2] = wpabuf_len(Y_pub) / 2;
+       addr[3] = wpabuf_head(X_pub);
+       len[3] = wpabuf_len(X_pub) / 2;
+       if (dpp_hmac_vector(curve->hash_len, Jx, Jx_len, 4, addr, len, u) < 0)
+               goto fail;
+
+       peer_u = dpp_get_attr(unwrapped, unwrapped_len, DPP_ATTR_I_AUTH_TAG,
+                             &peer_u_len);
+       if (!peer_u || peer_u_len != curve->hash_len ||
+           os_memcmp(peer_u, u, curve->hash_len) != 0) {
+               dpp_pkex_fail(pkex, "No valid u (I-Auth tag) found");
+               wpa_hexdump(MSG_DEBUG, "DPP: Calculated u'",
+                           u, curve->hash_len);
+               wpa_hexdump(MSG_DEBUG, "DPP: Received u", peer_u, peer_u_len);
+               pkex->t++;
+               goto fail;
+       }
+       wpa_printf(MSG_DEBUG, "DPP: Valid u (I-Auth tag) received");
+
+       /* ECDH: L = b * X' */
+       EVP_PKEY_CTX_free(ctx);
+       ctx = EVP_PKEY_CTX_new(pkex->own_bi->pubkey, NULL);
+       if (!ctx ||
+           EVP_PKEY_derive_init(ctx) != 1 ||
+           EVP_PKEY_derive_set_peer(ctx, pkex->x) != 1 ||
+           EVP_PKEY_derive(ctx, NULL, &Lx_len) != 1 ||
+           Lx_len > DPP_MAX_SHARED_SECRET_LEN ||
+           EVP_PKEY_derive(ctx, Lx, &Lx_len) != 1) {
+               wpa_printf(MSG_ERROR,
+                          "DPP: Failed to derive ECDH shared secret: %s",
+                          ERR_error_string(ERR_get_error(), NULL));
+               goto fail;
+       }
+
+       wpa_hexdump_key(MSG_DEBUG, "DPP: ECDH shared secret (L.x)",
+                       Lx, Lx_len);
+
+       /* v = HMAC(L.x, MAC-Responder | B.x | X'.x | Y.x) */
+       B_pub = dpp_get_pubkey_point(pkex->own_bi->pubkey, 0);
+       if (!B_pub)
+               goto fail;
+       addr[0] = pkex->own_mac;
+       len[0] = ETH_ALEN;
+       addr[1] = wpabuf_head(B_pub);
+       len[1] = wpabuf_len(B_pub) / 2;
+       addr[2] = wpabuf_head(X_pub);
+       len[2] = wpabuf_len(X_pub) / 2;
+       addr[3] = wpabuf_head(Y_pub);
+       len[3] = wpabuf_len(Y_pub) / 2;
+       if (dpp_hmac_vector(curve->hash_len, Lx, Lx_len, 4, addr, len, v) < 0)
+               goto fail;
+       wpa_hexdump(MSG_DEBUG, "DPP: v", v, curve->hash_len);
+
+       msg = dpp_pkex_build_commit_reveal_resp(pkex, B_pub, v);
+       if (!msg)
+               goto fail;
+
 out:
        EVP_PKEY_CTX_free(ctx);
        os_free(unwrapped);
@@ -6274,11 +8083,10 @@ out:
        wpabuf_free(B_pub);
        wpabuf_free(X_pub);
        wpabuf_free(Y_pub);
-       wpabuf_free(clear);
        return msg;
 fail:
-       wpabuf_free(msg);
-       msg = NULL;
+       wpa_printf(MSG_DEBUG,
+                  "DPP: PKEX Commit-Reveal Request processing failed");
        goto out;
 }
 
@@ -6301,11 +8109,24 @@ int dpp_pkex_rx_commit_reveal_resp(struct dpp_pkex *pkex, const u8 *hdr,
        EVP_PKEY_CTX *ctx = NULL;
        struct wpabuf *B_pub = NULL, *X_pub = NULL, *Y_pub = NULL;
 
+#ifdef CONFIG_TESTING_OPTIONS
+       if (dpp_test == DPP_TEST_STOP_AT_PKEX_CR_RESP) {
+               wpa_printf(MSG_INFO,
+                          "DPP: TESTING - stop at PKEX CR Response");
+               pkex->failed = 1;
+               goto fail;
+       }
+#endif /* CONFIG_TESTING_OPTIONS */
+
+       if (!pkex->exchange_done || pkex->failed ||
+           pkex->t >= PKEX_COUNTER_T_LIMIT || !pkex->initiator)
+               goto fail;
+
        wrapped_data = dpp_get_attr(buf, buflen, DPP_ATTR_WRAPPED_DATA,
                                    &wrapped_data_len);
        if (!wrapped_data || wrapped_data_len < AES_BLOCK_SIZE) {
-               wpa_printf(MSG_DEBUG,
-                          "DPP: Missing or invalid required Wrapped data attribute");
+               dpp_pkex_fail(pkex,
+                             "Missing or invalid required Wrapped Data attribute");
                goto fail;
        }
 
@@ -6327,29 +8148,31 @@ int dpp_pkex_rx_commit_reveal_resp(struct dpp_pkex *pkex, const u8 *hdr,
        if (aes_siv_decrypt(pkex->z, curve->hash_len,
                            wrapped_data, wrapped_data_len,
                            2, addr, len, unwrapped) < 0) {
-               wpa_printf(MSG_DEBUG, "DPP: AES-SIV decryption failed");
+               dpp_pkex_fail(pkex,
+                             "AES-SIV decryption failed - possible PKEX code mismatch");
+               pkex->t++;
                goto fail;
        }
        wpa_hexdump(MSG_DEBUG, "DPP: AES-SIV cleartext",
                    unwrapped, unwrapped_len);
 
        if (dpp_check_attrs(unwrapped, unwrapped_len) < 0) {
-               wpa_printf(MSG_DEBUG,
-                          "DPP: Invalid attribute in unwrapped data");
+               dpp_pkex_fail(pkex, "Invalid attribute in unwrapped data");
                goto fail;
        }
 
        b_key = dpp_get_attr(unwrapped, unwrapped_len, DPP_ATTR_BOOTSTRAP_KEY,
                             &b_key_len);
        if (!b_key || b_key_len != 2 * curve->prime_len) {
-               wpa_printf(MSG_DEBUG,
-                          "DPP: No valid peer bootstrapping key found");
+               dpp_pkex_fail(pkex, "No valid peer bootstrapping key found");
                goto fail;
        }
        pkex->peer_bootstrap_key = dpp_set_pubkey_point(pkex->x, b_key,
                                                        b_key_len);
-       if (!pkex->peer_bootstrap_key)
+       if (!pkex->peer_bootstrap_key) {
+               dpp_pkex_fail(pkex, "Peer bootstrapping key is invalid");
                goto fail;
+       }
        dpp_debug_print_key("DPP: Peer bootstrap public key",
                            pkex->peer_bootstrap_key);
 
@@ -6391,10 +8214,11 @@ int dpp_pkex_rx_commit_reveal_resp(struct dpp_pkex *pkex, const u8 *hdr,
                              &peer_v_len);
        if (!peer_v || peer_v_len != curve->hash_len ||
            os_memcmp(peer_v, v, curve->hash_len) != 0) {
-               wpa_printf(MSG_DEBUG, "DPP: No valid v (R-Auth tag) found");
+               dpp_pkex_fail(pkex, "No valid v (R-Auth tag) found");
                wpa_hexdump(MSG_DEBUG, "DPP: Calculated v'",
                            v, curve->hash_len);
                wpa_hexdump(MSG_DEBUG, "DPP: Received v", peer_v, peer_v_len);
+               pkex->t++;
                goto fail;
        }
        wpa_printf(MSG_DEBUG, "DPP: Valid v (R-Auth tag) received");
@@ -6426,3 +8250,1852 @@ void dpp_pkex_free(struct dpp_pkex *pkex)
        wpabuf_free(pkex->exchange_resp);
        os_free(pkex);
 }
+
+
+#ifdef CONFIG_TESTING_OPTIONS
+char * dpp_corrupt_connector_signature(const char *connector)
+{
+       char *tmp, *pos, *signed3 = NULL;
+       unsigned char *signature = NULL;
+       size_t signature_len = 0, signed3_len;
+
+       tmp = os_zalloc(os_strlen(connector) + 5);
+       if (!tmp)
+               goto fail;
+       os_memcpy(tmp, connector, os_strlen(connector));
+
+       pos = os_strchr(tmp, '.');
+       if (!pos)
+               goto fail;
+
+       pos = os_strchr(pos + 1, '.');
+       if (!pos)
+               goto fail;
+       pos++;
+
+       wpa_printf(MSG_DEBUG, "DPP: Original base64url encoded signature: %s",
+                  pos);
+       signature = base64_url_decode((const unsigned char *) pos,
+                                     os_strlen(pos), &signature_len);
+       if (!signature || signature_len == 0)
+               goto fail;
+       wpa_hexdump(MSG_DEBUG, "DPP: Original Connector signature",
+                   signature, signature_len);
+       signature[signature_len - 1] ^= 0x01;
+       wpa_hexdump(MSG_DEBUG, "DPP: Corrupted Connector signature",
+                   signature, signature_len);
+       signed3 = (char *) base64_url_encode(signature, signature_len,
+                                            &signed3_len, 0);
+       if (!signed3)
+               goto fail;
+       os_memcpy(pos, signed3, signed3_len);
+       pos[signed3_len] = '\0';
+       wpa_printf(MSG_DEBUG, "DPP: Corrupted base64url encoded signature: %s",
+                  pos);
+
+out:
+       os_free(signature);
+       os_free(signed3);
+       return tmp;
+fail:
+       os_free(tmp);
+       tmp = NULL;
+       goto out;
+}
+#endif /* CONFIG_TESTING_OPTIONS */
+
+
+#ifdef CONFIG_DPP2
+
+struct dpp_pfs * dpp_pfs_init(const u8 *net_access_key,
+                             size_t net_access_key_len)
+{
+       struct wpabuf *pub = NULL;
+       EVP_PKEY *own_key;
+       struct dpp_pfs *pfs;
+
+       pfs = os_zalloc(sizeof(*pfs));
+       if (!pfs)
+               return NULL;
+
+       own_key = dpp_set_keypair(&pfs->curve, net_access_key,
+                                 net_access_key_len);
+       if (!own_key) {
+               wpa_printf(MSG_ERROR, "DPP: Failed to parse own netAccessKey");
+               goto fail;
+       }
+       EVP_PKEY_free(own_key);
+
+       pfs->ecdh = crypto_ecdh_init(pfs->curve->ike_group);
+       if (!pfs->ecdh)
+               goto fail;
+
+       pub = crypto_ecdh_get_pubkey(pfs->ecdh, 0);
+       pub = wpabuf_zeropad(pub, pfs->curve->prime_len);
+       if (!pub)
+               goto fail;
+
+       pfs->ie = wpabuf_alloc(5 + wpabuf_len(pub));
+       if (!pfs->ie)
+               goto fail;
+       wpabuf_put_u8(pfs->ie, WLAN_EID_EXTENSION);
+       wpabuf_put_u8(pfs->ie, 1 + 2 + wpabuf_len(pub));
+       wpabuf_put_u8(pfs->ie, WLAN_EID_EXT_OWE_DH_PARAM);
+       wpabuf_put_le16(pfs->ie, pfs->curve->ike_group);
+       wpabuf_put_buf(pfs->ie, pub);
+       wpabuf_free(pub);
+       wpa_hexdump_buf(MSG_DEBUG, "DPP: Diffie-Hellman Parameter element",
+                       pfs->ie);
+
+       return pfs;
+fail:
+       wpabuf_free(pub);
+       dpp_pfs_free(pfs);
+       return NULL;
+}
+
+
+int dpp_pfs_process(struct dpp_pfs *pfs, const u8 *peer_ie, size_t peer_ie_len)
+{
+       if (peer_ie_len < 2)
+               return -1;
+       if (WPA_GET_LE16(peer_ie) != pfs->curve->ike_group) {
+               wpa_printf(MSG_DEBUG, "DPP: Peer used different group for PFS");
+               return -1;
+       }
+
+       pfs->secret = crypto_ecdh_set_peerkey(pfs->ecdh, 0, peer_ie + 2,
+                                             peer_ie_len - 2);
+       pfs->secret = wpabuf_zeropad(pfs->secret, pfs->curve->prime_len);
+       if (!pfs->secret) {
+               wpa_printf(MSG_DEBUG, "DPP: Invalid peer DH public key");
+               return -1;
+       }
+       wpa_hexdump_buf_key(MSG_DEBUG, "DPP: DH shared secret", pfs->secret);
+       return 0;
+}
+
+
+void dpp_pfs_free(struct dpp_pfs *pfs)
+{
+       if (!pfs)
+               return;
+       crypto_ecdh_deinit(pfs->ecdh);
+       wpabuf_free(pfs->ie);
+       wpabuf_clear_free(pfs->secret);
+       os_free(pfs);
+}
+
+#endif /* CONFIG_DPP2 */
+
+
+static unsigned int dpp_next_id(struct dpp_global *dpp)
+{
+       struct dpp_bootstrap_info *bi;
+       unsigned int max_id = 0;
+
+       dl_list_for_each(bi, &dpp->bootstrap, struct dpp_bootstrap_info, list) {
+               if (bi->id > max_id)
+                       max_id = bi->id;
+       }
+       return max_id + 1;
+}
+
+
+static int dpp_bootstrap_del(struct dpp_global *dpp, unsigned int id)
+{
+       struct dpp_bootstrap_info *bi, *tmp;
+       int found = 0;
+
+       if (!dpp)
+               return -1;
+
+       dl_list_for_each_safe(bi, tmp, &dpp->bootstrap,
+                             struct dpp_bootstrap_info, list) {
+               if (id && bi->id != id)
+                       continue;
+               found = 1;
+               dl_list_del(&bi->list);
+               dpp_bootstrap_info_free(bi);
+       }
+
+       if (id == 0)
+               return 0; /* flush succeeds regardless of entries found */
+       return found ? 0 : -1;
+}
+
+
+struct dpp_bootstrap_info * dpp_add_qr_code(struct dpp_global *dpp,
+                                           const char *uri)
+{
+       struct dpp_bootstrap_info *bi;
+
+       if (!dpp)
+               return NULL;
+
+       bi = dpp_parse_qr_code(uri);
+       if (!bi)
+               return NULL;
+
+       bi->id = dpp_next_id(dpp);
+       dl_list_add(&dpp->bootstrap, &bi->list);
+       return bi;
+}
+
+
+int dpp_bootstrap_gen(struct dpp_global *dpp, const char *cmd)
+{
+       char *chan = NULL, *mac = NULL, *info = NULL, *pk = NULL, *curve = NULL;
+       char *key = NULL;
+       u8 *privkey = NULL;
+       size_t privkey_len = 0;
+       size_t len;
+       int ret = -1;
+       struct dpp_bootstrap_info *bi;
+
+       if (!dpp)
+               return -1;
+
+       bi = os_zalloc(sizeof(*bi));
+       if (!bi)
+               goto fail;
+
+       if (os_strstr(cmd, "type=qrcode"))
+               bi->type = DPP_BOOTSTRAP_QR_CODE;
+       else if (os_strstr(cmd, "type=pkex"))
+               bi->type = DPP_BOOTSTRAP_PKEX;
+       else
+               goto fail;
+
+       chan = get_param(cmd, " chan=");
+       mac = get_param(cmd, " mac=");
+       info = get_param(cmd, " info=");
+       curve = get_param(cmd, " curve=");
+       key = get_param(cmd, " key=");
+
+       if (key) {
+               privkey_len = os_strlen(key) / 2;
+               privkey = os_malloc(privkey_len);
+               if (!privkey ||
+                   hexstr2bin(key, privkey, privkey_len) < 0)
+                       goto fail;
+       }
+
+       pk = dpp_keygen(bi, curve, privkey, privkey_len);
+       if (!pk)
+               goto fail;
+
+       len = 4; /* "DPP:" */
+       if (chan) {
+               if (dpp_parse_uri_chan_list(bi, chan) < 0)
+                       goto fail;
+               len += 3 + os_strlen(chan); /* C:...; */
+       }
+       if (mac) {
+               if (dpp_parse_uri_mac(bi, mac) < 0)
+                       goto fail;
+               len += 3 + os_strlen(mac); /* M:...; */
+       }
+       if (info) {
+               if (dpp_parse_uri_info(bi, info) < 0)
+                       goto fail;
+               len += 3 + os_strlen(info); /* I:...; */
+       }
+       len += 4 + os_strlen(pk);
+       bi->uri = os_malloc(len + 1);
+       if (!bi->uri)
+               goto fail;
+       os_snprintf(bi->uri, len + 1, "DPP:%s%s%s%s%s%s%s%s%sK:%s;;",
+                   chan ? "C:" : "", chan ? chan : "", chan ? ";" : "",
+                   mac ? "M:" : "", mac ? mac : "", mac ? ";" : "",
+                   info ? "I:" : "", info ? info : "", info ? ";" : "",
+                   pk);
+       bi->id = dpp_next_id(dpp);
+       dl_list_add(&dpp->bootstrap, &bi->list);
+       ret = bi->id;
+       bi = NULL;
+fail:
+       os_free(curve);
+       os_free(pk);
+       os_free(chan);
+       os_free(mac);
+       os_free(info);
+       str_clear_free(key);
+       bin_clear_free(privkey, privkey_len);
+       dpp_bootstrap_info_free(bi);
+       return ret;
+}
+
+
+struct dpp_bootstrap_info *
+dpp_bootstrap_get_id(struct dpp_global *dpp, unsigned int id)
+{
+       struct dpp_bootstrap_info *bi;
+
+       if (!dpp)
+               return NULL;
+
+       dl_list_for_each(bi, &dpp->bootstrap, struct dpp_bootstrap_info, list) {
+               if (bi->id == id)
+                       return bi;
+       }
+       return NULL;
+}
+
+
+int dpp_bootstrap_remove(struct dpp_global *dpp, const char *id)
+{
+       unsigned int id_val;
+
+       if (os_strcmp(id, "*") == 0) {
+               id_val = 0;
+       } else {
+               id_val = atoi(id);
+               if (id_val == 0)
+                       return -1;
+       }
+
+       return dpp_bootstrap_del(dpp, id_val);
+}
+
+
+struct dpp_bootstrap_info *
+dpp_pkex_finish(struct dpp_global *dpp, struct dpp_pkex *pkex, const u8 *peer,
+               unsigned int freq)
+{
+       struct dpp_bootstrap_info *bi;
+
+       bi = os_zalloc(sizeof(*bi));
+       if (!bi)
+               return NULL;
+       bi->id = dpp_next_id(dpp);
+       bi->type = DPP_BOOTSTRAP_PKEX;
+       os_memcpy(bi->mac_addr, peer, ETH_ALEN);
+       bi->num_freq = 1;
+       bi->freq[0] = freq;
+       bi->curve = pkex->own_bi->curve;
+       bi->pubkey = pkex->peer_bootstrap_key;
+       pkex->peer_bootstrap_key = NULL;
+       if (dpp_bootstrap_key_hash(bi) < 0) {
+               dpp_bootstrap_info_free(bi);
+               return NULL;
+       }
+       dpp_pkex_free(pkex);
+       dl_list_add(&dpp->bootstrap, &bi->list);
+       return bi;
+}
+
+
+const char * dpp_bootstrap_get_uri(struct dpp_global *dpp, unsigned int id)
+{
+       struct dpp_bootstrap_info *bi;
+
+       bi = dpp_bootstrap_get_id(dpp, id);
+       if (!bi)
+               return NULL;
+       return bi->uri;
+}
+
+
+int dpp_bootstrap_info(struct dpp_global *dpp, int id,
+                      char *reply, int reply_size)
+{
+       struct dpp_bootstrap_info *bi;
+       char pkhash[2 * SHA256_MAC_LEN + 1];
+
+       bi = dpp_bootstrap_get_id(dpp, id);
+       if (!bi)
+               return -1;
+       wpa_snprintf_hex(pkhash, sizeof(pkhash), bi->pubkey_hash,
+                        SHA256_MAC_LEN);
+       return os_snprintf(reply, reply_size, "type=%s\n"
+                          "mac_addr=" MACSTR "\n"
+                          "info=%s\n"
+                          "num_freq=%u\n"
+                          "curve=%s\n"
+                          "pkhash=%s\n",
+                          dpp_bootstrap_type_txt(bi->type),
+                          MAC2STR(bi->mac_addr),
+                          bi->info ? bi->info : "",
+                          bi->num_freq,
+                          bi->curve->name,
+                          pkhash);
+}
+
+
+void dpp_bootstrap_find_pair(struct dpp_global *dpp, const u8 *i_bootstrap,
+                            const u8 *r_bootstrap,
+                            struct dpp_bootstrap_info **own_bi,
+                            struct dpp_bootstrap_info **peer_bi)
+{
+       struct dpp_bootstrap_info *bi;
+
+       *own_bi = NULL;
+       *peer_bi = NULL;
+       if (!dpp)
+               return;
+
+       dl_list_for_each(bi, &dpp->bootstrap, struct dpp_bootstrap_info, list) {
+               if (!*own_bi && bi->own &&
+                   os_memcmp(bi->pubkey_hash, r_bootstrap,
+                             SHA256_MAC_LEN) == 0) {
+                       wpa_printf(MSG_DEBUG,
+                                  "DPP: Found matching own bootstrapping information");
+                       *own_bi = bi;
+               }
+
+               if (!*peer_bi && !bi->own &&
+                   os_memcmp(bi->pubkey_hash, i_bootstrap,
+                             SHA256_MAC_LEN) == 0) {
+                       wpa_printf(MSG_DEBUG,
+                                  "DPP: Found matching peer bootstrapping information");
+                       *peer_bi = bi;
+               }
+
+               if (*own_bi && *peer_bi)
+                       break;
+       }
+
+}
+
+
+static unsigned int dpp_next_configurator_id(struct dpp_global *dpp)
+{
+       struct dpp_configurator *conf;
+       unsigned int max_id = 0;
+
+       dl_list_for_each(conf, &dpp->configurator, struct dpp_configurator,
+                        list) {
+               if (conf->id > max_id)
+                       max_id = conf->id;
+       }
+       return max_id + 1;
+}
+
+
+int dpp_configurator_add(struct dpp_global *dpp, const char *cmd)
+{
+       char *curve = NULL;
+       char *key = NULL;
+       u8 *privkey = NULL;
+       size_t privkey_len = 0;
+       int ret = -1;
+       struct dpp_configurator *conf = NULL;
+
+       curve = get_param(cmd, " curve=");
+       key = get_param(cmd, " key=");
+
+       if (key) {
+               privkey_len = os_strlen(key) / 2;
+               privkey = os_malloc(privkey_len);
+               if (!privkey ||
+                   hexstr2bin(key, privkey, privkey_len) < 0)
+                       goto fail;
+       }
+
+       conf = dpp_keygen_configurator(curve, privkey, privkey_len);
+       if (!conf)
+               goto fail;
+
+       conf->id = dpp_next_configurator_id(dpp);
+       dl_list_add(&dpp->configurator, &conf->list);
+       ret = conf->id;
+       conf = NULL;
+fail:
+       os_free(curve);
+       str_clear_free(key);
+       bin_clear_free(privkey, privkey_len);
+       dpp_configurator_free(conf);
+       return ret;
+}
+
+
+static int dpp_configurator_del(struct dpp_global *dpp, unsigned int id)
+{
+       struct dpp_configurator *conf, *tmp;
+       int found = 0;
+
+       if (!dpp)
+               return -1;
+
+       dl_list_for_each_safe(conf, tmp, &dpp->configurator,
+                             struct dpp_configurator, list) {
+               if (id && conf->id != id)
+                       continue;
+               found = 1;
+               dl_list_del(&conf->list);
+               dpp_configurator_free(conf);
+       }
+
+       if (id == 0)
+               return 0; /* flush succeeds regardless of entries found */
+       return found ? 0 : -1;
+}
+
+
+int dpp_configurator_remove(struct dpp_global *dpp, const char *id)
+{
+       unsigned int id_val;
+
+       if (os_strcmp(id, "*") == 0) {
+               id_val = 0;
+       } else {
+               id_val = atoi(id);
+               if (id_val == 0)
+                       return -1;
+       }
+
+       return dpp_configurator_del(dpp, id_val);
+}
+
+
+int dpp_configurator_get_key_id(struct dpp_global *dpp, unsigned int id,
+                               char *buf, size_t buflen)
+{
+       struct dpp_configurator *conf;
+
+       conf = dpp_configurator_get_id(dpp, id);
+       if (!conf)
+               return -1;
+
+       return dpp_configurator_get_key(conf, buf, buflen);
+}
+
+
+#ifdef CONFIG_DPP2
+
+static void dpp_connection_free(struct dpp_connection *conn)
+{
+       if (conn->sock >= 0) {
+               wpa_printf(MSG_DEBUG, "DPP: Close Controller socket %d",
+                          conn->sock);
+               eloop_unregister_sock(conn->sock, EVENT_TYPE_READ);
+               eloop_unregister_sock(conn->sock, EVENT_TYPE_WRITE);
+               close(conn->sock);
+       }
+       wpabuf_free(conn->msg);
+       wpabuf_free(conn->msg_out);
+       dpp_auth_deinit(conn->auth);
+       os_free(conn);
+}
+
+
+static void dpp_connection_remove(struct dpp_connection *conn)
+{
+       dl_list_del(&conn->list);
+       dpp_connection_free(conn);
+}
+
+
+static void dpp_tcp_init_flush(struct dpp_global *dpp)
+{
+       struct dpp_connection *conn, *tmp;
+
+       dl_list_for_each_safe(conn, tmp, &dpp->tcp_init, struct dpp_connection,
+                             list)
+               dpp_connection_remove(conn);
+}
+
+
+static void dpp_relay_controller_free(struct dpp_relay_controller *ctrl)
+{
+       struct dpp_connection *conn, *tmp;
+
+       dl_list_for_each_safe(conn, tmp, &ctrl->conn, struct dpp_connection,
+                             list)
+               dpp_connection_remove(conn);
+       os_free(ctrl);
+}
+
+
+static void dpp_relay_flush_controllers(struct dpp_global *dpp)
+{
+       struct dpp_relay_controller *ctrl, *tmp;
+
+       if (!dpp)
+               return;
+
+       dl_list_for_each_safe(ctrl, tmp, &dpp->controllers,
+                             struct dpp_relay_controller, list) {
+               dl_list_del(&ctrl->list);
+               dpp_relay_controller_free(ctrl);
+       }
+}
+
+#endif /* CONFIG_DPP2 */
+
+
+struct dpp_global * dpp_global_init(struct dpp_global_config *config)
+{
+       struct dpp_global *dpp;
+
+       dpp = os_zalloc(sizeof(*dpp));
+       if (!dpp)
+               return NULL;
+       dpp->msg_ctx = config->msg_ctx;
+#ifdef CONFIG_DPP2
+       dpp->cb_ctx = config->cb_ctx;
+       dpp->process_conf_obj = config->process_conf_obj;
+#endif /* CONFIG_DPP2 */
+
+       dl_list_init(&dpp->bootstrap);
+       dl_list_init(&dpp->configurator);
+#ifdef CONFIG_DPP2
+       dl_list_init(&dpp->controllers);
+       dl_list_init(&dpp->tcp_init);
+#endif /* CONFIG_DPP2 */
+
+       return dpp;
+}
+
+
+void dpp_global_clear(struct dpp_global *dpp)
+{
+       if (!dpp)
+               return;
+
+       dpp_bootstrap_del(dpp, 0);
+       dpp_configurator_del(dpp, 0);
+#ifdef CONFIG_DPP2
+       dpp_tcp_init_flush(dpp);
+       dpp_relay_flush_controllers(dpp);
+       dpp_controller_stop(dpp);
+#endif /* CONFIG_DPP2 */
+}
+
+
+void dpp_global_deinit(struct dpp_global *dpp)
+{
+       dpp_global_clear(dpp);
+       os_free(dpp);
+}
+
+
+#ifdef CONFIG_DPP2
+
+static void dpp_controller_rx(int sd, void *eloop_ctx, void *sock_ctx);
+static void dpp_conn_tx_ready(int sock, void *eloop_ctx, void *sock_ctx);
+static void dpp_controller_auth_success(struct dpp_connection *conn,
+                                       int initiator);
+
+
+int dpp_relay_add_controller(struct dpp_global *dpp,
+                            struct dpp_relay_config *config)
+{
+       struct dpp_relay_controller *ctrl;
+
+       if (!dpp)
+               return -1;
+
+       ctrl = os_zalloc(sizeof(*ctrl));
+       if (!ctrl)
+               return -1;
+       dl_list_init(&ctrl->conn);
+       ctrl->global = dpp;
+       os_memcpy(&ctrl->ipaddr, config->ipaddr, sizeof(*config->ipaddr));
+       os_memcpy(ctrl->pkhash, config->pkhash, SHA256_MAC_LEN);
+       ctrl->cb_ctx = config->cb_ctx;
+       ctrl->tx = config->tx;
+       ctrl->gas_resp_tx = config->gas_resp_tx;
+       dl_list_add(&dpp->controllers, &ctrl->list);
+       return 0;
+}
+
+
+static struct dpp_relay_controller *
+dpp_relay_controller_get(struct dpp_global *dpp, const u8 *pkhash)
+{
+       struct dpp_relay_controller *ctrl;
+
+       if (!dpp)
+               return NULL;
+
+       dl_list_for_each(ctrl, &dpp->controllers, struct dpp_relay_controller,
+                        list) {
+               if (os_memcmp(pkhash, ctrl->pkhash, SHA256_MAC_LEN) == 0)
+                       return ctrl;
+       }
+
+       return NULL;
+}
+
+
+static void dpp_controller_gas_done(struct dpp_connection *conn)
+{
+       struct dpp_authentication *auth = conn->auth;
+
+       if (auth->peer_version >= 2 &&
+           auth->conf_resp_status == DPP_STATUS_OK) {
+               wpa_printf(MSG_DEBUG, "DPP: Wait for Configuration Result");
+               auth->waiting_conf_result = 1;
+               return;
+       }
+
+       wpa_msg(conn->ctrl->global->msg_ctx, MSG_INFO, DPP_EVENT_CONF_SENT);
+       dpp_connection_remove(conn);
+}
+
+
+static int dpp_tcp_send(struct dpp_connection *conn)
+{
+       int res;
+
+       if (!conn->msg_out) {
+               eloop_unregister_sock(conn->sock, EVENT_TYPE_WRITE);
+               conn->write_eloop = 0;
+               return -1;
+       }
+       res = send(conn->sock,
+                  wpabuf_head_u8(conn->msg_out) + conn->msg_out_pos,
+                  wpabuf_len(conn->msg_out) - conn->msg_out_pos, 0);
+       if (res < 0) {
+               wpa_printf(MSG_DEBUG, "DPP: Failed to send buffer: %s",
+                          strerror(errno));
+               dpp_connection_remove(conn);
+               return -1;
+       }
+
+       conn->msg_out_pos += res;
+       if (wpabuf_len(conn->msg_out) > conn->msg_out_pos) {
+               wpa_printf(MSG_DEBUG,
+                          "DPP: %u/%u bytes of message sent to Controller",
+                          (unsigned int) conn->msg_out_pos,
+                          (unsigned int) wpabuf_len(conn->msg_out));
+               if (!conn->write_eloop &&
+                   eloop_register_sock(conn->sock, EVENT_TYPE_WRITE,
+                                       dpp_conn_tx_ready, conn, NULL) == 0)
+                       conn->write_eloop = 1;
+               return 1;
+       }
+
+       wpa_printf(MSG_DEBUG, "DPP: Full message sent over TCP");
+       wpabuf_free(conn->msg_out);
+       conn->msg_out = NULL;
+       conn->msg_out_pos = 0;
+       eloop_unregister_sock(conn->sock, EVENT_TYPE_WRITE);
+       conn->write_eloop = 0;
+       if (!conn->read_eloop &&
+           eloop_register_sock(conn->sock, EVENT_TYPE_READ,
+                               dpp_controller_rx, conn, NULL) == 0)
+               conn->read_eloop = 1;
+       if (conn->on_tcp_tx_complete_remove) {
+               dpp_connection_remove(conn);
+       } else if (conn->ctrl && conn->on_tcp_tx_complete_gas_done &&
+                  conn->auth) {
+               dpp_controller_gas_done(conn);
+       } else if (conn->on_tcp_tx_complete_auth_ok) {
+               conn->on_tcp_tx_complete_auth_ok = 0;
+               dpp_controller_auth_success(conn, 1);
+       }
+
+       return 0;
+}
+
+
+static void dpp_controller_start_gas_client(struct dpp_connection *conn)
+{
+       struct dpp_authentication *auth = conn->auth;
+       struct wpabuf *buf;
+       char json[100];
+       int netrole_ap = 0; /* TODO: make this configurable */
+
+       os_snprintf(json, sizeof(json),
+                   "{\"name\":\"Test\","
+                   "\"wi-fi_tech\":\"infra\","
+                   "\"netRole\":\"%s\"}",
+                   netrole_ap ? "ap" : "sta");
+#ifdef CONFIG_TESTING_OPTIONS
+       if (dpp_test == DPP_TEST_INVALID_CONFIG_ATTR_OBJ_CONF_REQ) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - invalid Config Attr");
+               json[29] = 'k'; /* replace "infra" with "knfra" */
+       }
+#endif /* CONFIG_TESTING_OPTIONS */
+       wpa_printf(MSG_DEBUG, "DPP: GAS Config Attributes: %s", json);
+
+       buf = dpp_build_conf_req(auth, json);
+       if (!buf) {
+               wpa_printf(MSG_DEBUG,
+                          "DPP: No configuration request data available");
+               return;
+       }
+
+       wpabuf_free(conn->msg_out);
+       conn->msg_out_pos = 0;
+       conn->msg_out = wpabuf_alloc(4 + wpabuf_len(buf) - 1);
+       if (!conn->msg_out) {
+               wpabuf_free(buf);
+               return;
+       }
+       wpabuf_put_be32(conn->msg_out, wpabuf_len(buf) - 1);
+       wpabuf_put_data(conn->msg_out, wpabuf_head(buf) + 1,
+                       wpabuf_len(buf) - 1);
+       wpabuf_free(buf);
+
+       if (dpp_tcp_send(conn) == 1) {
+               if (!conn->write_eloop) {
+                       if (eloop_register_sock(conn->sock, EVENT_TYPE_WRITE,
+                                               dpp_conn_tx_ready,
+                                               conn, NULL) < 0)
+                               return;
+                       conn->write_eloop = 1;
+               }
+       }
+}
+
+
+static void dpp_controller_auth_success(struct dpp_connection *conn,
+                                       int initiator)
+{
+       struct dpp_authentication *auth = conn->auth;
+
+       if (!auth)
+               return;
+
+       wpa_printf(MSG_DEBUG, "DPP: Authentication succeeded");
+       wpa_msg(conn->global->msg_ctx, MSG_INFO,
+               DPP_EVENT_AUTH_SUCCESS "init=%d", initiator);
+#ifdef CONFIG_TESTING_OPTIONS
+       if (dpp_test == DPP_TEST_STOP_AT_AUTH_CONF) {
+               wpa_printf(MSG_INFO,
+                          "DPP: TESTING - stop at Authentication Confirm");
+               if (auth->configurator) {
+                       /* Prevent GAS response */
+                       auth->auth_success = 0;
+               }
+               return;
+       }
+#endif /* CONFIG_TESTING_OPTIONS */
+
+       if (!auth->configurator)
+               dpp_controller_start_gas_client(conn);
+}
+
+
+static void dpp_conn_tx_ready(int sock, void *eloop_ctx, void *sock_ctx)
+{
+       struct dpp_connection *conn = eloop_ctx;
+
+       wpa_printf(MSG_DEBUG, "DPP: TCP socket %d ready for TX", sock);
+       dpp_tcp_send(conn);
+}
+
+
+static int dpp_ipaddr_to_sockaddr(struct sockaddr *addr, socklen_t *addrlen,
+                                 const struct hostapd_ip_addr *ipaddr,
+                                 int port)
+{
+       struct sockaddr_in *dst;
+#ifdef CONFIG_IPV6
+       struct sockaddr_in6 *dst6;
+#endif /* CONFIG_IPV6 */
+
+       switch (ipaddr->af) {
+       case AF_INET:
+               dst = (struct sockaddr_in *) addr;
+               os_memset(dst, 0, sizeof(*dst));
+               dst->sin_family = AF_INET;
+               dst->sin_addr.s_addr = ipaddr->u.v4.s_addr;
+               dst->sin_port = htons(port);
+               *addrlen = sizeof(*dst);
+               break;
+#ifdef CONFIG_IPV6
+       case AF_INET6:
+               dst6 = (struct sockaddr_in6 *) addr;
+               os_memset(dst6, 0, sizeof(*dst6));
+               dst6->sin6_family = AF_INET6;
+               os_memcpy(&dst6->sin6_addr, &ipaddr->u.v6,
+                         sizeof(struct in6_addr));
+               dst6->sin6_port = htons(port);
+               *addrlen = sizeof(*dst6);
+               break;
+#endif /* CONFIG_IPV6 */
+       default:
+               return -1;
+       }
+
+       return 0;
+}
+
+
+static struct dpp_connection *
+dpp_relay_new_conn(struct dpp_relay_controller *ctrl, const u8 *src,
+                  unsigned int freq)
+{
+       struct dpp_connection *conn;
+       struct sockaddr_storage addr;
+       socklen_t addrlen;
+       char txt[100];
+
+       if (dl_list_len(&ctrl->conn) >= 15) {
+               wpa_printf(MSG_DEBUG,
+                          "DPP: Too many ongoing Relay connections to the Controller - cannot start a new one");
+               return NULL;
+       }
+
+       if (dpp_ipaddr_to_sockaddr((struct sockaddr *) &addr, &addrlen,
+                                  &ctrl->ipaddr, DPP_TCP_PORT) < 0)
+               return NULL;
+
+       conn = os_zalloc(sizeof(*conn));
+       if (!conn)
+               return NULL;
+
+       conn->global = ctrl->global;
+       conn->relay = ctrl;
+       os_memcpy(conn->mac_addr, src, ETH_ALEN);
+       conn->freq = freq;
+
+       conn->sock = socket(AF_INET, SOCK_STREAM, 0);
+       if (conn->sock < 0)
+               goto fail;
+       wpa_printf(MSG_DEBUG, "DPP: TCP relay socket %d connection to %s",
+                  conn->sock, hostapd_ip_txt(&ctrl->ipaddr, txt, sizeof(txt)));
+
+       if (fcntl(conn->sock, F_SETFL, O_NONBLOCK) != 0) {
+               wpa_printf(MSG_DEBUG, "DPP: fnctl(O_NONBLOCK) failed: %s",
+                          strerror(errno));
+               goto fail;
+       }
+
+       if (connect(conn->sock, (struct sockaddr *) &addr, addrlen) < 0) {
+               if (errno != EINPROGRESS) {
+                       wpa_printf(MSG_DEBUG, "DPP: Failed to connect: %s",
+                                  strerror(errno));
+                       goto fail;
+               }
+
+               /*
+                * Continue connecting in the background; eloop will call us
+                * once the connection is ready (or failed).
+                */
+       }
+
+       if (eloop_register_sock(conn->sock, EVENT_TYPE_WRITE,
+                               dpp_conn_tx_ready, conn, NULL) < 0)
+               goto fail;
+       conn->write_eloop = 1;
+
+       /* TODO: eloop timeout to clear a connection if it does not complete
+        * properly */
+
+       dl_list_add(&ctrl->conn, &conn->list);
+       return conn;
+fail:
+       dpp_connection_free(conn);
+       return NULL;
+}
+
+
+static struct wpabuf * dpp_tcp_encaps(const u8 *hdr, const u8 *buf, size_t len)
+{
+       struct wpabuf *msg;
+
+       msg = wpabuf_alloc(4 + 1 + DPP_HDR_LEN + len);
+       if (!msg)
+               return NULL;
+       wpabuf_put_be32(msg, 1 + DPP_HDR_LEN + len);
+       wpabuf_put_u8(msg, WLAN_PA_VENDOR_SPECIFIC);
+       wpabuf_put_data(msg, hdr, DPP_HDR_LEN);
+       wpabuf_put_data(msg, buf, len);
+       wpa_hexdump_buf(MSG_MSGDUMP, "DPP: Outgoing TCP message", msg);
+       return msg;
+}
+
+
+static int dpp_relay_tx(struct dpp_connection *conn, const u8 *hdr,
+                       const u8 *buf, size_t len)
+{
+       u8 type = hdr[DPP_HDR_LEN - 1];
+
+       wpa_printf(MSG_DEBUG,
+                  "DPP: Continue already established Relay/Controller connection for this session");
+       wpabuf_free(conn->msg_out);
+       conn->msg_out_pos = 0;
+       conn->msg_out = dpp_tcp_encaps(hdr, buf, len);
+       if (!conn->msg_out) {
+               dpp_connection_remove(conn);
+               return -1;
+       }
+
+       /* TODO: for proto ver 1, need to do remove connection based on GAS Resp
+        * TX status */
+       if (type == DPP_PA_CONFIGURATION_RESULT)
+               conn->on_tcp_tx_complete_remove = 1;
+       dpp_tcp_send(conn);
+       return 0;
+}
+
+
+int dpp_relay_rx_action(struct dpp_global *dpp, const u8 *src, const u8 *hdr,
+                       const u8 *buf, size_t len, unsigned int freq,
+                       const u8 *i_bootstrap, const u8 *r_bootstrap)
+{
+       struct dpp_relay_controller *ctrl;
+       struct dpp_connection *conn;
+       u8 type = hdr[DPP_HDR_LEN - 1];
+
+       /* Check if there is an already started session for this peer and if so,
+        * continue that session (send this over TCP) and return 0.
+        */
+       if (type != DPP_PA_PEER_DISCOVERY_REQ &&
+           type != DPP_PA_PEER_DISCOVERY_RESP) {
+               dl_list_for_each(ctrl, &dpp->controllers,
+                                struct dpp_relay_controller, list) {
+                       dl_list_for_each(conn, &ctrl->conn,
+                                        struct dpp_connection, list) {
+                               if (os_memcmp(src, conn->mac_addr,
+                                             ETH_ALEN) == 0)
+                                       return dpp_relay_tx(conn, hdr, buf, len);
+                       }
+               }
+       }
+
+       if (!r_bootstrap)
+               return -1;
+
+       ctrl = dpp_relay_controller_get(dpp, r_bootstrap);
+       if (!ctrl)
+               return -1;
+
+       wpa_printf(MSG_DEBUG,
+                  "DPP: Authentication Request for a configured Controller");
+       conn = dpp_relay_new_conn(ctrl, src, freq);
+       if (!conn)
+               return -1;
+
+       conn->msg_out = dpp_tcp_encaps(hdr, buf, len);
+       if (!conn->msg_out) {
+               dpp_connection_remove(conn);
+               return -1;
+       }
+       /* Message will be sent in dpp_conn_tx_ready() */
+
+       return 0;
+}
+
+
+int dpp_relay_rx_gas_req(struct dpp_global *dpp, const u8 *src, const u8 *data,
+                        size_t data_len)
+{
+       struct dpp_relay_controller *ctrl;
+       struct dpp_connection *conn, *found = NULL;
+       struct wpabuf *msg;
+
+       /* Check if there is a successfully completed authentication for this
+        * and if so, continue that session (send this over TCP) and return 0.
+        */
+       dl_list_for_each(ctrl, &dpp->controllers,
+                        struct dpp_relay_controller, list) {
+               if (found)
+                       break;
+               dl_list_for_each(conn, &ctrl->conn,
+                                struct dpp_connection, list) {
+                       if (os_memcmp(src, conn->mac_addr,
+                                     ETH_ALEN) == 0) {
+                               found = conn;
+                               break;
+                       }
+               }
+       }
+
+       if (!found)
+               return -1;
+
+       msg = wpabuf_alloc(4 + 1 + data_len);
+       if (!msg)
+               return -1;
+       wpabuf_put_be32(msg, 1 + data_len);
+       wpabuf_put_u8(msg, WLAN_PA_GAS_INITIAL_REQ);
+       wpabuf_put_data(msg, data, data_len);
+       wpa_hexdump_buf(MSG_MSGDUMP, "DPP: Outgoing TCP message", msg);
+
+       wpabuf_free(conn->msg_out);
+       conn->msg_out_pos = 0;
+       conn->msg_out = msg;
+       dpp_tcp_send(conn);
+       return 0;
+}
+
+
+static void dpp_controller_free(struct dpp_controller *ctrl)
+{
+       struct dpp_connection *conn, *tmp;
+
+       if (!ctrl)
+               return;
+
+       dl_list_for_each_safe(conn, tmp, &ctrl->conn, struct dpp_connection,
+                             list)
+               dpp_connection_remove(conn);
+
+       if (ctrl->sock >= 0) {
+               close(ctrl->sock);
+               eloop_unregister_sock(ctrl->sock, EVENT_TYPE_READ);
+       }
+       os_free(ctrl->configurator_params);
+       os_free(ctrl);
+}
+
+
+static int dpp_controller_rx_auth_req(struct dpp_connection *conn,
+                                     const u8 *hdr, const u8 *buf, size_t len)
+{
+       const u8 *r_bootstrap, *i_bootstrap;
+       u16 r_bootstrap_len, i_bootstrap_len;
+       struct dpp_bootstrap_info *own_bi = NULL, *peer_bi = NULL;
+
+       if (!conn->ctrl)
+               return 0;
+
+       wpa_printf(MSG_DEBUG, "DPP: Authentication Request");
+
+       r_bootstrap = dpp_get_attr(buf, len, DPP_ATTR_R_BOOTSTRAP_KEY_HASH,
+                                  &r_bootstrap_len);
+       if (!r_bootstrap || r_bootstrap_len != SHA256_MAC_LEN) {
+               wpa_printf(MSG_INFO,
+                          "Missing or invalid required Responder Bootstrapping Key Hash attribute");
+               return -1;
+       }
+       wpa_hexdump(MSG_MSGDUMP, "DPP: Responder Bootstrapping Key Hash",
+                   r_bootstrap, r_bootstrap_len);
+
+       i_bootstrap = dpp_get_attr(buf, len, DPP_ATTR_I_BOOTSTRAP_KEY_HASH,
+                                  &i_bootstrap_len);
+       if (!i_bootstrap || i_bootstrap_len != SHA256_MAC_LEN) {
+               wpa_printf(MSG_INFO,
+                          "Missing or invalid required Initiator Bootstrapping Key Hash attribute");
+               return -1;
+       }
+       wpa_hexdump(MSG_MSGDUMP, "DPP: Initiator Bootstrapping Key Hash",
+                   i_bootstrap, i_bootstrap_len);
+
+       /* Try to find own and peer bootstrapping key matches based on the
+        * received hash values */
+       dpp_bootstrap_find_pair(conn->ctrl->global, i_bootstrap, r_bootstrap,
+                               &own_bi, &peer_bi);
+       if (!own_bi) {
+               wpa_printf(MSG_INFO,
+                       "No matching own bootstrapping key found - ignore message");
+               return -1;
+       }
+
+       if (conn->auth) {
+               wpa_printf(MSG_INFO,
+                          "Already in DPP authentication exchange - ignore new one");
+               return 0;
+       }
+
+       conn->auth = dpp_auth_req_rx(conn->ctrl->global->msg_ctx,
+                                    conn->ctrl->allowed_roles,
+                                    conn->ctrl->qr_mutual,
+                                    peer_bi, own_bi, -1, hdr, buf, len);
+       if (!conn->auth) {
+               wpa_printf(MSG_DEBUG, "DPP: No response generated");
+               return -1;
+       }
+
+       if (dpp_set_configurator(conn->ctrl->global, conn->ctrl->global->msg_ctx,
+                                conn->auth,
+                                conn->ctrl->configurator_params) < 0) {
+               dpp_connection_remove(conn);
+               return -1;
+       }
+
+       wpabuf_free(conn->msg_out);
+       conn->msg_out_pos = 0;
+       conn->msg_out = wpabuf_alloc(4 + wpabuf_len(conn->auth->resp_msg) - 1);
+       if (!conn->msg_out)
+               return -1;
+       wpabuf_put_be32(conn->msg_out, wpabuf_len(conn->auth->resp_msg) - 1);
+       wpabuf_put_data(conn->msg_out, wpabuf_head(conn->auth->resp_msg) + 1,
+                       wpabuf_len(conn->auth->resp_msg) - 1);
+
+       if (dpp_tcp_send(conn) == 1) {
+               if (!conn->write_eloop) {
+                       if (eloop_register_sock(conn->sock, EVENT_TYPE_WRITE,
+                                               dpp_conn_tx_ready,
+                                               conn, NULL) < 0)
+                               return -1;
+                       conn->write_eloop = 1;
+               }
+       }
+
+       return 0;
+}
+
+
+static int dpp_controller_rx_auth_resp(struct dpp_connection *conn,
+                                      const u8 *hdr, const u8 *buf, size_t len)
+{
+       struct dpp_authentication *auth = conn->auth;
+       struct wpabuf *msg;
+
+       if (!auth)
+               return -1;
+
+       wpa_printf(MSG_DEBUG, "DPP: Authentication Response");
+
+       msg = dpp_auth_resp_rx(auth, hdr, buf, len);
+       if (!msg) {
+               if (auth->auth_resp_status == DPP_STATUS_RESPONSE_PENDING) {
+                       wpa_printf(MSG_DEBUG,
+                                  "DPP: Start wait for full response");
+                       return -1;
+               }
+               wpa_printf(MSG_DEBUG, "DPP: No confirm generated");
+               dpp_connection_remove(conn);
+               return -1;
+       }
+
+       wpabuf_free(conn->msg_out);
+       conn->msg_out_pos = 0;
+       conn->msg_out = wpabuf_alloc(4 + wpabuf_len(msg) - 1);
+       if (!conn->msg_out) {
+               wpabuf_free(msg);
+               return -1;
+       }
+       wpabuf_put_be32(conn->msg_out, wpabuf_len(msg) - 1);
+       wpabuf_put_data(conn->msg_out, wpabuf_head(msg) + 1,
+                       wpabuf_len(msg) - 1);
+       wpabuf_free(msg);
+
+       conn->on_tcp_tx_complete_auth_ok = 1;
+       if (dpp_tcp_send(conn) == 1) {
+               if (!conn->write_eloop) {
+                       if (eloop_register_sock(conn->sock, EVENT_TYPE_WRITE,
+                                               dpp_conn_tx_ready,
+                                               conn, NULL) < 0)
+                               return -1;
+                       conn->write_eloop = 1;
+               }
+       }
+
+       return 0;
+}
+
+
+static int dpp_controller_rx_auth_conf(struct dpp_connection *conn,
+                                      const u8 *hdr, const u8 *buf, size_t len)
+{
+       struct dpp_authentication *auth = conn->auth;
+
+       wpa_printf(MSG_DEBUG, "DPP: Authentication Confirmation");
+
+       if (!auth) {
+               wpa_printf(MSG_DEBUG,
+                          "DPP: No DPP Authentication in progress - drop");
+               return -1;
+       }
+
+       if (dpp_auth_conf_rx(auth, hdr, buf, len) < 0) {
+               wpa_printf(MSG_DEBUG, "DPP: Authentication failed");
+               return -1;
+       }
+
+       dpp_controller_auth_success(conn, 0);
+       return 0;
+}
+
+
+static int dpp_controller_rx_conf_result(struct dpp_connection *conn,
+                                        const u8 *hdr, const u8 *buf,
+                                        size_t len)
+{
+       struct dpp_authentication *auth = conn->auth;
+       enum dpp_status_error status;
+
+       if (!conn->ctrl)
+               return 0;
+
+       wpa_printf(MSG_DEBUG, "DPP: Configuration Result");
+
+       if (!auth || !auth->waiting_conf_result) {
+               wpa_printf(MSG_DEBUG,
+                          "DPP: No DPP Configuration waiting for result - drop");
+               return -1;
+       }
+
+       status = dpp_conf_result_rx(auth, hdr, buf, len);
+       if (status == DPP_STATUS_OK)
+               wpa_msg(conn->ctrl->global->msg_ctx, MSG_INFO,
+                       DPP_EVENT_CONF_SENT);
+       else
+               wpa_msg(conn->ctrl->global->msg_ctx, MSG_INFO,
+                       DPP_EVENT_CONF_FAILED);
+       return -1; /* to remove the completed connection */
+}
+
+
+static int dpp_controller_rx_action(struct dpp_connection *conn, const u8 *msg,
+                                   size_t len)
+{
+       const u8 *pos, *end;
+       u8 type;
+
+       wpa_printf(MSG_DEBUG, "DPP: Received DPP Action frame over TCP");
+       pos = msg;
+       end = msg + len;
+
+       if (end - pos < DPP_HDR_LEN ||
+           WPA_GET_BE24(pos) != OUI_WFA ||
+           pos[3] != DPP_OUI_TYPE) {
+               wpa_printf(MSG_DEBUG, "DPP: Unrecognized header");
+               return -1;
+       }
+
+       if (pos[4] != 1) {
+               wpa_printf(MSG_DEBUG, "DPP: Unsupported Crypto Suite %u",
+                          pos[4]);
+               return -1;
+       }
+       type = pos[5];
+       wpa_printf(MSG_DEBUG, "DPP: Received message type %u", type);
+       pos += DPP_HDR_LEN;
+
+       wpa_hexdump(MSG_MSGDUMP, "DPP: Received message attributes",
+                   pos, end - pos);
+       if (dpp_check_attrs(pos, end - pos) < 0)
+               return -1;
+
+       if (conn->relay) {
+               wpa_printf(MSG_DEBUG, "DPP: Relay - send over WLAN");
+               conn->relay->tx(conn->relay->cb_ctx, conn->mac_addr,
+                               conn->freq, msg, len);
+               return 0;
+       }
+
+       switch (type) {
+       case DPP_PA_AUTHENTICATION_REQ:
+               return dpp_controller_rx_auth_req(conn, msg, pos, end - pos);
+       case DPP_PA_AUTHENTICATION_RESP:
+               return dpp_controller_rx_auth_resp(conn, msg, pos, end - pos);
+       case DPP_PA_AUTHENTICATION_CONF:
+               return dpp_controller_rx_auth_conf(conn, msg, pos, end - pos);
+       case DPP_PA_CONFIGURATION_RESULT:
+               return dpp_controller_rx_conf_result(conn, msg, pos, end - pos);
+       default:
+               /* TODO: missing messages types */
+               wpa_printf(MSG_DEBUG,
+                          "DPP: Unsupported frame subtype %d", type);
+               return -1;
+       }
+}
+
+
+static int dpp_controller_rx_gas_req(struct dpp_connection *conn, const u8 *msg,
+                                    size_t len)
+{
+       const u8 *pos, *end, *next;
+       u8 dialog_token;
+       const u8 *adv_proto;
+       u16 slen;
+       struct wpabuf *resp, *buf;
+       struct dpp_authentication *auth = conn->auth;
+
+       if (len < 1 + 2)
+               return -1;
+
+       wpa_printf(MSG_DEBUG,
+                  "DPP: Received DPP Configuration Request over TCP");
+
+       if (!conn->ctrl || !auth || !auth->auth_success) {
+               wpa_printf(MSG_DEBUG, "DPP: No matching exchange in progress");
+               return -1;
+       }
+
+       pos = msg;
+       end = msg + len;
+
+       dialog_token = *pos++;
+       adv_proto = pos++;
+       slen = *pos++;
+       if (*adv_proto != WLAN_EID_ADV_PROTO ||
+           slen > end - pos || slen < 2)
+               return -1;
+
+       next = pos + slen;
+       pos++; /* skip QueryRespLenLimit and PAME-BI */
+
+       if (slen != 8 || *pos != WLAN_EID_VENDOR_SPECIFIC ||
+           pos[1] != 5 || WPA_GET_BE24(&pos[2]) != OUI_WFA ||
+           pos[5] != DPP_OUI_TYPE || pos[6] != 0x01)
+               return -1;
+
+       pos = next;
+       /* Query Request */
+       if (end - pos < 2)
+               return -1;
+       slen = WPA_GET_LE16(pos);
+       pos += 2;
+       if (slen > end - pos)
+               return -1;
+
+       resp = dpp_conf_req_rx(auth, pos, slen);
+       if (!resp)
+               return -1;
+
+       buf = wpabuf_alloc(4 + 18 + wpabuf_len(resp));
+       if (!buf) {
+               wpabuf_free(resp);
+               return -1;
+       }
+
+       wpabuf_put_be32(buf, 18 + wpabuf_len(resp));
+
+       wpabuf_put_u8(buf, WLAN_PA_GAS_INITIAL_RESP);
+       wpabuf_put_u8(buf, dialog_token);
+       wpabuf_put_le16(buf, WLAN_STATUS_SUCCESS);
+       wpabuf_put_le16(buf, 0); /* GAS Comeback Delay */
+
+       dpp_write_adv_proto(buf);
+       dpp_write_gas_query(buf, resp);
+       wpabuf_free(resp);
+
+       /* Send Config Response over TCP; GAS fragmentation is taken care of by
+        * the Relay */
+       wpa_hexdump_buf(MSG_MSGDUMP, "DPP: Outgoing TCP message", buf);
+       wpabuf_free(conn->msg_out);
+       conn->msg_out_pos = 0;
+       conn->msg_out = buf;
+       conn->on_tcp_tx_complete_gas_done = 1;
+       dpp_tcp_send(conn);
+       return 0;
+}
+
+
+static int dpp_tcp_rx_gas_resp(struct dpp_connection *conn, struct wpabuf *resp)
+{
+       struct dpp_authentication *auth = conn->auth;
+       int res;
+       struct wpabuf *msg, *encaps;
+       enum dpp_status_error status;
+
+       wpa_printf(MSG_DEBUG,
+                  "DPP: Configuration Response for local stack from TCP");
+
+       res = dpp_conf_resp_rx(auth, resp);
+       wpabuf_free(resp);
+       if (res < 0) {
+               wpa_printf(MSG_DEBUG, "DPP: Configuration attempt failed");
+               return -1;
+       }
+
+       if (conn->global->process_conf_obj)
+               res = conn->global->process_conf_obj(conn->global->cb_ctx,
+                                                    auth);
+       else
+               res = 0;
+
+       if (auth->peer_version < 2 || auth->conf_resp_status != DPP_STATUS_OK)
+               return -1;
+
+       wpa_printf(MSG_DEBUG, "DPP: Send DPP Configuration Result");
+       status = res < 0 ? DPP_STATUS_CONFIG_REJECTED : DPP_STATUS_OK;
+       msg = dpp_build_conf_result(auth, status);
+       if (!msg)
+               return -1;
+
+       encaps = wpabuf_alloc(4 + wpabuf_len(msg) - 1);
+       if (!encaps) {
+               wpabuf_free(msg);
+               return -1;
+       }
+       wpabuf_put_be32(encaps, wpabuf_len(msg) - 1);
+       wpabuf_put_data(encaps, wpabuf_head(msg) + 1, wpabuf_len(msg) - 1);
+       wpabuf_free(msg);
+       wpa_hexdump_buf(MSG_MSGDUMP, "DPP: Outgoing TCP message", encaps);
+
+       wpabuf_free(conn->msg_out);
+       conn->msg_out_pos = 0;
+       conn->msg_out = encaps;
+       conn->on_tcp_tx_complete_remove = 1;
+       dpp_tcp_send(conn);
+
+       /* This exchange will be terminated in the TX status handler */
+
+       return 0;
+}
+
+
+static int dpp_rx_gas_resp(struct dpp_connection *conn, const u8 *msg,
+                          size_t len)
+{
+       struct wpabuf *buf;
+       u8 dialog_token;
+       const u8 *pos, *end, *next, *adv_proto;
+       u16 status, slen;
+
+       if (len < 5 + 2)
+               return -1;
+
+       wpa_printf(MSG_DEBUG,
+                  "DPP: Received DPP Configuration Response over TCP");
+
+       pos = msg;
+       end = msg + len;
+
+       dialog_token = *pos++;
+       status = WPA_GET_LE16(pos);
+       if (status != WLAN_STATUS_SUCCESS) {
+               wpa_printf(MSG_DEBUG, "DPP: Unexpected Status Code %u", status);
+               return -1;
+       }
+       pos += 2;
+       pos += 2; /* ignore GAS Comeback Delay */
+
+       adv_proto = pos++;
+       slen = *pos++;
+       if (*adv_proto != WLAN_EID_ADV_PROTO ||
+           slen > end - pos || slen < 2)
+               return -1;
+
+       next = pos + slen;
+       pos++; /* skip QueryRespLenLimit and PAME-BI */
+
+       if (slen != 8 || *pos != WLAN_EID_VENDOR_SPECIFIC ||
+           pos[1] != 5 || WPA_GET_BE24(&pos[2]) != OUI_WFA ||
+           pos[5] != DPP_OUI_TYPE || pos[6] != 0x01)
+               return -1;
+
+       pos = next;
+       /* Query Response */
+       if (end - pos < 2)
+               return -1;
+       slen = WPA_GET_LE16(pos);
+       pos += 2;
+       if (slen > end - pos)
+               return -1;
+
+       buf = wpabuf_alloc(slen);
+       if (!buf)
+               return -1;
+       wpabuf_put_data(buf, pos, slen);
+
+       if (!conn->relay && !conn->ctrl)
+               return dpp_tcp_rx_gas_resp(conn, buf);
+
+       if (!conn->relay) {
+               wpa_printf(MSG_DEBUG, "DPP: No matching exchange in progress");
+               wpabuf_free(buf);
+               return -1;
+       }
+       wpa_printf(MSG_DEBUG, "DPP: Relay - send over WLAN");
+       conn->relay->gas_resp_tx(conn->relay->cb_ctx, conn->mac_addr,
+                                dialog_token, 0, buf);
+
+       return 0;
+}
+
+
+static void dpp_controller_rx(int sd, void *eloop_ctx, void *sock_ctx)
+{
+       struct dpp_connection *conn = eloop_ctx;
+       int res;
+       const u8 *pos;
+
+       wpa_printf(MSG_DEBUG, "DPP: TCP data available for reading (sock %d)",
+                  sd);
+
+       if (conn->msg_len_octets < 4) {
+               u32 msglen;
+
+               res = recv(sd, &conn->msg_len[conn->msg_len_octets],
+                          4 - conn->msg_len_octets, 0);
+               if (res < 0) {
+                       wpa_printf(MSG_DEBUG, "DPP: recv failed: %s",
+                                  strerror(errno));
+                       dpp_connection_remove(conn);
+                       return;
+               }
+               if (res == 0) {
+                       wpa_printf(MSG_DEBUG,
+                                  "DPP: No more data available over TCP");
+                       dpp_connection_remove(conn);
+                       return;
+               }
+               wpa_printf(MSG_DEBUG,
+                          "DPP: Received %d/%d octet(s) of message length field",
+                          res, (int) (4 - conn->msg_len_octets));
+               conn->msg_len_octets += res;
+
+               if (conn->msg_len_octets < 4) {
+                       wpa_printf(MSG_DEBUG,
+                                  "DPP: Need %d more octets of message length field",
+                                  (int) (4 - conn->msg_len_octets));
+                       return;
+               }
+
+               msglen = WPA_GET_BE32(conn->msg_len);
+               wpa_printf(MSG_DEBUG, "DPP: Message length: %u", msglen);
+               if (msglen > 65535) {
+                       wpa_printf(MSG_INFO, "DPP: Unexpectedly long message");
+                       dpp_connection_remove(conn);
+                       return;
+               }
+
+               wpabuf_free(conn->msg);
+               conn->msg = wpabuf_alloc(msglen);
+       }
+
+       if (!conn->msg) {
+               wpa_printf(MSG_DEBUG,
+                          "DPP: No buffer available for receiving the message");
+               dpp_connection_remove(conn);
+               return;
+       }
+
+       wpa_printf(MSG_DEBUG, "DPP: Need %u more octets of message payload",
+                  (unsigned int) wpabuf_tailroom(conn->msg));
+
+       res = recv(sd, wpabuf_put(conn->msg, 0), wpabuf_tailroom(conn->msg), 0);
+       if (res < 0) {
+               wpa_printf(MSG_DEBUG, "DPP: recv failed: %s", strerror(errno));
+               dpp_connection_remove(conn);
+               return;
+       }
+       if (res == 0) {
+               wpa_printf(MSG_DEBUG, "DPP: No more data available over TCP");
+               dpp_connection_remove(conn);
+               return;
+       }
+       wpa_printf(MSG_DEBUG, "DPP: Received %d octets", res);
+       wpabuf_put(conn->msg, res);
+
+       if (wpabuf_tailroom(conn->msg) > 0) {
+               wpa_printf(MSG_DEBUG,
+                          "DPP: Need %u more octets of message payload",
+                          (unsigned int) wpabuf_tailroom(conn->msg));
+               return;
+       }
+
+       conn->msg_len_octets = 0;
+       wpa_hexdump_buf(MSG_DEBUG, "DPP: Received TCP message", conn->msg);
+       if (wpabuf_len(conn->msg) < 1) {
+               dpp_connection_remove(conn);
+               return;
+       }
+
+       pos = wpabuf_head(conn->msg);
+       switch (*pos) {
+       case WLAN_PA_VENDOR_SPECIFIC:
+               if (dpp_controller_rx_action(conn, pos + 1,
+                                            wpabuf_len(conn->msg) - 1) < 0)
+                       dpp_connection_remove(conn);
+               break;
+       case WLAN_PA_GAS_INITIAL_REQ:
+               if (dpp_controller_rx_gas_req(conn, pos + 1,
+                                             wpabuf_len(conn->msg) - 1) < 0)
+                       dpp_connection_remove(conn);
+               break;
+       case WLAN_PA_GAS_INITIAL_RESP:
+               if (dpp_rx_gas_resp(conn, pos + 1,
+                                   wpabuf_len(conn->msg) - 1) < 0)
+                       dpp_connection_remove(conn);
+               break;
+       default:
+               wpa_printf(MSG_DEBUG, "DPP: Ignore unsupported message type %u",
+                          *pos);
+               break;
+       }
+}
+
+
+static void dpp_controller_tcp_cb(int sd, void *eloop_ctx, void *sock_ctx)
+{
+       struct dpp_controller *ctrl = eloop_ctx;
+       struct sockaddr_in addr;
+       socklen_t addr_len = sizeof(addr);
+       int fd;
+       struct dpp_connection *conn;
+
+       wpa_printf(MSG_DEBUG, "DPP: New TCP connection");
+
+       fd = accept(ctrl->sock, (struct sockaddr *) &addr, &addr_len);
+       if (fd < 0) {
+               wpa_printf(MSG_DEBUG,
+                          "DPP: Failed to accept new connection: %s",
+                          strerror(errno));
+               return;
+       }
+       wpa_printf(MSG_DEBUG, "DPP: Connection from %s:%d",
+                  inet_ntoa(addr.sin_addr), ntohs(addr.sin_port));
+
+       conn = os_zalloc(sizeof(*conn));
+       if (!conn)
+               goto fail;
+
+       conn->global = ctrl->global;
+       conn->ctrl = ctrl;
+       conn->sock = fd;
+
+       if (fcntl(conn->sock, F_SETFL, O_NONBLOCK) != 0) {
+               wpa_printf(MSG_DEBUG, "DPP: fnctl(O_NONBLOCK) failed: %s",
+                          strerror(errno));
+               goto fail;
+       }
+
+       if (eloop_register_sock(conn->sock, EVENT_TYPE_READ,
+                               dpp_controller_rx, conn, NULL) < 0)
+               goto fail;
+       conn->read_eloop = 1;
+
+       /* TODO: eloop timeout to expire connections that do not complete in
+        * reasonable time */
+       dl_list_add(&ctrl->conn, &conn->list);
+       return;
+
+fail:
+       close(fd);
+       os_free(conn);
+}
+
+
+int dpp_tcp_init(struct dpp_global *dpp, struct dpp_authentication *auth,
+                const struct hostapd_ip_addr *addr, int port)
+{
+       struct dpp_connection *conn;
+       struct sockaddr_storage saddr;
+       socklen_t addrlen;
+       const u8 *hdr, *pos, *end;
+       char txt[100];
+
+       wpa_printf(MSG_DEBUG, "DPP: Initialize TCP connection to %s port %d",
+                  hostapd_ip_txt(addr, txt, sizeof(txt)), port);
+       if (dpp_ipaddr_to_sockaddr((struct sockaddr *) &saddr, &addrlen,
+                                  addr, port) < 0) {
+               dpp_auth_deinit(auth);
+               return -1;
+       }
+
+       conn = os_zalloc(sizeof(*conn));
+       if (!conn) {
+               dpp_auth_deinit(auth);
+               return -1;
+       }
+
+       conn->global = dpp;
+       conn->auth = auth;
+       conn->sock = socket(AF_INET, SOCK_STREAM, 0);
+       if (conn->sock < 0)
+               goto fail;
+
+       if (fcntl(conn->sock, F_SETFL, O_NONBLOCK) != 0) {
+               wpa_printf(MSG_DEBUG, "DPP: fnctl(O_NONBLOCK) failed: %s",
+                          strerror(errno));
+               goto fail;
+       }
+
+       if (connect(conn->sock, (struct sockaddr *) &saddr, addrlen) < 0) {
+               if (errno != EINPROGRESS) {
+                       wpa_printf(MSG_DEBUG, "DPP: Failed to connect: %s",
+                                  strerror(errno));
+                       goto fail;
+               }
+
+               /*
+                * Continue connecting in the background; eloop will call us
+                * once the connection is ready (or failed).
+                */
+       }
+
+       if (eloop_register_sock(conn->sock, EVENT_TYPE_WRITE,
+                               dpp_conn_tx_ready, conn, NULL) < 0)
+               goto fail;
+       conn->write_eloop = 1;
+
+       hdr = wpabuf_head(auth->req_msg);
+       end = hdr + wpabuf_len(auth->req_msg);
+       hdr += 2; /* skip Category and Actiom */
+       pos = hdr + DPP_HDR_LEN;
+       conn->msg_out = dpp_tcp_encaps(hdr, pos, end - pos);
+       if (!conn->msg_out)
+               goto fail;
+       /* Message will be sent in dpp_conn_tx_ready() */
+
+       /* TODO: eloop timeout to clear a connection if it does not complete
+        * properly */
+       dl_list_add(&dpp->tcp_init, &conn->list);
+       return 0;
+fail:
+       dpp_connection_free(conn);
+       return -1;
+}
+
+
+int dpp_controller_start(struct dpp_global *dpp,
+                        struct dpp_controller_config *config)
+{
+       struct dpp_controller *ctrl;
+       int on = 1;
+       struct sockaddr_in sin;
+       int port;
+
+       if (!dpp || dpp->controller)
+               return -1;
+
+       ctrl = os_zalloc(sizeof(*ctrl));
+       if (!ctrl)
+               return -1;
+       ctrl->global = dpp;
+       if (config->configurator_params)
+               ctrl->configurator_params =
+                       os_strdup(config->configurator_params);
+       dl_list_init(&ctrl->conn);
+       /* TODO: configure these somehow */
+       ctrl->allowed_roles = DPP_CAPAB_ENROLLEE | DPP_CAPAB_CONFIGURATOR;
+       ctrl->qr_mutual = 0;
+
+       ctrl->sock = socket(AF_INET, SOCK_STREAM, 0);
+       if (ctrl->sock < 0)
+               goto fail;
+
+       if (setsockopt(ctrl->sock, SOL_SOCKET, SO_REUSEADDR,
+                      &on, sizeof(on)) < 0) {
+               wpa_printf(MSG_DEBUG,
+                          "DPP: setsockopt(SO_REUSEADDR) failed: %s",
+                          strerror(errno));
+               /* try to continue anyway */
+       }
+
+       if (fcntl(ctrl->sock, F_SETFL, O_NONBLOCK) < 0) {
+               wpa_printf(MSG_INFO, "DPP: fnctl(O_NONBLOCK) failed: %s",
+                          strerror(errno));
+               goto fail;
+       }
+
+       /* TODO: IPv6 */
+       os_memset(&sin, 0, sizeof(sin));
+       sin.sin_family = AF_INET;
+       sin.sin_addr.s_addr = INADDR_ANY;
+       port = config->tcp_port ? config->tcp_port : DPP_TCP_PORT;
+       sin.sin_port = htons(port);
+       if (bind(ctrl->sock, (struct sockaddr *) &sin, sizeof(sin)) < 0) {
+               wpa_printf(MSG_INFO,
+                          "DPP: Failed to bind Controller TCP port: %s",
+                          strerror(errno));
+               goto fail;
+       }
+       if (listen(ctrl->sock, 10 /* max backlog */) < 0 ||
+           fcntl(ctrl->sock, F_SETFL, O_NONBLOCK) < 0 ||
+           eloop_register_sock(ctrl->sock, EVENT_TYPE_READ,
+                               dpp_controller_tcp_cb, ctrl, NULL))
+               goto fail;
+
+       dpp->controller = ctrl;
+       wpa_printf(MSG_DEBUG, "DPP: Controller started on TCP port %d", port);
+       return 0;
+fail:
+       dpp_controller_free(ctrl);
+       return -1;
+}
+
+
+void dpp_controller_stop(struct dpp_global *dpp)
+{
+       if (dpp) {
+               dpp_controller_free(dpp->controller);
+               dpp->controller = NULL;
+       }
+}
+
+#endif /* CONFIG_DPP2 */