-/*-*- Mode: C; c-basic-offset: 8; indent-tabs-mode: nil -*-*/
-
+/* SPDX-License-Identifier: LGPL-2.1+ */
/***
This file is part of systemd.
along with systemd; If not, see <http://www.gnu.org/licenses/>.
***/
-#include <dirent.h>
-#include <errno.h>
-#include "unit.h"
+#include "conf-parser.h"
+#include "fs-util.h"
#include "load-dropin.h"
+#include "load-fragment.h"
#include "log.h"
+#include "stat-util.h"
+#include "string-util.h"
#include "strv.h"
#include "unit-name.h"
-#include "conf-parser.h"
-#include "load-fragment.h"
-#include "conf-files.h"
-
-static int iterate_dir(
- Unit *u,
- const char *path,
- UnitDependency dependency,
- char ***strv) {
+#include "unit.h"
- _cleanup_closedir_ DIR *d = NULL;
+static int unit_name_compatible(const char *a, const char *b) {
+ _cleanup_free_ char *prefix = NULL;
int r;
- assert(u);
- assert(path);
-
- /* The config directories are special, since the order of the
- * drop-ins matters */
- if (dependency < 0) {
- r = strv_extend(strv, path);
- if (r < 0)
- return log_oom();
+ /* the straightforward case: the symlink name matches the target */
+ if (streq(a, b))
+ return 1;
+ r = unit_name_template(a, &prefix);
+ if (r == -EINVAL)
+ /* not a template */
return 0;
- }
-
- d = opendir(path);
- if (!d) {
- if (errno == ENOENT)
- return 0;
-
- log_error("Failed to open directory %s: %m", path);
- return -errno;
- }
+ if (r < 0)
+ /* oom, or some other failure. Just skip the warning. */
+ return r;
- for (;;) {
- struct dirent *de;
- _cleanup_free_ char *f = NULL;
- int k;
-
- errno = 0;
- de = readdir(d);
- if (!de && errno != 0) {
- k = errno;
- log_error("Failed to read directory %s: %s", path, strerror(k));
- return -k;
- }
-
- if (!de)
- break;
-
- if (ignore_file(de->d_name))
- continue;
-
- f = strjoin(path, "/", de->d_name, NULL);
- if (!f)
- return log_oom();
-
- r = unit_add_dependency_by_name(u, dependency, de->d_name, f, true);
- if (r < 0)
- log_error("Cannot add dependency %s to %s, ignoring: %s", de->d_name, u->id, strerror(-r));
- }
+ /* an instance name points to a target that is just the template name */
+ if (streq(prefix, b))
+ return 1;
return 0;
}
-static int process_dir(
- Unit *u,
- const char *unit_path,
- const char *name,
- const char *suffix,
- UnitDependency dependency,
- char ***strv) {
-
- _cleanup_free_ char *path = NULL;
-
- assert(u);
- assert(unit_path);
- assert(name);
- assert(suffix);
+static int process_deps(Unit *u, UnitDependency dependency, const char *dir_suffix) {
+ _cleanup_strv_free_ char **paths = NULL;
+ char **p;
+ int r;
- path = strjoin(unit_path, "/", name, suffix, NULL);
- if (!path)
- return log_oom();
+ r = unit_file_find_dropin_paths(NULL,
+ u->manager->lookup_paths.search_path,
+ u->manager->unit_path_cache,
+ dir_suffix,
+ NULL,
+ u->names,
+ &paths);
+ if (r < 0)
+ return r;
+
+ STRV_FOREACH(p, paths) {
+ const char *entry;
+ _cleanup_free_ char *target = NULL;
+
+ entry = basename(*p);
+
+ if (null_or_empty_path(*p) > 0) {
+ /* an error usually means an invalid symlink, which is not a mask */
+ log_unit_debug(u, "%s dependency on %s is masked by %s, ignoring.",
+ unit_dependency_to_string(dependency), entry, *p);
+ continue;
+ }
- if (!u->manager->unit_path_cache || set_get(u->manager->unit_path_cache, path))
- iterate_dir(u, path, dependency, strv);
+ r = is_symlink(*p);
+ if (r < 0) {
+ log_unit_warning_errno(u, r, "%s dropin %s unreadable, ignoring: %m",
+ unit_dependency_to_string(dependency), *p);
+ continue;
+ }
+ if (r == 0) {
+ log_unit_warning(u, "%s dependency dropin %s is not a symlink, ignoring.",
+ unit_dependency_to_string(dependency), *p);
+ continue;
+ }
- if (u->instance) {
- _cleanup_free_ char *template = NULL, *p = NULL;
- /* Also try the template dir */
+ if (!unit_name_is_valid(entry, UNIT_NAME_ANY)) {
+ log_unit_warning(u, "%s dependency dropin %s is not a valid unit name, ignoring.",
+ unit_dependency_to_string(dependency), *p);
+ continue;
+ }
- template = unit_name_template(name);
- if (!template)
- return log_oom();
+ r = readlink_malloc(*p, &target);
+ if (r < 0) {
+ log_unit_warning_errno(u, r, "readlink(\"%s\") failed, ignoring: %m", *p);
+ continue;
+ }
- p = strjoin(unit_path, "/", template, suffix, NULL);
- if (!p)
- return log_oom();
+ /* We don't treat this as an error, especially because we didn't check this for a
+ * long time. Nevertheless, we warn, because such mismatch can be mighty confusing. */
+ r = unit_name_compatible(entry, basename(target));
+ if (r < 0) {
+ log_unit_warning_errno(u, r, "Can't check if names %s and %s are compatible, ignoring: %m", entry, basename(target));
+ continue;
+ }
+ if (r == 0)
+ log_unit_warning(u, "%s dependency dropin %s target %s has different name",
+ unit_dependency_to_string(dependency), *p, target);
- if (!u->manager->unit_path_cache || set_get(u->manager->unit_path_cache, p))
- iterate_dir(u, p, dependency, strv);
+ r = unit_add_dependency_by_name(u, dependency, entry, *p, true, UNIT_DEPENDENCY_FILE);
+ if (r < 0)
+ log_unit_warning_errno(u, r, "Cannot add %s dependency on %s, ignoring: %m",
+ unit_dependency_to_string(dependency), entry);
}
return 0;
}
-char **unit_find_dropin_paths(Unit *u) {
- _cleanup_strv_free_ char **strv = NULL;
- char **configs = NULL;
- Iterator i;
- char *t;
- int r;
-
- assert(u);
-
- SET_FOREACH(t, u->names, i) {
- char **p;
-
- STRV_FOREACH(p, u->manager->lookup_paths.unit_path)
- process_dir(u, *p, t, ".d", _UNIT_DEPENDENCY_INVALID, &strv);
- }
-
- if (strv_isempty(strv))
- return NULL;
-
- r = conf_files_list_strv(&configs, ".conf", NULL, (const char**) strv);
- if (r < 0) {
- log_error("Failed to get list of configuration files: %s", strerror(-r));
- strv_free(configs);
- return NULL;
- }
-
- return configs;
-}
-
int unit_load_dropin(Unit *u) {
- Iterator i;
- char *t, **f;
+ _cleanup_strv_free_ char **l = NULL;
+ char **f;
+ int r;
assert(u);
- /* Load dependencies from supplementary drop-in directories */
-
- SET_FOREACH(t, u->names, i) {
- char **p;
+ /* Load dependencies from .wants and .requires directories */
+ r = process_deps(u, UNIT_WANTS, ".wants");
+ if (r < 0)
+ return r;
- STRV_FOREACH(p, u->manager->lookup_paths.unit_path) {
- process_dir(u, *p, t, ".wants", UNIT_WANTS, NULL);
- process_dir(u, *p, t, ".requires", UNIT_REQUIRES, NULL);
- }
- }
+ r = process_deps(u, UNIT_REQUIRES, ".requires");
+ if (r < 0)
+ return r;
- u->dropin_paths = unit_find_dropin_paths(u);
- if (! u->dropin_paths)
+ /* Load .conf dropins */
+ r = unit_find_dropin_paths(u, &l);
+ if (r <= 0)
return 0;
- STRV_FOREACH(f, u->dropin_paths) {
- config_parse(u->id, *f, NULL,
- UNIT_VTABLE(u)->sections,
- config_item_perf_lookup, load_fragment_gperf_lookup,
- false, false, false, u);
+ if (!u->dropin_paths) {
+ u->dropin_paths = l;
+ l = NULL;
+ } else {
+ r = strv_extend_strv(&u->dropin_paths, l, true);
+ if (r < 0)
+ return log_oom();
}
+ STRV_FOREACH(f, u->dropin_paths)
+ (void) config_parse(u->id, *f, NULL,
+ UNIT_VTABLE(u)->sections,
+ config_item_perf_lookup, load_fragment_gperf_lookup,
+ 0, u);
+
u->dropin_mtime = now(CLOCK_REALTIME);
return 0;
projects / thirdparty / systemd.git / blobdiff