/*
- * Copyright (C) 1996-2015 The Squid Software Foundation and contributors
+ * Copyright (C) 1996-2021 The Squid Software Foundation and contributors
*
* Squid software is distributed under GPLv2+ license and includes
* contributions from numerous individuals and organizations.
else if (payload && len == 0)
len = strlen(payload);
- /** \li
- \bug If length specified or auto-detected is greater than the possible payload squid will die with an assert.
- \todo This should perhapse be reduced to a truncated payload? or no payload. A WARNING is due anyway.
- */
+ // XXX: If length specified or auto-detected is greater than the possible payload squid will die with an assert.
+ // TODO: This should perhapse be reduced to a truncated payload? or no payload. A WARNING is due anyway.
assert(len <= PINGER_PAYLOAD_SZ);
pecho.to = to;
x = comm_udp_send(icmp_sock, (char *)&pecho, slen, 0);
if (x < 0) {
- debugs(37, DBG_IMPORTANT, HERE << "send: " << xstrerror());
+ int xerrno = errno;
+ debugs(37, DBG_IMPORTANT, MYNAME << "send: " << xstrerr(xerrno));
/** \li If the send results in ECONNREFUSED or EPIPE errors from helper, will cleanly shutdown the module. */
- /** \todo This should try restarting the helper a few times?? before giving up? */
- if (errno == ECONNREFUSED || errno == EPIPE) {
+ // TODO: try restarting the helper a few times before giving up?
+ if (xerrno == ECONNREFUSED || xerrno == EPIPE) {
Close();
return;
}
static Ip::Address F;
Comm::SetSelect(icmp_sock, COMM_SELECT_READ, icmpSquidRecv, NULL, 0);
- memset(&preply, '\0', sizeof(pingerReplyData));
n = comm_udp_recv(icmp_sock,
(char *) &preply,
sizeof(pingerReplyData),
0);
if (n < 0 && EAGAIN != errno) {
- debugs(37, DBG_IMPORTANT, HERE << "recv: " << xstrerror());
+ int xerrno = errno;
+ debugs(37, DBG_IMPORTANT, MYNAME << "recv: " << xstrerr(xerrno));
- if (errno == ECONNREFUSED)
+ if (xerrno == ECONNREFUSED)
Close();
- if (errno == ECONNRESET)
+ if (xerrno == ECONNRESET)
Close();
if (++fail_count == 10)