]> git.ipfire.org Git - thirdparty/hostap.git/blobdiff - wpa_supplicant/dpp_supplicant.c
DPP: Indicate authentication success on ConfReqRX if needed
[thirdparty/hostap.git] / wpa_supplicant / dpp_supplicant.c
index 18404310acbd37695c6d4963cbd86989f4af28df..1f65658eff76bf971b35fa8456b03fc59d61fdff 100644 (file)
@@ -1,6 +1,7 @@
 /*
  * wpa_supplicant - DPP
  * Copyright (c) 2017, Qualcomm Atheros, Inc.
+ * Copyright (c) 2018-2019, The Linux Foundation
  *
  * This software may be distributed under the terms of the BSD license.
  * See README for more details.
@@ -10,6 +11,7 @@
 
 #include "utils/common.h"
 #include "utils/eloop.h"
+#include "utils/ip_addr.h"
 #include "common/dpp.h"
 #include "common/gas.h"
 #include "common/gas_server.h"
@@ -51,34 +53,6 @@ static const u8 broadcast[ETH_ALEN] = { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff };
 static const u8 TRANSACTION_ID = 1;
 
 
-static struct dpp_configurator *
-dpp_configurator_get_id(struct wpa_supplicant *wpa_s, unsigned int id)
-{
-       struct dpp_configurator *conf;
-
-       dl_list_for_each(conf, &wpa_s->dpp_configurator,
-                        struct dpp_configurator, list) {
-               if (conf->id == id)
-                       return conf;
-       }
-       return NULL;
-}
-
-
-static unsigned int wpas_dpp_next_id(struct wpa_supplicant *wpa_s)
-{
-       struct dpp_bootstrap_info *bi;
-       unsigned int max_id = 0;
-
-       dl_list_for_each(bi, &wpa_s->dpp_bootstrap, struct dpp_bootstrap_info,
-                        list) {
-               if (bi->id > max_id)
-                       max_id = bi->id;
-       }
-       return max_id + 1;
-}
-
-
 /**
  * wpas_dpp_qr_code - Parse and add DPP bootstrapping info from a QR Code
  * @wpa_s: Pointer to wpa_supplicant data
@@ -90,13 +64,10 @@ int wpas_dpp_qr_code(struct wpa_supplicant *wpa_s, const char *cmd)
        struct dpp_bootstrap_info *bi;
        struct dpp_authentication *auth = wpa_s->dpp_auth;
 
-       bi = dpp_parse_qr_code(cmd);
+       bi = dpp_add_qr_code(wpa_s->dpp, cmd);
        if (!bi)
                return -1;
 
-       bi->id = wpas_dpp_next_id(wpa_s);
-       dl_list_add(&wpa_s->dpp_bootstrap, &bi->list);
-
        if (auth && auth->response_pending &&
            dpp_notify_new_qr_code(auth, bi) == 1) {
                wpa_printf(MSG_DEBUG,
@@ -117,195 +88,6 @@ int wpas_dpp_qr_code(struct wpa_supplicant *wpa_s, const char *cmd)
 }
 
 
-static char * get_param(const char *cmd, const char *param)
-{
-       const char *pos, *end;
-       char *val;
-       size_t len;
-
-       pos = os_strstr(cmd, param);
-       if (!pos)
-               return NULL;
-
-       pos += os_strlen(param);
-       end = os_strchr(pos, ' ');
-       if (end)
-               len = end - pos;
-       else
-               len = os_strlen(pos);
-       val = os_malloc(len + 1);
-       if (!val)
-               return NULL;
-       os_memcpy(val, pos, len);
-       val[len] = '\0';
-       return val;
-}
-
-
-int wpas_dpp_bootstrap_gen(struct wpa_supplicant *wpa_s, const char *cmd)
-{
-       char *chan = NULL, *mac = NULL, *info = NULL, *pk = NULL, *curve = NULL;
-       char *key = NULL;
-       u8 *privkey = NULL;
-       size_t privkey_len = 0;
-       size_t len;
-       int ret = -1;
-       struct dpp_bootstrap_info *bi;
-
-       bi = os_zalloc(sizeof(*bi));
-       if (!bi)
-               goto fail;
-
-       if (os_strstr(cmd, "type=qrcode"))
-               bi->type = DPP_BOOTSTRAP_QR_CODE;
-       else if (os_strstr(cmd, "type=pkex"))
-               bi->type = DPP_BOOTSTRAP_PKEX;
-       else
-               goto fail;
-
-       chan = get_param(cmd, " chan=");
-       mac = get_param(cmd, " mac=");
-       info = get_param(cmd, " info=");
-       curve = get_param(cmd, " curve=");
-       key = get_param(cmd, " key=");
-
-       if (key) {
-               privkey_len = os_strlen(key) / 2;
-               privkey = os_malloc(privkey_len);
-               if (!privkey ||
-                   hexstr2bin(key, privkey, privkey_len) < 0)
-                       goto fail;
-       }
-
-       pk = dpp_keygen(bi, curve, privkey, privkey_len);
-       if (!pk)
-               goto fail;
-
-       len = 4; /* "DPP:" */
-       if (chan) {
-               if (dpp_parse_uri_chan_list(bi, chan) < 0)
-                       goto fail;
-               len += 3 + os_strlen(chan); /* C:...; */
-       }
-       if (mac) {
-               if (dpp_parse_uri_mac(bi, mac) < 0)
-                       goto fail;
-               len += 3 + os_strlen(mac); /* M:...; */
-       }
-       if (info) {
-               if (dpp_parse_uri_info(bi, info) < 0)
-                       goto fail;
-               len += 3 + os_strlen(info); /* I:...; */
-       }
-       len += 4 + os_strlen(pk);
-       bi->uri = os_malloc(len + 1);
-       if (!bi->uri)
-               goto fail;
-       os_snprintf(bi->uri, len + 1, "DPP:%s%s%s%s%s%s%s%s%sK:%s;;",
-                   chan ? "C:" : "", chan ? chan : "", chan ? ";" : "",
-                   mac ? "M:" : "", mac ? mac : "", mac ? ";" : "",
-                   info ? "I:" : "", info ? info : "", info ? ";" : "",
-                   pk);
-       bi->id = wpas_dpp_next_id(wpa_s);
-       dl_list_add(&wpa_s->dpp_bootstrap, &bi->list);
-       ret = bi->id;
-       bi = NULL;
-fail:
-       os_free(curve);
-       os_free(pk);
-       os_free(chan);
-       os_free(mac);
-       os_free(info);
-       str_clear_free(key);
-       bin_clear_free(privkey, privkey_len);
-       dpp_bootstrap_info_free(bi);
-       return ret;
-}
-
-
-static struct dpp_bootstrap_info *
-dpp_bootstrap_get_id(struct wpa_supplicant *wpa_s, unsigned int id)
-{
-       struct dpp_bootstrap_info *bi;
-
-       dl_list_for_each(bi, &wpa_s->dpp_bootstrap, struct dpp_bootstrap_info,
-                        list) {
-               if (bi->id == id)
-                       return bi;
-       }
-       return NULL;
-}
-
-
-static int dpp_bootstrap_del(struct wpa_supplicant *wpa_s, unsigned int id)
-{
-       struct dpp_bootstrap_info *bi, *tmp;
-       int found = 0;
-
-       dl_list_for_each_safe(bi, tmp, &wpa_s->dpp_bootstrap,
-                             struct dpp_bootstrap_info, list) {
-               if (id && bi->id != id)
-                       continue;
-               found = 1;
-               dl_list_del(&bi->list);
-               dpp_bootstrap_info_free(bi);
-       }
-
-       if (id == 0)
-               return 0; /* flush succeeds regardless of entries found */
-       return found ? 0 : -1;
-}
-
-
-int wpas_dpp_bootstrap_remove(struct wpa_supplicant *wpa_s, const char *id)
-{
-       unsigned int id_val;
-
-       if (os_strcmp(id, "*") == 0) {
-               id_val = 0;
-       } else {
-               id_val = atoi(id);
-               if (id_val == 0)
-                       return -1;
-       }
-
-       return dpp_bootstrap_del(wpa_s, id_val);
-}
-
-
-const char * wpas_dpp_bootstrap_get_uri(struct wpa_supplicant *wpa_s,
-                                       unsigned int id)
-{
-       struct dpp_bootstrap_info *bi;
-
-       bi = dpp_bootstrap_get_id(wpa_s, id);
-       if (!bi)
-               return NULL;
-       return bi->uri;
-}
-
-
-int wpas_dpp_bootstrap_info(struct wpa_supplicant *wpa_s, int id,
-                           char *reply, int reply_size)
-{
-       struct dpp_bootstrap_info *bi;
-
-       bi = dpp_bootstrap_get_id(wpa_s, id);
-       if (!bi)
-               return -1;
-       return os_snprintf(reply, reply_size, "type=%s\n"
-                          "mac_addr=" MACSTR "\n"
-                          "info=%s\n"
-                          "num_freq=%u\n"
-                          "curve=%s\n",
-                          dpp_bootstrap_type_txt(bi->type),
-                          MAC2STR(bi->mac_addr),
-                          bi->info ? bi->info : "",
-                          bi->num_freq,
-                          bi->curve->name);
-}
-
-
 static void wpas_dpp_auth_resp_retry_timeout(void *eloop_ctx, void *timeout_ctx)
 {
        struct wpa_supplicant *wpa_s = eloop_ctx;
@@ -363,6 +145,18 @@ static void wpas_dpp_auth_resp_retry(struct wpa_supplicant *wpa_s)
 }
 
 
+static void wpas_dpp_try_to_connect(struct wpa_supplicant *wpa_s)
+{
+       wpa_printf(MSG_DEBUG, "DPP: Trying to connect to the new network");
+       wpa_s->disconnected = 0;
+       wpa_s->reassociate = 1;
+       wpa_s->scan_runs = 0;
+       wpa_s->normal_scans = 0;
+       wpa_supplicant_cancel_sched_scan(wpa_s);
+       wpa_supplicant_req_scan(wpa_s, 0, 0);
+}
+
+
 static void wpas_dpp_tx_status(struct wpa_supplicant *wpa_s,
                               unsigned int freq, const u8 *dst,
                               const u8 *src, const u8 *bssid,
@@ -386,6 +180,17 @@ static void wpas_dpp_tx_status(struct wpa_supplicant *wpa_s,
                return;
        }
 
+#ifdef CONFIG_DPP2
+       if (auth->connect_on_tx_status) {
+               wpa_printf(MSG_DEBUG,
+                          "DPP: Try to connect after completed configuration result");
+               wpas_dpp_try_to_connect(wpa_s);
+               dpp_auth_deinit(wpa_s->dpp_auth);
+               wpa_s->dpp_auth = NULL;
+               return;
+       }
+#endif /* CONFIG_DPP2 */
+
        if (wpa_s->dpp_auth->remove_on_tx_status) {
                wpa_printf(MSG_DEBUG,
                           "DPP: Terminate authentication exchange due to an earlier error");
@@ -526,148 +331,6 @@ static void wpas_dpp_set_testing_options(struct wpa_supplicant *wpa_s,
 }
 
 
-static void wpas_dpp_set_configurator(struct wpa_supplicant *wpa_s,
-                                     struct dpp_authentication *auth,
-                                     const char *cmd)
-{
-       const char *pos, *end;
-       struct dpp_configuration *conf_sta = NULL, *conf_ap = NULL;
-       struct dpp_configurator *conf = NULL;
-       u8 ssid[32] = { "test" };
-       size_t ssid_len = 4;
-       char pass[64] = { };
-       size_t pass_len = 0;
-       u8 psk[PMK_LEN];
-       int psk_set = 0;
-
-       if (!cmd)
-               return;
-
-       wpa_printf(MSG_DEBUG, "DPP: Set configurator parameters: %s", cmd);
-       pos = os_strstr(cmd, " ssid=");
-       if (pos) {
-               pos += 6;
-               end = os_strchr(pos, ' ');
-               ssid_len = end ? (size_t) (end - pos) : os_strlen(pos);
-               ssid_len /= 2;
-               if (ssid_len > sizeof(ssid) ||
-                   hexstr2bin(pos, ssid, ssid_len) < 0)
-                       goto fail;
-       }
-
-       pos = os_strstr(cmd, " pass=");
-       if (pos) {
-               pos += 6;
-               end = os_strchr(pos, ' ');
-               pass_len = end ? (size_t) (end - pos) : os_strlen(pos);
-               pass_len /= 2;
-               if (pass_len > sizeof(pass) - 1 || pass_len < 8 ||
-                   hexstr2bin(pos, (u8 *) pass, pass_len) < 0)
-                       goto fail;
-       }
-
-       pos = os_strstr(cmd, " psk=");
-       if (pos) {
-               pos += 5;
-               if (hexstr2bin(pos, psk, PMK_LEN) < 0)
-                       goto fail;
-               psk_set = 1;
-       }
-
-       if (os_strstr(cmd, " conf=sta-")) {
-               conf_sta = os_zalloc(sizeof(struct dpp_configuration));
-               if (!conf_sta)
-                       goto fail;
-               os_memcpy(conf_sta->ssid, ssid, ssid_len);
-               conf_sta->ssid_len = ssid_len;
-               if (os_strstr(cmd, " conf=sta-psk") ||
-                   os_strstr(cmd, " conf=sta-sae") ||
-                   os_strstr(cmd, " conf=sta-psk-sae")) {
-                       if (os_strstr(cmd, " conf=sta-psk-sae"))
-                               conf_sta->akm = DPP_AKM_PSK_SAE;
-                       else if (os_strstr(cmd, " conf=sta-sae"))
-                               conf_sta->akm = DPP_AKM_SAE;
-                       else
-                               conf_sta->akm = DPP_AKM_PSK;
-                       if (psk_set) {
-                               os_memcpy(conf_sta->psk, psk, PMK_LEN);
-                       } else {
-                               conf_sta->passphrase = os_strdup(pass);
-                               if (!conf_sta->passphrase)
-                                       goto fail;
-                       }
-               } else if (os_strstr(cmd, " conf=sta-dpp")) {
-                       conf_sta->akm = DPP_AKM_DPP;
-               } else {
-                       goto fail;
-               }
-       }
-
-       if (os_strstr(cmd, " conf=ap-")) {
-               conf_ap = os_zalloc(sizeof(struct dpp_configuration));
-               if (!conf_ap)
-                       goto fail;
-               os_memcpy(conf_ap->ssid, ssid, ssid_len);
-               conf_ap->ssid_len = ssid_len;
-               if (os_strstr(cmd, " conf=ap-psk") ||
-                   os_strstr(cmd, " conf=ap-sae") ||
-                   os_strstr(cmd, " conf=ap-psk-sae")) {
-                       if (os_strstr(cmd, " conf=ap-psk-sae"))
-                               conf_ap->akm = DPP_AKM_PSK_SAE;
-                       else if (os_strstr(cmd, " conf=ap-sae"))
-                               conf_ap->akm = DPP_AKM_SAE;
-                       else
-                               conf_ap->akm = DPP_AKM_PSK;
-                       if (psk_set) {
-                               os_memcpy(conf_ap->psk, psk, PMK_LEN);
-                       } else {
-                               conf_ap->passphrase = os_strdup(pass);
-                               if (!conf_ap->passphrase)
-                                       goto fail;
-                       }
-               } else if (os_strstr(cmd, " conf=ap-dpp")) {
-                       conf_ap->akm = DPP_AKM_DPP;
-               } else {
-                       goto fail;
-               }
-       }
-
-       pos = os_strstr(cmd, " expiry=");
-       if (pos) {
-               long int val;
-
-               pos += 8;
-               val = strtol(pos, NULL, 0);
-               if (val <= 0)
-                       goto fail;
-               if (conf_sta)
-                       conf_sta->netaccesskey_expiry = val;
-               if (conf_ap)
-                       conf_ap->netaccesskey_expiry = val;
-       }
-
-       pos = os_strstr(cmd, " configurator=");
-       if (pos) {
-               pos += 14;
-               conf = dpp_configurator_get_id(wpa_s, atoi(pos));
-               if (!conf) {
-                       wpa_printf(MSG_INFO,
-                                  "DPP: Could not find the specified configurator");
-                       goto fail;
-               }
-       }
-       auth->conf_sta = conf_sta;
-       auth->conf_ap = conf_ap;
-       auth->conf = conf;
-       return;
-
-fail:
-       wpa_printf(MSG_DEBUG, "DPP: Failed to set configurator parameters");
-       dpp_configuration_free(conf_sta);
-       dpp_configuration_free(conf_ap);
-}
-
-
 static void wpas_dpp_init_timeout(void *eloop_ctx, void *timeout_ctx)
 {
        struct wpa_supplicant *wpa_s = eloop_ctx;
@@ -771,8 +434,15 @@ int wpas_dpp_auth_init(struct wpa_supplicant *wpa_s, const char *cmd)
 {
        const char *pos;
        struct dpp_bootstrap_info *peer_bi, *own_bi = NULL;
+       struct dpp_authentication *auth;
        u8 allowed_roles = DPP_CAPAB_CONFIGURATOR;
        unsigned int neg_freq = 0;
+       int tcp = 0;
+#ifdef CONFIG_DPP2
+       int tcp_port = DPP_TCP_PORT;
+       struct hostapd_ip_addr ipaddr;
+       char *addr;
+#endif /* CONFIG_DPP2 */
 
        wpa_s->dpp_gas_client = 0;
 
@@ -780,17 +450,36 @@ int wpas_dpp_auth_init(struct wpa_supplicant *wpa_s, const char *cmd)
        if (!pos)
                return -1;
        pos += 6;
-       peer_bi = dpp_bootstrap_get_id(wpa_s, atoi(pos));
+       peer_bi = dpp_bootstrap_get_id(wpa_s->dpp, atoi(pos));
        if (!peer_bi) {
                wpa_printf(MSG_INFO,
                           "DPP: Could not find bootstrapping info for the identified peer");
                return -1;
        }
 
+#ifdef CONFIG_DPP2
+       pos = os_strstr(cmd, " tcp_port=");
+       if (pos) {
+               pos += 10;
+               tcp_port = atoi(pos);
+       }
+
+       addr = get_param(cmd, " tcp_addr=");
+       if (addr) {
+               int res;
+
+               res = hostapd_parse_ip_addr(addr, &ipaddr);
+               os_free(addr);
+               if (res)
+                       return -1;
+               tcp = 1;
+       }
+#endif /* CONFIG_DPP2 */
+
        pos = os_strstr(cmd, " own=");
        if (pos) {
                pos += 5;
-               own_bi = dpp_bootstrap_get_id(wpa_s, atoi(pos));
+               own_bi = dpp_bootstrap_get_id(wpa_s->dpp, atoi(pos));
                if (!own_bi) {
                        wpa_printf(MSG_INFO,
                                   "DPP: Could not find bootstrapping info for the identified local entry");
@@ -829,28 +518,37 @@ int wpas_dpp_auth_init(struct wpa_supplicant *wpa_s, const char *cmd)
        if (pos)
                neg_freq = atoi(pos + 10);
 
-       if (wpa_s->dpp_auth) {
+       if (!tcp && wpa_s->dpp_auth) {
                eloop_cancel_timeout(wpas_dpp_init_timeout, wpa_s, NULL);
                eloop_cancel_timeout(wpas_dpp_reply_wait_timeout, wpa_s, NULL);
                eloop_cancel_timeout(wpas_dpp_auth_resp_retry_timeout, wpa_s,
                                     NULL);
                offchannel_send_action_done(wpa_s);
                dpp_auth_deinit(wpa_s->dpp_auth);
+               wpa_s->dpp_auth = NULL;
        }
-       wpa_s->dpp_auth = dpp_auth_init(wpa_s, peer_bi, own_bi, allowed_roles,
-                                       neg_freq,
-                                       wpa_s->hw.modes, wpa_s->hw.num_modes);
-       if (!wpa_s->dpp_auth)
+
+       auth = dpp_auth_init(wpa_s, peer_bi, own_bi, allowed_roles, neg_freq,
+                            wpa_s->hw.modes, wpa_s->hw.num_modes);
+       if (!auth)
                goto fail;
-       wpas_dpp_set_testing_options(wpa_s, wpa_s->dpp_auth);
-       wpas_dpp_set_configurator(wpa_s, wpa_s->dpp_auth, cmd);
+       wpas_dpp_set_testing_options(wpa_s, auth);
+       if (dpp_set_configurator(wpa_s->dpp, wpa_s, auth, cmd) < 0) {
+               dpp_auth_deinit(auth);
+               goto fail;
+       }
 
-       wpa_s->dpp_auth->neg_freq = neg_freq;
+       auth->neg_freq = neg_freq;
 
        if (!is_zero_ether_addr(peer_bi->mac_addr))
-               os_memcpy(wpa_s->dpp_auth->peer_mac_addr, peer_bi->mac_addr,
-                         ETH_ALEN);
+               os_memcpy(auth->peer_mac_addr, peer_bi->mac_addr, ETH_ALEN);
+
+#ifdef CONFIG_DPP2
+       if (tcp)
+               return dpp_tcp_init(wpa_s->dpp, auth, &ipaddr, tcp_port);
+#endif /* CONFIG_DPP2 */
 
+       wpa_s->dpp_auth = auth;
        return wpas_dpp_auth_init_next(wpa_s);
 fail:
        return -1;
@@ -909,6 +607,7 @@ static void dpp_start_listen_cb(struct wpa_radio_work *work, int deinit)
                wpa_printf(MSG_DEBUG,
                           "DPP: Failed to request the driver to remain on channel (%u MHz) for listen",
                           lwork->freq);
+               wpa_s->dpp_listen_freq = 0;
                wpas_dpp_listen_work_done(wpa_s);
                wpa_s->dpp_pending_listen_freq = 0;
                return;
@@ -989,29 +688,6 @@ void wpas_dpp_listen_stop(struct wpa_supplicant *wpa_s)
 }
 
 
-void wpas_dpp_remain_on_channel_cb(struct wpa_supplicant *wpa_s,
-                                  unsigned int freq)
-{
-       if (!wpa_s->dpp_listen_freq && !wpa_s->dpp_pending_listen_freq)
-               return;
-
-       wpa_printf(MSG_DEBUG,
-                  "DPP: remain-on-channel callback (off_channel_freq=%u dpp_pending_listen_freq=%d roc_waiting_drv_freq=%d freq=%u)",
-                  wpa_s->off_channel_freq, wpa_s->dpp_pending_listen_freq,
-                  wpa_s->roc_waiting_drv_freq, freq);
-       if (wpa_s->off_channel_freq &&
-           wpa_s->off_channel_freq == wpa_s->dpp_pending_listen_freq) {
-               wpa_printf(MSG_DEBUG, "DPP: Listen on %u MHz started", freq);
-               wpa_s->dpp_pending_listen_freq = 0;
-       } else {
-               wpa_printf(MSG_DEBUG,
-                          "DPP: Ignore remain-on-channel callback (off_channel_freq=%u dpp_pending_listen_freq=%d freq=%u)",
-                          wpa_s->off_channel_freq,
-                          wpa_s->dpp_pending_listen_freq, freq);
-       }
-}
-
-
 void wpas_dpp_cancel_remain_on_channel_cb(struct wpa_supplicant *wpa_s,
                                          unsigned int freq)
 {
@@ -1045,7 +721,10 @@ static void wpas_dpp_rx_auth_req(struct wpa_supplicant *wpa_s, const u8 *src,
 {
        const u8 *r_bootstrap, *i_bootstrap;
        u16 r_bootstrap_len, i_bootstrap_len;
-       struct dpp_bootstrap_info *bi, *own_bi = NULL, *peer_bi = NULL;
+       struct dpp_bootstrap_info *own_bi = NULL, *peer_bi = NULL;
+
+       if (!wpa_s->dpp)
+               return;
 
        wpa_printf(MSG_DEBUG, "DPP: Authentication Request from " MACSTR,
                   MAC2STR(src));
@@ -1072,28 +751,8 @@ static void wpas_dpp_rx_auth_req(struct wpa_supplicant *wpa_s, const u8 *src,
 
        /* Try to find own and peer bootstrapping key matches based on the
         * received hash values */
-       dl_list_for_each(bi, &wpa_s->dpp_bootstrap, struct dpp_bootstrap_info,
-                        list) {
-               if (!own_bi && bi->own &&
-                   os_memcmp(bi->pubkey_hash, r_bootstrap,
-                             SHA256_MAC_LEN) == 0) {
-                       wpa_printf(MSG_DEBUG,
-                                  "DPP: Found matching own bootstrapping information");
-                       own_bi = bi;
-               }
-
-               if (!peer_bi && !bi->own &&
-                   os_memcmp(bi->pubkey_hash, i_bootstrap,
-                             SHA256_MAC_LEN) == 0) {
-                       wpa_printf(MSG_DEBUG,
-                                  "DPP: Found matching peer bootstrapping information");
-                       peer_bi = bi;
-               }
-
-               if (own_bi && peer_bi)
-                       break;
-       }
-
+       dpp_bootstrap_find_pair(wpa_s->dpp, i_bootstrap, r_bootstrap,
+                               &own_bi, &peer_bi);
        if (!own_bi) {
                wpa_msg(wpa_s, MSG_INFO, DPP_EVENT_FAIL
                        "No matching own bootstrapping key found - ignore message");
@@ -1116,8 +775,12 @@ static void wpas_dpp_rx_auth_req(struct wpa_supplicant *wpa_s, const u8 *src,
                return;
        }
        wpas_dpp_set_testing_options(wpa_s, wpa_s->dpp_auth);
-       wpas_dpp_set_configurator(wpa_s, wpa_s->dpp_auth,
-                                 wpa_s->dpp_configurator_params);
+       if (dpp_set_configurator(wpa_s->dpp, wpa_s, wpa_s->dpp_auth,
+                                wpa_s->dpp_configurator_params) < 0) {
+               dpp_auth_deinit(wpa_s->dpp_auth);
+               wpa_s->dpp_auth = NULL;
+               return;
+       }
        os_memcpy(wpa_s->dpp_auth->peer_mac_addr, src, ETH_ALEN);
 
        if (wpa_s->dpp_listen_freq &&
@@ -1150,6 +813,27 @@ static struct wpa_ssid * wpas_dpp_add_network(struct wpa_supplicant *wpa_s,
 {
        struct wpa_ssid *ssid;
 
+#ifdef CONFIG_DPP2
+       if (auth->akm == DPP_AKM_SAE) {
+#ifdef CONFIG_SAE
+               struct wpa_driver_capa capa;
+               int res;
+
+               res = wpa_drv_get_capa(wpa_s, &capa);
+               if (res == 0 &&
+                   !(capa.key_mgmt & WPA_DRIVER_CAPA_KEY_MGMT_SAE) &&
+                   !(wpa_s->drv_flags & WPA_DRIVER_FLAGS_SAE)) {
+                       wpa_printf(MSG_DEBUG,
+                                  "DPP: SAE not supported by the driver");
+                       return NULL;
+               }
+#else /* CONFIG_SAE */
+               wpa_printf(MSG_DEBUG, "DPP: SAE not supported in the build");
+               return NULL;
+#endif /* CONFIG_SAE */
+       }
+#endif /* CONFIG_DPP2 */
+
        ssid = wpa_config_add_network(wpa_s->conf);
        if (!ssid)
                return NULL;
@@ -1192,12 +876,14 @@ static struct wpa_ssid * wpas_dpp_add_network(struct wpa_supplicant *wpa_s,
                ssid->dpp_netaccesskey_expiry = auth->net_access_key_expiry;
        }
 
-       if (!auth->connector) {
-               ssid->key_mgmt = 0;
-               if (auth->akm == DPP_AKM_PSK || auth->akm == DPP_AKM_PSK_SAE)
+       if (!auth->connector || dpp_akm_psk(auth->akm) ||
+           dpp_akm_sae(auth->akm)) {
+               if (!auth->connector)
+                       ssid->key_mgmt = 0;
+               if (dpp_akm_psk(auth->akm))
                        ssid->key_mgmt |= WPA_KEY_MGMT_PSK |
                                WPA_KEY_MGMT_PSK_SHA256 | WPA_KEY_MGMT_FT_PSK;
-               if (auth->akm == DPP_AKM_SAE || auth->akm == DPP_AKM_PSK_SAE)
+               if (dpp_akm_sae(auth->akm))
                        ssid->key_mgmt |= WPA_KEY_MGMT_SAE |
                                WPA_KEY_MGMT_FT_SAE;
                ssid->ieee80211w = MGMT_FRAME_PROTECTION_OPTIONAL;
@@ -1221,35 +907,47 @@ fail:
 }
 
 
-static void wpas_dpp_process_config(struct wpa_supplicant *wpa_s,
-                                   struct dpp_authentication *auth)
+static int wpas_dpp_process_config(struct wpa_supplicant *wpa_s,
+                                  struct dpp_authentication *auth)
 {
        struct wpa_ssid *ssid;
 
        if (wpa_s->conf->dpp_config_processing < 1)
-               return;
+               return 0;
 
        ssid = wpas_dpp_add_network(wpa_s, auth);
        if (!ssid)
-               return;
+               return -1;
 
        wpa_msg(wpa_s, MSG_INFO, DPP_EVENT_NETWORK_ID "%d", ssid->id);
+       if (wpa_s->conf->dpp_config_processing == 2)
+               ssid->disabled = 0;
+
+#ifndef CONFIG_NO_CONFIG_WRITE
+       if (wpa_s->conf->update_config &&
+           wpa_config_write(wpa_s->confname, wpa_s->conf))
+               wpa_printf(MSG_DEBUG, "DPP: Failed to update configuration");
+#endif /* CONFIG_NO_CONFIG_WRITE */
+
        if (wpa_s->conf->dpp_config_processing < 2)
-               return;
+               return 0;
 
-       wpa_printf(MSG_DEBUG, "DPP: Trying to connect to the new network");
-       ssid->disabled = 0;
-       wpa_s->disconnected = 0;
-       wpa_s->reassociate = 1;
-       wpa_s->scan_runs = 0;
-       wpa_s->normal_scans = 0;
-       wpa_supplicant_cancel_sched_scan(wpa_s);
-       wpa_supplicant_req_scan(wpa_s, 0, 0);
+#ifdef CONFIG_DPP2
+       if (auth->peer_version >= 2) {
+               wpa_printf(MSG_DEBUG,
+                          "DPP: Postpone connection attempt to wait for completion of DPP Configuration Result");
+               auth->connect_on_tx_status = 1;
+               return 0;
+       }
+#endif /* CONFIG_DPP2 */
+
+       wpas_dpp_try_to_connect(wpa_s);
+       return 0;
 }
 
 
-static void wpas_dpp_handle_config_obj(struct wpa_supplicant *wpa_s,
-                                      struct dpp_authentication *auth)
+static int wpas_dpp_handle_config_obj(struct wpa_supplicant *wpa_s,
+                                     struct dpp_authentication *auth)
 {
        wpa_msg(wpa_s, MSG_INFO, DPP_EVENT_CONF_RECEIVED);
        if (auth->ssid_len)
@@ -1301,7 +999,7 @@ static void wpas_dpp_handle_config_obj(struct wpa_supplicant *wpa_s,
                }
        }
 
-       wpas_dpp_process_config(wpa_s, auth);
+       return wpas_dpp_process_config(wpa_s, auth);
 }
 
 
@@ -1313,6 +1011,8 @@ static void wpas_dpp_gas_resp_cb(void *ctx, const u8 *addr, u8 dialog_token,
        struct wpa_supplicant *wpa_s = ctx;
        const u8 *pos;
        struct dpp_authentication *auth = wpa_s->dpp_auth;
+       int res;
+       enum dpp_status_error status = DPP_STATUS_CONFIG_REJECTED;
 
        wpa_s->dpp_gas_dialog_token = -1;
 
@@ -1320,7 +1020,8 @@ static void wpas_dpp_gas_resp_cb(void *ctx, const u8 *addr, u8 dialog_token,
                wpa_printf(MSG_DEBUG, "DPP: No matching exchange in progress");
                return;
        }
-       if (!resp || status_code != WLAN_STATUS_SUCCESS) {
+       if (result != GAS_QUERY_SUCCESS ||
+           !resp || status_code != WLAN_STATUS_SUCCESS) {
                wpa_printf(MSG_DEBUG, "DPP: GAS query did not succeed");
                goto fail;
        }
@@ -1349,13 +1050,46 @@ static void wpas_dpp_gas_resp_cb(void *ctx, const u8 *addr, u8 dialog_token,
                goto fail;
        }
 
-       wpas_dpp_handle_config_obj(wpa_s, auth);
-       dpp_auth_deinit(wpa_s->dpp_auth);
-       wpa_s->dpp_auth = NULL;
-       return;
+       res = wpas_dpp_handle_config_obj(wpa_s, auth);
+       if (res < 0)
+               goto fail;
 
+       status = DPP_STATUS_OK;
+#ifdef CONFIG_TESTING_OPTIONS
+       if (dpp_test == DPP_TEST_REJECT_CONFIG) {
+               wpa_printf(MSG_INFO, "DPP: TESTING - Reject Config Object");
+               status = DPP_STATUS_CONFIG_REJECTED;
+       }
+#endif /* CONFIG_TESTING_OPTIONS */
 fail:
-       wpa_msg(wpa_s, MSG_INFO, DPP_EVENT_CONF_FAILED);
+       if (status != DPP_STATUS_OK)
+               wpa_msg(wpa_s, MSG_INFO, DPP_EVENT_CONF_FAILED);
+#ifdef CONFIG_DPP2
+       if (auth->peer_version >= 2 &&
+           auth->conf_resp_status == DPP_STATUS_OK) {
+               struct wpabuf *msg;
+
+               wpa_printf(MSG_DEBUG, "DPP: Send DPP Configuration Result");
+               msg = dpp_build_conf_result(auth, status);
+               if (!msg)
+                       goto fail2;
+
+               wpa_msg(wpa_s, MSG_INFO,
+                       DPP_EVENT_TX "dst=" MACSTR " freq=%u type=%d",
+                       MAC2STR(addr), auth->curr_freq,
+                       DPP_PA_CONFIGURATION_RESULT);
+               offchannel_send_action(wpa_s, auth->curr_freq,
+                                      addr, wpa_s->own_addr, broadcast,
+                                      wpabuf_head(msg),
+                                      wpabuf_len(msg),
+                                      500, wpas_dpp_tx_status, 0);
+               wpabuf_free(msg);
+
+               /* This exchange will be terminated in the TX status handler */
+               return;
+       }
+fail2:
+#endif /* CONFIG_DPP2 */
        dpp_auth_deinit(wpa_s->dpp_auth);
        wpa_s->dpp_auth = NULL;
 }
@@ -1364,7 +1098,7 @@ fail:
 static void wpas_dpp_start_gas_client(struct wpa_supplicant *wpa_s)
 {
        struct dpp_authentication *auth = wpa_s->dpp_auth;
-       struct wpabuf *buf, *conf_req;
+       struct wpabuf *buf;
        char json[100];
        int res;
 
@@ -1385,39 +1119,18 @@ static void wpas_dpp_start_gas_client(struct wpa_supplicant *wpa_s)
        offchannel_send_action_done(wpa_s);
        wpas_dpp_listen_stop(wpa_s);
 
-       conf_req = dpp_build_conf_req(auth, json);
-       if (!conf_req) {
+       buf = dpp_build_conf_req(auth, json);
+       if (!buf) {
                wpa_printf(MSG_DEBUG,
                           "DPP: No configuration request data available");
                return;
        }
 
-       buf = gas_build_initial_req(0, 10 + 2 + wpabuf_len(conf_req));
-       if (!buf) {
-               wpabuf_free(conf_req);
-               return;
-       }
-
-       /* Advertisement Protocol IE */
-       wpabuf_put_u8(buf, WLAN_EID_ADV_PROTO);
-       wpabuf_put_u8(buf, 8); /* Length */
-       wpabuf_put_u8(buf, 0x7f);
-       wpabuf_put_u8(buf, WLAN_EID_VENDOR_SPECIFIC);
-       wpabuf_put_u8(buf, 5);
-       wpabuf_put_be24(buf, OUI_WFA);
-       wpabuf_put_u8(buf, DPP_OUI_TYPE);
-       wpabuf_put_u8(buf, 0x01);
-
-       /* GAS Query */
-       wpabuf_put_le16(buf, wpabuf_len(conf_req));
-       wpabuf_put_buf(buf, conf_req);
-       wpabuf_free(conf_req);
-
        wpa_printf(MSG_DEBUG, "DPP: GAS request to " MACSTR " (freq %u MHz)",
                   MAC2STR(auth->peer_mac_addr), auth->curr_freq);
 
        res = gas_query_req(wpa_s->gas, auth->peer_mac_addr, auth->curr_freq,
-                           buf, wpas_dpp_gas_resp_cb, wpa_s);
+                           1, buf, wpas_dpp_gas_resp_cb, wpa_s);
        if (res < 0) {
                wpa_msg(wpa_s, MSG_DEBUG, "GAS: Failed to send Query Request");
                wpabuf_free(buf);
@@ -1433,6 +1146,17 @@ static void wpas_dpp_auth_success(struct wpa_supplicant *wpa_s, int initiator)
 {
        wpa_printf(MSG_DEBUG, "DPP: Authentication succeeded");
        wpa_msg(wpa_s, MSG_INFO, DPP_EVENT_AUTH_SUCCESS "init=%d", initiator);
+#ifdef CONFIG_TESTING_OPTIONS
+       if (dpp_test == DPP_TEST_STOP_AT_AUTH_CONF) {
+               wpa_printf(MSG_INFO,
+                          "DPP: TESTING - stop at Authentication Confirm");
+               if (wpa_s->dpp_auth->configurator) {
+                       /* Prevent GAS response */
+                       wpa_s->dpp_auth->auth_success = 0;
+               }
+               return;
+       }
+#endif /* CONFIG_TESTING_OPTIONS */
 
        if (wpa_s->dpp_auth->configurator)
                wpas_dpp_start_gas_server(wpa_s);
@@ -1527,6 +1251,71 @@ static void wpas_dpp_rx_auth_conf(struct wpa_supplicant *wpa_s, const u8 *src,
 }
 
 
+#ifdef CONFIG_DPP2
+
+static void wpas_dpp_config_result_wait_timeout(void *eloop_ctx,
+                                               void *timeout_ctx)
+{
+       struct wpa_supplicant *wpa_s = eloop_ctx;
+       struct dpp_authentication *auth = wpa_s->dpp_auth;
+
+       if (!auth || !auth->waiting_conf_result)
+               return;
+
+       wpa_printf(MSG_DEBUG,
+                  "DPP: Timeout while waiting for Configuration Result");
+       wpa_msg(wpa_s, MSG_INFO, DPP_EVENT_CONF_FAILED);
+       dpp_auth_deinit(auth);
+       wpa_s->dpp_auth = NULL;
+}
+
+
+static void wpas_dpp_rx_conf_result(struct wpa_supplicant *wpa_s, const u8 *src,
+                                   const u8 *hdr, const u8 *buf, size_t len)
+{
+       struct dpp_authentication *auth = wpa_s->dpp_auth;
+       enum dpp_status_error status;
+
+       wpa_printf(MSG_DEBUG, "DPP: Configuration Result from " MACSTR,
+                  MAC2STR(src));
+
+       if (!auth || !auth->waiting_conf_result) {
+               wpa_printf(MSG_DEBUG,
+                          "DPP: No DPP Configuration waiting for result - drop");
+               return;
+       }
+
+       if (os_memcmp(src, auth->peer_mac_addr, ETH_ALEN) != 0) {
+               wpa_printf(MSG_DEBUG, "DPP: MAC address mismatch (expected "
+                          MACSTR ") - drop", MAC2STR(auth->peer_mac_addr));
+               return;
+       }
+
+       status = dpp_conf_result_rx(auth, hdr, buf, len);
+
+       offchannel_send_action_done(wpa_s);
+       wpas_dpp_listen_stop(wpa_s);
+       if (status == DPP_STATUS_OK)
+               wpa_msg(wpa_s, MSG_INFO, DPP_EVENT_CONF_SENT);
+       else
+               wpa_msg(wpa_s, MSG_INFO, DPP_EVENT_CONF_FAILED);
+       dpp_auth_deinit(auth);
+       wpa_s->dpp_auth = NULL;
+       eloop_cancel_timeout(wpas_dpp_config_result_wait_timeout, wpa_s, NULL);
+}
+
+
+static int wpas_dpp_process_conf_obj(void *ctx,
+                                    struct dpp_authentication *auth)
+{
+       struct wpa_supplicant *wpa_s = ctx;
+
+       return wpas_dpp_handle_config_obj(wpa_s, auth);
+}
+
+#endif /* CONFIG_DPP2 */
+
+
 static void wpas_dpp_rx_peer_disc_resp(struct wpa_supplicant *wpa_s,
                                       const u8 *src,
                                       const u8 *buf, size_t len)
@@ -1654,6 +1443,62 @@ fail:
 }
 
 
+static int wpas_dpp_allow_ir(struct wpa_supplicant *wpa_s, unsigned int freq)
+{
+       int i, j;
+
+       if (!wpa_s->hw.modes)
+               return -1;
+
+       for (i = 0; i < wpa_s->hw.num_modes; i++) {
+               struct hostapd_hw_modes *mode = &wpa_s->hw.modes[i];
+
+               for (j = 0; j < mode->num_channels; j++) {
+                       struct hostapd_channel_data *chan = &mode->channels[j];
+
+                       if (chan->freq != (int) freq)
+                               continue;
+
+                       if (chan->flag & (HOSTAPD_CHAN_DISABLED |
+                                         HOSTAPD_CHAN_NO_IR |
+                                         HOSTAPD_CHAN_RADAR))
+                               continue;
+
+                       return 1;
+               }
+       }
+
+       wpa_printf(MSG_DEBUG,
+                  "DPP: Frequency %u MHz not supported or does not allow PKEX initiation in the current channel list",
+                  freq);
+
+       return 0;
+}
+
+
+static int wpas_dpp_pkex_next_channel(struct wpa_supplicant *wpa_s,
+                                     struct dpp_pkex *pkex)
+{
+       if (pkex->freq == 2437)
+               pkex->freq = 5745;
+       else if (pkex->freq == 5745)
+               pkex->freq = 5220;
+       else if (pkex->freq == 5220)
+               pkex->freq = 60480;
+       else
+               return -1; /* no more channels to try */
+
+       if (wpas_dpp_allow_ir(wpa_s, pkex->freq) == 1) {
+               wpa_printf(MSG_DEBUG, "DPP: Try to initiate on %u MHz",
+                          pkex->freq);
+               return 0;
+       }
+
+       /* Could not use this channel - try the next one */
+       return wpas_dpp_pkex_next_channel(wpa_s, pkex);
+}
+
+
 static void wpas_dpp_pkex_retry_timeout(void *eloop_ctx, void *timeout_ctx)
 {
        struct wpa_supplicant *wpa_s = eloop_ctx;
@@ -1662,11 +1507,14 @@ static void wpas_dpp_pkex_retry_timeout(void *eloop_ctx, void *timeout_ctx)
        if (!pkex || !pkex->exchange_req)
                return;
        if (pkex->exch_req_tries >= 5) {
-               wpa_msg(wpa_s, MSG_INFO, DPP_EVENT_FAIL
-                       "No response from PKEX peer");
-               dpp_pkex_free(pkex);
-               wpa_s->dpp_pkex = NULL;
-               return;
+               if (wpas_dpp_pkex_next_channel(wpa_s, pkex) < 0) {
+                       wpa_msg(wpa_s, MSG_INFO, DPP_EVENT_FAIL
+                               "No response from PKEX peer");
+                       dpp_pkex_free(pkex);
+                       wpa_s->dpp_pkex = NULL;
+                       return;
+               }
+               pkex->exch_req_tries = 0;
        }
 
        pkex->exch_req_tries++;
@@ -1828,27 +1676,12 @@ static struct dpp_bootstrap_info *
 wpas_dpp_pkex_finish(struct wpa_supplicant *wpa_s, const u8 *peer,
                     unsigned int freq)
 {
-       struct dpp_pkex *pkex = wpa_s->dpp_pkex;
        struct dpp_bootstrap_info *bi;
 
-       bi = os_zalloc(sizeof(*bi));
+       bi = dpp_pkex_finish(wpa_s->dpp, wpa_s->dpp_pkex, peer, freq);
        if (!bi)
                return NULL;
-       bi->id = wpas_dpp_next_id(wpa_s);
-       bi->type = DPP_BOOTSTRAP_PKEX;
-       os_memcpy(bi->mac_addr, peer, ETH_ALEN);
-       bi->num_freq = 1;
-       bi->freq[0] = freq;
-       bi->curve = pkex->own_bi->curve;
-       bi->pubkey = pkex->peer_bootstrap_key;
-       pkex->peer_bootstrap_key = NULL;
-       dpp_pkex_free(pkex);
        wpa_s->dpp_pkex = NULL;
-       if (dpp_bootstrap_key_hash(bi) < 0) {
-               dpp_bootstrap_info_free(bi);
-               return NULL;
-       }
-       dl_list_add(&wpa_s->dpp_bootstrap, &bi->list);
        return bi;
 }
 
@@ -2011,6 +1844,11 @@ void wpas_dpp_rx_action(struct wpa_supplicant *wpa_s, const u8 *src,
                wpas_dpp_rx_pkex_commit_reveal_resp(wpa_s, src, hdr, buf, len,
                                                    freq);
                break;
+#ifdef CONFIG_DPP2
+       case DPP_PA_CONFIGURATION_RESULT:
+               wpas_dpp_rx_conf_result(wpa_s, src, hdr, buf, len);
+               break;
+#endif /* CONFIG_DPP2 */
        default:
                wpa_printf(MSG_DEBUG,
                           "DPP: Ignored unsupported frame subtype %d", type);
@@ -2045,6 +1883,18 @@ wpas_dpp_gas_req_handler(void *ctx, const u8 *sa, const u8 *query,
                wpa_printf(MSG_DEBUG, "DPP: No matching exchange in progress");
                return NULL;
        }
+
+       if (wpa_s->dpp_auth_ok_on_ack && auth->configurator) {
+               wpa_printf(MSG_DEBUG,
+                          "DPP: Have not received ACK for Auth Confirm yet - assume it was received based on this GAS request");
+               /* wpas_dpp_auth_success() would normally have been called from
+                * TX status handler, but since there was no such handler call
+                * yet, simply send out the event message and proceed with
+                * exchange. */
+               wpa_msg(wpa_s, MSG_INFO, DPP_EVENT_AUTH_SUCCESS "init=1");
+               wpa_s->dpp_auth_ok_on_ack = 0;
+       }
+
        wpa_hexdump(MSG_DEBUG,
                    "DPP: Received Configuration Request (GAS Query Request)",
                    query, query_len);
@@ -2080,6 +1930,21 @@ wpas_dpp_gas_status_handler(void *ctx, struct wpabuf *resp, int ok)
                   ok);
        eloop_cancel_timeout(wpas_dpp_reply_wait_timeout, wpa_s, NULL);
        eloop_cancel_timeout(wpas_dpp_auth_resp_retry_timeout, wpa_s, NULL);
+#ifdef CONFIG_DPP2
+       if (ok && auth->peer_version >= 2 &&
+           auth->conf_resp_status == DPP_STATUS_OK) {
+               wpa_printf(MSG_DEBUG, "DPP: Wait for Configuration Result");
+               auth->waiting_conf_result = 1;
+               auth->conf_resp = NULL;
+               wpabuf_free(resp);
+               eloop_cancel_timeout(wpas_dpp_config_result_wait_timeout,
+                                    wpa_s, NULL);
+               eloop_register_timeout(2, 0,
+                                      wpas_dpp_config_result_wait_timeout,
+                                      wpa_s, NULL);
+               return;
+       }
+#endif /* CONFIG_DPP2 */
        offchannel_send_action_done(wpa_s);
        wpas_dpp_listen_stop(wpa_s);
        if (ok)
@@ -2092,93 +1957,6 @@ wpas_dpp_gas_status_handler(void *ctx, struct wpabuf *resp, int ok)
 }
 
 
-static unsigned int wpas_dpp_next_configurator_id(struct wpa_supplicant *wpa_s)
-{
-       struct dpp_configurator *conf;
-       unsigned int max_id = 0;
-
-       dl_list_for_each(conf, &wpa_s->dpp_configurator,
-                        struct dpp_configurator, list) {
-               if (conf->id > max_id)
-                       max_id = conf->id;
-       }
-       return max_id + 1;
-}
-
-
-int wpas_dpp_configurator_add(struct wpa_supplicant *wpa_s, const char *cmd)
-{
-       char *curve = NULL;
-       char *key = NULL;
-       u8 *privkey = NULL;
-       size_t privkey_len = 0;
-       int ret = -1;
-       struct dpp_configurator *conf = NULL;
-
-       curve = get_param(cmd, " curve=");
-       key = get_param(cmd, " key=");
-
-       if (key) {
-               privkey_len = os_strlen(key) / 2;
-               privkey = os_malloc(privkey_len);
-               if (!privkey ||
-                   hexstr2bin(key, privkey, privkey_len) < 0)
-                       goto fail;
-       }
-
-       conf = dpp_keygen_configurator(curve, privkey, privkey_len);
-       if (!conf)
-               goto fail;
-
-       conf->id = wpas_dpp_next_configurator_id(wpa_s);
-       dl_list_add(&wpa_s->dpp_configurator, &conf->list);
-       ret = conf->id;
-       conf = NULL;
-fail:
-       os_free(curve);
-       str_clear_free(key);
-       bin_clear_free(privkey, privkey_len);
-       dpp_configurator_free(conf);
-       return ret;
-}
-
-
-static int dpp_configurator_del(struct wpa_supplicant *wpa_s, unsigned int id)
-{
-       struct dpp_configurator *conf, *tmp;
-       int found = 0;
-
-       dl_list_for_each_safe(conf, tmp, &wpa_s->dpp_configurator,
-                             struct dpp_configurator, list) {
-               if (id && conf->id != id)
-                       continue;
-               found = 1;
-               dl_list_del(&conf->list);
-               dpp_configurator_free(conf);
-       }
-
-       if (id == 0)
-               return 0; /* flush succeeds regardless of entries found */
-       return found ? 0 : -1;
-}
-
-
-int wpas_dpp_configurator_remove(struct wpa_supplicant *wpa_s, const char *id)
-{
-       unsigned int id_val;
-
-       if (os_strcmp(id, "*") == 0) {
-               id_val = 0;
-       } else {
-               id_val = atoi(id);
-               if (id_val == 0)
-                       return -1;
-       }
-
-       return dpp_configurator_del(wpa_s, id_val);
-}
-
-
 int wpas_dpp_configurator_sign(struct wpa_supplicant *wpa_s, const char *cmd)
 {
        struct dpp_authentication *auth;
@@ -2190,12 +1968,10 @@ int wpas_dpp_configurator_sign(struct wpa_supplicant *wpa_s, const char *cmd)
                return -1;
 
        curve = get_param(cmd, " curve=");
-       wpas_dpp_set_configurator(wpa_s, auth, cmd);
-
-       if (dpp_configurator_own_config(auth, curve, 0) == 0) {
-               wpas_dpp_handle_config_obj(wpa_s, auth);
-               ret = 0;
-       }
+       wpas_dpp_set_testing_options(wpa_s, auth);
+       if (dpp_set_configurator(wpa_s->dpp, wpa_s, auth, cmd) == 0 &&
+           dpp_configurator_own_config(auth, curve, 0) == 0)
+               ret = wpas_dpp_handle_config_obj(wpa_s, auth);
 
        dpp_auth_deinit(auth);
        os_free(curve);
@@ -2231,9 +2007,15 @@ int wpas_dpp_check_connect(struct wpa_supplicant *wpa_s, struct wpa_ssid *ssid,
        struct os_time now;
        struct wpabuf *msg;
        unsigned int wait_time;
+       const u8 *rsn;
+       struct wpa_ie_data ied;
 
        if (!(ssid->key_mgmt & WPA_KEY_MGMT_DPP) || !bss)
                return 0; /* Not using DPP AKM - continue */
+       rsn = wpa_bss_get_ie(bss, WLAN_EID_RSN);
+       if (rsn && wpa_parse_wpa_ie(rsn, 2 + rsn[1], &ied) == 0 &&
+           !(ied.key_mgmt & WPA_KEY_MGMT_DPP))
+               return 0; /* AP does not support DPP AKM - continue */
        if (wpa_sm_pmksa_exists(wpa_s->wpa, bss->bssid, ssid))
                return 0; /* PMKSA exists for DPP AKM - continue */
 
@@ -2346,7 +2128,7 @@ int wpas_dpp_pkex_add(struct wpa_supplicant *wpa_s, const char *cmd)
        if (!pos)
                return -1;
        pos += 5;
-       own_bi = dpp_bootstrap_get_id(wpa_s, atoi(pos));
+       own_bi = dpp_bootstrap_get_id(wpa_s->dpp, atoi(pos));
        if (!own_bi) {
                wpa_printf(MSG_DEBUG,
                           "DPP: Identified bootstrap info not found");
@@ -2400,7 +2182,6 @@ int wpas_dpp_pkex_add(struct wpa_supplicant *wpa_s, const char *cmd)
                wait_time = wpa_s->max_remain_on_chan;
                if (wait_time > 2000)
                        wait_time = 2000;
-               /* TODO: Support for 5 GHz channels */
                pkex->freq = 2437;
                wpa_msg(wpa_s, MSG_INFO, DPP_EVENT_TX "dst=" MACSTR
                        " freq=%u type=%d",
@@ -2468,6 +2249,7 @@ void wpas_dpp_stop(struct wpa_supplicant *wpa_s)
 
 int wpas_dpp_init(struct wpa_supplicant *wpa_s)
 {
+       struct dpp_global_config config;
        u8 adv_proto_id[7];
 
        adv_proto_id[0] = WLAN_EID_VENDOR_SPECIFIC;
@@ -2480,10 +2262,15 @@ int wpas_dpp_init(struct wpa_supplicant *wpa_s)
                                sizeof(adv_proto_id), wpas_dpp_gas_req_handler,
                                wpas_dpp_gas_status_handler, wpa_s) < 0)
                return -1;
-       dl_list_init(&wpa_s->dpp_bootstrap);
-       dl_list_init(&wpa_s->dpp_configurator);
-       wpa_s->dpp_init_done = 1;
-       return 0;
+
+       os_memset(&config, 0, sizeof(config));
+       config.msg_ctx = wpa_s;
+       config.cb_ctx = wpa_s;
+#ifdef CONFIG_DPP2
+       config.process_conf_obj = wpas_dpp_process_conf_obj;
+#endif /* CONFIG_DPP2 */
+       wpa_s->dpp = dpp_global_init(&config);
+       return wpa_s->dpp ? 0 : -1;
 }
 
 
@@ -2498,19 +2285,43 @@ void wpas_dpp_deinit(struct wpa_supplicant *wpa_s)
        wpa_s->dpp_groups_override = NULL;
        wpa_s->dpp_ignore_netaccesskey_mismatch = 0;
 #endif /* CONFIG_TESTING_OPTIONS */
-       if (!wpa_s->dpp_init_done)
+       if (!wpa_s->dpp)
                return;
+       dpp_global_clear(wpa_s->dpp);
        eloop_cancel_timeout(wpas_dpp_pkex_retry_timeout, wpa_s, NULL);
        eloop_cancel_timeout(wpas_dpp_reply_wait_timeout, wpa_s, NULL);
        eloop_cancel_timeout(wpas_dpp_init_timeout, wpa_s, NULL);
        eloop_cancel_timeout(wpas_dpp_auth_resp_retry_timeout, wpa_s, NULL);
+#ifdef CONFIG_DPP2
+       eloop_cancel_timeout(wpas_dpp_config_result_wait_timeout, wpa_s, NULL);
+       dpp_pfs_free(wpa_s->dpp_pfs);
+       wpa_s->dpp_pfs = NULL;
+#endif /* CONFIG_DPP2 */
        offchannel_send_action_done(wpa_s);
        wpas_dpp_listen_stop(wpa_s);
-       dpp_bootstrap_del(wpa_s, 0);
-       dpp_configurator_del(wpa_s, 0);
        wpas_dpp_stop(wpa_s);
        wpas_dpp_pkex_remove(wpa_s, "*");
        os_memset(wpa_s->dpp_intro_bssid, 0, ETH_ALEN);
        os_free(wpa_s->dpp_configurator_params);
        wpa_s->dpp_configurator_params = NULL;
 }
+
+
+#ifdef CONFIG_DPP2
+int wpas_dpp_controller_start(struct wpa_supplicant *wpa_s, const char *cmd)
+{
+       struct dpp_controller_config config;
+       const char *pos;
+
+       os_memset(&config, 0, sizeof(config));
+       if (cmd) {
+               pos = os_strstr(cmd, " tcp_port=");
+               if (pos) {
+                       pos += 10;
+                       config.tcp_port = atoi(pos);
+               }
+       }
+       config.configurator_params = wpa_s->dpp_configurator_params;
+       return dpp_controller_start(wpa_s->dpp, &config);
+}
+#endif /* CONFIG_DPP2 */