]> git.ipfire.org Git - thirdparty/glibc.git/commit - ChangeLog
Use PRINTF_FORTIFY instead of _IO_FLAGS2_FORTIFY (bug 11319)
authorZack Weinberg <zackw@panix.com>
Wed, 7 Mar 2018 19:32:03 +0000 (14:32 -0500)
committerGabriel F. T. Gomes <gabriel@inconstante.eti.br>
Wed, 5 Dec 2018 20:15:43 +0000 (18:15 -0200)
commit4e2f43f842ef5e253cc23383645adbaa03cedb86
treeca359423ba6ed4bb4d5ec247905a6ee13d456864
parent124fc732c15ef37b7ee9db25b1e9f9b20c799623
Use PRINTF_FORTIFY instead of _IO_FLAGS2_FORTIFY (bug 11319)

The _chk variants of all of the printf functions become much simpler.
This is the last thing that we needed _IO_acquire_lock_clear_flags2
for, so it can go as well.  I took the opportunity to make the headers
included and the names of all local variables consistent across all the
affected files.

Since we ultimately want to get rid of __no_long_double as well, it
must be possible to get all of the nontrivial effects of the _chk
functions by calling the _internal functions with appropriate flags.
For most of the __(v)xprintf_chk functions, this is covered by
PRINTF_FORTIFY plus some up-front argument checks that can be
duplicated.  However, __(v)sprintf_chk installs a custom jump table so
that it can crash instead of overflowing the output buffer.  This
functionality is moved to __vsprintf_internal, which now has a
'maxlen' argument like __vsnprintf_internal; to get the unsafe
behavior of ordinary (v)sprintf, pass -1 for that argument.

obstack_printf_chk and obstack_vprintf_chk are no longer in the same
file.

As a side-effect of the unification of both fortified and non-fortified
vdprintf initialization, this patch fixes bug 11319 for __dprintf_chk
and __vdprintf_chk, which was previously fixed only for dprintf and
vdprintf by the commit

commit 7ca890b88e6ab7624afb1742a9fffb37ad5b3fc3
Author: Ulrich Drepper <drepper@redhat.com>
Date:   Wed Feb 24 16:07:57 2010 -0800

    Fix reporting of I/O errors in *dprintf functions.

This patch adds a test case to avoid regressions.

Tested for powerpc and powerpc64le.
35 files changed:
ChangeLog
debug/Makefile
debug/asprintf_chk.c
debug/dprintf_chk.c
debug/fprintf_chk.c
debug/fwprintf_chk.c
debug/obprintf_chk.c
debug/printf_chk.c
debug/snprintf_chk.c
debug/sprintf_chk.c
debug/swprintf_chk.c
debug/vasprintf_chk.c
debug/vdprintf_chk.c
debug/vfprintf_chk.c
debug/vfwprintf_chk.c
debug/vobprintf_chk.c [new file with mode: 0644]
debug/vprintf_chk.c
debug/vsnprintf_chk.c
debug/vsprintf_chk.c
debug/vswprintf_chk.c
debug/vwprintf_chk.c
debug/wprintf_chk.c
include/stdio.h
include/wchar.h
libio/iovsprintf.c
libio/libio.h
libio/libioP.h
stdio-common/Makefile
stdio-common/sprintf.c
stdio-common/tst-bz11319-fortify2.c [new file with mode: 0644]
stdio-common/tst-bz11319.c [new file with mode: 0644]
stdio-common/vfprintf-internal.c
sysdeps/generic/stdio-lock.h
sysdeps/ieee754/ldbl-opt/nldbl-compat.c
sysdeps/nptl/stdio-lock.h