]> git.ipfire.org Git - thirdparty/glibc.git/commit - ChangeLog
Avoid overlapping addresses to stpcpy calls in nscd (BZ #16760)
authorSiddhesh Poyarekar <siddhesh@redhat.com>
Thu, 27 Mar 2014 14:18:15 +0000 (19:48 +0530)
committerSiddhesh Poyarekar <siddhesh@redhat.com>
Thu, 27 Mar 2014 14:18:15 +0000 (19:48 +0530)
commitea7d8b95e2fcb81f68b04ed7787a3dbda023991a
tree20e3018b10da00729cd8a8feec1e2265b173c321
parentdf5b85da90915ce6208ad737807e3d8f2a8fce87
Avoid overlapping addresses to stpcpy calls in nscd (BZ #16760)

Calls to stpcpy from nscd netgroups code will have overlapping source
and destination when all three values in the returned triplet are
non-NULL and in the expected (host,user,domain) order.  This is seen
in valgrind as:

==3181== Source and destination overlap in stpcpy(0x19973b48, 0x19973b48)
==3181==    at 0x4C2F30A: stpcpy (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==3181==    by 0x12567A: addgetnetgrentX (string3.h:111)
==3181==    by 0x12722D: addgetnetgrent (netgroupcache.c:665)
==3181==    by 0x11114C: nscd_run_worker (connections.c:1338)
==3181==    by 0x4E3C102: start_thread (pthread_create.c:309)
==3181==    by 0x59B81AC: clone (clone.S:111)
==3181==

Fix this by using memmove instead of stpcpy.
ChangeLog
NEWS
nscd/netgroupcache.c