]> git.ipfire.org Git - thirdparty/git.git/commit - Documentation/technical/protocol-v2.txt
protocol-v2.txt: align delim-pkt spec with usage
authorCalvin Wan <calvinwan@google.com>
Thu, 11 Nov 2021 22:00:48 +0000 (22:00 +0000)
committerJunio C Hamano <gitster@pobox.com>
Thu, 11 Nov 2021 22:53:18 +0000 (14:53 -0800)
commit74db416c9c3bf829b0d0641e74c252bf53da0158
treee97083e08cfb015cdb8c3ccf478f85b751f0b404
parent5fbd2fc5997dfa4d4593a862fe729b1e7a89bcf8
protocol-v2.txt: align delim-pkt spec with usage

The current protocol EBNF allows command-request to end with the
capability list, if no command specific arguments follow, but the
protocol requires that after the capability list, there must be a
delim-pkt regardless of the number of command specific arguments.  Fixed
the EBNF to match. Both JGit and libgit2's implementation has the
delim-pkt as mandatory. JGit's code is not publicly linkable, but
libgit2 is linked below[1]. As for currently implemented commands on v2
(ls-ref and fetch), the delim packet is already being passed through

[1]: https://github.com/libgit2/libgit2/blob/main/src/transports/git.c

Reported-by: Ivan Frade <ifrade@google.com>
Signed-off-by: Calvin Wan <calvinwan@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Documentation/technical/protocol-v2.txt