]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit - block/blk-merge.c
block: fix the DISCARD request merge
authorJianchao Wang <jianchao.w.wang@oracle.com>
Sat, 27 Oct 2018 11:52:14 +0000 (19:52 +0800)
committerJens Axboe <axboe@kernel.dk>
Mon, 29 Oct 2018 15:32:40 +0000 (09:32 -0600)
commit69840466086d2248898020a08dda52732686c4e6
tree4fd830c19b4c91854952e9ca56ba29cbdd99e376
parenta435ab4f80f983c53b4ca4f8c12b3ddd3ca17670
block: fix the DISCARD request merge

There are two cases when handle DISCARD merge.
If max_discard_segments == 1, the bios/requests need to be contiguous
to merge. If max_discard_segments > 1, it takes every bio as a range
and different range needn't to be contiguous.

But now, attempt_merge screws this up. It always consider contiguity
for DISCARD for the case max_discard_segments > 1 and cannot merge
contiguous DISCARD for the case max_discard_segments == 1, because
rq_attempt_discard_merge always returns false in this case.
This patch fixes both of the two cases above.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jianchao Wang <jianchao.w.wang@oracle.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-merge.c