]> git.ipfire.org Git - thirdparty/linux.git/commit - block/blk-wbt.c
blk-wbt: account flush requests correctly
authorJens Axboe <axboe@kernel.dk>
Mon, 5 Feb 2018 20:16:56 +0000 (13:16 -0700)
committerJens Axboe <axboe@kernel.dk>
Tue, 6 Feb 2018 21:14:03 +0000 (14:14 -0700)
commit5235553d821433e1f4fa720fd025d2c4b7ee9994
treeffb33398840277a538332805a98b0d8c376152c1
parent68c5735eaa5e680e701c9a2d1e3c7880bdf5ab66
blk-wbt: account flush requests correctly

Mikulas reported a workload that saw bad performance, and figured
out what it was due to various other types of requests being
accounted as reads. Flush requests, for instance. Due to the
high latency of those, we heavily throttle the writes to keep
the latencies in balance. But they really should be accounted
as writes.

Fix this by checking the exact type of the request. If it's a
read, account as a read, if it's a write or a flush, account
as a write. Any other request we disregard. Previously everything
would have been mistakenly accounted as reads.

Reported-by: Mikulas Patocka <mpatocka@redhat.com>
Cc: stable@vger.kernel.org # v4.12+
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-wbt.c