]> git.ipfire.org Git - thirdparty/git.git/commit - builtin/checkout.c
checkout: fix leak of non-existent branch names
authorJeff King <peff@peff.net>
Fri, 14 Aug 2020 16:14:53 +0000 (12:14 -0400)
committerJunio C Hamano <gitster@pobox.com>
Fri, 14 Aug 2020 17:52:04 +0000 (10:52 -0700)
commitc514c62a4fd8b4c4a3e2cad68fb590fce2940dc3
tree4a91ef7bee58c8096e672f5b0281c218d53901b0
parent9101c8ea2db466cce6d7d419d48e0516c6118813
checkout: fix leak of non-existent branch names

We unconditionally write a branch name into a newly allocated buffer in
new_branch_info->path, via setup_branch_path(). We then check to see if
the branch exists; if not, we set that field to NULL, leaking the
memory. We should take care to free() it when doing so.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/checkout.c