]> git.ipfire.org Git - thirdparty/git.git/commit - compat/mingw.c
mingw: simplify PATH handling
authorRené Scharfe <l.s.r@web.de>
Sat, 20 May 2017 19:35:37 +0000 (21:35 +0200)
committerJunio C Hamano <gitster@pobox.com>
Tue, 23 May 2017 12:44:38 +0000 (21:44 +0900)
commite0ca1ca20a0bde51c4eb9242dd9521ac1ed08304
tree61829780d3ba705b1720148837328c385250fac9
parent10c78a162fa821ee85203165b805ff46be454091
mingw: simplify PATH handling

On Windows the environment variable PATH contains a semicolon-separated
list of directories to search for, in order, when looking for the
location of a binary to run.  get_path_split() parses it and returns an
array of string copies, which is iterated by path_lookup(), which in
turn passes each entry to lookup_prog().

Change lookup_prog() to take the directory name as a length-limited
string instead of as a NUL-terminated one and parse PATH directly in
path_lookup().  This avoids memory allocations, simplifying the code.

Helped-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Rene Scharfe <l.s.r@web.de>
Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
compat/mingw.c