]> git.ipfire.org Git - thirdparty/gcc.git/commit - contrib/git-undescr.sh
contrib: Fix up git-descr.sh regression [PR102664]
authorJakub Jelinek <jakub@redhat.com>
Thu, 10 Mar 2022 08:42:03 +0000 (09:42 +0100)
committerJakub Jelinek <jakub@redhat.com>
Thu, 10 Mar 2022 08:42:03 +0000 (09:42 +0100)
commitff060ef08cfc3e48e70071cb63449b62a86f9d6f
tree019aed035cc28b4dce075d6fc2a3278e236d4377
parentbae10419f6e07dbde8e66ff4ff70d050f82ad451
contrib: Fix up git-descr.sh regression [PR102664]

On Wed, Mar 09, 2022 at 12:40:24PM -0500, Patrick Palka via Gcc-patches wrote:
> On Wed, Mar 9, 2022 at 8:54 AM Mikael Morin <morin-mikael@orange.fr> wrote:
> > Le 08/03/2022 à 18:58, Jonathan Wakely via Gcc-patches a écrit :
> > > Replace \([0-9]\+\) with \([0-9][0-9]*\) or with \([1-9][0-9]*\) in release branch numbers, where
> > > a leading zero does not occur.
> > >
> > Note that you also changed some gcc-[0-9]* to gcc-[1-9]*, which is a
> > typo/thinko I guess?  It looks like it wouldn’t match gcc-10 any more
> > for example…
>
> Perhaps related to this, I noticed the following
>   git gcc-descr ea1ce0d163ea1d63b6837144ae4be51d92630007
> now fails with
>   fatal: No tags can describe 'ea1ce0d163ea1d63b6837144ae4be51d92630007'.
> instead of outputting
>   r0-52309-gea1ce0d163ea1d

That is because of those [0-9] to [1-9] changes which prevent
basepoints/gcc-0 from working.  While basepoints/gcc-005 etc. are certainly
unexpected, basepoints/gcc-0 needs to work.

2022-03-10  Jakub Jelinek  <jakub@redhat.com>

PR other/102664
* git-descr.sh: Replace all [1-9] occurrences with [0-9].
* git-undescr.sh: Likewise.
contrib/git-descr.sh
contrib/git-undescr.sh