]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit - drivers/gpu/drm/i915/i915_reg.h
drm/i915: Whitelist SLICE_COMMON_ECO_CHICKEN1 on Geminilake.
authorKenneth Graunke <kenneth@whitecape.org>
Fri, 5 Jan 2018 08:59:05 +0000 (00:59 -0800)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Fri, 5 Jan 2018 17:42:33 +0000 (09:42 -0800)
commitab062639edb0412daf6de540725276b9a5d217f9
tree720dd3d55ae8f38857eb764d7d316723c3451cdc
parentfe9a9da61c3ec33c7d3ad305c2c535edbcae1ddb
drm/i915: Whitelist SLICE_COMMON_ECO_CHICKEN1 on Geminilake.

Geminilake requires the 3D driver to select whether barriers are
intended for compute shaders, or tessellation control shaders, by
whacking a "Barrier Mode" bit in SLICE_COMMON_ECO_CHICKEN1 when
switching pipelines.  Failure to do this properly can result in GPU
hangs.

Unfortunately, this means it needs to switch mid-batch, so only
userspace can properly set it.  To facilitate this, the kernel needs
to whitelist the register.

The workarounds page currently tags this as applying to Broxton only,
but that doesn't make sense.  The documentation for the register it
references says the bit userspace is supposed to toggle only exists on
Geminilake.  Empirically, the Mesa patch to toggle this bit appears to
fix intermittent GPU hangs in tessellation control shader barrier tests
on Geminilake; we haven't seen those hangs on Broxton.

v2: Mention WA #0862 in the comment (it doesn't have a name).

Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: stable@vger.kernel.org
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180105085905.9298-1-kenneth@whitecape.org
drivers/gpu/drm/i915/i915_reg.h
drivers/gpu/drm/i915/intel_engine_cs.c