]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit - drivers/md/bcache/btree.c
projects / thirdparty / kernel / stable.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 6b708de) | patch
bcache: fix use-after-free in btree_gc_coalesce()
authorSlava Pestov <sp@daterainc.com>
Sun, 13 Jul 2014 04:53:11 +0000 (21:53 -0700)
committerKent Overstreet <kmo@daterainc.com>
Mon, 4 Aug 2014 22:23:04 +0000 (15:23 -0700)
commit400ffaa2acd72274e2c7293a9724382383bebf3e
treed9f374a9be6fe1ce88ec1513282dba0980baf49ctree | snapshot
parent6b708de64adb6dc8319e7aeac922b46904fbeeeccommit | diff
bcache: fix use-after-free in btree_gc_coalesce()

If we goto out_nocoalesce after we free new_nodes[0], we end up freeing
new_nodes[0] again. This was generating a lockdep warning. The fix is
to set new_nodes[0] to NULL, since the out_nocoalesce path safely
ignores NULL entries in the new_nodes array.

This regression was introduced in 2d7f9531.

Change-Id: I76564d7257800583214376b4bacf236cda90c89c
drivers/md/bcache/btree.c diff | blob | blame | history
Mirror https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git