]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit - fs/exec.c
vfs: require i_size <= SIZE_MAX in kernel_read_file()
authorEric Biggers <ebiggers@google.com>
Fri, 7 Sep 2018 19:16:24 +0000 (12:16 -0700)
committerMimi Zohar <zohar@linux.ibm.com>
Wed, 10 Oct 2018 16:56:14 +0000 (12:56 -0400)
commit691115c3513ec83edf68ba6575ae85630bc94b8b
tree8e77e6e14650f10a67a314380362f9430254e151
parente6123c524064a571616ec978b1317f1696eff0ae
vfs: require i_size <= SIZE_MAX in kernel_read_file()

On 32-bit systems, the buffer allocated by kernel_read_file() is too
small if the file size is > SIZE_MAX, due to truncation to size_t.

Fortunately, since the 'count' argument to kernel_read() is also
truncated to size_t, only the allocated space is filled; then, -EIO is
returned since 'pos != i_size' after the read loop.

But this is not obvious and seems incidental.  We should be more
explicit about this case.  So, fail early if i_size > SIZE_MAX.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
fs/exec.c